[Koha-bugs] [Bug 33164] Return claim message shows intermittently when BlockReturnOfLostItems enabled

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33164

Phil Ringnalda <phil at chetcolibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |phil at chetcolibrary.org

--- Comment #2 from Phil Ringnalda <phil at chetcolibrary.org> ---
Wouldn't the correct fix be to instead move the processing of a ReturnClaims
message up out of the errmsgloop section, up around Wrongbranch? Otherwise,
someone else is going to show up with a workflow that involves withdrawing
claimed returns and wanting to resolve them at checkin.

If we believed in comments, the comment for the "# Error messages" loop would
be something like "Process messages that only need to be stuffed into
@errmsgloop, and which don't mind being randomly kept or ignored if something
sets $exit_required_p". Since ReturnClaims doesn't match either of those, it's
just in the wrong place (other than having to still have an empty elsif, to
stay out of the "unknown error code" path).

-- 
You are receiving this mail because:
You are watching all bug changes.