[Koha-bugs] [Bug 32594] Add a dedicated ES indexing background worker

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594

--- Comment #43 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #41)
> (In reply to Nick Clemens from comment #39)
> > Created attachment 148350 [details] [review] [review]
> > Bug 32594: POC
> 
> I don't think we should loop over the jobs, we are adding additional (almost
> useless) processing. Here we need to do things fast, so let's update them
> all at once. To prevent other scripts/jobs to use this, we should not
> provide a method (that does not feel correct).

I was trying to set the number processed to the numebr in the job, I forgot we
made all a size of 1

I squashed and mark yours SO

> 
> Now we need to decide if we allow indexing jobs from another worker. The
> detail page of the job is still wrong " / records have successfully been
> reindexed. Some errors occurred.". 

Bug 33319 filed to improve 

As for processing:
> IMO we should not provide 2 ways to process the jobs, only the new worker should do it. So let's remove the process method and simplify the job detail view.
> Sounds like we should move that to a separate bug...

I think that's a third job - we could have some plugins or some outside system
wanting to handle indexation for some reason? But I am okay to remove too

-- 
You are receiving this mail because:
You are watching all bug changes.