[Koha-bugs] [Bug 33342] Assigment in if clause sets invalid marc framework

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33342

Andreas Jonsson <andreas.jonsson at kreablo.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andreas.jonsson at kreablo.se

--- Comment #2 from Andreas Jonsson <andreas.jonsson at kreablo.se> ---

Obviously, the intention must be comparison; not assignment.

But I don't see how this can introduce an invalid framework code.

When I test the parameter "overlay_framework" is simply ignored.  The
expression $overlay_framework = '_USE_ORIG' should evaluate to TRUE, so the
body of the if-statement, $overlay_framework = undef, should always be
executed.

Also, in manage-marc-import.tt the option name seems to have an underscore at
the end as well:

<option value="_USE_ORIG_">Keep original framework</option>

So, only replacing assignment with comparison operator actually introduces the
incorrect framework codes.  We also need to fix the code value.

-- 
You are receiving this mail because:
You are watching all bug changes.