[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 148813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148813&action=edit
Bug 33302: Send and display errors when a hold cannot be placed on the OPAC

This patch changes opac-reserve.pl to return the error(s) when placing
a hold as a pipe delimited list which is then translated to a message for the
user

To test:
1 - Find a record with items available on the opac
2 - Click 'place hold' and set things up, but do not confirm
3 - In staff client, do something to make hold invalid:
    - Make item damaged
    - Make library not a pickup location
    - Place other holds for patron up to limit
    - etc.
4 - Confirm hold on OPAC
5 - You are sent to patron's account, hold is not placed
6 - There is little or no message to explain why
7 - Apply patch
8 - Repeat
9 - Now errors are clear

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.