[Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Please check javascript for various types of cover images:
    [% Asset.js("js/amazonimages.js") | $raw %]
    [% Asset.js("js/bakertaylorimages.js") | $raw %]
    [% Asset.js("js/coce.js") | $raw %]
    [% Asset.js("js/google-jackets.js") | $raw %]
    [% Asset.js("js/localcovers.js") | $raw %]
Hope I found them all ;)

For example, look at this in coce.js
img.onload = function() {
// image dimensions can't be known until image has loaded
if (img.height == 1 && img.width == 1) {
$(this).closest(".coce-coverimg").remove();
}
};

Or look here for localcovers:
            var img = $("<img />").attr('src',
                '/cgi-bin/koha/opac-image.pl?thumbnail=1&biblionumber=' +
$(mydiv).attr("class"))
                .load(function () {
If you would add into this callback function after load completion, remove the
spinner.

ETC,

Perhaps we can find a way to do this in one place for all types of covers?
Sorry to make this seemingly simple change a bit more complicated ;)

-- 
You are receiving this mail because:
You are watching all bug changes.