[Koha-bugs] [Bug 17649] Create only one message per borrower and overdue level

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32740

--- Comment #28 from Magnus Enger <magnus at libriotech.no> ---
Looked a bit more into this...

(In reply to Christopher Brannon from comment #27)
> (In reply to Caroline Cyr La Rose from comment #26)
> > Isn't there a pref for that (OverdueNoticeFrom)? Or am I misunderstanding
> > the discussion.
> 
> Not that I can see.  At least not in 22.05.  But we are dealing specifically
> with grouped items, not who emails should be from in general.

There should be OverdueNoticeFrom, yes:
https://koha-community.org/manual/22.11/en/html/circulationpreferences.html#overduenoticefrom

"This system preference overrides the –frombranch parameter in the
overdue_notices.pl cronjob.

When set to “command-line option”, the library information will be that of the
–frombranch parameter in the overdue_notices.pl cronjob or the checkout library
if the parameter is absent.

When set to “item home library”, the library information will be that of the
overdue item’s home library.

When set to “checkout library”, the library information will be that of the
library at which the overdue item was checked out."

There is also: Bug 32740 - Add a new option patron home library to
OverdueNoticeFrom [Needs Signoff right now]

I guess the problem is that with --all_in_one there can be more than one "item
home library" and more than one "checkout library". To me it looks like it
would make sense to either: 

- Set an explicit sender library for all messages, this should be possible with
OverdueNoticeFrom = "command-line option" and "the --frombranch parameter in
the overdue_notices.pl cronjob."
- Set the patron home library as the sender (bug 32740)

So when run with --all_in_one, that should only be an on/off switch for making
sure all items are in one message, and the script should choose either the
library in --frombranch or the patron home branch as the sender. 

Some combinations will not make sense, like having OverdueNoticeFrom = "item
home library" and running with --all_in_one. 

Does that make sense? Setting to Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.