From bugzilla-daemon at bugs.koha-community.org Mon May 1 00:21:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 22:21:50 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148544|0 |1 is obsolete| | --- Comment #237 from Aleisha Amohia --- Created attachment 150437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150437&action=edit Bug 8376: (QA follow-up) Update message on Hold waiting pickup report Signed-off-by: Nick Clemens https://bugs.koha-community.org/show_bug.cgi?id=8367 Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 00:21:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 22:21:57 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148545|0 |1 is obsolete| | --- Comment #238 from Aleisha Amohia --- Created attachment 150438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150438&action=edit Bug 8367: (QA follow-up) Improve display when value not set for rule When a rule is not set for a speficic line, the value in the syspref will be used. This should be made clear in the interface. To test: 1 - Add a new rule for a specific item type 2 - Do not fill the 'Hold pickup period' 3 - Confirm that the rule defaults to the system preference 4 - Hover on 'Default' in the circ rules under 'Hold pickup period' 5 - Confirm the text is readable Signed-off-by: Nick Clemens Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 00:22:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 22:22:03 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #239 from Aleisha Amohia --- Created attachment 150439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150439&action=edit Bug 8367: Add holds_pickup_period fallback circulation rule -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 00:23:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 22:23:27 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #240 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #236) > (In reply to Nick Clemens from comment #235) > > (In reply to Aleisha Amohia from comment #234) > > > There are lots of signoffs on these patches, can this be marked Passed QA? > > > > Hi Aleisha, > > > > It appears I was wrong in comment 187, see comment 222 > > > > It is a question of how the fallback should work, so we either need a DB > > update, or to change the expectation for when a rule is not set > > It sounds like this needs a little bit more work? Attached an atomic update patch, not sure how it affects the bug status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 00:33:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 22:33:04 +0000 Subject: [Koha-bugs] [Bug 33348] Show authority heading use with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 00:33:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 22:33:07 +0000 Subject: [Koha-bugs] [Bug 33348] Show authority heading use with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148791|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia --- Created attachment 150440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150440&action=edit Bug 33348: Show authority heading use with Elasticsearch This patch ensures the ShowHeadingUse system preference and feature works as expected when using Elasticsearch as the searchengine. To test, follow the test plan at Bug 29990 Comment 9. Ensure the SearchEngine system preference is set to Elasticsearch. Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 01:34:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 23:34:49 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #13 from David Cook --- (In reply to Katrin Fischer from comment #12) > You are right that different subdomains will create separate sessions, but I > think the 99% is wrong. Koha used ports for a long time in its default setup > and there are still reasons why you would want to do so. We do, with > packages, use ports, for the installations we support. > > And it doesn't solve the problem here... different sessions, one timeout. > How could you attach a different timeout to each? For your case, I think you'd need different cookie names for OPAC and Staff. Mostly would involve refactoring... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 02:21:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 00:21:55 +0000 Subject: [Koha-bugs] [Bug 23781] Recalls notices and messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150430|0 |1 is obsolete| | --- Comment #22 from David Nind --- Created attachment 150441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150441&action=edit Bug 23781: SMS notices and messaging preferences for recalls This patch adds recalls notices (pick up a waiting recall or return a requested recall) to the messaging preferences. To test: 1) Apply Bug 19532 2) Apply this bug 3) Update database, rebuild dbix files 4) Ensure UseRecalls syspref is enabled and values have been set in the circulation rules for recalls 5) Go to a borrower (Person A) account page in the Intranet or the OPAC 6) Go to messaging preferences 7) Notice there are now preferences for two recalls notices 8) Select email as a preference 9) Find a different borrower (Person B) and set their messaging preferences to SMS 10) Check out any item to Person B 11) Go to the OPAC logged in as Person A and find that item 12) Recall the item 13) In the terminal, look at the message_queue in the database. There should be a 'RETURN_RECALLED_ITEM' recall notice sent to Person B via SMS 14) Go back to the Intranet and check in the item. Confirm the recall when checking in 15) Look at the message_queue in the database again. There should be a 'PICKUP_RECALLED_ITEM' recall notice sent to Person A via email. 16) Confirm tests pass t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Lucas Gass Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 05:00:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 03:00:48 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 05:00:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 03:00:52 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146988|0 |1 is obsolete| | Attachment #146992|0 |1 is obsolete| | --- Comment #28 from Aleisha Amohia --- Created attachment 150442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150442&action=edit Bug 6796: Add branch_hours table and set opening hours for library -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 05:00:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 03:00:55 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146989|0 |1 is obsolete| | --- Comment #29 from Aleisha Amohia --- Created attachment 150443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150443&action=edit Bug 6796: ConsiderLibraryHoursWhenIssuing system preference -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 05:00:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 03:00:59 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146990|0 |1 is obsolete| | --- Comment #30 from Aleisha Amohia --- Created attachment 150444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150444&action=edit Bug 6796: Consider library hours when calculating due date + tests This feature adds the ability to set opening and closing hours for your library and for these hours to be considered when calculating due dates for hourly loans. If the due date for an hourly loan falls after the library closes, the library can choose for the due date to be shortened to meet the close time, or extended to meet the open time the next day. This feature adds a new table 'branch_hours' for storing the open and close times per day for each library, and a new system preference 'ConsiderLibraryHoursWhenIssuing' to choose which behaviour should be followed when calculating due dates. To test: 1. Apply patches and update database. Upgrade schema if not applying patch with schema changes. Restart services. 2. Go to Administration -> Libraries. Edit a library and scroll to the bottom to find the 'opening hours' section. Test adding and removing open and close times on various days. Confirm saving works as expected. 3. Add a new library and test adding open and close times works as expected. 4. Edit your default library and save open and close times for each day. 5. Go to Administration -> Circulation and fine rules. Edit a rule, set the unit to 'hours' and set the loan period to a number that would cause a checkout to be due after the close time you just set, i.e. if you set your close time to be 5pm and your system time is currently 1pm, set the loan period to be 5 (5 hours) so the calculated due date would be 6pm. 6. Go to Administration -> system preferences. Search for ConsiderLibraryHoursWhenIssuing. It should be under 'Checkout policy' in the Circulation system preferences. Confirm the pre-selected option is 'ignore'. Keep this tab open. 6. In a new tab, get the barcode for an item that has an itemtype matching the circulation rule you just set. 7. Go to the checkouts for a patron that has a categorycode matching the circulation rule you just set. 8. Check out your item. Confirm that the checkout is due at the end of the loan period, not taking closing hours into consideration. Return the item. 9. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to 'close', so the due date should be shortened to meet the close time. 10. Check out your item. Confirm the checkout is due when the library closes. Return the item. 11. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to 'open', so the due date should be extended to meet the opening time. 12. Check out your item. Confirm the checkout is due the next day when the library opens. 13. Confirm tests pass t/db_dependent/Circulation/CalcDateDue.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 05:01:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 03:01:02 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146991|0 |1 is obsolete| | --- Comment #31 from Aleisha Amohia --- Created attachment 150445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150445&action=edit Bug 6796: (follow-up) Fix logic for calculating following day's open hours Since days for branch hours are stored as 0-6 in the database, when it's a Saturday (6) incrementing the date leads to an error when issuing an hourly loan because no opening hours are found for the non-existent day (7). This patch fixes this by calculating the tomorrow day and setting it to 0 if it's greater than 6. This patch also corrects the mappings for days, where local_day_of_week caluclates the date with Sunday first, which put it out of sync with the database opening hours days. Sponsored-by: Auckland University of Technology Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 05:01:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 03:01:06 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #32 from Aleisha Amohia --- Created attachment 150446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150446&action=edit Bug 6796: Updated schema files -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 05:01:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 03:01:09 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #33 from Aleisha Amohia --- Created attachment 150447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150447&action=edit Bug 6796: Fix atomic updates -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 05:01:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 03:01:13 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #34 from Aleisha Amohia --- Created attachment 150448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150448&action=edit Bug 6796: Fix saving of libraries and tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 06:57:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 04:57:46 +0000 Subject: [Koha-bugs] [Bug 24400] REST API: Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24400 --- Comment #1 from Danyon Sewell --- Created attachment 150449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150449&action=edit Bug 24400: Rest API for checkout WIP -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 06:58:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 04:58:36 +0000 Subject: [Koha-bugs] [Bug 24400] REST API: Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24400 Danyon Sewell changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |danyonsewell at catalyst.net.n | |z Assignee|koha-bugs at lists.koha-commun |danyonsewell at catalyst.net.n |ity.org |z Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 08:56:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 06:56:00 +0000 Subject: [Koha-bugs] [Bug 33597] Get rid of few SameSite warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 --- Comment #10 from Marcel de Rooy --- (In reply to Nick Clemens from comment #8) > Signed-off-by: Nick Clemens Thx Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 09:03:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 07:03:00 +0000 Subject: [Koha-bugs] [Bug 33242] Allow passing things like add_days => 3 to KohaDates filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33242 --- Comment #18 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #17) > Signed-off-by: Kyle M Hall Thx ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 11:19:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 09:19:23 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #14 from Katrin Fischer --- (In reply to David Cook from comment #13) > (In reply to Katrin Fischer from comment #12) > > You are right that different subdomains will create separate sessions, but I > > think the 99% is wrong. Koha used ports for a long time in its default setup > > and there are still reasons why you would want to do so. We do, with > > packages, use ports, for the installations we support. > > > > And it doesn't solve the problem here... different sessions, one timeout. > > How could you attach a different timeout to each? > > For your case, I think you'd need different cookie names for OPAC and Staff. > Mostly would involve refactoring... Not only for our use case - currently it's not possible to set different timeouts even if you are using different sub domains which divides the sessions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 12:21:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 10:21:05 +0000 Subject: [Koha-bugs] [Bug 33363] More specific permissions for purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33363 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150247|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes --- Created attachment 150450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150450&action=edit Bug 33363: Add separate permissions for creating and deleting suggestions There are a number of libraries that would like for their staff to be able to submit (and view existing) purchase suggestions from the borrower record, but not give the staff the ability to edit/manage/delete purchase suggestions. Test Plan: 1) Apply this patch 2) Run restart all the things! 3) Run updatedatabase 4) Verify anyone with the suggestions manage permissions now has the create and delete permissions as well 5) Verify anyone without the suggestions manage permission has not recieved the new permissions 6) Enable only the create permission for a librarian 7) Verify that librarian can only create new suggestions ( not manage or delete ) 8) Enable only the manage permission for a librarian 9) Verify that librarian can only manage existing suggestions ( not create or delete ) 10) Enable only the delete permission for a librarian 11) Verify that librarian can only delete suggestions ( not create or manage ) Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 12:21:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 10:21:42 +0000 Subject: [Koha-bugs] [Bug 33363] More specific permissions for purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33363 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 13:12:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 11:12:04 +0000 Subject: [Koha-bugs] [Bug 33028] The decimal separator 'comma' and its consequences on the calculation of fines (crons) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 --- Comment #22 from Kyle M Hall --- (In reply to Katrin Fischer from comment #21) > (In reply to Kyle M Hall from comment #20) > > Circ rules are not enforcing currency formats either. This might fix things > > once, but does not keep the issue from coming back. > > Hi Kyle, what do you suggest? A format check on the inputs in the circ > rules? We could use the pattern check we use in other forms. Or did you > think of something else? Yes. Ideally we'd enforce the chosen format using javascript on the frontend, and in perl on the backend. Since the js should enforce it on the frontend, the backend could just die or throw an exception if it sees a violation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 13:47:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 11:47:54 +0000 Subject: [Koha-bugs] [Bug 33028] The decimal separator 'comma' and its consequences on the calculation of fines (crons) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major --- Comment #23 from Katrin Fischer --- We had multiple reports of fines not working in 22.11 on the mailing lists and on bugzilla - I'd like to move this forward in some way since I am pretty sure that this one is to blame from the logs we saw complaining about invalid values. I am upping severity for now. This is definitely not an enhancement. The problem is, that when you edit an existing rule, you might create problematic values without noticing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 13:50:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 11:50:19 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 --- Comment #10 from Laura Escamilla --- (In reply to Katrin Fischer from comment #9) > Hi Laura, I'd love to see this in 23.05 - please let me know if you need any > help or won't have time to continue. We can figure something out. Hi Katrin! I was out recently for parental leave, I will get back to working on this asap! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:11:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 12:11:12 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:19:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 12:19:44 +0000 Subject: [Koha-bugs] [Bug 33240] After the latest update koha is not calculating the fine. Previously it was calculating. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33240 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Check your circulation rules for incorrect values in fine and max fine, see bug 33028. *** This bug has been marked as a duplicate of bug 33028 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:19:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 12:19:44 +0000 Subject: [Koha-bugs] [Bug 33028] The decimal separator 'comma' and its consequences on the calculation of fines (crons) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dhanestraj at gmail.com --- Comment #24 from Katrin Fischer --- *** Bug 33240 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:27:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 12:27:27 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:31:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 12:31:27 +0000 Subject: [Koha-bugs] [Bug 33640] Adding new item group from item additem.pl does nothing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33640 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to group items for records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:31:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 12:31:27 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33640 [Bug 33640] Adding new item group from item additem.pl does nothing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:32:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 12:32:15 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to group items for records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:32:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 12:32:15 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33639 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 [Bug 33639] Adding item to item group from 'Add item' screen doesn't work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:50:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 12:50:17 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals creating issue with renewal history view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ILS-DI does not record |ILS-DI does not record |renewer_id for renewals |renewer_id for renewals | |creating issue with renewal | |history view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:51:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 12:51:00 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals creating issue with renewal history view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:51:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 12:51:03 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals creating issue with renewal history view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150184|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 150451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150451&action=edit Bug 33504: Update patron_to_html to deal with null In the patron_to_html function we were dealing explicitly with the case where patron may be passed undefined, but forgetting that it may be returned as 'null' from the api too. Changing from `( patron === undefined )` to `( patron == null )` is the recommended approach for detecting 'undefined or null' in javascript. Signed-off-by: Magnus Enger Works as advertised. Martin's test plan from Bugzilla: To test. 1) Use ILS-DI to renew an checkout 2) View the circulation history for the item 3) Click the 'View' button next to the count of renewals 4) Note that the modal just stalls at 'Retrieving renewals' 5) Apply the patch 6) Now the 'retrieving renewals' message should list the renewals instead. Note that step 2 should be something like "Go to the "Circulation history" of the patron. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:00:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:00:36 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer --- This fixes the problem, but it creates another: * When enumchron was already filled out, selecting an item group now will overwrite the entered value and replace it. I feel like the initial intention here was to avoid this and I think that would be correct: if ( ! $('input.items-enumchron').val() ) { I think if we keep the check, but change it to checking for the name with . not -, it might actually work? if ( ! $('input[name="items.enumchron"]').val() ) { -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:02:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:02:06 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:03:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:03:35 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- (In reply to David Nind from comment #10) > I was testing at the same time as Phil (using KTD): > > 1. Everything works as per the test plan. > > 2. However, after applying the patch and repeating the searches: > - for Step 6, after getting no results using my name and clicking on "Try > another search", the name in the field reverts to the original record name > and not my name > - for Step 10, the same as step 6 - which is probably correct (but I'm > not sure...) > - feel free to change the status to Failed QA if this is not the expected > behavour (I would probably have failed QA if there wasn't already a sign off) > > 3. I tested using MARC21 and UNIMARC instances. Hi Nick, could you please have a look at David's notes here? I believe we'd always want the new name, so that would be one last glitch to fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:08:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:08:00 +0000 Subject: [Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 --- Comment #13 from Katrin Fischer --- (In reply to Nick Clemens from comment #12) > (In reply to Katrin Fischer from comment #11) > >if you add any line breaks just for > > making the HTML more readable, they will also all create a line break. > > Should we not do either/or? > > We had calls that already did this - if we want either or, we need a flag to > determine whether the field is HTML or not, otherwise we need to test with > regex? > > I don't think the additional breaks for HTML cause a problem, but I'll > follow your viewpoint. Maybe a new bug - so we can make a decision and be > consistent on all the calls? I think mostly people will probably use bold, italic etc and not do whole paragraphs here, so we are probably OK with the line breaks. You are right, we should discuss separately when needed, but I feel we can wait and see if it actually turns out to be an issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:09:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:09:00 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 --- Comment #1 from Katrin Fischer --- Hi Marcel, can you explain this a bit more? Is this about logging when an item's lost status is lifted? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:12:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:12:17 +0000 Subject: [Koha-bugs] [Bug 29653] Return claims on deleted items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29653 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |22.11 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:17:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:17:46 +0000 Subject: [Koha-bugs] [Bug 33642] New: Typo: No log found . Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33642 Bug ID: 33642 Summary: Typo: No log found . Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When using the log viewer under tools and no logs are found you'll see: No log found . This should be: No log found. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:18:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:18:21 +0000 Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #1 from Katrin Fischer --- Also confirmed in master. Wonder if this could have something to do with the work on tabs? Adding Owen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:22:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:22:21 +0000 Subject: [Koha-bugs] [Bug 33643] New: Add page-section to 'scan index' page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33643 Bug ID: 33643 Summary: Add page-section to 'scan index' page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff interface Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 33505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 [Bug 33505] Improve styling of scan index page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:22:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:22:21 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33643 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33643 [Bug 33643] Add page-section to 'scan index' page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:22:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:22:42 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 --- Comment #13 from Katrin Fischer --- > 2. The results pages need the page section added (bug 31757). Moved to: Bug 33643 - Add page-section to 'scan index' page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:29:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:29:07 +0000 Subject: [Koha-bugs] [Bug 33643] Add page-section to 'scan index' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33643 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:29:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:29:09 +0000 Subject: [Koha-bugs] [Bug 33643] Add page-section to 'scan index' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33643 --- Comment #1 from Katrin Fischer --- Created attachment 150452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150452&action=edit Bug 33643: Add page-section to 'scan index' page in staff interface This adds the white background. As we do on other pages I have chosen to include the h2 heading within the page-section. To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * On the result list verify there is no white background/page section * Apply patch * Repeat test - background should be present now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:30:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:30:03 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Keywords| |rel_22_11_candidate --- Comment #7 from Katrin Fischer --- We've also seen this - happy to have a look! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:30:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:30:34 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150314|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:30:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:30:39 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:36:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:36:10 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #8 from Katrin Fischer --- Created attachment 150453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150453&action=edit k -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:37:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:37:17 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:37:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:37:20 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150320|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 150454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150454&action=edit Bug 33631: [alternate] Fix misaligned labels If you look at the results_summary on either the results or detail pages you will notice that the label and content are slightly misaligned. To test: 1. On staff results, detail page, or ISBD details notice that slight misaligmnet between label and content. 2. Apply patch, yarn_build, clear browser cache 3. Look again, alignment should be fixed Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:37:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:37:43 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150453|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:37:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:37:59 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #10 from Katrin Fischer --- I've fixed the commit message :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:41:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:41:48 +0000 Subject: [Koha-bugs] [Bug 33628] Show item info in self check-in module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33628 --- Comment #1 from Katrin Fischer --- Created attachment 150455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150455&action=edit Display of checkins on web based self checkin page Confirmed: the current display is quite minimalistic. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:42:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:42:34 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:53:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:53:03 +0000 Subject: [Koha-bugs] [Bug 29664] Do not show voided payments in cash_register_stats.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:53:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:53:05 +0000 Subject: [Koha-bugs] [Bug 29664] Do not show voided payments in cash_register_stats.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 --- Comment #10 from Kyle M Hall --- Created attachment 150456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150456&action=edit Bug 29664: Do not show voided payments in cash_register_stats.pl Test Plan: 1) Set up your cash register 2) Take a payment 3) Void that payment 4) Verify the voided fee shows for the "All payments to the library" and "Payment" transaction type filters 5) Apply this patch 6) Restart all the things! 7) Verify the voided fee no longer shows for the "All payments to the library" and "Payment" transaction type filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:57:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 13:57:45 +0000 Subject: [Koha-bugs] [Bug 28093] Additional configuration option(s) for Shibboleth-only mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28093 --- Comment #4 from Katrin Fischer --- I was looking into making the bug description a bit more specific, but now I am not sure if this shouldn't be separate bugs: * Add a landing page for Shibboleth/external auth that the user is redirected to * when being automatically logged in * when logging out I wonder if the first could be annoying or if we should still provide way to get to the URL that was originally requested somehow. * Deactivate local login if external auth is activated. It looks like we already have this for Shibboleth with OPACShibOnly/staffShibOnly? So would this be for extending this beyond Shibboleth? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 16:03:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 14:03:39 +0000 Subject: [Koha-bugs] [Bug 33614] Templates contain problematic references to local login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33614 --- Comment #1 from Katrin Fischer --- I think CSS might not be the correct solution here. You'll still want to have helpful text/notes. I feel like we need to adapt the templates for having no local login? There is OPACShibOnly. Do we need this for OIDC and others too? Or turn it into a general "LocalLogin" switch? We have opacuserlogin, but that totally turns off anything that requires or looks like login. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 16:06:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 14:06:29 +0000 Subject: [Koha-bugs] [Bug 33536] If staff member only has catalogue permission, search bar is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33536 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- I believe we have a duplicate with a patch now with bug 33612. *** This bug has been marked as a duplicate of bug 33612 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 16:06:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 14:06:29 +0000 Subject: [Koha-bugs] [Bug 33612] Staff with limited permissions don't always get an expanded catalog_search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #5 from Katrin Fischer --- *** Bug 33536 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:22:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 15:22:41 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:22:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 15:22:43 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150250|0 |1 is obsolete| | --- Comment #8 from Caroline Cyr La Rose --- Created attachment 150457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150457&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to article-requests.tt This commit fixed two cases: 1. Fixing "Select all" and "Clear all" links on the page. 2. Fixing the interaction with selected entries when switching between the "New" and "Pending" tabs. To test: (Create article requests if they don't exist) Case 1: 1. Go to /cgi-bin/koha/circ/article-requests.pl and don't switch between tabs. 2. Click on "Select all" and verify that it's not working -- the checkboxes are not selected. 3. Activate any checkbox and click "Clear all" -- the checkbox is not cleared. 4. Apply the patch. 5. Restart the page and, without switching between tabs, repeat steps 2 and 3. Verify that it works now. Case 2: 1. Go to /cgi-bin/koha/circ/article-requests.pl. 2. Switch between tabs and leave "New" active. 3. Select any entry and delete or move it to another tab. 4. Verify that the entry remains in the table until the page reloads. 5. Apply the patch. 6. Restart the page and repeat steps 2 and 3. Make sure that everything works now. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:22:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 15:22:46 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150251|0 |1 is obsolete| | --- Comment #9 from Caroline Cyr La Rose --- Created attachment 150458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150458&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to serials-collection.tt To test: * Add a subscription * From the subscription detail page, click on serial collection link in left hand navigation * Create some additional issues * "Clear all" link for selecting issues to edit won't work, "Select all" link neither * Apply the patch * * "Clear all" link for selecting issues to edit works now, "Select all" link works too. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:22:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 15:22:48 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150298|0 |1 is obsolete| | --- Comment #10 from Caroline Cyr La Rose --- Created attachment 150459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150459&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to modborrowers.tt The submitted numbers were not processed by the search query. To test: 1. Go to /cgi-bin/koha/circ/modborrowers.pl 2. On the relevant tab, enter the card number or the borrower number in the text area, or upload a text file with a relevant list of numbers. 3. Click "Continue" and verify that a message appears stating "No patron card numbers or borrowernumbers given". 4. Apply the patch. 5. Restart the page and repeat steps 2 and 3. Make sure you receive the correct response -- a list of borrowers or a message indicating that the specified numbers were not found. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:22:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 15:22:51 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150377|0 |1 is obsolete| | --- Comment #11 from Caroline Cyr La Rose --- Created attachment 150460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150460&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to export.tt The list of CSV profiles was not displayed if the CSV format was selected in the output format settings. To test: 1. Go to /cgi-bin/koha/tools/export.pl 2. At the bottom of the page in the Output format, select SCV format. *If SCV format is not active in the drop-down File format menu, create any profile to Usage export records on the link /cgi-bin/koha/tools/csv-profiles.pl 3. Note that the list of SCV profiles is not displayed. 4. Apply the patch. 5. Restart the page and repeat steps 2. 6. Verify that when you select the CSV format, the list of CSV profiles appears. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:24:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 15:24:14 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #12 from Caroline Cyr La Rose --- I tested the 4.5 scenarios (serial collection, article requests (cases 1 and 2), patron batch modification and catalog export) and everything works with the patch. Thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:28:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 15:28:15 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/669 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:44:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 15:44:45 +0000 Subject: [Koha-bugs] [Bug 29664] Do not show voided payments in cash_register_stats.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|Laura.escamilla at bywatersolu |kyle at bywatersolutions.com |tions.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:31:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 16:31:32 +0000 Subject: [Koha-bugs] [Bug 33643] Add page-section to 'scan index' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33643 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:31:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 16:31:35 +0000 Subject: [Koha-bugs] [Bug 33643] Add page-section to 'scan index' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33643 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150452|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 150461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150461&action=edit Bug 33643: Add page-section to 'scan index' page in staff interface This adds the white background. As we do on other pages I have chosen to include the h2 heading within the page-section. To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * On the result list verify there is no white background/page section * Apply patch * Repeat test - background should be present now Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:43:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 16:43:51 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 --- Comment #11 from Laura Escamilla --- Created attachment 150462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150462&action=edit Bug 33419: Set home library and current library as mandatory by default Test plan to be used with KTD (Koha Testing Docker): 1. Reset KTD so that the web installer is used to setup Koha 2. Setup the web installer -> When setting up the default settings, don't add any of the optional data. 3. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a and $952$b are not mandatory. 4. Apply the patch. 5. Repeat steps 1-2. 6. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a and $952$b are now mandatory. How to setup the web installer ~~~~~~~~~~~~~~~~~~~~ 1. Access the database server[1]: mysql -uroot -ppassword -hkoha_db_1 2. Drop the koha_kohadev database: drop database koha_kohadev; 3. Create the database: create database koha_kohadev; 4. Add privileges (for a real installation this would be limited): grant all on koha_kohadev.* to koha_kohadev; 5. Restart everything (may not be required, but just to be safe): flush_memcached + restart_all 6. Access the web installer: go to 127.0.0.1:8081 7. Use the database user name and password: get from /etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password) 8. Continue through the installation process -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:32:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 17:32:05 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 --- Comment #7 from Lucas Gass --- I have a few follow-up questions: 1. Should a default value of noindex, nofollow be used here? 2. Is freetext the right thing to use here? Using conflicting or inconsistent values can confuse search engine crawlers and cause them to make incorrect assumptions about how to treat your pages in their index. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:35:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 17:35:51 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas at bywatersolutions.com --- Comment #35 from Lucas Gass --- Aleisha, There are some things the QA script caught that need to be cleaned up: Missing filters: OK installer/data/mysql/mandatory/sysprefs.sql FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt FAIL filters missing_filter at line 292 ( ) missing_filter at line 295 ( ) missing_filter at line 299 ( ) missing_filter at line 306 ( ) missing_filter at line 316 ( ) missing_filter at line 319 ( ) DB columns: FAIL installer/data/mysql/kohastructure.sql FAIL boolean_vs_tinyint WARNING - The new column (day) for table branch_hours is using INT(1) as type, must be TINYINT(1) if it has a boolean purpose, see the SQL12 coding guideline -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:36:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 17:36:15 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150462|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:51:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 17:51:59 +0000 Subject: [Koha-bugs] [Bug 33348] Show authority heading use with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas at bywatersolutions.com --- Comment #3 from Lucas Gass --- With this patch applied and ShowHeadingUse set to 'Allow' I notice that unit tests are failing: kohadev-koha at kohadevbox:koha(master)$ prove -v /kohadevbox/koha/t/Koha/SearchEngine/Elasticsearch/Search.t /kohadevbox/koha/t/Koha/SearchEngine/Elasticsearch/Search.t .. 1..2 Name "Koha::SearchEngine::Elasticsearch::AUTHORITIES_INDEX" used only once: possible typo at /kohadevbox/koha/t/Koha/SearchEngine/Elasticsearch/Search.t line 55. ok 1 - use Koha::SearchEngine::Elasticsearch::Search; # Subtest: search_auth_compat 1..2 ok 1 - Creating a new Search object # Looks like you planned 2 tests but ran 1. not ok 2 - search_auth_compat # Failed test 'search_auth_compat' # at /kohadevbox/koha/t/Koha/SearchEngine/Elasticsearch/Search.t line 63. Can't call method "data" on an undefined value at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Search.pm line 252. # Looks like your test exited with 255 just after 2. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/2 subtests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:54:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 17:54:04 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #39 from Michael Hafen --- Let me try to amend the test plan with more detail. I was just able to apply this patch to a current master and get through the test plan successfully, but there are details missing from the test plan that could cause confusion if one isn't familiar with the module. Test plan: 1. start a new batch in the patron card creator (Tools -> Patron card creator -> New -> card batch) 2. click the Add patron(s) button. This will open the 'Patron search' window. Observe that Category and Library are the only options. 3. Close 'Patron search' window. 4. Apply patch. Restart Plack, etc. 5. click the Add patron(s) button. This will reopen the 'Patron search' window. Observe that you can now search for patrons by their sort1 and sort2 values. 6. perform a search using a sort1 or sort2 value that will have multiple results. Observe the 'Select all | Clear all | Add selected patrons' links and button. 7. use the Select all link to select all the patrons found by the search. 8. use the Add selected patrons button to add the selected patrons to the card batch's Add by borrowernumber(s) text input field in the main window. 9. close the 'Patron search' window. Click the Add patron(s) button again to add the patrons to the batch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:56:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 17:56:55 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:56:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 17:56:58 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150294|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 150463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150463&action=edit Bug 33611: Unit test Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:57:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 17:57:00 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150295|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 150464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150464&action=edit Bug 33611: Ensure dt_from_string always returns a new object This patch alters dt_from_string to pass a cloned object if called on an existing date time object This resolves an issue where a holds reserve date was being altered when the default expiration date was set To test: 1 - Set DefaultHoldExpiration to Set 2 - Set DefaultHoldExpirationPeriod to 365 3 - Set DefaultHoldExpirationunitOfTimeToDays 4 - Place a hold 5 - Note reserve date is 1 year in the future, same as expiration 6 - Apply patch 7 - Restart all 8 - Place another hold 9 - Note reserve date is set to today Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:06:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 18:06:59 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #11 from David Nind --- Thanks for testing and signing off Katrin! (You beat me to it!) I was working through various screens, but had not found anything - so far, any misalignments I found were already there before the patch. This also now corrects the display in the search results. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:12:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 18:12:30 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #12 from Katrin Fischer --- Please sign-off, then I can use my token for QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:24:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 18:24:49 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150454|0 |1 is obsolete| | --- Comment #13 from David Nind --- Created attachment 150465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150465&action=edit Bug 33631: [alternate] Fix misaligned labels If you look at the results_summary on either the results or detail pages you will notice that the label and content are slightly misaligned. To test: 1. On staff results, detail page, or ISBD details notice that slight misaligmnet between label and content. 2. Apply patch, yarn_build, clear browser cache 3. Look again, alignment should be fixed Signed-off-by: Katrin Fischer Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:27:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 18:27:02 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #14 from David Nind --- (In reply to Katrin Fischer from comment #12) > Please sign-off, then I can use my token for QA :) Done! I also tested a sample of other pages to see if I noticed any changes (this was in no way comprehensive). I only identified some minor misalignments that were present before the patch was applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:40:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 18:40:27 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:40:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 18:40:29 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #12 from Nick Clemens --- Created attachment 150466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150466&action=edit Bug 33445: Pass through form info if present and use record values otherwise This patch updates the form to pass through values formthe form when searching, and to use record values if nothing is passed in. TO test: 1 - Without the patch, edit a personal name authority record 2 - Replace 100 subfield a (200 subfield a for UNIMARC) with your own name 3 - Click "Replace record via Z39.50/SRU search" 4 - Note that prefilled search field contains the original value, not your name. 5 - Replace the Author (personal) field with your name in the search form 6 - choose a search target, and click Search. 7 - Note that the results of the search are for the original value, not your name 8 - From the details page of a record, click 'Edit -> Replace record via Z3950' 9 - Note form is prefilled 10 - Change value as in 5 and search 11 - Note original term was searched 12 - Apply patch, restart all 13 - Repeat searches as before 14 - Confirm that form is prefilled with record or the updated value 15 - Confirm your entered search terms are always searched Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:40:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 18:40:32 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #13 from Nick Clemens --- Created attachment 150467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150467&action=edit Bug 33445: (follow-up) Pass form values through when clicking 'Try another search' We didn't include anything except the authid id in the try again form, this patch extends to cover all the fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:40:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 18:40:35 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #14 from Nick Clemens --- Created attachment 150468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150468&action=edit Bug 33445: (follow-up) Allow all search fields to be passed through and returned when trying another search It seems the form didn't populate all fields form data passed in. This patch corrects that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:43:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 18:43:10 +0000 Subject: [Koha-bugs] [Bug 33644] New: Link tracking Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33644 Bug ID: 33644 Summary: Link tracking Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org It would be awesome if we could add a unique parameter to the opac url that, when used, would be recorded in a table as a use. It would record the link, and how many times it has been clicked. Sometimes we set up links on signage, or websites, or in a QR code, and it would be great to measure which links are being utilized where. So, maybe we could have a link that is in a QR code being displayed in a particular location, like https://YOUROPAC/cgi-bin/koha/opac-search.pl?q=(su%3A%7BGardening.%7D). Maybe we add a parameter like &track=qrnorthdisplay, and every time this link is visited, it would save to a tracking table, maybe linktracking. It would save the &track parameter, and then keep count every time that link is hit. That way it would only have one record in the table, rather than one for every click. Maybe you want one for every click so you could time stamp it and see when it is being clicked? I don't know. But this would be such a handy feature, especially for establishing how effective links are, and usage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:44:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 18:44:26 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150419|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:45:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 18:45:35 +0000 Subject: [Koha-bugs] [Bug 32906] Make 'Replace record via Z3950/SRU' buttons in authorities work consistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32906 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #1 from Nick Clemens --- I don't see the difference, it looks like both pass the authid and pull the terms from marc, and accounts for UNIMARC, maybe another bug fixed it? See also bug 33445 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:51:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 18:51:34 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_14772=5D_Remove_or_clarify_checkbox?= =?utf-8?q?_=C2=ABflagged=C2=BB_on_subfield_visibility_frameworks?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14772 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #4 from Caroline Cyr La Rose --- (In reply to Séverine Queune from comment #3) > I tested the use of this option for items subfields and I'm not sure it > should be suppressed, but adapted : this option is the only way (I found...) > to hide subfields from the modification pages "Add item" and "Batch item > modification". > It could be great to have the "Flagged" box checkable with the others (now, > all others boxes are unchecked when used) so each library could define which > subfields can be modified using the "Add item" page (checkbox "Editor") but > hidden on the "Batch item modification" form. > But maybe my comment out of purpose... Unless I'm misunderstanding, I cannot reproduce this in the current master (22.12). If I uncheck 'Editor', the subfield is removed from both 'Add item' and 'Batch item modification'. I agree that there is no way currently to make a subfield appear in the 'Add item' form, but not in the 'Batch item modification' form. You can use SubfieldsToAllowForRestrictedBatchmod if really this subfield shouldn't be allowed to be batch modified. This probably should be the subject of another bug report, if there really is a need. I'm in favour of removing the 'flagged' option completely -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:04:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 19:04:32 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #15 from Phil Ringnalda --- Comment on attachment 150468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150468 Bug 33445: (follow-up) Allow all search fields to be passed through and returned when trying another search >-[% USE raw %] >+nt[% USE raw %] Haven't looked at whether that nt belonged somewhere else, but it doesn't look right there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:06:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 19:06:45 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:08:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 19:08:13 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #16 from David Nind --- (In reply to Phil Ringnalda from comment #15) > Comment on attachment 150468 [details] [review] > Bug 33445: (follow-up) Allow all search fields to be passed through and > returned when trying another search > > >-[% USE raw %] > >+nt[% USE raw %] > > Haven't looked at whether that nt belonged somewhere else, but it doesn't > look right there. Was just retesting - the nt appears at the top left of the Z3950 search window. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:09:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 19:09:49 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150468|0 |1 is obsolete| | --- Comment #17 from Nick Clemens --- Created attachment 150469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150469&action=edit Bug 33445: (follow-up) Allow all search fields to be passed through and returned when trying another search It seems the form didn't populate all fields form data passed in. This patch corrects that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:10:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 19:10:35 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #18 from Nick Clemens --- (In reply to David Nind from comment #16) > (In reply to Phil Ringnalda from comment #15) > > Was just retesting - the nt appears at the top left of the Z3950 search > window. That was a slip, new patch attached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:14:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 19:14:24 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:14:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 19:14:27 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150466|0 |1 is obsolete| | --- Comment #19 from David Nind --- Created attachment 150470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150470&action=edit Bug 33445: Pass through form info if present and use record values otherwise This patch updates the form to pass through values formthe form when searching, and to use record values if nothing is passed in. TO test: 1 - Without the patch, edit a personal name authority record 2 - Replace 100 subfield a (200 subfield a for UNIMARC) with your own name 3 - Click "Replace record via Z39.50/SRU search" 4 - Note that prefilled search field contains the original value, not your name. 5 - Replace the Author (personal) field with your name in the search form 6 - choose a search target, and click Search. 7 - Note that the results of the search are for the original value, not your name 8 - From the details page of a record, click 'Edit -> Replace record via Z3950' 9 - Note form is prefilled 10 - Change value as in 5 and search 11 - Note original term was searched 12 - Apply patch, restart all 13 - Repeat searches as before 14 - Confirm that form is prefilled with record or the updated value 15 - Confirm your entered search terms are always searched Signed-off-by: Phil Ringnalda Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:14:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 19:14:29 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150467|0 |1 is obsolete| | --- Comment #20 from David Nind --- Created attachment 150471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150471&action=edit Bug 33445: (follow-up) Pass form values through when clicking 'Try another search' We didn't include anything except the authid id in the try again form, this patch extends to cover all the fields Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:14:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 19:14:32 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150469|0 |1 is obsolete| | --- Comment #21 from David Nind --- Created attachment 150472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150472&action=edit Bug 33445: (follow-up) Allow all search fields to be passed through and returned when trying another search It seems the form didn't populate all fields form data passed in. This patch corrects that Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:16:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 19:16:42 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #22 from David Nind --- (In reply to Nick Clemens from comment #18) > (In reply to David Nind from comment #16) > > (In reply to Phil Ringnalda from comment #15) > > > > Was just retesting - the nt appears at the top left of the Z3950 search > > window. > > That was a slip, new patch attached Thanks Nick! Now signed off. I added some values to the keyword input field, and these were retained (including 'Try another search'. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:32:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 19:32:11 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150470|0 |1 is obsolete| | --- Comment #23 from David Nind --- Created attachment 150473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150473&action=edit Bug 33445: Pass through form info if present and use record values otherwise This patch updates the form to pass through values formthe form when searching, and to use record values if nothing is passed in. TO test: 1 - Without the patch, edit a personal name authority record 2 - Replace 100 subfield a (200 subfield a for UNIMARC) with your own name 3 - Click "Replace record via Z39.50/SRU search" 4 - Note that prefilled search field contains the original value, not your name. 5 - Replace the Author (personal) field with your name in the search form 6 - choose a search target, and click Search. 7 - Note that the results of the search are for the original value, not your name 8 - From the details page of a record, click 'Edit -> Replace record via Z3950' 9 - Note form is prefilled 10 - Change value as in 5 and search 11 - Note original term was searched 12 - Apply patch, restart all 13 - Repeat searches as before 14 - Confirm that form is prefilled with record or the updated value 15 - Confirm your entered search terms are always searched Signed-off-by: Phil Ringnalda Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:32:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 19:32:14 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150471|0 |1 is obsolete| | --- Comment #24 from David Nind --- Created attachment 150474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150474&action=edit Bug 33445: (follow-up) Pass form values through when clicking 'Try another search' We didn't include anything except the authid id in the try again form, this patch extends to cover all the fields Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:32:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 19:32:17 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150472|0 |1 is obsolete| | --- Comment #25 from David Nind --- Created attachment 150475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150475&action=edit Bug 33445: (follow-up) Allow all search fields to be passed through and returned when trying another search It seems the form didn't populate all fields form data passed in. This patch corrects that Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:34:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 19:34:39 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #26 from David Nind --- Apologies for the noise - somehow managed to add the patch with the 'nt' when I signed off. Amended the patch, so should now be correct! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 22:34:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 20:34:25 +0000 Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #60 from Emily Lamancusa --- Hi Aleisha, I encountered a few errors while trying to test this patchset. #1 After changing RevertLostBibLevelHolds to "Revert", I get the following error on cataloguing/additem.pl: The method Koha::Items->holds is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Objects.pm line 572 Koha::Objects::AUTOLOAD('Koha::Items=HASH(0x564bf159f540)', 'HASH(0x564bf1743f18)') called at /kohadevbox/koha/cataloguing/additem.pl line 757 eval {...} at /kohadevbox/koha/cataloguing/additem.pl line 2 The error persists even if I change RevertLostBibLevelHolds to "Don't Revert" and restart all. (It does not occur before I change the syspref, and does not persist if I reset all.) --------------------------------------------------------------------------------- #2 I get the following error on moredetail.pl: Can't call method "holds" on an undefined value at /kohadevbox/koha/catalogue/moredetail.pl line 251 The line in question is: $item_info->{waiting_holds} = $item->{object}->holds({ found => [ 'W', 'T' ], item_level_hold => { '!=' => 0 } })->count; I tried replacing "$item->{object}->holds" with "$item->holds" and that seemed to fix it (and had no effect on error #1). --------------------------------------------------------------------------------- #3 Tests don't pass: t/db_dependent/Reserves.t .. "my" variable $item masks earlier declaration in same scope at /kohadevbox/koha/C4/Circulation.pm line 4029. t/db_dependent/Reserves.t .. 24/78 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 588. t/db_dependent/Reserves.t .. 73/78 # Looks like you planned 17 tests but ran 13. # Failed test 'Waiting item is marked as lost' # at t/db_dependent/Reserves.t line 1563. Can't call method "notice_email_address" on unblessed reference at /kohadevbox/koha/C4/Message.pm line 185. # Looks like your test exited with 11 just after 73. t/db_dependent/Reserves.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 6/78 subtests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 23:07:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 21:07:52 +0000 Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 --- Comment #2 from Aleisha Amohia --- (I'm using main in place of master as much as possible hehe) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 1 23:23:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 21:23:49 +0000 Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 --- Comment #3 from Katrin Fischer --- You are right - I think we also decided to switch, but haven't yet figured out the steps and timing. I mostly wanted to help this along saying I can see it too and I'd also really like to see it fixed - it could cause a bit of a panic when people think they lost their content. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 1 23:51:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 21:51:07 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de |testopia at bugs.koha-communit | |y.org Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer --- With this patch applied, I think we now have a regression for the other use case: select kohafield from marc_subfield_structure where tagfield = 952 and kohafield like "%perm%"; = empty, no results I haven't linked the subfield in the frameworks. But: * location and permanent location are both = FIC * Edit location (c) in the item editor: both are now GEN * Batch mod the same item. Set location (c) to FIC. * We now have location = FIC / permanent.locaton = GEN The item editor and the batch mod should behave the same way, shouldn't they? How do you check on the link? I still had k set to the auth_value, but I think that should not matter. It works as expected without the patch applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:04:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 22:04:56 +0000 Subject: [Koha-bugs] [Bug 33633] Check if email exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #9 from Katrin Fischer --- I think having the library send a verification email and flagging verified or problematic emails in Koha would be totally ok. But I think using any kind of outsite tool, API or website would be a big no-no in terms of data privacy and I also agree with Marcel that we should not implement it within Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:15:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 22:15:25 +0000 Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:15:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 22:15:27 +0000 Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 --- Comment #1 from Lucas Gass --- Created attachment 150476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150476&action=edit Bug 32253: Load all CodeMirror lines initially when using advanced editor To test: 1. Have advanced editor turned on. 2. Load a record with many lines and see that not all the lines appear until you click on the visible ones. 3. Apply patch and try again 4. All lines should load. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:16:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 22:16:14 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 --- Comment #12 from Katrin Fischer --- Hi Laura, glad to have you back and congratulations :) Leaving another note for later: I was wondering if we should also update existing ones with a database update. So I checked what we did for itype (see bug 25449). We didn't do a database update there, so answering my own question: I think w don't need one here either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:17:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 22:17:15 +0000 Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:17:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 22:17:29 +0000 Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31863 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 [Bug 31863] Advanced cataloging editor no longer auto-resizes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:17:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 22:17:29 +0000 Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer auto-resizes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32253 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 [Bug 32253] Advanced cataloging editor doesn't load every line initially -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:32:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 22:32:22 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:32:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 22:32:25 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #36 from Aleisha Amohia --- Created attachment 150477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150477&action=edit Bug 6796: (follow-up) Fix branch_hours.day to enum and add filters -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:32:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 22:32:29 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #37 from Aleisha Amohia --- Created attachment 150478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150478&action=edit Bug 6796: (follow-up) Schema changes -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:37:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 22:37:55 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass --- Alex, The QA tool complains about quite a few missing filters within Cookies.set. I think we can add the html filter in those cases, right? Also, should none be option along with lax and strict? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:39:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 22:39:45 +0000 Subject: [Koha-bugs] [Bug 33348] Show authority heading use with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:39:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 22:39:47 +0000 Subject: [Koha-bugs] [Bug 33348] Show authority heading use with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348 --- Comment #4 from Aleisha Amohia --- Created attachment 150479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150479&action=edit Bug 33348: (follow-up) Fix if no 008 defined And copy fix across to Zebra search as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:47:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 22:47:21 +0000 Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:47:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 22:47:25 +0000 Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 --- Comment #61 from Aleisha Amohia --- Created attachment 150480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150480&action=edit Bug 20844: (follow-up) Fixes for lists, objects, templates, tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:49:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 22:49:28 +0000 Subject: [Koha-bugs] [Bug 33348] Show authority heading use with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:49:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 22:49:31 +0000 Subject: [Koha-bugs] [Bug 33348] Show authority heading use with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150440|0 |1 is obsolete| | --- Comment #5 from Lucas Gass --- Created attachment 150481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150481&action=edit Bug 33348: Show authority heading use with Elasticsearch This patch ensures the ShowHeadingUse system preference and feature works as expected when using Elasticsearch as the searchengine. To test, follow the test plan at Bug 29990 Comment 9. Ensure the SearchEngine system preference is set to Elasticsearch. Sponsored-by: Education Services Australia SCIS Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:49:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 22:49:33 +0000 Subject: [Koha-bugs] [Bug 33348] Show authority heading use with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150479|0 |1 is obsolete| | --- Comment #6 from Lucas Gass --- Created attachment 150482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150482&action=edit Bug 33348: (follow-up) Fix if no 008 defined And copy fix across to Zebra search as well. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:09:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 23:09:04 +0000 Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:09:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 23:09:07 +0000 Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150476|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 150483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150483&action=edit Bug 32253: Load all CodeMirror lines initially when using advanced editor To test: 1. Have advanced editor turned on. 2. Load a record with many lines and see that not all the lines appear until you click on the visible ones. 3. Apply patch and try again 4. All lines should load. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:10:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 23:10:08 +0000 Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (using KTD): 1. Used biblionumber = 248 - this has more than 25 lines in the advanced editor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:32:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 23:32:26 +0000 Subject: [Koha-bugs] [Bug 33614] Templates contain problematic references to local login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33614 --- Comment #2 from David Cook --- (In reply to Katrin Fischer from comment #1) > There is OPACShibOnly. Do we need this for OIDC and others too? Or turn it > into a general "LocalLogin" switch? I like the idea of a general "LocalLogin" switch! Or I suppose OpacLocalLogin since we'd be focused on the OPAC in this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:35:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 May 2023 23:35:29 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #15 from David Cook --- (In reply to Katrin Fischer from comment #14) > Not only for our use case - currently it's not possible to set different > timeouts even if you are using different sub domains which divides the > sessions. I'm not 100% sure I understand what you're saying. Different subdomains have different cookies, but in Koha there is only the "timeout" syspref. Is that what you mean? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 02:15:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 00:15:45 +0000 Subject: [Koha-bugs] [Bug 33645] New: koha-foreach always returns 1 if --chdir not specified Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33645 Bug ID: 33645 Summary: koha-foreach always returns 1 if --chdir not specified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz If you don't provide --chdir to koha-foreach it will always return an exit code of 1, because the final if statement in the script will return false -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 02:15:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 00:15:53 +0000 Subject: [Koha-bugs] [Bug 33645] koha-foreach always returns 1 if --chdir not specified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33645 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 02:19:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 00:19:13 +0000 Subject: [Koha-bugs] [Bug 33645] koha-foreach always returns 1 if --chdir not specified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33645 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 02:19:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 00:19:16 +0000 Subject: [Koha-bugs] [Bug 33645] koha-foreach always returns 1 if --chdir not specified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33645 --- Comment #1 from David Cook --- Created attachment 150484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150484&action=edit Bug 33645: Make koha-foreach return 0 if it completes successfully This patch adds an "exit 0" to the end of koha-foreach, so that it returns a successful exit code if it reaches the bottom of the script without errors. Test plan: 0) `koha-foreach echo` 1) `echo $?` 2) Note that the exit status is 1 3) Apply patch 4) `./debian/scripts/koha-foreach echo` 5) `echo $?` 6) Note that the exit status is 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 02:23:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 00:23:05 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:18:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 01:18:08 +0000 Subject: [Koha-bugs] [Bug 22718] Authorized value for not for loan not showed in cataloging search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22718 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME CC| |dcook at prosentient.com.au Status|NEW |RESOLVED --- Comment #1 from David Cook --- Works for me in 21.11+ But there are other issues relating to the display of "not for loan" items in the Cataloging search... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:20:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 01:20:49 +0000 Subject: [Koha-bugs] [Bug 33646] New: "Cataloging search" missing branch data for not for loan items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646 Bug ID: 33646 Summary: "Cataloging search" missing branch data for not for loan items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org In the "Cataloging search" (ie /cgi-bin/koha/cataloguing/addbooks.pl), the branch name doesn't appear for "Not for loan" items, which makes the display nonsensical when there are many not for loan items for many branches. It's also inconsistent with the "Search results" (ie /cgi-bin/koha/catalogue/search.pl). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:22:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 01:22:15 +0000 Subject: [Koha-bugs] [Bug 33646] "Cataloging search" missing important data for not for loan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Cataloging search" missing |"Cataloging search" missing |branch data for not for |important data for not for |loan items |loan items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:38:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 01:38:36 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:38:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 01:38:39 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144131|0 |1 is obsolete| | --- Comment #32 from David Nind --- Created attachment 150485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150485&action=edit Bug 31391: RecallsInterface system preference Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:38:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 01:38:43 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144132|0 |1 is obsolete| | --- Comment #33 from David Nind --- Created attachment 150486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150486&action=edit Bug 31391: Recalled authorised value for hold cancellation Signed-off-by: David Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:38:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 01:38:46 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144133|0 |1 is obsolete| | --- Comment #34 from David Nind --- Created attachment 150487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150487&action=edit Bug 31391: Implement RecallsInterface on OPAC Signed-off-by: David Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:38:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 01:38:49 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144134|0 |1 is obsolete| | --- Comment #35 from David Nind --- Created attachment 150488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150488&action=edit Bug 31391: Request recalls and convert reserves on staff interface This enhancement adds the ability to place recalls via the staff interface by introducing a system preference, RecallsInterface, to configure where recalls can be placed. Recalls can either be placed via the OPAC, or the staff interface, or both. This is set to OPAC by default to be consistent with current behaviour. This enhancement also adds the ability to convert existing reserves to recalls easily via the staff interface. The reserve will be cancelled and a recall placed using the reserve's information. To test: 1) Update database and restart services 2) Enable UseRecalls and set the relevant recalls circulation rules 3) View the new RecallsInterface system preference. Confirm it is set to OPAC only by default 4) Check out Item A to Patron B. 5) Log into the OPAC as Patron A. Confirm you can place, view and cancel recalls as normal. 6) In the staff interface, set RecallsInterface to Staff interface only. 7) In the OPAC, confirm you can still view and cancel recalls, but can no longer place recalls. 8) In the staff interface, search for Item A and go to the Reserves tab. Place a reserve for Patron C. 9) Under the Priority column, select the dropdown and choose the recall option next to your reserve. 10) Click Update holds. Confirm when the page refreshes that your reserve has disappeared. 11) Go to the recalls tab. Confirm your reserve has been converted to a recall, and details like the patron, expiration, and pickup location have carried across to the recall. 12) On this recalls page, use the patron search to find Patron D. Test placing a record-level recall by keeping the 'recall next available item' checkbox. 13) When the page refreshes, confirm the recall was successfully placed with the correct details stored. 14) Repeat steps 12 and 13 with Patron E, this time place an item-level recall by choosing an item in the 'place a recall on a specific item' table. When selecting one of these items, the 'recall next available item' checkbox should de-select. 15) Set RecallsInterface back to OPAC only. Go back to the record and view the Recalls tab. 16) Confirm you cannot search for a patron to place a recall, but can still view and cancel recalls. Confirm you also cannot convert reserves to recalls. 17) Set RecallsInterface to both staff interface and OPAC. Confirm you can place recalls on both interfaces. 18) On the staff interface, test placing recalls that your circulation rules do not allow. For example, if 'recalls per record' is 1, ensure you're blocked from placing a second recall on a record for a patron. 19) Place a reserve for one of the patron's that already has a recall. Once complete, try to convert this reserve into a recall. Confirm you are blocked and shown a message that the hold cannot be converted to a recall. 20) Ensure tests pass t/db_dependent/Holds.t Sponsored-by: Auckland University of Technology Signed-off-by: David Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:38:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 01:38:52 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144135|0 |1 is obsolete| | --- Comment #36 from David Nind --- Created attachment 150489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150489&action=edit Bug 31391: (follow-up) Fix cancel recalls using checkbox Signed-off-by: David Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:38:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 01:38:55 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144136|0 |1 is obsolete| | --- Comment #37 from David Nind --- Created attachment 150490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150490&action=edit Bug 31391: (follow-up) Fix number of tests and terminology Fixed two items: - Number of tests: changed to 77 (from 76), tests now pass - Terminology: changed message when attempting to place recalls from the staff interface when RecallsInterface in set to the OPAC only (staff client should be staff interface) Signed-off-by: David Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:38:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 01:38:59 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147582|0 |1 is obsolete| | --- Comment #38 from David Nind --- Created attachment 150491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150491&action=edit Bug 31391: Interface and wording fixes This patch includes the following fixes: - Making the atomic updates executable - Preventing warns when running tests - Updating db updates - Fixing terminology - Make 'cancel selected recalls' button yellow - Fix HTML makeup of recalls request page - Show a warning when placing a recall if there is already a record-level hold by this patron - Show a link to mark a hold for conversion which selects the recall option on holds page Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:45:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 01:45:29 +0000 Subject: [Koha-bugs] [Bug 33645] koha-foreach always returns 1 if --chdir not specified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33645 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:45:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 01:45:31 +0000 Subject: [Koha-bugs] [Bug 33645] koha-foreach always returns 1 if --chdir not specified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33645 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150484|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 150492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150492&action=edit Bug 33645: Make koha-foreach return 0 if it completes successfully This patch adds an "exit 0" to the end of koha-foreach, so that it returns a successful exit code if it reaches the bottom of the script without errors. Test plan: 0) `koha-foreach echo` 1) `echo $?` 2) Note that the exit status is 1 3) Apply patch 4) `./debian/scripts/koha-foreach echo` 5) `echo $?` 6) Note that the exit status is 0 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:52:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 01:52:18 +0000 Subject: [Koha-bugs] [Bug 33045] Use process_tt in C4::Record::marcrecord2csv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33045 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:52:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 01:52:21 +0000 Subject: [Koha-bugs] [Bug 33045] Use process_tt in C4::Record::marcrecord2csv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33045 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147181|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 150493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150493&action=edit Bug 33045: Use process_tt in C4::Record::marcrecord2csv Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in marcrecord2csv. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Record/marcrecord2csv.t Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:58:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 01:58:18 +0000 Subject: [Koha-bugs] [Bug 33043] Use process_tt in SIP modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33043 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #3 from David Nind --- The patch no longer applies 8-(.. Applying: Bug 33043: Use process_tt in SIP modules Using index info to reconstruct a base tree... M C4/SIP/ILS/Patron.pm Falling back to patching base and 3-way merge... Auto-merging C4/SIP/ILS/Patron.pm CONFLICT (content): Merge conflict in C4/SIP/ILS/Patron.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 33043: Use process_tt in SIP modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 04:27:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 02:27:09 +0000 Subject: [Koha-bugs] [Bug 33030] Add standardized subroutine for processing Template Toolkit syntax outside of notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Failed QA --- Comment #4 from David Nind --- The tests currently fail: prove t/db_dependent/Koha/Items.t t/db_dependent/Koha/Items.t .. 6/16 # Looks like you planned 9 tests but ran 4. t/db_dependent/Koha/Items.t .. 15/16 # Failed test 'search_ordered' # at t/db_dependent/Koha/Items.t line 1904. DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'published_on_template' in 'field list' at /kohadevbox/koha/t/lib/TestBuilder.pm line 384 # Looks like your test exited with 11 just after 15. t/db_dependent/Koha/Items.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 2/16 subtests Test Summary Report ------------------- t/db_dependent/Koha/Items.t (Wstat: 2816 Tests: 15 Failed: 1) Failed test: 15 Non-zero exit status: 11 Parse errors: Bad plan. You planned 16 tests but ran 15. Files=1, Tests=15, 5 wallclock secs ( 0.04 usr 0.00 sys + 3.69 cusr 0.58 csys = 4.31 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 04:34:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 02:34:39 +0000 Subject: [Koha-bugs] [Bug 33046] Use process_tt in C4::Reports::Guided::EmailReport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33046 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 04:34:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 02:34:41 +0000 Subject: [Koha-bugs] [Bug 33046] Use process_tt in C4::Reports::Guided::EmailReport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33046 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147179|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 150494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150494&action=edit Bug 33046: Use process_tt in C4::Reports::Guided::EmailReport Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in EmailReport. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Reports/Guided.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 04:51:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 02:51:07 +0000 Subject: [Koha-bugs] [Bug 24400] REST API: Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24400 Danyon Sewell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150449|0 |1 is obsolete| | --- Comment #2 from Danyon Sewell --- Created attachment 150495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150495&action=edit Bug 24400: Rest API for checkout WIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 05:04:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 03:04:23 +0000 Subject: [Koha-bugs] [Bug 33030] Add standardized subroutine for processing Template Toolkit syntax outside of notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 07:28:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 05:28:30 +0000 Subject: [Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150417|0 |1 is obsolete| | --- Comment #3 from Emmi Takkinen --- Created attachment 150496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150496&action=edit Bug 32993: Holds priority changed incorrectly with dropdown selector Test Plan: 1) Find record with at least 3 holds. 2) Change first holds priority as 2, Priority is changed to 3. 3) Try to change priority back to 1, Priority is changed to 2. 4) Apply this patch 5) Reload the page 2) Change first holds priority as 2, Priority is changed to 2. 3) Try to change priority back to 1, Priority is changed to 1. Signed-off-by: David Nind Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 07:58:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 05:58:12 +0000 Subject: [Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393 --- Comment #8 from Alex Buckley --- Created attachment 150497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150497&action=edit Bug 33393: Add note to system preference explaining text length Sponsored-by: Pymble Ladies' College -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 08:01:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 06:01:04 +0000 Subject: [Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393 --- Comment #9 from Alex Buckley --- Hi David, I have attached a patchset adding a note to the system preference description noting to keep the text length to 3 lines. Is that what you had in mind? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 09:00:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 07:00:14 +0000 Subject: [Koha-bugs] [Bug 30002] Add project-level perltidyrc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 --- Comment #17 from Jonathan Druart --- (In reply to David Nind from comment #16) > Discussion at the 26 April 2023 Development IRC Meeting. > > To vote on this at the next Development IRC Meeting - see > https://meetings.koha-community.org/2023/ > development_irc_meeting_26_april_2023.2023-04-26-14.31.log.html#l-87 > > Added to the agenda: > https://wiki.koha-community.org/wiki/Development_IRC_meeting_10_May_2023 There is nothing to vote on, I am going to work on it. Please wait a bit more here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 09:01:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 07:01:54 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150281|0 |1 is obsolete| | Attachment #150362|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 150498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150498&action=edit Bug 33623: Encode URL params for getAll We must encode properly URL parameters when building the REST API routes Can be tested easily using const client = APIClient.erm client.licenses.getAll({ "me.name:%ff%" }) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 09:01:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 07:01:56 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 --- Comment #7 from Jonathan Druart --- Created attachment 150499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150499&action=edit Bug 33623: Move ULSearchParams into http-client.js Remove unused getAll methods in erm-api-client.js Make use of new getAll query in AgreementRelationships Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 09:03:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 07:03:03 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 --- Comment #8 from Jonathan Druart --- Great follow-up, Pedro, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 09:16:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 07:16:25 +0000 Subject: [Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #14 from Jonathan Druart --- (In reply to Jonathan Druart from comment #9) > Let push and see how it goes? This was more than 2 months ago, to have time to fix before the release. Now we are few weeks before the release. Why did we have wait so much time to push it? These patches are unnecessary painful to rebase! Are we part of a kind of masochist secret group? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 09:39:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 07:39:23 +0000 Subject: [Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #15 from Jonathan Druart --- Too many conflicts, I am giving up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 09:41:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 07:41:50 +0000 Subject: [Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #16 from Jonathan Druart --- On top of the remote branch, I think there are some occurrences missing % git grep '\-o"' **/*.tt **/*.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 09:55:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 07:55:10 +0000 Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32912 --- Comment #4 from Katrin Fischer --- I just checked our 22.11.03 instance and it still appears to be working ok there. Maybe another clue. Bug 32912 could be a possible candidate. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32912 [Bug 32912] Use template wrapper for notices tabs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 09:55:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 07:55:10 +0000 Subject: [Koha-bugs] [Bug 32912] Use template wrapper for notices tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32912 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33622 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 10:01:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 08:01:13 +0000 Subject: [Koha-bugs] [Bug 33328] x-marc-schema should be renamed x-record-schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33328 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149671|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 150500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150500&action=edit Bug 33328: Rename x-marc-schema => x-record-schema This patch renames the header on the biblio API so it is not entirely tied to MARC, trying to follow the biblio_metadata table generic approach. To test: 1. Apply this patch 2. Run: $ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass 3. You agree with the change? 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Magnus Enger Change sounds reasonable. Tests pass before and after patch. "grep -r "x-marc-schema" *" confirms no occurrences after patch. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 10:01:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 08:01:50 +0000 Subject: [Koha-bugs] [Bug 33328] x-marc-schema should be renamed x-record-schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33328 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Trivial improvement, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 10:10:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 08:10:55 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 10:10:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 08:10:58 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150100|0 |1 is obsolete| | Attachment #150101|0 |1 is obsolete| | Attachment #150102|0 |1 is obsolete| | Attachment #150239|0 |1 is obsolete| | Attachment #150293|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 150501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150501&action=edit Bug 32250: Linking authorities does not change holdability If the only change is a linked heading, we don't need to rebuild the holds queue To test: 1 - Set preference RealTimeHoldsQueue to enable 2 - Run link_bibs_to_authorities 3 - Note holds queue jobs generated 4 - Apply patch 5 - repeat 6 - No holds queue updates Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 10:11:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 08:11:01 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 --- Comment #18 from Jonathan Druart --- Created attachment 150502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150502&action=edit Bug 32250: Only reindex records when commiting This patch adds an array to catch updated bibs, and defers indexing until a batch of changes is committed To test: 1 - Set LinkerModule system preference to either first or last match Alternate this between runs of the linker to ensure changes are made 2 - Set SearchEngine to Elasticsearch and reindex (to ensure index is built) 3 - perl misc/link_bibs_to_authorities.pl -v 4 - Check Admin->Jobs and see that many ES index jobs are queued 5 - Apply patch 6 - perl misc/link_bibs_to_authorities.pl -v 7 - Check Admin->Jobs and see that 1 index per commit from is enqueued Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 10:11:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 08:11:04 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 --- Comment #19 from Jonathan Druart --- Created attachment 150503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150503&action=edit Bug 32250: (follow-up) Commit background job to the DB We can't run a background job if it isn't in the database, however, this script runs with AutoCommit disabled. We need to enable it while generating the background job, then disable for the updates. I don't nkow if using a transaction would be preferable. I tried to solve this independently, but it requires consolidating the index requests to make this work easily Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 10:11:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 08:11:07 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 --- Comment #20 from Jonathan Druart --- Created attachment 150504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150504&action=edit Bug 32250: (follow-up) Remove use of AutoCommit=0 This patch moves to using txn_begin and txn_commit Signed-off-by: Jonathan Druart Bug 32250: (follow-up) Remove one more dbh commit and don't start a new transaction when done Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 10:18:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 08:18:17 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #3 from Martin Renvoize --- This looks like a reasonably approach to me.. very minor wonder if whether the path is right.. /erm/config or whether it should be more generalised as /config/erm or /config?module=erm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 10:20:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 08:20:11 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #4 from Martin Renvoize --- On other minor wonder.. should we perhaps add a 'type' key.. so denote the config content type (yaml, csv, string etc).. Would that help in future for parsing the various different content we have in sysprefs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 10:21:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 08:21:03 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #12 from Jonathan Druart --- Created attachment 150505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150505&action=edit Bug 33491: Do not apply style to agreement list view We removed the 'scoped' attribute and so the style rules added in the previous patch were applied to the agreement list view. Why is 'scoped' not working is the main question here (?) but adding a more specific selector to aim only the component (AgreementsList) from the modal is a quick solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 10:21:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 08:21:29 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #13 from Jonathan Druart --- (In reply to Pedro Amorim from comment #11) > Created attachment 149924 [details] > comparison > > Top picture is the header in agreements list before the patch, bottom > picture is after the patch. > > This CSS in this patch is being applied in agreements list unintentionally. > > .filters input[type="checkbox"] { > margin-left: 0 !important; > } This patch is fixing the problem. Do you have something better to suggest? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 10:49:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 08:49:20 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue js files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Jonathan Druart --- See https://gitlab.com/koha-community/qa-test-tools/-/issues/66 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 10:58:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 08:58:15 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue .js and .ts files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Enforce formatting on vue |Enforce formatting on vue |js files |.js and .ts files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:04:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 09:04:31 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150498|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 150506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150506&action=edit Bug 33623: Encode URL params for getAll We must encode properly URL parameters when building the REST API routes Can be tested easily using const client = APIClient.erm client.licenses.getAll({ "me.name:%ff%" }) Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:04:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 09:04:33 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150499|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 150507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150507&action=edit Bug 33623: Move ULSearchParams into http-client.js Remove unused getAll methods in erm-api-client.js Make use of new getAll query in AgreementRelationships Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:04:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 09:04:53 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:06:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 09:06:09 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 --- Comment #11 from Martin Renvoize --- All working as expected in testing... Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:09:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 09:09:25 +0000 Subject: [Koha-bugs] [Bug 33353] Add compatibility with Elasticsearch 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33353 --- Comment #14 from David Liddle --- (In reply to Victor Grousset/tuxayo from comment #13) > After having this in main/master there will be the question of backporting > (now or later) to 22.11 which is the LTS. Because before the end of the LTS > it's likely that ES 7 won't be supported anymore. > > Here https://www.elastic.co/support/eol#elasticsearch > we can see that branch 7.x will be supported until 9.x comes out. > > There is no alpha version of 9.x for now, but when there will be, the stable > release can be expected 6 months later. (learned this in ES forums) So > people interested can keep an eye here: > https://github.com/elastic/elasticsearch/tags > for when the 1st 9.x alpha pops. > > Also, for OpenSearch, it's already planned that 1.x will reach end of life > before the end of 22.11's support. > https://opensearch.org/releases.html => "Maintenance Window End" => > "December 31, 2023" > > So what's the best strategy? (because it implies dropping 6.x support) > 1. backport now > 2. backport when/a bit before OpenSearch 1.x support ends (December 31, 2023) > 3. backport when/a bit before ElasticSearch 7.x support will have also > ended. (we don't know yet, it could be sooner than OS 1 or later) > 4. don't backport and require ES 7 or OS 1 Koha admins to keep an end of > life search engine or upgrade from the LTS. This bug caught my attention last week, and I have been watching with interest to see what responses there would be to Victor's question here. In the absence of any (so far), I would like to offer the perspective of a system administrator in the wild: - The cataloger for our consortium of small libraries has been itching to implement Elasticsearch for more than a year. - In examining the request, I was disconcerted by a few facts about Elasticsearch: 1. The version included by Koha appeared to be one that had reached end-of-life with the publisher, 2. Even the supported version had been associated with significant data breaches, and 3. There seemed to be a lack of clarity following the change in licensing and the open source world's response to it. - Given the above, there was no scenario in this corner of the multiverse in which I would have installed Elasticsearch on the internet-facing servers for which I was responsible. - HOWEVER, seeing OpenSearch on the horizon creates a new situation. Being well-supported by AWS, it has a chance of being a viable and safe alternative. - Our production server runs 22.05, BUT I can imagine a willingness to leap forward a bit if OpenSearch is backported to 22.11. - If that is indeed the future of more advanced indexing and searching, then it seems logical (to me) to backport it to an LTS release, if you have the resources to do so. Perhaps the question needs the attention of a broader or more representative forum, if you have one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:13:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 09:13:42 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue .js and .ts files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 --- Comment #2 from Jonathan Druart --- https://gitlab.com/koha-community/koha-testing-docker/-/issues/374 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:19:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 09:19:29 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue .js and .ts files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:19:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 09:19:32 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue .js and .ts files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 --- Comment #3 from Jonathan Druart --- Created attachment 150508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150508&action=edit Bug 33625: Add test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:19:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 09:19:35 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue .js and .ts files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 --- Comment #4 from Jonathan Druart --- Created attachment 150509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150509&action=edit Bug 33625: Pretty .js files for vue Test plan: = Koha = Apply the first patch, prove xt/vue_tidy.t and notice the failure Apply this patch, now it passes = QA test = Apply the change to the merge request linked with this qa-test-tools' issue: https://gitlab.com/koha-community/qa-test-tools/-/issues/62 inside your ktd container (at /kohadevbox/qa-test-tools/) Edit a .js within koha-tmpl/intranet-tmpl/prog/js/vue and a .ts file (cypress test) with something not pretty Commit and run the QA script => It's failing! Pretty the change, commit again, run the QA script => It's happy! = KTD - git hook = Go to the merge request linked with this ktd's issue: https://gitlab.com/koha-community/koha-testing-docker/-/issues/374 Copy the modified git hook to .git/hooks/ktd/pre-commit Edit a .js within koha-tmpl/intranet-tmpl/prog/js/vue and a .ts file (cypress test) with something not pretty Commit => Notice that the commit content is pretty! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:24:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 09:24:02 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 --- Comment #12 from Martin Renvoize --- The code looks like it introduces a behaviour change to me.. but maybe I'm just not entirely close enough to it. endpoint: "agreements?" + (query || "_per_page=-1"), vs endpoint: "agreements?" + new URLSearchParams({ _per_page: -1, ...(query && { q: JSON.stringify(query) }), }), To me, that looks like before now we let the query govern the paging whereas after we're always setting _per_page=-1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:31:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 09:31:07 +0000 Subject: [Koha-bugs] [Bug 33647] New: Display borrowers.lastseen Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Bug ID: 33647 Summary: Display borrowers.lastseen Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: klas.blomberg at skovde.se QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be nice if borrower.lastseen could be displayed at Patron details / Library use. Sometimes it gives a clue why a borrower who doesn't circulate anything is still active -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:31:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 09:31:21 +0000 Subject: [Koha-bugs] [Bug 32464] Koha::Item->as_marc_field obsolete option mss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32464 --- Comment #12 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #11) > I loved my first implementation performance. Don't remember why it was > removed. I would have kept it, as it was an optional parameter, to be used > where it makes sense. > > mss stands for 'marc subfield structure'. It is named like that everywhere > as far as I can tell. I am not expecting any significant performance gains passing a hashref that is actually retrieved from the cache (and 'unsafe' is used here). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:46:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 09:46:04 +0000 Subject: [Koha-bugs] [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 --- Comment #10 from Jonathan Druart --- The only thing I am seeing here is that we are passing the suggestion to generate the letter without the one from the DB (we don't get_from_storage). For now the downside is that suggestion.date won't be filled in with the default timestamp, but that should not be a problem. No idea if it's better to add a fetch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:47:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 09:47:15 +0000 Subject: [Koha-bugs] [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 --- Comment #11 from Jonathan Druart --- ha, you forgot the use statements for C4::Context and C4::Letters from Koha::Suggestion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 11:53:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 09:53:10 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #95 from Jonathan Druart --- (In reply to Martin Renvoize from comment #94) > RM note.. the QA tool threw two issues.. POD coverage which is a false > positive here I believe and a permissions issue.. but the permissions all > look correct to me.. not sure what's going on there. FAIL t/db_dependent/Koha/AdditionalField.pm FAIL file permissions File must not have the exec flag Well, this is valid: -rwxr-xr-x 1 jonathan jonathan 2506 mai 2 11:51 t/db_dependent/Koha/AdditionalField.pm Actually I guess it should be renamed to .t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:15:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 10:15:15 +0000 Subject: [Koha-bugs] [Bug 33629] allow pbuilder to use network via build-git-snapshot In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33629 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |blocker Priority|P5 - low |P1 - high --- Comment #4 from Mason James --- (In reply to Kyle M Hall from comment #3) > Moving directly to PQA. bump to blocker, to fix failing package builds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:18:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 10:18:59 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 --- Comment #13 from Jonathan Druart --- Yes you are correct, but it was not used. We should actually allow the callers to pass more options. Like embed, for a follow-up bug I need to retrieve the items with the biblio info. I wont add "embed: biblio" to items.getAll(), but allow the caller to ask for it. It should to be done when we will need it (unless I missed something). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:28:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 10:28:57 +0000 Subject: [Koha-bugs] [Bug 32748] Library limitations will cause data loss when editing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32748 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com --- Comment #13 from mathieu saby --- Hi We asked Biblibre to fix that bug a few monthes ago so I would like to add some comments from a librarian point of view. I am not completely sure of the predicted behavior of the patch, but please consider this situation : We have 2 libraries: - the library A has only 2 locations LOCA-1 and LOCA-2 - the library B has only 2 locations LOCB-1 and LOCB-2. An item's homebranch is library A, location LOCA-1. The librarian is connected to library B The location LOCA-1 should be preserved when the librarian edits the item in order to change an other item field. But he must not be allowed to change the location to LOCB-1 or LOCB-2. It would result in a data inconsistency because those location are not valid for Library A. Is it the behavior you are planning ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:38:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 10:38:16 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize --- OK, that makes sense to me.. upgrading my signoff to a PQA stamp. Thanks for the clarifications Jonathan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:44:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 10:44:07 +0000 Subject: [Koha-bugs] [Bug 8589] Advanced Search for itemtype and location produces some results that are not useful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8589 --- Comment #8 from Ray Delahunty --- Is there any way this problem can be fixed? It causes us lots of problems as we are a quite complex multi-site setup with collections at various college libraries, with some cataloguing policy variances across colleges that makes the 'not useful' results count sometime horridly high. We really need searches across the three ‘tiles’ of the Advanced Search (keyword area at the top, the tabs area in the middle, and the limits across the bottom) to work ‘correctly’. If you look at our OAPC https://libsearch.arts.ac.uk/cgi-bin/koha/opac-search.pl you can see we are having to add multiple ‘special collection’ searches (at CSM and LCF colleges for now, more wanted) but even that isn’t perfect. We should be able to have Special Collections in the tab area and the library limit at the bottom working together and not giving results that are not useful, as many currently are. Even searching on all special collections and then limiting by facets (homebranch) doesn’t work properly either as ‘not useful’ results are included that way too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:53:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 10:53:05 +0000 Subject: [Koha-bugs] [Bug 33030] Add standardized subroutine for processing Template Toolkit syntax outside of notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Kyle M Hall --- (In reply to David Nind from comment #4) > The tests currently fail: > > prove t/db_dependent/Koha/Items.t They are passing for me! Did you apply the dependency (Bug 33039) beforehand and run updatedatabase.pl? I get your error if I have applied both bugs but don't run updatedatabase.pl before running the unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:58:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 10:58:41 +0000 Subject: [Koha-bugs] [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 --- Comment #12 from Nick Clemens --- Created attachment 150510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150510&action=edit Bug 33236: (follow-up) Add use statements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:59:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 10:59:25 +0000 Subject: [Koha-bugs] [Bug 32464] Koha::Item->as_marc_field obsolete option mss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32464 --- Comment #13 from Nick Clemens --- (In reply to Jonathan Druart from comment #12) > (In reply to Tomás Cohen Arazi from comment #11) > > I loved my first implementation performance. Don't remember why it was > > removed. I would have kept it, as it was an optional parameter, to be used > > where it makes sense. > > > > mss stands for 'marc subfield structure'. It is named like that everywhere > > as far as I can tell. > > I am not expecting any significant performance gains passing a hashref that > is actually retrieved from the cache (and 'unsafe' is used here). See comment 5, please test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 12:59:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 10:59:40 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #16 from Katrin Fischer --- (In reply to David Cook from comment #15) > (In reply to Katrin Fischer from comment #14) > > Not only for our use case - currently it's not possible to set different > > timeouts even if you are using different sub domains which divides the > > sessions. > > I'm not 100% sure I understand what you're saying. > > Different subdomains have different cookies, but in Koha there is only the > "timeout" syspref. Is that what you mean? Yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:06:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 11:06:05 +0000 Subject: [Koha-bugs] [Bug 33030] Add standardized subroutine for processing Template Toolkit syntax outside of notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:06:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 11:06:07 +0000 Subject: [Koha-bugs] [Bug 33030] Add standardized subroutine for processing Template Toolkit syntax outside of notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147182|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 150511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150511&action=edit Bug 33030: Add standardized subroutine for processing Template Toolkit syntax outside of notices Koha has evolved to use Template Toolkit for many uses outside of generating slips and notices for patrons. Historically, each of these areas processed template toolkit in a slightly different way. We should add a module to allow Template Toolkit syntax to be processed in a standard and generic way such that all non-notice TT syntax is handled and processed the consistently. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Items.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:06:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 11:06:10 +0000 Subject: [Koha-bugs] [Bug 33030] Add standardized subroutine for processing Template Toolkit syntax outside of notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148076|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 150512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150512&action=edit Bug 33030: Add unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:07:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 11:07:04 +0000 Subject: [Koha-bugs] [Bug 33030] Add standardized subroutine for processing Template Toolkit syntax outside of notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 --- Comment #8 from David Nind --- (In reply to Kyle M Hall from comment #5) > (In reply to David Nind from comment #4) > > The tests currently fail: > > > > prove t/db_dependent/Koha/Items.t > > They are passing for me! Did you apply the dependency (Bug 33039) beforehand > and run updatedatabase.pl? I get your error if I have applied both bugs but > don't run updatedatabase.pl before running the unit tests. It works with the updatedatabase - now signed off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:07:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 11:07:27 +0000 Subject: [Koha-bugs] [Bug 33554] searching borrowers is a lot slower if there's searchable extended attributes. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554 --- Comment #2 from Didier Gautheron --- (In reply to Nick Clemens from comment #1) > An index on those tables might help - we saw similar issues on a site with > many borrowers. In my understanding these tables are already fully indexed. I did play with indexes' statistics but got no improvement. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:07:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 11:07:30 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue .js and .ts files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150508|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 150513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150513&action=edit Bug 33625: Add test Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:07:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 11:07:34 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue .js and .ts files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150509|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 150514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150514&action=edit Bug 33625: Pretty .js files for vue Test plan: = Koha = Apply the first patch, prove xt/vue_tidy.t and notice the failure Apply this patch, now it passes = QA test = Apply the change to the merge request linked with this qa-test-tools' issue: https://gitlab.com/koha-community/qa-test-tools/-/issues/62 inside your ktd container (at /kohadevbox/qa-test-tools/) Edit a .js within koha-tmpl/intranet-tmpl/prog/js/vue and a .ts file (cypress test) with something not pretty Commit and run the QA script => It's failing! Pretty the change, commit again, run the QA script => It's happy! = KTD - git hook = Go to the merge request linked with this ktd's issue: https://gitlab.com/koha-community/koha-testing-docker/-/issues/374 Copy the modified git hook to .git/hooks/ktd/pre-commit Edit a .js within koha-tmpl/intranet-tmpl/prog/js/vue and a .ts file (cypress test) with something not pretty Commit => Notice that the commit content is pretty! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:07:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 11:07:51 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue .js and .ts files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:08:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 11:08:19 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue .js and .ts files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- Straight to QA.. all working and a good improvement as per other bugs of a similar nature. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:08:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 11:08:35 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue .js and .ts files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:12:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 11:12:06 +0000 Subject: [Koha-bugs] [Bug 33041] Use process_tt in C4::Serial::NewIssue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33041 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:12:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 11:12:08 +0000 Subject: [Koha-bugs] [Bug 33041] Use process_tt in C4::Serial::NewIssue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33041 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147175|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 150515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150515&action=edit Bug 33041: Use process_tt in C4::Serial::NewIssue Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in C4::Serial::NewIssue Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Items.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:13:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 11:13:27 +0000 Subject: [Koha-bugs] [Bug 33041] Use process_tt in C4::Serial::NewIssue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33041 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (using KTD): 1. After applying the patch and dependencies, run updatedatabase (for 33039). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:45:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 11:45:26 +0000 Subject: [Koha-bugs] [Bug 32464] Koha::Item->as_marc_field obsolete option mss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32464 --- Comment #14 from Jonathan Druart --- (In reply to Nick Clemens from comment #13) > See comment 5, please test What/how did you test? What I've done: Add 1000 items to biblio 1 use t::lib::TestBuilder; my $b = t::lib::TestBuilder->new; for (1..1000){ $b->build_sample_item({biblionumber => 1}); } time that: use Modern::Perl; use Koha::Biblios; use Koha::Patrons; my $biblio = Koha::Biblios->find(1); my $patron = Koha::Patrons->find(51); my $items = $biblio->items->filter_by_visible_in_opac({ patron => $patron }); my $record = $biblio->metadata->record; my $record_processor = Koha::RecordProcessor->new({ filters => [ 'EmbedItems', 'ViewPolicy' ], options => { interface => 'opac', frameworkcode => $biblio->frameworkcode, items => [ $items->as_list ], } }); With this change: diff --git a/Koha/Item.pm b/Koha/Item.pm index 7251a8a094f..c1e948f0795 100644 --- a/Koha/Item.pm +++ b/Koha/Item.pm @@ -939,16 +939,14 @@ with the current mappings configuration. =cut sub as_marc_field { - my ( $self ) = @_; - - my ( $itemtag, $itemtagsubfield) = C4::Biblio::GetMarcFromKohaField( "items.itemnumber" ); + my ( $self, $params ) = @_; - my $tagslib = C4::Biblio::GetMarcStructure( 1, $self->biblio->frameworkcode, { unsafe => 1 }); + my $mss = $params->{mss} // C4::Biblio::GetMarcSubfieldStructure( '', { unsafe => 1 } ); + #my $mss = C4::Biblio::GetMarcSubfieldStructure( '', { unsafe => 1 } ); + my $itemtag = $mss->{'items.itemnumber'}[0]->{tagfield}; + my $item_field = $mss->{$itemtag}; my @subfields; - - my $item_field = $tagslib->{$itemtag}; - my $more_subfields = $self->additional_attributes->to_hashref; foreach my $subfield ( sort { Switching the 'my $mss' line. No difference noted (script takes ~4.5sec). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:45:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 11:45:36 +0000 Subject: [Koha-bugs] [Bug 32748] Library limitations will cause data loss when editing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32748 --- Comment #14 from Michaela Sieber --- (In reply to mathieu saby from comment #13) > Hi > We asked Biblibre to fix that bug a few monthes ago so I would like to add > some comments from a librarian point of view. > > I am not completely sure of the predicted behavior of the patch, but please > consider this situation : > We have 2 libraries: > - the library A has only 2 locations LOCA-1 and LOCA-2 > - the library B has only 2 locations LOCB-1 and LOCB-2. > An item's homebranch is library A, location LOCA-1. > The librarian is connected to library B > > The location LOCA-1 should be preserved when the librarian edits the item in > order to change an other item field. > But he must not be allowed to change the location to LOCB-1 or LOCB-2. It > would result in a data inconsistency because those location are not valid > for Library A. > > Is it the behavior you are planning ? Hi Mathieu, these patches are for preventing data loss! Problem TODAY : If a librarian connected to library B is editing for example the item call number of an item with homebranch library A he will not be able to see the value location LOCA-1. Saving the item record will result in data loss because the empty location field in the item form overwrites the existing value LOCA-1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:51:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 11:51:37 +0000 Subject: [Koha-bugs] [Bug 33030] Add standardized subroutine for processing Template Toolkit syntax outside of notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 --- Comment #9 from Kyle M Hall --- > It works with the updatedatabase - now signed off! Thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 13:58:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 11:58:17 +0000 Subject: [Koha-bugs] [Bug 33648] New: Errors when enabling ERM in 22.11 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33648 Bug ID: 33648 Summary: Errors when enabling ERM in 22.11 Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: nick at bywatersolutions.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, matt.blenkinsop at ptfs-europe.com, pedro.amorim at ptfs-europe.com To recreate: 1 - Enable ERM 2 - View Agreements page: Uncaught (in promise) ReferenceError: logged_in_user is not defined 3 - Click on Licenses Uncaught (in promise) TypeError: node is null -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 14:12:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 12:12:13 +0000 Subject: [Koha-bugs] [Bug 33043] Use process_tt in SIP modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33043 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 14:12:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 12:12:15 +0000 Subject: [Koha-bugs] [Bug 33043] Use process_tt in SIP modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33043 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147180|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 150516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150516&action=edit Bug 33043: Use process_tt in SIP modules Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in the various parts of the SIP server code where we are currently using Template::process directly. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 14:16:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 12:16:46 +0000 Subject: [Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #17 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #14) > (In reply to Jonathan Druart from comment #9) > > Let push and see how it goes? > > This was more than 2 months ago, to have time to fix before the release. Now > we are few weeks before the release. Why did we have wait so much time to > push it? I was willing to push it once I noticed it existed, but it already needed a rebase. I guess we've been busy with other things... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 14:20:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 12:20:33 +0000 Subject: [Koha-bugs] [Bug 33648] Errors when enabling ERM in 22.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33648 --- Comment #1 from Jonathan Druart --- Wrong resolution conflict on AgreementsList.vue in commit Bug 32991: Improve our Dialog component in master logged_in_user, + setWarning, + setMessage, in 22.11.x + logged_in_user, + setWarning, + setMessage, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 14:38:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 12:38:09 +0000 Subject: [Koha-bugs] [Bug 32464] Koha::Item->as_marc_field obsolete option mss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32464 --- Comment #15 from Nick Clemens --- (In reply to Jonathan Druart from comment #14) > (In reply to Nick Clemens from comment #13) > > See comment 5, please test > > What/how did you test? > Fortunately, I still had the script I used, it seems we have improved things though, I get much smaller results: Rate noPassMSS passMSS noPassMSS 14088/s -- -14% passMSS 16373/s 16% -- #!/usr/bin/env perl use strict; use warnings; use Benchmark qw/cmpthese timethese/; use Koha::Biblios; my $biblio = Koha::Biblios->find( 25 ); my $record = $biblio->metadata->record; my @items = $biblio->items->as_list; my $record_processor = Koha::RecordProcessor->new({ filters => ['EmbedItems'], options => { interface => 'opac', items => \@items } }); cmpthese( -10, { noPassMSS => sub { $record_processor->process( $record, 0); }, passMSS => sub { $record_processor->process( $record, 1); }, } ); Diff: diff --git a/Koha/Filter/MARC/EmbedItems.pm b/Koha/Filter/MARC/EmbedItems.pm index 2839694ff8..7401c3ebb9 100644 --- a/Koha/Filter/MARC/EmbedItems.pm +++ b/Koha/Filter/MARC/EmbedItems.pm @@ -67,6 +67,7 @@ Embed items into the MARC::Record object. sub filter { my $self = shift; my $record = shift; + my $pass_mss = shift; return unless defined $record and ref($record) eq 'MARC::Record'; @@ -76,6 +77,8 @@ sub filter { my @item_fields; + $mss = undef unless $pass_mss; + foreach my $item ( @{$items} ) { push @item_fields, $item->as_marc_field( { mss => $mss } ); } diff --git a/Koha/Item.pm b/Koha/Item.pm index 7251a8a094..f4e701bd58 100644 --- a/Koha/Item.pm +++ b/Koha/Item.pm @@ -939,15 +939,15 @@ with the current mappings configuration. =cut sub as_marc_field { - my ( $self ) = @_; + my ( $self, $params ) = @_; my ( $itemtag, $itemtagsubfield) = C4::Biblio::GetMarcFromKohaField( "items.itemnumber" ); - my $tagslib = C4::Biblio::GetMarcStructure( 1, $self->biblio->frameworkcode, { unsafe => 1 }); + my $mss = $params->{mss} // C4::Biblio::GetMarcSubfieldStructure( '', { unsafe => 1 } ); my @subfields; - my $item_field = $tagslib->{$itemtag}; + my $item_field = $mss->{$itemtag}; my $more_subfields = $self->additional_attributes->to_hashref; foreach my $subfield ( diff --git a/Koha/RecordProcessor.pm b/Koha/RecordProcessor.pm index ec7cbea0ca..fff2e7810a 100644 --- a/Koha/RecordProcessor.pm +++ b/Koha/RecordProcessor.pm @@ -172,12 +172,13 @@ return value will be of the same type. sub process { my $self = shift; my $record = shift || $self->record; + my $pass_mss = shift; return unless defined $record; foreach my $filterobj (@{$self->filters}) { next unless $filterobj; - $filterobj->filter($record); + $filterobj->filter($record, $pass_mss); } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 14:43:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 12:43:52 +0000 Subject: [Koha-bugs] [Bug 30002] Add project-level perltidyrc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 --- Comment #18 from Jonathan Druart --- Created attachment 150517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150517&action=edit Bug 30002: Adjust perltidy Remove the following 3 options that are not available in perltidy v20190601 that is the version shipped with bullseye --add-terminal-newline --valign-exclusion-list --extended-continuation-indentation Extend max line length --maximum-line-length=120 Prevent perltidy to format lists (see bug 30002 comment 10) --break-at-old-comma-breakpoints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 14:46:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 12:46:36 +0000 Subject: [Koha-bugs] [Bug 30002] Add project-level perltidyrc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #19 from Jonathan Druart --- We could eventually go with this version, merge the QA checks, and see how it goes. Given that we are not doing a tidy on the whole codebase we could refine it later if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 14:46:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 12:46:49 +0000 Subject: [Koha-bugs] [Bug 30002] Add project-level perltidyrc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 14:48:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 12:48:00 +0000 Subject: [Koha-bugs] [Bug 30002] Add project-level perltidyrc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 --- Comment #20 from Jonathan Druart --- There are some parts that are uglier than before, for instance the following block in Koha/Patron.pm 335 if ( C4::Context->preference("BorrowersLog") ) { But globally it's nicer! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 15:05:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 13:05:12 +0000 Subject: [Koha-bugs] [Bug 30002] Add project-level perltidyrc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 --- Comment #21 from Julian Maurice --- (In reply to Jonathan Druart from comment #18) > Remove the following 3 options that are not available in perltidy > v20190601 that is the version shipped with bullseye > --add-terminal-newline > --valign-exclusion-list > --extended-continuation-indentation That's something I haven't considered : different versions of perltidy will generate different code. For instance, vertical alignment of qw() after use is on by default since v20220613. Should we force usage of a specific version then ? Maybe add a version check in the QA scripts too. Also, since it's a developer-only tool, do we need to restrict ourselves to an old version ? (P.S. That doesn't change anything, but bullseye's version of perltidy is v20200110, not v20190601) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 15:14:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 13:14:28 +0000 Subject: [Koha-bugs] [Bug 33649] New: Fix use of cronlogaction in process_message_queue.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Bug ID: 33649 Summary: Fix use of cronlogaction in process_message_queue.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org process_message_queue.pl has this code: try { $script_handler->lock_exec; } catch { my $message = "Skipping execution of $0 ($_)"; print STDERR "$message\n" if $verbose; cronlogaction( $message ); exit; }; If lock_exec fails for some reason, we get this error: $ sudo koha-foreach --chdir --enabled --email /usr/share/koha/bin/cronjobs/process_message_queue.pl Can't use string ("Skipping execution of /usr/share"...) as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Log.pm line 135. mykoha: 13 status returned by "/usr/share/koha/bin/cronjobs/process_message_queue.pl" This is because cronlogaction should be called like this: cronlogaction({ info => $message }) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 15:14:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 13:14:35 +0000 Subject: [Koha-bugs] [Bug 33649] Fix use of cronlogaction in process_message_queue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |magnus at libriotech.no |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 15:28:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 13:28:53 +0000 Subject: [Koha-bugs] [Bug 32752] Add new serial issue status: "Out for binding", "Bound", and "Circulating" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32752 Maude changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maude.boudreau at collecto.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 15:31:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 13:31:17 +0000 Subject: [Koha-bugs] [Bug 29904] Serials: Clear 'Automatically set to late' when changing status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29904 Maude changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maude.boudreau at collecto.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 15:33:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 13:33:54 +0000 Subject: [Koha-bugs] [Bug 32464] Koha::Item->as_marc_field obsolete option mss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32464 --- Comment #16 from Jonathan Druart --- (In reply to Nick Clemens from comment #15) > (In reply to Jonathan Druart from comment #14) > > (In reply to Nick Clemens from comment #13) > > > See comment 5, please test > > > > What/how did you test? > > > > Fortunately, I still had the script I used, it seems we have improved things > though, I get much smaller results: > Rate noPassMSS passMSS > noPassMSS 14088/s -- -14% > passMSS 16373/s 16% -- Yes, I don't think 15% is significant here. I prefer to believe that retrieving from the cache is the best we can do (and keep the code tidy), instead of passing around something we have cached. From how many items this will be useful? If you want to improve that (from 15 to 7%), you could use the memory cache that would use the regular cache to populate itself. Bug if you are really chasing performance then help the big things (like 33568?) and you should see a real gain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 15:40:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 13:40:06 +0000 Subject: [Koha-bugs] [Bug 30002] Add project-level perltidyrc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 --- Comment #22 from Jonathan Druart --- (In reply to Julian Maurice from comment #21) > (P.S. That doesn't change anything, but bullseye's version of perltidy is > v20200110, not v20190601) Indeed, it was on Ubuntu 20.04! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 15:46:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 13:46:03 +0000 Subject: [Koha-bugs] [Bug 33465] Make it clear if there are linked licenses when viewing the vendor record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33465 --- Comment #1 from Jonathan Druart --- >From bug 33106 comment 11 """ (In reply to Jonathan Field from comment #9) > That works now, thanks for fixing that! I still think it would be good to > not display the link if there is no attached record but I think we can deal > with that in a separate bugzilla entry, this works as planned. I am not sure about that. The other tabs are there even if there is nothing on the view (for baskets). If we add another tab later (for issues for instance), it will be placed differently depending on the existence of license linked to the vendor, that does not seem correct to me. We could add the number of licenses in parenthesis but again, it is inconsistent with the other tabs. So basically, yes, we should discuss that on a separate bug :) """ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 15:50:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 13:50:51 +0000 Subject: [Koha-bugs] [Bug 33650] New: Auto sort MARC tags in numeric order when saving the record Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33650 Bug ID: 33650 Summary: Auto sort MARC tags in numeric order when saving the record Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: iming at rosewoodfarm.com.au QA Contact: testopia at bugs.koha-community.org Sometimes during cataloguing we may not have entered the tags in the correct numeric order. For example: 520 _ _ $... 500 _ _ $... 504 _ _ $... So it will be nice that when saving the record, MARC tags can be auto sort into the correct numeric order, like: 500 _ _ $... 504 _ _ $... 520 _ _ $... Currently, you can correct this issue by saving the record in basic editing mode. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 15:52:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 13:52:38 +0000 Subject: [Koha-bugs] [Bug 33650] Auto sort MARC tags in numeric order when saving the record in advanced editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33650 Iming Chan changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Auto sort MARC tags in |Auto sort MARC tags in |numeric order when saving |numeric order when saving |the record |the record in advanced | |editor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 15:57:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 13:57:57 +0000 Subject: [Koha-bugs] [Bug 33651] New: Separate user permissions for tools/batchMod.pl versus tools/automatic_item_modification_by_age.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33651 Bug ID: 33651 Summary: Separate user permissions for tools/batchMod.pl versus tools/automatic_item_modification_by_age.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: emily.lamancusa at montgomerycountymd.gov QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The user permission items_batchmod gives access to both the batch item modification tool, and the configuration page for batch item modification by age rules. Even if items_batchmod_restricted is also checked, the user has unrestricted access to the batch modification by age rules. We need all staff to have at least restricted access to the batch item modification tool, but the batch item modification by age rules should only be accessible to whoever is responsible for configuring them (in our case, superlibrarians only). There should be a separate permission specifically for access to configure the item modification by age rules. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:05:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:05:22 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150505|0 |1 is obsolete| | --- Comment #14 from Pedro Amorim --- Created attachment 150518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150518&action=edit Bug 33491: Do not apply style to agreement list view We removed the 'scoped' attribute and so the style rules added in the previous patch were applied to the agreement list view. Why is 'scoped' not working is the main question here (?) but adding a more specific selector to aim only the component (AgreementsList) from the modal is a quick solution. Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:07:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:07:56 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:07:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:07:58 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150463|0 |1 is obsolete| | Attachment #150464|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 150519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150519&action=edit Bug 33611: Unit test Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:08:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:08:01 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 --- Comment #8 from Jonathan Druart --- Created attachment 150520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150520&action=edit Bug 33611: Ensure dt_from_string always returns a new object This patch alters dt_from_string to pass a cloned object if called on an existing date time object This resolves an issue where a holds reserve date was being altered when the default expiration date was set To test: 1 - Set DefaultHoldExpiration to Set 2 - Set DefaultHoldExpirationPeriod to 365 3 - Set DefaultHoldExpirationunitOfTimeToDays 4 - Place a hold 5 - Note reserve date is 1 year in the future, same as expiration 6 - Apply patch 7 - Restart all 8 - Place another hold 9 - Note reserve date is set to today Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:11:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:11:52 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #16 from Jonathan Druart --- the remove span is really not future proof. What if you add an other tag to the include? You need another PROCESS that would return the translated restriction type from a given code. It will be used from the existing include, and from your -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:23:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:23:31 +0000 Subject: [Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off In-Reply-To: <bug-31722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31722-70-qQRCOMr5NE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:24:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:24:23 +0000 Subject: [Koha-bugs] [Bug 33367] tmp/modified_authorities/README.txt seems useless In-Reply-To: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33367-70-U5yqtPs09Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33367 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:24:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:24:51 +0000 Subject: [Koha-bugs] [Bug 32807] No need to fetch all if we need to know if one exist In-Reply-To: <bug-32807-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32807-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32807-70-9TMYaXF7Rj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:25:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:25:07 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-cuYA6ABM9q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- > Why is 'scoped' not working is the main question here As Pedro pointed to me, it is actually working as expected: style rules are defined in EHoldingsEBSCOPackageAgreements and the table is in AgreementList. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:25:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:25:20 +0000 Subject: [Koha-bugs] [Bug 32964] OPACResultsMaxItemsUnavailable description is misleading In-Reply-To: <bug-32964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32964-70-tuNYjnTKTP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:28:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:28:08 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33335-70-unZX4GvAu6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150521&action=edit Bug 33335: Use To.json to serialize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:29:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:29:00 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33335-70-PQ73s2HdFq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Why did you remove '*'? Also the indentation is not preserved. Attached a patch, feel free to drop it if you disagree with it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:31:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:31:34 +0000 Subject: [Koha-bugs] [Bug 31409] Set focus for cursor to Fund code when adding a new fund In-Reply-To: <bug-31409-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31409-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31409-70-tJ3DfMMeom@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31409 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:31:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:31:46 +0000 Subject: [Koha-bugs] [Bug 32003] Accessibility: Order search results has two h1 headings In-Reply-To: <bug-32003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32003-70-eTkvaRvJ7X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:31:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:31:52 +0000 Subject: [Koha-bugs] [Bug 32003] Accessibility: Order search results has two h1 headings In-Reply-To: <bug-32003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32003-70-wpwHnArZOz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:32:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:32:03 +0000 Subject: [Koha-bugs] [Bug 32217] Typo: Error authenticating in external provider In-Reply-To: <bug-32217-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32217-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32217-70-9GPmwP4pyg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32217 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:32:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:32:17 +0000 Subject: [Koha-bugs] [Bug 32771] Standardize structure around action fieldsets in serials In-Reply-To: <bug-32771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32771-70-CzGYalO9fA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:32:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:32:31 +0000 Subject: [Koha-bugs] [Bug 32945] Capitalization: id (part 2) In-Reply-To: <bug-32945-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32945-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32945-70-724I2docUV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:32:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:32:41 +0000 Subject: [Koha-bugs] [Bug 32954] Standardize action fieldsets in rotating collections, suggestions, tools In-Reply-To: <bug-32954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32954-70-2XkIdUpvRJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:32:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:32:50 +0000 Subject: [Koha-bugs] [Bug 32955] Standardize structure around action fieldsets in various templates In-Reply-To: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32955-70-6KTOdeuwS4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32955 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:33:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:33:00 +0000 Subject: [Koha-bugs] [Bug 32956] Use template wrapper for HTML customizations tabs In-Reply-To: <bug-32956-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32956-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32956-70-W7txe9x48c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32956 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:33:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:33:13 +0000 Subject: [Koha-bugs] [Bug 32969] Remove references to jQueryUI assets and style in the OPAC In-Reply-To: <bug-32969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32969-70-vaTI9hhvxO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:33:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:33:26 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33005-70-IJrYTyPxcC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:33:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:33:40 +0000 Subject: [Koha-bugs] [Bug 33129] Use template wrapper for breadcrumbs: Administration part 6 In-Reply-To: <bug-33129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33129-70-3UO65Sv74i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:33:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:33:55 +0000 Subject: [Koha-bugs] [Bug 33181] Use template wrapper for tabs on record merge pages In-Reply-To: <bug-33181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33181-70-BEmpYhHWwH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:34:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:34:09 +0000 Subject: [Koha-bugs] [Bug 33187] Use template wrapper for tabs article requests and holds awaiting pickup pages In-Reply-To: <bug-33187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33187-70-w1XXBsuhU8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33187 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:34:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:34:24 +0000 Subject: [Koha-bugs] [Bug 33651] Separate user permissions for tools/batchMod.pl versus tools/automatic_item_modification_by_age.pl In-Reply-To: <bug-33651-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33651-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33651-70-uMz344Hts1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33651 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:43:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:43:16 +0000 Subject: [Koha-bugs] [Bug 33290] Incorrect variable used in http-client.js In-Reply-To: <bug-33290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33290-70-sCpUZEGFLt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |ERM |and plumbing | CC| |jonathan.druart+koha at gmail. | |com, | |jonathan.field at ptfs-europe. | |com, | |martin.renvoize at ptfs-europe | |.com, | |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 16:52:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 14:52:45 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-yqzE8FJJr1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #1) > Hi Marcel, can you explain this a bit more? Is this about logging when an > item's lost status is lifted? Hi Katrin. Yes, this is about logging the switch to/from a lost status. We can currently retrieve info about setting to lost with the lost date in items, but we cannot see (easier) when we recovered a book and lifted the lost status within a given period. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:28:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 15:28:40 +0000 Subject: [Koha-bugs] [Bug 29522] Bib record not correctly updated when merging identical authorities with LinkerModule set to First Match In-Reply-To: <bug-29522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29522-70-kjBMACEaac@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29522 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I managed to recreate this on master. Here are my system preferences: - AutoCreateAuthorities = don't generate - RequireChoosingExistingAuthority = don't require - AutoLinkBiblios = Do - CatalogModuleRelink = Do - LinkerKeepStale = Don't - LinkerModule = first match - LinkerRelink = Do I use Elasticsearch with default mappings. Here is my complete test plan. 1. Create an authority record 1.1. Go to Authorities 1.2. Click on "New authority" and choose an authority type (I chose Corporate name)* 1.3. Fill in the mandatory fields (000, 003, 005, 008, 040$c) 1.4. In tab 1, click on the label of the main heading (110 for Corporate name) 1.5. Fill in subfield $a 1.6. Copy content of subfield $a 1.7. Click on "Save" 1.8. Note the authority record number 2. Duplicate the authority record 2.1. Click on "Edit" and choose "Edit as new (duplicate)" 2.2. Click on "Save" 2.3. Click on "No: Save as new authority" 2.4. Note the authority record number (should be the number from step 1.8 +1) 3. Link one of the authority records to a bibliographic record 3.1 In another tab, do a catalog search 3.2. Click on "Edit record" under one of the search results 3.3. Go to the relevant tab (for corporate name, I used field 710 in tab 7) 3.3.a. If there are no empty fields for that tag, click the "Repeat this tag" button (two rectangles) 3.4. Paste the text previously copied in subfield $a 3.5. Click on "Link authorities automatically" at the top of the page 3.6. Note the authority record number in subfield $9 --> The linked authority record should be the first authority record (step 1.8) 3.7. Click on "Save" 4. Merge the two authority records, keep the one that is not linked to the bibliographic record 4.1. Go back to the tab with the authorities 4.2. Click on "Actions" and choose "Merge" for both records  4.3. Select the record number that is NOT linked to the bibliographic record (should be the one already selected) 4.4. Click on "Next" 4.5. Click on "Merge" 5. Check the bibliographic record 5.1. Go back to the tab with the bibliographic record and refresh the page (Ctrl+F5) 5.2. Hover the mouse cursor over the name or term, without clicking 5.3. Note the record number that appears at the bottom of the screen --> The record number was not changed I also tried to run merge_authorities, without success. *I have found the linker doesn't seem to work in 6XX fields, so for this test plan, choose something that can go in 7XX (personal name, corporate name, or meeting name) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:43:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 15:43:17 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-rxbzhI5yTM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #16) > the remove span is really not future proof. What if you add an other tag to > the include? I agree it's not the prettiest fix, but we already use it in another spot. The span in this case was added to aid translations. Maybe we could add a note to the PROCESS for now? I could also file a separate bug for a 'no span' option. > You need another PROCESS that would return the translated restriction type > from a given code. It will be used from the existing include, and from your > <title> Sorry, I read it three times, but still not get it :( Can you explain? Happy to file it as a new bug, but it might not be for me right now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:53:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 15:53:08 +0000 Subject: [Koha-bugs] [Bug 33652] New: Always show datatable column filters at the top instead of the bottom of the table Message-ID: <bug-33652-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33652 Bug ID: 33652 Summary: Always show datatable column filters at the top instead of the bottom of the table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There are some tables, where the filters are only at the bottom of the table, which is not great usability. If a table is long enough for you to want to filter it, it would be more practical to have the filters on top. It also would make sense to always have them in the same spot. Tables with filters at the bottom: * Serials > claims * Serials > List of subscriptions Table with filters on top: * Catalog > detail page > item table * Patron search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 17:53:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 15:53:08 +0000 Subject: [Koha-bugs] [Bug 33332] Fix formatting of TT comments to improve translations In-Reply-To: <bug-33332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33332-70-EONzDa2qLP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33652 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:07:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 16:07:02 +0000 Subject: [Koha-bugs] [Bug 33653] New: Search for late orders can show received order lines Message-ID: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Bug ID: 33653 Summary: Search for late orders can show received order lines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org In some circumstances the list of late orders will show orders that have already been completed/fully received. As their is no indication in the list that they have been received, they might get accidentally claimed. Late orders should never include order lines that have been received. To test: * Create a basket * Create a normal order (not from a subscription, no standing order) * Leave estimated delivery date empty * Close the basket * Create a new invoice and receive the order line * Go to acq > late orders * Verify the order is not in the list * Set filter for 'To' date into the future, i.e. 01/01/2025 * Verify the order shows up now -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:07:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 16:07:32 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-obzVH998I1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:13:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 16:13:56 +0000 Subject: [Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30280-70-AAQ0Hd4pS4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Blocks| |33277, 33557 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 [Bug 33277] Correctly handle linking subfields with no defined thesaurus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:13:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 16:13:56 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-wWVCHrEBu1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30280 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 [Bug 30280] Support authority records with common subject headings from different thesaurus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:13:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 16:13:56 +0000 Subject: [Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking In-Reply-To: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33557-70-k4HUJRExyK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30280 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 [Bug 30280] Support authority records with common subject headings from different thesaurus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:18:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 16:18:08 +0000 Subject: [Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6 In-Reply-To: <bug-32910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32910-70-7wtM3M6Ipr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #18 from Owen Leonard <oleonard at myacpl.org> --- I've rebased this branch: https://gitlab.com/koha-dev/koha-dev/-/tree/bug_32910 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:20:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 16:20:42 +0000 Subject: [Koha-bugs] [Bug 33043] Use process_tt in SIP modules In-Reply-To: <bug-33043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33043-70-7VTGKtgILW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33043 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:20:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 16:20:45 +0000 Subject: [Koha-bugs] [Bug 33043] Use process_tt in SIP modules In-Reply-To: <bug-33043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33043-70-L0N3fhNGr7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33043 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150516|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Created attachment 150522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150522&action=edit Bug 33043: Use process_tt in SIP modules Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in the various parts of the SIP server code where we are currently using Template::process directly. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:20:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 16:20:50 +0000 Subject: [Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6 In-Reply-To: <bug-32910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32910-70-lotpQ3u9zS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #19 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Owen Leonard from comment #18) > I've rebased this branch Before seeing comment 16, so there are still a few missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:22:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 16:22:04 +0000 Subject: [Koha-bugs] [Bug 33043] Use process_tt in SIP modules In-Reply-To: <bug-33043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33043-70-AwNtDDZ4Ti@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33043 --- Comment #6 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. After applying the patch and dependencies, run updatedatabase (for 33039). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:22:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 16:22:17 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-qDcQTTUpf3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #50 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I think this doesn't apply anymore. Bug 33277 - Correctly handle linking subfields with no defined thesaurus 148530 - Bug 33277: Search thesaurus for 'notspecified' 149837 - Bug 33277: Do not search using thesaurus when linking non 6XX fields 149838 - Bug 33277: Support custom thesaurus authority with no 040 specified 149839 - Bug 33277: Add comments and missing thesauri 149840 - Bug 33277: Search thesaurus for 'notspecified' 149841 - Bug 33277: (follow-up) Fix notdefined search for Zebra and ES 149842 - Bug 33277: Adjust source file for zebra mappings Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 33277: Search thesaurus for 'notspecified' error: sha1 information is lacking or useless (Koha/SearchEngine/Elasticsearch/QueryBuilder.pm). error: could not build fake ancestor Patch failed at 0001 Bug 33277: Search thesaurus for 'notspecified' hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-33277-Search-thesaurus-for-notspecified-1Gg31H.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:30:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 16:30:42 +0000 Subject: [Koha-bugs] [Bug 30367] Plugins: Search explodes in error when searching for specific keywords In-Reply-To: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30367-70-DNg5EUQ7Ox@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:30:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 16:30:44 +0000 Subject: [Koha-bugs] [Bug 30367] Plugins: Search explodes in error when searching for specific keywords In-Reply-To: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30367-70-QyC6zwcaz8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367 --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150523&action=edit Bug 30367: Skip processing if we don't get releases Some repos don't have releases, and this seems to break things as get returns an empty response. Calling from_json on this is the error This simply skips the bad responses to avoid the error: To test: 1. Have this on your koha-conf.xml file: <plugin_repos> <repo> <name>ByWater Solutions</name> <org_name>bywatersolutions</org_name> <service>github</service> </repo> <repo> <name>Theke Solutions</name> <org_name>thekesolutions</org_name> <service>gitlab</service> </repo> <repo> <name>PTFS Europe</name> <org_name>ptfs-europe</org_name> <service>github</service> </repo> </plugin_repos> 2. Restart all services: $ restart_all 3. Search for the term 'barclaycard' The search will give an error: malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm line 190 4. Apply patch 5. Repeat 6. No error Note: The barclaycard plugin won't install even though it is returned as of this note - the plugin needs an update I believe, I don't think it's a Koha issue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:30:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 16:30:54 +0000 Subject: [Koha-bugs] [Bug 30367] Plugins: Search explodes in error when searching for specific keywords In-Reply-To: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30367-70-XMDwZd0myg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:50:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 16:50:03 +0000 Subject: [Koha-bugs] [Bug 33654] New: Add more permissions to Item Group Cataloging Message-ID: <bug-33654-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33654 Bug ID: 33654 Summary: Add more permissions to Item Group Cataloging Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Currently, there is only one permission attached to Item Groups: Permission Create, update, and delete item groups, add or remove items from an item group (manage_item_groups) It would be nice to make this functionality more granular within the permissions in Koha. For some catalogers, the permission to add an item to an item group is all they should be able to do in this workflow, but currently, once this overarching item group permission is granted, they can also create groups. Adding permission for only adding items to a group separate from creating groups would be the ultimate goal in this request. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:52:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 16:52:23 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-OZoSNzGFdm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148530|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:52:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 16:52:31 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-PL2yrNJIlZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 18:52:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 16:52:54 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-a3fQbubVmg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #51 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Caroline Cyr La Rose from comment #50) > I think this doesn't apply anymore. There was an old patch the needed obseleted, should apply now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 19:01:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 17:01:45 +0000 Subject: [Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF In-Reply-To: <bug-33393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33393-70-1OtlGow5D6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149076|0 |1 is obsolete| | --- Comment #10 from David Nind <david at davidnind.com> --- Created attachment 150524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150524&action=edit Bug 33393: Add system preference Sponsored-by: Pymble Ladies' College Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 19:01:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 17:01:48 +0000 Subject: [Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF In-Reply-To: <bug-33393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33393-70-z3PeljFVJe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149106|0 |1 is obsolete| | --- Comment #11 from David Nind <david at davidnind.com> --- Created attachment 150525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150525&action=edit Bug 33393: Enable libraries to configure their own text in the 1-Page order PDF Test plan: 1) Apply patches and restart services 2) Upgrade Koha schema: sudo koha-upgrade-schema <instance> 3) Go to Koha Administration -> Libraries. Ensure Library A has an address, phone and fax. 4) Go to Koha Administration -> System preferences. Search for OrderPdfFormat. Set this to English 1-page layout option. 5) Go to Acquisitions. Use an existing vendor or create a new one. Ensure the vendor has a postal address, phone, fax and accout number. 6) Create a basket for this vendor. Add many orders to this basket, for example 25 items (this is to make the Order PDF cover multiple pages). 7) Close the basket and add it to a basket group of the same name. 8) Edit the basket group. Add an address in the delivery place, and a delivery comment. Check the box to close the basket group and Save. 9) Click the button to Export as PDF. 10) View the exported PDF. Confirm the PDF is multiple pages long. If it is not then re-open the basketgroup and add more orders to the basket and repeat steps 7, 8, and 9 11) If the PDF is multiple pages long then confirm: - The text "Order number must appear on all related correspondence, shipping papers and invoices. Notify us immediately if you are unable to supply item(s)." appears above the order table. - The page numbers at the bottom of the first page are not obscured by the order table. - That the order table starts near the top of the second page, and not half way down. 12) Change content in the '1PageOrderPDFText' syspref (use the Enter key to split text over multiple lines) and save 13) Back in the Acquisitions module click the button to Export as PDF 14) View the exported PDF. Confirm the following: - The text above the order table is what you saved in the 1PageOrderPDFText system preference - The page numbers at the bottom of the first page are not obscrued by the order table. - That the order table starts near the top of the second page and not halfway down. 15) Empty the 1PageOrderPDFText system preference and save 16) Back in the Acquisitions module click te button to Export as PDF 17) View the exported PDF and confirm the line of text between the Tel/Fax line and the order table has been removed. Sponsored-by: Pymble Ladies' College Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 19:01:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 17:01:51 +0000 Subject: [Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF In-Reply-To: <bug-33393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33393-70-Gx6T9Q2g6c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150497|0 |1 is obsolete| | --- Comment #12 from David Nind <david at davidnind.com> --- Created attachment 150526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150526&action=edit Bug 33393: Add note to system preference explaining text length Sponsored-by: Pymble Ladies' College Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 19:02:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 17:02:33 +0000 Subject: [Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF In-Reply-To: <bug-33393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33393-70-JQYR8s3Nwt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393 --- Comment #13 from David Nind <david at davidnind.com> --- (In reply to Alex Buckley from comment #9) > Hi David, > > I have attached a patchset adding a note to the system preference > description noting to keep the text length to 3 lines. > > Is that what you had in mind? > > Thanks, > Alex That looks fine to me. Thanks Alex! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 19:23:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 17:23:44 +0000 Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled In-Reply-To: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33622-70-y8OZO6Rd8j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 19:25:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 17:25:32 +0000 Subject: [Koha-bugs] [Bug 30367] Plugins: Search explodes in error when searching for specific keywords In-Reply-To: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30367-70-gZ3wJ7duGo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 19:25:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 17:25:34 +0000 Subject: [Koha-bugs] [Bug 30367] Plugins: Search explodes in error when searching for specific keywords In-Reply-To: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30367-70-MAjlBlx4hB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150523|0 |1 is obsolete| | --- Comment #4 from David Nind <david at davidnind.com> --- Created attachment 150527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150527&action=edit Bug 30367: Skip processing if we don't get releases Some repos don't have releases, and this seems to break things as get returns an empty response. Calling from_json on this is the error This simply skips the bad responses to avoid the error: To test: 1. Have this on your koha-conf.xml file: <plugin_repos> <repo> <name>ByWater Solutions</name> <org_name>bywatersolutions</org_name> <service>github</service> </repo> <repo> <name>Theke Solutions</name> <org_name>thekesolutions</org_name> <service>gitlab</service> </repo> <repo> <name>PTFS Europe</name> <org_name>ptfs-europe</org_name> <service>github</service> </repo> </plugin_repos> 2. Restart all services: $ restart_all 3. Search for the term 'barclaycard' The search will give an error: malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm line 190 4. Apply patch 5. Repeat 6. No error Note: The barclaycard plugin won't install even though it is returned as of this note - the plugin needs an update I believe, I don't think it's a Koha issue Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 19:28:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 17:28:23 +0000 Subject: [Koha-bugs] [Bug 30367] Plugins: Search explodes in error when searching for specific keywords In-Reply-To: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30367-70-1k2dRSejAo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. To search (step 3), go to Administration > Plugins > Manage plugins. 2. Searching for 'barclaycard' didn't generate an error, but searching for 'edifact' did. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 19:39:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 17:39:26 +0000 Subject: [Koha-bugs] [Bug 31339] Add Template::Toolkit WRAPPER for Koha Tool Plugins In-Reply-To: <bug-31339-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31339-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31339-70-GFZ6PUiFF6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31339 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 19:39:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 17:39:29 +0000 Subject: [Koha-bugs] [Bug 31339] Add Template::Toolkit WRAPPER for Koha Tool Plugins In-Reply-To: <bug-31339-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31339-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31339-70-rrpB9140RH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31339 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139647|0 |1 is obsolete| | --- Comment #7 from David Nind <david at davidnind.com> --- Created attachment 150528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150528&action=edit Bug 31339: Add staff wrapper template include for tool plugins This change adds a template include which can be used as a WRAPPER for tool plugins, which makes it easy to pages in tool templates without having to copy and maintain a lot of template boilerplate. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Upload koha-plugin-test-wrapper 2. Enable the plugin 3. Click "Actions" and click "Run tool" 4. Note how the plugin page looks like a perfect Koha Tools page 5. Note that the plugin only contains 6 lines of template code to achieve this effect Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 19:51:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 17:51:48 +0000 Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled In-Reply-To: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33622-70-cahPFk6ze9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 19:51:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 17:51:50 +0000 Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled In-Reply-To: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33622-70-sf5ofx3yVg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 150529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150529&action=edit Bug 33622: Notice content does not show on default tab if TranslateNotices enabled This patch fixes a conflict between the template-generated markup and Bootstrap JS which were both competing to show the correct default tab. It's simpler to rely on JavaScript. To test, apply the patch and enable the TranslateNotices system preference if necessary. - Go to Tools -> Notices & slips - Go to edit any notice e.g. DUEDGST - The page should load with the "Default" tab selected by default. - Enter unique titles and contents under each tab to confirm that the data you see under the "Default" or "English (en)" tab is being shown in the right place. - Save your modified notice and edit it again to confirm that the tabs correspond correctly to your data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:14:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 18:14:15 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-lY1Miybc2E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149218|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:14:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 18:14:25 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-uIwBeRBcGm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149213|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:14:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 18:14:35 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-2hIssTSTMz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149211|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:35:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 18:35:36 +0000 Subject: [Koha-bugs] [Bug 33644] Link tracking In-Reply-To: <bug-33644-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33644-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33644-70-gkDNqyJxDZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33644 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:44:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 18:44:32 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-m4hSOVHt8T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 --- Comment #13 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 150530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150530&action=edit Bug 33419: Set home library and current library as mandatory by default Test plan to be used with KTD (Koha Testing Docker): 1. Reset KTD so that the web installer is used to setup Koha 2. Setup the web installer -> When setting up the default settings, don't add any of the optional data. 3. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a and $952$b are not mandatory. 4. Apply the patch. 5. Repeat steps 1-2. 6. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a and $952$b are now mandatory. How to setup the web installer ~~~~~~~~~~~~~~~~~~~~ 1. Access the database server[1]: mysql -uroot -ppassword -hkoha_db_1 2. Drop the koha_kohadev database: drop database koha_kohadev; 3. Create the database: create database koha_kohadev; 4. Add privileges (for a real installation this would be limited): grant all on koha_kohadev.* to koha_kohadev; 5. Restart everything (may not be required, but just to be safe): flush_memcached + restart_all 6. Access the web installer: go to 127.0.0.1:8081 7. Use the database user name and password: get from /etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password) 8. Continue through the installation process -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:48:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 18:48:24 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-WQAViuemLO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150530|0 |1 is obsolete| | --- Comment #14 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 150531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150531&action=edit Bug 33419: Set home library and current library as mandatory by default -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:51:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 18:51:19 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-Oi7QjrWM9H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150531|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:58:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 18:58:38 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-xWEQxRV9Yv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 --- Comment #15 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 150532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150532&action=edit Bug 33419: Make home library and current library mandatory by default -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 20:59:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 18:59:49 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-waB8UW4reS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #16 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Test plan to be used with KTD (Koha Testing Docker): 1. Reset KTD so that the web installer is used to setup Koha 2. Setup the web installer -> When setting up the default settings, don't add any of the optional data. 3. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a and $952$b are not mandatory. 4. Apply the patch. 5. Repeat steps 1-2. 6. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a and $952$b are now mandatory. How to setup the web installer ~~~~~~~~~~~~~~~~~~~~~~~ 1. Access the database server[1]: mysql -uroot -ppassword -hkoha_db_1 2. Drop the koha_kohadev database: drop database koha_kohadev; 3. Create the database: create database koha_kohadev; 4. Add privileges (for a real installation this would be limited): grant all on koha_kohadev.* to koha_kohadev; 5. Restart everything (may not be required, but just to be safe): flush_memcached + restart_all 6. Access the web installer: go to 127.0.0.1:8081 7. Use the database user name and password: get from /etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password) 8. Continue through the installation process -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 21:32:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 19:32:02 +0000 Subject: [Koha-bugs] [Bug 33655] New: z39.50 search no longer shows search in progress Message-ID: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Bug ID: 33655 Summary: z39.50 search no longer shows search in progress Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl With 22.11 when adding a new bib record via z39.50 import there is no longer any indication that a search has been submitted. Previously, the cursor icon would change to the busy status, but now there is no change so there is no way to know if the search has been submitted or not. This leads to staff submitting the same search repeatedly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 21:37:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 19:37:34 +0000 Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled In-Reply-To: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33622-70-GJCmK3GB2y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 21:37:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 19:37:36 +0000 Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled In-Reply-To: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33622-70-mP42dMehTO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150529|0 |1 is obsolete| | --- Comment #6 from David Nind <david at davidnind.com> --- Created attachment 150533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150533&action=edit Bug 33622: Notice content does not show on default tab if TranslateNotices enabled This patch fixes a conflict between the template-generated markup and Bootstrap JS which were both competing to show the correct default tab. It's simpler to rely on JavaScript. To test, apply the patch and enable the TranslateNotices system preference if necessary. - Go to Tools -> Notices & slips - Go to edit any notice e.g. DUEDGST - The page should load with the "Default" tab selected by default. - Enter unique titles and contents under each tab to confirm that the data you see under the "Default" or "English (en)" tab is being shown in the right place. - Save your modified notice and edit it again to confirm that the tabs correspond correctly to your data. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 21:46:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 19:46:39 +0000 Subject: [Koha-bugs] [Bug 31617] Allow manual editing of suggestions.biblionumber In-Reply-To: <bug-31617-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31617-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31617-70-h29R2a58Jt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31617 Kim Gnerre <kgnerre at hotchkiss.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kgnerre at hotchkiss.org --- Comment #3 from Kim Gnerre <kgnerre at hotchkiss.org> --- Because we support bugs 27595 and 33363 we support the development of this bug as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 22:01:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 20:01:34 +0000 Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled In-Reply-To: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33622-70-dgpyS9UGPY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #7 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. To replicate the issue (note: ACCOUNTS_SUMMARY has no email notice, DUEDGST does have an email notice) I had to install another language (other than just having the Default and English (en) tabs): - Install another language: koha-translate install fr-CA - Enable the language: Administration > System preferences > I18N/L10N > language > Français (fr-CA) - Enable the TranslateNotices system preference - Edit the DUEDGST notice - It opens on the Default tab: expand the Email notice --> it is blank - Click on the tabs for English (en) and Français (fr-CA), and expand the email notice section (should be blank, unless you've added translations already) - Click back on the Default tab and expand the Email notice --> it is now not blank - Refreshing the page resets things, so you can then replicate the issue again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 22:15:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 20:15:03 +0000 Subject: [Koha-bugs] [Bug 33656] New: In serial collection, items with "Missing" status are always checked by default Message-ID: <bug-33656-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33656 Bug ID: 33656 Summary: In serial collection, items with "Missing" status are always checked by default Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: maude.boudreau at collecto.ca QA Contact: testopia at bugs.koha-community.org Created attachment 150534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150534&action=edit Example Hi, In serial collection, items with "Missing" status are always checked by default. Some libraries always maintain this status in issues. This creates a problem when they want to prune issues. Example : (see file attachment) To prune all the numbers of 2021, i need to : Go to the 2022 and 2024 tab to uncheck all missing numbers so that it is not deleted. Go to the 2021 tab, click on "select all" and on "delete selected issues". If you forget to uncheck before clicking delete, all the missing numbers of 2022 and 2024 will be deleted! Also, when we edit serials. All missing numbers appear. Which can become cumbersome when there are several numbers for several years. It would be nice to have a system preference that allows us to choose if we want to check it or not by default Thanks! Maude -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 22:16:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 20:16:27 +0000 Subject: [Koha-bugs] [Bug 33656] In serial collection, items with "Missing" status are always checked by default In-Reply-To: <bug-33656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33656-70-vCzMR2VrZ6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33656 Maude <maude.boudreau at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maude.boudreau at collecto.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 22:25:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 20:25:55 +0000 Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled In-Reply-To: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33622-70-uF3Klr1jIC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 22:25:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 20:25:58 +0000 Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled In-Reply-To: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33622-70-u5dR1IVTRT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150533|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150535&action=edit Bug 33622: Notice content does not show on default tab if TranslateNotices enabled This patch fixes a conflict between the template-generated markup and Bootstrap JS which were both competing to show the correct default tab. It's simpler to rely on JavaScript. To test, apply the patch and enable the TranslateNotices system preference if necessary. - Go to Tools -> Notices & slips - Go to edit any notice e.g. DUEDGST - The page should load with the "Default" tab selected by default. - Enter unique titles and contents under each tab to confirm that the data you see under the "Default" or "English (en)" tab is being shown in the right place. - Save your modified notice and edit it again to confirm that the tabs correspond correctly to your data. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 22:28:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 20:28:25 +0000 Subject: [Koha-bugs] [Bug 31698] Add ability to move a hold to a new biblio/item In-Reply-To: <bug-31698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31698-70-qgnP1LezDJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:18:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 21:18:51 +0000 Subject: [Koha-bugs] [Bug 33657] New: Barcode list field in Inventory report doesn't honor BarcodeSeparators system preference Message-ID: <bug-33657-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 Bug ID: 33657 Summary: Barcode list field in Inventory report doesn't honor BarcodeSeparators system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: michael.hafen at washk12.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:23:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 21:23:38 +0000 Subject: [Koha-bugs] [Bug 33332] Fix formatting of TT comments to improve translations In-Reply-To: <bug-33332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33332-70-Dqts2aWp9P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33652 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:23:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 21:23:38 +0000 Subject: [Koha-bugs] [Bug 33652] Always show datatable column filters at the top instead of the bottom of the table In-Reply-To: <bug-33652-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33652-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33652-70-sBXOYcBFLp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33652 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33332 | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:26:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 21:26:11 +0000 Subject: [Koha-bugs] [Bug 33657] Barcode list field in Inventory report shouldn't be split on space In-Reply-To: <bug-33657-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33657-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33657-70-2dXSBzNgtW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 Michael Hafen <michael.hafen at washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Barcode list field in |Barcode list field in |Inventory report doesn't |Inventory report shouldn't |honor BarcodeSeparators |be split on space |system preference | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:29:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 21:29:40 +0000 Subject: [Koha-bugs] [Bug 33657] Barcode list field in Inventory report shouldn't be split on space In-Reply-To: <bug-33657-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33657-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33657-70-QjXC6DYiCf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I believe BarcodeSeparators could be at play here (or should be), so it might be a configuration issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:30:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 21:30:39 +0000 Subject: [Koha-bugs] [Bug 33657] Barcode list field in Inventory report shouldn't be split on space In-Reply-To: <bug-33657-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33657-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33657-70-qVWSKxQ1AJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Try changing the default \s\r\n to \r\n - that should give you the result you want. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:33:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 21:33:46 +0000 Subject: [Koha-bugs] [Bug 33657] Barcode list field in Inventory report shouldn't be split on space In-Reply-To: <bug-33657-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33657-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33657-70-0wVQrK0XXk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 Michael Hafen <michael.hafen at washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WORKSFORME |FIXED --- Comment #3 from Michael Hafen <michael.hafen at washk12.org> --- That would effect the file upload field, as per the code. The barcode list field is processed separately from the upload field, and does not reference the BarcodeSeparators system preference. I have already removed the \s from the BarcodeSeparators system preference. Looking at the page again, the field hint states that there should be one barcode per line. I don't think the BarcodeSeparators system preference should be applied to the field, and I also thing the field should split on space. I could understand stripping space from the beginning and/or the end of a barcode, but that's not what is currently done. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:34:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 21:34:01 +0000 Subject: [Koha-bugs] [Bug 33657] Barcode list field in Inventory report shouldn't be split on space In-Reply-To: <bug-33657-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33657-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33657-70-Uqcyual7Bv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 Michael Hafen <michael.hafen at washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:34:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 21:34:55 +0000 Subject: [Koha-bugs] [Bug 33657] Barcode list field in Inventory report shouldn't be split on space In-Reply-To: <bug-33657-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33657-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33657-70-2KvNHRcqvh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 --- Comment #4 from Michael Hafen <michael.hafen at washk12.org> --- I meant that the BarcodeSeparators system preference should not be applied to the barcode list field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:36:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 21:36:04 +0000 Subject: [Koha-bugs] [Bug 33657] Barcode list field in Inventory report shouldn't be split on space In-Reply-To: <bug-33657-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33657-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33657-70-xld8ZYPh8A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- > Looking at the page again, the field hint states that there should be one > barcode per line. I don't think the BarcodeSeparators system preference > should be applied to the field, and I also thing the field should split on > space. Should or should not? One per line seems save or using BarcodeSeparators seems the safest bet as we can't rule out libraries using spaces within their barcodes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:37:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 21:37:05 +0000 Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially In-Reply-To: <bug-32253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32253-70-0CfJZ38gBh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:37:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 21:37:08 +0000 Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially In-Reply-To: <bug-32253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32253-70-Fjt6zprz69@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150483|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150536&action=edit Bug 32253: Load all CodeMirror lines initially when using advanced editor To test: 1. Have advanced editor turned on. 2. Load a record with many lines and see that not all the lines appear until you click on the visible ones. 3. Apply patch and try again 4. All lines should load. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:37:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 21:37:23 +0000 Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially In-Reply-To: <bug-32253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32253-70-eqZRaFxbWT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Small fix, great effect, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:37:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 21:37:27 +0000 Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially In-Reply-To: <bug-32253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32253-70-CknQkrtlbw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:39:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 21:39:24 +0000 Subject: [Koha-bugs] [Bug 33657] Barcode list field in Inventory report shouldn't be split on space In-Reply-To: <bug-33657-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33657-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33657-70-TmWrsuBNqS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 --- Comment #6 from Michael Hafen <michael.hafen at washk12.org> --- Yes, I meant should not. The BarcodeSeparators sys pref should not apply, since it seems the barcode list field is already separated (one barcode per line). And the field should not be split on space, as you say, since space in a barcode is valid (many of my libraries have such barcodes). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:49:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 21:49:01 +0000 Subject: [Koha-bugs] [Bug 30910] Allow local definition of temporary shelving locations In-Reply-To: <bug-30910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30910-70-9VtUrBqyVs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30910 Katie Bliss <kebliss at dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:50:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 21:50:39 +0000 Subject: [Koha-bugs] [Bug 33657] Barcode list field in Inventory report shouldn't be split on space In-Reply-To: <bug-33657-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33657-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33657-70-0F2EsGsk0P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33657 Michael Hafen <michael.hafen at washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|REOPENED |RESOLVED --- Comment #7 from Michael Hafen <michael.hafen at washk12.org> --- I think I jumped the gun here. I read the regexp as a character class, but it's not. The field is split on space followed by a new line. Having actually tested it, I see that there isn't a problem in practice. I'm still not sure about that regexp, but it does work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 2 23:55:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 21:55:16 +0000 Subject: [Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF In-Reply-To: <bug-33393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33393-70-J4K0zgKn4c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393 --- Comment #14 from Alex Buckley <alexbuckley at catalyst.net.nz> --- (In reply to David Nind from comment #13) > (In reply to Alex Buckley from comment #9) > > Hi David, > > > > I have attached a patchset adding a note to the system preference > > description noting to keep the text length to 3 lines. > > > > Is that what you had in mind? > > > > Thanks, > > Alex > > That looks fine to me. Thanks Alex! Thanks so much David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:03:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:03:06 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-MNrVpuegcI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149682|0 |1 is obsolete| | --- Comment #96 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150537&action=edit Bug 11844: Use additional fields for order lines This patch allows to create additional fields for order lines. Once created, these fields can be filled during order line creation or modification. If additional field is linked to a MARC field, there are two possible scenario: - MARC field mode = get: The field cannot be modified and its value is retrieved from the bibliographic record (current behaviour) - MARC field mode = set: The field can be modified and its value is saved to the bibliographic record (new behaviour) If additional field is linked to an authorised value category, then authorised values are used. If not directly linked to an authorised value category, but linked to a MARC field, a search for an AV category is made on MARC default framework. This patch doesn't display additional fields value anywhere (except in order line creation/modification). Future patches will do that. Test plan: 1/ Go to Acquisitions home 2/ In the left menu, click on "Add order line fields" 3/ Click on "New field" button 4/ Give the field a name (unique), no AV category and no MARC field. 5/ Save. 6/ Create 5 other fields: a/ no AV category, a MARC field not linked to AV category, MARC field mode = get b/ no AV category, a MARC field not linked to AV category, MARC field mode = set c/ no AV category, a MARC field linked to AV category, MARC field mode = get d/ no AV category, a MARC field linked to AV category, MARC field mode = set e/ an AV category, no MARC field 7/ Create everything you need to be able to create order lines (supplier, basket, ...) 8/ Create an order line. At bottom of the page, you should see your additional fields, with authorised values dropdrown list for fields (c), (d) and (e). Fields (a) and (c) should be disabled. 9/ Fill these fields with some data and save order line 10/ check that data was correctly saved into biblio for fields (b) and (d), but not for (a) and (c) 11/ modify the same order line, check that values you've filled are correctly retrieved and that values for (a) and (c) were correctly retrieved from the bibliographic record 12/ modify all values, save, and check biblio once again Signed-off-by: Harold Dramer <harold.dramer at nyls.edu> Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:03:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:03:10 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-2uAiAsn8jp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149683|0 |1 is obsolete| | --- Comment #97 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150538&action=edit Bug 11844: Take into account itemtypes, branches, and cn_source MARC subfields can be linked to "authorised values" that are not real authorised values: itemtypes, branches, and cn_source. Those were not taken into account. This patch fixes that Test plan: 1. Create additional fields for order lines with a MARC subfield that is linked to one of those "fake" authorised values list 2. Follow the same steps as in the main test plan Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:03:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:03:14 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-0vXo7O2Rcz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149684|0 |1 is obsolete| | --- Comment #98 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150539&action=edit Bug 11844: Fix QA issues (POD, TT filters, file exec flag) Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:03:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:03:18 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-kAQmox7ijv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149685|0 |1 is obsolete| | --- Comment #99 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150540&action=edit Bug 11844: [DO NOT PUSH] Schema changes Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:03:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:03:22 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-wmMtTJzFRt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149686|0 |1 is obsolete| | --- Comment #100 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150541&action=edit Bug 11844: (follow-up) Fix terminology: biblio should be bibliographic record This is about the note displaying after an additional field that is linked to a MARC field. Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:03:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:03:26 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-QZLcBX3uMr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149687|0 |1 is obsolete| | --- Comment #101 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150542&action=edit Bug 11844: (follow-up) Add standard note to database update Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:03:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:03:30 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-Df0njnZhG1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149688|0 |1 is obsolete| | --- Comment #102 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150543&action=edit Bug 11844: (follow-up) Add new option to acq navigation The navigation on the left in the acq module has links to the additional fields for baskets and invoices. This also adds a link for the new order lines feature. Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:03:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:03:34 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-75p52M0EJU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149689|0 |1 is obsolete| | --- Comment #103 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150544&action=edit Bug 11844: (follow-up) Add format hint to the additional fields admin page The MARC field needs to be added with a $ between field and subfield for things to work right. So this adds a hint about the expected format. Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:03:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:03:39 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-TaMPxml3tS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149690|0 |1 is obsolete| | --- Comment #104 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150545&action=edit Bug 11844: Add tests for Koha::AdditionalField Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:03:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:03:43 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-yHvKacKbHv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149691|0 |1 is obsolete| | --- Comment #105 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150546&action=edit Bug 11844: Add tests for TransferOrder Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:03:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:03:47 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-DKP403S5hk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149692|0 |1 is obsolete| | --- Comment #106 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150547&action=edit Bug 11844: Add tests for marcfield_mode Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:03:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:03:51 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-sALVuV2Qjh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #107 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150548&action=edit Bug 11844: (QA follow-up) Fix unit test file ending t/db_dependent/Koha/AdditionalField.pm -> t/db_dependent/Koha/AdditionalField.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:05:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:05:00 +0000 Subject: [Koha-bugs] [Bug 33655] z39.50 search no longer shows search in progress In-Reply-To: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33655-70-KjHGghLMpl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- On what version of Koha did this previously work for you? I would love to implement something like I proposed in Bug 30437 here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:05:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:05:31 +0000 Subject: [Koha-bugs] [Bug 33654] Add more permissions to Item Group Cataloging In-Reply-To: <bug-33654-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33654-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33654-70-mFKsu3UD7G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33654 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:05:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:05:42 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-jWl4nDO8RV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #108 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #95) > (In reply to Martin Renvoize from comment #94) > > RM note.. the QA tool threw two issues.. POD coverage which is a false > > positive here I believe and a permissions issue.. but the permissions all > > look correct to me.. not sure what's going on there. > > FAIL t/db_dependent/Koha/AdditionalField.pm > FAIL file permissions > File must not have the exec flag > > Well, this is valid: > -rwxr-xr-x 1 jonathan jonathan 2506 mai 2 11:51 > t/db_dependent/Koha/AdditionalField.pm > > Actually I guess it should be renamed to .t Small rebase (conflicts in the USE statements, not hard), fixed the test, unit and QA tests pass now. Also did some tests in the GUI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:06:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:06:25 +0000 Subject: [Koha-bugs] [Bug 33655] z39.50 search no longer shows search in progress In-Reply-To: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33655-70-ec17JRLCiH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I was wondering too - maybe only on the advanced editor? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:09:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:09:33 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-lcRTrXNkeR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Laura, 2 small problems: 1) UNIMARC is missing the change for holdingbranch. +++ b/installer/data/mysql/en/marcflavour/unimarc/mandatory/unimarc_framework_DEFAULT.yml @@ -849,7 +849,7 @@ tables: liblibrarian: "Home library" libopac: "Home library" repeatable: 0 - mandatory: 0 + mandatory: 1 kohafield: items.homebranch tab: 10 authorised_value: branches 2) Patch was not authored by you :) >From 56de1c94a44702135407c30d318c896b50fd1fcb Mon Sep 17 00:00:00 2001 From: John Doe <you at example.com> Date: Tue, 2 May 2023 18:35:23 +0000 Subject: [PATCH] Bug 33419: Make home library and current library mandatory by default Have a look at git commit --amend --reset-author (when you have fixed the config) or git commit --amend --author if you just want to rewrite the line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:19:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:19:27 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-i3xkICwGqN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:19:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:19:30 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-InoUrlohxh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150457|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150549&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to article-requests.tt This commit fixed two cases: 1. Fixing "Select all" and "Clear all" links on the page. 2. Fixing the interaction with selected entries when switching between the "New" and "Pending" tabs. To test: (Create article requests if they don't exist) Case 1: 1. Go to /cgi-bin/koha/circ/article-requests.pl and don't switch between tabs. 2. Click on "Select all" and verify that it's not working -- the checkboxes are not selected. 3. Activate any checkbox and click "Clear all" -- the checkbox is not cleared. 4. Apply the patch. 5. Restart the page and, without switching between tabs, repeat steps 2 and 3. Verify that it works now. Case 2: 1. Go to /cgi-bin/koha/circ/article-requests.pl. 2. Switch between tabs and leave "New" active. 3. Select any entry and delete or move it to another tab. 4. Verify that the entry remains in the table until the page reloads. 5. Apply the patch. 6. Restart the page and repeat steps 2 and 3. Make sure that everything works now. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:19:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:19:33 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-KWPgHsfy0C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150458|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150550&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to serials-collection.tt To test: * Add a subscription * From the subscription detail page, click on serial collection link in left hand navigation * Create some additional issues * "Clear all" link for selecting issues to edit won't work, "Select all" link neither * Apply the patch * * "Clear all" link for selecting issues to edit works now, "Select all" link works too. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:19:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:19:35 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-F3qexMY0ZS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150459|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150551&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to modborrowers.tt The submitted numbers were not processed by the search query. To test: 1. Go to /cgi-bin/koha/circ/modborrowers.pl 2. On the relevant tab, enter the card number or the borrower number in the text area, or upload a text file with a relevant list of numbers. 3. Click "Continue" and verify that a message appears stating "No patron card numbers or borrowernumbers given". 4. Apply the patch. 5. Restart the page and repeat steps 2 and 3. Make sure you receive the correct response -- a list of borrowers or a message indicating that the specified numbers were not found. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:19:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:19:38 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-skYa9Q5A8U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150460|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150552&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to export.tt The list of CSV profiles was not displayed if the CSV format was selected in the output format settings. To test: 1. Go to /cgi-bin/koha/tools/export.pl 2. At the bottom of the page in the Output format, select CSV format. *If CSV format is not active in the drop-down File format menu, create any profile to Usage export records on the link /cgi-bin/koha/tools/csv-profiles.pl 3. Note that the list of CSV profiles is not displayed. 4. Apply the patch. 5. Restart the page and repeat steps 2. 6. Verify that when you select the CSV format, the list of CSV profiles appears. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:20:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:20:24 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-vIeI1IjBkH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32571 Component|Serials |Staff interface CC| |gmcharlt at gmail.com QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:20:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:20:24 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: <bug-32571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32571-70-9ODh1Q0M1T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:23:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:23:27 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-RApLX3CKtx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:23:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:23:29 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-zutwqCtpx5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150532|0 |1 is obsolete| | --- Comment #18 from David Nind <david at davidnind.com> --- Created attachment 150553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150553&action=edit Bug 33419: Make home library and current library mandatory by default Items without a home and current library can cause errors in Koha. On the bibliographic page, items appear without the "edit" drop-down or the selection check box. On a bulk delete page, items without a home library create a red error that says "Cannot delete". Making the home and current library values mandatory helps avoid these issues. Test plan (using koha-testing-docker (KTD)): 1. Reset KTD so that the web installer is used to setup Koha.[1] 2. Setup Koha using the web installer -> When setting up the default settings, don't add any of the optional data. 3. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a and $952$b are not mandatory. 4. Apply the patch. 5. Repeat steps 1-2. 6. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a and $952$b are now mandatory. [1] How to access the web installer to setup Koha in KTD: 1. Access the database server: mysql -uroot -ppassword -hkoha-db-1 2. Drop the koha_kohadev database: drop database koha_kohadev; 3. Create the database: create database koha_kohadev; 4. Add privileges (for a real installation this would be limited): grant all on koha_kohadev.* to koha_kohadev; 5. Restart everything (there may be some errors listed): flush_memcached and then restart_all 6. Access the web installer: go to 127.0.0.1:8081 7. Use the database user name and password: get from /etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password) 8. Continue through the installation process. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:26:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:26:06 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-JLTP7zKuPW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #19 from David Nind <david at davidnind.com> --- Hi Laura. I have signed off, and also had a go at amending the commit message to include a description and the test plan (including adding your name as the author). (See https://wiki.koha-community.org/wiki/Commit_messages) Feel free to amend it! David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:30:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:30:57 +0000 Subject: [Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion In-Reply-To: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33541-70-jbtpfATNtW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:30:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:30:59 +0000 Subject: [Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion In-Reply-To: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33541-70-fdUmAVTWiG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149731|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150554&action=edit Bug 33541: Add document type to list of suggestions when ordering This adds the document type (suggestions.itemtype) to the list of accepted suggestions when creating an order from a suggestion. To test: * Add some suggestions and make sure to pick different document types. * Accept those suggestions in the staff interface. * Go to acquisitions * Create a basket * Add an 'order from a suggestion' * Verify that the list shows the 'document type' nicely and correctly * Order one, all good? sign off. Signed-off-by: Juliet <jheltibridle at rcplib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Removed IS_OPAC param from AuthorisedValues.GetByCode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:31:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:31:21 +0000 Subject: [Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion In-Reply-To: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33541-70-wS2GH5d7Br@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #5) > This table can be configured, you need to update admin/columns_settings.yml I think you are confusing the tables. suggestions is, but newordersuggestion is not configurable. This is the table with accepted suggestions shown when using "ordering from suggestion". It has no table configuration icons and I didn't find it in the config. > Also you don't need the third parameter (opac=0), it's the default value. Fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:36:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:36:18 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-82qDfnQKIj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I had another look - the note about UNIMARC is invalid - holdingbranch already is mandatory without this patch. But now I get: FAIL t/db_dependent/selenium/basic_workflow.t FAIL valid syntax error Missing right curly or square bracket t/db_dependent/selenium/basic_workflow.t had compilation errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:48:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:48:38 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-HqjRYN5gwc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- Hey Nick, Can this take into account the default framework, which does not have a framworkcode? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:50:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:50:26 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-sUKkb5GR1t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:50:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:50:29 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-tqO0ufNdby@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150553|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150555&action=edit Bug 33419: Make home library and current library mandatory by default Items without a home and current library can cause errors in Koha. On the bibliographic page, items appear without the "edit" drop-down or the selection check box. On a bulk delete page, items without a home library create a red error that says "Cannot delete". Making the home and current library values mandatory helps avoid these issues. Test plan (using koha-testing-docker (KTD)): 1. Reset KTD so that the web installer is used to setup Koha.[1] 2. Setup Koha using the web installer -> When setting up the default settings, don't add any of the optional data. 3. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a and $952$b are not mandatory. 4. Apply the patch. 5. Repeat steps 1-2. 6. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a and $952$b are now mandatory. [1] How to access the web installer to setup Koha in KTD: 1. Access the database server: mysql -uroot -ppassword -hkoha-db-1 2. Drop the koha_kohadev database: drop database koha_kohadev; 3. Create the database: create database koha_kohadev; 4. Add privileges (for a real installation this would be limited): grant all on koha_kohadev.* to koha_kohadev; 5. Restart everything (there may be some errors listed): flush_memcached and then restart_all 6. Access the web installer: go to 127.0.0.1:8081 7. Use the database user name and password: get from /etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password) 8. Continue through the installation process. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 00:50:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 22:50:31 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-LRr3YkGMJD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 --- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150556&action=edit Bug 33419: (QA follow-up) Remove changes to basic_workflow.t These are not needed: 942 and 200 have no subfields for homebranch and holdingbranch. The tests pass without these changes. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 01:13:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 23:13:10 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33259-70-sHTne8cAF9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150259|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 01:13:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 23:13:20 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33259-70-LQa0ZYru2d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148590|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 01:13:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 23:13:26 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33259-70-YHbw3qozWh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148589|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 01:13:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 23:13:47 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33259-70-21NsWyWYYf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #11 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Created attachment 150557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150557&action=edit Bug 33259: Add SameSiteSessionCookie system preference Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 01:13:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 23:13:59 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33259-70-pOwQoUdwUw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #12 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Created attachment 150558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150558&action=edit Bug 33259: Optionally set SameSite attribute of session cookie to Strict Note: The below test plan is assuming you are running the Mozilla Firefox browser. Test plan: 1. Apply patches 2. Upgrade database sudo koha-upgrade-schema <instance> 3. Confirm the new system preference 'SameSiteSessionCookie' is 'Lax' 4. Go to a staff client and OPAC page, right click, choose 'Inspect', go to the 'Storage' tab, click on 'Cookies', click on 'CGISESSID' 5. Confirm 'SameSite' = 'Lax' 6. Change the 'SameSiteSessionCookie' to 'Strict' 7. Open a new private browser window. Go to a staff client and OPAC page, right click, choose 'Inspect, go to the 'Storage' tab, click on 'Cookies', click on 'CGISESSID' 8. Repeat step 4 and confirm 'SameSite' = 'Strict' 9. Go to: Cataloguing > New record 10. Right click, click 'Inspect', go to the 'Console' tab, confirm there are no JavaScript errors 11. Change 'SameSiteSessionCookie' to 'None' 12. Open a new private browser window, repeat step 4, and confirm the 'SameSite' = 'None' 13. Go to: Cataloguing > New record 14. Right click, click 'Inspect', go to the 'Console' tab, confirm there are no JavaScript errors. Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 01:14:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 23:14:14 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33259-70-ix4UdxXmS7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #13 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Created attachment 150559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150559&action=edit Bug 33259: (follow-up) Use different speechmarks to prevent errors To test: Confirm the checkouts table for a patron loads successfully -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 01:14:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 23:14:28 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33259-70-CX446OMvND@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #14 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Created attachment 150560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150560&action=edit Bug 33259: (follow-up) Add HTML filters to Cookies.set Test plan: Run QA test tools and confirm the no complaints about filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 01:15:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 23:15:11 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33259-70-mAe8w3Zhdg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #15 from Alex Buckley <alexbuckley at catalyst.net.nz> --- (In reply to Lucas Gass from comment #10) > Alex, > > The QA tool complains about quite a few missing filters within Cookies.set. > I think we can add the html filter in those cases, right? > > Also, should none be option along with lax and strict? Hi Lucas, Thanks for your comments. Yes, adding the HTML filters does fix up the QA test tool failures, so I have added that as a followup patch. Currently all Koha cookies have 'samesite' = 'Lax' which is why I made it the default syspref value. However, according to https://web.dev/samesite-cookies-explained/ there are three possible options for the 'samesite' attribute: - Strict - Lax - None - means you intentionally want the cookie sent in a third-party context. So I think yes we should probably add 'none' as a value along with lax and strict. I have amended the first patch 'Add SameSiteSessionCookie system preference' to add the 'none' option. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 01:25:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 May 2023 23:25:58 +0000 Subject: [Koha-bugs] [Bug 31652] Add geo-search In-Reply-To: <bug-31652-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31652-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31652-70-JCPMSM18Hx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #2 from David Nind <david at davidnind.com> --- The patch no longer applies 8-(... git bz apply 31652 Bug 31652 - Add geo-search 141406 - Bug 31652: Add geo-search Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 31652: Add geo-search .git/rebase-apply/patch:323: trailing whitespace. # can be single or multiple parameters separated by comma: kw,right-Truncation warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M Koha/SearchEngine/Elasticsearch.pm M Koha/SearchEngine/Elasticsearch/QueryBuilder.pm M Koha/SearchEngine/Elasticsearch/Search.pm M admin/searchengine/elasticsearch/field_config.yaml M admin/searchengine/elasticsearch/mappings.yaml M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt M opac/opac-search.pl .git/rebase-apply/patch:323: trailing whitespace. # can be single or multiple parameters separated by comma: kw,right-Truncation warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging opac/opac-search.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging admin/searchengine/elasticsearch/mappings.yaml Auto-merging admin/searchengine/elasticsearch/field_config.yaml CONFLICT (content): Merge conflict in admin/searchengine/elasticsearch/field_config.yaml Auto-merging Koha/SearchEngine/Elasticsearch/Search.pm Auto-merging Koha/SearchEngine/Elasticsearch/QueryBuilder.pm Auto-merging Koha/SearchEngine/Elasticsearch.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 31652: Add geo-search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 04:00:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 02:00:10 +0000 Subject: [Koha-bugs] [Bug 33168] Timeline on "About Koha" is not working for package installs In-Reply-To: <bug-33168-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33168-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33168-70-9ueEL0U0OU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate, | |rel_21_11_candidate --- Comment #48 from Mason James <mtj at kohaaloha.com> --- (In reply to Lucas Gass from comment #47) > Backported to 22.05.x for upcoming 22.05.12 can we get this backported to 21.11 and 21.05 please -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 04:01:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 02:01:52 +0000 Subject: [Koha-bugs] [Bug 32668] Automatic debian/control updates (oldoldstable) In-Reply-To: <bug-32668-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32668-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32668-70-bHBKMgbC3p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32668 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 04:52:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 02:52:24 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface In-Reply-To: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15428-70-rHgbtNPTe3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #17 from David Cook <dcook at prosentient.com.au> --- (In reply to Katrin Fischer from comment #16) > (In reply to David Cook from comment #15) > > (In reply to Katrin Fischer from comment #14) > > > Not only for our use case - currently it's not possible to set different > > > timeouts even if you are using different sub domains which divides the > > > sessions. > > > > I'm not 100% sure I understand what you're saying. > > > > Different subdomains have different cookies, but in Koha there is only the > > "timeout" syspref. Is that what you mean? > > Yes. So if we added a new "opac_timeout" syspref and hooked it into the Auth system, we'd be able to have separate timeouts for OPAC and staff interface, but only for systems that have separate cookies for the OPAC and staff interface. I figure it's probably worth moving forward on that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 04:53:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 02:53:45 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32250-70-1HLmVlwTQs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 --- Comment #21 from David Cook <dcook at prosentient.com.au> --- Just double checking... this is an Elasticsearch issue only right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:02:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 04:02:21 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-4ek1bPNOPN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #29 from David Cook <dcook at prosentient.com.au> --- I am so excited for this one to get in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:15:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 04:15:40 +0000 Subject: [Koha-bugs] [Bug 33191] AutoEmailPrimaryAddress options don't match labels in memberentry In-Reply-To: <bug-33191-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33191-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33191-70-ThuGW7Djb9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33191 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #14 from David Cook <dcook at prosentient.com.au> --- I still wish that we'd done a better shift from home/work to primary/secondary overall. So many libraries use work/secondary emails as the most important email and Koha has made things so confusing over the years. Bug 18398, Bug 33223 and Bug 29046 go a long way to improving things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:43:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 04:43:36 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-5aKBB7mU3H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:52:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 04:52:27 +0000 Subject: [Koha-bugs] [Bug 33592] Use drag&drop or sorting options for AutoEmailPrimaryAddress In-Reply-To: <bug-33592-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33592-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33592-70-cSje4CPuUG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33592 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:55:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 04:55:19 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-LkjKAJzlRz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #3 from David Cook <dcook at prosentient.com.au> --- Bug 33223 - Koha::Patron->notice_email_address isn't consistently used 148168 - Bug 33223: Replace 'first_valid' with 'notice' for email addresses Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 33223: Replace 'first_valid' with 'notice' for email addresses Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt M opac/opac-sendbasket.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-sendbasket.pl CONFLICT (content): Merge conflict in opac/opac-sendbasket.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 33223: Replace 'first_valid' with 'notice' for email addresses hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-33223-Replace-firstvalid-with-notice-for-email-t8SwfM.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:57:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 04:57:43 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-tinld57mnQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #30 from David Cook <dcook at prosentient.com.au> --- Comment on attachment 150125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150125 Bug 29046: Use EmailFieldPrecedence in first_valid_email_address Review of attachment 150125: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=29046&attachment=150125) ----------------------------------------------------------------- ::: Koha/Patron.pm @@ +1439,5 @@ > + > + my @fields = split /\s*\|\s*/, > + C4::Context->preference('EmailFieldPrecedence'); > + for my $field (@fields) { > + $email = $self->$field; You could crash Koha by putting junk into EmailFieldPrecedence. I think either @fields should be validated or $self->$field should be validated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 06:58:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 04:58:18 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-UNau3doqUh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #31 from David Cook <dcook at prosentient.com.au> --- Despite my above comment, I think this should go ahead. It's a valuable contribution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 08:04:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 06:04:25 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32250-70-2aHq2o35Dm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 --- Comment #22 from David Nind <david at davidnind.com> --- (In reply to David Cook from comment #21) > Just double checking... this is an Elasticsearch issue only right? Yes - see step 2 of the 'Only reindex records when commiting' patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 08:41:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 06:41:03 +0000 Subject: [Koha-bugs] [Bug 33648] Errors when enabling ERM in 22.11 In-Reply-To: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33648-70-ieV7cne2aC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33648 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32991 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 [Bug 32991] Improve our Dialog component and remove routes for deletion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 08:41:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 06:41:03 +0000 Subject: [Koha-bugs] [Bug 32991] Improve our Dialog component and remove routes for deletion In-Reply-To: <bug-32991-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32991-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32991-70-XBZspTAxtS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33648 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33648 [Bug 33648] Errors when enabling ERM in 22.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 08:43:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 06:43:41 +0000 Subject: [Koha-bugs] [Bug 33649] Fix use of cronlogaction in process_message_queue.pl In-Reply-To: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33649-70-rcFfQ1qq6x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- There is an other one in misc/cronjobs/fines.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 08:44:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 06:44:25 +0000 Subject: [Koha-bugs] [Bug 33649] Fix use of cronlogaction in process_message_queue.pl In-Reply-To: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33649-70-B0yJFimt8S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31203 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 [Bug 31203] Cronjobs should log completion as well as logging begin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 08:44:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 06:44:25 +0000 Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin In-Reply-To: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31203-70-Sv8jYeVIpt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33649 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 [Bug 33649] Fix use of cronlogaction in process_message_queue.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 08:48:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 06:48:02 +0000 Subject: [Koha-bugs] [Bug 33648] Errors when enabling ERM in 22.11 In-Reply-To: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33648-70-IG8vfDE6V1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33648 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 08:48:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 06:48:05 +0000 Subject: [Koha-bugs] [Bug 33648] Errors when enabling ERM in 22.11 In-Reply-To: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33648-70-knStL6boJE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33648 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150561&action=edit Bug 33648: (bug 32991 follow-up) fix bad resolution conflict Wrong resolution conflict on AgreementsList.vue in commit Bug 32991: Improve our Dialog component in master logged_in_user, + setWarning, + setMessage, in 22.11.x + logged_in_user, + setWarning, + setMessage, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 08:48:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 06:48:15 +0000 Subject: [Koha-bugs] [Bug 33648] Errors when enabling ERM in 22.11 In-Reply-To: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33648-70-cREiFzbVR6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33648 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 08:48:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 06:48:20 +0000 Subject: [Koha-bugs] [Bug 33648] Errors when enabling ERM in 22.11 In-Reply-To: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33648-70-6iw4qQo5AD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33648 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 08:48:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 06:48:25 +0000 Subject: [Koha-bugs] [Bug 33648] Errors when enabling ERM in 22.11 In-Reply-To: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33648-70-IQ1BiuYg0q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33648 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 08:48:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 06:48:34 +0000 Subject: [Koha-bugs] [Bug 33649] Fix use of cronlogaction In-Reply-To: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33649-70-5WT4Cg34Gl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix use of cronlogaction in |Fix use of cronlogaction |process_message_queue.pl | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 08:48:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 06:48:52 +0000 Subject: [Koha-bugs] [Bug 33649] Fix use of cronlogaction In-Reply-To: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33649-70-FqCyLOVr2j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 --- Comment #2 from Magnus Enger <magnus at libriotech.no> --- (In reply to Jonathan Druart from comment #1) > There is an other one in misc/cronjobs/fines.pl. Yeah, just spotted it. :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 08:50:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 06:50:49 +0000 Subject: [Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion In-Reply-To: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33541-70-tUztwji90D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 08:50:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 06:50:52 +0000 Subject: [Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion In-Reply-To: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33541-70-yhzeHK8fJS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150554|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150562&action=edit Bug 33541: Add document type to list of suggestions when ordering This adds the document type (suggestions.itemtype) to the list of accepted suggestions when creating an order from a suggestion. To test: * Add some suggestions and make sure to pick different document types. * Accept those suggestions in the staff interface. * Go to acquisitions * Create a basket * Add an 'order from a suggestion' * Verify that the list shows the 'document type' nicely and correctly * Order one, all good? sign off. Signed-off-by: Juliet <jheltibridle at rcplib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Removed IS_OPAC param from AuthorisedValues.GetByCode Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 08:51:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 06:51:19 +0000 Subject: [Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion In-Reply-To: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33541-70-Wt9a8qMiYE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Katrin Fischer from comment #7) > (In reply to Jonathan Druart from comment #5) > > This table can be configured, you need to update admin/columns_settings.yml > > I think you are confusing the tables. suggestions is, but newordersuggestion > is not configurable. This is the table with accepted suggestions shown when > using "ordering from suggestion". It has no table configuration icons and I > didn't find it in the config. Indeed, I was looking at the wrong table! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:04:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 07:04:20 +0000 Subject: [Koha-bugs] [Bug 33649] Fix use of cronlogaction In-Reply-To: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33649-70-U3DnnSQv0r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:04:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 07:04:22 +0000 Subject: [Koha-bugs] [Bug 33649] Fix use of cronlogaction In-Reply-To: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33649-70-oALo6q8R5g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 --- Comment #3 from Magnus Enger <magnus at libriotech.no> --- Created attachment 150563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150563&action=edit Bug 33649: Fix use of cronlogaction C4::Log::cronlogaction() takes a hashref as argument, with "info" and possibly "action" as keys. But there are a couple of places where it is called with just a string as argument, and that does not work. Both places need lock_exec to fail to trigger the error. I have seen this on a production server, but not been able to reproduce in ktd. To test: - Run this on the Koha repo: grep -r "cronlogaction(" * - Verify that fines.pl and process_message_queue.pl are the only scripts that call cronlogaction without a hashref as argument, but do it like this: cronlogaction( $message ); - Apply this patch - Run the grep again and verify that all calls to cronlogaction now take a hashref as argument -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:05:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 07:05:15 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-uZVrGqC3B7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- There is another problem: https://snipboard.io/Odhrai.jpg The .modal rule should apply to the modal of the EHoldingsEBSCOPackageAgreements component only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:05:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 07:05:38 +0000 Subject: [Koha-bugs] [Bug 33658] New: Capitalization: **To Reproduce** Message-ID: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658 Bug ID: 33658 Summary: Capitalization: **To Reproduce** Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Found while translating: **To Reproduce** installer/data/mysql/en/optional/sample_news.yml:additional_contents:1:row:4:mul:6 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:05:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 07:05:43 +0000 Subject: [Koha-bugs] [Bug 33658] Capitalization: **To Reproduce** In-Reply-To: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33658-70-BPKsppC74Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:06:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 07:06:10 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-6MNQit6rC8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150564&action=edit Bug 33491: Add a more specific class for the modal We don't want to apply these CSS rules to other modals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:09:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 07:09:54 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-BJvQbegHs5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150565&action=edit [ALTERNATIVE-PATCH] Bug 33551: Remove span from restriction-types.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:10:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 07:10:45 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-wHwLPecbyj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Why not simply this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:20:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 07:20:15 +0000 Subject: [Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST API In-Reply-To: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33470-70-uE5K7eD0pX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Please provide tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:21:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 07:21:16 +0000 Subject: [Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST API In-Reply-To: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33470-70-ltcdxXM87f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Sorry, I misread there is no behaviour changes expected here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:23:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 07:23:06 +0000 Subject: [Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST API In-Reply-To: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33470-70-zlNWWUE3u5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- What's the point of the changes then? Be faster? There are behaviour changes, 400 instead of 403 in case of invalid pickup locations. Maybe that's why it has been written that way in the first place? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:30:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 07:30:39 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-XXzfFGz3CB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Ok, you win - that's a good idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:34:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 07:34:38 +0000 Subject: [Koha-bugs] [Bug 33645] koha-foreach always returns 1 if --chdir not specified In-Reply-To: <bug-33645-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33645-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33645-70-v8E2ODDQxQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33645 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:34:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 07:34:40 +0000 Subject: [Koha-bugs] [Bug 33645] koha-foreach always returns 1 if --chdir not specified In-Reply-To: <bug-33645-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33645-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33645-70-hxoHJVYGIx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33645 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150492|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150566&action=edit Bug 33645: Make koha-foreach return 0 if it completes successfully This patch adds an "exit 0" to the end of koha-foreach, so that it returns a successful exit code if it reaches the bottom of the script without errors. Test plan: 0) `koha-foreach echo` 1) `echo $?` 2) Note that the exit status is 1 3) Apply patch 4) `./debian/scripts/koha-foreach echo` 5) `echo $?` 6) Note that the exit status is 0 Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:35:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 07:35:25 +0000 Subject: [Koha-bugs] [Bug 33036] REST API: Merge biblio records In-Reply-To: <bug-33036-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33036-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33036-70-ANayjyUZin@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 Mark Hofstetter <koha at trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |koha at trust-box.at |ity.org | CC| |koha at trust-box.at -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:35:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 07:35:35 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface In-Reply-To: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15428-70-UMzPp576F4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- But how do we know if it's an OPAC or a staff side cookie? Maybe naming the cookies differently and by that allowing to really have separate sessions independent of setup would be better. One reason to use ports is to block access to the staff interface in a firewall. It's a valid configuration option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:45:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 07:45:18 +0000 Subject: [Koha-bugs] [Bug 30367] Plugins: Search explodes in error when searching for specific keywords In-Reply-To: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30367-70-IrkMDKLpfc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- You are fixing for github, not gitlab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 09:46:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 07:46:11 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-aw7guK10jy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Lari Strand <lmstrand at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmstrand at gmail.com --- Comment #28 from Lari Strand <lmstrand at gmail.com> --- We use our custom value builder plugins for adding various keywords from an online vocabulary using dynamically created select2 elements. These patches fixed the issue with plugins not initialising on cloned fields. I needed to change the code so the plugin gets initialised with a click-function, formerly mouseover in the input field. "Events removed: change, mouseover, mouseout, mousedown, mouseup, mousemove, keydown, keypress, keyup. If you ever need one of those, you can still add event listeners in the 'focus' event handler, and remove them in the 'blur' event handler" How would I bring mouseover back as a valid function in code? What kind of performance issues do you mean by "'mouseover' and 'mousemove' are not used and would trigger too much events."? I also received a report that the patch breaks field/subfield cloning on Firefox 78.12.0esr. Apparently the field does not get cloned and the page goes to the top. They've tried to clear the browser cache. Does this make any sense? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 10:00:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 08:00:03 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-jDjxg35YhC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #29 from Lari Strand <lmstrand at gmail.com> --- (In reply to Lari Strand from comment #28) > We use our custom value builder plugins for adding various keywords from an > online vocabulary using dynamically created select2 elements. These patches > fixed the issue with plugins not initialising on cloned fields. I needed to > change the code so the plugin gets initialised with a click-function, > formerly mouseover in the input field. > > "Events removed: change, mouseover, mouseout, mousedown, mouseup, > mousemove, keydown, keypress, keyup. > If you ever need one of those, you can still add event listeners in > the 'focus' event handler, and remove them in the 'blur' event > handler" > > How would I bring mouseover back as a valid function in code? What kind of > performance issues do you mean by "'mouseover' and 'mousemove' are not used > and would trigger too much events."? > > I also received a report that the patch breaks field/subfield cloning on > Firefox 78.12.0esr. Apparently the field does not get cloned and the page > goes to the top. They've tried to clear the browser cache. Does this make > any sense? Also reportedly for fixed fields (000, 006, 007 and 008) Koha's own editors stopped working with this older ESR version of Firefox. Newer browser versions and for example switching to Edge everything was ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 10:20:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 08:20:47 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-x15bGpmz9C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #30 from Julian Maurice <julian.maurice at biblibre.com> --- > How would I bring mouseover back as a valid function in code? Can you post a link to your plugin ? > What kind of performance issues do you mean by "'mouseover' and 'mousemove' > are not used and would trigger too much events."? I admit I did not measure it, but with the new method used here (event delegation), the browser would have to trigger tens of mouse events every time the mouse move inside the editor, which I assumed would introduce perfomance issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 10:57:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 08:57:31 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-xlnxpr2O0V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #53 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #52) > Please have a look at bug 33445 that is suggesting to revert these patches! ping Thibaud? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 11:18:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 09:18:30 +0000 Subject: [Koha-bugs] [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider In-Reply-To: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32412-70-b5WzVvWy27@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150567&action=edit Bug 32412: Do not reload COCE image for biblio We do not want to fetch again the new image for the biblio record. We only want to fetch those for the shelf browser. Note that the third parameter 'covernewwindow' was not used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 11:18:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 09:18:49 +0000 Subject: [Koha-bugs] [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider In-Reply-To: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32412-70-KMqZvVJrOg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Lucas, your patch is working but I think it's actually hiding another bug: we should not reload the image for the bibliographic record when we are browsing the shelf. Do you agree with my follow-up patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 11:23:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 09:23:53 +0000 Subject: [Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities In-Reply-To: <bug-31185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31185-70-4Lx3w7efEl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 11:34:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 09:34:26 +0000 Subject: [Koha-bugs] [Bug 32921] SelfCheckTimeout doesn't logout if SelfCheckReceiptPrompt modal is open In-Reply-To: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32921-70-IZP38JtxuS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 11:34:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 09:34:28 +0000 Subject: [Koha-bugs] [Bug 32921] SelfCheckTimeout doesn't logout if SelfCheckReceiptPrompt modal is open In-Reply-To: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32921-70-W9NW0fmJDI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149779|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150568&action=edit Bug 32921: Honor SelfCheckTimeout when modal is open To test: 1. Set the 'SelfCheckTimeout' system preference to something low for testing. 2. Make sure 'SelfCheckReceiptPrompt' is set to 'Show'. 3. Log in to SCO and press finish but leave the modal open. 4. Wait until the 'SelfCheckTimeout' time has expired, nothing happens. 5. Apply patch and try again. You should be logged out when SelfCheckTimeout expires. Signed-off-by: Marius Mandrescu <marius.mandrescu at inLibro.com> JD amended patch - fix indentation Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 11:44:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 09:44:25 +0000 Subject: [Koha-bugs] [Bug 33176] Improve enforcing of RequirePaymentType In-Reply-To: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33176-70-SPJksUYW4x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- If you want to prevent manual edition of the DOM to get empty value, then you should also prevent bad value. It's possible to get payment_type=FOO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 11:48:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 09:48:01 +0000 Subject: [Koha-bugs] [Bug 33612] Staff with limited permissions don't always get an expanded catalog_search bar In-Reply-To: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33612-70-4oQA5CniSy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- You are changing the selected tab, is that expected? mainpage now has "search catalog", it was "Checkout". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 11:52:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 09:52:58 +0000 Subject: [Koha-bugs] [Bug 33018] debian package tidy-up In-Reply-To: <bug-33018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33018-70-YKESWU78p4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I would not remove CPAN::Meta from the cpanfile: commit a34d086a24b1e4519f8b31331d4c42b87b8e4a83 Bug 19735: Move Perl deps definitions into a cpanfile Added dependencies: - Module::CPANfile - CPAN::Meta (dependency of Module::CPANfile, but we need a more recent version than the one Module::CPANfile requires) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 11:57:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 09:57:37 +0000 Subject: [Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice In-Reply-To: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33314-70-eHLf8hjNbw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |jonathan.druart+koha at gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Blocked by bug 33313. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 12:38:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 10:38:22 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-8zUuDEw6YC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #47 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to David Cook from comment #43) > (In reply to Jonathan Druart from comment #42) > > Ok, let's discuss then. What do we do? > > > > I am ok with having our module where Data::Session is expecting it. > > How do you propose to do that in production though? > > The only reasonable option I see would be creating our > Data::Session::Serializer::yamlxs as a standalone library (with its own git > repository), and then packaging that and storing it in the Koha Community > APT repo, and then adding it as a Koha dependency. I don't understand. Why isn't this ok for production? It's what we do already for CGI::Session -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 12:41:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 10:41:05 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-jUGPTjWxMN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 12:41:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 10:41:08 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-32LAMxY3Az@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121657|0 |1 is obsolete| | Attachment #121658|0 |1 is obsolete| | Attachment #121659|0 |1 is obsolete| | --- Comment #48 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150569&action=edit Bug 17427: Replace CGI::Session with Data::Session CGI::Session is not maintained for ages and seems quite buggy. It would be the culprit of random logout problems. Another issue is the following crazy code in CGI::Session::Driver::DBI sub DESTROY { my $self = shift; unless ( defined $self->{Handle} && $self->{Handle} -> ping ) { $self->set_error(__PACKAGE__ . '::DESTROY(). Database handle has gone away'); return; } unless ( $self->{Handle}->{AutoCommit} ) { $self->{Handle}->commit; } if ( $self->{_disconnect} ) { $self->{Handle}->disconnect; } } If AutoCommit is off, it will commit anyway... It causes some tests to fail (api) if SessionStorage is set to MySQL Note that PostgreSQL is not supported yet so no need to implement it. Test plan: 0/ The dependencies are not packaged for debian so far, so install it via cpan 1/ Test the 3 different values for SessionStorage 2/ Using different browsers (or sessions) login into Koha with different users. Naviguate => you should not be logged out 3/ Set SessionStorage to Memcached, stop memcached make sure that it defaults to file. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 12:41:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 10:41:12 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-r95v33bn0K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #49 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150570&action=edit Bug 17427: Use JSON serialization -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 12:41:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 10:41:16 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-rEXmGd7246@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #50 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150571&action=edit Bug 17427: Use our own YAML::XS serializer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 12:41:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 10:41:41 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-6rNkLDYLdh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #51 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Patches rebased, status back to NSO. Why isn't this ready? What am I missing? Everything is working correctly in my tests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 12:42:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 10:42:04 +0000 Subject: [Koha-bugs] [Bug 29942] Spurious commit in mysql session storage In-Reply-To: <bug-29942-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29942-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29942-70-FXPlogD4VS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29942 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17427 | Status|NEW |RESOLVED --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- *** This bug has been marked as a duplicate of bug 17427 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 12:42:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 10:42:04 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-Th4FdVt9Gv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29942 | CC| |andreas.jonsson at kreablo.se --- Comment #52 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- *** Bug 29942 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 12:46:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 10:46:43 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-qVTabH6G8Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #53 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This needs more work to be ready for push: * Adjust deps (cpanfile) * `git grep CGI::Session` occurrences to be adjusted * Remove FIXMEs from api tests But please test and tell me if it's worth spending time to continue here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 12:50:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 10:50:25 +0000 Subject: [Koha-bugs] [Bug 33659] New: Using TT in CSV profiles is undocumented Message-ID: <bug-33659-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33659 Bug ID: 33659 Summary: Using TT in CSV profiles is undocumented Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: Needs documenting Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When creating a CSV profile, it says: You can use Template Toolkit tags too. See the help page for more information. But I didn't find any documentation in the Manual. It looks like the bug introducing this was bug 12404. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 12:57:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 10:57:41 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-ifcEUlzUWR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #54 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #53) > This needs more work to be ready for push: > * Adjust deps (cpanfile) > * `git grep CGI::Session` occurrences to be adjusted > * Remove FIXMEs from api tests > > But please test and tell me if it's worth spending time to continue here. I seems worthwhile to me if only because CGI::Session is unmaintained! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 12:59:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 10:59:44 +0000 Subject: [Koha-bugs] [Bug 30367] Plugins: Search explodes in error when searching for specific keywords In-Reply-To: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30367-70-aL1Yt9yee3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 12:59:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 10:59:47 +0000 Subject: [Koha-bugs] [Bug 30367] Plugins: Search explodes in error when searching for specific keywords In-Reply-To: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30367-70-EsK6cxZGlA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367 --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150572&action=edit Bug 30367: (follow-up) Same adjustment for gitlab This adds the same update for gitlab code. I was unable to trigger the error, however, I confirm searching for 'PayPal' returns a result after this patch as well as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:08:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:08:56 +0000 Subject: [Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST API In-Reply-To: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33470-70-TTRKtxIw1v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #6) > What's the point of the changes then? Be faster? Yes, performance. Biblio->pickup_locations can take a long time when there are many items/branches > There are behaviour changes, 400 instead of 403 in case of invalid pickup > locations. Maybe that's why it has been written that way in the first place? (In reply to Jonathan Druart from comment #6) > What's the point of the changes then? Be faster? > > There are behaviour changes, 400 instead of 403 in case of invalid pickup > locations. Maybe that's why it has been written that way in the first place? I get a 400 for an invalid pickup location before and after, can you describe the case you are seeing changed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:20:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:20:16 +0000 Subject: [Koha-bugs] [Bug 33659] Using TT in CSV profiles is undocumented In-Reply-To: <bug-33659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33659-70-sXAWZXzMuY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33659 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12404 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 [Bug 12404] CSV profiles improvements (concatenations, substrings, conditions...) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:20:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:20:16 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements (concatenations, substrings, conditions...) In-Reply-To: <bug-12404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12404-70-u85NMzY4Sz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33659 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33659 [Bug 33659] Using TT in CSV profiles is undocumented -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:20:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:20:58 +0000 Subject: [Koha-bugs] [Bug 33659] Using TT in CSV profiles is undocumented In-Reply-To: <bug-33659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33659-70-t6VJRswxIP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33659 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It looks like this got lost when we removed the old help pages in favor of links to the manual: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35052 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:22:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:22:59 +0000 Subject: [Koha-bugs] [Bug 33649] Fix use of cronlogaction In-Reply-To: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33649-70-3ogZTReSUV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:23:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:23:01 +0000 Subject: [Koha-bugs] [Bug 33649] Fix use of cronlogaction In-Reply-To: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33649-70-lONH5geNhO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150563|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150573&action=edit Bug 33649: Fix use of cronlogaction C4::Log::cronlogaction() takes a hashref as argument, with "info" and possibly "action" as keys. But there are a couple of places where it is called with just a string as argument, and that does not work. Both places need lock_exec to fail to trigger the error. I have seen this on a production server, but not been able to reproduce in ktd. To test: - Run this on the Koha repo: grep -r "cronlogaction(" * - Verify that fines.pl and process_message_queue.pl are the only scripts that call cronlogaction without a hashref as argument, but do it like this: cronlogaction( $message ); - Apply this patch - Run the grep again and verify that all calls to cronlogaction now take a hashref as argument Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:27:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:27:11 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements (concatenations, substrings, conditions...) In-Reply-To: <bug-12404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12404-70-B2mSeeV5Y1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #61 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I tried to use an example from the old help file, but I got: + <li>Display all 245$a and 245$c into the same column: + <p> + [% FOREACH field IN fields.245 %] + [% field.a %] [% field.c %] + [% END %] + </p> + </li> Titel=[% FOREACH field IN fields.245 %][% field.a %] [% field.b %] [% field.n %] [% field.p %] [% field.c %][% END %] ARRAY(0x5642032a0638) ARRAY(0x564202a832f0) ARRAY(0x564203388d48) ARRAY(0x5642033cc020) ARRAY(0x564203439cc0) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:30:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:30:21 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-RpbF4bZfAy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:30:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:30:23 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-SmV4l4U4zW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150574&action=edit Bug 33607: (follow-up) Handle default framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:34:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:34:27 +0000 Subject: [Koha-bugs] [Bug 33648] Errors when enabling ERM in 22.11 In-Reply-To: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33648-70-BgqLwxUQ6G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33648 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks for the quick fix Jonathan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:38:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:38:50 +0000 Subject: [Koha-bugs] [Bug 33648] Errors when enabling ERM in 22.11 In-Reply-To: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33648-70-hFpJg6Nr0o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33648 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:38:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:38:51 +0000 Subject: [Koha-bugs] [Bug 33648] Errors when enabling ERM in 22.11 In-Reply-To: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33648-70-s6kiTzX1wS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33648 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:39:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:39:13 +0000 Subject: [Koha-bugs] [Bug 33648] Errors when enabling ERM in 22.11 In-Reply-To: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33648-70-1Pu7mfpdaJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33648 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.06 |22.11.05-1 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:39:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:39:40 +0000 Subject: [Koha-bugs] [Bug 33648] Errors when enabling ERM in 22.11 In-Reply-To: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33648-70-jdnCGs1yyo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33648 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Adding now and will ask Mason to role a 22.11.05-1 package for us to include this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:45:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:45:13 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-aGQjdEtUYT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32594 CC| |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 [Bug 32594] Add a dedicated ES indexing background worker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:45:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:45:13 +0000 Subject: [Koha-bugs] [Bug 32594] Add a dedicated ES indexing background worker In-Reply-To: <bug-32594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32594-70-bHqHRGCx6l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33486 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:45:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:45:14 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-q4gb4MeK9n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #54 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- (In reply to Jonathan Druart from comment #53) > (In reply to Jonathan Druart from comment #52) > > Please have a look at bug 33445 that is suggesting to revert these patches! > > ping Thibaud? Hello Jonathan, Sorry for the delay, I saw and read the bug 33445 apparently other patches have been proposed to replace the revert. But I understand the problematic behavior of this one.. Do you think there is a need for me to do something? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:45:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:45:26 +0000 Subject: [Koha-bugs] [Bug 30367] Plugins: Search explodes in error when searching for specific keywords In-Reply-To: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30367-70-nW8MShzh2J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:45:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:45:29 +0000 Subject: [Koha-bugs] [Bug 30367] Plugins: Search explodes in error when searching for specific keywords In-Reply-To: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30367-70-QedyA2Dgr5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150527|0 |1 is obsolete| | Attachment #150572|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150575&action=edit Bug 30367: Skip processing if we don't get releases Some repos don't have releases, and this seems to break things as get returns an empty response. Calling from_json on this is the error This simply skips the bad responses to avoid the error: To test: 1. Have this on your koha-conf.xml file: <plugin_repos> <repo> <name>ByWater Solutions</name> <org_name>bywatersolutions</org_name> <service>github</service> </repo> <repo> <name>Theke Solutions</name> <org_name>thekesolutions</org_name> <service>gitlab</service> </repo> <repo> <name>PTFS Europe</name> <org_name>ptfs-europe</org_name> <service>github</service> </repo> </plugin_repos> 2. Restart all services: $ restart_all 3. Search for the term 'barclaycard' The search will give an error: malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm line 190 4. Apply patch 5. Repeat 6. No error Note: The barclaycard plugin won't install even though it is returned as of this note - the plugin needs an update I believe, I don't think it's a Koha issue Signed-off-by: David Nind <david at davidnind.com> JD amended patch: fix indentation Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:45:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:45:31 +0000 Subject: [Koha-bugs] [Bug 30367] Plugins: Search explodes in error when searching for specific keywords In-Reply-To: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30367-70-dH1Tbsw2Qk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367 --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150576&action=edit Bug 30367: (follow-up) Same adjustment for gitlab This adds the same update for gitlab code. I was unable to trigger the error, however, I confirm searching for 'PayPal' returns a result after this patch as well as before. JD amended patch: fix indentation Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:48:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:48:07 +0000 Subject: [Koha-bugs] [Bug 33649] Fix use of cronlogaction In-Reply-To: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33649-70-z7BMDS7QgN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:48:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:48:09 +0000 Subject: [Koha-bugs] [Bug 33649] Fix use of cronlogaction In-Reply-To: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33649-70-dQhyzkEax7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150573|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150577&action=edit Bug 33649: Fix use of cronlogaction C4::Log::cronlogaction() takes a hashref as argument, with "info" and possibly "action" as keys. But there are a couple of places where it is called with just a string as argument, and that does not work. Both places need lock_exec to fail to trigger the error. I have seen this on a production server, but not been able to reproduce in ktd. To test: - Run this on the Koha repo: grep -r "cronlogaction(" * - Verify that fines.pl and process_message_queue.pl are the only scripts that call cronlogaction without a hashref as argument, but do it like this: cronlogaction( $message ); - Apply this patch - Run the grep again and verify that all calls to cronlogaction now take a hashref as argument Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:48:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:48:36 +0000 Subject: [Koha-bugs] [Bug 33649] Fix use of cronlogaction In-Reply-To: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33649-70-DAnl3Q9Nti@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Can be tested easily adding a sleep right after the lock. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:52:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:52:52 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-sSjtWSzDYX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |ASSIGNED --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- 22.11.05 should NOT have had this.. we missed the dependencies as they weren't listed in the depends on. I'm reverting for a 22.11.05-1 release. We'll be restoring this, along with the proper tree of bugs beneath it for 22.11.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:52:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:52:59 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-MnknrhcY5H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:53:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:53:04 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-2eJksqPSDO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:53:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:53:13 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-liccNtWkwF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05 |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:56:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:56:41 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-9mQtcDQgSC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:56:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:56:43 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-TI2tMOLTpd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150238|0 |1 is obsolete| | --- Comment #6 from David Nind <david at davidnind.com> --- Created attachment 150578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150578&action=edit Bug 33607: Add framework display to staff details page This patch adds a Frameworks pluing to allow fetching the framework text and displays this on the intranet details page To test: 1 - Apply patch 2 - View a record details page in staff 3 - Confirm you see the framework name 4 - prove -v t/db_dependent/Template/Plugin/Frameworks.t Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:56:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:56:46 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-tv1NDxCPfn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150574|0 |1 is obsolete| | --- Comment #7 from David Nind <david at davidnind.com> --- Created attachment 150579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150579&action=edit Bug 33607: (follow-up) Handle default framework Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:58:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:58:16 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-tonviqrq4G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #55 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #53) > This needs more work to be ready for push: > * Adjust deps (cpanfile) > * `git grep CGI::Session` occurrences to be adjusted > * Remove FIXMEs from api tests > > But please test and tell me if it's worth spending time to continue here. +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 13:59:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 11:59:57 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-R91rIrheKc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 14:01:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 12:01:11 +0000 Subject: [Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6 In-Reply-To: <bug-32910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32910-70-V8ZoDQ5hPF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate --- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Early push candidate for 23.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 14:07:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 12:07:15 +0000 Subject: [Koha-bugs] [Bug 29664] Do not show voided payments in cash_register_stats.pl In-Reply-To: <bug-29664-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29664-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29664-70-70RjHyk9H0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 14:07:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 12:07:17 +0000 Subject: [Koha-bugs] [Bug 29664] Do not show voided payments in cash_register_stats.pl In-Reply-To: <bug-29664-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29664-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29664-70-XSMHjP9o28@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150456|0 |1 is obsolete| | --- Comment #11 from David Nind <david at davidnind.com> --- Created attachment 150580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150580&action=edit Bug 29664: Do not show voided payments in cash_register_stats.pl Test Plan: 1) Set up your cash register 2) Take a payment 3) Void that payment 4) Verify the voided fee shows for the "All payments to the library" and "Payment" transaction type filters 5) Apply this patch 6) Restart all the things! 7) Verify the voided fee no longer shows for the "All payments to the library" and "Payment" transaction type filters Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 14:12:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 12:12:35 +0000 Subject: [Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST API In-Reply-To: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33470-70-2Nx1wniGVC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Hum indeed, sorry! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 14:13:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 12:13:33 +0000 Subject: [Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST API In-Reply-To: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33470-70-GAhjky1Y13@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 14:13:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 12:13:35 +0000 Subject: [Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST API In-Reply-To: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33470-70-okwEki7zk9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149410|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150581&action=edit Bug 33470: Don't calculate overridden hold limits This patch can largely be checked in the code to ensure it makes sense, it moves a conditional up one level for the two different checks that could prevent holds To test: 1 - Attempt to place a hold via the REST API with an invalid pickup location Set pickup location as no in branches to make this easy 2 - Confirm you get an error 3 - Attempt again with header (bug 27760): x-koha-override: any 4 - Hold is placed 5 - Repeat 1-4 above but with an item that cannot be held 6 - Apply patch 7 - Repeat 1-4 above 8 - Results should be the same Signed-off-by: Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 14:22:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 12:22:36 +0000 Subject: [Koha-bugs] [Bug 32594] Add a dedicated ES indexing background worker In-Reply-To: <bug-32594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32594-70-UQMS43vM3O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 14:22:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 12:22:38 +0000 Subject: [Koha-bugs] [Bug 32594] Add a dedicated ES indexing background worker In-Reply-To: <bug-32594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32594-70-IxRUdXtkp4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 --- Comment #46 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 14:22:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 12:22:40 +0000 Subject: [Koha-bugs] [Bug 32992] Move background worker script to misc/workers In-Reply-To: <bug-32992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32992-70-4MWfvwzCvx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32992 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 14:22:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 12:22:41 +0000 Subject: [Koha-bugs] [Bug 32992] Move background worker script to misc/workers In-Reply-To: <bug-32992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32992-70-l1NADlSKa2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32992 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 14:22:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 12:22:43 +0000 Subject: [Koha-bugs] [Bug 33108] We need a way to launch the ES indexer automatically In-Reply-To: <bug-33108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33108-70-sjKB0WgJyz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 14:22:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 12:22:45 +0000 Subject: [Koha-bugs] [Bug 33108] We need a way to launch the ES indexer automatically In-Reply-To: <bug-33108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33108-70-hnx5Lw5dBV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 14:22:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 12:22:46 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-qc9cdWdx2d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 14:22:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 12:22:48 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-sBpYcCF69j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 14:32:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 12:32:56 +0000 Subject: [Koha-bugs] [Bug 32748] Library limitations will cause data loss when editing items In-Reply-To: <bug-32748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32748-70-zCB4dLJl8u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32748 --- Comment #15 from mathieu saby <mathsabypro at gmail.com> --- Yes, the data loss is a nasty bug and must be fixed. Perhaps my embarrassment arises from the fact that Koha relies exclusively on the librarian's connection library to filter the possible locations. Most of the time this is not a problem, but if the item's homebranch is different from the connexion library, it leads to a behavior that can be inconvenient or surprising. One could imagine that Koha relies dynamically on the homebranch defined in the form to determine the possible locations, like some other ILS. This has not been the initial choice of the community, but do you think it could be worth thinking about (in an other bug...) ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:20:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:20:07 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-VqrQjcXFIA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:20:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:20:09 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-Jgs3o12EpU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150582&action=edit Bug 33653: Never consider received orders as late We should not list received orders on the late orders page. Test plan: * Create a basket * Create a normal order (not from a subscription, no standing order) * Leave estimated delivery date empty * Close the basket * Create a new invoice and receive the order line * Go to acq > late orders * Verify the order is not in the list * Set filter for 'To' date into the future, i.e. 01/01/2025 => Without this patch the order shows up => With this patch applied the received order does not show up -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:20:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:20:34 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-HOLy6xCFvK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Not sure this is a regression, hence not sure it's a major. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:20:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:20:37 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-LziEHr3Ush@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:22:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:22:21 +0000 Subject: [Koha-bugs] [Bug 26802] Improve speed with records with many items In-Reply-To: <bug-26802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26802-70-1gmeckq6ND@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26802 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com See Also|https://bugs.koha-community |https://bugs.koha-community |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi |?id=33167 |?id=33568 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:22:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:22:21 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-00srS09TIh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26802 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:22:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:22:21 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff record details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-peIHH8Yipm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26802 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:23:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:23:28 +0000 Subject: [Koha-bugs] [Bug 26802] Improve speed with records with many items In-Reply-To: <bug-26802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26802-70-FDGoetxPKY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26802 --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to David Cook from comment #8) > (In reply to David Nind from comment #5) > > (In reply to Fridolin Somers from comment #4) > > > > - Add pagination to the items table (like is done with other Koha tables) and JS load. > > > I suggest this bug focus on this point > > > > +1 > > This could have other consequences but I think it's absolutely necessary at > this point. See bug 33568. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:39:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:39:53 +0000 Subject: [Koha-bugs] [Bug 26932] Importing staged bibliographic MARC records does not show a completed status if there are any item records to stage In-Reply-To: <bug-26932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26932-70-jowp9BhL6l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26932 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:42:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:42:37 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28328-70-YMWjWwED5L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:42:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:42:40 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28328-70-sPKQXmjEmf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150583&action=edit Bug 28328: Extend biblioitems.lccn to longtext Same sa issn and isbn, we want lccn to allow longer values. Test plan: Run the updatedatabase script to modify the DB structure restart_all Edit a bibliographic record and enter a long (more than 25 chars) lccn Save -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:42:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:42:42 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28328-70-b2ki495KCT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150584&action=edit Bug 28328: DBIC schema changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:42:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:42:45 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28328-70-YHzeJMGysi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150585&action=edit Bug 28328: Adjust tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:43:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:43:00 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28328-70-IcElsIaIR8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:44:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:44:12 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-dJjXNCOguA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Janusz Kaczmarek from comment #2) > (In reply to Janusz Kaczmarek from comment #1) > > > > I.e. changing ~ into '' for all MARC fields except 245. > > > > I meant, for title search field, of course. Hi Janusz, thx for the insight, this is really helpful. I also found bug 32479. Would you agree that all ~ shoudl be replaced by "" or 0? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:48:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:48:24 +0000 Subject: [Koha-bugs] [Bug 33069] File download from list in OPAC gives error In-Reply-To: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33069-70-GQjQuyOkXv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 kevin.ayrault87 at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin.ayrault87 at gmail.com --- Comment #2 from kevin.ayrault87 at gmail.com --- I have the same error and after check the code, i see maybe the correction. In line 93, there is an extra "->" after "record" in my opinion. When I replace the line "my $record = $biblio->metadata->record->(" with "my $record = $biblio->metadata->record(", the download works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:52:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:52:57 +0000 Subject: [Koha-bugs] [Bug 32748] Library limitations will cause data loss when editing items In-Reply-To: <bug-32748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32748-70-OjPIuj5umA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32748 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Failing QA for comment 12. Thibaud, avoid GROUP_CONCAT, and just don't display the libraries from where the value is limited. Also you should cache using the branchcode in the cache key, or you will get random wrong results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:55:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:55:23 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28328-70-1KZ5yDWKGB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:55:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:55:25 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28328-70-zsIjdqIkAQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150583|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150586&action=edit Bug 28328: Extend biblioitems.lccn to longtext Same sa issn and isbn, we want lccn to allow longer values. Test plan: Run the updatedatabase script to modify the DB structure restart_all Edit a bibliographic record and enter a long (more than 25 chars) lccn Save Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:55:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:55:27 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28328-70-xcH8dBcsJZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150584|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150587&action=edit Bug 28328: DBIC schema changes Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 15:55:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 13:55:29 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28328-70-dZpVnV5H90@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150585|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150588&action=edit Bug 28328: Adjust tests Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:03:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:03:19 +0000 Subject: [Koha-bugs] [Bug 33660] New: Allow editing "Create items when" when no orders have been created Message-ID: <bug-33660-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33660 Bug ID: 33660 Summary: Allow editing "Create items when" when no orders have been created Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When a new basket is created, the "Create items when" can be set. But: Once the basket has been saved, this filed is missing from the form. Suggestion: * Allow editing of the field when no orders have been created yet. * When orders exist, show the field as read only with a hint to avoid questions/confusion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:10:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:10:04 +0000 Subject: [Koha-bugs] [Bug 33661] New: Show number of accepted suggestions in list of options for creating a new order line Message-ID: <bug-33661-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33661 Bug ID: 33661 Summary: Show number of accepted suggestions in list of options for creating a new order line Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: michaela.sieber at kit.edu It would be a nice little enhancement if the number of suggestions ready for ordering was more visible during the ordering process. The number of accepted suggestions could be added to the link: * Create a basket * Click "Add to basket" button * Modal shows various options for ordering including "From a suggestion" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:10:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:10:47 +0000 Subject: [Koha-bugs] [Bug 33660] Allow editing "Create items when" when no orders have been created In-Reply-To: <bug-33660-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33660-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33660-70-FpV51VKqvt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33660 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:16:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:16:59 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-jS9G5i1bzO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #56 from Kyle M Hall <kyle at bywatersolutions.com> --- I'm getting the error "Data::Session. Unknown serialize 'yamlxs' at /usr/local/share/perl/5.32.1/Data/Session.pm line 752". I installed Data::Session, are there other deps I missed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:17:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:17:11 +0000 Subject: [Koha-bugs] [Bug 19249] Date picker broken in "Quick add new patron" form In-Reply-To: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19249-70-KwFZpVdssa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:17:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:17:14 +0000 Subject: [Koha-bugs] [Bug 19249] Date picker broken in "Quick add new patron" form In-Reply-To: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19249-70-ExT6RQchd1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150589&action=edit Bug 19249: Fix date inputs on patron quick add form This patch create a "apply_flatpickr" JS function to make the code reusable from the template, where we loop over the date inputs to reinstantiate flatpickr. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:17:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:17:36 +0000 Subject: [Koha-bugs] [Bug 19249] Date picker broken in "Quick add new patron" form In-Reply-To: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19249-70-bAuqYscFG2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:17:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:17:53 +0000 Subject: [Koha-bugs] [Bug 33662] New: Improve visibility of acq advanced search Message-ID: <bug-33662-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33662 Bug ID: 33662 Summary: Improve visibility of acq advanced search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, oleonard at myacpl.org With the new staff design we now require 3 clicks to get to the advanced search in the acquisition module: * Switch to Orders search tab * Open additional options * Click on Advanced search link That's one click more than in earlier versions and it makes it hard to find the page in general. In the serials module we have opted to display the search form right on the start page, which got some positive feedback already. In acq the space is more limited, because we show the budgets/funds summary table. Maybe we could add a link to advanced search in the first section (vendor search) or the sidebar navigation? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:18:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:18:01 +0000 Subject: [Koha-bugs] [Bug 33662] Improve visibility of acq advanced search In-Reply-To: <bug-33662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33662-70-4mJbx6YZ9u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33662 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:22:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:22:49 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28166-70-23tquxYq2o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 --- Comment #12 from Mark Hofstetter <koha at trust-box.at> --- Must fix: - the patch adds the function _add_rowdata, I think it's a rebase leftover? => OK, done - the call from _handle_one_result should be updated to pass the biblio related preference to the updated routine => I really don't understand this one, "_handle_one_result" is only used for bibs so nothing changes here - delete the commented lines from the code => OK, done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:23:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:23:56 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28166-70-bITfl6yKlL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Mark Hofstetter <koha at trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148778|0 |1 is obsolete| | --- Comment #13 from Mark Hofstetter <koha at trust-box.at> --- Created attachment 150590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150590&action=edit Bug 28166: Optionally add MARC fields to authority search adds the same feature to Authority Search as in the "normal" Z39.50 search, to display arbitrary marc fields in the search results 1. apply patch 2. go to System preferences->Authorities preferences 3. the new option "AdditionalFieldsInZ3950ResultAuthSearch" shows up 4. enter the additional field numbers you want to see eg '001' 5. make an "Authority" search via Z39.50 6. the new new column "Additional fields" will display 7. sign off ;-) Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> Signed-off-by: Clemens Tubach <clemens.tubach at kit.edu> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:27:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:27:30 +0000 Subject: [Koha-bugs] [Bug 33663] New: Don't hide Suggestions link in side navigation when suggestion preference is disabled Message-ID: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 Bug ID: 33663 Summary: Don't hide Suggestions link in side navigation when suggestion preference is disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: michaela.sieber at kit.edu There is a mismatch in how we handle the suggestions link in the top navigation (More menu) an the sidebar navigation in the acquisition module. The link in the More menu is only dependent on the permissions of the user, the link in the sidebar also checks for the suggestion system preference. I believe the latter is not correct, as the suggestion pref explicitly mentions the OPAC: [Enable|Disable] purchase suggestions in the OPAC. Some libraries use other forms/tools to allow for users to make purchase suggestions. When suggestions are deactivated, they still want to have the feature available in the staff interface. We also now have permissions for suggestions, so we can still hide from staff using those if necessary. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:35:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:35:18 +0000 Subject: [Koha-bugs] [Bug 33664] New: Should we allow cancelling orders while the basket is closed? Message-ID: <bug-33664-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Bug ID: 33664 Summary: Should we allow cancelling orders while the basket is closed? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: caroline.cyr-la-rose at inlibro.com, michaela.sieber at kit.edu This is a workflow question: At the moment cancelling an order line from the basket summary page is only possible, while the basket is open. For standing orders this means it's always possible, while it's not for other types of orders. There is now 2 ways to cancel the order: Option A: * Reopen the basket * Cancel the order * Close the basket + Less clicks than option B - All unreceived order lines will switch status unnecessarily (ordered - new - ordered) - The basket close date will reset to today's date Option B: * Create a new shipment * 'Fake' an invoice, for example it could be named: Cancellations * Use the cancelling options from the list of pending orders + Close date remains the same + Only the cancelled order line will change status - More clicks and not really convenient Now the question: Is there a strict reason why we should not permit cancelling from a closed order? The closed order lines will still show in the second table below. We could also add a hint on the cancellation date. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:37:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:37:00 +0000 Subject: [Koha-bugs] [Bug 9750] Bring routing lists into notices & slips In-Reply-To: <bug-9750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9750-70-PiMKvpngQf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9750 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think this might be the last remaining hardcoded notice right now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:38:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:38:39 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-9LFBBksXgu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:38:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:38:42 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-5rcZhLX4RP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149971|0 |1 is obsolete| | Attachment #150147|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150591&action=edit Bug 33576: Index records after import transaction is committed This patch simply moves our indexing call after the transaction is committed so that the job will exist in the DB when called. To test: 1 - Have Koha using Elasticsearch 2 - Stage and import a file of records 3 - View the job in Admin->Manage jobs 4 - Note it is not finished 5 - Check log: /var/log/koha/kohadev/es-indexer-output.log 6 - Note: [WARN] No job found for id=### 7 - Apply patch 8 - Stage and import 9 - Note no error in log 10 - Note successful completion of indexing job Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:38:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:38:44 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-NQwsrE9aK7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150592&action=edit Bug 33576: (QA follow-up) Polish comment, typo No test plan. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:40:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:40:14 +0000 Subject: [Koha-bugs] [Bug 33665] New: When editing items, you don't see total of items Message-ID: <bug-33665-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33665 Bug ID: 33665 Summary: When editing items, you don't see total of items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl, michaela.sieber at kit.edu It would be nice if you could see the total of items on a record while editing the items. At the moment it doesn't show in the datatable on top, nor on the items tab on the left. It might be nice to add the count to the items tab like we do for holds and also matching what we do on the holdings tab in the normal view. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:43:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:43:24 +0000 Subject: [Koha-bugs] [Bug 33666] New: Add facet for publication year Message-ID: <bug-33666-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33666 Bug ID: 33666 Summary: Add facet for publication year Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de CC: michaela.sieber at kit.edu I didn't find another older bug report for this, but maybe I just didn't spot it. It would be nice if the facets could be used to limit materials to certain range. This could be having the publication years as facet entries or something nicer allows you to limit to a year range using a graphical tool. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:51:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:51:11 +0000 Subject: [Koha-bugs] [Bug 33591] Cannot merge bibliographic records In-Reply-To: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33591-70-pggGxW7UBV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I am not sure I understand what you are describing, but I found a bug, the checkboxes from the source record are no longer selected by default. Is that your problem? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:52:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:52:11 +0000 Subject: [Koha-bugs] [Bug 33667] New: 'Copy to all libraries' doesn't work on editing holidays Message-ID: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33667 Bug ID: 33667 Summary: 'Copy to all libraries' doesn't work on editing holidays Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: michaela.sieber at kit.edu When editing an existing holiday and checking the "copy to all libraires" checkbox, the other calendars won't get updates. To test: A: * Add a new unique holiday to branch A * Check 'Copy to all libraries' checkbox * Save * Verify the entry shows on all calendars, within the calendar and in list on the right B: * Add another unique holiday to branch A * Don't check checkbox 'Copy to all libraries' * Save * Verify the holidays shows on all calendars as a green box (?) * Edit the holiday, now check 'copy to all libraries' * Verify nothing has changed in other calendars: only the green box, no holiday in list on the right * Edit again, make a change to description, check checkbox, save * Verify it's still not showing in the other calendars -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:52:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:52:15 +0000 Subject: [Koha-bugs] [Bug 33278] Correct JS for activating default tab on various pages In-Reply-To: <bug-33278-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33278-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33278-70-M2hxf0WEMr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:53:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:53:13 +0000 Subject: [Koha-bugs] [Bug 33667] 'Copy to all libraries' doesn't work on editing holidays In-Reply-To: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33667-70-X0BZTzZZgu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33667 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |4985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 [Bug 4985] Copy a change on the calendar to all libraries -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:53:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:53:13 +0000 Subject: [Koha-bugs] [Bug 4985] Copy a change on the calendar to all libraries In-Reply-To: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4985-70-e1diJUNuk1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33667 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33667 [Bug 33667] 'Copy to all libraries' doesn't work on editing holidays -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:54:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:54:01 +0000 Subject: [Koha-bugs] [Bug 33591] Cannot merge bibliographic records In-Reply-To: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33591-70-f1hTBZJjza@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29226 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:54:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:54:01 +0000 Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs In-Reply-To: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29226-70-pKcheopimt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33591 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 [Bug 33591] Cannot merge bibliographic records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:55:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:55:14 +0000 Subject: [Koha-bugs] [Bug 33591] Cannot merge bibliographic records In-Reply-To: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33591-70-cNrBq2dNtS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:55:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:55:16 +0000 Subject: [Koha-bugs] [Bug 33591] Cannot merge bibliographic records In-Reply-To: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33591-70-tHHyRydOos@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150593&action=edit Bug 33591: Restore auto-select of checkboxes of src record when merging When merging bib records the first tab (the source record) should have all the checkboxes checked by default. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:55:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:55:29 +0000 Subject: [Koha-bugs] [Bug 33591] Cannot merge bibliographic records In-Reply-To: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33591-70-nbcjkEwZwk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:56:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:56:01 +0000 Subject: [Koha-bugs] [Bug 33591] Cannot merge bibliographic records In-Reply-To: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33591-70-d81F3ylCF3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Not sure about the dependency, is bug 29226 really introduced this regression? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:57:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:57:18 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-CgtuOmrKAw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- I feel like we either (a) refactor everything and do server-side rendering as we do now with Template::Toolkit, or (b) provide a way to fetch the module configuration, as the patch proposes. I think (a) is not doable or worth. So I pick (b). I generally agree with an endpoint like /config/:module_name for retrieving things. I'd prefer we come up with something more generic than just passing the allow-listed sysprefs. We could talk about allowed-to-use features like: { features: { packages: [ add, update, delete, list ] } } If we look at our current approach (C4::Auth) it is easy to spot that we also add information about the permissions the current user has (CAN_<permission>). I'm not sure about the data structure. We should just copy what other projects do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:57:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:57:22 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28166-70-juzlymMmjH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Mark Hofstetter <koha at trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150590|0 |1 is obsolete| | --- Comment #14 from Mark Hofstetter <koha at trust-box.at> --- Created attachment 150594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150594&action=edit Bug 28166: Optionally add MARC fields to authority search adds the same feature to Authority Search as in the "normal" Z39.50 search, to display arbitrary marc fields in the search results 1. apply patch 2. go to System preferences->Authorities preferences 3. the new option "AdditionalFieldsInZ3950ResultAuthSearch" shows up 4. enter the additional field numbers you want to see eg '001' 5. make an "Authority" search via Z39.50 6. the new new column "Additional fields" will display 7. sign off ;-) Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> Signed-off-by: Clemens Tubach <clemens.tubach at kit.edu> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:57:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:57:24 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28166-70-LqTGOlBnCf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 --- Comment #15 from Mark Hofstetter <koha at trust-box.at> --- Created attachment 150595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150595&action=edit removed comments and _add_rowdata -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 16:59:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 14:59:01 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-PPFxL9bUeq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #55 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Thibaud Guillot from comment #54) > (In reply to Jonathan Druart from comment #53) > > (In reply to Jonathan Druart from comment #52) > > > Please have a look at bug 33445 that is suggesting to revert these patches! > > > > ping Thibaud? > > Hello Jonathan, > > Sorry for the delay, I saw and read the bug 33445 apparently other patches > have been proposed to replace the revert. But I understand the problematic > behavior of this one.. Do you think there is a need for me to do something? If you agree with the changes there it's all good. I hadn't noticed Nick submitted a new version of the patches! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:03:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:03:42 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28166-70-M2Q8bmJk0c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Mark Hofstetter <koha at trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:05:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:05:09 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-NnfHygGeKR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #57 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Kyle M Hall from comment #56) > I'm getting the error "Data::Session. Unknown serialize 'yamlxs' at > /usr/local/share/perl/5.32.1/Data/Session.pm line 752". > > I installed Data::Session, are there other deps I missed? Yes, you need to copy the lib file cp lib/Data/Session/Serialize/yamlxs.pm /usr/share/perl5/Data/Session/Serialize/yamlxs.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:05:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:05:17 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-A1uYncOXRW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Example found in the wild: https://www.permify.co/post/implementing-role-based-access-control-in-vue-js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:07:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:07:22 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28166-70-vJPUVwVLNn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150595|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150596&action=edit Bug 28166: Removed comments and _add_rowdata -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:07:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:07:31 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-PKyRIBiB0d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #58 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Can we (In reply to Jonathan Druart from comment #57) > (In reply to Kyle M Hall from comment #56) > > I'm getting the error "Data::Session. Unknown serialize 'yamlxs' at > > /usr/local/share/perl/5.32.1/Data/Session.pm line 752". > > > > I installed Data::Session, are there other deps I missed? > > Yes, you need to copy the lib file > cp lib/Data/Session/Serialize/yamlxs.pm > /usr/share/perl5/Data/Session/Serialize/yamlxs.pm Can we ship Data::Session inside the Koha project instead, and get rid of the need for that? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:07:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:07:44 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28166-70-GsXoDlVMDy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (Adjusted the commit title to make the QA script happy) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:10:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:10:37 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-wo6ZeBr0cV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:10:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:10:39 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-gSql8ajuiA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 --- Comment #21 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150597&action=edit Bug 31187: (follow-up) Check if input in form, not if values passed This patch updates the check to see if there was a form input present, not if a value was passed. $attr contains an item colum @form_attr contains the form inputs for the attribute @values (renamed from @v) contains the uniq values passed in to the form We want to know if permanent_location is in the form, not if it had values, to know if we should preserve the DB value To test: 1 - Apply patches 2 - Make sure permanent_location is not mapped to a marc field 3 - Batch edit an item, changing shelving location 4 - Confirm both location and permanent_location are changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:10:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:10:48 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-0O6QB7iUdi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #59 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- No, please read the previous comments. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:11:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:11:46 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-kL99LShoj8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #60 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #59) > No, please read the previous comments. Well, yes, we could, if we embed Data::Session and modify it. But what would we do that? Isn't the "lib trick" already in place anyway? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:12:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:12:12 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-zP0e6meqCh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #61 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #59) > No, please read the previous comments. Well, yes, we could, if we embed Data::Session and modify it. But why would we do that? Isn't the "lib trick" already in place anyway? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:12:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:12:24 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-6reSlmdImB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:12:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:12:40 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-ybCPJqeMOc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #56 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- ok great, thanks for the alert by the way -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:14:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:14:33 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31798-70-t46DPHab3W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:14:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:14:36 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31798-70-NHf1XOuiXf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147655|0 |1 is obsolete| | Attachment #147656|0 |1 is obsolete| | Attachment #147657|0 |1 is obsolete| | --- Comment #18 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 150598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150598&action=edit Bug 31798: Add REST endpoint to add a biblio's item To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Get a biblio 4. Make a POST request to /api/v1/biblios/:biblio_id/items with a json body that represents the new item 5. Check that the item is created 6. Sign off Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:14:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:14:39 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31798-70-TEkjJmNUaV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 --- Comment #19 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 150599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150599&action=edit Bug 31798: (follow-up) Tidy up and add duplicate barcode test Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:14:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:14:42 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31798-70-SmSJpd4feR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 --- Comment #20 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 150600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150600&action=edit Bug 31798: (follow-up) Handle all values of autoBarcode Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:15:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:15:41 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-d6jjT6IHAH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Tomás Cohen Arazi from comment #6) > Example found in the wild: > > https://www.permify.co/post/implementing-role-based-access-control-in-vue-js Yes but this is "user.json", we are not going into that direction (and I don't think we should). Or maybe we should, but then we remove the 'config' idea and build a big structure with everything for every modules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:21:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:21:19 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28166-70-yfGkjTefD8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 --- Comment #18 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Mark Hofstetter from comment #12) > Must fix: > - the call from _handle_one_result should be updated to pass the biblio > related preference to the updated routine > > => I really don't understand this one, "_handle_one_result" is only used for > bibs so nothing changes here _handle_one_result calls _add_custom_field_rowdata Previously _add_custom_field_rowdata fetched the system preference 'AdditionalFieldsInZ3950ResultSearch' After these patches it expects to receive the additional fields in a parameter, we need to update the call C4/Biblio.pm: 317 $row = _add_custom_field_rowdata($row, $marcrecord); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:25:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:25:54 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28166-70-X7tUV1bTa1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 --- Comment #19 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150601&action=edit Bug 28166: (follow-up) Restore custom fields for biblios To test: 1 - Add "245$a" to AdditionalFieldsInZ3950ResultSearch preference 2 - Cataloging -> new from z3950 3 - Search and see results have 'additional fields' including the title 4 - Apply other patches 5 - Restart all 6 - Repeat Z39 Additional fields are now blank 7 - Apply thi patch, restart all 8 - Repeat Z39 search. Additional fields are restored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:46:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:46:38 +0000 Subject: [Koha-bugs] [Bug 33668] New: Add a 'clear search' button/icon inside the search input box on the OPAC Message-ID: <bug-33668-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668 Bug ID: 33668 Summary: Add a 'clear search' button/icon inside the search input box on the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org It would be nice to have the option of a 'clear search' button/icon in the OPAC search box so users could quickly clear out text they have input instead of having to put their cursor in the search box and backspace or highlight the text and delete it. This is a common feature of many search boxes, such as in Chrome and Firefox. The clear search feature (typically and 'x' or an 'x' in a circle) would only display when the search box contains text that could be cleared. I added a mockup of what I'm referring to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:47:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:47:55 +0000 Subject: [Koha-bugs] [Bug 33668] Add a 'clear search' button/icon inside the search input box on the OPAC In-Reply-To: <bug-33668-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33668-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33668-70-XhmNeUSM4L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668 --- Comment #1 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- Created attachment 150602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150602&action=edit Search box with clear search feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 17:56:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 15:56:55 +0000 Subject: [Koha-bugs] [Bug 33664] Should we allow cancelling orders while the basket is closed? In-Reply-To: <bug-33664-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33664-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33664-70-2J7tECeoyE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- >From my library days, I would say it was very common for me to cancel orders I had already sent to the vendor. Mostly when the vendor would later tell me it was not available anymore or they would never get it. In Koha, I'm not a fan of having to reopen the basket since like you said, it changes the order date. I had never tried option B. It seems like a fiddly workaround for something that should be possible. >From a workflow standpoint, I don't think there is a reason to limit cancelling orders to open baskets only. >From a technical standpoint, we should probably look at what closing the basket does, to know if something would clash with cancelling the order. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:00:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 16:00:00 +0000 Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation In-Reply-To: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20844-70-nuQvMnOsLS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #62 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- The majority of the test plan works - just a few more bugs to be worked out: - If RevertLostBibLevelHolds is set to "Revert" and later switched back to "Don't Revert", the holds continue to automatically revert even after the syspref is disabled. And yes, I did double-check that I actually clicked "Save" and that the syspref was still set to "Don't Revert" if I navigated away from the System Preferences page and then back ;) - When RevertLostBibLevelHolds is disabled, if a waiting item on an item-level hold is marked as lost, the alert asking whether to revert or cancel the hold still appears, but the "Revert" and "Cancel" buttons have no effect. In combination with the previous bug, the effect is this: * If RevertLostBibLevelHolds has never been enabled, the effect just described occurs. * If RevertLostBibLevelHolds was enabled and then disabled, the alert appears and the buttons revert/cancel the hold, as would be expected if the pref was still enabled A thought: the preference is called RevertLostBibLevelHolds, but if I'm understanding correctly it affects the behavior of both bib level and item level holds. It seems to me that it could more accurately be called RevertLostHolds, and maybe add a note to the description explaining that item-level holds will ask whether they should be reverted or cancelled. Finally, I just want to clarify something from the test plan: > 41) Confirm that both Items are included in the alert box on page when > editing items (cataloguing/additem.pl) As far as I know, additem.pl can only edit one item at a time - is there a way to edit two at once from that page? (When I edited them one at a time they each got an alert as expected, so may not be an issue - just wanted to check.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:03:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 16:03:42 +0000 Subject: [Koha-bugs] [Bug 33664] Should we allow cancelling orders while the basket is closed? In-Reply-To: <bug-33664-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33664-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33664-70-x2QkYFXgsT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- AFAIK it changes the status if it was new to ordered. If it was received it remains the same. Otherwise it should not change a thing and you can already cancel new from the basket and ordered from the receive page... so I think we should be ok. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:20:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 16:20:40 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-YLP1I07ora@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150569|0 |1 is obsolete| | Attachment #150570|0 |1 is obsolete| | Attachment #150571|0 |1 is obsolete| | --- Comment #62 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150603&action=edit Bug 17427: Replace CGI::Session with Data::Session CGI::Session is not maintained for ages and seems quite buggy. It would be the culprit of random logout problems. Another issue is the following crazy code in CGI::Session::Driver::DBI sub DESTROY { my $self = shift; unless ( defined $self->{Handle} && $self->{Handle} -> ping ) { $self->set_error(__PACKAGE__ . '::DESTROY(). Database handle has gone away'); return; } unless ( $self->{Handle}->{AutoCommit} ) { $self->{Handle}->commit; } if ( $self->{_disconnect} ) { $self->{Handle}->disconnect; } } If AutoCommit is off, it will commit anyway... It causes some tests to fail (api) if SessionStorage is set to MySQL Note that PostgreSQL is not supported yet so no need to implement it. Test plan: 0/ The dependencies are not packaged for debian so far, so install it via cpan 1/ Test the 3 different values for SessionStorage 2/ Using different browsers (or sessions) login into Koha with different users. Naviguate => you should not be logged out 3/ Set SessionStorage to Memcached, stop memcached make sure that it defaults to file. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:20:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 16:20:49 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-ZIO75vD4so@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #63 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150604&action=edit Bug 17427: Use JSON serialization Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:20:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 16:20:52 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-VpHJdleneP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #64 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150605&action=edit Bug 17427: Use our own YAML::XS serializer Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:20:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 16:20:54 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-rWvUqXIjzX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #65 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150606&action=edit Bug 17427: Remove use lines for CGI::Session from Auth.pm Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:25:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 16:25:39 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-d44zX5M0HC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #66 from Kyle M Hall <kyle at bywatersolutions.com> --- The big blocker is replacing the use of CGI::Session::Find (https://metacpan.org/pod/CGI::Session#find(-%5C&code-)) in C4::Auth_with_cas -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:39:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 16:39:13 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31799-70-0opbJo8QVW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:39:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 16:39:16 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31799-70-Luu3GQFSQ5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144949|0 |1 is obsolete| | Attachment #144959|0 |1 is obsolete| | Attachment #145632|0 |1 is obsolete| | --- Comment #14 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 150607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150607&action=edit Bug 31799: Add REST endpoint to modify a biblio's item To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Get a biblio with an item 4. Make a PUT request to /api/v1/biblios/:biblio_id/items/:item_id with a json body that represents an item to replace 5. Check that the item was modified 6. Sign off Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:39:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 16:39:19 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31799-70-PsGqv7J9ac@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 --- Comment #15 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 150608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150608&action=edit Bug 31799: (follow-up) Tidy up and fix duplicate barcode handling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 18:39:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 16:39:22 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31799-70-52xuJvCyjp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 --- Comment #16 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 150609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150609&action=edit Bug 31799: (follow-up) Add 409 error to spec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 19:21:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 17:21:14 +0000 Subject: [Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities In-Reply-To: <bug-31185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31185-70-UVYFW9VOH2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150610&action=edit Bug 31185: Unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 19:22:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 17:22:32 +0000 Subject: [Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities In-Reply-To: <bug-31185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31185-70-myZth8WBfD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- I added a unit test, but I discovered that if AutoCreateAuthorities is on, we won't report multiple matches. I think we should? Feel free to adjust test expectations if not, but I suspect it reveals a problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 19:43:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 17:43:45 +0000 Subject: [Koha-bugs] [Bug 33563] Enable compatibility with Elasticsearch secure mode In-Reply-To: <bug-33563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33563-70-U9TAJ6zEWy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33563 Andreas Jonsson <andreas.jonsson at kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson at kreablo.se --- Comment #1 from Andreas Jonsson <andreas.jonsson at kreablo.se> --- For basic authentication, you can put the credentials in the connection details: <server>username:password at localhost:9200</server> It would be nice to have a comment about this in the koha-conf.xml template. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:01:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:01:20 +0000 Subject: [Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6 In-Reply-To: <bug-32910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32910-70-tZZNosO6bV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:08:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:08:14 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31735-70-iLt0Y6b4cp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147164|0 |1 is obsolete| | --- Comment #73 from David Gustafsson <glasklas at gmail.com> --- Created attachment 150611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150611&action=edit Bug 31735: Avoid re-fetcing objects from database by passing them directly instead of ids to various subroutines To test: 1) Run the following test and make sure all pass: t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/api/v1/return_claims.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/transferbook.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/HoldsQueue.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/Illrequests.t t/db_dependent/ILSDI_Services.t t/db_dependent/Items.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Acquisition/Order.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Holds.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/Reserves.t t/db_dependent/rollingloans.t t/db_dependent/selenium/regressions.t t/db_dependent/SIP/ILS.t t/db_dependent/Holds.t t/db_dependent/Holds/LocalHoldsPriority.t t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Holds/HoldItemtypeLimit.t t/db_dependent/Circulation/transferbook.t 2) Performe one or more checkouts for a patron, making sure that the circulation rules allows for renewals (for example by setting an earlier due-date). 3) Log in as this patron in OPAC and make sure the list of checkouts is displayed correctly, and that renewing an issue still works. Sponsored-by: Gothenburg University Library Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:08:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:08:17 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31735-70-OYuxvmrEZP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147165|0 |1 is obsolete| | --- Comment #74 from David Gustafsson <glasklas at gmail.com> --- Created attachment 150612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150612&action=edit Bug 31735: Optimize OPAC checkouts view Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:08:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:08:20 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31735-70-KAz51fsGOS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147166|0 |1 is obsolete| | --- Comment #75 from David Gustafsson <glasklas at gmail.com> --- Created attachment 150613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150613&action=edit Bug 31735: Fix array that should be passed as reference Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:08:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:08:46 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31735-70-qvtFrUF96N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #76 from David Gustafsson <glasklas at gmail.com> --- Rebased against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:20:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:20:14 +0000 Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm In-Reply-To: <bug-32496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32496-70-QLCUSMus54@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147162|0 |1 is obsolete| | --- Comment #18 from David Gustafsson <glasklas at gmail.com> --- Created attachment 150614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150614&action=edit Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm Refactor the most performance critical subroutines in Circulation.pm to take objects instead of unblessed ones to reduce unnecessary unblessings and generally clean up the code. To test: 1) Ensure the following tests all pass: t/db_dependent/Circulation.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/ILSDI_Services.t t/db_dependent/Illrequests.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/SIP/ILS.t t/db_dependent/Holds.t t/db_dependent/Holds/LocalHoldsPriority.t t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Holds/HoldItemtypeLimit.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/api/v1/return_claims.t t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/Reserves.t t/db_dependent/HoldsQueue.t t/db_dependent/selenium/regressions.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Plugins/Recall_hooks.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Circulation/_CalculateAndUpdateFine.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:21:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:21:49 +0000 Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm In-Reply-To: <bug-32496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32496-70-hDEcUUZ4YL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #19 from David Gustafsson <glasklas at gmail.com> --- Rebased against master, though need ensure tests still pass before ready for signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:31:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:31:17 +0000 Subject: [Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL In-Reply-To: <bug-30472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30472-70-TW2JaMBOvI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472 Mona Panchaud <m+koha at mpan.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m+koha at mpan.ch --- Comment #9 from Mona Panchaud <m+koha at mpan.ch> --- Hello. While upgrading from 22.05 to 22.11 we are running into the following problem that is related to this change: "Upgrade to 22.06.00.048 [20:19:53]: Bug 30472 - borrower_relationships.guarantor_id NOT NULL ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'guarantor_id': used in a foreign key constraint 'r_guarantor' at /usr/share/koha/lib/C4/Installer.pm line 743" Is there any workaround? What can we do to get the upgrade working? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:31:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:31:30 +0000 Subject: [Koha-bugs] [Bug 33076] Add context to "Quotes" In-Reply-To: <bug-33076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33076-70-Atk3oQ9IkI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33076 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com --- Comment #15 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- This bug doesn't apply fine on 21.11.x... can you provide a backport if needed? Thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:33:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:33:17 +0000 Subject: [Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters In-Reply-To: <bug-33100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33100-70-IvGiwnaa23@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|23.05.00,22.11.04,22.05.12 |23.05.00,22.11.04,22.05.12, released in| |21.11.20 --- Comment #15 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:34:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:34:30 +0000 Subject: [Koha-bugs] [Bug 32399] Database update for bug 30483 is failing In-Reply-To: <bug-32399-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32399-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32399-70-4Di5qC4QaY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32399 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |arthur.suzuki at biblibre.com Status|Pushed to oldstable |RESOLVED --- Comment #28 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- won't backport, depends on 30483 which is not applied to 21.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:35:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:35:20 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-tbQKngPBZ6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149705|0 |1 is obsolete| | --- Comment #8 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 150615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150615&action=edit Bug 32735: Add endpoint to list authorities This patch adds an endpoint to list authorities To test: 1. apply patch 2. enable basic auth 3. call to GET /api/v1/authorities with the following Accept headers: * application/json * application/marcxml+xml * application/marc-in-json * application/marc * text/plain 4. notice how data changes with each Accept header 5. prove t/db_dependent/api/v1/authorities.t 6. sign off Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:35:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:35:23 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-9tVk1uoLY2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 --- Comment #9 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 150616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150616&action=edit Bug 32735: (follow-up) Make Koha::Objects::Record::Collections->print_collection work with Authorities and Biblios -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:35:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:35:44 +0000 Subject: [Koha-bugs] [Bug 33151] Improve translation of strings in cities and circulation desk administration pages In-Reply-To: <bug-33151-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33151-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33151-70-uDgSn3fwFb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33151 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04,22.05.12 |23.05.00,22.11.04,22.05.12, released in| |21.11.20 Status|Pushed to oldstable |Pushed to oldoldstable CC| |arthur.suzuki at biblibre.com --- Comment #9 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:36:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:36:57 +0000 Subject: [Koha-bugs] [Bug 33137] Make sure columns on transactions and 'pay fines' tab are matching up In-Reply-To: <bug-33137-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33137-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33137-70-PuAT3fFVwx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.12 |23.05.00,22.11.05,22.05.12, released in| |21.11.20 CC| |arthur.suzuki at biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #20 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:38:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:38:18 +0000 Subject: [Koha-bugs] [Bug 33309] Race condition while checkout renewal with ES In-Reply-To: <bug-33309-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33309-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33309-70-FyH4ldtVGr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33309 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Version(s)|23.05.00,22.11.05,22.05.12 |23.05.00,22.11.05,22.05.12, released in| |21.11.20 Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:39:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:39:12 +0000 Subject: [Koha-bugs] [Bug 30966] Record overlay rules - can't use Z39.50 filter In-Reply-To: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30966-70-lsV82NE3Yu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.12 |23.05.00,22.11.05,22.05.12, released in| |21.11.20 CC| |arthur.suzuki at biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #16 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:39:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:39:59 +0000 Subject: [Koha-bugs] [Bug 33198] request.pl is calculating pickup locations that are not used In-Reply-To: <bug-33198-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33198-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33198-70-z4EvVWaloB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33198 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |arthur.suzuki at biblibre.com --- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:40:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:40:40 +0000 Subject: [Koha-bugs] [Bug 33669] New: Adding options to ApplyFrameworkDefaults preference Message-ID: <bug-33669-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33669 Bug ID: 33669 Summary: Adding options to ApplyFrameworkDefaults preference Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: noemie.labine at collecto.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi ! >From bz29146 and bz30250, a few changes have been made to enhance the way framework default values are applied in a record. But the changes made makes it impossible for someone to add quickly default values to a record they are editing since default values are applied only when a record is created. Before, when we saved a record, every empty field and/or subfield that had default values in the framework would get populated. Of course that was not ideal as someone could want to keep one of those field empty. But right now, if we edit a record, there is no way to populate those field... So I think a great way to keep the inhancement from 29146/30250 but to also have the option to add default values when editing a record (not only when creating one) would be to add two more options to ApplyFrameworkDefaults preference : - When repeating a field - When repeating a subfield This way, if my framework has a default value in field 336, for exemple, and I edit a record that has an empty 336 field, I could only use the "repeat this field" button to have a 336 field populated with my default values. The empty 336 would simply disappear when saving my record. And it would be the same for the subfield option, but having the two separated allows a bit more flexibility if a library wants to have default values when adding a complete field but not if they only repeat a subfield and vice versa. Thank you ! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 20:41:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 18:41:10 +0000 Subject: [Koha-bugs] [Bug 33669] Adding options to ApplyFrameworkDefaults preference In-Reply-To: <bug-33669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33669-70-eAukjw6dcl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33669 Noémie Labine <noemie.labine at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maude.boudreau at collecto.ca, | |noemie.labine at collecto.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:04:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 19:04:57 +0000 Subject: [Koha-bugs] [Bug 33341] Perl 5.36 doesn't consider some of our code cool In-Reply-To: <bug-33341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33341-70-nXwpqKKtKk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33341 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |arthur.suzuki at biblibre.com Version(s)|23.05.00,22.11.05,22.05.12 |23.05.00,22.11.05,22.05.12, released in| |21.11.20 --- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:05:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 19:05:59 +0000 Subject: [Koha-bugs] [Bug 33168] Timeline on "About Koha" is not working for package installs In-Reply-To: <bug-33168-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33168-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33168-70-H4Opk5yhk8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|23.05.00,22.11.05,22.05.12 |23.05.00,22.11.05,22.05.12, released in| |21.11.20 CC| |arthur.suzuki at biblibre.com --- Comment #49 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:07:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 19:07:34 +0000 Subject: [Koha-bugs] [Bug 28641] ILLHiddenRequestStatuses does not consider custom statuses In-Reply-To: <bug-28641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28641-70-VTLLxEDd3J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28641 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.12 |23.05.00,22.11.05,22.05.12, released in| |21.11.20 CC| |arthur.suzuki at biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #12 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:08:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 19:08:56 +0000 Subject: [Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical In-Reply-To: <bug-13976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13976-70-TvncSSGGRl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.12 |23.05.00,22.11.05,22.05.12, released in| |21.11.20 Status|Pushed to oldstable |Pushed to oldoldstable CC| |arthur.suzuki at biblibre.com --- Comment #32 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:10:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 19:10:32 +0000 Subject: [Koha-bugs] [Bug 31259] Downloading patron card PDF hangs the server In-Reply-To: <bug-31259-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31259-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31259-70-IepfpHvMaB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.12 |23.05.00,22.11.05,22.05.12, released in| |21.11.20 CC| |arthur.suzuki at biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #22 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:12:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 19:12:26 +0000 Subject: [Koha-bugs] [Bug 32280] Export method ImportBreedingAuth from C4::Breeding In-Reply-To: <bug-32280-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32280-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32280-70-X65kcQisi8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32280 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|23.05.00,22.11.05,22.05.12 |23.05.00,22.11.05,22.05.12, released in| |21.11.20 --- Comment #7 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:14:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 19:14:05 +0000 Subject: [Koha-bugs] [Bug 32279] GetAuthorizedHeading missing from exports of C4::AuthoritiesMarc In-Reply-To: <bug-32279-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32279-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32279-70-QLBT27u94R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32279 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.12 |23.05.00,22.11.05,22.05.12, released in| |21.11.20 Status|Pushed to oldstable |Pushed to oldoldstable CC| |arthur.suzuki at biblibre.com --- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:15:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 19:15:24 +0000 Subject: [Koha-bugs] [Bug 33285] It should be possible to specify the separator used in runreport.pl In-Reply-To: <bug-33285-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33285-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33285-70-Zztk2kSPrb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33285 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.12 |23.05.00,22.11.05,22.05.12, released in| |21.11.20 Status|Pushed to oldstable |Pushed to oldoldstable CC| |arthur.suzuki at biblibre.com --- Comment #14 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:15:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 19:15:49 +0000 Subject: [Koha-bugs] [Bug 33670] New: Changes from bz29146/bz30250 doesn't apply when duplicate record suspected Message-ID: <bug-33670-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33670 Bug ID: 33670 Summary: Changes from bz29146/bz30250 doesn't apply when duplicate record suspected Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: noemie.labine at collecto.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Bz29146/30250 changed the behavior of the default values to make it so they are only applied when creating a new record so if someone wanted to delete a field that had default valued in the framework, those informations wouldn't reappear when the record was saved. The old behavior seems to still apply when Koha detects a duplicate record. Test plan : 1. Have a framework with a default value in any non mandatory field. Make sure this field is visible in the editor. For my exemple I had "rdacontent" as the default value in subfield $2 of field 336. 2. Create a new record and delete the $2 that appears with my default value 3. Fill all the mandatory fields and in 245 write the title of an existing record in your catalogue to create a duplicate. 4. Save the record. The page will refresh and you'll have the "Duplicate record suspected" alert asking you if this is a new record or a duplicate. 5. Go to the field you deleted (336 in my exemple), the default value came back. To compare, do all of the same steps, but create a record that has no duplicate in the catalogue. When you save the record, the deleted field is not populated with the default values, it stays deleted as it should. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:15:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 19:15:55 +0000 Subject: [Koha-bugs] [Bug 33670] Changes from bz29146/bz30250 doesn't apply when duplicate record suspected In-Reply-To: <bug-33670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33670-70-Te8QVVBEhe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33670 Noémie Labine <noemie.labine at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine at collecto.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:16:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 19:16:10 +0000 Subject: [Koha-bugs] [Bug 33670] Changes from bz29146/bz30250 doesn't apply when duplicate record suspected In-Reply-To: <bug-33670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33670-70-r5jXQklbHB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33670 Noémie Labine <noemie.labine at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maude.boudreau at collecto.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:28:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 19:28:05 +0000 Subject: [Koha-bugs] [Bug 33591] Cannot merge bibliographic records In-Reply-To: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33591-70-AcZDEnoKD8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think the checkboxes could well be it, I'll try to test. It could also be another form of bug 33590, related to the other tab changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:38:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 19:38:39 +0000 Subject: [Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code In-Reply-To: <bug-27507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27507-70-qal3DphvPX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 Heather <heather_hernandez at nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 21:40:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 19:40:01 +0000 Subject: [Koha-bugs] [Bug 6011] 7xx fields should optionally link on standard (ISBN/ISSN/etc.) numbers In-Reply-To: <bug-6011-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6011-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6011-70-f5jS70HRpD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6011 Heather <heather_hernandez at nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 22:14:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 20:14:32 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: <bug-14783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14783-70-BoR1KNNoie@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |30500 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 22:14:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 20:14:32 +0000 Subject: [Koha-bugs] [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit In-Reply-To: <bug-30500-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30500-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30500-70-yL8MgVfS5K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14783 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 [Bug 14783] Allow patrons to change pickup location for non-waiting holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 22:16:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 20:16:57 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: <bug-14783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14783-70-Gan2s1J4xD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #67 from Fridolin Somers <fridolin.somers at biblibre.com> --- I add dependancy with Bug 30500 because it deletes the preference 'OPACInTransitHoldPickupLocationChange' this bug added -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 22:26:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 20:26:06 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-ge7iSJP1M4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 --- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Koha-2-MARC-Mappings are now always taken from the default framework (you can no longer set them by framework). So instead of checking the form, could we not use the link in the framework? It seems safer than to check on the form, where the field could just be hidden or altered in some way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 22:26:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 20:26:38 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-OzAS094Rl6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 22:28:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 20:28:12 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-XNskZ2yq3Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 --- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- My thought was: if permanent_location is linked to a MARC field = treat the subfields individually, else treat them as before. There also needs to be some special treatment for CART and PROC I guess. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 22:58:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 20:58:48 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-d9uY34mXem@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150226|0 |1 is obsolete| | Attachment #150227|0 |1 is obsolete| | Attachment #150228|0 |1 is obsolete| | Attachment #150565|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150617&action=edit Bug 33551: Remove span from restriction-types.inc Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 22:58:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 20:58:51 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-wz6CqXaw3E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150618&action=edit Bug 33551: (QA follow-up) Fix TT filters Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:00:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:00:07 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-8KTAfMKKec@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I've tested in the GUI, but also updated the po files to verify that the changes show up as strings and can be translated. Also fixed some TT filters ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:03:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:03:53 +0000 Subject: [Koha-bugs] [Bug 33612] Staff with limited permissions don't always get an expanded catalog_search bar In-Reply-To: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33612-70-jUI3Qdm1ue@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Joubu is right, the first selected tab on the start page changes with this patch. I wonder if we could get away with that, but it's certainly a behavior change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:05:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:05:32 +0000 Subject: [Koha-bugs] [Bug 29664] Do not show voided payments in cash register statistics wizard In-Reply-To: <bug-29664-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29664-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29664-70-vS6F4a2H3f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Do not show voided payments |Do not show voided payments |in cash_register_stats.pl |in cash register statistics | |wizard CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:05:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:05:34 +0000 Subject: [Koha-bugs] [Bug 33612] Staff with limited permissions don't always get an expanded catalog_search bar In-Reply-To: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33612-70-ge3D6kVhFn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #7) > Joubu is right, the first selected tab on the start page changes with this > patch. I wonder if we could get away with that, but it's certainly a > behavior change We should not try to get away with that. I think we need to keep the behavior we have now, I will return to this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:11:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:11:01 +0000 Subject: [Koha-bugs] [Bug 33655] z39.50 search no longer shows search in progress In-Reply-To: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33655-70-NiUk9h7sHB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org, | |phil at chetcolibrary.org Blocks| |32072 --- Comment #3 from Phil Ringnalda <phil at chetcolibrary.org> --- The basic editor, in 22.05. This is a regression from bug 32072, because https://git.koha-community.org/Koha-community/Koha/src/commit/9c039d4716a099365a45ab8d40d6b1362229f72b/koha-tmpl/intranet-tmpl/prog/js/z3950_search.js#L30 sets cursor: wait on click of a thing with the class "submit" but the submit button for a Z39.50 search no longer has that class. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072 [Bug 32072] Consistent classes for primary buttons: Cataloging -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:11:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:11:01 +0000 Subject: [Koha-bugs] [Bug 32072] Consistent classes for primary buttons: Cataloging In-Reply-To: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32072-70-4q4TAC4lKo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33655 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 [Bug 33655] z39.50 search no longer shows search in progress -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:16:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:16:19 +0000 Subject: [Koha-bugs] [Bug 29664] Do not show voided payments in cash register statistics wizard In-Reply-To: <bug-29664-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29664-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29664-70-gUGzEd4OWm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- There is an entry in the pull downs "Credit has been voided" that makes me wonder if we should still show the voided payments somehow, but marked as such. Maybe give them their own entry in the list of types? I understand what you don't want to see them in payments. Would love to get another set of eyes on this one. Martin maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:21:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:21:24 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-iSsvYt98Dw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thanks Jonathan! Chose the severity according to embarassment this might cause the library. :) Holding off for QA later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:21:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:21:57 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff interface catalog details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-t7xCfH4wVB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cleanup staff record |Cleanup staff interface |details page |catalog details page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:22:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:22:33 +0000 Subject: [Koha-bugs] [Bug 33176] Improve enforcing of RequirePaymentType In-Reply-To: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33176-70-ncKjLPmTMM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176 --- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #10) > If you want to prevent manual edition of the DOM to get empty value, then > you should also prevent bad value. It's possible to get payment_type=FOO. Good point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:24:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:24:05 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-6QWsmKaVZh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I feel it's a bug and we should fix it, but still a little confused about the different values we could use here for sort and what effect they will have. Can someone explain a little more? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:31:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:31:20 +0000 Subject: [Koha-bugs] [Bug 33069] File download from list in OPAC gives error In-Reply-To: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33069-70-xxJm4iVdwc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:31:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:31:22 +0000 Subject: [Koha-bugs] [Bug 33069] File download from list in OPAC gives error In-Reply-To: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33069-70-l1rL6YqPd1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150619&action=edit Bug 33069: Fix error in MARC download for OPAC lists There was a code typo causing an error when you tried to download a list in MARC format: Not a CODE reference at /kohadevbox/koha/opac/opac-downloadshelf.pl line 93 To test: * In the OPAC: create a new list, public or private, with some records * Open the list * Try to download the list as MARC * Verify you get an error * Apply patch * Verify you now get the expected download file * Sign off :) Co-authored-by: Kévin AYRAULT <kevin.ayrault87 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:32:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:32:20 +0000 Subject: [Koha-bugs] [Bug 33069] File download from list in OPAC gives error In-Reply-To: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33069-70-fFdYHGB3Wo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Kévin AYRAULT from comment #2) > I have the same error and after check the code, i see maybe the correction. > In line 93, there is an extra "->" after "record" in my opinion. > When I replace the line "my $record = $biblio->metadata->record->(" with "my > $record = $biblio->metadata->record(", the download works. Thank you! This was the problem, with the change the error is gone :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:34:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:34:35 +0000 Subject: [Koha-bugs] [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider In-Reply-To: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32412-70-63p9w3qSEC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #5) > Lucas, your patch is working but I think it's actually hiding another bug: > we should not reload the image for the bibliographic record when we are > browsing the shelf. > > Do you agree with my follow-up patch? yes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:35:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:35:46 +0000 Subject: [Koha-bugs] [Bug 32748] Library limitations will cause data loss when editing items In-Reply-To: <bug-32748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32748-70-f4m5br87jP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32748 --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #16) > Failing QA for comment 12. Thibaud, avoid GROUP_CONCAT, and just don't > display the libraries from where the value is limited. > > Also you should cache using the branchcode in the cache key, or you will get > random wrong results. Maybe to explain: GROUP_CONCAT creates an issue with <strict_sql_modes>1</strict_sql_modes>. If you have turned that off in koha-conf.xml you'll not see the error until you turn it back on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:37:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:37:35 +0000 Subject: [Koha-bugs] [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider In-Reply-To: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32412-70-9vCPPU6yHm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150567|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150620&action=edit Bug 32412: Do not reload COCE image for biblio We do not want to fetch again the new image for the biblio record. We only want to fetch those for the shelf browser. Note that the third parameter 'covernewwindow' was not used. Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:42:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:42:04 +0000 Subject: [Koha-bugs] [Bug 33591] Cannot merge bibliographic records In-Reply-To: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33591-70-FpojflJy03@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:42:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:42:06 +0000 Subject: [Koha-bugs] [Bug 33591] Cannot merge bibliographic records In-Reply-To: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33591-70-yN5CoZLdYO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150593|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150621&action=edit Bug 33591: Restore auto-select of checkboxes of src record when merging When merging bib records the first tab (the source record) should have all the checkboxes checked by default. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:42:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:42:27 +0000 Subject: [Koha-bugs] [Bug 33591] Cannot merge bibliographic records In-Reply-To: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33591-70-0VDCxkkT5H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29226 |32571 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:42:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:42:27 +0000 Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs In-Reply-To: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29226-70-uOe3ivicW7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33591 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 [Bug 33591] Cannot merge bibliographic records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:42:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:42:27 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: <bug-32571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32571-70-yGS9cm5Vyn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33591 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 [Bug 33591] Cannot merge bibliographic records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:42:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:42:33 +0000 Subject: [Koha-bugs] [Bug 33591] Cannot merge bibliographic records In-Reply-To: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33591-70-QAAQMoLyIq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:43:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:43:21 +0000 Subject: [Koha-bugs] [Bug 33591] Cannot merge bibliographic records In-Reply-To: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33591-70-QRMZZNHzGx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The change follows the pattern of the related bug 33590 and also works like a charm. Going straight to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:43:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:43:27 +0000 Subject: [Koha-bugs] [Bug 33591] Cannot merge bibliographic records In-Reply-To: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33591-70-4C2MdGFQtw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:48:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:48:55 +0000 Subject: [Koha-bugs] [Bug 33671] New: Database update 22.06.00.048 breaks when there are borrower_relationships.guarantor_id with NULL Message-ID: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 Bug ID: 33671 Summary: Database update 22.06.00.048 breaks when there are borrower_relationships.guarantor_id with NULL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30472 We've had 2 reports of this database update breaking the update on bug 30472. The database update altered the table without checking/dealing with existing NULL values: PabloAB: Upgrading to 22.11.02-1 from an updated 22.05 on a Debian 11: Upgrade to 22.06.00.048 [18:33:27]: Bug 30472 - borrower_relationships.guarantor_id NOT NULL ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'guarantor_id': used in a foreign key constraint 'r_guarantor' at /usr/share/koha/lib/C4/Installer.pm line 739 Maybe the same issue as on bug 32399? ------ Mona Panchaud: Hello. While upgrading from 22.05 to 22.11 we are running into the following problem that is related to this change: "Upgrade to 22.06.00.048 [20:19:53]: Bug 30472 - borrower_relationships.guarantor_id NOT NULL ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'guarantor_id': used in a foreign key constraint 'r_guarantor' at /usr/share/koha/lib/C4/Installer.pm line 743" Is there any workaround? What can we do to get the upgrade working? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472 [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:48:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:48:55 +0000 Subject: [Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL In-Reply-To: <bug-30472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30472-70-ZDKMkESWE6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33671 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 [Bug 33671] Database update 22.06.00.048 breaks when there are borrower_relationships.guarantor_id with NULL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:50:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:50:18 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33639-70-zRVFvtfQTX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #3) > This fixes the problem, but it creates another: > > * When enumchron was already filled out, selecting an item group now will > overwrite the entered value and replace it. > > I feel like the initial intention here was to avoid this and I think that > would be correct: > > if ( ! $('input.items-enumchron').val() ) { > > I think if we keep the check, but change it to checking for the name with . > not -, it might actually work? > > > if ( ! $('input[name="items.enumchron"]').val() ) { That makes sense. Should we also warn the user that enumchron value is not changing? If I clicked the dropdown and suspected the value was going to change but it does not I might be confused. So maybe we need a pop-up? "You are about to to change this value from A to B. Would you like to continue?" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:51:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:51:11 +0000 Subject: [Koha-bugs] [Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT NULL In-Reply-To: <bug-30472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30472-70-eR9AKJfkjl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Mona, hi Pablo, I've moved the problem into a new bug: bug 33671. What you can do: could you check if you have NULL values in borrower_relationships.guarantor_id? Also, which DBMS are you using and what is the version? (MariaDB or MySQL, check the about page in Koha) Please add info to bug 33671. Thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 3 23:51:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 21:51:42 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-KwKAaQ0cnr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Database update |Database update |22.06.00.048 breaks when |22.06.00.048 breaks update |there are |process |borrower_relationships.guar | |antor_id with NULL | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 00:03:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 22:03:06 +0000 Subject: [Koha-bugs] [Bug 33672] New: Item group features shows when placing holds if EnableItemGroupHolds is disabled Message-ID: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33672 Bug ID: 33672 Summary: Item group features shows when placing holds if EnableItemGroupHolds is disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 24857 If you don't want to allow item group holds, the option to do so should not show on the place hold forms in OPAC and staff interface when EnableItemGroupHolds is disabled. Currnetly the option always shows. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to group items for records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 00:03:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 22:03:06 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24857-70-qGpFJmjmQH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33672 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33672 [Bug 33672] Item group features shows when placing holds if EnableItemGroupHolds is disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 00:20:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 22:20:22 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33639-70-Km2IOyotAQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Actually I was quite surprised about the forced connection to enumchron. But then I realized that I always grouped the items from the catalog detail page. If you do that, enumchron is not altered/updated neither when empty nor when set. So we have some inconsistency there. We do display the item group in the staff interface items table, but we don't display it in the OPAC. Enumchron shows in a lot of places, soo I understand the idea. At the same time it feels not quite right yet. The initial intention was to not overwrite existing data, I think this is a good default. I am not sure if a dialog could get annoying, ideally maybe a checkbox setting to turn it off, that is remembered? But we should try to limit the changes here to the necessary. I think maybe we should stick to 'don't overwrite if already set' and work on a more sophisticated solution separately (keeping backporting in mind) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 00:24:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 22:24:05 +0000 Subject: [Koha-bugs] [Bug 30590] Add option for using AutoSelfCheckID and AutoSelfCheckPass values to log into OPAC self check-in module In-Reply-To: <bug-30590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30590-70-2FXUxtPkEd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30590 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |RESOLVED --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Mirjam Vantieghem from comment #7) > This bug seems to have the same aim as #Bug 22322. > Mark as duplicate? Hi Mirjam, I agree they sound the same and as the other already has signed off patches, I'll mark this one as the duplicate for now. *** This bug has been marked as a duplicate of bug 22322 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 00:24:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 22:24:05 +0000 Subject: [Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout) In-Reply-To: <bug-22322-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22322-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22322-70-XSC1MVQDvN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 30590 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 00:28:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 22:28:56 +0000 Subject: [Koha-bugs] [Bug 33610] Accelerated Reading Level Search not accurate In-Reply-To: <bug-33610-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33610-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33610-70-KJRAXTYdO4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33610 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Daphne, are you using Zebra or Elasticsearch? How do you search for the reading level? Are you using "expert search" or some other way? Both search engines might treat . as a space, making 5.6 into too separate words. For Zebra using exact field search with ,ext might work, but I haven't figured out yet how to do an exact field search with Elasticsearch. You could try enclosing in "", but I feel it's probably not enough here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 00:32:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 22:32:07 +0000 Subject: [Koha-bugs] [Bug 33412] Problem importing records (bug 15869 follow-up) wrong use of assignment In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-TVL49aoyMY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 00:32:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 22:32:09 +0000 Subject: [Koha-bugs] [Bug 33412] Problem importing records (bug 15869 follow-up) wrong use of assignment In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-vPB2IHjoQs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150191|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150622&action=edit Bug 33412: Fix comparison when checking for overlay framework TO test: 1 - Cataloging -> Export catalog data 2 - Export a record fom your catalog 3 - Cataloging -> Stage record for import 4 - Import the record, use Record matchign rule: KohaBiblio (999c) 5 - Stage, view batch 6 - Record should match the one that was exported 7 - When replacing record use this framework, choose a different value than current framework of record 8 - Import this batch 9 - View and edit record - note framework did not change 10 - Apply patch 11 - Restart all 12 - Repeat 4-8 13 - View and edit record, confirm framework has changed 14 - Sign off Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 00:33:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 22:33:06 +0000 Subject: [Koha-bugs] [Bug 33412] Problem importing records (bug 15869 follow-up) wrong use of assignment In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-MhlSyVseSQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- As the feature is already in stable releases it might be nice to rephrase the bug description a little to be more descriptive of how the problem manifests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 00:35:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 22:35:22 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17170-70-2cEQ6kxidT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #152 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Caroline Cyr La Rose from comment #151) > I added some stuff to the manual. Hopefully I didn't get it completely > wrong. I admit I didn't quite understand the use case for the URL thing, so > I didn't add that in. But if someone has a specific example, feel free to > add it in, or tell me and I'll add it. Do you mean the part about keeping URLs shorter? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 01:26:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 May 2023 23:26:54 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16122-70-gkQLuSzFDa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #30 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150623&action=edit Bug 16122: Add maintenance script to update items.localuse from stats -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 02:12:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 00:12:25 +0000 Subject: [Koha-bugs] [Bug 32916] [Bug 30280 follow-up] Problems in linking authorities to biblio fields (MARC 21) In-Reply-To: <bug-32916-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32916-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32916-70-QuoGjL9LeE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32916 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #14 from Phil Ringnalda <phil at chetcolibrary.org> --- Unsurprisingly, patches no longer apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 02:49:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 00:49:20 +0000 Subject: [Koha-bugs] [Bug 33673] New: Global system preferences - change to just system preferences Message-ID: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673 Bug ID: 33673 Summary: Global system preferences - change to just system preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Day-to-day, we normally just refer to "system preferences" rather than "global system preferences". I don't think there is any clear distinction between "Global system preferences" and "System preferences", or any need to have the "Global". This would mean changing Administration > Global system preferences to just "System preferences". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 02:49:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 00:49:44 +0000 Subject: [Koha-bugs] [Bug 33673] Global system preferences - change to just system preferences In-Reply-To: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33673-70-bFBRYFxCZk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 04:22:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 02:22:20 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-C71oLv18Bs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook <dcook at prosentient.com.au> --- (In reply to Jonathan Druart from comment #2) > I think we really to do this move, it will help people with lot of items > attached to a single biblio. I 100% agree. Since this is one of the big limitations I bump into with Koha these days, I should be able to find time to test at the very least. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 04:23:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 02:23:05 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-YUqV0TR2C5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- Oh wait... this is for the staff interface? Hmm... it's probably a more concern for us for the OPAC. Telling staff they have to wait a while isn't so bad in comparison to expecting public users to wait. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 04:37:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 02:37:08 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface In-Reply-To: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15428-70-VQyFJKiwtR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #19 from David Cook <dcook at prosentient.com.au> --- (In reply to Katrin Fischer from comment #18) > But how do we know if it's an OPAC or a staff side cookie? Maybe naming the > cookies differently and by that allowing to really have separate sessions > independent of setup would be better. Yes that's what I was thinking. We're replace CGISESSID with KOHA_OPAC_SESSID and KOHA_STAFF_SESSID or something like that, and then depending on where the auth is being initiated the appropriate cookie name would be looked up. (That said, I think that might get complicated with the API...so something to investigate further.) > One reason to use ports is to block access to the staff interface in a > firewall. It's a valid configuration option. You mean using access control lists in a firewall? That's true. I suppose that using different ports would be the only way to do it with that setup. I often suggest restricting by IP address at the HTTP/application layer, since it's easy to due on a per-host basis, but there's certainly advantages to restricting access at lower OSI layers. It's good to know that there are other folk out there restricting access to their staff interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:02:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 06:02:32 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-aTMvlcbgGT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:15:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 06:15:55 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-KFVZaDJdYT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #31 from Lari Strand <lmstrand at gmail.com> --- (In reply to Julian Maurice from comment #30) > > How would I bring mouseover back as a valid function in code? > Can you post a link to your plugin ? > Here: https://github.com/KohaSuomi/Koha-22x/commit/ee4464e7f428d14d9110b417878c43ddcbe73385 Should work out of the box. This one's been attached to the 650a field (modifies it's accompanying fields/tags). You can also mail me directly if you can help out with building the mouseover version. TY! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:19:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 06:19:48 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-AwCl4PGhVa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Biblibre Sandboxes <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150582|0 |1 is obsolete| | --- Comment #4 from Biblibre Sandboxes <sandboxes at biblibre.com> --- Created attachment 150624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150624&action=edit Bug 33653: Never consider received orders as late We should not list received orders on the late orders page. Test plan: * Create a basket * Create a normal order (not from a subscription, no standing order) * Leave estimated delivery date empty * Close the basket * Create a new invoice and receive the order line * Go to acq > late orders * Verify the order is not in the list * Set filter for 'To' date into the future, i.e. 01/01/2025 => Without this patch the order shows up => With this patch applied the received order does not show up Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:20:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 06:20:51 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-7Ex7LHMNcf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Michaela Sieber <michaela.sieber at kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Michaela Sieber <michaela.sieber at kit.edu> --- Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:21:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 06:21:00 +0000 Subject: [Koha-bugs] [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider In-Reply-To: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32412-70-8UjuRgBs4m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:21:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 06:21:02 +0000 Subject: [Koha-bugs] [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider In-Reply-To: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32412-70-FEdZXfv3dJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149219|0 |1 is obsolete| | Attachment #150620|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150625&action=edit Bug 32412: Empty coce container before appending image To test: 1. Apply patch and clear browser cache 2. Turn on Coce for the OPAC. 3. OPACShelfBrowser must be on 4. Find a record that returns a cover image and open it's detail page. 5. Use the next/previous navigation links in the OPACShelfBrowser 6. Notice that no extra image is being added to the biblio-cover-slider. 7. Make sure that Coce images still load correctly in on the OPAC detail page, OPAC results page, and in the shelf browser. Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:21:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 06:21:05 +0000 Subject: [Koha-bugs] [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider In-Reply-To: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32412-70-EK6lHsviqZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150626&action=edit Bug 32412: Do not reload COCE image for biblio We do not want to fetch again the new image for the biblio record. We only want to fetch those for the shelf browser. Note that the third parameter 'covernewwindow' was not used. Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:24:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 06:24:30 +0000 Subject: [Koha-bugs] [Bug 33176] Improve enforcing of RequirePaymentType In-Reply-To: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33176-70-eq4M7IqJ7z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:32:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 06:32:52 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31735-70-ZysG1t6Y3F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 --- Comment #77 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #72) > I am getting a conflict here that I managed to resolve, but then a "sha1 > lacking or useless" on bug 32496. Could you rebase and eventually push both > to a remote branch? I pushed the patches to https://gitlab.com/joubu/Koha/-/commits/bug_32496 in case we need it later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:40:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 06:40:02 +0000 Subject: [Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6 In-Reply-To: <bug-32910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32910-70-gBGxx6s9xe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Thanks Owen! I think there is this one left: koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt: .fa-file-archive-o { Also, are you sure we need v4-shims? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:44:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 06:44:13 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-fqu1eR2Hi0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- We should lower the priority here, it's not a blocker and it's a long standing bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:47:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 06:47:02 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-uK9d0cTB4x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- To get it working right away, just do this in mysql: DELETE FROM borrower_relationships WHERE guarantor_id IS NULL This is just bad data. You cannot add such relations (anymore). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:47:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 06:47:09 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-dQ4N1frcoi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:47:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 06:47:32 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-TpaCM57xsN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Adding a follow-up to update dbrev accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 08:47:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 06:47:43 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-QrOqmhwEQB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:07:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 07:07:21 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-XxWfDAPGxy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #49 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- critical with simple rebase that is abandoned? why?... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:08:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 07:08:06 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-FjohGKASJf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:08:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 07:08:10 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-B0bWVlt1ik@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145507|0 |1 is obsolete| | --- Comment #50 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150627&action=edit Bug 28267: Add warnings for database row formats This patch adds a warning on about.pl regarding database row formats other than "DYNAMIC". It points to the Koha community wiki for more information on how to resolve the problem. This patch also stops the installer if there are any database tables with a row format other than "DYNAMIC". It points to the Koha community wiki for more information on how to resolve the problem. Test plan: 0a. Apply the patch 0b. koha-plack --restart kohadev 1a. koha-mysql kohadev 1b. ALTER TABLE tags ROW_FORMAT=COMPACT; 2. Go to http://localhost:8081/cgi-bin/koha/about.pl 3. Note that there is a warning about database row formats 4a. koha-mysql kohadev 4b. ALTER TABLE tags ROW_FORMAT=DYNAMIC; 5. Go to http://localhost:8081/cgi-bin/koha/about.pl 6. Note that there is no warning about database row formats 7a. Manually change the version in Koha.pm to a higher version 7b. koha-plack --restart kohadev 8a. koha-mysql kohadev 8b. ALTER TABLE tags ROW_FORMAT=COMPACT; 9. Go to http://localhost:8081/ 10. Log into the web installer and click through until you reach a warning telling you that you have database row formats other than 'DYNAMIC' 11. Note that you can't progress with the installer until this problem is resolved 12a. koha-mysql kohadev 12b. ALTER TABLE tags ROW_FORMAT=DYNAMIC; 13. Refresh the page or redo the web installer process 14. Note that you're no longer blocked from running the installer due to database row format 15. Undo your change to Koha.pm 16. Profit Note: Due to bug 32665 you'll see an unrelated warning on step 3 Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:08:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 07:08:14 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-l7iPHnH9Vf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #51 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150628&action=edit Bug 28267: Simplify things We don't need: * a separate Koha::Installer module when we already have C4::Installer * the tests as they are actually modifying the DB structure without rolling back * An unecessary complicated subroutine, just make is simple Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:10:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 07:10:14 +0000 Subject: [Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 In-Reply-To: <bug-25439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25439-70-MTqZY9ObnN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Looks like this is done then, closing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:15:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 07:15:55 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-4Gazyf9GWI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:15:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 07:15:57 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-UOGSo29rSi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150629&action=edit Bug 33671: Fix for 30472 - Remove null-guarantors These guarantors cannot be added. They are of no use. NOTE FOR QA/RM: I do not think that it is needed to add a new db rev for this change since it happens seldom. But if you think that it is, just copy it to atomicupdate/change bugno. Test plan: [1] Check your table definition and modify it: alter table borrower_relationships modify column `guarantor_id` int(11) NULL; [2] Add an empty guarantor: insert into borrower_relationships (guarantee_id,relationship) values (SOME_PATRON_ID,'father'); [3] Run the dbrev and verify that the inserted record has been removed. [4] Check table definition with 'show create table borrower_relationships'. You should see NOT NULL with guarantor_id. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:15:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 07:15:59 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-AFjWcGNoT2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150630&action=edit Bug 33671: Update POD, remove unneeded check in relationship->guarantor [1] Update POD for $patron->guarantor_relationships [2] Remove check from Patron::Relationship->guarantor Test plan: Run t/db_dependent/Koha/Patron.t Run t/db_dependent/Patron/Relationships.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:16:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 07:16:25 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-veaw1YYaMB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Trivial: self SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:19:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 07:19:39 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-IDwMthdX6s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #52 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Janusz, do you think you could add your stamp to this (bug 33277) and bug 33557? If you do we can consider they Passed QA I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:25:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 07:25:01 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-Whz5M3Ym1s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:36:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 07:36:48 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-Pau0x2SCma@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #67 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #61) > (In reply to Jonathan Druart from comment #59) > > No, please read the previous comments. > > Well, yes, we could, if we embed Data::Session and modify it. But why would > we do that? > > Isn't the "lib trick" already in place anyway? I am wrong. The existing "lib trick" is copying our 'lib' dir content to /usr/share/koha/lib but we need yamlxs.pm in /usr/share/perl5/Data/Session/Serialize/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:54:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 07:54:10 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-NGmt6MWrms@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:55:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 07:55:43 +0000 Subject: [Koha-bugs] [Bug 33069] File download from list in OPAC gives error In-Reply-To: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33069-70-wQF5variP4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 09:55:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 07:55:45 +0000 Subject: [Koha-bugs] [Bug 33069] File download from list in OPAC gives error In-Reply-To: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33069-70-RmGOAhZUUp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150619|0 |1 is obsolete| | --- Comment #5 from Magnus Enger <magnus at libriotech.no> --- Created attachment 150631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150631&action=edit Bug 33069: Fix error in MARC download for OPAC lists There was a code typo causing an error when you tried to download a list in MARC format: Not a CODE reference at /kohadevbox/koha/opac/opac-downloadshelf.pl line 93 To test: * In the OPAC: create a new list, public or private, with some records * Open the list * Try to download the list as MARC * Verify you get an error * Apply patch * Verify you now get the expected download file * Sign off :) Co-authored-by: Kévin AYRAULT <kevin.ayrault87 at gmail.com> Signed-off-by: Magnus Enger <magnus at libriotech.no> Nasty error before the patch; nice, tasty MARC download after. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:29:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 08:29:09 +0000 Subject: [Koha-bugs] [Bug 33069] File download from list in OPAC gives error In-Reply-To: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33069-70-wztQ4UDcSz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx Magnus :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:39:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 08:39:57 +0000 Subject: [Koha-bugs] [Bug 19249] Date picker broken in "Quick add new patron" form In-Reply-To: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19249-70-rWx1LCWxtx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150589|0 |1 is obsolete| | --- Comment #12 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 150632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150632&action=edit Bug 19249: Fix date inputs on patron quick add form This patch create a "apply_flatpickr" JS function to make the code reusable from the template, where we loop over the date inputs to reinstantiate flatpickr. Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:40:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 08:40:35 +0000 Subject: [Koha-bugs] [Bug 19249] Date picker broken in "Quick add new patron" form In-Reply-To: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19249-70-AqhvUueIIi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Sally <sally.healey at cheshiresharedservices.gov.uk> --- Works as described, thanks for this important fix! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:42:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 08:42:11 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-phkeb8Nkit@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- blocker is defined as data loss. I hope to provide a patch before freezes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:44:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 08:44:08 +0000 Subject: [Koha-bugs] [Bug 33674] New: Landscape cover images are resized ignoring if image/book cover width > height Message-ID: <bug-33674-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33674 Bug ID: 33674 Summary: Landscape cover images are resized ignoring if image/book cover width > height Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: steve at softwaremage.co.nz QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The code fragments below (/Koha/CoverImage.pm) need to determine if the width is greater than the height before resizing and creating the thumbnails and 'fullsize' image version. Otherwise wide books are always resized as if they were tall books. As a result the thumbnails and fullsize images of wide books are always scaled smaller than their 'portrait' counterparts. Needless to say these hardcoded values should be part of system preferences. They were set before the days of 4K monitors. I think that might be an open item. sub new { my ( $class, $params ) = @_; my $src_image = delete $params->{src_image}; if ( $src_image ) { ; # GD autodetects three basic image formats: PNG, JPEG, XPM; we will convert all to PNG which is lossless... # Check the pixel size of the image we are about to import... my $thumbnail = $class->_scale_image( $src_image, 140, 200 ) ; # MAX pixel dims are 140 X 200 for thumbnail... my $fullsize = $class->_scale_image( $src_image, 600, 800 ) ; # MAX pixel dims are 600 X 800 for full-size image... $params->{mimetype} = 'image/png'; $params->{imagefile} = $fullsize->png(); $params->{thumbnail} = $thumbnail->png(); } return $class->SUPER::new($params); } sub _scale_image { my ( $self, $image, $maxwidth, $maxheight ) = @_; my ( $width, $height ) = $image->getBounds(); if ( $width > $maxwidth || $height > $maxheight ) { my $percent_reduce; # Percent we will reduce the image dimensions by... if ( $width > $maxwidth ) { $percent_reduce = sprintf( "%.5f", ( $maxwidth / $width ) ) ; # If the width is oversize, scale based on width overage... } else { $percent_reduce = sprintf( "%.5f", ( $maxheight / $height ) ) ; # otherwise scale based on height overage. } my $width_reduce = sprintf( "%.0f", ( $width * $percent_reduce ) ); my $height_reduce = sprintf( "%.0f", ( $height * $percent_reduce ) ); my $newimage = GD::Image->new( $width_reduce, $height_reduce, 1 ) ; #'1' creates true color image... $newimage->copyResampled( $image, 0, 0, 0, 0, $width_reduce, $height_reduce, $width, $height ); return $newimage; } else { return $image; } } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:45:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 08:45:53 +0000 Subject: [Koha-bugs] [Bug 30978] Potential data loss when using Quick add new patron In-Reply-To: <bug-30978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30978-70-tTeVdgfo8H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30978 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Sally <sally.healey at cheshiresharedservices.gov.uk> --- *** This bug has been marked as a duplicate of bug 31497 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:45:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 08:45:53 +0000 Subject: [Koha-bugs] [Bug 31497] Quick add: mandatory fields save as empty when not filled in before first save attempt In-Reply-To: <bug-31497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31497-70-a8DuJbqISd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk --- Comment #14 from Sally <sally.healey at cheshiresharedservices.gov.uk> --- *** Bug 30978 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:50:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 08:50:08 +0000 Subject: [Koha-bugs] [Bug 29303] Quick add form duplicates HTML ID's In-Reply-To: <bug-29303-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29303-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29303-70-dJWtlOlpYA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29303 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #5 from Sally <sally.healey at cheshiresharedservices.gov.uk> --- Appears to have been resolved as part of Bug 31497 *** This bug has been marked as a duplicate of bug 31497 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 10:50:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 08:50:08 +0000 Subject: [Koha-bugs] [Bug 31497] Quick add: mandatory fields save as empty when not filled in before first save attempt In-Reply-To: <bug-31497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31497-70-WLtTGYHXdb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 --- Comment #15 from Sally <sally.healey at cheshiresharedservices.gov.uk> --- *** Bug 29303 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:35:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 09:35:46 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-Ye1mWgrplv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 11:44:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 09:44:55 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-Po0BwLms9M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #32 from Lari Strand <lmstrand at gmail.com> --- These patches seems to break the functionality in barcode generator plugin barcode.pl. I removed the patches and it started generating barcodes again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:08:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:08:12 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-6gQE9UDeJK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #68 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150633&action=edit Bug 17427: Remove more occurrences of CGI::Session -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:08:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:08:16 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-lg4uY8TQPg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #69 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150634&action=edit Bug 17427: Remove SessionStorage mock from tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:08:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:08:20 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-yp2sZRhOmP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #70 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150635&action=edit Bug 17427: Embed Data::Session Test plan: Install libdata-session-perl and make sure our lib has priority over the installed version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:08:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:08:24 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-sMgWHRehEJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #71 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150636&action=edit Bug 17427: Remove confusion between session id and param id FIXME Certainly more work needed here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:08:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:08:28 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-qjjnMsEyuN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #72 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150637&action=edit Bug 17427: HACKY - force new session Look at Data::Session->new, it's calling $self -> load_session; Then look at load_session then user_id => we are retrieving the ID from the cookie But in our Auth.t tests we are mocking CGI->cookie to always return the previous CGISESSID We should certainly adjust the test here, and remove this patch. 194 # Note: We can test return values from checkauth here since we mocked the safe_exit after the Redirect 303 195 is( $return[0], $patron2->userid, 'Login of patron2 approved' ); 196 isnt( $return[2], $sessionID, 'Did not return previous session ID' ); 197 ok( $return[2], 'New session ID not empty' ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:08:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:08:31 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-ISaNS7jBby@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #73 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150638&action=edit Bug 17427: Retrieve sessionID from HTTP_COOKIE To make some tests pass (t/db_dependent/Auth.t) and mimick what did CGI::Session, but that is certainly useless and the tests should be adjusted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:08:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:08:35 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-iBzkjSSHwp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #74 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150639&action=edit Bug 17427: Fix id vs userid in tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:08:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:08:49 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-V4w6BqbB6a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #75 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- still 2 tests failing /kohadevbox/koha/t/db_dependent/Auth.t .. 12/17 # Failed test at /kohadevbox/koha/t/db_dependent/Auth.t line 840. # got: 'anon' # expected: 'expired' # Failed test at /kohadevbox/koha/t/db_dependent/Auth.t line 841. # got: 'Data::Session=HASH(0x564c72143498)' # expected: undef # Looks like you failed 2 tests of 31. /kohadevbox/koha/t/db_dependent/Auth.t .. 15/17 # Failed test 'checkauth & check_cookie_auth' # at /kohadevbox/koha/t/db_dependent/Auth.t line 909. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:26:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:26:46 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-lu41N9DQEl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #76 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Kyle M Hall from comment #66) > The big blocker is replacing the use of CGI::Session::Find > (https://metacpan.org/pod/CGI::Session#find(-%5C&code-)) in C4::Auth_with_cas Yes, that's a tricky one. And really ugly. First the method is experimental, and then we are looping over all the sessions to retrieve the corresponding one... outch! We could eventually generate the session ID from the CAS ticket (using Koha::Encryption for instance?). Would that work? I am not familiar with CAS! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:27:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:27:40 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-eaLaWeyhci@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|jonathan.druart+koha at gmail. |koha-bugs at lists.koha-commun |com |ity.org --- Comment #77 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I am done for now, please help (review, feedback, test, see last commit messages)! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:30:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:30:17 +0000 Subject: [Koha-bugs] [Bug 33297] Typo system preference RetainPatronSearchTerms in DB revs 220600044.pl In-Reply-To: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33297-70-Cs08RKffCu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33297 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to David Cook from comment #12) > Hoping to look at these soon... How soon? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:30:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:30:57 +0000 Subject: [Koha-bugs] [Bug 33358] Do not use editorconfig for vue files In-Reply-To: <bug-33358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33358-70-KtnqENn6iD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Paul, Pedro, can you help with this one please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:31:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:31:02 +0000 Subject: [Koha-bugs] [Bug 33358] Do not use editorconfig for vue files In-Reply-To: <bug-33358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33358-70-EKnpdLekGn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:31:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:31:18 +0000 Subject: [Koha-bugs] [Bug 33675] New: OAuth should support state parameter Message-ID: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 Bug ID: 33675 Summary: OAuth should support state parameter Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Some Authentication solutions require a 'state' parameter to be passed during authentication to verify the sources on either end, it is supported by Mojolicious: https://metacpan.org/pod/Mojolicious::Plugin::OAuth2 We should add this to Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:31:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:31:32 +0000 Subject: [Koha-bugs] [Bug 33675] OAuth should support state parameter In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-0Ea2eSM5lr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Version|22.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:37:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:37:14 +0000 Subject: [Koha-bugs] [Bug 33626] compare_es_to_db.pl does not work with Search::Elasticsearch 7.0 In-Reply-To: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33626-70-KBSJ8f9Xme@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33626 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:37:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:37:16 +0000 Subject: [Koha-bugs] [Bug 33626] compare_es_to_db.pl does not work with Search::Elasticsearch 7.0 In-Reply-To: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33626-70-KzpA1WgnBM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33626 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150289|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150640&action=edit Bug 33626: Remove invalid params This patch reformats the params passed to scroll_helper as defined here: https://metacpan.org/pod/Search::Elasticsearch::Client::7_0::Scroll To test: 1 - perl misc/maintenance/compare_es_to_db.pl 2 - It dies: [Param] ** Unknown param (scroll_in_qs) in (search) request. , called from sub Search::Elasticsearch::Client::7_0::Direct::scroll_helper at misc/maintenance/compare_es_to_db.pl line 55. 3 - Apply patch 4 - Repeat 5 - It succeeds! Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:37:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:37:26 +0000 Subject: [Koha-bugs] [Bug 33626] compare_es_to_db.pl does not work with Search::Elasticsearch 7.0 In-Reply-To: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33626-70-NZ21ghVZmp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33626 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:37:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:37:33 +0000 Subject: [Koha-bugs] [Bug 33626] compare_es_to_db.pl does not work with Search::Elasticsearch 7.0 In-Reply-To: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33626-70-vH1vHYFIV7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33626 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25439 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:37:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:37:33 +0000 Subject: [Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 In-Reply-To: <bug-25439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25439-70-mSd39XXP3f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33626 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33626 [Bug 33626] compare_es_to_db.pl does not work with Search::Elasticsearch 7.0 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:38:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:38:54 +0000 Subject: [Koha-bugs] [Bug 27542] It should be possible to cancel an ILL request sent to a partner In-Reply-To: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27542-70-H5UktiwAEc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27542 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147897|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150641&action=edit Bug 27542: Allow cancellation of partner ILL This commit enables the display of the "Revert request" button when a request's status is GENREQ / "Requested from partners" The relevant unit test has also been updated Rescued-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:38:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:38:57 +0000 Subject: [Koha-bugs] [Bug 27542] It should be possible to cancel an ILL request sent to a partner In-Reply-To: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27542-70-YdrsRnbtCi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27542 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147898|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150642&action=edit Bug 27542: (follow-up) Capitalization Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:38:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:38:59 +0000 Subject: [Koha-bugs] [Bug 27542] It should be possible to cancel an ILL request sent to a partner In-Reply-To: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27542-70-R7seV1RI5w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27542 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147899|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150643&action=edit Bug 27542: (follow-up) Fix unit test Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:39:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:39:08 +0000 Subject: [Koha-bugs] [Bug 27542] It should be possible to cancel an ILL request sent to a partner In-Reply-To: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27542-70-JipBzZ93ma@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27542 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:39:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:39:47 +0000 Subject: [Koha-bugs] [Bug 27542] It should be possible to cancel an ILL request sent to a partner In-Reply-To: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27542-70-oPJ4idcrBN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27542 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Added SO lines from customers using this in production. My feeling is we should go straight to PQA here.. the code is well and truly tested and working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:40:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:40:12 +0000 Subject: [Koha-bugs] [Bug 27542] It should be possible to cancel an ILL request sent to a partner In-Reply-To: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27542-70-FKZXXo9NdT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27542 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:43:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:43:27 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-6Q3bEBhIhj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:43:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:43:36 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-Eqsdk4OcCY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:43:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:43:36 +0000 Subject: [Koha-bugs] [Bug 32435] Add resolution types to catalog concerns In-Reply-To: <bug-32435-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32435-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32435-70-fM8ldr98C1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435 Bug 32435 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:43:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:43:36 +0000 Subject: [Koha-bugs] [Bug 32436] Add 'quick replies' to catalog concerns In-Reply-To: <bug-32436-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32436-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32436-70-ZoJu3JMnsF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32436 Bug 32436 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:43:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:43:37 +0000 Subject: [Koha-bugs] [Bug 33286] 'Catalog record' should be 'Bibliographic record' In-Reply-To: <bug-33286-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33286-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33286-70-9bIdAp8kPU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33286 Bug 33286 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:43:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:43:37 +0000 Subject: [Koha-bugs] [Bug 33288] Catalog concerns - Fallback email when CatalogerEmails is empty In-Reply-To: <bug-33288-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33288-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33288-70-4EUF81fKNa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33288 Bug 33288 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:43:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:43:37 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-AF1w7jgxaW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Bug 33313 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:43:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:43:37 +0000 Subject: [Koha-bugs] [Bug 33327] Catalog concerns - Hide resolved catalog concerns by default In-Reply-To: <bug-33327-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33327-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33327-70-b1B95cInoD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33327 Bug 33327 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:43:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:43:38 +0000 Subject: [Koha-bugs] [Bug 33494] Catalog concerns - Toggle 'Hide resolved' and 'Show all' In-Reply-To: <bug-33494-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33494-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33494-70-6Iwqa7Ozkd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33494 Bug 33494 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:43:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:43:38 +0000 Subject: [Koha-bugs] [Bug 33498] Catalog concerns - Lots of whitespace before the notice text In-Reply-To: <bug-33498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33498-70-YlPB6g4npU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33498 Bug 33498 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:43:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:43:38 +0000 Subject: [Koha-bugs] [Bug 33532] Catalog concerns - Title of the page says Tools instead of Cataloging In-Reply-To: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33532-70-MqOMV56yUs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33532 Bug 33532 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:43:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:43:38 +0000 Subject: [Koha-bugs] [Bug 33593] CatalogConcernTemplate needs to be HTML In-Reply-To: <bug-33593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33593-70-m5yqx5rB0x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33593 Bug 33593 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:43:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:43:38 +0000 Subject: [Koha-bugs] [Bug 33266] Patron name missing space before surname In-Reply-To: <bug-33266-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33266-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33266-70-7OK4TKoXWj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33266 Bug 33266 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:43:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:43:39 +0000 Subject: [Koha-bugs] [Bug 33315] Missing space in TICKET_NOTIFY In-Reply-To: <bug-33315-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33315-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33315-70-isRNC9SHe8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33315 Bug 33315 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:45:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:45:25 +0000 Subject: [Koha-bugs] [Bug 19249] Date picker broken in "Quick add new patron" form In-Reply-To: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19249-70-yuO2SzMjtS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:45:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:45:28 +0000 Subject: [Koha-bugs] [Bug 19249] Date picker broken in "Quick add new patron" form In-Reply-To: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19249-70-v0C3sxfJMS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150632|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150644&action=edit Bug 19249: Fix date inputs on patron quick add form This patch create a "apply_flatpickr" JS function to make the code reusable from the template, where we loop over the date inputs to reinstantiate flatpickr. Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:45:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:45:33 +0000 Subject: [Koha-bugs] [Bug 19249] Date picker broken in "Quick add new patron" form In-Reply-To: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19249-70-z6VKzIyd6q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:48:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:48:24 +0000 Subject: [Koha-bugs] [Bug 33676] New: Recognise documentation submissions on the about page Message-ID: <bug-33676-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33676 Bug ID: 33676 Summary: Recognise documentation submissions on the about page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Right now you're only recognised in the about page for work carried out in the main git repository.. however, documentation submissions are valid contributions to the project as a whole too and I think we should start recognising those too. We could either refine our release scripts to also look at the docs repository and update the history and authors pages respectively or we could try to catch new docs people by adding them to the documentation team retrospectively at each release? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:48:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:48:44 +0000 Subject: [Koha-bugs] [Bug 33676] Recognise documentation submissions on the about page In-Reply-To: <bug-33676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33676-70-2bPRgtWT1A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33676 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon at ptfs-europe. | |com, | |caroline.cyr-la-rose at inlibr | |o.com, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:56:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:56:24 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-OCp8MrZiMU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:56:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:56:26 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-VmnNEmi5AS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150627|0 |1 is obsolete| | --- Comment #52 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150645&action=edit Bug 28267: Add warnings for database row formats This patch adds a warning on about.pl regarding database row formats other than "DYNAMIC". It points to the Koha community wiki for more information on how to resolve the problem. This patch also stops the installer if there are any database tables with a row format other than "DYNAMIC". It points to the Koha community wiki for more information on how to resolve the problem. Test plan: 0a. Apply the patch 0b. koha-plack --restart kohadev 1a. koha-mysql kohadev 1b. ALTER TABLE tags ROW_FORMAT=COMPACT; 2. Go to http://localhost:8081/cgi-bin/koha/about.pl 3. Note that there is a warning about database row formats 4a. koha-mysql kohadev 4b. ALTER TABLE tags ROW_FORMAT=DYNAMIC; 5. Go to http://localhost:8081/cgi-bin/koha/about.pl 6. Note that there is no warning about database row formats 7a. Manually change the version in Koha.pm to a higher version 7b. koha-plack --restart kohadev 8a. koha-mysql kohadev 8b. ALTER TABLE tags ROW_FORMAT=COMPACT; 9. Go to http://localhost:8081/ 10. Log into the web installer and click through until you reach a warning telling you that you have database row formats other than 'DYNAMIC' 11. Note that you can't progress with the installer until this problem is resolved 12a. koha-mysql kohadev 12b. ALTER TABLE tags ROW_FORMAT=DYNAMIC; 13. Refresh the page or redo the web installer process 14. Note that you're no longer blocked from running the installer due to database row format 15. Undo your change to Koha.pm 16. Profit Note: Due to bug 32665 you'll see an unrelated warning on step 3 Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:56:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:56:29 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-3kOHpgxJsz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150628|0 |1 is obsolete| | --- Comment #53 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150646&action=edit Bug 28267: Simplify things We don't need: * a separate Koha::Installer module when we already have C4::Installer * the tests as they are actually modifying the DB structure without rolling back * An unecessary complicated subroutine, just make is simple WNC amended patch: Remove change to Koha.pm Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:57:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:57:23 +0000 Subject: [Koha-bugs] [Bug 32916] [Bug 30280 follow-up] Problems in linking authorities to biblio fields (MARC 21) In-Reply-To: <bug-32916-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32916-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32916-70-KoEh6oypdh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32916 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |DUPLICATE --- Comment #15 from Nick Clemens <nick at bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 33277 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 12:57:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 10:57:23 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-VNmlzGj5Mf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #53 from Nick Clemens <nick at bywatersolutions.com> --- *** Bug 32916 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:03:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:03:55 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17170-70-09CXrKOcXI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #153 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #152) > (In reply to Caroline Cyr La Rose from comment #151) > > I added some stuff to the manual. Hopefully I didn't get it completely > > wrong. I admit I didn't quite understand the use case for the URL thing, so > > I didn't add that in. But if someone has a specific example, feel free to > > add it in, or tell me and I'll add it. > > Do you mean the part about keeping URLs shorter? It's really just kind of a convenience, so you could create a 'New books search' and save it, but not select to display it as a filter, but then you could add a link: <a href="http://localhost:8080/cgi-bin/koha/opac-search.pl?limit=search_filter:1">New books</a> For a more complicated search, say "Picture books" / subject: Christmas / location: Children's room / Available Only It just provides a shorter more readable link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:05:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:05:14 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-0mem42UkG4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Problem importing records |(bug 15869 follow-up) |(bug 15869 follow-up) wrong |Overlay record framework is |use of assignment |always setting records to | |original framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:13:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:13:15 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-fIXBa3iXUf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 Mona Panchaud <m+koha at mpan.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m+koha at mpan.ch --- Comment #6 from Mona Panchaud <m+koha at mpan.ch> --- Thanks for taking a look at this and adding a fix! Just to be sure and for my understanding: The data that is deleted is not used by anything else? Will this fix get into the 22.11 branch so that we can try the update again in a straightforward way? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:16:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:16:11 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-Trx1O8mVWu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150647&action=edit Bug 33262: Add deleted_biblionumber column to aqorders table This adds a new column deleted_biblionumber to the aqorders table. This will allow us to store the biblionumber of a deleted record, so we will still be able to tell what has been ordered once the record is deleted. Test plan in last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:17:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:17:38 +0000 Subject: [Koha-bugs] [Bug 33672] Item group features shows when placing holds if EnableItemGroupHolds is disabled In-Reply-To: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33672-70-0PFrcS3MMb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33672 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:17:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:17:40 +0000 Subject: [Koha-bugs] [Bug 33672] Item group features shows when placing holds if EnableItemGroupHolds is disabled In-Reply-To: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33672-70-qxaEHIr9IT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33672 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150648&action=edit Bug 33672: Don't show item group holds on OPAC if not enabled This patch adds a check of the syspref 'EnbaleItemGroupHolds' to the opac request form To test: 1 - Enable 'EnableItemGroups' system preference 2 - On staff client, view a record details 3 - Go to 'Item groups' tab, add a enw group 4 - On holdings tab, select one or more items and add to group 5 - View record in OPAC 6 - PLace a hold 7 - Note group option is visible 8 - Apply patch 9 - Refresh, no group option 10 - Enable 'EnableItemGroupHolds' system preference 11 - Refresh opac page, note group option is visible -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:17:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:17:48 +0000 Subject: [Koha-bugs] [Bug 33672] Item group features shows when placing holds if EnableItemGroupHolds is disabled In-Reply-To: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33672-70-N6bmHoZhoz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33672 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:18:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:18:02 +0000 Subject: [Koha-bugs] [Bug 33672] Item group features shows when placing holds if EnableItemGroupHolds is disabled In-Reply-To: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33672-70-kfV562ehKX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33672 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- I don't recreate on staff, please provide steps if you can -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:20:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:20:53 +0000 Subject: [Koha-bugs] [Bug 33672] Item group features shows when placing holds if EnableItemGroupHolds is disabled In-Reply-To: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33672-70-IGHwsinmrm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33672 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Nick Clemens from comment #2) > I don't recreate on staff, please provide steps if you can Maybe you are right, I was probably in the OPAC yesterday when I stumbled on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:22:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:22:10 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-0tRLbtkGb9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:27:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:27:41 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-oCMznNYgJF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Mona Panchaud from comment #6) > Thanks for taking a look at this and adding a fix! > > Just to be sure and for my understanding: The data that is deleted is not > used by anything else? The new data structure won't allow these to be added, which is why you get the complaint in the update. So it should be safe as this type of data can no longer be generated. > Will this fix get into the 22.11 branch so that we can try the update again > in a straightforward way? The fix is now going through the QA process and when everything is ok the goal will be to also include in the stable branches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:34:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:34:14 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-GSKt4kd3bF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #4) > I feel it's a bug and we should fix it, but still a little confused about > the different values we could use here for sort and what effect they will > have. Can someone explain a little more? 27316 moved the options for setting the field in staff interface from "Undef/Yes/No" to simply "Yes/No" = 0/1 We did not update the mappings file, that should be done here The code continues to support ~/Undef so that we don't break existing setups - we should update the comment Janusz noted to explain that 'UNdef' should be set as '1' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:36:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:36:18 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-h8ASBkj2q7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:36:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:36:20 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-mHJWr0AWjN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150649&action=edit Bug 33594: Update mappings and comment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:38:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:38:31 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-6HJcTD3Z12@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:39:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:39:35 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-gALnLfl5ri@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- This changes a few other fields, but it really is just a dump from the DB, those changes are essentially how the fields are going to be treated anyways, it was generated using: perl misc/search_tools/export_elasticsearch_mappings.pl > admin/searchengine/elasticsearch/mappings.yaml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:45:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:45:30 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28726-70-vMDr8p2vhi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #40 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Michael Hafen from comment #39) Thanks. > 8. use the Add selected patrons button to add the selected patrons to the > card batch's Add by borrowernumber(s) text input field in the main window. This is the confusing part. Since I clicked on that button before selecting the patrons, it is quite strange that you should click it again to kind of confirm the action you did. It is outside the scope of this report, but the operation is not intuitive. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:49:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:49:25 +0000 Subject: [Koha-bugs] [Bug 31493] Circulation.t fails if "RenewalPeriodBase" is set as "the current date" In-Reply-To: <bug-31493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31493-70-KKdhWQEdLl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31493 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Needs Signoff |Failed QA --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Tests are passing for me without the patch, can you have another look please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:50:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:50:04 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28726-70-rGc4MMGn4a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Medium patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:50:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:50:06 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28726-70-p9NpmE35mE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148489|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150650&action=edit Bug 28726: Add sort1 and sort2 to patron card creator - patron search. Also adds a select all / clear all and checkboxes. Test plan: 1. start a new batch in the patron card creator (Tools -> Patron card creator -> New -> card batch) 2. click the Add patron(s) button. Observe that Category and Library are the only options. 3. Close search for patron window. 4. Apply patch. 5. click the Add patron(s) button. Observe that you can now search for patrons by their sort1 and sort2 values. 6. perform a search and observe the 'Select all | Clear all | Add selected patrons' links and button. 7. use the Select all link to select all the patrons found by the search. 8. use the Add selected patrons button to add the selected patrons to the card batch's Add by borrowernumber(s) text input field. 9. close the search for patron window. Signed-off-by: Solene Ngamga <solene.ngamga at inLibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:50:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:50:26 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28726-70-rtXAAjXoBw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:51:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:51:41 +0000 Subject: [Koha-bugs] [Bug 31493] Circulation.t fails if "RenewalPeriodBase" is set as "the current date" In-Reply-To: <bug-31493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31493-70-jAmelnx9bh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31493 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Might have been fixed by bug 31676. *** This bug has been marked as a duplicate of bug 31676 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:51:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:51:41 +0000 Subject: [Koha-bugs] [Bug 31676] Make db_dependent/Circulation.t tests more robust In-Reply-To: <bug-31676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31676-70-oQLypdxrpq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31676 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at koha-suomi.fi --- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- *** Bug 31493 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:53:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:53:36 +0000 Subject: [Koha-bugs] [Bug 32132] Missing budget_period_id in aqbudgets kills lateorders.pl In-Reply-To: <bug-32132-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32132-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32132-70-dQZ4XLSw8y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32132 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- There is the ON DELETE CASCADE clause on this FK so I think the correct fix is to make budget_period_id NOT NULL instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 13:55:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 11:55:56 +0000 Subject: [Koha-bugs] [Bug 32333] IdRef system preference revamping In-Reply-To: <bug-32333-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32333-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32333-70-01FvAy254L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:01:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:01:31 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-PyTPTGBqkk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #33 from Lari Strand <lmstrand at gmail.com> --- (In reply to Lari Strand from comment #32) > These patches seems to break the functionality in barcode generator plugin > barcode.pl. I removed the patches and it started generating barcodes again. This problem has been addressed in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32813 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:03:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:03:38 +0000 Subject: [Koha-bugs] [Bug 30255] Allow skipping "list" step for record batch modification/deletion In-Reply-To: <bug-30255-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30255-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30255-70-A7bZZkqxhb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:08:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:08:38 +0000 Subject: [Koha-bugs] [Bug 32392] Ability to skip forward serial issues when receiving double (or more) issue In-Reply-To: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32392-70-G7RwX4dLNr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:09:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:09:37 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31856-70-ctDOK6zCfo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142058|0 |1 is obsolete| | Attachment #142156|0 |1 is obsolete| | Attachment #142157|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150651&action=edit Bug 31856: Improve performance of serials subscriptions search To test: 1) Perform an advanced search that produces a reasonably large resultset for serial subscriptions (preferably at least a couple of hundred) and take not of the execution time. 2) Apply the patch. 3) Perform the search again, the execution should now be about one fifth of the previous search. 4) Ensure tests in t/db_dependent/AuthorisedValues.t all pass. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:09:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:09:41 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31856-70-ysoC7pFdMU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150652&action=edit Bug 31856: Don't fetch additional field valudes if there are no fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:09:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:09:44 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31856-70-Ts5GNhrIMu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150653&action=edit Bug 31856: Add test for get_description_by_category_and_authorised_value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:09:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:09:54 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31856-70-sNdn0ubo7z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Patches rebased against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:10:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:10:45 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17170-70-CvNx78VdS8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #154 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Thank you Nick! That helps :) I will add that example. I think maybe I misunderstood how to use the filters. Because in the OPAC, you need to do a search to get the filters, so in the test plan when it says to copy the URL, it's the URL for search + filter, not just filter. It gave me something like cgi-bin/koha/opac-search.pl?idx=&q=shakespeare&limit=search_filter:4 Anyway, now I have the URL you gave me, so it's all good. Ill put that in the manual with the new books example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:11:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:11:08 +0000 Subject: [Koha-bugs] [Bug 33358] Do not use editorconfig for vue files In-Reply-To: <bug-33358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33358-70-PHo103Y5ZG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 Paul Derscheid <paul.derscheid at lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148929|0 |1 is obsolete| | --- Comment #3 from Paul Derscheid <paul.derscheid at lmscloud.de> --- Created attachment 150654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150654&action=edit Bug 33358: Do not use .editorconfig for vue files I looked at the docs for editorconfig and I think I found the right syntax to achieve what we want. Correct me, if I'm wrong. To test: 1. Try this pattern on every filetype we use. 2. Assert it respects the rules. 3. Sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:13:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:13:08 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31856-70-OB06YbXdXj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Is the change in SearchSubscriptions really makes things faster? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:15:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:15:22 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17170-70-G1ALYGBdD0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #155 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Caroline Cyr La Rose from comment #154) > Thank you Nick! That helps :) I will add that example. > > I think maybe I misunderstood how to use the filters. Because in the OPAC, > you need to do a search to get the filters, so in the test plan when it says > to copy the URL, it's the URL for search + filter, not just filter. It gave > me something like > cgi-bin/koha/opac-search.pl?idx=&q=shakespeare&limit=search_filter:4 > > Anyway, now I have the URL you gave me, so it's all good. Ill put that in > the manual with the new books example. Yeah, it would be nice to provide the staff/opac link to the filter with no extra query in the filters list - you can file that and I'll try to get to it sometime -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:17:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:17:05 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31856-70-rOa3V7ZSFV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 --- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #11) > Is the change in SearchSubscriptions really makes things faster? Right, there is no FK. Maybe we are just missing an index on a DB column then? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:17:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:17:10 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-naAhM7C1tO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |kyle at bywatersolutions.com --- Comment #56 from Kyle M Hall <kyle at bywatersolutions.com> --- I've reviewed Martin's rebase and it's looking good! I've reset the status to assigned so Martin can change it back to NSO when the patch set is ready! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:24:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:24:39 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-bq1iKTFYQV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #34 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Lari Strand from comment #33) > (In reply to Lari Strand from comment #32) > > These patches seems to break the functionality in barcode generator plugin > > barcode.pl. I removed the patches and it started generating barcodes again. > > This problem has been addressed in > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32813 Do not try to test this patch without all the other patches applied. They are marked as dependencies for a good reason ;) (and the status is "BLOCKED" for this reason as well) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:28:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:28:23 +0000 Subject: [Koha-bugs] [Bug 33358] Do not use editorconfig for vue files In-Reply-To: <bug-33358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33358-70-MFRnf0tbvr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This patch does not work for me, using vscodium. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:36:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:36:32 +0000 Subject: [Koha-bugs] [Bug 33610] Accelerated Reading Level Search not accurate In-Reply-To: <bug-33610-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33610-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33610-70-CNNWmccWa9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33610 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- We use the elasticsearch query string query, you want to do a range search: https://www.elastic.co/guide/en/elasticsearch/reference/7.17/query-dsl-query-string-query.html#_ranges Try: arl:[6 TO 7} That should get you 6 and above up to, but excluding 7 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:38:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:38:24 +0000 Subject: [Koha-bugs] [Bug 33677] New: Remove --verbose from koha-worker manpage Message-ID: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677 Bug ID: 33677 Summary: Remove --verbose from koha-worker manpage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz koha-worker does not have a --verbose option, but the "man page" says it does. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:43:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:43:29 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-ZaOCNCaCgj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15494 CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I don't think the removal here is correct, the method does more than C4::Context->yaml_preference Nick maybe? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 [Bug 15494] Block renewals by arbitrary item values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:43:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:43:29 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: <bug-15494-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15494-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15494-70-72d0CPoYSt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:52:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:52:29 +0000 Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm In-Reply-To: <bug-32496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32496-70-ohwNOHsKR4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:53:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:53:46 +0000 Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm In-Reply-To: <bug-32496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32496-70-VMRNLJbVV8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 --- Comment #20 from David Gustafsson <glasklas at gmail.com> --- Tests seems to pass, so again ready for signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:54:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:54:08 +0000 Subject: [Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods In-Reply-To: <bug-32476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32476-70-4IdqDEe8yU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #22 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Did you identify where they (is_expired and has_overdues) would be called extensively? Did you benchmark your patches? I can easily imagine a scenario where it would bring hard to detect side-effects: * check if a patron can check an item out => yes, cache "yes" * check the item out * check if the patron can check an other item out => Get "yes" from cache -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:54:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:54:46 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-0nu3Z7Cige@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #2) > I don't think the removal here is correct, the method does more than > C4::Context->yaml_preference > > Nick maybe? perl -e 'use Koha::Config::SysPrefs; use C4::Context; my $sp = Koha::Config::SysPrefs->find("ItemsDeniedRenewal")->get_yaml_pref_hash; warn Data::Dumper::Dumper($sp); warn Data::Dumper::Dumper( C4::Context->yaml_preference("ItemsDeniedRenewal"));' It doesn't convert from 'NULL' to undef - the expectation is that we can pass the return value into a DBIC search directly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:56:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:56:42 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-lGktJQVczh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Depends on| |30920 Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Please rebase on top of bug 30920 (that is pushed to master already). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30920 [Bug 30920] Add caching to C4::Biblio::GetAuthorisedValueDesc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:56:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:56:42 +0000 Subject: [Koha-bugs] [Bug 30920] Add caching to C4::Biblio::GetAuthorisedValueDesc In-Reply-To: <bug-30920-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30920-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30920-70-eTlz0FqrzR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30920 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32060 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 [Bug 32060] Improve performance of Koha::Item->columns_to_str -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:56:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:56:59 +0000 Subject: [Koha-bugs] [Bug 31124] koha-remove fails to remove long_tasks queue daemon, so koha-create for same <instance> user fails In-Reply-To: <bug-31124-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31124-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31124-70-8mpr0qBDk2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31124 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #1 from Magnus Enger <magnus at libriotech.no> --- (In reply to wajasu from comment #0) > 2) > koha-worker needs: > the --queue option should be added to the --help / POD > > Also, koha-worker --help should at least show: > Usage: > koha-worker [--start|--stop|--restart] [--quiet|-q] [--queue <queuename>] > instancename1 [instancename2...] > and also: > --queue <queuename> Specify a queue name I think this was added to the script itself here: https://git.koha-community.org/Koha-community/Koha/commit/486d78f544f1fe074d4f474206155c4bcb02ea2a And to the "man" page here: https://git.koha-community.org/Koha-community/Koha/commit/f1fef6527c778977bd0d48e2cb42b5c9dc153a8f The problem with the long_tasks still running after koha-remove remains, at least for 22.05.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 14:58:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 12:58:51 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-ymDqMDTdE6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Nick Clemens from comment #3) > (In reply to Jonathan Druart from comment #2) > > I don't think the removal here is correct, the method does more than > > C4::Context->yaml_preference > > > > Nick maybe? > > perl -e 'use Koha::Config::SysPrefs; use C4::Context; my $sp = > Koha::Config::SysPrefs->find("ItemsDeniedRenewal")->get_yaml_pref_hash; warn > Data::Dumper::Dumper($sp); warn Data::Dumper::Dumper( > C4::Context->yaml_preference("ItemsDeniedRenewal"));' > > It doesn't convert from 'NULL' to undef - the expectation is that we can > pass the return value into a DBIC search directly Perhaps we removed the wrong copy here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27154 One was an object, the other took a pref name, so would have used cache -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:05:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:05:33 +0000 Subject: [Koha-bugs] [Bug 2894] Routing list holds are broken In-Reply-To: <bug-2894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-2894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2894-70-iOiyJOTtCX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2894 --- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Now that there are patches here and on the other linked bugs, can I get feedback on them please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:11:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:11:02 +0000 Subject: [Koha-bugs] [Bug 22375] Due dates should be formatted consistently In-Reply-To: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22375-70-zrTYANWV7h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:11:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:11:05 +0000 Subject: [Koha-bugs] [Bug 22375] Due dates should be formatted consistently In-Reply-To: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22375-70-vtoBtAJ3fl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149722|0 |1 is obsolete| | Attachment #149723|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150655&action=edit Bug 22375: Format due date consistantly Test plan: Make some daily an hourly checkouts and confirm the right display (hourly with hours and minutes, daily only date) of due date on these places: 1) catalogue -> checkout history 2) circulation -> overdues with fines 3) <already fixed> 4) circulation -> pending on site checkouts 5) patrons circulation history 6) opac -> account summary -> relatives checkouts Note: I suspect the moremember-receipt.tt template is not used anymore Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:11:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:11:08 +0000 Subject: [Koha-bugs] [Bug 22375] Due dates should be formatted consistently In-Reply-To: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22375-70-kNZNiuzlzY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150656&action=edit Bug 22375: (follow-up) Format even more due dates consistently To test: Create some checkouts in future and past, make sure to include some with a time != 23:59.CirculateILL Verify that the due date is displayed correctly on: * Catalog detail page > Items tab > Checkout status * Circulation start page > Renew > Renew one of your checkouts > dialog message * ILL request page: requires ILL setup and CirculateILL system preference * Patron acccount in staff > Print > Print summary * Catalog detail page > Holds > search for patron > due date on checked out items * Recalls: * Activate UseRecalls system preference, set up circulation rules to allow recalls * Checkout an item to another user * In the OPAC, place a recall on that record with yor use * Check "Recall a specific item" * Verify due date in item list * Place recall on checked out item * Patron account in OPAC > Recalls history (due date might have been changed through recall) * OPAC patron account > Summary > Overdue tab * Self checkout: * Activate WebBasedSelfCheck * Go to <opacbaseurl>/cgi-bin/koha/sco/sco-main.pl * Log in > Tab checkouts Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> JD amended patch - removed 'fda' Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:11:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:11:50 +0000 Subject: [Koha-bugs] [Bug 22375] Due dates should be formatted consistently In-Reply-To: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22375-70-bFegc64fRS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|Signed Off |Passed QA CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:12:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:12:14 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-ZeRXPZc2kC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:12:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:12:16 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-WWaoFEcJCZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150647|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150657&action=edit Bug 33262: Add deleted_biblionumber column to aqorders table This adds a new column deleted_biblionumber to the aqorders table. This will allow us to store the biblionumber of a deleted record, so we will still be able to tell what has been ordered once the record is deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:12:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:12:19 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-hL4ez2NYuU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150658&action=edit Bug 33262: [DO NOT PUSH] Schema update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:12:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:12:21 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-sQoIOEa2fS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150659&action=edit Bug 33262: Store the biblionumber of a deleted record in the order line When a bibliographic record is deleted and linked to an order in the acquisition module, the biblionumber in the order line is currently deleted as well. This makes it impossible to tell what was ordered in the first place. This is a big issue for libraries that need to be able to track how money was spent over long periods of time. With this patch the biblionumber of the deleted record will be moved to a new column deleted_biblionumber in the order line, keeping the FK on biblionumber. To test: * Apply patch, run dataase update * Create a order/basket in the acquisitions module * Order several things, you can use existing records from the sample data * Make sure you order one of the records at least twice * Take a look at the aqorders table in your database, using a report: SELECT biblionumber, deleted_biblionumber, ordernumber from aqorders; * From the catalog, delete the items on the records and then the records Note: There is a warning about attached orders warning about consequences for acquisitions. I have chosen to keep it at this point in time, as there are still visible side effects of deleting the record, like bug 10758. * Re-run the report and compare results to the first run. deleted_biblionumber should now be filled with the biblionumber of the deleted record. biblionumber should be NULL/empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:12:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:12:24 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-dBj0wchpoN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150660&action=edit Bug 33262: Unit tests prove t/db_dependent/Biblio.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:12:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:12:50 +0000 Subject: [Koha-bugs] [Bug 33678] New: Saving new numbering pattern crashes on missing description Message-ID: <bug-33678-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33678 Bug ID: 33678 Summary: Saving new numbering pattern crashes on missing description Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Save as new pattern generates a 500 when I change advanced pattern and save GET https://SERVER/cgi-bin/koha/serials/create-numberpattern.pl?patternname=vol_no_week&numberingmethod=Vol. {X}, No. {Y}&label1=Volume&label2=Number&add1=1&add2=1&every1=12&every2=1&setto1=1&setto2=1&whenmorethan1=99999&whenmorethan2=52 [HTTP/1.1 500 Internal Server Error 64ms] C4::Serials::Numberpattern::AddSubscriptionNumberpattern(): DBI Exception: DBD::mysql::st execute failed: Field 'description' doesn't have a default value at /usr/share/koha/serials/create-numberpattern.pl line 58 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 DBIx::Class::Exception::throw('DBIx::Class::Exception', 'DBI Exception: DBD::mysql::st execute failed: Field \'description\' doesn\'t have a default value', 0) called at /usr/share/perl5/DBIx/Class/Schema.pm line 1118 Keywords for searching: ​saveAdvancedPattern #saveadvancedpatternbutton Reproduce by changing number pattern of saved subscription and trying to Save the new numbering pattern. This is an ajax call. You see 500 in the console. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:13:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:13:30 +0000 Subject: [Koha-bugs] [Bug 32392] Ability to skip forward serial issues when receiving double (or more) issue In-Reply-To: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32392-70-GJwCmTAFL4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33678 --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- While testing, stumbled over byg 33678 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:13:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:13:30 +0000 Subject: [Koha-bugs] [Bug 33678] Saving new numbering pattern crashes on missing description In-Reply-To: <bug-33678-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33678-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33678-70-5OU1YTTaXs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33678 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32392 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:14:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:14:18 +0000 Subject: [Koha-bugs] [Bug 33679] New: Buttons Select all and Clear all do not work on serial collection Message-ID: <bug-33679-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33679 Bug ID: 33679 Summary: Buttons Select all and Clear all do not work on serial collection Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:14:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:14:51 +0000 Subject: [Koha-bugs] [Bug 32392] Ability to skip forward serial issues when receiving double (or more) issue In-Reply-To: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32392-70-0MusJxQABj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33679 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- And bug 33679 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:14:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:14:51 +0000 Subject: [Koha-bugs] [Bug 33679] Buttons Select all and Clear all do not work on serial collection In-Reply-To: <bug-33679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33679-70-SSRSkx8Exa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33679 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32392 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:19:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:19:58 +0000 Subject: [Koha-bugs] [Bug 29507] Speed up auto renew cronjob via parallel processing In-Reply-To: <bug-29507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29507-70-nF0SDFT6Hd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29507 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart+koha at gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Does not apply. I am wondering how this can work with the digest option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:22:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:22:30 +0000 Subject: [Koha-bugs] [Bug 33013] Add age, interface and operator as additional report stats In-Reply-To: <bug-33013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33013-70-fM2G05yEM3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33013 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I don't understand the "operator", can you detail please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:25:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:25:15 +0000 Subject: [Koha-bugs] [Bug 32767] Trimming of attribute types by wish (if enabled) In-Reply-To: <bug-32767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32767-70-F9eXlcZooS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32767 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Please provide tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:26:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:26:07 +0000 Subject: [Koha-bugs] [Bug 32795] ILLHiddenRequestStatuses system preference description is wrong In-Reply-To: <bug-32795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32795-70-7RZ7ZEcTHj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32795 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #4 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Closing this as the problem described has been fixed by bug 28641 and 32799 and both have been pushed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:28:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:28:56 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-L07PTfZj0U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150657|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150661&action=edit Bug 33262: Add deleted_biblionumber column to aqorders table This adds a new column deleted_biblionumber to the aqorders table. This will allow us to store the biblionumber of a deleted record, so we will still be able to tell what has been ordered once the record is deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:28:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:28:59 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-KscWHZUmJ6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150662&action=edit Bug 33262: [DO NOT PUSH) Schema update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:29:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:29:02 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-ffyIaM2s4N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150659|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150663&action=edit Bug 33262: Store the biblionumber of a deleted record in the order line When a bibliographic record is deleted and linked to an order in the acquisition module, the biblionumber in the order line is currently deleted as well. This makes it impossible to tell what was ordered in the first place. This is a big issue for libraries that need to be able to track how money was spent over long periods of time. With this patch the biblionumber of the deleted record will be moved to a new column deleted_biblionumber in the order line, keeping the FK on biblionumber. To test: * Apply patch, run dataase update * Create a order/basket in the acquisitions module * Order several things, you can use existing records from the sample data * Make sure you order one of the records at least twice * Take a look at the aqorders table in your database, using a report: SELECT biblionumber, deleted_biblionumber, ordernumber from aqorders; * From the catalog, delete the items on the records and then the records Note: There is a warning about attached orders warning about consequences for acquisitions. I have chosen to keep it at this point in time, as there are still visible side effects of deleting the record, like bug 10758. * Re-run the report and compare results to the first run. deleted_biblionumber should now be filled with the biblionumber of the deleted record. biblionumber should be NULL/empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:29:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:29:04 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-spx05cfeKX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150660|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150664&action=edit Bug 33262: Unit tests prove t/db_dependent/Biblio.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:32:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:32:31 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-9blRNCUrls@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150658|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:34:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:34:12 +0000 Subject: [Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold In-Reply-To: <bug-33302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33302-70-OS8SyDh734@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:34:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:34:21 +0000 Subject: [Koha-bugs] [Bug 32392] Ability to skip forward serial issues when receiving double (or more) issue In-Reply-To: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32392-70-VWbYrnOM8X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Do not understand why we add this to serial-EDIT here ? + $("form").on("submit", function(){ + let issues = $('input[name="skip_issues"]').val() ? $('input[name="skip_issues"]').val() : ''; + let too_many = _("Choose a value between 0-10 in issues to skip!"); + let no_number = _("Not a number in skip issues!"); + + if ( issues == '' || ( issues.match(/^\d+$/) && issues <= 10 ) ) { + return true; + } + else if ( issues.match(/^\d+$/) && issues > 10 ) { + alert(too_many); + return false; + } else if ( !issues.match(/^\d+$/) ) { + alert(no_number); + return false; + } + else { + return false; + } + }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:34:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:34:36 +0000 Subject: [Koha-bugs] [Bug 32392] Ability to skip forward serial issues when receiving double (or more) issue In-Reply-To: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32392-70-taVby3HF1d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- And why do we cap at 10 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:35:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:35:08 +0000 Subject: [Koha-bugs] [Bug 32392] Ability to skip forward serial issues when receiving double (or more) issue In-Reply-To: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32392-70-IdrRkbZ5w1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #8) > And why do we cap at 10 ? And why dont we cap on serial-collection then ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:36:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:36:14 +0000 Subject: [Koha-bugs] [Bug 32392] Ability to skip forward serial issues when receiving double (or more) issue In-Reply-To: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32392-70-OqKerI6Hp5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- serials/serials-collection.pl my $count_forward = int $skip_issues + 1; serials/serials-edit.pl +my $count_forward = $skip_issues + 1; Inconsistent. Remove int ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:36:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:36:51 +0000 Subject: [Koha-bugs] [Bug 32392] Ability to skip forward serial issues when receiving double (or more) issue In-Reply-To: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32392-70-tuGA6rN30A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Both Perl and JS allow you to write this shorter with a = b || c. Note that Perl also has a // b but this checks on defined instead of true. + my $count = $count_forward ? $count_forward : 1; + let issues = $('input[name="skip_issues"]').val() ? $('input[name="skip_issues"]').val() : ''; No blocker but less typing and errors doing so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:37:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:37:04 +0000 Subject: [Koha-bugs] [Bug 32392] Ability to skip forward serial issues when receiving double (or more) issue In-Reply-To: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32392-70-32pRrbKyxm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- koha-tmpl/intranet-tmpl/prog/en/includes/modals/serials_skip_issues.inc TYPO serils-edit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:38:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:38:21 +0000 Subject: [Koha-bugs] [Bug 32392] Ability to skip forward serial issues when receiving double (or more) issue In-Reply-To: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32392-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32392-70-RLF3l0opSu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Just raising questions here. But I spent some time here and am not confident that this change is without bugs. The whole context of Serials is quite buggy, I am afraid. Opened two new reports too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:40:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:40:55 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-jcwxgJiZid@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Applying: Bug 32911: (follow-up) Move pref from Notifications to Features section error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/interlibrary_loans.pref). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:43:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:43:51 +0000 Subject: [Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way In-Reply-To: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24480-70-onuIBeCFs9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:43:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:43:53 +0000 Subject: [Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way In-Reply-To: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24480-70-i8Lb0Sk65z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98975|0 |1 is obsolete| | Attachment #98976|0 |1 is obsolete| | Attachment #106621|0 |1 is obsolete| | --- Comment #24 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150665&action=edit Bug 24480: Fix insert_fields_ordered instead of append_fields in SimpleMARC Test plan : - create a marc modification template which add a new field to a record - apply that template to some records - verify that the new field is always appended at the bottom of the record, even if some fields are higher. - apply patch - apply template to another set of records - verify the added field is now ordered within the already existing fields in the records Signed-off-by: Kelly <kelly at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:43:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:43:55 +0000 Subject: [Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way In-Reply-To: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24480-70-SH29Qtwk1P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480 --- Comment #25 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150666&action=edit Bug 24480: Unit test This updates the SimpleMARC tests and MarcModificationTemplates tests to expect the new order of fields Signed-off-by: Kelly <kelly at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:45:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:45:20 +0000 Subject: [Koha-bugs] [Bug 33680] New: Provide ready-made link to search filters Message-ID: <bug-33680-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33680 Bug ID: 33680 Summary: Provide ready-made link to search filters Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 17170 introduced search filters. There is an option to use search filter links in news or html customizations or elsewhere, but the links are not readily available. To recreate: 1. Enable SavedSearchFilters 2. Go to advanced search and search for anything 3. Click 'Save as search filter' 4. Check 'Show in OPAC' and 'Show in staff interface' 5. Name the filter 6. Click 'Save' 7. Go to Administration > Search filters It would be nice here to have the links to the filters, where it says "true". I was thinking something like in the Upload tool, there is a "Yes" link under "Public" with a chain-link icon, which when clicked opens the link to the thing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:45:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:45:31 +0000 Subject: [Koha-bugs] [Bug 33680] Provide ready-made link to search filters In-Reply-To: <bug-33680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33680-70-QSikb32Esj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33680 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17170 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:45:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:45:31 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17170-70-NLl66fyk1N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33680 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33680 [Bug 33680] Provide ready-made link to search filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:46:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:46:37 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-9TbvcJQRCN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 --- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- "Deleted bibliographic record, can't find title" should not we adjust that then? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:48:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:48:03 +0000 Subject: [Koha-bugs] [Bug 33681] New: Omnibus: Allow SIP2 users to be created through the Koha staff interface Message-ID: <bug-33681-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33681 Bug ID: 33681 Summary: Omnibus: Allow SIP2 users to be created through the Koha staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org Let's fix this - libraries ought to be able to create their own SIP users (even the part we currently manage with XML) through the Koha UI. Initial requirements: Create a user that without any touching of server side configuration files can allow a SIP login for the most basic usage of SIP. Allow those users to be configurable with all of the configuration options available through SIPConfig.xml as documented in SIPConfig.xml https://github.com/Koha-Community/Koha/blob/master/etc/SIPconfig.xml -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:51:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:51:21 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: <bug-12802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12802-70-YlP9YGMtpB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:51:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:51:37 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: <bug-12802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12802-70-tkO1wE9bZ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #106 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- AutoEmailPrimaryAddress has been renamed :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:53:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:53:19 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-VNJ5GQhh3Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #78 from Kyle M Hall <kyle at bywatersolutions.com> --- After applying the patches and running reset_all in ktd, I get the following error when I try to log in: Data::Session::Driver::mysql::store(): DBI Exception: DBD::mysql::db do failed: Data too long for column 'id' at row 1 at /kohadevbox/koha/lib/Data/Session.pm line 262 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 15:58:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 13:58:11 +0000 Subject: [Koha-bugs] [Bug 31650] We should publish our coding guidelines more openly In-Reply-To: <bug-31650-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31650-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31650-70-ILUiwYGMdH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31650 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #2 from Liz Rea <wizzyrea at gmail.com> --- Why don't we put this in the website somewhere? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:00:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:00:43 +0000 Subject: [Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold In-Reply-To: <bug-33302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33302-70-mmf3hq1FF8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:00:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:00:46 +0000 Subject: [Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold In-Reply-To: <bug-33302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33302-70-birhYtKQgw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149123|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150667&action=edit Bug 33302: Send and display errors when a hold cannot be placed on the OPAC This patch changes opac-reserve.pl to return the error(s) when placing a hold as a pipe delimited list which is then translated to a message for the user To test: 1 - Find a record with items available on the opac 2 - Click 'place hold' and set things up, but do not confirm 3 - In staff client, do something to make hold invalid: - Make item damaged - Make library not a pickup location - Place other holds for patron up to limit - etc. 4 - Confirm hold on OPAC 5 - You are sent to patron's account, hold is not placed 6 - There is little or no message to explain why 7 - Apply patch 8 - Repeat 9 - Now errors are clear Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:00:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:00:48 +0000 Subject: [Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold In-Reply-To: <bug-33302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33302-70-rEma3z34rG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150668&action=edit Bug 33302: (QA follow-up) Rephrase errors to be more user friendly These error message will show within the patron account. The goal of this patch is to make them a little more user friendly avoiding 'patron' and 'hold group' terminology :) Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:01:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:01:26 +0000 Subject: [Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold In-Reply-To: <bug-33302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33302-70-LE1CLKY1fo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I tried to make the error messages a little more user friendly - please feel free to drop the patch if you don't like it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:02:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:02:19 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-Octe1Wbdhc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:04:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:04:18 +0000 Subject: [Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons In-Reply-To: <bug-32986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32986-70-Skhnctq6H4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Not sure whats going on, but clicking these Print buttons or options does actually do totally nothing.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:08:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:08:20 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-qNixeRXLFd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #14) > "Deleted bibliographic record, can't find title" should not we adjust that > then? This would be the next step, but I wanted to keep things small and manageable. this is taking care of the data only, but there are already bug 10758 and bug 10869 filed and linked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:21:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:21:11 +0000 Subject: [Koha-bugs] [Bug 33679] Buttons Select all and Clear all do not work on serial collection In-Reply-To: <bug-33679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33679-70-sapmDTxSXy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33679 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Marcel, I had already reported that one, the fix is on bug 33590. *** This bug has been marked as a duplicate of bug 33590 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:21:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:21:11 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-Gg9k7FrDC1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 33679 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:23:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:23:34 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-D3NlohrIz8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:23:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:23:36 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-75liR0hilO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150624|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150669&action=edit Bug 33653: Never consider received orders as late We should not list received orders on the late orders page. Test plan: * Create a basket * Create a normal order (not from a subscription, no standing order) * Leave estimated delivery date empty * Close the basket * Create a new invoice and receive the order line * Go to acq > late orders * Verify the order is not in the list * Set filter for 'To' date into the future, i.e. 01/01/2025 => Without this patch the order shows up => With this patch applied the received order does not show up Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:24:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:24:42 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-WwvK4hzv4L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I'll try to fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:27:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:27:27 +0000 Subject: [Koha-bugs] [Bug 33681] Omnibus: Allow SIP2 users to be created through the Koha staff interface In-Reply-To: <bug-33681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33681-70-NlyYDHDCO5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33681 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think one issue here could be all the extra configuration options we have tied to the SIP logins. Maybe we'd need some kind of default entry in the .xml to make sure we can still connect the config to the user? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:34:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:34:27 +0000 Subject: [Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons In-Reply-To: <bug-32986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32986-70-s1cvlE08Qk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 --- Comment #13 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #12) > Not sure whats going on, but clicking these Print buttons or options does > actually do totally nothing.. All working for me, ensure you hard refresh the browser so that the JS reloads - I saw your issue before I did that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:41:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:41:11 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29453-70-cifEuzAEI8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:41:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:41:15 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29453-70-zN3P0qyVos@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147644|0 |1 is obsolete| | --- Comment #16 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 150670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150670&action=edit Bug 29453: Add endpoints for fetching patron credits & debits This patch adds two new API endpoints for fetching a patrons credits and a patrons debits. Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Agustin Moyano <agustinmoyano at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:41:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:41:18 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29453-70-FtoM7Wvcwt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 --- Comment #17 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 150671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150671&action=edit Bug 29453: (follow-up) Add tests and fix minimum amount in credit.yaml definition -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:49:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:49:57 +0000 Subject: [Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way In-Reply-To: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24480-70-cFvR8kbS3R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480 --- Comment #26 from Phil Ringnalda <phil at chetcolibrary.org> --- Why use insert_grouped_field for move rather than insert_fields_ordered? My vague memory of looking at it in 2020 says that it's because just using $record->insert_fields_ordered( @new_fields ); winds up putting them in reversed, so that if you say to move all 502 to 520 you go from 502 $aFirst 502 $aSecond to 520 $aSecond 520 $aFirst but if that was all it was, why not just reverse @new_fields before calling insert_fields_ordered? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:54:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:54:56 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-FawSk2n8EY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:54:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:54:59 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-An2fpcYRwJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147417|0 |1 is obsolete| | Attachment #147418|0 |1 is obsolete| | Attachment #147419|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150672&action=edit Bug 32911: Remove ILL partner_code config from koha-conf.xml and turn it into a system preference Preparation: 1) apply patch 2) run reset_all 3) enable ILLModule sys preference 4) install a backend (e.g. FreeForm) 5) go into system preferences and confirm that ILLPartnerCode exists and is the default inter-library loan (IL) Test plan: 1) create an ILL request 2) ensure the patron of category 'IL' has a primary e-mail configured 3) click on "place request with partners" 4) verify that the patron(s) of said category are on the partners list Upgrade test: 1) Remove the system preference from the database, run query: delete from systempreferences where variable="ILLPartnerCode"; 2) Check or edit the value or partner_code in koha-conf.xml and run atomicupdate: installer/data/mysql/updatedatabase.pl 3) Confirm the value in koha-conf.xml has been successfully migrated into the system preference, run query: select * from systempreferences where variable="ILLPartnerCode"; Optional tests: - Set a patron category in the sys pref and then delete said patron category (needs to not have patrons in it) - Check the about page -> System information and confirm the warning message is correct - Set the sys pref to the empty option - Check the about page -> System information and confirm the warning message is correct - Set the sys pref to a category that has no patrons of its type (ktd examples: Board, or Library) - Check the about page -> System information and confirm the warning message is correct Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:55:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:55:01 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-a7erOyuRyY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150673&action=edit Bug 32911: Database update Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:55:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:55:04 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-iIB8PSJuly@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150674&action=edit Bug 32911: (follow-up) Move pref from Notifications to Features section The new preference appeared under Notifications, but is better suited for the Features section on the ILL tab in system preferences. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:55:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:55:45 +0000 Subject: [Koha-bugs] [Bug 32333] IdRef system preference revamping In-Reply-To: <bug-32333-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32333-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32333-70-rQNFCEPegI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Frédéric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 16:55:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 14:55:48 +0000 Subject: [Koha-bugs] [Bug 32333] IdRef system preference revamping In-Reply-To: <bug-32333-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32333-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32333-70-FKmrZruyjl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Frédéric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147762|0 |1 is obsolete| | --- Comment #13 from Frédéric Demians <frederic at tamil.fr> --- Created attachment 150675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150675&action=edit Bug 32333: IdRef system preference revamping IdRef system preference enables a Unimarc-only functionality. Authors fields contain in $3 subfield a PPN, an unique identifier in IdRef a French national authority file, similar to VIAF. KohaLa, the Koha French users association, has designed a revamped implementation of IdRef in Koha. The goal is to improve the visual and to add a functionality. - Visually — The author publications list is currently displayed in an old fashion dialog box. It uses greybox library, which is deprecated. See bug 8290. With this patch, the list is displayed in a distinct tab of holdings block. - Functionality — The title in the list are searched in Koha local catalog. So it's possible to mark titles locally available and link to them. PPN are searched directly in Elasticsearch for efficiency. Koha IdRef users are academic libraries or higher education school. So Zebra support is not required for them. NOTE: After pushing this patch, greybox library could be removed completely for OPAC : /koha-tmpl/opac-tmpl/bootstrap/lib/greybox/ TO TEST : - On a Unimarc Koha, with a Sudoc compliant Catalog, enable IdRef. - Use default OPAC XSL. - On opac-detail.pl page, you can see a logo IdRef next to authors having a $3 (ppn) subfield. Click on the logo. - Confirm that a tab is added to holdings. It contains the author publications found in the Sudoc. - A Sudoc logo is displayed in front of each title. Clicking the icon open the title in Sudoc web site. - A Koha logo is displayed in from of each title available locally. Clicking the logo open the title in Koha OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:01:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 15:01:36 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31735-70-p2fyUMSzRw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150611|0 |1 is obsolete| | Attachment #150612|0 |1 is obsolete| | Attachment #150613|0 |1 is obsolete| | --- Comment #78 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150676&action=edit Bug 31735: Avoid re-fetcing objects from database by passing them directly instead of ids to various subroutines To test: 1) Run the following test and make sure all pass: t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/api/v1/return_claims.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/transferbook.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/HoldsQueue.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/Illrequests.t t/db_dependent/ILSDI_Services.t t/db_dependent/Items.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Acquisition/Order.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Holds.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/Reserves.t t/db_dependent/rollingloans.t t/db_dependent/selenium/regressions.t t/db_dependent/SIP/ILS.t t/db_dependent/Holds.t t/db_dependent/Holds/LocalHoldsPriority.t t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Holds/HoldItemtypeLimit.t t/db_dependent/Circulation/transferbook.t 2) Performe one or more checkouts for a patron, making sure that the circulation rules allows for renewals (for example by setting an earlier due-date). 3) Log in as this patron in OPAC and make sure the list of checkouts is displayed correctly, and that renewing an issue still works. Sponsored-by: Gothenburg University Library Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:01:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 15:01:44 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31735-70-T1iCJ495RA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 --- Comment #79 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150677&action=edit Bug 31735: Optimize OPAC checkouts view Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:01:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 15:01:46 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31735-70-Fi3eww9kt0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 --- Comment #80 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150678&action=edit Bug 31735: Fix array that should be passed as reference Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:01:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 15:01:58 +0000 Subject: [Koha-bugs] [Bug 19249] Date picker broken in "Quick add new patron" form In-Reply-To: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19249-70-ED3EVFSK82@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 nicolas.giraud at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150644|0 |1 is obsolete| | --- Comment #15 from nicolas.giraud at inlibro.com --- Created attachment 150679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150679&action=edit Bug 19249: Fix date inputs on patron quick add form This patch create a "apply_flatpickr" JS function to make the code reusable from the template, where we loop over the date inputs to reinstantiate flatpickr. Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Nicolas Giraud <nicolas.giraud at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:09:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 15:09:24 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-2AI42pUq1y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150661|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150680&action=edit Bug 33262: Add deleted_biblionumber column to aqorders table This adds a new column deleted_biblionumber to the aqorders table. This will allow us to store the biblionumber of a deleted record, so we will still be able to tell what has been ordered once the record is deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:09:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 15:09:27 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-14wwkCDXbm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150662|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150681&action=edit Bug 33262: [DO NOT PUSH) Schema update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:09:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 15:09:29 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-oApG0Py87U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150663|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150682&action=edit Bug 33262: Store the biblionumber of a deleted record in the order line When a bibliographic record is deleted and linked to an order in the acquisition module, the biblionumber in the order line is currently deleted as well. This makes it impossible to tell what was ordered in the first place. This is a big issue for libraries that need to be able to track how money was spent over long periods of time. With this patch the biblionumber of the deleted record will be moved to a new column deleted_biblionumber in the order line, keeping the FK on biblionumber. To test: * Apply patch, run dataase update * Create a order/basket in the acquisitions module * Order several things, you can use existing records from the sample data * Make sure you order one of the records at least twice * Take a look at the aqorders table in your database, using a report: SELECT biblionumber, deleted_biblionumber, ordernumber from aqorders; * From the catalog, delete the items on the records and then the records Note: There is a warning about attached orders warning about consequences for acquisitions. I have chosen to keep it at this point in time, as there are still visible side effects of deleting the record, like bug 10758. * Re-run the report and compare results to the first run. deleted_biblionumber should now be filled with the biblionumber of the deleted record. biblionumber should be NULL/empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:09:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 15:09:32 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-m33YfFIRcb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150664|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150683&action=edit Bug 33262: Unit tests prove t/db_dependent/Biblio.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:09:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 15:09:35 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-sZ3ZF3znMJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150684&action=edit Bug 33262: Add new field to REST API route for orders Without this patch the API driven list of pending orders on the order receive page was broken. With the patch, all should be well now. prove -v t/db_dependent/api/v1/acquisitions_orders.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:19:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 15:19:20 +0000 Subject: [Koha-bugs] [Bug 33681] Omnibus: Allow SIP2 users to be created through the Koha staff interface In-Reply-To: <bug-33681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33681-70-KgNpPjIBTj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33681 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #1) > I think one issue here could be all the extra configuration options we have > tied to the SIP logins. > > Maybe we'd need some kind of default entry in the .xml to make sure we can > still connect the config to the user? I'm certain we can build a UI editor that can handle all those SIP options. I think the two blocks of the xml file that should be moved to the database/ui are the accounts ( https://github.com/Koha-Community/Koha/blob/edbc81199798aa084365a1845188aa24e6ad010b/etc/SIPconfig.xml#L55 ) and the institutions ( https://github.com/Koha-Community/Koha/blob/edbc81199798aa084365a1845188aa24e6ad010b/etc/SIPconfig.xml#L105 ). One thing to consider is you can currently set institution codes to non-branchcodes, but this makes things explode. We should probably start with a something to codify that SIP institutions *must* be branchcodes now, then it would be trivial to move that part to the database/UI. We have another thought that perhaps would should get rid of accounts/login/institution as the SIP patron's branchcode is functionally equivalent. That's not necessary but could be a good followup. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:27:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 15:27:39 +0000 Subject: [Koha-bugs] [Bug 33681] Omnibus: Allow SIP2 users to be created through the Koha staff interface In-Reply-To: <bug-33681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33681-70-N1rluUEMvO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33681 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Do we need to keep the option to configure in the file for backwards compatibility? I am not sure if it would be possible to migrate. I like the idea of a configuration page. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:53:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 15:53:36 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-O5ICKYGmhv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 --- Comment #5 from David Gustafsson <glasklas at gmail.com> --- Created attachment 150685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150685&action=edit Bug 32478: Fix handling of undef values in ItemsDeniedRenewal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 17:54:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 15:54:31 +0000 Subject: [Koha-bugs] [Bug 11436] Default values in subfields are not passed on when cloning the field In-Reply-To: <bug-11436-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11436-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11436-70-NpQtdAU7q7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11436 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:00:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 16:00:11 +0000 Subject: [Koha-bugs] [Bug 33669] Adding options to ApplyFrameworkDefaults preference In-Reply-To: <bug-33669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33669-70-ov0q0uGAYu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33669 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 18:00:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 16:00:47 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-CKwdAtuG2z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 --- Comment #6 from David Gustafsson <glasklas at gmail.com> --- (In reply to Nick Clemens from comment #4) > (In reply to Nick Clemens from comment #3) > > (In reply to Jonathan Druart from comment #2) > > > I don't think the removal here is correct, the method does more than > > > C4::Context->yaml_preference > > > > > > Nick maybe? > > > > perl -e 'use Koha::Config::SysPrefs; use C4::Context; my $sp = > > Koha::Config::SysPrefs->find("ItemsDeniedRenewal")->get_yaml_pref_hash; warn > > Data::Dumper::Dumper($sp); warn Data::Dumper::Dumper( > > C4::Context->yaml_preference("ItemsDeniedRenewal"));' > > > > It doesn't convert from 'NULL' to undef - the expectation is that we can > > pass the return value into a DBIC search directly > > Perhaps we removed the wrong copy here: > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27154 > > One was an object, the other took a pref name, so would have used cache Yes, it would have used cache, but still a good thing to remove it as C4::Context->yaml_preference exists using a proper yaml-parser (and utilized cache). Thanks for pointing out the nuance of the special handling of NULL values. null (lowercase) is valid yaml for null values (converted to undef by the perl parser). So the problem can be solved by using that instead of NULL. Provided a patch to fix this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 19:07:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 17:07:25 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface In-Reply-To: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15428-70-MBLEBvymPm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 ddemick at oslri.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ddemick at oslri.net --- Comment #20 from ddemick at oslri.net --- I'm going to echo other's sentiments. Ideally Patron Category would be the defining attribute for different time out requirements. We would set our self-check patron category for a longer timeout to ensure even during inactive periods the machine stays logged in. Library Staff users would have a short inactivity period defined to auto-log-out if they're not using the system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 20:10:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 18:10:01 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: <bug-30250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30250-70-qm84izB2vp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca --- Comment #48 from Patrick Robitaille <patrick.robitaille at collecto.ca> --- Hi, It seems there is a problem with the default values ​​in the acquisition module as well. When adding a record to a basket with the "from a new (empty) record" option, the default values ​​are not added to the record according to the default grid. Was there work for this problem? currently the ApplyFrameworkDefaults system preference does not fix the problem for the acquisition module. Thanks, Patrick. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 20:15:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 18:15:17 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-Zsrtcc3378@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Hinemoea Viault <hinemoea.viault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150669|0 |1 is obsolete| | --- Comment #7 from Hinemoea Viault <hinemoea.viault at inlibro.com> --- Created attachment 150686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150686&action=edit Bug 33653: Never consider received orders as late We should not list received orders on the late orders page. Test plan: * Create a basket * Create a normal order (not from a subscription, no standing order) * Leave estimated delivery date empty * Close the basket * Create a new invoice and receive the order line * Go to acq > late orders * Verify the order is not in the list * Set filter for 'To' date into the future, i.e. 01/01/2025 => Without this patch the order shows up => With this patch applied the received order does not show up Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Hinemoea Viault <hinemoea.viault at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 20:40:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 18:40:19 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-aHOi0gdx6U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 20:40:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 18:40:21 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-HkcSTgm6RL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144633|0 |1 is obsolete| | Attachment #150685|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150687&action=edit Bug 32478: Remove Koha::Config::SysPref->find since bypasses cache get_yaml_pref_hash also allows invalid YAML and only parses a limited subset so remove this method to avoid future issues. To test): Since tests already exists for C4::Context->yaml_preference and this is a trivial change, do we really need a test plan for this? Sponsored-by: Gothenburg University Library Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 20:40:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 18:40:23 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-ZNGbAythHD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150688&action=edit Bug 32478: Fix handling of undef values in ItemsDeniedRenewal Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 20:40:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 18:40:25 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-51zuuAK3Gz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150689&action=edit Bug 32478: (follow-up) UpdateItemLocationOnCheckin no longer needs flattening This patch removes a line flattening the arrays generated by get_yaml_pref_hash as it is no longer necessary Conditionals are adjusted to avoid warnings in tests Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 20:40:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 18:40:28 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-B6VKPW5BJP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150690&action=edit Bug 32478: (follow-up) Tidy code Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 20:48:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 18:48:28 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface In-Reply-To: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15428-70-AQULZMNzaX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think the patron category is not ideal, but maybe the web based self check could get its own sessions as well, while we are at it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 20:56:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 18:56:44 +0000 Subject: [Koha-bugs] [Bug 32731] Option for cataloguing tools to also be shown in Tools Home In-Reply-To: <bug-32731-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32731-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32731-70-BHeB2PjT7l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 20:56:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 18:56:46 +0000 Subject: [Koha-bugs] [Bug 32731] Option for cataloguing tools to also be shown in Tools Home In-Reply-To: <bug-32731-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32731-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32731-70-8mm29M7A9p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145752|0 |1 is obsolete| | Attachment #145753|0 |1 is obsolete| | Attachment #148947|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150691&action=edit Bug 32731: Move cataloging tools to an include and show on tools home This patch moves the cataloging tools to an include, which is then added with a toggle to the tools homepage. This allows for the content to be on both pages, and can easily be hidden or shown by default. It ensures we don't have to maintain the same links in two places To test: 1 - Apply patch 2 - Ensure cataloging home page looks the same 3 - Ensure you can view/hide the cataloging tools on the tools page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 21:14:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 19:14:26 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface In-Reply-To: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15428-70-CyTGObQAw3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #22 from ddemick at oslri.net --- (In reply to Katrin Fischer from comment #21) > I think the patron category is not ideal, but maybe the web based self check > could get its own sessions as well, while we are at it? I would support that too. Basically a way to force an auto-logoff for staff but still be able to keep our self-check machines logged in for the full day. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 21:29:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 19:29:38 +0000 Subject: [Koha-bugs] [Bug 29507] Speed up auto renew cronjob via parallel processing In-Reply-To: <bug-29507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29507-70-qOOfRIsKW5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29507 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 21:29:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 19:29:40 +0000 Subject: [Koha-bugs] [Bug 29507] Speed up auto renew cronjob via parallel processing In-Reply-To: <bug-29507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29507-70-cXpAK5Va9W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29507 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132056|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150692&action=edit Bug 29507: Speed up auto renew cronjob via parallel processing The cron can take a very long time to run on systems with many issues. For example, a partner with ~250k auto_renew issues is taking about 9 hours to run. If we run that same number of holds in 5 parallel chunks ( splitting the number of issues as evenly as possible ), it could take under 2 hours. Test Plan: 1) Generate a number of issues marked for auto_renew 2) Run the automatic_renewals.pl, use the `time` utility to track how much time it took to run 3) Set parallel_loops to 10 in auto_renew_cronjob section of config in koha-conf 4) Repeat step 2, note the improvement in speed 5) Experiment with other values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 21:34:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 19:34:59 +0000 Subject: [Koha-bugs] [Bug 29507] Speed up auto renew cronjob via parallel processing In-Reply-To: <bug-29507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29507-70-nATRe78ZhJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29507 --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #4) > I am wondering how this can work with the digest option. There's a loop to split based on borrowers. We push all the issues from the first borrower to chunk 0, when we complete one borrower we push the next on to the next chunk, then the next borrower to next chunk When we have pushed to as many chunks as we need (as many loops) we start again. So a single borrower, no matter how many checkouts, will always be processed by a single fork. It means the chunks won't be necessarily the same size, but they will work with digest -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 21:46:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 19:46:21 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16122-70-upQpoqiDWN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150623|0 |1 is obsolete| | --- Comment #31 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150693&action=edit Bug 16122: Add maintenance script to update items.localuse from stats -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 22:05:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 20:05:04 +0000 Subject: [Koha-bugs] [Bug 32959] Item Templates will apply the same barcode each time template is applied if autobarcode is enabled In-Reply-To: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32959-70-e0JW6KYEFE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32959 Hinemoea Viault <hinemoea.viault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149700|0 |1 is obsolete| | --- Comment #3 from Hinemoea Viault <hinemoea.viault at inlibro.com> --- Created attachment 150694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150694&action=edit Bug 32959: Don't store results of autobarcode in item editor templates Test Plan: 1) Enable autobarcode 2) Create a new item template, leave the barcode field blank 3) Apply that item template 4) Note the template prefills the barcode field 5) Delete that item template 6) Apply this patch 7) Restart all the things! 8) Repeat steps 2-4 9) Note the barcode field remains empty! Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org> Signed-off-by: Hinemoea Viault <hinemoea.viault at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 22:19:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 20:19:53 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-9LnFeqUyXY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 Janusz Kaczmarek <januszop at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #8 from Janusz Kaczmarek <januszop at gmail.com> --- Nick, thank you for your contribution. Changing "sort: ~" into "sort: 1" makes the mappings.yaml to be more explicit and therefor less mysterious. But the patch does not change the way Koha with ES sorts titles, so it does not fix the problem. I think, everybody would expect that when choosing sort order by title (both in staff and OPAC interface) the sorting will by done according to the main title, i.e. 245 in MARC 21 and 200 in UNIMARC. So, IMHO, in searchfield 'title' only 245 (for MARC 21) and 200 (for UNIMARC) should have 'sort: 1', and the rest of tags indexed with title -- 'sort: 0'. I would appreciate your feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 22:34:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 20:34:58 +0000 Subject: [Koha-bugs] [Bug 33673] Global system preferences - change to just system preferences In-Reply-To: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33673-70-8xki3UCaAF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 22:35:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 20:35:00 +0000 Subject: [Koha-bugs] [Bug 33673] Global system preferences - change to just system preferences In-Reply-To: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33673-70-JRNjP87jLI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673 --- Comment #1 from David Nind <david at davidnind.com> --- Created attachment 150695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150695&action=edit Bug 33673: Change "global system preferences" to "system preferences" The Koha Community normally refers to "global system preferences" as just "system preferences". This updates the staff interface and other occurences to refelect this, including: - Administration > Global system preferences and the description - Patrons > [a patron] > More > Set permissions > Manage Koha system settings > Manage global system preferences (manage_sysprefs) - The installer files and the database (permissions table) Test plan: 1. Note that in the staff interface "Global system preferences" is dispalyed in two places: 1.1 Administration: Go to Administration. There is a section called "Global system preferences" with a description and a search box. 1.2 User permissions: View the details for a patron > More > Set permissions > expand 'Manage Koha system settings' > scroll down to 'Manage global system preferences (manage_sysprefs)' 2. Apply the patch. 3. Update the database. 4. Revisit the pages in step 1 - these should now show as "System prefereneces" or "system preferences" as appropriate. 5. Sign off! Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 22:36:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 20:36:11 +0000 Subject: [Koha-bugs] [Bug 33673] Global system preferences - change to just system preferences In-Reply-To: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33673-70-2AVWonSE8O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673 --- Comment #2 from David Nind <david at davidnind.com> --- This is the first time I've done a database update - hopefully I got it right! Also, I'm not sure anyone will agree with me about changing this - comments welcome! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 22:37:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 20:37:44 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-4Iq3PAezoj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Janusz Kaczmarek from comment #8) > Nick, thank you for your contribution. Changing "sort: ~" into "sort: 1" > makes the mappings.yaml to be more explicit and therefor less mysterious. > > But the patch does not change the way Koha with ES sorts titles, so it does > not fix the problem. I think, everybody would expect that when choosing > sort order by title (both in staff and OPAC interface) the sorting will by > done according to the main title, i.e. 245 in MARC 21 and 200 in UNIMARC. > > So, IMHO, in searchfield 'title' only 245 (for MARC 21) and 200 (for > UNIMARC) should have 'sort: 1', and the rest of tags indexed with title -- > 'sort: 0'. > > I would appreciate your feedback. I'd agree with that expectation. The other titles don't even all show, so it can get quite confusing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 22:39:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 20:39:56 +0000 Subject: [Koha-bugs] [Bug 33676] Recognise documentation submissions on the about page In-Reply-To: <bug-33676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33676-70-NpsJqs9EeZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33676 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I totally agree about recognizing documentation writers. Not sure how hard it would be to automate, happy with both options. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 22:45:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 20:45:16 +0000 Subject: [Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer In-Reply-To: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33300-70-5bGeVlVL6X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 --- Comment #17 from Fridolin Somers <fridolin.somers at biblibre.com> --- Please backport this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 22:46:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 20:46:06 +0000 Subject: [Koha-bugs] [Bug 33682] New: Logs don't give enough information Message-ID: <bug-33682-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33682 Bug ID: 33682 Summary: Logs don't give enough information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I'm not sure what component this should be part of. Looking at the cataloging logs, it records when a cataloging record is changed, and what the record looks like at that moment. But it does not indicate what part was changed, and what it was before the change. This would be VERY HELPFUL. If all I want to know is when the record took on its current form, then the log is useful. If you are not purging old log records on a regular basis, then there is a chance you might have an older record showing the last change. Even if that were the case, you would have to compare it bit by bit to find out what changed. Please consider noting what parts are changed, and their previous state in the logs. This would be incredibly helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 22:47:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 20:47:38 +0000 Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31132-70-53TvvNLsqh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132 Nicolas Giraud <nicolas.giraud at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137596|0 |1 is obsolete| | --- Comment #7 from Nicolas Giraud <nicolas.giraud at inlibro.com> --- Created attachment 150696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150696&action=edit Bug 31132: Add button to clear the cataloguing auth finder form This enhancement adds a 'Clear form' link to empty all of the input fields on the authority finder plugin form when cataloguing bibliographic records. To test: 1) Search for a bibliographic record in the staff interface 2) Edit a record 3) Go to tabs 1, 6 or 7 to find a tag linked to the authority finder plugin 4) Launch the authority finder plugin by clicking the Tag editor icon at the end of the field 5) If the fields are empty, add some text in the text fields 6) Click the 'Clear form' link at the bottom of the form 7) Confirm the text is cleared from the input fields and the form is empty Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: nicolas <nicolas at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 22:47:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 20:47:40 +0000 Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31132-70-dF0FjoW3Zu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132 Nicolas Giraud <nicolas.giraud at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138069|0 |1 is obsolete| | --- Comment #8 from Nicolas Giraud <nicolas.giraud at inlibro.com> --- Created attachment 150697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150697&action=edit Bug 31132: (follow-up) Reset dropdown values and style button This follow-up patch resets the dropdown values of the form alongside the text inputs. It styles the button to look like a link so it doesn't distract the user and get 'accidentally' clicked when attempting to submit. Test that the button looks and behaves as expected after submitting a search. Signed-off-by: nicolas <nicolas at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 22:50:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 20:50:01 +0000 Subject: [Koha-bugs] [Bug 33610] Accelerated Reading Level Search not accurate In-Reply-To: <bug-33610-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33610-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33610-70-0FDTl5F5xr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33610 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- [ and } correct? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 4 22:57:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 20:57:23 +0000 Subject: [Koha-bugs] [Bug 22375] Due dates should be formatted consistently In-Reply-To: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22375-70-B7yWuNJJgq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx, Jonathan :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 23:02:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 21:02:58 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: <bug-30250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30250-70-lO0HidTqs5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 --- Comment #49 from Aleisha Amohia <aleisha at catalyst.net.nz> --- (In reply to Patrick Robitaille from comment #48) > Hi, > > It seems there is a problem with the default values ​​in the acquisition > module as well. When adding a record to a basket with the "from a new > (empty) record" option, the default values ​​are not added to the record > according to the default grid. > > Was there work for this problem? currently the ApplyFrameworkDefaults system > preference does not fix the problem for the acquisition module. > > Thanks, Patrick. Hi Patrick, can you please open a new bug report for this enhancement so someone can add to ApplyFrameworkDefaults to make it work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 23:15:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 21:15:42 +0000 Subject: [Koha-bugs] [Bug 33672] Item group features shows when placing holds if EnableItemGroupHolds is disabled In-Reply-To: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33672-70-ycz0cdGx7u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33672 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 23:15:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 21:15:44 +0000 Subject: [Koha-bugs] [Bug 33672] Item group features shows when placing holds if EnableItemGroupHolds is disabled In-Reply-To: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33672-70-ZUoRxiXGZV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33672 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150648|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150698&action=edit Bug 33672: Don't show item group holds on OPAC if not enabled This patch adds a check of the syspref 'EnbaleItemGroupHolds' to the opac request form To test: 1 - Enable 'EnableItemGroups' system preference 2 - On staff client, view a record details 3 - Go to 'Item groups' tab, add a enw group 4 - On holdings tab, select one or more items and add to group 5 - View record in OPAC 6 - PLace a hold 7 - Note group option is visible 8 - Apply patch 9 - Refresh, no group option 10 - Enable 'EnableItemGroupHolds' system preference 11 - Refresh opac page, note group option is visible Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 23:18:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 21:18:27 +0000 Subject: [Koha-bugs] [Bug 33672] Item group features shows when placing holds if EnableItemGroupHolds is disabled In-Reply-To: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33672-70-kl5mMgB08W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33672 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Simple template fix, thx Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 4 23:31:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 21:31:35 +0000 Subject: [Koha-bugs] [Bug 33610] Accelerated Reading Level Search not accurate In-Reply-To: <bug-33610-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33610-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33610-70-Rx1ssosqnS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33610 --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- [] are inclusive {} Are exclusive They can be mixed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 00:38:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 22:38:18 +0000 Subject: [Koha-bugs] [Bug 22848] Ability to merge suggestions In-Reply-To: <bug-22848-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22848-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22848-70-9LDeuIC5my@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22848 Tracy <tracy.skousen at suncitywest.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tracy.skousen at suncitywest.c | |om --- Comment #1 from Tracy <tracy.skousen at suncitywest.com> --- I would also like the option to merge multiple suggestions. For popular books we can get several suggestions this way we can add holds for all that made suggestions. For some subjects we wait until we have multiple requests before purchasing so a easy way to see how many have requested a title would be helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 01:14:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 23:14:11 +0000 Subject: [Koha-bugs] [Bug 32731] Option for cataloguing tools to also be shown in Tools Home In-Reply-To: <bug-32731-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32731-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32731-70-XJuy0i4GfL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 --- Comment #15 from David Cook <dcook at prosentient.com.au> --- (In reply to Katrin Fischer from comment #13) > Maybe it would be better to have a clean break? Makes sense to me. I'm already telling people that those tools have moved from Tools to Cataloguing. No one has complained yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 01:19:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 23:19:58 +0000 Subject: [Koha-bugs] [Bug 33297] Typo system preference RetainPatronSearchTerms in DB revs 220600044.pl In-Reply-To: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33297-70-F5F2dOeLkW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33297 --- Comment #14 from David Cook <dcook at prosentient.com.au> --- (In reply to Jonathan Druart from comment #13) > (In reply to David Cook from comment #12) > > Hoping to look at these soon... > > How soon? Alas, I've given up hope for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 01:24:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 23:24:21 +0000 Subject: [Koha-bugs] [Bug 29507] Speed up auto renew cronjob via parallel processing In-Reply-To: <bug-29507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29507-70-cLkMWjXH4Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29507 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 01:40:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 May 2023 23:40:48 +0000 Subject: [Koha-bugs] [Bug 31650] We should publish our coding guidelines more openly In-Reply-To: <bug-31650-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31650-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31650-70-zbP9VpEaU0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31650 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook <dcook at prosentient.com.au> --- (In reply to Julian Maurice from comment #1) > Just an idea: we could move them inside the git repository. That would bring > them closer to where they are needed, they can be published using a link to > git.koha-community.org, and changes can be proposed using the current patch > workflow. I was just thinking how a lot of projects have a CONTRIBUTING.md file for this in their git repos. https://github.com/github/docs/blob/main/CONTRIBUTING.md https://github.com/rails/rails/blob/main/CONTRIBUTING.md https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 02:08:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 00:08:36 +0000 Subject: [Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode In-Reply-To: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32341-70-bRmYce4ZJF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |blocker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 02:22:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 00:22:53 +0000 Subject: [Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode In-Reply-To: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32341-70-dJTGbTEbSu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 --- Comment #17 from David Cook <dcook at prosentient.com.au> --- Upgrading the severity of this one, since this really should be fixed ASAP. -- That said, I'm looking at 21.11, and the holdings on the OPAC detail page looks bad too (although in a totally different way). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 02:25:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 00:25:46 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31735-70-ThyGcuu4yV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 02:25:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 00:25:50 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31735-70-YhGnxjdZ0h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150676|0 |1 is obsolete| | --- Comment #81 from David Nind <david at davidnind.com> --- Created attachment 150699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150699&action=edit Bug 31735: Avoid re-fetcing objects from database by passing them directly instead of ids to various subroutines To test: 1) Run the following test and make sure all pass: t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/api/v1/return_claims.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/transferbook.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/HoldsQueue.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/Illrequests.t t/db_dependent/ILSDI_Services.t t/db_dependent/Items.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Acquisition/Order.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Holds.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/Reserves.t t/db_dependent/rollingloans.t t/db_dependent/selenium/regressions.t t/db_dependent/SIP/ILS.t t/db_dependent/Holds.t t/db_dependent/Holds/LocalHoldsPriority.t t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Holds/HoldItemtypeLimit.t t/db_dependent/Circulation/transferbook.t 2) Performe one or more checkouts for a patron, making sure that the circulation rules allows for renewals (for example by setting an earlier due-date). 3) Log in as this patron in OPAC and make sure the list of checkouts is displayed correctly, and that renewing an issue still works. Sponsored-by: Gothenburg University Library Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 02:25:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 00:25:53 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31735-70-QtcBH3o7pQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150677|0 |1 is obsolete| | --- Comment #82 from David Nind <david at davidnind.com> --- Created attachment 150700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150700&action=edit Bug 31735: Optimize OPAC checkouts view Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 02:25:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 00:25:57 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31735-70-Nhd526CQSw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150678|0 |1 is obsolete| | --- Comment #83 from David Nind <david at davidnind.com> --- Created attachment 150701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150701&action=edit Bug 31735: Fix array that should be passed as reference Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 02:32:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 00:32:15 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31735-70-j58xGUZzX4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 --- Comment #84 from David Nind <david at davidnind.com> --- I've tested and added my sign-off (status was set to needs signoff - maybe Kyle or Nick didn't change the status?). Testing notes (using KTD): - All tests pass before after the patch is applied (ran prove -v t/db_dependent/) - Everything works as per the test plan - I also checked out an item with a due date before today and checked the automatic renewal, then ran the automatic renewal script misc/cronjobs/automatic_renwal.pl -v -c -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 02:46:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 00:46:26 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-JVywEplTmz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 02:46:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 00:46:29 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-ORUUZteZvI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150680|0 |1 is obsolete| | --- Comment #21 from David Nind <david at davidnind.com> --- Created attachment 150702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150702&action=edit Bug 33262: Add deleted_biblionumber column to aqorders table This adds a new column deleted_biblionumber to the aqorders table. This will allow us to store the biblionumber of a deleted record, so we will still be able to tell what has been ordered once the record is deleted. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 02:46:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 00:46:32 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-PhG09n4gk2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150681|0 |1 is obsolete| | --- Comment #22 from David Nind <david at davidnind.com> --- Created attachment 150703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150703&action=edit Bug 33262: [DO NOT PUSH) Schema update Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 02:46:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 00:46:35 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-P87CwwuOl3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150682|0 |1 is obsolete| | --- Comment #23 from David Nind <david at davidnind.com> --- Created attachment 150704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150704&action=edit Bug 33262: Store the biblionumber of a deleted record in the order line When a bibliographic record is deleted and linked to an order in the acquisition module, the biblionumber in the order line is currently deleted as well. This makes it impossible to tell what was ordered in the first place. This is a big issue for libraries that need to be able to track how money was spent over long periods of time. With this patch the biblionumber of the deleted record will be moved to a new column deleted_biblionumber in the order line, keeping the FK on biblionumber. To test: * Apply patch, run dataase update * Create a order/basket in the acquisitions module * Order several things, you can use existing records from the sample data * Make sure you order one of the records at least twice * Take a look at the aqorders table in your database, using a report: SELECT biblionumber, deleted_biblionumber, ordernumber from aqorders; * From the catalog, delete the items on the records and then the records Note: There is a warning about attached orders warning about consequences for acquisitions. I have chosen to keep it at this point in time, as there are still visible side effects of deleting the record, like bug 10758. * Re-run the report and compare results to the first run. deleted_biblionumber should now be filled with the biblionumber of the deleted record. biblionumber should be NULL/empty. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 02:46:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 00:46:38 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-0q8na97O71@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150683|0 |1 is obsolete| | --- Comment #24 from David Nind <david at davidnind.com> --- Created attachment 150705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150705&action=edit Bug 33262: Unit tests prove t/db_dependent/Biblio.t Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 02:46:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 00:46:41 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-4WhkjJeyxi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150684|0 |1 is obsolete| | --- Comment #25 from David Nind <david at davidnind.com> --- Created attachment 150706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150706&action=edit Bug 33262: Add new field to REST API route for orders Without this patch the API driven list of pending orders on the order receive page was broken. With the patch, all should be well now. prove -v t/db_dependent/api/v1/acquisitions_orders.t Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 02:50:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 00:50:14 +0000 Subject: [Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode In-Reply-To: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32341-70-XJOI82qvfi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 --- Comment #18 from David Cook <dcook at prosentient.com.au> --- root at kohadevbox:koha(bug_32341)$ yarn build --view opac yarn run v1.22.19 $ yarn css:build && yarn js:build --view opac $ gulp css && gulp css --view opac [00:48:48] Using gulpfile /kohadevbox/koha/gulpfile.js [00:48:48] Starting 'css'... [00:48:48] Finished 'css' after 12 ms [00:48:51] Using gulpfile /kohadevbox/koha/gulpfile.js [00:48:51] Starting 'css'... [00:48:51] Finished 'css' after 13 ms $ webpack --mode development --view opac [webpack-cli] Error: Unknown option '--view' [webpack-cli] Run 'webpack --help' to see available commands and options error Command failed with exit code 2. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. error Command failed with exit code 2. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 02:51:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 00:51:42 +0000 Subject: [Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode In-Reply-To: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32341-70-k0hILvTczO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 --- Comment #19 from David Cook <dcook at prosentient.com.au> --- Of course, since we .gitignore built files, it's tough to say if anything changed. But it looks like the timestamp on koha-tmpl/opac-tmpl/bootstrap/css/opac.css is different, so we'll assume it worked despite the webpack error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 03:23:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 01:23:36 +0000 Subject: [Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode In-Reply-To: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32341-70-Nu4OaAtBD1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 03:23:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 01:23:40 +0000 Subject: [Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode In-Reply-To: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32341-70-yPCHFCTeJ8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144768|0 |1 is obsolete| | --- Comment #20 from David Cook <dcook at prosentient.com.au> --- Created attachment 150707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150707&action=edit Bug 32341: Some OPAC tables are not displayed well in mobile mode Some OPAC tables are not displayed well in mobile mode, it is absolutely necessary to scroll to the right to read the content properly This patch fix this problem by making the tables responsive To test: 1- Go to the OPAC 2- Open mobile mode 3- Go to a bibliographic record detail page in the OPAC (opac-detail.pl?biblionumber=X) 4- Check the Holdings table --> the information is not presented in a table as it is when viewing on a laptop or PC browser screen. --> we see very narrow columns --> unreadable text 5- Go to to the page 'Summary' (opac-user.pl) 6- Check the 'Checked out' table --> the information is not presented in a table as it is when viewing on a laptop or PC browser screen. --> The columns are overflowing to the right 7- Check the 'Overdue' table --> the information is not presented in a table as it is when viewing on a laptop or PC browser screen. --> The columns are overflowing to the right 8- Go to the page 'Charges' (opac-account.pl) 9- Click on 'Show all transactions' --> the information is not presented in a table as it is when viewing on a laptop or PC browser screen. --> The columns are overflowing to the right 10- Go to the page 'Search history' (opac-search-history.pl) --> the information is not presented in a table as it is when viewing on a laptop or PC browser screen. --> The columns are overflowing to the right 11- Apply the patch 12- Execute 'yarn build --view opac' 13- Clean your cache or open your navigator on private mode (to load updated css files) 14- Perform previous step (1-10) 15- Confirm that the tables are now displayed correctly and is now responsive. Signed-off-by: pauld <pauld at pop-os.localdomain> Signed-off-by: LMSCloudPaulD <paul.derscheid at lmscloud.de> Signed-off-by: David Cook <dcook at prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 03:23:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 01:23:43 +0000 Subject: [Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode In-Reply-To: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32341-70-liO3FRf12t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144808|0 |1 is obsolete| | --- Comment #21 from David Cook <dcook at prosentient.com.au> --- Created attachment 150708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150708&action=edit Bug 32341: (Fix) Changing the placement of the button This attachment correct the placement of the responsive button. It is now in its own column at the last column and the '+' and '-' are remplaced by 'Expand' and 'Unexpand' to make it more clear. Signed-off-by: David Cook <dcook at prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 03:23:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 01:23:47 +0000 Subject: [Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode In-Reply-To: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32341-70-ETfp3d2sUs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145159|0 |1 is obsolete| | --- Comment #22 from David Cook <dcook at prosentient.com.au> --- Created attachment 150709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150709&action=edit Bug 32341: (follow-up) Alternate button style This patch applies a different button style and does a couple of clean up tasks: Removing the redundant sorting-related CSS and moving the responsive button CSS to _common.scss where other DataTable-related styles are found. I think this different button style is more consistent with the OPAC's design. It also eliminates untranslatable strings from the CSS. Signed-off-by: David Cook <dcook at prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 03:23:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 01:23:50 +0000 Subject: [Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode In-Reply-To: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32341-70-JLqsM76P4a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146294|0 |1 is obsolete| | --- Comment #23 from David Cook <dcook at prosentient.com.au> --- Created attachment 150710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150710&action=edit Bug 32341: (follow-up) Making the remains OPAC tables responsive Apply the patch and check for the responsivity of the following tables 1- Go to the OPAC 2- Open mobile mode 3- The following tables are not responsive - Summary - Clubs - Summary - Recalls - Summary - Article requests - Charges - (relative's) - Search history - Authority - Checkout history - All - Checkout history - Checkouts - Checkout history - On-site - Recalls history - Messaging - Subscription (serial) - Course reserves - Courses - Course reserves - Reserves - Authority search results 4- Apply the patch 5- Execute 'yarn build --view opac' 6- Clean your cache or open your navigator on private mode (to load updated css files) 7- Perform previous step (1-3) 8- Confirm that the tables are now displayed correctly and is now responsive. Signed-off-by: David Cook <dcook at prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 03:23:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 01:23:54 +0000 Subject: [Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode In-Reply-To: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32341-70-GRctdYVpRd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149986|0 |1 is obsolete| | --- Comment #24 from David Cook <dcook at prosentient.com.au> --- Created attachment 150711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150711&action=edit Bug 32341: (follow-up) Add responsivity to Curbside pickups table and changing button style for finestables To activate Curbside pickups 1- Enable the CurbsidePickup system preference 1.1 Go to Administration > Global system preferences 1.2 Search for CurbsidePickup 1.3 Change the value for 'Enable' 1.4 Click on 'Save all circulation preferences' 2- Configure time slots for at least one library 2.1 Go to Administration > Curbside pickup 2.2 Fill out the form for Centerville (or another library) Enable: Check Pickup interval: 10 (or other) Maximum boss per interval: 3 (or other) Patron-scheduled pickup: Check Enable for waiting holds only: DO NOT check 2.3 Add a time slot In 'New slot', enter Monday From: 10:00 To: 12:00 Click on 'Add' 3- Make an appointment from the OPAC 3.1 Go to OPAC 3.2 Open mobile mode 3.3 Connect with a user 3.4 Click on 'Curbside pickups' 3.5 Choose the library in 'Pick a library' 3.6 Choose a date in 'Pickup date' 3.7 Choose a time range in 'Select a time' 3.8 Click on 'Schedule pickup' => Notice The table is not responsive 4- Apply the patch 5- Execute 'yarn build --view opac' 6- Clean your cache or open your navigator on private mode (to load updated css files) 7- Perform step 3.1, 3.2, 3.3, 3.4, 8- click on 'Your pickups' => Confirm that the CurbsidePickup table are now displayed correctly and is now responsive. 9- Click on 'Charges' => Confirm that the Charges table are now displayed correctly and is now responsive. I correct a little bug. The "suspend_hold" button did not work anymore. This change resets it to it's original state. Signed-off-by: David Cook <dcook at prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 03:23:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 01:23:57 +0000 Subject: [Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode In-Reply-To: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32341-70-WzNK2f5veZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150321|0 |1 is obsolete| | --- Comment #25 from David Cook <dcook at prosentient.com.au> --- Created attachment 150712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150712&action=edit Bug 32341: (follow-up) Making the label not showed twice when the tables are in responsive mode Signed-off-by: David Cook <dcook at prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 04:18:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 02:18:49 +0000 Subject: [Koha-bugs] [Bug 18148] Make list of lists in OPAC sortable In-Reply-To: <bug-18148-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18148-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18148-70-XkYPESAgiD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32341 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 04:18:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 02:18:49 +0000 Subject: [Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode In-Reply-To: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32341-70-fxHvaouShx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18148 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 04:21:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 02:21:43 +0000 Subject: [Koha-bugs] [Bug 33683] New: Hello, I am writing this report in order to know what are the hardware required for install koha 22.11 on a module-server. Message-ID: <bug-33683-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33683 Bug ID: 33683 Summary: Hello, I am writing this report in order to know what are the hardware required for install koha 22.11 on a module-server. Change sponsored?: --- Product: Koha Version: 22.11 Hardware: PC OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: rulyvazquez23 at gmail.com QA Contact: testopia at bugs.koha-community.org Hi, my name is Raúl Francisco, and I'm studying mechatronics engineering. I'm doing this post because of a project that tries to implement the KOHA software in a physical library, more specifically 22.11 version. I would like to know what would be the hardware requirements to install this version of Koha. In this case, we will use a module-server. Thank you in advance. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 04:22:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 02:22:01 +0000 Subject: [Koha-bugs] [Bug 28965] Add public routes for lists In-Reply-To: <bug-28965-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28965-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28965-70-9fF3nlz59E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #6 from David Cook <dcook at prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #5) > This failure is because you didn't run the updatedatabase script with bug > 28959 applied. That said, I found some missing bits on that bug as well. So > hold on. Now that the dependencies are pushed, what else needs to be done to move this into Needs Signoff? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 04:40:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 02:40:37 +0000 Subject: [Koha-bugs] [Bug 33683] Hello, I am writing this report in order to know what are the hardware required for install koha 22.11 on a module-server. In-Reply-To: <bug-33683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33683-70-tUHUI3fJq9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33683 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |dcook at prosentient.com.au Resolution|--- |INVALID --- Comment #1 from David Cook <dcook at prosentient.com.au> --- Bugzilla is for reporting bugs and enhancements - not for asking general questions. I think what you want is probably the mailing lists. Consider the options at https://koha-community.org/support/ -- That said, you're unlikely to find one ready answer to your question. You can find some general information at https://wiki.koha-community.org/wiki/System_requirements_and_recommendations There are no published hardware requirements since Koha is a large multi-component system and it depends on how many concurrent users it will have. If you search around on the mailing lists, you can find some past conversations on this topic: https://lists.katipo.co.nz/public/koha/2020-December/055608.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 08:02:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 06:02:02 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33611-70-kNBNb6LYey@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 Anneli Österman <anneli.osterman at koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman at koha-suomi. | |fi --- Comment #9 from Anneli Österman <anneli.osterman at koha-suomi.fi> --- Is this bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32563 about the same problem as this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 08:41:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 06:41:08 +0000 Subject: [Koha-bugs] [Bug 29016] viewlog.pl - Problem with many entries In-Reply-To: <bug-29016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29016-70-HQzTD6VNlS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29016 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook <dcook at prosentient.com.au> --- I have a library that gets timeouts when trying to use viewlog.pl. The timeouts come from a HTTP forward proxy that times out after 60 seconds, so it would be interesting to have an AJAX driven DataTable that only returned a small number of logs at a time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 08:54:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 06:54:39 +0000 Subject: [Koha-bugs] [Bug 18398] CHECKIN/CHECKOUT/RENEWAL don't use AutoEmailPrimaryAddress but first valid e-mail In-Reply-To: <bug-18398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18398-70-e1XMymVlLA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 --- Comment #16 from David Cook <dcook at prosentient.com.au> --- Backport to 22.11 would probably be good for this one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 09:05:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 07:05:30 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-h0QrIDDNg5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #35 from Lari Strand <lmstrand at gmail.com> --- (In reply to Julian Maurice from comment #34) > (In reply to Lari Strand from comment #33) > > (In reply to Lari Strand from comment #32) > > > These patches seems to break the functionality in barcode generator plugin > > > barcode.pl. I removed the patches and it started generating barcodes again. > > > > This problem has been addressed in > > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32813 > > Do not try to test this patch without all the other patches applied. They > are marked as dependencies for a good reason ;) (and the status is "BLOCKED" > for this reason as well) Good point :). Just noticed some patches marked dependencies are mostly code refactorings and do not change how some plugins work with/without the patch but that's fine by me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 09:28:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 07:28:37 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at library level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-MbJ1LRGE1S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 09:45:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 07:45:21 +0000 Subject: [Koha-bugs] [Bug 33684] New: Able to save patron without date of birth when field is set as mandatory Message-ID: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33684 Bug ID: 33684 Summary: Able to save patron without date of birth when field is set as mandatory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: emmi.takkinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com One is able to save patron without date of birth even if "dateofbirth" is set mandatory in syspref BorrowerMandatoryField. This doesn't seem to happen with other fields. To reproduce: 1. Add "dateofbirth" to syspref BorrowerMandatoryField. 2. Add patron and leave date of birth input field empty. 3. Save. => Patron is saved succesfully. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 10:04:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 08:04:59 +0000 Subject: [Koha-bugs] [Bug 33684] Able to save patron without date of birth when field is set as mandatory In-Reply-To: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33684-70-i7rRBgp0ed@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33684 --- Comment #1 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> --- Tested this a bit and it seems that any field with flatpicker attached to it has this same problem, e.g. expiration date. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 10:27:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 08:27:38 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at library level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-XNvTU4sH33@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150713&action=edit Bug 32721: Highlight the branch specific option from the global syspref Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 10:57:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 08:57:33 +0000 Subject: [Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Transliteration code' In-Reply-To: <bug-32567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32567-70-MwWJ6vYeJK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567 pierre.genty at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 11:46:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 09:46:51 +0000 Subject: [Koha-bugs] [Bug 33676] Recognise documentation submissions on the about page In-Reply-To: <bug-33676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33676-70-sqLmtAdFVU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33676 --- Comment #2 from Aude Charillon <aude.charillon at ptfs-europe.com> --- I'm the one who raised this with Martin... I was thinking of the people who contributed to updating screenshots during Hackfest. Not sure how it would work either; leaving it to the experts! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:42:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 10:42:45 +0000 Subject: [Koha-bugs] [Bug 33685] New: We should display both backend and local status for ILL loan requests Message-ID: <bug-33685-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33685 Bug ID: 33685 Summary: We should display both backend and local status for ILL loan requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com At least in the staff client, it would be clearer to display the combination of backend status and local status_alias in the status column for ill requests. At the moment, it's unclear to the end user (and the developer) what the actual state of the request is.. These really are distinct states and should be clearly displayed as such. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:42:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 10:42:58 +0000 Subject: [Koha-bugs] [Bug 33685] We should display both backend and local status for ILL loan requests In-Reply-To: <bug-33685-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33685-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33685-70-P7Pkn3nsEo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33685 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 [Bug 22440] ILL API response objects inconsistent with other endpoints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:42:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 10:42:58 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-PNpY9IWMwo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33685 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33685 [Bug 33685] We should display both backend and local status for ILL loan requests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:56:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 10:56:54 +0000 Subject: [Koha-bugs] [Bug 33685] We should display both backend and local status for ILL loan requests In-Reply-To: <bug-33685-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33685-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33685-70-Bys0O8FwIV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33685 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |pedro.amorim at ptfs-europe.co | |m, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 12:57:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 10:57:14 +0000 Subject: [Koha-bugs] [Bug 31431] Cannot change one's own userid if logged in as staff In-Reply-To: <bug-31431-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31431-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31431-70-3aYrlYRFgY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31431 Janusz Kaczmarek <januszop at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop at gmail.com --- Comment #3 from Janusz Kaczmarek <januszop at gmail.com> --- Same effect (Internal Server Error) in 22.11.03. In log we find: Can't call method "password_expired" on an undefined value at /usr/share/koha/lib/C4/Auth.pm line 1785. This is because, in function C4::Auth::check_cookie_auth, the following is done: my $userid = $session->param('id'); [...] my $patron = Koha::Patrons->find({ userid => $userid }); $patron = Koha::Patrons->find({ cardnumber => $userid }) unless $patron; return ("password_expired", undef ) if $patron->password_expired; $userid is taken from stored session data and contains the old user login (= userid). At the same time, the content of the borrowers table is already updated with the new userid. So no patron object is found. As a consequence, $patron->password_expired is called on an undefined patron (without checking if it exists). So, maybe while self-modifying the userid the session data should also be updated? Would it work? And how about SSO methods, should any of them be used? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:00:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:00:23 +0000 Subject: [Koha-bugs] [Bug 33686] New: Update plugin unimarc_field_110.pl 'Script of title' with 2022 values Message-ID: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Bug ID: 33686 Summary: Update plugin unimarc_field_110.pl 'Script of title' with 2022 values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: thibaud.guillot at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hello all, Update of the data with the values introduced in 2022 concerning unimarc_field_110.pl Was missing : - ib : birman - ic : khmer - jb : bengali - jc : gujurati - jd : gurmukhi - je : odia (oriya) - lb : kannada (kannara) - lc : malayalam - ld : singhalais (cinghalais) - le : télougou - na : éthiopien (guèze) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:00:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:00:30 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_110.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-oWuz9W1uYo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |thibaud.guillot at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:03:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:03:42 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_110.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-kt7JRDpa4x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:03:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:03:44 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_110.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-pEFeMYbSPr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 --- Comment #1 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 150714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150714&action=edit Bug 33686: Update plugin unimarc_field_110.pl with 2022 values Was missing : - ib : birman - ic : khmer - jb : bengali - jc : gujurati - jd : gurmukhi - je : odia (oriya) - lb : kannada (kannara) - lc : malayalam - ld : singhalais (cinghalais) - le : télougou - na : éthiopien (guèze) Sponsored by BibLibre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:04:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:04:43 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-mgzG6W9z1s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150715&action=edit Bug 22440: Add Koha::Illrequests->filter_by_visible This patch introduces a method for filtering out requests that match the statuses specified on the *ILLHiddenRequestStatuses* system preference. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Illrequests.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:04:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:04:45 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-LeSzviz5gA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150716&action=edit Bug 22440: Add missing foreign key Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:04:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:04:48 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-Riu02whFhB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150717&action=edit Bug 22440: Add standard accessors for later usage Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:04:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:04:51 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-DsMYchfPMI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150718&action=edit Bug 22440: Add GET /ill_requests Co-authored-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:04:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:04:55 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-BV7cwXAUDG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150719&action=edit Bug 22440: New ILL requests table Use kohaTable requesting the REST api instead of the old KohaTable Co-authored-by: Tomás Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:04:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:04:57 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-6f0aCVcKlh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150720&action=edit Bug 22440: ILL API changes * Add GET /illbackends/{id}/statuses * Change API route to ill/requests Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:05:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:05:01 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-0cKLPsbeRy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150721&action=edit Bug 22440: Tests Updated API tests Co-authored-by: Tomás Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:05:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:05:04 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-dieIyiiMpA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150722&action=edit Bug 22440: Move backend statuses api endpoint Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:05:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:05:07 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-fhcnIGdLpP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150723&action=edit Bug 22440: Schema Update Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:06:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:06:49 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-fGkAp5eCyZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:07:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:07:47 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-RV2PE1KyqF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This has had significant testing in house at PTFS-E and was worked on collaboratively by Tomas and Pedro (with a little interruption from myself a few times) We all agreed to go PQA given the eyes's it's had on :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:08:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:08:58 +0000 Subject: [Koha-bugs] [Bug 33545] Adding faceting to API result sets In-Reply-To: <bug-33545-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33545-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33545-70-px2E2MU0qq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33545 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 [Bug 22440] ILL API response objects inconsistent with other endpoints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:08:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:08:58 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-wjTLinOFcA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33545 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33545 [Bug 33545] Adding faceting to API result sets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:09:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:09:52 +0000 Subject: [Koha-bugs] [Bug 33545] Adding faceting to API result sets In-Reply-To: <bug-33545-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33545-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33545-70-QRzayGSyXo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33545 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- The `status+strings` embed option in ILLBackends as actually really a facet.. we should move it to a new syntax once we've agreed upon it asap. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:23:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:23:06 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at library level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-7s8DQlQtog@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:23:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:23:08 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at library level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-ZJQLa4C8NA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149860|0 |1 is obsolete| | Attachment #149861|0 |1 is obsolete| | Attachment #149862|0 |1 is obsolete| | Attachment #149863|0 |1 is obsolete| | Attachment #149864|0 |1 is obsolete| | Attachment #149865|0 |1 is obsolete| | Attachment #149866|0 |1 is obsolete| | Attachment #150713|0 |1 is obsolete| | --- Comment #29 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150724&action=edit Bug 32721: Add branch specific userjs and usercss This patch allows for branch specific userJS and userCSS to be added through the libraries table. This works in conjunction with the global UserJS and UserCSS functionality and allows for multiple OPACs with different css and js options. Test plan: 1) Add to apache conf (/etc/apache2/sites-available/kohadev.conf) SetEnv OPAC_BRANCH_DEFAULT "FFL" RequestHeader add X-Koha-SetEnv "OPAC_BRANCH_DEFAULT FFL" 2) In the container, run restart_all 3) Navigate to the OPACUserJS and OPACUserCSS system preferences and add the following: OPACUserJS - console.log('Hello from global sysprefs');, OPACUserCSS - 'body { background-color: black; }' 4) Refresh the OPAC and the background should be black and the message should be logged to the console in developer tools 5) Navigate to Administration > Libraries 6) On the Fairfield branch (if this does not exist you will need to create a branch with a code matching the code that you added to the apache conf file), click edit 7) At the bottom there should be two fields to add userjs and usercss, complete with Codemirror syntax checking 8) In userjs add console.log('Hello from branch level'); and in usercss add 'body { background-color: blue; } then save 9) Return to the OPAC and refresh 10) If you are logged out of the OPAC it should now be logging both the message from global and from the branch level and the background should be blue (if not you will need to log out) 11) Log back into the OPAC using a user that DOES NOT have a default branch matching the branch you added to the Apache conf 12) The OPAC should now revert to only showing the global message in the console with a black background Sponsored-by: PTFS Europe Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:23:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:23:11 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at library level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-usN1ZvALAn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #30 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150725&action=edit Bug 32721: Database update to add userjs and usercss to branches table This patch adds the columns for userjs and usercss to the branches table Test plan as per previous commit Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:23:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:23:13 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at library level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-bvqZHlvO3S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #31 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150726&action=edit Bug 32721: DBIC Schema This commit adds the DBIC Schema for the database change Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:23:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:23:16 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at library level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-xz5IqAKduY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #32 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150727&action=edit Bug 32721: Add unit tests Unit tests to test two new functions: GetBranchSpecificJS and GetBranchSpecificCSS Test plan: 1) In the shell run prove -t t/db_dependent/Template/Plugin/Branches.t Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:23:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:23:18 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at library level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-USZj2IlLJr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #33 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150728&action=edit Bug 32721: Tidy up - duplicate fetching of userjs and css Currently UserJS and UserCSS is injected into the template as a parameter through Auth.pm but is then fetched using Koha.Preference() in the template. This patch tidies this up by removing the parameters from Auth.pm Test plan as per first commit Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:23:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:23:21 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at library level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-36CJ8ovUiT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #34 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150729&action=edit Bug 32721: (QA follow up) - fix QA issues This patches addresses issues raised by the QA tests. It also adds a missed import of the Branches file in the document head Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:23:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:23:23 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at library level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-77pe5wMDje@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #35 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150730&action=edit Bug 32721: (QA follow-up) Add missing imports Missing imports added in three template files Exec flag added to atomic update file Tinymce imports removed A new bug will be created to move codemirror into an inc file at latest version Test plan as before Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:23:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:23:26 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at library level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-RJPl4pbzke@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #36 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150731&action=edit Bug 32721: Highlight the branch specific option from the global syspref Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:23:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:23:28 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at library level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-9qzCpA6Zwh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #37 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150732&action=edit Bug 32721: (QA follow-up) Add exec flag to DB update and expand tests Added tests for case of no branch specific settings and when no branch passed Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:25:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:25:32 +0000 Subject: [Koha-bugs] [Bug 32563] Reservedate becomes expirationdate in some cases In-Reply-To: <bug-32563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32563-70-iIUln4NLtJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32563 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED CC| |nick at bywatersolutions.com Resolution|--- |DUPLICATE --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 33611 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:25:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:25:32 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33611-70-dzQstNUljh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |slavashishkin at gmail.com --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- *** Bug 32563 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:28:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:28:16 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at library level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-dOzJToLe5q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #38 from Nick Clemens <nick at bywatersolutions.com> --- One question: You add the fields to the api, do we want them? They feel like they may be somewhat Koha specific, not needed for outside connections? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:47:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:47:02 +0000 Subject: [Koha-bugs] [Bug 33673] Global system preferences - change to just system preferences In-Reply-To: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33673-70-Lhtuo56vMR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:47:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:47:05 +0000 Subject: [Koha-bugs] [Bug 33673] Global system preferences - change to just system preferences In-Reply-To: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33673-70-nepniTvWuL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150695|0 |1 is obsolete| | --- Comment #3 from Magnus Enger <magnus at libriotech.no> --- Created attachment 150733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150733&action=edit Bug 33673: Change "global system preferences" to "system preferences" The Koha Community normally refers to "global system preferences" as just "system preferences". This updates the staff interface and other occurences to refelect this, including: - Administration > Global system preferences and the description - Patrons > [a patron] > More > Set permissions > Manage Koha system settings > Manage global system preferences (manage_sysprefs) - The installer files and the database (permissions table) Test plan: 1. Note that in the staff interface "Global system preferences" is dispalyed in two places: 1.1 Administration: Go to Administration. There is a section called "Global system preferences" with a description and a search box. 1.2 User permissions: View the details for a patron > More > Set permissions > expand 'Manage Koha system settings' > scroll down to 'Manage global system preferences (manage_sysprefs)' 2. Apply the patch. 3. Update the database. 4. Revisit the pages in step 1 - these should now show as "System prefereneces" or "system preferences" as appropriate. 5. Sign off! Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Magnus Enger <magnus at libriotech.no> I agree with this change, consistency is good. As far as I can see this patch cathes all the occurrences of "global". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 13:47:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 11:47:59 +0000 Subject: [Koha-bugs] [Bug 33673] Global system preferences - change to just system preferences In-Reply-To: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33673-70-e8ev48RVAU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #4 from Magnus Enger <magnus at libriotech.no> --- (In reply to David Nind from comment #2) > This is the first time I've done a database update - hopefully I got it > right! Works nicely as far as I can see. Well done! :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:04:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:04:05 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-elkiCoe1GA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:04:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:04:08 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-aLDDQVIpC4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150702|0 |1 is obsolete| | --- Comment #26 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150734&action=edit Bug 33262: Add deleted_biblionumber column to aqorders table This adds a new column deleted_biblionumber to the aqorders table. This will allow us to store the biblionumber of a deleted record, so we will still be able to tell what has been ordered once the record is deleted. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:04:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:04:10 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-6KwY9ouOlk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150703|0 |1 is obsolete| | --- Comment #27 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150735&action=edit Bug 33262: [DO NOT PUSH) Schema update Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:04:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:04:13 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-icIjfFnaVH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150704|0 |1 is obsolete| | --- Comment #28 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150736&action=edit Bug 33262: Store the biblionumber of a deleted record in the order line When a bibliographic record is deleted and linked to an order in the acquisition module, the biblionumber in the order line is currently deleted as well. This makes it impossible to tell what was ordered in the first place. This is a big issue for libraries that need to be able to track how money was spent over long periods of time. With this patch the biblionumber of the deleted record will be moved to a new column deleted_biblionumber in the order line, keeping the FK on biblionumber. To test: * Apply patch, run dataase update * Create a order/basket in the acquisitions module * Order several things, you can use existing records from the sample data * Make sure you order one of the records at least twice * Take a look at the aqorders table in your database, using a report: SELECT biblionumber, deleted_biblionumber, ordernumber from aqorders; * From the catalog, delete the items on the records and then the records Note: There is a warning about attached orders warning about consequences for acquisitions. I have chosen to keep it at this point in time, as there are still visible side effects of deleting the record, like bug 10758. * Re-run the report and compare results to the first run. deleted_biblionumber should now be filled with the biblionumber of the deleted record. biblionumber should be NULL/empty. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:04:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:04:16 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-TiCEhSMsSs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150705|0 |1 is obsolete| | --- Comment #29 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150737&action=edit Bug 33262: Unit tests prove t/db_dependent/Biblio.t Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:04:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:04:18 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-NiKT4GavZb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150706|0 |1 is obsolete| | --- Comment #30 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150738&action=edit Bug 33262: Add new field to REST API route for orders Without this patch the API driven list of pending orders on the order receive page was broken. With the patch, all should be well now. prove -v t/db_dependent/api/v1/acquisitions_orders.t Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:04:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:04:23 +0000 Subject: [Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-dITF5Dhs2o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #11 from Magnus Enger <magnus at libriotech.no> --- Trying to apply the patches, I get this: $ git bz apply 26403 Bug 26403 Depends on bug 20307 (BLOCKED) As far as I can tell "Bug 20307 - Language overlay for authorized values" is for getting translateable authorised values in the interface, which would be another solution to this problem? Or is there a connection between these two bugs that I am not seeing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:07:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:07:53 +0000 Subject: [Koha-bugs] [Bug 22714] ILL table population call might benefit from being inside the datatable In-Reply-To: <bug-22714-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22714-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22714-70-i7RcwqWcjx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22714 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 22440 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:07:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:07:53 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-wnklXehN5u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** Bug 22714 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:09:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:09:03 +0000 Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to server side filtering In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-B6LdVsu7Wh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ILL API response objects |Improve ILL page |inconsistent with other |performance by moving to |endpoints |server side filtering -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:09:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:09:36 +0000 Subject: [Koha-bugs] [Bug 32926] Cannot expand or collapse some System preference sections after a search In-Reply-To: <bug-32926-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32926-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32926-70-lCpWU7tujE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 --- Comment #20 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150739&action=edit Bug 32926: Restore scroll to sub-tab Test plan: Go to sys prefs, click 'Enhanced Content' Click 'OverDrive', notice it doesnt scroll there Apply this patch: Do the same test plan, but notice it does scroll there, like before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:09:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:09:59 +0000 Subject: [Koha-bugs] [Bug 32926] Cannot expand or collapse some System preference sections after a search In-Reply-To: <bug-32926-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32926-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32926-70-SMMLBEeeRn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |martin.renvoize at ptfs-europe | |.com, | |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:15:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:15:32 +0000 Subject: [Koha-bugs] [Bug 33687] New: Clicking on a sys pref sub-menu item does not scroll to that item Message-ID: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 Bug ID: 33687 Summary: Clicking on a sys pref sub-menu item does not scroll to that item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: pedro.amorim at ptfs-europe.com Reporter: pedro.amorim at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Depends on: 32926 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 [Bug 32926] Cannot expand or collapse some System preference sections after a search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:15:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:15:32 +0000 Subject: [Koha-bugs] [Bug 32926] Cannot expand or collapse some System preference sections after a search In-Reply-To: <bug-32926-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32926-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32926-70-zM5na3JeOr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33687 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 [Bug 33687] Clicking on a sys pref sub-menu item does not scroll to that item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:16:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:16:07 +0000 Subject: [Koha-bugs] [Bug 33687] Clicking on a sys pref sub-menu item does not scroll to that item In-Reply-To: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33687-70-OH8uiGRwOO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:16:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:16:09 +0000 Subject: [Koha-bugs] [Bug 33687] Clicking on a sys pref sub-menu item does not scroll to that item In-Reply-To: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33687-70-bji37Gwdws@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 --- Comment #1 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150740&action=edit Bug 33687: Restore scroll to sub-tab Test plan: Go to sys prefs, click 'Enhanced Content' Click 'OverDrive', notice it doesnt scroll there Apply this patch: Do the same test plan, but notice it does scroll there, like before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:16:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:16:41 +0000 Subject: [Koha-bugs] [Bug 19249] Date picker broken in "Quick add new patron" form In-Reply-To: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19249-70-YyGcEPBfrS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:16:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:16:44 +0000 Subject: [Koha-bugs] [Bug 19249] Date picker broken in "Quick add new patron" form In-Reply-To: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19249-70-kQ6bf1KFgY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 --- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:16:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:16:47 +0000 Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to server side filtering In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-krMA4FskYM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:16:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:16:49 +0000 Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to server side filtering In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-t3iFgdbuM1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:16:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:16:51 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32250-70-ENQsQEzUcU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:16:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:16:53 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32250-70-OzswRQzYaS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 --- Comment #23 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:16:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:16:55 +0000 Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially In-Reply-To: <bug-32253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32253-70-KCzg6sJHwI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:16:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:16:57 +0000 Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially In-Reply-To: <bug-32253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32253-70-hmfHy1NKIt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:16:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:16:59 +0000 Subject: [Koha-bugs] [Bug 32745] Jobs view breaks when there are jobs with context IS NULL In-Reply-To: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32745-70-VJN6jhrkfM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32745 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:01 +0000 Subject: [Koha-bugs] [Bug 32745] Jobs view breaks when there are jobs with context IS NULL In-Reply-To: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32745-70-MusRARi0bC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32745 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:04 +0000 Subject: [Koha-bugs] [Bug 32782] Add UNIMARC support to the ERM module In-Reply-To: <bug-32782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32782-70-VJURTKRy0u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32782 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:06 +0000 Subject: [Koha-bugs] [Bug 32782] Add UNIMARC support to the ERM module In-Reply-To: <bug-32782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32782-70-v47GxltAE4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32782 --- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:08 +0000 Subject: [Koha-bugs] [Bug 32874] Fix cataloguing/value_builder/unimarc_field_700-4.pl In-Reply-To: <bug-32874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32874-70-kwM9jWbGln@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32874 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:10 +0000 Subject: [Koha-bugs] [Bug 32874] Fix cataloguing/value_builder/unimarc_field_700-4.pl In-Reply-To: <bug-32874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32874-70-gKtKsnUoE0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32874 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:12 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-hkJVOPBPi5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:15 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-dKtbCS4zNb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #21 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:16 +0000 Subject: [Koha-bugs] [Bug 32926] Cannot expand or collapse some System preference sections after a search In-Reply-To: <bug-32926-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32926-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32926-70-jY6xQRUgUb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:17 +0000 Subject: [Koha-bugs] [Bug 33156] Batch patron modification tool is missing search bar and other attributes In-Reply-To: <bug-33156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33156-70-K93Sb1sy3J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:19 +0000 Subject: [Koha-bugs] [Bug 33156] Batch patron modification tool is missing search bar and other attributes In-Reply-To: <bug-33156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33156-70-fPBCo21C1x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 --- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:21 +0000 Subject: [Koha-bugs] [Bug 33328] x-marc-schema should be renamed x-record-schema In-Reply-To: <bug-33328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33328-70-4dkwE0x5L7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33328 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:22 +0000 Subject: [Koha-bugs] [Bug 33328] x-marc-schema should be renamed x-record-schema In-Reply-To: <bug-33328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33328-70-yw06oTqjcd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33328 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:24 +0000 Subject: [Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 In-Reply-To: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33437-70-GR9GnvUIUl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:26 +0000 Subject: [Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 In-Reply-To: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33437-70-NimWwUICSD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 --- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:28 +0000 Subject: [Koha-bugs] [Bug 33482] Errors from EBSCO's ws are not reported to the UI In-Reply-To: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33482-70-RhJzk7A1nw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33482 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:31 +0000 Subject: [Koha-bugs] [Bug 33482] Errors from EBSCO's ws are not reported to the UI In-Reply-To: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33482-70-vBnJCd9BBb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33482 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:31 +0000 Subject: [Koha-bugs] [Bug 32926] Cannot expand or collapse some System preference sections after a search In-Reply-To: <bug-32926-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32926-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32926-70-ela9MdvALa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150739|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:32 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-0FlJjfi1Aj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:34 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-L0qOyuF7iq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #46 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:36 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals creating issue with renewal history view In-Reply-To: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33504-70-0Qpp30TCxg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:39 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals creating issue with renewal history view In-Reply-To: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33504-70-jg8gJd6EBe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:41 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-48W5QlWx79@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:43 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-io7RddxS7R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 --- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:45 +0000 Subject: [Koha-bugs] [Bug 33506] Series has wrong index name on scan index page and search option selection is not retained In-Reply-To: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33506-70-c7BX8amnoJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:47 +0000 Subject: [Koha-bugs] [Bug 33506] Series has wrong index name on scan index page and search option selection is not retained In-Reply-To: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33506-70-bpUUURaaEg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:49 +0000 Subject: [Koha-bugs] [Bug 33559] Use template wrapper for breadcrumbs: Serials part 2 In-Reply-To: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33559-70-dxvhLQr5pf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:51 +0000 Subject: [Koha-bugs] [Bug 33559] Use template wrapper for breadcrumbs: Serials part 2 In-Reply-To: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33559-70-qzlqGeAYgH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:51 +0000 Subject: [Koha-bugs] [Bug 32926] Cannot expand or collapse some System preference sections after a search In-Reply-To: <bug-32926-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32926-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32926-70-GVPmRqm3GI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 --- Comment #21 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Made patch obsolete, opened bug 33687 instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:53 +0000 Subject: [Koha-bugs] [Bug 33564] Use template wrapper for breadcrumbs: Serials part 3 In-Reply-To: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33564-70-ClQySmnTIF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33564 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:55 +0000 Subject: [Koha-bugs] [Bug 33564] Use template wrapper for breadcrumbs: Serials part 3 In-Reply-To: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33564-70-e8djB41z3A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33564 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:57 +0000 Subject: [Koha-bugs] [Bug 33566] Use template wrapper for breadcrumbs: Tools, part 1 In-Reply-To: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33566-70-eJLiBlJjM2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:17:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:17:58 +0000 Subject: [Koha-bugs] [Bug 33566] Use template wrapper for breadcrumbs: Tools, part 1 In-Reply-To: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33566-70-UCh4gCWSNM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:00 +0000 Subject: [Koha-bugs] [Bug 33588] Inventory item list is missing page-section class In-Reply-To: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33588-70-CbZovfdfse@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33588 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:02 +0000 Subject: [Koha-bugs] [Bug 33588] Inventory item list is missing page-section class In-Reply-To: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33588-70-KUXND26hfG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33588 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:04 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-NsR6HpHVKt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:06 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-LzyVVfEbo5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 --- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:08 +0000 Subject: [Koha-bugs] [Bug 33597] Get rid of few SameSite warnings In-Reply-To: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33597-70-uy4HZsSB0T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:10 +0000 Subject: [Koha-bugs] [Bug 33597] Get rid of few SameSite warnings In-Reply-To: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33597-70-gkQBMnoTYs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 --- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:12 +0000 Subject: [Koha-bugs] [Bug 33598] Use template wrapper for breadcrumbs: Tools, part 5 In-Reply-To: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33598-70-7OKaKImasP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33598 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:14 +0000 Subject: [Koha-bugs] [Bug 33598] Use template wrapper for breadcrumbs: Tools, part 5 In-Reply-To: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33598-70-YlQk8jIVts@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33598 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:16 +0000 Subject: [Koha-bugs] [Bug 33603] misc/maintenance/search_for_data_inconsistencies.pl fails if biblio.biblionumber on control field In-Reply-To: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33603-70-t4KPlJHHSq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:18 +0000 Subject: [Koha-bugs] [Bug 33603] misc/maintenance/search_for_data_inconsistencies.pl fails if biblio.biblionumber on control field In-Reply-To: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33603-70-rVF8AJXn8S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:19 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31799-70-hG81GLWh11@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:20 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-9005Ghcn6A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:22 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31799-70-jW3iSgzeQa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150607|0 |1 is obsolete| | Attachment #150608|0 |1 is obsolete| | Attachment #150609|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150741&action=edit Bug 31799: Add REST endpoint to modify a biblio's item To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Get a biblio with an item 4. Make a PUT request to /api/v1/biblios/:biblio_id/items/:item_id with a json body that represents an item to replace 5. Check that the item was modified 6. Sign off Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:22 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-Eeac0q6Kkk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 --- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:24 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31799-70-Yk8WNKdZHC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 --- Comment #18 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150742&action=edit Bug 31799: (follow-up) Tidy up and fix duplicate barcode handling Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:24 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33623-70-Z2elH4KPbt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:26 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33623-70-NBbWeRmOAU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 --- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:26 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31799-70-sfdU7qW0j5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 --- Comment #19 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150743&action=edit Bug 31799: (follow-up) Add 409 error to spec Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:28 +0000 Subject: [Koha-bugs] [Bug 33629] allow pbuilder to use network via build-git-snapshot In-Reply-To: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33629-70-nI8UnCzyPg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33629 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:30 +0000 Subject: [Koha-bugs] [Bug 33629] allow pbuilder to use network via build-git-snapshot In-Reply-To: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33629-70-Haj5imn4jq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33629 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:33 +0000 Subject: [Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section In-Reply-To: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33634-70-iyswtwKfez@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:18:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:18:35 +0000 Subject: [Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section In-Reply-To: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33634-70-ZMV3nhUtvE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:19:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:19:18 +0000 Subject: [Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-LKRz5gnPBU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:19:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:19:21 +0000 Subject: [Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-Xkausm0a9P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149104|0 |1 is obsolete| | --- Comment #12 from Magnus Enger <magnus at libriotech.no> --- Created attachment 150744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150744&action=edit Bug 26403: "Issue refund" is not fully translatable This patch moves account debit and credit types, as well as the CASH payment type, into YAML files under installer/data/en/mandatory. This should make the debit and credit types translatable (for new installations only). To test: 1. Apply patch 2. Update po files ./misc/translator/translate update xx-XX 3. View the xx-XX-installer.po file -->The default account debit and credit types (and cash payment type) should be available to be translated 4. Translate the strings 5. Apply the translations ./misc/translator/translate install xx-XX 6. Load the new translated YAML files (with a fresh install, or by deleting the values in the db and using ./misc/load_yaml.pl to load the files) 7. In the staff interface, go to Administration > Credit types --> They should be translated 8. Go to Administration > Debit types --> They should be translated Signed-off-by: Magnus Enger <magnus at libriotech.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:19:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:19:24 +0000 Subject: [Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-JHQwWglVRi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149105|0 |1 is obsolete| | --- Comment #13 from Magnus Enger <magnus at libriotech.no> --- Created attachment 150745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150745&action=edit Bug 26403: (follow-up) Deleted old SQL files Signed-off-by: Magnus Enger <magnus at libriotech.no> Followed the test plan. Works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:20:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:20:34 +0000 Subject: [Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-CFbn7SPzl0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20307 Depends on|20307 | --- Comment #14 from Magnus Enger <magnus at libriotech.no> --- Worked nicely without 20307 for me, so I am taking the liberty of changing that to a "see also". Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 [Bug 20307] Language overlay for authorized values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:20:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:20:34 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20307-70-NFaSyeCS0t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|26403 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 [Bug 26403] "Issue refund" is not fully translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:22:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:22:33 +0000 Subject: [Koha-bugs] [Bug 33687] Clicking on a sys pref sub-menu item does not scroll to that item In-Reply-To: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33687-70-BrRz7cLuO5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |katrin.fischer at bsz-bw.de, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:29:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:29:32 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-H3KslEN3Kp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 --- Comment #31 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Well done, Katrina. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:32:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:32:38 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-kiXczRYNID@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:32:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:32:40 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-eilMvRqmlg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150615|0 |1 is obsolete| | Attachment #150616|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150746&action=edit Bug 32735: Add endpoint to list authorities This patch adds an endpoint to list authorities To test: 1. apply patch 2. enable basic auth 3. call to GET /api/v1/authorities with the following Accept headers: * application/json * application/marcxml+xml * application/marc-in-json * application/marc * text/plain 4. notice how data changes with each Accept header 5. prove t/db_dependent/api/v1/authorities.t 6. sign off Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:32:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:32:43 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-ITyw60hN6G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150747&action=edit Bug 32735: (follow-up) Make Koha::Objects::Record::Collections->print_collection work with Authorities and Biblios Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:33:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:33:41 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_110.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-urgasU3AQi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 pierre.genty at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:41:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:41:18 +0000 Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's account In-Reply-To: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21043-70-Rx6G2sDiuT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|martin.renvoize at ptfs-europe |kyle at bywatersolutions.com |.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:45:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:45:41 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-q1KSrDyTvO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Janusz Kaczmarek from comment #8) > Nick, thank you for your contribution. Changing "sort: ~" into "sort: 1" > makes the mappings.yaml to be more explicit and therefor less mysterious. > > But the patch does not change the way Koha with ES sorts titles, so it does > not fix the problem. I think, everybody would expect that when choosing > sort order by title (both in staff and OPAC interface) the sorting will by > done according to the main title, i.e. 245 in MARC 21 and 200 in UNIMARC. > > So, IMHO, in searchfield 'title' only 245 (for MARC 21) and 200 (for > UNIMARC) should have 'sort: 1', and the rest of tags indexed with title -- > 'sort: 0'. > > I would appreciate your feedback. Agreed - it looks like the Elastic default on a multi-value sort field is min (ascending) or max (descending) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:48:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:48:27 +0000 Subject: [Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out In-Reply-To: <bug-23102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23102-70-hmkH0hCfT9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #25 from Magnus Enger <magnus at libriotech.no> --- I can't reproduce the problem in ktd. I put this: </script> <img src="http://localhost:8080/silk/famfamfam.png"/> <script> in SCOUserJS, restarted all the things and logged into SCO, then clicked "Finished", "Print receipt and end session" and could print the receipt without getting logged out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:54:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:54:30 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at library level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-D6tN77RDU8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #39 from Nick Clemens <nick at bywatersolutions.com> --- One more question: should these be 'opacuserjs' and 'opacusercss' in the case of implementing the same feature in the staff client? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:54:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:54:47 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-FTdwSlGo4S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow UserCSS and UserJS at |Allow specifying UserCSS |library level |and UserJS at library level | |for the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:55:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:55:37 +0000 Subject: [Koha-bugs] [Bug 33687] Clicking on a sys pref sub-menu item does not scroll to that item In-Reply-To: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33687-70-tsnhfhcB46@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150740|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150748&action=edit Bug 33687: Restore scroll to sub-tab Test plan: Go to sys prefs, click 'Enhanced Content' Click 'OverDrive', notice it doesnt scroll there Apply this patch: Do the same test plan, but notice it does scroll there, like before Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:55:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:55:41 +0000 Subject: [Koha-bugs] [Bug 33688] New: ApplyFrameworkDefaults does not work When adding a record to basket with the "from a new (empty) record" option Message-ID: <bug-33688-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33688 Bug ID: 33688 Summary: ApplyFrameworkDefaults does not work When adding a record to basket with the "from a new (empty) record" option Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: patrick.robitaille at collecto.ca QA Contact: testopia at bugs.koha-community.org Hi, It seems there is a problem with the default values ​​in the acquisition module as well. When adding a record to a basket with the "from a new (empty) record" option, the default values ​​are not added to the record according to the default grid. Was there work for this problem? currently the ApplyFrameworkDefaults system preference does not fix the problem for the acquisition module. Thanks, Patrick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:56:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:56:20 +0000 Subject: [Koha-bugs] [Bug 33687] Clicking on a sys pref sub-menu item does not scroll to that item In-Reply-To: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33687-70-G48KyBFxPF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Working as expected, fixes the regression from bug 32926 without causing further issues. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 14:57:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 12:57:12 +0000 Subject: [Koha-bugs] [Bug 32477] Hiding batch item modification columns isn't remembered correctly In-Reply-To: <bug-32477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32477-70-L20nPkiMWx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32477 Noémie Labine <noemie.labine at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine at collecto.ca --- Comment #2 from Noémie Labine <noemie.labine at collecto.ca> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:00:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:00:37 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-qhCql5jUOu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #52 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #51) > Rename asked by Tomas. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:02:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:02:42 +0000 Subject: [Koha-bugs] [Bug 33472] Error 500 when many items attached to bib record In-Reply-To: <bug-33472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33472-70-N58oaIs1Us@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33472 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33568 CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:02:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:02:42 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-bLdWkX1mS6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33472 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:04:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:04:33 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-nMzjBSXTsn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply Keywords| |rel_23_05_candidate --- Comment #27 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Please rebase ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:05:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:05:34 +0000 Subject: [Koha-bugs] [Bug 22926] Use standard columns configuration on batch item modification and delete pages In-Reply-To: <bug-22926-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22926-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22926-70-scSWCsygTY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22926 Noémie Labine <noemie.labine at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine at collecto.ca --- Comment #1 from Noémie Labine <noemie.labine at collecto.ca> --- That would be nice ! When we hide columns in batch item modification/batch item deletion, the hiddens columns will stay hidden in the next batch modification or deletion (tho currently there's a bug for that in bz32477). But when our browser cache is renewed, those choices are reinitialised and all the colums are showned. Having the choice to permanently hide some columns by adding those tool to the column configuration would save time when we always hide one or more columns. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:11:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:11:18 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-1SZyPuy0EW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:11:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:11:20 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-Mdz74p2whL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150749&action=edit Bug 33594: Only sort on title main heading This patch simply remvoes sort from all elements that are not strictly the main title Note: If multiple fields are set as sort, they are collapsed into a single entry in the {field}__sort field in the ES index. The order will be determined by the order in the marc record To test: 1 - Apply patch 2 - perl misc/search_tools/rebuild_elasticsearch -r -v 3 - Search the catalog 4 - Sort by title 5 - Confirm records are correct 6 - Add a 240 (before the 245) with subfield a 'AAAAA' 7 - Confirm sorting is not affected 8 - View record details, click 'Elasticsearch record: Show' 9 - Find 'title__sort' and confirm it looks correct (does not include AAAAA) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:11:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:11:31 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-2Taw3GacTY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- This is correct but: shouldn't we chain ->filter_by_active instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:12:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:12:17 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-KCHc0QdE4S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:14:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:14:42 +0000 Subject: [Koha-bugs] [Bug 21699] Allow circulation messages to be editable In-Reply-To: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21699-70-QhHTnhJnwI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:14:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:14:44 +0000 Subject: [Koha-bugs] [Bug 21699] Allow circulation messages to be editable In-Reply-To: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21699-70-wMIbFoMDIV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699 --- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:14:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:14:47 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-yKZR1DYSyk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:14:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:14:49 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-eVFoAlxPQB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #54 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:14:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:14:52 +0000 Subject: [Koha-bugs] [Bug 30367] Plugins: Search explodes in error when searching for specific keywords In-Reply-To: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30367-70-0LkkMIfZqk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:14:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:14:54 +0000 Subject: [Koha-bugs] [Bug 30367] Plugins: Search explodes in error when searching for specific keywords In-Reply-To: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30367-70-kWAiRciFTX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367 --- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:14:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:14:56 +0000 Subject: [Koha-bugs] [Bug 31448] Add option to re-send email receipt when UseEmailReceipts is enabled In-Reply-To: <bug-31448-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31448-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31448-70-TEqvKstzB7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:14:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:14:58 +0000 Subject: [Koha-bugs] [Bug 31448] Add option to re-send email receipt when UseEmailReceipts is enabled In-Reply-To: <bug-31448-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31448-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31448-70-twv0C7dG1i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448 --- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:00 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-96vfyf3FFF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:02 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-nSUsYgkRLa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 --- Comment #24 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:03 +0000 Subject: [Koha-bugs] [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider In-Reply-To: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32412-70-cWRodTdBgy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:05 +0000 Subject: [Koha-bugs] [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider In-Reply-To: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32412-70-82KgmrRsKp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 --- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:07 +0000 Subject: [Koha-bugs] [Bug 32701] Self checkout help page lacks required I18N JavaScript In-Reply-To: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32701-70-wcoSMFxzbi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:09 +0000 Subject: [Koha-bugs] [Bug 32701] Self checkout help page lacks required I18N JavaScript In-Reply-To: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32701-70-RCAFdoscZF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:11 +0000 Subject: [Koha-bugs] [Bug 32921] SelfCheckTimeout doesn't logout if SelfCheckReceiptPrompt modal is open In-Reply-To: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32921-70-SP4uX7AO4H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:13 +0000 Subject: [Koha-bugs] [Bug 32921] SelfCheckTimeout doesn't logout if SelfCheckReceiptPrompt modal is open In-Reply-To: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32921-70-uXrvzBT5Vr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:15 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-A4DOGy2hSq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:16 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-4Hq4lNQDjJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #53 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:17 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-ZiGPcTgY7O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150672|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150750&action=edit Bug 32911: Remove ILL partner_code config from koha-conf.xml and turn it into a system preference Preparation: 1) apply patch 2) run reset_all 3) enable ILLModule sys preference 4) install a backend (e.g. FreeForm) 5) go into system preferences and confirm that ILLPartnerCode exists and is the default inter-library loan (IL) Test plan: 1) create an ILL request 2) ensure the patron of category 'IL' has a primary e-mail configured 3) click on "place request with partners" 4) verify that the patron(s) of said category are on the partners list Upgrade test: 1) Remove the system preference from the database, run query: delete from systempreferences where variable="ILLPartnerCode"; 2) Check or edit the value or partner_code in koha-conf.xml and run atomicupdate: installer/data/mysql/updatedatabase.pl 3) Confirm the value in koha-conf.xml has been successfully migrated into the system preference, run query: select * from systempreferences where variable="ILLPartnerCode"; Optional tests: - Set a patron category in the sys pref and then delete said patron category (needs to not have patrons in it) - Check the about page -> System information and confirm the warning message is correct - Set the sys pref to the empty option - Check the about page -> System information and confirm the warning message is correct - Set the sys pref to a category that has no patrons of its type (ktd examples: Board, or Library) - Check the about page -> System information and confirm the warning message is correct Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:19 +0000 Subject: [Koha-bugs] [Bug 33197] Terminology: rename GDPR_Policy system preference In-Reply-To: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33197-70-WmJgtW1naY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33197 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:20 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-KJPmWBOVKi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150673|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150751&action=edit Bug 32911: Database update Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:21 +0000 Subject: [Koha-bugs] [Bug 33197] Terminology: rename GDPR_Policy system preference In-Reply-To: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33197-70-e2JnYnJH8i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33197 --- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:23 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-wbccJdMzg9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150674|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150752&action=edit Bug 32911: (follow-up) Move pref from Notifications to Features section The new preference appeared under Notifications, but is better suited for the Features section on the ILL tab in system preferences. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:23 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-pjO1xRrq1S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:25 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-ndWxnaMqMZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 --- Comment #32 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:27 +0000 Subject: [Koha-bugs] [Bug 33329] GET /biblios encoding wrong when UNIMARC In-Reply-To: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33329-70-8NClVM6ej8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:29 +0000 Subject: [Koha-bugs] [Bug 33329] GET /biblios encoding wrong when UNIMARC In-Reply-To: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33329-70-IsqIWlbSf5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:31 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-MnFZPyUGut@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:33 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-dAbEONtvJA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 --- Comment #23 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:35 +0000 Subject: [Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST API In-Reply-To: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33470-70-0zxwBGk6Eg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:36 +0000 Subject: [Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST API In-Reply-To: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33470-70-zORiKoRSWE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 --- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:38 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-JHaNSp1uRc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:40 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-aeUUybF5M7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #24 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:42 +0000 Subject: [Koha-bugs] [Bug 33626] compare_es_to_db.pl does not work with Search::Elasticsearch 7.0 In-Reply-To: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33626-70-OInilfS79W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33626 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:44 +0000 Subject: [Koha-bugs] [Bug 33626] compare_es_to_db.pl does not work with Search::Elasticsearch 7.0 In-Reply-To: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33626-70-wTNIYO7zWt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33626 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:46 +0000 Subject: [Koha-bugs] [Bug 33649] Fix use of cronlogaction In-Reply-To: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33649-70-kiJL5pFZIp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:15:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:15:47 +0000 Subject: [Koha-bugs] [Bug 33649] Fix use of cronlogaction In-Reply-To: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33649-70-0KXkKtlDWK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:16:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:16:48 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-2xvcDb0rWO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Discussed with Katrin, I have permission to QA some of the ILL bugs in the queue even though they're written by our team. There are few people in a position to properly review and QA ILL so she's trusting me to be unbiased. As such, this one is a pass, code works, it's a nice cleanup and the QA scripts are all happy too. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:16:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:16:54 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-tkgnxwaV2B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:17:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:17:35 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-ILO5L6Zqxr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:21:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:21:08 +0000 Subject: [Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30579-70-C4gkAd0TIN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no Status|Needs Signoff |Failed QA --- Comment #29 from Magnus Enger <magnus at libriotech.no> --- I don't think this works as intended for me. 1. When I load the page, the radio button to the right of "Hold next available item" is active/selected. - Under "Hold next available item from an item group", the dropdown and the radio button is disabled. The dropdown is "greyed out" and nothing happens if I click on either of them. - But under "Place a hold on a specific item" the dropdown for "Allowed pickup locations" is not "greyed out" and I can interact with it. I can click on the radio buttons under "Hold", and if I do, the radio button to the right of "Hold next available item" is no longer active/selected. In fact, none of the three radio buttons to the right of the headings are active/selected. 2. If i click on the radio button for "Hold next available item from an item group" - I can interact with the "Hold" radio button and the "Allowed pickup locations" dropdown under "Place a hold on a specific item". - If i click on a radio button under "Hold", then the radio button to the right of "Hold next available item from an item group" remains active/selected (this is different from what happens under 1 above). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:21:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:21:53 +0000 Subject: [Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30579-70-AT4ZeSYwco@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #30 from Magnus Enger <magnus at libriotech.no> --- PS. Tested on 112.0.5615.49 snap (64-bit) on Ubuntu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:25:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:25:45 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-yoDfPShnQn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150753&action=edit Bug 32911: (follow-up) Remove a couple of cases from tests This patch simply removes the partner_code defaults from some tests where it is no longer required. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:25:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:25:55 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-pOBF7rLwW5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:26:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:26:44 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-g8o0cTr7hO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I find it really odd that Illrequest::Config.pm has partner_code as a 'setter' as well as getter.. it's never actually used in that way, but it is tested for. I reckon we can drop that functionality at a later date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:33:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:33:01 +0000 Subject: [Koha-bugs] [Bug 31705] Option for ILL "Manage request" button to appear on left of the screen to improve accessibility In-Reply-To: <bug-31705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31705-70-Yc6reZvG6Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31705 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I think this is actually already resolved with bug 22440 too.. feel free to switch to RESOLVED if that's the case Pedro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:33:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:33:28 +0000 Subject: [Koha-bugs] [Bug 31705] Option for ILL "Manage request" button to appear on left of the screen to improve accessibility In-Reply-To: <bug-31705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31705-70-yNHAe5jy3X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31705 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22440 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:33:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:33:28 +0000 Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to server side filtering In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-MNpxByhUSW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31705 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:37:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:37:57 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-wz5ntuwPMa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #40 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Comment on attachment 150728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150728 Bug 32721: Tidy up - duplicate fetching of userjs and css Review of attachment 150728: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=32721&attachment=150728) ----------------------------------------------------------------- ::: C4/Auth.pm @@ +1364,5 @@ > + OpacCloud => C4::Context->preference("OpacCloud"), > + OpacTopissue => C4::Context->preference("OpacTopissue"), > + OpacAuthorities => C4::Context->preference("OpacAuthorities"), > + OpacBrowser => C4::Context->preference("OpacBrowser"), > + TagsEnabled => C4::Context->preference("TagsEnabled"), Were these deliberately added.. they feel like a rebase mistake to me? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:39:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:39:50 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-CWfETDN6Nn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #41 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Nick Clemens from comment #38) > One question: You add the fields to the api, do we want them? They feel like > they may be somewhat Koha specific, not needed for outside connections? Hmm, I agree.. we perhaps don't need to add them in.. instead we could map them to undef to drop them in API responses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:40:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:40:09 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-Ly65emO7Yy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #42 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Nick Clemens from comment #39) > One more question: should these be 'opacuserjs' and 'opacusercss' in the > case of implementing the same feature in the staff client? You're probably right there too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:46:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:46:29 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29453-70-pS5yHidSiq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:56:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:56:47 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-NpzEsxY14B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 15:59:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 13:59:29 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-hvfb24rX63@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:14:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:14:15 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-nYvuTtowib@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150732|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150754&action=edit Bug 32721: (QA follow-up) Add exec flag to DB update and expand tests Added tests for case of no branch specific settings and when no branch passed Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:14:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:14:18 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-p2QuzHan6y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #44 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150755&action=edit Bug 32721: (QA follow-up) Drop fields from API response Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:14:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:14:22 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-zOWH1tcARL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #45 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150756&action=edit Bug 32721: (QA follow-up) Rename fields to opac* This patch updates the field names to reflect that they're OPAC related. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:14:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:14:25 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-dmlGTdR2Xi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #46 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150757&action=edit Bug 32721: DBIC Schema update Update after field change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:14:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:14:29 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-64vI4nQqsU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #47 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150758&action=edit Bug 32721: (QA follow-up) Fix rebase errors We let some superflous template params creep back in during a rebase somewhere. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:15:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:15:03 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-HJ4tUcsltQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150163|0 |1 is obsolete| | --- Comment #28 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150759&action=edit Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:15:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:15:06 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-nw56IPLZTK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150164|0 |1 is obsolete| | --- Comment #29 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150760&action=edit Bug 33355: Update forms markup to be in line with interface patterns https://wiki.koha-community.org/wiki/Interface_patterns Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:15:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:15:09 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-sYqEG2knNP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150165|0 |1 is obsolete| | --- Comment #30 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150761&action=edit Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:15:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:15:22 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-OYF11BblVI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | Status|ASSIGNED |Passed QA --- Comment #48 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Matt's on leave at the minute, so I took care of the thoughts raised by Nick.. They all made sense to me. Back to PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:15:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:15:32 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-6obKTX1EzE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:25:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:25:03 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate 'no automatic renewal before' rule In-Reply-To: <bug-25393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25393-70-Iq3QIBI5j2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:26:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:26:37 +0000 Subject: [Koha-bugs] [Bug 31705] Option for ILL "Manage request" button to appear on left of the screen to improve accessibility In-Reply-To: <bug-31705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31705-70-AzgiyN6ZTT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31705 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |FIXED --- Comment #10 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- (In reply to Martin Renvoize from comment #9) > I think this is actually already resolved with bug 22440 too.. feel free to > switch to RESOLVED if that's the case Pedro +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:26:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:26:45 +0000 Subject: [Koha-bugs] [Bug 30299] Create a Registration API to allow for use of email verification when outside systems are registering patrons In-Reply-To: <bug-30299-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30299-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30299-70-8mZaEKQwwq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30299 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Thought from Tomas: Use X-Koha-Override -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:27:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:27:47 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-9jzZ1yPtoR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|32768 |22440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 [Bug 22440] Improve ILL page performance by moving to server side filtering https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32768 [Bug 32768] Autocomplete suggestions container should always be on top of other UI elements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:27:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:27:47 +0000 Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to server side filtering In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-SQclqb9AIL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30719 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 [Bug 30719] ILL should provide the ability to create batch requests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:27:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:27:47 +0000 Subject: [Koha-bugs] [Bug 32768] Autocomplete suggestions container should always be on top of other UI elements In-Reply-To: <bug-32768-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32768-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32768-70-yCmRspxLRt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32768 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|30719 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 [Bug 30719] ILL should provide the ability to create batch requests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:28:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:28:01 +0000 Subject: [Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities In-Reply-To: <bug-31185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31185-70-ECzKuzI9ka@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Adolfo Rodríguez Taboada <adolfo.rodriguez at xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139857|0 |1 is obsolete| | --- Comment #11 from Adolfo Rodríguez Taboada <adolfo.rodriguez at xercode.es> --- Created attachment 150762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150762&action=edit New patch version The test expectations are correct, it should report multiple matches if AutoCreateAuthorities is on as it's an issue must be dealt with no matter the value of that preference. This is an updated version of the patch that reports multiple matches in both scenarios. Thanks for the unit test! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:28:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:28:14 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-JDRfqwlRfI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32768 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32768 [Bug 32768] Autocomplete suggestions container should always be on top of other UI elements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:28:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:28:14 +0000 Subject: [Koha-bugs] [Bug 32768] Autocomplete suggestions container should always be on top of other UI elements In-Reply-To: <bug-32768-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32768-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32768-70-TEZMwAIFXG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32768 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30719 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 [Bug 30719] ILL should provide the ability to create batch requests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:29:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:29:35 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-Z5NhUFo3ni@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #44 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- New rebase on top of bug 22440 coming soon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:39:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:39:01 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29453-70-1nwBJZmSjw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:39:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:39:03 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29453-70-CkNrovZPHk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150670|0 |1 is obsolete| | Attachment #150671|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150763&action=edit Bug 29453: Add endpoints for fetching patron credits & debits This patch adds two new API endpoints for fetching a patrons credits and a patrons debits. Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Agustin Moyano <agustinmoyano at theke.io> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:39:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:39:11 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29453-70-bde4vufyn3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 --- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150764&action=edit Bug 29453: (follow-up) Add tests and fix minimum amount in credit.yaml definition Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:41:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:41:04 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-FxibnP3crb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Doh.. I missed something (that Pedro asking a question just highlighted to me) We also need to remove it from the installer configs.. i.e debian/templates and /etc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:46:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:46:59 +0000 Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31132-70-gV7qhOdUC7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:50:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:50:11 +0000 Subject: [Koha-bugs] [Bug 33013] Add age, interface and operator as additional report stats In-Reply-To: <bug-33013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33013-70-Ee6423AJZK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33013 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:52:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:52:44 +0000 Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's account In-Reply-To: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21043-70-sAdyF2NLsn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147642|0 |1 is obsolete| | Attachment #147643|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150765&action=edit Bug 21043: Add debit REST endpoint This patch adds an endpoint to create a debit for a patron. Testplan 1. Create a new account debit type (Administration > Debit types) 2. Add a fee with this debit type to a patron’s account via API 3. Make sure that this fee is shown in the accounting overview in the patron’s account in the staff interface 4. Make sure that it is possible to make a payment for this fee Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:52:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:52:52 +0000 Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's account In-Reply-To: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21043-70-88QsoFThwk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 --- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150766&action=edit Bug 21043: Handle exceptions and switch to debit response We were cheating a bit here and expecting a 'debit' to be sent in but a 'line' to be returned. We should really be sending a debit and returning a debit.. so I've update the paths schema as such and we're now coercing the Koha::Account::Line object that's returned by Koha::Account->add_debit into a Koha::Account::Debit object. Longer term it would be nice to convert returns from the various Koha::Account methods to their correct Koha::Account:: objects as apposed to them all being the base ::Line I've also added some code to catch exceptions that can be thrown by Koha::Account->add_debit and added the appropriate 400 errors into the path specs again. Finally.. I added more unit tests to prove the above Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:54:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:54:50 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29453-70-B4pc43jdt2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:56:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:56:18 +0000 Subject: [Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30579-70-7eTU0jsXMd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 16:56:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 14:56:20 +0000 Subject: [Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30579-70-Jcsx1AF6d1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148898|0 |1 is obsolete| | Attachment #149271|0 |1 is obsolete| | --- Comment #31 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150767&action=edit Bug 30579: Disentangle multi-hold and single bib forms This patch alters the structure of the hold request page to make it clear that "Hold next available", "Hold item group", and "Hold specific item" are mutually-exclusive options. While there is some duplication from this, it makes the sections easier to read and allows for more variation in the two forms To test: 1 - Find a bib with multiple items 2 - Enable item groups and item group holds in system preferences 3 - Load the records detail page 4 - Add an item group on the item groups tab 5 - Select two items and add to the group 6 - Place a hold for a patron 7 - Confirm the three levels of holds are clear 8 - Confirm checking the radio next to one disables the others 9 - Confirm you can successfully place all 3 types of holds 10 - Confirm if placing a second hold that the type is forced correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:00:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:00:07 +0000 Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's account In-Reply-To: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21043-70-f8Ma8QNYbr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:01:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:01:09 +0000 Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's account In-Reply-To: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21043-70-piw6YvUO3K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:06:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:06:11 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-nrzdJZwEQH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148481|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:09:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:09:07 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-iEO9twbgmC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 --- Comment #22 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150768&action=edit Bug 32911: (follow-up) Remove partner_code from debian and /etc koha-conf.xml files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:09:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:09:09 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-UeX8OtSVR8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 --- Comment #23 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150769&action=edit Bug 32911: (follow-up) Only move config value from koha-conf.xml if it exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:10:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:10:51 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-BeH6SLjVuW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:15 +0000 Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's account In-Reply-To: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21043-70-rB0BktmLa9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:17 +0000 Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's account In-Reply-To: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21043-70-elTVVVyBck@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 --- Comment #24 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:20 +0000 Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23924-70-523qUhQo5i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:22 +0000 Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23924-70-BteHb0zGHW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924 --- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:24 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29453-70-Rj1RuJ8ClA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:26 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29453-70-apKCw3Y1IE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 --- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:28 +0000 Subject: [Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set In-Reply-To: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31405-70-myU15MwjTw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:30 +0000 Subject: [Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set In-Reply-To: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31405-70-TFzWUzdHX4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:33 +0000 Subject: [Koha-bugs] [Bug 31410] Set focus for cursor to Server name when adding a new Z39.50 or SRU server In-Reply-To: <bug-31410-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31410-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31410-70-jbfLKieFe7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31410 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:35 +0000 Subject: [Koha-bugs] [Bug 31410] Set focus for cursor to Server name when adding a new Z39.50 or SRU server In-Reply-To: <bug-31410-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31410-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31410-70-5vSrpqK1Oz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31410 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:37 +0000 Subject: [Koha-bugs] [Bug 31796] REST API: PUT endpoint for Authorities In-Reply-To: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31796-70-RE0yuNwoCG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:39 +0000 Subject: [Koha-bugs] [Bug 31796] REST API: PUT endpoint for Authorities In-Reply-To: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31796-70-6KZgXdtQBs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:41 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-TmPKwkGteK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:43 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-1mnT0JX80Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 --- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:44 +0000 Subject: [Koha-bugs] [Bug 32990] Possible deadlock in C4::ImportBatch::_update_batch_record_counts In-Reply-To: <bug-32990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32990-70-Jb4Z1nnG8v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32990 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:46 +0000 Subject: [Koha-bugs] [Bug 32990] Possible deadlock in C4::ImportBatch::_update_batch_record_counts In-Reply-To: <bug-32990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32990-70-Kerd4kSk2V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32990 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:49 +0000 Subject: [Koha-bugs] [Bug 33196] Terminology: rephrase Pseudonymization system preference to be more general In-Reply-To: <bug-33196-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33196-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33196-70-NHDijOuYEW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33196 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:50 +0000 Subject: [Koha-bugs] [Bug 33196] Terminology: rephrase Pseudonymization system preference to be more general In-Reply-To: <bug-33196-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33196-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33196-70-oCIbZpET47@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33196 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:53 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-XnOKJZPlFU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:55 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-d3eI0nbF3N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 --- Comment #31 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:57 +0000 Subject: [Koha-bugs] [Bug 33596] Merge result page is missing page-section In-Reply-To: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33596-70-keJxy7TCSU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33596 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:14:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:14:59 +0000 Subject: [Koha-bugs] [Bug 33596] Merge result page is missing page-section In-Reply-To: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33596-70-acQhoAblic@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33596 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:15:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:15:01 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-wHZVK1VLL6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:15:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:15:03 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-uDXNdVkBad@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 --- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:15:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:15:05 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33631-70-9SZ7rluVj5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:15:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:15:08 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33631-70-53BhIKpAAO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:20:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:20:28 +0000 Subject: [Koha-bugs] [Bug 33676] Recognise documentation submissions on the about page In-Reply-To: <bug-33676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33676-70-Gj2Ic7griZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33676 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I'm not sure how it would work either, keeping in mind that we are very late compared to the Koha cycle. Most things being worked on in the manual right now are for 22.11. But I think the About page is created upon release? I doubt there was any manual submission to the 22.11 manual back in november. Should we then just keep a list of names, regardless of version? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:21:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:21:47 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-K9Q7T6bs1a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:25:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:25:32 +0000 Subject: [Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout) In-Reply-To: <bug-22322-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22322-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22322-70-dsfHwFywkm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Hinemoea Viault <hinemoea.viault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143764|0 |1 is obsolete| | --- Comment #9 from Hinemoea Viault <hinemoea.viault at inlibro.com> --- Created attachment 150770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150770&action=edit Bug 22322: Fix QA issues This patch fixes following QA issues: - Add missing filters - Use dt_from_string instead of DateTime->now in sco-main.pl Following issue is left unchanged, since it is purposeful: forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:27:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:27:23 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31798-70-ozvfbJs2fb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:27:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:27:25 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31798-70-cpMZhMYZpK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150598|0 |1 is obsolete| | Attachment #150599|0 |1 is obsolete| | Attachment #150600|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150771&action=edit Bug 31798: Add REST endpoint to add a biblio's item To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Get a biblio 4. Make a POST request to /api/v1/biblios/:biblio_id/items with a json body that represents the new item 5. Check that the item is created 6. Sign off Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:38:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:38:41 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31798-70-LMSkMYHnuz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150771|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150772&action=edit Bug 31798: Add REST endpoint to add a biblio's item To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Get a biblio 4. Make a POST request to /api/v1/biblios/:biblio_id/items with a json body that represents the new item 5. Check that the item is created 6. Sign off Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:38:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:38:48 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31798-70-5KlhZGB6ON@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 --- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150773&action=edit Bug 31798: (follow-up) Tidy up and add duplicate barcode test Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:38:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:38:50 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31798-70-Wua503T9FW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 --- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150774&action=edit Bug 31798: (follow-up) Handle all values of autoBarcode Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:38:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:38:52 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31798-70-AX5eB1J4nS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 --- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150775&action=edit Bug 31798: (QA follow-up) Remove use Koha::Item, we already use Koha::Items Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:41:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:41:26 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-MD0UAkVp18@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://gitlab.com/mrenvoiz |https://github.com/PTFS-Eur |e/Koha/-/tree/bug_30979 |ope/koha/tree/bug_30979_reb | |ased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:46:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:46:11 +0000 Subject: [Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout) In-Reply-To: <bug-22322-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22322-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22322-70-Qa3ysy9W80@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Hinemoea Viault <hinemoea.viault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150770|0 |1 is obsolete| | --- Comment #10 from Hinemoea Viault <hinemoea.viault at inlibro.com> --- Created attachment 150776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150776&action=edit Bug 22322: Fix QA issues This patch fixes following QA issues: - Add missing filters - Use dt_from_string instead of DateTime->now in sco-main.pl Following issue is left unchanged, since it is purposeful: forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error Sponsored-by: Koha-Suomi Oy Signed-off-by: hinemoea <hinemoea at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 17:56:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 15:56:20 +0000 Subject: [Koha-bugs] [Bug 33689] New: No confirmation when deleting a search filter Message-ID: <bug-33689-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33689 Bug ID: 33689 Summary: No confirmation when deleting a search filter Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com To recreate: 1. Enable SavedSearchFilters 2. Go to advanced search and search for anything 3. Click 'Save as search filter' 4. Check 'Show in OPAC' and 'Show in staff interface' 5. Name the filter 6. Click 'Save' 7. Go to Administration > Search filters 8. Click 'Delete' --> The filter is automatically deleted, no confirmation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:24:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 16:24:23 +0000 Subject: [Koha-bugs] [Bug 33690] New: Add ability to send welcome notice when creating patrons using the REST API Message-ID: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 Bug ID: 33690 Summary: Add ability to send welcome notice when creating patrons using the REST API Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com CC: tomascohen at gmail.com As an addition/alternative to Bug 30299, it would be nice to have the ability to send a welcome notice when creating patrons via the API. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:24:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 16:24:29 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33690-70-DYaUj41fIN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:27:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 16:27:13 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33690-70-2fl5PIPwSb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:27:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 16:27:14 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33690-70-jUFX29zxWM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150777&action=edit Bug 33690: Add ability to send welcome notice when creating patrons using the REST API It would be nice to have the ability to send a welcome notice when creating patrons via the API. Test Plan: 1) Apply this patch 2) Ensure you have a WELCOME notice 3) Create a new patron using the REST API ( api/v1/patrons ) 4) Note no welcome notice is sent to the patron ( you can check the notices tab for the patron ) 5) Repeat step 3, but send the header X-Koha-SendWelcomeEmail with a value of 1 as part of the POST 6) Note the welcome message for the patron is in their notices! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:28:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 16:28:41 +0000 Subject: [Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods In-Reply-To: <bug-32476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32476-70-YynWUwzl6N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476 --- Comment #23 from David Gustafsson <glasklas at gmail.com> --- (In reply to Jonathan Druart from comment #22) > Did you identify where they (is_expired and has_overdues) would be called > extensively? > > Did you benchmark your patches? > > I can easily imagine a scenario where it would bring hard to detect > side-effects: > * check if a patron can check an item out > => yes, cache "yes" > * check the item out > * check if the patron can check an other item out > => Get "yes" from cache Yes, I did, the main culprits are CanBookBeRenewed and _CanBookBeAutoRenewed since there are cases where these are called for each issue of a patron, accessing is_expired and has_overdues. For patrons with hundreds of issues the cost adds up to about 3-4% of the total execution time. It might not sound like much, but when applying some other perforamce fixes like bug 31735 and bug 32496 I think it's more like 6-8% (though I have not run that particular benchmark). Looking at the patch again I see that there are cached called being made in some other subs where the benefit is neglectable to non existent (like AddRenewal and AddReturn, CanBookBeIssued), that are mostly called once or a few times, so I removed the cached calls in those cases. There are to my understanding no cases in the current code base where this patch could cause issues, and if you where to write a script to produce a similar case you are describing one would explicitly have to call has_overdues with the {cache => 1} argument after for example calling AddReturn for a delayed item. Now that AddReturn no longer used the has_overdues the cache is cleared on returns, so even if one where to do that you would not get a stale value. But you where correct in pointing out that more care should be taken where caching is used, so disabling it for subroutines which are in no need of optimization makes total sense, and instead expiring the cache in those cases minimize the risk of future bugs are introduced as a result of stale cache values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:31:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 16:31:48 +0000 Subject: [Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods In-Reply-To: <bug-32476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32476-70-zarTfCtWnz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147145|0 |1 is obsolete| | --- Comment #24 from David Gustafsson <glasklas at gmail.com> --- Created attachment 150778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150778&action=edit Bug 32476: Add caching for relatively expensive patron methods To test: 1) Ensure tests in t/db_dependant/Koha/Patrons.t all pass Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 18:42:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 16:42:22 +0000 Subject: [Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods In-Reply-To: <bug-32476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32476-70-Vbg9whUeEP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150778|0 |1 is obsolete| | --- Comment #25 from David Gustafsson <glasklas at gmail.com> --- Created attachment 150779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150779&action=edit Bug 32476: Add caching for relatively expensive patron methods To test: 1) Ensure tests in t/db_dependant/Koha/Patrons.t all pass Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 19:19:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 17:19:03 +0000 Subject: [Koha-bugs] [Bug 30024] link_bibs_to_authorities.pl relies on CatalogModuleRelink In-Reply-To: <bug-30024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30024-70-xzQBNEmpqB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30024 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil at chetcolibrary.org --- Comment #6 from Phil Ringnalda <phil at chetcolibrary.org> --- Testing notes (with ktd): You can't just run link_bibs_to_authorities.pl, since bib 369 is unparseable and crashes it. Instead you have to find a single bib to run against with, e.g., --bib-limit=biblionumber=16 You can't relink anything but 6xx headings without bug 33277 Test plan: 1. Set the preferences AutoLinkBiblios and CatalogModuleRelink to "Don't" so you can cause something to be mislinked, set LinkerRelink to "Do" (those are all default values) and set EnableAdvancedCatalogingEditor to "Enable." 2. Load http://127.0.0.1:8081/cgi-bin/koha/cataloguing/editor.pl#catalog/16 and change subfield 9 for one of the subjects to a recognizably wrong value like 999999 and save, ensuring that it didn't get automatically relinked 3. misc/link_bibs_to_authorities.pl --bib-limit=biblionumber=16 should list "Number of bibs modified: 0" because CatalogModuleRelink is still "Don't" 4. Switch CatalogModuleRelink to "Do", misc/link_bibs_to_authorities.pl --bib-limit=biblionumber=16 should list "Number of bibs modified: 1" and reloading http://127.0.0.1:8081/cgi-bin/koha/cataloguing/editor.pl#catalog/16 should show the 999999 replaced with the correct authid 5. Apply patch, restart 6. Redo Step 1 and 2. 7. misc/link_bibs_to_authorities.pl --bib-limit=biblionumber=16 should list "Number of bibs modified: 1" and reloading http://127.0.0.1:8081/cgi-bin/koha/cataloguing/editor.pl#catalog/16 should show the 999999 replaced with the correct authid when you have CatalogModuleRelink at "Don't" and LinkerRelink at "Do". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 19:19:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 17:19:46 +0000 Subject: [Koha-bugs] [Bug 30024] link_bibs_to_authorities.pl relies on CatalogModuleRelink In-Reply-To: <bug-30024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30024-70-lTNnOuOrv7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30024 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 19:19:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 17:19:48 +0000 Subject: [Koha-bugs] [Bug 30024] link_bibs_to_authorities.pl relies on CatalogModuleRelink In-Reply-To: <bug-30024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30024-70-HPg525hxh9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30024 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141038|0 |1 is obsolete| | --- Comment #7 from Phil Ringnalda <phil at chetcolibrary.org> --- Created attachment 150780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150780&action=edit Bug 30024: Make link_bibs_to_authorities.pl rely on LinkerRelink This patch makes the trivial change of making the linker script rely on LinkerRelink instead of CatalogModuleRelink, which is confusing and incorrect (according to both sysprefs descriptions). To test: 1. Verify that relinking is now tied to the right syspref Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 19:28:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 17:28:09 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-JZAb6slGHB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 --- Comment #26 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 150781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150781&action=edit Bug 33117: New System Preference PatronAutoCompleteSearchMethod WIP - NOT READY FOR TESTING -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 19:45:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 17:45:12 +0000 Subject: [Koha-bugs] [Bug 33673] Global system preferences - change to just system preferences In-Reply-To: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33673-70-F2xePZTlb9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673 --- Comment #5 from David Nind <david at davidnind.com> --- (In reply to Magnus Enger from comment #4) > (In reply to David Nind from comment #2) > > This is the first time I've done a database update - hopefully I got it > > right! > > Works nicely as far as I can see. Well done! :-) Thanks Magnus! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 19:51:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 17:51:17 +0000 Subject: [Koha-bugs] [Bug 33691] New: Improve query for do_check_for_previous_checkout Message-ID: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33691 Bug ID: 33691 Summary: Improve query for do_check_for_previous_checkout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org do_check_for_previous_checkout will pass a list of itemnumbers as part of the query. This could be hundreds of items or more. It makes sense to check by biblionumber instead when possible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 19:52:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 17:52:48 +0000 Subject: [Koha-bugs] [Bug 33691] Improve query for do_check_for_previous_checkout In-Reply-To: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33691-70-vlciU1S3pc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33691 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 19:52:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 17:52:50 +0000 Subject: [Koha-bugs] [Bug 33691] Improve query for do_check_for_previous_checkout In-Reply-To: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33691-70-VjUBIISaG5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33691 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150782&action=edit Bug 33691: Improve query for do_check_for_previous_checkout do_check_for_previous_checkout will pass a list of itemnumbers as part of the query. This could be hundreds of items or more. It makes sense to check by biblionumber instead when possible. Test Plan: 1) prove t/db_dependent/Patron/Borrower_PrevCheckout.t 2) Apply this patch 3) prove t/db_dependent/Patron/Borrower_PrevCheckout.t 4) Test still pass! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 19:57:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 17:57:26 +0000 Subject: [Koha-bugs] [Bug 33691] Improve query for do_check_for_previous_checkout In-Reply-To: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33691-70-l6HaFpFTiq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33691 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150782|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150783&action=edit Bug 33691: Improve query for do_check_for_previous_checkout do_check_for_previous_checkout will pass a list of itemnumbers as part of the query. This could be hundreds of items or more. It makes sense to check by biblionumber instead when possible. Test Plan: 1) prove t/db_dependent/Patron/Borrower_PrevCheckout.t 2) Apply this patch 3) prove t/db_dependent/Patron/Borrower_PrevCheckout.t 4) Test still pass! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 19:58:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 17:58:20 +0000 Subject: [Koha-bugs] [Bug 33691] Improve query for do_check_for_previous_checkout In-Reply-To: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33691-70-rORKm2ajZ0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33691 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150783|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150784&action=edit Bug 33691: Improve query for do_check_for_previous_checkout do_check_for_previous_checkout will pass a list of itemnumbers as part of the query. This could be hundreds of items or more. It makes sense to check by biblionumber instead when possible. Test Plan: 1) prove t/db_dependent/Patron/Borrower_PrevCheckout.t 2) Apply this patch 3) prove t/db_dependent/Patron/Borrower_PrevCheckout.t 4) Test still pass! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 19:59:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 17:59:05 +0000 Subject: [Koha-bugs] [Bug 33691] Improve query for do_check_for_previous_checkout In-Reply-To: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33691-70-z9Y28WMERR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33691 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150784|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150785&action=edit Bug 33691: Improve query for do_check_for_previous_checkout do_check_for_previous_checkout will pass a list of itemnumbers as part of the query. This could be hundreds of items or more. It makes sense to check by biblionumber instead when possible. Test Plan: 1) prove t/db_dependent/Patron/Borrower_PrevCheckout.t 2) Apply this patch 3) prove t/db_dependent/Patron/Borrower_PrevCheckout.t 4) Test still pass! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:25:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:25:03 +0000 Subject: [Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30579-70-200bdNJyIc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Hinemoea Viault <hinemoea.viault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150767|0 |1 is obsolete| | --- Comment #32 from Hinemoea Viault <hinemoea.viault at inlibro.com> --- Created attachment 150786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150786&action=edit Bug 30579: Disentangle multi-hold and single bib forms This patch alters the structure of the hold request page to make it clear that "Hold next available", "Hold item group", and "Hold specific item" are mutually-exclusive options. While there is some duplication from this, it makes the sections easier to read and allows for more variation in the two forms To test: 1 - Find a bib with multiple items 2 - Enable item groups and item group holds in system preferences 3 - Load the records detail page 4 - Add an item group on the item groups tab 5 - Select two items and add to the group 6 - Place a hold for a patron 7 - Confirm the three levels of holds are clear 8 - Confirm checking the radio next to one disables the others 9 - Confirm you can successfully place all 3 types of holds 10 - Confirm if placing a second hold that the type is forced correctly Signed-off-by: Hinemoea Viault <hinemoea.viault at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:31:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:31:51 +0000 Subject: [Koha-bugs] [Bug 30871] Make it clear that 008 Type of Material is controlled by Leader 6th position in MARC21 In-Reply-To: <bug-30871-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30871-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30871-70-xVA7AoYB2n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30871 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/678 CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:33:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:33:33 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15348-70-lrd9GYfNNd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:33:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:33:34 +0000 Subject: [Koha-bugs] [Bug 32504] Empty column name, misaligning visibility, and export for basket/orders in table settings In-Reply-To: <bug-32504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32504-70-yUPTotHZmO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32504 Bug 32504 depends on bug 15348, which changed state. Bug 15348 Summary: Change/Edit estimated delivery date per order line https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:35:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:35:26 +0000 Subject: [Koha-bugs] [Bug 30901] Add template method to be able to look up renewal data in Koha slips and notices In-Reply-To: <bug-30901-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30901-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30901-70-MJs37v1bWE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://wiki.koha-community submission| |.org/wiki/Notices_with_Temp | |late_Toolkit#Example:_Circu | |lationRules.Renewals CC| |caroline.cyr-la-rose at inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:35:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:35:26 +0000 Subject: [Koha-bugs] [Bug 31048] Add information about remaining renewals to sample RENEWAL notice In-Reply-To: <bug-31048-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31048-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31048-70-6Zuc0sPgFO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31048 Bug 31048 depends on bug 30901, which changed state. Bug 30901 Summary: Add template method to be able to look up renewal data in Koha slips and notices https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:37:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:37:04 +0000 Subject: [Koha-bugs] [Bug 30612] Add account_lines method to Koha::[Old::]Checkout In-Reply-To: <bug-30612-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30612-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30612-70-78g0DxBUK3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #17 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Not sure what needs to be documented here. Closing, but feel free to reopen with details if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:37:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:37:20 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31378-70-6zAbZ2Je2W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:37:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:37:22 +0000 Subject: [Koha-bugs] [Bug 31851] Allow prioritizing identity providers In-Reply-To: <bug-31851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31851-70-417QbzeFr0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31851 Bug 31851 depends on bug 31378, which changed state. Bug 31378 Summary: Add a generic OAuth2/OIDC client implementation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:37:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:37:22 +0000 Subject: [Koha-bugs] [Bug 31900] Add support for logout from external OAuth2/OIDC identity providers In-Reply-To: <bug-31900-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31900-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31900-70-8vynMLWLVO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31900 Bug 31900 depends on bug 31378, which changed state. Bug 31378 Summary: Add a generic OAuth2/OIDC client implementation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:37:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:37:22 +0000 Subject: [Koha-bugs] [Bug 32133] Streamline OIDC error messages In-Reply-To: <bug-32133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32133-70-u7kVxuNglv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32133 Bug 32133 depends on bug 31378, which changed state. Bug 31378 Summary: Add a generic OAuth2/OIDC client implementation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:37:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:37:22 +0000 Subject: [Koha-bugs] [Bug 32138] OIDC client uses backwards default mapping In-Reply-To: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32138-70-jF9R8lR66I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138 Bug 32138 depends on bug 31378, which changed state. Bug 31378 Summary: Add a generic OAuth2/OIDC client implementation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:37:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:37:23 +0000 Subject: [Koha-bugs] [Bug 32139] "Update on login" setting not set when creating domain from new IdP page In-Reply-To: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32139-70-GfaxoC85k6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32139 Bug 32139 depends on bug 31378, which changed state. Bug 31378 Summary: Add a generic OAuth2/OIDC client implementation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:37:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:37:23 +0000 Subject: [Koha-bugs] [Bug 32141] New and edit identity provider UIs inconsistent In-Reply-To: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32141-70-zjxOZW4GKB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 Bug 32141 depends on bug 31378, which changed state. Bug 31378 Summary: Add a generic OAuth2/OIDC client implementation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:37:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:37:23 +0000 Subject: [Koha-bugs] [Bug 33517] Add support for extended attributes mapping on IdP config In-Reply-To: <bug-33517-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33517-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33517-70-HMNtCpi74u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33517 Bug 33517 depends on bug 31378, which changed state. Bug 31378 Summary: Add a generic OAuth2/OIDC client implementation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:37:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:37:24 +0000 Subject: [Koha-bugs] [Bug 33518] Inconsistent breadcrumbs in IdP pages In-Reply-To: <bug-33518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33518-70-OtVUBtJcYQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33518 Bug 33518 depends on bug 31378, which changed state. Bug 31378 Summary: Add a generic OAuth2/OIDC client implementation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:37:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:37:24 +0000 Subject: [Koha-bugs] [Bug 32354] Handle session_state param given by OAuth identity provider In-Reply-To: <bug-32354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32354-70-cOuTyz7WLA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354 Bug 32354 depends on bug 31378, which changed state. Bug 31378 Summary: Add a generic OAuth2/OIDC client implementation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:37:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:37:24 +0000 Subject: [Koha-bugs] [Bug 32140] Sessions created using the OIDC/OAuth2 client use an "api" interface rather than "intranet" or "opac" In-Reply-To: <bug-32140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32140-70-iahrp7FeUM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32140 Bug 32140 depends on bug 31378, which changed state. Bug 31378 Summary: Add a generic OAuth2/OIDC client implementation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:38:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:38:35 +0000 Subject: [Koha-bugs] [Bug 30337] Holds to pull ( pendingreserves.pl ) ignores holds if priority 1 hold is suspended In-Reply-To: <bug-30337-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30337-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30337-70-653iN7Ebse@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30337 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- This seems like a bug fix, nothing to add to the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:42:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:42:57 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31798-70-MYZu5mRgsC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:42:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:42:59 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31798-70-YDqr4CzBSX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 --- Comment #26 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:43:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:43:01 +0000 Subject: [Koha-bugs] [Bug 33053] Tables item_groups and recalls have a biblio_id column with a default of 0 In-Reply-To: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33053-70-cN5ubFtpaf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33053 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:43:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:43:04 +0000 Subject: [Koha-bugs] [Bug 33053] Tables item_groups and recalls have a biblio_id column with a default of 0 In-Reply-To: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33053-70-lnuoXmX84n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33053 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:43:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:43:05 +0000 Subject: [Koha-bugs] [Bug 33102] Cart in OPAC and staff interface does no longer display infos from biblioitems table In-Reply-To: <bug-33102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33102-70-wqcRxwvUmC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33102 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:43:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:43:07 +0000 Subject: [Koha-bugs] [Bug 33102] Cart in OPAC and staff interface does no longer display infos from biblioitems table In-Reply-To: <bug-33102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33102-70-fMmOfBfFps@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33102 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:43:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:43:09 +0000 Subject: [Koha-bugs] [Bug 33233] OPAC advanced search inputs stay disabled when using browser's back button In-Reply-To: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33233-70-84tzSAoyCZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:43:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:43:11 +0000 Subject: [Koha-bugs] [Bug 33233] OPAC advanced search inputs stay disabled when using browser's back button In-Reply-To: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33233-70-71jM1rWAW6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:43:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:43:13 +0000 Subject: [Koha-bugs] [Bug 33532] Catalog concerns - Title of the page says Tools instead of Cataloging In-Reply-To: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33532-70-iJPAYyDcYU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33532 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:43:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:43:14 +0000 Subject: [Koha-bugs] [Bug 33532] Catalog concerns - Title of the page says Tools instead of Cataloging In-Reply-To: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33532-70-NsBBF9cjSn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33532 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:43:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:43:16 +0000 Subject: [Koha-bugs] [Bug 33582] Use template wrapper for breadcrumbs: Tools, part 4 In-Reply-To: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33582-70-iFTXP2jGng@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33582 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:43:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:43:18 +0000 Subject: [Koha-bugs] [Bug 33582] Use template wrapper for breadcrumbs: Tools, part 4 In-Reply-To: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33582-70-RR6XVrhr0k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33582 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:43:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:43:20 +0000 Subject: [Koha-bugs] [Bug 33637] Batch patron modification broken In-Reply-To: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33637-70-1AiktvutnR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:43:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:43:22 +0000 Subject: [Koha-bugs] [Bug 33637] Batch patron modification broken In-Reply-To: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33637-70-bZG7DiaHCp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:43:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:43:23 +0000 Subject: [Koha-bugs] [Bug 33645] koha-foreach always returns 1 if --chdir not specified In-Reply-To: <bug-33645-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33645-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33645-70-lgM3KNtZ5H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33645 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:43:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:43:25 +0000 Subject: [Koha-bugs] [Bug 33645] koha-foreach always returns 1 if --chdir not specified In-Reply-To: <bug-33645-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33645-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33645-70-b60UcawMqP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33645 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:50:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:50:15 +0000 Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation history In-Reply-To: <bug-21381-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21381-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21381-70-78pRLnRjXl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/678 | |https://gitlab.com/koha-com | |munity/koha-manual/-/merge_ | |requests/605 Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:50:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:50:16 +0000 Subject: [Koha-bugs] [Bug 18080] OMNIBUS: Circulation history UI improvements In-Reply-To: <bug-18080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18080-70-gaRdiwX9gk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18080 Bug 18080 depends on bug 21381, which changed state. Bug 21381 Summary: Add serial enumeration to circulation history https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:51:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:51:14 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33690-70-EuA3KQL6wn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150777|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150787&action=edit Bug 33690: Add ability to send welcome notice when creating patrons using the REST API It would be nice to have the ability to send a welcome notice when creating patrons via the API. Test Plan: 1) Apply this patch 2) Ensure you have a WELCOME notice 3) Create a new patron using the REST API ( api/v1/patrons ) 4) Note no welcome notice is sent to the patron ( you can check the notices tab for the patron ) 5) Repeat step 3, but send the header X-Koha-SendWelcomeEmail with a value of 1 as part of the POST 6) Note the welcome message for the patron is in their notices! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:54:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:54:33 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: <bug-20262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20262-70-Dz85I8CaAm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/667 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:57:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:57:20 +0000 Subject: [Koha-bugs] [Bug 7021] Add patron category to the statistics table In-Reply-To: <bug-7021-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7021-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7021-70-OurTPhy2kN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose at inlibr | |o.com Status|Needs documenting |RESOLVED --- Comment #61 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Not sure what needs documenting here. It seems like backend stuff. Closing, but feel free to reopen with details if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:57:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:57:21 +0000 Subject: [Koha-bugs] [Bug 22794] [Omnibus] Improve and extend logging in Koha In-Reply-To: <bug-22794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22794-70-zHJkmsCuWZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Bug 22794 depends on bug 7021, which changed state. Bug 7021 Summary: Add patron category to the statistics table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 20:59:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 18:59:07 +0000 Subject: [Koha-bugs] [Bug 32391] [DOCS] Reorganise the manual contents In-Reply-To: <bug-32391-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32391-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32391-70-RQJJoypPaZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32391 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon at ptfs-europe. | |com --- Comment #4 from David Nind <david at davidnind.com> --- I've asked for feedback on the proposed contents on the development list - will ask on the main list after I've incorporated any feedback and discussed further with the Documentation Team. Link to message: https://lists.koha-community.org/pipermail/koha-devel/2023-May/048138.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:05:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:05:43 +0000 Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to server side filtering In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-I8LwqlE7Pk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 150788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150788&action=edit Bug 22440: (follow-up) Nothing is forever This patch picks (yet) another class for testing purposes. The class needs to not implement to_api() and to_api_mapping(). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:09:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:09:00 +0000 Subject: [Koha-bugs] [Bug 31854] Document conflict with delete_patrons.pl --not_borrowed_since and anonymization In-Reply-To: <bug-31854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31854-70-rPgE1WWP2Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31854 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/678 CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:23:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:23:13 +0000 Subject: [Koha-bugs] [Bug 33649] Fix use of cronlogaction In-Reply-To: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33649-70-Mpnq1m7zif@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Bug 33649 depends on bug 31203, which changed state. Bug 31203 Summary: Cronjobs should log completion as well as logging begin https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:23:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:23:12 +0000 Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin In-Reply-To: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31203-70-EeqeuvdpmB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/678 Resolution|--- |FIXED CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:26:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:26:39 +0000 Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to server side filtering In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-sYF1Eb9jYn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 150789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150789&action=edit Bug 22440: (follow-up) Fix existing tests As we are introducing a FK for illrequests.biblio_id, TestBuilder is generating a linked biblio, and so tests expecting undef are failing. This fixes it by explicitly setting biblio_id => undef on creating the request. The patch also cleans the area a bit, removing a redundant and fragile test as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:28:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:28:59 +0000 Subject: [Koha-bugs] [Bug 24865] Customize the accountlines description In-Reply-To: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24865-70-ypnKpxGMz0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:29:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:29:00 +0000 Subject: [Koha-bugs] [Bug 31170] Capitalization: Overdue Item Fine Description In-Reply-To: <bug-31170-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31170-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31170-70-vUYWx5b6JG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31170 Bug 31170 depends on bug 24865, which changed state. Bug 24865 Summary: Customize the accountlines description https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:31:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:31:06 +0000 Subject: [Koha-bugs] [Bug 31963] Only show hold fee message on OPAC and charge hold fee if HoldFeeMode conditions are true as described in the system preference In-Reply-To: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31963-70-a88E8O3lyG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- This seems like a bug fix, nothing to add to the manual. Closing, but feel free to reopen with details if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:31:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:31:07 +0000 Subject: [Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are checked out OR the record has at least one hold already" In-Reply-To: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32142-70-ixNHJIXr4d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142 Bug 32142 depends on bug 31963, which changed state. Bug 31963 Summary: Only show hold fee message on OPAC and charge hold fee if HoldFeeMode conditions are true as described in the system preference https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:34:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:34:16 +0000 Subject: [Koha-bugs] [Bug 25449] Make itemtype mandatory by default In-Reply-To: <bug-25449-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25449-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25449-70-ptFQJArnmN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #20 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Manual already said it was required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:36:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:36:38 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: <bug-27421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27421-70-mqBuvYVUSG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #101 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Already in the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:36:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:36:39 +0000 Subject: [Koha-bugs] [Bug 31580] Review Koha::BackgroundJob->finish and 'failed' case workflow In-Reply-To: <bug-31580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31580-70-fuyS36KX8I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31580 Bug 31580 depends on bug 27421, which changed state. Bug 27421 Summary: Porting tools/stage-marc-import.pl to BackgroundJob https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:36:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:36:39 +0000 Subject: [Koha-bugs] [Bug 31711] When creating order lines "From a new file" you are no longer redirected to acq after import In-Reply-To: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31711-70-JvLMLg0hAK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711 Bug 31711 depends on bug 27421, which changed state. Bug 27421 Summary: Porting tools/stage-marc-import.pl to BackgroundJob https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:36:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:36:40 +0000 Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results" with clear link to manage staged batch In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31891-70-AhNecweMB6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891 Bug 31891 depends on bug 27421, which changed state. Bug 27421 Summary: Porting tools/stage-marc-import.pl to BackgroundJob https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:36:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:36:40 +0000 Subject: [Koha-bugs] [Bug 31992] t::lib::Mocks::Zebra still using old stage for import page In-Reply-To: <bug-31992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31992-70-kLDHtoHpjZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 Bug 31992 depends on bug 27421, which changed state. Bug 27421 Summary: Porting tools/stage-marc-import.pl to BackgroundJob https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:36:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:36:40 +0000 Subject: [Koha-bugs] [Bug 32780] t/db_dependent/Koha/BackgroundJobs must be moved to t/db_dependent/Koha/BackgroundJob In-Reply-To: <bug-32780-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32780-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32780-70-XgVjdjGxEG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32780 Bug 32780 depends on bug 27421, which changed state. Bug 27421 Summary: Porting tools/stage-marc-import.pl to BackgroundJob https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:36:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:36:41 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-NYyjdHcv6E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 Bug 33576 depends on bug 27421, which changed state. Bug 27421 Summary: Porting tools/stage-marc-import.pl to BackgroundJob https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:37:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:37:48 +0000 Subject: [Koha-bugs] [Bug 31626] Add letter ID to the message queue table In-Reply-To: <bug-31626-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31626-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31626-70-KfbqF9lvdF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31626 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #14 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Not sure what needs documenting, seems to be only backend stuff. Closing, but feel free to reopen with details if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:37:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:37:49 +0000 Subject: [Koha-bugs] [Bug 31627] Add ability to embed the letter ID in outgoing email notices In-Reply-To: <bug-31627-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31627-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31627-70-6Aj2eU2RJt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Bug 31627 depends on bug 31626, which changed state. Bug 31626 Summary: Add letter ID to the message queue table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31626 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:53:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:53:31 +0000 Subject: [Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level In-Reply-To: <bug-26689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26689-70-eL3jwn2keS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/678 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:53:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:53:32 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24381-70-BKx92FABuZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Bug 24381 depends on bug 26689, which changed state. Bug 26689 Summary: Monetary accounts notices should be definable at the credit_type/debit_type level https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:53:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:53:40 +0000 Subject: [Koha-bugs] [Bug 33692] New: stage-marc-import.pl does not work regular when importing marc files Message-ID: <bug-33692-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33692 Bug ID: 33692 Summary: stage-marc-import.pl does not work regular when importing marc files Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: mengu at devinim.com.tr QA Contact: testopia at bugs.koha-community.org stage-marc-import.pl does not work when importing marc files. Problem is on the line 93 of the file If we change the $overlay_framework = undef if $overlay_framework = '_USE_ORIG'; to $overlay_framework = undef if ($overlay_framework == '_USE_ORIG'); will solve the issue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:55:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:55:55 +0000 Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices In-Reply-To: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19966-70-pNc6pWd6gI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #26 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Not sure what needs documenting, seems like backend stuff. Feel free to enlighten me, if needed :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 21:55:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 19:55:56 +0000 Subject: [Koha-bugs] [Bug 30751] Print autorenewal notice to console when running in verbose. In-Reply-To: <bug-30751-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30751-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30751-70-02YdMC3m8S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30751 Bug 30751 depends on bug 19966, which changed state. Bug 19966 Summary: Add ability to pass objects directly to slips and notices https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:27:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 20:27:36 +0000 Subject: [Koha-bugs] [Bug 33692] stage-marc-import.pl does not work regular when importing marc files In-Reply-To: <bug-33692-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33692-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33692-70-gtdKkAnsyM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33692 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |phil at chetcolibrary.org Resolution|--- |DUPLICATE --- Comment #1 from Phil Ringnalda <phil at chetcolibrary.org> --- *** This bug has been marked as a duplicate of bug 33342 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:27:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 20:27:36 +0000 Subject: [Koha-bugs] [Bug 33342] Fix framework handling in manage-marc-import.pl In-Reply-To: <bug-33342-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33342-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33342-70-FxrvpGndie@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33342 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mengu at devinim.com.tr --- Comment #7 from Phil Ringnalda <phil at chetcolibrary.org> --- *** Bug 33692 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:34:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 20:34:46 +0000 Subject: [Koha-bugs] [Bug 33342] Fix framework handling in manage-marc-import.pl In-Reply-To: <bug-33342-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33342-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33342-70-0GPS4qdl4E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33342 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com, | |phil at chetcolibrary.org Depends on| |15869 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 [Bug 15869] Change framework on overlay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:34:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 20:34:46 +0000 Subject: [Koha-bugs] [Bug 15869] Change framework on overlay In-Reply-To: <bug-15869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15869-70-R3sdNHPXWL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33342 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33342 [Bug 33342] Fix framework handling in manage-marc-import.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:36:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 20:36:49 +0000 Subject: [Koha-bugs] [Bug 33342] Fix framework handling in manage-marc-import.pl In-Reply-To: <bug-33342-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33342-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33342-70-3qaNCIR2G2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33342 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Depends on|15869 | Status|Needs Signoff |RESOLVED --- Comment #8 from Phil Ringnalda <phil at chetcolibrary.org> --- *** This bug has been marked as a duplicate of bug 33412 *** Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 [Bug 15869] Change framework on overlay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:36:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 20:36:49 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-gUo8NaIh0I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |glasklas at gmail.com --- Comment #5 from Phil Ringnalda <phil at chetcolibrary.org> --- *** Bug 33342 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:36:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 20:36:49 +0000 Subject: [Koha-bugs] [Bug 15869] Change framework on overlay In-Reply-To: <bug-15869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15869-70-2syGfU7l5o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33342 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33342 [Bug 33342] Fix framework handling in manage-marc-import.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:40:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 20:40:44 +0000 Subject: [Koha-bugs] [Bug 31463] (Bug 31313 follow-up) Show item order status on opac-detail In-Reply-To: <bug-31463-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31463-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31463-70-sw70oN6o59@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31463 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Not sure what needs documenting here, it seems like backend changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:44:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 20:44:41 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-Hv8zcf2nDK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Mengu Yazicioglu <mengu at devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mengu at devinim.com.tr --- Comment #6 from Mengu Yazicioglu <mengu at devinim.com.tr> --- (In reply to Katrin Fischer from comment #4) > As the feature is already in stable releases it might be nice to rephrase > the bug description a little to be more descriptive of how the problem > manifests. Strongly agree. What about adding stage marc import and manage-marc-import.pl keywords in the title? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 22:49:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 20:49:09 +0000 Subject: [Koha-bugs] [Bug 33692] manage-marc-import.pl does not work regular when importing marc files In-Reply-To: <bug-33692-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33692-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33692-70-wikLQywGKh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33692 Mengu Yazicioglu <mengu at devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|stage-marc-import.pl does |manage-marc-import.pl does |not work regular when |not work regular when |importing marc files |importing marc files -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:10:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 21:10:01 +0000 Subject: [Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn In-Reply-To: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30678-70-mgZmqOsrYO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/678 Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:14:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 21:14:04 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-3ohrgWjkAQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil at chetcolibrary.org Status|Signed Off |Failed QA --- Comment #7 from Phil Ringnalda <phil at chetcolibrary.org> --- Test plan was missing a step where you import with Keep original framework and verify that the job succeeds. Since the option value is _USE_ORIG_ with a trailing underscore, it doesn't get undeffed by checking for eq to _USE_ORIG without a trailing underscore, and the job fails. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:18:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 21:18:26 +0000 Subject: [Koha-bugs] [Bug 23258] Batch tool for placing and cancelling holds In-Reply-To: <bug-23258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23258-70-Y4X4RqA8Sm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Suzanne <smhodson123extra at yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |smhodson123extra at yahoo.com --- Comment #25 from Suzanne <smhodson123extra at yahoo.com> --- We would also like to have this available for batch changing a hold expiration date. Is there a way we could get a check box (and maybe a select all option--with the ability to unclick as necessary) to be able to elect multiple holds and batch change the expiration date all at once? When a patron has a lot of holds and needs more time to pick them up, it is a bit cumbersome to have to do it individually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:28:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 21:28:25 +0000 Subject: [Koha-bugs] [Bug 32263] Capitalization: ...and on the Libraries page in the OPAC. In-Reply-To: <bug-32263-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32263-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32263-70-VUTJAXgZws@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32263 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply clean in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:30:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 21:30:05 +0000 Subject: [Koha-bugs] [Bug 33272] Color of the "(remove)" link when an item is in the cart (OPAC) In-Reply-To: <bug-33272-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33272-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33272-70-i23917jIpD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Does not apply clean in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:31:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 21:31:22 +0000 Subject: [Koha-bugs] [Bug 31841] Shelving location search in staff interface sometimes creates invalid Zebra query In-Reply-To: <bug-31841-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31841-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31841-70-wJfv8cbg6s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com --- Comment #20 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply cleanly to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:33:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 21:33:08 +0000 Subject: [Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w In-Reply-To: <bug-33160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33160-70-H70i1V1imn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #19 from Lucas Gass <lucas at bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:34:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 21:34:04 +0000 Subject: [Koha-bugs] [Bug 33391] Currently active menu item on navmenulist should not change style on hover In-Reply-To: <bug-33391-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33391-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33391-70-oSaNi71WRe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Not needed in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:36:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 21:36:43 +0000 Subject: [Koha-bugs] [Bug 27513] Add description to reports page In-Reply-To: <bug-27513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27513-70-pY9q2E0wq8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:40:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 21:40:54 +0000 Subject: [Koha-bugs] [Bug 33040] Add "Date published (text)" to serials tab on record view (detail.pl) In-Reply-To: <bug-33040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33040-70-VEpAnzpHeM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33040 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:44:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 21:44:34 +0000 Subject: [Koha-bugs] [Bug 31057] Add clarifying text to 'To date' in the calendar tool In-Reply-To: <bug-31057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31057-70-wmLYUN5ZQo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply clean in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:50:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 21:50:13 +0000 Subject: [Koha-bugs] [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs In-Reply-To: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29311-70-AiXQnQz1B6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | --- Comment #18 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:51:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 21:51:44 +0000 Subject: [Koha-bugs] [Bug 32800] build_oai_sets.pl fails on deleted records In-Reply-To: <bug-32800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32800-70-z0TKMgaIQb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply cleanly in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:55:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 21:55:16 +0000 Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32301-70-eTJyf4f1ZP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | --- Comment #16 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:57:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 21:57:04 +0000 Subject: [Koha-bugs] [Bug 33367] tmp/modified_authorities/README.txt seems useless In-Reply-To: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33367-70-xJlSbME4FO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33367 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:59:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 21:59:05 +0000 Subject: [Koha-bugs] [Bug 33332] Fix formatting of TT comments to improve translations In-Reply-To: <bug-33332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33332-70-z6cEzYGJWX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 5 23:59:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 21:59:42 +0000 Subject: [Koha-bugs] [Bug 33414] Dates displayed in ISO format in orders by fund In-Reply-To: <bug-33414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33414-70-4YZ628CS62@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:00:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:00:54 +0000 Subject: [Koha-bugs] [Bug 33261] Dates for issues on subscription detail page display unformatted In-Reply-To: <bug-33261-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33261-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33261-70-2Di5mL1see@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33261 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply clean to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:01:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:01:25 +0000 Subject: [Koha-bugs] [Bug 33265] Additional unformatted navigation items when on serial receive page In-Reply-To: <bug-33265-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33265-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33265-70-OaxP0ugGbp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33265 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply cleanly to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:05:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:05:15 +0000 Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable In-Reply-To: <bug-33323-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33323-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33323-70-4PfYZuBk8G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:06:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:06:51 +0000 Subject: [Koha-bugs] [Bug 33077] Improve ease of translating template title tags In-Reply-To: <bug-33077-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33077-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33077-70-rxpyZqhyJF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:07:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:07:36 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-tjIwiU8aaa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Missing 22.05.x dependencies, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:07:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:07:36 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-mm6BaB4bBp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Bug 33316 depends on bug 33486, which changed state. Bug 33486 Summary: Remove Koha::BackgroundJob::UpdateElasticIndex->process routine https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:08:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:08:55 +0000 Subject: [Koha-bugs] [Bug 33154] Tab WRAPPER follow-up: label text must be translatable In-Reply-To: <bug-33154-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33154-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33154-70-qS7rx1tDra@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- Missing 22.05.x dependencies, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:09:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:09:33 +0000 Subject: [Koha-bugs] [Bug 33289] Vue - Add API client class to interact with svc/config/systempreferences In-Reply-To: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33289-70-OMG0jbQOsv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> --- Missing dependencies for 22.05.x backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:09:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:09:34 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: <bug-30708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30708-70-Cy8lPpSPAT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Bug 30708 depends on bug 33289, which changed state. Bug 33289 Summary: Vue - Add API client class to interact with svc/config/systempreferences https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:09:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:09:34 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-Q8mhQAuxc2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Bug 33408 depends on bug 33289, which changed state. Bug 33289 Summary: Vue - Add API client class to interact with svc/config/systempreferences https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:09:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:09:58 +0000 Subject: [Koha-bugs] [Bug 33481] EBSCO ws return 415: Content type 'application/octet-stream' not supported In-Reply-To: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33481-70-9wFRUv7FLk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33481 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:11:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:11:19 +0000 Subject: [Koha-bugs] [Bug 32716] update NGINX config examples to increase proxy_buffer_size In-Reply-To: <bug-32716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32716-70-qYSnQ4U1rp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32716 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:12:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:12:06 +0000 Subject: [Koha-bugs] [Bug 33485] Add/remove title from holdings is not using the correct endpoint In-Reply-To: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33485-70-FtVEFucRia@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33485 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:13:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:13:01 +0000 Subject: [Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl In-Reply-To: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32418-70-W1zRvjpwFm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #42 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply cleanly to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:13:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:13:48 +0000 Subject: [Koha-bugs] [Bug 33345] On-site checkout checkbox does not work since issue date using flatpickr In-Reply-To: <bug-33345-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33345-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33345-70-299ouoj4Yx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> --- Missing 22.05.x dependencies, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:16:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:16:54 +0000 Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in templates In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32127-70-Ypnd9FMF2Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | --- Comment #17 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:18:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:18:52 +0000 Subject: [Koha-bugs] [Bug 33088] background-job-progressbar.js no longer needed in batch_record_modification.tt In-Reply-To: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33088-70-bqsnuIazZ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33088 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:20:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:20:15 +0000 Subject: [Koha-bugs] [Bug 33375] Advanced editor crashes when using MySQL 8 due to reserved rank keyword In-Reply-To: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33375-70-tcdqqBPtCN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33375 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:21:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:21:23 +0000 Subject: [Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off In-Reply-To: <bug-31722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31722-70-Foe2eaC1KU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply clean to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:22:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:22:02 +0000 Subject: [Koha-bugs] [Bug 32955] Standardize structure around action fieldsets in various templates In-Reply-To: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32955-70-vWhogA09Rs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32955 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Missing 22.05.x dependencies. No backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:22:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:22:02 +0000 Subject: [Koha-bugs] [Bug 32744] [OMNIBUS] Standardize structure around action fieldsets In-Reply-To: <bug-32744-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32744-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32744-70-KTnt11BAm7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32744 Bug 32744 depends on bug 32955, which changed state. Bug 32955 Summary: Standardize structure around action fieldsets in various templates https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32955 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:22:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:22:47 +0000 Subject: [Koha-bugs] [Bug 32956] Use template wrapper for HTML customizations tabs In-Reply-To: <bug-32956-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32956-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32956-70-YgBBoRsQNO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32956 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Missing 22.05.x dependencies. No backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:24:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:24:04 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31695-70-yWlDHfV6I2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:25:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:25:00 +0000 Subject: [Koha-bugs] [Bug 33231] (Bug 30813 follow-up) No publication date nor edition statements in Z39.50 biblio search results In-Reply-To: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33231-70-P3DLmJHFY4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33231 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> --- Missing 22.05.x dependencies. NO backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:27:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:27:03 +0000 Subject: [Koha-bugs] [Bug 33509] Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternate holdings In-Reply-To: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33509-70-38pZMoReQG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:30:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:30:06 +0000 Subject: [Koha-bugs] [Bug 33238] Error adding suggestion to basket as non-superlibrarian (Bug 29886 follow-up) In-Reply-To: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33238-70-xhUjRITnLc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:31:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:31:06 +0000 Subject: [Koha-bugs] [Bug 33229] Patron reading history should be cleared when privacy set to never In-Reply-To: <bug-33229-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33229-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33229-70-AliR9QRUyP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33229 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #15 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply clean to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:31:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:31:44 +0000 Subject: [Koha-bugs] [Bug 32954] Standardize action fieldsets in rotating collections, suggestions, tools In-Reply-To: <bug-32954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32954-70-TNfCcp4PZ8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:31:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:31:44 +0000 Subject: [Koha-bugs] [Bug 32744] [OMNIBUS] Standardize structure around action fieldsets In-Reply-To: <bug-32744-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32744-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32744-70-laYZJCykos@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32744 Bug 32744 depends on bug 32954, which changed state. Bug 32954 Summary: Standardize action fieldsets in rotating collections, suggestions, tools https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:32:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:32:01 +0000 Subject: [Koha-bugs] [Bug 32634] Add 'page-section' to various pages In-Reply-To: <bug-32634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32634-70-zNWzsDLEP0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32634 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:32:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:32:01 +0000 Subject: [Koha-bugs] [Bug 31757] [Omnibus] Add 'page-section' where it's missing In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31757-70-NvDT06oQ3D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Bug 31757 depends on bug 32634, which changed state. Bug 32634 Summary: Add 'page-section' to various pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32634 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:32:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:32:53 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-C7YR0EfHcX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Not needed in 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:32:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:32:53 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16223-70-He3hjrqiCL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Bug 16223 depends on bug 33574, which changed state. Bug 33574 Summary: Restriction type is not stored, all restrictions fall back to MANUAL https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:33:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:33:34 +0000 Subject: [Koha-bugs] [Bug 32992] Move background worker script to misc/workers In-Reply-To: <bug-32992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32992-70-m2DYkxK7zh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32992 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- Not needed in 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:33:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:33:34 +0000 Subject: [Koha-bugs] [Bug 32594] Add a dedicated ES indexing background worker In-Reply-To: <bug-32594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32594-70-MjRbqarHdM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 Bug 32594 depends on bug 32992, which changed state. Bug 32992 Summary: Move background worker script to misc/workers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32992 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:34:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:34:13 +0000 Subject: [Koha-bugs] [Bug 32594] Add a dedicated ES indexing background worker In-Reply-To: <bug-32594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32594-70-YuH6JW6750@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:34:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:34:14 +0000 Subject: [Koha-bugs] [Bug 32572] We should have a background queue for each job type In-Reply-To: <bug-32572-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32572-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32572-70-K21e3HpfDP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32572 Bug 32572 depends on bug 32594, which changed state. Bug 32594 Summary: Add a dedicated ES indexing background worker https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:34:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:34:14 +0000 Subject: [Koha-bugs] [Bug 33108] We need a way to launch the ES indexer automatically In-Reply-To: <bug-33108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33108-70-sjh6mYi2Es@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 Bug 33108 depends on bug 32594, which changed state. Bug 32594 Summary: Add a dedicated ES indexing background worker https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:34:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:34:14 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-WKAfY9hen4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 Bug 33486 depends on bug 32594, which changed state. Bug 32594 Summary: Add a dedicated ES indexing background worker https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:34:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:34:20 +0000 Subject: [Koha-bugs] [Bug 33693] New: Add ability to batch mark items as lost from checkout screen Message-ID: <bug-33693-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33693 Bug ID: 33693 Summary: Add ability to batch mark items as lost from checkout screen Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some partners would like the ability to mark items as lost from the checkout screen without having to open each item's record. Possibly from the screen directly, or adding an export to barcode file that could then be used in batch modification tool. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 00:34:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 May 2023 22:34:40 +0000 Subject: [Koha-bugs] [Bug 33108] We need a way to launch the ES indexer automatically In-Reply-To: <bug-33108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33108-70-rUX5o6lcbm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33108 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 08:54:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 May 2023 06:54:30 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-wDF9Ze0oht@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Michaela Sieber <michaela.sieber at kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 15:38:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 May 2023 13:38:09 +0000 Subject: [Koha-bugs] [Bug 29852] Add option to exclude certain types of url in check-url-quick.pl In-Reply-To: <bug-29852-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29852-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29852-70-nUF4q3Ju27@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29852 Sarah Cornell <sbcornell at cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell at cityofportsmouth. | |com --- Comment #1 from Sarah Cornell <sbcornell at cityofportsmouth.com> --- We agree! There are URLs that always show up on our report that we know are fine, even though they returned an error in the cron job. We'd like to enter a list of prefixes that do not need checked, or do not need to be reported. Either option would achieve a shorter list to review. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 6 23:06:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 May 2023 21:06:42 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-2cO3RIiUgP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #8 from David Nind <david at davidnind.com> --- Some discussion on this issue on the mailing list over the last couple of days: - Development list: https://lists.koha-community.org/pipermail/koha-devel/2023-May/048136.html - Main list: https://lists.katipo.co.nz/pipermail/koha/2023-May/059402.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 00:49:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 May 2023 22:49:15 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33690-70-Fn8G5T7BmU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind <david at davidnind.com> --- I'd be happy to test, but don't know enough for step 3. Could you provide an example of the JSON for adding a patron? I can use Postman for basic things.... Otehrwsie, I'll leave for someone else who knows what to do, to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 01:17:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 May 2023 23:17:25 +0000 Subject: [Koha-bugs] [Bug 33297] Typo system preference RetainPatronSearchTerms in DB revs 220600044.pl In-Reply-To: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33297-70-uC7bgXgyiM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33297 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #15 from David Nind <david at davidnind.com> --- I'd like to test, but don't know how to do step 1.2 (upgrading from 22.05 to master) using KTD (koha-testing-docker). If I could get some instructions on how to do that, I'll happily test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 01:31:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 May 2023 23:31:39 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33690-70-mui1cb0NMt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to David Nind from comment #3) > I'd be happy to test, but don't know enough for step 3. > > Could you provide an example of the JSON for adding a patron? > > I can use Postman for basic things.... > > Otehrwsie, I'll leave for someone else who knows what to do, to test. When you do a GET /API/V1/patrons you can get an idea of how a patron object for POST should look like. I'd suggest you pick a couple attributes like firstname, surname and user id. And see if it tells you you need more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 01:47:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 May 2023 23:47:32 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_110.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-NJMpiVGVOl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 01:47:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 May 2023 23:47:35 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_110.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-HhhGkaDF2q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150714|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 150790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150790&action=edit Bug 33686: Update plugin unimarc_field_110.pl with 2022 values Was missing : - ib : birman - ic : khmer - jb : bengali - jc : gujurati - jd : gurmukhi - je : odia (oriya) - lb : kannada (kannara) - lc : malayalam - ld : singhalais (cinghalais) - le : télougou - na : éthiopien (guèze) Sponsored by BibLibre Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 02:01:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2023 00:01:33 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_110.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-SpNWrAC9uV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind <david at davidnind.com> --- I've signed off, as this adds the new values in the 2022 UNIMARC update. However, I do have a question: should the script of title name values match exactly with the UNIMARC definitions (see references)? For example, in the definitions eg is shown as eg Naxi Dongba (Nakhi Tomba), but in Koha it is shown as eg Dongba (Naxi). If they should, I'm happy to create a bug for that. References: 1. UNIMARC Bibliographic (3rd ed.) Updates https://www.ifla.org/g/unimarc-rg/unimarc-bibliographic-3rd-edition-with-updates/ 2. Tag 100 values (see page 8 for 'Script of title') https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf Testing notes (using KTD): 1. Before starting KTD, edit your .env file to change KOHA_MARC_FLAVOUR=unimarc 2. Edit a record and view the values for tag 100 and the 'Script of title' dropdown list. 3. Codes and names for values being added by this bug are not listed. 4. Apply the patch. 5. Restart everything (flush_memcached, restart_all, clear browser cache). 6. Repeat step 2. 7. New codes and values are now lsited. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 21:41:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2023 19:41:26 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33690-70-RTzW0nByG8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 21:41:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2023 19:41:29 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33690-70-mu51gIgRxe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150787|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Created attachment 150791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150791&action=edit Bug 33690: Add ability to send welcome notice when creating patrons using the REST API It would be nice to have the ability to send a welcome notice when creating patrons via the API. Test Plan: 1) Apply this patch 2) Ensure you have a WELCOME notice 3) Create a new patron using the REST API ( api/v1/patrons ) 4) Note no welcome notice is sent to the patron ( you can check the notices tab for the patron ) 5) Repeat step 3, but send the header X-Koha-SendWelcomeEmail with a value of 1 as part of the POST 6) Note the welcome message for the patron is in their notices! Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 21:42:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2023 19:42:17 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33690-70-hi9AE2GWBJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 --- Comment #6 from David Nind <david at davidnind.com> --- (In reply to Tomás Cohen Arazi from comment #4) > (In reply to David Nind from comment #3) > > I'd be happy to test, but don't know enough for step 3. > > > > Could you provide an example of the JSON for adding a patron? > > > > I can use Postman for basic things.... > > > > Otehrwsie, I'll leave for someone else who knows what to do, to test. > > When you do a GET /API/V1/patrons you can get an idea of how a patron object > for POST should look like. I'd suggest you pick a couple attributes like > firstname, surname and user id. And see if it tells you you need more. Thanks Tomás! That helped me figure it out. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 21:44:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2023 19:44:41 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33690-70-xLTJl4bCj4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 --- Comment #7 from David Nind <david at davidnind.com> --- Testing notes (using KTD) 1. Enabled RESTBasicAuth system preference. 2. Used Postman to create a new HTTP Request with these values/settings: - POST to http://127.0.0.1:8081/api/v1/patrons - Authorization: Basic Auth with koha as both username password - Headers: added x-koha-welcome with a value of email - Body (raw and JSON selected): { "cardnumber": "987654321", "category_id": "PT", "library_id": "CPL", "email": "email at example.com", "surname": "bz33690", "userid": "bz33690" } 3. Tests pass: prove -v t/db_dependent/api/v1/patrons.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 22:21:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2023 20:21:20 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-7Gx082YHXf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 22:21:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2023 20:21:24 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-xKYZc0VJXi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150649|0 |1 is obsolete| | --- Comment #12 from David Nind <david at davidnind.com> --- Created attachment 150792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150792&action=edit Bug 33594: Update mappings and comment Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 22:21:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2023 20:21:26 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-J25lFIYJCu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150749|0 |1 is obsolete| | --- Comment #13 from David Nind <david at davidnind.com> --- Created attachment 150793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150793&action=edit Bug 33594: Only sort on title main heading This patch simply remvoes sort from all elements that are not strictly the main title Note: If multiple fields are set as sort, they are collapsed into a single entry in the {field}__sort field in the ES index. The order will be determined by the order in the marc record To test: 1 - Apply patch 2 - perl misc/search_tools/rebuild_elasticsearch -r -v 3 - Search the catalog 4 - Sort by title 5 - Confirm records are correct 6 - Add a 240 (before the 245) with subfield a 'AAAAA' 7 - Confirm sorting is not affected 8 - View record details, click 'Elasticsearch record: Show' 9 - Find 'title__sort' and confirm it looks correct (does not include AAAAA) Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 22:40:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2023 20:40:59 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-DWiTNd09k8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This changes the behavour release notes| |of title search and sorting | |(Title (A-Z)) in the OPAC | |and staff interface when | |using Elasticsearch or Open | |Search. The title search | |now only uses 245 (for MARC | |21) and 200 (for UNIMARC). | |Previously other title | |fields may have affected | |the search order, for | |example 240$a in MARC21. | | | |To make this change for | |existing installations, | |reset the search engine | |mappings (Administration > | |Catalog > Search engine | |configuration | |(Elasticsearch) > Reset | |mappings (scroll down to | |the bottom of the page)) | |and rebuild the search | |index (koha-elasticsearch | |--rebuild -d -b -a | |<instancename>). If you | |have customized the search | |engine configuration, | |remember to record or back | |these up BEFORE resetting | |the mappings. CC| |david at davidnind.com --- Comment #14 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. I used the example in the bug description (#c0) to test. 2. After step 1, I needed to reset the mappings (Administration > Catalog > Search engine configuration (Elasticsearch) > Reset mappings (scroll down to the bottom of the page)). 3. Draft release notes. I've made an attempt at this, but this area is not something I really understand. Please update to fix what I've got wrong! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 7 23:55:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2023 21:55:00 +0000 Subject: [Koha-bugs] [Bug 33684] Able to save patron with empty mandatory date fields In-Reply-To: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33684-70-oFDVfm1mTv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33684 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Summary|Able to save patron without |Able to save patron with |date of birth when field is |empty mandatory date fields |set as mandatory | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 00:07:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2023 22:07:12 +0000 Subject: [Koha-bugs] [Bug 33693] Add ability to batch mark items as lost from checkout screen In-Reply-To: <bug-33693-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33693-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33693-70-lFKtdPOlj8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33693 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Lisette, did you see ExportCircHistory? It allows to export MARC, but also adds an entry to export "Today's checked in barcodes" to the More menu. Not quite what we want, but maybe it would be possible to extend it to allow for a barcode file as an additional export option. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 8 00:09:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2023 22:09:53 +0000 Subject: [Koha-bugs] [Bug 32766] Update plugin unimarc_field_116.pl fields In-Reply-To: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32766-70-WqUA9ioQ8c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32766 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 00:09:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2023 22:09:55 +0000 Subject: [Koha-bugs] [Bug 32766] Update plugin unimarc_field_116.pl fields In-Reply-To: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32766-70-VVhejqZgXC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32766 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145844|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Created attachment 150794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150794&action=edit Bug 32766: Update some labels for better understanding and translation examples: 'crayon'->'carchoal' or 'camaiu'->'cameo' Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 00:09:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2023 22:09:58 +0000 Subject: [Koha-bugs] [Bug 32766] Update plugin unimarc_field_116.pl fields In-Reply-To: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32766-70-mpjCWGjeQ1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32766 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145877|0 |1 is obsolete| | --- Comment #6 from David Nind <david at davidnind.com> --- Created attachment 150795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150795&action=edit Bug 32766: (follow-up) Fix translation function The previous syntax causes a warning during the execution of the translation script Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 00:20:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2023 22:20:10 +0000 Subject: [Koha-bugs] [Bug 32766] Update plugin unimarc_field_116.pl fields In-Reply-To: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32766-70-t8Gb2eK33I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32766 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #7 from David Nind <david at davidnind.com> --- Testing notes (using koha-testing-docker (KTD)): 1. Before starting KTD, edit your .env file to change KOHA_MARC_FLAVOUR=unimarc 2. Edit a record, view the values for tag 116, and note the before values listed in [1] that will change. 3. Apply the patch. 4. Restart everything (flush_memcached, restart_all, clear browser cache). 5. Repeat step 2 - note that the changes listed in [1] were made. [1] Before and after changes to dropdown list values: - Specific material designation: i- print (no change in display) m- master -> m- mould - Techniques (drawings, paintings) 1, 2, and 3: crayon -> charcoal - Technique (prints) 1,2, and 3: Label for dropdown list changed to Techniques (print) 1, 2, and 3 camaiu -> cameo computer graphics -> infography - Functional designation ab- item cover -> ab- resource cover ag- chart -> ag- diagram Other notes - full details for 116 are not available online: - UNIMARC Bibliographic (3rd ed.) Updates https://www.ifla.org/g/unimarc-rg/unimarc-bibliographic-3rd-edition-with-updates/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 01:59:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 May 2023 23:59:27 +0000 Subject: [Koha-bugs] [Bug 33472] Error 500 when many items attached to bib record In-Reply-To: <bug-33472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33472-70-uKcTQWSYII@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33472 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 02:13:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 00:13:17 +0000 Subject: [Koha-bugs] [Bug 33684] Able to save patron with empty mandatory date fields In-Reply-To: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33684-70-EKohY7C7GV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33684 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 02:13:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 00:13:40 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33690-70-ghNScbtPiQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 06:37:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 04:37:40 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-eKpcj0hQEf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #2 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Bump, we are experiencing the same problem as described by Esther. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 10:45:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 08:45:43 +0000 Subject: [Koha-bugs] [Bug 33413] Make staff notices digest-able for OPAC_REG and NEW_SUGGESTION In-Reply-To: <bug-33413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33413-70-zAXzOUHlui@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33413 Klas Blomberg <klas.blomberg at skovde.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |klas.blomberg at skovde.se --- Comment #1 from Klas Blomberg <klas.blomberg at skovde.se> --- +1 to this suggestion. I will hopefully solve one of our problems. The same notice is sent to the patron and to the circulation desk - so some staff members only read the mail and never closes suggestions in Koha, leaving us with a lot of unprocessed suggestions. This problem will be solved if e have a digest noticetxt, where we can give instructions to staff on how to proceed correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 10:50:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 08:50:35 +0000 Subject: [Koha-bugs] [Bug 33413] Make staff notices digest-able for OPAC_REG and NEW_SUGGESTION In-Reply-To: <bug-33413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33413-70-tDFjMdeYaU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33413 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Klas, it should not be the same notice actually. This is about features that send notice to staff when a new suggestion/self registration is made. So you could already include specific instructions. Maybe you also send the mails going out to patrons using the BCC pref? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 10:57:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 08:57:20 +0000 Subject: [Koha-bugs] [Bug 33413] Make staff notices digest-able for OPAC_REG and NEW_SUGGESTION In-Reply-To: <bug-33413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33413-70-4y5wpVo4D5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33413 --- Comment #3 from Klas Blomberg <klas.blomberg at skovde.se> --- A sorry - I was too fast. We don't allow self registrations, so our problem is about NEW_SUGGESTION -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 8 11:12:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 09:12:06 +0000 Subject: [Koha-bugs] [Bug 33413] Make staff notices digest-able for OPAC_REG and NEW_SUGGESTION In-Reply-To: <bug-33413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33413-70-3AZ9YDcFWu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33413 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- But this should also only be sent to the staff as well, not to the users. See: EmailPurchaseSuggestions. I just verified that in the source code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 8 12:04:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 10:04:44 +0000 Subject: [Koha-bugs] [Bug 33503] Plugin OpenAPI2.0 specification schema fragments are not resolved. Merge full schema definitions. In-Reply-To: <bug-33503-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33503-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33503-70-FxC29NOmCe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33503 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 12:08:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 10:08:15 +0000 Subject: [Koha-bugs] [Bug 33694] New: Incorrect sorting of call numbers in shelf browser Message-ID: <bug-33694-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33694 Bug ID: 33694 Summary: Incorrect sorting of call numbers in shelf browser Change sponsored?: --- Product: Koha Version: 22.05 Hardware: Other OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: anke.bruns at gwdg.de QA Contact: testopia at bugs.koha-community.org (Not sure if this is related to Bug #14907) In the view of a record in OPAC, there is a link "Browse Shelf" next to the call number in the item information. The surrounding records displayed are sorted by their call number but not correctly, e.g. 2 comes after 19, and 16 after 159, whereas it should sort numerically like this: 2 - 19 and 16 - 159. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 13:01:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 11:01:00 +0000 Subject: [Koha-bugs] [Bug 33694] Incorrect sorting of call numbers in shelf browser In-Reply-To: <bug-33694-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33694-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33694-70-gPOfJgluMe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33694 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Just to check: does the sorting work ok for you in other places? For example the inventory list? You could also try a report like this: select cn_source, cn_sort, itemcallnumber from items order by cn_sort This should reflect how Koha thinks the callnumbers should be sorted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 13:13:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 11:13:52 +0000 Subject: [Koha-bugs] [Bug 33694] Incorrect sorting of call numbers in shelf browser In-Reply-To: <bug-33694-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33694-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33694-70-JrJBgyjplp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33694 --- Comment #2 from Anke Bruns <anke.bruns at gwdg.de> --- With the SQL query, I get results sorted in the same (numerically incorrect) way as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 13:31:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 11:31:26 +0000 Subject: [Koha-bugs] [Bug 33695] New: Audio alerts in the OPAC broken? Message-ID: <bug-33695-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33695 Bug ID: 33695 Summary: Audio alerts in the OPAC broken? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org A library asked to connect a sound alert to the different error messages in the web based self checkout module, but it appears that the audio alerts are broken or not fully implemented for the OPAC. I put body as selector to trigger an alert on every page. It works in the staff interface, but not in the OPAC. Looking at the source code of the OPAC pages, you can see code for audio alerts, but it doesn't seem to work or maybe it's not loading the configuration? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 14:27:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 12:27:43 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-LvH9Ms54ch@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Raising author's attention. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 14:33:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 12:33:16 +0000 Subject: [Koha-bugs] [Bug 33696] New: Doubled up home icon in budgets page Message-ID: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33696 Bug ID: 33696 Summary: Doubled up home icon in budgets page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 14:33:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 12:33:22 +0000 Subject: [Koha-bugs] [Bug 33696] Doubled up home icon in budgets page In-Reply-To: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33696-70-bU2qWgmrq7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33696 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33006 CC| |tomascohen at gmail.com Assignee|oleonard at myacpl.org |tomascohen at gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33006 [Bug 33006] Use template wrapper for breadcrumbs: Administration part 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 14:33:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 12:33:22 +0000 Subject: [Koha-bugs] [Bug 33006] Use template wrapper for breadcrumbs: Administration part 1 In-Reply-To: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33006-70-gfwR2rdRdJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33006 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33696 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33696 [Bug 33696] Doubled up home icon in budgets page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 14:36:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 12:36:38 +0000 Subject: [Koha-bugs] [Bug 33696] Doubled up home icon in budgets page In-Reply-To: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33696-70-y84efZWMXv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33696 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 14:36:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 12:36:41 +0000 Subject: [Koha-bugs] [Bug 33696] Doubled up home icon in budgets page In-Reply-To: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33696-70-Q8eDKx1bAj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33696 --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 150796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150796&action=edit Bug 33696: Fix doubled up home icon in budgets page To test: 1. Go to the Administration > Budgets page => FAIL: Breadcrumbs show two little house icons 2. Apply this patch 3. Reload page => SUCCESS: Only one icon 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 14:36:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 12:36:58 +0000 Subject: [Koha-bugs] [Bug 33696] Doubled up home icon in budgets page In-Reply-To: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33696-70-ACM6CypBgC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33696 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off QA Contact|testopia at bugs.koha-communit |oleonard at myacpl.org |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 14:58:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 12:58:08 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-rJIvDclQue@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 15:03:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 13:03:49 +0000 Subject: [Koha-bugs] [Bug 33697] New: Remove RecordedBooks (rbdigital) integration Message-ID: <bug-33697-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33697 Bug ID: 33697 Summary: Remove RecordedBooks (rbdigital) integration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 17602 RecordedBooks search API integration is now obsolete following rbdigital's incorporation into OverDrive. Associated code should be removed. https://company.overdrive.com/2020/06/23/overdrive-to-acquire-rbdigital-from-rbmedia/ Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 [Bug 17602] Integrate support for RecordedBooks (formerly OneClickDigital) API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 15:03:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 13:03:49 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for RecordedBooks (formerly OneClickDigital) API In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17602-70-6drcwMHqMb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33697 [Bug 33697] Remove RecordedBooks (rbdigital) integration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 15:25:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 13:25:31 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-57HN5C4I5F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:16:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 15:16:25 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33611-70-jGpfeNhOQH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 Hinemoea Viault <hinemoea.viault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150519|0 |1 is obsolete| | --- Comment #11 from Hinemoea Viault <hinemoea.viault at inlibro.com> --- Created attachment 150797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150797&action=edit Bug 33611: Unit test Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Hinemoea Viault <hinemoea.viault at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:16:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 15:16:27 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33611-70-l0f1pelbUG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 Hinemoea Viault <hinemoea.viault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150520|0 |1 is obsolete| | --- Comment #12 from Hinemoea Viault <hinemoea.viault at inlibro.com> --- Created attachment 150798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150798&action=edit Bug 33611: Ensure dt_from_string always returns a new object This patch alters dt_from_string to pass a cloned object if called on an existing date time object This resolves an issue where a holds reserve date was being altered when the default expiration date was set To test: 1 - Set DefaultHoldExpiration to Set 2 - Set DefaultHoldExpirationPeriod to 365 3 - Set DefaultHoldExpirationunitOfTimeToDays 4 - Place a hold 5 - Note reserve date is 1 year in the future, same as expiration 6 - Apply patch 7 - Restart all 8 - Place another hold 9 - Note reserve date is set to today Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Hinemoea Viault <hinemoea.viault at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:25:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 15:25:47 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24194-70-KmKb1Eqw01@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Nicolas Giraud <nicolas.giraud at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147527|0 |1 is obsolete| | --- Comment #62 from Nicolas Giraud <nicolas.giraud at inlibro.com> --- Created attachment 150799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150799&action=edit Bug 24194: Add ReserveExpiration system preference to disable expiration date options for reserves To test: 1) Update database 2) Go to place a hold on any biblio in the staff intranet and confirm you can see the 'Hold expires on date' field. 3) In another tab, go to place a hold on any biblio in the OPAC and confirm you can see the 'Hold not needed after' field as an option. 4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as waiting. Notice that an expiration date has now been generated for this reserve. 5) Attempt to check out the item you reserved to some other borrower. Revert waiting status. Notice that the expiration date that was generated remains. 6) Go to Administration -> system preferences and set ReserveExpiration system preference to 'Disable' 7) Refresh the hold request page in the intranet. Confirm the expiration date field disappears. 8) Refresh the hold request page in the OPAC. Confirm the expiration date field disappears. 9) Place another reserve. Check it in and set the reserve as waiting. Notice that no expiration date was generated for this reserve. 10) Attempt to check out the item you reserved to some other borrower. Revert waiting status. The expiration date should remain null. 11) Confirm tests pass t/db_dependent/Hold.t t/db_dependent/Reserves.t 12) Go to Admin -> System preferences and search for ReserveExpiration. Confirm related system preferences have a reference to ReserveExpiration and the links all work 13) Text the cancel_expired_holds.pl cronjob and confirm it works with ReserveExpiration enabled, and does nothing when disabled 14) Confirm all instances where hold expiration dates are set or referenced are shown or hidden correctly, depending on ReserveExpiration Pages in the staff interface: - Check out to a patron and check the holds tab - View patron details and check the holds tab - Patron hold history - Patron details -> Print -> Print summary - Place a hold on a title which already has at least one hold on it, check the table of existing holds. - Circulation -> Holds awaiting pickup Pages in the OPAC: - Log in to the OPAC as a patron with holds - Your summary -> Holds tab - Your holds history (OPACHoldsHistory must be enabled). Sponsored-by: Horowhenua Library Trust Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nicolas Giraud <nicolas.giraud at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:25:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 15:25:50 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24194-70-wlE6Ki9pOX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Nicolas Giraud <nicolas.giraud at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147528|0 |1 is obsolete| | --- Comment #63 from Nicolas Giraud <nicolas.giraud at inlibro.com> --- Created attachment 150800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150800&action=edit Bug 24194: (follow-up) Throw an error if expiration date used Signed-off-by: Nicolas Giraud <nicolas.giraud at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:50:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 15:50:38 +0000 Subject: [Koha-bugs] [Bug 33694] Incorrect sorting of call numbers in shelf browser In-Reply-To: <bug-33694-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33694-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33694-70-XDiJE35mAj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33694 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I don't believe it's a bug then, it's a configuration issue. Koha will generate a sorting form of your callnumber (itemcallnumber) from the classification source (cn_source). It's saved to cn_sort and used in a lot of places for sorting callnumbers. If you check the manual for classification sources, you'll find information there about the 3 algorithms Koha has to do that (DDC, LOC and generic). Sadly no RVK and similar yet (I'd be happy to see that added :) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 17:54:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 15:54:27 +0000 Subject: [Koha-bugs] [Bug 33693] Add ability to batch mark items as lost from checkout screen In-Reply-To: <bug-33693-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33693-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33693-70-EbE1kalx35@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33693 --- Comment #2 from Lisette Scheer <lisette.scheer at bywatersolutions.com> --- Yes, I looked into it, but some libraries want to leave the item on the account rather than checking them in. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 8 18:07:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 16:07:11 +0000 Subject: [Koha-bugs] [Bug 32765] Transfer is not retried after cancelling hold In-Reply-To: <bug-32765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32765-70-eAFdcLHBmG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Nicolas Giraud <nicolas.giraud at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145839|0 |1 is obsolete| | --- Comment #7 from Nicolas Giraud <nicolas.giraud at inlibro.com> --- Created attachment 150801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150801&action=edit Bug 32765: Retry transfer after cancelling hold When trying to manually transfer an item that is on hold, we have the choice to cancel the hold and try the transfer again. When choosing this option, the hold is correctly cancelled but the transfer is not tried again. This patch fixes that Test plan: 1. Place a hold on a specific item 2. Try to transfer it manually (Circulation » Transfer) 3. Choose the option to "Cancel hold and then attempt transfer" 4. See that the hold was cancelled, but no transfer was made 5. Apply the patch 6. Repeat step 1-3 7. See that the hold was cancelled, and the transfer was made Signed-off-by: Nicolas Giraud <nicolas.giraud at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 18:08:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 16:08:35 +0000 Subject: [Koha-bugs] [Bug 33613] Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge In-Reply-To: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33613-70-3VdPtRq0qU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Hinemoea Viault <hinemoea.viault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150252|0 |1 is obsolete| | --- Comment #7 from Hinemoea Viault <hinemoea.viault at inlibro.com> --- Created attachment 150802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150802&action=edit Bug 33613: Use prop() to evaluate checkbox To test: 1. Have an item with a replacement cost checked out to a patron 2. Set the ClaimReturnedChargeFee sys pref to "Ask if a lost fee should be charged" 3. Make a claim and check the box for charging. 4. Claim happens but no charge occurs. 5. Apply patch and try again. 6. A charge should now occur. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Hinemoea Viault <hinemoea.viault at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 18:24:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 16:24:18 +0000 Subject: [Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector In-Reply-To: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32993-70-vhUnuvy8Fs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 --- Comment #4 from Hinemoea Viault <hinemoea.viault at inlibro.com> --- Created attachment 150803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150803&action=edit Bug 32993: Holds priority changed incorrectly with dropdown selector Test Plan: 1) Find record with at least 3 holds. 2) Change first holds priority as 2, Priority is changed to 3. 3) Try to change priority back to 1, Priority is changed to 2. 4) Apply this patch 5) Reload the page 2) Change first holds priority as 2, Priority is changed to 2. 3) Try to change priority back to 1, Priority is changed to 1. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi> Signed-off-by: Hinemoea Viault <hinemoea.viault at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 18:26:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 16:26:33 +0000 Subject: [Koha-bugs] [Bug 33693] Add ability to batch mark items as lost from checkout screen In-Reply-To: <bug-33693-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33693-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33693-70-oZaXfoiicu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33693 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Maybe I didn't explain my thought well. The export feature provides an additional column with checkboxes to the checkouts table, so you can select the items you want. Then you can choose an export format at the bottom of the table (currently MARC with/without items and user defined ones from CSV profiles. I was suggesting to add another option there to give you a barcode list. It feels like we would be almost there that way. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 19:06:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 17:06:30 +0000 Subject: [Koha-bugs] [Bug 33681] Omnibus: Allow SIP2 users to be created through the Koha staff interface In-Reply-To: <bug-33681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33681-70-x1pagCe964@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33681 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #4 from Liz Rea <wizzyrea at gmail.com> --- I imagine we'd have to support both - perhaps they are additive to each other, i.e. if you have accounts in there, we use them, and if we create any in the UI, those also work? There may be technical reasons why that's not possible. Possibly we do one or the other, via syspref? upgrading koha use SIPConfig.xml until the accounts can be moved or updated, new koha use the UI? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 19:07:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 17:07:23 +0000 Subject: [Koha-bugs] [Bug 33563] Document Elasticsearch secure mode In-Reply-To: <bug-33563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33563-70-8l5OI1jdUq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33563 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Enable compatibility with |Document Elasticsearch |Elasticsearch secure mode |secure mode CC| |wizzyrea at gmail.com --- Comment #2 from Liz Rea <wizzyrea at gmail.com> --- Agreed, let's make the bug "document secure mode" :D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 19:48:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 17:48:15 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-2rasp6GEYZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 19:48:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 17:48:17 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-8BLBffJeHr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150622|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150804&action=edit Bug 33412: Fix comparison when checking for overlay framework TO test: 1 - Cataloging -> Export catalog data 2 - Export a record fom your catalog 3 - Cataloging -> Stage record for import 4 - Import the record, use Record matchign rule: KohaBiblio (999c) 5 - Stage, view batch 6 - Record should match the one that was exported 7 - When replacing record use this framework, choose a different value than current framework of record 8 - Import this batch 9 - View and edit record - note framework did not change 10 - Apply patch 11 - Restart all 12 - Repeat 4-8 13 - View and edit record, confirm framework has changed 14 - Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 20:10:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 18:10:01 +0000 Subject: [Koha-bugs] [Bug 33643] Add page-section to 'scan index' page In-Reply-To: <bug-33643-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33643-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33643-70-HDprMD0PgE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33643 Nicolas Giraud <nicolas.giraud at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150461|0 |1 is obsolete| | --- Comment #3 from Nicolas Giraud <nicolas.giraud at inlibro.com> --- Created attachment 150805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150805&action=edit Bug 33643: Add page-section to 'scan index' page in staff interface This adds the white background. As we do on other pages I have chosen to include the h2 heading within the page-section. To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * On the result list verify there is no white background/page section * Apply patch * Repeat test - background should be present now Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Nicolas Giraud <nicolas.giraud at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 21:35:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 19:35:20 +0000 Subject: [Koha-bugs] [Bug 32740] Add a new option patron home library to OverdueNoticeFrom In-Reply-To: <bug-32740-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32740-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32740-70-4JNgnZJkZW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Hinemoea Viault <hinemoea.viault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149695|0 |1 is obsolete| | --- Comment #4 from Hinemoea Viault <hinemoea.viault at inlibro.com> --- Created attachment 150806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150806&action=edit Bug 32740: Add a new option patron home library to OverdueNoticeFrom This patch add 'patron home library' option to the OverdueNoticeFrom preference. When it's selected notification messages for overdues will be bundled and sent from the borrowing user's home library To Test 1. Create 3 libraries B1, B2 and B3 1.1. Go to Koha administration, click on Libraries 1.2. Click New library 1.3. Fill the Library Code (ex. B1), Name(ex. B1) and email(ex. b1 at test.com) fields. 2. Create a user belonging to B1 2.1. Go to patron module, click on New patron and patron 2.2. Fill the Surname,Card number,Primary email,Card number field and select B1 as Library. 3. Create 2 notices : the first belongs to B2 and the second belong to B3 3.1. Go to Cataloging module and click on new 3.2. field the required field (000 subfield 0, 003 subfield 0, 005 subfield 0, 008 subfield 0, 040 subfield c,245 subfield a, and 942 subfield c ) 3.3. Click on save 3.4. In the item form, Select Home library = B2 and Current library = B2 and type a Barcode. 3.5. Repeat 3.1 3.2 3.3 3.4 to create a second notice belong to B3 4. Have (or create) a default notice for all branches in Notices and Slips Module 5. Make sure you connected to branch B2 or Switch to branch B2 6. checkout item I2 (belonging to B2) to the user created in step 2 (specifying as due date the day before (1 day overdue)) 7. switch to branch B3 8. checkout item I3 (belonging to B3) to the user created in step 2 (specifying as due date the day before (1 day overdue)) 9. make sure you have defined 'Overdue notice/status triggers' for that patron category, ie with Delay=1 so that 'Overdue Notice' is selected and 'Email' is checked. Note: we have a user belong to B1, two item: I2 belong to B2, I3 belong to B3 and the user has borrowed I2 from B2 and I3 from B3. 10. Test 10.1. Search for OverdueNoticeFrom in System preferences and select item home library 10.2. from cli run 'perl ./misc/cronjobs/overdue_notices.pl' => Two new entries will be generated in message_queue DB table, coming from different branches that have the SAME list of overdue items. => The sender address is the item home library address for each entry. 11. Apply the patch 12. Search for OverdueNoticeFrom in System preferences => There is now 'patron home library' in the options list 13. Select patron home library 14. from cli run 'perl ./misc/cronjobs/overdue_notices.pl' => You will see that only one message had been created. Its content shows both B2 and B3 overdue items => The sender address matches B1 address (the patron home library). 15. Search for OverdueNoticeFrom in System preferences and select cron 16. from cli run './misc/cronjobs/overdue_notices.pl --frombranch patron-homebranch' => you will get the same result at step 14 Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Hinemoea Viault <hinemoea.viault at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 22:24:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 20:24:41 +0000 Subject: [Koha-bugs] [Bug 33698] New: Add fields to verbose output of cronjob delete_items.pl Message-ID: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33698 Bug ID: 33698 Summary: Add fields to verbose output of cronjob delete_items.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: Laura.escamilla at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Currently the log for delete_items.pl only shows the item numbers for items that could not be deleted. It would be useful to also show the item's barcode and title information for easier searching. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 22:24:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 20:24:58 +0000 Subject: [Koha-bugs] [Bug 33699] New: Typo in identity_provider_domains.tt (presedence) Message-ID: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Bug ID: 33699 Summary: Typo in identity_provider_domains.tt (presedence) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org In identity_provider_domains.tt, there is a typo in the sentence Exact matches have presedence over wildcard ones, so 'library.com' domain will take presedence over '*library.com' when the email is 'somebody at library.com' "presedence" should be "precedence" in both occurrences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 22:25:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 20:25:39 +0000 Subject: [Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence) In-Reply-To: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33699-70-imWY7uniEl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 22:25:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 20:25:38 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24194-70-952lxGTmoP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 --- Comment #64 from David Nind <david at davidnind.com> --- Hi Nicolas. Since you have signed off, you should change the status to Signed Off. That way you will get credit on the dashboard (https://dashboard.koha-community.org/). David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 22:37:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 20:37:31 +0000 Subject: [Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence) In-Reply-To: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33699-70-D0ZICcFqMt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I just noticed there is more than one sentence with the term "presedence". The same way, the longest match will take presedence over the shorter one, so '*teacher.university.com' will take presedence over '*.university.com' if the email is 'user at math.teacher.university.com' Each sentence is repeated twice in the file, for a total of 8 occurrences of "presedence" to correct. I also noticed that one of the sentences has superfluous words. Exact matches have presedence over asterix ones, so if the 'library.com' domain will take presedence over '*library.com' when the email is 'somebody at library.com' "so if the" in the other sentence that is the same is simply "so". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 22:48:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 20:48:04 +0000 Subject: [Koha-bugs] [Bug 33069] File download from list in OPAC gives error In-Reply-To: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33069-70-EVsthiKeW8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Hinemoea Viault <hinemoea.viault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150631|0 |1 is obsolete| | --- Comment #7 from Hinemoea Viault <hinemoea.viault at inlibro.com> --- Created attachment 150807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150807&action=edit Bug 33069: Fix error in MARC download for OPAC lists There was a code typo causing an error when you tried to download a list in MARC format: Not a CODE reference at /kohadevbox/koha/opac/opac-downloadshelf.pl line 93 To test: * In the OPAC: create a new list, public or private, with some records * Open the list * Try to download the list as MARC * Verify you get an error * Apply patch * Verify you now get the expected download file * Sign off :) Co-authored-by: Kévin AYRAULT <kevin.ayrault87 at gmail.com> Signed-off-by: Magnus Enger <magnus at libriotech.no> Nasty error before the patch; nice, tasty MARC download after. Signed-off-by: Hinemoea Viault <hinemoea.viault at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:11:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:11:04 +0000 Subject: [Koha-bugs] [Bug 33643] Add page-section to 'scan index' page In-Reply-To: <bug-33643-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33643-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33643-70-FIYd9g9f7f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33643 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Setting to PQA by counting Lucas for QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:11:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:11:46 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24194-70-gDAyaErhNh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Nicolas Giraud <nicolas.giraud at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nicolas.giraud at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:14:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:14:12 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24194-70-0RSXezEAma@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 --- Comment #65 from Nicolas Giraud <nicolas.giraud at inlibro.com> --- Hi David, I've just modified it, sorry ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:19:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:19:06 +0000 Subject: [Koha-bugs] [Bug 33696] Doubled up home icon in budgets page In-Reply-To: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33696-70-3Bsu3gMEfJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33696 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:19:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:19:09 +0000 Subject: [Koha-bugs] [Bug 33696] Doubled up home icon in budgets page In-Reply-To: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33696-70-Au8XRTh4wG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33696 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150796|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150808&action=edit Bug 33696: Fix doubled up home icon in budgets page To test: 1. Go to the Administration > Budgets page => FAIL: Breadcrumbs show two little house icons 2. Apply this patch 3. Reload page => SUCCESS: Only one icon 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:20:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:20:11 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-a7c9APzpNt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:20:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:20:14 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-2FSJCLwMm2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150804|0 |1 is obsolete| | --- Comment #10 from David Nind <david at davidnind.com> --- Created attachment 150809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150809&action=edit Bug 33412: Fix comparison when checking for overlay framework TO test: 1 - Cataloging -> Export catalog data 2 - Export a record fom your catalog 3 - Cataloging -> Stage record for import 4 - Import the record, use Record matchign rule: KohaBiblio (999c) 5 - Stage, view batch 6 - Record should match the one that was exported 7 - When replacing record use this framework, choose a different value than current framework of record 8 - Import this batch 9 - View and edit record - note framework did not change 10 - Apply patch 11 - Restart all 12 - Repeat 4-8 13 - View and edit record, confirm framework has changed 14 - Sign off Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:20:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:20:43 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-nOU4Wf4KBd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33594 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I wonder if there could be some similarities to bug 33594 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:20:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:20:43 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-amv0gzIwIr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26472 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:24:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:24:02 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-oxLDgVxYgR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:32:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:32:04 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-cNUEur4DH6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I've now repeated the steps several times, but this doesn't seem to work right for me: 1) Exported Perl best practices (biblionumber 5) 2) Staged for import, match on biblionumber, replace, don't process items 3) The record matched on biblionumber 4) When replacing records use this framework: Kit 5) Imported the record 6) Framework remains Books, Booklets, ... Patch was applied, restarted all multiple times. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:37:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:37:36 +0000 Subject: [Koha-bugs] [Bug 32766] Update plugin unimarc_field_116.pl fields In-Reply-To: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32766-70-2baukIUu0j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32766 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:37:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:37:39 +0000 Subject: [Koha-bugs] [Bug 32766] Update plugin unimarc_field_116.pl fields In-Reply-To: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32766-70-At3VHSEhtk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32766 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150794|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150810&action=edit Bug 32766: Update some labels for better understanding and translation examples: 'crayon'->'carchoal' or 'camaiu'->'cameo' Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:37:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:37:41 +0000 Subject: [Koha-bugs] [Bug 32766] Update plugin unimarc_field_116.pl fields In-Reply-To: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32766-70-57TbwSF19C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32766 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150795|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150811&action=edit Bug 32766: (follow-up) Fix translation function The previous syntax causes a warning during the execution of the translation script Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:37:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:37:44 +0000 Subject: [Koha-bugs] [Bug 32766] Update plugin unimarc_field_116.pl fields In-Reply-To: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32766-70-W025kHfrTP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32766 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150812&action=edit Bug 32766: (QA follow-up) Remove stray p from USE statements +q[% SET footerjs = 1 %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:37:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:37:55 +0000 Subject: [Koha-bugs] [Bug 32766] Update plugin unimarc_field_116.pl fields In-Reply-To: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32766-70-Tbf1f3hLR9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32766 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- There is something wrong here: +q[% SET footerjs = 1 %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:39:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:39:55 +0000 Subject: [Koha-bugs] [Bug 33395] Patron search results shows only overdues if patron has overdues In-Reply-To: <bug-33395-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33395-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33395-70-Y16nrgDrOP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:40:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:40:37 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-MEh6zUPUxj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:52:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:52:23 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-aDQO74LTnv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:52:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:52:26 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-5DHGmeLQHX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150793|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150813&action=edit Bug 33594: Only sort on title main heading This patch simply remvoes sort from all elements that are not strictly the main title Note: If multiple fields are set as sort, they are collapsed into a single entry in the {field}__sort field in the ES index. The order will be determined by the order in the marc record To test: 1 - Apply patch 2 - perl misc/search_tools/rebuild_elasticsearch -r -v 3 - Search the catalog 4 - Sort by title 5 - Confirm records are correct 6 - Add a 240 (before the 245) with subfield a 'AAAAA' 7 - Confirm sorting is not affected 8 - View record details, click 'Elasticsearch record: Show' 9 - Find 'title__sort' and confirm it looks correct (does not include AAAAA) Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:56:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:56:45 +0000 Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31132-70-UUpJhL7NkE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:56:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:56:47 +0000 Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31132-70-N0AUrBgSBj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150696|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150814&action=edit Bug 31132: Add button to clear the cataloguing auth finder form This enhancement adds a 'Clear form' link to empty all of the input fields on the authority finder plugin form when cataloguing bibliographic records. To test: 1) Search for a bibliographic record in the staff interface 2) Edit a record 3) Go to tabs 1, 6 or 7 to find a tag linked to the authority finder plugin 4) Launch the authority finder plugin by clicking the Tag editor icon at the end of the field 5) If the fields are empty, add some text in the text fields 6) Click the 'Clear form' link at the bottom of the form 7) Confirm the text is cleared from the input fields and the form is empty Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: nicolas <nicolas at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:56:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:56:50 +0000 Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31132-70-1JS8pTat2P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150697|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150815&action=edit Bug 31132: (follow-up) Reset dropdown values and style button This follow-up patch resets the dropdown values of the form alongside the text inputs. It styles the button to look like a link so it doesn't distract the user and get 'accidentally' clicked when attempting to submit. Test that the button looks and behaves as expected after submitting a search. Signed-off-by: nicolas <nicolas at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 8 23:58:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 21:58:26 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-tJvQgIVvNS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This will make the home release notes| |library and holding library | |on the item form manatory | |for new installations. It's | |recommended to also | |manually make these changes | |for existing installations | |as Koha won't function | |properly if any of these | |fields are missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 00:00:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 22:00:42 +0000 Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31132-70-iYkx1TMkjB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 00:01:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 22:01:08 +0000 Subject: [Koha-bugs] [Bug 33687] Clicking on a sys pref sub-menu item does not scroll to that item In-Reply-To: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33687-70-geMFdesU7q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 00:03:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 22:03:43 +0000 Subject: [Koha-bugs] [Bug 33687] Clicking on a system preference sub-menu item does not scroll to that item In-Reply-To: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33687-70-42dQVVIsZL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Clicking on a sys pref |Clicking on a system |sub-menu item does not |preference sub-menu item |scroll to that item |does not scroll to that | |item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 00:05:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 22:05:19 +0000 Subject: [Koha-bugs] [Bug 33687] Clicking on a system preference sub-menu item does not scroll to that item In-Reply-To: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33687-70-q2rw0FLTxt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Is it possible this was already fixed elsewhere or is browser dependent? I just tried without the patches applied and it works for me (Enhanced content - Overdrive) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 00:07:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 22:07:40 +0000 Subject: [Koha-bugs] [Bug 33687] Clicking on a system preference sub-menu item does not scroll to that item In-Reply-To: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33687-70-fJTxF3Xqob@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Also: patch currently doesn't apply: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 33687: Restore scroll to sub-tab Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 33687: Restore scroll to sub-tab hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-33687-Restore-scroll-to-sub-tab-a82QmL.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 00:10:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 22:10:33 +0000 Subject: [Koha-bugs] [Bug 33673] Global system preferences - change to just system preferences In-Reply-To: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33673-70-dO39HB2le7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 00:10:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 22:10:36 +0000 Subject: [Koha-bugs] [Bug 33673] Global system preferences - change to just system preferences In-Reply-To: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33673-70-IrPIXy6syC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150733|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150816&action=edit Bug 33673: Change "global system preferences" to "system preferences" The Koha Community normally refers to "global system preferences" as just "system preferences". This updates the staff interface and other occurences to refelect this, including: - Administration > Global system preferences and the description - Patrons > [a patron] > More > Set permissions > Manage Koha system settings > Manage global system preferences (manage_sysprefs) - The installer files and the database (permissions table) Test plan: 1. Note that in the staff interface "Global system preferences" is dispalyed in two places: 1.1 Administration: Go to Administration. There is a section called "Global system preferences" with a description and a search box. 1.2 User permissions: View the details for a patron > More > Set permissions > expand 'Manage Koha system settings' > scroll down to 'Manage global system preferences (manage_sysprefs)' 2. Apply the patch. 3. Update the database. 4. Revisit the pages in step 1 - these should now show as "System prefereneces" or "system preferences" as appropriate. 5. Sign off! Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Magnus Enger <magnus at libriotech.no> I agree with this change, consistency is good. As far as I can see this patch cathes all the occurrences of "global". Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 00:14:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 22:14:07 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-s5XRPHR8SY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 --- Comment #12 from David Nind <david at davidnind.com> --- Created attachment 150817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150817&action=edit Screenshots - settings and results after patch applied I tested again, using the record you used, and it still worked for me. So I'm not sure why it isn't working for you 8-(. I also tested with settings changed about not checking for embedded data and not importing items (even though there isn't in this case), but it still worked. Also, I normally go flushed_memcached and restart_all after applying a patch, as well as using a fresh browser (with a cleared cache). This time I just did a restart_all and then used the same browser windows. It still worked OK. In addition, I re-staged the file for import, rather than using the previously staged batch. I've attached some screenshots of the settings I used and the results, if this helps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 00:16:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 22:16:36 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-MH7GLoeLf3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi David, thx for taking the time! I'll reset to Signed off, I won't have time right now to dig deeper on this one and another set of eyes might help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 00:19:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 22:19:18 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24194-70-RGFFpxSU3l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 --- Comment #66 from David Nind <david at davidnind.com> --- No problem! We all do this every now and again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 00:37:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 22:37:13 +0000 Subject: [Koha-bugs] [Bug 33700] New: Allow setting for CircConfirmItemParts to checkout via self check Message-ID: <bug-33700-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33700 Bug ID: 33700 Summary: Allow setting for CircConfirmItemParts to checkout via self check Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be great if we could add an option to either allow checking out without confirmation or set up a way to confirm, like maybe scanning the barcode again to confirm items are present. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 01:08:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 23:08:01 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-uQgXeyz3Zx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 01:09:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 23:09:47 +0000 Subject: [Koha-bugs] [Bug 33563] Document Elasticsearch secure mode In-Reply-To: <bug-33563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33563-70-l4rqsFePcy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33563 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 01:11:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 23:11:30 +0000 Subject: [Koha-bugs] [Bug 33503] Plugin OpenAPI2.0 specification schema fragments are not resolved. Merge full schema definitions. In-Reply-To: <bug-33503-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33503-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33503-70-vp1Peuc4FQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33503 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 01:13:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 23:13:11 +0000 Subject: [Koha-bugs] [Bug 33413] Make staff notices digest-able for OPAC_REG and NEW_SUGGESTION In-Reply-To: <bug-33413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33413-70-i67G3DrgXI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33413 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 01:49:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 May 2023 23:49:26 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-6ZdBF6FCe1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 Janusz Kaczmarek <januszop at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop at gmail.com --- Comment #4 from Janusz Kaczmarek <januszop at gmail.com> --- I'm unable to verify it right now, but maybe somebody could -- if adding "alternate: shifted" in admin/searchengine/elasticsearch/field_config.yaml here: sort: default: type: icu_collation_keyword index: false numeric: true + alternate: shifted would solve the issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 03:33:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 01:33:52 +0000 Subject: [Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30579-70-MkjIYkVwZ7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #33 from David Nind <david at davidnind.com> --- Hi Hinemoea. As you have signed off this bug, could you update the bug status to Signed Off? That way, you will get the credit on the dashboard (https://dashboard.koha-community.org/). (It will also move in to the Needs QA queue, for the QA Team to do their thing!) David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 03:37:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 01:37:01 +0000 Subject: [Koha-bugs] [Bug 32765] Transfer is not retried after cancelling hold In-Reply-To: <bug-32765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32765-70-dowMXzK4PJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #8 from David Nind <david at davidnind.com> --- Hi Nicolas. Another one for you to change the status to Signed Off, so that you get the credit on the dashboard. 8-) David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 03:44:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 01:44:12 +0000 Subject: [Koha-bugs] [Bug 33691] Improve query for do_check_for_previous_checkout In-Reply-To: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33691-70-Fw3v0vKY1E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33691 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 03:44:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 01:44:15 +0000 Subject: [Koha-bugs] [Bug 33691] Improve query for do_check_for_previous_checkout In-Reply-To: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33691-70-qNrHZIu4rd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33691 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150785|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Created attachment 150818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150818&action=edit Bug 33691: Improve query for do_check_for_previous_checkout do_check_for_previous_checkout will pass a list of itemnumbers as part of the query. This could be hundreds of items or more. It makes sense to check by biblionumber instead when possible. Test Plan: 1) prove t/db_dependent/Patron/Borrower_PrevCheckout.t 2) Apply this patch 3) prove t/db_dependent/Patron/Borrower_PrevCheckout.t 4) Test still pass! Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 03:48:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 01:48:18 +0000 Subject: [Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout) In-Reply-To: <bug-22322-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22322-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22322-70-5twv6zUhyQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #11 from David Nind <david at davidnind.com> --- Hi Hinemoea. Another one for you to change the status to Signed Off, so that you get the credit on the dashboard. 8-) David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 04:17:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 02:17:49 +0000 Subject: [Koha-bugs] [Bug 33701] New: Catalogue detail page no longer shows all tab data when printing Message-ID: <bug-33701-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33701 Bug ID: 33701 Summary: Catalogue detail page no longer shows all tab data when printing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Before the staff interface styling change, the data for the tabs "Holdings", "Descriptions", "Acquisition details", "Images", etc would be printed out vertically when printing the detail page. Now, when printing the detail page in the staff interface, it just shows the tab headings and the content/data for the active tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 04:46:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 02:46:55 +0000 Subject: [Koha-bugs] [Bug 33701] Catalogue detail page no longer shows all tab data when printing In-Reply-To: <bug-33701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33701-70-QG63AecEjj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33701 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |dcook at prosentient.com.au --- Comment #1 from David Cook <dcook at prosentient.com.au> --- I'm attaching a patch which will work but there's more print CSS work to do on this page, and we might want to consider an alternative approach across the board. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 04:47:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 02:47:13 +0000 Subject: [Koha-bugs] [Bug 33701] Catalogue detail page no longer shows all tab data when printing In-Reply-To: <bug-33701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33701-70-baIX6D5Erg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33701 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 04:47:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 02:47:16 +0000 Subject: [Koha-bugs] [Bug 33701] Catalogue detail page no longer shows all tab data when printing In-Reply-To: <bug-33701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33701-70-zZj2Pff7PM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33701 --- Comment #2 from David Cook <dcook at prosentient.com.au> --- Created attachment 150819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150819&action=edit Bug 33701: Display all tab content when printing staff cat detail page This change adds some print CSS to display all tab content when printing the catalogue detail page on the staff interface. Test plan: 1. Apply patch 2. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 3. Click "Print" on the toolbar 4. Note that the "Descriptions" and "Acquisition details" also appear on the printed page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 05:55:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 03:55:57 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-KYIiy4J5T8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 --- Comment #5 from Aleisha Amohia <aleisha at catalyst.net.nz> --- (In reply to Katrin Fischer from comment #3) > I wonder if there could be some similarities to bug 33594 I applied the fixes from Bug 33594 but it didn't seem to solve this problem, thank you anyway! (In reply to Janusz Kaczmarek from comment #4) > I'm unable to verify it right now, but maybe somebody could -- if adding > "alternate: shifted" in admin/searchengine/elasticsearch/field_config.yaml > here: > > sort: > default: > type: icu_collation_keyword > index: false > numeric: true > + alternate: shifted > > would solve the issue. This worked at least for upstream, I will attach a patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 06:00:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 04:00:16 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-jkDsmu75mo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 06:14:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 04:14:58 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-BFy4GUdmQh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 06:15:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 04:15:01 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-b1NCsEiQPn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 --- Comment #6 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150820&action=edit Bug 26472: Configure Elasticsearch for better alphabetic sorting This enhancement configures the ICU collation keyword plugin used by Elasticsearch for sorting to better handle punctuation and whitespace in sort fields. Details at: https://www.elastic.co/guide/en/elasticsearch/plugins/current/analysis-icu-collation-keyword-field.html To test: 1. Create three authority records with the following values: 150 $a Science 150 $a Science $v B 150 $a Science $v C 2. Search for your authority records with "Science" in "Heading A-Z" order The search results will likely be in this order: 1. Science B 2. Science C 3. Science This is an unexpected order 3. Apply the patch and reindex sudo koha-elasticsearch --rebuild -r <instancename> 4. Search for your authority records again with "Science" in "Heading A-Z" order Confirm your search results show in the correct order. 1. Science 2. Science B 3. Science C Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 08:10:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 06:10:31 +0000 Subject: [Koha-bugs] [Bug 33701] Catalogue detail page no longer shows all tab data when printing In-Reply-To: <bug-33701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33701-70-hQ8pZfpohw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33701 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 09:01:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 07:01:46 +0000 Subject: [Koha-bugs] [Bug 33472] Error 500 when many items attached to bib record In-Reply-To: <bug-33472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33472-70-WJKIJW6q3w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33472 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- What is the error you have in Koha logs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 09:20:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 07:20:57 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-skiPvdUcgL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150821&action=edit Bug 33653: Use filter_by_active instead We have filter_by_active that is filtering by status already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 09:21:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 07:21:40 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-IFmr9nRCZQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Tomás Cohen Arazi from comment #8) > This is correct but: shouldn't we chain ->filter_by_active instead? Yes, that makes sense. Katrin, do you agree? I have removed the existing condition on status in filter_by_lates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 09:23:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 07:23:15 +0000 Subject: [Koha-bugs] [Bug 33687] Clicking on a system preference sub-menu item does not scroll to that item In-Reply-To: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33687-70-v8P4vsn6so@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 --- Comment #6 from Andreas Roussos <a.roussos at dataly.gr> --- (In reply to Katrin Fischer from comment #4) > Is it possible this was already fixed elsewhere or is browser dependent? Please see earlier Bug 33634, looks like it was fixed there. However, as per the patch Pedro has provided here, the TT filter for the TAB.tab_id variable needs to be 'htmlId' instead of 'html'. (In reply to Katrin Fischer from comment #5) > Also: patch currently doesn't apply: Looks like the same line (line 200) in the template file was modified by commit 0d1278aa14b from Bug 33634. That would explain why this patch currently doesn't apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 09:25:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 07:25:17 +0000 Subject: [Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section In-Reply-To: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33634-70-W9gSDDcHJK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32926 CC| |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 [Bug 32926] Cannot expand or collapse some System preference sections after a search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 09:25:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 07:25:17 +0000 Subject: [Koha-bugs] [Bug 32926] Cannot expand or collapse some System preference sections after a search In-Reply-To: <bug-32926-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32926-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32926-70-Ng4VFnKC5V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33634 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 09:28:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 07:28:04 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-twsDiDCqcD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 09:28:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 07:28:07 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-68F2AH1EtF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150809|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150822&action=edit Bug 33412: Fix comparison when checking for overlay framework TO test: 1 - Cataloging -> Export catalog data 2 - Export a record fom your catalog 3 - Cataloging -> Stage record for import 4 - Import the record, use Record matchign rule: KohaBiblio (999c) 5 - Stage, view batch 6 - Record should match the one that was exported 7 - When replacing record use this framework, choose a different value than current framework of record 8 - Import this batch 9 - View and edit record - note framework did not change 10 - Apply patch 11 - Restart all 12 - Repeat 4-8 13 - View and edit record, confirm framework has changed 14 - Sign off Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 09:29:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 07:29:06 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-7CjlGcbJ42@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Severity|normal |major Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 10:00:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 08:00:12 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-dRGu195YJF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- If I am reading that right: { '-or' => [ { 'basket.is_standing' => 1, 'orderstatus' => [ 'new', 'ordered', 'partial' ] }, { 'orderstatus' => [ 'ordered', 'partial' ] } ] } * It's a standing order with new, ordered or partial * It's ordered or partial That should work ok here. I believe the standing orders could be an issue, but if I understand the code correctly, they are already showing up in the late orders: - ( orderstatus => { '!=' => 'cancelled' } ), + ( orderstatus => { '-not_in' => ['cancelled', 'complete'] } ), If the delivery date is calculated from the order date, they will all be "late" for the 'new' order line and there is no way to tell that it is a standing order in the results list... probably something for a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 10:14:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 08:14:51 +0000 Subject: [Koha-bugs] [Bug 33684] Able to save patron with empty mandatory date fields In-Reply-To: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33684-70-NCYW1tR4zZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33684 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 10:14:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 08:14:54 +0000 Subject: [Koha-bugs] [Bug 33684] Able to save patron with empty mandatory date fields In-Reply-To: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33684-70-U0psbkhPZp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33684 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150823&action=edit Bug 33684: Make mandatory date fields required when editing a patron Date fields in BorrowerMandatoryField are not required by the validation form when a new patron is added or modified. This is because the 'required' prop does not exist on the input element when the flatpickr instance is created. We should either add it in the DOM directly (tt), but it will require to do it "manually" for each date fields, or add it when we add it to the inputs. This patch implements the second option. Test plan: 1. Add "dateofbirth" to syspref BorrowerMandatoryField. 2. Add patron and leave date of birth input field empty. 3. Save. => Form is not submitted and you are asked to fill in a date of birth -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 10:16:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 08:16:21 +0000 Subject: [Koha-bugs] [Bug 33684] Able to save patron with empty mandatory date fields In-Reply-To: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33684-70-Bhczks8XGU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33684 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 10:24:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 08:24:20 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-5Pva2QnCdA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 10:24:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 08:24:23 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-Usm22ntvce@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150629|0 |1 is obsolete| | Attachment #150630|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150824&action=edit Bug 33671: Fix for 30472 - Remove null-guarantors These guarantors cannot be added. They are of no use. NOTE FOR QA/RM: I do not think that it is needed to add a new db rev for this change since it happens seldom. But if you think that it is, just copy it to atomicupdate/change bugno. Test plan: [1] Check your table definition and modify it: alter table borrower_relationships modify column `guarantor_id` int(11) NULL; [2] Add an empty guarantor: insert into borrower_relationships (guarantee_id,relationship) values (SOME_PATRON_ID,'father'); [3] Run the dbrev and verify that the inserted record has been removed. [4] Check table definition with 'show create table borrower_relationships'. You should see NOT NULL with guarantor_id. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 10:24:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 08:24:26 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-NnuB9zPbYr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150825&action=edit Bug 33671: Update POD, remove unneeded check in relationship->guarantor [1] Update POD for $patron->guarantor_relationships [2] Remove check from Patron::Relationship->guarantor Test plan: Run t/db_dependent/Koha/Patron.t Run t/db_dependent/Patron/Relationships.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 10:24:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 08:24:34 +0000 Subject: [Koha-bugs] [Bug 33684] Able to save patron with empty mandatory date fields In-Reply-To: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33684-70-q1OzPvTzIf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33684 Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150823|0 |1 is obsolete| | --- Comment #3 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> --- Created attachment 150826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150826&action=edit Bug 33684: Make mandatory date fields required when editing a patron Date fields in BorrowerMandatoryField are not required by the validation form when a new patron is added or modified. This is because the 'required' prop does not exist on the input element when the flatpickr instance is created. We should either add it in the DOM directly (tt), but it will require to do it "manually" for each date fields, or add it when we add it to the inputs. This patch implements the second option. Test plan: 1. Add "dateofbirth" to syspref BorrowerMandatoryField. 2. Add patron and leave date of birth input field empty. 3. Save. => Form is not submitted and you are asked to fill in a date of birth Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 10:24:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 08:24:41 +0000 Subject: [Koha-bugs] [Bug 33684] Able to save patron with empty mandatory date fields In-Reply-To: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33684-70-0UoEZqzBgr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33684 Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 10:39:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 08:39:27 +0000 Subject: [Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods In-Reply-To: <bug-32476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32476-70-zHiLL9BTcS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32894 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 10:39:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 08:39:27 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-Fpgob0rltR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32476 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 10:50:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 08:50:08 +0000 Subject: [Koha-bugs] [Bug 33687] Clicking on a system preference sub-menu item does not scroll to that item In-Reply-To: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33687-70-tUeWBIurwD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33687 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #7 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Thanks everyone, yes this certainly is a duplicate of bug 33634 *** This bug has been marked as a duplicate of bug 33634 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 10:50:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 08:50:08 +0000 Subject: [Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section In-Reply-To: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33634-70-RtuzOs2wEm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m --- Comment #5 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- *** Bug 33687 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:04:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:04:13 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-KiDDnSxSju@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150827&action=edit Bug 32894: (follow-up) Koha::Item->last_returned_by -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:04:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:04:15 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-Woxg6gEhUw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150828&action=edit Bug 32894: Make ->sharee looks like others -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:04:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:04:57 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-i9Hc9oFFkN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Assignee|martin.renvoize at ptfs-europe |jonathan.druart+koha at gmail. |.com |com --- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Nick Clemens from comment #18) > Something is not right with Koha::Item::last_returned_by > > It returns a patron object, but the relationship is to ItemsLastBorrower and > the call to set it doesn't work > > prove -v t/db_dependent/Circulation/StoreLastBorrower.t Oops! Thanks! > Also Koha/Virtualshelfshare.pm : > everywhere else we assign resultset to rs, then create new - it isn't wrong, > just inconsistent Done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:34:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:34:57 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-3K5SaU7Q0F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- After talking to Joubu I realized we only include the new ones for standing orders now - this is another enhancement :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:42:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:42:29 +0000 Subject: [Koha-bugs] [Bug 33613] Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge In-Reply-To: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33613-70-oU8pyZvbnb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:42:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:42:32 +0000 Subject: [Koha-bugs] [Bug 33613] Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge In-Reply-To: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33613-70-nuMvqZAguX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150802|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150829&action=edit Bug 33613: Use prop() to evaluate checkbox To test: 1. Have an item with a replacement cost checked out to a patron 2. Set the ClaimReturnedChargeFee sys pref to "Ask if a lost fee should be charged" 3. Make a claim and check the box for charging. 4. Claim happens but no charge occurs. 5. Apply patch and try again. 6. A charge should now occur. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Hinemoea Viault <hinemoea.viault at inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:42:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:42:56 +0000 Subject: [Koha-bugs] [Bug 33613] Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge In-Reply-To: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33613-70-KTPKwaHkDp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29983 CC| |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:42:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:42:56 +0000 Subject: [Koha-bugs] [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt) In-Reply-To: <bug-29983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29983-70-S9NMOSdBGR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33613 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 [Bug 33613] Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:44:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:44:02 +0000 Subject: [Koha-bugs] [Bug 33648] Errors when enabling ERM in 22.11 In-Reply-To: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33648-70-0PmabPuevn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33648 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150830&action=edit Bug 33684: Make mandatory date fields required when editing a patron Date fields in BorrowerMandatoryField are not required by the validation form when a new patron is added or modified. This is because the 'required' prop does not exist on the input element when the flatpickr instance is created. We should either add it in the DOM directly (tt), but it will require to do it "manually" for each date fields, or add it when we add it to the inputs. This patch implements the second option. Test plan: 1. Add "dateofbirth" to syspref BorrowerMandatoryField. 2. Add patron and leave date of birth input field empty. 3. Save. => Form is not submitted and you are asked to fill in a date of birth Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:44:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:44:23 +0000 Subject: [Koha-bugs] [Bug 33684] Able to save patron with empty mandatory date fields In-Reply-To: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33684-70-SUvjeWeLbm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33684 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:44:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:44:26 +0000 Subject: [Koha-bugs] [Bug 33684] Able to save patron with empty mandatory date fields In-Reply-To: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33684-70-zwfp5nBPdr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33684 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150826|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150831&action=edit Bug 33684: Make mandatory date fields required when editing a patron Date fields in BorrowerMandatoryField are not required by the validation form when a new patron is added or modified. This is because the 'required' prop does not exist on the input element when the flatpickr instance is created. We should either add it in the DOM directly (tt), but it will require to do it "manually" for each date fields, or add it when we add it to the inputs. This patch implements the second option. Test plan: 1. Add "dateofbirth" to syspref BorrowerMandatoryField. 2. Add patron and leave date of birth input field empty. 3. Save. => Form is not submitted and you are asked to fill in a date of birth Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> https://bugs.koha-community.org/show_bug.cgi?id=33648 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:45:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:45:16 +0000 Subject: [Koha-bugs] [Bug 32959] Item Templates will apply the same barcode each time template is applied if autobarcode is enabled In-Reply-To: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32959-70-5e4DBsyK05@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32959 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24606 CC| |jonathan.druart+koha at gmail. | |com Version|22.11 |unspecified Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 [Bug 24606] Allow storing item values as a template for creating new items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:45:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:45:16 +0000 Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24606-70-FP2Q1drrIA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32959 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32959 [Bug 32959] Item Templates will apply the same barcode each time template is applied if autobarcode is enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:45:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:45:17 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-HKXDkjrmlQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150686|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:46:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:46:53 +0000 Subject: [Koha-bugs] [Bug 33648] Errors when enabling ERM in 22.11 In-Reply-To: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33648-70-JI2bfEslYT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33648 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150830|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Comment on attachment 150830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150830 Bug 33684: Make mandatory date fields required when editing a patron Bug number typo, sorry for the noise -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:48:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:48:33 +0000 Subject: [Koha-bugs] [Bug 32959] Item Templates will apply the same barcode each time template is applied if autobarcode is enabled In-Reply-To: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32959-70-vf3zuohQFj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32959 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:48:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:48:35 +0000 Subject: [Koha-bugs] [Bug 32959] Item Templates will apply the same barcode each time template is applied if autobarcode is enabled In-Reply-To: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32959-70-GjIfiXtEvE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32959 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150694|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150832&action=edit Bug 32959: Don't store results of autobarcode in item editor templates Test Plan: 1) Enable autobarcode 2) Create a new item template, leave the barcode field blank 3) Apply that item template 4) Note the template prefills the barcode field 5) Delete that item template 6) Apply this patch 7) Restart all the things! 8) Repeat steps 2-4 9) Note the barcode field remains empty! Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:48:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:48:45 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-u3V31iJbQq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150686|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:52:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:52:06 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-V0r15mXqOA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:52:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:52:09 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-SfT4icnCUQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150686|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150833&action=edit Bug 33653: Never consider received orders as late We should not list received orders on the late orders page. Test plan: * Create a basket * Create a normal order (not from a subscription, no standing order) * Leave estimated delivery date empty * Close the basket * Create a new invoice and receive the order line * Go to acq > late orders * Verify the order is not in the list * Set filter for 'To' date into the future, i.e. 01/01/2025 => Without this patch the order shows up => With this patch applied the received order does not show up Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:52:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:52:11 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-nL88FmhZWV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150821|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150834&action=edit Bug 33653: Use filter_by_active instead We have filter_by_active that is filtering by status already. Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:53:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:53:29 +0000 Subject: [Koha-bugs] [Bug 33069] File download from list in OPAC gives error In-Reply-To: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33069-70-2uac9CXWiT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Depends on| |29697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:53:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:53:29 +0000 Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29697-70-IiUGmMMx8d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33069 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 [Bug 33069] File download from list in OPAC gives error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:55:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:55:47 +0000 Subject: [Koha-bugs] [Bug 33069] File download from list in OPAC gives error In-Reply-To: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33069-70-rq5hYHVnB4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:55:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:55:50 +0000 Subject: [Koha-bugs] [Bug 33069] File download from list in OPAC gives error In-Reply-To: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33069-70-UF8caUbG9L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150807|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150835&action=edit Bug 33069: Fix error in MARC download for OPAC lists There was a code typo causing an error when you tried to download a list in MARC format: Not a CODE reference at /kohadevbox/koha/opac/opac-downloadshelf.pl line 93 To test: * In the OPAC: create a new list, public or private, with some records * Open the list * Try to download the list as MARC * Verify you get an error * Apply patch * Verify you now get the expected download file * Sign off :) Co-authored-by: Kévin AYRAULT <kevin.ayrault87 at gmail.com> Signed-off-by: Magnus Enger <magnus at libriotech.no> Nasty error before the patch; nice, tasty MARC download after. Signed-off-by: Hinemoea Viault <hinemoea.viault at inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 11:56:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 09:56:05 +0000 Subject: [Koha-bugs] [Bug 33069] File download from list in OPAC gives error In-Reply-To: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33069-70-pZO5psgCJI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate Severity|normal |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 12:02:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 10:02:10 +0000 Subject: [Koha-bugs] [Bug 32959] Item Templates will apply the same barcode each time template is applied if autobarcode is enabled In-Reply-To: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32959-70-ZhEGKZOqAi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32959 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, looks like we overlapped, I was just writing this up: I can't reproduce this error in master. What I did: * Activate Autobarcode, I chose YYYY-0001 * Create a new item, leave barcode empty, save as template * Load the template = Barcode field is empty * Crate a new item, generate barcode, empty field, save as template * Load the template = Barcode field remains empty The only way I can replicate is if the barcode field is filled in when I create the template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 12:05:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 10:05:31 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-u2D03L9OkU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150836&action=edit [ALTERNATE PATCH] Bug 33607: Handle default framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 12:05:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 10:05:50 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-0zTpHHXxOy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- What about this patch, Nick? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 12:11:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 10:11:56 +0000 Subject: [Koha-bugs] [Bug 32959] Item Templates will apply the same barcode each time template is applied if autobarcode is enabled In-Reply-To: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32959-70-hXjiQcsHVC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32959 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- You need autobarcode=incremental -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 12:16:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 10:16:14 +0000 Subject: [Koha-bugs] [Bug 33567] Remove fallback for Reference_NFL_statuses in C4/XSLT module In-Reply-To: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33567-70-omrMN5NtqU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33567 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21260 CC| |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21260 [Bug 21260] Improve the Availability line of OPAC XSLT search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 12:16:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 10:16:14 +0000 Subject: [Koha-bugs] [Bug 21260] Improve the Availability line of OPAC XSLT search results In-Reply-To: <bug-21260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21260-70-70JnzpyBIn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21260 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33567 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33567 [Bug 33567] Remove fallback for Reference_NFL_statuses in C4/XSLT module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 12:23:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 10:23:08 +0000 Subject: [Koha-bugs] [Bug 33567] Remove fallback for Reference_NFL_statuses in C4/XSLT module In-Reply-To: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33567-70-P8BBdBpO3n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33567 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 12:23:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 10:23:11 +0000 Subject: [Koha-bugs] [Bug 33567] Remove fallback for Reference_NFL_statuses in C4/XSLT module In-Reply-To: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33567-70-g2aUUrPSmk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33567 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149921|0 |1 is obsolete| | Attachment #149922|0 |1 is obsolete| | Attachment #149923|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150837&action=edit Bug 33567: Empty NFL_statuses pref in unit test This test should fail now, since it would trigger the hardcoded fallback in the XSLT module. Test plan: Run t/db_dependent/XSLT.t Should fail. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 12:23:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 10:23:13 +0000 Subject: [Koha-bugs] [Bug 33567] Remove fallback for Reference_NFL_statuses in C4/XSLT module In-Reply-To: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33567-70-4LMyvWGJgT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33567 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150838&action=edit Bug 33567: Remove hardcoded fallback in module Test plan: Run t/db_dependent/XSLT.t again Should pass now. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 12:23:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 10:23:16 +0000 Subject: [Koha-bugs] [Bug 33567] Remove fallback for Reference_NFL_statuses in C4/XSLT module In-Reply-To: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33567-70-aBeXQfIWH6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33567 --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150839&action=edit Bug 33567: Add a dbrev for installation with empty pref To keep current behavior, we can copy the removed fallback into the syspref value in case someone might have cleared the pref. Note: We are not restoring deleted prefs here; that is a data problem outside the scope of this report. A regular installation should always have this pref. Test plan: Run updatedatabase.pl Bonus: Clear the pref Reference_NFL_Statuses and run again, verify that the pref has changed. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 12:28:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 10:28:36 +0000 Subject: [Koha-bugs] [Bug 30171] Creating a subfield without linking it to an authorized value is error 500 In-Reply-To: <bug-30171-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30171-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30171-70-XbMVjazV9W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30171 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Resolution|--- |WORKSFORME Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 12:54:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 10:54:12 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-Zisu7XpyYR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #9) > What about this patch, Nick? Yes, that's better, I need to learn translation tools :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:02:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:02:21 +0000 Subject: [Koha-bugs] [Bug 33567] Remove fallback for Reference_NFL_statuses in C4/XSLT module In-Reply-To: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33567-70-zKrnL0E67u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33567 --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #7) > Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Thx. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:15:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:15:02 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-0EMuCy8J19@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- OK.. I'm in need of help to progress this.. I've hit a point where I'm not sure how to proceed. The basic code works, but the circ rules are not tied in as yet and I'm struggling to work out how to achieve that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:24:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:24:46 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-xYDL9ZyKCw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:24:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:24:48 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-MD6ubOOHin@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150840&action=edit Bug 33608: Add two new circulation types in Statistics module These are: item_lost and item_found. Speak for themself. Test plan: Run t/db_dependent/Stats.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:24:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:24:50 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-Lf9UU0ZMlW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150841&action=edit Bug 33608: Add UpdateStats to item->store Test plan: Run t/db_dependent/Koha/Item.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:24:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:24:53 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-7fq8wCVGGx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150842&action=edit Bug 33608: Rearranging Stats.t, removing useless t version Subtest, modules, license. The t/Stats.t is as good as empty, can be removed. Test plan: Run t/db_dependent/Stats.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:24:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:24:55 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-Y1EVPXLIAe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150843&action=edit Bug 33608: Correct indentation in Stats.t Test plan: Run t/db_dependent/Stats.t Run git diff -w HEAD~1.. t/db_dependent/Stats.t, proving that we only did whitespace changes. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:24:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:24:57 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-N9kELd6PDP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150844&action=edit Bug 33608: Redirect UpdateStats to Koha namespace Moving code to Koha::Statistic->new and ->insert. Polishing code a bit further in next patch. Test plan: Run t/db_dependent/Stats.t Run t/db_dependent/Koha/Statistics.t Run t/db_dependent/Koha/Pseudonymization.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:24:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:24:59 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-wYHwxO5F8o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150845&action=edit Bug 33608: Polish Koha::Statistic further Adding exceptions, removing croaks. No exception in new for unknown hash keys, store will catch that. Prepare switching amount parameter to value (db column name). Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:25:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:25:01 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-WEWNp7WY6s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150846&action=edit Bug 33608: Move older Stats tests to Koha/Statistics.t Test plan: Run t/db_dependent/Koha/Statistics.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:33:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:33:05 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-NFKfkTsZ7O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #54 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:34:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:34:17 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-vTJ63tEEph@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:42:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:42:13 +0000 Subject: [Koha-bugs] [Bug 32959] Item Templates will apply the same barcode each time template is applied if autobarcode is enabled In-Reply-To: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32959-70-57vVZVaD9U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32959 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #6) > You need autobarcode=incremental That was not in the test plan! (but glad we could clear it up) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:51:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:51:02 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-wmzP8CGpR0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:51:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:51:04 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-S4DpQEnhCe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150016|0 |1 is obsolete| | Attachment #150017|0 |1 is obsolete| | Attachment #150018|0 |1 is obsolete| | Attachment #150019|0 |1 is obsolete| | Attachment #150020|0 |1 is obsolete| | Attachment #150021|0 |1 is obsolete| | Attachment #150827|0 |1 is obsolete| | Attachment #150828|0 |1 is obsolete| | --- Comment #22 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150847&action=edit Bug 32894: Remove wrong caching from Koha:: methods - simple In some of our Koha:: objects we have methods that cache their result and return it in subsequent calls. However there is no invalidation of the cache if the object is modified. For instance, in Koha/ArticleRequest.pm sub biblio { my ($self) = @_; $self->{_biblio} ||= Koha::Biblios->find( $self->biblionumber() ); return $self->{_biblio}; } This pattern exists in several places. It can lead to confusion and incorrect results, such as: use Koha::ArticleRequests; my $ar = Koha::ArticleRequest->new({ borrowernumber => 42, biblionumber => 42, })->store; say $ar->biblio->biblionumber; # Display 42, correct $ar->set({ biblionumber => 24 })->store; say $ar->biblio->biblionumber; # Display 42, wrong $ar->discard_changes; say $ar->biblio->biblionumber; # Display 42, wrong $ar->delete; We should remove those caching and rely on DBIC/DBMS caching mechanism instead. This patch is adjusting the trivial occurrences Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:51:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:51:06 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-9qDOW2ddC1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #23 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150848&action=edit Bug 32894: Koha::Item->last_returned_by Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:51:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:51:08 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-SstcwkW9MV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #24 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150849&action=edit Bug 32894: Koha::Biblio->biblioitem Can we do better here? Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:51:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:51:10 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-sx5L4jpHw5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #25 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150850&action=edit Bug 32894: Fix test Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:51:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:51:12 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-YSp5DFpSNR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #26 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150851&action=edit Bug 32894: Remove incorrect caching from bundle_items Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:51:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:51:15 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-wtFFhWPeu3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #27 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150852&action=edit Bug 32894: (QA follow-up) Fix typo Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:51:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:51:17 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-2CzS6SYj6J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #28 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150853&action=edit Bug 32894: (follow-up) Koha::Item->last_returned_by Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:51:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:51:19 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-xycvIrVNcr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #29 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150854&action=edit Bug 32894: Make ->sharee looks like others Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:51:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:51:21 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-rvImVs66gv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #30 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150855&action=edit Bug 32894: (QA follow-up) Fix tests Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:52:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:52:04 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-uN6hvjUlbb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #31 from Nick Clemens <nick at bywatersolutions.com> --- Looks good, t/db_dependent all pass now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:55:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:55:26 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-nyUeoJdtJ9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 --- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150856&action=edit k -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:55:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:55:54 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-T1A1zr4RE2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:55:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:55:57 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-r3FyJ5JqJi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150285|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150857&action=edit Bug 32914: Use template wrapper for batch record deletion and modification templates This patch updates the batch record modification and batch record deletion templates to replace tab markup with the use of WRAPPERs. This patch adds a "clearfix" snippet of CSS to _mixins.scss copied from Bootstrap. Applied to the active tab pane, this helps in situations where Bootstrap tabs follow a floated element. The patch also wraps tab label strings in <span> to ensure they can be translated. Unrelated: The patch removes an extra </option> from the batch record modification template. To test you should have at least one list and at least one MARC modification template defined. - Apply the patch and go to Cataloging -> Batch record modification - You should see three tabs, "Upload a file," "Select a list of records," and "Enter a list of record numbers." - The tabs should look correct and work correctly. - Checking the "Authorities" radio button should hide the lists tab. - Test that submissions from each form work correctly. - Go to Cataloging -> Batch record deletion and perform the same tests. Signed-off-by: Philip Orr <philip.orr at lmscloud.de> Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:55:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:55:59 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-ZwK3nkxnEa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150286|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150858&action=edit Bug 32914: (follow-up) Improve handling of list tab visibility This patch makes minor changes to the way this page handles switching between authority and bibliographic record batch operation in order to ensure that the list tab is correctly shown or hidden and that the list tab selection isn't transmitted when an authority batch is submitted. This patch also changes the labels on the "record type" fields to fix the incorrect use of the abbreviated "biblios" in favor of "Bibliographic." To test, apply the patch and go to Cataloging -> Batch record modification - With the "Bibliographic records" selected, click the "Select a list of records" tab." - Select the "Authority records" radio button. - The "Select a list of records" tab should disappear, and the "Upload a file" tab should now be selected." - Select the "Bibliographic records radio button. - The "Select a list of records" tab should reappear, and the "Upload a file" tab should be selected. - Test all combinations of form submissions to confirm that each works correctly: - Bibliographic records by upload, list, and biblionumber entry - Authory records by upload and authority record number entry Signed-off-by: Philip Orr <philip.orr at lmscloud.de> Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:56:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:56:40 +0000 Subject: [Koha-bugs] [Bug 33601] Use template wrapper for breadcrumbs: Tools, part 8 In-Reply-To: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33601-70-YX2PRywv0z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33601 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:58:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:58:44 +0000 Subject: [Koha-bugs] [Bug 33601] Use template wrapper for breadcrumbs: Tools, part 8 In-Reply-To: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33601-70-SPDaGVlsN5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33601 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:58:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:58:47 +0000 Subject: [Koha-bugs] [Bug 33601] Use template wrapper for breadcrumbs: Tools, part 8 In-Reply-To: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33601-70-t9wTa2UDpZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33601 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150173|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150859&action=edit Bug 33601: Use template wrapper for breadcrumbs: Tools, part 8 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Tools home page - Log viewer - Search result - Uploads - Upload results - Cataloging -> - Upload local cover image - Upload result - Test uploading an biblio-level image from the bibliographic detail page - Test uploading an item-level image from the bibliograhpic detail page's holdings table Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 13:59:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 11:59:43 +0000 Subject: [Koha-bugs] [Bug 33600] Use template wrapper for breadcrumbs: Tools, part 7 In-Reply-To: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33600-70-3Hong9N91p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33600 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:03:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 12:03:21 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-E6EfP8PjjK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:03:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 12:03:24 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-j8IEdbqAZ2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150578|0 |1 is obsolete| | Attachment #150579|0 |1 is obsolete| | Attachment #150836|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150860&action=edit Bug 33607: Add framework display to staff details page This patch adds a Frameworks pluing to allow fetching the framework text and displays this on the intranet details page To test: 1 - Apply patch 2 - View a record details page in staff 3 - Confirm you see the framework name 4 - prove -v t/db_dependent/Template/Plugin/Frameworks.t Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:03:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 12:03:27 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-mfoOxdLklr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 --- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150861&action=edit Bug 33607: Handle default framework Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:03:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 12:03:32 +0000 Subject: [Koha-bugs] [Bug 33600] Use template wrapper for breadcrumbs: Tools, part 7 In-Reply-To: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33600-70-ukEu9ooiBa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33600 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:03:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 12:03:34 +0000 Subject: [Koha-bugs] [Bug 33600] Use template wrapper for breadcrumbs: Tools, part 7 In-Reply-To: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33600-70-GKbGK9Qg6u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33600 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150166|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150862&action=edit Bug 33600: Use template wrapper for breadcrumbs: Tools, part 7 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Task scheduler - Cataloging -> - Stage MARC records for import (use a batch of MARC records which will match existing records) - View batch -> - View diff of records with a match - Stock rotation (must have StockRotation enabled) - New rota - Edit rota - Manage stages - Manage items Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:04:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 12:04:56 +0000 Subject: [Koha-bugs] [Bug 33599] Use template wrapper for breadcrumbs: Various In-Reply-To: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33599-70-SF9f0K7tyR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:19:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 12:19:21 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-UQFLHfVbbW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> --- I do not think this is a great idea long term. This is moving backwards when it comes to efficiency and will introduce far more database calls. It seems like it might be better to fix the code that is making a bad assumption. The short term fix is to use discard_changes when needed. The long term fix is to use Koha objects from the perl scripts and pass them to subroutines so we have no need to re-fetch data from the database. Have you identified any bugs being caused by this, or it just a possibility as you've shown? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:57:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 12:57:11 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-M8R2zcQpC3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #55 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Tested this with Zebra. Copied cp etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl /etc/koha/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl Rebuilt index, restarted Zebra. Conform test plan, opened record and saved it again. Checked sysprefs. The links are not relinked to the correct authids. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:57:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 12:57:38 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-uLiOZsHBY2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 14:58:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 12:58:20 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-Hr3fwwmwOL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #56 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- > ! grep /$thesaurus/,('lcsh','lcac','mesh','nal','notspecified','cash','rvm','sears','aat') This regex might not always do what you want. Probably we could better do something like: none { $_ eq $thesaurus } etc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl <xslo:when> <xsl:attribute name="test"><xsl:value-of select="$alt_select"/></xsl:attribute> <xslo:value-of> <xsl:attribute name="select"><xsl:value-of select="$alt_select"/></xsl:attribute> </xslo:value-of> </xslo:when> <xslo:otherwise><xslo:text>notdefined</xslo:text></xslo:otherwise> This could be done much simpler. Funny construction here. Out of scope. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:01:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:01:57 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-vCLCv0IgSd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:01:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:01:59 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-ig8qMgY6Vx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150591|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150863&action=edit Bug 33576: Index records after import transaction is committed This patch simply moves our indexing call after the transaction is committed so that the job will exist in the DB when called. To test: 1 - Have Koha using Elasticsearch 2 - Stage and import a file of records 3 - View the job in Admin->Manage jobs 4 - Note it is not finished 5 - Check log: /var/log/koha/kohadev/es-indexer-output.log 6 - Note: [WARN] No job found for id=### 7 - Apply patch 8 - Stage and import 9 - Note no error in log 10 - Note successful completion of indexing job Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:02:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:02:02 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-wqEGKvbyEg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150592|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150864&action=edit Bug 33576: (QA follow-up) Polish comment, typo No test plan. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:07:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:07:35 +0000 Subject: [Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages In-Reply-To: <bug-32730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32730-70-VRS2iWjqvu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |BLOCKED QA Contact|katrin.fischer at bsz-bw.de |m.de.rooy at rijksmuseum.nl --- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- QAing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:26:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:26:32 +0000 Subject: [Koha-bugs] [Bug 33681] Omnibus: Allow SIP2 users to be created through the Koha staff interface In-Reply-To: <bug-33681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33681-70-7RGp9zVEgu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33681 --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Liz Rea from comment #4) > I imagine we'd have to support both - perhaps they are additive to each > other, i.e. if you have accounts in there, we use them, and if we create any > in the UI, those also work? > > There may be technical reasons why that's not possible. > > Possibly we do one or the other, via syspref? upgrading koha use > SIPConfig.xml until the accounts can be moved or updated, new koha use the > UI? There is no reason we can't "merge" the database and xml users together. The only question would be which has precedence in the case of duplicate users. I would say the database version to avoid librarian's creating a sip user only to find it's not working and they don't know why. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:38:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:38:53 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-BnnuJfwAwP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150834|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:39:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:39:38 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-AhQOsPPrNl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 --- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 150865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150865&action=edit Bug 33653: Use filter_by_active instead This patch makes `filter_by_lates` use the `filter_by_active` method instead of an ad-hoc query filter. It has the advantage that it considers standing orders too. No behavior change, tests should still pass. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:40:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:40:02 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-b0QK4TJ25b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144348|0 |1 is obsolete| | --- Comment #5 from David Gustafsson <glasklas at gmail.com> --- Created attachment 150866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150866&action=edit Bug 32060: Improve performance of columns_to_str To test: 1) Ensure tests in t/db_dependent/Koha/Item.t all pass 2) Go to a biblio (preferably as serial) with many items and click "New" -> "New item" and take not of the response time. 3) Apply the patch. 4) Ensure tests in t/db_dependent/Koha/Item.t still pass 5) Repeat step 1), the response time should be substantially improved. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:40:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:40:45 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-BKrOw8mQPV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #6 from David Gustafsson <glasklas at gmail.com> --- Rebased against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:47:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:47:23 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-YurcLdLRa7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 --- Comment #7 from David Gustafsson <glasklas at gmail.com> --- Since caching of GetAuthorisedValueDesc is now in master, the performance gain will not be as large, but still substantial. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:48:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:48:00 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-4av7SeaR1W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148734|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:20 +0000 Subject: [Koha-bugs] [Bug 28315] PopupMARCFieldDoc is defined twice in addbiblio.tt In-Reply-To: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28315-70-lM88s67EJD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28315 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:22 +0000 Subject: [Koha-bugs] [Bug 28315] PopupMARCFieldDoc is defined twice in addbiblio.tt In-Reply-To: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28315-70-ko1r3KRv84@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28315 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:24 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31799-70-TEs8hBzqIU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:26 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31799-70-lOqSnPsW7L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 --- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:28 +0000 Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32232-70-x6ciUYbTCQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:30 +0000 Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32232-70-LgR47nNhSk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 --- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:32 +0000 Subject: [Koha-bugs] [Bug 33069] File download from list in OPAC gives error In-Reply-To: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33069-70-z9aWlZMlpd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:34 +0000 Subject: [Koha-bugs] [Bug 33069] File download from list in OPAC gives error In-Reply-To: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33069-70-KAeGcBgpJX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:36 +0000 Subject: [Koha-bugs] [Bug 33093] (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase' In-Reply-To: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33093-70-dGGk7ZU1N7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33093 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:38 +0000 Subject: [Koha-bugs] [Bug 33093] (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase' In-Reply-To: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33093-70-MlRwHZmuko@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33093 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:40 +0000 Subject: [Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports In-Reply-To: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33356-70-YnvC1DMSZw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:42 +0000 Subject: [Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports In-Reply-To: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33356-70-DYL3yDfBXb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356 --- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:44 +0000 Subject: [Koha-bugs] [Bug 33513] Batch update from report module - no patrons loaded into view In-Reply-To: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33513-70-TxkuxhQifx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33513 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:46 +0000 Subject: [Koha-bugs] [Bug 33513] Batch update from report module - no patrons loaded into view In-Reply-To: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33513-70-93vItkBaet@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33513 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:48 +0000 Subject: [Koha-bugs] [Bug 33586] Library and category are switched in table configuration for patron search results table settings In-Reply-To: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33586-70-mqljUpkhMN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33586 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:50 +0000 Subject: [Koha-bugs] [Bug 33586] Library and category are switched in table configuration for patron search results table settings In-Reply-To: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33586-70-PFrNJQtAnc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33586 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:52 +0000 Subject: [Koha-bugs] [Bug 33600] Use template wrapper for breadcrumbs: Tools, part 7 In-Reply-To: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33600-70-SipThSxcug@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33600 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:53 +0000 Subject: [Koha-bugs] [Bug 33600] Use template wrapper for breadcrumbs: Tools, part 7 In-Reply-To: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33600-70-Rh6fYY4SGC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33600 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:55 +0000 Subject: [Koha-bugs] [Bug 33601] Use template wrapper for breadcrumbs: Tools, part 8 In-Reply-To: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33601-70-7XgFjjCq5P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33601 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:57 +0000 Subject: [Koha-bugs] [Bug 33601] Use template wrapper for breadcrumbs: Tools, part 8 In-Reply-To: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33601-70-VJ8rxKZmcE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33601 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:51:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:51:59 +0000 Subject: [Koha-bugs] [Bug 33643] Add page-section to 'scan index' page In-Reply-To: <bug-33643-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33643-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33643-70-9Ogfupgt2q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33643 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:52:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:52:01 +0000 Subject: [Koha-bugs] [Bug 33643] Add page-section to 'scan index' page In-Reply-To: <bug-33643-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33643-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33643-70-WjC4dAqaoL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33643 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:52:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:52:03 +0000 Subject: [Koha-bugs] [Bug 33673] Global system preferences - change to just system preferences In-Reply-To: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33673-70-6BUrLPshb0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:52:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:52:05 +0000 Subject: [Koha-bugs] [Bug 33673] Global system preferences - change to just system preferences In-Reply-To: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33673-70-983FiypzMd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:52:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:52:06 +0000 Subject: [Koha-bugs] [Bug 33696] Doubled up home icon in budgets page In-Reply-To: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33696-70-NaiLHz23gW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33696 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 15:52:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 13:52:08 +0000 Subject: [Koha-bugs] [Bug 33696] Doubled up home icon in budgets page In-Reply-To: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33696-70-Au6QGudsYW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33696 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:00:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:00:07 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-ZgPmdezS1Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:00:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:00:09 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-ILboxvzZDj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 --- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:00:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:00:11 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-nmmNWAXiVC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:00:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:00:13 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-yaGu6nAh4T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:00:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:00:15 +0000 Subject: [Koha-bugs] [Bug 33591] Cannot merge bibliographic records In-Reply-To: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33591-70-EbBZZcNwP0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:00:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:00:17 +0000 Subject: [Koha-bugs] [Bug 33591] Cannot merge bibliographic records In-Reply-To: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33591-70-pkAKOxo8U5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:00:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:00:19 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33611-70-1kug0TXM7O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:00:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:00:21 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33611-70-QEYoqwXeVc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 --- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:00:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:00:23 +0000 Subject: [Koha-bugs] [Bug 33613] Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge In-Reply-To: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33613-70-CrdkFp6UlO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:00:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:00:25 +0000 Subject: [Koha-bugs] [Bug 33613] Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge In-Reply-To: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33613-70-zOlxcYkVRU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:00:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:00:27 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-zMzHUkHQtW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:00:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:00:29 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-kxYNcpCLVp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 --- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:07:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:07:00 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface In-Reply-To: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15428-70-h4WMCkFuLJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 pierre.genty at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:13:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:13:11 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface In-Reply-To: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15428-70-M34N1l4cii@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 mathieu saby <mathsabypro at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com --- Comment #23 from mathieu saby <mathsabypro at gmail.com> --- Hi A different timeout for staff and OPAC would be very useful -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:27:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:27:30 +0000 Subject: [Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages In-Reply-To: <bug-32730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32730-70-vxNMvuVQcP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 --- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- $paton->get_lists_with_patron Looking at package Koha::List::Patron, it feels to me that it better should live there. No absolute blocker. That package is no Koha::Object btw. Explaining probably too why you add DBIx code Seeing some calls that only need the count of this result btw. +<div class="patroninfo-section"> + <h4>Patron lists without this patron</h4> Looks like this section contains a lot of duplicated code? Could probably be merged in some named block. Not sure why we need two tables, but that seems just a matter of taste. @available_lists = GetPatronLists(); @available_lists = grep { ! $list_id_lookup{$_->patron_list_id} } @available_lists; [...] in_lists => \@in_lists, list_id_lookup => \%list_id_lookup, available_lists => \@available_lists, This makes me even more wonder why we are using get_lists_with_patron. You are selecting the reverse here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:28:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:28:46 +0000 Subject: [Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages In-Reply-To: <bug-32730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32730-70-S3jHeK3iWp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- I am bit hesitant to PQA this patch. But cannot FQA it either. Would be nice to get another QA perspective on this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:30:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:30:57 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-uId9BItDmq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Failed QA --- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> --- I think quoting here is a bit naive... Can we make it use the quote_search_terms XSLT template we have: https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl#L589 Example usage: https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl#L219-L223 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:31:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:31:05 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-YEpyCz78R4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:31:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:31:46 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-PRV07h2WXj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #21 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Adjust and it will get pushed. No need to be PQA by the freeze. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:34:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:34:07 +0000 Subject: [Koha-bugs] [Bug 33676] Recognise documentation submissions on the about page In-Reply-To: <bug-33676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33676-70-cH3ysNsiAy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33676 --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I noticed that for developers, it seems to be any developer who ever contributed, so we could parse the contributors list for the manual and get all the names regardless of version. Here is the list https://gitlab.com/koha-community/koha-manual/-/graphs/master?ref_type=heads -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:45:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:45:48 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-oT777xN3vG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #57 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150867&action=edit Bug 30979: Unit tests - Availability endpoint This patch adds unit tests for the new checkout availability endpoint we're going to introduce in this patchset. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:45:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:45:52 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-xX5qAkTWF2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #58 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150868&action=edit Bug 30979: Add checkout API's This patch adds API's to allow for a checkout flow using the RESTful API. We add an availability endpoint to check an items current availability status. The endpoint can be found at `/checkouts/availability` and is a GET request that requires item_id and patron_id passed as parameters. We return an availability object that includes blockers, confirms, warnings and a confirmation token to be used for checkout. We also add a corresponding checkout method to the `/checkouts` endpoint. The method accepts a POST request with checkout details including item_id , patron_id and the confirmation token in the body. Future work: We should properly migrate CanBookBeIssued into Koha::* and use that here instead of refering to C4::Circulation. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:45:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:45:55 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-b2GvcuvJtX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145627|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150869&action=edit Bug 30979: Fix inconsistent return of AddIssue AddIssue can on occasion create a renewal instead of a fresh issue and in such a case we currently return undefined. We should be consistent and return the existing issue object for the renewal. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:45:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:45:58 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-RXTJGW8GD2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #60 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150870&action=edit Bug 30979: Add public endpoints This patch expands the checkouts endpoints to allow for a public workflow. We add the availability endpoint under `/public/checkouts/availability` and restrict the information we send back to only those fields a public user should be allowed to see. We also add a new checkout endpoint at `/patrons/{patron_id}/checkouts` that allows for users to checkout to themselves and accepts the same POST request with checkout details including item_id and a confirmation token in the body that the staff client endpoints accept. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:46:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:46:01 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-vP73wL7HFS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145623|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150871&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:46:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:46:05 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-S5RN3GikjY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #62 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150872&action=edit Bug 30979: Limit public checkout endpoint using preference The public api endpoint for self-checkout should only be enabled in the case where the OpacTrustedSelfCheckout option is enabled. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:46:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:46:08 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-mEfO07RrXZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145628|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150873&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode to checkout. We check for item existance and availability and then check the item out after any confirmations have been displayed. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:46:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:46:12 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-8KerdbwtGS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145629|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150874&action=edit Bug 30979: Always show self-checkout when preference enabled This patch updates the display logic such that if the truested self-checkout option is enabled we always show the checkout button and prompt a login when no user is found. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:46:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:46:15 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-3MPMPHAZuI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145630|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150875&action=edit Bug 30979: Redirect to checkout summary This is a temporary solution whilst we wait for the biblio api endpoints so we may include more biblio details in the checkout modal itself. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:46:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:46:18 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-vlUjewvuhS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #66 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150876&action=edit Bug 30979: Add modal trigger to shibboleth target url Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:46:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:46:21 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-UPHxls7HRA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #67 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150877&action=edit Bug 32711: Add biblio details to modal This patch adds biblio details to the self-checkout modal. As part of this we add 'biblio' to the x-koha-embed option on the public items endpoint, clone the js-biblio-format include from the staff client adapting it slightly for OPAC use along the way and also import escape_str and escapeHtml from staff to opac too. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:46:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:46:26 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-pTFLWgoCH3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #68 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150878&action=edit Bug 32711: Add 'public_read_list' appropriately We're exposing biblio (and thus biblioitem) to the public API now and as such we need to explisitely list which fields to include in the response when called on the public api. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:46:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:46:29 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-Qc46Q5JRGS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #69 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150879&action=edit Bug 32711: Fix biblio embeds We need to drop the embed part of the args we pass to biblioitem else we end up with some very strange behaviours on the acquisitions endpoint. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:47:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:47:19 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-NJnIMLMBlp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150877|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:47:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:47:29 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-z1CNcIEX0T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150878|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:47:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:47:36 +0000 Subject: [Koha-bugs] [Bug 22375] Due dates should be formatted consistently In-Reply-To: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22375-70-VXKEYRquAC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:47:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:47:38 +0000 Subject: [Koha-bugs] [Bug 22375] Due dates should be formatted consistently In-Reply-To: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22375-70-vU9vLNNHAA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:47:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:47:40 +0000 Subject: [Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin In-Reply-To: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25379-70-orfPL6rJCE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:47:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:47:41 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-zJN3eiW2Ge@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150879|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:47:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:47:42 +0000 Subject: [Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin In-Reply-To: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25379-70-IBzJT6bHm5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 --- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:47:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:47:44 +0000 Subject: [Koha-bugs] [Bug 30621] Author should be its own column on opac-readingrecord.tt In-Reply-To: <bug-30621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30621-70-iVM4snkyNX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30621 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:47:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:47:46 +0000 Subject: [Koha-bugs] [Bug 30621] Author should be its own column on opac-readingrecord.tt In-Reply-To: <bug-30621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30621-70-So8AmG1MNQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30621 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:47:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:47:48 +0000 Subject: [Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices In-Reply-To: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32548-70-17PpJ8TpBC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:47:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:47:49 +0000 Subject: [Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices In-Reply-To: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32548-70-IuUukxv4sj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 --- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:47:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:47:51 +0000 Subject: [Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice In-Reply-To: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32917-70-XSOtTiW5VP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:47:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:47:53 +0000 Subject: [Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice In-Reply-To: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32917-70-1Jjldd09OU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:47:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:47:55 +0000 Subject: [Koha-bugs] [Bug 33037] [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) In-Reply-To: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33037-70-OwSGOIgYsQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:47:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:47:57 +0000 Subject: [Koha-bugs] [Bug 33037] [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) In-Reply-To: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33037-70-Zms3GLg362@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:47:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:47:59 +0000 Subject: [Koha-bugs] [Bug 33206] Bad title__sort made of multisubfield 245 In-Reply-To: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33206-70-FaWz3EwlSc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33206 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:48:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:48:01 +0000 Subject: [Koha-bugs] [Bug 33206] Bad title__sort made of multisubfield 245 In-Reply-To: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33206-70-guiAxVIHBl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33206 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:48:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:48:03 +0000 Subject: [Koha-bugs] [Bug 33253] 2FA - Form not excluded from autofill In-Reply-To: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33253-70-DkoYF9G93s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33253 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:48:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:48:04 +0000 Subject: [Koha-bugs] [Bug 33253] 2FA - Form not excluded from autofill In-Reply-To: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33253-70-nWIYL1sbQo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33253 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:48:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:48:06 +0000 Subject: [Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold In-Reply-To: <bug-33302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33302-70-S99U04kuzk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:48:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:48:08 +0000 Subject: [Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold In-Reply-To: <bug-33302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33302-70-3vE7EOzjyl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 --- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:48:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:48:10 +0000 Subject: [Koha-bugs] [Bug 33569] Order by relevance may not be visible In-Reply-To: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33569-70-YnpUvPHHzD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33569 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:48:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:48:12 +0000 Subject: [Koha-bugs] [Bug 33569] Order by relevance may not be visible In-Reply-To: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33569-70-OTq2SZGpLW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33569 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:48:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:48:14 +0000 Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled In-Reply-To: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33622-70-05np3pxguY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:48:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:48:15 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-v8FsUTDsZ0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- # Subtest: is_denied_renewal 1..11 ok 1 - Renewal allowed when no rules ok 2 - Renewal blocked when 1 rules (withdrawn) ok 3 - Renewal allowed when 1 rules not matched (withdrawn) ok 4 - Renewal blocked when 2 rules matched (withdrawn, itype) ok 5 - Renewal allowed when 2 rules not matched (withdrawn, itype) ok 6 - Renewal blocked when 3 rules matched (withdrawn, itype, location) ok 7 - Renewal allowed when 3 rules not matched (withdrawn, itype, location) not ok 8 - Renewal blocked for undef when NULL in pref # Failed test 'Renewal blocked for undef when NULL in pref' # at t/db_dependent/Koha/Item.t line 2157. # got: '0' # expected: '1' ok 9 - Renewal not blocked for undef when "" in pref ok 10 - Renewal not blocked for "" when NULL in pref ok 11 - Renewal blocked for empty string when "" in pref # Looks like you failed 1 test of 11. not ok 28 - is_denied_renewal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:48:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:48:15 +0000 Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled In-Reply-To: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33622-70-S8o86K9Oe6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:48:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:48:17 +0000 Subject: [Koha-bugs] [Bug 33672] Item group features shows when placing holds if EnableItemGroupHolds is disabled In-Reply-To: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33672-70-MMxf71BEMt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33672 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:48:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:48:19 +0000 Subject: [Koha-bugs] [Bug 33672] Item group features shows when placing holds if EnableItemGroupHolds is disabled In-Reply-To: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33672-70-gABAfRrbgR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33672 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:48:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:48:58 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-F2jEWB7vbC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- The replace NULL by null thing feels a bit odd btw.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:49:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:49:12 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-GQ8IP6TcOQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:51:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:51:26 +0000 Subject: [Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages In-Reply-To: <bug-32730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32730-70-bWdS2AMT2p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 --- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Asked for a second perspective, tcohen replied on IRC: [16:40] <tcohen> I don't like those method names [16:40] <tcohen> well, name [16:41] <tcohen> or plain DBIC [16:41] <tcohen> it needs more work [16:41] <tcohen> FQA [16:41] <tcohen> it would be good to give a list of changes [16:41] <tcohen> to encourage them to keep working on it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:51:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:51:35 +0000 Subject: [Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages In-Reply-To: <bug-32730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32730-70-l3UKmjASnu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:52:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:52:06 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-UY5TsqISnk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150867|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150880&action=edit Bug 30979: Unit tests - Availability endpoint This patch adds unit tests for the new checkout availability endpoint we're going to introduce in this patchset. Signed-off-by: Helen Oliver <HOliver at tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:52:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:52:09 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-Yf3A0J5LJw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150868|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150881&action=edit Bug 30979: Add checkout API's This patch adds API's to allow for a checkout flow using the RESTful API. We add an availability endpoint to check an items current availability status. The endpoint can be found at `/checkouts/availability` and is a GET request that requires item_id and patron_id passed as parameters. We return an availability object that includes blockers, confirms, warnings and a confirmation token to be used for checkout. We also add a corresponding checkout method to the `/checkouts` endpoint. The method accepts a POST request with checkout details including item_id , patron_id and the confirmation token in the body. Future work: We should properly migrate CanBookBeIssued into Koha::* and use that here instead of refering to C4::Circulation. Signed-off-by: Helen Oliver <HOliver at tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:52:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:52:13 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-3JQ2BwuXZG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150869|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150882&action=edit Bug 30979: Fix inconsistent return of AddIssue AddIssue can on occasion create a renewal instead of a fresh issue and in such a case we currently return undefined. We should be consistent and return the existing issue object for the renewal. Signed-off-by: Helen Oliver <HOliver at tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:52:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:52:16 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-zRcHxuksLQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150870|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150883&action=edit Bug 30979: Add public endpoints This patch expands the checkouts endpoints to allow for a public workflow. We add the availability endpoint under `/public/checkouts/availability` and restrict the information we send back to only those fields a public user should be allowed to see. We also add a new checkout endpoint at `/patrons/{patron_id}/checkouts` that allows for users to checkout to themselves and accepts the same POST request with checkout details including item_id and a confirmation token in the body that the staff client endpoints accept. Signed-off-by: Helen Oliver <HOliver at tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:52:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:52:19 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-5dd3CoHOYf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150871|0 |1 is obsolete| | --- Comment #74 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150884&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. Signed-off-by: Helen Oliver <HOliver at tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:52:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:52:23 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-L5Zf1CWlmP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150872|0 |1 is obsolete| | --- Comment #75 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150885&action=edit Bug 30979: Limit public checkout endpoint using preference The public api endpoint for self-checkout should only be enabled in the case where the OpacTrustedSelfCheckout option is enabled. Signed-off-by: Helen Oliver <HOliver at tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:52:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:52:27 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-eKjWTwGZrV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150873|0 |1 is obsolete| | --- Comment #76 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150886&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode to checkout. We check for item existance and availability and then check the item out after any confirmations have been displayed. Signed-off-by: Helen Oliver <HOliver at tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:52:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:52:30 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-vlUqcLUcpm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150874|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150887&action=edit Bug 30979: Always show self-checkout when preference enabled This patch updates the display logic such that if the truested self-checkout option is enabled we always show the checkout button and prompt a login when no user is found. Signed-off-by: Helen Oliver <HOliver at tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:52:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:52:34 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-7myndo5IwE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150875|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150888&action=edit Bug 30979: Redirect to checkout summary This is a temporary solution whilst we wait for the biblio api endpoints so we may include more biblio details in the checkout modal itself. Signed-off-by: Helen Oliver <HOliver at tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:52:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:52:37 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-myHY5VvxX0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150876|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150889&action=edit Bug 30979: Add modal trigger to shibboleth target url Signed-off-by: Helen Oliver <HOliver at tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:56:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:56:04 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-xRqrOgIFhd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145624|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:56:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:56:13 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-uT5HgtrLge@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145625|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:56:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:56:25 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-ig5FlEOfe0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145626|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 16:57:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 14:57:01 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-3RGBSH6mz5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:01:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 15:01:20 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-T8tWg6SQzf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #20) > I think quoting here is a bit naive... Can we make it use the > quote_search_terms XSLT template we have: > > https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha- > tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl#L589 > > Example usage: > https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha- > tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl#L219-L223 Could you elaborate on this one please? Which construction do you object to ? <xsl:value-of select="normalize-space(translate(substring-before(marc:subfield[@code=$cnum_subfield],')'),'()',''))"/> OR <xsl:value-of select="str:encode-uri(concat($scriptname,'?q=ti,phr:',translate(marc:subfield[@code=$title_subfield], '()', '')),false())"/> In both cases it is not just about quoting a URI part. Note that they are not completely new inventions, but adjusted existent constructs moved to a central template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:03:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 15:03:13 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-PgV4tRDU0E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- <tcohen> you are manually quoting something that comes from the record [17:02] <tcohen> and could in theory contain quote chars -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:03:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 15:03:40 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-IVZW115fGe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #23) 17:02] <tcohen> the latter > <tcohen> you are manually quoting something that comes from the record > [17:02] <tcohen> and could in theory contain quote chars -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:05:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 15:05:00 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-EEKUSwyaJj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 --- Comment #13 from David Gustafsson <glasklas at gmail.com> --- Ok! Suppose due to forgot to fix the tests that still uses the 'NULL' value, will do so. Why is it odd? null is valid json, NULL is not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:41:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 15:41:57 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-Q0l0LuimYk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148957|0 |1 is obsolete| | --- Comment #57 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150890&action=edit Updated authority records for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:42:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 15:42:22 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-x0k4lvFL1b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:42:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 15:42:25 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-rb4ofJJwG7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #58 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150891&action=edit Bug 33277: (follow-up) Don't use regex, tidy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:44:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 15:44:14 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-zLmYXm3mpt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #59 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #55) > Tested this with Zebra. Copied > cp etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl > /etc/koha/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl > > Rebuilt index, restarted Zebra. > Conform test plan, opened record and saved it again. Checked sysprefs. The > links are not relinked to the correct authids. None of them? Or some of them? Restart zebra (restart_all) then reindex Make sure AutoLinkBiblios is set to 'Do'(In reply to Marcel de Rooy from comment #56) > > ! grep /$thesaurus/,('lcsh','lcac','mesh','nal','notspecified','cash','rvm','sears','aat') > This regex might not always do what you want. > Probably we could better do something like: none { $_ eq $thesaurus } etc Updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:51:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 15:51:50 +0000 Subject: [Koha-bugs] [Bug 27265] process_message_queue.pl cron should be able to take multiple types as a parameter In-Reply-To: <bug-27265-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27265-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27265-70-BQpZbUFn2o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/679 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 17:51:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 15:51:56 +0000 Subject: [Koha-bugs] [Bug 27265] process_message_queue.pl cron should be able to take multiple types as a parameter In-Reply-To: <bug-27265-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27265-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27265-70-GVpVE2bvd2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 18:16:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 16:16:09 +0000 Subject: [Koha-bugs] [Bug 30195] Suggestion form in OPAC should use ISBN to FindDuplicate In-Reply-To: <bug-30195-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30195-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30195-70-q4UFUt36Ib@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30195 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/679 Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 18:24:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 16:24:19 +0000 Subject: [Koha-bugs] [Bug 30646] Add option to send WELCOME notice for new patrons added at first login via LDAP/SAML In-Reply-To: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30646-70-KghuVEXKy7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/679 Resolution|--- |FIXED Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 18:27:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 16:27:16 +0000 Subject: [Koha-bugs] [Bug 27697] Opening bibliographic record page prepopulates search bar text In-Reply-To: <bug-27697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27697-70-dvPchIgWcQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27697 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #14 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- This seems like a bug fix rather than a feature. Not sure what documentation is needed. Closing, but feel free to reopen with details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 18:29:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 16:29:02 +0000 Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no results, repeat the search with term quoted In-Reply-To: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31213-70-GnWTGLnhHc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #16 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- This seems like a backend change. There is no effect on the manual, that I can see. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 18:29:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 16:29:02 +0000 Subject: [Koha-bugs] [Bug 32100] "edit search" feature quote-wraps search terms if original search had no results In-Reply-To: <bug-32100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32100-70-2CpkWBjjvg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32100 Bug 32100 depends on bug 31213, which changed state. Bug 31213 Summary: When performing a basic search with no results, repeat the search with term quoted https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 18:34:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 16:34:06 +0000 Subject: [Koha-bugs] [Bug 27546] Add option to search within results on the staff interface In-Reply-To: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27546-70-Bu42hbrUaN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/679 Resolution|--- |FIXED Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 18:46:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 16:46:42 +0000 Subject: [Koha-bugs] [Bug 31289] Hide article requests column in circulation rules when ArticleRequests syspref is disabled In-Reply-To: <bug-31289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31289-70-S5mKe3MMCz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/679 Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 18:50:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 16:50:44 +0000 Subject: [Koha-bugs] [Bug 33158] Use template wrapper for authorized values and item types administration tabs In-Reply-To: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33158-70-M2hItleRjC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 18:50:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 16:50:47 +0000 Subject: [Koha-bugs] [Bug 33158] Use template wrapper for authorized values and item types administration tabs In-Reply-To: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33158-70-YGgSYrZqbx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 --- Comment #12 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 150893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150893&action=edit Bug 33158: (follow-up) Fix for QA test failure The page seems to work fine without these changes but the QA test script is happier with "USE raw" and html_helpers.inc added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 18:52:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 16:52:05 +0000 Subject: [Koha-bugs] [Bug 33703] New: Bug in Date of Birth Field Entry Message-ID: <bug-33703-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Bug ID: 33703 Summary: Bug in Date of Birth Field Entry Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kkrueger at cuyahogalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 150894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150894&action=edit DateNoSlash_1 Description: When using the Koha Date of Birth field to add a new patron, entering a date without punctuation (/ or -) causes the date to change to an incorrect date. Steps to reproduce: 1. From Koha Patron module > add new patron > patron identity section, Date of birth field, enter a birthdate for 24 May 1964 as 05241964 (DateNoSlash_1.png) manually. 2. Tab or hit enter, and the birth date that is recorded changes to 06/10/1964 or June 10 1964 (DateNoSlash_2.png). Similar behavior happens whenever the date is entered without punctuation. Expected Results: If data is entered in this field without slashes or hyphens, the slashes would be input without changing the intended date. Suggesting here a correction to correctly assign birthdates as entered with or without punctuation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 18:52:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 16:52:39 +0000 Subject: [Koha-bugs] [Bug 33703] Bug in Date of Birth Field Entry In-Reply-To: <bug-33703-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33703-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33703-70-J8YQ7f5hFs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #1 from Kristi <kkrueger at cuyahogalibrary.org> --- Created attachment 150895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150895&action=edit DateNoSlash_2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 18:52:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 16:52:52 +0000 Subject: [Koha-bugs] [Bug 33703] Bug in Date of Birth Field Entry In-Reply-To: <bug-33703-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33703-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33703-70-ChI7kOtxqn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Kristi <kkrueger at cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger at cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 18:53:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 16:53:47 +0000 Subject: [Koha-bugs] [Bug 30937] Add a detail view for libraries In-Reply-To: <bug-30937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30937-70-cnAmZbbEpr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30937 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/679 Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:01:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 17:01:05 +0000 Subject: [Koha-bugs] [Bug 30773] Standardize spelling i-tive / Itiva In-Reply-To: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30773-70-1c2H3uRKkW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30773 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/679 Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:02:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 17:02:34 +0000 Subject: [Koha-bugs] [Bug 30770] Terminology: Lost reserve In-Reply-To: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30770-70-HdQqP4MsfI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- The string 'lost reserve' is not in the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:25:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 17:25:51 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-C5zYoZfxSI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150781|0 |1 is obsolete| | --- Comment #27 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 150896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150896&action=edit Bug 33117: New System Preference PatronAutoCompleteSearchMethod WIP - Not ready for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:37:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 17:37:35 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-dCnAfQsz19@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150896|0 |1 is obsolete| | --- Comment #28 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 150897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150897&action=edit Bug 33117: New System Preference PatronAutoCompleteSearchMethod WIP - Fixing up syntax errors - NOT READY FOR TESTING -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:51:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 17:51:14 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-hKzGJGD5qf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:51:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 17:51:19 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-hDHxIqljk8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148981|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:51:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 17:51:24 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-iscjdnj6MH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148982|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:51:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 17:51:30 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-eXk7al8EOU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148983|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:51:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 17:51:36 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-J6iL6XFhxm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148984|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:51:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 17:51:41 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-qiptD4jaCB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148985|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 19:51:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 17:51:47 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-2jvljvFKTJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148986|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 20:07:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 18:07:52 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-1n1oiu8UKr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150897|0 |1 is obsolete| | --- Comment #29 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 150898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150898&action=edit Bug 33117: New System Preference PatronAutoCompleteSearchMethod Still a WIP - -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 20:15:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 18:15:14 +0000 Subject: [Koha-bugs] [Bug 26841] No warning if a hold on an available item is placed in staff with AllowHoldPolicyOverride In-Reply-To: <bug-26841-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26841-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26841-70-AHp01rbu0F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26841 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |emily.lamancusa at montgomeryc | |ountymd.gov Status|NEW |RESOLVED --- Comment #7 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- *** This bug has been marked as a duplicate of bug 31575 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 20:15:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 18:15:14 +0000 Subject: [Koha-bugs] [Bug 31575] Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed In-Reply-To: <bug-31575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31575-70-fUWOf986qF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rickard.lindfors at sh.se --- Comment #9 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- *** Bug 26841 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 20:20:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 18:20:02 +0000 Subject: [Koha-bugs] [Bug 33675] OAuth should support state parameter In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-NCqyLnSRRO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 20:21:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 18:21:03 +0000 Subject: [Koha-bugs] [Bug 30764] Terminology: Cancelled reserve In-Reply-To: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30764-70-UQGkqnHeGB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30764 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- No occurrence of "Cancelled reserve" in the manual. I took the opportunity to change the few occurrences of reserve (meant as hold) to hold, but there wasn't much in the text. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 20:21:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 18:21:04 +0000 Subject: [Koha-bugs] [Bug 30770] Terminology: Lost reserve In-Reply-To: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30770-70-s7oBMyo9X7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 Bug 30770 depends on bug 30764, which changed state. Bug 30764 Summary: Terminology: Cancelled reserve https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30764 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 20:30:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 18:30:45 +0000 Subject: [Koha-bugs] [Bug 30333] Move view actions on acquisitions receipt summary page into menu In-Reply-To: <bug-30333-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30333-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30333-70-VRoUJKeJJk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30333 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Screenshots in the current manual seem to include this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 20:30:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 18:30:45 +0000 Subject: [Koha-bugs] [Bug 16640] Move actions on acquisitions receipt summary page into menu In-Reply-To: <bug-16640-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16640-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16640-70-kwJJKh77MT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16640 Bug 16640 depends on bug 30333, which changed state. Bug 30333 Summary: Move view actions on acquisitions receipt summary page into menu https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30333 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 20:43:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 18:43:27 +0000 Subject: [Koha-bugs] [Bug 33703] Bug in Date of Birth Field Entry In-Reply-To: <bug-33703-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33703-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33703-70-8VYBCVDnBY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 lthorrat at cuyahogalibrary.org <lthorrat at cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lthorrat at cuyahogalibrary.or | |g Priority|P5 - low |P3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 21:00:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 19:00:54 +0000 Subject: [Koha-bugs] [Bug 26486] Group edit buttons in reports toolbar In-Reply-To: <bug-26486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26486-70-S1qkb0084g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26486 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Screenshots that show this seem to already have been updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:14:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:14:29 +0000 Subject: [Koha-bugs] [Bug 31385] Additional contents: Allow searching a CMS page by code in multilanguage env In-Reply-To: <bug-31385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31385-70-jYrWHkj0GM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31385 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/679 Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:14:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:14:29 +0000 Subject: [Koha-bugs] [Bug 29190] Additional contents: Cache local pages In-Reply-To: <bug-29190-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29190-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29190-70-QcbnvkWhtg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29190 Bug 29190 depends on bug 31385, which changed state. Bug 31385 Summary: Additional contents: Allow searching a CMS page by code in multilanguage env https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31385 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:27:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:27:28 +0000 Subject: [Koha-bugs] [Bug 33704] New: Fixed length control fields does not save "Type of Material" when edited. Message-ID: <bug-33704-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33704 Bug ID: 33704 Summary: Fixed length control fields does not save "Type of Material" when edited. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: Laura.escamilla at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To reproduce: - Open the MARC structure for any bibliographic MARC framework - Go to 008 - FIXED-LENGTH DATA ELEMENTS--GENERAL INFORMATION and click on the tag editor - Attempt to change the BKS - Books subfield to MX - Mixed materials; save the record. - View the completed record and note that the material type is still showing as "Text". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:28:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:28:09 +0000 Subject: [Koha-bugs] [Bug 33703] Bug in Date of Birth Field Entry In-Reply-To: <bug-33703-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33703-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33703-70-shrqz8rekZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Which Dateformat are you using? I am not sure how easy it would be to implement this as the MM DD and YY parts can be in a different position depending on the DateFormat. Do you know if this worked with the old date picker widget? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:28:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:28:48 +0000 Subject: [Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats In-Reply-To: <bug-33703-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33703-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33703-70-B5OjYbWAt2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bug in Date of Birth Field |Entering dates should be |Entry |more flexible accepting | |different entry formats -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:31:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:31:41 +0000 Subject: [Koha-bugs] [Bug 33705] New: Quote of the day: table has configure button even if it's not configurable Message-ID: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Bug ID: 33705 Summary: Quote of the day: table has configure button even if it's not configurable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org I'm not sure if bug 31435 was meant as a general fix or if each individual table needs to be fixed... The Quote of the day table has the "Configure" button, and it leads to the column configuration page, but that table is not in the list. To test: - Make sure you have quotes, add at least one, or add the sample quotes during installation, or load the installer/data/mysql/en/optional/sample_quotes.yml file 1. Go to Tools > Quote editor 2. Click "Configure" --> You are brought to the column settings page, but the quote editor table is not there -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:32:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:32:02 +0000 Subject: [Koha-bugs] [Bug 33705] Quote of the day: table has configure button even if it's not configurable In-Reply-To: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33705-70-E0gGAvU0g7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29723, 31435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 [Bug 29723] Add a "Configure table" button for KohaTable tables https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 [Bug 31435] "Configure this table" appears for non-configurable tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:32:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:32:02 +0000 Subject: [Koha-bugs] [Bug 29723] Add a "Configure table" button for KohaTable tables In-Reply-To: <bug-29723-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29723-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29723-70-LNUZ6CGgfX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 [Bug 33705] Quote of the day: table has configure button even if it's not configurable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:32:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:32:02 +0000 Subject: [Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables In-Reply-To: <bug-31435-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31435-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31435-70-70sJBrqDTg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 [Bug 33705] Quote of the day: table has configure button even if it's not configurable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:32:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:32:03 +0000 Subject: [Koha-bugs] [Bug 33704] Fixed length control fields does not save "Type of Material" when edited. In-Reply-To: <bug-33704-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33704-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33704-70-49WpmC79iA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33704 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Laura, this is one of those MARC things: you need to make sure that LDR Pos. 6 is set correctly, it determines what material type will be selected for 008. See bug 19419 and and bug 30871 - maybe we need to add more hints? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:33:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:33:34 +0000 Subject: [Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats In-Reply-To: <bug-33703-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33703-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33703-70-KOGvuMcu82@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #3 from Kristi <kkrueger at cuyahogalibrary.org> --- (In reply to Katrin Fischer from comment #2) > Which Dateformat are you using? > > I am not sure how easy it would be to implement this as the MM DD and YY > parts can be in a different position depending on the DateFormat. Do you > know if this worked with the old date picker widget? Our dateformat is set to mm/dd/yyyy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:44:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:44:05 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-b2ZynT40Ff@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 --- Comment #7 from Heather <heather_hernandez at nps.gov> --- I haven't been able to reproduce the problem. I created a sandbox without applying the patch (the sandbox is version 22.12.00.030), and created authority records with these values: 150 _ 0 Science 150 _ 0 Science B 150 _ 0 Science $v Bibliographies 150 _ 0 Science C 150 _ 0 Science $v Congresses (I created all of these because I wasn't sure if the plan meant literally "Science B" in the $a, or create a heading with a subdivision that begins with "B" after the $a Science, so I did both.) In the staff client, searching the $a for: Science Displays these headings sorting correctly: Science Science B Science Bibliographies Science Brazil Periodicals. Science C Science Congresses Likewise an authority search in the OPAC for "starts with" sorted by "heading ascendent" sorts them correctly: Science Science B Science Bibliographies Science Brazil Periodicals. Science C Science Congresses --h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:49:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:49:18 +0000 Subject: [Koha-bugs] [Bug 33706] New: Full serials permission required for managing frequencies Message-ID: <bug-33706-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33706 Bug ID: 33706 Summary: Full serials permission required for managing frequencies Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: sbrown at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The full serials permission is required in order to manage frequencies (subscription-frequencies.pl), which can be confusing for staff since managing numbering patters (subscription-numberpatterns.pl) does not thanks to bug 29608. It's unclear why managing frequencies should require more permissions than staff need to manage numbering patterns. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:49:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:49:22 +0000 Subject: [Koha-bugs] [Bug 33707] New: News vs Quote of the day styling on staff interface main page Message-ID: <bug-33707-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33707 Bug ID: 33707 Summary: News vs Quote of the day styling on staff interface main page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org I was updating the screenshots for the QOTD feature and noticed the styling for the news block and the styling for the QOTD block on the staff interface are slightly different. To test: - Have at least one news item for the staff interface (create one, load the sample ones in the web installer, or load the installer/data/mysql/en/optional/sample_news.yml file) - Have at least one quote (create one, load the sample ones in the web installer, or load the installer/data/mysql/en/optional/sample_quotes.yml file) - Enable the QuoteOfTheDay syspref for the staff interface - Go to the staff interface main page --> The news font is grey --> The quote font is black (or at least darker grey) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:50:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:50:45 +0000 Subject: [Koha-bugs] [Bug 33707] News vs Quote of the day styling on staff interface main page In-Reply-To: <bug-33707-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33707-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33707-70-foGvIiTDoh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33707 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I personally like the darker colour, as it's easier to read... but I'm not sure what the styling guide recommends -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:52:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:52:24 +0000 Subject: [Koha-bugs] [Bug 18398] CHECKIN/CHECKOUT/RENEWAL don't use AutoEmailPrimaryAddress but first valid e-mail In-Reply-To: <bug-18398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18398-70-dLfdLG7Gfh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:52:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:52:26 +0000 Subject: [Koha-bugs] [Bug 18398] CHECKIN/CHECKOUT/RENEWAL don't use AutoEmailPrimaryAddress but first valid e-mail In-Reply-To: <bug-18398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18398-70-HadHR9dYdf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 --- Comment #17 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:52:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:52:28 +0000 Subject: [Koha-bugs] [Bug 33216] SIP fee paid messages explode if payment registers are enabled and the SIP account has no register In-Reply-To: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33216-70-stHNuEDG4E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33216 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:52:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:52:30 +0000 Subject: [Koha-bugs] [Bug 33216] SIP fee paid messages explode if payment registers are enabled and the SIP account has no register In-Reply-To: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33216-70-ywsZ7eIvRQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33216 --- Comment #16 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:52:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:52:31 +0000 Subject: [Koha-bugs] [Bug 33354] Error 400 Bad Request when submitting form in ERM In-Reply-To: <bug-33354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33354-70-stZU4iVKLm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33354 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:52:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:52:33 +0000 Subject: [Koha-bugs] [Bug 33354] Error 400 Bad Request when submitting form in ERM In-Reply-To: <bug-33354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33354-70-Oxtqi7XWYd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33354 --- Comment #12 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:52:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:52:34 +0000 Subject: [Koha-bugs] [Bug 33402] ERM Cypress tests needs to be moved to their own directory In-Reply-To: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33402-70-FjyZOWiuDo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)| |22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:52:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:52:36 +0000 Subject: [Koha-bugs] [Bug 33402] ERM Cypress tests needs to be moved to their own directory In-Reply-To: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33402-70-6g2SoZmGfD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 --- Comment #14 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:52:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:52:38 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-ncLWmDdXVc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:52:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:52:40 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-gRS8zqYekN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 --- Comment #17 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:52:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:52:41 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-ZwbIO366qb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:52:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:52:43 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-qT4gcCO73Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 --- Comment #20 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:52:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:52:45 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-MPe36TlBk2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:52:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:52:46 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-XR7sCEVzHm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #18 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:52:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:52:48 +0000 Subject: [Koha-bugs] [Bug 33533] Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt In-Reply-To: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33533-70-IOtAfT3mOE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:52:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:52:49 +0000 Subject: [Koha-bugs] [Bug 33533] Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt In-Reply-To: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33533-70-skTrbNLRRp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:54:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:54:39 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-cXewEwkaFc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 --- Comment #8 from Heather <heather_hernandez at nps.gov> --- I added some more headings, with punctuation, since I noticed the problem originally in headings with punctuation. I added topical headings: 150 _ 0 Science (Fictitious character) 150 _ 0 Science Science 150 _ 0 Science-Science 150 _ 0 Science, Science And repeated the above searches, and everything is still sorting correctly without the patch applied, thusly, in both the staff client and the OPAC of the sandbox: Science Science B Science Bibliographies Science Brazil Periodicals. Science C Science Congresses Science fiction. Science (Fictitious character) Science Science Science-Science Science, Science SCIENCES DU SOL However, in my own Koha (version 22.05.11.000), the problem persists, with retrieved authority records sorting: Saint (Fictitious character) Saint Charles, Charles Rather than correctly as: Saint Charles, Charles Saint (Fictitious character) So the problem exists in my Koha catalog, but I can't reproduce the problem in a sandbox, so can't test the patch. I don't know whether to be happy or sad!:) --h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 22:57:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 20:57:22 +0000 Subject: [Koha-bugs] [Bug 33701] Catalogue detail page no longer shows all tab data when printing In-Reply-To: <bug-33701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33701-70-w8IjTKaL4q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33701 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It looks like the print layout was much better in the old design, something that slipped through unnoticed so far. For example navigation items and sidebar should be hidden. But this really feels like it should be fixed globally for printing tabs instead of only for the staff detail view. Another example is printing the patron account details/checkouts pages, holds awaiting pick-up etc. Is there a way the headings could be displayed above each content section? (asking, not blocker) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:01:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:01:04 +0000 Subject: [Koha-bugs] [Bug 33708] New: OAuth/OIDC authentication for the staff interface requires OPAC enabled Message-ID: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 Bug ID: 33708 Summary: OAuth/OIDC authentication for the staff interface requires OPAC enabled Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Because of a mistake, the code that generates the redirect URL on the OAuth/OIDC handshake is using the `/public`namespace regardless of the interface we are acessing. This has the consequence of requiring the public-facing API enabled. This is wrong! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:01:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:01:27 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-1TtesJxGQS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | CC| |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:03:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:03:26 +0000 Subject: [Koha-bugs] [Bug 31062] Change description of QOTD tool in tools-home In-Reply-To: <bug-31062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31062-70-XKW1jONY1u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31062 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/679 Resolution|--- |FIXED Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:03:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:03:27 +0000 Subject: [Koha-bugs] [Bug 31063] [OMNIBUS] QOTD tool In-Reply-To: <bug-31063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31063-70-Vy4hseVW49@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31063 Bug 31063 depends on bug 31062, which changed state. Bug 31062 Summary: Change description of QOTD tool in tools-home https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31062 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:05:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:05:20 +0000 Subject: [Koha-bugs] [Bug 6936] Allow to limit on multiple itemtypes when exporting bibliographic records In-Reply-To: <bug-6936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6936-70-cTU21GEFg6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6936 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose at inlibr | |o.com Status|Needs documenting |RESOLVED --- Comment #15 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Manual seems to be already updated for this. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:06:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:06:14 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-MwdpytlXT5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:06:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:06:16 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-1sLehXEyg9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150820|0 |1 is obsolete| | --- Comment #9 from David Nind <david at davidnind.com> --- Created attachment 150899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150899&action=edit Bug 26472: Configure Elasticsearch for better alphabetic sorting This enhancement configures the ICU collation keyword plugin used by Elasticsearch for sorting to better handle punctuation and whitespace in sort fields. Details at: https://www.elastic.co/guide/en/elasticsearch/plugins/current/analysis-icu-collation-keyword-field.html To test: 1. Create three authority records with the following values: 150 $a Science 150 $a Science $v B 150 $a Science $v C 2. Search for your authority records with "Science" in "Heading A-Z" order The search results will likely be in this order: 1. Science B 2. Science C 3. Science This is an unexpected order 3. Apply the patch and reindex sudo koha-elasticsearch --rebuild -r <instancename> 4. Search for your authority records again with "Science" in "Heading A-Z" order Confirm your search results show in the correct order. 1. Science 2. Science B 3. Science C Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:09:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:09:14 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-Ka8rODayCz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:10:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:10:37 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-ax3ullaX4I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:10:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:10:40 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-JZmvjGyaNZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150316|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150900&action=edit Bug 33550: Rename Patron restrictions administration page to Patron restriction types This patch renames 'Patron restriction' to 'Patron restriction type' in the context of custom restriction type administration. To test: 0. Apply patch 1. Enable PatronRestrictionTypes 2. Go to Administration 3. Check the name, spelling/grammar of the following elements * Section name * Section caption 4. Click 'Patron restriction types' 5. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Left hand side menu * 'New' button * Page heading 6. Click 'New restriction type' 7. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 8. Fill out the form and click 'Save' to create a new restriction type * Dialog message ('Restriction type added') 9. Click 'New restriction type' 10. Enter the same code as last time * Warning ('Restriction type code is already in use') 11. Click 'Cancel' 12. Click 'Edit' next to one of the types 13. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 14. Without changing anything, click 'Save' * Warning ('Restriction type label is already in use') 15. Change the label and click 'Save' * Dialog message ('Restriction type updated') 16. Click 'Delete' next to one of the types 17. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading * Delete button 18. Click 'Delete this restriction type' * Dialog message ('Restriction type deleted') Signed-off-by: Marius Mandrescu <marius.mandrescu at inLibro.com> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> https://bugs.koha-community.org/show_bug.cgi?id=33500 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:10:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:10:43 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-aTmhm1g03M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150317|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150901&action=edit Bug 33550: (follow-up) Rename Patron restrictions administration page to Patron restriction types) Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> https://bugs.koha-community.org/show_bug.cgi?id=33500 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:10:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:10:46 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-88CLZL5iLJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150318|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150902&action=edit Bug 33550: Remove period in patron restriction type description Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> https://bugs.koha-community.org/show_bug.cgi?id=33500 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:10:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:10:49 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-nLJwkBWBbv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150319|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150903&action=edit Bug 33550: Remove question mark in breadcrumb Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> https://bugs.koha-community.org/show_bug.cgi?id=33500 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:10:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:10:52 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-YrGYKeec0K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150904&action=edit Bug 33550: (QA follow-up) Switch from double to single quotes in text As we use single quotes in general and also in breadcrumbs and page title on this specific page, we shoudl also use them for the main content: Are you sure you want to delete 'T'? Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> https://bugs.koha-community.org/show_bug.cgi?id=33500 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:11:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:11:19 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-jxepUALCfM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 150905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150905&action=edit Bug 33708: Make staff interface login not require public API (OAuth/OIDC) This patch makes the URL for staff login not point to the `/public` namespace. The behavior is not changed for the protocol, but as `/public` requires several settings to be available, it effectively requires to enable the OPAC, the public API, etc. This patch diferentiates both to solve the problem. I've tested following the Wiki instructions to set keycloak [1] using the *--sso* switch for `ktd` as well [2]. It is important to set the following URLs as allowed redirect in order to replicate the issue and verify the fix: http://localhost:8080/api/v1/public/oauth/login/test/opac http://localhost:8081/api/v1/oauth/login/test/staff To test: 1. Login into the staff interface using the SSO link: => FAIL: Results in a 'Bad redirect URL' error 2. Apply this patch and repeat 1 => SUCCESS: You get a permission denied error or you just login, depending on your setup. [1] https://wiki.koha-community.org/wiki/Testing_SSO [2] ktd --sso up -d Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:11:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:11:41 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-fjMm70ighz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:12:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:12:18 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-Le8vpAn5m1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:13:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:13:39 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-cGquu6uqep@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 --- Comment #10 from David Nind <david at davidnind.com> --- I've signed this off, but I have a query: 1. If I add the authority records as per step 1 of the test plan, the authority records sort correctly both before and after the patch is applied. 2. If I add some punctuation to the terms, then before applying they don't sort correctly, but after the patch they do. For example: 150 $a Science. (displays last) 150 $a Science $v B (displays second) 150 $a Science $v (C) (displays first) Reading the bug, I'm assuming that the problem we are trying to solve is for terms with punctuation. Testing notes (using koha-testing-docker (KTD)): 1. I tested using Elasticsearch 7 - let me know if it should be tested with other versions, and Open Search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:15:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:15:45 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-QPmNfZ7879@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:15:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:15:47 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-yIBmgvg8QZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149719|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150906&action=edit Bug 33512: Change text and add button classes on serial-edit page To test: 1. Create a subscription 2. Make sure that you choose "Create an item record" when receiving the serial and associate it with a record. 3. Fill out the numbering pattern stuff and save the subscription. 4. Receive and change the status to arrived. Doing so will make the item subfields appear for editing. 5. Add some stuff, like a barcode, and Save. 6. Now, if you have made a mistake, you may want to edit the serial/item. Check the edit box and click 'Edit serials ' 7. For your issue that has already arrived click 'Click to add item'. The item record from before appears. 8. Apply patch. 9. Try 6 & 7 again. The existing items should now read 'Click to edit item' Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:15:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:15:50 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-mevhqC2gXa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149720|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150907&action=edit Bug 33512: (QA follow-up) Remove 'Click to' from buttons This is following recommendations from accessibility guidelines. It being a link or button already indicates that you need to click it. We don't need to spell it out. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:15:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:15:53 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-NOzTfU5shB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150179|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150908&action=edit Bug 33512: (follow-up) Check item count before adding add/edit button Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:19:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:19:46 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-3Kal4lZv5D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 Janusz Kaczmarek <januszop at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #11 from Janusz Kaczmarek <januszop at gmail.com> --- (In reply to Heather from comment #8) > However, in my own Koha (version 22.05.11.000), the problem persists, with > retrieved authority records sorting: > > Saint (Fictitious character) > Saint Charles, Charles > > Rather than correctly as: > Saint Charles, Charles > Saint (Fictitious character) > > So the problem exists in my Koha catalog, but I can't reproduce the problem > in a sandbox, so can't test the patch. I don't know whether to be happy or > sad!:) But did you check "Saint (Fictitious character)" vs. "Saint (Fictitious character)" in the test environment? I must say, with the Aleisha's examples I got always correct results, with or without the patch (there is no punctuation). However with the two Saints I get: Saint (Fictitious character) Saint Charles, Charles without the patch, and: Saint Charles, Charles Saint (Fictitious character) with the patch applied. Aleisha, could you please verify your test data proposal? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:20:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:20:51 +0000 Subject: [Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news and HTML customizations In-Reply-To: <bug-22659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22659-70-zurcTtPJmW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/679 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:31:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:31:04 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-U9qRphGeO1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano at theke.io -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:36:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:36:20 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-6vUXIuh2sL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org --- Comment #10 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- Item_found and item_lost don't fit very well with the other types of actions recorded in statistics, conceptually. Everything else is an action that someone took -- checkout, checkin, payment, writeoff, etc. Item_found and item_lost are changes to the state of the item as a result of one of those actions. So this feels like it's adding confusion to the nature of the data recorded in this table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:40:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:40:02 +0000 Subject: [Koha-bugs] [Bug 33390] Expand links to authorized values interface when an authval is mentioned in preferences In-Reply-To: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33390-70-wleqvHccnl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:40:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:40:05 +0000 Subject: [Koha-bugs] [Bug 33390] Expand links to authorized values interface when an authval is mentioned in preferences In-Reply-To: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33390-70-UCxIl9J2TY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149110|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150909&action=edit Bug 33390: Add links to various system preference descriptions To test: 1. Apply patch and look at the descriptions of the following system preferences. Make sure each link works and makes sense: DefaultLongOverdueChargeValue DefaultLongOverdueLostValue and DefaultLongOverdueDays DefaultLongOverdueSkipLostStatuses UpdateItemWhenLostFromHoldList NewItemsDefaultLocation UpdateItemLocationOnCheckin SkipHoldTrapOnNotForLoanValue UpdateNotForLoanStatusOnCheckin Reference_NFL_Statuses ItemsDeniedRenewal Signed-off-by: Catrina <catrina at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:40:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:40:07 +0000 Subject: [Koha-bugs] [Bug 33390] Expand links to authorized values interface when an authval is mentioned in preferences In-Reply-To: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33390-70-GHLTvvG7KH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150178|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150910&action=edit Bug 33390: (follow-up) move ItemsDeniedRenewal links to less confusing place Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:40:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:40:10 +0000 Subject: [Koha-bugs] [Bug 33390] Expand links to authorized values interface when an authval is mentioned in preferences In-Reply-To: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33390-70-qqmpFLbd2B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150911&action=edit Bug 33390: (QA follow-up) Rephrase some preferences * to include 'authorised value' in text * to keep sentences on one line (translation) * to use sentences instead of just links in some places Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:40:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:40:59 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-pumbvBZK68@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 --- Comment #12 from David Nind <david at davidnind.com> --- Additional notes: 1. I added Heather's and Janusz's terms - before the patch is applied they sort incorrectly, after the patch they sort correctly (I can attach some screenshots if that helps). 2. After applying the patch, I restarted everything (flush_memcached and restart_all) and I did a full re-index (koha-elasticsearch --rebuild -d -b -a kohadev). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:41:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:41:02 +0000 Subject: [Koha-bugs] [Bug 33390] Expand links to authorized values interface when an authval is mentioned in preferences In-Reply-To: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33390-70-Oj3IneOKCx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I tried to provide some more context in a few spots. Lucas, if you hate it, please feel free to obsolete :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:55:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:55:21 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-SAmo7N0nwM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Issue refund" is not fully |Move debit and credit types |translatable |to YAML files to make them | |translatable for use in | |reports --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The templates use .inc files to make the system internal debit and credit types multi-lingual. So this will only affect reports or places where the description is pulled from the database directly (which we shouldn't do... but...) My initial bug was about things missing from the include files, this might be still something to investigate, but repurposing this one now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:55:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:55:52 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-vewSv9F9lY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:55:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:55:55 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-1ydB4V6ZrM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150912&action=edit Bug 26403: Move credit and debit types into translatable YAML files This patch moves account debit and credit types, as well as the CASH payment type, into YAML files under installer/data/en/mandatory. This should make the debit and credit types translatable (for new installations only). To test: 1. Apply patch 2. Update po files ./misc/translator/translate update xx-XX 3. View the xx-XX-installer.po file -->The default account debit and credit types (and cash payment type) should be available to be translated 4. Translate the strings 5. Apply the translations ./misc/translator/translate install xx-XX 6. Load the new translated YAML files (with a fresh install, or by deleting the values in the db and using ./misc/load_yaml.pl to load the files) 7. In the staff interface, go to Administration > Credit types --> They should be translated 8. Go to Administration > Debit types --> They should be translated Signed-off-by: Magnus Enger <magnus at libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> 150744 - Bug 26403: "Issue refund" is not fully translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:55:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:55:58 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-8dcErLGYuA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150745|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150913&action=edit Bug 26403: (follow-up) Deleted old SQL files Signed-off-by: Magnus Enger <magnus at libriotech.no> Followed the test plan. Works as advertised. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:57:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:57:34 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-8Pp4PSn1Jn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150899|0 |1 is obsolete| | --- Comment #13 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150914&action=edit Bug 26472: Configure Elasticsearch for better alphabetic sorting This enhancement configures the ICU collation keyword plugin used by Elasticsearch for sorting to better handle punctuation and whitespace in sort fields. Details at: https://www.elastic.co/guide/en/elasticsearch/plugins/current/analysis-icu-collation-keyword-field.html To test: 1. Create three authority records with the following values: 150 $a Science. 150 $a Science $v B. 150 $a Science $v C. 2. Search for your authority records with "Science" in "Heading A-Z" order The search results will likely be in this order: 1. Science B. 2. Science C. 3. Science. This is an unexpected order 3. Apply the patch and reindex sudo koha-elasticsearch --rebuild -r <instancename> 4. Search for your authority records again with "Science" in "Heading A-Z" order Confirm your search results show in the correct order. 1. Science. 2. Science B. 3. Science C. Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:57:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:57:55 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-Nyi0NqvU7F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 --- Comment #14 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Oops, left the punctuation off my test plan, have amended -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 9 23:59:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 21:59:29 +0000 Subject: [Koha-bugs] [Bug 33575] Add table settings to hold_table on /reserve/request.pl In-Reply-To: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33575-70-WPVy3jEWS8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 00:10:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 22:10:33 +0000 Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version In-Reply-To: <bug-23073-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23073-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23073-70-g4oyq6utLF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 --- Comment #37 from David Nind <david at davidnind.com> --- Hi Thomas. Could you have a look at the account request settings? Lately, very few new account requests are coming through for approval. In the Recent changes page, there are lots of accounts being created (see the recent changes page - User creation log entries). Most are red linked, but these have not been coming through the Confirm account requests page (https://wiki.koha-community.org/wiki/Special:ConfirmAccounts). Also, there are some spam pages that need deleting - see 4 May 2023 on the recent changes page. See also, the discussion on the development mailing list: https://lists.koha-community.org/pipermail/koha-devel/2023-May/048145.html Thanks! David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 00:18:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 22:18:32 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-6LPtUvyTnr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from David Nind <david at davidnind.com> --- (In reply to Aleisha Amohia from comment #14) > Oops, left the punctuation off my test plan, have amended Thanks ALeisha. I can confirm that with the change, authorities with punctuation are now sorting correctly (Heading A-Z). Tested using Elasticsearch 7. Have changed the status to Signed Off. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 00:20:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 22:20:23 +0000 Subject: [Koha-bugs] [Bug 33575] Add table settings to hold_table on /reserve/request.pl In-Reply-To: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33575-70-XjeYgOylO4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 00:20:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 22:20:26 +0000 Subject: [Koha-bugs] [Bug 33575] Add table settings to hold_table on /reserve/request.pl In-Reply-To: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33575-70-EtEF4eVq3N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150187|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150915&action=edit Bug 33575: Add dataTable to hold table on /reserve/request.tt To test: 1. Have a record with several holds on it. 2. Go to the holds page for that record ( /cgi-bin/koha/reserve/request.pl?biblionumber=144 ) 3. Cannot sort by columns 4. Apply patch, restart_all 5. Now the table should be a dataTable that will allow you sort. 6. Try hiding columns by clicking on the 'Columns' icon above the table, make sure columns are correctly being hidden. 7. Try to hide columns by going to Adminstration > Table settings ( Circulation > Holds > patron_holds_table ), make sure columns are correctly being hidden. 8. Now login with a user who has the 'place_holds' permission but does NOT have the 'modify_holds_priority' permssion. 9. The table will not have the change priority columns. Make sure all columns can still be hidden/shown correctly for that use. Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 00:20:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 22:20:28 +0000 Subject: [Koha-bugs] [Bug 33575] Add table settings to hold_table on /reserve/request.pl In-Reply-To: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33575-70-vG4CxTj2M3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150188|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150916&action=edit Bug 33575: (follow-up) don't allow priority and pickup location to be hidden Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 00:20:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 22:20:31 +0000 Subject: [Koha-bugs] [Bug 33575] Add table settings to hold_table on /reserve/request.pl In-Reply-To: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33575-70-uy9Y15KV1g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150917&action=edit Bug 33575: (QA follow-up) Fix date sorting on Date column Implements correct date sorting for different date formats on the Date column. See: https://wiki.koha-community.org/wiki/DataTables_HowTo#Sorting_dates_regardless_of_date_format_preference Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 00:21:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 22:21:52 +0000 Subject: [Koha-bugs] [Bug 33575] Add table settings to the holds table for a specific record in the staff interface In-Reply-To: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33575-70-Yj39cjNLxK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add table settings to |Add table settings to the |hold_table on |holds table for a specific |/reserve/request.pl |record in the staff | |interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 01:30:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 23:30:09 +0000 Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees In-Reply-To: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33411-70-If9GmDONSs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net |y.org | CC| |victor at tuxayo.net --- Comment #6 from Victor Grousset/tuxayo <victor at tuxayo.net> --- > 11 - Parent blocked, children should not be David's test have the parent unblocked thanks to the patch. Is the test plan wrong then? I can't get a difference with and without the patch. Even after doing "koha-sip --restart" is that the right way? (testing on ktd) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 01:30:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 23:30:26 +0000 Subject: [Koha-bugs] [Bug 33701] Catalogue detail page no longer shows all tab data when printing In-Reply-To: <bug-33701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33701-70-e9HliCYXCj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33701 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- (In reply to Katrin Fischer from comment #3) > It looks like the print layout was much better in the old design, something > that slipped through unnoticed so far. For example navigation items and > sidebar should be hidden. Yeah I was thinking the same thing. The old print layout was quite nice really. I can see why it slipped past though. I don't know why people print webpages... > But this really feels like it should be fixed globally for printing tabs > instead of only for the staff detail view. Agreed. I'm not familiar enough with the whole design to know how to do it. But happy to help someone who does. > Another example is printing the patron account details/checkouts pages, > holds awaiting pick-up etc. I think we might need to define a class like "print-visible" and then apply it to each tab panel on each page individually. I think the same classes are used for all the tabs at the moment, which makes it tough to isolate certain parts of the page. But hopefully a person more focused on the frontend UI can weigh in on that one.. > Is there a way the headings could be displayed above each content section? > (asking, not blocker) Not that I know of since the HTML for the tab headings and tab contents are in different spots, but someone else might have an idea for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 01:54:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 23:54:30 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-GttpjVMCwn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 01:58:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 May 2023 23:58:21 +0000 Subject: [Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats In-Reply-To: <bug-33703-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33703-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33703-70-EFOrx6iMgh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 02:42:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 00:42:14 +0000 Subject: [Koha-bugs] [Bug 16327] Running build_oai_sets.pl with embed items option should consider every item in a biblio In-Reply-To: <bug-16327-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16327-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16327-70-mPvU7jQWlA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16327 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook <dcook at prosentient.com.au> --- Yikes... this isn't good... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 02:47:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 00:47:02 +0000 Subject: [Koha-bugs] [Bug 16327] Running build_oai_sets.pl with embed items option should consider every item in a biblio In-Reply-To: <bug-16327-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16327-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16327-70-wVUPDVlUZr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16327 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- The code has changed since this was posted. I'm doing some testing of OAI sets, so I might try to see if I can reproduce this one, but I think it's probably invalid at this point. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 03:06:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 01:06:35 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-uQ1DRbelEG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 --- Comment #2 from David Cook <dcook at prosentient.com.au> --- Looking at this now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 03:15:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 01:15:07 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-g72WBL1AOa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from David Cook <dcook at prosentient.com.au> --- Not all URLs are updated it seems. The path for the URL for the button "Log in with Keycloak" on the staff interface is still /api/v1/public/oauth/login/keycloak/staff If you disable the sysprefs "RESTPublicAnonymousRequests" and "RESTPublicAPI", you'll see the following error {"error":"Configuration prevents the usage of this endpoint by unprivileged users"} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 03:30:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 01:30:43 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-F2ov6HMZRV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- If I fix the URL, then I get a 404. I see the paths in api/v1/swagger/paths/oauth.yaml but it doesn't appear in http://localhost:8081/api/v1/.html Ah because it's missing from api/v1/swagger/swagger.yaml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 03:35:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 01:35:43 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-VVpFBROkhy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 --- Comment #5 from David Cook <dcook at prosentient.com.au> --- If I fix the URL and the Swagger, then I get a 401 trying to access http://localhost:8081/api/v1/oauth/login/keycloak/staff I think I thought about this a bit when the OAuth/OIDC functionality was being developed. -- (The public endpoint actually has a similar problem. If you have disabled OpacPublic, you have to enable RESTPublicAnonymousRequests in order to use the OAuth/OIDC for the OPAC.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 03:36:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 01:36:56 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-jTjkDS0yO7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 --- Comment #6 from David Cook <dcook at prosentient.com.au> --- Created attachment 150918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150918&action=edit Bug 33708: Provide non-public endpoint for OAuth/OIDC for staff interface This change fixes the definition for the non-public endpoint for the OAuth/OIDC implementation. It also uses the non-public endpoint for the staff interface UI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 04:45:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 02:45:11 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-Ter7KDhTze@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 04:45:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 02:45:14 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-7L9lfg4GrZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 --- Comment #7 from David Cook <dcook at prosentient.com.au> --- Created attachment 150919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150919&action=edit Bug 33708: Allow anonymous access to OAuth endpoints Users needs anonymous access to OAuth endpoints so that they can login, and then use authenticated access for other endpoints. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 04:46:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 02:46:08 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-ZXGu1mHifA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 --- Comment #8 from David Cook <dcook at prosentient.com.au> --- Tomas, take a look at my patches and let me know what you think. With all 3 patches, I've tested OIDC on staff interface and OPAC, and gotten them working with their respective URLs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 06:13:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 04:13:23 +0000 Subject: [Koha-bugs] [Bug 24400] REST API: Checkout In-Reply-To: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24400-70-RVUPv9fJva@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24400 Danyon Sewell <danyonsewell at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150495|0 |1 is obsolete| | --- Comment #3 from Danyon Sewell <danyonsewell at catalyst.net.nz> --- Created attachment 150920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150920&action=edit Bug 24400: Rest API for checkout WIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 06:18:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 04:18:47 +0000 Subject: [Koha-bugs] [Bug 24400] REST API: Checkout In-Reply-To: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24400-70-Bi0cPED8it@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24400 --- Comment #4 from Danyon Sewell <danyonsewell at catalyst.net.nz> --- Created attachment 150921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150921&action=edit fixing variable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 06:26:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 04:26:04 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-hV34GXtcOE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #33 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Kyle M Hall from comment #32) > I do not think this is a great idea long term. This is moving backwards when > it comes to efficiency and will introduce far more database calls. It seems > like it might be better to fix the code that is making a bad assumption. The > short term fix is to use discard_changes when needed. The long term fix is > to use Koha objects from the perl scripts and pass them to subroutines so we > have no need to re-fetch data from the database. > > Have you identified any bugs being caused by this, or it just a possibility > as you've shown? This is a bad pattern, we should get rid of it and prevent it from propagating over the codebase. The correct way to fix the refetch is patch like bug 32496 and bug 31735. There is also bug 32476 that can be helpful to cache *calculated* values when specific performance problems are identified. Here we are caching only 1 DB call that is already cached by an underlying mechanism anyway (DBMS or DBIC). > It seems like it might be better to fix the code that is making a bad assumption. No need to make bad assumption to get incorrect results, see comment 0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 06:32:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 04:32:51 +0000 Subject: [Koha-bugs] [Bug 33705] Quote of the day: table has configure button even if it's not configurable In-Reply-To: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33705-70-j07rT4Zmxu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33066 Keywords| |rel_23_05_candidate Assignee|oleonard at myacpl.org |jonathan.druart+koha at gmail. | |com CC| |jonathan.druart+koha at gmail. | |com Status|NEW |ASSIGNED Severity|enhancement |normal --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Caused by commit 765fd1ced3b9efc4ff6fb71e2fee1a7a227d1cae Bug 33066: Introduce a KohaTable Vue component Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 [Bug 33066] We need a KohaTable Vue component -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 06:32:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 04:32:51 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-hGbiyw7lsz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 [Bug 33705] Quote of the day: table has configure button even if it's not configurable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 06:34:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 04:34:26 +0000 Subject: [Koha-bugs] [Bug 33705] Tables have configure button even if it's not configurable In-Reply-To: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33705-70-GyBL9wuFaM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Quote of the day: table has |Tables have configure |configure button even if |button even if it's not |it's not configurable |configurable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 06:34:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 04:34:35 +0000 Subject: [Koha-bugs] [Bug 33705] Tables have configure button even if they are not configurable In-Reply-To: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33705-70-YdcbUWb0H5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Tables have configure |Tables have configure |button even if it's not |button even if they are not |configurable |configurable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 06:37:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 04:37:41 +0000 Subject: [Koha-bugs] [Bug 33705] Tables have configure button even if they are not configurable In-Reply-To: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33705-70-CsWbKa8uIJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 06:37:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 04:37:44 +0000 Subject: [Koha-bugs] [Bug 33705] Tables have configure button even if they are not configurable In-Reply-To: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33705-70-mLRZvqq9Zw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150922&action=edit Bug 33705: (bug 33066 follow-up) Fix 'configure' button for kohaTable The 'configure' button is displayed for any tables, even those that cannot be configured. This is a regression caused by commit 765fd1ced3b9efc4ff6fb71e2fee1a7a227d1cae Bug 33066: Introduce a KohaTable Vue component It's adding a default value for table_settings, but then later we are testing if table_settings is true: 699 let table_settings = params.table_settings || {}; ... 798 if ( table_settings && CAN_user_parameters_manage_column_config ) { This patch is reverting the default value, so the test will be corrected. Test plan: 1. Go to Tools > Quote editor 2. Click "Configure" => Without this patch you are brought to the column settings page, but the quote editor table is not there => With this patch the button is not present 3. Go to the cities page (admin/cities.pl) 4. Click "Configure" => You are brought to the column settings page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 06:47:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 04:47:36 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-FfGpuu0cSK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- 1. Then I would C4::Biblio::GetFrameworkCode and cache there. 2. - my $tagslib = C4::Biblio::GetMarcStructure(1, $frameworkcode); + my $tagslib = C4::Biblio::GetMarcStructure( 1, $frameworkcode, { unsafe => 1 } ); Yes, definitely. 3. - my $value = $self->$column; + my $value = $self->_result()->get_column($column); Really faster? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 08:09:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 06:09:44 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-gRim74Me70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- The first two patches look like duplicates to me and I don't understand how the first one fixes the issue refund issue initially reported. Also, this encourages bad practice in so much as the DB level descriptions are not meant it be used. Has someone broken the use of the include somewhere to make this work.. the DB fields should ONLY be getting used for reports.. nowhere else -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 08:21:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 06:21:01 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-6KAxnjaMkV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Your just introducing double translation here. The "correct" patch would change the .description calls in the two tables to use the include as intended. I have a feeling that got undone during QA of the original patchsets that added these management pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 08:39:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 06:39:41 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-DRUyNpcJxt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150925&action=edit Bug 26403: Use accounts include in account management pages This patch updates the credit and debit types management pages to use the proper includes for handling system type translations. This is how it should have been done in the first place on the original bugs that introduced the management of these types but for some reason I think it got dropped during the QA process leading to confusion around these system types with their fixed descriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 08:39:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 06:39:53 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-769cmDs3Cx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 08:40:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 06:40:51 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-tF7YlX7Uuw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Please try the final patch as an alternative. With this version you do not need to translate the strings again, they should already all be in appearance in the po files so we're no longer doubling up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 08:42:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 06:42:12 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-MWnL4adqQ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150634|0 |1 is obsolete| | Attachment #150635|0 |1 is obsolete| | Attachment #150636|0 |1 is obsolete| | Attachment #150637|0 |1 is obsolete| | Attachment #150638|0 |1 is obsolete| | Attachment #150639|0 |1 is obsolete| | --- Comment #79 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150926&action=edit Bug 17427: Remove SessionStorage mock from tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 08:42:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 06:42:17 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-Y6FeKsFDuK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #80 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150927&action=edit Bug 17427: Embed Data::Session Test plan: Install libdata-session-perl and make sure our lib has priority over the installed version -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 08:42:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 06:42:20 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-DBI3nC0SOO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #81 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150928&action=edit Bug 17427: Remove confusion between session id and param id FIXME Certainly more work needed here -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 08:42:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 06:42:24 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-UNIGODeIOD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #82 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150929&action=edit Bug 17427: HACKY - force new session Look at Data::Session->new, it's calling $self -> load_session; Then look at load_session then user_id => we are retrieving the ID from the cookie But in our Auth.t tests we are mocking CGI->cookie to always return the previous CGISESSID We should certainly adjust the test here, and remove this patch. 194 # Note: We can test return values from checkauth here since we mocked the safe_exit after the Redirect 303 195 is( $return[0], $patron2->userid, 'Login of patron2 approved' ); 196 isnt( $return[2], $sessionID, 'Did not return previous session ID' ); 197 ok( $return[2], 'New session ID not empty' ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 08:42:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 06:42:28 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-5MDXJZNwv5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #83 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150930&action=edit Bug 17427: Retrieve sessionID from HTTP_COOKIE To make some tests pass (t/db_dependent/Auth.t) and mimick what did CGI::Session, but that is certainly useless and the tests should be adjusted. Commit modified, added ';' see comment 78 - if ( $http_cookie && $http_cookie =~ m{CGISESSID=([^,:]*)} ) { + if ( $http_cookie && $http_cookie =~ m{CGISESSID=([^,:;]*)} ) { sessionID was "a035bf508448b8b3ecd1ca23609b90b3; bib_list=; KohaOpacLanguage=; JWT= " -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 08:42:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 06:42:31 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-idOZ4ba3M4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #84 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150931&action=edit Bug 17427: Fix id vs userid in tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 08:42:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 06:42:46 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-7GOs5s1PV5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #85 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Kyle M Hall from comment #78) > After applying the patches and running reset_all in ktd, I get the following > error when I try to log in: > > Data::Session::Driver::mysql::store(): DBI Exception: DBD::mysql::db do > failed: Data too long for column 'id' at row 1 at > /kohadevbox/koha/lib/Data/Session.pm line 262 > at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Fixed in "Retrieve sessionID from HTTP_COOKIE" Patches rebased against master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 08:44:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 06:44:44 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-bGyoIZSUKJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- You can also keep the original patches if you want.. but the test plan should be altered to: To test: 1. Apply patch 2. Update po files ./misc/translator/translate update xx-XX 3. View the xx-XX-installer.po file -->The default account debit and credit types (and cash payment type) should be available to be translated 4. Translate the strings 5. Apply the translations ./misc/translator/translate install xx-XX 6. Load the new translated YAML files (with a fresh install, or by deleting the values in the db and using ./misc/load_yaml.pl to load the files) 7. In the staff interface, go to Reports 8. Create a report that includes credit_type.description and debit_type.description 9. Run the report and note the translated values For ALL other occurrences of credit type or debit type in the UI and notices, you should find translations are already applied using the template based translations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 08:45:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 06:45:03 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-biJAXC6swg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150744|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 08:46:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 06:46:30 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-MJxDReOyqE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150925|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150932&action=edit Bug 26403: Use accounts include in account management pages This patch updates the credit and debit types management pages to use the proper includes for handling system type translations. This is how it should have been done in the first place on the original bugs that introduced the management of these types but for some reason I think it got dropped during the QA process leading to confusion around these system types with their fixed descriptions. To test: 1. Apply patch 2. Apply the translations ./misc/translator/translate install xx-XX 3. In the staff interface, go to Administration > Credit types --> They should be translated 4. Go to Administration > Debit types --> They should be translated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 08:58:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 06:58:54 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-VG7VFmemW5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #86 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #73) > Created attachment 150638 [details] [review] > Bug 17427: Retrieve sessionID from HTTP_COOKIE > > To make some tests pass (t/db_dependent/Auth.t) and mimick what did > CGI::Session, but that is certainly useless and the tests should be > adjusted. This patch fixes some tests but make the sessionID handling very wrong. We always end up with the same sessionID (even after logout, change user, etc.) I think we should revert it and remove the related tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 09:00:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 07:00:00 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17427-70-aFWfFigKuy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|dependency | --- Comment #87 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Mason James from comment #37) > hi joubu > i've uploaded a libdata-session-perl pkg to koha-staging/dev, for testing If we are going with the approach we have now we won't need it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 09:02:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 07:02:09 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-EJHKHfSFRV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update plugin |Update plugin |unimarc_field_110.pl |unimarc_field_100.pl |'Script of title' with 2022 |'Script of title' with 2022 |values |values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 09:02:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 07:02:30 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-kC46Egq613@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 --- Comment #4 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Comment on attachment 150790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150790 Bug 33686: Update plugin unimarc_field_110.pl with 2022 values >From 0fc81a34b3ff8e6eaf1b1270282a31cfc8453c8b Mon Sep 17 00:00:00 2001 >From: Thibaud Guillot <thibaud.guillot at biblibre.com> >Date: Fri, 5 May 2023 13:01:23 +0200 >Subject: [PATCH] Bug 33686: Update plugin unimarc_field_100.pl with 2022 > values >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Was missing : > >- ib : birman >- ic : khmer >- jb : bengali >- jc : gujurati >- jd : gurmukhi >- je : odia (oriya) >- lb : kannada (kannara) >- lc : malayalam >- ld : singhalais (cinghalais) >- le : télougou >- na : éthiopien (guèze) > >Sponsored by BibLibre > >Signed-off-by: David Nind <david at davidnind.com> >--- > .../value_builder/unimarc_field_100.tt | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100.tt >index 103e8949cc..23e43cff13 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100.tt >@@ -685,6 +685,16 @@ > [% ELSE %] > <option value="ia">ia- Thai</option> > [% END %] >+ [% IF ( f15ib ) %] >+ <option value="ib" selected="selected">ib- Birman</option> >+ [% ELSE %] >+ <option value="ib">ib- Birman</option> >+ [% END %] >+ [% IF ( f15ic ) %] >+ <option value="ic" selected="selected">ic- Khmer</option> >+ [% ELSE %] >+ <option value="ic">ic- Khmer</option> >+ [% END %] > [% IF ( f15id ) %] > <option value="id" selected="selected">id- Laotian</option> > [% ELSE %] >@@ -700,6 +710,26 @@ > [% ELSE %] > <option value="ja">ja- Devanagari</option> > [% END %] >+ [% IF ( f15jb ) %] >+ <option value="jb" selected="selected">jb- Bengali</option> >+ [% ELSE %] >+ <option value="jb">jb- Bengali</option> >+ [% END %] >+ [% IF ( f15jc ) %] >+ <option value="jc" selected="selected">jc- Gujurati</option> >+ [% ELSE %] >+ <option value="jc">jc- Gujurati</option> >+ [% END %] >+ [% IF ( f15jd ) %] >+ <option value="jd" selected="selected">jd- Gurmukhi</option> >+ [% ELSE %] >+ <option value="jd">jd- Gurmukhi</option> >+ [% END %] >+ [% IF ( f15je ) %] >+ <option value="je" selected="selected">je- Odia (oriya)</option> >+ [% ELSE %] >+ <option value="je">je- Odia (oriya)</option> >+ [% END %] > [% IF ( f15jf ) %] > <option value="jf" selected="selected">jf- Tibetan</option> > [% ELSE %] >@@ -720,6 +750,26 @@ > [% ELSE %] > <option value="la">la- Tamil</option> > [% END %] >+ [% IF ( f15lb ) %] >+ <option value="lb" selected="selected">lb- Kannada (kannara)</option> >+ [% ELSE %] >+ <option value="lb">lb- Kannada (kannara)</option> >+ [% END %] >+ [% IF ( f15lc ) %] >+ <option value="lc" selected="selected">lc- Malayalam</option> >+ [% ELSE %] >+ <option value="lc">lc- Malayalam</option> >+ [% END %] >+ [% IF ( f15ld ) %] >+ <option value="ld" selected="selected">ld- Singhalais (cinghalais)</option> >+ [% ELSE %] >+ <option value="ld">ld- Singhalais (cinghalais)</option> >+ [% END %] >+ [% IF ( f15le ) %] >+ <option value="le" selected="selected">le- Tégoulou</option> >+ [% ELSE %] >+ <option value="le">le- Tégoulou</option> >+ [% END %] > [% IF ( f15lf ) %] > <option value="lf" selected="selected">lf- Grantha</option> > [% ELSE %] >@@ -735,6 +785,11 @@ > [% ELSE %] > <option value="mb">mb- Armenian</option> > [% END %] >+ [% IF ( f15na ) %] >+ <option value="na" selected="selected">na- Ethiopien (guèze)</option> >+ [% ELSE %] >+ <option value="na">na- Ethiopien (guèze)</option> >+ [% END %] > [% IF ( f15nb ) %] > <option value="nb" selected="selected">nb- Tifinagh (Berber alphabet)</option> > [% ELSE %] >-- >2.30.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 09:02:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 07:02:55 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-tOPUqIaAmV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150790|Bug 33686: Update plugin |Bug 33686: Update plugin description|unimarc_field_110.pl with |unimarc_field_100.pl with |2022 values |2022 values Attachment #150790|Bug-33686-Update-plugin-uni |Bug-33686-Update-plugin-uni filename|marcfield110pl-with-202.pat |marcfield100pl-with-202.pat |ch |ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 09:05:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 07:05:37 +0000 Subject: [Koha-bugs] [Bug 33667] 'Copy to all libraries' doesn't work on editing holidays In-Reply-To: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33667-70-RRtK26A79a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33667 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at koha-suomi.fi | |, | |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Emmi, can you have a look at this one please? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 09:17:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 07:17:25 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements (concatenations, substrings, conditions...) In-Reply-To: <bug-12404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12404-70-okjY0ZRAl4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #62 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Katrin Fischer from comment #61) > I tried to use an example from the old help file, but I got: > > + <li>Display all 245$a and 245$c into the same column: > + <p> > + [% FOREACH field IN fields.245 %] > + [% field.a %] [% field.c %] > + [% END %] > + </p> > + </li> > > Titel=[% FOREACH field IN fields.245 %][% field.a %] [% field.b %] [% > field.n %] [% field.p %] [% field.c %][% END %] > > ARRAY(0x5642032a0638) ARRAY(0x564202a832f0) ARRAY(0x564203388d48) > ARRAY(0x5642033cc020) ARRAY(0x564203439cc0) field.a contains the list of a's. The following works: Title=[% FOREACH field IN fields.245 %][% field.a.0 %] [% field.b.0 %] [% field.n.0 %] [% field.p.0 %] [% field.c.0 %][% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 09:21:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 07:21:12 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements (concatenations, substrings, conditions...) In-Reply-To: <bug-12404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12404-70-x3Ro5kP2ru@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #63 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #62) > (In reply to Katrin Fischer from comment #61) > > I tried to use an example from the old help file, but I got: > > > > + <li>Display all 245$a and 245$c into the same column: > > + <p> > > + [% FOREACH field IN fields.245 %] > > + [% field.a %] [% field.c %] > > + [% END %] > > + </p> > > + </li> > > > > Titel=[% FOREACH field IN fields.245 %][% field.a %] [% field.b %] [% > > field.n %] [% field.p %] [% field.c %][% END %] > > > > ARRAY(0x5642032a0638) ARRAY(0x564202a832f0) ARRAY(0x564203388d48) > > ARRAY(0x5642033cc020) ARRAY(0x564203439cc0) > > field.a contains the list of a's. > The following works: > Title=[% FOREACH field IN fields.245 %][% field.a.0 %] [% field.b.0 %] [% > field.n.0 %] [% field.p.0 %] [% field.c.0 %][% END %] Ha, there is a follow-up commit: commit c33c56028fb39a464a780b2a22e95af0da73585f Bug 12404: FIX documentation to join subfield The correct syntax is: <li>Display all 245$a and 245$c into the same column: <p> [% FOREACH field IN fields.245 %] [% field.a.join(' ') %] [% field.c.join(' ') %] [% END %] </p> </li> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 09:37:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 07:37:18 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-1VwmgWr06N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- https://irc.koha-community.org/koha/2023-05-09#i_2485635 """ it could certainly be /config/erm i.e. constrained to specific modules and instead of exposing the sysprefs list enabled modules or components in terms of your solution, it is just a matter of naming things more generically, and consistently """ Please be explicit, I don't understand. I am exposing ERMModule and ERMProviders. Why should I make the code obscure and hide that behind an other config key? Having the syspref names in tt/vue to grep make things easy. If it's really important for you, I am suggesting /config/erm { enabled => 1|0, providers => ['local', 'ebsco'], } For now. Then we will add the permission list later (for bug 32968), and it could be something like: { enabled => 1|0, providers => ['local', 'ebsco'], permissions => ['agreements.write', 'eholdings.write'], etc. } Would that work for everybody? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 09:52:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 07:52:47 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-zQ6NJZL0za@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think we should do both. 1) Web installer: It will help with SQL reporting where you can't use the includes. I have translated ours in the database for this reason and it has no bad side effects. 2) Template fixes: These are great, because they fix what I initially had reported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 09:55:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 07:55:10 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-eKlqdBgvZs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Actually, I think we might need some more template fixes, but are on a good road here. Looking at my original test plan: To test: - Make sure a language with a complete translation is installed - Switch to the language - Go to any user account - Add a manual invoice - Pay it off fully or partially - Click on "issue refund" - Verify the list of "Transaction types" is not translated - Check the information in the patron account. It will show: I'll try to test this now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:04:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:04:54 +0000 Subject: [Koha-bugs] [Bug 33667] 'Copy to all libraries' doesn't work on editing holidays In-Reply-To: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33667-70-oled733ncz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33667 --- Comment #2 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> --- Modifying holidays only affects to existing holidays and since holiday created and edited in branch A doesn't exists in branches B, C etc. "Copy changes to all libraries" has no effect. Maybe we could call "isHoliday" before calling e.g. "ModDaymonthholiday" and then add holiday if it doesn't exists? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:08:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:08:47 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-yLIxRBMbY8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 --- Comment #5 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 150933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150933&action=edit Bug 33584: (follow-up) Remove DEFAULT_GENERATED from column info MySQL 8 returns this additional information for a timestamp such as the timestamp2 in the Commenter test. Which results in the following alter: ALTER TABLE koha_myclone.database_commenter_1 MODIFY COLUMN `timestamp2` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP DEFAULT_GENERATED COMMENT 'Column_5' And that statement fails again on that keyword. For now, it seems sufficient to ignore this keyword when building the alter statement. Test plan: Run t/db_dependent/Koha/Database/Commenter.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Did test it now under MySQL 8. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:09:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:09:08 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-2AlGOWxokN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 --- Comment #6 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 150934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150934&action=edit Bug 33686: Correction of existing terms related to 'Script of title' According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:10:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:10:18 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-0KpoyrwxGb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:10:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:10:18 +0000 Subject: [Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu In-Reply-To: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33169-70-UbwYWje0ce@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- There is something broken. Uncaught (in promise) Error: Missing required param "license_id" To recreate: 1. Create a license 2. Go to /cgi-bin/koha/erm/licenses 3. Click on a license's name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:10:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:10:21 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-lS94plZWdy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150790|0 |1 is obsolete| | Attachment #150933|0 |1 is obsolete| | --- Comment #7 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 150935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150935&action=edit Bug 33686: Update plugin unimarc_field_100.pl with 2022 values According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:10:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:10:23 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-YwymOteO04@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150934|0 |1 is obsolete| | --- Comment #8 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 150936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150936&action=edit Bug 33686: Correction of existing terms related to 'Script of title' According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:15:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:15:06 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-4wxCfijcQG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150935|0 |1 is obsolete| | Attachment #150936|0 |1 is obsolete| | --- Comment #9 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 150937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150937&action=edit Bug 33686: Update plugin unimarc_field_100.pl with 2022 values According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:15:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:15:09 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-aqIV6chUqt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 --- Comment #10 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 150938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150938&action=edit Bug 33686: Correction of existing terms related to 'Script of title' According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:18:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:18:58 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-RtUaxJjnqZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 --- Comment #11 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- (In reply to David Nind from comment #3) > I've signed off, as this adds the new values in the 2022 UNIMARC update. > > However, I do have a question: should the script of title name values match > exactly with the UNIMARC definitions (see references)? > > For example, in the definitions eg is shown as eg Naxi Dongba (Nakhi Tomba), > but in Koha it is shown as eg Dongba (Naxi). > > If they should, I'm happy to create a bug for that. > > References: > 1. UNIMARC Bibliographic (3rd ed.) Updates > https://www.ifla.org/g/unimarc-rg/unimarc-bibliographic-3rd-edition-with- > updates/ > 2. Tag 100 values (see page 8 for 'Script of title') > https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf > > Testing notes (using KTD): > 1. Before starting KTD, edit your .env file to change > KOHA_MARC_FLAVOUR=unimarc > 2. Edit a record and view the values for tag 100 and the 'Script of title' > dropdown list. > 3. Codes and names for values being added by this bug are not listed. > 4. Apply the patch. > 5. Restart everything (flush_memcached, restart_all, clear browser cache). > 6. Repeat step 2. > 7. New codes and values are now lsited. Hello David, Indeed there are some terms which are not exactly the same as those of the ifla document, I propose a correction of those in a differentiated commit (only concerning the section "Script of title" to be precise with the BZ title). I took the opportunity to change the title of the BZ, there was an error concerning the value builder, it is 100 and not 110 as previously indicated. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:25:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:25:33 +0000 Subject: [Koha-bugs] [Bug 33358] Do not use editorconfig for vue files In-Reply-To: <bug-33358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33358-70-9sAq2BsQ2s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |INVALID --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I finally found what caused the original problem (vscodium not taking into account its own config). There is a "Prettier: Use Editor Config" that was set. I removed it and now it's working without any changes in Koha. I think that's the best solution for now, as nobody else seems to have problems. Closing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:25:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:25:38 +0000 Subject: [Koha-bugs] [Bug 33358] Do not use editorconfig for vue files In-Reply-To: <bug-33358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33358-70-qkJmiO3Hng@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:26:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:26:40 +0000 Subject: [Koha-bugs] [Bug 33358] Do not use editorconfig for vue files In-Reply-To: <bug-33358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33358-70-BwG3ogXLgE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Another solution would be to have our prettier options defined in a .prettierrc. For ts, vue and js files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:27:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:27:38 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-3hhdQDqUrf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #25) > Actually, I think we might need some more template fixes, but are on a good > road here. > > Looking at my original test plan: > > To test: > - Make sure a language with a complete translation is installed > - Switch to the language > - Go to any user account > - Add a manual invoice > - Pay it off fully or partially > - Click on "issue refund" > - Verify the list of "Transaction types" is not translated Only Cash stands out there, the other entries are translated now. This will be fixed by Caroline's adding Cash to the web installer files, because this list is part hard coded and part coming from AV: [% FOREACH pt IN payment_types %] <option value="[% pt.authorised_value | html %]">[% pt.lib | html %]</option> [% END %] > - Check the information in the patron account. It will show: Some debit and credit types are missing from the includes. I'll provide a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:27:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:27:47 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-iV6ZVcuBam@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:29:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:29:18 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-OWGS3QIWAg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 --- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jacob O'Mara from comment #20) > Nice work, thanks everyone! > > Pushed to 22.11.x for the next release. You broke Jenkins Can't locate Koha/Exceptions/Checkin.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:42:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:42:13 +0000 Subject: [Koha-bugs] [Bug 33642] Typo: No log found . In-Reply-To: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33642-70-S5FsLekHhA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33642 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:42:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:42:15 +0000 Subject: [Koha-bugs] [Bug 33642] Typo: No log found . In-Reply-To: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33642-70-u7qcY96h0L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33642 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150940&action=edit Bug 33642: Fix 'No log found.' in viewlog It should ease translatability and remove an extra space. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:42:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:42:40 +0000 Subject: [Koha-bugs] [Bug 33642] Typo: No log found . In-Reply-To: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33642-70-7Kr6BGCNo4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33642 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:42:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:42:56 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-ouv7JruXGI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Mengu Yazicioglu <mengu at devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mengu at devinim.com.tr --- Comment #55 from Mengu Yazicioglu <mengu at devinim.com.tr> --- Hi all, Does this patch only change row format of table "tags" ? I've manually changed that table but didn't pass the installation phase. I've found some other tables like biblioitems,branches,borrowers,etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:44:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:44:33 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-jf4GhUehwi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:44:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:44:35 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-PKFBLT0F6K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150912|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150941&action=edit Bug 26403: Move credit and debit types into translatable YAML files This patch moves account debit and credit types, as well as the CASH payment type, into YAML files under installer/data/en/mandatory. This should make the debit and credit types translatable (for new installations only). To test: 1. Apply patch 2. Update po files ./misc/translator/translate update xx-XX 3. View the xx-XX-installer.po file -->The default account debit and credit types (and cash payment type) should be available to be translated 4. Translate the strings 5. Apply the translations ./misc/translator/translate install xx-XX 6. Load the new translated YAML files (with a fresh install, or by deleting the values in the db and using ./misc/load_yaml.pl to load the files) 7. In the staff interface, go to Administration > Credit types --> They should be translated 8. Go to Administration > Debit types --> They should be translated Signed-off-by: Magnus Enger <magnus at libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:44:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:44:38 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-4f2wQWlfzP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150913|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150942&action=edit Bug 26403: (follow-up) Deleted old SQL files Signed-off-by: Magnus Enger <magnus at libriotech.no> Followed the test plan. Works as advertised. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:44:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:44:40 +0000 Subject: [Koha-bugs] [Bug 33646] "Cataloging search" missing important data for not for loan items In-Reply-To: <bug-33646-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33646-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33646-70-o07keyh8py@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Which display do you suggest? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:44:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:44:40 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-CxzxkKgwzV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150932|0 |1 is obsolete| | --- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150943&action=edit Bug 26403: Use accounts include in account management pages This patch updates the credit and debit types management pages to use the proper includes for handling system type translations. This is how it should have been done in the first place on the original bugs that introduced the management of these types but for some reason I think it got dropped during the QA process leading to confusion around these system types with their fixed descriptions. To test: 1. Apply patch 2. Apply the translations ./misc/translator/translate install xx-XX 3. In the staff interface, go to Administration > Credit types --> They should be translated 4. Go to Administration > Debit types --> They should be translated Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:44:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:44:43 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files to make them translatable for use in reports In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-W9tOUHeTn4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150944&action=edit Bug 26403: (QA follow-up) Add missing debit and credit types to includes This adds the missing debit and credit types to the includes, namely: DISCOUNT, PURCHASE, PAYOUT, and VOID. I sorted them as they appear in the GUI (alphabetically) so it's a little easier to spot missing ones. Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:45:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:45:22 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files and fix other related translation issues In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-eSg3V25YhI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move debit and credit types |Move debit and credit types |to YAML files to make them |to YAML files and fix other |translatable for use in |related translation issues |reports | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:46:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:46:02 +0000 Subject: [Koha-bugs] [Bug 33658] Capitalization: **To Reproduce** In-Reply-To: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33658-70-2JGU8VSJYM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:46:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:46:04 +0000 Subject: [Koha-bugs] [Bug 33658] Capitalization: **To Reproduce** In-Reply-To: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33658-70-ZZqs8ba9qc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150945&action=edit Bug 33658: Fix capitalization 'To Reproduce' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:46:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:46:24 +0000 Subject: [Koha-bugs] [Bug 33658] Capitalization: **To Reproduce** In-Reply-To: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33658-70-1FcnSkTtvF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com CC| |jonathan.druart+koha at gmail. | |com Depends on| |31028 Keywords| |rel_23_05_candidate Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:46:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:46:24 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-gszedmOfZJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33658 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658 [Bug 33658] Capitalization: **To Reproduce** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:47:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:47:20 +0000 Subject: [Koha-bugs] [Bug 33655] z39.50 search no longer shows search in progress In-Reply-To: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33655-70-zM61Vw14Rk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Depends on| |32072 Blocks|32072 | Version|22.11 |unspecified Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072 [Bug 32072] Consistent classes for primary buttons: Cataloging -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:47:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:47:20 +0000 Subject: [Koha-bugs] [Bug 32072] Consistent classes for primary buttons: Cataloging In-Reply-To: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32072-70-owzaqklfCH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33655 Depends on|33655 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 [Bug 33655] z39.50 search no longer shows search in progress -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:51:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:51:00 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files and fix other related translation issues In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-EZasrTdmxw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150944|0 |1 is obsolete| | --- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150946&action=edit Bug 26403: (QA follow-up) Add missing debit and credit types to includes This adds the missing debit and credit types to the includes, namely: DISCOUNT, PURCHASE, PAYOUT, and VOID. I sorted them as they appear in the GUI (alphabetically) so it's a little easier to spot missing ones. Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:53:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:53:18 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files and fix other related translation issues In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-Efxgckj1l7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |With this patch the release notes| |descriptions of system | |internal credit and debit | |types will be translated | |into the selected language | |at installation time. This | |will only affect new | |installations and SQL | |reporting. If you are | |building your own SQL | |reports, you'll be able to | |pull the descriptions from | |the tables. | | | |It also makes | |sure, that all system | |internal debit and credit | |types appear translated in | |the GUI. This now also | |includes the administration | |pages for managing credit | |and debit types. Some | |descriptions for discount, | |payout, purchase, and void | |were missing. These have | |now also been added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:56:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:56:48 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-0MQflOdP0P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150947&action=edit Bug 23336: Unit tests This patch adds unit tests for the new checkout availability endpoint we're going to introduce in this patchset. Signed-off-by: Helen Oliver <HOliver at tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:56:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:56:51 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-gIq4ZEZqC1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150948&action=edit Bug 23336: Add checkout API's This patch adds API's to allow for a checkout flow using the RESTful API. We add an availability endpoint to check an items current availability status. The endpoint can be found at `/checkouts/availability` and is a GET request that requires item_id and patron_id passed as parameters. We return an availability object that includes blockers, confirms, warnings and a confirmation token to be used for checkout. We also add a corresponding checkout method to the `/checkouts` endpoint. The method accepts a POST request with checkout details including item_id , patron_id and the confirmation token in the body. Future work: We should properly migrate CanBookBeIssued into Koha::* and use that here instead of refering to C4::Circulation. Signed-off-by: Helen Oliver <HOliver at tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:56:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:56:53 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-zW0HkUAxr4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150949&action=edit Bug 23336: Fix inconsistent return of AddIssue AddIssue can on occasion create a renewal instead of a fresh issue and in such a case we currently return undefined. We should be consistent and return the existing issue object for the renewal. Signed-off-by: Helen Oliver <HOliver at tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:57:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:57:03 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-m9QHNvynZN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:57:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:57:11 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-kjvMleG5vB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91634|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:59:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:59:25 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-99nTub8KNq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #56 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Mengu Yazicioglu from comment #55) > Hi all, > > Does this patch only change row format of table "tags" ? > > I've manually changed that table but didn't pass the installation phase. > I've found some other tables like biblioitems,branches,borrowers,etc. This patch does not modify the DB, it only displays a warning on the about page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:59:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:59:55 +0000 Subject: [Koha-bugs] [Bug 33663] Don't hide Suggestions link in side navigation when suggestion preference is disabled In-Reply-To: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33663-70-FhTowy3FXm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 10:59:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 08:59:57 +0000 Subject: [Koha-bugs] [Bug 33663] Don't hide Suggestions link in side navigation when suggestion preference is disabled In-Reply-To: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33663-70-93iH7oUwWj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150950&action=edit Bug 33663: Don't hide Suggestions link in side navigation when suggestion preference is disabled We don't want to depend on the pref for the staff interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:00:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:00:00 +0000 Subject: [Koha-bugs] [Bug 33663] Don't hide Suggestions link in side navigation when suggestion preference is disabled In-Reply-To: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33663-70-l73mZpvQWu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150951&action=edit Bug 33663: Pass 'suggestion' to the OPAC templates only We don't need it for the staff interface. The previous patch is removing the only occurrence using it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:00:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:00:08 +0000 Subject: [Koha-bugs] [Bug 33663] Don't hide Suggestions link in side navigation when suggestion preference is disabled In-Reply-To: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33663-70-oidlc9xdLd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:01:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:01:03 +0000 Subject: [Koha-bugs] [Bug 33670] Changes from bz29146/bz30250 doesn't apply when duplicate record suspected In-Reply-To: <bug-33670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33670-70-NzSXzJLo23@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33670 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Depends on| |29146, 30250 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 [Bug 29146] Default values from the framework should only be applied at biblio/item creation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 [Bug 30250] Configure when to apply framework defaults when cataloguing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:01:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:01:03 +0000 Subject: [Koha-bugs] [Bug 29146] Default values from the framework should only be applied at biblio/item creation In-Reply-To: <bug-29146-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29146-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29146-70-aWI2rVcqUs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33670 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33670 [Bug 33670] Changes from bz29146/bz30250 doesn't apply when duplicate record suspected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:01:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:01:03 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: <bug-30250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30250-70-qwwkebYs9U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33670 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33670 [Bug 33670] Changes from bz29146/bz30250 doesn't apply when duplicate record suspected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:03:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:03:18 +0000 Subject: [Koha-bugs] [Bug 33677] Remove --verbose from koha-worker manpage In-Reply-To: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33677-70-Tld4ADhbhn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Depends on| |27839 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27839 [Bug 27839] koha-worker missing tab-completion in bash -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:03:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:03:18 +0000 Subject: [Koha-bugs] [Bug 27839] koha-worker missing tab-completion in bash In-Reply-To: <bug-27839-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27839-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27839-70-oT6VrzBsh2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27839 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33677 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677 [Bug 33677] Remove --verbose from koha-worker manpage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:04:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:04:30 +0000 Subject: [Koha-bugs] [Bug 33677] Remove --verbose from koha-worker manpage In-Reply-To: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33677-70-RHodZs36uK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:04:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:04:33 +0000 Subject: [Koha-bugs] [Bug 33677] Remove --verbose from koha-worker manpage In-Reply-To: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33677-70-3yJ8nUb7dz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150952&action=edit Bug 33677: Remove verbose option from koha-worker man -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:04:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:04:40 +0000 Subject: [Koha-bugs] [Bug 33677] Remove --verbose from koha-worker manpage In-Reply-To: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33677-70-otixWGikZ2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:07:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:07:39 +0000 Subject: [Koha-bugs] [Bug 33695] Audio alerts in the OPAC broken? In-Reply-To: <bug-33695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33695-70-8KCV9UQi6k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33695 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16732 CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- It's not implemented, only for sco. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:07:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:07:39 +0000 Subject: [Koha-bugs] [Bug 16732] Add audio alerts (custom sound notifications) to web based self checkout In-Reply-To: <bug-16732-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16732-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16732-70-xxH5sqt2Kp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33695 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:09:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:09:00 +0000 Subject: [Koha-bugs] [Bug 33677] Remove --verbose from koha-worker manpage In-Reply-To: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33677-70-oPHfId0D90@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:09:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:09:03 +0000 Subject: [Koha-bugs] [Bug 33677] Remove --verbose from koha-worker manpage In-Reply-To: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33677-70-QNdxGkDrZu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150952|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus at libriotech.no> --- Created attachment 150953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150953&action=edit Bug 33677: Remove verbose option from koha-worker man Signed-off-by: Magnus Enger <magnus at libriotech.no> No more mention of verbose. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:14:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:14:58 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-4TJcHFCUKX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This is a complete rework based on the implementation I did for bug 30979 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:15:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:15:41 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-aZzjwCriMq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30979 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 [Bug 30979] Add ability for OPAC users to checkout to themselves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:15:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:15:41 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-d6h3opPi3c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 [Bug 23336] Add an API endpoint for issuing an item to a patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:16:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:16:23 +0000 Subject: [Koha-bugs] [Bug 33587] "Save" button in modifying "News" entry is not working in Russian localization In-Reply-To: <bug-33587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33587-70-MTRMxPadTy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33587 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |jonathan.druart+koha at gmail. | |com Status|NEW |RESOLVED --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Confirmed on 22.11.05 Uncaught SyntaxError: missing ) after argument listadditional-contents.pl:1055:59 It's coming from alert(_("Укажите название для "По умолчанию"")); You should surround the string with simple quote. Please fix on pootle at translate.koha-community.org/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:17:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:17:17 +0000 Subject: [Koha-bugs] [Bug 33553] Unecessary GetCategories calls in template In-Reply-To: <bug-33553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33553-70-oezTMaXfM0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 [Bug 12461] Add patron clubs feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:17:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:17:17 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: <bug-12461-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12461-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12461-70-HoEgGkCyqr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33553 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 [Bug 33553] Unecessary GetCategories calls in template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:21:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:21:40 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-psEXgAjxgj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150947|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150954&action=edit Bug 23336: Unit tests This patch adds unit tests for the new checkout availability endpoint we're going to introduce in this patchset. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:21:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:21:42 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-G3AIxOAxFb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150948|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150955&action=edit Bug 23336: Add checkout API's This patch adds API's to allow for a checkout flow using the RESTful API. We add an availability endpoint to check an items current availability status. The endpoint can be found at `/checkouts/availability` and is a GET request that requires item_id and patron_id passed as parameters. We return an availability object that includes blockers, confirms, warnings and a confirmation token to be used for checkout. We also add a corresponding checkout method to the `/checkouts` endpoint. The method accepts a POST request with checkout details including item_id , patron_id and the confirmation token in the body. Future work: We should properly migrate CanBookBeIssued into Koha::* and use that here instead of refering to C4::Circulation. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:21:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:21:45 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-885KxsYxKM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150949|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150956&action=edit Bug 23336: Fix inconsistent return of AddIssue AddIssue can on occasion create a renewal instead of a fresh issue and in such a case we currently return undefined. We should be consistent and return the existing issue object for the renewal. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:22:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:22:28 +0000 Subject: [Koha-bugs] [Bug 33578] Cannot edit patron restriction types In-Reply-To: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33578-70-WWs36crxkp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:22:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:22:30 +0000 Subject: [Koha-bugs] [Bug 33578] Cannot edit patron restriction types In-Reply-To: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33578-70-ohA7xo0p7e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578 --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150957&action=edit Bug 33578: Fix patron restriction types edition When editing an existing patron restriction type you'll always get an error on saving: Label is already in use To test: * Activate use of patron restriction types * Edit any of the system types * Create new ones -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:22:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:22:34 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-K0rPqr4GBB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:22:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:22:37 +0000 Subject: [Koha-bugs] [Bug 33578] Cannot edit patron restriction types In-Reply-To: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33578-70-ONlNi7KWcm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com CC| |jonathan.druart+koha at gmail. | |com Depends on| |23681 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 [Bug 23681] Make patron restrictions user definable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:22:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:22:37 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23681-70-LK20IuVztO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33578 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578 [Bug 33578] Cannot edit patron restriction types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:22:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:22:48 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-mXmzSu01lm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150880|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:22:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:22:57 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-KNCMLxKdm8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150881|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:23:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:23:07 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-zNNRFaq6fu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150882|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:24:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:24:26 +0000 Subject: [Koha-bugs] [Bug 33667] 'Copy to all libraries' doesn't work on editing holidays In-Reply-To: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33667-70-RiwBzSxArY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33667 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think it would be great to at least have some visual clue or not to provide the option if the holiday is not present in all other branches. I believe the use case here is: * add a new holiday * realize I forgot to set the checkbox * try to fix it with editing (because it looks like it will work) So either we make it work... or make it somehow clear it won't and you need to delete first. I don't know the code well enough to make a recommendation or helpful comment in that part. :( -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:53:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:53:58 +0000 Subject: [Koha-bugs] [Bug 33709] New: Add override options to checkouts Message-ID: <bug-33709-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33709 Bug ID: 33709 Summary: Add override options to checkouts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com CC: tomascohen at gmail.com Depends on: 23336 I stripped out the local overrides when creating a checkouts POST route.. we should add them back in using the accepted x-koha-overrides method. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 [Bug 23336] Add an API endpoint for issuing an item to a patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 11:53:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 09:53:58 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-x1LWTdnae5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33709 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33709 [Bug 33709] Add override options to checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:02:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:02:56 +0000 Subject: [Koha-bugs] [Bug 33709] Add override options to checkouts In-Reply-To: <bug-33709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33709-70-c5eVNsiSn7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33709 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- There's things in the original patch I didn't understand so will need a bit of help unpicking. * ? inprocess ? * due_date override * ignore_reserves * cancel_reserves * issue_date * sipmode -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:03:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:03:05 +0000 Subject: [Koha-bugs] [Bug 33710] New: Ignore howto files Message-ID: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33710 Bug ID: 33710 Summary: Ignore howto files Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Related to https://gitlab.com/koha-community/koha-testing-docker/-/issues/378 If we merge it we will want to hide how-to.pl and how-to.ptt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:03:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:03:46 +0000 Subject: [Koha-bugs] [Bug 33710] Ignore howto files In-Reply-To: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33710-70-ftO7dne09W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33710 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150958&action=edit Bug 33710: Ignore how-to related files Related to https://gitlab.com/koha-community/koha-testing-docker/-/issues/378 If we merge it we will want to hide how-to.pl and how-to.ptt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:04:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:04:03 +0000 Subject: [Koha-bugs] [Bug 33710] Ignore howto files In-Reply-To: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33710-70-BUQk0OY1qf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33710 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:05:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:05:41 +0000 Subject: [Koha-bugs] [Bug 33710] Ignore howto files In-Reply-To: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33710-70-LgyWl6V17Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33710 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:07:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:07:05 +0000 Subject: [Koha-bugs] [Bug 33449] Marc Overlay rules screen is broken In-Reply-To: <bug-33449-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33449-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33449-70-3MK9GjQ2i7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33449 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Duplicate of bug 33335? Reopen if not. *** This bug has been marked as a duplicate of bug 33335 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:07:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:07:05 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33335-70-nN26sZ2cma@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ruchi.agarwal at avidreaders.i | |n --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- *** Bug 33449 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:21:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:21:03 +0000 Subject: [Koha-bugs] [Bug 33421] Filtering purchase suggestions by status does not work if All Libraries is selected In-Reply-To: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33421-70-T7KfBekVHW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33421 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:21:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:21:05 +0000 Subject: [Koha-bugs] [Bug 33421] Filtering purchase suggestions by status does not work if All Libraries is selected In-Reply-To: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33421-70-OtBihrbztg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33421 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150959&action=edit Bug 33421: Fix filtering suggestions by status If the display is by status and a specific status is selected in the filter, the filter won't have any effects. Test plan: Create several suggestions, with different status, for different libraries. Use the "display by status" view and filter on a given status => Result must be relevant -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:21:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:21:23 +0000 Subject: [Koha-bugs] [Bug 33421] Filtering purchase suggestions by status does not work if All Libraries is selected In-Reply-To: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33421-70-KmjQCJc9zA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33421 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com CC| |jonathan.druart+koha at gmail. | |com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:23:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:23:08 +0000 Subject: [Koha-bugs] [Bug 33358] Do not use editorconfig for vue files In-Reply-To: <bug-33358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33358-70-pNLlsUdDJl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 --- Comment #7 from Paul Derscheid <paul.derscheid at lmscloud.de> --- I really like the idea of a prettierrc file. Let's do it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:23:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:23:25 +0000 Subject: [Koha-bugs] [Bug 33655] z39.50 search no longer shows search in progress In-Reply-To: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33655-70-GcZcQRKI4P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:26:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:26:31 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-YXVeHoW8Yw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150954|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150960&action=edit Bug 23336: Unit tests This patch adds unit tests for the new checkout availability endpoint we're going to introduce in this patchset. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:26:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:26:34 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-j8ZpBH5616@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150955|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150961&action=edit Bug 23336: Add checkout API's This patch adds API's to allow for a checkout flow using the RESTful API. We add an availability endpoint to check an items current availability status. The endpoint can be found at `/checkouts/availability` and is a GET request that requires item_id and patron_id passed as parameters. We return an availability object that includes blockers, confirms, warnings and a confirmation token to be used for checkout. We also add a corresponding checkout method to the `/checkouts` endpoint. The method accepts a POST request with checkout details including item_id , patron_id and the confirmation token in the body. Future work: We should properly migrate CanBookBeIssued into Koha::* and use that here instead of refering to C4::Circulation. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:26:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:26:36 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-1Cvq0nr3mk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150956|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150962&action=edit Bug 23336: Fix inconsistent return of AddIssue AddIssue can on occasion create a renewal instead of a fresh issue and in such a case we currently return undefined. We should be consistent and return the existing issue object for the renewal. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:35:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:35:33 +0000 Subject: [Koha-bugs] [Bug 33403] Letters.t: Foreign key exception if you do not have a numberpattern with id=1 In-Reply-To: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33403-70-QJ29iu782Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33403 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:35:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:35:35 +0000 Subject: [Koha-bugs] [Bug 33403] Letters.t: Foreign key exception if you do not have a numberpattern with id=1 In-Reply-To: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33403-70-h3HjESGhg6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33403 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150963&action=edit Bug 33403: Fix Letters.t if number pattern with id=1 does not exist Bad assumption in DB, we should create the data we need Test plan: > delete from subscription_numberpatterns; prove t/db_dependent/Letters.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:35:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:35:44 +0000 Subject: [Koha-bugs] [Bug 33403] Letters.t: Foreign key exception if you do not have a numberpattern with id=1 In-Reply-To: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33403-70-Xk9EfqNRqj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33403 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |jonathan.druart+koha at gmail. | |com CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:39:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:39:58 +0000 Subject: [Koha-bugs] [Bug 33695] Audio alerts in the OPAC broken? In-Reply-To: <bug-33695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33695-70-V1ckIVVZ85@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33695 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I tried for self checkouts, it wouldn't work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:40:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:40:16 +0000 Subject: [Koha-bugs] [Bug 33695] Audio alerts for self checkout broken In-Reply-To: <bug-33695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33695-70-oyQOjpVUTr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33695 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Audio alerts in the OPAC |Audio alerts for self |broken? |checkout broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:45:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:45:03 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-zwSX69gIuL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #57 from Mengu Yazicioglu <mengu at devinim.com.tr> --- When we try to upgrade to 22.11.05, post-installation database update part gives error about ERM tables related with this bug. In order to bypass the post-installation steps, we need manually change some tables' row format status, otherwise we can't go forward. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:45:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:45:19 +0000 Subject: [Koha-bugs] [Bug 33670] Changes from bug 29146/bug 30250 doesn't apply when duplicate record suspected In-Reply-To: <bug-33670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33670-70-zuUPZihr87@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33670 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Changes from |Changes from bug 29146/bug |bz29146/bz30250 doesn't |30250 doesn't apply when |apply when duplicate record |duplicate record suspected |suspected | --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi, what does your configuration for ApplyFrameworkDefaults look like? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:46:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:46:36 +0000 Subject: [Koha-bugs] [Bug 33587] "Save" button in modifying "News" entry is not working in Russian localization In-Reply-To: <bug-33587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33587-70-HMAHB2ttzK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33587 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I went ahead and fixed the string on Pootle. The fix will be included in the next maintenance versions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:48:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:48:04 +0000 Subject: [Koha-bugs] [Bug 33578] Cannot edit patron restriction types In-Reply-To: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33578-70-eAxUJ62aqC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:56:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:56:31 +0000 Subject: [Koha-bugs] [Bug 33655] z39.50 search no longer shows search in progress In-Reply-To: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33655-70-5Et0hWNxAY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 12:56:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 10:56:33 +0000 Subject: [Koha-bugs] [Bug 33655] z39.50 search no longer shows search in progress In-Reply-To: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33655-70-zu9q1B0G5E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 150964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150964&action=edit Bug 33655: z39.50 search no longer shows search in progress This patch adds an id to z39.50 search interface submit buttons so that the JavaScript event for changing the cursor can be linked to that instead of the obsolete class. The patch also adds code copied from Bug 33233 in order to make the "waiting" cursor revert to the default if the user uses the back button to return to the search form. To test, apply the patch and go to Cataloging -> New from Z39.50 - Fill in a search term and click the submit button - Your cursor should change to a "waiting" cursor while the search is performed, before you're redirected to the results. - From the results page, clicking the back button (or right-clicking the page and choosing "Back") should return you to the search form and your cursor should be a standard pointer. Perform the same test from: - Acquisitions -> Vendor -> Basket -> Add to basket -> From an external source - Authorities -> New from Z39.50/SRU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:04:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:04:41 +0000 Subject: [Koha-bugs] [Bug 33578] Cannot edit patron restriction types In-Reply-To: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33578-70-zKiqGUlXpE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- This patch works for the form validation error, but I see something else too: If you open the restriction edit form and submit it without changing anything you'll be returned to the "Patron restrictions" page where there will be a message, " Another restriction already has this label" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:06:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:06:48 +0000 Subject: [Koha-bugs] [Bug 33403] Letters.t: Foreign key exception if you do not have a numberpattern with id=1 In-Reply-To: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33403-70-F0Kd8p0DgG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33403 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:06:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:06:50 +0000 Subject: [Koha-bugs] [Bug 33403] Letters.t: Foreign key exception if you do not have a numberpattern with id=1 In-Reply-To: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33403-70-Bs1FOi2krj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33403 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150963|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150965&action=edit Bug 33403: Fix Letters.t if number pattern with id=1 does not exist Bad assumption in DB, we should create the data we need Test plan: > delete from subscription_numberpatterns; prove t/db_dependent/Letters.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:07:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:07:10 +0000 Subject: [Koha-bugs] [Bug 33403] Letters.t: Foreign key exception if you do not have a numberpattern with id=1 In-Reply-To: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33403-70-bi3rftQue0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33403 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- SO + QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:14:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:14:57 +0000 Subject: [Koha-bugs] [Bug 33658] Capitalization: **To Reproduce** In-Reply-To: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33658-70-iS1JdV6hag@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:14:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:14:59 +0000 Subject: [Koha-bugs] [Bug 33658] Capitalization: **To Reproduce** In-Reply-To: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33658-70-WcizyDIlTS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150945|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 150966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150966&action=edit Bug 33658: Fix capitalization 'To Reproduce' Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:15:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:15:05 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-nE9EH6tGTd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #80 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150967&action=edit Bug 30979: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:15:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:15:08 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-2wNvK02Iai@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150883|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150968&action=edit Bug 30979: Add public endpoints This patch expands the checkouts endpoints to allow for a public workflow. We add the availability endpoint under `/public/checkouts/availability` and restrict the information we send back to only those fields a public user should be allowed to see. We also add a new checkout endpoint at `/patrons/{patron_id}/checkouts` that allows for users to checkout to themselves and accepts the same POST request with checkout details including item_id and a confirmation token in the body that the staff client endpoints accept. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:15:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:15:11 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-sGM6hbFAF2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150884|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150969&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:15:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:15:15 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-EhUGouEoEF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150885|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150970&action=edit Bug 30979: Limit public checkout endpoint using preference The public api endpoint for self-checkout should only be enabled in the case where the OpacTrustedSelfCheckout option is enabled. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:15:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:15:18 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-DlCquryWkd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150886|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150971&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode to checkout. We check for item existance and availability and then check the item out after any confirmations have been displayed. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:15:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:15:22 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-pc8GVQfgip@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150887|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150972&action=edit Bug 30979: Always show self-checkout when preference enabled This patch updates the display logic such that if the truested self-checkout option is enabled we always show the checkout button and prompt a login when no user is found. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:15:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:15:26 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-BVmPsGJ9Wb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150888|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150973&action=edit Bug 30979: Redirect to checkout summary This is a temporary solution whilst we wait for the biblio api endpoints so we may include more biblio details in the checkout modal itself. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:15:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:15:29 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-lUqqwV9Nxi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150889|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150974&action=edit Bug 30979: Add modal trigger to shibboleth target url Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:15:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:15:55 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-0NfxGYL7oD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:20:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:20:22 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-vf423FYL2u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Andrew Fuerste-Henry from comment #10) > Item_found and item_lost don't fit very well with the other types of actions > recorded in statistics, conceptually. Everything else is an action that > someone took -- checkout, checkin, payment, writeoff, etc. Item_found and > item_lost are changes to the state of the item as a result of one of those > actions. So this feels like it's adding confusion to the nature of the data > recorded in this table. Thx for taking a look. Found and lost represent the result of actions like a checkin or an item edit. These actions do change state of the items just like the other ones mentioned. I do not really see why this would create confusion. Since the table has a very generic name (statistics), and the data stored fits fine in the current table design, I opted for this solution. All data is about item status changes. The one thing we are missing the most is the number of found/recovered items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:22:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:22:16 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-4njEXJsGXT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #60 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Nick Clemens from comment #59) > (In reply to Marcel de Rooy from comment #55) > None of them? Or some of them? > None. > Restart zebra (restart_all) then reindex Will try that again. > Make sure AutoLinkBiblios is set to 'Do' Yes, I verified all prefs with the test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:25:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:25:53 +0000 Subject: [Koha-bugs] [Bug 33642] Typo: No log found . In-Reply-To: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33642-70-3O21Rs6PRD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33642 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:25:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:25:55 +0000 Subject: [Koha-bugs] [Bug 33642] Typo: No log found . In-Reply-To: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33642-70-yEVnCYNLVn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33642 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150940|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 150975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150975&action=edit Bug 33642: Fix 'No log found.' in viewlog It should ease translatability and remove an extra space. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:31:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:31:59 +0000 Subject: [Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities In-Reply-To: <bug-31185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31185-70-2i1djJiPHI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:40:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:40:03 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-vcIOivFkud@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to David Cook from comment #8) > Tomas, take a look at my patches and let me know what you think. > > With all 3 patches, I've tested OIDC on staff interface and OPAC, and gotten > them working with their respective URLs. They look great. I was really tired last night when I submitted. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:51:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:51:53 +0000 Subject: [Koha-bugs] [Bug 33707] News vs Quote of the day styling on staff interface main page In-Reply-To: <bug-33707-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33707-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33707-70-t2OdyNoREh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33707 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|enhancement |minor Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:54:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:54:52 +0000 Subject: [Koha-bugs] [Bug 33578] Cannot edit patron restriction types In-Reply-To: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33578-70-5VGrMvy3vV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:54:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:54:54 +0000 Subject: [Koha-bugs] [Bug 33578] Cannot edit patron restriction types In-Reply-To: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33578-70-U5avRTmm2A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578 --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150976&action=edit Bug 33578: Fix controller when editing a restriction type Do not display a warning when we are editing a restriction type and no other types with this description exists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 13:54:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 11:54:57 +0000 Subject: [Koha-bugs] [Bug 33670] Changes from bug 29146/bug 30250 doesn't apply when duplicate record suspected In-Reply-To: <bug-33670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33670-70-XXdhThyto8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33670 --- Comment #2 from Noémie Labine <noemie.labine at collecto.ca> --- Hi, oups forgot to mention :-) All options are selected. Thanks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:00:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:00:33 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31735-70-ZXROnMPDZY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:02:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:02:43 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-URSjdNCThC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:03:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:03:10 +0000 Subject: [Koha-bugs] [Bug 33709] Add override options to checkouts endpoint(s) In-Reply-To: <bug-33709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33709-70-G0ET7yFhMp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33709 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add override options to |Add override options to |checkouts |checkouts endpoint(s) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:04:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:04:40 +0000 Subject: [Koha-bugs] [Bug 26932] Importing staged bibliographic MARC records does not show a completed status if there are any item records to stage In-Reply-To: <bug-26932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26932-70-kfy1QAFnTu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26932 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart+koha at gmail. | |com Resolution|--- |FIXED --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This is working correctly for me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:05:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:05:08 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-P9O015bOdp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #61 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Update: Most auth fields are linked now! The 600 Hamlet is not linked since it looks for: 'value' => [ "Hamlet posta\x{107} fikcyjna", 'notdefined' ], And the $c does not occur in the authority data. So thats explained too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:08:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:08:12 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-zi7ACDBOI5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #62 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Note: there was also a space in the bib side: <subfield code="a">Hamlet </subfield> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:09:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:09:52 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-9tmbr5FGlE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:09:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:09:55 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-PWzDfz5V0x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149837|0 |1 is obsolete| | --- Comment #63 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150977&action=edit Bug 33277: Do not search using thesaurus when linking non 6XX fields This patch sets thesaurus as undefined when linking any field except 6XX This fixes the case where authrotiy records don't have the thesaurus defined Consequently - this means that Koha does not support multiple thesaurus records for authorities outside of subjects i.e. Using the default linker, and having both an LCSH and Sears record for 'Shakespeare,William' A 100 entry will find two results and the heading won't be linked. Previously we always linked to the LCSH To test: 1 - Import the attached auths and biblio (from bug 33159 comment 24) 2 - Set system preferences: RequireChoosingExistingAuthority - don't require AutoCreateAuthorities - don't generate CatalogModuleRelink - Do LinkerKeepStale - Don't LinkerModule - default LinkerRelink - do 3 - Edit the imported bib 4 - Save it 5 - Headings are not linked except 600 6 - Apply patch 7 - Restart all 8 - Edit and save record 9 - Headings are successfully linked Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:09:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:09:58 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-vW5zOXBxbo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149838|0 |1 is obsolete| | --- Comment #64 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150978&action=edit Bug 33277: Support custom thesaurus authority with no 040 specified Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:10:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:10:01 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-bahQDspeEw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149839|0 |1 is obsolete| | --- Comment #65 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150979&action=edit Bug 33277: Add comments and missing thesauri Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:10:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:10:05 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-kdNou3AsaA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149840|0 |1 is obsolete| | --- Comment #66 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150980&action=edit Bug 33277: Search thesaurus for 'notspecified' Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:10:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:10:08 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-smm3Hnl74H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149841|0 |1 is obsolete| | --- Comment #67 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150981&action=edit Bug 33277: (follow-up) Fix notdefined search for Zebra and ES Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:10:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:10:11 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-8PWl4wDoT1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149842|0 |1 is obsolete| | --- Comment #68 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150982&action=edit Bug 33277: Adjust source file for zebra mappings The previous patches adjusted the mappings directly - moving this change to the correct build file Not needed for sign off, but QA can test that nothing changes when rebuilding the files: xsltproc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml > etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:10:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:10:14 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-co8TG73IWl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150891|0 |1 is obsolete| | --- Comment #69 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150983&action=edit Bug 33277: (follow-up) Don't use regex, tidy Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:12:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:12:31 +0000 Subject: [Koha-bugs] [Bug 33711] New: Refine the token passing mechanisms introduced in bug 23336 Message-ID: <bug-33711-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33711 Bug ID: 33711 Summary: Refine the token passing mechanisms introduced in bug 23336 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com CC: koha-bugs at lists.koha-community.org, tomascohen at gmail.com Depends on: 23336 Bug 23336 introduces an API workflow for checkouts by adding two endpoints.. one for availability that creates a token for confirmations that can then be used by the checkouts endpoint to verify that availability has been checked. Whilst I think the availability endpoint is worthwhile in it's own right, I think we could also send back the token in the 409 pre-condition failed response of the checkouts endpoint so one could use that single endpoint for double duty in the right circumstances. I also think we could work on how the confirmation token is sent to the endpoint.. it's currently a simple query param but may lend itself to being part of the x-koha-overrides header or another header? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 [Bug 23336] Add an API endpoint for issuing an item to a patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:12:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:12:31 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-CYQ95ZDr5M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33711 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33711 [Bug 33711] Refine the token passing mechanisms introduced in bug 23336 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:13:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:13:16 +0000 Subject: [Koha-bugs] [Bug 33711] Refine the token passing mechanisms introduced in bug 23336 In-Reply-To: <bug-33711-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33711-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33711-70-rChCBtRan0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33711 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:19:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:19:07 +0000 Subject: [Koha-bugs] [Bug 32711] Add biblio details to trusted self-checkout modal In-Reply-To: <bug-32711-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32711-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32711-70-OTQwgBrstq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32711 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145787|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150984&action=edit Bug 32711: Add biblio details to modal This patch adds biblio details to the self-checkout modal. As part of this we add 'biblio' to the x-koha-embed option on the public items endpoint, clone the js-biblio-format include from the staff client adapting it slightly for OPAC use along the way and also import escape_str and escapeHtml from staff to opac too. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:19:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:19:10 +0000 Subject: [Koha-bugs] [Bug 32711] Add biblio details to trusted self-checkout modal In-Reply-To: <bug-32711-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32711-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32711-70-PI55CbzcbZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32711 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145788|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150985&action=edit Bug 32711: Add 'public_read_list' appropriately We're exposing biblio (and thus biblioitem) to the public API now and as such we need to explisitely list which fields to include in the response when called on the public api. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:19:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:19:12 +0000 Subject: [Koha-bugs] [Bug 32711] Add biblio details to trusted self-checkout modal In-Reply-To: <bug-32711-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32711-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32711-70-q0WzGoF13w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32711 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150986&action=edit Bug 32711: Fix biblio embeds We need to drop the embed part of the args we pass to biblioitem else we end up with some very strange behaviours on the acquisitions endpoint. Signed-off-by: Silvia Meakins <smeakins at eso.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:19:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:19:17 +0000 Subject: [Koha-bugs] [Bug 33704] Fixed length control fields does not save "Type of Material" when edited. In-Reply-To: <bug-33704-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33704-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33704-70-Gf92KPnwWQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33704 --- Comment #2 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #1) > Hi Laura, this is one of those MARC things: you need to make sure that LDR > Pos. 6 is set correctly, it determines what material type will be selected > for 008. > > See bug 19419 and and bug 30871 - maybe we need to add more hints? Thanks, Katrin! It would definitely be helpful to have hints or more documentation available regarding this procedure. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:19:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:19:54 +0000 Subject: [Koha-bugs] [Bug 32711] Add biblio details to trusted self-checkout modal In-Reply-To: <bug-32711-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32711-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32711-70-ndWsfa2EjE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32711 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |martin.renvoize at ptfs-europe | |.com Status|BLOCKED |Passed QA QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:27:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:27:24 +0000 Subject: [Koha-bugs] [Bug 32985] Patron quick search done on cardnumber even if not inDefaultPatronSearchFields In-Reply-To: <bug-32985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32985-70-bxc7pIaufP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32985 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Summary|DefaultPatronSearchFields |Patron quick search done on |not affecting all patron |cardnumber even if not |searches |inDefaultPatronSearchFields -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:27:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:27:29 +0000 Subject: [Koha-bugs] [Bug 33712] New: Use new checkout api's for staff client checkouts Message-ID: <bug-33712-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33712 Bug ID: 33712 Summary: Use new checkout api's for staff client checkouts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, koha-bugs at lists.koha-community.org, tomascohen at gmail.com Depends on: 33709 Bug #23336 introduces some new checkout api's and then bug 33709 refines them a little. Once those are both pushed we should eat our own dogfood and consider updating the staff client workflows to use these API's instead of relying on the full page reloads we currently do. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33709 [Bug 33709] Add override options to checkouts endpoint(s) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:27:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:27:29 +0000 Subject: [Koha-bugs] [Bug 33709] Add override options to checkouts endpoint(s) In-Reply-To: <bug-33709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33709-70-2MNlhbNUto@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33709 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33712 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33712 [Bug 33712] Use new checkout api's for staff client checkouts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:27:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:27:42 +0000 Subject: [Koha-bugs] [Bug 32985] Patron quick search done on cardnumber even if not inDefaultPatronSearchFields In-Reply-To: <bug-32985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32985-70-sKYikktuW0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32985 --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150987&action=edit Bug 32985: Do not search on cardnumber if not in DefaultPatronSearchFields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:28:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:28:24 +0000 Subject: [Koha-bugs] [Bug 32985] Patron quick search done on cardnumber even if not inDefaultPatronSearchFields In-Reply-To: <bug-32985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32985-70-KN04PwlsI3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32985 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This patch should fix the problem you are describing, but not sure it's something we want. This behaviour has been around for years now. Lowering priority. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:28:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:28:34 +0000 Subject: [Koha-bugs] [Bug 33712] Use new checkout api's for staff client checkouts In-Reply-To: <bug-33712-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33712-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33712-70-OGvJTPzdol@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33712 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33711 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33711 [Bug 33711] Refine the token passing mechanisms introduced in bug 23336 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:28:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:28:34 +0000 Subject: [Koha-bugs] [Bug 33711] Refine the token passing mechanisms introduced in bug 23336 In-Reply-To: <bug-33711-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33711-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33711-70-2iFQrZAWv9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33711 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33712 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33712 [Bug 33712] Use new checkout api's for staff client checkouts -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:30:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:30:00 +0000 Subject: [Koha-bugs] [Bug 32717] problems user and cataloging In-Reply-To: <bug-32717-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32717-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32717-70-hFpVAk7C2j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32717 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |jonathan.druart+koha at gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Closing, feel free to reopen with the required details. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:31:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:31:21 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-E6cqN2BtyE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://github.com/PTFS-Eur | |ope/koha/tree/bug_30979_reb | |ased | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:33:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:33:11 +0000 Subject: [Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints In-Reply-To: <bug-22613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22613-70-HIjKAgv0IU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23336 CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:33:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:33:11 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-UK6svEGKyJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22613 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:34:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:34:14 +0000 Subject: [Koha-bugs] [Bug 32896] Can we move autoBarcode handling into Koha::Item->store() ? In-Reply-To: <bug-32896-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32896-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32896-70-wYXMSOx7p6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32896 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:35:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:35:21 +0000 Subject: [Koha-bugs] [Bug 32896] Can we move autoBarcode handling into Koha::Item->store() ? In-Reply-To: <bug-32896-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32896-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32896-70-NcbHQxbtNq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32896 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I have no idea when I'll find time for this.. anyone interested in taking it on would get my support though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:40:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:40:57 +0000 Subject: [Koha-bugs] [Bug 26967] Patron autocomplete does not correctly format addresses In-Reply-To: <bug-26967-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26967-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26967-70-2rREmGhN6l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26967 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:42:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:42:25 +0000 Subject: [Koha-bugs] [Bug 31432] MARC21: Make 245 n and p subfields visible in frameworks by default In-Reply-To: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31432-70-ouhXOFTB91@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31432 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:44:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:44:09 +0000 Subject: [Koha-bugs] [Bug 33707] News vs Quote of the day styling on staff interface main page In-Reply-To: <bug-33707-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33707-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33707-70-WGY844J91B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33707 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:44:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:44:12 +0000 Subject: [Koha-bugs] [Bug 33707] News vs Quote of the day styling on staff interface main page In-Reply-To: <bug-33707-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33707-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33707-70-AxPYBPJKDK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33707 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 150988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150988&action=edit Bug 33707: News vs Quote of the day styling on staff interface main page This patch makes minor adjustments to the global and staff home page CSS so that the display of news and quote-of-the-day are more consistent. To test, apply the patch and rebuild the staff interface CSS. - If necessary, add at least one news item (Tools -> News -> New entry) and at least one quote (Tools -> Quote editor -> New quote). - View the staff interface home page to confirm that the style of the news area and the quotes is consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:50:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:50:20 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-jUof0fkTLA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to David Gustafsson from comment #13) > Ok! Suppose due to forgot to fix the tests that still uses the 'NULL' value, > will do so. Why is it odd? null is valid json, NULL is not. Some things are hard to explain :) The fact that you need to type null as a valid JSON expression in a textarea is not very appealing as to user interface. (Or even stricter, valid YAML.) But I could certainly live with it :) Just document it clearly. And going bit out of scope, but why are we specifying a: [ b, c ] instead of the pure YAML approach with something like: a: - b - c We probably need some discussion/consensus about handling all such preferences. The fact that is all kind of YAML now, does however make a difference. See next comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:51:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:51:07 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-71THhjWIcw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- We remove these lines completely now and just trust ->yaml_preference: - foreach my $line (@lines){ - my ($field,$array) = split /:/, $line; - next if !$array; - $field =~ s/^\s*|\s*$//g; - $array =~ s/[ [\]\r]//g; - my @array = split /,/, $array; - @array = map { $_ eq '""' || $_ eq "''" ? '' : $_ } @array; - @array = map { $_ eq 'NULL' ? undef : $_ } @array; - $pref_as_hash->{$field} = \@array; - } But this is not the same. If I pasted correct YAML previously like below, it would not work. ccode : - null - NULL - undefined - 2 - '3' Now it does. But perhaps more serious is the opposite, if I am entering some valid YAML array by 'forgetting' the first line: - null - NULL - undefined - 2 - '3' I will get back an array, while the former routine returned an empty hash ! This will trigger an error like: Not a HASH reference at /usr/share/koha/Koha/Item.pm line 2071. => foreach my $field (keys %$denyingrules) { This is a bit long way of saying: I still think that we may need an intermediate routine between pure YAML (yaml_preference) and what we expect for specific preferences? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:52:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:52:14 +0000 Subject: [Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats In-Reply-To: <bug-33703-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33703-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33703-70-CtlDB11vhB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- This is definitely not a bug in the sense of something not working the way it's designed to. Koha doesn't have code that automatically formats entry into dates, that's why the date picker widget is used. However, it is certainly becoming increasingly common for date fields to accept and automatically format text entry, and adding that should be something we look into. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:53:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:53:39 +0000 Subject: [Koha-bugs] [Bug 26967] Patron autocomplete does not correctly format addresses In-Reply-To: <bug-26967-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26967-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26967-70-NGlEGkPbDF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26967 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:53:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:53:41 +0000 Subject: [Koha-bugs] [Bug 26967] Patron autocomplete does not correctly format addresses In-Reply-To: <bug-26967-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26967-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26967-70-11emby8oYf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26967 --- Comment #10 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:53:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:53:42 +0000 Subject: [Koha-bugs] [Bug 31432] MARC21: Make 245 n and p subfields visible in frameworks by default In-Reply-To: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31432-70-NbPkGXTuIB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31432 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:53:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:53:44 +0000 Subject: [Koha-bugs] [Bug 31432] MARC21: Make 245 n and p subfields visible in frameworks by default In-Reply-To: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31432-70-KQPefYS1m8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31432 --- Comment #10 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:53:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:53:45 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32642-70-j8UI7bkeZP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:53:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:53:47 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32642-70-4F4sBy3ywH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 --- Comment #29 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:53:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:53:49 +0000 Subject: [Koha-bugs] [Bug 32817] Clean up cataloguing/value_builder/dateaccessioned.pl In-Reply-To: <bug-32817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32817-70-36qzYq0Hpt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:53:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:53:51 +0000 Subject: [Koha-bugs] [Bug 32817] Clean up cataloguing/value_builder/dateaccessioned.pl In-Reply-To: <bug-32817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32817-70-Bc3HCon7JS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 --- Comment #12 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:53:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:53:53 +0000 Subject: [Koha-bugs] [Bug 32818] Clean up cataloguing/value_builder/marc21_field_005.pl In-Reply-To: <bug-32818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32818-70-w8Ms7CEHdy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:53:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:53:54 +0000 Subject: [Koha-bugs] [Bug 32818] Clean up cataloguing/value_builder/marc21_field_005.pl In-Reply-To: <bug-32818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32818-70-XDf6Nax8bf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818 --- Comment #7 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:53:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:53:56 +0000 Subject: [Koha-bugs] [Bug 32865] Clean up cataloguing/value_builder/unimarc_field_146a.pl In-Reply-To: <bug-32865-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32865-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32865-70-U30E9gWWsl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:53:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:53:58 +0000 Subject: [Koha-bugs] [Bug 32865] Clean up cataloguing/value_builder/unimarc_field_146a.pl In-Reply-To: <bug-32865-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32865-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32865-70-roobeSHMVP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 --- Comment #10 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:53:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:53:59 +0000 Subject: [Koha-bugs] [Bug 32866] Clean up cataloguing/value_builder/unimarc_field_146h.pl In-Reply-To: <bug-32866-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32866-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32866-70-UJrzoWXfEq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32866 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:01 +0000 Subject: [Koha-bugs] [Bug 32866] Clean up cataloguing/value_builder/unimarc_field_146h.pl In-Reply-To: <bug-32866-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32866-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32866-70-HREbnV3ken@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32866 --- Comment #7 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:03 +0000 Subject: [Koha-bugs] [Bug 32867] Clean up cataloguing/value_builder/unimarc_field_146i.pl In-Reply-To: <bug-32867-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32867-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32867-70-XYjRIe8djg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32867 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:04 +0000 Subject: [Koha-bugs] [Bug 32867] Clean up cataloguing/value_builder/unimarc_field_146i.pl In-Reply-To: <bug-32867-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32867-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32867-70-iJEtFV5deb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32867 --- Comment #7 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:06 +0000 Subject: [Koha-bugs] [Bug 32868] Fix cataloguing/value_builder/unimarc_field_210c_bis.pl In-Reply-To: <bug-32868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32868-70-V1jDucmda0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32868 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:08 +0000 Subject: [Koha-bugs] [Bug 32868] Fix cataloguing/value_builder/unimarc_field_210c_bis.pl In-Reply-To: <bug-32868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32868-70-93qhpls036@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32868 --- Comment #9 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:10 +0000 Subject: [Koha-bugs] [Bug 32869] Fix cataloguing/value_builder/unimarc_field_210c.pl In-Reply-To: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32869-70-7xZKOCwUHR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32869 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:11 +0000 Subject: [Koha-bugs] [Bug 32869] Fix cataloguing/value_builder/unimarc_field_210c.pl In-Reply-To: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32869-70-TbPUbILVqN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32869 --- Comment #10 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:13 +0000 Subject: [Koha-bugs] [Bug 32870] Fix cataloguing/value_builder/unimarc_field_225a_bis.pl In-Reply-To: <bug-32870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32870-70-o1Vwr68ZMR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32870 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:15 +0000 Subject: [Koha-bugs] [Bug 32870] Fix cataloguing/value_builder/unimarc_field_225a_bis.pl In-Reply-To: <bug-32870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32870-70-uw1CAHOcCz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32870 --- Comment #9 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:16 +0000 Subject: [Koha-bugs] [Bug 32871] Fix cataloguing/value_builder/unimarc_field_225a.pl In-Reply-To: <bug-32871-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32871-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32871-70-1yAvQD0MNv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32871 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:18 +0000 Subject: [Koha-bugs] [Bug 32871] Fix cataloguing/value_builder/unimarc_field_225a.pl In-Reply-To: <bug-32871-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32871-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32871-70-bS4t7LDDuT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32871 --- Comment #8 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:20 +0000 Subject: [Koha-bugs] [Bug 32872] Fix cataloguing/value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-32872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32872-70-QD38f0mIkL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32872 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:21 +0000 Subject: [Koha-bugs] [Bug 32872] Fix cataloguing/value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-32872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32872-70-xzVufToiIz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32872 --- Comment #7 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:23 +0000 Subject: [Koha-bugs] [Bug 32873] Fix cataloguing/value_builder/unimarc_field_686a.pl In-Reply-To: <bug-32873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32873-70-37bvAaPZRg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32873 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:24 +0000 Subject: [Koha-bugs] [Bug 32873] Fix cataloguing/value_builder/unimarc_field_686a.pl In-Reply-To: <bug-32873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32873-70-1bzy9iQLiG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32873 --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:26 +0000 Subject: [Koha-bugs] [Bug 32875] Fix cataloguing/value_builder/unimarc_leader_authorities.pl In-Reply-To: <bug-32875-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32875-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32875-70-Fa5jrdo4Ir@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32875 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:28 +0000 Subject: [Koha-bugs] [Bug 32875] Fix cataloguing/value_builder/unimarc_leader_authorities.pl In-Reply-To: <bug-32875-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32875-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32875-70-lZyWNT4BQK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32875 --- Comment #7 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:30 +0000 Subject: [Koha-bugs] [Bug 32876] Fix cataloguing/value_builder/unimarc_leader.pl In-Reply-To: <bug-32876-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32876-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32876-70-PFHzV2UzzV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32876 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:31 +0000 Subject: [Koha-bugs] [Bug 32876] Fix cataloguing/value_builder/unimarc_leader.pl In-Reply-To: <bug-32876-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32876-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32876-70-vVf77ksCfh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32876 --- Comment #7 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:33 +0000 Subject: [Koha-bugs] [Bug 33127] Use template wrapper for breadcrumbs: Administration part 5 In-Reply-To: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33127-70-q1Qp6P6X7m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33127 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:34 +0000 Subject: [Koha-bugs] [Bug 33127] Use template wrapper for breadcrumbs: Administration part 5 In-Reply-To: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33127-70-8oOKgiRtlm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33127 --- Comment #9 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:36 +0000 Subject: [Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer In-Reply-To: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33300-70-1C65mPnlgW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:38 +0000 Subject: [Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer In-Reply-To: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33300-70-hbvVcE9gKZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 --- Comment #18 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:40 +0000 Subject: [Koha-bugs] [Bug 33310] Use template wrapper for tabs: Suggestions In-Reply-To: <bug-33310-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33310-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33310-70-aCmw700CVd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33310 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:41 +0000 Subject: [Koha-bugs] [Bug 33310] Use template wrapper for tabs: Suggestions In-Reply-To: <bug-33310-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33310-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33310-70-7JLk1k2Vvc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33310 --- Comment #8 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:43 +0000 Subject: [Koha-bugs] [Bug 33388] Use template wrapper for breadcrumbs: Patrons part 4 In-Reply-To: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33388-70-u86jJ05op2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33388 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:44 +0000 Subject: [Koha-bugs] [Bug 33388] Use template wrapper for breadcrumbs: Patrons part 4 In-Reply-To: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33388-70-K0GlyRKj5I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33388 --- Comment #11 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:46 +0000 Subject: [Koha-bugs] [Bug 33438] Use template wrapper for breadcrumbs: Reports part 3 In-Reply-To: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33438-70-6hVKJCqTz2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33438 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:48 +0000 Subject: [Koha-bugs] [Bug 33438] Use template wrapper for breadcrumbs: Reports part 3 In-Reply-To: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33438-70-UTc7CLcNAk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33438 --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:49 +0000 Subject: [Koha-bugs] [Bug 33439] Use template wrapper for breadcrumbs: Reports part 4 In-Reply-To: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33439-70-leet8faDkC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33439 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:51 +0000 Subject: [Koha-bugs] [Bug 33439] Use template wrapper for breadcrumbs: Reports part 4 In-Reply-To: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33439-70-JS6C4TaKiC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33439 --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:52 +0000 Subject: [Koha-bugs] [Bug 33555] Use template wrapper for breadcrumbs: Rotating collections In-Reply-To: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33555-70-yuWe1nYJEi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33555 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:54 +0000 Subject: [Koha-bugs] [Bug 33555] Use template wrapper for breadcrumbs: Rotating collections In-Reply-To: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33555-70-FYFDTlbUWZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33555 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:55 +0000 Subject: [Koha-bugs] [Bug 33558] Use template wrapper for breadcrumbs: Serials part 1 In-Reply-To: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33558-70-yqDy9JvSoB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33558 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:57 +0000 Subject: [Koha-bugs] [Bug 33558] Use template wrapper for breadcrumbs: Serials part 1 In-Reply-To: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33558-70-4Z6uHpf1dC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33558 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:54:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:54:58 +0000 Subject: [Koha-bugs] [Bug 33565] Use template wrapper for breadcrumbs: Tags In-Reply-To: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33565-70-Cpe9zqEyDS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33565 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:55:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:55:00 +0000 Subject: [Koha-bugs] [Bug 33565] Use template wrapper for breadcrumbs: Tags In-Reply-To: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33565-70-taxFvAslxJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33565 --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:55:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:55:01 +0000 Subject: [Koha-bugs] [Bug 33571] Use template wrapper for breadcrumbs: Tools, part 2 In-Reply-To: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33571-70-g0qwLktvrV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33571 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:55:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:55:03 +0000 Subject: [Koha-bugs] [Bug 33571] Use template wrapper for breadcrumbs: Tools, part 2 In-Reply-To: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33571-70-UpO21KNCQb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33571 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:55:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:55:05 +0000 Subject: [Koha-bugs] [Bug 33572] Use template wrapper for breadcrumbs: Tools, part 3 In-Reply-To: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33572-70-SZ242g3FTC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33572 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:55:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:55:06 +0000 Subject: [Koha-bugs] [Bug 33572] Use template wrapper for breadcrumbs: Tools, part 3 In-Reply-To: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33572-70-zE5aPaSPLg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33572 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:55:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:55:08 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-HycY0KCKzq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:55:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:55:09 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-DiB3g8t6Xv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:56:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:56:46 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-rkDRRq34cx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148736|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150989&action=edit Bug 29523: Add Koha::Objects->search_limited stub method This method is just a passthru to the search method. It is defined here to avoid the need to check if each class implements it. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:56:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:56:49 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-W8zOGMYhO1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148737|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150990&action=edit Bug 29523: Add Koha::Object->accessible This patch introduces a method for checking if an object can be retrieved by the current user. It depends on the plural class implementation of the ->search_limited method. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:56:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:56:53 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-3DrzerGIRE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148738|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150991&action=edit Bug 29523: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:56:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:56:57 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-RD7hc0LrSy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148739|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150992&action=edit Bug 29523: Make Koha::Object->to_api respect accessibility This patch makes the *to_api* method honour the accessibility check for the object. This is relevant in the context of embedding single objects. The Koha::Patron->to_api method is adjusted to reflect this behavior as well (it does some manipulation after the ->to_api call and we need to prevent it). To test: 1. Apply up to the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: A patron, that shouldn't be accessed, is returned by ->to_api 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 6. Pick Henry Acevedo from the sample data, assign him 'catalogue' permissions and a know user/password combination 7. Enable basic authentication 8. Point your favourite tool (Postman?) to GET http://kohadev-intra.myDNSname.org:8081/api/v1/biblio/245/checkouts Set the following header: x-koha-embed: patron Pick whatever biblio you want, actually. => SUCCESS: No checkouts 9. Perform a couple checkouts on the chosen biblio. Make sure one checkout is for a patron on the same library as Henry, and the other on a different one. 10. Repeat 8 => SUCCESS: You see two checkouts. One of them has an attribute 'patron' containing the patron from Henry's library. The other, has the attribute set to 'null'. 11. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:57:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:57:00 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-jv3FJfNUeK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148740|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150993&action=edit Bug 29523: (QA follow-up) Catch remaining SUPER::to_api cases Koha::Object->to_api can now return undefined.. we should be catching that cases in all post manipulation cases. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:57:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:57:04 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-k5vd1QpWan@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148741|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150994&action=edit Bug 29523: (QA follow-up) Fix failing test in club holds With this patch series, all singular objects need to 'use' their plural counterparts.. otherwise the parent can't find search_related. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:57:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:57:07 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-pCZ42tH7gu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148742|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150995&action=edit Bug 29523: Pass the logged user around and use for validating In this patch I add 'user', containing the Koha::Patron object for the logged in user in the params hash we pass around in to_api. I then use that in a new 'is_accessible' method added to Koha::Patron. The new method is really the equivilent of 'search_limited' in the plural class and could perhaps be renamed 'is_limited' or something clearer for the singular form 'is_filtered' or 'fitler_for_api' or something? Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:57:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:57:10 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-VCmCJMyW1P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148743|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150996&action=edit Bug 29523: Cache the restricted branches list This patch introduces a very localised cache of the restricted branches list in the logged in patron object. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:57:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:57:14 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-z8NLl4Z9HV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148744|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150997&action=edit Bug 29523: Remove the FIXME This patch works through the unit tests and existing code to allow removal of the FIXME I introduced earlier in the patchset. We now require the `user` parameter be passed to `is_accessible` which in turn makes `user` a required parameter for `to_api` in the `Koha::Patron` case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:57:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:57:17 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-XxMvpDeRsq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148745|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150998&action=edit Bug 29523: Remove no longer required methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:58:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:58:01 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-cu0NS0MpK8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #91 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Aha.. thanks Marcel.. that helped me spot the issue! All rebased again and the 'Regressions tests' patch fixed. Tests all passing again now. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:58:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:58:52 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-yZrXlbA3lV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 14:59:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 12:59:23 +0000 Subject: [Koha-bugs] [Bug 33549] Patron restriction types - Style missing for dialog messages In-Reply-To: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33549-70-e77KGK95gu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial CC| |jacob.omara at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:00:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:00:50 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-JlMdufoSAP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #92 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #91) > Aha.. thanks Marcel.. that helped me spot the issue! > > All rebased again and the 'Regressions tests' patch fixed. > > Tests all passing again now. :) You chose the wrong status, I am afraid. It came from SO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:10:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:10:08 +0000 Subject: [Koha-bugs] [Bug 33707] News vs Quote of the day styling on staff interface main page In-Reply-To: <bug-33707-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33707-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33707-70-chBSi1dNMb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33707 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:10:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:10:10 +0000 Subject: [Koha-bugs] [Bug 33707] News vs Quote of the day styling on staff interface main page In-Reply-To: <bug-33707-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33707-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33707-70-WxsdAYqQNN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33707 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150988|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Created attachment 150999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150999&action=edit Bug 33707: News vs Quote of the day styling on staff interface main page This patch makes minor adjustments to the global and staff home page CSS so that the display of news and quote-of-the-day are more consistent. To test, apply the patch and rebuild the staff interface CSS. - If necessary, add at least one news item (Tools -> News -> New entry) and at least one quote (Tools -> Quote editor -> New quote). - View the staff interface home page to confirm that the style of the news area and the quotes is consistent. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:18:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:18:35 +0000 Subject: [Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence) In-Reply-To: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33699-70-vk0K8vv00M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:23:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:23:40 +0000 Subject: [Koha-bugs] [Bug 33705] Tables have configure button even if they are not configurable In-Reply-To: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33705-70-vpXy53j7SP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:23:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:23:42 +0000 Subject: [Koha-bugs] [Bug 33705] Tables have configure button even if they are not configurable In-Reply-To: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33705-70-l9blVDHeI5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150922|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Created attachment 151000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151000&action=edit Bug 33705: (bug 33066 follow-up) Fix 'configure' button for kohaTable The 'configure' button is displayed for any tables, even those that cannot be configured. This is a regression caused by commit 765fd1ced3b9efc4ff6fb71e2fee1a7a227d1cae Bug 33066: Introduce a KohaTable Vue component It's adding a default value for table_settings, but then later we are testing if table_settings is true: 699 let table_settings = params.table_settings || {}; ... 798 if ( table_settings && CAN_user_parameters_manage_column_config ) { This patch is reverting the default value, so the test will be corrected. Test plan: 1. Go to Tools > Quote editor 2. Click "Configure" => Without this patch you are brought to the column settings page, but the quote editor table is not there => With this patch the button is not present 3. Go to the cities page (admin/cities.pl) 4. Click "Configure" => You are brought to the column settings page Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:25:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:25:19 +0000 Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error In-Reply-To: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28844-70-XLTvyxhf1A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:25:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:25:22 +0000 Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error In-Reply-To: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28844-70-IQzmrPQ2e8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151001&action=edit Bug 28844: DB changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:25:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:25:24 +0000 Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error In-Reply-To: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28844-70-t3dUQIXBwl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151002&action=edit Bug 28844: DBIC schema changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:25:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:25:27 +0000 Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error In-Reply-To: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28844-70-BcOQGNeHCF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151003&action=edit Bug 28844: DBIC specific -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:25:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:25:30 +0000 Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error In-Reply-To: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28844-70-hj2UZprDEc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151004&action=edit Bug 28844: Add link between suggestions and orders -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:25:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:25:32 +0000 Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error In-Reply-To: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28844-70-vjcUxS2mGl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151005&action=edit Bug 28844: Remove GetSuggestionInfoFromBiblionumber -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:25:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:25:35 +0000 Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error In-Reply-To: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28844-70-98X3RHeKMP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151006&action=edit Bug 28844: Replace GetSuggestionFromBiblionumber -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:25:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:25:38 +0000 Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error In-Reply-To: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28844-70-NnxevlIoLV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151007&action=edit Bug 28844: Remove GetSuggestionFromBiblionumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:26:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:26:28 +0000 Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error In-Reply-To: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28844-70-TrfcY5jYj2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Well, no test plan here. You need to test the whole suggestion/acquisition workflow and search for bugs! Link should be displayed correctly as before, and even better in cause of multiple suggestions on the same record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:27:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:27:25 +0000 Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error In-Reply-To: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28844-70-qFdovHJaqt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:27:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:27:42 +0000 Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error In-Reply-To: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28844-70-puOLlIORvb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Please do not backport this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:31:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:31:20 +0000 Subject: [Koha-bugs] [Bug 33675] OAuth should support state parameter In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-0ONQC9KxGi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://www.oauth.com/oauth | |2-servers/accessing-data/au | |thorization-request/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:37:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:37:48 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-47oHh2g1ZK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:42:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:42:25 +0000 Subject: [Koha-bugs] [Bug 33675] OAuth should support state parameter In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-qkKgTlbY7N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano at theke.io, | |dcook at prosentient.com.au --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- This is a recommended openid-connect parameter [1] and OAuth2 integrations seem to require it [2], but I'm not sure if it should be enforced. Basically because I don't know all the IdPs around. [1] https://openid.net/specs/openid-connect-core-1_0.html#AuthRequest [2] https://www.oauth.com/oauth2-servers/accessing-data/authorization-request/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:42:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:42:41 +0000 Subject: [Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence) In-Reply-To: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33699-70-hlgWVx0jwl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 15:42:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 13:42:44 +0000 Subject: [Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence) In-Reply-To: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33699-70-GP01bLXEnV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151008&action=edit Bug 33699: Typo in identity_provider_domains.tt (presedence) This patch corrects the typo "presedence" with "precedence." The patch also corrects some grammar: "so if the 'library.com' domain will take presedence over '*library.com'" ...changed to... "so 'library.com' domain will take presedence over '*library.com'" I also changed the <div>s inside that block of help text to <p> in order to improve legibility. To test, apply the patch and go to Administration -> Identity providers -> Manage domains (on an existing provider) -> Edit, and click the "More" button under the "Domain" field. Confirm that the text is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:04:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:04:36 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-DwoTcT8V40@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:04:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:04:39 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-gEWMnSN216@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151009&action=edit Bug 29185: (QA follow-up) Quote title search in GetCnumSearchURL Test plan: Disable UseControlNumber Change biblio title to something like: Hamlet or CHINESE_CHARS where you add some nice Chinese chars. Create a 765 looking for that title in another biblio record. Without this patch, the link at detail page finds both records, since it looks for ti-phr:Hamlet OR the Chinese chars. With this patch, the link at detail uses quotes and finds only one, since the OR is now part of the ti-phr search. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:09:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:09:10 +0000 Subject: [Koha-bugs] [Bug 32985] Patron quick search done on cardnumber even if not inDefaultPatronSearchFields In-Reply-To: <bug-32985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32985-70-bRt8sui9ag@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32985 --- Comment #7 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Jonathan Druart from comment #6) > This patch should fix the problem you are describing, but not sure it's > something we want. This behaviour has been around for years now. > > Lowering priority. If it is not something you want, I'm not sure why you are providing it. A couple of options were presented. A) Make it consistent with how the preference works with everything else defined or not defined. B) Make it the exception, and list it as so in the description. Either way, it just needs to be consistent. There is no sane reason for having it work one way in some places, and another in other places. Let's just decide on a a consistent way of making this function, and help everyone to understand how it functions. That is all I ask. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:10:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:10:03 +0000 Subject: [Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence) In-Reply-To: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33699-70-FL6OFmJ4l5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Thanks Owen for the correction! Does the div vs p affect the space between the lines? I noticed that when adding a new domain, the lines are all smushed together, but when editing an existing domain, the lines are spaced out, making it easier to read. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:10:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:10:41 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-b8tbmAFtQg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Depends on| |32121 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 [Bug 32121] Show an alert when adding a checked out item to an item bundle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:10:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:10:41 +0000 Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle In-Reply-To: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32121-70-BE8Qsu1pyf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33447 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 [Bug 33447] Add caching to Biblio->pickup_locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:14:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:14:12 +0000 Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle In-Reply-To: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32121-70-pZ7PSG592j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:25:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:25:32 +0000 Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle In-Reply-To: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32121-70-v4jWOP3epE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:25:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:25:32 +0000 Subject: [Koha-bugs] [Bug 32802] Bundle handling JS should be moved to an asset In-Reply-To: <bug-32802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32802-70-VrmWUmkjbA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32802 Bug 32802 depends on bug 32121, which changed state. Bug 32121 Summary: Show an alert when adding a checked out item to an item bundle https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:25:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:25:32 +0000 Subject: [Koha-bugs] [Bug 33021] Show an alert when adding a reserved item to an item bundle In-Reply-To: <bug-33021-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33021-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33021-70-tAJwmDLUP2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Bug 33021 depends on bug 32121, which changed state. Bug 32121 Summary: Show an alert when adding a checked out item to an item bundle https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:25:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:25:33 +0000 Subject: [Koha-bugs] [Bug 33025] Show an alert when adding a lost item to an item bundle In-Reply-To: <bug-33025-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33025-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33025-70-5TpO6KYYvA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33025 Bug 33025 depends on bug 32121, which changed state. Bug 32121 Summary: Show an alert when adding a checked out item to an item bundle https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:25:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:25:33 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-52Yn6fR0rf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Bug 33447 depends on bug 32121, which changed state. Bug 32121 Summary: Show an alert when adding a checked out item to an item bundle https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:25:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:25:40 +0000 Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle In-Reply-To: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32121-70-mEtDF7de7C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:25:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:25:41 +0000 Subject: [Koha-bugs] [Bug 32802] Bundle handling JS should be moved to an asset In-Reply-To: <bug-32802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32802-70-wl2j1iMkcS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32802 Bug 32802 depends on bug 32121, which changed state. Bug 32121 Summary: Show an alert when adding a checked out item to an item bundle https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:25:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:25:41 +0000 Subject: [Koha-bugs] [Bug 33021] Show an alert when adding a reserved item to an item bundle In-Reply-To: <bug-33021-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33021-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33021-70-JfNDfmKWa8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Bug 33021 depends on bug 32121, which changed state. Bug 32121 Summary: Show an alert when adding a checked out item to an item bundle https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:25:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:25:41 +0000 Subject: [Koha-bugs] [Bug 33025] Show an alert when adding a lost item to an item bundle In-Reply-To: <bug-33025-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33025-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33025-70-WfWOWZ8deb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33025 Bug 33025 depends on bug 32121, which changed state. Bug 32121 Summary: Show an alert when adding a checked out item to an item bundle https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:25:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:25:42 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-HzbmZMxHFl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Bug 33447 depends on bug 32121, which changed state. Bug 32121 Summary: Show an alert when adding a checked out item to an item bundle https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:25:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:25:49 +0000 Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle In-Reply-To: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32121-70-x4jKbfCSlO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:25:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:25:54 +0000 Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle In-Reply-To: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32121-70-XDVRrIHxbH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:26:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:26:00 +0000 Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle In-Reply-To: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32121-70-4lQsqLSWwo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:26:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:26:27 +0000 Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle In-Reply-To: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32121-70-44EUNKlR0S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:27:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:27:36 +0000 Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle In-Reply-To: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32121-70-6lh4bAwQBZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- We've opted to upgrade this to bugfix and backport it now (some parts of it are needed for subsequent bugfixes that we want) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:28:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:28:03 +0000 Subject: [Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence) In-Reply-To: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33699-70-g7m0zzI0tc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Whoops, my patch is incomplete! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:38:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:38:56 +0000 Subject: [Koha-bugs] [Bug 33691] Improve query for do_check_for_previous_checkout In-Reply-To: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33691-70-RboyNPfpic@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33691 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:39:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:39:35 +0000 Subject: [Koha-bugs] [Bug 33691] Improve query for do_check_for_previous_checkout In-Reply-To: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33691-70-SDmmh9r6nM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33691 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:43:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:43:12 +0000 Subject: [Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence) In-Reply-To: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33699-70-siCNoeTyfA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:43:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:43:14 +0000 Subject: [Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence) In-Reply-To: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33699-70-uuZQReS7Js@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151008|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151010&action=edit Bug 33699: Typo in identity_provider_domains.tt (presedence) This patch corrects the typo "presedence" with "precedence." The patch also corrects some grammar: "so if the 'library.com' domain will take presedence over '*library.com'" ...changed to... "so 'library.com' domain will take presedence over '*library.com'" I also changed the <div>s inside that block of help text to <p> in order to improve legibility. To test, apply the patch and go to Administration -> Identity providers -> Manage domains (on an existing provider) -> Edit, and click the "More" button under the "Domain" field. Confirm that the text is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 16:48:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 14:48:01 +0000 Subject: [Koha-bugs] [Bug 33691] Improve query for do_check_for_previous_checkout In-Reply-To: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33691-70-NdaUDyg3jF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33691 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- my @item_nos; [..] @item_nos = $biblio->items->get_column( 'itemnumber' ); And now we are fetching lots of item numbers and doing nothing with them? Could you explain why we can miss the item numbers in general here ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:00:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:00:35 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-BYWhCRlKAp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:00:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:00:37 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-8NEE2kCJ4z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #17 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:00:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:00:38 +0000 Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle In-Reply-To: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32121-70-n00dHBtLl4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:00:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:00:40 +0000 Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle In-Reply-To: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32121-70-w39p3XBvCh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 --- Comment #14 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:00:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:00:42 +0000 Subject: [Koha-bugs] [Bug 33549] Patron restriction types - Style missing for dialog messages In-Reply-To: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33549-70-wNaiSKiPGA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:00:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:00:43 +0000 Subject: [Koha-bugs] [Bug 33549] Patron restriction types - Style missing for dialog messages In-Reply-To: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33549-70-u8sI1hMa9s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 --- Comment #7 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:00:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:00:45 +0000 Subject: [Koha-bugs] [Bug 33577] Buttons on reserve/request.pl are misaligned In-Reply-To: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33577-70-aJyQg6Roiz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33577 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:00:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:00:47 +0000 Subject: [Koha-bugs] [Bug 33577] Buttons on reserve/request.pl are misaligned In-Reply-To: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33577-70-VS5G4U2pmL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33577 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:03:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:03:46 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-nPDPznqZ6Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Status|Pushed to stable |ASSIGNED --- Comment #19 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- PLEASE IGNORE THE ABOVE, NOT PUSHED TO STABLE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:03:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:03:52 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-bOOww26oqC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:03:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:03:56 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-0rot7poFco@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:04:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:04:06 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-hpXe2n2f3J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.06 |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:04:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:04:41 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-dwRTx9eb1F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Status|Pushed to stable |ASSIGNED --- Comment #18 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- PLEASE IGNORE THE ABOVE, NOT PUSHED TO STABLE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:04:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:04:53 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-ZMoQ4uUIkr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.06 |23.05.00 released in| | Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:04:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:04:57 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-rulA9kcxD8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:05:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:05:31 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-nd37iFjfOo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #17) > Created attachment 150564 [details] [review] > Bug 33491: Add a more specific class for the modal > > We don't want to apply these CSS rules to other modals Pedro, should we go with this patch and see if we can do better on a separate bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:12:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:12:07 +0000 Subject: [Koha-bugs] [Bug 33681] Omnibus: Allow SIP2 users to be created through the Koha staff interface In-Reply-To: <bug-33681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33681-70-JhPGjxPqy0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33681 --- Comment #6 from Liz Rea <wizzyrea at gmail.com> --- love that yes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:13:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:13:52 +0000 Subject: [Koha-bugs] [Bug 33681] Omnibus: Allow SIP2 users to be created through the Koha staff interface In-Reply-To: <bug-33681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33681-70-2Aw0e4PbAg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33681 --- Comment #7 from Liz Rea <wizzyrea at gmail.com> --- It just occurred to me that also it would be desirable, but perhaps not mvp level, to allow the UI to set which fields to send (of the non-required ones) for privacy reasons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:45:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:45:00 +0000 Subject: [Koha-bugs] [Bug 20751] Marc21: Show i for 776 In-Reply-To: <bug-20751-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20751-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20751-70-JwOfNd7Nrd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20751 Lauren Denny <lauren_denny at sil.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny at sil.org --- Comment #2 from Lauren Denny <lauren_denny at sil.org> --- This already exists in koha. I don't remember which version it started to appear though. :) We use the 776$i on a regular basis. It would be nice if it could be displayed in the other linking fields that Heather mentions in her comment. Should that be a new bug? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:50:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:50:37 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-elEAlHhncr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150750|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151011&action=edit Bug 32911: Remove ILL partner_code config from koha-conf.xml and turn it into a system preference Preparation: 1) apply patch 2) run reset_all 3) enable ILLModule sys preference 4) install a backend (e.g. FreeForm) 5) go into system preferences and confirm that ILLPartnerCode exists and is the default inter-library loan (IL) Test plan: 1) create an ILL request 2) ensure the patron of category 'IL' has a primary e-mail configured 3) click on "place request with partners" 4) verify that the patron(s) of said category are on the partners list Upgrade test: 1) Remove the system preference from the database, run query: delete from systempreferences where variable="ILLPartnerCode"; 2) Check or edit the value or partner_code in koha-conf.xml and run atomicupdate: installer/data/mysql/updatedatabase.pl 3) Confirm the value in koha-conf.xml has been successfully migrated into the system preference, run query: select * from systempreferences where variable="ILLPartnerCode"; Optional tests: - Set a patron category in the sys pref and then delete said patron category (needs to not have patrons in it) - Check the about page -> System information and confirm the warning message is correct - Set the sys pref to the empty option - Check the about page -> System information and confirm the warning message is correct - Set the sys pref to a category that has no patrons of its type (ktd examples: Board, or Library) - Check the about page -> System information and confirm the warning message is correct Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:50:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:50:40 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-DHqW5nZUTl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150751|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151012&action=edit Bug 32911: Database update Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:50:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:50:43 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-g2gR9tnpXt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150752|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151013&action=edit Bug 32911: (follow-up) Move pref from Notifications to Features section The new preference appeared under Notifications, but is better suited for the Features section on the ILL tab in system preferences. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:50:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:50:46 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-1On8rKLcTC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150753|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151014&action=edit Bug 32911: (follow-up) Remove a couple of cases from tests This patch simply removes the partner_code defaults from some tests where it is no longer required. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:50:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:50:48 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-Nuho6TUoqR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150768|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151015&action=edit Bug 32911: (follow-up) Remove partner_code from debian and /etc koha-conf.xml files Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:50:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:50:51 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-CAgVIuPYRJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150769|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151016&action=edit Bug 32911: (follow-up) Only move config value from koha-conf.xml if it exists Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:51:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:51:05 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-pJSaVtzxWv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:51:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:51:11 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-1b1XAiCgUh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:58:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:58:27 +0000 Subject: [Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence) In-Reply-To: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33699-70-O8xRZWkx8K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:58:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:58:29 +0000 Subject: [Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence) In-Reply-To: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33699-70-rcc1S1AmaJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151010|0 |1 is obsolete| | --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Created attachment 151017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151017&action=edit Bug 33699: Typo in identity_provider_domains.tt (presedence) This patch corrects the typo "presedence" with "precedence." The patch also corrects some grammar: "so if the 'library.com' domain will take presedence over '*library.com'" ...changed to... "so 'library.com' domain will take presedence over '*library.com'" I also changed the <div>s inside that block of help text to <p> in order to improve legibility. To test, apply the patch and go to Administration -> Identity providers -> Manage domains (on an existing provider) -> Edit, and click the "More" button under the "Domain" field. Confirm that the text is correct. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 17:59:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 15:59:56 +0000 Subject: [Koha-bugs] [Bug 32985] Patron quick search done on cardnumber even if not inDefaultPatronSearchFields In-Reply-To: <bug-32985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32985-70-iHlgnRsQ5e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32985 --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Christopher Brannon from comment #7) > (In reply to Jonathan Druart from comment #6) > > This patch should fix the problem you are describing, but not sure it's > > something we want. This behaviour has been around for years now. > > > > Lowering priority. > > If it is not something you want, I'm not sure why you are providing it. A > couple of options were presented. > > A) Make it consistent with how the preference works with everything else > defined or not defined. This is what the patch does. I've provided it for discussion. Did you try it? Does it fit your needs? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:03:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:03:07 +0000 Subject: [Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking In-Reply-To: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33557-70-btecAKq3o0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149830|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151018&action=edit Bug 33557: Add LinkerConsiderThesaurus system preference Bug 30280 added the ability to use multiple thesauri for authorities in Koha. This is a large change, and many libraries use authorities in a ess strict manner. This patch simply adds a preference, disabled by default, to enable this new feature To test: 1 - Find or create a record with a 650 heading, second indicator 0 (LOC) 2 - Ensure this links to an authority in your system 3 - Disable AutoCreateAuthorities, enable CatalogModuleRelink 4 - Edit the heading to second indicator 2 5 - Save, the heading does not link 6 - Apply patch, updatedatabase, restart all 7 - Edit and save record again 8 - Heading should now link to the LOC authority, despite different second indicator value for source Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:03:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:03:31 +0000 Subject: [Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking In-Reply-To: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33557-70-0d1M4czIic@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- All working as expected.. passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:07:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:07:10 +0000 Subject: [Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode In-Reply-To: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32341-70-Z5TKh6hlyh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:09:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:09:30 +0000 Subject: [Koha-bugs] [Bug 33712] Use new checkout API's for staff interface checkouts In-Reply-To: <bug-33712-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33712-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33712-70-lUhsSH1qKT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33712 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use new checkout api's for |Use new checkout API's for |staff client checkouts |staff interface checkouts -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:10:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:10:04 +0000 Subject: [Koha-bugs] [Bug 33675] OAuth should support state parameter In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-FvwqOyKg3Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:10:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:10:07 +0000 Subject: [Koha-bugs] [Bug 33675] OAuth should support state parameter In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-cI3oGZnltG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151019&action=edit Bug 33675: Add CSRF protection to OAuth/OIDC authentication This patch makes the OAuth/OIDC client pass a `state` parameter with a CSRF protection token, to be validated back when the flow returns to Koha. Ideally, the Mojolicious::Plugin::OAuth2 library should deal with this implicitly, probably making use of JWT. But as of now, this is the best way to implement it. To test: 1. Have a working SSO solution (ktd --sso) 2. Click to login using SSO => SUCCESS: Notice a 'state' parameter on the URL, looks like a random thing 3. When you login, no error is reported -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:10:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:10:20 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-GLjxlfU4n9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OAuth should support state |Add CSRF protection to |parameter |OAuth/OIDC authentication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:10:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:10:32 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28328-70-fqgf6TllRm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150586|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151020&action=edit Bug 28328: Extend biblioitems.lccn to longtext Same sa issn and isbn, we want lccn to allow longer values. Test plan: Run the updatedatabase script to modify the DB structure restart_all Edit a bibliographic record and enter a long (more than 25 chars) lccn Save Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:10:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:10:35 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28328-70-9coy13mOfw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150587|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151021&action=edit Bug 28328: DBIC schema changes Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:10:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:10:39 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28328-70-cBaznqhlqz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150588|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151022&action=edit Bug 28328: Adjust tests Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:10:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:10:57 +0000 Subject: [Koha-bugs] [Bug 33681] Omnibus: Allow SIP2 users to be created through the Koha staff interface In-Reply-To: <bug-33681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33681-70-6QlUdX8uC6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33681 --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Liz Rea from comment #7) > It just occurred to me that also it would be desirable, but perhaps not mvp > level, to allow the UI to set which fields to send (of the non-required > ones) for privacy reasons Excellent idea! Probably best as a follow up bug for ease of testing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:10:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:10:58 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28328-70-bfE1ZBhegp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- All working as described and fixes the issue. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:10:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:10:59 +0000 Subject: [Koha-bugs] [Bug 20751] Marc21: Show i for 776 In-Reply-To: <bug-20751-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20751-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20751-70-EOWYS2bjMx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20751 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Lauren Denny from comment #2) > This already exists in koha. I don't remember which version it started to > appear though. :) We use the 776$i on a regular basis. > > It would be nice if it could be displayed in the other linking fields that > Heather mentions in her comment. Should that be a new bug? Yes, please :) But I believe we already do show in several, not sure which ones might be missing still if at all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:11:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:11:01 +0000 Subject: [Koha-bugs] [Bug 33353] Add compatibility with Elasticsearch 8 In-Reply-To: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33353-70-bKRcCCK2uo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33353 koha-US bug tracker <bugzilla at koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:14:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:14:44 +0000 Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) In-Reply-To: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25669-70-dgstTRZdbK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 koha-US bug tracker <bugzilla at koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:17:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:17:42 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-CGTnuIuTnl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148168|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151023&action=edit Bug 33223: Replace 'first_valid' with 'notice' for email addresses This patch replaces the uses of first_valid_email_address with notice_email_address in waiting_holds, transferstoreceive, clubs and sendbasket so that we take EmailFieldPrimary into account for these notices too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:17:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:17:54 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-MHYEAhVxAo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:30:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:30:14 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33462-70-5WWeJSjJSK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 --- Comment #1 from koha-US bug tracker <bugzilla at koha-us.org> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:30:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:30:50 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33462-70-HM9zrx3EwS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #2 from George Williams (NEKLS) <george at nekls.org> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:44:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:44:39 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-zoz9llEYmF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33223 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:44:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:44:39 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-oWZhno2VUm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12532 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:47:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:47:20 +0000 Subject: [Koha-bugs] [Bug 33713] New: Report batch operations should open in new tab Message-ID: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33713 Bug ID: 33713 Summary: Report batch operations should open in new tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: andrewfh at dubcolib.org QA Contact: testopia at bugs.koha-community.org When using the batch operations from report results, it would be great if the batch operation links defaulted to opening in a new tab, rather than navigating one away from the report results. I'm working on a project that involves running a report with a runtime variable, doing a batch edit on all of the objects in the results, then rerunning the report with a new variable, a new edit, and so on. Getting pushed out of the reports module for each batch action makes the workflow much more cumbersome. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:49:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:49:20 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-8YDco0o6UR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #109 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Looking here.. I think it you want to make sure you're catching all locations you need to depend on bug 33223 which systematically goes through the codebase making sure we use notice_email_address consistently. I'm doing a splinter review now.. there seems to be a lot wrapped up into the commit that I'm not sure it directly related to the bug reported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:49:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:49:29 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-JxPIGg3ov5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:49:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:49:38 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-KJxKfFPqnQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 [Bug 33223] Koha::Patron->notice_email_address isn't consistently used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:49:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:49:38 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-oF7aWtJWSU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 [Bug 12532] Redirect guarantee email to guarantor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:55:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:55:38 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-nf6j8mIijH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #110 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Comment on attachment 150256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150256 Bug 12532: Send email to guarantee and guarantor Review of attachment 150256: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12532&attachment=150256) ----------------------------------------------------------------- I love where this is going... but I think it needs a few more little fixes to get it through. Happy to help work those in. ::: C4/Letters.pm @@ +1471,5 @@ > || $message->{to_address} ne $email->email->header('To'); > > + _update_message_from_address($message->{'message_id'},$email->email->header('From') ) > + if !$message->{from_address} > + || $message->{from_address} ne $email->email->header('From'); Not sure how this relates to the core bug here.. and I don't see any updated tests to show what this does either? ::: Koha/Email.pm @@ +118,4 @@ > $args->{to} = $params->{to}; > } > > + my @emails = split(',', $args->{to}); Interesting.. I thought we already supported multiple comma delimited to addresses.. this feels bad enough that we should have it on it's own bug really... but I'm happy to let that slide to get it in. ::: Koha/Patron.pm @@ +1439,5 @@ > + $address .= $guarantor_address if $guarantor_address; > + } > + } > + } > + return $address; I'd like to see this rebased against bug 33223 given it makes the use of notice_email_address more consistent generally. ::: installer/data/mysql/mandatory/sysprefs.sql @@ +597,4 @@ > ('RecallsMaxPickUpDelay','7',NULL,'Define the maximum time a recall can be awaiting pickup','Integer'), > ('RecordLocalUseOnReturn','0',NULL,'If ON, statistically record returns of unissued items as local use, instead of return','YesNo'), > ('Reference_NFL_Statuses','1|2',NULL,'Contains not for loan statuses considered as available for reference','Free'), > +('RedirectGuaranteeEmail', '0', NULL, 'Enable the ability to redirect guarantee email messages to guarantor.', 'YesNo'), Redirect seems like the wrong term here.. we're cc'ing in effect in the end.. so perhaps it should be renamed 'Copy' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:55:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:55:52 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-CdaAwqIkbd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 18:59:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 16:59:51 +0000 Subject: [Koha-bugs] [Bug 33714] New: Enabling advanced editor causes 500 error Message-ID: <bug-33714-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33714 Bug ID: 33714 Summary: Enabling advanced editor causes 500 error Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: Windows Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: kohasupport at nlj.gov.jm QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Good day. I am using Koha version 21.05 and 21.11 on local and offsite servers respectively. When I try to enable the Advanced Editor for the catalog, I get a 500 error which also affects the standard editor when it's enabled. Any help would be appreciated. Thank you. P.S- no updates were done on the system. Do I need to change something on the server? We run Apache on ubuntu. Thanks again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:02:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:02:57 +0000 Subject: [Koha-bugs] [Bug 33715] New: Unable to find default code Message-ID: <bug-33715-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33715 Bug ID: 33715 Summary: Unable to find default code Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kohasupport at nlj.gov.jm QA Contact: testopia at bugs.koha-community.org Good day, I am trying to modify the current default css in the OPAC, however, the code is no where to be found in any of the css related fields. (opacuserCSS, OpacUserJS, etc). This is a new instance so no code is available in the Tool>News either. Thanks for your help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:03:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:03:39 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-Hx8axkzwgB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151023|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151024&action=edit Bug 33223: Replace 'first_valid' with 'notice' for email addresses This patch replaces the uses of first_valid_email_address with notice_email_address in waiting_holds, transferstoreceive, clubs and sendbasket so that we take EmailFieldPrimary into account for these notices too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:03:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:03:42 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-dnnl4aWtiH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151025&action=edit Bug 33223: Fix sendshelf Two new occurences of first_valid crept in, this patch corrects those to also use notice_ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:05:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:05:18 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-eOYsdJlqKy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3150 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 [Bug 3150] Move emails for sending cart and list contents into notices tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:05:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:05:18 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3150-70-7IQ70ATlOG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 [Bug 33223] Koha::Patron->notice_email_address isn't consistently used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:11:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:11:25 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-OQODDBVv9v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #111 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Comment on attachment 150256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150256 Bug 12532: Send email to guarantee and guarantor Review of attachment 150256: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12532&attachment=150256) ----------------------------------------------------------------- ::: Koha/Email.pm @@ +118,5 @@ > $args->{to} = $params->{to}; > } > > + my @emails = split(',', $args->{to}); > + foreach my $email (@emails) { This isn't required.. Email::Address handles formatted lists of addresses already. See: https://metacpan.org/pod/Email::Address#parse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:12:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:12:46 +0000 Subject: [Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats In-Reply-To: <bug-33703-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33703-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33703-70-6TJ3mAIfoi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- So what appears to be happening is that the date is being parsed as if the expected separators are there. i.e: 05241964 is being read as: 05/41/64 The 41st day of May becomes the 10th of June -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:16:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:16:37 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-wW05IbiUsr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #112 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Working on fixes and will PQA with follow-ups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:19:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:19:10 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-QNyL1TdqUM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #25 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Gentle message from the RM: the QA script tells the atomicupdate doesn't have the right permissions. I'm pushing this already, but keep in mind for future submissions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:19:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:19:45 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-jqHUbYMpZb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:19:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:19:47 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-IGQhpncI2t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #26 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:19:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:19:50 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-xFOKUDJ5IF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:19:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:19:52 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-px1vtiUIvk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 --- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:19:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:19:53 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-gBvILiIIc3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:19:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:19:55 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-p1IkkWW08p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 --- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:27:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:27:20 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-ralvivRbs5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #124 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151026&action=edit Bug 8179: Receive multiple orders This patch implements the code to allow a patron to receive multiple orders at the same time in /cgi-bin/koha/acqui/orderreceive.pl page To test: 1. apply all patches 2. updatedatabase 3. Go to system preferences and allow AcqReceiveMultipleOrderLines 4. In acquisitions module, create a vendor if you don't have one and add 3 baskets.. one with create items on ordering, one with create items on receiving and finally one with create items when cataloguing 5. Fill baskets with orders (There should be at least 15 orders in total). There should be a mix of orders created by suggestions, others by subscriptions and others by neither of those methods. 6. Close all baskets and receive shipment. CHECK => in /cgi-bin/koha/acqui/parcel.pl page, in top table there is a column with checkboxes, and a button that says "Receive selected" 7. If all orders from all baskets are shown in the table, set the rows per page to 10, so table has more than one page 8. Check some of the checkboxes CHECK => "Receive selected" button shows how many rows are selected 9. Go to the next page and select some more rows CHECK => Changing page does not modify how many rows where selected 10. Go back to previous page CHECK => Previously selected rows are still selected 11. Reload the page to deselect all rows 12. Select only one row and click on "Receive selected" button CHECK => the page /cgi-bin/koha/acqui/orderreceive.pl behaves just the same as if the "receive" link in the selected row would have been clicked. 13. Click on cancel to go back to parcel.pl page 14. Select all rows (even the ones from the next page of the table) and click on "Receive selected" CHECH => In orderreceive.pl page there is a table with all selected rows 15. Ensure table has more than one page, as in step 7 16. Click on the "edit" link in the last row of the current page CHECK => A modal window is displayed with 4 tabs within: Info, Accounting, Receipt history and Items CHECK => Modal has 4 buttons at the bottom, 'Previous' to go to previos order, 'Cancel' to close the modal without keeping modifications, 'Save' to close modal keeping modifications and 'Next' to go to the next order CHECK => Even that we are at the end of the current page, 'Next' button is still available 17. Click on 'Next' button CHECK => The table behind the modal now displays the next page, and the modal was not closed 18. Click on 'Previous' CHECK => The table behind the modal went back to the first page, and the modal was not closed 19. Click on 'Previous' button till you reach the first row of the first page CHECK => Only when you reach the first row of the first page 'Previous' button gets disabled 20. Click on 'Next' button till you reach the last row of the last page CHECK => Only when you reach the last button of the last page 'Next' button gets disabled 21. Check that behaviour for the different types of order are still the same a. For orders that where created through suggestion, check that the suggestion info is present in Info tab. If when suggestion was accepted you set a reason, a dropdown to change the reason shoul display also. b. For orders that where created through subscriptions, check that the Items tab is disabled, and the Receipt history is enabled. On accounting tab you should be able to change quantity ordered. If there were less items received than ordered, the next time you receive this order the child order generated from this one shoul appear in receipt history. c. For orders that don't come from subscription and creates there items on ordering, Receipt history should be disabled, and a table with prefilled items shold appear in the Items tab. You can edit them and the changes should appear in the item's row. d. For orders that don't come from subscription and creates there items on receiving, Receipt history should be disabled, and a form to create the items should appear in Items tab. When you add an item a table should appear. e. For orders that don't come from subscription and creates there ites on cataloguing, Receipt history and Items tabs should be disabled. f. Any changes made in quantity (received or ordered) or funds in the modal should be reflected in the table if you click save from the modal. 22. Once you've done all you checking and verifications click save 23. While saving a progress bar should appear 24. If no error was detected, you should be redirected back to parcel.pl page 25. If an error or warning was detected (like there is an order with 0 items to receive) the save button should be disabled and warnings are dispayed. 26. prove t/db_dependent/Koha/Acquisition/Fund.t t/db_dependent/Koha/Acquisitoin/Order.t t/db_dependent/Koha/Item.t Sponsored-by: Virginia Polytechnic Institute and State University Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:29:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:29:11 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-UU9lCKMsAU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:29:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:29:28 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-J0rxU9lNtc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:36:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:36:27 +0000 Subject: [Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking In-Reply-To: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33557-70-cJb43zh1uh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:36:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:36:33 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-PKHE5JS66A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:37:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:37:51 +0000 Subject: [Koha-bugs] [Bug 33715] Unable to find default code In-Reply-To: <bug-33715-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33715-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33715-70-ziufPzUtzf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33715 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Usually you will use OpacUserJS to overwrite the standard that is delivered with Koha. We are using SCSS and minimized CSS, you should not edit these, as they would be orverwritten by the next update or you'd have to constantly merge your changes and Koha's. This might help: https://wiki.koha-community.org/wiki/Koha_simple_theming_guide Please note: bugzilla is for filing bugs and enhancement requests. General questions should be directed at the mailing lists or IRC channel: https://koha-community.org/support/community-support/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:39:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:39:38 +0000 Subject: [Koha-bugs] [Bug 33715] Unable to find default code In-Reply-To: <bug-33715-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33715-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33715-70-3HrISWXdxw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33715 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |FIXED --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #1) > Usually you will use OpacUserJS to overwrite the standard that is delivered This should have been: OpacUserCSS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:54:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:54:13 +0000 Subject: [Koha-bugs] [Bug 17787] Hidden items included in count of search results In-Reply-To: <bug-17787-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17787-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17787-70-VWtOYi3Uk6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Noémie Labine <noemie.labine at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine at collecto.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 19:55:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 17:55:18 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-UQYl9cmrw9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Keywords| |rel_23_05_candidate Status|Passed QA |Patch doesn't apply --- Comment #36 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Please minor rebase required. Will be included in next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:05:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:05:48 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-h1YXb5uEic@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:22:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:22:42 +0000 Subject: [Koha-bugs] [Bug 31155] Document --since option in help of borrowers-force-messaging-defaults.pl In-Reply-To: <bug-31155-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31155-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31155-70-ifWgNgbpr5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31155 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Seems to be already well documented in the manual. I think I did it in the manual first before this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:26:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:26:13 +0000 Subject: [Koha-bugs] [Bug 33716] New: ILL - Allow for a disclaimer stage per request type Message-ID: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Bug ID: 33716 Summary: ILL - Allow for a disclaimer stage per request type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com CC: andrew.auld at ptfs-europe.com, katrin.fischer at bsz-bw.de, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com, tomascohen at gmail.com Created attachment 151027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151027&action=edit Workflow diagram This new feature should allow the specification of a new custom HTML message alongside a custom authorised values category to be presented to the user after the ILL request has been submitted, on both OPAC and Staff. This should also allow for different specifications for each request type, and a fallback disclaimer if the type of the new ILL request being created does not exist in the new system preference. Once the disclaimer is submitted, the selected value from authorised values category as well as a timestamp should be saved in the database. To implement this, a refactor of the current ILLCheckAvailability system preference is required to make sure this new feature works in harmony, as it's also an extra step the user must take after it has submitted the create request form, but before the request has been saved in the database. Please check the attached diagram. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:26:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:26:32 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-2yA0BfVbTF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #113 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151028&action=edit Bug 12532: (QA follow-up) Undo changes to Koha::Email The changes here aren't required (Email::Address already deals with lists of addresses internally) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:26:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:26:37 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-389ewKCn8S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #114 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151029&action=edit Bug 12532: (QA follow-up) Clean up notice_email_address Reduce some of the code duplication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:18 +0000 Subject: [Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table In-Reply-To: <bug-25503-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25503-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25503-70-BC7OL4ArNQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:20 +0000 Subject: [Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table In-Reply-To: <bug-25503-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25503-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25503-70-UM4rpjmC1m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503 --- Comment #25 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:22 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files and fix other related translation issues In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-9jkHTQ16uT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:24 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files and fix other related translation issues In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-ehKlKczR8q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #32 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:26 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28328-70-F5fDg8T6xT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:28 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28328-70-g5LrE1wDg0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 --- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:30 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-70HdQKlJ9Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:32 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-SFXPLYYcsf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #26 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:34 +0000 Subject: [Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates In-Reply-To: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31479-70-yefgTbad17@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:36 +0000 Subject: [Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates In-Reply-To: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31479-70-8wGebYSS09@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:38 +0000 Subject: [Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar In-Reply-To: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33064-70-DzjTSEu274@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:40 +0000 Subject: [Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar In-Reply-To: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33064-70-dp4U5hkcoV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:42 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-1DEPRutEWD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:42 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-C0pLzEZwRs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #115 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I'm not so sure that we're hooking this into the right place.. I'm wondering if it may be better placed in Koha::Email->create.. Needs a little thought.. I've stuck my QA follow-up's in and will switch back to SO to get some other QA opinions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:44 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-N0dqGjgGWf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #70 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:47 +0000 Subject: [Koha-bugs] [Bug 33403] Letters.t: Foreign key exception if you do not have a numberpattern with id=1 In-Reply-To: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33403-70-XXfZ2cOmPZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33403 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:48 +0000 Subject: [Koha-bugs] [Bug 33403] Letters.t: Foreign key exception if you do not have a numberpattern with id=1 In-Reply-To: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33403-70-o4kFRc52hm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33403 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:50 +0000 Subject: [Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking In-Reply-To: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33557-70-9bEOEFSiVg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:52 +0000 Subject: [Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking In-Reply-To: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33557-70-hxMkEQL2He@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:54 +0000 Subject: [Koha-bugs] [Bug 33684] Able to save patron with empty mandatory date fields In-Reply-To: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33684-70-1qj2Wf7x5p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33684 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:28:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:28:56 +0000 Subject: [Koha-bugs] [Bug 33684] Able to save patron with empty mandatory date fields In-Reply-To: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33684-70-BWfZqFfshG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33684 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:30:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:30:29 +0000 Subject: [Koha-bugs] [Bug 19942] Children's search interface In-Reply-To: <bug-19942-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19942-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19942-70-N64kxHCaBg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19942 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:33:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:33:08 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files and fix other related translation issues In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-RgzbKdjy4E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice one everyone, thanks for the further follow-up Katrin :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:39:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:39:13 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-r6EMLlzte5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #116 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Sorry, I also meant to say I think the guarantor email should go in the cc field rather than to field (unless the to field is empty in which case just put guarantor in to). This complicates things a little but I feel it's the right behaviour -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:43:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:43:25 +0000 Subject: [Koha-bugs] [Bug 28556] Make guarantor information available in notices In-Reply-To: <bug-28556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28556-70-v69te3LgEv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- You realise you can already use ALL object methods in TT based notices right? So anywhere you have a patron in a notice you can use the relations to get at the guarantors. I'm not sure we need to add the boiler code here to support this.. we're trying to clean up these scripts and then simplify/clarify the pickers in the medium to long term. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:50:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:50:49 +0000 Subject: [Koha-bugs] [Bug 33717] New: Typo in search_for_data_inconsistencies.pl Message-ID: <bug-33717-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33717 Bug ID: 33717 Summary: Typo in search_for_data_inconsistencies.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz If a biblio has no title, the script output reads == Biblio without title 245$a == * Biblio with biblionumber=768 does not have title defined => Edit these biblio records to defined a title "defined" in the last sentence should be "define" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:54:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:54:51 +0000 Subject: [Koha-bugs] [Bug 28556] Make guarantor information available in notices In-Reply-To: <bug-28556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28556-70-Dck6RHOvPM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- [% FOREACH guarantor_relation IN patron.guarantor_relatuonships %] [% SET guarantor = guarantor_relation.guarantor %] [% guarantor.firstname | html %] [% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:56:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:56:46 +0000 Subject: [Koha-bugs] [Bug 33717] Typo in search_for_data_inconsistencies.pl In-Reply-To: <bug-33717-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33717-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33717-70-drvUrEIPgy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33717 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:56:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:56:48 +0000 Subject: [Koha-bugs] [Bug 33717] Typo in search_for_data_inconsistencies.pl In-Reply-To: <bug-33717-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33717-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33717-70-03HNKpWqgs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33717 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Created attachment 151030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151030&action=edit Bug 33717: Typo in search_for_data_inconsistencies.pl This patch corrects a typo in the output of search_for_data_inconsistencies.pl when a bibliographic record has no title. The patch also replaces biblio to bibliographic record in the same sentence for terminology consistency. To test: - Have a bibliographic record without a title - Run misc/maintenance/search_for_data_inconsistencies.pl - Read output, make sure the sentence is correct -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:57:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:57:50 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-Qv06Bx4Via@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:57:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:57:52 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-146KCIeaAW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #1 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151031&action=edit Bug 33716: New ILLModuleDisclaimerByType sys pref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:57:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:57:55 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-JtVkkiPB1W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #2 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151032&action=edit Bug 33716: Preparation New Illrequest::Workflow superclass New Illrequest::Workflow::TypeDisclaimer Moved Illrequest::Availability to Illrequest::Workflow::Availability Removed check for backend capability "should_display_availability" Instead, the check is now done for "can_create_request" backend capability This serves the purpose of having the backend let core know if it can create the request or not. In other words, if the create form has been submitted or not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:57:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:57:57 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-QkC5h2Op6T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #3 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151033&action=edit Bug 33716: ILL Type Disclaimer - Staff Update the way Availability is handled Add the new type disclaimer workflow operation after Availability -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:58:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:58:00 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-hZMBhoScLD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #4 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151034&action=edit Bug 33716: ILL Type Disclaimer - OPAC Update the way Availability is handled Add the new type disclaimer workflow operation after Availability -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 20:58:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 18:58:03 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-vymDg5xZdj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #5 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151035&action=edit Bug 33716: Tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 10 21:23:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 19:23:27 +0000 Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl In-Reply-To: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26311-70-EzeRJ9mA5U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose at inlibr | |o.com Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/680 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 21:28:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 19:28:26 +0000 Subject: [Koha-bugs] [Bug 13529] Easy analyticals and UseControl number should be able to coexist In-Reply-To: <bug-13529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13529-70-hmihrp7i1s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13529 --- Comment #1 from Lauren Denny <lauren_denny at sil.org> --- Could someone explain why the two system preferences 'UseControlNumber' & 'EasyAnalytics' cannot co-exist? We used to have both turned on until a recent upgrade and now only use 'UseControlNumber' so that we can seperate our links to the corresponding relationship instead of combining all the options into the 773 field. We are needing features from both system preferences. The flexibility of the 'UseControlNumber' allows koha to use seperate linking fields based on the relationship between records/items instead of putting all the links in the 773 which is only for the parent/child relationship. And how EasyAnalytics allows koha display the item record on both records for those linked together. Here are functions that are utilized by the EasyAnalytics that I would find helpful with some ideas on how to make it work. (I am not a programer so I don't totally know if they would work but are ideas from a librarian's point of view.) 1 - Have a drop-down menu that allows you to choose the linking field you want the information to koha auto-populate subfields from based on the bibilonumber instead of the barcode. The field selected where to put the inforamtion to pulled based on system preference or framework selection. 2- System preference that allows you to control which fields auto-populate with the selected field. 245$ab title to $t, 1xx$a author to $a, 250$a edition to $b, 001 control number (biblionumber) to $w , 260/264 publishing details to $d, 020 ISBN to $x, 022 ISSN to $z Another idea would be to have a checkbox in the framework that people select that tells koha what information to pull into the field. 3- Have the item record appear on both the parent & child records This would be helpful for records using the 773 (parent & child relationship) where one item record is 'shared' with both record. It is physcially on the child record but would be helpful to patrons to have a list of all the items associated with the parent record. An idea would be, if the item number or barcode is found in the 773 field, the item appears on record with the link. If these subfields are empty the item will not display on the linked record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 21:34:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 19:34:10 +0000 Subject: [Koha-bugs] [Bug 33053] Tables item_groups and recalls have a biblio_id column with a default of 0 In-Reply-To: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33053-70-voGCYGmke5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33053 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Keywords| |additional_work_needed --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- This patchset highlighted an issue, see: I commented like this: $ git diff diff --git a/t/db_dependent/api/v1/item_groups.t b/t/db_dependent/api/v1/item_groups.t index 3506eae582d..8a823d121ec 100755 --- a/t/db_dependent/api/v1/item_groups.t +++ b/t/db_dependent/api/v1/item_groups.t @@ -112,11 +112,11 @@ subtest 'add() tests' => sub { # Invalid biblio id { # hide useless warnings - local *STDERR; - open STDERR, '>', '/dev/null'; + #local *STDERR; + #open STDERR, '>', '/dev/null'; $t->post_ok( "//$auth_userid:$password@/api/v1/biblios/XXX/item_groups" => json => $item_group ) ->status_is( 404 ); - close STDERR; + #close STDERR; } $schema->storage->txn_rollback; And then: $ prove t/db_dependent/api/v1/item_groups.t t/db_dependent/api/v1/item_groups.t .. 1/5 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'biblio_id' cannot be null at /kohadevbox/koha/Koha/Object.pm line 170 # Failed test '404 Not Found' # at t/db_dependent/api/v1/item_groups.t line 117. # got: '500' # expected: '404' # Looks like you failed 1 test of 6. # Failed test 'add() tests' # at t/db_dependent/api/v1/item_groups.t line 123. Please provide a fix! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 22:18:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 20:18:32 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-4TGwRwTNmi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 22:33:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 20:33:34 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-aG809o0vfU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/681 Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 23:05:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 21:05:02 +0000 Subject: [Koha-bugs] [Bug 27638] Allow exclusions from automatic cancellation of expired holds via cron In-Reply-To: <bug-27638-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27638-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27638-70-EnAkpTzntE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27638 hebah at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah at bywatersolutions.com --- Comment #1 from hebah at bywatersolutions.com --- I do like this idea, especially if those parameters could include found status, so that libraries that prefer to cancel holds manually could still cancel expired but unfilled holds. (And if that's too far afield from initial bug idea, I'm happy to file a separate one!) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 23:23:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 21:23:49 +0000 Subject: [Koha-bugs] [Bug 27638] Allow exclusions from automatic cancellation of expired holds via cron In-Reply-To: <bug-27638-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27638-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27638-70-0PAoF6Bm8l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27638 Katie Bliss <kebliss at dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 10 23:24:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 21:24:57 +0000 Subject: [Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC In-Reply-To: <bug-31051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31051-70-wrzGwcv32J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/681 CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 01:29:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 23:29:00 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-099sUeYNuW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 --- Comment #3 from David Cook <dcook at prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #1) > This is a recommended openid-connect parameter [1] and OAuth2 integrations > seem to require it [2], but I'm not sure if it should be enforced. Basically > because I don't know all the IdPs around. It looks like OAuth2 also only recommends it: https://www.rfc-editor.org/rfc/rfc6749#section-4.1.1 However, the specs do say that the "state" parameter is required in the Authorization Response if it was included in the Authorization Request: https://www.rfc-editor.org/rfc/rfc6749#section-4.1.2 I suspect that most IdPs should support "state" if they want to be spec compliant, although I suppose there's no guarantee. I've certainly dealt with 1 non-compliant IdP in the past, although that was nearly 10 years ago now. If we are worried, I think we could make using "state" optional in terms of whether or not to send it, but... I think it should be all right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 01:32:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 23:32:00 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-mktpP5WClu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 --- Comment #10 from David Cook <dcook at prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #9) > They look great. I was really tired last night when I submitted. Thanks! No worries. How do we want to do the sign offs for these? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 01:32:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 23:32:54 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-wJIXAkGO90@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33708 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 01:32:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 23:32:54 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-ttSQ8HLRo8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33675 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 [Bug 33675] Add CSRF protection to OAuth/OIDC authentication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 01:36:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 23:36:32 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-AqR89A2ixV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- Hmm I got an error the first time I tried it and then when I clicked the "Login" button a second time it worked. The error might be residue from previous work I suppose. Going to see if I can reproduce it... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 01:38:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 23:38:50 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-aaOT38GyES@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 --- Comment #5 from David Cook <dcook at prosentient.com.au> --- (In reply to David Cook from comment #4) > Hmm I got an error the first time I tried it and then when I clicked the > "Login" button a second time it worked. The error might be residue from > previous work I suppose. Going to see if I can reproduce it... Can't reproduce so yeah probably not a problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 01:39:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 23:39:48 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-aChuEqdBPD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 01:39:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 23:39:51 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-vFuPDFNpRv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151019|0 |1 is obsolete| | --- Comment #6 from David Cook <dcook at prosentient.com.au> --- Created attachment 151036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151036&action=edit Bug 33675: Add CSRF protection to OAuth/OIDC authentication This patch makes the OAuth/OIDC client pass a `state` parameter with a CSRF protection token, to be validated back when the flow returns to Koha. Ideally, the Mojolicious::Plugin::OAuth2 library should deal with this implicitly, probably making use of JWT. But as of now, this is the best way to implement it. To test: 1. Have a working SSO solution (ktd --sso) 2. Click to login using SSO => SUCCESS: Notice a 'state' parameter on the URL, looks like a random thing 3. When you login, no error is reported Signed-off-by: David Cook <dcook at prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 01:40:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 23:40:45 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-yt9jas6efo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150905|0 |1 is obsolete| | --- Comment #11 from David Cook <dcook at prosentient.com.au> --- Created attachment 151037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151037&action=edit Bug 33708: Make staff interface login not require public API (OAuth/OIDC) This patch makes the URL for staff login not point to the `/public` namespace. The behavior is not changed for the protocol, but as `/public` requires several settings to be available, it effectively requires to enable the OPAC, the public API, etc. This patch diferentiates both to solve the problem. I've tested following the Wiki instructions to set keycloak [1] using the *--sso* switch for `ktd` as well [2]. It is important to set the following URLs as allowed redirect in order to replicate the issue and verify the fix: http://localhost:8080/api/v1/public/oauth/login/test/opac http://localhost:8081/api/v1/oauth/login/test/staff To test: 1. Login into the staff interface using the SSO link: => FAIL: Results in a 'Bad redirect URL' error 2. Apply this patch and repeat 1 => SUCCESS: You get a permission denied error or you just login, depending on your setup. [1] https://wiki.koha-community.org/wiki/Testing_SSO [2] ktd --sso up -d Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Cook <dcook at prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 01:40:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 23:40:48 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-wSybFMsdSA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150918|0 |1 is obsolete| | --- Comment #12 from David Cook <dcook at prosentient.com.au> --- Created attachment 151038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151038&action=edit Bug 33708: Provide non-public endpoint for OAuth/OIDC for staff interface This change fixes the definition for the non-public endpoint for the OAuth/OIDC implementation. It also uses the non-public endpoint for the staff interface UI. Signed-off-by: David Cook <dcook at prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 01:40:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 23:40:51 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-uPhA5E66Lt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150919|0 |1 is obsolete| | --- Comment #13 from David Cook <dcook at prosentient.com.au> --- Created attachment 151039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151039&action=edit Bug 33708: Allow anonymous access to OAuth endpoints Users needs anonymous access to OAuth endpoints so that they can login, and then use authenticated access for other endpoints. Signed-off-by: David Cook <dcook at prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 01:41:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 23:41:30 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-CoNegKwMjs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 --- Comment #14 from David Cook <dcook at prosentient.com.au> --- (In reply to David Cook from comment #10) > (In reply to Tomás Cohen Arazi from comment #9) > > They look great. I was really tired last night when I submitted. Thanks! > > No worries. How do we want to do the sign offs for these? I've added my sign off to the patches. If you want to do the same for my last two, then I think we could move this to "Signed Off"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 01:44:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 23:44:50 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-waBWrV1z0R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #58 from David Cook <dcook at prosentient.com.au> --- (In reply to Mengu Yazicioglu from comment #57) > When we try to upgrade to 22.11.05, post-installation database update part > gives error about ERM tables related with this bug. > > In order to bypass the post-installation steps, we need manually change some > tables' row format status, otherwise we can't go forward. What version of MySQL are you using and on what OS? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 01:52:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 23:52:13 +0000 Subject: [Koha-bugs] [Bug 33646] "Cataloging search" missing important data for not for loan items In-Reply-To: <bug-33646-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33646-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33646-70-RM8flFUM0Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646 --- Comment #2 from David Cook <dcook at prosentient.com.au> --- (In reply to Jonathan Druart from comment #1) > Which display do you suggest? The "Search results" display is the better display for sure. It looks like ./koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt defines a BLOCK that could be re-used on ./koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt if it were refactored and moved into an include... Although that's just in terms of the information provided. I'm not sure it would work stylistically... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 01:57:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 23:57:24 +0000 Subject: [Koha-bugs] [Bug 19942] Children's search interface In-Reply-To: <bug-19942-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19942-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19942-70-alk0v4quwE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19942 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 01:58:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 May 2023 23:58:27 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33462-70-vqqgPSadKE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 02:17:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 00:17:45 +0000 Subject: [Koha-bugs] [Bug 33655] z39.50 search no longer shows search in progress In-Reply-To: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33655-70-AIKN2BaJfb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 02:17:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 00:17:47 +0000 Subject: [Koha-bugs] [Bug 33655] z39.50 search no longer shows search in progress In-Reply-To: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33655-70-LrtnGJhPGt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150964|0 |1 is obsolete| | --- Comment #5 from Phil Ringnalda <phil at chetcolibrary.org> --- Created attachment 151040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151040&action=edit Bug 33655: z39.50 search no longer shows search in progress This patch adds an id to z39.50 search interface submit buttons so that the JavaScript event for changing the cursor can be linked to that instead of the obsolete class. The patch also adds code copied from Bug 33233 in order to make the "waiting" cursor revert to the default if the user uses the back button to return to the search form. To test, apply the patch and go to Cataloging -> New from Z39.50 - Fill in a search term and click the submit button - Your cursor should change to a "waiting" cursor while the search is performed, before you're redirected to the results. - From the results page, clicking the back button (or right-clicking the page and choosing "Back") should return you to the search form and your cursor should be a standard pointer. Perform the same test from: - Acquisitions -> Vendor -> Basket -> Add to basket -> From an external source - Authorities -> New from Z39.50/SRU Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 04:58:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 02:58:40 +0000 Subject: [Koha-bugs] [Bug 33701] Catalogue detail page no longer shows all tab data when printing In-Reply-To: <bug-33701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33701-70-YMKiaDK3G0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33701 --- Comment #5 from David Cook <dcook at prosentient.com.au> --- For now, I'm just going to work around this using the syspref IntranetUserCSS: @media print { /* print-visible */ #bibliodetails .tab-pane { display: block !important; height: auto !important; visibility: visible !important; overflow: visible !important; } } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 05:19:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 03:19:45 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-92vVvL6jH1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 05:19:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 03:19:48 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-0XgvTwPjP1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151024|0 |1 is obsolete| | --- Comment #7 from David Cook <dcook at prosentient.com.au> --- Created attachment 151041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151041&action=edit Bug 33223: Replace 'first_valid' with 'notice' for email addresses This patch replaces the uses of first_valid_email_address with notice_email_address in waiting_holds, transferstoreceive, clubs and sendbasket so that we take EmailFieldPrimary into account for these notices too. Signed-off-by: David Cook <dcook at prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 05:19:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 03:19:51 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-W8HANS5wAu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151025|0 |1 is obsolete| | --- Comment #8 from David Cook <dcook at prosentient.com.au> --- Created attachment 151042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151042&action=edit Bug 33223: Fix sendshelf Two new occurences of first_valid crept in, this patch corrects those to also use notice_ Signed-off-by: David Cook <dcook at prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 05:20:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 03:20:39 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-GQoBAKYyyn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 --- Comment #9 from David Cook <dcook at prosentient.com.au> --- Patches apply and change looks good upon review. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 06:30:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 04:30:44 +0000 Subject: [Koha-bugs] [Bug 24400] REST API: Checkout In-Reply-To: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24400-70-mOp04oEk0g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24400 --- Comment #5 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Created attachment 151043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151043&action=edit Bug 24400: Unit tests for all responses of checkout API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 06:43:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 04:43:39 +0000 Subject: [Koha-bugs] [Bug 24400] REST API: Checkout In-Reply-To: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24400-70-GQ3iIBafG5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24400 Danyon Sewell <danyonsewell at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150920|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 06:43:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 04:43:49 +0000 Subject: [Koha-bugs] [Bug 24400] REST API: Checkout In-Reply-To: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24400-70-ymvIuMqLvD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24400 Danyon Sewell <danyonsewell at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150921|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 06:43:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 04:43:58 +0000 Subject: [Koha-bugs] [Bug 24400] REST API: Checkout In-Reply-To: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24400-70-XVdGYoxRjo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24400 Danyon Sewell <danyonsewell at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151043|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 06:44:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 04:44:34 +0000 Subject: [Koha-bugs] [Bug 24400] REST API: Checkout In-Reply-To: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24400-70-IzQmblCRpT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24400 --- Comment #6 from Danyon Sewell <danyonsewell at catalyst.net.nz> --- Created attachment 151044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151044&action=edit Bug 24400: Rest API for checkout Feature to provide API endpoints for checking out items. To test: 1) Apply this patch 2) Run: $ ktd --shell $ prove t/db_dependent/api/v1/items.t => SUCCESS: Tests pass! 3. Play with item checkout using a REST tool like Postman => SUCCESS: All works as expected 4. Sign off :-D Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 06:44:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 04:44:56 +0000 Subject: [Koha-bugs] [Bug 24400] REST API: Checkout In-Reply-To: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24400-70-OcRLybGmOr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24400 Danyon Sewell <danyonsewell at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 07:31:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 05:31:04 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-UQQ3Z5VSqQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #117 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #115) > I'm not so sure that we're hooking this into the right place.. I'm wondering > if it may be better placed in Koha::Email->create.. I would prefer to keep ->create clean and move this specific guarantor action a level higher. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 07:57:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 05:57:18 +0000 Subject: [Koha-bugs] [Bug 24400] REST API: Checkout In-Reply-To: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24400-70-us2f4qyiek@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24400 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 08:07:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 06:07:11 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-DfqtSaeJTd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- I am rebasing now bug 33608 on top of this one. We have a failure after this patch set on Koha/Pseudonymization.t Will add a follow-up here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 08:13:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 06:13:56 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-Td3QBbq5p5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Hmm. It may come from another pushed patch set.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 08:35:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 06:35:14 +0000 Subject: [Koha-bugs] [Bug 33655] z39.50 search no longer shows search in progress In-Reply-To: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33655-70-6ggq8HuNf9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 08:35:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 06:35:17 +0000 Subject: [Koha-bugs] [Bug 33655] z39.50 search no longer shows search in progress In-Reply-To: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33655-70-3QAWVvtCB8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151040|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151045&action=edit Bug 33655: z39.50 search no longer shows search in progress This patch adds an id to z39.50 search interface submit buttons so that the JavaScript event for changing the cursor can be linked to that instead of the obsolete class. The patch also adds code copied from Bug 33233 in order to make the "waiting" cursor revert to the default if the user uses the back button to return to the search form. To test, apply the patch and go to Cataloging -> New from Z39.50 - Fill in a search term and click the submit button - Your cursor should change to a "waiting" cursor while the search is performed, before you're redirected to the results. - From the results page, clicking the back button (or right-clicking the page and choosing "Back") should return you to the search form and your cursor should be a standard pointer. Perform the same test from: - Acquisitions -> Vendor -> Basket -> Add to basket -> From an external source - Authorities -> New from Z39.50/SRU Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 08:47:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 06:47:09 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-6kOGOoSHpV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #118 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I agree Marcel.. It was late last night. So.. In short, I'd like some explanations from the original author as to why they picked the changes they did.. I still don't understand a number of them. I think hooking into _send_message_by_email in C4::Letters is starting to feel like it might be the right place... but setting a `cc` rather than additional `to` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 08:47:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 06:47:11 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-b0XFCUcrLO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #28) > Hmm. It may come from another pushed patch set.. It must be the authority relinking stuff that was pushed too. That makes sample_biblio crash in Pseudonymization.t. So not caused here definitely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:12:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:12:32 +0000 Subject: [Koha-bugs] [Bug 33718] New: _new_Zconn may crash on missing context Message-ID: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 Bug ID: 33718 Summary: _new_Zconn may crash on missing context Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Related to enabling pref LinkerRelink and friends, and running build_sample_biblio in a test like I found with Koha/Pseudonymization.t. See test plan for enabling prefs on report 33277 Debugging brought me to this line: my $host = _common_config($server, 'listen')->{content}; The crash: {UNKNOWN}: Can't use string ("authorities") as a HASH ref while "strict refs" in use at /usr/share/koha/C4/Context.pm line 590. at /usr/share/koha/C4/Biblio.pm line 304 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:12:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:12:54 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn may crash on missing context In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-2tlfvZRCAD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:13:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:13:12 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn may crash on missing context In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-R0h4g3pO98@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33277 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:13:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:13:12 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-mdrsmZoLjw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33718 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:14:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:14:03 +0000 Subject: [Koha-bugs] [Bug 33303] Performance issues/timeouts in item search In-Reply-To: <bug-33303-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33303-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33303-70-YEmMXOjVLG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33303 mathieu saby <mathsabypro at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:19:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:19:08 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-tH8wPS5gBZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28556 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:19:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:19:08 +0000 Subject: [Koha-bugs] [Bug 28556] Make guarantor information available in notices In-Reply-To: <bug-28556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28556-70-yR4rAnFNI3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12532 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:27:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:27:03 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-dMKJ7kwDbR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #125 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- 1. - b_sel => ( $budget->{budget_id} == $order->budget_id ) ? 1 : 0, + # b_sel => ( $budget->{budget_id} == $order->budget_id ) ? 1 : 0, Then remove ;) 2. + creator: + type: + - object + - "null" + description: Patron that created the order We could tell here we expect an object representing a patron 3. + - items.home_branch + - items.holding_branch + - items.itemtype Shouldn't they use the "fixed names"? home_library, item_type? It means to add more methods, and tests, but once it's in the spec it will be hard to modify. Not blocker as I guess we are doing that in other places. 4. https://snipboard.io/SvHwAn.jpg The "Change currency" checkbox is not aligned properly And it's actually not working: * edit * Set actual cost, check "change currency", select a currency, save * edit again => Values are not saved, you are actually breaking bug 25655. Also I have seen "NaN" generated in actual cost but not sure when/how. And finally, values are not saved in the DB (invoice_currency, invoice_unitprice). 5. Partial receive does not seem to work I ordered 3, received 1, receiving again: "Receiving 0 out of 2" => OK Click edit => There are 3 items in the items table 6. "Date received:" does not have flatpickr applied 7. Fund is not marked "required" like before 8. We lost the "show active" checkbox next to the fund list 9. There are missing spaces after numbers "Retail price: 0.00(adjusted for USD, tax exclusive)" 10. + <th><!--input type="checkbox" id="selectAll"/--></th> Do we want that? 11. JS code in parcel.tt use 2 spaces indentation instead of 4 12. I noticed 2 parallel request to parcel.pl?invoiceid=1 at the end of the process, and one of them is aborted. This is what is in the console: https://snipboard.io/IKwoVP.jpg 13. comment 111 and comment 112 still need an answer. I don't understand how dataTables.select.min.js, select.dataTables.min.css is useful here. Is that the row.select() and row.deselect() statements in parcel.tt? If so, what are they doing? I removed them and didn't see any issues. 14. There are several parts of the JS code in orderreceive.tt that are commented, if we don't need them we should remove them. 15. I think we should widen the modal. The item form is not displayed nicely https://snipboard.io/VIKAgY.jpg 16: not sure it's a blocker: When you select some orders, the table on the order receive page has "Showing 1 to 1 of 1 entries (filtered from 3 total entries)" But there is no way to display them all. I understand why and what it implies, just noting. 17. Another "just noting": the code (introduced by bug 20212 I think) related to biblio.suggestions.suggester is bad and should have been simplified before we did all this. I submitted a patch yesterday to remove GetSuggestionInfoFromBiblionumber, it's on bug 28844. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:28:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:28:58 +0000 Subject: [Koha-bugs] [Bug 28556] Make guarantor information available in notices In-Reply-To: <bug-28556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28556-70-h3oJqve1FI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Improving the notice creation tools and migrating all notices to TT so we can deprecate the older custom syntaxes was on the roadmaps for at least three cycles, but it's not a one person job and didn't get the uptake from people... I'd rather see effort shared and pushed in that direction that adding more old style code and hacks on top like this I'm afraid. This gets a downvote from me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:32:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:32:23 +0000 Subject: [Koha-bugs] [Bug 24400] REST API: Checkout In-Reply-To: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24400-70-AOVXJf6K78@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24400 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 23336 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:32:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:32:23 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-2jAuCyfKDM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula at hypernova.fi --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** Bug 24400 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:32:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:32:54 +0000 Subject: [Koha-bugs] [Bug 24609] Add routes for updating checkouts In-Reply-To: <bug-24609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24609-70-cUyFUiADIF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23336 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:32:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:32:54 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-iGbz1KZdxm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24609 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:33:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:33:25 +0000 Subject: [Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16826-70-EMEOwbU80r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23336 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:33:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:33:25 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-ICs7csHIbM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16826 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:34:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:34:43 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-g2QQu7YHMB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150087|0 |1 is obsolete| | Attachment #150088|0 |1 is obsolete| | Attachment #150089|0 |1 is obsolete| | Attachment #150090|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151046&action=edit Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:34:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:34:46 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-u0KoBmBqbQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #53 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151047&action=edit Bug 27634: Update PatronSelfRegistrationBorrowerUnwantedField's value Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:34:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:34:49 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-KmN5xSAoTh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #54 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151048&action=edit Bug 27634: Hide "Register here" links Make sure the pref is filled with a valid patron's category to display the "register" link Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:34:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:34:52 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-0UfvMU0zNF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #55 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151049&action=edit Bug 27634: (QA follow-up) Add punctuation to message on About page This just adds some missing commas and turns a pref into preference in the messages displayed on the system information tab. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:35:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:35:03 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-ivGYkC5HSU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #56 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Trivial rebase (about.tt) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:38:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:38:58 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-iROuNaVwSx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #38 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- FAIL installer/data/mysql/atomicupdate/bug_29822.pl FAIL file permissions File must have the exec flag OK installer/data/mysql/mandatory/sysprefs.sql OK koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc OK koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc FAIL koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc FAIL forbidden patterns forbidden pattern: Do not use line breaks inside template tags (bug 18675) (line 90) FAIL valid_template parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc line 90-91: unexpected token ([) [% standard.replace('|', ',') [% SET full_address = 'streetnumber,streettype,address,address2,city,state,zipcode,country' %] OK koha-tmpl/intranet-tmpl/prog/js/patron-autocomplete.js OK t/db_dependent/selenium/patrons_search.t Processing additional checks OK! Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/selenium/patrons_search.t KO! # Failed test 'All standard fields are searchable if DefaultPatronSearchFields not set. middle_name is there.' # at /kohadevbox/koha/t/db_dependent/selenium/patrons_search.t line 163. # got: '0' # expected: '14' # Looks like you planned 25 tests but ran 1. # Looks like you failed 1 test of 1 run. # Failed test 'Search patrons' # at /kohadevbox/koha/t/db_dependent/selenium/patrons_search.t line 341. Can't call method "get_value" on an undefined value at /kohadevbox/koha/t/db_dependent/selenium/patrons_search.t line 164. # Looks like your test exited with 255 just after 1. /kohadevbox/koha/t/db_dependent/selenium/patrons_search.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/1 subtests Test Summary Report------------------- /kohadevbox/koha/t/db_dependent/selenium/patrons_search.t (Wstat: 65280 Tests: 1 Failed: 1) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:46:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:46:04 +0000 Subject: [Koha-bugs] [Bug 33707] News vs Quote of the day styling on staff interface main page In-Reply-To: <bug-33707-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33707-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33707-70-8Mbh2BIDKQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33707 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 09:46:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 07:46:07 +0000 Subject: [Koha-bugs] [Bug 33707] News vs Quote of the day styling on staff interface main page In-Reply-To: <bug-33707-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33707-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33707-70-EYAV9trdOx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33707 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150999|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151050&action=edit Bug 33707: News vs Quote of the day styling on staff interface main page This patch makes minor adjustments to the global and staff home page CSS so that the display of news and quote-of-the-day are more consistent. To test, apply the patch and rebuild the staff interface CSS. - If necessary, add at least one news item (Tools -> News -> New entry) and at least one quote (Tools -> Quote editor -> New quote). - View the staff interface home page to confirm that the style of the news area and the quotes is consistent. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:31:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 08:31:50 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-VunZF3mksB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150840|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151051&action=edit Bug 33608: Add two new circulation types in Statistics module These are: item_lost and item_found. Speak for themself. Test plan: Run t/db_dependent/Stats.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:31:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 08:31:53 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-FkhUV8DjzZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150841|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151052&action=edit Bug 33608: Add UpdateStats to item->store Test plan: Run t/db_dependent/Koha/Item.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:31:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 08:31:55 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-4iHdKpm4pI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150842|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151053&action=edit Bug 33608: Rearranging Stats.t, removing useless t version Subtest, modules, license. The t/Stats.t is as good as empty, can be removed. Test plan: Run t/db_dependent/Stats.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:31:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 08:31:57 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-YmD5Kf7mAk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150843|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151054&action=edit Bug 33608: Correct indentation in Stats.t Test plan: Run t/db_dependent/Stats.t Run git diff -w HEAD~1.. t/db_dependent/Stats.t, proving that we only did whitespace changes. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:32:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 08:32:00 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-Sm0KSd36IG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150844|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151055&action=edit Bug 33608: Redirect UpdateStats to Koha namespace Moving code to Koha::Statistic->new and ->insert. Polishing code a bit further in next patch. Test plan: Run t/db_dependent/Stats.t Run t/db_dependent/Koha/Statistics.t Run t/db_dependent/Koha/Pseudonymization.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:32:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 08:32:02 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-37VH4OoIOq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150845|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151056&action=edit Bug 33608: Polish Koha::Statistic further Adding exceptions, removing croaks. No exception in new for unknown hash keys, store will catch that. Prepare switching amount parameter to value (db column name). Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:32:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 08:32:04 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-GD9G5HNddt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150846|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151057&action=edit Bug 33608: Move older Stats tests to Koha/Statistics.t Test plan: Run t/db_dependent/Koha/Statistics.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:42:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 08:42:24 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-Efu0W2Socv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 --- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Rebased on top of 30928. More laborious than hoped for ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:42:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 08:42:45 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-aXoLVADvUr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149890|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151058&action=edit Bug 29822: Update 'DefaultPatronSearchFields' to a select list This patch updates the `DefaultPatronSearchFields` preference from freetext expecting a comma delimited list of borrower fields to a multi-select with a sensible list of fields available. I opted to not use the Modal approach with all borrower fields listed as I felt it made more sense to only expose a more limited subset of the fields available to us. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:42:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 08:42:48 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-4fNou1v08A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149891|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151059&action=edit Bug 29822: Use the modal As requested by Katrin.. switch to the modal and expose all fields from the borrowers database table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:42:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 08:42:51 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-Vf0GD0pGiW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149892|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151060&action=edit Bug 29822: Update code to reference by pipe Moving to modalselect also has the effect of moving from comma delimited to pipe delimitation for the preference contents tmp -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:42:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 08:42:54 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-tLu6DYxngu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149893|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151061&action=edit Bug 29822: Database and Preference description updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:42:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 08:42:57 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-patBpYb1CY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149894|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151062&action=edit Bug 29822: Update unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:44:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 08:44:31 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-YKwS2PktFu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #44 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Rebased.. seems we lost a closing brace.. should be working now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:44:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 08:44:47 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-qOZ6noI6vd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #29) > (In reply to Marcel de Rooy from comment #28) > > Hmm. It may come from another pushed patch set.. > > It must be the authority relinking stuff that was pushed too. That makes > sample_biblio crash in Pseudonymization.t. > So not caused here definitely. Opened bug 33718 for these issues. Disabling AutoLinkBiblios helps to get it passing again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:45:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 08:45:52 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-FgjZtpl4vr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #71 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Opened bug 33718 for issues with tests when you have the prefs set like in the test plan here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 10:46:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 08:46:14 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-119xfWnndS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- First time trying this, and I failed to test. I am getting """ test We are sorry... Invalid parameter: redirect_uri """ After I clicked "login with test" The generated URL is http://sso:8082/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=kohaoidc&redirect_uri=http%3A%2F%2Fkohadev-intra.myDNSname.org%3A8081%2Fapi%2Fv1%2Foauth%2Flogin%2Ftest%2Fstaff&scope=openid+email&state=873f7839ab38384730c0635c3b260564297de884%2Ca443349be07f4216b95089525be35eeb96b74452%2C1683794690 I guess I made an error in the config somewhere but I have double-checked everything :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 11:00:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 09:00:24 +0000 Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30556-70-S7U0Sru14B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #44 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- 1. + return { status => '' } unless $borrowernumber; + return 0 unless $patron; No, you can raise an exception if you want. 2. There is no explanation on the logic changes. Can you detail? 3. Code is duplicated in controller scripts, that feels wrong. We certainly want it in a module, covered by tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 11:00:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 09:00:35 +0000 Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30556-70-rqIhF19L9C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 11:04:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 09:04:41 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-RjtfqOF0dA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #45 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- The tests are still failing for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 11:14:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 09:14:35 +0000 Subject: [Koha-bugs] [Bug 17867] Improve display of source (MARC21 773) in result list In-Reply-To: <bug-17867-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17867-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17867-70-9mXKdjT6Px@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17867 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #10 from Magnus Enger <magnus at libriotech.no> --- There are patches here. Should the status be "Needs signoff"? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 11:19:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 09:19:31 +0000 Subject: [Koha-bugs] [Bug 33719] New: Search.t: too much noise about ContentWarningField Message-ID: <bug-33719-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33719 Bug ID: 33719 Summary: Search.t: too much noise about ContentWarningField Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Seeing a lot of warns: The syspref ContentWarningField was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 161. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 11:21:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 09:21:32 +0000 Subject: [Koha-bugs] [Bug 33719] Search.t: too much noise about ContentWarningField In-Reply-To: <bug-33719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33719-70-C2WI6NXskW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33719 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 11:21:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 09:21:34 +0000 Subject: [Koha-bugs] [Bug 33719] Search.t: too much noise about ContentWarningField In-Reply-To: <bug-33719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33719-70-isafggeLZU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33719 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151063&action=edit Bug 33719: Silence warnings on ContentWarningField in Search.t Test plan: Run t/db_dependent/Search.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 11:21:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 09:21:53 +0000 Subject: [Koha-bugs] [Bug 33719] Search.t: too much noise about ContentWarningField In-Reply-To: <bug-33719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33719-70-Lc1McnMhYe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33719 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Trivial: self SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 11:41:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 09:41:35 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-Pk4a5W99pn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 11:41:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 09:41:38 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-9C640tbRUn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #46 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151064&action=edit Bug 29822: Escape backslash on split + effectively replace 'standard', don't display it. + avoid mixing | and , -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:00:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:00:09 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn may crash on missing context In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-bLkGhsWXJf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- If it's from tests only you need to call mock_userenv. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:12:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:12:59 +0000 Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content warnings' to catalogue records In-Reply-To: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31123-70-5MJ5RBVNGj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:24:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:24:07 +0000 Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23919-70-PGulbcnBuB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #38 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Katrin Fischer from comment #37) > I am sad to say, but adding this to item search was not a great idea :( > > Item search is SQL based, not a search engine, which changes things quite a > bit. > > We are exploding the search now with up to 4 forms of ISBN into something > like: > > isbn like 'isbn1' or isbn like 'isbn2' ... > > But: We are not truncating. > > As soon as there is more than one ISBN or ISSN (these are repeatable fields) > or the library actually follows MARC21 standard adding ISBD punctuation, > this fails. We store in biblioitems.isbn like this: > > isbn1 ; | isbn2 ; | isbn3. > isbn1. > > This also seems to create quite a performance issue on big databases and it > can't be turned off separately from the normal search. > > I've filed bug 33514. Can you please address bug 33514? In the meanwhile should we remove this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:24:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:24:41 +0000 Subject: [Koha-bugs] [Bug 33336] Use a dedicated column for plugin status in plugins table In-Reply-To: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33336-70-wGzgmXqxqh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 22.11.x for 22.11.06 release. Thanks everyone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:24:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:24:52 +0000 Subject: [Koha-bugs] [Bug 33336] Use a dedicated column for plugin status in plugins table In-Reply-To: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33336-70-zHQ2sLMYfw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00, 22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:28:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:28:46 +0000 Subject: [Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable In-Reply-To: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33463-70-On8szS6kVD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:28:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:28:49 +0000 Subject: [Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable In-Reply-To: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33463-70-5kYsv1GMYx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151066&action=edit Bug 33463: Remove sort for 'Actions' on the plugins table Test plan: Go go the plugin admin page upload a plugin Notice that the "Actions" column is not longuer sortable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:29:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:29:32 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-GrEPhSr1gw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |martin.renvoize at ptfs-europe | |.com --- Comment #63 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This is a great enhancement, but not one for backport I'm afraid Marking Needs documenting :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:30:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:30:18 +0000 Subject: [Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable In-Reply-To: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33463-70-fAwiwimFSJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Looks like there are much more occurrences. git grep 'Actions</th>'|grep -v NoSort We should fix them all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:30:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:30:23 +0000 Subject: [Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable In-Reply-To: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33463-70-JbA9hSF1UP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:30:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:30:36 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12029-70-7UTekODaL2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting --- Comment #77 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice enhancement, marking as Needs documenting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:32:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:32:26 +0000 Subject: [Koha-bugs] [Bug 33210] (Bug 31963 follow-up) No hold fee message on OPAC should be displayed when there is no fee In-Reply-To: <bug-33210-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33210-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33210-70-6HVLIpkKMh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33210 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:32:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:32:28 +0000 Subject: [Koha-bugs] [Bug 33210] (Bug 31963 follow-up) No hold fee message on OPAC should be displayed when there is no fee In-Reply-To: <bug-33210-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33210-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33210-70-3sZ1s2Y0rn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33210 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:38:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:38:43 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-7RgvgwhSqR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:38:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:38:45 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-ZOBi0Du5ta@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:39:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:39:34 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-ed4UrFULBt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed as requested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:40:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:40:53 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-3tL06Z07hR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:40:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:40:55 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-VLoKcqXyNc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:41:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:41:12 +0000 Subject: [Koha-bugs] [Bug 33406] Searching for authority with hyphen surrounded by spaces causes error 500 (with ES) In-Reply-To: <bug-33406-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33406-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33406-70-wolcTd9vrZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33406 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:41:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:41:14 +0000 Subject: [Koha-bugs] [Bug 33406] Searching for authority with hyphen surrounded by spaces causes error 500 (with ES) In-Reply-To: <bug-33406-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33406-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33406-70-eS8pVmJ1Sj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33406 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151067&action=edit Bug 33406: Handle ES search errors for authorities We are dealing ok with ES exceptions for biblio records search, catching them and raising them to the end user. But we don't for authorities, where we explode with an ugly 500. Test plan: Search for "(term_1*) AND (-) AND (term_2*)" in the authority search and notice that you don't get a 500 but an error instead saying that you should try again -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:41:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:41:32 +0000 Subject: [Koha-bugs] [Bug 33406] Searching for authority with hyphen surrounded by spaces causes error 500 (with ES) In-Reply-To: <bug-33406-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33406-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33406-70-XUWXoFNqrK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33406 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |unspecified Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:46:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:46:18 +0000 Subject: [Koha-bugs] [Bug 33624] Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed In-Reply-To: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33624-70-JeqDzL0YpY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I am not sure I understand. "Select a list of records" exists for both biblios and authorities. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:47:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:47:14 +0000 Subject: [Koha-bugs] [Bug 33279] OAI-PMH should not die on record errors In-Reply-To: <bug-33279-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33279-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33279-70-Lx6711na1i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33279 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- *** This bug has been marked as a duplicate of bug 33270 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:47:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:47:14 +0000 Subject: [Koha-bugs] [Bug 33270] OAI-PMH should not die on record errors In-Reply-To: <bug-33270-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33270-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33270-70-n2NMhzQpwC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33270 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- *** Bug 33279 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:52:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:52:31 +0000 Subject: [Koha-bugs] [Bug 33128] Add Polish translations for language descriptions In-Reply-To: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33128-70-LtMDbA1m8Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33128 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:52:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:52:33 +0000 Subject: [Koha-bugs] [Bug 33128] Add Polish translations for language descriptions In-Reply-To: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33128-70-md7i3AUwYm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33128 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:52:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:52:33 +0000 Subject: [Koha-bugs] [Bug 33320] Patron modification requests: options are squashed In-Reply-To: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33320-70-kEjOV2ez4v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33320 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:52:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:52:35 +0000 Subject: [Koha-bugs] [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link In-Reply-To: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33560-70-yX1tH6QUWn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:52:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:52:36 +0000 Subject: [Koha-bugs] [Bug 33320] Patron modification requests: options are squashed In-Reply-To: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33320-70-ClHicVfgQS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33320 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151068&action=edit Bug 33320: Add spacing in Patron modification requests * Go to the OPAC, log into your account * Make changes to your personal details and save * Go to the staff interface and use the link on the start page to moderate the change request * At the top of the list you'll see something like: Without this patch: Ignore|Patron details With this patch: Ignore | Patron details -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:52:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:52:37 +0000 Subject: [Koha-bugs] [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link In-Reply-To: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33560-70-dGSi7iWAoP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:52:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:52:41 +0000 Subject: [Koha-bugs] [Bug 33320] Patron modification requests: options are squashed In-Reply-To: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33320-70-64NDFlyKM4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33320 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Assignee|oleonard at myacpl.org |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:54:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:54:41 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-rvdirEiVgy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32334 CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |normal Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 [Bug 32334] Sync comments in database with schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:54:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:54:41 +0000 Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema In-Reply-To: <bug-32334-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32334-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32334-70-qoq9BcH93j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:55:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:55:27 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-eXjsZMSTfg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Bugfix to enhancement not in 22.11.x. Marking as resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:57:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:57:16 +0000 Subject: [Koha-bugs] [Bug 33603] misc/maintenance/search_for_data_inconsistencies.pl fails if biblio.biblionumber on control field In-Reply-To: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33603-70-tIriTrw5nx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:57:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:57:17 +0000 Subject: [Koha-bugs] [Bug 33603] misc/maintenance/search_for_data_inconsistencies.pl fails if biblio.biblionumber on control field In-Reply-To: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33603-70-BehPf9T2FV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:58:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:58:20 +0000 Subject: [Koha-bugs] [Bug 33629] allow pbuilder to use network via build-git-snapshot In-Reply-To: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33629-70-VEENNnY7Af@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33629 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 12:58:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 10:58:22 +0000 Subject: [Koha-bugs] [Bug 33629] allow pbuilder to use network via build-git-snapshot In-Reply-To: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33629-70-tjE5U7YdKx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33629 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:00:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:00:12 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-bMeTrWHsEO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:00:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:00:14 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-CVpav6CK8R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:02:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:02:47 +0000 Subject: [Koha-bugs] [Bug 33156] Batch patron modification tool is missing search bar and other attributes In-Reply-To: <bug-33156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33156-70-q6hyAiNNyW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:02:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:02:49 +0000 Subject: [Koha-bugs] [Bug 33156] Batch patron modification tool is missing search bar and other attributes In-Reply-To: <bug-33156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33156-70-w7IO3erSW1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:08:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:08:11 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals creating issue with renewal history view In-Reply-To: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33504-70-m33RqlJkOJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:08:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:08:13 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals creating issue with renewal history view In-Reply-To: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33504-70-0EB59lsCCH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:10:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:10:46 +0000 Subject: [Koha-bugs] [Bug 32782] Add UNIMARC support to the ERM module In-Reply-To: <bug-32782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32782-70-Hz6P4FX8gw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32782 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:10:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:10:48 +0000 Subject: [Koha-bugs] [Bug 32782] Add UNIMARC support to the ERM module In-Reply-To: <bug-32782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32782-70-UF6G8ztJBs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32782 --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:12:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:12:50 +0000 Subject: [Koha-bugs] [Bug 33482] Errors from EBSCO's ws are not reported to the UI In-Reply-To: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33482-70-TIKOZzNPwO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33482 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:12:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:12:52 +0000 Subject: [Koha-bugs] [Bug 33482] Errors from EBSCO's ws are not reported to the UI In-Reply-To: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33482-70-SK0uV2KKC5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33482 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:13:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:13:47 +0000 Subject: [Koha-bugs] [Bug 33320] Patron modification requests: options are squashed In-Reply-To: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33320-70-D74Ow9dlFU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33320 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:13:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:13:50 +0000 Subject: [Koha-bugs] [Bug 33320] Patron modification requests: options are squashed In-Reply-To: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33320-70-9XoHCtPqVd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33320 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151068|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151069&action=edit Bug 33320: Add spacing in Patron modification requests * Go to the OPAC, log into your account * Make changes to your personal details and save * Go to the staff interface and use the link on the start page to moderate the change request * At the top of the list you'll see something like: Without this patch: Ignore|Patron details With this patch: Ignore | Patron details Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:16:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:16:10 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32250-70-vlEMmDEyyP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:16:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:16:12 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32250-70-DtaQgydacT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:17:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:17:30 +0000 Subject: [Koha-bugs] [Bug 33328] x-marc-schema should be renamed x-record-schema In-Reply-To: <bug-33328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33328-70-HUe5dxUaS8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33328 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:17:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:17:31 +0000 Subject: [Koha-bugs] [Bug 33328] x-marc-schema should be renamed x-record-schema In-Reply-To: <bug-33328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33328-70-hta9CYtMVm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33328 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:23:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:23:45 +0000 Subject: [Koha-bugs] [Bug 19249] Date picker broken in "Quick add new patron" form In-Reply-To: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19249-70-lqTk3urkfg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:23:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:23:47 +0000 Subject: [Koha-bugs] [Bug 19249] Date picker broken in "Quick add new patron" form In-Reply-To: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19249-70-c0fMGAy1V7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:23:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:23:50 +0000 Subject: [Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 In-Reply-To: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33437-70-dHlhv759Er@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:23:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:23:52 +0000 Subject: [Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 In-Reply-To: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33437-70-IYVsTLGjVz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:23:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:23:53 +0000 Subject: [Koha-bugs] [Bug 33559] Use template wrapper for breadcrumbs: Serials part 2 In-Reply-To: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33559-70-ZUqVb4B0oO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:23:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:23:55 +0000 Subject: [Koha-bugs] [Bug 33559] Use template wrapper for breadcrumbs: Serials part 2 In-Reply-To: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33559-70-hmWyI3ilJw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:23:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:23:57 +0000 Subject: [Koha-bugs] [Bug 33564] Use template wrapper for breadcrumbs: Serials part 3 In-Reply-To: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33564-70-2C0lDT8G8W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33564 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:23:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:23:58 +0000 Subject: [Koha-bugs] [Bug 33564] Use template wrapper for breadcrumbs: Serials part 3 In-Reply-To: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33564-70-BDFDQm7ogb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33564 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:24:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:24:00 +0000 Subject: [Koha-bugs] [Bug 33566] Use template wrapper for breadcrumbs: Tools, part 1 In-Reply-To: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33566-70-6O7weCpctb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:24:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:24:02 +0000 Subject: [Koha-bugs] [Bug 33566] Use template wrapper for breadcrumbs: Tools, part 1 In-Reply-To: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33566-70-SmwUzpNs3e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:24:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:24:04 +0000 Subject: [Koha-bugs] [Bug 33598] Use template wrapper for breadcrumbs: Tools, part 5 In-Reply-To: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33598-70-OrH3YUSG2D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33598 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:24:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:24:05 +0000 Subject: [Koha-bugs] [Bug 33598] Use template wrapper for breadcrumbs: Tools, part 5 In-Reply-To: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33598-70-OIFpo8H5Im@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33598 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:24:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:24:07 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-s1HKgB9ZST@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:24:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:24:09 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-6Pp9ZzdwN8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:24:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:24:11 +0000 Subject: [Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section In-Reply-To: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33634-70-UO2Rb0aTPA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:24:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:24:13 +0000 Subject: [Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section In-Reply-To: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33634-70-aKGUL1DtsK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:25:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:25:56 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn may crash on missing context In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-rlFf9bkxUK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #1) > If it's from tests only you need to call mock_userenv. It is a weird error that cannot be reproduced consistently yet. Context passes a second 'listen' parameter to Koha::Config->get and in that routine I did not see that parameter. Needs a bit more digging still. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:35:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:35:28 +0000 Subject: [Koha-bugs] [Bug 33250] DELETE /biblios/:biblio_id fails when ES is enabled In-Reply-To: <bug-33250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33250-70-pJLtS0HGyq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33250 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- how fails? curl -XDELETE -H "Content-Type: application/json" -u koha:koha http://kohadev-intra.mydnsname.org:8081/api/v1/biblios/3 "DELETE /api/v1/app.pl/api/v1/biblios/3 HTTP/1.1" 204 - "-" "curl/7.68.0" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:35:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:35:42 +0000 Subject: [Koha-bugs] [Bug 33250] DELETE /biblios/:biblio_id fails when ES is enabled In-Reply-To: <bug-33250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33250-70-lLylO74wfj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33250 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:36:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:36:54 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-zwzrmmihaD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #7) > First time trying this, and I failed to test. > > I am getting > > """ > test > We are sorry... > > Invalid parameter: redirect_uri > """ > After I clicked "login with test" > The generated URL is > http://sso:8082/auth/realms/test/protocol/openid-connect/ > auth?response_type=code&client_id=kohaoidc&redirect_uri=http%3A%2F%2Fkohadev- > intra.myDNSname. > org%3A8081%2Fapi%2Fv1%2Foauth%2Flogin%2Ftest%2Fstaff&scope=openid+email&state > =873f7839ab38384730c0635c3b260564297de884%2Ca443349be07f4216b95089525be35eeb9 > 6b74452%2C1683794690 > > I guess I made an error in the config somewhere but I have double-checked > everything :-/ The wiki suggests using localhost:port/* but your URL is using kohadev.myDNSname... because it picks it from the baseURL prefs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:50:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:50:22 +0000 Subject: [Koha-bugs] [Bug 33624] Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed In-Reply-To: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33624-70-XiU6xHh1Sb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 --- Comment #2 from Philip Orr <philip.orr at lmscloud.de> --- Oops, sorry - forgot to mention that you need to have applied the patch for bug 32914 first. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 New steps to recreate: - Apply the patch for bug 32914 - Make sure you have at least one template for MARC Modification - Also make sure you have at least one list of biblio records - navigate to Cataloging -> Batch record modification - Check the "Authorities" radio button - Select your template and continue - No records were modified -> use your browser's Back button to go back one page - The "Authorities" radio button should still be selected, but you should now see the tab "Select a list of records". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:51:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:51:30 +0000 Subject: [Koha-bugs] [Bug 33247] Deleted authority still on results list In-Reply-To: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33247-70-OCD5nrhgZJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:51:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:51:33 +0000 Subject: [Koha-bugs] [Bug 33247] Deleted authority still on results list In-Reply-To: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33247-70-ViFCFrtzue@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151070&action=edit Bug 33247: Flag the authority pending deletion in the result list When an authority is removed from the result list it is not removed from the search engine yet. This patch suggests to add a note in the summary column to tell the user that the deletion is pending. Test plan: 1 - Go to authorities home and perform a search; 2 - Delete any authority; 3 - After the confirmation, the page is refreshed but still contains the deleted authority, with a red note explaining that the deletion is pending. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 13:52:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 11:52:10 +0000 Subject: [Koha-bugs] [Bug 33247] Deleted authority still on results list In-Reply-To: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33247-70-O4DJJVIA2r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Quick an dirty fix. Would it be enough? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:03:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:03:40 +0000 Subject: [Koha-bugs] [Bug 33246] itemBarcodeFallbackSearch search results should show whether or not items are available In-Reply-To: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33246-70-AbJr9lVnUm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33246 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:03:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:03:42 +0000 Subject: [Koha-bugs] [Bug 33246] itemBarcodeFallbackSearch search results should show whether or not items are available In-Reply-To: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33246-70-flrigWAXPD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33246 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151071&action=edit Bug 33246: Show the onloan status on the BarcodeFallbackSearch result -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:04:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:04:10 +0000 Subject: [Koha-bugs] [Bug 33246] itemBarcodeFallbackSearch search results should show whether or not items are available In-Reply-To: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33246-70-w4cRVHl7hd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33246 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Something like that? In a different column? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:05:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:05:27 +0000 Subject: [Koha-bugs] [Bug 33246] itemBarcodeFallbackSearch search results should show whether or not items are available In-Reply-To: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33246-70-Fb3inRYPWb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33246 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:19:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:19:28 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-tE98l4NxW8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #59 from Mengu Yazicioglu <mengu at devinim.com.tr> --- (In reply to David Cook from comment #58) > (In reply to Mengu Yazicioglu from comment #57) > > When we try to upgrade to 22.11.05, post-installation database update part > > gives error about ERM tables related with this bug. > > > > In order to bypass the post-installation steps, we need manually change some > > tables' row format status, otherwise we can't go forward. > > What version of MySQL are you using and on what OS? We upgraded from Debian 9 to Debian 11 and Mariadb 10.1 to 10.5 and it is not possible to bypass to change related tables row_format to DYNAMIC. I've updated wiki page for solution. https://wiki.koha-community.org/wiki/Database_row_format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:25:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:25:31 +0000 Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially In-Reply-To: <bug-32253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32253-70-YmHYq9h2E7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:25:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:25:33 +0000 Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially In-Reply-To: <bug-32253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32253-70-8tTqsYvzPp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:25:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:25:34 +0000 Subject: [Koha-bugs] [Bug 32745] Jobs view breaks when there are jobs with context IS NULL In-Reply-To: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32745-70-w4zegMtgqi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32745 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:25:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:25:36 +0000 Subject: [Koha-bugs] [Bug 32745] Jobs view breaks when there are jobs with context IS NULL In-Reply-To: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32745-70-cwoliYZzQc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32745 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:25:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:25:38 +0000 Subject: [Koha-bugs] [Bug 32874] Fix cataloguing/value_builder/unimarc_field_700-4.pl In-Reply-To: <bug-32874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32874-70-0qcOACtRHd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32874 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:25:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:25:39 +0000 Subject: [Koha-bugs] [Bug 32874] Fix cataloguing/value_builder/unimarc_field_700-4.pl In-Reply-To: <bug-32874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32874-70-PIZLFwPXt1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32874 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:25:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:25:41 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-YD117fMr8o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:25:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:25:43 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-3NyarrSAMf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:25:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:25:44 +0000 Subject: [Koha-bugs] [Bug 33506] Series has wrong index name on scan index page and search option selection is not retained In-Reply-To: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33506-70-3LVF784u9H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:25:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:25:46 +0000 Subject: [Koha-bugs] [Bug 33506] Series has wrong index name on scan index page and search option selection is not retained In-Reply-To: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33506-70-vshkFRUmoj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:25:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:25:48 +0000 Subject: [Koha-bugs] [Bug 33588] Inventory item list is missing page-section class In-Reply-To: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33588-70-UlMnR4e9gt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33588 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:25:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:25:49 +0000 Subject: [Koha-bugs] [Bug 33588] Inventory item list is missing page-section class In-Reply-To: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33588-70-VPhSEvxpEz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33588 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:25:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:25:51 +0000 Subject: [Koha-bugs] [Bug 33597] Get rid of few SameSite warnings In-Reply-To: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33597-70-CjLydPWgpA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:25:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:25:52 +0000 Subject: [Koha-bugs] [Bug 33597] Get rid of few SameSite warnings In-Reply-To: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33597-70-3Y3tGjd0g2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:37:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:37:27 +0000 Subject: [Koha-bugs] [Bug 33624] Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed In-Reply-To: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33624-70-LfnvZolP3r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Depends on| |32914 Status|NEW |ASSIGNED --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Philip Orr from comment #2) > Oops, sorry - forgot to mention that you need to have applied the patch for > bug 32914 first. > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 > > New steps to recreate: > - Apply the patch for bug 32914 > - Make sure you have at least one template for MARC Modification > - Also make sure you have at least one list of biblio records > - navigate to Cataloging -> Batch record modification > - Check the "Authorities" radio button > - Select your template and continue > - No records were modified -> use your browser's Back button to go back one > page > - The "Authorities" radio button should still be selected, > but you should now see the tab "Select a list of records". Ho right, the list tab, I meant "Enter a list of record numbers" in my previous comment. I didn't notice the list one as I didn't have one created. I do recreate the problem on master. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 [Bug 32914] Use template wrapper for batch record deletion and modification templates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:37:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:37:27 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-tbo5lUJc5Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33624 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 [Bug 33624] Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:38:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:38:23 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-vqiA3tymV5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #126 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #125) > 1. > - b_sel => ( $budget->{budget_id} == $order->budget_id ) ? 1 : 0, > + # b_sel => ( $budget->{budget_id} == $order->budget_id ) ? 1 : 0, > > Then remove ;) Agreed. > 2. > + creator: > + type: > + - object > + - "null" > + description: Patron that created the order > > We could tell here we expect an object representing a patron It doesn't work. You cannot put a $ref and 'null', unfortunately. OpenAPI v3 might make it possible. > 3. > + - items.home_branch > + - items.holding_branch > + - items.itemtype > > Shouldn't they use the "fixed names"? home_library, item_type? That's a leftover, not even used and prior to the +strings addition. Will remove. > 4. https://snipboard.io/SvHwAn.jpg > The "Change currency" checkbox is not aligned properly > And it's actually not working: > * edit > * Set actual cost, check "change currency", select a currency, save > * edit again > => Values are not saved, you are actually breaking bug 25655. > Also I have seen "NaN" generated in actual cost but not sure when/how. > > And finally, values are not saved in the DB (invoice_currency, > invoice_unitprice). Will check. The most recent iteration got them flawed. > 5. Partial receive does not seem to work > I ordered 3, received 1, receiving again: > "Receiving 0 out of 2" => OK > Click edit > => There are 3 items in the items table Noted, it's a problem with how the post form is built (the items_to_receive array arrives empty to finishreceive.pl). Working on it > 6. "Date received:" does not have flatpickr applied > > 7. Fund is not marked "required" like before > > 8. We lost the "show active" checkbox next to the fund list > > 9. There are missing spaces after numbers "Retail price: 0.00(adjusted for > USD, tax exclusive)" > > 10. > + <th><!--input type="checkbox" id="selectAll"/--></th> > > Do we want that? > > 11. JS code in parcel.tt use 2 spaces indentation instead of 4 > > 12. I noticed 2 parallel request to parcel.pl?invoiceid=1 at the end of the > process, and one of them is aborted. This is what is in the console: > https://snipboard.io/IKwoVP.jpg > > 13. comment 111 and comment 112 still need an answer. > I don't understand how dataTables.select.min.js, select.dataTables.min.css > is useful here. Is that the row.select() and row.deselect() statements in > parcel.tt? If so, what are they doing? I removed them and didn't see any > issues. > > 14. There are several parts of the JS code in orderreceive.tt that are > commented, if we don't need them we should remove them. > > 15. I think we should widen the modal. The item form is not displayed nicely > https://snipboard.io/VIKAgY.jpg > > 16: not sure it's a blocker: When you select some orders, the table on the > order receive page has "Showing 1 to 1 of 1 entries (filtered from 3 total > entries)" > But there is no way to display them all. I understand why and what it > implies, just noting. > > 17. Another "just noting": the code (introduced by bug 20212 I think) > related to biblio.suggestions.suggester is bad and should have been > simplified before we did all this. I submitted a patch yesterday to remove > GetSuggestionInfoFromBiblionumber, it's on bug 28844. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:39:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:39:38 +0000 Subject: [Koha-bugs] [Bug 33624] Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed In-Reply-To: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33624-70-1RQla3k58y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:39:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:39:41 +0000 Subject: [Koha-bugs] [Bug 33624] Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed In-Reply-To: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33624-70-k95wW1A6AW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151072&action=edit Bug 33624: Hide the "list" tab if authority is selected The "Select a list of records" should only be available for biblio records. But if the page is accessed using the back button of the browser it will be displayed for authorities as well. Test plan: - Make sure you have at least one template for MARC Modification - Also make sure you have at least one list of biblio records - navigate to Cataloging -> Batch record modification - Check the "Authorities" radio button - Select your template and continue - No records were modified -> use your browser's Back button to go back one page - The "Authorities" radio button should still be selected => Without this patch you see the tab "Select a list of records" => With this patch applied it's hidden when the page is loaded -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:40:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:40:02 +0000 Subject: [Koha-bugs] [Bug 33624] Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed In-Reply-To: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33624-70-KAYrgCBzVK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Bug is in master, without bug 32914. But it's PQA so I built the fix on top of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:40:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:40:47 +0000 Subject: [Koha-bugs] [Bug 33118] Bug 30472 provoke a DBI Exception when upgrading from 22.05.x to 22.11.02-1 In-Reply-To: <bug-33118-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33118-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33118-70-JnDgc91FAa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33118 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- *** This bug has been marked as a duplicate of bug 33671 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:40:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:40:47 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-Mznbyiy2Hu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi at gmail.com --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- *** Bug 33118 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:41:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:41:39 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn may crash on missing context In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-CKZgUymaVM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Got it. Patch coming. It is a more fundamental error in t::lib::Mocks. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:42:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:42:36 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn may crash on wrong results from Koha::Config->get In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-R6FpeUz5Tl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|_new_Zconn may crash on |_new_Zconn may crash on |missing context |wrong results from | |Koha::Config->get -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:46:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:46:31 +0000 Subject: [Koha-bugs] [Bug 32029] Automatic item modifications by age missing biblio table In-Reply-To: <bug-32029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32029-70-go71Gc8plC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32029 Philip Orr <philip.orr at lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:46:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:46:33 +0000 Subject: [Koha-bugs] [Bug 32029] Automatic item modifications by age missing biblio table In-Reply-To: <bug-32029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32029-70-SRjqIheRF2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32029 Philip Orr <philip.orr at lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142752|0 |1 is obsolete| | --- Comment #4 from Philip Orr <philip.orr at lmscloud.de> --- Created attachment 151073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151073&action=edit Bug 32029: Automatic item modifications by age add biblio table In automatic item modifications by age missing, conditions can be on columns of tables items or biblioitems. Table biblio is missing. Test plan : 1) Create an automatic item modifications by age with a condition on a column of biblio table 2) Create a record and item matching the rule 3) Run misc/cronjobs/automatic_item_modification_by_age.pl -c -v => Check only matching items are impacted Signed-off-by: Philip Orr <philip.orr at lmscloud.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:51:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:51:55 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-fA8aeCXRUK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|_new_Zconn may crash on |_new_Zconn crashes on a bug |wrong results from |in |Koha::Config->get |t::lib::Mocks::mock_config -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:59:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:59:35 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-cp6CaORx2e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 14:59:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 12:59:37 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-bdJDv9trMH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151074&action=edit Bug 33718: Fix the mock of Koha::Config->get in mock_config It should not mock calls for other sections than 'config' in koha-conf.xml. Test plan: Without this patch: [1] Enable CatalogModuleRelink and LinkerRelink. This will trigger a SearchAuthorities call when creating a sample biblio. Note: SearchAuthorities calls Zconn and gets back information from a wrong part of koha-conf.xml. [2] Run t/db_dependent/Koha/Pseudonymization.t You should see something like: {UNKNOWN}: Can't use string ("authorities") as a HASH ref while "strict refs" in use at /usr/share/koha/C4/Context.pm line 587. at /usr/share/koha/C4/Biblio.pm line 302 With this patch: [3] Run t/db_dependent/Koha/Pseudonymization.t. Should pass now. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:00:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:00:01 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-wn5kz1ews9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:01:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:01:16 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-6IN7GEPjmK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151074|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151075&action=edit Bug 33718: Fix the mock of Koha::Config->get in mock_config It should not mock calls for other sections than 'config' in koha-conf.xml. Test plan: Without this patch: [1] Enable CatalogModuleRelink and LinkerRelink. This will trigger a SearchAuthorities call when creating a sample biblio. Note: SearchAuthorities calls Zconn and gets back information from a wrong part of koha-conf.xml. [2] Run t/db_dependent/Koha/Pseudonymization.t You should see something like: {UNKNOWN}: Can't use string ("authorities") as a HASH ref while "strict refs" in use at /usr/share/koha/C4/Context.pm line 587. at /usr/share/koha/C4/Biblio.pm line 302 With this patch: [3] Run t/db_dependent/Koha/Pseudonymization.t. Should pass now. [4] git grep -l mock_config | xargs -i{} prove {} Exclude Mocks.pm. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:02:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:02:55 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-d9V0AX1V77@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Note for QA: The crash refers to authorities (this comes from config/authorityserver in koha-conf while we expected information from the listen section in this line: my $host = _common_config($server, 'listen')->{content}; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:03:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:03:39 +0000 Subject: [Koha-bugs] [Bug 33421] Filtering purchase suggestions by status does not work if All Libraries is selected In-Reply-To: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33421-70-3JptIqyScx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33421 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150959|0 |1 is obsolete| | --- Comment #2 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- Created attachment 151076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151076&action=edit Bug 33421: Fix filtering suggestions by status If the display is by status and a specific status is selected in the filter, the filter won't have any effects. Test plan: Create several suggestions, with different status, for different libraries. Use the "display by status" view and filter on a given status => Result must be relevant Signed-off-by: Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:03:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:03:53 +0000 Subject: [Koha-bugs] [Bug 33421] Filtering purchase suggestions by status does not work if All Libraries is selected In-Reply-To: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33421-70-nvvZnJNS8H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33421 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:16:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:16:23 +0000 Subject: [Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record In-Reply-To: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26314-70-iAGn2psG6P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:19:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:19:40 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31856-70-e1eGf0GuWA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 --- Comment #13 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151077&action=edit Bug 31856: Prefetch additional fields for increased performance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:19:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:19:42 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31856-70-GxE2cKByls@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 --- Comment #14 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151078&action=edit Bug 31856: Refactor GetAuthorisedValueDesc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:24:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:24:55 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31856-70-HpZnteiqXZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 --- Comment #15 from David Gustafsson <glasklas at gmail.com> --- (In reply to Jonathan Druart from comment #11) > Is the change in SearchSubscriptions really makes things faster? Yes, fetching the subsctiption object is quite expensive, so the change (in SearchSubscriptions alone) makes searches about twice as fast. Also decided to prefetch additional values, so now is done one query instead of on per subscripton witch speeds things up an additional 25% or so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:25:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:25:52 +0000 Subject: [Koha-bugs] [Bug 32929] ERM - 'Submit' button untranslatable In-Reply-To: <bug-32929-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32929-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32929-70-qwn2R8WUOG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32929 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart+koha at gmail. | |com Resolution|--- |INVALID --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- messages-js is generated using: gulp po:update --lang fr-CA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:25:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:25:59 +0000 Subject: [Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC In-Reply-To: <bug-31051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31051-70-pz5odhJQDo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #54 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Can the [% IF savings %] [% savings | $Price with_symbol => 1 %] be used in notices? It would be useful to replace https://wiki.koha-community.org/wiki/Notices_and_Slips_Library#Add_total_value_of_items_borrowed_to_date_on_issue_slip -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:27:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:27:08 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31856-70-BvLDIPp0Jc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 --- Comment #16 from David Gustafsson <glasklas at gmail.com> --- (In reply to Jonathan Druart from comment #12) > (In reply to Jonathan Druart from comment #11) > > Is the change in SearchSubscriptions really makes things faster? > > Right, there is no FK. Maybe we are just missing an index on a DB column > then? I tried adding an index for that column and did not make much of a difference, perhaps a few percent at most if even that. 99% of the cost is DBIx, the database query itself is a neglectable part if using and index or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:28:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:28:24 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11300-70-FE029OajGW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148824|0 |1 is obsolete| | --- Comment #49 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151079&action=edit Bug 11300: Add a new authority linker which searches for authority links on a Z39.50 server. This patch adds a Z39.50 Linker which searches for authority links on a remote server. If a matching authority is found, it's imported in the local database for linking with the current biblio record. If no matching authority was found on the remote server, the Linker falls back to a local authority search. Configuration : * The option "Z39.50 Server" is added to the LinkerModule preference. You must choose this to use the new Linker. * The preference LinkerZ3950Server is required and specifies which server to use for linking. It must contain the "name" of the server, as defined in the z3950servers table. * You can set the "local_first" option in the LinkerOptions preference to force the Linker to search for authorities in the local database first. If no local authority match was found, the Linker falls back to a remote Z39.50 search. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:28:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:28:45 +0000 Subject: [Koha-bugs] [Bug 32988] Cannot clear guarantor with clear link In-Reply-To: <bug-32988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32988-70-3GIzVVvE3W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32988 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Which "clear" link are we talking about? https://snipboard.io/myYMjG.jpg -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:30:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:30:14 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11300-70-eOrSPtr2rW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hammat.wele at inlibro.com --- Comment #50 from Hammat wele <hammat.wele at inlibro.com> --- I rebased the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:31:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:31:10 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31856-70-KZyJHrHwlh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 --- Comment #17 from David Gustafsson <glasklas at gmail.com> --- Not saying there should not be an index, perhaps there are use cases where it could matter, my guess is that in the absolute majority of cases the number of rows in that table is small enough that a sequential scan will be about as fast as using an index. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:37:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:37:29 +0000 Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to server side filtering In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-qBpIMHImSc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26635 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 [Bug 26635] Expand coded values in REST API call -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:37:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:37:29 +0000 Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26635-70-E6ddLuW3io@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 [Bug 22440] Improve ILL page performance by moving to server side filtering -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:37:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:37:46 +0000 Subject: [Koha-bugs] [Bug 33320] Patron modification requests: options are squashed In-Reply-To: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33320-70-CukD6CdxSZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33320 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:37:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:37:48 +0000 Subject: [Koha-bugs] [Bug 33320] Patron modification requests: options are squashed In-Reply-To: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33320-70-Y80LMBahso@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33320 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151069|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151080&action=edit Bug 33320: Add spacing in Patron modification requests * Go to the OPAC, log into your account * Make changes to your personal details and save * Go to the staff interface and use the link on the start page to moderate the change request * At the top of the list you'll see something like: Without this patch: Ignore|Patron details With this patch: Ignore | Patron details Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:37:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:37:57 +0000 Subject: [Koha-bugs] [Bug 33320] Patron modification requests: options are squashed In-Reply-To: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33320-70-Tqor9Ll3vQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33320 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:41:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:41:42 +0000 Subject: [Koha-bugs] [Bug 33677] Remove --verbose from koha-worker manpage In-Reply-To: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33677-70-x0P0DlyRiK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:41:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:41:44 +0000 Subject: [Koha-bugs] [Bug 33677] Remove --verbose from koha-worker manpage In-Reply-To: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33677-70-yeFgTEGV0a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150953|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151081&action=edit Bug 33677: Remove verbose option from koha-worker man Signed-off-by: Magnus Enger <magnus at libriotech.no> No more mention of verbose. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:41:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:41:49 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-FC0qMwOMrz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #103 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Whilst this is most certainly an enhancement.. it's an important architectural one for ERM. I've decided to overrule the decision made not to backport as I believe, especially as this is an LTS release, we need it to ensure we can continue to maintain ERM going forward for the rest of the maintanence period. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:41:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:41:56 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-oxEWXSxeB8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:41:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:41:57 +0000 Subject: [Koha-bugs] [Bug 32607] Add import sources CRUD In-Reply-To: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32607-70-RNCFKi30U5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Bug 32607 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:41:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:41:58 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-DZV3eh37yK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Bug 33483 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:41:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:41:58 +0000 Subject: [Koha-bugs] [Bug 33705] Tables have configure button even if they are not configurable In-Reply-To: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33705-70-8LwfAI8x0n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Bug 33705 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:41:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:41:58 +0000 Subject: [Koha-bugs] [Bug 33529] Increase flexibility of action buttons in Vue Kohatables In-Reply-To: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33529-70-p1RnaV6HgB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33529 Bug 33529 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:42:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:42:06 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-gAXKxpbzSJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:42:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:42:07 +0000 Subject: [Koha-bugs] [Bug 32607] Add import sources CRUD In-Reply-To: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32607-70-2mnfG4qXOl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Bug 32607 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:42:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:42:07 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-SPIXonfyeG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Bug 33483 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:42:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:42:08 +0000 Subject: [Koha-bugs] [Bug 33705] Tables have configure button even if they are not configurable In-Reply-To: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33705-70-6uM5xCGDtF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Bug 33705 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:42:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:42:08 +0000 Subject: [Koha-bugs] [Bug 33529] Increase flexibility of action buttons in Vue Kohatables In-Reply-To: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33529-70-J2YHBgmWLG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33529 Bug 33529 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:42:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:42:17 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-lsiUO0nsmg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:42:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:42:24 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-G0UxfLSrjc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:42:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:42:31 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-XVbWeea88J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:42:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:42:39 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-Whb1sP99Po@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:44:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:44:29 +0000 Subject: [Koha-bugs] [Bug 33677] Remove --verbose from koha-worker manpage In-Reply-To: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33677-70-72uXSfnEl3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:45:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:45:13 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-mifhz3E2F0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #119 from Blou <philippe.blouin at inlibro.com> --- Hello Martin, Thanks for the feedbacks AND the corrections. Now, as to your latest inquiry, I'm not the one who will answer it. But I'll give perspective. This has been coded about 10 years ago. A request from one of our clients that made a lot of sense to us. Then and now (frankly, sending email to guarantor is a VERY obvious requirement in the public libraries real world). But it was coded in a very different Koha, and the patches have tried to follow up in the last decade through a good dozen of our team members. The sponsor's money have long dried up, but the ticket is opened and we maintain it with the blind faith one day we won't have to rebase it for our own deliveries (were I to stop putting it on our pile one year and 20 libraries would notice me). So I don't know WHY things are like what they are. And I'm certain our current dev is not aware either. He'll modify what's asked to push it through, with no recoding/reachitecturing considered. I'm sorry nobody at inLibro can answer the questions you asked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:51:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:51:46 +0000 Subject: [Koha-bugs] [Bug 33047] Local cover image fetchers return 500 internal error when image not available In-Reply-To: <bug-33047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33047-70-dB8MBrzXmS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33047 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:51:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:51:48 +0000 Subject: [Koha-bugs] [Bug 33047] Local cover image fetchers return 500 internal error when image not available In-Reply-To: <bug-33047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33047-70-6t62loXfvw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33047 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151082&action=edit Bug 33047: Return 404 instead of 500 when biblio does not exist If the biblionumber or the itemnumber passed in parameter does not exist we should return 404 instead of exploding with a 500. Test plan: Attach cover images to biblio and items Notice that the UI is working correctly (staff and OPAC) Hit catalogue/image.pl and opac/opac-image.pl with non-existent biblionumber and imagenumber Notice that you now get 404 instead of 500 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:52:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:52:09 +0000 Subject: [Koha-bugs] [Bug 33047] Local cover image fetchers return 500 internal error when image not available In-Reply-To: <bug-33047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33047-70-NNqwkCFdKS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33047 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Galen, would that work for you? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:54:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:54:36 +0000 Subject: [Koha-bugs] [Bug 33720] New: koha-upgrade-schema should restart memcached Message-ID: <bug-33720-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33720 Bug ID: 33720 Summary: koha-upgrade-schema should restart memcached Change sponsored?: --- Product: Koha Version: master Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: jake.deery at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: mtj at kohaaloha.com Hello community, We have been caught out with a minor annoyance in the koha-upgrade-schema script (Debian package) - upon reloading a database from an SQL dump file (e.g. re-imaging a test server from a live system), the database upgrade appears to complete successfully, but in fact steps are missed. We believe this is because memcached is keeping the software version cached as a value, as a restart of memcached seems to resolve the issue. I attach a proposed solution; restarting memcached just before calling the updatedatabase.pl script. I hope this makes sense, can can be backported for 22.11.xx. Many thanks, Jake -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:58:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:58:57 +0000 Subject: [Koha-bugs] [Bug 33720] koha-upgrade-schema should restart memcached In-Reply-To: <bug-33720-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33720-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33720-70-euSo0IA5Ni@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33720 --- Comment #1 from Jake Deery <jake.deery at ptfs-europe.com> --- Created attachment 151083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151083&action=edit Add memcached restart before updatedatabase.pl is called This patch adds a call to /etc/init.d/memcached so that when koha-upgrade-schema is called, the correct DB revision number is fetched, avoiding issues when loading & upgrading a SQL dump file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 15:59:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 13:59:10 +0000 Subject: [Koha-bugs] [Bug 33720] koha-upgrade-schema should restart memcached In-Reply-To: <bug-33720-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33720-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33720-70-8ylfHvjI9p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33720 Jake Deery <jake.deery at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:09:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 14:09:47 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-wjgzpIOJ96@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:10:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 14:10:48 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-OCx7yyiq4c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144335|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:11:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 14:11:21 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-gbWGllM3c3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144384|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:12:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 14:12:25 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-Pd16meDt6W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141157|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:13:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 14:13:15 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-vFsrMwdhii@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141160|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:13:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 14:13:56 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-Xj2kl2n9Wy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141161|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:16:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 14:16:50 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-lZq7mGY8QO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144384|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:17:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 14:17:56 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-Js71Yy7p1R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141162|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:19:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 14:19:06 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-E9tdwcPdUV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141163|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:19:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 14:19:30 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-jXHO62I5pd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141164|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:29:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 14:29:06 +0000 Subject: [Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl In-Reply-To: <bug-26890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26890-70-ezzVF26Jhy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890 Michaela Sieber <michaela.sieber at kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:42:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 14:42:04 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33335-70-EVRyll5A9q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Two things: As already commented, we lost the * => * now. Please add it back. And the To.JSON approach does not guarantee a correct sort order which we did have. If you add the *,* in js you will probably loose the sort order which you could not lean on anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:46:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 14:46:06 +0000 Subject: [Koha-bugs] [Bug 33362] Return claims can be un-resolvable if issue_id is set but no issue is found in issues or old_issues In-Reply-To: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33362-70-X7r0gHHyCX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33362 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:46:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 14:46:08 +0000 Subject: [Koha-bugs] [Bug 33362] Return claims can be un-resolvable if issue_id is set but no issue is found in issues or old_issues In-Reply-To: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33362-70-pezjoowxwT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33362 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151084&action=edit Bug 33362: Allow return claims to be resolved even if the issue has since been delete from the database Test Plan: 1) Check out an item 2) Claim return on it, moving it to the old_issues table 3) Delete the old_issue via koha-mysql or Use cleanup_database.pl 4) Attempt to resolve the claim 5) Note the error 6) Apply this patch set 7) Restart all the things! 8) Attempt to resolve the claim 9) No errors! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:46:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 14:46:12 +0000 Subject: [Koha-bugs] [Bug 33362] Return claims can be un-resolvable if issue_id is set but no issue is found in issues or old_issues In-Reply-To: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33362-70-TRlZ5FREma@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33362 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:47:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 14:47:46 +0000 Subject: [Koha-bugs] [Bug 29431] Hold queue does not consider expiration date In-Reply-To: <bug-29431-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29431-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29431-70-ZEIRwOam7O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29431 Katie Bliss <kebliss at dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 16:48:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 14:48:11 +0000 Subject: [Koha-bugs] [Bug 33362] Return claims can be un-resolvable if issue_id is set but no issue is found in issues or old_issues In-Reply-To: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33362-70-VwufktaLL8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33362 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151084|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151085&action=edit Bug 33362: Allow return claims to be resolved even if the issue has since been delete from the database Test Plan: 1) Check out an item 2) Claim return on it, moving it to the old_issues table 3) Delete the old_issue via koha-mysql or Use cleanup_database.pl 4) Attempt to resolve the claim 5) Note the error 6) Apply this patch set 7) Restart all the things! 8) Attempt to resolve the claim 9) No errors! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:05:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 15:05:03 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-8LN6XdLFAF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #127 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151086&action=edit Bug 8179: Make partial receive work correctly Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:08:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 15:08:23 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-gSkWZLVpiJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 --- Comment #9 from David Gustafsson <glasklas at gmail.com> --- (In reply to Jonathan Druart from comment #8) > 1. Then I would C4::Biblio::GetFrameworkCode and cache there. > > 2. - my $tagslib = C4::Biblio::GetMarcStructure(1, $frameworkcode); > + my $tagslib = C4::Biblio::GetMarcStructure( 1, $frameworkcode, { unsafe > => 1 } ); > > Yes, definitely. > > 3. - my $value = $self->$column; > + my $value = $self->_result()->get_column($column); > > Really faster? 1. Could do that, but that change is a little bit scarier as we don't expire the cache and GetFrameworkCode is used extensively in other places. But could be done in ModBiblio, which is simple enough I guess. Would also speed up other calls to GetFrameworkCode, doubt would have much impact as it's already pretty fast and columns_to_str most likely the only place it makes much of a difference, but you never know. 3. I'm quite surprised myself, but using $self->$column is about 1.4x slower for a biblio with 1400 items. My guess the offending line of code is: if ( grep { $_ eq $method } @columns ) { in AUTOLOAD. Looping over @columns has O(n) time complexity but using a columns_info hash where columns can be looked in O(1) time. Could be wworth looking into in another bug to generally speed up accessing of properties in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:09:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 15:09:03 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-akMOavuNyI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #128 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151087&action=edit Bug 8179: Remove commented code Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:10:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 15:10:36 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-qSdORV38vb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #129 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151088&action=edit Bug 8179: Remove leftover/not used embed definitions Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:11:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 15:11:41 +0000 Subject: [Koha-bugs] [Bug 33406] Searching for authority with hyphen surrounded by spaces causes error 500 (with ES) In-Reply-To: <bug-33406-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33406-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33406-70-eoeQAzHax9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33406 --- Comment #2 from Janusz Kaczmarek <januszop at gmail.com> --- Jonathan, thank you for the patch. I'll test it and it most probably will do its job. At the same time, I'm not quite sure if all we can do is to catch error. IMHO it will be rather surprising for an librarian to see information about an error and a prompt to try again while searching (with default settings) for an existing authority (and hyphens surrounded by spaces normally occur e.g. in corporate names or in series titles). Couldn't we, retaining the catching mechanism, also add somehow a correction like this: --- a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm +++ b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm @@ -1228,6 +1228,8 @@ sub _split_query { # Filter out empty values @tokens = grep( /\S/, @tokens ); + # Filter out some known isolated trouble makers: -, ^, \, ~, + + @tokens = grep( !/^[-\^\\~\+]*$/, @tokens ); return @tokens; } [The auth 'contains' query goes always through _split_query which is called by _truncate_terms] This would prevent most known issues to emerge. (I was unable, due to lack of time, to prepare the official patch by myself). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:11:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 15:11:59 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-sLpqHQ7tIH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #130 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151089&action=edit Bug 8179: Fix JS indentation in parcel.tt Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:38:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 15:38:47 +0000 Subject: [Koha-bugs] [Bug 27976] Add Granular options to CircConfirmItemParts In-Reply-To: <bug-27976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27976-70-aKnPFEd7qP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27976 koha-US bug tracker <bugzilla at koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:39:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 15:39:07 +0000 Subject: [Koha-bugs] [Bug 30519] Regression: using sys pref CircConfirmItemParts prevents checkin from moremember.pl and circulation.pl In-Reply-To: <bug-30519-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30519-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30519-70-3cp9mStUj0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 koha-US bug tracker <bugzilla at koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:39:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 15:39:17 +0000 Subject: [Koha-bugs] [Bug 30995] Bug 29504 - Confirm item parts requires force_checkout permission (batch checkout) In-Reply-To: <bug-30995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30995-70-b34XrxWgdM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30995 koha-US bug tracker <bugzilla at koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:39:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 15:39:34 +0000 Subject: [Koha-bugs] [Bug 33700] Allow setting for CircConfirmItemParts to checkout via self check In-Reply-To: <bug-33700-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33700-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33700-70-J0nHO7Jfx9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33700 koha-US bug tracker <bugzilla at koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 17:40:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 15:40:30 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-hQ8YAEEDHk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 --- Comment #10 from David Gustafsson <glasklas at gmail.com> --- No, the loop is not it, I think AUTOLOAD in itself is slow, perhaps parsing of method name etc. I think there are techniques to speed this up by lazily defining actual setter/getter methods on AUTOLOAD, and could be worth looking into. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:11:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:11:50 +0000 Subject: [Koha-bugs] [Bug 33713] Report batch operations should open in new tab In-Reply-To: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33713-70-78RI9xXH3K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33713 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:16:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:16:06 +0000 Subject: [Koha-bugs] [Bug 32924] Filter agreements by logged in librarian In-Reply-To: <bug-32924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32924-70-djadBoC5wh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32924 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:17:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:17:08 +0000 Subject: [Koha-bugs] [Bug 32924] Filter agreements by logged in librarian In-Reply-To: <bug-32924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32924-70-HefXUfxYbP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32924 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- For 22.11.06 I've decided to incorporate the majority of ERM improvements.. a lot of work has gone into improving ERM this cycle and for long term maintenance I think it makes sense to include these changes at this stage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:18:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:18:07 +0000 Subject: [Koha-bugs] [Bug 33466] Link vendor name in list of licenses In-Reply-To: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33466-70-2UFlIteaSq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |Pushed to master --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- For 22.11.06 I've decided to incorporate the majority of ERM improvements.. a lot of work has gone into improving ERM this cycle and for long term maintenance I think it makes sense to include these changes at this stage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:19:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:19:13 +0000 Subject: [Koha-bugs] [Bug 32924] Filter agreements by logged in librarian In-Reply-To: <bug-32924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32924-70-gRAOUPFcGy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32924 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:19:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:19:15 +0000 Subject: [Koha-bugs] [Bug 32924] Filter agreements by logged in librarian In-Reply-To: <bug-32924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32924-70-bCwAM13f67@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32924 --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:19:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:19:16 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-0apdoSfYC2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:19:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:19:18 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-S89vBh6ZZx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #104 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:19:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:19:21 +0000 Subject: [Koha-bugs] [Bug 33466] Link vendor name in list of licenses In-Reply-To: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33466-70-plL1n53DYr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:19:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:19:22 +0000 Subject: [Koha-bugs] [Bug 33466] Link vendor name in list of licenses In-Reply-To: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33466-70-vlwZ4Ariwz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:19:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:19:24 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-bAHdN1qGMn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:19:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:19:26 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-TaAx5rtkH7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:19:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:19:28 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-ezIrjNVG0C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:19:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:19:29 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-B3Utny0uUT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:22:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:22:57 +0000 Subject: [Koha-bugs] [Bug 32924] Filter agreements by logged in librarian In-Reply-To: <bug-32924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32924-70-ysYKSRZzSd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32924 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:23:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:23:07 +0000 Subject: [Koha-bugs] [Bug 33466] Link vendor name in list of licenses In-Reply-To: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33466-70-SBavSJVFSJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:23:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:23:18 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-7oSaGxtOtZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:28:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:28:17 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-TiAHtfYBdc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 --- Comment #11 from David Gustafsson <glasklas at gmail.com> --- This actually speeds speeds up so that calling the property method directly is as fast as$self->_result()->get_column($column) if ( grep { $_ eq $method } @columns ) { # if ( @_ ) { # $self->_result()->set_column( $method, @_); # return $self; #} else { # my $value = $self->_result()->get_column( $method ); # return $value; #} no strict 'refs'; *{$AUTOLOAD} = sub { my $self = shift; if ( @_ ) { $self->_result()->set_column( $method, @_); return $self; } else { my $value = $self->_result()->get_column( $method ); return $value; } }; This lazily defined new methods in the symbol table, and next time that method will be called instead of AUTOLOAD. Will have a look at creating another bug for this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:30:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:30:46 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-gLMgPL1L0D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 --- Comment #12 from David Gustafsson <glasklas at gmail.com> --- Accidentally omitted goto &{$AUTOLOAD}; which should be on the last line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:38:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:38:58 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-BHX5qiZ8rD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:45:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:45:15 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-T81nu83AXW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 --- Comment #13 from David Gustafsson <glasklas at gmail.com> --- And about 3. above, it was poorly formulated, I meant that using $self->$column results in the page taking 40% longer to generate, not that $self->$column is %40 more expensive than get_column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 18:48:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 16:48:21 +0000 Subject: [Koha-bugs] [Bug 33390] Expand links to authorized values interface when an authval is mentioned in preferences In-Reply-To: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33390-70-2WXRX9qO0q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 --- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #12) > I tried to provide some more context in a few spots. Lucas, if you hate it, > please feel free to obsolete :) It looks great to me!! Thanks for the follow-ups! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 19:10:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 17:10:50 +0000 Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version In-Reply-To: <bug-23073-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23073-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23073-70-VYCVWaJ4uj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 --- Comment #38 from Thomas Dukleth <td-koha-bugs at agogme.com> --- Wiki account creation bypassing the ConfirmAccount extension was possible when email from the container was working due to a bug for which ConfirmAccount is incompatible with the current version of MediaWiki. Yesterday, I applied the workaround to add to LocalSettings.php. $wgGroupPermissions['*']['createaccount'] = false; Broken email service for the wiki because of complications authenticating to the SMTP server from the Docker container in addition to previous testing configuration remaining in LocalSettings.php meant that there were very few spam accounts created which were actually functional. If the accounts had been functional, we would have found the problem shortly after the upgraded wiki went live. Given the similarity of spam messages and timing there may have only been one or two spammers or spambots even with hundreds of suspicious non-working accounts created. There were about 20 spam accounts which had mostly just created some spam content in the wiki user page for the account and some which created a spam wiki page. 5 accounts before May which did not attract much notice and about 15 from 3 and 4 May which made the problem obvious. All spam content has been deleted and the accounts blocked. Spam accounts were included in recent created users with contributions, https://wiki.koha-community.org/wiki/Special:ListUsers?username=&group=&editsOnly=1&creationSort=1&desc=1&wpsubmit=&wpFormIdentifier=mw-listusers-form&limit=50 . Thanks to Katrin Fischer and especially David Nind for blocking a few hundred accounts which had almost all likely never functioned but had been created automatically until the bug in ConfirmAccount had the workaround applied and could have been activated. I paused after the first hundred or so such accounts. Suspected spam accounts were included in all recently created users, https://wiki.koha-community.org/wiki/Special:ListUsers?username=&group=&creationSort=1&desc=1&wpsubmit=&wpFormIdentifier=mw-listusers-form&limit=50 . We used a manual process one account at a time to block suspicious accounts. Legitimate accounts with contributions could be recognised but it is possible that we inadvertently blocked a legitimate user account which had not yet been used to create content. David Nind proposed to write a message to the mailing list informing anyone who might have been inadvertently affected to raise attention to their account being improperly blocked. The Wikimedia Foundation uses the UserCheck extension to help manage spam account blocking but it is not working properly inside the Koha Docker container where all users appear to have logged in from the same local IP address instead of an external IP address. Other extensions which had helped in combating WikiMedia spam no longer function or do not scale better than the manual process which we used. Direct database manipulation to block accounts could be possible but would need extra careful checking and the problem was small enough to manage manually via the web user interface. Using Docker is nice but there are some Docker specific bugs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 20:04:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 18:04:51 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-zwYGd1QAOs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150898|0 |1 is obsolete| | --- Comment #30 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 151090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151090&action=edit Bug 33117: New System Preference PatronAutoCompleteSearchMethod Still working on this -- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 20:24:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 18:24:25 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-tbUqERlJDV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/681 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 20:24:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 18:24:26 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-VUxrfc9DtC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Bug 33104 depends on bug 33103, which changed state. Bug 33103 Summary: Add vendor aliases https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 20:24:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 18:24:26 +0000 Subject: [Koha-bugs] [Bug 33480] Improve display of the vendor aliases in the ERM module In-Reply-To: <bug-33480-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33480-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33480-70-cZ6lGeGXe3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33480 Bug 33480 depends on bug 33103, which changed state. Bug 33103 Summary: Add vendor aliases https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 20:25:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 18:25:45 +0000 Subject: [Koha-bugs] [Bug 32988] Cannot clear guarantor with clear link In-Reply-To: <bug-32988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32988-70-1CicugWrQE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32988 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> --- Never mind. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 20:43:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 18:43:39 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-cBg7afkCms@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 --- Comment #31 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 151091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151091&action=edit Bug 33117: Adding new system preference for patron searching -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 20:44:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 18:44:08 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-f7af5aEB2T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151090|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 20:44:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 18:44:52 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-LiIhyETo0m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #131 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151092&action=edit Bug 8179: Cosmetic changes Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 20:44:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 18:44:57 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-xqIiW7qN6I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #132 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151093&action=edit Bug 8179: Fund required -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 21:00:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 19:00:17 +0000 Subject: [Koha-bugs] [Bug 29335] CheckinSlip should be configurable to prpvide only checkouts in a time period In-Reply-To: <bug-29335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29335-70-7VWMDwvkh1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29335 Rebecca Coert <rcoert at arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us --- Comment #2 from Rebecca Coert <rcoert at arlingtonva.us> --- Agreed! This would be a useful feature for both the CHECKINSLIP and ISSUEQSLIP. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 21:02:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 19:02:32 +0000 Subject: [Koha-bugs] [Bug 27976] Add Granular options to CircConfirmItemParts In-Reply-To: <bug-27976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27976-70-jCGlutneN7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27976 Rebecca Coert <rcoert at arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us --- Comment #4 from Rebecca Coert <rcoert at arlingtonva.us> --- This would be an extremely helpful feature! Agree with the group that limiting by itemtype would be the preferred way to do this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 21:22:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 19:22:34 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33462-70-UZprUm3GMX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 --- Comment #3 from Christopher Brannon <cbrannon at cdalibrary.org> --- Probably the easiest way to implement this would be to have both a global and patron category enable/disable setting for new patrons created by staff option. If enabled, when you are entering a new patron on the staff side, the password expiration date would be defaulted to expired as the account is created. Any other edits would ignore this setting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 21:45:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 19:45:40 +0000 Subject: [Koha-bugs] [Bug 33093] (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase' In-Reply-To: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33093-70-bdBuIFT9vt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33093 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 21:49:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 19:49:02 +0000 Subject: [Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results In-Reply-To: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28884-70-V99UaxMMCP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #16 from Galen Charlton <gmcharlt at gmail.com> --- Since this remains a definite usability issue, would it be sufficient to get a fix in place by adding a system preference? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 21:57:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 19:57:23 +0000 Subject: [Koha-bugs] [Bug 33053] Tables item_groups and recalls have a biblio_id column with a default of 0 In-Reply-To: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33053-70-7Xd2miCf3x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33053 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151094&action=edit Bug 33053: Handle invalid biblio_id more robustly This patch addresses the fact the invalid FK error might differ under some circumstances. We could try to catch the exception adding another case, but I think this pattern is cleaner and the authors didn't provide a fix. We can discuss it later, as this controller class has several things to review. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 22:27:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 20:27:11 +0000 Subject: [Koha-bugs] [Bug 32705] Display actual cost in foreign currency and currency from the invoice In-Reply-To: <bug-32705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32705-70-gBVXLOPkvj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Bug 32705 depends on bug 25655, which changed state. Bug 25655 Summary: Additionally store actual cost in foreign currency and currency from the invoice https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 22:27:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 20:27:10 +0000 Subject: [Koha-bugs] [Bug 25655] Additionally store actual cost in foreign currency and currency from the invoice In-Reply-To: <bug-25655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25655-70-Uq44EwjT17@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #52 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Not sure what needs documenting here. It seems to be only backend changes. I'll close, but feel free to add details if the manual needs to be changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 22:30:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 20:30:32 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-UKRgEtkgmw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141161|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 22:30:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 20:30:37 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-LhYndpzg1s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141162|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 22:30:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 20:30:42 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-DuudQds0vC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141163|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 22:30:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 20:30:47 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-G1pueqB5Js@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141164|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 22:35:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 20:35:17 +0000 Subject: [Koha-bugs] [Bug 22839] Manual screenshots and description in Acquisition (Funds) are outdated In-Reply-To: <bug-22839-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22839-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22839-70-ipRR6q4ppk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22839 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I'm closing this since I recently redid all screenshots in the acquisitions module. (and also because I cannot find the cited text https://koha-community.org/manual/23.05/en/html/acquisitions.html) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 22:38:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 20:38:39 +0000 Subject: [Koha-bugs] [Bug 29252] Document the uses of 942c (MARC21) In-Reply-To: <bug-29252-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29252-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29252-70-iYvrbnhTY0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29252 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- This was done a while ago. https://koha-community.org/manual/23.05/en/html/cataloging.html#c-koha-item-type -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 11 22:39:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 20:39:47 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-4EVpVgq18V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141157|0 |1 is obsolete| | --- Comment #153 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151095&action=edit Bug 17385: Add custom export XSLT Rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 22:39:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 20:39:54 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-6YDoYoFTjZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141158|0 |1 is obsolete| | --- Comment #154 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151096&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 22:40:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 20:40:01 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-aqhNf177mY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141159|0 |1 is obsolete| | --- Comment #155 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151097&action=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 22:40:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 20:40:08 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-CwGAVigq21@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141160|0 |1 is obsolete| | --- Comment #156 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151098&action=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : <pre> $ prove -l t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. 1/3 # Failed test 'This list comes from the cache and that is fine' # at t/db_dependent/XSLT.t line 122. # got: '1' # expected: '2' # Looks like you failed 1 test of 1. # Failed test 'CustomXSLTExportList: Caching' # at t/db_dependent/XSLT.t line 124. # Looks like you failed 1 test of 3. t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report ------------------- t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.74 cusr 0.14 csys = 1.91 CPU) Result: FAIL </pre> This one works fine : <pre> $ prove -l t/XSLT.t t/XSLT.t .. ok All tests successful. Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.55 cusr 0.17 csys = 2.74 CPU) Result: PASS </pre> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 22:40:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 20:40:15 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-2aCK24v1uf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #157 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151099&action=edit Bug 17385: (Fix) Add custum export format option to the cart and the lists and fix tests for CustomXSLTExportList This patch adds 'XSL-Simple Export' to the cart and the lists and correct the fail test in t/XSLT.t it contains Add custum export format option when saving a record TO TEST: Before applying: 1) Search for a record in the intranet. 2) Click on the 'Save' button and observe the dropdown menu. --> There is no 'XSL- Simple Export' in the dropdown menu. 3) Apply the patch. 4) In System preferences search for OpacExportOptions and enable XSL 5) Repeat the steps 1 and 2. ---> There is now 'XSL- Simple Export' option in the dropdown menu 6) Click on 'XSL - Simple Export'. a .html file should be downloaded. 7) Open the .html file. You should see the record's informations. 8) Add some items to your Cart 9) Open the Cart 10) Click on the 'Download' and 'XSL - Simple Export'. ----> a .html file should be downloaded. ----> you should see the record's informations in the downloaded file. 11) Add some items to a List 12) Open the List 13) Click on the 'Download' and 'XSL - Simple Export'. ----> a .html file should be downloaded. ----> you should see the record's informations in the downloaded file. 14) Do the same steps in OPAC ----> a .html file should be downloaded. ----> you should see the record's informations in the downloaded file. 15) In System preferences search for OpacExportOptions and disable XSL 16) Repeat all steps 17) Notice that 'XSL - Simple Export' is no more in the menus. 18) Run prove -l t/XSLT.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 22:40:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 20:40:54 +0000 Subject: [Koha-bugs] [Bug 7840] Remove from manual Koha as a CMS (or add it to master) In-Reply-To: <bug-7840-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7840-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7840-70-mpHma87NRJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7840 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #15 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- This has been done for a while, closing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 22:42:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 20:42:42 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-lODsSbNudO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 22:48:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 20:48:29 +0000 Subject: [Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results In-Reply-To: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28884-70-Ala6PNK9xi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 --- Comment #17 from Galen Charlton <gmcharlt at gmail.com> --- And to clarify what I mean, a new system preference that is just about the ES wildcard/truncation characters and permits different behavior in staff and OPAC? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 22:50:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 20:50:29 +0000 Subject: [Koha-bugs] [Bug 33721] New: Show inactive funds in invoice.tt out of order Message-ID: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Bug ID: 33721 Summary: Show inactive funds in invoice.tt out of order Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org Created attachment 151100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151100&action=edit Screenshot of the invoice section with the fund line When viewing an invoice, the elements in the 'Fund' line are out of order. The is the 'Fund:' label, followed by 'Show inactive:' label, then the fund drop-down and then the show inactive checkbox. The order should be 'Fund:' label, fund drop-down, 'Show inactive:' label, show inactive checkbox. To recreate: 1. In acquisitions, create an order and close the basket 2. Click 'Receive shipment' and receive the order 3. Click 'Finish receiving' --> The Fund line in invoice.tt is out of order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 22:59:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 20:59:44 +0000 Subject: [Koha-bugs] [Bug 29935] Add option to search in archive to all information tabs In-Reply-To: <bug-29935-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29935-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29935-70-R09OlOKWqh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29935 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/681 CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 23:01:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 21:01:19 +0000 Subject: [Koha-bugs] [Bug 32975] Error in package.json's definition of css:build vs css:build:prod In-Reply-To: <bug-32975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32975-70-Q44hwpPCQi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose at inlibr | |o.com Status|Needs documenting |RESOLVED --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- This seems to be backend stuff, nothing to be added to the manual. I will close, but feel free to add details as to what needs to be documented, and I will add it to the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 23:01:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 21:01:19 +0000 Subject: [Koha-bugs] [Bug 32978] 'npm install' fails in ktd on aarch64, giving unsupported architecture error for node-sass In-Reply-To: <bug-32978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32978-70-1gMFMzWnjl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32978 Bug 32978 depends on bug 32975, which changed state. Bug 32975 Summary: Error in package.json's definition of css:build vs css:build:prod https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 23:01:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 21:01:20 +0000 Subject: [Koha-bugs] [Bug 32994] Remove compiled files from src (2) In-Reply-To: <bug-32994-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32994-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32994-70-8viSA0TbcW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Bug 32994 depends on bug 32975, which changed state. Bug 32975 Summary: Error in package.json's definition of css:build vs css:build:prod https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 23:16:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 21:16:40 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-7xfZbYhvZM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 23:16:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 21:16:42 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-4RIEsz9eCW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151075|0 |1 is obsolete| | --- Comment #7 from David Nind <david at davidnind.com> --- Created attachment 151101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151101&action=edit Bug 33718: Fix the mock of Koha::Config->get in mock_config It should not mock calls for other sections than 'config' in koha-conf.xml. Test plan: Without this patch: [1] Enable CatalogModuleRelink and LinkerRelink. This will trigger a SearchAuthorities call when creating a sample biblio. Note: SearchAuthorities calls Zconn and gets back information from a wrong part of koha-conf.xml. [2] Run t/db_dependent/Koha/Pseudonymization.t You should see something like: {UNKNOWN}: Can't use string ("authorities") as a HASH ref while "strict refs" in use at /usr/share/koha/C4/Context.pm line 587. at /usr/share/koha/C4/Biblio.pm line 302 With this patch: [3] Run t/db_dependent/Koha/Pseudonymization.t. Should pass now. [4] git grep -l mock_config | xargs -i{} prove {} Exclude Mocks.pm. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 23:19:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 21:19:21 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-CdeZ0RCkXL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #8 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. I had to enable AutoLinkBiblios to get the error message in step 2 (see comment 59 in bug 33277). 2. Tests pass with no errors after applying the patch. 3. For step 4, I ran: git grep -l mock_config | xargs -i{} prove {} => lots of tests are run and these should all pass except for t/lib/Mocks.pm t/lib/Mocks.pm .. No subtests run Test Summary Report ------------------- t/lib/Mocks.pm (Wstat: 0 Tests: 0 Failed: 0) Parse errors: No plan found in TAP output Files=1, Tests=0, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.16 cusr 0.03 csys = 0.20 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 23:50:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 21:50:01 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-ZBNomx6wfM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 23:50:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 21:50:06 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-0ffvFFWv43@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151095|0 |1 is obsolete| | --- Comment #158 from David Nind <david at davidnind.com> --- Created attachment 151102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151102&action=edit Bug 17385: Add custom export XSLT Rebase Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 23:50:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 21:50:10 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-nVo6oPOqT0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151096|0 |1 is obsolete| | --- Comment #159 from David Nind <david at davidnind.com> --- Created attachment 151103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151103&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 23:50:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 21:50:15 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-086cwIfmAG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151097|0 |1 is obsolete| | --- Comment #160 from David Nind <david at davidnind.com> --- Created attachment 151104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151104&action=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 23:50:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 21:50:19 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-yyrasAal3n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151098|0 |1 is obsolete| | --- Comment #161 from David Nind <david at davidnind.com> --- Created attachment 151105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151105&action=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : <pre> $ prove -l t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. 1/3 # Failed test 'This list comes from the cache and that is fine' # at t/db_dependent/XSLT.t line 122. # got: '1' # expected: '2' # Looks like you failed 1 test of 1. # Failed test 'CustomXSLTExportList: Caching' # at t/db_dependent/XSLT.t line 124. # Looks like you failed 1 test of 3. t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report ------------------- t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.74 cusr 0.14 csys = 1.91 CPU) Result: FAIL </pre> This one works fine : <pre> $ prove -l t/XSLT.t t/XSLT.t .. ok All tests successful. Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.55 cusr 0.17 csys = 2.74 CPU) Result: PASS </pre> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 11 23:50:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 21:50:24 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-COhQ8hhZkJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151099|0 |1 is obsolete| | --- Comment #162 from David Nind <david at davidnind.com> --- Created attachment 151106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151106&action=edit Bug 17385: (Fix) Add custum export format option to the cart and the lists and fix tests for CustomXSLTExportList This patch adds 'XSL-Simple Export' to the cart and the lists and correct the fail test in t/XSLT.t it contains Add custum export format option when saving a record TO TEST: Before applying: 1) Search for a record in the intranet. 2) Click on the 'Save' button and observe the dropdown menu. --> There is no 'XSL- Simple Export' in the dropdown menu. 3) Apply the patch. 4) In System preferences search for OpacExportOptions and enable XSL 5) Repeat the steps 1 and 2. ---> There is now 'XSL- Simple Export' option in the dropdown menu 6) Click on 'XSL - Simple Export'. a .html file should be downloaded. 7) Open the .html file. You should see the record's informations. 8) Add some items to your Cart 9) Open the Cart 10) Click on the 'Download' and 'XSL - Simple Export'. ----> a .html file should be downloaded. ----> you should see the record's informations in the downloaded file. 11) Add some items to a List 12) Open the List 13) Click on the 'Download' and 'XSL - Simple Export'. ----> a .html file should be downloaded. ----> you should see the record's informations in the downloaded file. 14) Do the same steps in OPAC ----> a .html file should be downloaded. ----> you should see the record's informations in the downloaded file. 15) In System preferences search for OpacExportOptions and disable XSL 16) Repeat all steps 17) Notice that 'XSL - Simple Export' is no more in the menus. 18) Run prove -l t/XSLT.t Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 00:24:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 22:24:04 +0000 Subject: [Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results In-Reply-To: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28884-70-53ejS0R2kN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 --- Comment #18 from Janusz Kaczmarek <januszop at gmail.com> --- I'm not sure if I would like to have one preference (even if in two incarnations: OPAC and staff) switching off all the ES wildcard and truncation special characters... From some months of experience with Koha + ES I would say, it is '/' and '?' (sometimes also '!') that are problematic. There is no problem with most useful '*' or '~' -- even if unconsciously used by a user. >From my perspective it would be best to have the special meaning of '?', '/', '!' switched off by default, while '*' and '~' enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 01:16:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 23:16:42 +0000 Subject: [Koha-bugs] [Bug 33722] New: Cannot see existing public lists from virtualshelves/addbybiblionumber.pl Message-ID: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 Bug ID: 33722 Summary: Cannot see existing public lists from virtualshelves/addbybiblionumber.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: 1. Have two users with staff access and lists permissions. ( User A and User B) 2. Create some public lists with User A. Make some that are for staff only and some for everyone. 3. Make sure you create at least 10 different public lists. 4. Log in to the staff interface as user B and search the catalog. 5. Select a few titles and in the toolbar click 'Add to list'. 6. Here you should properly see your lists and any public lists which you can edit. 7. If you have more than 10 lists you won't see them all in this dropdown. 8. At the bottom of the dropdown you should see 'More lists', click it. 9. Notice here you cannot select any of the existing public lists which User B should be able to edit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 01:16:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 23:16:50 +0000 Subject: [Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl In-Reply-To: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33722-70-TPmLMSJTJa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 01:20:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 23:20:56 +0000 Subject: [Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl In-Reply-To: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33722-70-CcIiIOrTHt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 01:20:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 23:20:58 +0000 Subject: [Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl In-Reply-To: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33722-70-cLHDCOx9s4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151107&action=edit Bug 33722: Make public lists viewable for users on virtualshelves/addbybiblionumber.pl To test: 1. Have two users with staff access and lists permissions. ( User A and User B) 2. Create some public lists with User A. Make some that are for staff only and some for everyone. 3. Make sure you create at least 10 different public lists. 4. Log in to the staff interface as user B and search the catalog. 5. Select a few titles and in the toolbar click 'Add to list'. 6. Here you should properly see your lists and any public lists which you can edit. 7. If you have more than 10 lists you won't see them all in this dropdown. 8. At the bottom of the dropdown you should see 'More lists', click it. 9. Notice here you cannot select any of the existing public lists which User B should be able to edit. 10. APPLY PATCH 11. Repeate steps 5 - 8. Now you should be able to edit public lists. 12. Create some private lists with User A and make sure User B cannot see them. 13. PLay with some new lists for User A and change 'Allow changes to contents from' and make sure User B can see the ones they should. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 01:21:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 23:21:21 +0000 Subject: [Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl In-Reply-To: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33722-70-d7hNePUg5J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 01:25:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 23:25:48 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33462-70-Tk4PwdEQqT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28980 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 01:25:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 23:25:48 +0000 Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset after first login In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28980-70-RlalSluncg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33462 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 01:32:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 23:32:25 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-PU3R4HeVmS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #60 from David Cook <dcook at prosentient.com.au> --- (In reply to Mengu Yazicioglu from comment #59) > We upgraded from Debian 9 to Debian 11 and Mariadb 10.1 to 10.5 and it is > not possible to bypass to change related tables row_format to DYNAMIC. I don't understand what you're saying here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 01:32:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 23:32:45 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-4quKkuBohO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Danyon Sewell <danyonsewell at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danyonsewell at catalyst.net.n | |z --- Comment #18 from Danyon Sewell <danyonsewell at catalyst.net.nz> --- Going to be working on the check-in API endpoint now just in case there is already work being done on it, I really should have checked for duplicates before working on the checkout one too but oh well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 01:39:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 May 2023 23:39:02 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-lQahWjC5WO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 02:09:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 00:09:12 +0000 Subject: [Koha-bugs] [Bug 33009] bump Standards-Version to 4.6.2 In-Reply-To: <bug-33009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33009-70-tX5jN2fUwg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33009 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |victor at tuxayo.net --- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> --- If I understand correctly this is just bumping the version while the package isn't in accordance to the standards. We might be okay with this if the changes needed are tedious without much value. Since it's not about having an official Koha package in Debian's repo. But what would be the needed changes? To actually choose what to pick or not. To not miss on something important that might cause issues in the future. I never did Debian packaging so maybe it's totally irrelevant, you tell us Mason. By any chance, does a compliance tool exists so the assessment itself isn't a big task? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 06:07:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 04:07:02 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24401-70-Q50dLxR49v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 --- Comment #3 from Danyon Sewell <danyonsewell at catalyst.net.nz> --- Created attachment 151109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151109&action=edit Bug 24401: REST API: Check-in WIP Updating files to include API endpoints for check-ins Test plan: 1) Apply bug 23336 as there are dependencies in there required for this to work 2) Apply this patch 3) Run unit tests in t/db_dependent/api/v1/checkouts.t 4) Make POST request to http://yourlibrary/api/v1/checkouts with request body containing 'item_id' & 'library_id' properties. - Observe returned data and HTTP code - 201 for item checked in - 403 for check in not allowed - 409 for Item not found - 400 for item not checked out Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 06:10:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 04:10:32 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24401-70-sGVBCL5CQx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 Danyon Sewell <danyonsewell at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danyonsewell at catalyst.net.n | |z Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:12:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 06:12:49 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-pqcGdB6cLl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to David Nind from comment #8) Thx David. > 1. I had to enable AutoLinkBiblios to get the error message in step 2 (see > comment 59 in bug 33277). I checked my setup. Yes, I had it enabled. Good catch. > t/lib/Mocks.pm .. No subtests run Yes, that was expected :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:14:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 06:14:59 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-RuPXc4LGFa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151101|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151110&action=edit Bug 33718: Fix the mock of Koha::Config->get in mock_config It should not mock calls for other sections than 'config' in koha-conf.xml. Test plan: Without this patch: [1] Enable AutoLinkBiblios, CatalogModuleRelink and LinkerRelink. This will trigger a SearchAuthorities call when creating a sample biblio. Note: SearchAuthorities calls Zconn and gets back information from a wrong part of koha-conf.xml. [2] Run t/db_dependent/Koha/Pseudonymization.t You should see something like: {UNKNOWN}: Can't use string ("authorities") as a HASH ref while "strict refs" in use at /usr/share/koha/C4/Context.pm line 587. at /usr/share/koha/C4/Biblio.pm line 302 With this patch: [3] Run t/db_dependent/Koha/Pseudonymization.t. Should pass now. [4] git grep -l mock_config | xargs -i{} prove {} Exclude Mocks.pm. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:15:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 06:15:23 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-mwBLe59XOQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Updated the test plan for pref AutoLinkBiblios. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:37:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 06:37:22 +0000 Subject: [Koha-bugs] [Bug 33720] koha-upgrade-schema should restart memcached In-Reply-To: <bug-33720-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33720-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33720-70-mJ3jEa4uk1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33720 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- If we need a flush a can call bin/flush_memcached -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 08:39:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 06:39:38 +0000 Subject: [Koha-bugs] [Bug 33720] koha-upgrade-schema should restart memcached In-Reply-To: <bug-33720-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33720-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33720-70-NJNuaA31rS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33720 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Another solution would be to retrieve the value from the DB in updatedatabase.pl 74 my $original_version = C4::Context->preference("Version"); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:13:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 07:13:04 +0000 Subject: [Koha-bugs] [Bug 33642] Typo: No log found . In-Reply-To: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33642-70-Jux8VFGSNA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33642 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:13:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 07:13:06 +0000 Subject: [Koha-bugs] [Bug 33642] Typo: No log found . In-Reply-To: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33642-70-coL3rocsCQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33642 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150975|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151115&action=edit Bug 33642: Fix 'No log found.' in viewlog It should ease translatability and remove an extra space. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:13:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 07:13:17 +0000 Subject: [Koha-bugs] [Bug 33642] Typo: No log found . In-Reply-To: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33642-70-JyJmwJnq6v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33642 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:19:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 07:19:58 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-FKE5oqZF3B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Looking here, although I feel that this patch is somewhere between bug and enh actually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:20:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 07:20:11 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-ifj6Iwmpj0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:25:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 07:25:56 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33335-70-36DxcV2Igx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150521|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151116&action=edit Bug 33335: Use To.json to serialize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:26:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 07:26:26 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33335-70-GaOz6E9NY8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:26:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 07:26:35 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33335-70-vSJ7HEwJwv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- My last try here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:31:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 07:31:18 +0000 Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to server side filtering In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-AHWhEpAc4J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:31:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 07:31:20 +0000 Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to server side filtering In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-SIhsXEhc6P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:34:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 07:34:45 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-ks0M4SG1yy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Looking at what remains for first_valid_email i would opt for removing the OFF option of EmailFieldPrimary and default it to the email field. Here it is only used as boolean: $params->{is_email_required} = 0 unless $self->first_valid_email_address(); Koha/SharedContent.pm: $mana_email = $borrower->first_valid_email_address This one could be replaced imo by notice_email. But yes, not here :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:42:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 07:42:43 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-ey60S1RQYA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:42:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 07:42:45 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-ZfRMlbyhyv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151041|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151117&action=edit Bug 33223: Replace 'first_valid' with 'notice' for email addresses This patch replaces the uses of first_valid_email_address with notice_email_address in waiting_holds, transferstoreceive, clubs and sendbasket so that we take EmailFieldPrimary into account for these notices too. Signed-off-by: David Cook <dcook at prosentient.com.au> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 09:42:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 07:42:48 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-TcPfCLwKAy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151042|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151118&action=edit Bug 33223: Fix sendshelf Two new occurences of first_valid crept in, this patch corrects those to also use notice_ Signed-off-by: David Cook <dcook at prosentient.com.au> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:38:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 08:38:50 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33335-70-FERxXdfVrB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:38:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 08:38:52 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33335-70-Cvt9WjWx6U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149253|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151119&action=edit Bug 33335: Fix JavaScript error on the MARC overlay rules page The "MARC overlay rules" page doesn't display or work correctly if a patron category code contains a "-". This happens because of the JavaScript function in "marc-overlay-rules.tt" line 469. This causes an error "Uncaught SyntaxError: missing : after property id". Test plan: 1. Go to Administration > Patron categories. 2. Make sure you don't have a patron category code that contains a "-". 3. Go to Administration > Record overlay rules. 4. The table should display correctly, and you can add, edit and delete rules. 5. Return to Patron categories. 6. Add a new patron category with a "-" in the patron category code. 7. Return to Record overlay rules page: => The page doesn't display and load correctly (see the attached image) - the normal DataTables header and footer aren't displayed, and you can't add, edit or delete overlay rules. => If you turn on web developer tools, an error is displayed in the console: "Uncaught SyntaxError: missing : after property id". 8. Apply the patch. 9. Repeat the step 7, the Record overlay rules page should now display correctly and you should be able to add, edit and delete rules. 10. Sign off. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:38:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 08:38:55 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33335-70-sfwCe7lx53@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151116|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151120&action=edit Bug 33335: Use To.json to serialize Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:38:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 08:38:57 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33335-70-Pfoc37tw5z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151121&action=edit Bug 33335: (QA follow-up) Polishing and comments Just send the codes and descriptions only to client. Adding a few comments to the reduce construction. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:39:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 08:39:09 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33335-70-Zln2G9mWDH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:44:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 08:44:02 +0000 Subject: [Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence) In-Reply-To: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33699-70-md8veQxZZa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:44:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 08:44:05 +0000 Subject: [Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence) In-Reply-To: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33699-70-Hb2GMca64p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151017|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151122&action=edit Bug 33699: Typo in identity_provider_domains.tt (presedence) This patch corrects the typo "presedence" with "precedence." The patch also corrects some grammar: "so if the 'library.com' domain will take presedence over '*library.com'" ...changed to... "so 'library.com' domain will take presedence over '*library.com'" I also changed the <div>s inside that block of help text to <p> in order to improve legibility. To test, apply the patch and go to Administration -> Identity providers -> Manage domains (on an existing provider) -> Edit, and click the "More" button under the "Domain" field. Confirm that the text is correct. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:44:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 08:44:12 +0000 Subject: [Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence) In-Reply-To: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33699-70-CCCsCieyAZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:48:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 08:48:11 +0000 Subject: [Koha-bugs] [Bug 33496] Add 'host_items' param to Koha::Biblio->items In-Reply-To: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33496-70-kGC47avEpS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33496 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Marking as enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:49:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 08:49:45 +0000 Subject: [Koha-bugs] [Bug 33471] Improve performance of hold pickup location verification for next available holds In-Reply-To: <bug-33471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33471-70-yEToOTye4r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33471 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Severity|normal |enhancement --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Marking as enh -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:53:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 08:53:54 +0000 Subject: [Koha-bugs] [Bug 29993] Syndetics cover images do not display in browse shelf when scrolling from the first page In-Reply-To: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29993-70-HAQvqBpt7l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:55:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 08:55:28 +0000 Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for branchtransfers In-Reply-To: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33493-70-wlj7M5MpLx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Back to SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:56:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 08:56:43 +0000 Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for branchtransfers In-Reply-To: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33493-70-RLHVNa5kPV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Sorry but again marking as enh -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 10:58:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 08:58:59 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-U6CW9a4OVM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Processing additional checks * Commit title does not start with 'Bug XXXXX: ' - b097a2bf40 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:07:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 09:07:28 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-ws0ku6WSFV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- No blocker, but it is a bit obscure how the values of this option work. The documentation is quite poor.. The name could be improved too? + my $seen = $account->{seen_on_item_information}; + ModDateLastSeen( $item->itemnumber, $seen eq 'keep_lost' ) if $seen; + seen_on_item_information="mark_found"> <!-- could be "keep_lost", empty to disable --> Nevertheless passing QA to fix a regression. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:07:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 09:07:51 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-OsEMcWZqvI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:07:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 09:07:53 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-y3S7Y1gn67@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150113|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151123&action=edit Bug 33580 - Bring back ability to mark item as seen via SIP2 item information request Prior to Koha 22.05, the SIP2 item information message had a side affect of updating the datelastseen field for items. This bug has been fixed, but was being utilized by inventory tools that used SIP2. We should bring back this affect and formalize it as an optional SIP2 config account setting. Test Plan: 1) Apply this patch set 2) prove t/db_dependent/SIP/Message.t Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:08:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 09:08:02 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-v5oDjoEidp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:14:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 09:14:00 +0000 Subject: [Koha-bugs] [Bug 32995] Koha agent string not sent for OverDrive fulfillment requests In-Reply-To: <bug-32995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32995-70-MOEESkZruP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32995 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:14:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 09:14:02 +0000 Subject: [Koha-bugs] [Bug 32995] Koha agent string not sent for OverDrive fulfillment requests In-Reply-To: <bug-32995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32995-70-nbbhLfcIhw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32995 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150182|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151124&action=edit Bug 32995: Pass user agent string for OverDrive fulfillment This patch simply adds the string Koha/VERSION to the fulfillment request TO test: 1 - Have OverDrive credentials for testing 2 - Enable all the overdrive options in system preferences 3 - Sign in to opac with an overdrive user and verify you can checkout and download titles 4 - Sign off Signed-off-by: Magnus Enger <magnus at libriotech.no> Not tested with OverDrive, but change looks harmless enough. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:14:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 09:14:16 +0000 Subject: [Koha-bugs] [Bug 32995] Koha agent string not sent for OverDrive fulfillment requests In-Reply-To: <bug-32995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32995-70-Htz4ZdqniE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32995 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:29:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 09:29:50 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-xZHJFmdJDs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:29:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 09:29:52 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-mMosLvEmD7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150473|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151125&action=edit Bug 33445: Pass through form info if present and use record values otherwise This patch updates the form to pass through values formthe form when searching, and to use record values if nothing is passed in. TO test: 1 - Without the patch, edit a personal name authority record 2 - Replace 100 subfield a (200 subfield a for UNIMARC) with your own name 3 - Click "Replace record via Z39.50/SRU search" 4 - Note that prefilled search field contains the original value, not your name. 5 - Replace the Author (personal) field with your name in the search form 6 - choose a search target, and click Search. 7 - Note that the results of the search are for the original value, not your name 8 - From the details page of a record, click 'Edit -> Replace record via Z3950' 9 - Note form is prefilled 10 - Change value as in 5 and search 11 - Note original term was searched 12 - Apply patch, restart all 13 - Repeat searches as before 14 - Confirm that form is prefilled with record or the updated value 15 - Confirm your entered search terms are always searched Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:29:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 09:29:55 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-SUiZ8V2wha@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150474|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151126&action=edit Bug 33445: (follow-up) Pass form values through when clicking 'Try another search' We didn't include anything except the authid id in the try again form, this patch extends to cover all the fields Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:29:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 09:29:57 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-INksgpx5Tr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150475|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151127&action=edit Bug 33445: (follow-up) Allow all search fields to be passed through and returned when trying another search It seems the form didn't populate all fields form data passed in. This patch corrects that Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:30:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 09:30:08 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-UiKgnObuCQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:49:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 09:49:38 +0000 Subject: [Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector In-Reply-To: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32993-70-efMexkxw5D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:49:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 09:49:40 +0000 Subject: [Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector In-Reply-To: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32993-70-RvSgWk0HeG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150803|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151128&action=edit Bug 32993: Holds priority changed incorrectly with dropdown selector Test Plan: 1) Find record with at least 3 holds. 2) Change first holds priority as 2, Priority is changed to 3. 3) Try to change priority back to 1, Priority is changed to 2. 4) Apply this patch 5) Reload the page 2) Change first holds priority as 2, Priority is changed to 2. 3) Try to change priority back to 1, Priority is changed to 1. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi> Signed-off-by: Hinemoea Viault <hinemoea.viault at inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:50:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 09:50:11 +0000 Subject: [Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector In-Reply-To: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32993-70-YOb6R0uqj3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Attachment #150496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:50:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 09:50:37 +0000 Subject: [Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector In-Reply-To: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32993-70-eGd3T9S0OD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 11:56:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 09:56:55 +0000 Subject: [Koha-bugs] [Bug 30024] link_bibs_to_authorities.pl relies on CatalogModuleRelink In-Reply-To: <bug-30024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30024-70-UOuBbwKZqI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30024 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- What about: C4/Biblio.pm: LinkBibHeadingsToAuthorities( $linker, $record, $frameworkcode, C4::Context->preference("CatalogModuleRelink") || '', undef, $verbose ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 13:02:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 11:02:26 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-PIH3rGTdvs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I think the user/permissions/permify approach is best left to bug 32986. We're mixing requirements here. As for configuration keys themselves.. I'm more torn now.. I can see both sides.. it's really nice to have consistency.. but should that consistency be permission names being consistent across DB/Controller/API/TT vs consistenct between different API endpoints. I like Jonathans suggestion (without permissions added).. but at the same time I can see as we move to more and more vue in the client we may just want to look cross module for preferences and then the overlapping keys could get confusing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 13:17:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 11:17:56 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-gwJxdrRv9I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- How about `/configurations` or `/settings` that returns an array of key:value pair objects... [ { 'ERMModule': true }, { 'ERMProviders': [ 'A', 'B', 'C' ] } ] and we could allow searching on key.. Or perhaps [ { id: 'ERMModule', value: true } { id: 'ERMProviders', value: [ 'A', 'B', 'C' ] } ] What's going to be easiest to use from code whilst also being easy to filter in the API? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 13:27:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 11:27:25 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-3TCnhxlRpP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Clearly different preferences have different security concerns.. perhaps we'd need a new field in the perferences table to denote 'public', 'staff', 'internal' or something to allow things like API keys to require a higher privilege to see on the API? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 13:58:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 11:58:16 +0000 Subject: [Koha-bugs] [Bug 33200] IndependentBranchesTransfers does not prevent holds from creating transfers In-Reply-To: <bug-33200-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33200-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33200-70-DkEfBKPbQT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33200 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148484|0 |1 is obsolete| | --- Comment #8 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151129&action=edit Bug 33200: IndependentBranchesTransfers does not prevent holds from creating transfers This patch don't concider hold made from other branches when IndependentBranchesTransfers is set to Yes and the connected user is not a SuperLibrarian To test, you must have - IndependentBranches, IndependentBranchesPatronModifications and IndependentBranchesTransfers preferences set to Yes - canreservefromotherbranches must be set to Don't allow - Circulation rules that allow holds and checkouts - Two libraries (I used Midway (A) and Centerville (B)) - A record with two items, one at each library, with barcodes, check out the one from library A - Two non-superlibrarian staff user, one in each library, with at least catalogue and holds permissions, this is what I gave them - circulate (all) - catalogue - delete_borrowers - edit_borrowers - reserveforothers (all) 1. Log in to the staff interface with the non-superlibrarian staff user from library A 2. Go to the record with the two items, click 'Place hold' 3. Place a hold for a user, without changing anything (should be for 'next available item') 4. Log out and log back in with the non-superlibrarian staff user from library B 5. Check in the item from library B, which should be available --> Hold is confirmed for patron from library A, transfer is created 6. Click on 'Confirm hold and transfer' 7. Optionally, you can log out and log back in as staff from library A 8. Go to Circulation > Transfers to receive (should this even be available with IndependentBranchesTransfers turned on?) --> Item from other branch is there 9. Apply the patch 10. Create an other record with two items, one at each library, with barcodes, check out the one from library A 11. repeat step 1, 2, 3, 4, 5 --> The 'Hold found' popup is not shown, because there is no hold for this item in the user branch (library B) 12. repeat step 7,8 --> Item from other branch is not there -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 13:58:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 11:58:19 +0000 Subject: [Koha-bugs] [Bug 33200] IndependentBranchesTransfers does not prevent holds from creating transfers In-Reply-To: <bug-33200-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33200-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33200-70-JSPv2CmwiI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33200 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148918|0 |1 is obsolete| | --- Comment #9 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151130&action=edit Bug 33200: (follow-up) Adding Unit test, renaming _Removereserve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:11:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 12:11:04 +0000 Subject: [Koha-bugs] [Bug 32648] Search.t is failing randomly In-Reply-To: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32648-70-udaEmI18u9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Looks like it didn't work 00:19:24 koha_1 | # Failed test 'Item field returned from default XSLT if pref set' 00:19:24 koha_1 | # at t/Search.t line 239. 00:19:24 koha_1 | # found warning: No item at t/Search.t line 186. 00:19:24 koha_1 | # expected to find warning: (?^u:Item here) 00:19:24 koha_1 | # Looks like you failed 1 test of 2. 00:19:24 koha_1 | 00:19:24 koha_1 | # Failed test 'searchResults PassItemMarcToXSLT test' 00:19:24 koha_1 | # at t/Search.t line 248. 00:19:24 koha_1 | # Looks like you failed 1 test of 4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:11:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 12:11:15 +0000 Subject: [Koha-bugs] [Bug 32648] Search.t is failing randomly In-Reply-To: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32648-70-DpWJH80mZb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #8) > Looks like it didn't work > > 00:19:24 koha_1 | # Failed test 'Item field returned from > default XSLT if pref set' > 00:19:24 koha_1 | # at t/Search.t line 239. > 00:19:24 koha_1 | # found warning: No item at t/Search.t line 186. > 00:19:24 koha_1 | # expected to find warning: (?^u:Item here) > 00:19:24 koha_1 | # Looks like you failed 1 test of 2. > 00:19:24 koha_1 | > 00:19:24 koha_1 | # Failed test 'searchResults PassItemMarcToXSLT > test' > 00:19:24 koha_1 | # at t/Search.t line 248. > 00:19:24 koha_1 | # Looks like you failed 1 test of 4. Koha_Master_My8/1213 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 14:33:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 12:33:57 +0000 Subject: [Koha-bugs] [Bug 33667] 'Copy to all libraries' doesn't work on editing holidays In-Reply-To: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33667-70-LheQcQKVSb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33667 --- Comment #4 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> --- Imo, it would probably be far more simpler just to make it work instead of checking every calendar for matching holiday. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:02:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:02:29 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-BHNZ0mtNty@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #61 from Mengu Yazicioglu <mengu at devinim.com.tr> --- (In reply to David Cook from comment #60) > (In reply to Mengu Yazicioglu from comment #59) > > We upgraded from Debian 9 to Debian 11 and Mariadb 10.1 to 10.5 and it is > > not possible to bypass to change related tables row_format to DYNAMIC. > > I don't understand what you're saying here. As you know, if there is a change in database structure, we have to run post installation steps from intranet part. Due to row format issues of some tables, newly added ERM tables in the post installation steps gave many errors saying "Row size too large..." In order to finish upgrade we have to click "Try again" button but first solve the row format issue. In a new terminal, we have to change row_format feature of related tables to DYNAMIC. After solving this issue, we may go through Try again and post database installation steps will pass I hope I am explained well now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:19:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:19:02 +0000 Subject: [Koha-bugs] [Bug 33083] Handle generic collection of records methods In-Reply-To: <bug-33083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33083-70-W4dqmppWpX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33083 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- This seems like only backend stuff, nothing to document. Closing, but feel free to reopen with more details if I'm wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:19:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:19:03 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-KauscpnEVQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 Bug 32735 depends on bug 33083, which changed state. Bug 33083 Summary: Handle generic collection of records methods https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33083 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:19:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:19:04 +0000 Subject: [Koha-bugs] [Bug 32734] REST API: Add a list endpoint for Biblios In-Reply-To: <bug-32734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32734-70-YTnvBCekq9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32734 Bug 32734 depends on bug 33083, which changed state. Bug 33083 Summary: Handle generic collection of records methods https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33083 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:19:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:19:51 +0000 Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32092-70-CXA6V8IMP3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:20:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:20:01 +0000 Subject: [Koha-bugs] [Bug 33321] "Starts With" function when searching for patrons by address is broken In-Reply-To: <bug-33321-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33321-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33321-70-2x4qUZh81x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33321 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |Laura.escamilla at bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:20:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:20:19 +0000 Subject: [Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing In-Reply-To: <bug-33080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33080-70-si5eRA9Tw6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #33 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- This seems like backend stuff only, nothing to document. Closing, but feel free to reopen with more details if I'm wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:20:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:20:20 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-fvYPKTXPu7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 Bug 32735 depends on bug 33080, which changed state. Bug 33080 Summary: Add helpers that return result_set for further processing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:20:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:20:20 +0000 Subject: [Koha-bugs] [Bug 32734] REST API: Add a list endpoint for Biblios In-Reply-To: <bug-32734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32734-70-LLdQkL0iU5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32734 Bug 32734 depends on bug 33080, which changed state. Bug 33080 Summary: Add helpers that return result_set for further processing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:20:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:20:26 +0000 Subject: [Koha-bugs] [Bug 33321] "Starts With" function when searching for patrons by address is broken In-Reply-To: <bug-33321-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33321-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33321-70-Yj1NEzPwoi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33321 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:22:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:22:14 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32609-70-IQDxd1SSlt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #79 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I don't think there is anything to document here. Closing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:22:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:22:15 +0000 Subject: [Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability In-Reply-To: <bug-32806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32806-70-J4YiaYaSLm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Bug 32806 depends on bug 32609, which changed state. Bug 32609 Summary: Remove compiled files from src https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:22:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:22:16 +0000 Subject: [Koha-bugs] [Bug 32975] Error in package.json's definition of css:build vs css:build:prod In-Reply-To: <bug-32975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32975-70-WK1F2e2H5T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 Bug 32975 depends on bug 32609, which changed state. Bug 32609 Summary: Remove compiled files from src https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:22:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:22:16 +0000 Subject: [Koha-bugs] [Bug 32994] Remove compiled files from src (2) In-Reply-To: <bug-32994-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32994-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32994-70-r1mnd9Gqn6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Bug 32994 depends on bug 32609, which changed state. Bug 32609 Summary: Remove compiled files from src https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:26:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:26:11 +0000 Subject: [Koha-bugs] [Bug 33321] "Starts With" function when searching for patrons by address is broken In-Reply-To: <bug-33321-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33321-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33321-70-oyB0sUV1jN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33321 --- Comment #1 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- (In reply to Laura Escamilla from comment #0) > When searching for a patron by their address, the "Starts with" function > yields no results. Searching for patrons with an address while using the "Standard" search field also yields no results with both the "Starts with" and "Contains" function. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:27:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:27:14 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-SSz760cxF3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150866|0 |1 is obsolete| | --- Comment #14 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151131&action=edit Bug 32060: Improve performance of columns_to_str To test: 1) Ensure the following tests pass t/db_dependent/Koha/Item.t t/db_dependent/Koha/Bibio.t 2) Go to a biblio (preferably as serial) with many items and click "New" -> "New item" and note down the response time. 3) Apply the patch 4) Ensure tests in 1) still pass 5) Repeat step 2), the response time should be substantially improved Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:28:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:28:40 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-KygRcvvJ0X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151131|0 |1 is obsolete| | --- Comment #15 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151132&action=edit Bug 32060: Improve performance of columns_to_str To test: 1) Ensure the following tests pass t/db_dependent/Koha/Item.t t/db_dependent/Koha/Bibio.t 2) Go to a biblio (preferably as serial) with many items and click "New" -> "New item" and note down the response time. 3) Apply the patch 4) Ensure tests in 1) still pass 5) Repeat step 2), the response time should be substantially improved Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:29:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:29:34 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-ncUbQ17fHN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151132|0 |1 is obsolete| | --- Comment #16 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151133&action=edit Bug 32060: Improve performance of columns_to_str To test: 1) Ensure the following tests pass t/db_dependent/Koha/Item.t t/db_dependent/Koha/Bibio.t 2) Go to a biblio (preferably as serial) with many items and click "New" -> "New item" and note down the response time. 3) Apply the patch 4) Ensure tests in 1) still pass 5) Repeat step 2), the response time should be substantially improved Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:37:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:37:54 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-C02R6gpYbz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:38:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:38:30 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-KBTbRYbU8R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 --- Comment #17 from David Gustafsson <glasklas at gmail.com> --- Added caching for GetFrameworkCode and now using that instead. Also saw that strings_map had the same issues as columns_to_str since they share some code, so applied the same changes there. Removed get_column and will create another bug for making columns methods as fast. Also removed: my $columns_info = $self->_result->result_source->columns_info; for my $column ( keys %$columns_info ) { and replaced by: for my $column ( @{$self->_columns}) { in columns_to_str and strings_map. Not much of a difference in terms of speed, but both confusing and unnecessary to fetch the whole info when you just need the column names. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:44:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:44:45 +0000 Subject: [Koha-bugs] [Bug 31557] Add ability for holds queue builder to prioritize either matching a patron's home library to the item's home or holding library In-Reply-To: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31557-70-Gj5DMwNXmt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:48:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:48:36 +0000 Subject: [Koha-bugs] [Bug 33710] Ignore howto files In-Reply-To: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33710-70-OhoN6BQHF0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33710 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150958|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151134&action=edit Bug 33710: Ignore how-to related files Related to https://gitlab.com/koha-community/koha-testing-docker/-/issues/378 If we merge it we will want to hide how-to.pl and how-to.ptt Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:48:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:48:59 +0000 Subject: [Koha-bugs] [Bug 33710] Ignore howto files In-Reply-To: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33710-70-tsgyqq5jiP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33710 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|In Discussion |Passed QA --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This makes perfect sense to me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:53:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:53:20 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-GK3muCdKuT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 --- Comment #16 from David Gustafsson <glasklas at gmail.com> --- (In reply to Marcel de Rooy from comment #14) > (In reply to David Gustafsson from comment #13) > > Ok! Suppose due to forgot to fix the tests that still uses the 'NULL' value, > > will do so. Why is it odd? null is valid json, NULL is not. > > Some things are hard to explain :) > The fact that you need to type null as a valid JSON expression in a textarea > is not very appealing as to user interface. (Or even stricter, valid YAML.) > But I could certainly live with it :) Just document it clearly. > > And going bit out of scope, but why are we specifying a: [ b, c ] instead of > the pure YAML approach with something like: > a: > - b > - c > We probably need some discussion/consensus about handling all such > preferences. > > The fact that is all kind of YAML now, does however make a difference. See > next comment. Yes, but previously you still had to type and invalid subset of YAML, which should be worse? That you can use null values is documented in the preference description, where the patch changes the mentions of NULL to lowercase. both a: [ b, c ] and a: - b - c is valid YAML. The syspref documentation doesn't explicitly say the format is YAML, but I don't really see any reason to inform the user about the alternative syntax. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 15:54:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 13:54:04 +0000 Subject: [Koha-bugs] [Bug 32057] Add optional stack trace to action logs In-Reply-To: <bug-32057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32057-70-I5yWjACRt1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32057 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/683 Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:05:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:05:34 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-ZA4AwVso7w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:05:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:05:36 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-H1Ru6uN2zk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #62 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:05:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:05:38 +0000 Subject: [Koha-bugs] [Bug 32921] SelfCheckTimeout doesn't logout if SelfCheckReceiptPrompt modal is open In-Reply-To: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32921-70-vBMlPLdaeS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:05:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:05:40 +0000 Subject: [Koha-bugs] [Bug 32921] SelfCheckTimeout doesn't logout if SelfCheckReceiptPrompt modal is open In-Reply-To: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32921-70-ZAIxrrxkqF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:05:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:05:42 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-z5m2UVsARc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:05:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:05:44 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-0oIYzKSNSe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 --- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:05:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:05:46 +0000 Subject: [Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST API In-Reply-To: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33470-70-Qcv1iEdg6o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:05:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:05:48 +0000 Subject: [Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST API In-Reply-To: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33470-70-lIFQQLXQCq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:05:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:05:49 +0000 Subject: [Koha-bugs] [Bug 33649] Fix use of cronlogaction In-Reply-To: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33649-70-BZ0dRpVqpf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:05:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:05:51 +0000 Subject: [Koha-bugs] [Bug 33649] Fix use of cronlogaction In-Reply-To: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33649-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33649-70-nVHMVgmWEl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:16:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:16:25 +0000 Subject: [Koha-bugs] [Bug 31557] Add ability for holds queue builder to prioritize either matching a patron's home library to the item's home or holding library In-Reply-To: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31557-70-Qd3Q43EcPa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151135&action=edit Bug 31557: (QA follow-up) Make tests more robust Tests had a few problems: - They weren't wrapped in a transaction explicitly - They called Koha::Biblios->delete! - They failed if run a couple times This patch: - Wraps things in a transaction - Removes not-required things ($target_rs variable not used) - Preserves the tests logic, but filters the resultset on the biblionumber instead of deleting all the database which can fail depending on FK constraints. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:17:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:17:27 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-uWN6PAsQAG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 --- Comment #17 from David Gustafsson <glasklas at gmail.com> --- (In reply to Marcel de Rooy from comment #15) > We remove these lines completely now and just trust ->yaml_preference: > - foreach my $line (@lines){ > - my ($field,$array) = split /:/, $line; > - next if !$array; > - $field =~ s/^\s*|\s*$//g; > - $array =~ s/[ [\]\r]//g; > - my @array = split /,/, $array; > - @array = map { $_ eq '""' || $_ eq "''" ? '' : $_ } @array; > - @array = map { $_ eq 'NULL' ? undef : $_ } @array; > - $pref_as_hash->{$field} = \@array; > - } > > But this is not the same. If I pasted correct YAML previously like below, it > would not work. > ccode : > - null > - NULL > - undefined > - 2 > - '3' > Now it does. > > But perhaps more serious is the opposite, if I am entering some valid YAML > array by 'forgetting' the first line: > - null > - NULL > - undefined > - 2 > - '3' > I will get back an array, while the former routine returned an empty hash ! > This will trigger an error like: Not a HASH reference at > /usr/share/koha/Koha/Item.pm line 2071. => foreach my $field (keys > %$denyingrules) { > > This is a bit long way of saying: I still think that we may need an > intermediate routine between pure YAML (yaml_preference) and what we expect > for specific preferences? I see your point, but was it not already possible to make that code crash (or even worse things) by for example using key values that does not exist on the item object, or for example using "delete" as key :/ sub is_denied_renewal { my ( $self ) = @_; my $denyingrules = Koha::Config::SysPrefs->find('ItemsDeniedRenewal')->get_yaml_pref_hash(); return 0 unless $denyingrules; foreach my $field (keys %$denyingrules) { my $val = $self->$field; Validation would be nice, but feels like out of the scope for this issue. I will update the patch to check that an actual hash before iterating over the keys though, as this particular case was not a problem before. If I'm not missing something $self->$field; where $field is user input is a security vulnerability and a pretty bad one at that. Should use get_column instead! I guess should create a new issue for this, or if we handle it in this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:19:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:19:15 +0000 Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds" permission can no longer update hold pickup locations In-Reply-To: <bug-30207-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30207-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30207-70-4nTqIIMEPi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 Aude Charillon <aude.charillon at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |aude.charillon at ptfs-europe. | |com Resolution|--- |FIXED --- Comment #21 from Aude Charillon <aude.charillon at ptfs-europe.com> --- No changes to the Manual needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:19:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:19:16 +0000 Subject: [Koha-bugs] [Bug 30213] Hide Delete (aka Priority) column when user only has place_hold permission In-Reply-To: <bug-30213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30213-70-swN52AAI3O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Bug 30213 depends on bug 30207, which changed state. Bug 30207 Summary: Librarians with only "place_holds" permission can no longer update hold pickup locations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:20:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:20:42 +0000 Subject: [Koha-bugs] [Bug 31557] Add ability for holds queue builder to prioritize either matching a patron's home library to the item's home or holding library In-Reply-To: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31557-70-dUmiGJ7ZnO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:20:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:20:44 +0000 Subject: [Koha-bugs] [Bug 31557] Add ability for holds queue builder to prioritize either matching a patron's home library to the item's home or holding library In-Reply-To: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31557-70-r3FB3N50d3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:20:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:20:47 +0000 Subject: [Koha-bugs] [Bug 32627] Reprinting holds slips should not reset the expiration date In-Reply-To: <bug-32627-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32627-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32627-70-HFqLL862Nt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:20:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:20:49 +0000 Subject: [Koha-bugs] [Bug 32627] Reprinting holds slips should not reset the expiration date In-Reply-To: <bug-32627-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32627-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32627-70-ccb62lodVR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:20:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:20:51 +0000 Subject: [Koha-bugs] [Bug 32766] Update plugin unimarc_field_116.pl fields In-Reply-To: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32766-70-kp8iEIg9qA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32766 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:20:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:20:53 +0000 Subject: [Koha-bugs] [Bug 32766] Update plugin unimarc_field_116.pl fields In-Reply-To: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32766-70-oJNSuSv8KM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32766 --- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:20:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:20:55 +0000 Subject: [Koha-bugs] [Bug 32937] Zebra: Ignore copyright symbol when searching In-Reply-To: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32937-70-lPwWBw3KSQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32937 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:20:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:20:56 +0000 Subject: [Koha-bugs] [Bug 32937] Zebra: Ignore copyright symbol when searching In-Reply-To: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32937-70-zjvwQJdwSF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32937 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:20:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:20:58 +0000 Subject: [Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector In-Reply-To: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32993-70-vwiOv7Rw1D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:00 +0000 Subject: [Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector In-Reply-To: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32993-70-PblHWSdsKW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:02 +0000 Subject: [Koha-bugs] [Bug 32995] Koha agent string not sent for OverDrive fulfillment requests In-Reply-To: <bug-32995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32995-70-TQKdT77An8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32995 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:04 +0000 Subject: [Koha-bugs] [Bug 32995] Koha agent string not sent for OverDrive fulfillment requests In-Reply-To: <bug-32995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32995-70-pHCIeVWgVq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32995 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:06 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff interface catalog details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-6cVRWEf7th@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:08 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff interface catalog details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-kjJzGBC3Lx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 --- Comment #24 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:10 +0000 Subject: [Koha-bugs] [Bug 33320] Patron modification requests: options are squashed In-Reply-To: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33320-70-KN26UHXJ1T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33320 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:12 +0000 Subject: [Koha-bugs] [Bug 33320] Patron modification requests: options are squashed In-Reply-To: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33320-70-7pbv1UXWpH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33320 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:14 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-hp750NRcyq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:16 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-WnKgkEs6JP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #30 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:18 +0000 Subject: [Koha-bugs] [Bug 33567] Remove fallback for Reference_NFL_statuses in C4/XSLT module In-Reply-To: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33567-70-Q4N3wUODg6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33567 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:19 +0000 Subject: [Koha-bugs] [Bug 33567] Remove fallback for Reference_NFL_statuses in C4/XSLT module In-Reply-To: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33567-70-OTX9u6uCR8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33567 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:21 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-5BsJ1gzYcP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:23 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-bI2potZl0K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:25 +0000 Subject: [Koha-bugs] [Bug 33642] Typo: No log found . In-Reply-To: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33642-70-7AnscwB7dB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33642 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:27 +0000 Subject: [Koha-bugs] [Bug 33642] Typo: No log found . In-Reply-To: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33642-70-deII2WRmgI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33642 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:29 +0000 Subject: [Koha-bugs] [Bug 33655] z39.50 search no longer shows search in progress In-Reply-To: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33655-70-qBHzBvYoxC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:30 +0000 Subject: [Koha-bugs] [Bug 33655] z39.50 search no longer shows search in progress In-Reply-To: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33655-70-S5VN8AcSxO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:32 +0000 Subject: [Koha-bugs] [Bug 33677] Remove --verbose from koha-worker manpage In-Reply-To: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33677-70-UYlIBkFHSr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:34 +0000 Subject: [Koha-bugs] [Bug 33677] Remove --verbose from koha-worker manpage In-Reply-To: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33677-70-yd8BUEeWfc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:36 +0000 Subject: [Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence) In-Reply-To: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33699-70-dxK8FDoSPQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:21:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:21:38 +0000 Subject: [Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence) In-Reply-To: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33699-70-jo8vG6lOwY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:22:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:22:17 +0000 Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available In-Reply-To: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30687-70-fsmT9vyzBs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:22:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:22:19 +0000 Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available In-Reply-To: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30687-70-2qNp2TV9WR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 --- Comment #32 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:25:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:25:27 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33462-70-loJhDtdqD9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:30:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:30:04 +0000 Subject: [Koha-bugs] [Bug 28126] Remove AllowPurchaseSuggestionBranchChoice from the Koha manual In-Reply-To: <bug-28126-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28126-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28126-70-FMGFzITU8b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28126 Aude Charillon <aude.charillon at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Aude Charillon contact| | Status|NEW |Needs documenting CC| |aude.charillon at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:30:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:30:34 +0000 Subject: [Koha-bugs] [Bug 28126] Remove AllowPurchaseSuggestionBranchChoice from the Koha manual In-Reply-To: <bug-28126-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28126-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28126-70-u5kavXP0pB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28126 Aude Charillon <aude.charillon at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #2 from Aude Charillon <aude.charillon at ptfs-europe.com> --- Confirmed any trace of AllowPurchaseSuggestionBranchChoice has been removed from the master manual. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:37:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:37:15 +0000 Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32092-70-4zE8gALDxf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> --- Can you show create a script or test or another way to demonstrate the speed improvement? I used multitime to test and it appears to be a bit slower with your patches. If your code is indeed faster, I'm wondering if the additional cache flushing is causing the issue Master: 1: prove t/db_dependent/Circulation.t t/db_dependent/Reserves.t t/db_dependent/Biblio.t t/db_dependent/Koha/Charges/Fees.t t/db_dependent/Items.t t/db_dependent/Koha/Patron.t t/db_dependent/api/v1/checkouts.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t Mean Std.Dev. Min Median Max real 41.937 2.340 38.932 41.881 46.608 user 35.524 1.881 33.089 35.399 39.304 sys 4.245 0.429 3.624 4.191 4.969 Both Patches: 1: prove t/db_dependent/Circulation.t t/db_dependent/Reserves.t t/db_dependent/Biblio.t t/db_dependent/Koha/Charges/Fees.t t/db_dependent/Items.t t/db_dependent/Koha/Patron.t t/db_dependent/api/v1/checkouts.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t Mean Std.Dev. Min Median Max real 42.670 2.010 39.200 42.716 45.849 user 35.969 1.485 33.404 35.807 38.477 sys 4.444 0.457 3.742 4.612 5.096 Without the "Fix tests" Patch: 1: prove t/db_dependent/Circulation.t t/db_dependent/Reserves.t t/db_dependent/Biblio.t t/db_dependent/Koha/Charges/Fees.t t/db_dependent/Items.t t/db_dependent/Koha/Patron.t t/db_dependent/api/v1/checkouts.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t Mean Std.Dev. Min Median Max real 41.730 1.535 40.115 41.217 45.135 user 35.400 1.165 34.116 34.928 37.987 sys 4.158 0.345 3.633 4.152 4.908 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:39:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:39:16 +0000 Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset after first login In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28980-70-axHhlnKRxi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980 --- Comment #20 from Christopher Brannon <cbrannon at cdalibrary.org> --- I agree with an earlier statement, that this should be only applied to accounts created by staff. If you are letting patrons create their own password on patron self registration, it should not be needed. That said, to fall in line with existing password settings, there should be a default general setting to force first time users created by staff to reset the password. This setting should also exist at the patron category level. It should apply to memberentry.pl?op=add, and be ignored with memberentry.pl?op=edit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:40:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:40:16 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-JZNk4XiRfL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Good work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:40:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:40:17 +0000 Subject: [Koha-bugs] [Bug 31790] REST API: CRUD endpoints for Authorities [omnibus] In-Reply-To: <bug-31790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31790-70-aPQy6W5tCM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31790 Bug 31790 depends on bug 31795, which changed state. Bug 31795 Summary: REST API: POST endpoint for Authorities https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:40:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:40:17 +0000 Subject: [Koha-bugs] [Bug 31796] REST API: PUT endpoint for Authorities In-Reply-To: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31796-70-XQpHUMJjTH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796 Bug 31796 depends on bug 31795, which changed state. Bug 31795 Summary: REST API: POST endpoint for Authorities https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:42:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:42:36 +0000 Subject: [Koha-bugs] [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider In-Reply-To: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32412-70-kmhlVCPCN4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:42:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:42:38 +0000 Subject: [Koha-bugs] [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider In-Reply-To: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32412-70-ZEiDSIupaE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:42:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:42:40 +0000 Subject: [Koha-bugs] [Bug 32701] Self checkout help page lacks required I18N JavaScript In-Reply-To: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32701-70-Io2MX6jrrx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:42:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:42:42 +0000 Subject: [Koha-bugs] [Bug 32701] Self checkout help page lacks required I18N JavaScript In-Reply-To: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32701-70-uLTytntLxJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:42:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:42:43 +0000 Subject: [Koha-bugs] [Bug 33329] GET /biblios encoding wrong when UNIMARC In-Reply-To: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33329-70-stSdqBwPCq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:42:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:42:45 +0000 Subject: [Koha-bugs] [Bug 33329] GET /biblios encoding wrong when UNIMARC In-Reply-To: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33329-70-BAW4nNapny@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:42:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:42:46 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-GB463OrT9B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:42:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:42:48 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-W0mZSSDuoB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:42:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:42:50 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-wEmG27Fdln@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:42:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:42:52 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-4fl6cQUMui@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:42:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:42:57 +0000 Subject: [Koha-bugs] [Bug 31448] Add option to re-send email receipt when UseEmailReceipts is enabled In-Reply-To: <bug-31448-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31448-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31448-70-xsAXzffzMq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancements, won't be backported to 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:44:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:44:04 +0000 Subject: [Koha-bugs] [Bug 33724] New: Expand explanations of terms used in ERM module Message-ID: <bug-33724-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33724 Bug ID: 33724 Summary: Expand explanations of terms used in ERM module Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: Needs documenting Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: aude.charillon at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The manual should better explain what each available field on the Agreements and Licenses screen mean and what they can be used for. Also clarify the difference between Agreements and Licenses. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:44:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:44:14 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-feXTqQugRn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #6 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Apply patches, on ktd, preparation: - Run reset_all - Run sh start-ill-dev.sh (copy from https://github.com/ammopt/koha-ill-dev/blob/master/start-ill-dev.sh) Test plan: 1 Go to system preferences, check the new YAML preference ILLModuleDisclaimerByType 2 Copy the bold example YAML text into the system preference input box 3 Go to ILL Requests click "New ILL request" (Pick FreeForm if you have more than one backend installed) 4 Pick type "Journal article", enter "42" in cardnumber and a random library, create. Notice the request is created normally. 5 Go back to the system preferences, remove the "bypass: 1" line, save. 6 Repeat 3 and 4 7 Verify that a Type Disclaimer stage now exists. Verify that the text being presented is the one specified for "article" in the system preference. Submit it. 8 Verify that that the disclaimer value and disclaimer date have been saved as illrequestattributes for that ILL request. 9 Repeat 3 and 4 but with a different type 10 Verify that the text being presented is the one defined in "all" in the system preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:44:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:44:54 +0000 Subject: [Koha-bugs] [Bug 33724] Expand explanations of terms used in ERM module In-Reply-To: <bug-33724-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33724-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33724-70-RT2SZsGBzs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33724 --- Comment #1 from Aude Charillon <aude.charillon at ptfs-europe.com> --- Some of the information needed in the manual has been posted at: https://bywatersolutions.com/education/koha-erm-module-licensing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:45:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:45:09 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-izwelkrNzK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #18 from David Gustafsson <glasklas at gmail.com> --- I'm leaning towards that it's better to leave the patch as it is with regards to the problem of crashing on non hash-values. The same problem applies for 'OpacHiddenItems', that is currently using C4::Context->yaml_preference and not get_yaml_pref_hash. So feel like this issue should be handled in another issue and solved properly instead of some band aid solution like validating everywhere the syspref is used instead of on input. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:48:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:48:57 +0000 Subject: [Koha-bugs] [Bug 33667] 'Copy to all libraries' doesn't work on editing holidays In-Reply-To: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33667-70-8OKpNHLb8G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33667 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- You are probably right. Does it need a little hint/warning maybe: may overwrite existing holidays in other calendars? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:49:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:49:04 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-fs3z9kYVaj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #54 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement and dependencies are not present.. won't backport to 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:50:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:50:34 +0000 Subject: [Koha-bugs] [Bug 33197] Terminology: rename GDPR_Policy system preference In-Reply-To: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33197-70-EyoZi57hkS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33197 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:54:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:54:03 +0000 Subject: [Koha-bugs] [Bug 21699] Allow circulation messages to be editable In-Reply-To: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21699-70-gK2Xvv0aOk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This is a nice enhancement.. but an enhancement it is so no backport for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:54:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:54:07 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-3vAXzXxCO6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 --- Comment #19 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151136&action=edit Bug 32478: Fix syspref NULL values in tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:54:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:54:52 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-TUzh9HxqHZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:59:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:59:13 +0000 Subject: [Koha-bugs] [Bug 31796] REST API: PUT endpoint for Authorities In-Reply-To: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31796-70-hS1RM8WYSj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement, won't be backporting as the tree above has also not been ported. If you're desperate for this in 22.11 let me know and we can look at backporting the whole tree as one set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:59:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:59:13 +0000 Subject: [Koha-bugs] [Bug 31790] REST API: CRUD endpoints for Authorities [omnibus] In-Reply-To: <bug-31790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31790-70-fSaj6SUgOS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31790 Bug 31790 depends on bug 31796, which changed state. Bug 31796 Summary: REST API: PUT endpoint for Authorities https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 16:59:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 14:59:13 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-vAF6i98lwz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 Bug 32735 depends on bug 31796, which changed state. Bug 31796 Summary: REST API: PUT endpoint for Authorities https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:00:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:00:19 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-7jQYUEWReW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- As the dependency states.. if we want this for 22.11 let me know and we can backport as a full set. Otherwise, not backporting for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:00:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:00:19 +0000 Subject: [Koha-bugs] [Bug 31790] REST API: CRUD endpoints for Authorities [omnibus] In-Reply-To: <bug-31790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31790-70-LgREUHdKTr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31790 Bug 31790 depends on bug 32735, which changed state. Bug 32735 Summary: REST API: Add a list endpoint for Authorities https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:01:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:01:25 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29453-70-fwFTkreFQb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- New feature, no backport for 22.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:01:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:01:26 +0000 Subject: [Koha-bugs] [Bug 17735] Merge boraccount and pay pages into one In-Reply-To: <bug-17735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17735-70-iiL7XFgmtI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17735 Bug 17735 depends on bug 29453, which changed state. Bug 29453 Summary: Add routes to fetch patron credits/debits https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:01:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:01:26 +0000 Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's account In-Reply-To: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21043-70-Ed4OnFibRm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 Bug 21043 depends on bug 29453, which changed state. Bug 29453 Summary: Add routes to fetch patron credits/debits https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:01:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:01:27 +0000 Subject: [Koha-bugs] [Bug 28544] Add API's for account transactions In-Reply-To: <bug-28544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28544-70-BT6kVWfWL2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28544 Bug 28544 depends on bug 29453, which changed state. Bug 29453 Summary: Add routes to fetch patron credits/debits https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:01:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:01:33 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29453-70-bAu6GOm5Jz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|new feature |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:03:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:03:00 +0000 Subject: [Koha-bugs] [Bug 32613] Can we add 'autocompletion' to our SQL reports editor? In-Reply-To: <bug-32613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32613-70-eAiPPL9HYm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32613 Aude Charillon <aude.charillon at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon at ptfs-europe. | |com Documentation| |Aude Charillon contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:03:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:03:05 +0000 Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's account In-Reply-To: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21043-70-LmQQHhtE87@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- New feature, not backporting to 22.11.x series (again.. for API's I'm always tempted, so let me know if you're keen for this to make the cut) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:03:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:03:05 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15165-70-5XehWjCjOR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Bug 15165 depends on bug 21043, which changed state. Bug 21043 Summary: Add routes to add debits to a patron's account https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:03:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:03:15 +0000 Subject: [Koha-bugs] [Bug 31361] Button batch operations disappears when alias is used for itemnumber of biblionumber In-Reply-To: <bug-31361-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31361-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31361-70-f1MixiSE1P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31361 Aude Charillon <aude.charillon at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon at ptfs-europe. | |com Documentation| |Aude Charillon contact| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:04:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:04:43 +0000 Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23924-70-w2PatU1whu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement, no backport for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:12:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:12:36 +0000 Subject: [Koha-bugs] [Bug 30367] Plugins: Search explodes in error when searching for specific keywords In-Reply-To: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30367-70-CLhJtZmKU8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:12:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:12:38 +0000 Subject: [Koha-bugs] [Bug 30367] Plugins: Search explodes in error when searching for specific keywords In-Reply-To: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30367-70-oj0vZxL6Di@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:12:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:12:40 +0000 Subject: [Koha-bugs] [Bug 33197] Terminology: rename GDPR_Policy system preference In-Reply-To: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33197-70-Mvpgoi4IJf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33197 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:12:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:12:41 +0000 Subject: [Koha-bugs] [Bug 33197] Terminology: rename GDPR_Policy system preference In-Reply-To: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33197-70-RHTWkAWHSq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33197 --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:12:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:12:43 +0000 Subject: [Koha-bugs] [Bug 33626] compare_es_to_db.pl does not work with Search::Elasticsearch 7.0 In-Reply-To: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33626-70-RBtP6OuTcg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33626 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:12:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:12:44 +0000 Subject: [Koha-bugs] [Bug 33626] compare_es_to_db.pl does not work with Search::Elasticsearch 7.0 In-Reply-To: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33626-70-RpkSEgZweg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33626 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:14:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:14:43 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-xICKw0OAAY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32931 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:14:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:14:43 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-kU9Ym6o8qQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 [Bug 33355] ERM UI and markup has some issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:17:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:17:26 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-R1Xys8ETaZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:17:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:17:28 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-r4xV87SCny@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:18:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:18:37 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-TmHdctCXuM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32030 CC| |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:18:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:18:37 +0000 Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM) In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32030-70-ED5NGNXeah@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32931 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:18:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:18:49 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-Rd2gnc1M8f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|32030 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:18:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:18:49 +0000 Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM) In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32030-70-pUHFVCBGTu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33355 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 [Bug 33355] ERM UI and markup has some issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:19:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:19:30 +0000 Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32092-70-C5bGutblSy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092 --- Comment #13 from David Gustafsson <glasklas at gmail.com> --- (In reply to Kyle M Hall from comment #12) > Can you show create a script or test or another way to demonstrate the speed > improvement? I used multitime to test and it appears to be a bit slower with > your patches. If your code is indeed faster, I'm wondering if the additional > cache flushing is causing the issue > > Master: > 1: prove t/db_dependent/Circulation.t t/db_dependent/Reserves.t > t/db_dependent/Biblio.t t/db_dependent/Koha/Charges/Fees.t > t/db_dependent/Items.t t/db_dependent/Koha/Patron.t > t/db_dependent/api/v1/checkouts.t > t/db_dependent/Koha/Template/Plugin/CirculationRules.t > Mean Std.Dev. Min Median Max > real 41.937 2.340 38.932 41.881 46.608 > user 35.524 1.881 33.089 35.399 39.304 > sys 4.245 0.429 3.624 4.191 4.969 > > Both Patches: > 1: prove t/db_dependent/Circulation.t t/db_dependent/Reserves.t > t/db_dependent/Biblio.t t/db_dependent/Koha/Charges/Fees.t > t/db_dependent/Items.t t/db_dependent/Koha/Patron.t > t/db_dependent/api/v1/checkouts.t > t/db_dependent/Koha/Template/Plugin/CirculationRules.t > Mean Std.Dev. Min Median Max > real 42.670 2.010 39.200 42.716 45.849 > user 35.969 1.485 33.404 35.807 38.477 > sys 4.444 0.457 3.742 4.612 5.096 > > Without the "Fix tests" Patch: > 1: prove t/db_dependent/Circulation.t t/db_dependent/Reserves.t > t/db_dependent/Biblio.t t/db_dependent/Koha/Charges/Fees.t > t/db_dependent/Items.t t/db_dependent/Koha/Patron.t > t/db_dependent/api/v1/checkouts.t > t/db_dependent/Koha/Template/Plugin/CirculationRules.t > Mean Std.Dev. Min Median Max > real 41.730 1.535 40.115 41.217 45.135 > user 35.400 1.165 34.116 34.928 37.987 > sys 4.158 0.345 3.633 4.152 4.908 Circulation rules are rarely (if ever) fetched more than once in those tests, and for the difference to be noticeable you would have to access the rules within some kind of loop iterating over a larger number of items (for example). Don't have a lot of time on my hands right now so providing a script will probably take some time. What I could do meanwhile is to upload a flame graph before and after the patch with the test case have been using. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:19:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:19:33 +0000 Subject: [Koha-bugs] [Bug 31410] Set focus for cursor to Server name when adding a new Z39.50 or SRU server In-Reply-To: <bug-31410-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31410-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31410-70-5VCbw3viv9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31410 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:20:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:20:41 +0000 Subject: [Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set In-Reply-To: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31405-70-x0et42UJlg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:21:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:21:15 +0000 Subject: [Koha-bugs] [Bug 33196] Terminology: rephrase Pseudonymization system preference to be more general In-Reply-To: <bug-33196-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33196-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33196-70-gZFogYA5Uo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33196 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:23:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:23:43 +0000 Subject: [Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set In-Reply-To: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31405-70-24XwRyzEVz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:23:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:23:45 +0000 Subject: [Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set In-Reply-To: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31405-70-pGSEugDBdE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:23:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:23:47 +0000 Subject: [Koha-bugs] [Bug 31410] Set focus for cursor to Server name when adding a new Z39.50 or SRU server In-Reply-To: <bug-31410-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31410-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31410-70-8UycCCNUny@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31410 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:23:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:23:48 +0000 Subject: [Koha-bugs] [Bug 31410] Set focus for cursor to Server name when adding a new Z39.50 or SRU server In-Reply-To: <bug-31410-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31410-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31410-70-N5j41w0jD7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31410 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:23:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:23:50 +0000 Subject: [Koha-bugs] [Bug 32990] Possible deadlock in C4::ImportBatch::_update_batch_record_counts In-Reply-To: <bug-32990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32990-70-8DAWTciRup@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32990 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:23:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:23:51 +0000 Subject: [Koha-bugs] [Bug 32990] Possible deadlock in C4::ImportBatch::_update_batch_record_counts In-Reply-To: <bug-32990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32990-70-graTAZm1YC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32990 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:23:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:23:53 +0000 Subject: [Koha-bugs] [Bug 33196] Terminology: rephrase Pseudonymization system preference to be more general In-Reply-To: <bug-33196-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33196-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33196-70-vXKHgNPKyI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33196 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:23:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:23:55 +0000 Subject: [Koha-bugs] [Bug 33196] Terminology: rephrase Pseudonymization system preference to be more general In-Reply-To: <bug-33196-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33196-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33196-70-uBArXANpHj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33196 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:23:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:23:56 +0000 Subject: [Koha-bugs] [Bug 33596] Merge result page is missing page-section In-Reply-To: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33596-70-PO8YRd6oAL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33596 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:23:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:23:58 +0000 Subject: [Koha-bugs] [Bug 33596] Merge result page is missing page-section In-Reply-To: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33596-70-XEJjQDYyVC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33596 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:24:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:24:00 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-haEm24Zm2Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:24:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:24:01 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-7g1NCictst@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:24:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:24:03 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33631-70-OhtXZCLRKh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:24:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:24:05 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33631-70-hNv6yGDo4S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:24:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:24:07 +0000 Subject: [Koha-bugs] [Bug 33645] koha-foreach always returns 1 if --chdir not specified In-Reply-To: <bug-33645-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33645-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33645-70-6Mw3RwUb5V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33645 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:24:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:24:09 +0000 Subject: [Koha-bugs] [Bug 33645] koha-foreach always returns 1 if --chdir not specified In-Reply-To: <bug-33645-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33645-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33645-70-odDXlwvt4R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33645 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:32:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:32:47 +0000 Subject: [Koha-bugs] [Bug 21548] Make ILL patron category in koha-conf.xml match with ILL patron category in sample data In-Reply-To: <bug-21548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21548-70-GD4cpByURS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Aude Charillon <aude.charillon at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting Documentation| |Aude Charillon contact| | CC| |aude.charillon at ptfs-europe. | |com --- Comment #12 from Aude Charillon <aude.charillon at ptfs-europe.com> --- Manual will need to be updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:32:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:32:48 +0000 Subject: [Koha-bugs] [Bug 19822] Add system preferences for ILL Module In-Reply-To: <bug-19822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19822-70-jSGqFWIcT4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Bug 19822 depends on bug 21548, which changed state. Bug 21548 Summary: Make ILL patron category in koha-conf.xml match with ILL patron category in sample data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:32:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:32:49 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-TRx5KrPbXL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Bug 32911 depends on bug 21548, which changed state. Bug 21548 Summary: Make ILL patron category in koha-conf.xml match with ILL patron category in sample data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:33:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:33:07 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31798-70-YyK3ZwgMc1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Another API addition.. for now I'm choosing not to backport, but let me know if this is important to you and I'll look at backporting the whole tree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:33:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:33:07 +0000 Subject: [Koha-bugs] [Bug 31789] REST API: CRUD endpoint for Items In-Reply-To: <bug-31789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31789-70-9JSFeJn9wF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31789 Bug 31789 depends on bug 31798, which changed state. Bug 31798 Summary: REST API: POST endpoint for Items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:33:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:33:07 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31799-70-r47ZduHQyA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Bug 31799 depends on bug 31798, which changed state. Bug 31798 Summary: REST API: POST endpoint for Items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:36:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:36:18 +0000 Subject: [Koha-bugs] [Bug 33053] Tables item_groups and recalls have a biblio_id column with a default of 0 In-Reply-To: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33053-70-3L3edgXXXf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33053 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:36:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:36:20 +0000 Subject: [Koha-bugs] [Bug 33053] Tables item_groups and recalls have a biblio_id column with a default of 0 In-Reply-To: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33053-70-5JIIMAah71@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33053 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:36:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:36:21 +0000 Subject: [Koha-bugs] [Bug 33069] File download from list in OPAC gives error In-Reply-To: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33069-70-jYDPWfqzgR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:36:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:36:23 +0000 Subject: [Koha-bugs] [Bug 33069] File download from list in OPAC gives error In-Reply-To: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33069-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33069-70-Tz8nD50Ego@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:36:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:36:24 +0000 Subject: [Koha-bugs] [Bug 33102] Cart in OPAC and staff interface does no longer display infos from biblioitems table In-Reply-To: <bug-33102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33102-70-VHE13JJQXD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33102 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:36:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:36:26 +0000 Subject: [Koha-bugs] [Bug 33102] Cart in OPAC and staff interface does no longer display infos from biblioitems table In-Reply-To: <bug-33102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33102-70-VFYRzQKaUS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33102 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:36:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:36:27 +0000 Subject: [Koha-bugs] [Bug 33233] OPAC advanced search inputs stay disabled when using browser's back button In-Reply-To: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33233-70-KHrCJQs1jL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:36:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:36:29 +0000 Subject: [Koha-bugs] [Bug 33233] OPAC advanced search inputs stay disabled when using browser's back button In-Reply-To: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33233-70-zMdgO1PMl0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:36:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:36:30 +0000 Subject: [Koha-bugs] [Bug 33582] Use template wrapper for breadcrumbs: Tools, part 4 In-Reply-To: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33582-70-ZQMefxMXZA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33582 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:36:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:36:32 +0000 Subject: [Koha-bugs] [Bug 33582] Use template wrapper for breadcrumbs: Tools, part 4 In-Reply-To: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33582-70-f3gWb7PGyb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33582 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:36:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:36:33 +0000 Subject: [Koha-bugs] [Bug 33637] Batch patron modification broken In-Reply-To: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33637-70-gc74bk5UAN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:36:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:36:35 +0000 Subject: [Koha-bugs] [Bug 33637] Batch patron modification broken In-Reply-To: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33637-70-7Z1jy0wqrB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:37:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:37:19 +0000 Subject: [Koha-bugs] [Bug 30642] We should record the renewal type (automatic/manual) In-Reply-To: <bug-30642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30642-70-BX4e9YUfli@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30642 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/684 Resolution|--- |FIXED CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:40:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:40:42 +0000 Subject: [Koha-bugs] [Bug 22428] MARC modification template cuts text to 100 characters In-Reply-To: <bug-22428-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22428-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22428-70-ZAi9YG8fsl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22428 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Seems to be only backend stuff, nothing to add/change in the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:40:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:40:54 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31735-70-2WRTbsNkDe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:40:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:40:56 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31735-70-sSzY7VNmYh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 --- Comment #85 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 17:58:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 15:58:15 +0000 Subject: [Koha-bugs] [Bug 32648] Search.t is failing randomly In-Reply-To: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32648-70-AlOWbFVLY3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I've reused the same order as in https://jenkins.koha-community.org/job/Koha_Master_My8/1213/consoleText And I managed to make it fails. So it's data related (and note that it's wrongly in t instead of t/db_dependent!) Will need to investigate later. To recreate run this script: https://pastebin.com/t1qmfJcS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 18:08:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 16:08:22 +0000 Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32092-70-baTdTEbwup@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092 --- Comment #14 from David Gustafsson <glasklas at gmail.com> --- Will attach the flame graph data on monday. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 18:10:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 16:10:14 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-kBJwHMQXXx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Michaela Sieber <michaela.sieber at kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 18:19:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 16:19:03 +0000 Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32092-70-lgeAj4rYBu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092 --- Comment #15 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- It sounds like you're looking for something more rigorous, but I can provide a little more info on the results I got when testing for sign-off, if that's helpful: For my testing, I used the "add multiple copies" feature to create a bib with 400 items split between 4 branches. I then timed the page loads for placing a hold a few times on master and a few times with the patch (nothing fancy, just literally used a stopwatch timer). I got page loads taking about 18-23 seconds on master, and 9-11 seconds with the patch. As I said, not statistically rigorous, but definitely noticeable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 18:34:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 16:34:58 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-XzeZH4Vwzu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151026|0 |1 is obsolete| | Attachment #151086|0 |1 is obsolete| | Attachment #151087|0 |1 is obsolete| | Attachment #151088|0 |1 is obsolete| | Attachment #151089|0 |1 is obsolete| | Attachment #151092|0 |1 is obsolete| | Attachment #151093|0 |1 is obsolete| | --- Comment #133 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151137&action=edit Bug 8179: Receive multiple orders This patch implements the code to allow a patron to receive multiple orders at the same time in /cgi-bin/koha/acqui/orderreceive.pl page To test: 1. apply all patches 2. updatedatabase 3. Go to system preferences and allow AcqReceiveMultipleOrderLines 4. In acquisitions module, create a vendor if you don't have one and add 3 baskets.. one with create items on ordering, one with create items on receiving and finally one with create items when cataloguing 5. Fill baskets with orders (There should be at least 15 orders in total). There should be a mix of orders created by suggestions, others by subscriptions and others by neither of those methods. 6. Close all baskets and receive shipment. CHECK => in /cgi-bin/koha/acqui/parcel.pl page, in top table there is a column with checkboxes, and a button that says "Receive selected" 7. If all orders from all baskets are shown in the table, set the rows per page to 10, so table has more than one page 8. Check some of the checkboxes CHECK => "Receive selected" button shows how many rows are selected 9. Go to the next page and select some more rows CHECK => Changing page does not modify how many rows where selected 10. Go back to previous page CHECK => Previously selected rows are still selected 11. Reload the page to deselect all rows 12. Select only one row and click on "Receive selected" button CHECK => the page /cgi-bin/koha/acqui/orderreceive.pl behaves just the same as if the "receive" link in the selected row would have been clicked. 13. Click on cancel to go back to parcel.pl page 14. Select all rows (even the ones from the next page of the table) and click on "Receive selected" CHECH => In orderreceive.pl page there is a table with all selected rows 15. Ensure table has more than one page, as in step 7 16. Click on the "edit" link in the last row of the current page CHECK => A modal window is displayed with 4 tabs within: Info, Accounting, Receipt history and Items CHECK => Modal has 4 buttons at the bottom, 'Previous' to go to previos order, 'Cancel' to close the modal without keeping modifications, 'Save' to close modal keeping modifications and 'Next' to go to the next order CHECK => Even that we are at the end of the current page, 'Next' button is still available 17. Click on 'Next' button CHECK => The table behind the modal now displays the next page, and the modal was not closed 18. Click on 'Previous' CHECK => The table behind the modal went back to the first page, and the modal was not closed 19. Click on 'Previous' button till you reach the first row of the first page CHECK => Only when you reach the first row of the first page 'Previous' button gets disabled 20. Click on 'Next' button till you reach the last row of the last page CHECK => Only when you reach the last button of the last page 'Next' button gets disabled 21. Check that behaviour for the different types of order are still the same a. For orders that where created through suggestion, check that the suggestion info is present in Info tab. If when suggestion was accepted you set a reason, a dropdown to change the reason shoul display also. b. For orders that where created through subscriptions, check that the Items tab is disabled, and the Receipt history is enabled. On accounting tab you should be able to change quantity ordered. If there were less items received than ordered, the next time you receive this order the child order generated from this one shoul appear in receipt history. c. For orders that don't come from subscription and creates there items on ordering, Receipt history should be disabled, and a table with prefilled items shold appear in the Items tab. You can edit them and the changes should appear in the item's row. d. For orders that don't come from subscription and creates there items on receiving, Receipt history should be disabled, and a form to create the items should appear in Items tab. When you add an item a table should appear. e. For orders that don't come from subscription and creates there ites on cataloguing, Receipt history and Items tabs should be disabled. f. Any changes made in quantity (received or ordered) or funds in the modal should be reflected in the table if you click save from the modal. 22. Once you've done all you checking and verifications click save 23. While saving a progress bar should appear 24. If no error was detected, you should be redirected back to parcel.pl page 25. If an error or warning was detected (like there is an order with 0 items to receive) the save button should be disabled and warnings are dispayed. 26. prove t/db_dependent/Koha/Acquisition/Fund.t t/db_dependent/Koha/Acquisitoin/Order.t t/db_dependent/Koha/Item.t Sponsored-by: Virginia Polytechnic Institute and State University Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 18:35:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 16:35:08 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-oVWDcypzwl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #134 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151138&action=edit Bug 8179: Make partial receive work correctly Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 18:35:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 16:35:13 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-M3FCiyRDHM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #135 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151139&action=edit Bug 8179: Remove commented code Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 18:35:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 16:35:17 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-jELepJgSJ6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #136 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151140&action=edit Bug 8179: Remove leftover/not used embed definitions Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 18:35:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 16:35:22 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-CPyS5hxeI8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #137 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151141&action=edit Bug 8179: Fix JS indentation in parcel.tt Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 18:35:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 16:35:26 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-0lDzs5DwjO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #138 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151142&action=edit Bug 8179: Cosmetic changes Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 18:35:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 16:35:31 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-0FSzyqq6y1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #139 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151143&action=edit Bug 8179: Fund required Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 18:35:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 16:35:35 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-bCKdpWtftn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #140 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151144&action=edit Bug 8179: (QA follow-up) Date received should default to today Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 18:35:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 16:35:40 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-F32mRda7rG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #141 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151145&action=edit Bug 8179: (QA follow-up) Fix currency conversion Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 19:32:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 17:32:07 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-dZ4Goo16bd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151031|0 |1 is obsolete| | --- Comment #7 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151146&action=edit Bug 33716: New ILLModuleDisclaimerByType sys pref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 19:32:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 17:32:10 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-tyx90i7YaL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151032|0 |1 is obsolete| | --- Comment #8 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151147&action=edit Bug 33716: Preparation New Illrequest::Workflow superclass New Illrequest::Workflow::TypeDisclaimer Moved Illrequest::Availability to Illrequest::Workflow::Availability Removed check for backend capability "should_display_availability" Instead, the check is now done for "can_create_request" backend capability This serves the purpose of having the backend let core know if it can create the request or not. In other words, if the create form has been submitted or not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 19:32:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 17:32:12 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-YEEb23EXWW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151033|0 |1 is obsolete| | --- Comment #9 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151148&action=edit Bug 33716: ILL Type Disclaimer - Staff Update the way Availability is handled Add the new type disclaimer workflow operation after Availability -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 19:32:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 17:32:15 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-75a1WYygCA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151034|0 |1 is obsolete| | --- Comment #10 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151149&action=edit Bug 33716: ILL Type Disclaimer - OPAC Update the way Availability is handled Add the new type disclaimer workflow operation after Availability -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 19:32:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 17:32:18 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-sOeugmyaUj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151035|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151150&action=edit Bug 33716: Tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 19:33:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 17:33:26 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-xSL2PSR9IN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30719 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 [Bug 30719] ILL should provide the ability to create batch requests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 19:33:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 17:33:26 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-tnD3O7vd5F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33716 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 [Bug 33716] ILL - Allow for a disclaimer stage per request type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 19:53:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 17:53:23 +0000 Subject: [Koha-bugs] [Bug 33725] New: Add item's collection code to search results location column in staff interface Message-ID: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33725 Bug ID: 33725 Summary: Add item's collection code to search results location column in staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be handy if the location column in search results included the collection code. This can be helpful information to librarians as they are scanning the results page for relevant information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 19:56:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 17:56:41 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-mwzANzu6b5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #142 from Kyle M Hall <kyle at bywatersolutions.com> --- I gone over the open issues and everything looks good for me except for the currency issue and the received date, which I've supplied fixes for! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 19:57:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 17:57:03 +0000 Subject: [Koha-bugs] [Bug 33725] Add item's collection code to search results location column in staff interface In-Reply-To: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33725-70-a3zOkB9qSH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33725 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 19:57:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 17:57:05 +0000 Subject: [Koha-bugs] [Bug 33725] Add item's collection code to search results location column in staff interface In-Reply-To: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33725-70-WThswQl7Dc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33725 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151151&action=edit Bug 33725: Add collection to search results To test: 1. Apply patch and restart services 2. Do a catalog search that will return available, onloan, and notforloan items. (withdrawn,lost,damaged) 3. Notice that the location column should now also include the collection description underneath the shelving location. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 19:57:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 17:57:24 +0000 Subject: [Koha-bugs] [Bug 33725] Add item's collection code to search results location column in staff interface In-Reply-To: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33725-70-QOATXm2XhC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33725 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 19:58:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 17:58:46 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-ejMDjGmANb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151145|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:04:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:04:01 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-kApmFtM8LZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147952|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:04:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:04:07 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-YcwTEtcrLP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147953|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:04:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:04:14 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-Xwrp4vh1OG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147954|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:04:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:04:18 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-k3vlw74X2V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:04:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:04:22 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-FJm1TNtTBt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147956|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:05:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:05:31 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11300-70-T0W4avzYR5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #51 from Phil Ringnalda <phil at chetcolibrary.org> --- Here's a super-simple test plan, which fails. 1. Set the preference LinkerModule to Z39.50 Server 2. Set the preference LinkerZ3950Server to LIBRARY OF CONGRESS SUBJECTS 3. Set the preference LinkerOptions to local_first 4. Verify that your local authorities include "Perl (Computer program language)" but do not include "Scripting languages (Computer science)" 5. Cataloging > New record 6. In tab 6, field 650, paste Perl (Computer program language) in subfield a and click "Link authorities automatically" - you should be told "650 - A matching authority was found in the local database." which verifies that authority linking currently works at all. 7. Clear the 650 by clicking the "Delete this tag" icon with the red X at the end of the tag description, and paste "Scripting languages (Computer science)" in subfield a and click "Link authorities automatically" - if you are told "650 - No matching authority found" then this patch does not work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:06:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:06:16 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-RSg0FEyruv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:06:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:06:19 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-PwbKs8GFmN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #45 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151152&action=edit Bug 30719: DB and API - Adds 'batch' accessor to Illrequest object - New illbatches and illbatch_statuses tables - New foreign key 'batch_id' in illrequests table - Atomic update file - Default illbatch_statuses - Add 'add' ill_requests api method - Add POST method in ill_requests path - Add 'batch_id property to ill_request api definition - Updated swagger.yml with new batches and batchstatuses endpoints Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:06:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:06:23 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-sA92W09rjD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #46 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151153&action=edit Bug 30719: ILL Batches - Add batch column to requests table - Establish if there are any availability or metadata enrichment plugins and pass that to the template - Verify if we have any backend that can support batches, if not, don't show the option - Updates to the ILL toolbar - New ILL batch modal - New Koha classes - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:06:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:06:26 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-jeTMCBWdhk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #47 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151154&action=edit Bug 30719: ILL Batch Statuses - UI adding support for batch statuses in batch UI - Admin UI for managing batch statuses - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:06:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:06:29 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-Pcl08JpzDZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #48 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151155&action=edit Bug 30719: Tests Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:06:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:06:32 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-lgvs8482Hf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #49 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151156&action=edit Bug 30719: dbic specific, DONT PUSH -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:08:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:08:19 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11300-70-qLlnS6KCc7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 --- Comment #52 from Phil Ringnalda <phil at chetcolibrary.org> --- Also, the patch has included adding the file C4/Biblio.pm.rej for a couple of years now. Also, there are still unaddressed concerns from comment 24 from 5+ years ago. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:08:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:08:52 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-74N2QfCm9R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #50 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- This has now been rebased on top of 22440 and 33716 and is ready for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:11:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:11:39 +0000 Subject: [Koha-bugs] [Bug 33713] Report batch operations should open in new tab In-Reply-To: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33713-70-Pi0d6iqjiP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33713 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:11:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:11:41 +0000 Subject: [Koha-bugs] [Bug 33713] Report batch operations should open in new tab In-Reply-To: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33713-70-vdJt1mAnif@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33713 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151157&action=edit Bug 33713: Make batch operations from report results open in new tab To test: 1. Have some reports that can do the following batch operations: -Batch patron mod -Batch item deletion -Batch add to list -Batch item mod -Batch record delection -Batch record mod 2. Run the report ann click 'Batch operations with X visible records', make sure each batch op opens in a new tab. These two simple reports should allow you to test each of the batch cases: select * from items limit 1 select * from borrowers limit 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:11:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:11:54 +0000 Subject: [Koha-bugs] [Bug 33713] Report batch operations should open in new tab In-Reply-To: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33713-70-4QpZpdrCBQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33713 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:13:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:13:30 +0000 Subject: [Koha-bugs] [Bug 32799] ILLSTATUS authorized value category name is confusing In-Reply-To: <bug-32799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32799-70-XXwIRGbJOd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/685 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:15:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:15:56 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-NKucJZtZW6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #42 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Please avoid including schema file updates along with other changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:46:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:46:56 +0000 Subject: [Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail In-Reply-To: <bug-15461-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15461-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15461-70-NinThLemgY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33725 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:46:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:46:56 +0000 Subject: [Koha-bugs] [Bug 33725] Add item's collection code to search results location column in staff interface In-Reply-To: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33725-70-lDWCsEnYMb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33725 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15461 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:47:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:47:13 +0000 Subject: [Koha-bugs] [Bug 30412] Separate shelving location column in holdings table in staff interface In-Reply-To: <bug-30412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30412-70-yfnbqtndtZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30412 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33725 CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:47:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:47:13 +0000 Subject: [Koha-bugs] [Bug 33725] Add item's collection code to search results location column in staff interface In-Reply-To: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33725-70-LFoczFGODi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33725 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30412 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:48:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:48:13 +0000 Subject: [Koha-bugs] [Bug 30412] Separate shelving location column in holdings table in staff interface In-Reply-To: <bug-30412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30412-70-ZfMzlGBu18@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30412 --- Comment #7 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- Is this a dupe of bug 15461? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:54:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:54:11 +0000 Subject: [Koha-bugs] [Bug 33725] Add item's collection code to search results location column in staff interface In-Reply-To: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33725-70-TzS8CsBiBS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33725 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151151|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 151158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151158&action=edit Bug 33725: Add collection to search results To test: 1. Apply patch and restart services 2. Do a catalog search that will return available, onloan, and notforloan items. (withdrawn,lost,damaged) 3. Notice that the location column should now also include the collection description underneath the shelving location. Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:54:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:54:23 +0000 Subject: [Koha-bugs] [Bug 33725] Add item's collection code to search results location column in staff interface In-Reply-To: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33725-70-PUXJWkFxvJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33725 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 20:59:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 18:59:32 +0000 Subject: [Koha-bugs] [Bug 33713] Report batch operations should open in new tab In-Reply-To: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33713-70-rz8PAQ8mGM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33713 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151157|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 151159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151159&action=edit Bug 33713: Make batch operations from report results open in new tab To test: 1. Have some reports that can do the following batch operations: -Batch patron mod -Batch item deletion -Batch add to list -Batch item mod -Batch record delection -Batch record mod 2. Run the report ann click 'Batch operations with X visible records', make sure each batch op opens in a new tab. These two simple reports should allow you to test each of the batch cases: select * from items limit 1 select * from borrowers limit 1 Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 21:00:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 19:00:08 +0000 Subject: [Koha-bugs] [Bug 33713] Report batch operations should open in new tab In-Reply-To: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33713-70-mK4693zSMM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33713 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 21:00:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 19:00:23 +0000 Subject: [Koha-bugs] [Bug 33725] Add item's collection code to search results location column in staff interface In-Reply-To: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33725-70-O7QuBxwNVk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33725 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15461, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30412 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 21:00:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 19:00:23 +0000 Subject: [Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail In-Reply-To: <bug-15461-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15461-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15461-70-ZBL2m1ApQy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33725 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 21:00:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 19:00:23 +0000 Subject: [Koha-bugs] [Bug 30412] Separate shelving location column in holdings table in staff interface In-Reply-To: <bug-30412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30412-70-XWpbjSNQKF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30412 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33725 | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 21:50:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 19:50:53 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library In-Reply-To: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30624-70-oGuf8FoAkl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/685 Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 21:53:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 19:53:32 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library In-Reply-To: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30624-70-qDBDz39rbQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a new release notes| |permission, | |loggedinlibrary, to allow | |or prevent staff members to | |set the library where they | |log in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 21:57:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 19:57:53 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-nSZ4uTd5Ms@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #143 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I was reviewing at the same time as Kyle by the looks.. didn't make it as far as he did clearly as he did some follow-ups. Generally it's all looking good.. I'm happy to lend a hand on any fixes needed if we missed something. Great work guys. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:12:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:12:38 +0000 Subject: [Koha-bugs] [Bug 32129] Use patron categorycode of most relevant recall when checking if item can be a waiting recall In-Reply-To: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32129-70-7sGYg95D40@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151160&action=edit Bug 32129: (QA follow-up) Avoid duplicate calculation This patch stores the output from ->check_recall() (a Koha::Recall object or undef) and reuses afterwards, on a ternaty operator. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:15:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:15:48 +0000 Subject: [Koha-bugs] [Bug 33726] New: Koha::Item->check_recalls needs to be renamed Message-ID: <bug-33726-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33726 Bug ID: 33726 Summary: Koha::Item->check_recalls needs to be renamed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org The name clearly comes from emulating CheckReserves or something similar. We could pick `most_relevant_recall`. Someone familiar with the feature could come up with something better. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:15:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:15:54 +0000 Subject: [Koha-bugs] [Bug 33726] Koha::Item->check_recalls needs to be renamed In-Reply-To: <bug-33726-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33726-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33726-70-y6CkH8PCLe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33726 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32129 CC| |tomascohen at gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129 [Bug 32129] Use patron categorycode of most relevant recall when checking if item can be a waiting recall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:15:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:15:54 +0000 Subject: [Koha-bugs] [Bug 32129] Use patron categorycode of most relevant recall when checking if item can be a waiting recall In-Reply-To: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32129-70-3x3WJe7EdJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33726 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33726 [Bug 33726] Koha::Item->check_recalls needs to be renamed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:25:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:25:55 +0000 Subject: [Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record In-Reply-To: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26314-70-3DeBouAppf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |phil at chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:34:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:34:21 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3150-70-4K67ea2enO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/685 Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:34:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:34:23 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-5jpk6oDKHC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 Bug 33223 depends on bug 3150, which changed state. Bug 3150 Summary: Move emails for sending cart and list contents into notices tool https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:34:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:34:23 +0000 Subject: [Koha-bugs] [Bug 7001] User Configurable Slips In-Reply-To: <bug-7001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7001-70-X0mcsEDUgC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001 Bug 7001 depends on bug 3150, which changed state. Bug 3150 Summary: Move emails for sending cart and list contents into notices tool https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:46:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:46:06 +0000 Subject: [Koha-bugs] [Bug 33488] Library transfer limits should have an index on fromBranch In-Reply-To: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33488-70-jdmzZynJaw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33488 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151161&action=edit Bug 33488: (QA follow-up) Fix index name Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:54:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:54:19 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-o8g2dLZBUv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:54:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:54:21 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-NBPExw7oFG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #43 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:54:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:54:23 +0000 Subject: [Koha-bugs] [Bug 32129] Use patron categorycode of most relevant recall when checking if item can be a waiting recall In-Reply-To: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32129-70-pORkwFmZxV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:54:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:54:25 +0000 Subject: [Koha-bugs] [Bug 32129] Use patron categorycode of most relevant recall when checking if item can be a waiting recall In-Reply-To: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32129-70-EndzJyW3ou@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:54:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:54:27 +0000 Subject: [Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL In-Reply-To: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32357-70-T4cFiYQswa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:54:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:54:29 +0000 Subject: [Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL In-Reply-To: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32357-70-hZyTkuyXRW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 --- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:54:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:54:31 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33335-70-YOdDkPlLKY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:54:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:54:33 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33335-70-AhDTACyLaa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 --- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:54:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:54:35 +0000 Subject: [Koha-bugs] [Bug 33488] Library transfer limits should have an index on fromBranch In-Reply-To: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33488-70-IQxufWdniv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33488 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:54:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:54:36 +0000 Subject: [Koha-bugs] [Bug 33488] Library transfer limits should have an index on fromBranch In-Reply-To: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33488-70-U2pCTKY1kn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33488 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:54:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:54:38 +0000 Subject: [Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields In-Reply-To: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33489-70-rG8IVGAD3q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:54:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:54:40 +0000 Subject: [Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields In-Reply-To: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33489-70-ugI057Pffo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:54:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:54:42 +0000 Subject: [Koha-bugs] [Bug 33710] Ignore howto files In-Reply-To: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33710-70-OmQkq720MZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33710 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 22:54:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 20:54:43 +0000 Subject: [Koha-bugs] [Bug 33710] Ignore howto files In-Reply-To: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33710-70-EX7Xdz6FOt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33710 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 23:09:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 21:09:16 +0000 Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content warnings' to catalogue records In-Reply-To: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31123-70-uKicOFZZcd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/685 CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 23:09:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 21:09:16 +0000 Subject: [Koha-bugs] [Bug 31551] Add a 'Quick add' option for harmful content warnings. In-Reply-To: <bug-31551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31551-70-VZuSwdg3sq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31551 Bug 31551 depends on bug 31123, which changed state. Bug 31123 Summary: Add a simple way to add 'Harmful content warnings' to catalogue records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 23:19:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 21:19:03 +0000 Subject: [Koha-bugs] [Bug 33247] Deleted authority still on results list In-Reply-To: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33247-70-y31SfwHTF2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil at chetcolibrary.org --- Comment #4 from Phil Ringnalda <phil at chetcolibrary.org> --- Enough for people who never delete more than one between index updates, maybe. I routinely have 5-10 deleted between updates multiple times a day. We actually already have a dirty indication of deleted records if your search didn't specify an authority type, since in that case we can't look up the authority type to display it above the heading in the search results. So already-deleted headings are the ones with a slightly shorter row because they don't have the authority type part of the display. Maybe try to look up the authority type even when it's specified in the search, and when the record isn't found, mark it as deleted/missing? I'd be surprised if that made a noticeable perf hit, what with everything else we have to do to assemble a page of search results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 23:30:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 21:30:45 +0000 Subject: [Koha-bugs] [Bug 33247] Deleted authority still on results list In-Reply-To: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33247-70-lnCAmQhp6Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 12 23:30:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 21:30:48 +0000 Subject: [Koha-bugs] [Bug 33247] Deleted authority still on results list In-Reply-To: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33247-70-Obt6JxLvhO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151070|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Created attachment 151162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151162&action=edit Bug 33247: Flag the authority pending deletion in the result list When an authority is removed from the result list it is not removed from the search engine yet. This patch suggests to add a note in the summary column to tell the user that the deletion is pending. Test plan: 1 - Go to authorities home and perform a search; 2 - Delete any authority; 3 - After the confirmation, the page is refreshed but still contains the deleted authority, with a red note explaining that the deletion is pending. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 00:01:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 May 2023 22:01:19 +0000 Subject: [Koha-bugs] [Bug 27255] Authorized values does not allow you to provide a description for the category In-Reply-To: <bug-27255-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27255-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27255-70-vn70sEsKOC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27255 Pablo AB <pablo.bianchi at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi at gmail.com --- Comment #2 from Pablo AB <pablo.bianchi at gmail.com> --- This seems a duplicate of bug 23861. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 13 02:11:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2023 00:11:40 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-BmoHuqt34P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #144 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 151163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151163&action=edit Bug 8179: (follow-up) Fix currency change and remove datatables select -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 04:55:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2023 02:55:16 +0000 Subject: [Koha-bugs] [Bug 29993] Syndetics cover images do not display in browse shelf when scrolling from the first page In-Reply-To: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29993-70-GXQ80gEU1p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #4 from Victor Grousset/tuxayo <victor at tuxayo.net> --- test note: just put "test" in SyndeticsClientCode, it worked, that was total guesswork ^^" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 06:33:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2023 04:33:44 +0000 Subject: [Koha-bugs] [Bug 29993] Syndetics cover images do not display in browse shelf when scrolling from the first page In-Reply-To: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29993-70-rPLosrGguY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149766|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Created attachment 151164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151164&action=edit Bug 29993: Show Syndetics covers when using shelfbrowser controls 1. Have items that include itemcallnumber. 2. Enable OPACShelfBrowser. 3. Enable SyndeticsCoverImages and SyndeticsEnabled. 4. Go the an OPAC detail page and open the shelf browser. 5. Use the Next/Previous buttons. 6. Notice that no Syndetics images populate after using Next/Previous buttons. 7. Apply patch and try again, cover images for Syndetics should be generating. Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> Rebased-by: Victor Grousset/tuxayo <victor at tuxayo.net> Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 06:34:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2023 04:34:03 +0000 Subject: [Koha-bugs] [Bug 29993] Syndetics cover images do not display in browse shelf when scrolling from the first page In-Reply-To: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29993-70-hwRFRTsLoQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #6 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Works, makes sense, QA script happy, code ok, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 08:17:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2023 06:17:57 +0000 Subject: [Koha-bugs] [Bug 30002] Add project-level perltidyrc In-Reply-To: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30002-70-LUbAQXDD8M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:25:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2023 12:25:44 +0000 Subject: [Koha-bugs] [Bug 33727] New: Merge Calendar tests Message-ID: <bug-33727-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33727 Bug ID: 33727 Summary: Merge Calendar tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Move tests from t/Calendar to t/db/Calendar, remove need for Test::DBIx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:27:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2023 12:27:36 +0000 Subject: [Koha-bugs] [Bug 33727] Merge Calendar tests In-Reply-To: <bug-33727-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33727-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33727-70-77I5DuXN7a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33727 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:27:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2023 12:27:38 +0000 Subject: [Koha-bugs] [Bug 33727] Merge Calendar tests In-Reply-To: <bug-33727-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33727-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33727-70-iqc090VtHw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33727 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151165&action=edit Bug 33727: Groundwork for Calendar.t Update test while removing need for Test::DBIx::Class. Test plan: Run t/Calendar.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:27:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2023 12:27:41 +0000 Subject: [Koha-bugs] [Bug 33727] Merge Calendar tests In-Reply-To: <bug-33727-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33727-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33727-70-uYPvPPMrkI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33727 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151166&action=edit Bug 33727: Merge both Calendar tests The old t tests become part of the first subtest. Test plan: Run the new t/db_dependent/Calendar.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 14:27:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2023 12:27:49 +0000 Subject: [Koha-bugs] [Bug 33727] Merge Calendar tests In-Reply-To: <bug-33727-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33727-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33727-70-wKhr9SKNdo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33727 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 15:33:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2023 13:33:44 +0000 Subject: [Koha-bugs] [Bug 27309] Add plugin hooks for capturing raw passwords (NNPDB) In-Reply-To: <bug-27309-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27309-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27309-70-clDPinCzzx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27309 mathieu saby <mathsabypro at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 18:52:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2023 16:52:16 +0000 Subject: [Koha-bugs] [Bug 33728] New: Add a way to copy a report result to clipboard Message-ID: <bug-33728-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33728 Bug ID: 33728 Summary: Add a way to copy a report result to clipboard Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org It could be useful to have a button or a menu to copy easily the result of a report to clipboard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 13 19:06:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 May 2023 17:06:15 +0000 Subject: [Koha-bugs] [Bug 33729] New: Add a column for dateaccessioned to item search results Message-ID: <bug-33729-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33729 Bug ID: 33729 Summary: Add a column for dateaccessioned to item search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org It would be useful to add a column for dateaccessioned to item search results -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 14 06:27:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 04:27:46 +0000 Subject: [Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 In-Reply-To: <bug-25439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25439-70-usdkICrpv5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 --- Comment #17 from Victor Grousset/tuxayo <victor at tuxayo.net> --- > So unless someone thinks of a problem I'll update the system requirements wikipage with that. Finally done. For ES 7 and OS 1 support. No recommendation for now, I'll have to email the 2nd half for comment 15 to koha-devel so we settle on something. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 06:38:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 04:38:54 +0000 Subject: [Koha-bugs] [Bug 33353] Add compatibility with Elasticsearch 8 In-Reply-To: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33353-70-81gMnTRirD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33353 --- Comment #15 from Victor Grousset/tuxayo <victor at tuxayo.net> --- > This bug caught my attention last week, and I have been watching with interest to see what responses there would be to Victor's question here. In the absence of any (so far), I would like to offer the perspective of a system administrator in the wild: Hi, welcome :) More input can definitely help to unblock this. > 1. The version included by Koha appeared to be one that had reached end-of-life with the publisher ES 7 and OpenSearch 1.X (which isn't eol) has been supported since a year. But we didn't update the systems requirements documentation (now it's finally updated) due to not having the time to search for real work usage to confidently claim support :-/ > 2. Even the supported version had been associated with significant data breaches You mean the log4j vulnerabilities? (latest 6.x patched them) or like bad defaults? Is your statement still valid for ES 7.x? > 3. There seemed to be a lack of clarity following the change in licensing and the open source world's response to it. Indeed! About that, to have more material to raise awareness about the issue, do you happen to know more about the open source world's response to it? Besides Debian, Fedora and the Open Source Initiative not considering the SSPL license libre/open source? > - Our production server runs 22.05, BUT I can imagine a willingness to leap forward a bit if OpenSearch is backported to 22.11. You can do that right away with OpenSearch 1.x , 22.05 supported it on launch. Sorry again for the delay in advertising it's support. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 12:59:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 10:59:26 +0000 Subject: [Koha-bugs] [Bug 33272] Color of the "(remove)" link when an item is in the cart (OPAC) In-Reply-To: <bug-33272-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33272-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33272-70-WDGIHrCb5d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151167&action=edit k -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:01:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:01:23 +0000 Subject: [Koha-bugs] [Bug 33727] Merge Calendar tests In-Reply-To: <bug-33727-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33727-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33727-70-QmMxJBeMAi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33727 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:01:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:01:26 +0000 Subject: [Koha-bugs] [Bug 33727] Merge Calendar tests In-Reply-To: <bug-33727-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33727-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33727-70-kTRURAppxO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33727 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151165|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151168&action=edit Bug 33727: Groundwork for Calendar.t Update test while removing need for Test::DBIx::Class. Test plan: Run t/Calendar.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:01:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:01:29 +0000 Subject: [Koha-bugs] [Bug 33727] Merge Calendar tests In-Reply-To: <bug-33727-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33727-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33727-70-x63ukAPrTv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33727 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151166|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151169&action=edit Bug 33727: Merge both Calendar tests The old t tests become part of the first subtest. Test plan: Run the new t/db_dependent/Calendar.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:03:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:03:48 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-WEWkcvIEyZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:06:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:06:09 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-2sPM1ta3Am@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:06:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:06:12 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-DWYRKmaxn4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151110|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151170&action=edit Bug 33718: Fix the mock of Koha::Config->get in mock_config It should not mock calls for other sections than 'config' in koha-conf.xml. Test plan: Without this patch: [1] Enable AutoLinkBiblios, CatalogModuleRelink and LinkerRelink. This will trigger a SearchAuthorities call when creating a sample biblio. Note: SearchAuthorities calls Zconn and gets back information from a wrong part of koha-conf.xml. [2] Run t/db_dependent/Koha/Pseudonymization.t You should see something like: {UNKNOWN}: Can't use string ("authorities") as a HASH ref while "strict refs" in use at /usr/share/koha/C4/Context.pm line 587. at /usr/share/koha/C4/Biblio.pm line 302 With this patch: [3] Run t/db_dependent/Koha/Pseudonymization.t. Should pass now. [4] git grep -l mock_config | xargs -i{} prove {} Exclude Mocks.pm. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:08:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:08:49 +0000 Subject: [Koha-bugs] [Bug 33009] bump Standards-Version to 4.6.2 In-Reply-To: <bug-33009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33009-70-jZhCboXZ2A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33009 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- If I remember correctly one of the things that keeps us out of the Debian repository is our messy copyright statements. It didn't look like an easy fix at all. I'd go with trusting Mason here. Mason, could you give a quick feedback to the questions maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:11:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:11:52 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-RiLw89gD07@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add an API endpoint for |Add an API endpoint for |issuing an item to a patron |checking an item out to a | |patron --- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Danyon Sewell from comment #18) > Going to be working on the check-in API endpoint now just in case there is > already work being done on it, I really should have checked for duplicates > before working on the checkout one too but oh well. Duplicates are not always easy to spot especially with different terminology used (issue/checkout etc.). I hope this fits your needs as well? And welcome, Danyon :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:19:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:19:26 +0000 Subject: [Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order In-Reply-To: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33721-70-SSTF5sf0nx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:22:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:22:31 +0000 Subject: [Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order In-Reply-To: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33721-70-blqOKZzNwp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:22:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:22:33 +0000 Subject: [Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order In-Reply-To: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33721-70-DGMtNI2ey3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151171&action=edit Bug 33721: Fix display of shipping cost/fund on invoice summary page When viewing an invoice, the elements in the 'Fund' line were out of order: 'Fund:' label, followed by 'Show inactive:' label, then the fund drop-down and then the show inactive checkbox. The order should be: 'Fund:' label, fund drop-down, 'Show inactive:' label, show inactive checkbox. This copies the markup that is used when you click on "Receive shipment". It also changes 'Fund' to 'Shipping fund' to bring the forms even more in line. To recreate: 1. In acquisitions, create an order and close the basket 2. Click 'Receive shipment' and receive the order 3. Click 'Finish receiving' --> The Fund line in invoice.tt is out of order 4. Apply patch 5. Verify the order is now fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:29:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:29:33 +0000 Subject: [Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC In-Reply-To: <bug-31051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31051-70-wVuWDCrNZ7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 --- Comment #55 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Caroline Cyr La Rose from comment #54) > Can the [% IF savings %] [% savings | $Price with_symbol => 1 %] be used in > notices? It would be useful to replace > https://wiki.koha-community.org/wiki/ > Notices_and_Slips_Library#Add_total_value_of_items_borrowed_to_date_on_issue_ > slip Hi Caroline, I tested in CHECKIN and this works: [% USE Price %] [% borrower.get_savings | $Price with_symbol => 1 %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:40:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:40:20 +0000 Subject: [Koha-bugs] [Bug 33246] itemBarcodeFallbackSearch search results should show whether or not items are available In-Reply-To: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33246-70-LRTCm25Y8Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33246 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:40:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:40:22 +0000 Subject: [Koha-bugs] [Bug 33246] itemBarcodeFallbackSearch search results should show whether or not items are available In-Reply-To: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33246-70-oQlRZnw80j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33246 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151071|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151172&action=edit Bug 33246: Show the onloan status on the BarcodeFallbackSearch result Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:40:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:40:25 +0000 Subject: [Koha-bugs] [Bug 33246] itemBarcodeFallbackSearch search results should show whether or not items are available In-Reply-To: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33246-70-dvXlPjODjr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33246 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151173&action=edit Bug 33246: Add some space between icon and text when there is only one result When there is only one result line, the text "Checked out" would show directly after the icon at the end of the title. This makes sure there will always be a little space between them. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:42:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:42:42 +0000 Subject: [Koha-bugs] [Bug 33246] itemBarcodeFallbackSearch search results should show whether or not items are available In-Reply-To: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33246-70-rZkc5VIdQO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33246 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I like that it's at the beginning of the table, so quite obvious. It's also only a small change, so we could consider putting it in 22.11 as well. I imagine maybe having a filter on 'checked out' would be nice that is set by default and can be unset if needed. Usually the item presented to you should not be the checked out in this situation. It could also be nice to have a different background color for the full line as they can be a little long. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:50:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:50:03 +0000 Subject: [Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable In-Reply-To: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33463-70-eacquymOUl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #2) > Looks like there are much more occurrences. > > git grep 'Actions</th>'|grep -v NoSort > > We should fix them all. I have checked a few and I think there is other mark-up there to prevent them from being sorted sometimes: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt: <th class="noExport">Actions</th> Action column on vendor search is NOT sortable. koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt:<th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt: <th>Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt: <th class="noExport">Actions</th> Actions IS sortable. koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqcontract.tt: <th scope="col">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt: <th data-class-name="actions noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/cash_registers.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt: <th scope="col">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt: <th data-class-name="actions noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/credit_types.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_accounts.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_ean_accounts.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt: <th data-class-name="actions noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt: <th data-class-name="actions noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_fields.tt: <th class="noExport">Actions</th> Table is not sortable at all. koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt: <th>Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt: <th class="noExport">Actions</th> Table is not sortable at all. koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt: <th scope="col">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: <th class="noExport">Actions</th> Actions is NOT sortable. I feel this might be a nice excercise for maybe a newbiew/intro session as they require taking a closer look maybe? I feel we can still push this one. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:51:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:51:00 +0000 Subject: [Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable In-Reply-To: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33463-70-mwajHKyzos@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:51:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:51:25 +0000 Subject: [Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable In-Reply-To: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33463-70-cu6fX9sCgz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:51:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:51:27 +0000 Subject: [Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable In-Reply-To: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33463-70-Apw6TYdQAR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151066|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151174&action=edit Bug 33463: Remove sort for 'Actions' on the plugins table Test plan: Go go the plugin admin page upload a plugin Notice that the "Actions" column is not longuer sortable Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:53:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:53:47 +0000 Subject: [Koha-bugs] [Bug 33730] New: Action column should not be sortable Message-ID: <bug-33730-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33730 Bug ID: 33730 Summary: Action column should not be sortable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 33463 fixes the Actions column on the plugins table to be not sortable. The fix used there can be also applied to other tables. Jonathan suggests this to detect other cases: git grep 'Actions</th>'|grep -v NoSort They might still need some individual attention as some tables are not sortable at all or sorting for Actions is already suppressed using different methods. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:53:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:53:47 +0000 Subject: [Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable In-Reply-To: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33463-70-ohW3DhdNH2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33730 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:54:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:54:35 +0000 Subject: [Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable In-Reply-To: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33463-70-JLe7qOXoqz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Filed: Bug 33730 - Action column should not be sortable Easy fix, excercising QAM super powers here: PQA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:56:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:56:44 +0000 Subject: [Koha-bugs] [Bug 31859] Error 500 when enabling advanced cataloging editor In-Reply-To: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31859-70-AIvaxkXATt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31859 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Could this be vug 33375? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:57:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:57:03 +0000 Subject: [Koha-bugs] [Bug 31859] Error 500 when enabling advanced cataloging editor In-Reply-To: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31859-70-9dynaOv8uV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31859 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #7) > Could this be vug 33375? Bug 33375. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:58:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:58:23 +0000 Subject: [Koha-bugs] [Bug 33714] Enabling advanced editor causes 500 error In-Reply-To: <bug-33714-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33714-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33714-70-4TkUlTkPXF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33714 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi, there was a bug fixing a similar issue. Please check your exact version to see if the fix is already included in your installation or not: Bug 33375 - Advanced editor crashes when using MySQL 8 due to reserved rank keyword See: Version(s) released in at the top section of the bug -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 14 13:59:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 11:59:15 +0000 Subject: [Koha-bugs] [Bug 33714] Enabling advanced editor causes 500 error In-Reply-To: <bug-33714-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33714-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33714-70-jbCW3Ye57K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33714 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, I realize if it's this bug, it will be neither fixed in 21.05 nor 21.11. Can you confirm if you are using MySQL8? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:01:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 12:01:42 +0000 Subject: [Koha-bugs] [Bug 33717] Typo in search_for_data_inconsistencies.pl In-Reply-To: <bug-33717-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33717-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33717-70-yI16Ioml3G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33717 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Severity|enhancement |trivial Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:02:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 12:02:10 +0000 Subject: [Koha-bugs] [Bug 33717] Typo in search_for_data_inconsistencies.pl In-Reply-To: <bug-33717-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33717-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33717-70-K7hPdtZmuX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33717 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:02:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 12:02:12 +0000 Subject: [Koha-bugs] [Bug 33717] Typo in search_for_data_inconsistencies.pl In-Reply-To: <bug-33717-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33717-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33717-70-n0Ji703SY5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33717 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151030|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151175&action=edit Bug 33717: Typo in search_for_data_inconsistencies.pl This patch corrects a typo in the output of search_for_data_inconsistencies.pl when a bibliographic record has no title. The patch also replaces biblio to bibliographic record in the same sentence for terminology consistency. To test: - Have a bibliographic record without a title - Run misc/maintenance/search_for_data_inconsistencies.pl - Read output, make sure the sentence is correct Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:03:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 12:03:03 +0000 Subject: [Koha-bugs] [Bug 33717] Typo in search_for_data_inconsistencies.pl In-Reply-To: <bug-33717-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33717-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33717-70-rsxjOonFxq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33717 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx, Caroline! Don't forget to assign yourself :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:10:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 12:10:05 +0000 Subject: [Koha-bugs] [Bug 17867] Improve display of source (MARC21 773) in result list In-Reply-To: <bug-17867-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17867-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17867-70-0LwvdN4v98@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17867 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think this has been resolved by bug 16522 that centralized the 773 display between detail and result pages using one common template in the Utils file. *** This bug has been marked as a duplicate of bug 16522 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:10:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 12:10:05 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16522-70-UJI3pOQiMB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #92 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 17867 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:30:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 12:30:16 +0000 Subject: [Koha-bugs] [Bug 33695] Audio alerts for self checkout broken In-Reply-To: <bug-33695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33695-70-pnKDSgyw5o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33695 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It turns out that the audio-alerts for sco only work when you use a full URL. *** This bug has been marked as a duplicate of bug 22406 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:30:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 12:30:16 +0000 Subject: [Koha-bugs] [Bug 22406] Add ability to play internal sounds in self checkout system In-Reply-To: <bug-22406-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22406-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22406-70-2xAkRHG3Q8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22406 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 33695 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:33:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 12:33:04 +0000 Subject: [Koha-bugs] [Bug 33731] New: Add hint to audio alert configuration page that for self checkout pages full URLs must be used Message-ID: <bug-33731-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33731 Bug ID: 33731 Summary: Add hint to audio alert configuration page that for self checkout pages full URLs must be used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The self checkout pages implement Audio alerts, but you can't pick a sound from the list, but have to enter a full URL instead in order to make them work (see bug 22406). This is not obvious and a little hint would be nice until this can be fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:34:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 12:34:17 +0000 Subject: [Koha-bugs] [Bug 33658] Capitalization: **To Reproduce** In-Reply-To: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33658-70-10ohNUbZUV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:34:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 12:34:51 +0000 Subject: [Koha-bugs] [Bug 33658] Capitalization: **To Reproduce** In-Reply-To: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33658-70-XPCrPTo5A0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 14:34:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 12:34:53 +0000 Subject: [Koha-bugs] [Bug 33658] Capitalization: **To Reproduce** In-Reply-To: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33658-70-wllraY9LmA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150966|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151176&action=edit Bug 33658: Fix capitalization 'To Reproduce' Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 17:32:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 15:32:55 +0000 Subject: [Koha-bugs] [Bug 33732] New: intranet Holdings Table uses opac item images Message-ID: <bug-33732-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33732 Bug ID: 33732 Summary: intranet Holdings Table uses opac item images Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: koha at trust-box.at QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com on the detail page in the intranet cgi-bin/koha/catalogue/detail.pl in the Holdings Table the image urls for the opac item images are used eg "opac-tmpl/bootstrap/itemtypeimg/bridge/book.png" and not the url to the intranet images like everywhere else <img src="/intranet-tmpl/prog/img/itemtypeimg/bridge/book.png" title="Books" alt="Books"> I am not sure if this intentional, but I doubt it thx Mark -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 17:33:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 15:33:39 +0000 Subject: [Koha-bugs] [Bug 33732] intranet Holdings Table uses opac item images In-Reply-To: <bug-33732-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33732-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33732-70-suQmxNUQrD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33732 Mark Hofstetter <koha at trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 14 17:35:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 15:35:13 +0000 Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23919-70-9X05SHDBqm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #39 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #38) > (In reply to Katrin Fischer from comment #37) > > I am sad to say, but adding this to item search was not a great idea :( > > > > Item search is SQL based, not a search engine, which changes things quite a > > bit. > > > > We are exploding the search now with up to 4 forms of ISBN into something > > like: > > > > isbn like 'isbn1' or isbn like 'isbn2' ... > > > > But: We are not truncating. > > > > As soon as there is more than one ISBN or ISSN (these are repeatable fields) > > or the library actually follows MARC21 standard adding ISBD punctuation, > > this fails. We store in biblioitems.isbn like this: > > > > isbn1 ; | isbn2 ; | isbn3. > > isbn1. > > > > This also seems to create quite a performance issue on big databases and it > > can't be turned off separately from the normal search. > > > > I've filed bug 33514. > > Can you please address bug 33514? In the meanwhile should we remove this? What do you mean with "address"? It's all explained there as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 17:38:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 15:38:29 +0000 Subject: [Koha-bugs] [Bug 33514] SearchWithIS[B|S]NVariations breaks ISBN search in item search In-Reply-To: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33514-70-Vgl8bm0D7n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am not sure what the best solution here is: 1) Remove the ISBN handling from item search. 2) Fix it to search for ISBN left and right truncated (%isbn%) a) create a separate system preference to turn it on/off b) leave it at one system preference as it is now that controls catalog and item search Note: the performance issues I mentioned earlier have been fixed by giving the databaes more resources. 2a? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 14 18:44:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 16:44:46 +0000 Subject: [Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order In-Reply-To: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33721-70-DKukXMAnSn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151171|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 151177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151177&action=edit Bug 33721: Fix display of shipping cost/fund on invoice summary page When viewing an invoice, the elements in the 'Fund' line were out of order: 'Fund:' label, followed by 'Show inactive:' label, then the fund drop-down and then the show inactive checkbox. The order should be: 'Fund:' label, fund drop-down, 'Show inactive:' label, show inactive checkbox. This copies the markup that is used when you click on "Receive shipment". It also changes 'Fund' to 'Shipping fund' to bring the forms even more in line. To recreate: 1. In acquisitions, create an order and close the basket 2. Click 'Receive shipment' and receive the order 3. Click 'Finish receiving' --> The Fund line in invoice.tt is out of order 4. Apply patch 5. Verify the order is now fixed Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 18:45:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 16:45:07 +0000 Subject: [Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order In-Reply-To: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33721-70-1UDZZ4bjYA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 18:51:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 16:51:07 +0000 Subject: [Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order In-Reply-To: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33721-70-tsa80pjQUI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thanks, Barbara! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 21:40:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 19:40:49 +0000 Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version In-Reply-To: <bug-23073-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23073-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23073-70-e7Xkll6Hrd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 --- Comment #39 from David Nind <david at davidnind.com> --- Message sent to the general mailing list: https://lists.katipo.co.nz/pipermail/koha/2023-May/059454.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 14 21:41:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 19:41:23 +0000 Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version In-Reply-To: <bug-23073-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23073-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23073-70-wOxGtzNsw8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #40 from David Nind <david at davidnind.com> --- Since the Wiki upgrade is completed, I've closed this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 01:16:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 23:16:46 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-wOzoZ8Mhmi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #63 from David Cook <dcook at prosentient.com.au> --- (In reply to Mengu Yazicioglu from comment #61) > As you know, if there is a change in database structure, we have to run post > installation steps from intranet part. Due to row format issues of some > tables, newly added ERM tables in the post installation steps gave many > errors saying "Row size too large..." > > In order to finish upgrade we have to click "Try again" button but first > solve the row format issue. In a new terminal, we have to change row_format > feature of related tables to DYNAMIC. Thanks, Mengu. I'm a bit surprised that the error would appear when adding new tables, since they should default to the DYNAMIC format when you're on a newer MySQL/MariaDB on a newer OS. Maybe something more to look at with your installation... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 01:35:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 23:35:38 +0000 Subject: [Koha-bugs] [Bug 33009] bump Standards-Version to 4.6.2 In-Reply-To: <bug-33009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33009-70-ijytjJOnR9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33009 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #9 from David Cook <dcook at prosentient.com.au> --- (In reply to Marcel de Rooy from comment #6) > I am reading: > When updating existing packaging, the Standards-Version must not be updated > except after reviewing the changes between the old and the new versions of > the standards and updating your package if necessary (the Upgrading > checklist can help with this task). > > Mason, how do/did we implement that review ? I think this is the checklist to which Marcel was referring: https://www.debian.org/doc/packaging-manuals/upgrading-checklist.txt There's about 4,884 words spanning 12 years in-between 3.8.4 and 4.6.2 so I don't think anyone's fully reviewed it. Perhaps we don't need to update all the way to 4.6.2 though. Maybe it's worth finding a middle ground and doing a review between 3.8.4 and there. I spent a little bit of time checking backwards from 3.8.4 and we looked compliant before it, although it's possible that we might not be 100% compliant going back to the very beginning... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 01:36:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 May 2023 23:36:33 +0000 Subject: [Koha-bugs] [Bug 30002] Add project-level perltidyrc In-Reply-To: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30002-70-39MBHYH6Mz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 02:08:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 00:08:55 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-1av4WB6Ti7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 02:08:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 00:08:58 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-KglJeKa7M6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150937|0 |1 is obsolete| | --- Comment #12 from David Nind <david at davidnind.com> --- Created attachment 151178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151178&action=edit Bug 33686: Update plugin unimarc_field_100.pl with 2022 values According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 02:09:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 00:09:01 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-4ZCU1O5u9k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150938|0 |1 is obsolete| | --- Comment #13 from David Nind <david at davidnind.com> --- Created attachment 151179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151179&action=edit Bug 33686: Correction of existing terms related to 'Script of title' According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 02:48:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 00:48:10 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-nIhy2QXYUC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150914|0 |1 is obsolete| | --- Comment #16 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Created attachment 151180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151180&action=edit Bug 26472: Configure Elasticsearch for better alphabetic sorting This enhancement configures the ICU collation keyword plugin used by Elasticsearch for sorting to better handle punctuation and whitespace in sort fields. Details at: https://www.elastic.co/guide/en/elasticsearch/plugins/current/analysis-icu-collation-keyword-field.html To test: 1. Create three authority records with the following values: 150 $a Science. 150 $a Science $v B. 150 $a Science $v C. 2. Search for your authority records with "Science" in "Heading A-Z" order The search results will likely be in this order: 1. Science B. 2. Science C. 3. Science. This is an unexpected order 3. Apply the patch and reindex sudo koha-elasticsearch --rebuild -r <instancename> 4. Search for your authority records again with "Science" in "Heading A-Z" order Confirm your search results show in the correct order. 1. Science. 2. Science B. 3. Science C. Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 02:49:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 00:49:32 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-uKuHCkFjME@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor at tuxayo.net --- Comment #17 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 07:49:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 05:49:36 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24401-70-AEiLYf94sk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 --- Comment #4 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Created attachment 151181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151181&action=edit Bug 24401: REST API: Checkin unit test fixes Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 07:54:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 05:54:12 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24401-70-oCfl2EKC1k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz Attachment #151181|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 07:55:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 05:55:40 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24401-70-MXXIy56tmf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 --- Comment #5 from Danyon Sewell <danyonsewell at catalyst.net.nz> --- Created attachment 151182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151182&action=edit bug 24401 - REST API: Check-in WIP Couple minor fixes to swagger.yaml Sponsored by: Auckland University of Technology -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 07:55:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 05:55:53 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24401-70-0dFpiillCi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 --- Comment #6 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Created attachment 151183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151183&action=edit Bug 24401: REST API: Checkin unit test fixes Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 08:20:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 06:20:21 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24401-70-SQldxfvZZm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 Danyon Sewell <danyonsewell at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151109|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 08:20:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 06:20:33 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24401-70-z7oRGWBzhx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 Danyon Sewell <danyonsewell at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151182|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 08:20:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 06:20:44 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24401-70-QUVu3os9ED@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 Danyon Sewell <danyonsewell at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151183|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 08:21:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 06:21:19 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24401-70-UI0WKdG0Yf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 --- Comment #7 from Danyon Sewell <danyonsewell at catalyst.net.nz> --- Created attachment 151184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151184&action=edit Bug 24401: REST API: Check-in Updating files to include API endpoints for check-ins Test plan: 1) Apply bug 23336 as there are dependencies in there required for this to work 2) Apply this patch 3) Run unit tests in t/db_dependent/api/v1/checkouts.t 4) Make POST request to http://yourlibrary/api/v1/checkouts with request body containing 'item_id' & 'library_id' properties. - Observe returned data and HTTP code - 201 for item checked in - 403 for check in not allowed - 409 for Item not found - 400 for item not checked out Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 08:21:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 06:21:46 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24401-70-ev9twn7IR3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 Danyon Sewell <danyonsewell at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 08:21:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 06:21:58 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24401-70-eNhDiQn1Dj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 Danyon Sewell <danyonsewell at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |danyonsewell at catalyst.net.n |ity.org |z -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 08:27:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 06:27:34 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-neju5Ukd2I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #12) > Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Thx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 09:01:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 07:01:21 +0000 Subject: [Koha-bugs] [Bug 33733] New: Move t/XSLT.t to db_dependent Message-ID: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 Bug ID: 33733 Summary: Move t/XSLT.t to db_dependent Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org This test is not database independent after all, reading various sysprefs from database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 09:12:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 07:12:53 +0000 Subject: [Koha-bugs] [Bug 24400] REST API: Checkout In-Reply-To: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24400-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24400-70-Ipfi3lhVNG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24400 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Apologies Danyon.. seems I missed a comment here when marking as a duplicate. It's not always easy to spot a duplicate.. especially given in this case there were a few with long histories. It's generally a good idea to ask questions on those with a history to help them move forward before having a fresh attemp, but I wouldn't let it hold you up too long either. In this case, I look at the code you submitted and did a comparison before picking which to set as a duplicate. The other bugs handles a few more cases, so I picked that one, but it also needs further development for it to fully cater for all the existing cases in the UI. I'd love some help there and your input would be greatly appreciated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 09:16:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 07:16:45 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-ktDqdCRdEI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I'm not aware of anyone working on a Check-in endpoint.. do you have a specification you're working from? I found checkout to be rather complex given all the cases that need to be accounted for (and not all of them are accounted or here as yet.. hence the tail of follow-up bugs) and I'm envisaging the same for Check-in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 09:23:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 07:23:48 +0000 Subject: [Koha-bugs] [Bug 33733] Move t/XSLT.t to db_dependent In-Reply-To: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33733-70-0SpxKGxTNQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 09:23:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 07:23:50 +0000 Subject: [Koha-bugs] [Bug 33733] Move t/XSLT.t to db_dependent In-Reply-To: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33733-70-cqd0V0VV7n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151185&action=edit Bug 33733: Remove need for Test::DBIx::Class Test plan: Run t/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 09:23:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 07:23:52 +0000 Subject: [Koha-bugs] [Bug 33733] Move t/XSLT.t to db_dependent In-Reply-To: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33733-70-ppmqy5lgeu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151186&action=edit Bug 33733: Fix indentation in subtest Test plan: git diff -w HEAD~1.. t/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 09:23:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 07:23:54 +0000 Subject: [Koha-bugs] [Bug 33733] Move t/XSLT.t to db_dependent In-Reply-To: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33733-70-O33LqcJZ8V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151187&action=edit Bug 33733: Move to db_dependent The subtest is added to the existing db_dependent test. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 09:24:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 07:24:12 +0000 Subject: [Koha-bugs] [Bug 33733] Move t/XSLT.t to db_dependent In-Reply-To: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33733-70-6f52CSYGcb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 09:25:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 07:25:02 +0000 Subject: [Koha-bugs] [Bug 33733] Move t/XSLT.t to db_dependent In-Reply-To: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33733-70-V8eVyre29s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:30:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 08:30:42 +0000 Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23919-70-7yVuthauuF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #40 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I was actually asking the author of 23919 (here) to fix the bug they introduced. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:39:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 08:39:53 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-7pX1JjA7U9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:40:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 08:40:03 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-771l6WGZtg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Comment on attachment 151123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151123 Bug 33580 - Bring back ability to mark item as seen via SIP2 item information request Review of attachment 151123: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=33580&attachment=151123) ----------------------------------------------------------------- ::: t/db_dependent/SIP/Message.t @@ +457,5 @@ > + $item_object->update({ itemlost => 1, datelastseen => '1900-01-01' }); > + $server->{account}->{seen_on_item_information} = 'keep_lost'; > + $msg->handle_item_information( $server ); > + $item_object = Koha::Items->find( $item_object->id ); > + isnt( $item_object->datelastseen, "1900-01-01", "datelastseen updated" ); The tests are failing due to date vs datetime format mismatch. However.. I think I'd also like ot have seen a different date used to prove the change.. at first glance this looks like it's checking the field that's already set.? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:40:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 08:40:28 +0000 Subject: [Koha-bugs] [Bug 33667] 'Copy to all libraries' doesn't work on editing holidays In-Reply-To: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33667-70-3XJvRKGvAY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33667 --- Comment #6 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> --- (In reply to Katrin Fischer from comment #5) > You are probably right. Does it need a little hint/warning maybe: may > overwrite existing holidays in other calendars? Good idea. I'll assign myself on this for now. Hopefully I'm able to work on this soon. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:40:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 08:40:44 +0000 Subject: [Koha-bugs] [Bug 33667] 'Copy to all libraries' doesn't work on editing holidays In-Reply-To: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33667-70-9J0iuW7Q1Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33667 Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at koha-suomi.fi |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:50:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 08:50:12 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-pH5wRcHCaJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Doh.. I missed that it's an `isnt`! So, the test checks out.. but the format is still a problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:50:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 08:50:35 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-r9epaYe7vw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151188&action=edit Bug 33580: fix tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:51:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 08:51:29 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-UDZpaLBdeZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Looks like some of you forgot that there is a --run-tests flag that you can pass to the qa script... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:52:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 08:52:24 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-MbLaUEwtX0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #9) > Created attachment 151188 [details] [review] > Bug 33580: fix tests My try at fixing the tests, no idea if it's correct but it seems to be what it should have been. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:52:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 08:52:49 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-xYApEhh8op@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Looks like someone changed datelastseen :) commit f729d46478fbfbb258262888941a6aa42da04d70 Author: Lucas Gass <lucas at bywatersolutions.com> Date: Tue Feb 7 23:14:43 2023 +0000 Bug 31212: Change datelastseen from date to datetime field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:54:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 08:54:40 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-ExBX4P5wMn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Ho right, datelastseen has been changed to datetime on 31212, pushed at the same time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:57:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 08:57:18 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-5rdkFmGRfN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #44 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151189&action=edit Bug 31212: Fix api/v1/items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:58:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 08:58:01 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-2ozcXZU4Dv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151189|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151190&action=edit Bug 31212: Fix api/v1/items.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:58:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 08:58:53 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-5LhnVQpwPM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149887|0 |1 is obsolete| | --- Comment #37 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151191&action=edit Bug 32680: Add cover images plugin hook This patch adds a plugin hook to inject cover images into the templates Test plan: 1) Apply all patches 2) Go to https://github.com/PTFS-Europe/koha-plugin-addBDSCovers 3) In the releases section, download the .kpz file 4) Upload this in the plugins section and enable the plugin 5) In either the OPAC or staff client, search the catalog 6) The results should have cover art from BDS covers 7) Click on a result and the detail page should also have the cover art Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:58:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 08:58:57 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-aUDzIYk8ar@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149888|0 |1 is obsolete| | --- Comment #38 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151192&action=edit Bug 32680: Add classes to template files This patch adds the classes to the template files so that the plugin hook can identify that cover images are required and where to inject them Test plan as per first commit Sponsored-by: PTFS Europe Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:59:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 08:59:00 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-8oJhOzQcgq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149889|0 |1 is obsolete| | --- Comment #39 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151193&action=edit Bug 32680: (QA follow-up) Fix opac call and remove second fetch Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 10:59:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 08:59:37 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-4JtA4bH4VT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #40 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Rebased to latest master version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:03:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 09:03:14 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-dMYKjZT3Hx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #46 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #45) > Created attachment 151190 [details] [review] > Bug 31212: Fix api/v1/items.t it should fix api/v1/biblios.t as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:07:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 09:07:42 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-CEcOrrRis8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:09:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 09:09:38 +0000 Subject: [Koha-bugs] [Bug 33710] Ignore howto files In-Reply-To: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33710-70-iQh2vbDmg9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33710 --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Tomás Cohen Arazi from comment #4) > Pushed to master for 23.05. > > Nice work everyone, thanks! ok but then we should merge the ktd merge request :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:48:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 09:48:03 +0000 Subject: [Koha-bugs] [Bug 33353] Add compatibility with Elasticsearch 8 In-Reply-To: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33353-70-5X5UBT2eHg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33353 --- Comment #16 from David Liddle <david.liddle at wycliff.de> --- (In reply to Victor Grousset/tuxayo from comment #15) Hi, Victor, and thank you for following up! > > 1. The version included by Koha appeared to be one that had reached end-of-life with the publisher > > ES 7 and OpenSearch 1.X (which isn't eol) has been supported since a year. > But we didn't update the systems requirements documentation (now it's > finally updated) due to not having the time to search for real work usage to > confidently claim support :-/ Our Koha installations represent a fraction of the systems that I support or manage in my role. I have to judiciously balance the time and effort I give to any single system. When considering the addition of a new software, I only do so when that software is actively developed by the publisher, is clearly supported on the target system, and has a well-documented installation/integration process. Since I didn't see that with Elasticsearch and Koha, I avoided it. > > 2. Even the supported version had been associated with significant data breaches > > You mean the log4j vulnerabilities? (latest 6.x patched them) or like bad > defaults? > Is your statement still valid for ES 7.x? No, I believe log4j was a separate issue. The data breaches were in the news a few years ago. Here's an example: https://www.techradar.com/news/what-is-elasticsearch-and-why-is-it-involved-in-so-many-data-leaks That article doesn't specify which CVEs were involved, but I wasn't about to create a new installation with an old, unsupported (read: perhaps unpatched) version that could _possibly_ make our system vulnerable to the exfiltration of patron and staff data. That would be irresponsible, especially since some portion of those people are under the protection of the EU GDPR. > > 3. There seemed to be a lack of clarity following the change in licensing and the open source world's response to it. > > Indeed! About that, to have more material to raise awareness about the > issue, do you happen to know more about the open source world's response to > it? Besides Debian, Fedora and the Open Source Initiative not considering > the SSPL license libre/open source? The details of whether or not ES truly can be considered 'open source' are not actually important to me. Observing a general lack of clarity, and not knowing the Koha development team's point of view on the matter, I couldn't be certain of the future of ES with regards to Koha. In my situation, that caused me to recommend against installing ES. > > - Our production server runs 22.05, BUT I can imagine a willingness to leap forward a bit if OpenSearch is backported to 22.11. > > You can do that right away with OpenSearch 1.x , 22.05 supported it on > launch. Sorry again for the delay in advertising it's support. That's why I was pleased to see this entry and the references to OpenSearch. Once I see an open declaration of support for its usage, and once I see some clear instructions for integrating it, I will be willing to install it on our test server. I have to approach the matter cautiously to protect the correct function of our systems – as well as my time and sanity. Thanks again for your response! I just want to let you all have an idea how one system administrator views the situation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:55:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 09:55:40 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31799-70-LuUWlSvtEx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #21 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 11:55:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 09:55:40 +0000 Subject: [Koha-bugs] [Bug 31789] REST API: CRUD endpoint for Items In-Reply-To: <bug-31789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31789-70-CCSLzsdcIK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31789 Bug 31789 depends on bug 31799, which changed state. Bug 31799 Summary: REST API: PUT endpoint for Items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:09:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:09:50 +0000 Subject: [Koha-bugs] [Bug 28315] PopupMARCFieldDoc is defined twice in addbiblio.tt In-Reply-To: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28315-70-TboAymH8qO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28315 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:09:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:09:52 +0000 Subject: [Koha-bugs] [Bug 28315] PopupMARCFieldDoc is defined twice in addbiblio.tt In-Reply-To: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28315-70-wG8wccgjgH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28315 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:09:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:09:53 +0000 Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32232-70-auEcrcwe6o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:09:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:09:55 +0000 Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32232-70-MjSgTIiwCk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 --- Comment #13 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:09:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:09:57 +0000 Subject: [Koha-bugs] [Bug 33093] (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase' In-Reply-To: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33093-70-xfLItNvter@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33093 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:09:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:09:59 +0000 Subject: [Koha-bugs] [Bug 33093] (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase' In-Reply-To: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33093-70-pR9Y4anNay@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33093 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:10:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:10:01 +0000 Subject: [Koha-bugs] [Bug 33600] Use template wrapper for breadcrumbs: Tools, part 7 In-Reply-To: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33600-70-YHfXCGSW4Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33600 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:10:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:10:02 +0000 Subject: [Koha-bugs] [Bug 33600] Use template wrapper for breadcrumbs: Tools, part 7 In-Reply-To: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33600-70-EafaUXOyRg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33600 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:10:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:10:04 +0000 Subject: [Koha-bugs] [Bug 33601] Use template wrapper for breadcrumbs: Tools, part 8 In-Reply-To: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33601-70-tlaXfQyiAD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33601 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:10:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:10:06 +0000 Subject: [Koha-bugs] [Bug 33601] Use template wrapper for breadcrumbs: Tools, part 8 In-Reply-To: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33601-70-AXm8EugrFg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33601 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:10:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:10:07 +0000 Subject: [Koha-bugs] [Bug 33643] Add page-section to 'scan index' page In-Reply-To: <bug-33643-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33643-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33643-70-8GOAwSmzfj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33643 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:10:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:10:09 +0000 Subject: [Koha-bugs] [Bug 33643] Add page-section to 'scan index' page In-Reply-To: <bug-33643-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33643-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33643-70-7xf1VWyySA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33643 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:10:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:10:11 +0000 Subject: [Koha-bugs] [Bug 33696] Doubled up home icon in budgets page In-Reply-To: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33696-70-mT0JdkeEb2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33696 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:10:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:10:12 +0000 Subject: [Koha-bugs] [Bug 33696] Doubled up home icon in budgets page In-Reply-To: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33696-70-2sn4uSm3VR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33696 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:14:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:14:14 +0000 Subject: [Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports In-Reply-To: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33356-70-MwZIGIXNgM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #14 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:15:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:15:35 +0000 Subject: [Koha-bugs] [Bug 33673] Global system preferences - change to just system preferences In-Reply-To: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33673-70-gpGSV6Y3qD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #8 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:36:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:36:27 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-EKlirZ9uUi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:36:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:36:29 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-xQQjswB9x5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 --- Comment #16 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:36:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:36:30 +0000 Subject: [Koha-bugs] [Bug 33513] Batch update from report module - no patrons loaded into view In-Reply-To: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33513-70-v1nSe6jfXv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33513 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:36:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:36:32 +0000 Subject: [Koha-bugs] [Bug 33513] Batch update from report module - no patrons loaded into view In-Reply-To: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33513-70-lboaDycrRf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33513 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:36:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:36:33 +0000 Subject: [Koha-bugs] [Bug 33586] Library and category are switched in table configuration for patron search results table settings In-Reply-To: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33586-70-5DC2oV99mv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33586 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:36:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:36:35 +0000 Subject: [Koha-bugs] [Bug 33586] Library and category are switched in table configuration for patron search results table settings In-Reply-To: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33586-70-HLzwCJbszh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33586 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:36:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:36:37 +0000 Subject: [Koha-bugs] [Bug 33591] Cannot merge bibliographic records In-Reply-To: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33591-70-yjseQJXHdP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:36:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:36:38 +0000 Subject: [Koha-bugs] [Bug 33591] Cannot merge bibliographic records In-Reply-To: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33591-70-t7jVEVqcUX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:36:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:36:40 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33611-70-kdFBgMPDIc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:36:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:36:41 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33611-70-3vGnzir30d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 --- Comment #14 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:36:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:36:43 +0000 Subject: [Koha-bugs] [Bug 33613] Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge In-Reply-To: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33613-70-kVcEwflzbh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:36:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:36:44 +0000 Subject: [Koha-bugs] [Bug 33613] Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge In-Reply-To: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33613-70-1tFvMJ84tE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:37:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:37:46 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-ixQ6OkQyIJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #31 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:39:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:39:38 +0000 Subject: [Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table In-Reply-To: <bug-25503-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25503-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25503-70-rQ1gcIUMWd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #26 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:42:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:42:56 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-uXBlbzNb1A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:42:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:42:58 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-NcHmHTi6Ag@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #72 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:44:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:44:14 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-ntbQJuRTNy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #27 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:45:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:45:08 +0000 Subject: [Koha-bugs] [Bug 33567] Remove fallback for Reference_NFL_statuses in C4/XSLT module In-Reply-To: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33567-70-bYrpapv7zu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33567 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |matt.blenkinsop at ptfs-europe | |.com Status|Pushed to master |RESOLVED --- Comment #10 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:46:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:46:12 +0000 Subject: [Koha-bugs] [Bug 31557] Add ability for holds queue builder to prioritize either matching a patron's home library to the item's home or holding library In-Reply-To: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31557-70-y3jiD8BDRk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #9 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 12:47:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 10:47:44 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-NDw8Pg27kQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #47 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement with additional_work_needed flag active - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:29:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 11:29:15 +0000 Subject: [Koha-bugs] [Bug 33053] Tables item_groups and recalls have a biblio_id column with a default of 0 In-Reply-To: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33053-70-YDFm04GDAE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33053 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:34:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 11:34:27 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-qhUTZZeqqz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:35:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 11:35:07 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-89WTzRKlNo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:42:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 11:42:31 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-g3HVBqrV1a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151190|0 |1 is obsolete| | --- Comment #48 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151194&action=edit Bug 31212: Adjust item spec for last_seen_date This bug changed the column to a date-time and the spec gets adjusted as well. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:43:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 11:43:01 +0000 Subject: [Koha-bugs] [Bug 33553] Unecessary GetCategories calls in template In-Reply-To: <bug-33553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33553-70-LoTBUYjREs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:49:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 11:49:53 +0000 Subject: [Koha-bugs] [Bug 33734] New: Using custom search filters breaks scandic characters in search term Message-ID: <bug-33734-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33734 Bug ID: 33734 Summary: Using custom search filters breaks scandic characters in search term Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: vilkunpostilaatikko at gmail.com QA Contact: testopia at bugs.koha-community.org To recreate: 1. Enable SavedSearchFilters syspref 2. Perform search with bib-level:("a") 3. Click "Save search as filter" and save 4. Perform search containing scandic character (åöä) 5. Use filter you just created => notice that scandic characters in search term displayed incorrectly e.g. ä turns to ä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:51:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 11:51:54 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-KvdSaxF5pt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:51:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 11:51:58 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-2UrgwxmZch@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #145 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:52:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 11:52:01 +0000 Subject: [Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable In-Reply-To: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33463-70-fvxu5FL4AF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:52:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 11:52:03 +0000 Subject: [Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable In-Reply-To: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33463-70-ujr1LzPGrE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:52:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 11:52:05 +0000 Subject: [Koha-bugs] [Bug 33658] Capitalization: **To Reproduce** In-Reply-To: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33658-70-RbcXBtPUz8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:52:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 11:52:07 +0000 Subject: [Koha-bugs] [Bug 33658] Capitalization: **To Reproduce** In-Reply-To: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33658-70-os8Mr8ZGeQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:52:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 11:52:09 +0000 Subject: [Koha-bugs] [Bug 33717] Typo in search_for_data_inconsistencies.pl In-Reply-To: <bug-33717-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33717-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33717-70-KZU7k3ROno@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33717 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:52:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 11:52:11 +0000 Subject: [Koha-bugs] [Bug 33717] Typo in search_for_data_inconsistencies.pl In-Reply-To: <bug-33717-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33717-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33717-70-G9VLGHceml@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33717 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:54:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 11:54:29 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-BcxyWZ8FhN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 13:54:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 11:54:32 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-WSP5TJu7c1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 --- Comment #41 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:10:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:10:03 +0000 Subject: [Koha-bugs] [Bug 33206] Bad title__sort made of multisubfield 245 In-Reply-To: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33206-70-9nOeVrOVAQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33206 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:10:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:10:05 +0000 Subject: [Koha-bugs] [Bug 33206] Bad title__sort made of multisubfield 245 In-Reply-To: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33206-70-IIzjxn3RXa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33206 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:10:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:10:07 +0000 Subject: [Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold In-Reply-To: <bug-33302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33302-70-jZZr7bUhpH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:10:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:10:09 +0000 Subject: [Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold In-Reply-To: <bug-33302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33302-70-Ske6ryo4KR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 --- Comment #11 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:10:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:10:11 +0000 Subject: [Koha-bugs] [Bug 33569] Order by relevance may not be visible In-Reply-To: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33569-70-ZmDs3RxrGJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33569 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:10:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:10:12 +0000 Subject: [Koha-bugs] [Bug 33569] Order by relevance may not be visible In-Reply-To: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33569-70-10AQmOIHB4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33569 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:10:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:10:13 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-P0V9usbXZZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:10:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:10:15 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-Kdy2RkPoak@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:10:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:10:17 +0000 Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled In-Reply-To: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33622-70-v6XlKw3brN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:10:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:10:18 +0000 Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled In-Reply-To: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33622-70-Ks2jEZgl9V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:10:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:10:20 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-LnFSkb0785@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:10:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:10:22 +0000 Subject: [Koha-bugs] [Bug 33653] Search for late orders can show received order lines In-Reply-To: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33653-70-MRLCEMEhsM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 --- Comment #18 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:13:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:13:30 +0000 Subject: [Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices In-Reply-To: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32548-70-Gp1azkJnUf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #16 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:13:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:13:45 +0000 Subject: [Koha-bugs] [Bug 33735] New: Misspelling in SMS provier Message-ID: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33735 Bug ID: 33735 Summary: Misspelling in SMS provier Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: anneli.osterman at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org In Koha/Database/Columns.pm line is misspelling in line 186. There is word "provier" and I think it should be "provider". The complete string is "SMS provier ID (internal)". I noticed it while translating into Finnish in translate.koha-community.org (https://translate.koha-community.org/fi/22.11/translate/fi-FI-messages.po#unit=27204788). I was translating 22.11 project but the same misspelling is in 23.05 also. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:20:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:20:30 +0000 Subject: [Koha-bugs] [Bug 30621] Author should be its own column on opac-readingrecord.tt In-Reply-To: <bug-30621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30621-70-08MxOtfRG2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30621 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #8 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:21:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:21:07 +0000 Subject: [Koha-bugs] [Bug 22375] Due dates should be formatted consistently In-Reply-To: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22375-70-Wi32DzB0w1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:21:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:21:09 +0000 Subject: [Koha-bugs] [Bug 22375] Due dates should be formatted consistently In-Reply-To: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22375-70-cXBXoqnVW3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:21:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:21:10 +0000 Subject: [Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin In-Reply-To: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25379-70-a1XHXHmxM9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:21:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:21:12 +0000 Subject: [Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin In-Reply-To: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25379-70-KZV7CmIKhJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 --- Comment #15 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:21:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:21:14 +0000 Subject: [Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice In-Reply-To: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32917-70-0R9tFgteiv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:21:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:21:16 +0000 Subject: [Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice In-Reply-To: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32917-70-aCSRrUf0RM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:21:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:21:17 +0000 Subject: [Koha-bugs] [Bug 33037] [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) In-Reply-To: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33037-70-UTYuTi1ehc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:21:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:21:19 +0000 Subject: [Koha-bugs] [Bug 33037] [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) In-Reply-To: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33037-70-5OtQDfqQ7g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:21:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:21:21 +0000 Subject: [Koha-bugs] [Bug 33253] 2FA - Form not excluded from autofill In-Reply-To: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33253-70-Y4drDtd6yC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33253 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:21:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:21:22 +0000 Subject: [Koha-bugs] [Bug 33253] 2FA - Form not excluded from autofill In-Reply-To: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33253-70-ZfXSUOSpY2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33253 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:21:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:21:24 +0000 Subject: [Koha-bugs] [Bug 33672] Item group features shows when placing holds if EnableItemGroupHolds is disabled In-Reply-To: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33672-70-sMHYFeYjnJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33672 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:21:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:21:25 +0000 Subject: [Koha-bugs] [Bug 33672] Item group features shows when placing holds if EnableItemGroupHolds is disabled In-Reply-To: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33672-70-YhGAT3C8gl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33672 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:27:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:27:17 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files and fix other related translation issues In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-8wBoIMdmMO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:27:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:27:18 +0000 Subject: [Koha-bugs] [Bug 26403] Move debit and credit types to YAML files and fix other related translation issues In-Reply-To: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26403-70-lIdCQanWve@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 --- Comment #34 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:27:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:27:20 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-EqUzosl7iT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:27:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:27:22 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-FdkvvYNxjD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 --- Comment #15 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:27:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:27:23 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-Jkf3bKsfX6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:27:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:27:25 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33671-70-dgcCUTz78I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 --- Comment #12 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:28:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:28:46 +0000 Subject: [Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates In-Reply-To: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31479-70-AtJQoA2aym@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:42:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:42:21 +0000 Subject: [Koha-bugs] [Bug 32627] Reprinting holds slips should not reset the expiration date In-Reply-To: <bug-32627-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32627-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32627-70-FG73G5vM5P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:42:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:42:22 +0000 Subject: [Koha-bugs] [Bug 32627] Reprinting holds slips should not reset the expiration date In-Reply-To: <bug-32627-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32627-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32627-70-YecKm3aPu5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:42:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:42:24 +0000 Subject: [Koha-bugs] [Bug 32937] Zebra: Ignore copyright symbol when searching In-Reply-To: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32937-70-IZ0iDVO0E1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32937 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:42:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:42:25 +0000 Subject: [Koha-bugs] [Bug 32937] Zebra: Ignore copyright symbol when searching In-Reply-To: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32937-70-u5z09FWpLB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32937 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:42:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:42:27 +0000 Subject: [Koha-bugs] [Bug 33403] Letters.t: Foreign key exception if you do not have a numberpattern with id=1 In-Reply-To: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33403-70-V3hscMR26i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33403 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:42:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:42:28 +0000 Subject: [Koha-bugs] [Bug 33403] Letters.t: Foreign key exception if you do not have a numberpattern with id=1 In-Reply-To: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33403-70-ruPnFtTpfx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33403 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:42:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:42:30 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-BXnilkPIoB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:42:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:42:32 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-8WhsUdjBjG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #31 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:42:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:42:33 +0000 Subject: [Koha-bugs] [Bug 33655] z39.50 search no longer shows search in progress In-Reply-To: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33655-70-ZqYh0cunaQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:42:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:42:35 +0000 Subject: [Koha-bugs] [Bug 33655] z39.50 search no longer shows search in progress In-Reply-To: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33655-70-bgDtIKx4Ni@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33655 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:42:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:42:37 +0000 Subject: [Koha-bugs] [Bug 33684] Able to save patron with empty mandatory date fields In-Reply-To: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33684-70-7wYqMFiJRn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33684 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:42:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:42:38 +0000 Subject: [Koha-bugs] [Bug 33684] Able to save patron with empty mandatory date fields In-Reply-To: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33684-70-NL1NaNyT3L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33684 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:57:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:57:33 +0000 Subject: [Koha-bugs] [Bug 32766] Update plugin unimarc_field_116.pl fields In-Reply-To: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32766-70-ES0YYSO112@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32766 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:57:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:57:35 +0000 Subject: [Koha-bugs] [Bug 32766] Update plugin unimarc_field_116.pl fields In-Reply-To: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32766-70-LCWDk0baXG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32766 --- Comment #13 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:57:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:57:36 +0000 Subject: [Koha-bugs] [Bug 32995] Koha agent string not sent for OverDrive fulfillment requests In-Reply-To: <bug-32995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32995-70-wSBUZeJ27X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32995 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:57:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:57:38 +0000 Subject: [Koha-bugs] [Bug 32995] Koha agent string not sent for OverDrive fulfillment requests In-Reply-To: <bug-32995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32995-70-ltoevf0d8T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32995 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:57:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:57:39 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff interface catalog details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-imBAqohJYE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:57:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:57:41 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff interface catalog details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-zD95ok6hnu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 --- Comment #25 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:57:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:57:43 +0000 Subject: [Koha-bugs] [Bug 33642] Typo: No log found . In-Reply-To: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33642-70-wYAdQWxxBz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33642 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:57:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:57:44 +0000 Subject: [Koha-bugs] [Bug 33642] Typo: No log found . In-Reply-To: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33642-70-ZDLKkzNb73@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33642 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:57:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:57:46 +0000 Subject: [Koha-bugs] [Bug 33677] Remove --verbose from koha-worker manpage In-Reply-To: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33677-70-EiWKXpLDJw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:57:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:57:47 +0000 Subject: [Koha-bugs] [Bug 33677] Remove --verbose from koha-worker manpage In-Reply-To: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33677-70-gALbHVPiKC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33677 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:57:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:57:49 +0000 Subject: [Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence) In-Reply-To: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33699-70-X86bGndcma@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 14:57:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 12:57:50 +0000 Subject: [Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence) In-Reply-To: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33699-70-o4dGfJUSPj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:00:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 13:00:29 +0000 Subject: [Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector In-Reply-To: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32993-70-XFYel81R8k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:00:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 13:00:30 +0000 Subject: [Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector In-Reply-To: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32993-70-XbfIiM3Bxu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:00:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 13:00:32 +0000 Subject: [Koha-bugs] [Bug 33320] Patron modification requests: options are squashed In-Reply-To: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33320-70-hAV9iWcFOI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33320 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:00:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 13:00:33 +0000 Subject: [Koha-bugs] [Bug 33320] Patron modification requests: options are squashed In-Reply-To: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33320-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33320-70-HL9QwryeII@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33320 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:03:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 13:03:13 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31735-70-CznxYSTQqL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #86 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:03:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 13:03:14 +0000 Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm In-Reply-To: <bug-32496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32496-70-CmUfqJOdsE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 Bug 32496 depends on bug 31735, which changed state. Bug 31735 Summary: Avoid re-fetching objects from database by passing them down instead of object ids https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:06:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 13:06:03 +0000 Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available In-Reply-To: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30687-70-1aQiEI7U7v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:06:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 13:06:05 +0000 Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available In-Reply-To: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30687-70-3edfmSaoal@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 --- Comment #33 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:06:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 13:06:07 +0000 Subject: [Koha-bugs] [Bug 32129] Use patron categorycode of most relevant recall when checking if item can be a waiting recall In-Reply-To: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32129-70-6yUIbOTQib@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:06:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 13:06:09 +0000 Subject: [Koha-bugs] [Bug 32129] Use patron categorycode of most relevant recall when checking if item can be a waiting recall In-Reply-To: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32129-70-oDZbGgQpy9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:06:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 13:06:11 +0000 Subject: [Koha-bugs] [Bug 33710] Ignore howto files In-Reply-To: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33710-70-UK5rcaAW56@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33710 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:06:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 13:06:12 +0000 Subject: [Koha-bugs] [Bug 33710] Ignore howto files In-Reply-To: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33710-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33710-70-in97FqJUOD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33710 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:08:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 13:08:49 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33335-70-P4aJVQBVxQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:08:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 13:08:51 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33335-70-lYXn3c7w05@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 --- Comment #16 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:28:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 13:28:02 +0000 Subject: [Koha-bugs] [Bug 28852] Extend options in SelfCheckoutByLogin syspref In-Reply-To: <bug-28852-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28852-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28852-70-WlvCXbtwSQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28852 Ed Veal <eveal at mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eveal at mckinneytexas.org --- Comment #3 from Ed Veal <eveal at mckinneytexas.org> --- This hasn't been very active so I am adding my .02 worth. I think this would be a great added feature. We have patrons that have been asking for this as a option. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:53:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 13:53:55 +0000 Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32092-70-AI3LhaUt2g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092 --- Comment #16 from David Gustafsson <glasklas at gmail.com> --- (In reply to Emily Lamancusa from comment #15) > It sounds like you're looking for something more rigorous, but I can provide > a little more info on the results I got when testing for sign-off, if that's > helpful: > > For my testing, I used the "add multiple copies" feature to create a bib > with 400 items split between 4 branches. I then timed the page loads for > placing a hold a few times on master and a few times with the patch (nothing > fancy, just literally used a stopwatch timer). I got page loads taking about > 18-23 seconds on master, and 9-11 seconds with the patch. > > As I said, not statistically rigorous, but definitely noticeable. That's great :) I didn't know about that feature, very useful for testing this and similar patches. I think testing the way you did is completely sufficient, but will also attach to flame graphs so can see what parts of the code is sped up. Basically, without the patch 44.3s is spent in Koha::CirculationRules::get_effective_rule, with the patch that time is reduced to 49.9ms (for this particular benchmark using about 1400 items). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:56:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 13:56:46 +0000 Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32092-70-zGgl277GOD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092 --- Comment #17 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151195&action=edit Before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:57:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 13:57:07 +0000 Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32092-70-mefyKCagz7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092 --- Comment #18 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151196&action=edit After -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 15:58:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 13:58:19 +0000 Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32092-70-glK0pXJuFZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:08:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:08:24 +0000 Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32092-70-RJTSct0tgD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092 --- Comment #19 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151197&action=edit Bug 32092: Fix uninitialized value in addition -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:09:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:09:49 +0000 Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32092-70-r1W1BHBkSG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092 --- Comment #20 from David Gustafsson <glasklas at gmail.com> --- @Emily Lamancusa thanks for spotting the warning the previous code did not produce, this should now be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:12:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:12:47 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-Xl6Y48AdzM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:12:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:12:49 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-sKxpBFyxOb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 --- Comment #32 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:12:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:12:51 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-CkZP3A3RDN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:12:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:12:53 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-LA76qNIa8S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #47 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:12:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:12:54 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33623-70-Zy0xcPORcD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:12:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:12:56 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33623-70-hMUhqZqapb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 --- Comment #16 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:15:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:15:44 +0000 Subject: [Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar In-Reply-To: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33064-70-GT9zF1D0Wg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:15:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:15:46 +0000 Subject: [Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar In-Reply-To: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33064-70-6jmOmuiiYt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:34:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:34:37 +0000 Subject: [Koha-bugs] [Bug 18398] CHECKIN/CHECKOUT/RENEWAL don't use AutoEmailPrimaryAddress but first valid e-mail In-Reply-To: <bug-18398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18398-70-Lat75AuY8N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #18 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:37:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:37:02 +0000 Subject: [Koha-bugs] [Bug 32164] Add link to MARC modification templates from batch record modification page In-Reply-To: <bug-32164-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32164-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32164-70-u8pj6Byxgx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32164 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Jacob O'Mara from comment #6) > Enhancement - not backporting to 22.11.x > > Nice work everyone! Jacob, it looks like you did backport this one? https://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=6ce18a8cdb62f279cbfb73bc4f6a46bfd8acc20d -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:37:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:37:45 +0000 Subject: [Koha-bugs] [Bug 33402] ERM Cypress tests needs to be moved to their own directory In-Reply-To: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33402-70-UTERLCSlEC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #15 from Lucas Gass <lucas at bywatersolutions.com> --- Not needed for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:37:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:37:46 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-AwHvwhW3B1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Bug 33408 depends on bug 33402, which changed state. Bug 33402 Summary: ERM Cypress tests needs to be moved to their own directory https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:40:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:40:07 +0000 Subject: [Koha-bugs] [Bug 33216] SIP fee paid messages explode if payment registers are enabled and the SIP account has no register In-Reply-To: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33216-70-B4rmlrmDr5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33216 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #17 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:42:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:42:12 +0000 Subject: [Koha-bugs] [Bug 33354] Error 400 Bad Request when submitting form in ERM In-Reply-To: <bug-33354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33354-70-tyKItyX3pv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33354 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:43:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:43:21 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-YvLl06btjH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #22 from Lucas Gass <lucas at bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:44:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:44:02 +0000 Subject: [Koha-bugs] [Bug 25631] Adding ability to alter the expiration date of the hold from the patron's account in staff In-Reply-To: <bug-25631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25631-70-w0oPvm4jZr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25631 Brenda <bowens at washoecounty.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bowens at washoecounty.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:44:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:44:48 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-NOYpsQzgIO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29422, 29450 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29422 [Bug 29422] Add additional match types to dataTables api wrapper https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 [Bug 29450] Allow flatPickr to instantiate in any order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:44:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:44:48 +0000 Subject: [Koha-bugs] [Bug 29422] Add additional match types to dataTables api wrapper In-Reply-To: <bug-29422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29422-70-nzI1g5Tilq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29422 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29002 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:44:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:44:48 +0000 Subject: [Koha-bugs] [Bug 29450] Allow flatPickr to instantiate in any order In-Reply-To: <bug-29450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29450-70-Js5Z4DpuWJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29002 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:46:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:46:23 +0000 Subject: [Koha-bugs] [Bug 33736] New: Add bookings to collect circulation report Message-ID: <bug-33736-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Bug ID: 33736 Summary: Add bookings to collect circulation report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 29002 As part of the bookings workflow, we should add a "bookings to collect" report along similar lines to the "holds to pull" system. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:46:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:46:23 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-t4bTrGHNu7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33736 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 [Bug 33736] Add bookings to collect circulation report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:47:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:47:38 +0000 Subject: [Koha-bugs] [Bug 33736] Add bookings to collect circulation report In-Reply-To: <bug-33736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33736-70-oPmRSVAOF1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:48:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:48:18 +0000 Subject: [Koha-bugs] [Bug 33737] New: Add bookings to patron details Message-ID: <bug-33737-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33737 Bug ID: 33737 Summary: Add bookings to patron details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com, testopia at bugs.koha-community.org Depends on: 29002 As part of the bookings workflow, we should add a "bookings" tab to the patron details page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:48:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:48:17 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-do7ct7G7Co@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #49 from Tomás Cohen Arazi <tomascohen at gmail.com> --- This development introduced a small regression in which the item gets stored twice during the tests in t/db_dependent/Koha/SearchEngine/Indexer.t because it used to store a date a couple times, with no real changes to the object (i.e. dt_from_string->ymd) and now it always differs (i.e. the attribute is marked as dirty). Options: 1. Adjust the tests to this situation and add FIXME and file a new bug to deal with the fact 2. Fix it here Ideas? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:48:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:48:18 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-GLvrAkeW7V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33737 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33737 [Bug 33737] Add bookings to patron details -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:48:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:48:23 +0000 Subject: [Koha-bugs] [Bug 33737] Add bookings to patron details In-Reply-To: <bug-33737-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33737-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33737-70-OKPguJ0Toz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33737 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:49:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:49:13 +0000 Subject: [Koha-bugs] [Bug 33738] New: Add bookings to the OPAC Message-ID: <bug-33738-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33738 Bug ID: 33738 Summary: Add bookings to the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com, testopia at bugs.koha-community.org Depends on: 29002 As part of the bookings workflow, we should add support for making bookings from the OPAC as a patron. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:49:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:49:13 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-lDspgQGo6U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33738 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33738 [Bug 33738] Add bookings to the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:49:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:49:18 +0000 Subject: [Koha-bugs] [Bug 33738] Add bookings to the OPAC In-Reply-To: <bug-33738-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33738-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33738-70-KdhTQx4Ji7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33738 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:52:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:52:31 +0000 Subject: [Koha-bugs] [Bug 33739] New: ModItemTransfer triggers indexing twice Message-ID: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33739 Bug ID: 33739 Summary: ModItemTransfer triggers indexing twice Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org With the changes from bug 31212, it is happening again, because the implicit call to `ModDateLastSeen` is not passed the skip_record_index flag. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:52:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:52:38 +0000 Subject: [Koha-bugs] [Bug 33739] ModItemTransfer triggers indexing twice In-Reply-To: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33739-70-q9kllWcCIY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33739 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31212 CC| |tomascohen at gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 [Bug 31212] Datelastseen should be a datetime -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:52:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:52:38 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-o72vHZOSGe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33739 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33739 [Bug 33739] ModItemTransfer triggers indexing twice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:52:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:52:50 +0000 Subject: [Koha-bugs] [Bug 33739] ModItemTransfer triggers indexing twice In-Reply-To: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33739-70-ae24ku77Ld@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33739 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate Severity|normal |blocker -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:53:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:53:25 +0000 Subject: [Koha-bugs] [Bug 33739] ModItemTransfer triggers indexing twice In-Reply-To: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33739-70-iVPcrcUsm8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33739 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |lucas at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Marking as blocker to get some attention. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 16:59:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 14:59:38 +0000 Subject: [Koha-bugs] [Bug 32021] Pages 'appear in position' field is not useful In-Reply-To: <bug-32021-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32021-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32021-70-OM05kYwt2K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32021 Marie-Luce Laflamme <marie-luce.laflamme at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/686 Status|Needs documenting |RESOLVED Documentation| |marie-luce laflamme contact| | CC| |marie-luce.laflamme at inlibro | |.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 17:06:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 15:06:22 +0000 Subject: [Koha-bugs] [Bug 33739] ModItemTransfer triggers indexing twice In-Reply-To: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33739-70-gCWsYCdH6n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33739 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 17:11:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 15:11:34 +0000 Subject: [Koha-bugs] [Bug 32648] Search.t is failing randomly In-Reply-To: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32648-70-tThW1qRJly@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Some debugging here, 245$a (and I think all other fields and so 952$*) had visibility=8 and so considered hidden. flush_memcached made the tests pass. We are missing a flush in another tests, but this also means that this test does not set properly the data it needs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 17:15:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 15:15:46 +0000 Subject: [Koha-bugs] [Bug 33739] ModItemTransfer triggers indexing twice In-Reply-To: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33739-70-Cm9dYjLyhV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33739 --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151198&action=edit Bug 33739: Only trigger indexing on last item modification at ModItemTransfer This patch makes ModItemTransfer trigger record indexing only on the last call (in $transfer->transit). And extra parameter is added to ->transit to effectively honour the ModItemTransfer parameter. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Koha/SearchEngine/Indexer.t => FAIL: Indexing is requested twice, should only be once 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! Indexing is requested only once! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 17:16:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 15:16:10 +0000 Subject: [Koha-bugs] [Bug 32648] Search.t is failing randomly In-Reply-To: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32648-70-NNa9ASHRsk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 17:17:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 15:17:48 +0000 Subject: [Koha-bugs] [Bug 32648] Search.t is failing randomly In-Reply-To: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32648-70-wa1GmLJ7OP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 17:17:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 15:17:50 +0000 Subject: [Koha-bugs] [Bug 32648] Search.t is failing randomly In-Reply-To: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32648-70-ZIh7jXy4Eh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 --- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151199&action=edit Bug 32648: Clear cache in Filter_MARC_ViewPolicy.t Search.t is failing if run after Filter_MARC_ViewPolicy.t because of a missing flush -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 17:18:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 15:18:06 +0000 Subject: [Koha-bugs] [Bug 32648] Search.t is failing is run after Filter_MARC_ViewPolicy.t In-Reply-To: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32648-70-9pnkYFWFsx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Search.t is failing |Search.t is failing is run |randomly |after | |Filter_MARC_ViewPolicy.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 17:18:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 15:18:13 +0000 Subject: [Koha-bugs] [Bug 32648] Search.t is failing if run after Filter_MARC_ViewPolicy.t In-Reply-To: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32648-70-I8CV1ptBYw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Search.t is failing is run |Search.t is failing if run |after |after |Filter_MARC_ViewPolicy.t |Filter_MARC_ViewPolicy.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 17:26:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 15:26:11 +0000 Subject: [Koha-bugs] [Bug 33739] ModItemTransfer triggers indexing twice In-Reply-To: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33739-70-2710YyJ9ON@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33739 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- I wanted to mention that bug 31212 highlighted an existing issue, not catched by the current tests before its inclussion, because of the DT truncation taking place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 17:56:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 15:56:11 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-NLKs6kaxEQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #146 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Can we get an updated test plan? It looks like for example that the system preference in step 3 got lost. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 18:26:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 16:26:15 +0000 Subject: [Koha-bugs] [Bug 33553] Unecessary GetCategories calls in template In-Reply-To: <bug-33553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33553-70-u90vAU6DJY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 18:26:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 16:26:18 +0000 Subject: [Koha-bugs] [Bug 33553] Unecessary GetCategories calls in template In-Reply-To: <bug-33553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33553-70-1tnK0E79VY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151200&action=edit Bug 33553: Remove unecessary GetCategories calls in templates This patch removes unnecessary references to AuthorisedValues.GetCategories: SET AuthorisedValuesCategories = AuthorisedValues.GetCategories The AuthorisedValuesCategories variable is not used. To test, apply the patch and go to Tools -> Patron clubs. - If necessary, create a club template with "Allow public enrollment" enabled. - Create a new club. The club creation process should work correctly. - Open a patron account for checkout and confirm that you can enroll the patron in the new club via the "Clubs" tab. - Log in to the OPAC and confirm that you can successfully enroll yourself in the new club via the "Clubs" tab on your patron summary page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 18:54:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 16:54:38 +0000 Subject: [Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages In-Reply-To: <bug-32730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32730-70-ZsOWtDKLhr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 --- Comment #21 from Michael Hafen <michael.hafen at washk12.org> --- Comment 8 on this bug mentioned the method name, but only that it needed to be snake case, which it now is. Same comment also mentioned the get_lists_with_patron() method and suggested putting it in Koha/Patron. I'm fine either way; as a Patron method it would need a Patron object, as a List method it would need the borrowernumber or patron object passed as a parameter. Either way works for me. There is a lot of apparent duplication in the patron lists tables, but there is a purpose. It's mostly for convenience. One table show the lists the patron is in, and needs the get_lists_with_patron() call. The second table shows the available lists the patron is not in; this is for the convenience of quickly adding the patron to one of those lists. So it calls get_lists() and then culls out the lists the patron is already in. If this convenience is deemed to system heavy to be feasible it can be pulled out. Or the second table could be reduced to a drop down with list names. This package isn't a Koha Object, as you noted, so there's a lot of DBIC. The specialized nature of some of those methods, in that they have to dig into the patronlistpatrons table, makes me think that's the best way to handle it either way. I don't think get_lists_with_patron() could be done efficiently without going to DBIC. I'd like to see some suggestions for a better method name, I think it's got a pretty good name myself. It's very descriptive. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 18:55:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 16:55:25 +0000 Subject: [Koha-bugs] [Bug 33673] Global system preferences - change to just system preferences In-Reply-To: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33673-70-6qquIQEYpQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/687 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 18:55:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 16:55:36 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-EpQN0MUBC9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/687 CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 18:55:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 16:55:36 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-B1CQr1C4BQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 Bug 33105 depends on bug 33104, which changed state. Bug 33104 Summary: Add vendor interfaces https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 18:55:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 16:55:37 +0000 Subject: [Koha-bugs] [Bug 33499] Improve styling of vendor detail page In-Reply-To: <bug-33499-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33499-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33499-70-FvVurd2FCs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 Bug 33499 depends on bug 33104, which changed state. Bug 33104 Summary: Add vendor interfaces https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 19:04:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 17:04:44 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-h7lZXgHEmf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #147 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Katrin Fischer from comment #146) > Can we get an updated test plan? It looks like for example that the system > preference in step 3 got lost. It is enabled, and no action required to use the feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 19:38:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 17:38:16 +0000 Subject: [Koha-bugs] [Bug 33735] Misspelling in SMS provier In-Reply-To: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33735-70-wD0Gs34hzP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33735 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|22.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 19:41:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 17:41:26 +0000 Subject: [Koha-bugs] [Bug 32729] Deleting an item removes the itemnumber from old_issues when it probably should not In-Reply-To: <bug-32729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32729-70-LOMR4yTnrq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32729 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 19:43:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 17:43:51 +0000 Subject: [Koha-bugs] [Bug 33735] Misspelling in SMS provier In-Reply-To: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33735-70-WA3SKchQVA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33735 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 19:43:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 17:43:54 +0000 Subject: [Koha-bugs] [Bug 33735] Misspelling in SMS provier In-Reply-To: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33735-70-Qpbh0M9UGa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33735 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151201&action=edit Bug 33735: Misspelling in SMS provier Correct spelling error: "provier" -> "provider" This change is a one-character edit, I think visual inspection of the patch is sufficient testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 19:53:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 17:53:31 +0000 Subject: [Koha-bugs] [Bug 33734] Using custom search filters breaks scandic characters in search term In-Reply-To: <bug-33734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33734-70-xyFzyGEMHn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33734 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Where is the malformed text? It looks correct to me when it's shown in the sidebar in both the OPAC and the staff interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:05:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:05:02 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30358-70-4az8yVFF1f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145308|0 |1 is obsolete| | Attachment #145317|0 |1 is obsolete| | Attachment #145318|0 |1 is obsolete| | --- Comment #74 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151202&action=edit Bug 30358: Strip leading/trailing whitespace characters from input fields when cataloguing This enhancement adds a system preference StripWhitespaceChars which, when enabled, will strip leading and trailing whitespace characters from all fields when cataloguing both bibliographic records and authority records. Whitespace characters that will be stripped are: - spaces - newlines - carriage returns - tabs To test: 1. Apply patch and install database updates 2. Go to Administration, system preferences, find the new StripWhitespaceChars preference. It should be "Don't strip" by default. Change it to "Strip". 3. Search for a biblio record and edit it. Put some leading or trailing whitespace characters in input fields and textarea fields and save. 4. Confirm these characters are removed when you save the record. 5. Repeat steps 3 and 4 for authority records. 6. Confirm tests pass t/db_dependent/Biblio/ModBiblioMarc.t Sponsored-by: Educational Services Australia SCIS Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:05:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:05:07 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30358-70-uyAUaUQ4hd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145309|0 |1 is obsolete| | --- Comment #75 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151203&action=edit Bug 30358: (follow-up) Also strip inner newlines This patch amends the StripWhitespaceChars system preference to also strip inner newlines (line breaks and carriage returns) when enabled. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:05:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:05:11 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30358-70-LrfUgSqQWC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145310|0 |1 is obsolete| | --- Comment #76 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151204&action=edit Bug 30358: (follow-up) Inner newlines should be replaced with a space Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:05:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:05:15 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30358-70-ENicmf9lNZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145311|0 |1 is obsolete| | --- Comment #77 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151205&action=edit Bug 30358: (follow-up) Fixing tests and including for inner newlines Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:05:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:05:19 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30358-70-MFddEpxIHc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145312|0 |1 is obsolete| | --- Comment #78 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151206&action=edit Bug 30358: (follow-up) Clarify syspref wording about fields affected Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:05:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:05:23 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30358-70-dzpYMl9Y7d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145313|0 |1 is obsolete| | --- Comment #79 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151207&action=edit Bug 30358: (follow-up) Consider field has multiple subfields of same key To test: 1) Click the clone subfield button to make multiple subfields with the same key, i.e. 500$a$a$a 2) Save the record and confirm that the fields contain the correct data after whitespaces are stripped. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:05:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:05:27 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30358-70-owO9EZmVxb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145314|0 |1 is obsolete| | --- Comment #80 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151208&action=edit Bug 30358: (follow-up) Put multiple subfields fix on auth side Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:05:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:05:31 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30358-70-elJOnyoklZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145315|0 |1 is obsolete| | --- Comment #81 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151210&action=edit Bug 30358: (follow-up) stripWhitespaceChars subroutine and tests To test: Confirm test plan above still works as expected and tests pass in t/Koha_MetadataRecord.t Sponsored-by: Catalyst IT Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:05:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:05:31 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-Tl3llUwnNW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151209&action=edit Bug 29002: Add bookings table to kohastructure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:05:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:05:35 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30358-70-BkWHKly3Yz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145316|0 |1 is obsolete| | --- Comment #82 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151212&action=edit Bug 30358: (follow-up) Fixing ModBiblioMarc.t tests Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:05:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:05:35 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-c94Aeey978@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151211&action=edit Bug 29002: DBIC Schema Build -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:05:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:05:38 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-q1QIsQi7Ry@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151213&action=edit Bug 29002: Add Booking objects and API classes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:05:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:05:39 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30358-70-9XQx0Sk5a0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 --- Comment #83 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151214&action=edit Bug 30358: (follow-up) Do not strip whitespace from control fields Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:05:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:05:42 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30358-70-pbD9hOHXwy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 --- Comment #84 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151215&action=edit Bug 30358: (follow-up) Simplify regex The regex does the following: 1. Replace newlines and carriage returns with a space 2. Replace leading and trailing whitespace with nothing (strip) Signed-off-by: Hammat Wele <hammat.wele at inlibro.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:05:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:05:42 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-ZSXlypqcgF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151216&action=edit Bug 29002: Add ability to book material from the staff client This patch introduces a new modal to the biblio details page to allow booking of materials. Test plan 1) Navigate to the details page of a biblio 2) Note the new 'Place booking' button in the toolbar 3) Click the new button and note the new modal dialogue 4) Enter part of a patron name or cardnumber and then select from the presented results 5) Select a start date and end date from the calender 6) Submit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:05:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:05:46 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-9wiHrZbm1z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151217&action=edit Bug 29002: Add bookings view This patch adds a new view to the biblio details page to display any bookings that may have been made. Test plan 1) Run through the steps from the previous patch 2) Note the appearance of a new 'Bookings' option in the left menu 3) Click the bookings option to load the new bookings page for the biblio 4) See that the booking from the previous patch appears on the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:05:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:05:49 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-rlb5XMfoF1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151218&action=edit Bug 29002: Add modal based booking cancellation This patch adds a modal based booking cancellation flow to the biblio bookings display tab page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:07:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:07:02 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-nAkVdamHY9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://gitlab.com/mrenvoiz |https://gitlab.com/mrenvoiz |e/Koha/-/tree/bug_29002_reb |e/Koha/-/tree/bug_29002 |ased | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:07:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:07:14 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-rmYXAmdyXC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151209|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:07:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:07:24 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-udBK9GDsCm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151213|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:07:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:07:33 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-rCOl38qRUX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151211|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:07:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:07:43 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-oxlpiv50hP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151216|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:07:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:07:53 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-V0FYnHffxN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151217|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:08:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:08:03 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-Nv7wOHIkz4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151218|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:09:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:09:30 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-CBjmc31fek@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Failed QA Keywords| |rel_23_05_candidate --- Comment #109 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Hi Julian et al, there's a failing test. Please fix against this branch: https://gitlab.com/thekesolutions/Koha/-/commits/qa_11844 # Failed test 'No tests run for subtest "set_additional_fields with marcfield_mode = "get""' # at /kohadevbox/koha/t/db_dependent/Koha/Object/Mixin/AdditionalFields.t line 54. Can't call method "value" on an undefined value at /kohadevbox/koha/t/db_dependent/Koha/Object/Mixin/AdditionalFields.t line 51. # Looks like your test exited with 255 just after 1. /kohadevbox/koha/t/db_dependent/Koha/Object/Mixin/AdditionalFields.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/2 subtests Test Summary Report ------------------- /kohadevbox/koha/t/db_dependent/Koha/Object/Mixin/AdditionalFields.t (Wstat: 65280 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 255 Parse errors: Bad plan. You planned 2 tests but ran 1. Files=1, Tests=1, 3 wallclock secs ( 0.03 usr 0.01 sys + 1.66 cusr 0.38 csys = 2.08 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:09:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:09:36 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30358-70-xVgw7vy6sG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 --- Comment #85 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- * Rebased, only conflict was in the .pref file * Fixed commit messages on the last 2 patches (QA script is happy now) * Ran the unit tests. All green * Verified controlfields are not affected, but other fields are cleaned up Back to Tomas :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:09:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:09:56 +0000 Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees In-Reply-To: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33411-70-MnCxWXowlM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Moving off the QA queue pending clarification of the test plan and holding off new test attempt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:15:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:15:39 +0000 Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference In-Reply-To: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29033-70-JxXNofgy87@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Keywords|rel_23_05_candidate |rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:17:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:17:06 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-jsxgdgszo1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:18:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:18:47 +0000 Subject: [Koha-bugs] [Bug 32546] Move ILL system preferences to their own tab in administration In-Reply-To: <bug-32546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32546-70-FeJDucPMyn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32546 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/685 Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:18:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:18:47 +0000 Subject: [Koha-bugs] [Bug 19822] Add system preferences for ILL Module In-Reply-To: <bug-19822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19822-70-QIsteBZvME@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Bug 19822 depends on bug 32546, which changed state. Bug 32546 Summary: Move ILL system preferences to their own tab in administration https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32546 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:23:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:23:25 +0000 Subject: [Koha-bugs] [Bug 23824] Add a 'Save and run' button to reports In-Reply-To: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23824-70-wrOl01iXm3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Marie-Luce Laflamme <marie-luce.laflamme at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |marie-luce.laflamme at inlibro | |.com Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:27:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:27:18 +0000 Subject: [Koha-bugs] [Bug 33353] Add compatibility with Elasticsearch 8 In-Reply-To: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33353-70-UoC5Ehl24o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33353 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |These changes to support release notes| |ElasticSearch 8.x and | |OpenSearch 2.x come with a | |loss of support for | |ElasticSearch 6.x. | |Existing | |instances will have to | |upgrade to either | |ElasticSearch 7.x or 8.x or | |OpenSearch 1.x or 2.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:41:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:41:27 +0000 Subject: [Koha-bugs] [Bug 30403] Update notforloan status also on check out In-Reply-To: <bug-30403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30403-70-7r03VsckLR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/687 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:41:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:41:27 +0000 Subject: [Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference In-Reply-To: <bug-33431-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33431-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33431-70-16i498AHDO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 Bug 33431 depends on bug 30403, which changed state. Bug 30403 Summary: Update notforloan status also on check out https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:42:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:42:59 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28328-70-uKTaxc3vVQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:43:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:43:01 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28328-70-sXM2ZGJO6n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:51:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:51:03 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: <bug-32775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32775-70-eiztsP3chw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #34 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:54:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:54:30 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: <bug-32775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32775-70-M0hhp6eDCa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #35 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Sorry, it was a very easy rebase. Fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:55:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:55:27 +0000 Subject: [Koha-bugs] [Bug 33740] New: Error 500, when editing authority TAG 000 (leader). Message-ID: <bug-33740-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33740 Bug ID: 33740 Summary: Error 500, when editing authority TAG 000 (leader). Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: pablo.joneslobos at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In the Authority module, when entering a new Personal Name Authority record, clicking on the field fills in the default value " nz a22 n 4500", correctly, but when trying to edit the field, the popup window says " An error has occurred! Error 500...". In general, it does not happen with other types of Authority, "Corporate Names", "Geographical Names", "Chronological Term", etc. Tests performed: -Empty browser cookies (Firefox), does not improve the situation. -In a private window, it works "better", open the editor in the pop-up window first, (Personal Authority Sheet). -In Normal window, it loads without error, after loading default fields like 003,005,008, and open to edit field 008. -When it opens, I can make the changes in the editor, and they are applied to the 000 field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:59:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:59:37 +0000 Subject: [Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification In-Reply-To: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33192-70-vVIQfI5ZYL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/687 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:59:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:59:42 +0000 Subject: [Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification In-Reply-To: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33192-70-4eNwm35yE3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:59:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:59:43 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-CWfePVpOea@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Bug 29046 depends on bug 33192, which changed state. Bug 33192 Summary: We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:59:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:59:43 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-3QpyCcSZiK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 Bug 33223 depends on bug 33192, which changed state. Bug 33192 Summary: We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 20:59:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 18:59:43 +0000 Subject: [Koha-bugs] [Bug 33191] AutoEmailPrimaryAddress options don't match labels in memberentry In-Reply-To: <bug-33191-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33191-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33191-70-UPRFG0NnE1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33191 Bug 33191 depends on bug 33192, which changed state. Bug 33192 Summary: We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 21:16:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 19:16:37 +0000 Subject: [Koha-bugs] [Bug 32305] Background worker doesn't check jobs receive from rabbitmq are in 'new' state In-Reply-To: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32305-70-hKAwvPKaHg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31245 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 21:16:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 19:16:37 +0000 Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if job not started In-Reply-To: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31245-70-EwRu5WNstT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32305 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 21:26:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 19:26:11 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12029-70-gHDm25kNUc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/687 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 21:26:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 19:26:12 +0000 Subject: [Koha-bugs] [Bug 33097] Is message for staff or OPAC on circulation.pl? In-Reply-To: <bug-33097-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33097-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33097-70-oKQakRp1nv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33097 Bug 33097 depends on bug 12029, which changed state. Bug 12029 Summary: Patrons should be able to delete their patron messages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 21:44:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 19:44:31 +0000 Subject: [Koha-bugs] [Bug 33093] (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase' In-Reply-To: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33093-70-NRwaDge0Lf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33093 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27546 CC| |fridolin.somers at biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546 [Bug 27546] Add option to search within results on the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 21:44:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 19:44:31 +0000 Subject: [Koha-bugs] [Bug 27546] Add option to search within results on the staff interface In-Reply-To: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27546-70-gWZ0wst8be@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33093 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33093 [Bug 33093] (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 21:49:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 19:49:16 +0000 Subject: [Koha-bugs] [Bug 33093] (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase' In-Reply-To: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33093-70-Jw2fXg2vCq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33093 --- Comment #9 from Fridolin Somers <fridolin.somers at biblibre.com> --- We should add a unit test to : t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 21:52:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 19:52:37 +0000 Subject: [Koha-bugs] [Bug 26628] Clubs permissions should grant access to Tools page In-Reply-To: <bug-26628-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26628-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26628-70-nazUdrSQm5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26628 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33595 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 21:55:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 19:55:38 +0000 Subject: [Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer In-Reply-To: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33300-70-EKkjp20oYV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 21:57:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 19:57:24 +0000 Subject: [Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer In-Reply-To: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33300-70-WcmWtRwl5n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|caroline.cyr-la-rose at inlibr | |o.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 22:25:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 20:25:34 +0000 Subject: [Koha-bugs] [Bug 33197] Terminology: rename GDPR_Policy system preference In-Reply-To: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33197-70-wZXT0jmoCR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33197 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/687 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 22:28:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 20:28:44 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-a3shMx8NgI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #32 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- It looks like only backend changes. Nothing to add/change in the manual. Closing, but feel free to include more details if this needs to be documented in the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 22:37:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 20:37:10 +0000 Subject: [Koha-bugs] [Bug 33739] ModItemTransfer triggers indexing twice In-Reply-To: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33739-70-flsj4d5ri5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33739 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 22:37:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 20:37:13 +0000 Subject: [Koha-bugs] [Bug 33739] ModItemTransfer triggers indexing twice In-Reply-To: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33739-70-dY8jXrdzIZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33739 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151198|0 |1 is obsolete| | --- Comment #4 from David Nind <david at davidnind.com> --- Created attachment 151219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151219&action=edit Bug 33739: Only trigger indexing on last item modification at ModItemTransfer This patch makes ModItemTransfer trigger record indexing only on the last call (in $transfer->transit). And extra parameter is added to ->transit to effectively honour the ModItemTransfer parameter. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Koha/SearchEngine/Indexer.t => FAIL: Indexing is requested twice, should only be once 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! Indexing is requested only once! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 22:49:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 20:49:18 +0000 Subject: [Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking In-Reply-To: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33557-70-9M57i7FhRK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/687 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 22:53:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 20:53:34 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-9InTzgslO0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #110 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I can fix the test. I think what happens is: If the field is a repeatable one, we are only looking at the first occurence. The test was using 999, but this field is already present in the created biblio, before another 999 is added with $Z. So when trying to set the field, no $Z was found and the additional_field was not set. This can be fixed by: 1) Using another field than 999 that doesn't already exist in the record. 2) appending Z to the already existing 999 3) Making sure that set_additional_fields loops through repeatable subfields, using the first subfield found. 1) is done easily, 3) is harder. I tried to determine how it worked before this patch set, as the 'set' functionality was already there: https://git.koha-community.org/Koha-community/Koha/src/commit/f891156f424a466aadb5ab85c445fcdbae4f3536/serials/subscription-add.pl#L370 my $value = $query->param('additional_field_' . $field->id); if ($field->marcfield) { my ($field, $subfield) = split /\$/, $field->marcfield; if ( $record and $field and $subfield ) { $value = $record->subfield( $field, $subfield ); } } It appears it never dealt 'cleverly' with repeated subfields. So we might move this to a separate bug and go with 1) for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 22:56:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 20:56:02 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-XA7SeuqW15@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #111 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151220&action=edit k -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 22:56:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 20:56:11 +0000 Subject: [Koha-bugs] [Bug 21330] Add XSLT for authority detail page in OPAC In-Reply-To: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21330-70-9h1XoHFGMD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #30 from Tomás Cohen Arazi <tomascohen at gmail.com> --- No XSLT? <.< -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 22:56:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 20:56:23 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-3DZIyX90KV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151220|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:01:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:01:34 +0000 Subject: [Koha-bugs] [Bug 33321] "Starts With" function when searching for patrons by address is broken In-Reply-To: <bug-33321-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33321-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33321-70-H8ECN74ghV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33321 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:01:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:01:47 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-SAjUSEiBvU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150537|0 |1 is obsolete| | Attachment #150538|0 |1 is obsolete| | Attachment #150539|0 |1 is obsolete| | Attachment #150540|0 |1 is obsolete| | Attachment #150541|0 |1 is obsolete| | Attachment #150542|0 |1 is obsolete| | Attachment #150543|0 |1 is obsolete| | Attachment #150544|0 |1 is obsolete| | Attachment #150545|0 |1 is obsolete| | Attachment #150546|0 |1 is obsolete| | Attachment #150547|0 |1 is obsolete| | Attachment #150548|0 |1 is obsolete| | --- Comment #112 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151221&action=edit Bug 11844: Use additional fields for order lines This patch allows to create additional fields for order lines. Once created, these fields can be filled during order line creation or modification. If additional field is linked to a MARC field, there are two possible scenario: - MARC field mode = get: The field cannot be modified and its value is retrieved from the bibliographic record (current behaviour) - MARC field mode = set: The field can be modified and its value is saved to the bibliographic record (new behaviour) If additional field is linked to an authorised value category, then authorised values are used. If not directly linked to an authorised value category, but linked to a MARC field, a search for an AV category is made on MARC default framework. This patch doesn't display additional fields value anywhere (except in order line creation/modification). Future patches will do that. Test plan: 1/ Go to Acquisitions home 2/ In the left menu, click on "Add order line fields" 3/ Click on "New field" button 4/ Give the field a name (unique), no AV category and no MARC field. 5/ Save. 6/ Create 5 other fields: a/ no AV category, a MARC field not linked to AV category, MARC field mode = get b/ no AV category, a MARC field not linked to AV category, MARC field mode = set c/ no AV category, a MARC field linked to AV category, MARC field mode = get d/ no AV category, a MARC field linked to AV category, MARC field mode = set e/ an AV category, no MARC field 7/ Create everything you need to be able to create order lines (supplier, basket, ...) 8/ Create an order line. At bottom of the page, you should see your additional fields, with authorised values dropdrown list for fields (c), (d) and (e). Fields (a) and (c) should be disabled. 9/ Fill these fields with some data and save order line 10/ check that data was correctly saved into biblio for fields (b) and (d), but not for (a) and (c) 11/ modify the same order line, check that values you've filled are correctly retrieved and that values for (a) and (c) were correctly retrieved from the bibliographic record 12/ modify all values, save, and check biblio once again Signed-off-by: Harold Dramer <harold.dramer at nyls.edu> Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:01:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:01:52 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-bJVavQoWhq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #113 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151222&action=edit Bug 11844: Take into account itemtypes, branches, and cn_source MARC subfields can be linked to "authorised values" that are not real authorised values: itemtypes, branches, and cn_source. Those were not taken into account. This patch fixes that Test plan: 1. Create additional fields for order lines with a MARC subfield that is linked to one of those "fake" authorised values list 2. Follow the same steps as in the main test plan Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:01:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:01:57 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-33TVSPNTlz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #114 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151223&action=edit Bug 11844: Fix QA issues (POD, TT filters, file exec flag) Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:02:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:02:01 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-DGG2c0i3i0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #115 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151224&action=edit Bug 11844: (follow-up) Fix terminology: biblio should be bibliographic record This is about the note displaying after an additional field that is linked to a MARC field. Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:02:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:02:06 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-1mGjfJ85P2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #116 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151225&action=edit Bug 11844: (follow-up) Add standard note to database update Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:02:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:02:10 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-4vxBwn4DEi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #117 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151226&action=edit Bug 11844: (follow-up) Add new option to acq navigation The navigation on the left in the acq module has links to the additional fields for baskets and invoices. This also adds a link for the new order lines feature. Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:02:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:02:14 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-QMUYWF5GlL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #118 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151227&action=edit Bug 11844: (follow-up) Add format hint to the additional fields admin page The MARC field needs to be added with a $ between field and subfield for things to work right. So this adds a hint about the expected format. Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:02:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:02:19 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-pDd8OmF1jC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #119 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151228&action=edit Bug 11844: Add tests Tests added for: - Koha::AdditionalField - TransferOrder - marcfield_mode Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:02:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:02:23 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-vkoR6YlXvY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #120 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151229&action=edit Bug 11844: DBIC schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:02:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:02:27 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-qrnPHzwoxH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #121 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151230&action=edit Bug 11844: (follow-up) Fix tests Moves the test from 999 which already exists in record to 998 as the feature only matches on the first field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:02:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:02:54 +0000 Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle In-Reply-To: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32121-70-KvFb4BaIhu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #15 from Lucas Gass <lucas at bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:02:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:02:55 +0000 Subject: [Koha-bugs] [Bug 32802] Bundle handling JS should be moved to an asset In-Reply-To: <bug-32802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32802-70-xMfLe0ums4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32802 Bug 32802 depends on bug 32121, which changed state. Bug 32121 Summary: Show an alert when adding a checked out item to an item bundle https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:02:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:02:55 +0000 Subject: [Koha-bugs] [Bug 33021] Show an alert when adding a reserved item to an item bundle In-Reply-To: <bug-33021-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33021-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33021-70-uhEOPhuGRv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Bug 33021 depends on bug 32121, which changed state. Bug 32121 Summary: Show an alert when adding a checked out item to an item bundle https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:02:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:02:55 +0000 Subject: [Koha-bugs] [Bug 33025] Show an alert when adding a lost item to an item bundle In-Reply-To: <bug-33025-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33025-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33025-70-LXkIQaq88I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33025 Bug 33025 depends on bug 32121, which changed state. Bug 32121 Summary: Show an alert when adding a checked out item to an item bundle https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:02:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:02:56 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-lm7UmkJWqY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Bug 33447 depends on bug 32121, which changed state. Bug 32121 Summary: Show an alert when adding a checked out item to an item bundle https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:03:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:03:16 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-cp3y3nsFiZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #22 from Lucas Gass <lucas at bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:03:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:03:17 +0000 Subject: [Koha-bugs] [Bug 33471] Improve performance of hold pickup location verification for next available holds In-Reply-To: <bug-33471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33471-70-DBQoZdPB7F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33471 Bug 33471 depends on bug 33447, which changed state. Bug 33447 Summary: Add caching to Biblio->pickup_locations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:04:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:04:57 +0000 Subject: [Koha-bugs] [Bug 33533] Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt In-Reply-To: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33533-70-po9yTOiYtO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply cleanly to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:05:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:05:27 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-753H92Z8fB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #19 from Lucas Gass <lucas at bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:08:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:08:54 +0000 Subject: [Koha-bugs] [Bug 30860] Add option for CanBookBeReserved to return all item values In-Reply-To: <bug-30860-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30860-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30860-70-NSZhU5DIdr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30860 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:09:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:09:09 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32642-70-nDKNAj3OBJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #30 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:10:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:10:32 +0000 Subject: [Koha-bugs] [Bug 26967] Patron autocomplete does not correctly format addresses In-Reply-To: <bug-26967-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26967-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26967-70-QwJz9UYNK0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26967 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply cleanly to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:12:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:12:23 +0000 Subject: [Koha-bugs] [Bug 31432] MARC21: Make 245 n and p subfields visible in frameworks by default In-Reply-To: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31432-70-9VTJikK3xC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31432 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:12:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:12:36 +0000 Subject: [Koha-bugs] [Bug 33741] New: Patron attribute IDs should match code Message-ID: <bug-33741-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33741 Bug ID: 33741 Summary: Patron attribute IDs should match code Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently patron attributes are given a random index number (in order of their creation). This is not helpful if you are using jQuery modifications and changing things around on occasion. If the attribute is given an ID that matches the attribute code, it would make it much easier to identify the attribute selector in jQuery, and you don't run the risk of it changing on you if you eliminate or add another attribute. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:16:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:16:47 +0000 Subject: [Koha-bugs] [Bug 21330] Add XSLT for authority detail page in OPAC In-Reply-To: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21330-70-wlXAmXxkTl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:16:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:16:49 +0000 Subject: [Koha-bugs] [Bug 21330] Add XSLT for authority detail page in OPAC In-Reply-To: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21330-70-0vsRlPMAAn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 --- Comment #31 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:16:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:16:51 +0000 Subject: [Koha-bugs] [Bug 28366] Add batch patron modification to patron search results In-Reply-To: <bug-28366-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28366-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28366-70-oKNEK0G5EF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28366 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:16:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:16:53 +0000 Subject: [Koha-bugs] [Bug 28366] Add batch patron modification to patron search results In-Reply-To: <bug-28366-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28366-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28366-70-O4Ai6JPgOc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28366 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:16:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:16:55 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30418-70-I9Lrp3lyht@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:16:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:16:57 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30418-70-4o8jAuSG0k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #34 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:16:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:16:59 +0000 Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be encrypted in the database In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30649-70-bnvl0wYZ8v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:17:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:17:01 +0000 Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be encrypted in the database In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30649-70-TDMB5vp9NZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649 --- Comment #33 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:17:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:17:03 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: <bug-32775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32775-70-aXOtVhFnI0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:17:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:17:05 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: <bug-32775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32775-70-CIAxdiJ3GB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 --- Comment #36 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:17:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:17:44 +0000 Subject: [Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer In-Reply-To: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33300-70-5YXi2yzc3F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #19 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply cleanly to 22.05.x, if needed please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:19:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:19:48 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-gnO5IRT9Tb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:20:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:20:05 +0000 Subject: [Koha-bugs] [Bug 33742] New: Add permission to circumvent HidePatronName syspref Message-ID: <bug-33742-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33742 Bug ID: 33742 Summary: Add permission to circumvent HidePatronName syspref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: andrewfh at dubcolib.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be helpful to have a permission with which an individual user could be set to see patron names throughout the staff interface regardless of the HidePatronName value. We have a small number of volunteers with very limited Koha access -- essentially just the "catalogue" permission. If we turned HidePatronName to Show, the volunteers would be able to see who a given item is checked out to. But we would like staff to be able to see that information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:20:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:20:19 +0000 Subject: [Koha-bugs] [Bug 33577] Buttons on reserve/request.pl are misaligned In-Reply-To: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33577-70-SlYAg3jHVe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33577 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- Not needed in 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:23:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:23:38 +0000 Subject: [Koha-bugs] [Bug 32752] Add new serial issue status: "Out for binding", "Bound", and "Circulating" In-Reply-To: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32752-70-LSSwZHfZUp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32752 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:23:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:23:40 +0000 Subject: [Koha-bugs] [Bug 32752] Add new serial issue status: "Out for binding", "Bound", and "Circulating" In-Reply-To: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32752-70-hbgOHOQ948@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32752 --- Comment #33 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:25:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:25:57 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: <bug-32775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32775-70-wQRCGTMBk9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 --- Comment #37 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Hello, Could we please request that this enhancement be backported to the 22.05.x branch. One of our clients sponsored this fix and would love to receive it before their upgrade to 23.05 later this year. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:28:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:28:57 +0000 Subject: [Koha-bugs] [Bug 33734] Using custom search filters breaks scandic characters in search term In-Reply-To: <bug-33734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33734-70-npu5acdNWF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33734 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am seeing the issue too. * Activate search filters * Search for the * Save as search filter * Search for ü * Limit to saved filter No results match your search for 'kw,wrdl: "ü"' with limit(s): 'and (the)'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:29:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:29:27 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-5WI9Fgm1ON@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | --- Comment #18 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:30:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:30:03 +0000 Subject: [Koha-bugs] [Bug 33549] Patron restriction types - Style missing for dialog messages In-Reply-To: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33549-70-Nsc44Jvsjz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- Not needed for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:32:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:32:53 +0000 Subject: [Koha-bugs] [Bug 33336] Use a dedicated column for plugin status in plugins table In-Reply-To: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33336-70-xObOK2cnis@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> --- Does not apply cleanly to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:37:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:37:15 +0000 Subject: [Koha-bugs] [Bug 33210] (Bug 31963 follow-up) No hold fee message on OPAC should be displayed when there is no fee In-Reply-To: <bug-33210-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33210-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33210-70-HUF6YBCu2B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33210 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31963 CC| |lucas at bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 [Bug 31963] Only show hold fee message on OPAC and charge hold fee if HoldFeeMode conditions are true as described in the system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:37:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:37:15 +0000 Subject: [Koha-bugs] [Bug 31963] Only show hold fee message on OPAC and charge hold fee if HoldFeeMode conditions are true as described in the system preference In-Reply-To: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31963-70-8NKc8bcxoV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33210 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33210 [Bug 33210] (Bug 31963 follow-up) No hold fee message on OPAC should be displayed when there is no fee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:38:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:38:14 +0000 Subject: [Koha-bugs] [Bug 33210] (Bug 31963 follow-up) No hold fee message on OPAC should be displayed when there is no fee In-Reply-To: <bug-33210-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33210-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33210-70-yXwGxAr2VI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33210 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> --- I accidentally pushed this for 22.05 and then realized it is dependent on 31963 so I reverted. Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:38:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:38:59 +0000 Subject: [Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface In-Reply-To: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32677-70-8MolH5Vh16@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677 --- Comment #6 from Victor Zuniga <vctrzuniga at gmail.com> --- Hi Katrin, Thanks for the update. I tried the command using the instance name at the end and got the following: vzuniga at SJDS:/etc/koha/sites$ sudo koha-translate --remove es-ES catalog [sudo] password for vzuniga: Error: the selected language is not installed. Then, doubled check the list and noticed the Spanish package is listed on the system (es-ES): vzuniga at SJDS:/etc/koha/sites$ sudo koha-translate --list -a catalog am-Ethi ar-Arab as-IN az-AZ be-BY bg-Cyrl bn-IN ca-ES cs-CZ cy-GB da-DK de-CH de-DE dz el-GR en-GB en-NZ eo es-ES et eu fa-Arab fi-FI fo-FO fr-CA fr-FR ga gd gl he-Hebr hi hr-HR hu-HU hy-Armn hyw-Armn ia id-ID iq-CA is-IS it-IT iu-CA ja-Jpan-JP ka km-KH kn-Knda ko-Kore-KP ku-Arab lo-Laoo lv mi-NZ ml mon mr ms-MY my nb-NO ne-NE nl-BE nl-NL nn-NO oc pbr pl-PL prs pt-BR pt-PT ro-RO ru-RU rw-RW sd-PK si sk-SK sl-SI sq-AL sr-Cyrl sv-SE sw-KE ta-LK ta te tet th-TH tk tl-PH tr-TR tvl uk-UA ur-Arab uz vi-VN zh-Hans-CN zh-Hant-TW Then tried to install it again: vzuniga at SJDS:/etc/koha/sites$ sudo koha-translate --install es-ES catalog Error: the selected language is not currently available. Is there a way to grab the files manually and upload them to the server? I even upgraded to the latest version (Koha 22.11.05) before attempting the commands listed below. No success :/ Thanks, Victor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:39:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:39:15 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-aGeQybY9Iq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #22 from Lucas Gass <lucas at bywatersolutions.com> --- Enhancement will not be backported to the 22.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:43:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:43:32 +0000 Subject: [Koha-bugs] [Bug 33735] Misspelling in SMS provier In-Reply-To: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33735-70-5cAH79fdqN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33735 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:43:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:43:34 +0000 Subject: [Koha-bugs] [Bug 33735] Misspelling in SMS provier In-Reply-To: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33735-70-8MDWiiFzeh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33735 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151201|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 151231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151231&action=edit Bug 33735: Misspelling in SMS provier Correct spelling error: "provier" -> "provider" This change is a one-character edit, I think visual inspection of the patch is sufficient testing. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:44:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:44:43 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-Q7uRTHPjAs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | CC| |lucas at bywatersolutions.com --- Comment #24 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:45:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:45:05 +0000 Subject: [Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface In-Reply-To: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32677-70-qecTgmOkff@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I have just tried installing es-ES on my dev system and it worked fine. It also looks ok on our 22.11.05 installation. Only thing I noticed is that I installed from a different directory... but I am not sure if that should make any difference. Do you have es-ES files in misc/translator/po ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:47:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:47:45 +0000 Subject: [Koha-bugs] [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link In-Reply-To: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33560-70-tpvZj3Eear@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- Not needed in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:47:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:47:45 +0000 Subject: [Koha-bugs] [Bug 33559] Use template wrapper for breadcrumbs: Serials part 2 In-Reply-To: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33559-70-ymwsoQN4lu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Bug 33559 depends on bug 33560, which changed state. Bug 33560 Summary: Batch edit link broken if subscriptions are selected using "select all" link https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:52:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:52:26 +0000 Subject: [Koha-bugs] [Bug 33603] misc/maintenance/search_for_data_inconsistencies.pl fails if biblio.biblionumber on control field In-Reply-To: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33603-70-YkT7rm24a3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:54:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:54:15 +0000 Subject: [Koha-bugs] [Bug 33629] allow pbuilder to use network via build-git-snapshot In-Reply-To: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33629-70-cM5vc8NkXT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33629 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:55:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:55:07 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-W8mWy20Ww2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #20 from Lucas Gass <lucas at bywatersolutions.com> --- Not needed for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 15 23:56:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 21:56:56 +0000 Subject: [Koha-bugs] [Bug 33156] Batch patron modification tool is missing search bar and other attributes In-Reply-To: <bug-33156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33156-70-9b5h71rIuS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:00:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:00:46 +0000 Subject: [Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface In-Reply-To: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32677-70-hxfcpK61Rg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677 --- Comment #8 from Victor Zuniga <vctrzuniga at gmail.com> --- Hi Katrin, I can see a few files for es-ES: vzuniga at SJDS:/usr/share/koha/misc/translator/po$ ls es-ES-marc-MARC21.po es-ES-installer.po es-ES-installer-UNIMARC.po es-ES-marc-MARC21.po es-ES-marc-UNIMARC.po es-ES-messages-js.po es-ES-messages.po es-ES-opac-bootstrap.po es-ES-pref.po es-ES-staff-prog.po Victor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:02:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:02:42 +0000 Subject: [Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface In-Reply-To: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32677-70-keofDsphpS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am running out of ideas, it would be best to bring this up on the mailing list or in the IRC channel next. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:08:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:08:40 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals creating issue with renewal history view In-Reply-To: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33504-70-wumS8m0qRW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | --- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:09:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:09:16 +0000 Subject: [Koha-bugs] [Bug 32782] Add UNIMARC support to the ERM module In-Reply-To: <bug-32782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32782-70-bmKMBaOsHx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32782 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #17 from Lucas Gass <lucas at bywatersolutions.com> --- NOt needed for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:09:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:09:24 +0000 Subject: [Koha-bugs] [Bug 32782] Add UNIMARC support to the ERM module In-Reply-To: <bug-32782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32782-70-nasXaCHlVy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32782 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:10:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:10:07 +0000 Subject: [Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface In-Reply-To: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32677-70-Zv9qeN39gV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677 --- Comment #10 from Victor Zuniga <vctrzuniga at gmail.com> --- (In reply to Katrin Fischer from comment #9) > I am running out of ideas, it would be best to bring this up on the mailing > list or in the IRC channel next. I hear you! Feeling the same. I'll reach out to the mailing list. Just puzzled by this one. Everything else is working fine. Thanks again for all your help, Victor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:17:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:17:21 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32250-70-GRjjR3NfNq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #25 from Lucas Gass <lucas at bywatersolutions.com> --- This patchset does not apply cleanly to 22.05.x, no backport unless rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:18:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:18:34 +0000 Subject: [Koha-bugs] [Bug 33328] x-marc-schema should be renamed x-record-schema In-Reply-To: <bug-33328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33328-70-afHhJywDTL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33328 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:18:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:18:57 +0000 Subject: [Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages In-Reply-To: <bug-32730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32730-70-M7TG67m8RG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:19:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:19:45 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-kW2ACXLeW5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #18 from Lucas Gass <lucas at bywatersolutions.com> --- I cannot recreate this in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:22:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:22:00 +0000 Subject: [Koha-bugs] [Bug 19249] Date picker broken in "Quick add new patron" form In-Reply-To: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19249-70-3aJPPwAv8o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #18 from Lucas Gass <lucas at bywatersolutions.com> --- Does not apply cleanly to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:23:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:23:40 +0000 Subject: [Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section In-Reply-To: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33634-70-eD7POimYi7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:25:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:25:33 +0000 Subject: [Koha-bugs] [Bug 33597] Get rid of few SameSite warnings In-Reply-To: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33597-70-v4peFvB0fm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | --- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:27:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:27:37 +0000 Subject: [Koha-bugs] [Bug 33506] Series has wrong index name on scan index page and search option selection is not retained In-Reply-To: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33506-70-ErmpDMGVKt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:32:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:32:21 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-PF1BgbaKxC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #16 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:33:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:33:45 +0000 Subject: [Koha-bugs] [Bug 33588] Inventory item list is missing page-section class In-Reply-To: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33588-70-M83QTwEQZn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33588 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:36:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:36:53 +0000 Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load every line initially In-Reply-To: <bug-32253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32253-70-kOGs4mRBiO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:38:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:38:31 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-JmwG67Kb1M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #105 from Lucas Gass <lucas at bywatersolutions.com> --- Not needed for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:38:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:38:31 +0000 Subject: [Koha-bugs] [Bug 32607] Add import sources CRUD In-Reply-To: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32607-70-x2dQDw0yFC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Bug 32607 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:38:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:38:32 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-RWz96MdrMo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Bug 33483 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:38:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:38:32 +0000 Subject: [Koha-bugs] [Bug 33705] Tables have configure button even if they are not configurable In-Reply-To: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33705-70-3cXPpsYMHz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Bug 33705 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:38:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:38:33 +0000 Subject: [Koha-bugs] [Bug 33529] Increase flexibility of action buttons in Vue Kohatables In-Reply-To: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33529-70-NxohjqQS6R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33529 Bug 33529 depends on bug 33066, which changed state. Bug 33066 Summary: We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:40:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:40:44 +0000 Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to server side filtering In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-mvW9rDxMwR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #18 from Lucas Gass <lucas at bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:40:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:40:45 +0000 Subject: [Koha-bugs] [Bug 19774] Adapt existing endpoints to new naming guidelines OMNIBUS In-Reply-To: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19774-70-aEly4PSoxv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774 Bug 19774 depends on bug 22440, which changed state. Bug 22440 Summary: Improve ILL page performance by moving to server side filtering https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:40:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:40:45 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-M5Zlwbncsn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Bug 30719 depends on bug 22440, which changed state. Bug 22440 Summary: Improve ILL page performance by moving to server side filtering https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:40:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:40:45 +0000 Subject: [Koha-bugs] [Bug 33544] Squash some ILL fields to alleviate request table overflow In-Reply-To: <bug-33544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33544-70-ZSkR1PjSin@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Bug 33544 depends on bug 22440, which changed state. Bug 22440 Summary: Improve ILL page performance by moving to server side filtering https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:40:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:40:46 +0000 Subject: [Koha-bugs] [Bug 33685] We should display both backend and local status for ILL loan requests In-Reply-To: <bug-33685-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33685-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33685-70-lbJF67EHAK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33685 Bug 33685 depends on bug 22440, which changed state. Bug 22440 Summary: Improve ILL page performance by moving to server side filtering https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:40:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:40:46 +0000 Subject: [Koha-bugs] [Bug 33545] Adding faceting to API result sets In-Reply-To: <bug-33545-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33545-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33545-70-rHSDYrbhdC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33545 Bug 33545 depends on bug 22440, which changed state. Bug 22440 Summary: Improve ILL page performance by moving to server side filtering https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:49:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:49:39 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-uJJwDtqt1u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #34 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:50:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:50:59 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-0VauGqsDh3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #64 from Lucas Gass <lucas at bywatersolutions.com> --- Merge conflicts with 22.05.x, please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 00:52:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 May 2023 22:52:35 +0000 Subject: [Koha-bugs] [Bug 32921] SelfCheckTimeout doesn't logout if SelfCheckReceiptPrompt modal is open In-Reply-To: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32921-70-eleJUarZE1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 02:30:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 00:30:29 +0000 Subject: [Koha-bugs] [Bug 33705] Tables have configure button even if they are not configurable In-Reply-To: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33705-70-8geNTvF2WZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151000|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Created attachment 151232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151232&action=edit Bug 33705: (bug 33066 follow-up) Fix 'configure' button for kohaTable The 'configure' button is displayed for any tables, even those that cannot be configured. This is a regression caused by commit 765fd1ced3b9efc4ff6fb71e2fee1a7a227d1cae Bug 33066: Introduce a KohaTable Vue component It's adding a default value for table_settings, but then later we are testing if table_settings is true: 699 let table_settings = params.table_settings || {}; ... 798 if ( table_settings && CAN_user_parameters_manage_column_config ) { This patch is reverting the default value, so the test will be corrected. Test plan: 1. Go to Tools > Quote editor 2. Click "Configure" => Without this patch you are brought to the column settings page, but the quote editor table is not there => With this patch the button is not present 3. Go to the cities page (admin/cities.pl) 4. Click "Configure" => You are brought to the column settings page Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 03:27:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 01:27:36 +0000 Subject: [Koha-bugs] [Bug 33705] Tables have configure button even if they are not configurable In-Reply-To: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33705-70-nROUzT8KnH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor at tuxayo.net --- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 03:38:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 01:38:05 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-2yInsUrhBY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 03:38:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 01:38:08 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-axLuX004RY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151058|0 |1 is obsolete| | --- Comment #47 from David Nind <david at davidnind.com> --- Created attachment 151233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151233&action=edit Bug 29822: Update 'DefaultPatronSearchFields' to a select list This patch updates the `DefaultPatronSearchFields` preference from freetext expecting a comma delimited list of borrower fields to a multi-select with a sensible list of fields available. I opted to not use the Modal approach with all borrower fields listed as I felt it made more sense to only expose a more limited subset of the fields available to us. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 03:38:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 01:38:12 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-mm7lxuQR0y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151059|0 |1 is obsolete| | --- Comment #48 from David Nind <david at davidnind.com> --- Created attachment 151234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151234&action=edit Bug 29822: Use the modal As requested by Katrin.. switch to the modal and expose all fields from the borrowers database table Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 03:38:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 01:38:15 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-SIOuLOO79k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151060|0 |1 is obsolete| | --- Comment #49 from David Nind <david at davidnind.com> --- Created attachment 151235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151235&action=edit Bug 29822: Update code to reference by pipe Moving to modalselect also has the effect of moving from comma delimited to pipe delimitation for the preference contents tmp Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 03:38:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 01:38:18 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-mr3cTZa8LL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151061|0 |1 is obsolete| | --- Comment #50 from David Nind <david at davidnind.com> --- Created attachment 151236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151236&action=edit Bug 29822: Database and Preference description updates Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 03:38:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 01:38:21 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-LYDYSjoxQ9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151062|0 |1 is obsolete| | --- Comment #51 from David Nind <david at davidnind.com> --- Created attachment 151237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151237&action=edit Bug 29822: Update unit tests Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 03:38:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 01:38:24 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-3SX36dfuCY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151064|0 |1 is obsolete| | --- Comment #52 from David Nind <david at davidnind.com> --- Created attachment 151238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151238&action=edit Bug 29822: Escape backslash on split + effectively replace 'standard', don't display it. + avoid mixing | and , Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 03:42:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 01:42:38 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-Q5T27ajdOz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement changes |This enhancement changes release notes|the |the |DefaultPatronSearchFields |DefaultPatronSearchFields |system preference from an |system preference from an |input field where field |input field where field |values separated by a comma |values separated by a comma |are entered, to a dropdown |are entered, to a modal |list with a limited subset |window listing all patron |of the available patron |fields (non-selectable |fields. |fields are greyed out). | | |This makes it much |This makes it much easier |easier to set the standard |to set the standard fields |fields for patron search, |for patron search, and |and helps avoid breaking |helps avoid breaking the |the patron search when |patron search when |incorrect field values are |incorrect field values are |entered. |entered. | | |NOTE: There is a | |change in behavour for this | |system preference, as only | |a limited subset of the | |available patron fields are | |now selectable for the | |standard patron search. | --- Comment #53 from David Nind <david at davidnind.com> --- Testing notes using KTD: 1. Check system preference DefaultPatronSearchFields and note that it is defined by entering a comma separated list. 2. Go to the patrons module and view the HTML source for the page: . search the source for 'standard' - this should have two results . note that the option value for the Standard input field are "firstname,middle_name,surname,othernames,cardnumber,userid" 3. Break the patron search: . for the DefaultPatronSearchFields system preference, add a field that doesn't exist, for example: someunknownfield . for patron search, enter any value in the search field and make sure standard is selected for the search field drop down list . you get a pop-up error message: "Something went wrong when loading the table. 500: Internal Server Error." 4. Apply the patch. 5. Update the database: databaseupdate 6. Restart everything: flushmemcached, restart_all 7. Reload or search again for the DefaultPatronSearchFields system preference. 8. Note that this is now a modal window with all the patron fields that are selectable shown (greyed out items are not selectable), rather than needing to enter a comma separated list. 9. Select some fields, such as 'First name', 'Surname', 'Primary email'. 10. Repeat step 2 - the standard input field now includes the fields you selected. 11. Make sure some patrons have a primary email address, such as firstname at gmail.com 12. Do a standard search for gmail.com ==> the results should include all the patrons you added a gmail address to 13. Do a specific search on the 'Primary email' field ==> the search results should be the same as for step 12 14. Run the tests, these should pass (note - KTD needs to be started with selenium: ktd --selenium up): . prove t/db_dependent/selenium/patrons_search.t BONUS: Perform the same search using the header search bar and the search options drop down (note: you need to change the 'Search type' from 'Starts with' to 'Contains'). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 04:05:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 02:05:37 +0000 Subject: [Koha-bugs] [Bug 32648] Search.t is failing if run after Filter_MARC_ViewPolicy.t In-Reply-To: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32648-70-2CvsuqZrhL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151199|0 |1 is obsolete| | --- Comment #13 from David Nind <david at davidnind.com> --- Created attachment 151239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151239&action=edit Bug 32648: Clear cache in Filter_MARC_ViewPolicy.t Search.t is failing if run after Filter_MARC_ViewPolicy.t because of a missing flush Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 04:09:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 02:09:05 +0000 Subject: [Koha-bugs] [Bug 31128] Add effective_not_for_loan_status to API item objects In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31128-70-j4jQmn3rln@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #16 from David Cook <dcook at prosentient.com.au> --- In 22.11 getting 500 errors with the message {"message":"Expected integer - got null.","path":"\/body\/0\/effective_not_for_loan_status"} Going to keep exploring... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 04:11:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 02:11:09 +0000 Subject: [Koha-bugs] [Bug 31128] Add effective_not_for_loan_status to API item objects In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31128-70-WaBdU0nvoE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 --- Comment #17 from David Cook <dcook at prosentient.com.au> --- (In reply to David Cook from comment #16) > In 22.11 getting 500 errors with the message > {"message":"Expected integer - got > null.","path":"\/body\/0\/effective_not_for_loan_status"} > > Going to keep exploring... Specfically when I'm going to /api/v1/public/biblios/16/items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 04:11:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 02:11:26 +0000 Subject: [Koha-bugs] [Bug 32648] Search.t is failing if run after Filter_MARC_ViewPolicy.t In-Reply-To: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32648-70-JyOxdmIC6A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |david at davidnind.com --- Comment #14 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. The main patch for this bug is already in master. 2. Before applying the additional patch: - run prove t/db_dependent/Filter_MARC_ViewPolicy.t then prove t/Search.t => t/Search.t tests will fail - run prove t/db_dependent/Filter_MARC_ViewPolicy.t then flush_memcached and then prove t/Search.t => tests pass 3. Apply the second patch and then run prove t/db_dependent/Filter_MARC_ViewPolicy.t then prove t/Search.t => tests will now pass without the flush_memcached between running the tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 04:18:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 02:18:55 +0000 Subject: [Koha-bugs] [Bug 31128] Add effective_not_for_loan_status to API item objects In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31128-70-StxeJoEjfB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 --- Comment #18 from David Cook <dcook at prosentient.com.au> --- Working fine in koha-testing-docker though so maybe something else is going on... :| -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 04:21:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 02:21:17 +0000 Subject: [Koha-bugs] [Bug 31128] Add effective_not_for_loan_status to API item objects In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31128-70-3Wyu7w79vM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 --- Comment #19 from David Cook <dcook at prosentient.com.au> --- Yep never mind me. Looks like something broken in an instance rather than the Koha version... probably a red herring error message... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 04:25:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 02:25:24 +0000 Subject: [Koha-bugs] [Bug 31128] Add effective_not_for_loan_status to API item objects In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31128-70-CqPhmJnwrg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 --- Comment #20 from David Cook <dcook at prosentient.com.au> --- (In reply to David Cook from comment #19) > Yep never mind me. Looks like something broken in an instance rather than > the Koha version... probably a red herring error message... Looks like a number of item types had NULL instead of 0 in the itemtypes table. Ahhhhhhhh. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 04:32:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 02:32:31 +0000 Subject: [Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers In-Reply-To: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16652-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16652-70-cRMF9cbLBc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30962 CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 04:32:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 02:32:31 +0000 Subject: [Koha-bugs] [Bug 30962] REST API: Add endpoint /auth/password/validation In-Reply-To: <bug-30962-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30962-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30962-70-q5ZO4xzbZo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16652 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 04:33:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 02:33:45 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: <bug-17712-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17712-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17712-70-ndIkrF9hSp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 04:38:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 02:38:20 +0000 Subject: [Koha-bugs] [Bug 32419] Show availability in list view in staff interface In-Reply-To: <bug-32419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32419-70-5RkPBulFdV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32419 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook <dcook at prosentient.com.au> --- I think once we've got more APIs for this it'll be easier to make changes like this -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 16 04:59:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 02:59:08 +0000 Subject: [Koha-bugs] [Bug 33733] Move t/XSLT.t to db_dependent In-Reply-To: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33733-70-rIe6ioSYPF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 04:59:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 02:59:11 +0000 Subject: [Koha-bugs] [Bug 33733] Move t/XSLT.t to db_dependent In-Reply-To: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33733-70-XVyMI2Lu3k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151185|0 |1 is obsolete| | --- Comment #4 from David Nind <david at davidnind.com> --- Created attachment 151240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151240&action=edit Bug 33733: Remove need for Test::DBIx::Class Test plan: Run t/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 04:59:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 02:59:13 +0000 Subject: [Koha-bugs] [Bug 33733] Move t/XSLT.t to db_dependent In-Reply-To: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33733-70-gnulQmMRqj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151186|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Created attachment 151241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151241&action=edit Bug 33733: Fix indentation in subtest Test plan: git diff -w HEAD~1.. t/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 04:59:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 02:59:16 +0000 Subject: [Koha-bugs] [Bug 33733] Move t/XSLT.t to db_dependent In-Reply-To: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33733-70-EViG01dg9t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151187|0 |1 is obsolete| | --- Comment #6 from David Nind <david at davidnind.com> --- Created attachment 151242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151242&action=edit Bug 33733: Move to db_dependent The subtest is added to the existing db_dependent test. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 05:00:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 03:00:39 +0000 Subject: [Koha-bugs] [Bug 33733] Move t/XSLT.t to db_dependent In-Reply-To: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33733-70-cFui4675ug@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #7 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. Ran prove t/db_dependent/XSLT.t - tests pass (no longer any t/XSLT.t). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 06:45:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 04:45:57 +0000 Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32301-70-87CKU4PPAX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 --- Comment #17 from Aleisha Amohia <aleisha at catalyst.net.nz> --- This bug is present in 21.11.x, can it please be backported? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 06:50:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 04:50:13 +0000 Subject: [Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16826-70-0zzbqSpvuP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #55 from David Cook <dcook at prosentient.com.au> --- I'd love to revisit this. For now, I'm planning to look at https://github.com/NatLibFi/koha-plugin-rest-di since the folk in Finland have been kind enough to make their work available there! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 07:18:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 05:18:38 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-XAkxlQev5D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #5 from David Cook <dcook at prosentient.com.au> --- I was looking at the REST API route /biblios/XXX/items for some discovery but realized it needed more for the "Status" column unless I wanted to re-implement all the logic that we've embedded in the template view layer... Wonder if there's something to be done with this one and bug 16826 and https://github.com/NatLibFi/koha-plugin-rest-di -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 07:53:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 05:53:46 +0000 Subject: [Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16826-70-4LJMhT3V3S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 --- Comment #56 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I took a short cut to add an availability endpoint in bug 23336 but I'd love to see a more thorough treatment done longer term. The availability code needs a cleanup along the lines of what NatLibFi do I believe but I didn't have the sponsorship to go the distance that way. Happy to help though -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:32:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:32:45 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-uoIFFW9uJK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- On (In reply to David Cook from comment #5) > I was looking at the REST API route /biblios/XXX/items for some discovery > but realized it needed more for the "Status" column unless I wanted to > re-implement all the logic that we've embedded in the template view layer... > > Wonder if there's something to be done with this one and bug 16826 and > https://github.com/NatLibFi/koha-plugin-rest-di That is totally outside the scope of this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:45:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:45:17 +0000 Subject: [Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL In-Reply-To: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32357-70-0VDRAvCqKc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:45:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:45:18 +0000 Subject: [Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL In-Reply-To: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32357-70-PZf8rJQ1ar@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:45:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:45:20 +0000 Subject: [Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields In-Reply-To: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33489-70-oT65QF9pdj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:45:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:45:21 +0000 Subject: [Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields In-Reply-To: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33489-70-zvkEL7s5Oe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:45:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:45:23 +0000 Subject: [Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking In-Reply-To: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33557-70-UlI89zmNp6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:45:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:45:25 +0000 Subject: [Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking In-Reply-To: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33557-70-YWi8QjzrTY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:45:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:45:26 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-7uYOBejwXd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:45:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:45:28 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-OAHLhkyy1a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:46:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:46:49 +0000 Subject: [Koha-bugs] [Bug 32648] Search.t is failing if run after Filter_MARC_ViewPolicy.t In-Reply-To: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32648-70-Ur032ZUILO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151239|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151243&action=edit Bug 32648: Clear cache in Filter_MARC_ViewPolicy.t Search.t is failing if run after Filter_MARC_ViewPolicy.t because of a missing flush Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:47:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:47:01 +0000 Subject: [Koha-bugs] [Bug 32648] Search.t is failing if run after Filter_MARC_ViewPolicy.t In-Reply-To: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32648-70-QLgzH6Xbgd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:47:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:47:02 +0000 Subject: [Koha-bugs] [Bug 33739] ModItemTransfer triggers indexing twice In-Reply-To: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33739-70-0KAOyUoRVj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33739 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:47:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:47:04 +0000 Subject: [Koha-bugs] [Bug 33739] ModItemTransfer triggers indexing twice In-Reply-To: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33739-70-t1a0vYARLc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33739 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151219|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151244&action=edit Bug 33739: Only trigger indexing on last item modification at ModItemTransfer This patch makes ModItemTransfer trigger record indexing only on the last call (in $transfer->transit). And extra parameter is added to ->transit to effectively honour the ModItemTransfer parameter. I wanted to mention that bug 31212 highlighted an existing issue, not catched by the current tests before its inclussion, because of the DT truncation taking place. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Koha/SearchEngine/Indexer.t => FAIL: Indexing is requested twice, should only be once 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! Indexing is requested only once! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:47:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:47:38 +0000 Subject: [Koha-bugs] [Bug 32648] Search.t is failing if run after Filter_MARC_ViewPolicy.t In-Reply-To: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32648-70-i7pI8P1jCQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Back to PQA to get the follow-up pushed.. all works as desired -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:47:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:47:51 +0000 Subject: [Koha-bugs] [Bug 33739] ModItemTransfer triggers indexing twice In-Reply-To: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33739-70-eup6qtaoN6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33739 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I am wondering if we should not switch from "always index unless asked for" to "index on-demand only". This is getting messy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:49:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:49:25 +0000 Subject: [Koha-bugs] [Bug 33553] Unecessary GetCategories calls in template In-Reply-To: <bug-33553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33553-70-QEiOdrqj36@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:49:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:49:27 +0000 Subject: [Koha-bugs] [Bug 33553] Unecessary GetCategories calls in template In-Reply-To: <bug-33553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33553-70-veZzegouug@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151200|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151245&action=edit Bug 33553: Remove unecessary GetCategories calls in templates This patch removes unnecessary references to AuthorisedValues.GetCategories: SET AuthorisedValuesCategories = AuthorisedValues.GetCategories The AuthorisedValuesCategories variable is not used. To test, apply the patch and go to Tools -> Patron clubs. - If necessary, create a club template with "Allow public enrollment" enabled. - Create a new club. The club creation process should work correctly. - Open a patron account for checkout and confirm that you can enroll the patron in the new club via the "Clubs" tab. - Log in to the OPAC and confirm that you can successfully enroll yourself in the new club via the "Clubs" tab on your patron summary page. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:49:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:49:44 +0000 Subject: [Koha-bugs] [Bug 33553] Unecessary GetCategories calls in template In-Reply-To: <bug-33553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33553-70-GZghE0nVWf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:52:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:52:46 +0000 Subject: [Koha-bugs] [Bug 33488] Library transfer limits should have an index on fromBranch In-Reply-To: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33488-70-QgwvjXcT8o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33488 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 08:52:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 06:52:47 +0000 Subject: [Koha-bugs] [Bug 33488] Library transfer limits should have an index on fromBranch In-Reply-To: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33488-70-pSqxPLXJj4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33488 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 09:09:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 07:09:11 +0000 Subject: [Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer In-Reply-To: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33300-70-PC61sZByAP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 --- Comment #20 from Fridolin Somers <fridolin.somers at biblibre.com> --- Created attachment 151246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151246&action=edit Bug 33300: [22.05.x] (follow-up) DBRev for existing databases Test plan : 1.1) Start from a Koha 22.05 1.2) Upgrade to master => Check the upgrade says : Wrong system preference 'AutomaticWrongTransfer' renamed 'AutomaticConfirmTransfer' 2.1) Start from a Koha 22.05 2.2) Upgrade to 22.11 2.3) Via interface change system preference 'AutomaticConfirmTransfer' and save 2.4) Upgrade to master => Check the upgrade says : Wrong system preference 'AutomaticWrongTransfer' deleted Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 09:10:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 07:10:00 +0000 Subject: [Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer In-Reply-To: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33300-70-xiN3EEQQNI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 --- Comment #21 from Fridolin Somers <fridolin.somers at biblibre.com> --- Created attachment 151247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151247&action=edit Bug 33300: [22.05.x] Wrong system preference name AutomaticWrongTransfer Bug 29792 added a DBRev with new system preference 'AutomaticConfirmTransfer'. But name in installer/data/mysql/mandatory/sysprefs.sql is wrong 'AutomaticWrongTransfer' Test plan : Create a new database and check there is in table systempreferences an entry with variable='AutomaticConfirmTransfer' Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 09:10:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 07:10:03 +0000 Subject: [Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer In-Reply-To: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33300-70-QCBEym2uvi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151246|0 |1 is obsolete| | --- Comment #22 from Fridolin Somers <fridolin.somers at biblibre.com> --- Created attachment 151248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151248&action=edit Bug 33300: [22.05.x] (follow-up) DBRev for existing databases Test plan : 1.1) Start from a Koha 22.05 1.2) Upgrade to master => Check the upgrade says : Wrong system preference 'AutomaticWrongTransfer' renamed 'AutomaticConfirmTransfer' 2.1) Start from a Koha 22.05 2.2) Upgrade to 22.11 2.3) Via interface change system preference 'AutomaticConfirmTransfer' and save 2.4) Upgrade to master => Check the upgrade says : Wrong system preference 'AutomaticWrongTransfer' deleted Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 09:11:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 07:11:20 +0000 Subject: [Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer In-Reply-To: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33300-70-BZsDL5DQmM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 --- Comment #23 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Lucas Gass from comment #19) > Doesn't apply cleanly to 22.05.x, if needed please rebase. Here are the patches. This is needed where Bug 29792 as been pushed : 22.11.00,22.05.10, 21.11.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 09:14:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 07:14:09 +0000 Subject: [Koha-bugs] [Bug 21330] Add XSLT for authority detail page in OPAC In-Reply-To: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21330-70-BXo4YOyLnm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 --- Comment #32 from Fridolin Somers <fridolin.somers at biblibre.com> --- If possible, we would like to see this backported to 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 09:34:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 07:34:54 +0000 Subject: [Koha-bugs] [Bug 21330] Add XSLT for authority detail page in OPAC In-Reply-To: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21330-70-dGhieMl5WV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement allows to |This enhancement enables release notes|use custom XSLT stylesheets |using custom XSLT |for displaying authority |stylesheets to display |detail pages in the OPAC. |authority detail pages in | |the OPAC. | | | |Enter a path to | |the custom XSLT file in the | |new system preference | |AuthorityXSLTOpacDetailsDis | |play (or enter an external | |URL). Use placeholders for | |multiple custom style | |sheets for different | |languages ({langcode}) and | |authority types | |({authtypecode}). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 09:36:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 07:36:25 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-3PxFTbRMLa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Why are not you using Koha::Token here? Koha/Token.pm:use Mojo::JWT; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 09:38:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 07:38:31 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-vCzO1E7SNq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 09:44:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 07:44:35 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-P6VE2qnnAs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #22 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Shouldn't we also rework/reword the confirmation/errors/warnings we send to the client? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 09:55:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 07:55:52 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30418-70-VY9iynLUJs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #35 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151249&action=edit Bug 30418: Fix t/Koha/Auth/Permissions.t koha_1 | # Failed test 'Expected permissions generated for superlibrarian' koha_1 | # at t/Koha/Auth/Permissions.t line 283. koha_1 | # Structures begin differing at: koha_1 | # $got->{CAN_user_lists_edit_public_list_contents} = '1' koha_1 | # $expected->{CAN_user_lists_edit_public_list_contents} = Does not exist koha_1 | # Looks like you failed 1 test of 1. koha_1 | koha_1 | # Failed test 'superlibrarian tests' koha_1 | # at t/Koha/Auth/Permissions.t line 284. koha_1 | # Looks like you failed 1 test of 3. koha_1 | [23:34:42] t/Koha/Auth/Permissions.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 09:56:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 07:56:09 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30418-70-aoQgDs5gQz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 09:56:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 07:56:24 +0000 Subject: [Koha-bugs] [Bug 33739] ModItemTransfer triggers indexing twice In-Reply-To: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33739-70-TFp7hFhBhA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33739 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #6) > I am wondering if we should not switch from "always index unless asked for" > to "index on-demand only". This is getting messy. Agreed... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 09:59:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 07:59:24 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-1KehHIoocl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #148 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151250&action=edit Bug 8179: Remove ref to select.dataTables.min.css -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 09:59:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 07:59:41 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-DNY9l5VMe9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 10:04:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 08:04:56 +0000 Subject: [Koha-bugs] [Bug 33732] intranet Holdings Table uses opac item images In-Reply-To: <bug-33732-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33732-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33732-70-SAoFAogdep@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33732 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I am not seeing that on master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 10:21:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 08:21:50 +0000 Subject: [Koha-bugs] [Bug 33697] Remove RecordedBooks (rbdigital) integration In-Reply-To: <bug-33697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33697-70-VU7eVSUWfq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33697 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 10:21:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 08:21:53 +0000 Subject: [Koha-bugs] [Bug 33697] Remove RecordedBooks (rbdigital) integration In-Reply-To: <bug-33697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33697-70-SnviadjQBT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33697 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151251&action=edit Bug 33697: Remove RecordedBooks (rbdigital) integration RecordedBooks search API integration is now obsolete following rbdigital's incorporation into OverDrive. Associated code should be removed. https://company.overdrive.com/2020/06/23/overdrive-to-acquire-rbdigital-from-rbmedia/ Test plan: use git grep extensively and confirm that this patch removes all occurrences of this feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 10:27:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 08:27:42 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-DklHX75zrt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #49 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Thanks Martin and Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 10:38:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 08:38:38 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-Ox2a0JCpIP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Jonathan Druart from comment #21) > Why are not you using Koha::Token here? > > Koha/Token.pm:use Mojo::JWT; Because the work I split this out from has been in progress for months and I totally forgot the existence of Koha::Token. I can follow-up here to move to that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 10:40:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 08:40:32 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-D4uvvSeWSZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Jonathan Druart from comment #22) > Shouldn't we also rework/reword the confirmation/errors/warnings we send to > the client? Also yes.. but I wanted to continue working through modernising this in follow-up bugs.. I was under pressure to get the OPAC trusted self-checkout bug that this is at the bottom of the tree of in... and I found that doing the job properly was well and truly out of scope for the sponsor.. I intend to continue in my own time to improve things here.. perhaps we could mark the endpoint as experimental, allowing ourselves to continue the cleanup whilst still pushing this to allow the core feature to be present. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 10:56:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 08:56:13 +0000 Subject: [Koha-bugs] [Bug 33697] Remove RecordedBooks (rbdigital) integration In-Reply-To: <bug-33697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33697-70-bxwGzEonbO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33697 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151251|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151252&action=edit Bug 33697: Remove RecordedBooks (rbdigital) integration RecordedBooks search API integration is now obsolete following rbdigital's incorporation into OverDrive. Associated code should be removed. https://company.overdrive.com/2020/06/23/overdrive-to-acquire-rbdigital-from-rbmedia/ Test plan: use git grep extensively and confirm that this patch removes all occurrences of this feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:00:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:00:54 +0000 Subject: [Koha-bugs] [Bug 19774] Adapt existing endpoints to new naming guidelines OMNIBUS In-Reply-To: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19774-70-DNxiU29Dxr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m --- Comment #1 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- I believe this is already done in the to_api_mapping method in Illrequest.pm in this patch: https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22440&attachment=150718 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:03:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:03:13 +0000 Subject: [Koha-bugs] [Bug 32013] Autorenewals is effectively a bulk action and should be treated as such In-Reply-To: <bug-32013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32013-70-34McS92jWi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013 Aude Charillon <aude.charillon at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon at ptfs-europe. | |com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #22 from Aude Charillon <aude.charillon at ptfs-europe.com> --- No need for any changes in the Manual; updating status from Needs documenting to Resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:03:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:03:14 +0000 Subject: [Koha-bugs] [Bug 33444] AddRenewal should take a hash of parameters In-Reply-To: <bug-33444-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33444-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33444-70-0HacaJysa9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33444 Bug 33444 depends on bug 32013, which changed state. Bug 32013 Summary: Autorenewals is effectively a bulk action and should be treated as such https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:03:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:03:35 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-VxWMERaK5t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Having now looked at Koha::Token it really doesn't feel appropriate here.. we get rid of claims entirely which is what I'm relying on here.. I find it strange to drop the fundamental point of a JWT in Koha::Token.. can you explain? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:12:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:12:12 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-rEhqhRxkyN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #26 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Martin Renvoize from comment #25) > Having now looked at Koha::Token it really doesn't feel appropriate here.. > we get rid of claims entirely which is what I'm relying on here.. I find it > strange to drop the fundamental point of a JWT in Koha::Token.. can you > explain? We can extend it if you think it's missing something. But IMO we should not use Mojo::JWT directly if we have our own Koha::Token that is using it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:28:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:28:06 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30418-70-VcxYF9qbsl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #36 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #35) > Created attachment 151249 [details] [review] > Bug 30418: Fix t/Koha/Auth/Permissions.t > > koha_1 | # Failed test 'Expected permissions generated for > superlibrarian' > koha_1 | # at t/Koha/Auth/Permissions.t line 283. > koha_1 | # Structures begin differing at: > koha_1 | # > $got->{CAN_user_lists_edit_public_list_contents} = '1' > koha_1 | # > $expected->{CAN_user_lists_edit_public_list_contents} = Does not exist > koha_1 | # Looks like you failed 1 test of 1. > koha_1 | > koha_1 | # Failed test 'superlibrarian tests' > koha_1 | # at t/Koha/Auth/Permissions.t line 284. > koha_1 | # Looks like you failed 1 test of 3. > koha_1 | [23:34:42] t/Koha/Auth/Permissions.t Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:28:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:28:16 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-ilBmS7aneF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #149 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #148) > Created attachment 151250 [details] [review] > Bug 8179: Remove ref to select.dataTables.min.css Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:28:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:28:40 +0000 Subject: [Koha-bugs] [Bug 32648] Search.t is failing if run after Filter_MARC_ViewPolicy.t In-Reply-To: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32648-70-qv5DfUJUIg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master --- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Follow-up pushed to master for 23.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:28:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:28:57 +0000 Subject: [Koha-bugs] [Bug 33739] ModItemTransfer triggers indexing twice In-Reply-To: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33739-70-pwSwsUh0bm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33739 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Keywords|rel_23_05_candidate | Severity|blocker |normal --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Pushed to master for 23.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:31:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:31:45 +0000 Subject: [Koha-bugs] [Bug 33678] Saving new numbering pattern crashes on missing description In-Reply-To: <bug-33678-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33678-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33678-70-ozt0eY13Np@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33678 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |jonathan.druart+koha at gmail. | |com Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- *** This bug has been marked as a duplicate of bug 28012 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:31:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:31:45 +0000 Subject: [Koha-bugs] [Bug 28012] Error on saving new numbering pattern In-Reply-To: <bug-28012-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28012-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28012-70-qBAXcEIp90@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #24 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- *** Bug 33678 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:39:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:39:02 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-65RWJqPZPE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:39:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:39:04 +0000 Subject: [Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking In-Reply-To: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33557-70-e1Tns4BMaR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:39:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:39:11 +0000 Subject: [Koha-bugs] [Bug 33629] allow pbuilder to use network via build-git-snapshot In-Reply-To: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33629-70-kI31myW18C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33629 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Keywords|rel_22_11_candidate, | |rel_23_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:39:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:39:15 +0000 Subject: [Koha-bugs] [Bug 32401] x-koha-query cannot contain non-ISO-8859-1 values In-Reply-To: <bug-32401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32401-70-4FySg4S4Ak@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32401 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:39:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:39:17 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-GKOLiEL37V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:39:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:39:18 +0000 Subject: [Koha-bugs] [Bug 33328] x-marc-schema should be renamed x-record-schema In-Reply-To: <bug-33328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33328-70-vXNMYooDT3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33328 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:39:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:39:22 +0000 Subject: [Koha-bugs] [Bug 33658] Capitalization: **To Reproduce** In-Reply-To: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33658-70-gTCwBGDPBu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy, | |rel_23_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:39:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:39:24 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-UWcZPoRB4Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:39:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:39:25 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-N0VP1BR2Lr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:39:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:39:29 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library In-Reply-To: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30624-70-ta0JQB4k8G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed, | |rel_23_05_candidate | CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:39:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:39:31 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31699-70-6QE8HHu4x7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Keywords|rel_23_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:44:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:44:12 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31692-70-s4ooW8i5kz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Keywords|rel_23_05_candidate |rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:45:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:45:23 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31391-70-iXZnnZfvv4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 --- Comment #39 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- IMO we are too far in the release cycle to push this one for 23.05. Additionally there are several bugs opened for the OPAC part that are still waiting to be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:46:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:46:34 +0000 Subject: [Koha-bugs] [Bug 31576] [21.11] Cannot place hold even when AllowHoldPolicyOverride should allow it In-Reply-To: <bug-31576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31576-70-ht8Q4kA1rE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldstable CC| |arthur.suzuki at biblibre.com, | |jonathan.druart+koha at gmail. | |com --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Arthur, this is for you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:47:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:47:13 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-3cDVDvMZPw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151253&action=edit Bug 23336: (follow-up) Switch to using Koha::Token -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:49:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:49:30 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-Wq83lA0vsn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:49:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:49:50 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-OGyrq54axt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Follow-up to use Koha::Token now added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:50:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:50:14 +0000 Subject: [Koha-bugs] [Bug 12580] DataTables overflow their container elements In-Reply-To: <bug-12580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12580-70-bXZGz7SeW6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12580 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:51:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:51:40 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue .js and .ts files In-Reply-To: <bug-33625-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33625-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33625-70-6Tqi8nlb4y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Pushed to master for 23.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:51:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:51:52 +0000 Subject: [Koha-bugs] [Bug 33705] Tables have configure button even if they are not configurable In-Reply-To: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33705-70-5n9smW1m37@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Pushed to master for 23.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:52:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:52:30 +0000 Subject: [Koha-bugs] [Bug 33707] News vs Quote of the day styling on staff interface main page In-Reply-To: <bug-33707-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33707-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33707-70-6nezj2ccuk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33707 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Pushed to master for 23.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:52:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:52:43 +0000 Subject: [Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config In-Reply-To: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33718-70-0R3TSdy0Ly@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master --- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Pushed to master for 23.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:53:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:53:13 +0000 Subject: [Koha-bugs] [Bug 33739] ModItemTransfer triggers indexing twice In-Reply-To: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33739-70-HyTYvM1k9s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33739 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:55:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:55:23 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-QtPVnXOaOW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150967|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151254&action=edit Bug 30979: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:55:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:55:26 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-5YK92nWvW2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150968|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151255&action=edit Bug 30979: Add public endpoints This patch expands the checkouts endpoints to allow for a public workflow. We add the availability endpoint under `/public/checkouts/availability` and restrict the information we send back to only those fields a public user should be allowed to see. We also add a new checkout endpoint at `/patrons/{patron_id}/checkouts` that allows for users to checkout to themselves and accepts the same POST request with checkout details including item_id and a confirmation token in the body that the staff client endpoints accept. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:55:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:55:30 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-hNdM5MbwcJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150969|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151256&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:55:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:55:33 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-CPDc1Y2wtl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150970|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151257&action=edit Bug 30979: Limit public checkout endpoint using preference The public api endpoint for self-checkout should only be enabled in the case where the OpacTrustedSelfCheckout option is enabled. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:55:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:55:37 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-i2Wq7gW2pM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150971|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151258&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode to checkout. We check for item existance and availability and then check the item out after any confirmations have been displayed. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:55:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:55:41 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-lSuAAHWTnF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150972|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151259&action=edit Bug 30979: Always show self-checkout when preference enabled This patch updates the display logic such that if the truested self-checkout option is enabled we always show the checkout button and prompt a login when no user is found. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:55:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:55:44 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-GzQYbv5Jem@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150973|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151260&action=edit Bug 30979: Redirect to checkout summary This is a temporary solution whilst we wait for the biblio api endpoints so we may include more biblio details in the checkout modal itself. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:55:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:55:48 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-HBQxtQy9en@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150974|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151261&action=edit Bug 30979: Add modal trigger to shibboleth target url Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:58:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:58:20 +0000 Subject: [Koha-bugs] [Bug 32711] Add biblio details to trusted self-checkout modal In-Reply-To: <bug-32711-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32711-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32711-70-xfFveWOOn2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32711 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150984|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151262&action=edit Bug 32711: Add biblio details to modal This patch adds biblio details to the self-checkout modal. As part of this we add 'biblio' to the x-koha-embed option on the public items endpoint, clone the js-biblio-format include from the staff client adapting it slightly for OPAC use along the way and also import escape_str and escapeHtml from staff to opac too. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:58:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:58:23 +0000 Subject: [Koha-bugs] [Bug 32711] Add biblio details to trusted self-checkout modal In-Reply-To: <bug-32711-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32711-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32711-70-LsPXmvqixo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32711 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150985|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151263&action=edit Bug 32711: Add 'public_read_list' appropriately We're exposing biblio (and thus biblioitem) to the public API now and as such we need to explisitely list which fields to include in the response when called on the public api. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 11:58:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 09:58:25 +0000 Subject: [Koha-bugs] [Bug 32711] Add biblio details to trusted self-checkout modal In-Reply-To: <bug-32711-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32711-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32711-70-WdZVcdslPf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32711 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150986|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151264&action=edit Bug 32711: Fix biblio embeds We need to drop the embed part of the args we pass to biblioitem else we end up with some very strange behaviours on the acquisitions endpoint. Signed-off-by: Silvia Meakins <smeakins at eso.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 12:21:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 10:21:45 +0000 Subject: [Koha-bugs] [Bug 33733] Move t/XSLT.t to db_dependent In-Reply-To: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33733-70-gMRcwkrl2g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 12:21:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 10:21:48 +0000 Subject: [Koha-bugs] [Bug 33733] Move t/XSLT.t to db_dependent In-Reply-To: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33733-70-k4xHV3EnqJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151240|0 |1 is obsolete| | Attachment #151241|0 |1 is obsolete| | Attachment #151242|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151265&action=edit Bug 33733: Remove need for Test::DBIx::Class Test plan: Run t/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 12:21:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 10:21:50 +0000 Subject: [Koha-bugs] [Bug 33733] Move t/XSLT.t to db_dependent In-Reply-To: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33733-70-YP3uwJseUD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151266&action=edit Bug 33733: Fix indentation in subtest Test plan: git diff -w HEAD~1.. t/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 12:21:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 10:21:53 +0000 Subject: [Koha-bugs] [Bug 33733] Move t/XSLT.t to db_dependent In-Reply-To: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33733-70-2ncsOaJHET@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151267&action=edit Bug 33733: Move to db_dependent The subtest is added to the existing db_dependent test. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 12:22:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 10:22:03 +0000 Subject: [Koha-bugs] [Bug 33018] debian package tidy-up In-Reply-To: <bug-33018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33018-70-TokByNPI61@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Mason, ping? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 12:29:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 10:29:57 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-uwc4pBnsdV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #150 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #125) > 8. We lost the "show active" checkbox next to the fund list Still missing, and the fund list is empty! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 12:34:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 10:34:51 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-x1dnkw6NDe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #151 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- When doing a partial receive, "Actual cost" should be prefilled with the value of the first order. It does not work when another currency is used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 12:50:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 10:50:44 +0000 Subject: [Koha-bugs] [Bug 33743] New: xt/find-missing-filters.t parsing files outside of git repo Message-ID: <bug-33743-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33743 Bug ID: 33743 Summary: xt/find-missing-filters.t parsing files outside of git repo Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org it's catching missing filters on how-to.tt, which is not part of Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 12:50:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 10:50:44 +0000 Subject: [Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules In-Reply-To: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32352-70-doX4cPOJU5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33743 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 12:52:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 10:52:59 +0000 Subject: [Koha-bugs] [Bug 33743] xt/find-missing-filters.t parsing files outside of git repo In-Reply-To: <bug-33743-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33743-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33743-70-sXfrx8rdAD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33743 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 12:53:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 10:53:02 +0000 Subject: [Koha-bugs] [Bug 33743] xt/find-missing-filters.t parsing files outside of git repo In-Reply-To: <bug-33743-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33743-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33743-70-u5kP8Z0r9f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33743 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151268&action=edit Bug 33743: Make xt/find-missing-filters.t check directories in git index only -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 12:57:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 10:57:07 +0000 Subject: [Koha-bugs] [Bug 33743] xt/find-missing-filters.t parsing files outside of git repo In-Reply-To: <bug-33743-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33743-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33743-70-VppojW9hzA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33743 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151268|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151269&action=edit Bug 33743: Make xt/find-missing-filters.t and xt/single_quotes.t check directories in git index only -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 12:57:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 10:57:42 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-vNZn5aEytZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 12:59:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 10:59:26 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-ldyPsXfuOQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master Keywords|rel_23_05_candidate | --- Comment #122 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Patches pushed for 23.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 12:59:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 10:59:35 +0000 Subject: [Koha-bugs] [Bug 33733] Move t/XSLT.t to db_dependent In-Reply-To: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33733-70-DZaleZ0cs6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33733 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | CC| |jonathan.druart+koha at gmail. | |com Status|Passed QA |Pushed to master --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Patches pushed for 23.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 12:59:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 10:59:54 +0000 Subject: [Koha-bugs] [Bug 33719] Search.t: too much noise about ContentWarningField In-Reply-To: <bug-33719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33719-70-5EN72EntaM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33719 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:00:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:00:10 +0000 Subject: [Koha-bugs] [Bug 33719] Search.t: too much noise about ContentWarningField In-Reply-To: <bug-33719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33719-70-E1Wc8dmP5Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33719 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Patches pushed for 23.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:00:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:00:18 +0000 Subject: [Koha-bugs] [Bug 33743] xt/find-missing-filters.t parsing files outside of git repo In-Reply-To: <bug-33743-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33743-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33743-70-HYkSZW1aOh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33743 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:00:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:00:23 +0000 Subject: [Koha-bugs] [Bug 33743] xt/find-missing-filters.t parsing files outside of git repo In-Reply-To: <bug-33743-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33743-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33743-70-rpGJ6ZMEPT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33743 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:00:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:00:33 +0000 Subject: [Koha-bugs] [Bug 33743] xt/find-missing-filters.t parsing files outside of git repo In-Reply-To: <bug-33743-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33743-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33743-70-pMytCWji4S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33743 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Patches pushed for 23.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:12:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:12:35 +0000 Subject: [Koha-bugs] [Bug 33744] New: Plugins not working on duplicated MARC fields Message-ID: <bug-33744-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 Bug ID: 33744 Summary: Plugins not working on duplicated MARC fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: matt.blenkinsop at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl AddEventHandlers in cataloging.js uses .data('events') which is now deprecated. This means that a duplicated field with the upload.pl plugin doesn't function as expected as the event handler doesn't pass to the duplicated field. To reproduce: 1) In Administration > MARC frameworks, choose a framework and through the actions button click on MARC structure 2) Search for field 856 3) Click on edit subfields 4) Select subfield "u" using the tabs at the top 5) At the bottom, in the dropdown menu called "Plugin", select "upload.pl" (bottom of the list) and save 6) Navigate to Cataloging and create a new record using the framework you have just edited 7) Click on tab 8 and check you have field 856. Click on the Upload button and the pop up should open as expected allowing you to upload a file 8) Click on the "Repeat this tag" button for the 856 tag 9) Click on the Upload button and nothing will happen 10) Delete the cloned tag 11) On the original tag, click the "Repeat this subfield" button next to the "Upload" button. 12) Click the "Upload" button on the new subfield and the same issue will occur. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:12:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:12:41 +0000 Subject: [Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields In-Reply-To: <bug-33744-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33744-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33744-70-txd6Uy8Tel@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |matt.blenkinsop at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:14:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:14:20 +0000 Subject: [Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields In-Reply-To: <bug-33744-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33744-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33744-70-Xn9WbIupHg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Looks like this is addressed under bug 30975. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:14:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:14:37 +0000 Subject: [Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields In-Reply-To: <bug-33744-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33744-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33744-70-RntKjlfLzx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- *** This bug has been marked as a duplicate of bug 30975 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:14:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:14:37 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-poAdP2c2qJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #36 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- *** Bug 33744 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:17:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:17:13 +0000 Subject: [Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields In-Reply-To: <bug-33744-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33744-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33744-70-4f8EaylZHP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151270&action=edit Bug 33744: Fix deprecated use of .data('events') This patch removes a deprecated internal data structure no longer supported in jQuery. This means that AddEventHandlers now correctly passes events to cloned fields in the MARC record Test plan: 1) Apply patch 2) Repeat steps in the original bug description 3) This time clicking on the Upload button for a cloned field should launch the uploads pop up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:17:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:17:49 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-WtM9Tl7uS0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #123 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Thanks for the research and follow-up, Katrina. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:39:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:39:15 +0000 Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees In-Reply-To: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33411-70-XialLb8Qom@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:39:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:39:17 +0000 Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees In-Reply-To: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33411-70-vbtLbCbh1J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149292|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151271&action=edit Bug 33411: Unit test update Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:39:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:39:19 +0000 Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees In-Reply-To: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33411-70-q9eNsRwLtg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149293|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151272&action=edit Bug 33411: Don't count related guarantees fees against NoIssuesChargeGuarantees To test: 1 - Find an adult patron in Koha 2 - Add two guarantees 3 - Add $1 fine to parent, $5 fine to each guarantee 4 - Set no issues charge guarantees to 9 5 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron BARCODE 6 - Note the 64 message starts with Y's that mean patron is blocked 7 - Repeat with each child barcode 8 - They are blocked? 9 - Apply patch, restart all (restart_all will restart SIP) 10 - Try again 11 - Parent blocked, children should not be -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:41:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:41:03 +0000 Subject: [Koha-bugs] [Bug 33745] New: Speed up Koha::Object attribute accessors Message-ID: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 Bug ID: 33745 Summary: Speed up Koha::Object attribute accessors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: glasklas at gmail.com QA Contact: testopia at bugs.koha-community.org In Bug 32060 object accessor methods surprisingly turned out to have a not huge, but significant negative effect on performance. By dynamically/lazily creating accessor subroutines in AUTOLOAD, which on subsequent calls will be called directly instead of AUTOLOAD accessing/setting an object attribute will become about 7 times faster. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:41:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:41:08 +0000 Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees In-Reply-To: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33411-70-OeR1Z1z0t7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to David Nind from comment #5) > Testing notes using KTD: > > 1. I used Ruben Harper (23529000686353) as the guarantor and Joyce Gaines > (23529000224510) and Bobbie Middleton (23529000080862) as the guarantees. > > 2. I wasn't sure how to restart the SIP emulator after applying the patch, > so ending up shutting down and starting up KTD (otherwise there was no > change in the responses received). > restart_all will restart SIP - I had a mistake in the test plan, set the pref to 9 for the guarantees to trigger the block (In reply to Victor Grousset/tuxayo from comment #6) > > 11 - Parent blocked, children should not be > > David's test have the parent unblocked thanks to the patch. Is the test plan > wrong then? > > I can't get a difference with and without the patch. Even after doing > "koha-sip --restart" is that the right way? (testing on ktd) When KTD is shut down and restarted, all data is cleared, so the patrons no longer had fines - that is why the parent was unblocked The problem was the mistake in plan, now fixed, ready for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:49:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:49:51 +0000 Subject: [Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields In-Reply-To: <bug-33744-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33744-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33744-70-m4L7DLTFxq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:53:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:53:41 +0000 Subject: [Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields In-Reply-To: <bug-33744-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33744-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33744-70-ceyGtpm95r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- > This patch removes a deprecated internal data structure no longer supported in jQuery. // Note: This code depends on the jQuery data for events; this structure // is moved to _data as of jQuery 1.8. - var ev= $(oldcontrol).data('events'); + var ev = $._data(oldcontrol, "events"); You are using an internal structure here. Where we really dont know how long it will be supported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:54:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:54:52 +0000 Subject: [Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields In-Reply-To: <bug-33744-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33744-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33744-70-BBrFvgSApp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Perhaps we can use it as a temporary workaround until 30975 gets in ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:55:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:55:47 +0000 Subject: [Koha-bugs] [Bug 33745] Speed up Koha::Object attribute accessors In-Reply-To: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33745-70-f7I1Pf0wzW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 --- Comment #1 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151273&action=edit Bug 33745: Lazily create attribute accessor methods in AUTOLOAD Lazily create accessor methods when getting or setting an Koha::Object attribute resulting in a significant speed up. To test: 1) Run the benchmark.pl script 2) Apply the patch 3) Run the script again, Koha::Object accessors be about 7 times faster 5) Ensure tests in t/db_dependent/Item.t still pass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:56:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:56:07 +0000 Subject: [Koha-bugs] [Bug 33745] Speed up Koha::Object attribute accessors In-Reply-To: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33745-70-CsfWD0xYpz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:56:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:56:22 +0000 Subject: [Koha-bugs] [Bug 33745] Speed up Koha::Object attribute accessors In-Reply-To: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33745-70-MOh1cFuUFz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:57:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:57:40 +0000 Subject: [Koha-bugs] [Bug 33745] Speed up Koha::Object attribute accessors In-Reply-To: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33745-70-uQo6LxoHSC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 --- Comment #2 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151274&action=edit Benschmark script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:58:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:58:59 +0000 Subject: [Koha-bugs] [Bug 33745] Speed up Koha::Object attribute accessors In-Reply-To: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33745-70-KZEG2A9hZ9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32060 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:58:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:58:59 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-vmhqZlhzHC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33745 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 13:59:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 11:59:38 +0000 Subject: [Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields In-Reply-To: <bug-33744-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33744-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33744-70-lIOIP301yj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 14:02:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 12:02:03 +0000 Subject: [Koha-bugs] [Bug 33745] Speed up Koha::Object attribute accessors In-Reply-To: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33745-70-rfDC88x9dr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151274|Benschmark script |Benchmark script description| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 14:04:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 12:04:32 +0000 Subject: [Koha-bugs] [Bug 33745] Speed up Koha::Object attribute accessors In-Reply-To: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33745-70-q45IcgGzoh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151273|0 |1 is obsolete| | --- Comment #3 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151275&action=edit Bug 33745: Lazily create attribute accessor methods in AUTOLOAD Lazily create accessor methods when getting or setting an Koha::Object attribute resulting in a significant speed up. To test: 1) Run the benchmark.pl script 2) Apply the patch 3) Run the script again, Koha::Object accessors should be about 7 times faster 5) Ensure tests in t/db_dependent/Item.t still pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 14:07:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 12:07:44 +0000 Subject: [Koha-bugs] [Bug 33521] Column item_priority in OPAC holdingst can never show In-Reply-To: <bug-33521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33521-70-3Zihbic4mI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33521 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- The logic changed on bug 13335, but it applied to opac-reserve only... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 16 14:12:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 12:12:53 +0000 Subject: [Koha-bugs] [Bug 33740] Error 500, when editing authority TAG 000 (leader). In-Reply-To: <bug-33740-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33740-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33740-70-CGTIjsIPZX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33740 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- do you have access to the Koha logs on the server? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 14:28:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 12:28:32 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-uTfjnaiNDr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 14:29:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 12:29:04 +0000 Subject: [Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin In-Reply-To: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25379-70-Cmc9ZTIeCB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 14:33:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 12:33:45 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-AZ6wJbtUwc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 14:33:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 12:33:48 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-ywvFkPLbW0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150204|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151276&action=edit Bug 33606: Add a erm/config route to retrieve the ERM config needed for the Vue app This could be extended later in bug 32968 to pass the permission of the logged in user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 14:33:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 12:33:50 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-34LhEi7mkk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151277&action=edit Bug 33606: Mark the endpoint as experimental -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 14:36:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 12:36:12 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-5HAIdOeNai@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Could we add a test to cover this change? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 14:49:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 12:49:41 +0000 Subject: [Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference In-Reply-To: <bug-25560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25560-70-r2WTOTmVzq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 14:49:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 12:49:51 +0000 Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees In-Reply-To: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33411-70-D1wI1C8Xga@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 14:49:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 12:49:54 +0000 Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees In-Reply-To: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33411-70-rApw25XRiA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151271|0 |1 is obsolete| | --- Comment #11 from David Nind <david at davidnind.com> --- Created attachment 151278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151278&action=edit Bug 33411: Unit test update Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 14:49:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 12:49:56 +0000 Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees In-Reply-To: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33411-70-auZZMLIlXB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151272|0 |1 is obsolete| | --- Comment #12 from David Nind <david at davidnind.com> --- Created attachment 151279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151279&action=edit Bug 33411: Don't count related guarantees fees against NoIssuesChargeGuarantees To test: 1 - Find an adult patron in Koha 2 - Add two guarantees 3 - Add $1 fine to parent, $5 fine to each guarantee 4 - Set no issues charge guarantees to 9 5 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron BARCODE 6 - Note the 64 message starts with Y's that mean patron is blocked 7 - Repeat with each child barcode 8 - They are blocked? 9 - Apply patch, restart all (restart_all will restart SIP) 10 - Try again 11 - Parent blocked, children should not be Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:11:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:11:20 +0000 Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments In-Reply-To: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29145-70-1xkHTlcmCt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:15:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:15:42 +0000 Subject: [Koha-bugs] [Bug 31498] Allow for custom primary contact method values In-Reply-To: <bug-31498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31498-70-KDHGqjfAqn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31498 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |tomascohen at gmail.com --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Hi all. It feels to me that this should go the (say) debit types route, in which there are some system-defined ones the end user cannot remove, and then the user defined. What y'all think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:18:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:18:01 +0000 Subject: [Koha-bugs] [Bug 32970] Allow export of batch item modification results in background jobs In-Reply-To: <bug-32970-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32970-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32970-70-AtKb6tTqJh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32970 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:18:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:18:03 +0000 Subject: [Koha-bugs] [Bug 32970] Allow export of batch item modification results in background jobs In-Reply-To: <bug-32970-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32970-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32970-70-3T4l3tJH0g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32970 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:18:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:18:05 +0000 Subject: [Koha-bugs] [Bug 33098] Revert suggestion status to 'Accepted' when orders made from a suggestion are cancelled In-Reply-To: <bug-33098-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33098-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33098-70-xHYQ6e03gq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:18:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:18:06 +0000 Subject: [Koha-bugs] [Bug 33098] Revert suggestion status to 'Accepted' when orders made from a suggestion are cancelled In-Reply-To: <bug-33098-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33098-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33098-70-LpepaB2zgB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:18:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:18:08 +0000 Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep In-Reply-To: <bug-33190-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33190-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33190-70-ExWfFp7SKJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:18:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:18:10 +0000 Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep In-Reply-To: <bug-33190-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33190-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33190-70-J8GfaBpMQF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 --- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:18:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:18:12 +0000 Subject: [Koha-bugs] [Bug 33365] Add item type column to cn_browser results table In-Reply-To: <bug-33365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33365-70-AFC3CzsUcc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33365 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:18:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:18:14 +0000 Subject: [Koha-bugs] [Bug 33365] Add item type column to cn_browser results table In-Reply-To: <bug-33365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33365-70-qwVdoT5T1P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33365 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:45:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:45:06 +0000 Subject: [Koha-bugs] [Bug 33688] ApplyFrameworkDefaults does not work When adding a record to basket with the "from a new (empty) record" option In-Reply-To: <bug-33688-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33688-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33688-70-Q6hT4Ta8kr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33688 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:47:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:47:04 +0000 Subject: [Koha-bugs] [Bug 33297] Typo system preference RetainPatronSearchTerms in DB revs 220600044.pl In-Reply-To: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33297-70-p8JTUzQ4kI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33297 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:47:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:47:06 +0000 Subject: [Koha-bugs] [Bug 33297] Typo system preference RetainPatronSearchTerms in DB revs 220600044.pl In-Reply-To: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33297-70-NHaGIib92N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33297 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148582|0 |1 is obsolete| | Attachment #148583|0 |1 is obsolete| | Attachment #148584|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151280&action=edit Bug 33297: Fix typo system preference RetainPatronSearchTerms in DB revs 220600044.pl Bug 26247 added system preference RetainPatronsSearchTerms. There is a typo in DB revs 220600044.pl : RetainPatronSearchTerms instead of RetainPatronsSearchTerms. Test plan : Upgrade from 22.05 to 22.11 and check there is a system preference named 'RetainPatronsSearchTerms' Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:47:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:47:09 +0000 Subject: [Koha-bugs] [Bug 33297] Typo system preference RetainPatronSearchTerms in DB revs 220600044.pl In-Reply-To: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33297-70-Tg0q3Bxr39@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33297 --- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151281&action=edit Bug 33297: (follow-up) DBRev for existing databases Test plan : 1.1) Start from a Koha 22.05 1.2) Upgrade to master => Check the upgrade says : Wrong system preference 'RetainPatronSearchTerms' renamed 'RetainPatronsSearchTerms' 2.1) Start from a Koha 22.05 2.2) Upgrade to 22.11 2.3) Via interface change system preference 'RetainPatronsSearchTerms' and save 2.4) Upgrade to master => Check the upgrade says : Wrong system preference 'RetainPatronSearchTerms' deleted Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:47:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:47:12 +0000 Subject: [Koha-bugs] [Bug 33297] Typo system preference RetainPatronSearchTerms in DB revs 220600044.pl In-Reply-To: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33297-70-p2rgL8e3wK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33297 --- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151282&action=edit Bug 33297: (follow-up) DBRev check wrong preference exists Better db upgrade messages Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:47:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:47:20 +0000 Subject: [Koha-bugs] [Bug 33297] Typo system preference RetainPatronSearchTerms in DB revs 220600044.pl In-Reply-To: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33297-70-HlbFbOLeqq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33297 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:47:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:47:25 +0000 Subject: [Koha-bugs] [Bug 33297] Typo system preference RetainPatronSearchTerms in DB revs 220600044.pl In-Reply-To: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33297-70-vfP8Ff0LAi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33297 --- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to David Nind from comment #15) > I'd like to test, but don't know how to do step 1.2 (upgrading from 22.05 to > master) using KTD (koha-testing-docker). > > If I could get some instructions on how to do that, I'll happily test. % git checkout v22.05.00 % reset_all % git checkout master > SELECT variable from systempreferences where variable like "%RetainPatron%"; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:48:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:48:09 +0000 Subject: [Koha-bugs] [Bug 33297] Typo system preference RetainPatronSearchTerms in DB revs 220600044.pl In-Reply-To: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33297-70-QrrwAeczTk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33297 --- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I am not sure about "Wrong system preference 'RetainPatronSearchTerms' does not exist" I would say: If nothing is wrong, then tell nothing. It could be confusing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:49:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:49:32 +0000 Subject: [Koha-bugs] [Bug 33697] Remove RecordedBooks (rbdigital) integration In-Reply-To: <bug-33697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33697-70-VsZlm9Ifr3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33697 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart+koha at gmail. | |com CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 15:58:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 13:58:08 +0000 Subject: [Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out In-Reply-To: <bug-23102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23102-70-H3TgsBDILR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:06:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:06:14 +0000 Subject: [Koha-bugs] [Bug 33444] AddRenewal should take a hash of parameters In-Reply-To: <bug-33444-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33444-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33444-70-22iRE0hHJ7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33444 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:06:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:06:17 +0000 Subject: [Koha-bugs] [Bug 33444] AddRenewal should take a hash of parameters In-Reply-To: <bug-33444-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33444-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33444-70-mFn4dhSKHM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33444 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149280|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151283&action=edit Bug 33444: Update AddRenewal to take a hashref of params Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:07:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:07:39 +0000 Subject: [Koha-bugs] [Bug 32671] basic_workflow.t is failing randomly In-Reply-To: <bug-32671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32671-70-OUCbDsbVHP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32671 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Koha_Master/2516 koha_1 | CP main = 3.14 koha_1 | CP add patron category = 5.06 koha_1 | koha_1 | # Failed test at t/db_dependent/selenium/basic_workflow.t line 122. koha_1 | Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 125. koha_1 | # 'Add patron (test cat description) › Patrons › Koha' koha_1 | # doesn't match '(?^u:Patron details for test_patron_surname)' koha_1 | CP add patron = 8.83 koha_1 | CP add biblio = 0.23 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:11:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:11:46 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-nZt8vM5oai@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Keywords| |rel_23_05_candidate --- Comment #25 from Nick Clemens <nick at bywatersolutions.com> --- This may go in as a standalone feature, marked experimental for the 23.05 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:19:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:19:24 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-vlZ6E3isUM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151152|0 |1 is obsolete| | --- Comment #51 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151284&action=edit Bug 30719: DB and API - Adds 'batch' accessor to Illrequest object - New illbatches and illbatch_statuses tables - New foreign key 'batch_id' in illrequests table - Atomic update file - Default illbatch_statuses - Add 'add' ill_requests api method - Add POST method in ill_requests path - Add 'batch_id property to ill_request api definition - Updated swagger.yml with new batches and batchstatuses endpoints Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:19:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:19:27 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-MzJPDtoDFA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151153|0 |1 is obsolete| | --- Comment #52 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151285&action=edit Bug 30719: ILL Batches - Add batch column to requests table - Establish if there are any availability or metadata enrichment plugins and pass that to the template - Verify if we have any backend that can support batches, if not, don't show the option - Updates to the ILL toolbar - New ILL batch modal - New Koha classes - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:19:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:19:31 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-QAXekGceHv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151154|0 |1 is obsolete| | --- Comment #53 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151286&action=edit Bug 30719: ILL Batch Statuses - UI adding support for batch statuses in batch UI - Admin UI for managing batch statuses - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:19:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:19:34 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-FFYmbouXa2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151155|0 |1 is obsolete| | --- Comment #54 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151287&action=edit Bug 30719: Tests Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:19:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:19:37 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-L51KgHmzum@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151156|0 |1 is obsolete| | --- Comment #55 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151288&action=edit Bug 30719: dbic specific, DONT PUSH -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:20:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:20:45 +0000 Subject: [Koha-bugs] [Bug 30255] Allow skipping "list" step for record batch modification/deletion In-Reply-To: <bug-30255-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30255-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30255-70-H0c5jegU9i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131527|0 |1 is obsolete| | --- Comment #3 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151289&action=edit Bug 30255: Make selection step optional for batch record del/mod Allow the user to optionally skip the record selection step in batch record deletion/modification tools and directly enqueue job for all records. 1) Create a record modification template. 2) Enter some biblionumber(s) in the batch record modification tool form, select the record modification template, the "Select records to modify" option and proceed to the next step. 3) Verify that records can be selected, proceed to the next step and verify that a job has been enqueued for the selected records. 4) Return to the batch record modification form and enter the biblionumbers(s) again. Now select "Modify all" and proceed to the next step. 5) Verify that a job has been enqueued for all records. 6) Enter some biblionumber(s) in the batch record deletion tool form, select the "Select records to delete" option and proceed to the next step. 7) Verify that records can be selected, proceed to the next step and verify that a job has been enqueued for the selected records. 8) Return to the batch record deletion form and enter the biblionumbers(s) again. Now select "Delete all" and proceed to the next step. 9) Verify that a job has been enqueued for all records. Sponsored by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:22:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:22:06 +0000 Subject: [Koha-bugs] [Bug 28852] Extend options in SelfCheckoutByLogin syspref In-Reply-To: <bug-28852-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28852-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28852-70-6XnL5YKFnR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28852 Megan F <mfarve at mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfarve at mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:22:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:22:55 +0000 Subject: [Koha-bugs] [Bug 33745] Speed up Koha::Object attribute accessors In-Reply-To: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33745-70-tJQFuk6Q1m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:22:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:22:57 +0000 Subject: [Koha-bugs] [Bug 33745] Speed up Koha::Object attribute accessors In-Reply-To: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33745-70-CIRnDBz7Tb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151275|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151290&action=edit Bug 33745: Lazily create attribute accessor methods in AUTOLOAD Lazily create accessor methods when getting or setting an Koha::Object attribute resulting in a significant speed up. To test: 1) Run the benchmark.pl script 2) Apply the patch 3) Run the script again, Koha::Object accessors should be about 7 times faster 5) Ensure tests in t/db_dependent/Item.t still pass Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:23:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:23:24 +0000 Subject: [Koha-bugs] [Bug 30255] Allow skipping "list" step for record batch modification/deletion In-Reply-To: <bug-30255-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30255-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30255-70-MZQxnWJZCM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from David Gustafsson <glasklas at gmail.com> --- Rebased against master. Can't get my local koha docker to work with latest master though, and considering how many issues encountered will probably take a while to fix, so have not been able to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:26:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:26:20 +0000 Subject: [Koha-bugs] [Bug 28852] Extend options in SelfCheckoutByLogin syspref In-Reply-To: <bug-28852-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28852-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28852-70-xLmRQ7MzYD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28852 --- Comment #4 from Megan F <mfarve at mckinneytexas.org> --- My main goal at the library is to provide excellent customer service. While we have moved to digital cards that are more accessible via mobile phones, adding another checkout method would further promote customer satisfaction. Especially since patrons constantly ask about this feature. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:32:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:32:15 +0000 Subject: [Koha-bugs] [Bug 30255] Allow skipping "list" step for record batch modification/deletion In-Reply-To: <bug-30255-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30255-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30255-70-rogTb4cgm8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to David Gustafsson from comment #4) > Rebased against master. Can't get my local koha docker to work with latest > master though, and considering how many issues encountered will probably > take a while to fix, so have not been able to test. It was broken this "morning", pull the new images it should be fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:39:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:39:38 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-KgLTWcdFnA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:39:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:39:40 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-vT9F1NPC8Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151133|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151291&action=edit Bug 32060: Improve performance of columns_to_str To test: 1) Ensure the following tests pass t/db_dependent/Koha/Item.t t/db_dependent/Koha/Bibio.t 2) Go to a biblio (preferably as serial) with many items and click "New" -> "New item" and note down the response time. 3) Apply the patch 4) Ensure tests in 1) still pass 5) Repeat step 2), the response time should be substantially improved Sponsored-by: Gothenburg University Library Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:39:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:39:43 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-9rjAVBpESi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 --- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151292&action=edit Bug 32060: Use selectrow_array Trivial ergonomic patch, use selectrow_array, no need to prepare the query + perltidy the sub Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:44:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:44:13 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29440-70-arGKAH74lZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140924|0 |1 is obsolete| | --- Comment #61 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151293&action=edit Bug 29440: Refactor and clean up bulkmarcimport.pl To test: 1) Import biblios using ./bulkmarcimport.pl -v -b -file biblios.mrc -insert -update -c=MARC21 -match "control-number,001" -n=1 -l "/tmp/import.log" 2) Verify in /tmp/import.log that one biblio has been inserted 3) Import again without the "-n" option, verify that one biblio has been updated and the rest inserted 4) In the staff interface search the catalog for some string appearing in the imported biblios to verify records have been indexed 5) View/edit some of the biblios the staff interface to very have been properly imported 6) Import authorities using ./bulkmarcimport.pl -v -m=MARCXML -a -file authorities.xml -insert -update -c=MARC21 -keepids="024a" -match "heading-main,100a" -l "/tmp/import.log" -yaml="/tmp/ids.yml" 7) Go to the authorities page and find the imported authority by for example search for a 400 or 100 field value. Verify that the 001 field of the incoming record has been moved to 024a. Also check that the value of 024a appear as a key in /tmp/ids.yml. 8) Edit the authorities.xml file and change the value of field 400a 9) Import authorities again using the same options 10) Verify that the 400a field of the authority in Koha has not been updated (the import was skippped since revision did not change) 11) Edit authorities.xml, replace the value of field 005 in the file with field 005 of the authority in Koha incremented by one 12) Import again with the same options 13) Verify that the 400a field of the authority in Koha now have been updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:44:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:44:16 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29440-70-WIgFOjRCQb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140925|0 |1 is obsolete| | --- Comment #62 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151294&action=edit Bug 29440: Make authorities import behavior consistent with biblios The current behavior for when importing authorities, when match option is enabled, is to insert as a new authority fetching from db fails. This is both a bit confusing and not consistent with the biblio case where an error is generated. Also clean up error and log messages so both messages/errors and when messages/errors are issued are more consistent for the biblio and authority case. Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> The patch works fine for me. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:44:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:44:19 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29440-70-s917JFH740@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140926|0 |1 is obsolete| | --- Comment #63 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151295&action=edit Bug 29440: Fix QA-tool issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:44:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:44:22 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29440-70-oVy2xEalxQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140927|0 |1 is obsolete| | --- Comment #64 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151296&action=edit Bug 29440: defer biblio autolinking until records are indexed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:44:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:44:22 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-nu7JptfctV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Nick for QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:44:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:44:25 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29440-70-YpBNbgLaHT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140928|0 |1 is obsolete| | --- Comment #65 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151297&action=edit Bug 29440: replace usage of removed GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:44:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:44:28 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29440-70-VZXl2r02qD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140987|0 |1 is obsolete| | --- Comment #66 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151298&action=edit Bug 29440: Remove pointless call to _strip_item_fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:44:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:44:31 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29440-70-z8XHKGzCJd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140988|0 |1 is obsolete| | --- Comment #67 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151299&action=edit Bug 29440: Rename $modify_biblio_marc_options to $mod_bilbio_options This variable actually contains ModBibio options and ModifyBiblioMarc accepts a subset of these -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:44:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:44:34 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29440-70-Fpwf7d36gf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140989|0 |1 is obsolete| | --- Comment #68 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151300&action=edit Bug 29440: Only log items has been inserted if actually have been so, and remove extra out of place logging of record insertion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:44:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:44:37 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29440-70-fLPSVDXKHh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143375|0 |1 is obsolete| | --- Comment #69 from David Gustafsson <glasklas at gmail.com> --- Created attachment 151301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151301&action=edit Bug 29440: Replace removed syspref BiblioAddsAuthorities with AutoLinkBiblios -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:44:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:44:42 +0000 Subject: [Koha-bugs] [Bug 33745] Speed up Koha::Object attribute accessors In-Reply-To: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33745-70-wa7s74yif1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |nick at bywatersolutions.com --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Nick for QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:44:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:44:55 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29440-70-snjSkozuiA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 --- Comment #70 from David Gustafsson <glasklas at gmail.com> --- Rebased against master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:46:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:46:43 +0000 Subject: [Koha-bugs] [Bug 33746] New: [omnibus] speed improvement Message-ID: <bug-33746-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 Bug ID: 33746 Summary: [omnibus] speed improvement Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:46:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:46:44 +0000 Subject: [Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6 In-Reply-To: <bug-32910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32910-70-4RpWI9PsLR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #22 from Owen Leonard <oleonard at myacpl.org> --- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt: > .fa-file-archive-o { Remote branch rebased again and updated to fix a couple more missing references and to remove unused assets from the staff interface and OPAC https://gitlab.com/koha-dev/koha-dev/-/tree/bug_32910 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:48:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:48:13 +0000 Subject: [Koha-bugs] [Bug 33746] [omnibus] speed improvement In-Reply-To: <bug-33746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33746-70-s6ueCFVVcQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26802, 33745, 32060, 31856, | |33568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26802 [Bug 26802] Improve speed with records with many items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 [Bug 31856] Improve performance of serials subscriptions search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 [Bug 32060] Improve performance of Koha::Item->columns_to_str https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the biblio detail view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 [Bug 33745] Speed up Koha::Object attribute accessors -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:48:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:48:13 +0000 Subject: [Koha-bugs] [Bug 26802] Improve speed with records with many items In-Reply-To: <bug-26802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26802-70-R2vzuBgVeD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26802 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33746 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 [Bug 33746] [omnibus] speed improvement -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:48:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:48:13 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31856-70-TYMYviZoKf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33746 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 [Bug 33746] [omnibus] speed improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:48:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:48:13 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-FPrkVbtGX0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33746 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 [Bug 33746] [omnibus] speed improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:48:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:48:13 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-D5h2xOqVlT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33746 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 [Bug 33746] [omnibus] speed improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:48:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:48:13 +0000 Subject: [Koha-bugs] [Bug 33745] Speed up Koha::Object attribute accessors In-Reply-To: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33745-70-q2juYSPft8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33746 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 [Bug 33746] [omnibus] speed improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:49:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:49:53 +0000 Subject: [Koha-bugs] [Bug 33746] [omnibus] speed improvement In-Reply-To: <bug-33746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33746-70-OyTaP6RI2V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32496, 32476 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476 [Bug 32476] Add caching for relatively expensive patron methods https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:49:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:49:53 +0000 Subject: [Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods In-Reply-To: <bug-32476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32476-70-gW2b6b05B5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33746 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 [Bug 33746] [omnibus] speed improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 16:49:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 14:49:53 +0000 Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm In-Reply-To: <bug-32496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32496-70-x25BQemddE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33746 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 [Bug 33746] [omnibus] speed improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:00:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 15:00:59 +0000 Subject: [Koha-bugs] [Bug 26777] Give the user the option to display their patron card barcode from the OPAC In-Reply-To: <bug-26777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26777-70-EMA9YmL0BN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- https://codelabs.developers.google.com/add-to-wallet-android#0 is interesting too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:02:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 15:02:38 +0000 Subject: [Koha-bugs] [Bug 29063] [DOCS] Manual: Translation issue with repeated strings in system preferences In-Reply-To: <bug-29063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29063-70-uL808Smkve@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29063 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion CC| |aude.charillon at ptfs-europe. | |com --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Any opinions on the first option? (see my last comment) Or should we wait for a developer to help us with either option 2 or 3? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:02:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 15:02:56 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31856-70-LmdCqNswgZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 --- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- What's the purpose of this line? 632 $subscriptions_by_id{$field_value->record_id}->{additional_fields}->{$field_name} = $field_value->value; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:05:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 15:05:03 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31856-70-ZMl0CxMcyM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 --- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- ok got it. I will need another review another day, with a fresh brain. We should make the code a bit more readable, I find it a bit obscure at the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:11:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 15:11:59 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-SuchS5OBn9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151091|0 |1 is obsolete| | --- Comment #32 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 151302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151302&action=edit Bug 33117: Adding new system preference for patron searching -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:17:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 15:17:17 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-UvweyzVTS5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151284|0 |1 is obsolete| | --- Comment #56 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151303&action=edit Bug 30719: DB and API - Adds 'batch' accessor to Illrequest object - New illbatches and illbatch_statuses tables - New foreign key 'batch_id' in illrequests table - Atomic update file - Default illbatch_statuses - Add 'add' ill_requests api method - Add POST method in ill_requests path - Add 'batch_id property to ill_request api definition - Updated swagger.yml with new batches and batchstatuses endpoints Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:17:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 15:17:21 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-4spqNfYEYc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151285|0 |1 is obsolete| | --- Comment #57 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151304&action=edit Bug 30719: ILL Batches - Add batch column to requests table - Establish if there are any availability or metadata enrichment plugins and pass that to the template - Verify if we have any backend that can support batches, if not, don't show the option - Updates to the ILL toolbar - New ILL batch modal - New Koha classes - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:17:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 15:17:24 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-h856qYln91@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151286|0 |1 is obsolete| | --- Comment #58 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151305&action=edit Bug 30719: ILL Batch Statuses - UI adding support for batch statuses in batch UI - Admin UI for managing batch statuses - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:17:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 15:17:27 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-G6mACVuG0j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151287|0 |1 is obsolete| | --- Comment #59 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151306&action=edit Bug 30719: Tests Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:17:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 15:17:30 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-qMHjwc5diz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151288|0 |1 is obsolete| | --- Comment #60 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151307&action=edit Bug 30719: dbic specific, DONT PUSH -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:30:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 15:30:09 +0000 Subject: [Koha-bugs] [Bug 33742] Add permission to circumvent HidePatronName syspref In-Reply-To: <bug-33742-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33742-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33742-70-jZMdhkeq5y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33742 --- Comment #1 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- Or maybe the syspref HidePatronName could be updated to have a third option of "only show names to staff with edit_borrowers permission"? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:36:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 15:36:20 +0000 Subject: [Koha-bugs] [Bug 33742] Add permission to circumvent HidePatronName syspref In-Reply-To: <bug-33742-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33742-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33742-70-5pcLWzvu75@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33742 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:42:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 15:42:46 +0000 Subject: [Koha-bugs] [Bug 31557] Add ability for holds queue builder to prioritize either matching a patron's home library to the item's home or holding library In-Reply-To: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31557-70-xCETJi9A8Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I know I'm late, but shouldn't this look at pickup library rather than patron's home library? If the purpose was to limit transfers, pickup library should be prioritized. If patron has home library = A and the hold is pickup library = B, this will make the item with library A fill the hold, even if there is an item at library B. I'm wondering if this is by design or not. If not, I can open a new bug report. Just let me know. Caroline -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:54:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 15:54:14 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-Sv45C8M4HX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151303|0 |1 is obsolete| | --- Comment #61 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151308&action=edit Bug 30719: DB and API - Adds 'batch' accessor to Illrequest object - New illbatches and illbatch_statuses tables - New foreign key 'batch_id' in illrequests table - Atomic update file - Default illbatch_statuses - Add 'add' ill_requests api method - Add POST method in ill_requests path - Add 'batch_id property to ill_request api definition - Updated swagger.yml with new batches and batchstatuses endpoints Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:54:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 15:54:18 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-n11vgFg6Bd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151304|0 |1 is obsolete| | --- Comment #62 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151309&action=edit Bug 30719: ILL Batches - Add batch column to requests table - Establish if there are any availability or metadata enrichment plugins and pass that to the template - Verify if we have any backend that can support batches, if not, don't show the option - Updates to the ILL toolbar - New ILL batch modal - New Koha classes - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:54:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 15:54:22 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-rZL53ynrs3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151305|0 |1 is obsolete| | --- Comment #63 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151310&action=edit Bug 30719: ILL Batch Statuses - UI adding support for batch statuses in batch UI - Admin UI for managing batch statuses - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:54:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 15:54:25 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-4f76OExprR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151306|0 |1 is obsolete| | --- Comment #64 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151311&action=edit Bug 30719: Tests Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 17:54:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 15:54:28 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-u4YNfBSsIJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151307|0 |1 is obsolete| | --- Comment #65 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151312&action=edit Bug 30719: dbic specific, DONT PUSH -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 18:05:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 16:05:48 +0000 Subject: [Koha-bugs] [Bug 33528] Use template wrapper for tabs: Patron details page In-Reply-To: <bug-33528-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33528-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33528-70-iDv8RR0UA6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 18:05:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 16:05:51 +0000 Subject: [Koha-bugs] [Bug 33528] Use template wrapper for tabs: Patron details page In-Reply-To: <bug-33528-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33528-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33528-70-hNEnuZu5Ou@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151313&action=edit Bug 33528: Use template wrapper for tabs: Patron details page This patch updates the checkout and patron details templates so that they use the new WRAPPER directive to build tabbed navigation. The markup for the tab navigation and tab panels is moved into its own include file since the templates were duplicating essentially the same code. To fully test you should have patrons with checkouts, fines, holds, recalls, and article requests. Apply the patch and go to the checkout page in the staff interface. With each tab, test as much functionality as you can within that tab. - Checkouts - Holds - Recalls (with UseRecalls enabled) - Claims (with a LOST value defined in ClaimReturnedLostValue) - Restrictions - Article Requests (with ArticleRequests preference enabled) - Clubs (with at least one club defined) - Relatives' checkouts (patron must have a guarantee linked to their account). Perform the same tests on the patron details page. Note that the "Charges" tab is shown on the patron details page but not the checkout page. This is not a change made by this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 18:08:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 16:08:47 +0000 Subject: [Koha-bugs] [Bug 33528] Use template wrapper for tabs: Patron details page In-Reply-To: <bug-33528-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33528-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33528-70-4euONGvthy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Not expecting this to go into 23.05 but I thought I'd submit it in case someone can start testing it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 18:09:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 16:09:14 +0000 Subject: [Koha-bugs] [Bug 33528] Use template wrapper for tabs: Patron details and circulation In-Reply-To: <bug-33528-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33528-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33528-70-naeypuPAYK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use template wrapper for |Use template wrapper for |tabs: Patron details page |tabs: Patron details and | |circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 18:09:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 16:09:38 +0000 Subject: [Koha-bugs] [Bug 33527] Use template wrapper for tabs: Checkout page In-Reply-To: <bug-33527-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33527-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33527-70-FUQR3q5G9h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33527 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- *** This bug has been marked as a duplicate of bug 33528 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 18:09:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 16:09:38 +0000 Subject: [Koha-bugs] [Bug 33528] Use template wrapper for tabs: Patron details and circulation In-Reply-To: <bug-33528-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33528-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33528-70-cR4xDXHB7z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- *** Bug 33527 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 18:12:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 16:12:45 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-X4EA23DtHb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151302|0 |1 is obsolete| | --- Comment #33 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 151314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151314&action=edit Bug 33117: Adding new system preference for patron searching -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 18:17:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 16:17:29 +0000 Subject: [Koha-bugs] [Bug 25763] Allow update of order fund after receipt In-Reply-To: <bug-25763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25763-70-hiGAWd1uUB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 koha-US bug tracker <bugzilla at koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 18:42:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 16:42:53 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-mJ9dBXeZKV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/690 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 18:42:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 16:42:54 +0000 Subject: [Koha-bugs] [Bug 33739] ModItemTransfer triggers indexing twice In-Reply-To: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33739-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33739-70-daT9ifgKPB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33739 Bug 33739 depends on bug 31212, which changed state. Bug 31212 Summary: Datelastseen should be a datetime https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 18:50:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 16:50:29 +0000 Subject: [Koha-bugs] [Bug 32164] Add link to MARC modification templates from batch record modification page In-Reply-To: <bug-32164-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32164-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32164-70-O3AfXIbvBc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32164 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- No screenshot to update. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 18:51:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 16:51:24 +0000 Subject: [Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates In-Reply-To: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31479-70-7NATihbEOc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Nothing to add to the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 19:01:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 17:01:35 +0000 Subject: [Koha-bugs] [Bug 30621] Author should be its own column on opac-readingrecord.tt In-Reply-To: <bug-30621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30621-70-qSvmUJNyQd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30621 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/690 Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 19:14:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 17:14:35 +0000 Subject: [Koha-bugs] [Bug 33010] CheckinSlip doesn't return checkins if checkout branch and checkin branch differ In-Reply-To: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33010-70-zrCX6L4zMA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 19:22:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 17:22:55 +0000 Subject: [Koha-bugs] [Bug 33297] Typo system preference RetainPatronSearchTerms in DB revs 220600044.pl In-Reply-To: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33297-70-RZ6wEItAFL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33297 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #21 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #20) > I am not sure about "Wrong system preference 'RetainPatronSearchTerms' does > not exist" > > I would say: If nothing is wrong, then tell nothing. It could be confusing. Agreed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 19:38:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 17:38:32 +0000 Subject: [Koha-bugs] [Bug 33748] New: UI issue on addorderiso2709.pl page Message-ID: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Bug ID: 33748 Summary: UI issue on addorderiso2709.pl page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org How I recreated: 1. Set MarcItemFieldsToOrder like this: homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 975$8 notforloan: 975$7 quantity: 975$q price: 975$g replacementprice: 975$v uri: 975$u 2. Set MarcFieldsToOrder like this: price: 975$p quantity: 975$q budget_code: 975$h 3. Stage a MARC file that has bibs with items. 4. From acquisitions create a new basket and add 'From a staged file' Notices that the Item record X info is pushed to the left and the 'Match' label has a border running right through it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 19:39:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 17:39:51 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30358-70-MspcEXKJx5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #86 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Hi all. I'm willing to push a squashed version of this, because it's been hanging around for a while and it has an on/off switch and also (when squashed) seems like a small thing. I would've prefered more communication about this and a more QA eyes, because the chosen pattern is hard to accept in the current codebase (a static method on a not so related class). This should've been a Koha::RecordProcessor filter instead, as (a) This is not about Koha::Metadata::Record objects, but MARC::Record (b) that's what the Koha::RecordProcessor pattern is designed for. I will file a separate follow-up bug, and would like the authors to consider movign this code into a Koha::recordProcessor::Filter class. Happy to guide/help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 19:40:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 17:40:59 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-e2lCgMcj6N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 19:41:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 17:41:01 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-U3m0NKV1U1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151315&action=edit Bug 33748: Fix UI issue when importing records from a staged MARC file To test: 1. Set MarcItemFieldsToOrder like this: homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 975$8 notforloan: 975$7 quantity: 975$q price: 975$g replacementprice: 975$v uri: 975$u 2. Set MarcFieldsToOrder like this: price: 975$p quantity: 975$q budget_code: 975$h 3. Stage a MARC file that has bibs with items. 4. From acquisitions create a new basket and add 'From a staged file' 5. APPLY PATCH 6. Try 3 - 4 again, the display should now look correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 19:56:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 17:56:45 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-0IY59OKkyS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Attachment #150856|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 19:59:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 17:59:59 +0000 Subject: [Koha-bugs] [Bug 33599] Use template wrapper for breadcrumbs: Various In-Reply-To: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33599-70-qX56nfJDja@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:00:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:00:02 +0000 Subject: [Koha-bugs] [Bug 33599] Use template wrapper for breadcrumbs: Various In-Reply-To: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33599-70-wrp1T8VSpI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150192|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151316&action=edit Bug 33599: Use template wrapper for breadcrumbs: Various This patch updates various templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - ILL requests - New ill request - Manage ill request - Bibliographic record -> - Place hold - Place multiple holds - Tools -> - Comments awaiting moderation - Approved comments - Suggestions - New suggestion - View suggestion - Edit suggestion - Lists - Public Lists - Private lists - New list - Edit list - Transfer list - View list contents Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:08:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:08:08 +0000 Subject: [Koha-bugs] [Bug 33749] New: Move Koha::MetadataRecord::stripWhitespaceChars into a RecordProcessor filter Message-ID: <bug-33749-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 Bug ID: 33749 Summary: Move Koha::MetadataRecord::stripWhitespaceChars into a RecordProcessor filter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Bug 30358 introduced the static method Koha::MetadataRecord::stripWhitespaceChars. This method should've been put on a RecordProcessor filter. I open this bug for handling that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:08:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:08:34 +0000 Subject: [Koha-bugs] [Bug 33749] Move Koha::MetadataRecord::stripWhitespaceChars into a RecordProcessor filter In-Reply-To: <bug-33749-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33749-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33749-70-vX7Q51ldMG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Depends on| |30358 Status|NEW |ASSIGNED Severity|normal |enhancement Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:08:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:08:34 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30358-70-PyQ2HRzIaD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33749 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33749 [Bug 33749] Move Koha::MetadataRecord::stripWhitespaceChars into a RecordProcessor filter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:05 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30358-70-TEiBXPDQWo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:07 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30358-70-MFwoaj3hNv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 --- Comment #87 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:09 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-C4DV7i0Rov@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:11 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-LkAcUK7Ro7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 --- Comment #25 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:13 +0000 Subject: [Koha-bugs] [Bug 33158] Use template wrapper for authorized values and item types administration tabs In-Reply-To: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33158-70-wpwRdKnu00@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:15 +0000 Subject: [Koha-bugs] [Bug 33158] Use template wrapper for authorized values and item types administration tabs In-Reply-To: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33158-70-Pp512rwbni@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 --- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:17 +0000 Subject: [Koha-bugs] [Bug 33220] Recalls to pull should not show in transit or allocated items In-Reply-To: <bug-33220-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33220-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33220-70-zIJbQtMamg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33220 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:18 +0000 Subject: [Koha-bugs] [Bug 33220] Recalls to pull should not show in transit or allocated items In-Reply-To: <bug-33220-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33220-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33220-70-PpADX1AQHp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33220 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:20 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-BDIcEhuFWE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:22 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-238NshqrKx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 --- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:24 +0000 Subject: [Koha-bugs] [Bug 33297] Typo system preference RetainPatronSearchTerms in DB revs 220600044.pl In-Reply-To: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33297-70-Rimqy7rbHr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33297 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:26 +0000 Subject: [Koha-bugs] [Bug 33297] Typo system preference RetainPatronSearchTerms in DB revs 220600044.pl In-Reply-To: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33297-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33297-70-5hwAgZh0Du@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33297 --- Comment #22 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:28 +0000 Subject: [Koha-bugs] [Bug 33340] Correct formatting of English 1-page order PDF when the basket group covers multiple pages In-Reply-To: <bug-33340-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33340-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33340-70-oI1Sc4s2Pd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:30 +0000 Subject: [Koha-bugs] [Bug 33340] Correct formatting of English 1-page order PDF when the basket group covers multiple pages In-Reply-To: <bug-33340-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33340-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33340-70-PQRJW6M8Zc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:31 +0000 Subject: [Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion In-Reply-To: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33541-70-scfi8hSa6L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:33 +0000 Subject: [Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion In-Reply-To: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33541-70-y3rxxw0KOt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 --- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:35 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-glxTtrZyYs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:37 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-d5kh46yA90@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #24 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:39 +0000 Subject: [Koha-bugs] [Bug 33553] Unecessary GetCategories calls in template In-Reply-To: <bug-33553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33553-70-2QrTt9N5Lj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:41 +0000 Subject: [Koha-bugs] [Bug 33553] Unecessary GetCategories calls in template In-Reply-To: <bug-33553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33553-70-kdaYU5vfS4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:42 +0000 Subject: [Koha-bugs] [Bug 33599] Use template wrapper for breadcrumbs: Various In-Reply-To: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33599-70-hXVbOx6rcH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:44 +0000 Subject: [Koha-bugs] [Bug 33599] Use template wrapper for breadcrumbs: Various In-Reply-To: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33599-70-SeqScYfwUH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:46 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-qsaGpwd4Vq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:19:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:19:48 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-vagpXCIaMI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 --- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:53:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:53:37 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-7AP9WsJ5F7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151314|0 |1 is obsolete| | --- Comment #34 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 151317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151317&action=edit Bug 33117: Adding new system preference for patron searching -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 20:54:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 18:54:40 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-SYKliAPD11@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate --- Comment #34 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Can be backported. Let's push early next cycle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 21:28:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 19:28:48 +0000 Subject: [Koha-bugs] [Bug 33742] Add permission to circumvent HidePatronName syspref In-Reply-To: <bug-33742-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33742-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33742-70-t84gw064oc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33742 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 21:52:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 19:52:51 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-sl37JgJxyT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150960|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 21:52:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 19:52:54 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-2FQ1GFHWJb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150961|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 21:52:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 19:52:56 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-Dj2mMviQul@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150962|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 21:52:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 19:52:58 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-6cXCM1tRue@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151253|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 21:54:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 19:54:12 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-YzQtgmaB6g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #29 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151318&action=edit Bug 23336: Unit tests This patch adds unit tests for the new checkout availability endpoint we're going to introduce in this patchset. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 21:54:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 19:54:15 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-jcN4Br5GtB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #30 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151319&action=edit Bug 23336: Add checkout API's This patch adds API's to allow for a checkout flow using the RESTful API. We add an availability endpoint to check an items current availability status. The endpoint can be found at `/checkouts/availability` and is a GET request that requires item_id and patron_id passed as parameters. We return an availability object that includes blockers, confirms, warnings and a confirmation token to be used for checkout. We also add a corresponding checkout method to the `/checkouts` endpoint. The method accepts a POST request with checkout details including item_id , patron_id and the confirmation token in the body. Future work: We should properly migrate CanBookBeIssued into Koha::* and use that here instead of refering to C4::Circulation. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 21:54:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 19:54:19 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-mjPrJ3HUps@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #31 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151320&action=edit Bug 23336: Fix inconsistent return of AddIssue AddIssue can on occasion create a renewal instead of a fresh issue and in such a case we currently return undefined. We should be consistent and return the existing issue object for the renewal. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 21:54:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 19:54:22 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-P6jMn7wW37@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #32 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151321&action=edit Bug 23336: (follow-up) Switch to using Koha::Token Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 21:54:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 19:54:25 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-QNXO6CyZ7p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #33 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151322&action=edit Bug 23336: (QA follow-up) Some minor fixes This patch deals with some QA script warnings, and also makes some changes in line with bug 33556. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 21:57:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 19:57:21 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-fPMkq3xCp3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate Status|Passed QA |Failed QA --- Comment #34 from Tomás Cohen Arazi <tomascohen at gmail.com> --- I took some time to review this and added my two cents. Things to note: - There are a couple failing tests - I expected to see a use of check_jwt (at least) in the tests - Maybe the Koha::Token use on bug 33675 might be of help (I used the session id for the token id, etc) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 22:03:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 20:03:21 +0000 Subject: [Koha-bugs] [Bug 32613] Can we add 'autocompletion' to our SQL reports editor? In-Reply-To: <bug-32613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32613-70-Q9SlOuDcGu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32613 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED Documentation|Aude Charillon |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/690 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 22:07:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 20:07:34 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-Uq9UIuhfd8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #2 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- The patch did help improve the style but I see several issues: In 22.05 the data for Item record 1, item record 2, etc. displayed on the right side of the screen. It was nice to be able to visually connect the item data with the order data displayed directly to the left. It also makes good use of screen real estate and decreases the amount of scrolling down to the bottom in order to save. In 22.05 if there was no matching record nothing was displayed. In 22.11 the word Match: displays with no additional info since there is no match. It seems like this is extraneous and should be removed for non-matches. I attached two screenshots for the display in 22.05 and two for how it is now displaying in 22.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 22:09:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 20:09:30 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-26Q6NcQEfx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #3 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- Created attachment 151323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151323&action=edit 22.05 match -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 16 22:09:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 20:09:51 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-267HKuWrUD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #4 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- Created attachment 151324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151324&action=edit 22.05 no match -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 16 22:10:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 20:10:12 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-WIXaSuHLxb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #5 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- Created attachment 151325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151325&action=edit 22.11 style match -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 22:10:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 20:10:35 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-LwUfVZTMna@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #6 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- Created attachment 151326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151326&action=edit 22.11 style no match -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 16 22:13:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 20:13:24 +0000 Subject: [Koha-bugs] [Bug 32613] Add auto-completion to our SQL reports editor In-Reply-To: <bug-32613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32613-70-9qjBsUCgTO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32613 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can we add 'autocompletion' |Add auto-completion to our |to our SQL reports editor? |SQL reports editor Text to go in the| |This adds an auto-complete release notes| |feature to the SQL reports | |editor. This works for | |tables and columns. For | |columns you'll need to | |start with the table name, | |like 'borrowers.'. The | |editor will then suggest | |the columns of the | |borrowers table. The | |auto-complete feature will | |also work when tables have | |been renamed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 22:13:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 20:13:50 +0000 Subject: [Koha-bugs] [Bug 32613] Add auto-completion to our SQL reports editor In-Reply-To: <bug-32613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32613-70-kSMc1wM50Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32613 --- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Super nice feature, looking forward to using it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 23:27:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 21:27:03 +0000 Subject: [Koha-bugs] [Bug 33624] Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed In-Reply-To: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33624-70-DEJhRQrRMO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 23:27:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 21:27:06 +0000 Subject: [Koha-bugs] [Bug 33624] Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed In-Reply-To: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33624-70-QKpNDqQzHV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151072|0 |1 is obsolete| | --- Comment #6 from Phil Ringnalda <phil at chetcolibrary.org> --- Created attachment 151327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151327&action=edit Bug 33624: Hide the "list" tab if authority is selected The "Select a list of records" should only be available for biblio records. But if the page is accessed using the back button of the browser it will be displayed for authorities as well. Test plan: - Make sure you have at least one template for MARC Modification - Also make sure you have at least one list of biblio records - navigate to Cataloging -> Batch record modification - Check the "Authorities" radio button - Select your template and continue - No records were modified -> use your browser's Back button to go back one page - The "Authorities" radio button should still be selected => Without this patch you see the tab "Select a list of records" => With this patch applied it's hidden when the page is loaded Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 23:27:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 21:27:18 +0000 Subject: [Koha-bugs] [Bug 33624] Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed In-Reply-To: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33624-70-iiN6MDMxQc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil at chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 23:39:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 21:39:41 +0000 Subject: [Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl In-Reply-To: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33722-70-kJsz17bwQx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 23:39:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 21:39:44 +0000 Subject: [Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl In-Reply-To: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33722-70-sOqHsHxZYP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151107|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 151328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151328&action=edit Bug 33722: Make public lists viewable for users on virtualshelves/addbybiblionumber.pl To test: 1. Have two users with staff access and lists permissions. ( User A and User B) 2. Create some public lists with User A. Make some that are for staff only and some for everyone. 3. Make sure you create at least 10 different public lists. 4. Log in to the staff interface as user B and search the catalog. 5. Select a few titles and in the toolbar click 'Add to list'. 6. Here you should properly see your lists and any public lists which you can edit. 7. If you have more than 10 lists you won't see them all in this dropdown. 8. At the bottom of the dropdown you should see 'More lists', click it. 9. Notice here you cannot select any of the existing public lists which User B should be able to edit. 10. APPLY PATCH 11. Repeate steps 5 - 8. Now you should be able to edit public lists. 12. Create some private lists with User A and make sure User B cannot see them. 13. PLay with some new lists for User A and change 'Allow changes to contents from' and make sure User B can see the ones they should. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 16 23:45:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 21:45:01 +0000 Subject: [Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl In-Reply-To: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33722-70-SIWZY888D2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind <david at davidnind.com> --- The only thing I noticed was that you can choose to make a list Private and choose Nobody for allow changes to content. You then lose access to the list, and even a super librarian can't see it. This is also the case in master, so I think this is a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 00:21:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 22:21:45 +0000 Subject: [Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl In-Reply-To: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33722-70-zFri9lw6Vx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to David Nind from comment #3) > The only thing I noticed was that you can choose to make a list Private and > choose Nobody for allow changes to content. > > You then lose access to the list, and even a super librarian can't see it. > > This is also the case in master, so I think this is a separate bug. I fail to see the point of the nobody option, for either public or private lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 01:03:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 23:03:17 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-fns7VEtQcJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151315|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151329&action=edit Bug 33748: Fix UI issue when importing records from a staged MARC file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 01:03:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 23:03:47 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-Q7FJZit1wv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- Barbara, Can you test my new patch? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 01:43:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 23:43:10 +0000 Subject: [Koha-bugs] [Bug 33750] New: Expiration warnings Message-ID: <bug-33750-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33750 Bug ID: 33750 Summary: Expiration warnings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Does SIP response on login give any fore warning of account or password expiration? Seems like it should, if it doesn't. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 01:45:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 23:45:18 +0000 Subject: [Koha-bugs] [Bug 33751] New: Notice needed for password expiration Message-ID: <bug-33751-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33751 Bug ID: 33751 Summary: Notice needed for password expiration Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org It would be good customer service to give some fore warning to the patron that their password is going to expire soon, just like we do with account expirations. It would also be good to remind them when the password has expired. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 01:48:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 23:48:26 +0000 Subject: [Koha-bugs] [Bug 33752] New: Password expiration warning Message-ID: <bug-33752-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33752 Bug ID: 33752 Summary: Password expiration warning Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Patron should see a warning that their password is expiring soon, just like they do with the account expiration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 01:49:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 May 2023 23:49:35 +0000 Subject: [Koha-bugs] [Bug 33753] New: Password expiration warning Message-ID: <bug-33753-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33753 Bug ID: 33753 Summary: Password expiration warning Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Staff should see a warning that the patron's password is expiring soon, just like with account expirations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 02:15:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 00:15:31 +0000 Subject: [Koha-bugs] [Bug 26777] Give the user the option to display their patron card barcode from the OPAC In-Reply-To: <bug-26777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26777-70-5ayZKY0JQx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #12 from David Cook <dcook at prosentient.com.au> --- (In reply to Martin Renvoize from comment #11) > https://codelabs.developers.google.com/add-to-wallet-android#0 is > interesting too Ohhh very interesting. That would be a very cool feature. I think I'll raise a ticket for that. It's not something most of our libraries would use, but as a library user I would love to have this... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 02:23:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 00:23:12 +0000 Subject: [Koha-bugs] [Bug 25332] Add library card to smart phone wallet In-Reply-To: <bug-25332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25332-70-lfZr0YY2wu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25332 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add library card to iPhone |Add library card to smart |wallet |phone wallet CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 02:23:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 00:23:36 +0000 Subject: [Koha-bugs] [Bug 26777] Give the user the option to display their patron card barcode from the OPAC In-Reply-To: <bug-26777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26777-70-JLMXCW3juQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #13 from David Cook <dcook at prosentient.com.au> --- See Bug 25332 for talk about adding a library card to a smart phone wallet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 02:36:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 00:36:53 +0000 Subject: [Koha-bugs] [Bug 25332] Add library card to smart phone wallet In-Reply-To: <bug-25332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25332-70-Ncr3sIvgh7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25332 --- Comment #3 from David Cook <dcook at prosentient.com.au> --- (In reply to Owen Leonard from comment #2) > I'm pretty sure you'd have to have an app installed on the iPhone which > would interface with the OS's wallet system. Perhaps someone with some app > development experience could confirm. You don't need an app to add to the Apple Wallet. Servers send cryptographically signed compressed packages to the user who can add the package to their phone's wallet as a pass. The tricky bit with Apple is that the signature needs to be done using a key from an Apple developer account. I don't think we'd want to do this at a community level; I think it would need to be done at an institutional/organisational level. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 02:37:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 00:37:14 +0000 Subject: [Koha-bugs] [Bug 25332] Add library card to smart phone wallet In-Reply-To: <bug-25332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25332-70-XswgJpopUu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25332 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- For the Google Wallet, Martin provided the following link: https://codelabs.developers.google.com/add-to-wallet-android#0 I haven't reviewed it though. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 03:10:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 01:10:38 +0000 Subject: [Koha-bugs] [Bug 25332] Add library card to smart phone wallet In-Reply-To: <bug-25332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25332-70-Zta2MJRqwS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25332 --- Comment #5 from David Cook <dcook at prosentient.com.au> --- Looks like the Apple Developer program costs at least 99 USD, although a library might be able to get a fee waiver... https://help.passkit.com/en/articles/2010098-why-do-i-need-an-apple-developer-account -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 03:11:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 01:11:25 +0000 Subject: [Koha-bugs] [Bug 25332] Add library card to smart phone wallet In-Reply-To: <bug-25332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25332-70-bOH2bqLbo1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25332 --- Comment #6 from David Cook <dcook at prosentient.com.au> --- Note that this could be an interesting Koha plugin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 03:12:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 01:12:57 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-2TtMXFmhrX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #7 from David Cook <dcook at prosentient.com.au> --- (In reply to Jonathan Druart from comment #6) > That is totally outside the scope of this bug. Sure although it'll relate in the future one hopes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 03:23:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 01:23:23 +0000 Subject: [Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16826-70-pemymRgMpf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 --- Comment #57 from David Cook <dcook at prosentient.com.au> --- (In reply to Martin Renvoize from comment #56) > I took a short cut to add an availability endpoint in bug 23336 but I'd love > to see a more thorough treatment done longer term. The availability code > needs a cleanup along the lines of what NatLibFi do I believe but I didn't > have the sponsorship to go the distance that way. I've been wondering a bit if the word "availability" means different things to different people as well. For me, I'm interested in the "Status" message that we see on the OPAC. Is that the same thing needed for the checkout or is it a bit different? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 03:54:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 01:54:02 +0000 Subject: [Koha-bugs] [Bug 17921] Shelf Browser does not take OpacSuppression or OpacHiddenItems into consideration In-Reply-To: <bug-17921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17921-70-J1NImMuopx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17921 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- I have a local customization for this that I should really upstream one day... Although that customization is old and uses a naive/brute force approach. I have better ways of handling OpacHiddenItems these days using SQL::Abstract to write better SQL queries... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 04:14:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 02:14:28 +0000 Subject: [Koha-bugs] [Bug 17921] Shelf Browser does not take OpacSuppression or OpacHiddenItems into consideration In-Reply-To: <bug-17921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17921-70-kba25Cib0E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17921 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Oh I forgot about this one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 06:35:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 04:35:13 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31856-70-VH7S3DtfyZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 06:35:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 04:35:22 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-vZJK0snLkq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 06:35:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 04:35:27 +0000 Subject: [Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods In-Reply-To: <bug-32476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32476-70-YUpRIBVL8Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 06:35:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 04:35:31 +0000 Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm In-Reply-To: <bug-32496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32496-70-1cH6tKBiWr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 08:49:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 06:49:29 +0000 Subject: [Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability In-Reply-To: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16826-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16826-70-tcAw93uqDx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 --- Comment #58 from David Cook <dcook at prosentient.com.au> --- (In reply to David Cook from comment #55) > I'd love to revisit this. > > For now, I'm planning to look at > https://github.com/NatLibFi/koha-plugin-rest-di since the folk in Finland > have been kind enough to make their work available there! I've just been talking to Ere on Zoom. I'm going to use the plugin API for now while I do a demo for a library, and if that goes well, then I'd be interested in working with Ere and anyone else (Tomas? Martin?) who want to help move this into core Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 08:49:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 06:49:53 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-EAvDBJJ3YL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 --- Comment #35 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Laura, let me know if you need help here. I would suggest to use strings as codes for the syspref, 'start_with' and 'contains', instead of a boolean value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 08:50:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 06:50:12 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-4BFk207UMl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 --- Comment #36 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- * use strings instead of codes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 09:25:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 07:25:42 +0000 Subject: [Koha-bugs] [Bug 25332] Add library card to smart phone wallet In-Reply-To: <bug-25332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25332-70-PegHV1pVwa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25332 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 10:59:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 08:59:01 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_32884=5D_Advanced_Editor_=28rancor?= =?utf-8?q?=29_don=C2=B4t_work_after_21=2E11=2E17_upgrade?= In-Reply-To: <bug-32884-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32884-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32884-70-xCl2xsHB8H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32884 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 33318 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 10:59:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 08:59:01 +0000 Subject: [Koha-bugs] [Bug 33318] [21.11] Advanced editor doesn't load In-Reply-To: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33318-70-AGJSYCLKwQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33318 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paliotti at mdp.edu.ar --- Comment #7 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- *** Bug 32884 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 11:42:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 09:42:52 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-QMXKfLtHBP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Remote branch rebased and a couple of fixes added. Setting status to Needs Signoff, this is ready to get feedback from testers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 11:43:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 09:43:12 +0000 Subject: [Koha-bugs] [Bug 33746] [omnibus] speed improvement In-Reply-To: <bug-33746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33746-70-mJdqjaHh8i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|26802, 31856, 32060, 32476, | |32496, 33568, 33745 | Depends on| |26802, 31856, 32060, 32476, | |32496, 33568, 33745 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26802 [Bug 26802] Improve speed with records with many items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 [Bug 31856] Improve performance of serials subscriptions search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 [Bug 32060] Improve performance of Koha::Item->columns_to_str https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476 [Bug 32476] Add caching for relatively expensive patron methods https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the biblio detail view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 [Bug 33745] Speed up Koha::Object attribute accessors -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 11:43:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 09:43:12 +0000 Subject: [Koha-bugs] [Bug 26802] Improve speed with records with many items In-Reply-To: <bug-26802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26802-70-mWSly0G6a8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26802 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33746 Depends on|33746 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 [Bug 33746] [omnibus] speed improvement -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 11:43:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 09:43:12 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31856-70-c8UVJV2ZJ8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33746 Depends on|33746 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 [Bug 33746] [omnibus] speed improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 11:43:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 09:43:12 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-yZOW9n7ch1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33746 Depends on|33746 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 [Bug 33746] [omnibus] speed improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 11:43:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 09:43:12 +0000 Subject: [Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods In-Reply-To: <bug-32476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32476-70-EwIx8JAaUk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33746 Depends on|33746 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 [Bug 33746] [omnibus] speed improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 11:43:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 09:43:12 +0000 Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm In-Reply-To: <bug-32496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32496-70-00sL6xxd0B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33746 Depends on|33746 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 [Bug 33746] [omnibus] speed improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 11:43:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 09:43:12 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-mEK3aa000a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33746 Depends on|33746 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 [Bug 33746] [omnibus] speed improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 11:43:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 09:43:12 +0000 Subject: [Koha-bugs] [Bug 33745] Speed up Koha::Object attribute accessors In-Reply-To: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33745-70-O0S8Ca6wo5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33746 Depends on|33746 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 [Bug 33746] [omnibus] speed improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 12:24:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 10:24:17 +0000 Subject: [Koha-bugs] [Bug 33752] Password expiration warning In-Reply-To: <bug-33752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33752-70-g8ferMEryD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33752 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- *** Bug 33753 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 12:24:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 10:24:17 +0000 Subject: [Koha-bugs] [Bug 33753] Password expiration warning In-Reply-To: <bug-33753-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33753-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33753-70-uu8CBQzhqe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33753 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- *** This bug has been marked as a duplicate of bug 33752 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 13:21:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 11:21:00 +0000 Subject: [Koha-bugs] [Bug 30024] link_bibs_to_authorities.pl relies on CatalogModuleRelink In-Reply-To: <bug-30024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30024-70-SKmwU6nPKr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30024 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Please provide feedback -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 13:26:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 11:26:31 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31391-70-oEGjc86Vbm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate |rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 13:35:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 11:35:08 +0000 Subject: [Koha-bugs] [Bug 33624] Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed In-Reply-To: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33624-70-bDrMix1wQD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- I dont understand what this patch actually is supposed to solve. If the list is not displayed but still contains the numbers entered, why hide it ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 13:37:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 11:37:03 +0000 Subject: [Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl In-Reply-To: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33722-70-WuHN7GRlTj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Lucas Gass from comment #4) > (In reply to David Nind from comment #3) > > The only thing I noticed was that you can choose to make a list Private and > > choose Nobody for allow changes to content. > > > > You then lose access to the list, and even a super librarian can't see it. > > > > This is also the case in master, so I think this is a separate bug. > > I fail to see the point of the nobody option, for either public or private > lists. Did its behavior change? The intention is to not allow *changes*. Not to hide it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 13:57:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 11:57:17 +0000 Subject: [Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl In-Reply-To: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33722-70-JFrho0NQCU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #5) > (In reply to Lucas Gass from comment #4) > > (In reply to David Nind from comment #3) > > > The only thing I noticed was that you can choose to make a list Private and > > > choose Nobody for allow changes to content. > > > > > > You then lose access to the list, and even a super librarian can't see it. > > > > > > This is also the case in master, so I think this is a separate bug. > > > > I fail to see the point of the nobody option, for either public or private > > lists. > > Did its behavior change? The intention is to not allow *changes*. Not to > hide it. Yes, this definitely is a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:02:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 12:02:40 +0000 Subject: [Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl In-Reply-To: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33722-70-aNXy20c2mc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Even if it allow changes from owner, I should see it in the public lists of opac and on the staff view, but I dont. Things got messed up in this area. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:04:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 12:04:40 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30418-70-dN43tOLkwP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #37 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Hmm We have problems with permissions now. Could this one be the cause? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:09:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 12:09:45 +0000 Subject: [Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl In-Reply-To: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33722-70-d350p0qhjw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30418 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:09:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 12:09:45 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30418-70-wd3bwiYj9u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33722 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:10:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 12:10:02 +0000 Subject: [Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl In-Reply-To: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33722-70-2EXqVfsm7p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #7) > Even if it allow changes from owner, I should see it in the public lists of > opac and on the staff view, but I dont. > Things got messed up in this area. Bug 30418 perhaps ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:21:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 12:21:18 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: <bug-24172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24172-70-4tiKCizrvO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148921|0 |1 is obsolete| | --- Comment #44 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151330&action=edit Bug 24172: Allow translation of seasons in serials-edit.tt and subscription-detail.tt Seasons are not handled by locales. Those generated are stored in English in the database, and the display in serials-collection.tt is translating them. But once you click on "Edit serials" or if you go straight to the subscription's display, those are displayed as in the database: in English. This patch reproduces the same trick as in serial-collection.tt and allow for the display to be translated. NOTE: this patch's testing require knowledge of translation tools. Reproducing Caroline's test: 0- Make sure you have at least one language other than English installed 1- With staff interface in English, create a subscription with a seasonal numbering pattern and frequency, with locale in your other language 2- Check the prediction pattern, note that the season names are in English not the locale language 3- Change the staff interface to other language, redo the prediction pattern test with locale in other language, note that the season names are in other language 4- Save the subscription 5- Receive an issue, note that the season name in the "Numbered" column on serials-edit.pl is in English 6- Save your issue 7- Switch interface in other language 8- Note that the season name on serials-collection is in other language 9- If you check the database, you will see the season name is in English, even though the subscription.locale is something else 10- validate the different pages: - serials-collection.pl: display is translated - serials-edit.pl: name pulled directly from db - subscription-detail.pl: name pulled directly from db - detail.pl: name pulled directly from db - opac-detail.pl: name pulled directly from db 11- APPLY THE PATCH 12- translate the string a) ./translate update <some locale> b) find the strings, translate them c) ./translate install <same locale> 13- restart Plack ? 14- validate the pages again. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Bug 24172: Allow translation of seasons in details.tt and opac-details.tt Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Bug 24172: Move duplicated code to an include file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:24:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 12:24:03 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30418-70-JXermOk8YH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #38 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #37) > Hmm We have problems with permissions now. Could this one be the cause? Still looking btw -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:25:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 12:25:43 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue .js and .ts files In-Reply-To: <bug-33625-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33625-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33625-70-9lvzxrfYDB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151331&action=edit Bug 33625: Adjust test to deal with cypress tests Cypress test files were ignored. This patch also deals with files in git index only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:25:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 12:25:46 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue .js and .ts files In-Reply-To: <bug-33625-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33625-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33625-70-W6LMVIZN5s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151332&action=edit Bug 33625: Tidy remaining cypress test files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:25:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 12:25:55 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue .js and .ts files In-Reply-To: <bug-33625-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33625-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33625-70-M4OqE6uGdq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:30:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 12:30:24 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-Tal2637xdV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151276|0 |1 is obsolete| | Attachment #151277|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151333&action=edit Bug 33606: Add a erm/config route to retrieve the ERM config needed for the Vue app This could be extended later in bug 32968 to pass the permission of the logged in user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:30:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 12:30:27 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-SwgtK66qH6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151334&action=edit Bug 33606: Mark the endpoint as experimental -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:34:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 12:34:30 +0000 Subject: [Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl In-Reply-To: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33722-70-Bpn9RwkG0X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to David Nind from comment #3) > The only thing I noticed was that you can choose to make a list Private and > choose Nobody for allow changes to content. > > You then lose access to the list, and even a super librarian can't see it. > > This is also the case in master, so I think this is a separate bug. I thought that I saw it too. But cannot reproduce anymore now somehow. Could you give the exact steps to reproduce? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:40:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 12:40:06 +0000 Subject: [Koha-bugs] [Bug 33624] Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed In-Reply-To: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33624-70-H9ojpIWimC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:40:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 12:40:09 +0000 Subject: [Koha-bugs] [Bug 33624] Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed In-Reply-To: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33624-70-ytyQ6A1O5o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151327|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151335&action=edit Bug 33624: Hide the "list" tab if authority is selected The "Select a list of records" should only be available for biblio records. But if the page is accessed using the back button of the browser it will be displayed for authorities as well. Test plan: - Make sure you have at least one template for MARC Modification - Also make sure you have at least one list of biblio records - navigate to Cataloging -> Batch record modification - Check the "Authorities" radio button - Select your template and continue - No records were modified -> use your browser's Back button to go back one page - The "Authorities" radio button should still be selected => Without this patch you see the tab "Select a list of records" => With this patch applied it's hidden when the page is loaded Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:40:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 12:40:32 +0000 Subject: [Koha-bugs] [Bug 33624] Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed In-Reply-To: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33624-70-ZOAanFgSYJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:43:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 12:43:01 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-J6MLMKw2Kf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Checkbox selection should be preserve when a new request is made (pagination, filtering, etc.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 14:57:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 12:57:56 +0000 Subject: [Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl In-Reply-To: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33722-70-9E6xAZigZV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- - [% IF private_shelves_shared_with_me.count %] - <optgroup label="Private lists shared with me"> - [% FOREACH private_shelf IN private_shelves_shared_with_me %] - <option value="[% private_shelf.shelfnumber | html %]">[% private_shelf.shelfname | html %]</option> - [% END %] - </optgroup> - [% END %] We loose the separate display of shared lists. We still have in OPAC. I think we should keep that distinction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:01:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:01:48 +0000 Subject: [Koha-bugs] [Bug 33735] Misspelling in SMS provier In-Reply-To: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33735-70-ERak8fv4FC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33735 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- >From POD Static method that returns a hashref with mappings from column names to descriptions, for several tables. Currently => Seems like it was typed at 5 o'clock ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:02:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:02:20 +0000 Subject: [Koha-bugs] [Bug 33735] Misspelling in SMS provier In-Reply-To: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33735-70-if53lDoKal@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33735 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:02:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:02:22 +0000 Subject: [Koha-bugs] [Bug 33735] Misspelling in SMS provier In-Reply-To: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33735-70-3FpiD77FP5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33735 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151231|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151336&action=edit Bug 33735: Misspelling in SMS provier Correct spelling error: "provier" -> "provider" This change is a one-character edit, I think visual inspection of the patch is sufficient testing. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:02:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:02:37 +0000 Subject: [Koha-bugs] [Bug 33735] Misspelling in SMS provier In-Reply-To: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33735-70-c5DFXSO5f7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33735 --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Just before string freeze -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:02:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:02:43 +0000 Subject: [Koha-bugs] [Bug 33735] Misspelling in SMS provier In-Reply-To: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33735-70-URTDcITrUA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33735 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:08:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:08:13 +0000 Subject: [Koha-bugs] [Bug 32613] Add auto-completion to our SQL reports editor In-Reply-To: <bug-32613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32613-70-noh7j1Dtcz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32613 Aude Charillon <aude.charillon at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|aude.charillon at ptfs-europe. | |com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:25:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:25:34 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-z2hRdlLpGr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:25:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:25:36 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-ARV1v8ujB1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #50 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:25:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:25:58 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue .js and .ts files In-Reply-To: <bug-33625-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33625-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33625-70-YDbxQXpvGH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Follow-ups pushed. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:28:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:28:16 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-25IuGBvUaQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://www.oauth.com/oauth |https://www.oauth.com/oauth |2-servers/accessing-data/au |2-servers/accessing-data/au |thorization-request/ |thorization-request/ | |https://wiki.koha-community | |.org/wiki/Testing_SSO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:28:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:28:34 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-35AeO8lRDn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://www.oauth.com/oauth |https://www.oauth.com/oauth |2-servers/accessing-data/au |2-servers/accessing-data/au |thorization-request/ |thorization-request/ |https://wiki.koha-community | |.org/wiki/Testing_SSO | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:29:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:29:01 +0000 Subject: [Koha-bugs] [Bug 33247] Deleted authority still on results list In-Reply-To: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33247-70-US56Bgycvg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- This does not cover cases where another user just removed an authority before it got reindexed. So it feels like a partial solution. Should we build the list from the database, or just live with the time frame between action and reindex? Instead of marking it as pending deletion, I would suggest to not display it since it was deleted after all. Please provide feedback why the current solution is better than doing that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:29:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:29:09 +0000 Subject: [Koha-bugs] [Bug 33247] Deleted authority still on results list In-Reply-To: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33247-70-K7nlzKU56H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:29:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:29:19 +0000 Subject: [Koha-bugs] [Bug 33624] Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed In-Reply-To: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33624-70-CNeZaGPsei@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:29:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:29:21 +0000 Subject: [Koha-bugs] [Bug 33624] Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed In-Reply-To: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33624-70-WXBKDlKDoC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:29:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:29:23 +0000 Subject: [Koha-bugs] [Bug 33735] Misspelling in SMS provier In-Reply-To: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33735-70-RMIflqfh5d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33735 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:29:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:29:25 +0000 Subject: [Koha-bugs] [Bug 33735] Misspelling in SMS provier In-Reply-To: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33735-70-Bq8fNGIej8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33735 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:33:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:33:40 +0000 Subject: [Koha-bugs] [Bug 33247] Deleted authority still on results list In-Reply-To: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33247-70-PZ7HlS4Y7N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Phil Ringnalda from comment #4) > We actually already have a dirty indication of deleted records if your > search didn't specify an authority type, since in that case we can't look up > the authority type to display it above the heading in the search results. So > already-deleted headings are the ones with a slightly shorter row because > they don't have the authority type part of the display. Do not understand this argument. I removed a PERSO_NAME record. It is marked with Pending deletion, but I still see the heading type Personal name. Or do you mean something else ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:38:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:38:59 +0000 Subject: [Koha-bugs] [Bug 33713] Report batch operations should open in new tab In-Reply-To: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33713-70-fzpdrntGy4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33713 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:39:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:39:01 +0000 Subject: [Koha-bugs] [Bug 33713] Report batch operations should open in new tab In-Reply-To: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33713-70-QUkUnVo6PC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33713 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151159|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151337&action=edit Bug 33713: Make batch operations from report results open in new tab To test: 1. Have some reports that can do the following batch operations: -Batch patron mod -Batch item deletion -Batch add to list -Batch item mod -Batch record delection -Batch record mod 2. Run the report ann click 'Batch operations with X visible records', make sure each batch op opens in a new tab. These two simple reports should allow you to test each of the batch cases: select * from items limit 1 select * from borrowers limit 1 Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:39:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:39:14 +0000 Subject: [Koha-bugs] [Bug 33713] Report batch operations should open in new tab In-Reply-To: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33713-70-N4ezyBYG5u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33713 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:53:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:53:48 +0000 Subject: [Koha-bugs] [Bug 33421] Filtering purchase suggestions by status does not work if All Libraries is selected In-Reply-To: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33421-70-0obpNQeDAK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33421 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:53:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:53:50 +0000 Subject: [Koha-bugs] [Bug 33421] Filtering purchase suggestions by status does not work if All Libraries is selected In-Reply-To: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33421-70-tNffCcHvC3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33421 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151076|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151338&action=edit Bug 33421: Fix filtering suggestions by status If the display is by status and a specific status is selected in the filter, the filter won't have any effects. Test plan: Create several suggestions, with different status, for different libraries. Use the "display by status" view and filter on a given status => Result must be relevant Signed-off-by: Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:54:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:54:17 +0000 Subject: [Koha-bugs] [Bug 33247] Deleted authority still on results list In-Reply-To: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33247-70-Z4gnMxCoek@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Marcel de Rooy from comment #6) > Instead of marking it as pending deletion, I would suggest to not display it > since it was deleted after all. Please provide feedback why the current > solution is better than doing that. Easy and simple to implement, that was my only motivation to try to resolve this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:54:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:54:26 +0000 Subject: [Koha-bugs] [Bug 33247] Deleted authority still on results list In-Reply-To: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33247-70-h05G0ljQcZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha at gmail. |koha-bugs at lists.koha-commun |com |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:54:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:54:41 +0000 Subject: [Koha-bugs] [Bug 33421] Filtering purchase suggestions by status does not work if All Libraries is selected In-Reply-To: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33421-70-iqKQXUcbOO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33421 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:55:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:55:19 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-Vfws18QU0c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151339&action=edit Bug 33568: Preserve item selection across pagination and filtering BTW Do we really need StaffDetailItemSelection? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:56:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:56:18 +0000 Subject: [Koha-bugs] [Bug 33247] Deleted authority still on results list In-Reply-To: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33247-70-7ZXdeUqLnX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #8) > (In reply to Marcel de Rooy from comment #6) > > Instead of marking it as pending deletion, I would suggest to not display it > > since it was deleted after all. Please provide feedback why the current > > solution is better than doing that. > > Easy and simple to implement, that was my only motivation to try to resolve > this bug. Would it be so hard to hide a row instead of marking it with an additional string then? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:58:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:58:00 +0000 Subject: [Koha-bugs] [Bug 33444] AddRenewal should take a hash of parameters In-Reply-To: <bug-33444-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33444-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33444-70-nrs9nzxUql@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33444 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Feels like an enh ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 15:58:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 13:58:12 +0000 Subject: [Koha-bugs] [Bug 33444] AddRenewal should take a hash of parameters In-Reply-To: <bug-33444-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33444-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33444-70-LzsFel7cnJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33444 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 16:04:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 14:04:21 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-lR3kyBbgiC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 16:04:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 14:04:24 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-AiDS6BmHwS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151178|0 |1 is obsolete| | Attachment #151179|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151340&action=edit Bug 33686: Update plugin unimarc_field_100.pl with 2022 values According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 16:04:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 14:04:27 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-WSbCQFwuOt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151341&action=edit Bug 33686: Correction of existing terms related to 'Script of title' According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 16:09:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 14:09:49 +0000 Subject: [Koha-bugs] [Bug 29522] Bib record not correctly updated when merging identical authorities with LinkerModule set to First Match In-Reply-To: <bug-29522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29522-70-WfiYmkfOXj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29522 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 16:17:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 14:17:54 +0000 Subject: [Koha-bugs] [Bug 32029] Automatic item modifications by age missing biblio table In-Reply-To: <bug-32029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32029-70-Icp5IzYrIi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32029 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Please add some tests to t/db_dependent/Items/AutomaticItemModificationByAge.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 16:20:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 14:20:52 +0000 Subject: [Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order In-Reply-To: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33721-70-X85cLm8WcZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 16:20:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 14:20:54 +0000 Subject: [Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order In-Reply-To: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33721-70-D84SzPEjyj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151177|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151342&action=edit Bug 33721: Fix display of shipping cost/fund on invoice summary page When viewing an invoice, the elements in the 'Fund' line were out of order: 'Fund:' label, followed by 'Show inactive:' label, then the fund drop-down and then the show inactive checkbox. The order should be: 'Fund:' label, fund drop-down, 'Show inactive:' label, show inactive checkbox. This copies the markup that is used when you click on "Receive shipment". It also changes 'Fund' to 'Shipping fund' to bring the forms even more in line. To recreate: 1. In acquisitions, create an order and close the basket 2. Click 'Receive shipment' and receive the order 3. Click 'Finish receiving' --> The Fund line in invoice.tt is out of order 4. Apply patch 5. Verify the order is now fixed Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 16:21:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 14:21:03 +0000 Subject: [Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order In-Reply-To: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33721-70-dtE3BxwOJc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 16:27:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 14:27:33 +0000 Subject: [Koha-bugs] [Bug 33246] itemBarcodeFallbackSearch search results should show whether or not items are available In-Reply-To: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33246-70-kzK0XSXlKr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33246 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 16:27:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 14:27:35 +0000 Subject: [Koha-bugs] [Bug 33246] itemBarcodeFallbackSearch search results should show whether or not items are available In-Reply-To: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33246-70-8L4N60rzhi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33246 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151172|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151343&action=edit Bug 33246: Show the onloan status on the BarcodeFallbackSearch result Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 16:27:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 14:27:38 +0000 Subject: [Koha-bugs] [Bug 33246] itemBarcodeFallbackSearch search results should show whether or not items are available In-Reply-To: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33246-70-Ei9e9alkYO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33246 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151173|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151344&action=edit Bug 33246: Add some space between icon and text when there is only one result When there is only one result line, the text "Checked out" would show directly after the icon at the end of the title. This makes sure there will always be a little space between them. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 16:28:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 14:28:08 +0000 Subject: [Koha-bugs] [Bug 33246] itemBarcodeFallbackSearch search results should show whether or not items are available In-Reply-To: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33246-70-CHLURlL24R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33246 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- + [% IF item.onloan %]<span style="float: right; color: red; margin-left:5px;">Checked out</span>[% END %] So glad we have css files, LOL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 16:30:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 14:30:20 +0000 Subject: [Koha-bugs] [Bug 8838] Digest option for HOLD notice In-Reply-To: <bug-8838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8838-70-PXL40HJxxs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 blawlor at clamsnet.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor at clamsnet.org --- Comment #21 from blawlor at clamsnet.org --- A digest for Holds Pickup notices would also help with the issue of getting rate limited by email providers like Google. Patrons getting notified that their holds are available for pickup is top priority for libraries. See bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 16:32:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 14:32:53 +0000 Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees In-Reply-To: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33411-70-zNXhpcLyfm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- # Subtest: NoIssuesChargeGuarantees tests 1..6 not ok 1 - Only patron's fines are reported in total # Failed test 'Only patron's fines are reported in total' # at t/db_dependent/SIP/Patron.t line 327. # got: '0' # expected: '11' ok 2 - Guarantor blocked not ok 3 - Screen message includes related fines total # Failed test 'Screen message includes related fines total' # at t/db_dependent/SIP/Patron.t line 329. # 'Greetings from Koha. GxXo8ZD -- Patron blocked by fines (11.22) on guaranteed accounts' # doesn't match '(?^u:Patron blocked by fines \(22\.22\) on guaranteed accounts)' ok 4 - Guarantee only fines correctly counted ok 5 - Guarantee not blocked by guarantor fines ok 6 - Screen message does not include blocked message # Looks like you failed 2 tests of 6. not ok 9 - NoIssuesChargeGuarantees tests # Failed test 'NoIssuesChargeGuarantees tests' # at t/db_dependent/SIP/Patron.t line 338. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 16:33:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 14:33:00 +0000 Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees In-Reply-To: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33411-70-TLF0V8ZiII@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|victor at tuxayo.net |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 17:18:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 15:18:34 +0000 Subject: [Koha-bugs] [Bug 33672] Item group features shows when placing holds if EnableItemGroupHolds is disabled In-Reply-To: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33672-70-prtG0f5rPf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33672 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 17:56:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 15:56:19 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-ceBoFkAfDA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- The display is much better now. Here are several things to take a look at: The three action buttons for the items are sitting right on top of a thin border line. Some space between the buttons would look better. Or, is the line needed at all? Since the item labels are of different widths it makes the input boxes display in a staggered fashion. It would be easier to view if the labels were all one width so that the input boxes could align. It was that way for me in 22.05 but it's possible I put some code in place to do that. If there is no match for the bib then 'Match:' is just hanging above the order info with no purpose. It did not display at all in 22.05 if there was no match. When clicking on the 'Item information' tab the edit_item_form does not display. I've attached a few screenshots. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 17:56:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 15:56:59 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-EQvBL29fp0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #10 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- Created attachment 151345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151345&action=edit Original display after updated patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 17:57:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 15:57:30 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-rc1gtiSz3C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #11 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- Created attachment 151346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151346&action=edit Display after suggested tweaks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 17:57:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 15:57:49 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-pdvx0o3V5O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #12 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- Created attachment 151347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151347&action=edit Missing edit_item_form -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 18:04:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 16:04:20 +0000 Subject: [Koha-bugs] [Bug 33200] IndependentBranchesTransfers does not prevent holds from creating transfers In-Reply-To: <bug-33200-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33200-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33200-70-saPp2fOjA5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33200 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151129|0 |1 is obsolete| | --- Comment #10 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151348&action=edit Bug 33200: IndependentBranchesTransfers does not prevent holds from creating transfers This patch don't concider hold made from other branches when IndependentBranchesTransfers is set to Yes and the connected user is not a SuperLibrarian To test, you must have - IndependentBranches, IndependentBranchesPatronModifications and IndependentBranchesTransfers preferences set to Yes - canreservefromotherbranches must be set to Don't allow - Circulation rules that allow holds and checkouts - Two libraries (I used Midway (A) and Centerville (B)) - A record with two items, one at each library, with barcodes, check out the one from library A - Two non-superlibrarian staff user, one in each library, with at least catalogue and holds permissions, this is what I gave them - circulate (all) - catalogue - delete_borrowers - edit_borrowers - reserveforothers (all) 1. Log in to the staff interface with the non-superlibrarian staff user from library A 2. Go to the record with the two items, click 'Place hold' 3. Place a hold for a user, without changing anything (should be for 'next available item') 4. Log out and log back in with the non-superlibrarian staff user from library B 5. Check in the item from library B, which should be available --> Hold is confirmed for patron from library A, transfer is created 6. Click on 'Confirm hold and transfer' 7. Optionally, you can log out and log back in as staff from library A 8. Go to Circulation > Transfers to receive (should this even be available with IndependentBranchesTransfers turned on?) --> Item from other branch is there 9. Apply the patch 10. Create an other record with two items, one at each library, with barcodes, check out the one from library A 11. repeat step 1, 2, 3, 4, 5 --> The 'Hold found' popup is not shown, because there is no hold for this item in the user branch (library B) 12. repeat step 7,8 --> Item from other branch is not there -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 18:04:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 16:04:23 +0000 Subject: [Koha-bugs] [Bug 33200] IndependentBranchesTransfers does not prevent holds from creating transfers In-Reply-To: <bug-33200-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33200-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33200-70-TBwG4eJnHS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33200 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151130|0 |1 is obsolete| | --- Comment #11 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151349&action=edit Bug 33200: (follow-up) Adding Unit test, renaming _Removereserve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 18:04:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 16:04:30 +0000 Subject: [Koha-bugs] [Bug 33714] Enabling advanced editor causes 500 error In-Reply-To: <bug-33714-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33714-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33714-70-4KOOVLoaCY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33714 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 33375 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 18:04:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 16:04:30 +0000 Subject: [Koha-bugs] [Bug 33375] Advanced editor crashes when using MySQL 8 due to reserved rank keyword In-Reply-To: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33375-70-jJgb0Pd8Sn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33375 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kohasupport at nlj.gov.jm --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 33714 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 18:05:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 16:05:03 +0000 Subject: [Koha-bugs] [Bug 33375] Advanced editor crashes when using MySQL 8 due to reserved rank keyword In-Reply-To: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33375-70-tdjTVENTmo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33375 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 18:08:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 16:08:48 +0000 Subject: [Koha-bugs] [Bug 33754] New: Expand MaxTotalSuggestion to have an option for a calendar month rather than a set number of days Message-ID: <bug-33754-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33754 Bug ID: 33754 Summary: Expand MaxTotalSuggestion to have an option for a calendar month rather than a set number of days Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some users would find it very helpful to be able to set MaxTotalSuggestion by calendar month rather than a specific number of days. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 18:34:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 16:34:08 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-tSSIvnFKIz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 18:34:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 16:34:11 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-lfdqlfV5qE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151333|0 |1 is obsolete| | --- Comment #16 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151350&action=edit Bug 33606: Add a erm/config route to retrieve the ERM config needed for the Vue app This could be extended later in bug 32968 to pass the permission of the logged in user. Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 18:34:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 16:34:14 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-8KnO16swTT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151334|0 |1 is obsolete| | --- Comment #17 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151351&action=edit Bug 33606: Mark the endpoint as experimental Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 18:34:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 16:34:17 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-hhgknPcy8O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #18 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151352&action=edit Bug 33606: Fix settings Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 18:37:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 16:37:43 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-dWyjTdjzKx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32971 --- Comment #19 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- This fixes the issue. A non-superlibrarian user no longer requires parameters => 'manage_sysprefs' to properly access ERM, although the issues in bug 32971 remain. I want to come up with a better long-term solution but I can't think of one that doesn't imply rearranging how we handle permissions at a core level. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 18:37:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 16:37:43 +0000 Subject: [Koha-bugs] [Bug 32971] Access to ERM module requires 'erm' permission and 'vendors_manage' acquisition sub-permission In-Reply-To: <bug-32971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32971-70-W1QR7AIgLV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32971 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33606 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 18:39:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 16:39:09 +0000 Subject: [Koha-bugs] [Bug 33755] New: Profile used is not saved when importing records Message-ID: <bug-33755-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33755 Bug ID: 33755 Summary: Profile used is not saved when importing records Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Before 22.11 if you selected a profile when staging marc records for import, when you went to see staged records it would show which profile was used both in the table and in the batch details. Post 22.11, if you select a profile, it saves the selections but doesn't save which profile was used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:01:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:01:10 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-zRrd2sJB5s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151318|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151353&action=edit Bug 23336: Unit tests This patch adds unit tests for the new checkout availability endpoint we're going to introduce in this patchset. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:01:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:01:14 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-lWYWOp1u3y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151319|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151354&action=edit Bug 23336: Add checkout API's This patch adds API's to allow for a checkout flow using the RESTful API. We add an availability endpoint to check an items current availability status. The endpoint can be found at `/checkouts/availability` and is a GET request that requires item_id and patron_id passed as parameters. We return an availability object that includes blockers, confirms, warnings and a confirmation token to be used for checkout. We also add a corresponding checkout method to the `/checkouts` endpoint. The method accepts a POST request with checkout details including item_id , patron_id and the confirmation token in the body. Future work: We should properly migrate CanBookBeIssued into Koha::* and use that here instead of refering to C4::Circulation. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:01:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:01:17 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-7iKvDYrTGQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151320|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151355&action=edit Bug 23336: Fix inconsistent return of AddIssue AddIssue can on occasion create a renewal instead of a fresh issue and in such a case we currently return undefined. We should be consistent and return the existing issue object for the renewal. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:01:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:01:20 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-1NY9F7U4FT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151321|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151356&action=edit Bug 23336: (follow-up) Switch to using Koha::Token Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:01:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:01:24 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-jYKa3GMwbq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151357&action=edit Bug 23336: (QA follow-up) Minor fixes This patch deals with some QA script warnings, and also makes some changes in line with bug 33556. We also adds current user id and checkout item id into the confirmation token to improve security and fix the failing tests. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:02:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:02:02 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-H18i2sbGEb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:03:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:03:58 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-FFfRcI3gQR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 --- Comment #40 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Tests are passing again, and a little more thorough.. I kept your fixes and squashed a few extra's of my own into that same patch. Back to PQA to see what you think.. at this point I'm not worried if we hit 23.05, though I'd keep this and the tree that depends on it moving if we don't hit release so it can be pushed early next cycle rather than get stuck for another few months and pushed up against the deadline of 23.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:07:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:07:08 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-fSyUjS7SxV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #11 from Michaela Sieber <michaela.sieber at kit.edu> --- (In reply to Jonathan Druart from comment #8) > Remote branch rebased and a couple of fixes added. > > Setting status to Needs Signoff, this is ready to get feedback from testers. Is there a test plan? btw: it is not possible to test the patch in a sandbox http://staff-b33568.sandboxes.ptfs-europe.co.uk/ Error: Template process failed: undef error - C4::Koha::GetAuthorisedValues(): DBI Exception: DBD::mysql::st execute failed: 'koha_b32748.av.category' isn't in GROUP BY at /kohadevbox/koha/Koha/Template/Plugin/AuthorisedValues.pm line 39 at /kohadevbox/koha/C4/Templates.pm line 127 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:07:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:07:21 +0000 Subject: [Koha-bugs] [Bug 21889] Include Staff Client entered Purchase Suggestions with System Preference maxopensuggestions In-Reply-To: <bug-21889-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21889-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21889-70-BWXPIF1xHw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21889 Katie Bliss <kebliss at dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:12:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:12:07 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-DrFEpz2jtB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151254|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151358&action=edit Bug 30979: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:12:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:12:11 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-tOn9SPhoOS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151255|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151359&action=edit Bug 30979: Add public endpoints This patch expands the checkouts endpoints to allow for a public workflow. We add the availability endpoint under `/public/checkouts/availability` and restrict the information we send back to only those fields a public user should be allowed to see. We also add a new checkout endpoint at `/patrons/{patron_id}/checkouts` that allows for users to checkout to themselves and accepts the same POST request with checkout details including item_id and a confirmation token in the body that the staff client endpoints accept. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:12:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:12:14 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-4zOItRk59D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151256|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151360&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:12:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:12:18 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-TfSJHJsWHq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151257|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151361&action=edit Bug 30979: Limit public checkout endpoint using preference The public api endpoint for self-checkout should only be enabled in the case where the OpacTrustedSelfCheckout option is enabled. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:12:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:12:22 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-pX6d3w2qqS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151258|0 |1 is obsolete| | --- Comment #100 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151362&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode to checkout. We check for item existance and availability and then check the item out after any confirmations have been displayed. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:12:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:12:26 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-Ngni24Jo3V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151259|0 |1 is obsolete| | --- Comment #101 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151363&action=edit Bug 30979: Always show self-checkout when preference enabled This patch updates the display logic such that if the truested self-checkout option is enabled we always show the checkout button and prompt a login when no user is found. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:12:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:12:30 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-fi2W1Mx4OD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151260|0 |1 is obsolete| | --- Comment #102 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151364&action=edit Bug 30979: Redirect to checkout summary This is a temporary solution whilst we wait for the biblio api endpoints so we may include more biblio details in the checkout modal itself. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:12:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:12:33 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-prVZxa8U9O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151261|0 |1 is obsolete| | --- Comment #103 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151365&action=edit Bug 30979: Add modal trigger to shibboleth target url Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:18:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:18:34 +0000 Subject: [Koha-bugs] [Bug 33756] New: Wrong calculation of total amount spent? Message-ID: <bug-33756-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33756 Bug ID: 33756 Summary: Wrong calculation of total amount spent? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org I am trying to work out something in acquisitions and stumbled on this bit: https://git.koha-community.org/Koha-community/Koha/src/branch/master/C4/Budgets.pm#L553 # Get all the budgets totals in as few queries as possible my $hr_budget_spent = $dbh->selectall_hashref(q| SELECT aqorders.budget_id, aqbudgets.budget_parent_id, SUM( | . C4::Acquisition::get_rounding_sql(qq|COALESCE(unitprice_tax_included, ecost_tax_included)|) . q| * quantity ) AS budget_spent FROM aqorders JOIN aqbudgets USING (budget_id) WHERE quantityreceived > 0 AND datecancellationprinted IS NULL GROUP BY budget_id, budget_parent_id |, 'budget_id'); If the amount is spent, I feel multiplying by quantity is incorrect. It should be quantityreceived. I am not sure yet where this is used and how it manifests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:20:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:20:23 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-K47zbhfTSe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #104 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Hmm.. the rebase on 23336 broke something here.. working on a fresh rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:22:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:22:38 +0000 Subject: [Koha-bugs] [Bug 33740] Error 500, when editing authority TAG 000 (leader). In-Reply-To: <bug-33740-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33740-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33740-70-ToJlWFePlo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33740 --- Comment #2 from Pablo Jones <pablo.joneslobos at gmail.com> --- (In reply to Jonathan Druart from comment #1) > do you have access to the Koha logs on the server? Hi! Joneathan, thanks for answering, yes, I already checked the log files, I can't find anything related to the error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:35:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:35:40 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-iRAn2Vggi7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #124 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151366&action=edit Bug 11844: Only display 'Additional fields' section if they are defined Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 19:44:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 17:44:30 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-MhqICpQmzt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #152 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151367&action=edit Bug 8179: Add vendor id on breadcrumb link Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:00:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:00:00 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-zNeL2rhPuo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151358|0 |1 is obsolete| | --- Comment #105 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151368&action=edit Bug 30979: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:00:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:00:46 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-yD6bQWoYhj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151359|0 |1 is obsolete| | --- Comment #106 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151369&action=edit Bug 30979: Add public endpoints This patch expands the checkouts endpoints to allow for a public workflow. We add the availability endpoint under `/public/checkouts/availability` and restrict the information we send back to only those fields a public user should be allowed to see. We also add a new checkout endpoint at `/patrons/{patron_id}/checkouts` that allows for users to checkout to themselves and accepts the same POST request with checkout details including item_id and a confirmation token in the body that the staff client endpoints accept. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:01:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:01:26 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-mcQVjRbtn5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151360|0 |1 is obsolete| | --- Comment #107 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151370&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:01:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:01:58 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-L0XPg0GlAj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151361|0 |1 is obsolete| | --- Comment #108 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151371&action=edit Bug 30979: Limit public checkout endpoint using preference The public api endpoint for self-checkout should only be enabled in the case where the OpacTrustedSelfCheckout option is enabled. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:02:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:02:36 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-EOOEn60i0U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151362|0 |1 is obsolete| | --- Comment #109 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151372&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode to checkout. We check for item existance and availability and then check the item out after any confirmations have been displayed. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:03:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:03:05 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-ENEOF9hHxm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151363|0 |1 is obsolete| | --- Comment #110 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151373&action=edit Bug 30979: Always show self-checkout when preference enabled This patch updates the display logic such that if the truested self-checkout option is enabled we always show the checkout button and prompt a login when no user is found. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:03:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:03:28 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-55iwB5Tw3l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151364|0 |1 is obsolete| | --- Comment #111 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151374&action=edit Bug 30979: Redirect to checkout summary This is a temporary solution whilst we wait for the biblio api endpoints so we may include more biblio details in the checkout modal itself. Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:03:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:03:49 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-oIPjlZbAzg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151365|0 |1 is obsolete| | --- Comment #112 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151375&action=edit Bug 30979: Add modal trigger to shibboleth target url Signed-off-by: Silvia Meakins <smeakins at eso.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:04:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:04:11 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-JZczDjTwZM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #113 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151376&action=edit Bug 30979: (follow-up) Fix public availability 500 When we introduced the logged in user id to the token generation we had the knock on effect of creating a 500 response for unauthenticated availability lookups. This patch resolves the 500, but results in a token that's not useful for the end user. We should consider this in the wider context down the line. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:36:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:36:57 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-ITcYZPrfmR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151102|0 |1 is obsolete| | --- Comment #163 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151377&action=edit Bug 17385: Add custom export XSLT Rebase Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:37:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:37:03 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-pk8dYTbJ5j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151103|0 |1 is obsolete| | --- Comment #164 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151378&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:37:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:37:09 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-BMJJJh5Sfj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151104|0 |1 is obsolete| | --- Comment #165 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151379&action=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:37:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:37:14 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-zvksulXHZy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151105|0 |1 is obsolete| | --- Comment #166 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151380&action=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : <pre> $ prove -l t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. 1/3 # Failed test 'This list comes from the cache and that is fine' # at t/db_dependent/XSLT.t line 122. # got: '1' # expected: '2' # Looks like you failed 1 test of 1. # Failed test 'CustomXSLTExportList: Caching' # at t/db_dependent/XSLT.t line 124. # Looks like you failed 1 test of 3. t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report ------------------- t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.74 cusr 0.14 csys = 1.91 CPU) Result: FAIL </pre> This one works fine : <pre> $ prove -l t/XSLT.t t/XSLT.t .. ok All tests successful. Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.55 cusr 0.17 csys = 2.74 CPU) Result: PASS </pre> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:37:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:37:20 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-8BHajNnX40@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151106|0 |1 is obsolete| | --- Comment #167 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151381&action=edit Bug 17385: (Fix) Add custum export format option to the cart and the lists and fix tests for CustomXSLTExportList This patch adds 'XSL-Simple Export' to the cart and the lists and correct the fail test in t/XSLT.t it contains Add custum export format option when saving a record TO TEST: Before applying: 1) Search for a record in the intranet. 2) Click on the 'Save' button and observe the dropdown menu. --> There is no 'XSL- Simple Export' in the dropdown menu. 3) Apply the patch. 4) In System preferences search for OpacExportOptions and enable XSL 5) Repeat the steps 1 and 2. ---> There is now 'XSL- Simple Export' option in the dropdown menu 6) Click on 'XSL - Simple Export'. a .html file should be downloaded. 7) Open the .html file. You should see the record's informations. 8) Add some items to your Cart 9) Open the Cart 10) Click on the 'Download' and 'XSL - Simple Export'. ----> a .html file should be downloaded. ----> you should see the record's informations in the downloaded file. 11) Add some items to a List 12) Open the List 13) Click on the 'Download' and 'XSL - Simple Export'. ----> a .html file should be downloaded. ----> you should see the record's informations in the downloaded file. 14) Do the same steps in OPAC ----> a .html file should be downloaded. ----> you should see the record's informations in the downloaded file. 15) In System preferences search for OpacExportOptions and disable XSL 16) Repeat all steps 17) Notice that 'XSL - Simple Export' is no more in the menus. 18) Run prove -l t/XSLT.t Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:42:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:42:14 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-bBIZxjZEFF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:42:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:42:53 +0000 Subject: [Koha-bugs] [Bug 33753] Password expiration warning In-Reply-To: <bug-33753-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33753-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33753-70-csnpdJAxSH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33753 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED --- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> --- Not a duplicate. Other bug has to do with PATRONS seeing a warning in the OPAC. I purposely kept this separate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:43:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:43:15 +0000 Subject: [Koha-bugs] [Bug 33753] Password expiration warning In-Reply-To: <bug-33753-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33753-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33753-70-OP5f5GvztG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33753 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:44:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:44:11 +0000 Subject: [Koha-bugs] [Bug 33752] Password expiration warning In-Reply-To: <bug-33752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33752-70-vYWuuCOiT3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33752 --- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> --- Bug 33753 is not a duplicate. That bug has to do with the staff interface. This one has to do with the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:47:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:47:00 +0000 Subject: [Koha-bugs] [Bug 33751] Notice needed for password expiration In-Reply-To: <bug-33751-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33751-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33751-70-iAvp2gYxrc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33751 --- Comment #1 from Christopher Brannon <cbrannon at cdalibrary.org> --- This is particularly important with STAFF accounts that are SHARED. It is common practice around here for libraries to have a shared circulation account so the library is managing less accounts. However, it would be best if a notification is sent out, so that someone doesn't change it on the fly and forget to tell everyone else. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:48:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:48:05 +0000 Subject: [Koha-bugs] [Bug 33217] Allow different default sorting when click author links In-Reply-To: <bug-33217-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33217-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33217-70-QUmC5ShzYj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33217 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Sorting dropdown does not show correct value after applying -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:56:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:56:30 +0000 Subject: [Koha-bugs] [Bug 33340] Correct formatting of English 1-page order PDF when the basket group covers multiple pages In-Reply-To: <bug-33340-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33340-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33340-70-yMDNOVcteX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 --- Comment #7 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Thank you Tomás! Could we please request that this enhancement be backported to 22.11.x? Our client who sponsored the enhancement would love to benefit from having it sooner than their next major upgrade in Jan-March next year. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 21:57:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 19:57:57 +0000 Subject: [Koha-bugs] [Bug 33757] New: Help manual link in Label Creator points to wrong place Message-ID: <bug-33757-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33757 Bug ID: 33757 Summary: Help manual link in Label Creator points to wrong place Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org In 22.11, when in Label creator and you click on Help, you are taken to https://koha-community.org/manual//22.11/en/html/tools.html#label-creator-label but should be taken to https://koha-community.org/manual//22.11/en/html/cataloging.html#creating-labels -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 22:00:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 20:00:53 +0000 Subject: [Koha-bugs] [Bug 33037] [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) In-Reply-To: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33037-70-o0gxdcKSZb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31313 CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 22:00:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 20:00:53 +0000 Subject: [Koha-bugs] [Bug 31313] Remove GetItemsInfo from opac-detail In-Reply-To: <bug-31313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31313-70-dz96j15UUO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33037 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 22:01:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 20:01:00 +0000 Subject: [Koha-bugs] [Bug 33037] [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) In-Reply-To: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33037-70-RHxPJtYDwt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32555 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 22:01:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 20:01:00 +0000 Subject: [Koha-bugs] [Bug 32555] Error when viewing serial in OPAC In-Reply-To: <bug-32555-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32555-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32555-70-N34oU4Puk0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32555 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33037 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 22:03:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 20:03:33 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33462-70-zcnSs3sn7G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 --- Comment #4 from Christopher Brannon <cbrannon at cdalibrary.org> --- This feature is rather important for us. Our consortium wants to stay away from having patron passwords expiring on a regular basis, but we want patrons to get away from default passwords as quickly as possible. An option for changing the password after a first time login would meet this need. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 22:19:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 20:19:34 +0000 Subject: [Koha-bugs] [Bug 30255] Allow skipping "list" step for record batch modification/deletion In-Reply-To: <bug-30255-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30255-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30255-70-uPIIFieSfs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151289|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 151382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151382&action=edit Bug 30255: Make selection step optional for batch record del/mod Allow the user to optionally skip the record selection step in batch record deletion/modification tools and directly enqueue job for all records. 1) Create a record modification template. 2) Enter some biblionumber(s) in the batch record modification tool form, select the record modification template, the "Select records to modify" option and proceed to the next step. 3) Verify that records can be selected, proceed to the next step and verify that a job has been enqueued for the selected records. 4) Return to the batch record modification form and enter the biblionumbers(s) again. Now select "Modify all" and proceed to the next step. 5) Verify that a job has been enqueued for all records. 6) Enter some biblionumber(s) in the batch record deletion tool form, select the "Select records to delete" option and proceed to the next step. 7) Verify that records can be selected, proceed to the next step and verify that a job has been enqueued for the selected records. 8) Return to the batch record deletion form and enter the biblionumbers(s) again. Now select "Delete all" and proceed to the next step. 9) Verify that a job has been enqueued for all records. Sponsored by: Gothenburg University Library Signed-off-by: Laura <laura.escamilla at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 22:19:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 20:19:57 +0000 Subject: [Koha-bugs] [Bug 30255] Allow skipping "list" step for record batch modification/deletion In-Reply-To: <bug-30255-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30255-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30255-70-p2YmvWcsf2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 22:39:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 20:39:08 +0000 Subject: [Koha-bugs] [Bug 33247] Deleted authority still on results list In-Reply-To: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33247-70-QTMxd1AuLZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 --- Comment #10 from Phil Ringnalda <phil at chetcolibrary.org> --- (In reply to Marcel de Rooy from comment #7) > (In reply to Phil Ringnalda from comment #4) > > We actually already have a dirty indication of deleted records if your > > search didn't specify an authority type, since in that case we can't look up > > the authority type to display it above the heading in the search results. So > > already-deleted headings are the ones with a slightly shorter row because > > they don't have the authority type part of the display. > > Do not understand this argument. I removed a PERSO_NAME record. It is marked > with Pending deletion, but I still see the heading type Personal name. Or do > you mean something else ? Turns out not to be what I thought it was: rather than the result of hitting the db for the authority type, it must be the result of index differences (either a missing index, or speed at updating an index) between Zebra and Elasticsearch, since it's Zebra-only that the type in the Summary column disappears, and the one in the Heading type column switches to Default. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 22:43:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 20:43:12 +0000 Subject: [Koha-bugs] [Bug 33578] Cannot edit patron restriction types In-Reply-To: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33578-70-kbROnUYIVv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com --- Comment #8 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #7) > Created attachment 150976 [details] [review] > Bug 33578: Fix controller when editing a restriction type > > Do not display a warning when we are editing a restriction type and no > other types with this description exists. Still seeing the message that Owen reported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 17 22:48:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 20:48:18 +0000 Subject: [Koha-bugs] [Bug 33758] New: Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook Message-ID: <bug-33758-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Bug ID: 33758 Summary: Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: nicolas.giraud at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: caroline.cyr-la-rose at inlibro.com, philippe.blouin at inlibro.com I have one plugin who have to know the biblionumber to add a custom button in the toolbar in the page details.pl But currently, the method is called without parameter so the plugin doesn't know in which biblionumber details page it adds the new button. The parameter allows to create custom with the biblionumber link to the button. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 22:48:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 20:48:38 +0000 Subject: [Koha-bugs] [Bug 33758] Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook In-Reply-To: <bug-33758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33758-70-kvMguEY9A6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Nicolas Giraud <nicolas.giraud at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nicolas.giraud at inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 17 22:54:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 20:54:43 +0000 Subject: [Koha-bugs] [Bug 33758] Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook In-Reply-To: <bug-33758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33758-70-aGGZ0ciFcD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Nicolas Giraud <nicolas.giraud at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 00:27:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 22:27:55 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33639-70-5CLrpQvbqQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 00:27:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 May 2023 22:27:57 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33639-70-uvp8bD9poM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150422|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151383&action=edit Bug 33639: Fix selectors for adding to item group To test: Apply patch 1 - Browse to details page for a record 2 - Create or ensure the record has item group(s) 3 - Click New->New item 4 - Note the bottom of the page has a form to attach to existing group 5 - Note when a group is selected the enumchron field is populated if it is blank 6 - Note that the enumchron field is NOT update is there is a an existing value 7 - Confirm item is saved to group when saved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 03:41:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 01:41:00 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue .js and .ts files In-Reply-To: <bug-33625-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33625-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33625-70-m90fMLi8lp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 04:22:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 02:22:15 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30418-70-p7glwhgc8e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #39 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Hi Marcel, According to comment #36 this enhancement (bug 30418) was pushed to master around 2023-05-16 09:28:06 UTC, however, the list permission problems in bug 33722 were reported earlier at 2023-05-11 23:16:42 UTC Also, noting that if you checkout 2928c1cf634c97041ea3b1268dcc27a550feb2ca 'Bug 32775: (QA follow-up) remove useless empty line' (the commit in log before bug 30418 was pushed) the problem reported in bug 33722 can be replicated then. Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 05:13:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 03:13:06 +0000 Subject: [Koha-bugs] [Bug 33412] (bug 15869 follow-up) Overlay record framework is always setting records to original framework In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-IGvPOHzGIC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 05:17:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 03:17:00 +0000 Subject: [Koha-bugs] [Bug 32638] No reason given for why items ignored during MARC import In-Reply-To: <bug-32638-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32638-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32638-70-idrsfyA2MO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32638 --- Comment #1 from David Cook <dcook at prosentient.com.au> --- Bumped into this issue again today when I was trying to import a record that contained an item with a barcode that already existed in Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 05:23:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 03:23:55 +0000 Subject: [Koha-bugs] [Bug 32638] No reason given for why items ignored during MARC import In-Reply-To: <bug-32638-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32638-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32638-70-jOAbQAeDVc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32638 --- Comment #2 from David Cook <dcook at prosentient.com.au> --- I see in C4::ImportBatch::_batchCommitItems that duplicate barcode is the only error that will increment the items errored count... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 05:26:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 03:26:38 +0000 Subject: [Koha-bugs] [Bug 32638] No reason given for why items ignored during MARC import In-Reply-To: <bug-32638-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32638-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32638-70-eVSFIsYhv2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32638 --- Comment #3 from David Cook <dcook at prosentient.com.au> --- Interestingly if the barcode is too long then the whole import fails and I see the following in worker-output.log, so that's something...: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'barcode' at row 1 at /kohadevbox/koha/Koha/Object.pm line 170 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 05:29:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 03:29:00 +0000 Subject: [Koha-bugs] [Bug 32638] No reason given for why items ignored during MARC import In-Reply-To: <bug-32638-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32638-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32638-70-merzY4GhAB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32638 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- Looks like the coded location qualifier will cause the whole import to fail as well now, so that's good. You can see this in the worker-output.log: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'coded_location_qualifier' at row 1 at /kohadevbox/koha/Koha/Object.pm line 170 It could be good to add something to the Web UI to ask people to consult their sysadmin so they can check the logs for more specifics... -- And maybe the duplicate barcode could be hinted at more although given the code flow I can see how that would be very difficult (without throwing a fatal error to stop the whole import) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 05:56:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 03:56:37 +0000 Subject: [Koha-bugs] [Bug 27452] Create GUI for patron_emailer cron In-Reply-To: <bug-27452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27452-70-U5fEd5KVvW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27452 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook <dcook at prosentient.com.au> --- Looks like the plugin is gone in any case... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 08:24:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 06:24:56 +0000 Subject: [Koha-bugs] [Bug 23773] Send MEMBERSHIP_EXPIRY notice by SMS In-Reply-To: <bug-23773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23773-70-JocyO7XJqz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23773 --- Comment #7 from David Cook <dcook at prosentient.com.au> --- Curious if this one will make it into 23.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 08:33:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 06:33:52 +0000 Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28998-70-4973Ftu39H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 --- Comment #105 from David Cook <dcook at prosentient.com.au> --- (In reply to Jonathan Druart from comment #4) > How do we generate the new config entry on upgrade? I don't think this was ever done... which has been driving me a little crazy lately 😅 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 10:07:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 08:07:13 +0000 Subject: [Koha-bugs] [Bug 27452] Create GUI for patron_emailer cron In-Reply-To: <bug-27452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27452-70-Um7YUIP1N0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27452 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, that's odd as it's one of the most popular plugins. I left a note for Nick on IRC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 10:30:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 08:30:56 +0000 Subject: [Koha-bugs] [Bug 31859] Error 500 when enabling advanced cataloging editor In-Reply-To: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31859-70-WoAAizHUae@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31859 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I believe this IS a duplicate to bug 33375: [Tue Oct 18 14:19:17.189372 2022] [cgi:error] [pid 3532853] [client 186.102.58.32:7547] AH01215: {UNKNOWN}: DBI Exception: DBD::mysql::db selectall_arrayref failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ',servername' The fix: WHERE recordtype != 'authority' AND servertype = 'zed' - ORDER BY rank,servername + ORDER BY `rank`,servername *** This bug has been marked as a duplicate of bug 33375 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 10:30:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 08:30:56 +0000 Subject: [Koha-bugs] [Bug 33375] Advanced editor crashes when using MySQL 8 due to reserved rank keyword In-Reply-To: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33375-70-SChLKR7i0V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33375 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcautomatizacion at gmail.com --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 31859 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 10:38:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 08:38:40 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: <bug-32775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32775-70-ZIJRxgUgY5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 10:39:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 08:39:54 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30418-70-XZ4vBioDIu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #40 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Alex Buckley from comment #39) > Hi Marcel, > > According to comment #36 this enhancement (bug 30418) was pushed to master > around 2023-05-16 09:28:06 UTC, however, the list permission problems in bug > 33722 were reported earlier at 2023-05-11 23:16:42 UTC > > Also, noting that if you checkout 2928c1cf634c97041ea3b1268dcc27a550feb2ca > 'Bug 32775: (QA follow-up) remove useless empty line' (the commit in log > before bug 30418 was pushed) the problem reported in bug 33722 can be > replicated then. > > Alex Might be false alarm indeed. Sorry for the confusion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 10:46:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 08:46:14 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-3Lfk2UbvBH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 10:59:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 08:59:55 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-LZc5D4LwmR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I didn't get back to this in time, maybe consider a follow-up next time? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:13:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 09:13:27 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-dvxa39cjYa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:13:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 09:13:30 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-cIZpWLothJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150135|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151384&action=edit Bug 33313: Fix catalog links in TICKET_NOTIFY This fixes the system preference name from IntranetBaseURL to staffClientBaseURL. As this feature has just been pushed I chose to fix the database updates that will be run when installing 23.05. To test: * Verify the wrong link in TICKET_NOTIFY * Drop database, create database, run web installer * Verify the link is now correct in the notice Bonus: Test update from 22.11 to 23.05 and verify the notices are correct there as well. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:15:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 09:15:00 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-kNNWIcBaNr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate Severity|enhancement |normal --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am moving the typo fixes to a different bug. I believe we might get away with pushing this as the string might not change in pootle now. It's currently: You can mark this concern as resolved from the concern management %spage%s. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:15:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 09:15:55 +0000 Subject: [Koha-bugs] [Bug 33759] New: Typo: Thankyou Message-ID: <bug-33759-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33759 Bug ID: 33759 Summary: Typo: Thankyou Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org There are several notices reading 'Thankyou' we can fix to read "Thank you". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:33:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 09:33:48 +0000 Subject: [Koha-bugs] [Bug 33759] Typo: Thankyou In-Reply-To: <bug-33759-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33759-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33759-70-4OyWgO3OK7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33759 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Maybe also needs a database update? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:33:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 09:33:55 +0000 Subject: [Koha-bugs] [Bug 33759] Typo: Thankyou In-Reply-To: <bug-33759-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33759-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33759-70-IhopTKtlSN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33759 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:37:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 09:37:34 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-YoesFIxTDM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Testing... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 11:38:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 09:38:00 +0000 Subject: [Koha-bugs] [Bug 33760] New: Error 500 showing with self-registration form due to mandatory and optional fields Message-ID: <bug-33760-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33760 Bug ID: 33760 Summary: Error 500 showing with self-registration form due to mandatory and optional fields Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: rebecca.bradshaw at nnuh.nhs.uk QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We have been having a lot of difficulty with our self-registration form on the OPAC. We set up some fields as mandatory but this triggered an error 500 message. On our self-registration form we have the employment details mandatory: https://elms.koha-ptfs.co.uk/cgi-bin/koha/opac-memberentry.pl (we have had to make them optional for the time being due to the error showing). Whilst these fields were mandatory and new users completed them an error 500 would trigger when the form was saved. However, the user record would still be made (this led to many new users creating multiple records as they thought it had not saved the first time). The user record, however, would not contain the completed employment details or the consent (yes/no) answer for whether users would like to sign up to the Knowledge Share or Open Athens. This appears to have been because the mandatory fields in the staff interface user record form were not being shown on the OPAC self-registration form. This has meant that the fields staff must complete on the staff interface have had to be made optional so they 1. don't show on the self-registration form and 2. don't create an error 500 message from showing. Is it possible for the bug to be looked into please? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 12:27:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 10:27:56 +0000 Subject: [Koha-bugs] [Bug 31585] "ACQUISITION ORDER" action missing from log viewer search form In-Reply-To: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31585-70-fJHSNNoWXD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31585 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 12:27:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 10:27:58 +0000 Subject: [Koha-bugs] [Bug 31585] "ACQUISITION ORDER" action missing from log viewer search form In-Reply-To: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31585-70-LmBlh1n9cH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31585 --- Comment #2 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151385&action=edit Bug 31585: Fix 'acquisition order' and 'acquisition claim' Added 'ACQUISITION CLAIM' and 'ACQUISITION ORDER' to the log viewer form. Please test this well (making sure there are log entries of these types and they show properly upon searching for them) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 12:59:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 10:59:11 +0000 Subject: [Koha-bugs] [Bug 14261] Switch 'ask for a discharge' to 'download discharge confirmation' when patron was discharge in OPAC user account In-Reply-To: <bug-14261-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14261-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14261-70-yFVrNFPrwp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14261 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m --- Comment #8 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Can you rebase please Katrin and I'll take a look -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 12:59:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 10:59:52 +0000 Subject: [Koha-bugs] [Bug 14261] Switch 'ask for a discharge' to 'download discharge confirmation' when patron was discharge in OPAC user account In-Reply-To: <bug-14261-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14261-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14261-70-HKEZHJGHEN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14261 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 12:59:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 10:59:58 +0000 Subject: [Koha-bugs] [Bug 14261] Switch 'ask for a discharge' to 'download discharge confirmation' when patron was discharge in OPAC user account In-Reply-To: <bug-14261-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14261-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14261-70-8ZhwukysSu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14261 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:06:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:06:32 +0000 Subject: [Koha-bugs] [Bug 33761] New: Holds queue is not selecting items with completed transfers Message-ID: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Bug ID: 33761 Summary: Holds queue is not selecting items with completed transfers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 24295 removed the use of GetTransfer by adding a join to branchtransfers when getting available items. The conditions are right, datearrived and datecancelled are null - but they need to be in the join, otherwise we remove all items with completed transfers from the results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:06:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:06:48 +0000 Subject: [Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers In-Reply-To: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33761-70-4JjFVKCLvP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30580 Depends on| |24295 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:06:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:06:48 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: <bug-24295-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24295-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24295-70-KHIGwXNcmJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33761 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 [Bug 33761] Holds queue is not selecting items with completed transfers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:06:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:06:48 +0000 Subject: [Koha-bugs] [Bug 30580] GetItemsAvailableToFillHoldRequestsForBib should get transfers during initial query In-Reply-To: <bug-30580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30580-70-TAB9hm7GCM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33761 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:10:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:10:29 +0000 Subject: [Koha-bugs] [Bug 30820] Standardize sample patron category for ILL libraries In-Reply-To: <bug-30820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30820-70-s14SigUA7s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30820 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |pedro.amorim at ptfs-europe.co | |m --- Comment #1 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- This should already be fixed by bug 21548 *** This bug has been marked as a duplicate of bug 21548 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:10:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:10:29 +0000 Subject: [Koha-bugs] [Bug 21548] Make ILL patron category in koha-conf.xml match with ILL patron category in sample data In-Reply-To: <bug-21548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21548-70-9FGMv77Dgh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 --- Comment #13 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- *** Bug 30820 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:12:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:12:39 +0000 Subject: [Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers In-Reply-To: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33761-70-hy80oUw4hG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:12:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:12:41 +0000 Subject: [Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers In-Reply-To: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33761-70-qeOqwdJQhg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151386&action=edit Bug 33761: Unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:12:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:12:43 +0000 Subject: [Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers In-Reply-To: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33761-70-8wGwLLgCZ2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151387&action=edit Bug 33761: Alter query to remove items with active transfers from available list Current code removes all items without an active transfer, and any with completed transfers. This patch moves the conditionals for transfers into the join, then adds a new condition to remove items with active transfers. To test: 1 - Apply unit test patch only 2 - prove -v t/db_dependent/HoldsQueue.t 3 - It fails 4 - Apply second patch 5 - prove -v t/db_dependent/HoldsQueue.t 6 - Success! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:24:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:24:39 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-iMlvXyodlu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:24:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:24:42 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-Kk1iKVzYyc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151146|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151388&action=edit Bug 33716: New ILLModuleDisclaimerByType sys pref Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:24:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:24:46 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-h5BJFk0vqx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151147|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151389&action=edit Bug 33716: Preparation New Illrequest::Workflow superclass New Illrequest::Workflow::TypeDisclaimer Moved Illrequest::Availability to Illrequest::Workflow::Availability Removed check for backend capability "should_display_availability" Instead, the check is now done for "can_create_request" backend capability This serves the purpose of having the backend let core know if it can create the request or not. In other words, if the create form has been submitted or not. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:24:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:24:49 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-oijDTBOE2M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151148|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151390&action=edit Bug 33716: ILL Type Disclaimer - Staff Update the way Availability is handled Add the new type disclaimer workflow operation after Availability Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:24:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:24:52 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-IXVxRPWAyR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151149|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151391&action=edit Bug 33716: ILL Type Disclaimer - OPAC Update the way Availability is handled Add the new type disclaimer workflow operation after Availability Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:24:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:24:55 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-NKbJ2Sy0Hf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151150|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151392&action=edit Bug 33716: Tests Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:24:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:24:58 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-z0L8TJspAW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151393&action=edit Bug 33716: (follow-up) Amend system preference descrpition and improve formatting This adds some documentation for the different options presented in the example YAML entry and improves formatting a little for better readability of the example. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:25:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:25:01 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-EmwzsV7Op4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151394&action=edit Bug 33716: (follow-up) Add cancel links and update breadcrumbs For both staff interface and OPAC: * Update breadcrumbs to have a new entry for the page * Rename button From Next to submit * Add a cancel link to back out Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:36:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:36:31 +0000 Subject: [Koha-bugs] [Bug 33762] New: Restore page-section in ILL Message-ID: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33762 Bug ID: 33762 Summary: Restore page-section in ILL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com CC: katrin.fischer at bsz-bw.de, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com Bug 32576 was erroneously rolled back with bug 22440. It should be restored. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:37:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:37:08 +0000 Subject: [Koha-bugs] [Bug 33762] Restore page-section in ILL In-Reply-To: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33762-70-bFhCt0Wwun@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33762 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:37:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:37:10 +0000 Subject: [Koha-bugs] [Bug 33762] Restore page-section in ILL In-Reply-To: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33762-70-Bz35JdaIFl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33762 --- Comment #1 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151395&action=edit Bug 33762: Fix page-section in ILL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 13:42:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 11:42:08 +0000 Subject: [Koha-bugs] [Bug 31585] "ACQUISITION ORDER" action missing from log viewer search form In-Reply-To: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31585-70-bixFBU5h4l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31585 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151385|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151396&action=edit Bug 31585: Fix 'acquisition order' and 'acquisition claim' Added 'ACQUISITION CLAIM' and 'ACQUISITION ORDER' to the log viewer form. Please test this well (making sure there are log entries of these types and they show properly upon searching for them) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:10:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:10:05 +0000 Subject: [Koha-bugs] [Bug 31585] "ACQUISITION ORDER" action missing from log viewer search form In-Reply-To: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31585-70-Tu8dTOHZhx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31585 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:10:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:10:07 +0000 Subject: [Koha-bugs] [Bug 31585] "ACQUISITION ORDER" action missing from log viewer search form In-Reply-To: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31585-70-79ymCsar7J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31585 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151397&action=edit Bug 31585: (follow-up) Terminology: Rename Intranet to Staff interface Just a small fix renaming one of the options to comply with terminology guidelines. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:10:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:10:23 +0000 Subject: [Koha-bugs] [Bug 31585] "ACQUISITION ORDER" action missing from log viewer search form In-Reply-To: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31585-70-CH1studA8U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31585 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151396|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151398&action=edit Bug 31585: Fix 'acquisition order' and 'acquisition claim' Added 'ACQUISITION CLAIM' and 'ACQUISITION ORDER' to the log viewer form. Please test this well (making sure there are log entries of these types and they show properly upon searching for them) Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:10:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:10:25 +0000 Subject: [Koha-bugs] [Bug 31585] "ACQUISITION ORDER" action missing from log viewer search form In-Reply-To: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31585-70-QhD486trIc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31585 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151397|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151399&action=edit Bug 31585: (follow-up) Terminology: Rename Intranet to Staff interface Just a small fix renaming one of the options to comply with terminology guidelines. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:17:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:17:01 +0000 Subject: [Koha-bugs] [Bug 25366] MARC import does not have duplicate record search option for online items In-Reply-To: <bug-25366-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25366-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25366-70-oYvfOY09Bj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25366 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Hi Jaki, Koha does allow for matching on other fields - it is required that those fields are indexed in the search engine, but new matching rules can be defined in the Administration section of Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:18:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:18:09 +0000 Subject: [Koha-bugs] [Bug 33762] Restore page-section in ILL In-Reply-To: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33762-70-gjBC36RTUK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33762 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:18:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:18:11 +0000 Subject: [Koha-bugs] [Bug 33762] Restore page-section in ILL In-Reply-To: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33762-70-RuLs5NaeTf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33762 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151395|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151400&action=edit Bug 33762: Fix page-section in ILL Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:19:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:19:02 +0000 Subject: [Koha-bugs] [Bug 33762] Restore page-section in ILL In-Reply-To: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33762-70-oKiV2OqtJG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33762 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pedro.amorim at ptfs-europe.co |ity.org |m Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:21:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:21:38 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-TrfsCtimkO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #20 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151401&action=edit Bug 33716: (follow-up) Move sysprefs to new Workflow sub heading Move ILLModuleCopyrightClearance, ILLCheckAvailability, and ILLModuleDisclaimerByType sys prefs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:21:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:21:40 +0000 Subject: [Koha-bugs] [Bug 33763] New: It should be possible to only import items if a matching item is found Message-ID: <bug-33763-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33763 Bug ID: 33763 Summary: It should be possible to only import items if a matching item is found Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The current import option for replacing items says: Replace items if matching bib was found (only for existing items) What it really does is: Replace items if matching bib was found (only for existing items) AND add items with no match found It would be nice to have the option to add or ignore items when no match is found -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:27:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:27:05 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-IJbUdDQ1a1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151401|0 |1 is obsolete| | --- Comment #21 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151402&action=edit Bug 33716: (follow-up) Move sysprefs to new Workflow sub heading Move ILLModuleCopyrightClearance, ILLCheckAvailability, and ILLModuleDisclaimerByType sys prefs State that ILLModuleCopyrightClearance is OPAC only in its description Correct 'bold' reference in ILLModuleDisclaimerByType description -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:30:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:30:58 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-ICVlJeXDwh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151388|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151403&action=edit Bug 33716: New ILLModuleDisclaimerByType sys pref Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:31:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:31:01 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-1RHIwk8Hqb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151389|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151404&action=edit Bug 33716: Preparation New Illrequest::Workflow superclass New Illrequest::Workflow::TypeDisclaimer Moved Illrequest::Availability to Illrequest::Workflow::Availability Removed check for backend capability "should_display_availability" Instead, the check is now done for "can_create_request" backend capability This serves the purpose of having the backend let core know if it can create the request or not. In other words, if the create form has been submitted or not. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:31:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:31:04 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-ts2SivQYST@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151390|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151405&action=edit Bug 33716: ILL Type Disclaimer - Staff Update the way Availability is handled Add the new type disclaimer workflow operation after Availability Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:31:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:31:07 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-rWkuZB9ch7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151391|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151406&action=edit Bug 33716: ILL Type Disclaimer - OPAC Update the way Availability is handled Add the new type disclaimer workflow operation after Availability Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:31:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:31:10 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-YbCHeo1cK1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151392|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151407&action=edit Bug 33716: Tests Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:31:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:31:13 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-bRLNaOecXQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151393|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151408&action=edit Bug 33716: (follow-up) Amend system preference descrpition and improve formatting This adds some documentation for the different options presented in the example YAML entry and improves formatting a little for better readability of the example. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:31:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:31:16 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-rKUJfqounN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151394|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151409&action=edit Bug 33716: (follow-up) Add cancel links and update breadcrumbs For both staff interface and OPAC: * Update breadcrumbs to have a new entry for the page * Rename button From Next to submit * Add a cancel link to back out Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:31:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:31:20 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-T52xt8keay@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151402|0 |1 is obsolete| | --- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151410&action=edit Bug 33716: (follow-up) Move sysprefs to new Workflow sub heading Move ILLModuleCopyrightClearance, ILLCheckAvailability, and ILLModuleDisclaimerByType sys prefs State that ILLModuleCopyrightClearance is OPAC only in its description Correct 'bold' reference in ILLModuleDisclaimerByType description -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:33:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:33:07 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-m0xmhBQ80r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151410|0 |1 is obsolete| | --- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151411&action=edit Bug 33716: (follow-up) Move sysprefs to new Workflow sub heading Move ILLModuleCopyrightClearance, ILLCheckAvailability, and ILLModuleDisclaimerByType sys prefs State that ILLModuleCopyrightClearance is OPAC only in its description Correct 'bold' reference in ILLModuleDisclaimerByType description Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:51:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:51:16 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-C68WGPBvKW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Remote branch is up to date and working on sandboxes at the moment.. # Test plan 1) Navigate to a biblio with at least one item attached 2) Navigate to the 'Items' tab for that biblio 3) Mark at least one item as 'Bookable' using the new select box 4) Note that a new 'Place booking' button should appear in the biblio toolbar 5) Confirm the button triggers a modal dialog allowing one to select a patron, item and booking period 6) Confirm that when creating subsequent bookings the booking period select greys out booking dates that would lead to overlapping bookings 7) Note the new 'Bookings' page available from the left menu 8) Confirm bookings appear correctly in both the table and timelines on this new page 9) Confirm cancelling a booking from the table updates both the table and timeline view 10) Click a booking on the timeline view and note it highlights in yellow and a read cross appears next to it 11) Confirm that clicking the red cross triggers the same cancellation confirmation as above 12) Confirm that is confirmed, the cancellation removes the booking from both the table and timeline 13) Click another booking on the timeline view and now attempt to drag the booking around to edit it 14) Confirm the booking cannot overlap with another booking on the same item 15) Attempt to checkout an item with a booking to a user other than the user who booked the item 16) Confirm that if the checkout would overlap the booking period you are notified of the clash and 16a) Blocked if you do not have permissions to override 16b) Asked to confirm a shorter loan period to ensure the item is returned to fulfil the booking promptly 17) Attempt to checkout an item with a booking to the user the booking is for (but prior to, but close to the booking period) and 17a) Confirm that if you can override the block, you are asked if you wish to checkout early 17b) Confirm that you are blocked from checkout if you are not allowed to override 18) Attempt to checkout the item to the user owning the booking during the booking period 19) Confirm the due date matches the end of the booked period -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:51:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:51:25 +0000 Subject: [Koha-bugs] [Bug 33764] New: Accessibility: Fix ambiguous form-field in masthead.inc Message-ID: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33764 Bug ID: 33764 Summary: Accessibility: Fix ambiguous form-field in masthead.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: matt.blenkinsop at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The form field for "muserid" is called Login. This is confusing for screen readers and has been flagged as non-compliant in an accessibility report carried out for the British Museum. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:55:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:55:10 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-srRT013yEx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds the option to add release notes| |additional user defined | |fields to the order lines | |in the acquisition module. | |The fields can be yet up as | |free text fields or pull | |down lists driven by | |authorised values. They can | |also pull information from | |the MARC record or allow | |you to create and edit a | |field in the MARC record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:55:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:55:16 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-44VizzTGp5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:55:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:55:31 +0000 Subject: [Koha-bugs] [Bug 33764] Accessibility: Fix ambiguous form-field in masthead.inc In-Reply-To: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33764-70-C0l9uvefbv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33764 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151412&action=edit Bug 33764: Fix ambiguous "Login" field This patch changes the use of "Login" to "Username" to assist with screen reading Test plan: 1) In the masthead, click Log in to your account 2) On the modal, the first input should be labelled Username -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:56:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:56:02 +0000 Subject: [Koha-bugs] [Bug 33764] Accessibility: Fix ambiguous form-field in masthead.inc In-Reply-To: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33764-70-BaN4AZHaSP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33764 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Blocks| |23003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:56:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:56:02 +0000 Subject: [Koha-bugs] [Bug 23003] Accessibility improvements In-Reply-To: <bug-23003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23003-70-M56Y214OLO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33764 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33764 [Bug 33764] Accessibility: Fix ambiguous form-field in masthead.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:56:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:56:35 +0000 Subject: [Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers In-Reply-To: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33761-70-yVMzpcUy8z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151386|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151413&action=edit Bug 33761: Unit test Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:56:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:56:37 +0000 Subject: [Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers In-Reply-To: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33761-70-HcdbJlZKoB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151387|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151414&action=edit Bug 33761: Alter query to remove items with active transfers from available list Current code removes all items without an active transfer, and any with completed transfers. This patch moves the conditionals for transfers into the join, then adds a new condition to remove items with active transfers. To test: 1 - Apply unit test patch only 2 - prove -v t/db_dependent/HoldsQueue.t 3 - It fails 4 - Apply second patch 5 - prove -v t/db_dependent/HoldsQueue.t 6 - Success! Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:56:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:56:46 +0000 Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content warnings' to catalogue records In-Reply-To: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31123-70-IoYt3yUekl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature allows |This new feature allows release notes|librarians to pick a note |librarians to pick a note |field to use to store |field to use to store |'Content warnings' about |'Content warnings' about |biblio records. |biblio records. | | |The new |The new |`ContentWarningField` |`ContentWarningField` |system preference can be |system preference can be |set to any MARC field, |set to any MARC field, |though for MARC21 an 59X is |though for MARC21 an 59X is |recommended. One can then |recommended. One can add |add said field to the |said field to the |frameworks and it will be |frameworks and it will be |displayed appropriately |displayed appropriately |with the label 'Content |with the label 'Content |warning:' in OPAC and Staff |warning:' in OPAC and staff |interfaces on both detail |interface on both detail |and results pages. We hide |and results pages. We hide |subfield x from the OPAC as |subfield x from the OPAC as |it is often used as a |it is often used as a |'private note' in other |'private note' in other |note fields and we also |note fields and we also |handle turning the content |handle turning the content |of a 'u' subfield into a |of a 'u' subfield into a |clickable link if you wish |clickable link if you wish |to use that. Other |to use that. Other |subfields as just displayed |subfields as just displayed |in line when present. |in line when present. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:58:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:58:27 +0000 Subject: [Koha-bugs] [Bug 33765] New: Accessibility: Fix ambiguous form-field in opac-main.inc Message-ID: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33765 Bug ID: 33765 Summary: Accessibility: Fix ambiguous form-field in opac-main.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: matt.blenkinsop at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The form field for "userid" is called Login. This is confusing for screen readers and has been flagged as non-compliant in an accessibility report carried out for the British Museum. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:58:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:58:50 +0000 Subject: [Koha-bugs] [Bug 33765] Accessibility: Fix ambiguous form-field in opac-main.inc In-Reply-To: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33765-70-EvC9qtqPWm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33765 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23003 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33764 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:58:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:58:50 +0000 Subject: [Koha-bugs] [Bug 23003] Accessibility improvements In-Reply-To: <bug-23003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23003-70-I409kgT3Xa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33765 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33765 [Bug 33765] Accessibility: Fix ambiguous form-field in opac-main.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 14:58:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 12:58:50 +0000 Subject: [Koha-bugs] [Bug 33764] Accessibility: Fix ambiguous form-field in masthead.inc In-Reply-To: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33764-70-JlHlzCkXxK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33764 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33765 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:01:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:01:27 +0000 Subject: [Koha-bugs] [Bug 33765] Accessibility: Fix ambiguous form-field in opac-main.inc In-Reply-To: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33765-70-lywqcIXYUg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33765 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151415&action=edit Bug 33765: Fix ambiguous "Login" field This patch changes the use of "Login" to "Username" to assist with screen reading Test plan: 1) On the OPAC main page, the log in form should now have the first field labelled as Username, not Login -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:01:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:01:46 +0000 Subject: [Koha-bugs] [Bug 33765] Accessibility: Fix ambiguous form-field in opac-main.inc In-Reply-To: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33765-70-IOeq7HcT0q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33765 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:02:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:02:55 +0000 Subject: [Koha-bugs] [Bug 33766] New: Accessibility: Fix ambiguous form-field in opac-auth.tt Message-ID: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Bug ID: 33766 Summary: Accessibility: Fix ambiguous form-field in opac-auth.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: matt.blenkinsop at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The form field for "userid" is called Login. This is confusing for screen readers and has been flagged as non-compliant in an accessibility report carried out for the British Museum. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:03:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:03:38 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-W1i1R8aP9y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23003 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33764, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33765 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:03:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:03:38 +0000 Subject: [Koha-bugs] [Bug 23003] Accessibility improvements In-Reply-To: <bug-23003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23003-70-8W9r7dZLxf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33766 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:03:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:03:38 +0000 Subject: [Koha-bugs] [Bug 33764] Accessibility: Fix ambiguous form-field in masthead.inc In-Reply-To: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33764-70-fTe0ffTc22@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33764 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33766 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:03:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:03:38 +0000 Subject: [Koha-bugs] [Bug 33765] Accessibility: Fix ambiguous form-field in opac-main.inc In-Reply-To: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33765-70-AGWgr6Zsgh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33765 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33766 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:03:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:03:55 +0000 Subject: [Koha-bugs] [Bug 33765] Accessibility: Fix ambiguous form-field in opac-main.tt In-Reply-To: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33765-70-cVF8ZsSzck@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33765 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accessibility: Fix |Accessibility: Fix |ambiguous form-field in |ambiguous form-field in |opac-main.inc |opac-main.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:06:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:06:17 +0000 Subject: [Koha-bugs] [Bug 32426] Make userid generation pluggable In-Reply-To: <bug-32426-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32426-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32426-70-L32Oa8E4Vq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32426 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This adds a new plugin hook release notes| |`patron_generate_userid` | |that allows to have a | |custom method for | |generating the userid on a | |patron record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:08:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:08:35 +0000 Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's account In-Reply-To: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21043-70-wbiDc2oxJe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature adds the |This new feature adds the release notes|ability to add debits to a |ability to add debits to a |patrons account via API. |patron's account via the | |REST API. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:09:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:09:30 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-dLumtzZuBE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151416&action=edit Bug 33766: Fix ambiguous "Login" field This patch changes the use of "Login" to "Username" to assist with screen reading Test plan: 1) On the OPAC homepage, click on Lists in the top left 2) Click Log in to create your own lists 3) The login form should have the first field labelled as Username, not Login -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:10:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:10:02 +0000 Subject: [Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers In-Reply-To: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33761-70-wDkV9RccIH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks for the prompt fix here Nick. Tested and working.. kinda silly I missed it until now. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:10:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:10:11 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-DQdeCBqgX6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:10:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:10:13 +0000 Subject: [Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers In-Reply-To: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33761-70-K8YKj8zjwQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:12:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:12:24 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-9l9TAtkBuG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #27 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Martin, I'm testing in the sandbox. At step 5 (click Place booking button) the modal has an empty dropdown for the patron. http://staff-bug29002.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=285&itemnumber=631#item631 Is there something I should activate for patrons to appear in there? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:15:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:15:01 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-xZ79UQV6jT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This brings the catalog release notes| |concerns feature to the | |OPAC and staff interface | |allowing non-cataloguers to | |report issues with catalog | |records from the record | |details page. | |Reported | |concerns will be visible in | |the dashboard on the staff | |interface start page. | |The | |feature can be enabled for | |OPAC and staff interface | |separately using the | |`OpacCatalogConcerns` and | |`CatalogConcerns` system | |preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:19:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:19:42 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-2StMRzQwD9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds a GET endpoint to release notes| |the REST API that allows to | |request a list of | |authorities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:19:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:19:43 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-cm0vv0VyX7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This brings the catalog |This brings a new catalog release notes|concerns feature to the |concerns feature to the |OPAC and staff interface |OPAC and staff interface, |allowing non-cataloguers to |allowing non-cataloguers to |report issues with catalog |report issues with catalog |records from the record |records from the record |details page. |details pages. |Reported | |concerns will be visible in |Reported |the dashboard on the staff |concerns will be visible in |interface start page. |the dashboard on the staff |The |interface start page and |feature can be enabled for |available from the |OPAC and staff interface |cataloguing home page. |separately using the | |`OpacCatalogConcerns` and |The |`CatalogConcerns` system |feature can be |preferences. |independently enabled for | |OPAC and staff interface | |using the | |`OpacCatalogConcerns` and | |`CatalogConcerns` system | |preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:20:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:20:32 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31799-70-lW8McgLWRU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds a PUT endpoint release notes| |for updating items to the | |REST API. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:21:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:21:13 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31798-70-RhaiDOxiL5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds a POST endpoint release notes| |to add items to a | |bibliographic record to the | |REST API. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:21:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:21:51 +0000 Subject: [Koha-bugs] [Bug 31797] REST API: DELETE endpoint for Items In-Reply-To: <bug-31797-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31797-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31797-70-kGjJXFn9io@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31797 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds a DELETE endpoint release notes| |to allow for deleting items | |to the REST API. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:22:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:22:44 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-wJIotrLcoA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151384|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151417&action=edit Bug 33313: Fix catalog links in TICKET_NOTIFY This fixes the system preference name from IntranetBaseURL to staffClientBaseURL. As this feature has just been pushed I chose to fix the database updates that will be run when installing 23.05. To test: * Verify the wrong link in TICKET_NOTIFY * Drop database, create database, run web installer * Verify the link is now correct in the notice Bonus: Test update from 22.11 to 23.05 and verify the notices are correct there as well. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:23:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:23:09 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-jCYjUwlee6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:25:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:25:15 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-ixfxo7smmv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:25:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:25:35 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-A0e4vxhWlx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- My mistake.. sure it was intranet at some point.. or I'm going mad. Passing QA anyway -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:28:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:28:27 +0000 Subject: [Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers In-Reply-To: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33761-70-Fxo90LVKwU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- As this is critical.. lets go straight for PQA here.. It's a clear and simple fix with solid unit tests. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:28:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:28:31 +0000 Subject: [Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers In-Reply-To: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33761-70-DgCbE53Sxm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:29:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:29:59 +0000 Subject: [Koha-bugs] [Bug 25655] Additionally store actual cost in foreign currency and currency from the invoice In-Reply-To: <bug-25655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25655-70-v5luCtrxWT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |When receiving an item with release notes| |a price in a foreign | |currency, you already had | |the option to calculate the | |price in the active | |currency, but the original | |price and currency were not | |stored. They will now be | |stored in | |`invoice_unitprice` and | |`invoice_currency` in the | |`aqorders` table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:30:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:30:48 +0000 Subject: [Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice In-Reply-To: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33314-70-iGnKIiMIrG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:31:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:31:00 +0000 Subject: [Koha-bugs] [Bug 32705] Display actual cost in foreign currency and currency from the invoice In-Reply-To: <bug-32705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32705-70-4S14JA22Qy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The original price of an release notes| |order in a foreign currency | |and the currency will now | |display on the invoice | |summary page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:34:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:34:07 +0000 Subject: [Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice In-Reply-To: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33314-70-2vmUy1aUCN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150144|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151418&action=edit Bug 33314: Fix link into staff catalog and link text Both fixes concern the TICKET_NOTIFY message. * biblio-title.inc builds a link with the intention of using it inside the Koha GUI. Therefore the baseURL part is missing. But we can use it for display and wrap it into a link. * Changes second link from reading 'page' to 'concern management page'. Accessiblity guidelines teach us that you should not link general terms, but always be specific. To test: 1. Make sure staffClientBaseURL is filled correctly 2. Enable CatalogConcerns 3. Enter an email address in CatalogerEmails 4. Go to a bibliographic record in the staff interface or in the OPAC 5. Click New > New catalog concern 6. Fill out the form and click Submit 7. Check the message_queue table for the message 8. Verify the first link is not working (incomplete) and the second is 'page' 9. Apply patch, drop db, create db and run web installer 10. Repeat setup and testing 11. Both links should now be updated and working Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:34:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:34:32 +0000 Subject: [Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice In-Reply-To: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33314-70-1L5p7kbd99@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work Katrin, thank you very much for these fixes! Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:39:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:39:09 +0000 Subject: [Koha-bugs] [Bug 32452] Link basket group name from basket summary page In-Reply-To: <bug-32452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32452-70-NHQ1k6FlmP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32452 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Adds a link to the basket release notes| |group page from the basket | |summary page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:39:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:39:56 +0000 Subject: [Koha-bugs] [Bug 29935] Add option to search in archived suggestions to all search tabs In-Reply-To: <bug-29935-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29935-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29935-70-rvrQh6YXRC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29935 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds a checkbox release notes| |'Include archived' to all | |of the search filter tabs | |for suggestions in the | |staff interface. Summary|Add option to search in |Add option to search in |archive to all information |archived suggestions to all |tabs |search tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:41:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:41:02 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-HkBksG4Lzc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement enables |This enhancement enables release notes|the use of framework |the use of framework |plugins when: |plugins when: |- |- |UseACQFrameworkForBiblioRec |`UseACQFrameworkForBiblioRe |ords is enabled, and |cords` is enabled, and |- |- |entering catalog details |entering catalog details |when adding items to a |when adding items to a |basket from a new (empty) |basket from a new (empty) |record. |record. |This requires |This requires |plugins to be enabled for |plugins to be enabled for |fields in the ACQ |fields in the `ACQ` |framework. |framework. Keywords|rel_22_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:42:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:42:06 +0000 Subject: [Koha-bugs] [Bug 33098] Revert suggestion status to 'Accepted' when orders made from a suggestion are cancelled In-Reply-To: <bug-33098-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33098-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33098-70-eZHZe4GoIk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement will release notes| |revert the status of a | |suggestion from `ORDERED` | |to `ACCEPTED` when an order | |made from a suggestion is | |cancelled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:44:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:44:45 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-uQ2qciuy3G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This allows to create release notes| |aliases for a vendor. The | |aliases can be former names | |or different spellings of | |the name. Once added they | |will display on the vendor | |detail page. And they will | |be included in search when | |searching by a vendor's | |name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:45:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:45:14 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-YGDa9nr6kN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:45:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:45:21 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-dL8uxViwVh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:49:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:49:43 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-f4dRDtQ3Xc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds the ability to release notes| |create interfaces for | |vendors. | |An interface is a | |website, software, or | |portal that you use to | |manage orders or gather | |statistics from the vendor | |or organisation. Interfaces | |can also include usernames | |and passwords, that will be | |encrypted for storage, but | |can be decrypted and made | |visible in the staff | |interface. | |The type of an | |interface can be set using | |the `VENDOR_INTERFACE_TYPE` | |authorised values category. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:50:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:50:58 +0000 Subject: [Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion In-Reply-To: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33541-70-Ako48QqTAN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The 'Document type' of a release notes| |suggestion will now be | |visible in the list of | |accepted suggestions when | |creating a new order line. | |This is to help with | |ordering the right material | |type and also for picking | |the correct item type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:51:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:51:20 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-KeG49QTOCs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Matt Blenkinsop from comment #0) > has been flagged as non-compliant in an accessibility report > carried out for the British Museum. What is problematic screen reader behavior? It seems wrong to me that the screen reader should care what name or id the field has as long as it has an associated label. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:52:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:52:42 +0000 Subject: [Koha-bugs] [Bug 33340] Correct formatting of English 1-page order PDF when the basket group covers multiple pages In-Reply-To: <bug-33340-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33340-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33340-70-NaCGImTy2G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |If a basket group contains release notes| |many order lines, this will | |ensure: | | * The page number | |at the bottom of the first | |page is not obscured. | | * | |The table of ordered items | |does not start half way | |down the second page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:52:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:52:52 +0000 Subject: [Koha-bugs] [Bug 33767] New: Accessibility: The 'OPAC results' page contains semantically incorrect headings Message-ID: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33767 Bug ID: 33767 Summary: Accessibility: The 'OPAC results' page contains semantically incorrect headings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: matt.blenkinsop at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The OPAC results page contains an illogical skip from an H2 to H6 through the injection of page-numbers.inc. This can be replaced with a span with a class of h6 to maintain formatting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:53:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:53:44 +0000 Subject: [Koha-bugs] [Bug 33767] Accessibility: The 'OPAC results' page contains semantically incorrect headings In-Reply-To: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33767-70-au5Ee3ar3G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33767 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25150 Assignee|oleonard at myacpl.org |matt.blenkinsop at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25150 [Bug 25150] Accessibility: 2.4.10 Section Headings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:53:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:53:44 +0000 Subject: [Koha-bugs] [Bug 25150] Accessibility: 2.4.10 Section Headings In-Reply-To: <bug-25150-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25150-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25150-70-XVBibV5VUd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25150 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33767 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33767 [Bug 33767] Accessibility: The 'OPAC results' page contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:54:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:54:06 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-3OMmkojMep@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |matt.blenkinsop at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:54:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:54:15 +0000 Subject: [Koha-bugs] [Bug 33765] Accessibility: Fix ambiguous form-field in opac-main.tt In-Reply-To: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33765-70-mU3VLPKOHb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33765 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |matt.blenkinsop at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:54:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:54:24 +0000 Subject: [Koha-bugs] [Bug 33764] Accessibility: Fix ambiguous form-field in masthead.inc In-Reply-To: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33764-70-5XPHSrGwTJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33764 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |matt.blenkinsop at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:54:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:54:46 +0000 Subject: [Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers In-Reply-To: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33761-70-SuVTZCOp58@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:54:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:54:48 +0000 Subject: [Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers In-Reply-To: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33761-70-LtYRxrHz4N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:56:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:56:50 +0000 Subject: [Koha-bugs] [Bug 30642] We should record the renewal type (automatic/manual) In-Reply-To: <bug-30642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30642-70-H8Gq0hEJKq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30642 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com, | |kyle.m.hall at gmail.com Text to go in the| |This ensures that the type release notes| |of a renewal, automatic or | |manual, is stored in the | |new column `renewal_type` | |of the `checkout_renewals` | |table. Component|Architecture, internals, |Circulation |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:58:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:58:05 +0000 Subject: [Koha-bugs] [Bug 33767] Accessibility: The 'OPAC results' page contains semantically incorrect headings In-Reply-To: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33767-70-a8viRHOR3c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33767 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151419&action=edit Bug 33767: Fix incorrect heading in page-numbers.inc This patch replaces an h6 with a span to avoid a jump from h2 to h6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 15:58:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 13:58:16 +0000 Subject: [Koha-bugs] [Bug 33767] Accessibility: The 'OPAC results' page contains semantically incorrect headings In-Reply-To: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33767-70-6CTuIiUt4Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33767 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:04:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:04:30 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-CunNZQHmOi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:04:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:04:32 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-rzunrDymoa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:04:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:04:34 +0000 Subject: [Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice In-Reply-To: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33314-70-WoJEApeZu9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:04:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:04:36 +0000 Subject: [Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice In-Reply-To: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33314-70-N0GyFd4iFm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:04:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:04:37 +0000 Subject: [Koha-bugs] [Bug 33421] Filtering purchase suggestions by status does not work if All Libraries is selected In-Reply-To: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33421-70-Mx4pouuavL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33421 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:04:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:04:39 +0000 Subject: [Koha-bugs] [Bug 33421] Filtering purchase suggestions by status does not work if All Libraries is selected In-Reply-To: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33421-70-axNHINnrKx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33421 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:04:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:04:41 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-fPFKrtujwv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:04:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:04:43 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-lgmkDbH3kM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 --- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:04:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:04:45 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-793tiu4lYW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:04:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:04:47 +0000 Subject: [Koha-bugs] [Bug 33686] Update plugin unimarc_field_100.pl 'Script of title' with 2022 values In-Reply-To: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33686-70-hq4MxOCLh4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33686 --- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:04:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:04:48 +0000 Subject: [Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order In-Reply-To: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33721-70-aqYrJFXnqM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:04:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:04:50 +0000 Subject: [Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order In-Reply-To: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33721-70-BS1Pw37HfR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:05:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:05:02 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-u2Gk4vF2Ny@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This moves the last seen release notes| |date in | |`items.datelastseen` from a | |date to a datetime, meaning | |that now not only the date, | |but also the time will be | |recorded. Component|Architecture, internals, |Cataloging |and plumbing | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:07:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:07:29 +0000 Subject: [Koha-bugs] [Bug 32057] Add optional stack trace to action logs In-Reply-To: <bug-32057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32057-70-pCaZtsDoJI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32057 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|It can be useful to know |It can be useful to know release notes|where in Koha a logged |where in Koha a logged |action was generated from, |action was generated from, |and how. This enhancement |and how. This enhancement |adds stack traces to action |adds stack traces to action |logs. To use, add a number |logs. To use, add a number |for the trace depth (such |for the trace depth (such |as 3) to the new system |as 3) to the new system |preference |preference |ActionLogsTraceDepth. The |`ActionLogsTraceDepth`. The |details for the stack trace |details for the stack trace |are available by querying |are available by querying |the database, for example: |the database, for example: |SELECT * FROM action_logs | |WHERE trace IS NOT NULL; |`SELECT * FROM action_logs | |WHERE trace IS NOT NULL;` Component|Architecture, internals, |Reports |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:08:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:08:26 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32609-70-9xdyUbXWpd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This important |This important release notes|architectural change |architectural change |removes the built css and |removes the built CSS and |javascript files from |JavaScript files from |source control and |source control and |introduces a build process |introduces a build process |and trigger into our |and trigger into our |packaging routines. |packaging routines. | |This |This |will both save space in the |will both save space in the |repository and lead to less |repository and lead to less |mistakes from developers by |mistakes from developers by |dropping the need to build, |dropping the need to build, |add and commit these files |add and commit these files |at release time. |at release time. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:08:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:08:57 +0000 Subject: [Koha-bugs] [Bug 33031] Update OPAC lists page to use Bootstrap markup for tabs In-Reply-To: <bug-33031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33031-70-7ZZVcBOR1M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Templates |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:09:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:09:04 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-vIad7AO4U7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:11:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:11:49 +0000 Subject: [Koha-bugs] [Bug 23656] Add search box at the top of the cataloging editor page In-Reply-To: <bug-23656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23656-70-OVAnt9NfXM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds the search header release notes| |to the cataloging editor | |page. With the recent staff | |interface redesign, this | |takes up very little space. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:14:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:14:51 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-stzmSgBCnM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> --- reset_all && multitime -n 10 prove t/db_dependent/Koha Just Master: 1: prove t/db_dependent/Koha Mean Std.Dev. Min Median Max real 129.754 3.631 121.324 130.872 134.770 user 107.146 2.759 100.859 108.025 111.129 sys 17.488 0.720 15.979 17.469 18.793 Master + 32890: 1: prove t/db_dependent/Koha Mean Std.Dev. Min Median Max real 128.499 4.333 123.117 127.620 139.403 user 106.268 3.456 102.384 105.515 114.984 sys 17.237 0.992 15.540 17.337 19.357 I'm no statistician so take from this what you will. I think it's generally positive. Lower average with the patches but a higher standard deviation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:16:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:16:26 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-OQW0SiXA7H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:19:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:19:17 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-HrZoXWifc1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Sponsored by CLiC (Colorado |**Sponsored by** *CLiC release notes|Library Consortium). |(Colorado Library | |Consortium)* | | | |This adds | |the ability to limit item | |editing to staff users from | |libraries within a specific | |library group. This is done | |via a new option when | |creating item groups. There | |is also a new system | |preference `edit_any_item` | |that permits users to edit | |all items on a record | |independent of the library | |groups and their own home | |library. Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:24:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:24:39 +0000 Subject: [Koha-bugs] [Bug 33742] Add permission to circumvent HidePatronName syspref In-Reply-To: <bug-33742-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33742-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33742-70-eU1g0ylzCa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33742 --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #1) > Or maybe the syspref HidePatronName could be updated to have a third option > of "only show names to staff with edit_borrowers permission"? Either this or shift HidePatronName into it's own permission so libraries can have more control over which staff see names or not? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:25:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:25:29 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-bUbobmYJoH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 --- Comment #42 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Matt, could you please complete my entry for this on https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:26:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:26:21 +0000 Subject: [Koha-bugs] [Bug 33767] Accessibility: The 'OPAC results' page contains semantically incorrect headings In-Reply-To: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33767-70-E9MbaNFdGv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33767 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:26:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:26:24 +0000 Subject: [Koha-bugs] [Bug 33767] Accessibility: The 'OPAC results' page contains semantically incorrect headings In-Reply-To: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33767-70-sISiIsT4i4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33767 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151419|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151420&action=edit Bug 33767: Fix incorrect heading in page-numbers.inc This patch replaces an h6 with a span to avoid a jump from h2 to h6. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:28:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:28:32 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30358-70-uXexDiAZWj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds a new system release notes| |preference | |`StripWhitespaceChars` | |which, when enabled, will | |strip leading and trailing | |whitespace characters from | |all fields when cataloguing | |both bibliographic records | |and authority records. | |Whitespace characters that | |will be stripped are: | | * | |spaces | | * newlines | | * | |carriage returns | | * tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:29:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:29:43 +0000 Subject: [Koha-bugs] [Bug 30930] Ability to change authority type while editing record In-Reply-To: <bug-30930-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30930-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30930-70-znbOozsDP6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30930 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds the ability to release notes| |change the MARC authority | |type/framework used while | |editing an authority | |record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:30:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:30:20 +0000 Subject: [Koha-bugs] [Bug 33768] New: We need tests for the OAuth2/OIDC client Message-ID: <bug-33768-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33768 Bug ID: 33768 Summary: We need tests for the OAuth2/OIDC client Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:30:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:30:27 +0000 Subject: [Koha-bugs] [Bug 32766] Update plugin unimarc_field_116.pl fields In-Reply-To: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32766-70-E8dJOTdLpf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32766 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Cataloging |MARC Bibliographic data | |support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:31:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:31:15 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-qWHIHQpHGY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 --- Comment #18 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151421&action=edit Screenshot of sorting after Forgive the silly example, but "alternate: shifted" ignores punctuation and whitespace. Do we want white space considered? i.e. is it correct for 'Santabna' to sort before 'Santa clarita'? I would expect: Santa Ana Santa Clarita Santa Claus Santabna Santana, Carlos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:31:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:31:22 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-evCXMIC42v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:32:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:32:08 +0000 Subject: [Koha-bugs] [Bug 33365] Add item type column to call number browser's results table In-Reply-To: <bug-33365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33365-70-VSwrkTKhDX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33365 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add item type column to |Add item type column to |cn_browser results table |call number browser's | |results table Text to go in the| |This adds a new column for release notes| |the item type to the | |results list of the | |cn_browser.pl value builder | |that can be linked to the | |subfield for the | |callnumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:32:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:32:39 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff interface catalog details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-mmkXmc67GQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Cataloging |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:32:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:32:52 +0000 Subject: [Koha-bugs] [Bug 33768] We need tests for the OAuth2/OIDC client In-Reply-To: <bug-33768-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33768-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33768-70-l5N1py46rk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33768 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au, | |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- When the feature was developed, we didn't find a way to make tests for it. All testing was done against live servers (that's why the `--sso` switch was added to `ktd`. There's a Mock targert server in the Mojolicious::Plugin::OAuth2 library we could try, or maybe it would require ad-hoc mocking. Not sure, ideas/patches welcome. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:33:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:33:27 +0000 Subject: [Koha-bugs] [Bug 33768] We need tests for the OAuth2/OIDC client In-Reply-To: <bug-33768-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33768-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33768-70-rzXl9joEUy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33768 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33675 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:33:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:33:27 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-IZLcbfRV0D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33768 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:35:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:35:22 +0000 Subject: [Koha-bugs] [Bug 33353] Add compatibility with Elasticsearch 8 In-Reply-To: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33353-70-WRqNNOnshO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33353 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- I think before this is pushed we need a way for those using ES7 to remove the type parameter, and continue to use Koha. With these patches, the upgrade would require: Upgrade Koha Upgrade ES Reindex ES I'd like to see a path of: Reindex Koha on ES 7 to remove type then either: Upgrade Koha Upgrade ES Making the upgrade of Koha force the ES upgrade without allowing it before feels like it could cause issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:35:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:35:42 +0000 Subject: [Koha-bugs] [Bug 23773] Send MEMBERSHIP_EXPIRY notice by SMS In-Reply-To: <bug-23773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23773-70-Fj6yxUN9Zi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23773 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:35:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:35:44 +0000 Subject: [Koha-bugs] [Bug 23773] Send MEMBERSHIP_EXPIRY notice by SMS In-Reply-To: <bug-23773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23773-70-RlxGb3GgJL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23773 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:35:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:35:46 +0000 Subject: [Koha-bugs] [Bug 29993] Syndetics cover images do not display in browse shelf when scrolling from the first page In-Reply-To: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29993-70-GxybB5UPad@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:35:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:35:48 +0000 Subject: [Koha-bugs] [Bug 29993] Syndetics cover images do not display in browse shelf when scrolling from the first page In-Reply-To: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29993-70-ZwNbqO8Xog@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:35:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:35:49 +0000 Subject: [Koha-bugs] [Bug 32959] Item Templates will apply the same barcode each time template is applied if autobarcode is enabled In-Reply-To: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32959-70-f4DLI3MOCk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32959 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:35:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:35:51 +0000 Subject: [Koha-bugs] [Bug 32959] Item Templates will apply the same barcode each time template is applied if autobarcode is enabled In-Reply-To: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32959-70-u8znBYL0i1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32959 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:35:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:35:53 +0000 Subject: [Koha-bugs] [Bug 33010] CheckinSlip doesn't return checkins if checkout branch and checkin branch differ In-Reply-To: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33010-70-h7dcYTibeQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:35:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:35:55 +0000 Subject: [Koha-bugs] [Bug 33010] CheckinSlip doesn't return checkins if checkout branch and checkin branch differ In-Reply-To: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33010-70-3eghWRCakL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:35:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:35:57 +0000 Subject: [Koha-bugs] [Bug 33138] Don't copy tag 147 to MARC frameworks, since it should only be in a manually-created NAME_EVENT framework In-Reply-To: <bug-33138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33138-70-h7JoNF2wEj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33138 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:35:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:35:59 +0000 Subject: [Koha-bugs] [Bug 33138] Don't copy tag 147 to MARC frameworks, since it should only be in a manually-created NAME_EVENT framework In-Reply-To: <bug-33138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33138-70-S6kAiXPMBL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33138 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:36:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:36:01 +0000 Subject: [Koha-bugs] [Bug 33246] itemBarcodeFallbackSearch search results should show whether or not items are available In-Reply-To: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33246-70-2PLBYwR2vE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33246 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:36:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:36:03 +0000 Subject: [Koha-bugs] [Bug 33246] itemBarcodeFallbackSearch search results should show whether or not items are available In-Reply-To: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33246-70-7b18zL5qkx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33246 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:36:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:36:05 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-RbOQaybUTH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:36:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:36:07 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-tHhFm6BJfy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 --- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:36:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:36:09 +0000 Subject: [Koha-bugs] [Bug 33713] Report batch operations should open in new tab In-Reply-To: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33713-70-bZrlZGWgfW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33713 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:36:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:36:11 +0000 Subject: [Koha-bugs] [Bug 33713] Report batch operations should open in new tab In-Reply-To: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33713-70-mV0ywmvWS4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33713 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:36:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:36:20 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-96kU2sXCLU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 --- Comment #43 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- You beat me to it, I requested my wiki account last night to add it to the list and hadn't got round to logging in yet! I'll complete it as soon as I can log in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:37:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:37:51 +0000 Subject: [Koha-bugs] [Bug 33742] Add permission to circumvent HidePatronName syspref In-Reply-To: <bug-33742-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33742-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33742-70-uV1sHvjqfl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33742 --- Comment #3 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- I'm not averse to ditching the syspref entirely and creating a new see_patron_names permission. That seems a little trickier to handle at update -- if the updating system had the syspref set to show, then give the permission to all users with staff interface access? But once the update is complete, either approach seems equally usable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:38:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:38:15 +0000 Subject: [Koha-bugs] [Bug 33203] Overdue notice/status triggers letter selection is ambiguous In-Reply-To: <bug-33203-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33203-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33203-70-FVSzmBcOe5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33203 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:38:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:38:16 +0000 Subject: [Koha-bugs] [Bug 33203] Overdue notice/status triggers letter selection is ambiguous In-Reply-To: <bug-33203-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33203-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33203-70-5tTykUp6vs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33203 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:39:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:39:04 +0000 Subject: [Koha-bugs] [Bug 33769] New: Terminology: 'Warning: Item {barcode} is reserved' Message-ID: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33769 Bug ID: 33769 Summary: Terminology: 'Warning: Item {barcode} is reserved' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org 'is reserved' should be 'is on hold' Complete line is: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt .append(__x('Warning: Item {barcode} is reserved', { barcode })) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:39:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:39:42 +0000 Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content warnings' to catalogue records In-Reply-To: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31123-70-tUk6xUFNz7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature allows |**Sponsored by** *Tavistock release notes|librarians to pick a note |& Portman Library* |field to use to store | |'Content warnings' about |This |biblio records. |new feature allows | |librarians to pick a note |The new |field to use to store |`ContentWarningField` |'Content warnings' about |system preference can be |biblio records. |set to any MARC field, | |though for MARC21 an 59X is |The new |recommended. One can add |`ContentWarningField` |said field to the |system preference can be |frameworks and it will be |set to any MARC field, |displayed appropriately |though for MARC21 an 59X is |with the label 'Content |recommended. One can add |warning:' in OPAC and staff |said field to the |interface on both detail |frameworks and it will be |and results pages. We hide |displayed appropriately |subfield x from the OPAC as |with the label 'Content |it is often used as a |warning:' in OPAC and staff |'private note' in other |interface on both detail |note fields and we also |and results pages. We hide |handle turning the content |subfield x from the OPAC as |of a 'u' subfield into a |it is often used as a |clickable link if you wish |'private note' in other |to use that. Other |note fields and we also |subfields as just displayed |handle turning the content |in line when present. |of a 'u' subfield into a | |clickable link if you wish | |to use that. Other | |subfields as just displayed | |in line when present. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:40:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:40:00 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-7zKdP1HBgH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This brings a new catalog |**Sponsored by** *Tavistock release notes|concerns feature to the |& Portman Library* |OPAC and staff interface, | |allowing non-cataloguers to |This |report issues with catalog |brings a new catalog |records from the record |concerns feature to the |details pages. |OPAC and staff interface, | |allowing non-cataloguers to |Reported |report issues with catalog |concerns will be visible in |records from the record |the dashboard on the staff |details pages. |interface start page and | |available from the |Reported |cataloguing home page. |concerns will be visible in | |the dashboard on the staff |The |interface start page and |feature can be |available from the |independently enabled for |cataloguing home page. |OPAC and staff interface | |using the |The |`OpacCatalogConcerns` and |feature can be |`CatalogConcerns` system |independently enabled for |preferences. |OPAC and staff interface | |using the | |`OpacCatalogConcerns` and | |`CatalogConcerns` system | |preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:40:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:40:20 +0000 Subject: [Koha-bugs] [Bug 33769] Terminology: 'Warning: Item {barcode} is reserved' In-Reply-To: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33769-70-nHIxiuXtxY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33769 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:40:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:40:35 +0000 Subject: [Koha-bugs] [Bug 33021] Show an alert when adding an item on hold to an item bundle In-Reply-To: <bug-33021-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33021-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33021-70-8KLdLmiaVQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show an alert when adding a |Show an alert when adding |reserved item to an item |an item on hold to an item |bundle |bundle Text to go in the| |When adding an item that is release notes| |currently on hold to an | |item bundle, a warning will | |display, but you can still | |choose to add the item to | |the bundle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:40:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:40:52 +0000 Subject: [Koha-bugs] [Bug 33769] Terminology: 'Warning: Item {barcode} is reserved' In-Reply-To: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33769-70-xk3h28gJsS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33769 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Depends on| |33021 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 [Bug 33021] Show an alert when adding an item on hold to an item bundle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:40:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:40:52 +0000 Subject: [Koha-bugs] [Bug 33021] Show an alert when adding an item on hold to an item bundle In-Reply-To: <bug-33021-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33021-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33021-70-PkijLyI2v9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33769 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33769 [Bug 33769] Terminology: 'Warning: Item {barcode} is reserved' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:41:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:41:31 +0000 Subject: [Koha-bugs] [Bug 32959] Item templates will apply the same barcode each time template is applied if autobarcode is enabled In-Reply-To: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32959-70-Z93m8fdq52@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32959 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Item Templates will apply |Item templates will apply |the same barcode each time |the same barcode each time |template is applied if |template is applied if |autobarcode is enabled |autobarcode is enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:42:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:42:02 +0000 Subject: [Koha-bugs] [Bug 33010] CheckinSlip doesn't return checkins if checkout library and checkin library differ In-Reply-To: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33010-70-3CoDAxAUNb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|CheckinSlip doesn't return |CheckinSlip doesn't return |checkins if checkout branch |checkins if checkout |and checkin branch differ |library and checkin library | |differ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:42:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:42:42 +0000 Subject: [Koha-bugs] [Bug 33010] CheckinSlip doesn't return checkins if checkout library and checkin library differ In-Reply-To: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33010-70-9JGWl2a9lM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- It would be very nice if this one could be backported into 22.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:42:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:42:52 +0000 Subject: [Koha-bugs] [Bug 33138] Don't copy tag 147 to all MARC frameworks, since it should only be used in a separate NAME_EVENT framework In-Reply-To: <bug-33138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33138-70-N89X4RAXqJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33138 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Don't copy tag 147 to MARC |Don't copy tag 147 to all |frameworks, since it should |MARC frameworks, since it |only be in a |should only be used in a |manually-created NAME_EVENT |separate NAME_EVENT |framework |framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:43:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:43:31 +0000 Subject: [Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar In-Reply-To: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33064-70-FRRa1LhBzX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |**Sponsored by** *PTFS release notes| |Europe* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:43:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:43:57 +0000 Subject: [Koha-bugs] [Bug 33246] itemBarcodeFallbackSearch search results should show whether or not items are available In-Reply-To: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33246-70-07OELCoP7k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33246 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement Text to go in the| |This adds a label 'Checked release notes| |out' to the result list of | |items when using | |`itemBarcodeFallbackSearch` | |. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:44:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:44:09 +0000 Subject: [Koha-bugs] [Bug 31448] Add option to re-send email receipt when UseEmailReceipts is enabled In-Reply-To: <bug-31448-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31448-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31448-70-SRgWhpFy2i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |**Sponsored by** *PTFS release notes| |Europe* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:44:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:44:52 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-9ZXYB63mKS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement allows a |**Sponsored by** *PTFS release notes|user to select which debit |Europe* |types should be included in | |deciding whether a patron |This enhancement |should be restricted from |allows a user to select |checkouts (noissuescharge |which debit types should be |system preference). Three |included in deciding |existing system preferences |whether a patron should be |have been deleted |restricted from checkouts |(ManInvInNoissuesCharge, |(noissuescharge system |RentalsInNoissuesCharge, |preference). Three existing |HoldsInNoissuesCharge) and |system preferences have |the management of the debit |been deleted |types now sits in the Debit |(ManInvInNoissuesCharge, |Types area of system |RentalsInNoissuesCharge, |preferences. The user can |HoldsInNoissuesCharge) and |edit each debit type and |the management of the debit |select whether it should be |types now sits in the Debit |included in the |Types area of system |noissuescharge calculation, |preferences. The user can |giving users much more |edit each debit type and |flexibility over |select whether it should be |restrictions. |included in the | |noissuescharge calculation, | |giving users much more | |flexibility over | |restrictions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:45:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:45:28 +0000 Subject: [Koha-bugs] [Bug 21548] Make ILL patron category in koha-conf.xml match with ILL patron category in sample data In-Reply-To: <bug-21548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21548-70-FXzhkcPeK4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |**Sponsored by** *PTFS release notes| |Europe* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:45:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:45:48 +0000 Subject: [Koha-bugs] [Bug 33713] Report batch operations should open in new tab In-Reply-To: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33713-70-4erhIKFsUx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33713 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |When using the batch release notes| |operations from report | |results, the links to the | |batch tools will now open | |in a new tab instead of the | |same one, leaving the | |report results visible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:47:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:47:14 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31699-70-bHBYo6hIPH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds the |**Sponsored by** *The release notes|ability to redirect users |European Southern |back to where they were |Observatory* |when using the modal type | |logins in place of an |This |action that requires login |enhancement adds the |on the OPAC. |ability to redirect users | |back to where they were |Example: On |when using the modal type |the OPAC detail page you |logins in place of an |can add comments if logged |action that requires login |in. Prior to this patch, |on the OPAC. |clicking the link to add a | |comment prior to being |Example: On |logged in would expose the |the OPAC detail page you |login modal and then |can add comments if logged |re-direct you to your OPAC |in. Prior to this patch, |user page, and thus lose |clicking the link to add a |the context of your action. |comment prior to being | With this enhancement, you |logged in would expose the |are redirected back to the |login modal and then |record you were looking at |re-direct you to your OPAC |and can then post your |user page, and thus lose |comment. |the context of your action. | | With this enhancement, you | |are redirected back to the | |record you were looking at | |and can then post your | |comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:48:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:48:09 +0000 Subject: [Koha-bugs] [Bug 32125] Implement contextual return on OPAC comments In-Reply-To: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32125-70-1srkZqvqHN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement ensures |**Sponsored by** *PTFS release notes|patrons are returned to the |Europe* |correct biblio detail page | |after a login that is |This enhancement |prompted when attempting to |ensures patrons are |comment on a bilio. |returned to the correct | |biblio detail page after a | |login that is prompted when | |attempting to comment on a | |bilio. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:48:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:48:13 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-6YRaUZD4F1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 --- Comment #44 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Matt Blenkinsop from comment #43) > You beat me to it, I requested my wiki account last night to add it to the > list and hadn't got round to logging in yet! I'll complete it as soon as I > can log in :) It looks like David already moderated your request last night - could you please check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:49:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:49:42 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-drT0wXf83J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 --- Comment #19 from Heather <heather_hernandez at nps.gov> --- Hi! > Do we want white space considered? i.e. is it correct for 'Santabna' to sort > before 'Santa clarita'? It is not correct. The shorthand rule is "nothing before something." Therefore, "Santabna" should sort after "Santa Clarita." This is correct: > Santa Ana > Santa Clarita > Santa Claus > Santabna > Santana, Carlos The example that illustrates this is in 1.1.1 of the Library of Congress Filing Rules (cited above) (apologies for omited diacritics, but diacritical characters are filed as their non-diacritic English language equivalents): Hand blows Hand book for Prospect Park Hand in glove Handbok for sangere Handbook for adventure Hande im Pflug Hands in the past Handu --h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:50:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:50:14 +0000 Subject: [Koha-bugs] [Bug 33769] Terminology: 'Warning: Item {barcode} is reserved' In-Reply-To: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33769-70-IwFZfidAb9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33769 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:50:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:50:17 +0000 Subject: [Koha-bugs] [Bug 33769] Terminology: 'Warning: Item {barcode} is reserved' In-Reply-To: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33769-70-JYCeSFTB0Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33769 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151422&action=edit Bug 33769: Terminology: 'Warning: Item {barcode} is reserved' This patch corrects an instance of the term "reserved" and replaces it with "on hold." The string is shown when the user tries to add an item which is on hold to a bundle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:51:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:51:50 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29453-70-65sH3ycS1v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |**Sponsored by** *PTFS release notes| |Europe* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:52:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:52:41 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29453-70-L34eXfQje2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:54:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:54:42 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-z4CVDeoi7O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Sponsored by** *PTFS |**Sponsored by** *PTFS release notes|Europe* |Europe* | | |This enhancement |This enhancement |allows a user to select |allows a user to select |which debit types should be |which debit types should be |included in deciding |included in deciding |whether a patron should be |whether a patron should be |restricted from checkouts |restricted from checkouts |(noissuescharge system |(`noissuescharge` system |preference). Three existing |preference). Three existing |system preferences have |system preferences have |been deleted |been deleted |(ManInvInNoissuesCharge, |(`ManInvInNoissuesCharge`, |RentalsInNoissuesCharge, |`RentalsInNoissuesCharge`, |HoldsInNoissuesCharge) and |`HoldsInNoissuesCharge`) |the management of the debit |and the management of the |types now sits in the Debit |debit types now sits in the |Types area of system |Debit Types area of system |preferences. The user can |preferences. The user can |edit each debit type and |edit each debit type and |select whether it should be |select whether it should be |included in the |included in the |noissuescharge calculation, |`noissuescharge` |giving users much more |calculation, giving users |flexibility over |much more flexibility over |restrictions. |restrictions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:56:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:56:41 +0000 Subject: [Koha-bugs] [Bug 21548] Make ILL patron category in koha-conf.xml match with ILL patron category in sample data In-Reply-To: <bug-21548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21548-70-H06gHTanqo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Sponsored by** *PTFS |**Sponsored by** *PTFS release notes|Europe* |Europe* | | | |This makes sure, | |that in the future the | |Inter-Library Loan (IL) | |patron category of the | |sample data matches the | |default configuration of | |the ILL patron category in | |the `koha-conf.xml` file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:57:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:57:30 +0000 Subject: [Koha-bugs] [Bug 32125] Implement contextual return on OPAC comments In-Reply-To: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32125-70-EAw7aEXj4c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Sponsored by** *PTFS |**Sponsored by** *PTFS release notes|Europe* |Europe* | | |This enhancement |This enhancement |ensures patrons are |ensures patrons are |returned to the correct |returned to the correct |biblio detail page after a |bibliographic record detail |login that is prompted when |page after a login that is |attempting to comment on a |prompted when attempting to |bilio. |comment on a bibliographic | |record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:59:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:59:30 +0000 Subject: [Koha-bugs] [Bug 33769] Terminology: 'Warning: Item {barcode} is reserved' In-Reply-To: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33769-70-sIqpwVz6j9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33769 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:59:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:59:33 +0000 Subject: [Koha-bugs] [Bug 33769] Terminology: 'Warning: Item {barcode} is reserved' In-Reply-To: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33769-70-2WLdNwPll7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33769 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151423&action=edit Bug 33769: Terminology: 'Warning: Item {barcode} is reserved' This patch corrects an instance of the term "reserved" and replaces it with "on hold." The string is shown when the user tries to add an item which is on hold to a bundle. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 16:59:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 14:59:47 +0000 Subject: [Koha-bugs] [Bug 33769] Terminology: 'Warning: Item {barcode} is reserved' In-Reply-To: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33769-70-0Rps0HWLGC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33769 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:02:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:02:14 +0000 Subject: [Koha-bugs] [Bug 33769] Terminology: 'Warning: Item {barcode} is reserved' In-Reply-To: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33769-70-kOJos2D3Iu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33769 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Attachment #151422|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:03:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:03:03 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29453-70-VYI06AeFjR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Sponsored by** *PTFS |**Sponsored by** *PTFS release notes|Europe* |Europe* | | | |This adds GET | |endpoints for fetching | |credits and debits of a | |patron to the REST API. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:07:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:07:40 +0000 Subject: [Koha-bugs] [Bug 33077] Improve ease of translating template title tags In-Reply-To: <bug-33077-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33077-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33077-70-0xqmlu04tf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|I18N/L10N |Templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:08:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:08:01 +0000 Subject: [Koha-bugs] [Bug 33128] Add Polish translations for language descriptions In-Reply-To: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33128-70-ElH5Mve2YE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33128 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com Component|I18N/L10N |Installation and upgrade | |(web-based installer) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:09:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:09:21 +0000 Subject: [Koha-bugs] [Bug 32613] Add auto-completion to our SQL reports editor In-Reply-To: <bug-32613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32613-70-Ax7XRntoTK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32613 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This adds an auto-complete |This adds an auto-complete release notes|feature to the SQL reports |feature to the SQL reports |editor. This works for |editor. This works for |tables and columns. For |tables and columns. For |columns you'll need to |columns you'll need to |start with the table name, |start with the table name, |like 'borrowers.'. The |like `borrowers.`. The |editor will then suggest |editor will then suggest |the columns of the |the columns of the |borrowers table. The |`borrowers` table. The |auto-complete feature will |auto-complete feature will |also work when tables have |also work when tables have |been renamed. |been renamed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:11:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:11:11 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-zDHUTklXsu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds a new |**Sponsored by** *PTFS release notes|system preference |Europe* |EmailFieldPrecedence, which | |allows libraries to set the |This enhancement |order in which patron email |adds a new system |addresses are used when |preference |selecting "first valid" in |EmailFieldPrecedence, which |EmailFieldPrimary (formerly |allows libraries to set the |AutoEmailPrimaryAddress). |order in which patron email | |addresses are used when | |selecting "first valid" in | |EmailFieldPrimary (formerly | |AutoEmailPrimaryAddress). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:11:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:11:39 +0000 Subject: [Koha-bugs] [Bug 14911] Item search: Display additional title information In-Reply-To: <bug-14911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14911-70-IYsXomPO6f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Item search: Display |Item search: Display |additional 245 subfields in |additional title |search results |information Text to go in the| |Improves display of title release notes| |information in item search | |by adding subtitle, part | |name, part number and | |medium to the display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:15:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:15:14 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-9HnYP6h8va@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:15:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:15:16 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-4LLxB8fwfH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #32 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:15:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:15:18 +0000 Subject: [Koha-bugs] [Bug 33769] Terminology: 'Warning: Item {barcode} is reserved' In-Reply-To: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33769-70-IXYNkSC2bF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33769 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:15:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:15:20 +0000 Subject: [Koha-bugs] [Bug 33769] Terminology: 'Warning: Item {barcode} is reserved' In-Reply-To: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33769-70-5NbJM90jxQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33769 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:16:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:16:27 +0000 Subject: [Koha-bugs] [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used In-Reply-To: <bug-31338-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31338-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31338-70-CvO15yNHl8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |When release notes| |`IncludeSeeFromInSearches` | |is activated, there will be | |a note below the first | |search form on the advanced | |search in staff interface | |and OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:17:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:17:49 +0000 Subject: [Koha-bugs] [Bug 33770] New: Rephrase note on advanced search for IncludeSeeFromInSearches Message-ID: <bug-33770-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33770 Bug ID: 33770 Summary: Rephrase note on advanced search for IncludeSeeFromInSearches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 31338 It currently reads: See from (non-preferred form) headings are included I feel that this could be more user friendly, maybe talking about alternative name forms, spelling and pseudonnyms? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338 [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:17:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:17:49 +0000 Subject: [Koha-bugs] [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used In-Reply-To: <bug-31338-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31338-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31338-70-s5mEl4d8U5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33770 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33770 [Bug 33770] Rephrase note on advanced search for IncludeSeeFromInSearches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:18:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:18:19 +0000 Subject: [Koha-bugs] [Bug 33764] Accessibility: Fix ambiguous form-field in masthead.inc In-Reply-To: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33764-70-KJvNTjmYdd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33764 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151412|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 151424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151424&action=edit Bug 33764: Fix ambiguous "Login" field This patch changes the use of "Login" to "Username" to assist with screen reading Test plan: 1) In the masthead, click Log in to your account 2) On the modal, the first input should be labelled Username Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:18:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:18:35 +0000 Subject: [Koha-bugs] [Bug 33764] Accessibility: Fix ambiguous form-field in masthead.inc In-Reply-To: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33764-70-a3NM3Hcfnr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33764 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |Laura.escamilla at bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:23:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:23:54 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-mxcGOpAfeL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #28 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Ok I tested this and it's very interesting! Especially for schools. However, I'm not sure it's ready for release yet... Here are my conmments, and I apologize, I know there's a lot... I tried to separate into actual bugs vs comments. I tested in the sandbox provided. Bugs: - The patron search doesn't work in the modal when you click the Place booking button when in "Item" tab https://snipboard.io/EDpzBr.jpg - When you click on the Bookings tab, MARC and ISBD view disapears. - In the bookings tab, the months appear in french (in the sandbox, which I assume only has english installed). https://snipboard.io/fCPapt.jpg Does it take the language from my computer? My Ubuntu is in English, and so is my Chrome... - It seems the next day after a booking is not available? Also the calendar view and the table don't show the same dates. To recreate: 1. Click Place booking 2. Place a booking for two days, for example May 22 and 23 3. Click Place booking again for the same item --> Note that 22, 23 and 24 are greyed out 4. Place the booking for May 25-26 5. In the bookings tab, move the second booking to May 24-25 --> It worked 6. In the table, the dates are not updated --> First booking in the calendar is 22-23, in the table it's 22-24 --> The second booking (the one that was moved) in the calendar is 24-25, in the table it's 25-27 - If you checkout early to the correct patron, the due date is still the start of the booking? To recreate: 1. Place a booking for a couple days in the future, for example May 22-23 2. Attempt to check out to the same patron 3. Confirm early collection 4. Click Show checkotus --> Due date is May 22 Usability comments: - The patron search is not the same as elsewhere. I don't mind this version but for usability I think it would be best to have the same search everywhere. (Summary of IRC discussions - Martin said the traditional search doesn't work well with modals - Katrin said the traditional search works better for large datasets, so you can limit by library or category - Martin said he'd work on a middle ground) Maybe an alternative would be to make it work like the holds, i.e. send to a page with the form, the calendar and the table... - I didn't catch right away that you had to choose two dates. It's nifty once you know, but elsewhere in Koha there are two field "From:" and "To:". - Will it eventually be possible to limit the number of days a patron can book for? Right now, a patron can hog an item for a very long time... I know you said circulation rules will be added later, is that what you meant? - The Holds tab shows how many holds there are, maybe the bookings tab should show if there are bookings and how many? - In the bookings tab, the calendar shows the booking id (?). This id is not displayed in the table, so it's not very clear what it refers to. I think it would be better to show the patron's name and cardnumber. Maybe with a hover display for short bookings. - The calendar should show a fixed number of days. Right now it tries to adapt to the bookings, but if you have a long one or one in the far future, it's all scrunched up https://snipboard.io/5Acelp.jpg I think the next 30 days is sufficient, and we can scroll as needed. - In the bookings tab, in the table, not sure why there is a search box for the Actions columns... - I would also like the patron's name to have their cardnumber, and maybe a link to their file like in the Holds tab - Not sure how I triggered the "It worked" message https://snipboard.io/0KNJzp.jpg I think it was by moving a booking around in the calendar, but I also got it while scrolling in the calendar (although I think the latter was a belated message for the former) If it was for updating a booking, it could say "Booking updated". - Bookings are not shown in the patron file? Maybe for later versions... Maybe in a later version, but it would be nice to be able to choose a period within a day. For example, I have a class from 8 to 12 for which I need some special equipment. I could book the equipment for those hours only and someone else could have it in the afternoon. Another nice to have would be to be able to book recurrently. If I have my class every Tuesday from september to december, I could book the equipment "every tuesday" or "every other tuesday", etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:29:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:29:12 +0000 Subject: [Koha-bugs] [Bug 33765] Accessibility: Fix ambiguous form-field in opac-main.tt In-Reply-To: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33765-70-ufAHi0ohoq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33765 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151415|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 151425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151425&action=edit Bug 33765: Fix ambiguous "Login" field This patch changes the use of "Login" to "Username" to assist with screen reading Test plan: 1) On the OPAC main page, the log in form should now have the first field labelled as Username, not Login Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:29:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:29:33 +0000 Subject: [Koha-bugs] [Bug 33765] Accessibility: Fix ambiguous form-field in opac-main.tt In-Reply-To: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33765-70-nBdVZaQXUJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33765 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:34:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:34:59 +0000 Subject: [Koha-bugs] [Bug 27775] Add hint about drag and drop feature on framework subfield edit In-Reply-To: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27775-70-9fsQLd3FyL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27775 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The sequence subfields release notes| |appear when cataloguing | |bibliographic records, | |auhority records or items | |can be changed for each | |framework. To make this | |feature more visible a note | |was added to the framework | |administration page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:35:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:35:25 +0000 Subject: [Koha-bugs] [Bug 33758] Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook In-Reply-To: <bug-33758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33758-70-3ulUQm2Hk0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 --- Comment #1 from Nicolas Giraud <nicolas.giraud at inlibro.com> --- Created attachment 151426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151426&action=edit Bug 33758 - Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook This patch adds a parameter to call the method intranet_catalog_biblio_enhancements_toolbar_button with a biblionumber in the page catalogue/detail.pl. Modification of cat-toolbar.inc to display new buttons correctly. To test : 1. Apply the patch 2. Take a plugin who implements the method intranet_catalog_biblio_enhancements_toolbar_button 3. Check if the parameter "biblionumber" is passed correctly at this method 4. Create the new button in HTML in the plugin method (button must be like the ones that are in the toolbar of the page detail.pl) 5. Go to the page in browser and check if the new button is displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:36:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:36:03 +0000 Subject: [Koha-bugs] [Bug 33758] Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook In-Reply-To: <bug-33758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33758-70-EWKWtUIm67@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Nicolas Giraud <nicolas.giraud at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:36:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:36:29 +0000 Subject: [Koha-bugs] [Bug 33758] Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook In-Reply-To: <bug-33758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33758-70-Hw68darZ9T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Nicolas Giraud <nicolas.giraud at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:36:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:36:53 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: <bug-27424-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27424-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27424-70-8J9ePDBE5V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |We have been able to define release notes| |SMTP servers in the staff | |interface for a while now. | |But to utilize them you had | |to set the SMTP server for | |each library individually. | |With this you can now chose | |to apply an SMTP server as | |default to all your | |libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:38:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:38:26 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-YxdMya5Rcr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |With this patch the MARC release notes| |framework shows at the end | |of the bibliographic | |description on the catalog | |detail page in the staff | |interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:39:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:39:46 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library In-Reply-To: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30624-70-RQk4buMSV0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds a new |This enhancement adds a new release notes|permission, |`loggedinlibrary` |loggedinlibrary, to allow |permission to allow or |or prevent staff members to |prevent staff members to |set the library where they |set the library where they |log in. |log in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:41:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:41:51 +0000 Subject: [Koha-bugs] [Bug 32173] Add count of total titles in list to staff interface In-Reply-To: <bug-32173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32173-70-Kgg3qJ6yAD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32173 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add count of total titles |Add count of total titles |in list to staff client |in list to staff interface |view | Component|Staff interface |Lists CC| |m.de.rooy at rijksmuseum.nl Text to go in the| |With this the number of release notes| |entries on a list will show | |in the detail page of a | |list in the staff | |interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:44:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:44:56 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-nJIf4t1Se0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com --- Comment #3 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- (In reply to Owen Leonard from comment #2) > (In reply to Matt Blenkinsop from comment #0) > > has been flagged as non-compliant in an accessibility report > > carried out for the British Museum. > > What is problematic screen reader behavior? It seems wrong to me that the > screen reader should care what name or id the field has as long as it has an > associated label. It's not so much an issue with the screen reader device, but with the patrons using the device to login into our Opac. Since the field is currently named "Login" it might confuse patrons using the screen reader since they might not understand that it is the "Username" field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:46:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:46:55 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-YrAs4G1ot3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151416|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 151427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151427&action=edit Bug 33766: Fix ambiguous "Login" field This patch changes the use of "Login" to "Username" to assist with screen reading Test plan: 1) On the OPAC homepage, click on Lists in the top left 2) Click Log in to create your own lists 3) The login form should have the first field labelled as Username, not Login Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:47:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:47:08 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-gUG1Q2oo0X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:50:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:50:08 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-AThz6ti55K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Sorry, but have to veto here: we picked login on purpose as Koha accepts both, the username and the cardnumber. So login was the best fit we found that was not indicating one or the other only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:50:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:50:24 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-4U7a33uy5G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:59:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:59:24 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33639-70-RiTKK7af5g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151383|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 151428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151428&action=edit Bug 33639: Fix selectors for adding to item group To test: Apply patch 1 - Browse to details page for a record 2 - Create or ensure the record has item group(s) 3 - Click New->New item 4 - Note the bottom of the page has a form to attach to existing group 5 - Note when a group is selected the enumchron field is populated if it is blank 6 - Note that the enumchron field is NOT update is there is a an existing value 7 - Confirm item is saved to group when saved Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 17:59:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 15:59:34 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33639-70-uGv2W8B2iw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |Laura.escamilla at bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 18:08:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 16:08:59 +0000 Subject: [Koha-bugs] [Bug 33771] New: Markup errors on orderreceive.tt after 8179 Message-ID: <bug-33771-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771 Bug ID: 33771 Summary: Markup errors on orderreceive.tt after 8179 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: lucas at bywatersolutions.com Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org I am opening this bug to address so HTML markup errors on orderreceive.tt. -One of the <th> is closed with a </td> -The #jobpanel element div is not properly closed -Style tags are in the HTML body and they should be in the HTML head -The following is invalid - <div id="modal-order-main row"> It should be: + <div id="modal-order-main" class="row"> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 18:09:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 16:09:11 +0000 Subject: [Koha-bugs] [Bug 33771] Markup errors on orderreceive.tt after 8179 In-Reply-To: <bug-33771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33771-70-cYJ4eoxERe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8179 Severity|enhancement |normal Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 18:09:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 16:09:11 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-SAH7rvxKSO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33771 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771 [Bug 33771] Markup errors on orderreceive.tt after 8179 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 18:12:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 16:12:52 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-I3aS0k5ZkW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #6 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #5) > Sorry, but have to veto here: we picked login on purpose as Koha accepts > both, the username and the cardnumber. So login was the best fit we found > that was not indicating one or the other only. Maybe we can update it to "Login ID"? That way patrons will understand that it's intended to be a username/cardnumber field and not the Login button itself? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 18:12:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 16:12:56 +0000 Subject: [Koha-bugs] [Bug 33771] Markup errors on orderreceive.tt after 8179 In-Reply-To: <bug-33771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33771-70-lcMlbaGFiJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 18:12:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 16:12:58 +0000 Subject: [Koha-bugs] [Bug 33771] Markup errors on orderreceive.tt after 8179 In-Reply-To: <bug-33771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33771-70-gNxN8zvnh3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151429&action=edit Bug 33771: Fix markup errors in orderreceive.tt This patch fixed the following on orderreceive.tt: -One of the <th> is closed with a </td> -The #jobpanel element div is not properly closed -Style tags are in the HTML body and they should be in the HTML head -The #modal-order-main needs a class of 'row', this has been added. Apply the pacth and follow the steps in 8179 until you get to the orderreceive.tt. There should be no visual changes but the markup has been corrected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 18:13:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 16:13:30 +0000 Subject: [Koha-bugs] [Bug 33771] Markup errors on orderreceive.tt after 8179 In-Reply-To: <bug-33771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33771-70-8neNs5yATh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 18:42:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 16:42:40 +0000 Subject: [Koha-bugs] [Bug 8838] Digest option for HOLD notice In-Reply-To: <bug-8838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8838-70-hwWSYqM1lm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 mspinney at clamsnet.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 19:05:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 17:05:04 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-ZzsWhEKHsS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- All excellent feedback, thanks for testing Caroline. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 19:12:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 17:12:08 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-oPHnbGEQDj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- But doesn't the screen reader indicate if something is a link or button? Just wondering because login seems a very common field label. And I worry with login ID people will overthink it. Would be great to get more opinions/eyes on this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 19:14:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 17:14:05 +0000 Subject: [Koha-bugs] [Bug 33771] Markup errors on orderreceive.tt after 8179 In-Reply-To: <bug-33771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33771-70-WkTqMQ0hZ0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 19:14:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 17:14:08 +0000 Subject: [Koha-bugs] [Bug 33771] Markup errors on orderreceive.tt after 8179 In-Reply-To: <bug-33771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33771-70-IxPMPE13OT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151429|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151430&action=edit Bug 33771: Fix markup errors in orderreceive.tt This patch fixed the following on orderreceive.tt: -One of the <th> is closed with a </td> -The #jobpanel element div is not properly closed -Style tags are in the HTML body and they should be in the HTML head -The #modal-order-main needs a class of 'row', this has been added. Apply the pacth and follow the steps in 8179 until you get to the orderreceive.tt. There should be no visual changes but the markup has been corrected. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 19:16:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 17:16:37 +0000 Subject: [Koha-bugs] [Bug 33771] Markup errors on orderreceive.tt after 8179 In-Reply-To: <bug-33771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33771-70-46Divcpe4z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 19:17:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 17:17:16 +0000 Subject: [Koha-bugs] [Bug 33771] Markup errors on orderreceive.tt after 8179 In-Reply-To: <bug-33771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33771-70-pRrkpMZvBy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 19:17:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 17:17:17 +0000 Subject: [Koha-bugs] [Bug 33771] Markup errors on orderreceive.tt after 8179 In-Reply-To: <bug-33771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33771-70-ui8qVp0Fr5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 19:48:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 17:48:31 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-ZiyOyCr5mi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #153 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151431&action=edit Bug 8179: (follow-up) Restore funds dropdown and checkbox This patch reintroduces the dropdown that got lost in some refactoring of the patchset. It also introduces a couple minor fixes. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 19:53:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 17:53:25 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-3Px8sREkJ8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #154 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed the last follow-up for the sake of having the strings in place. Lucas was looking at styling it better. Remaining issues should be handled in follow-up bugs for clarity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 19:56:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 17:56:27 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-u0aSh3IGBi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This development changes release notes| |the order receive page so | |multiple orders can be | |selected and processed at | |once. | | | |Selected orders can | |be browsed using the added | |'Next order' and 'Previous | |order' buttons. | | | |After | |editing each order, without | |reloading the page or | |having to search for them | |again, a convenient | |'Confirm' button allows us | |to receive all orders at | |once. | | | |This opens the door | |for new enhancements like | |adding default actions on | |all selected orders, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:02:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 18:02:12 +0000 Subject: [Koha-bugs] [Bug 33195] Reindent the bibliographic details page In-Reply-To: <bug-33195-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33195-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33195-70-SNiA9nCrZp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:02:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 18:02:15 +0000 Subject: [Koha-bugs] [Bug 33195] Reindent the bibliographic details page In-Reply-To: <bug-33195-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33195-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33195-70-lizY4wcCcj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151432&action=edit Bug 33195: Reindent the bibliographic details page This patch reindents the bibliographic details template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and view the detail page for a bibliographic record. Test as many variations as you can: - With and without cover images enabled - With FRBRizeEditions enabled (and multiple editions in your catalog) - With LocalCoverImages enabled - With AcquisitionDetails enabled - With a serial record - With a record with component parts - With EnableItemGroups enabled - Wtih CatalogConcerns enabled - With HTML5MediaEnabled and a record with media links Viewing the diff while ignoring whitespace changes should show only places where a line break was added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:02:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 18:02:17 +0000 Subject: [Koha-bugs] [Bug 33195] Reindent the bibliographic details page In-Reply-To: <bug-33195-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33195-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33195-70-86EBkdinOj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151433&action=edit Bug 33195: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:05:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 18:05:00 +0000 Subject: [Koha-bugs] [Bug 33526] Use template wrapper for tabs: Bibliographic detail page In-Reply-To: <bug-33526-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33526-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33526-70-3bzcCLvYpD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33195 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 [Bug 33195] Reindent the bibliographic details page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:05:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 18:05:00 +0000 Subject: [Koha-bugs] [Bug 33195] Reindent the bibliographic details page In-Reply-To: <bug-33195-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33195-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33195-70-mIEwBp6cEm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 [Bug 33526] Use template wrapper for tabs: Bibliographic detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:05:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 18:05:57 +0000 Subject: [Koha-bugs] [Bug 33758] Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook In-Reply-To: <bug-33758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33758-70-EXbUuv1jKL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 --- Comment #2 from Nicolas Giraud <nicolas.giraud at inlibro.com> --- Created attachment 151434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151434&action=edit Simple plugin to test the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:19:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 18:19:09 +0000 Subject: [Koha-bugs] [Bug 33772] New: Header search input no longer has an outline when focused Message-ID: <bug-33772-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33772 Bug ID: 33772 Summary: Header search input no longer has an outline when focused Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: jrobb at sekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 151435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151435&action=edit Comparison of header search pre and post 22.11 Prior to the staff interface redesign, the input box in the header search had a black outline to indicate focus. This no longer appears post-redesign so it is easy to miss when the input is in or out of focus. This is also an accessibility concern: https://developer.mozilla.org/en-US/docs/Web/CSS/:focus#accessibility_concerns A possible workaround is to add an inset box-shadow: #header_search .form-content:focus-within { box-shadow: inset 0 0 0px 3px #ffc32b; } The attachment includes the before and after, as well as how the above css looks. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:29:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 18:29:28 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-koiTL0po0n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:29:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 18:29:30 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-M77ZhlOxYV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151036|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151436&action=edit Bug 33675: Add CSRF protection to OAuth/OIDC authentication This patch makes the OAuth/OIDC client pass a `state` parameter with a CSRF protection token, to be validated back when the flow returns to Koha. Ideally, the Mojolicious::Plugin::OAuth2 library should deal with this implicitly, probably making use of JWT. But as of now, this is the best way to implement it. To test: 1. Have a working SSO solution (ktd --sso) 2. Click to login using SSO => SUCCESS: Notice a 'state' parameter on the URL, looks like a random thing 3. When you login, no error is reported Signed-off-by: David Cook <dcook at prosentient.com.au> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:37:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 18:37:53 +0000 Subject: [Koha-bugs] [Bug 26053] Adding more details to the manual about Patron Restrictions In-Reply-To: <bug-26053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26053-70-tl4MlZulRS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Component|Documentation |Patrons --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I think this has moved from documentation to enhancement request? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:51:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 18:51:15 +0000 Subject: [Koha-bugs] [Bug 33773] New: Possible CSS adjustments for the header search usability improvement Message-ID: <bug-33773-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33773 Bug ID: 33773 Summary: Possible CSS adjustments for the header search usability improvement Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: jrobb at sekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 151437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151437&action=edit Search header css adjustments The header search post-redesign is a little claustrophobic. Some of my libraries are staffed by people who struggle with mousing and keyboarding and will have trouble with accidentally hitting top nav bar links when attempting to click into the search input. I've made some css tweaks on my system to give it a little more breathing room and improve usability -- sharing in case others might find any of the changes beneficial enough to make them standard. The attached gif shows what the css below does. #header_search { padding: 0.6em; } #header_search .form-title { background-color: #6FAF42; padding: 0 16px; border-radius: 16px; } #header_search .form-title label { margin: 0 auto; } #header_search .nav-tabs>li>a { padding: 0.3em 0.5em; } #header_search .nav-tabs>li.active a, #header_search .nav-tabs>li.active a:hover { cursor: default; padding: 0.3em .5em; border: 2px solid #7CBB51; background-color: #7CBB51; border-radius: 16px; } #header_search .nav-tabs>li>a:hover, #header_search .nav-tabs>li>a:focus { background-color: #408540; border: 2px solid #408540; border-bottom-color: #6faf44; padding: 0.3em .5em; text-decoration: none; } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:55:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 18:55:42 +0000 Subject: [Koha-bugs] [Bug 28527] Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received In-Reply-To: <bug-28527-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28527-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28527-70-rMpBOCYW8y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28527 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED CC| |Laura.escamilla at bywatersolu | |tions.com --- Comment #7 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Blocking for now until a test plan is available for sign offs. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 20:59:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 18:59:36 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33639-70-zr6zr8omER@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 Sam <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau at gmail.com Status|Signed Off |Failed QA --- Comment #8 from Sam <samalau at gmail.com> --- When adding a new item, a group is already preselected in the dropdown box, which makes the enumchron box empty by default, even though a group is selected. Had to deselect the group and then reselect it in order for the enumchron to be filled. Another issue was that when the new item was added, the selected group did not show up in the group column, instead, the group column was left empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:04:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 19:04:28 +0000 Subject: [Koha-bugs] [Bug 33772] Header search input no longer has an outline when focused In-Reply-To: <bug-33772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33772-70-L4Vbi2ighO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33772 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #1 from George Williams (NEKLS) <george at nekls.org> --- I agree. Adding an outline when focused would be helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:07:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 19:07:06 +0000 Subject: [Koha-bugs] [Bug 33773] Possible CSS adjustments for the header search usability improvement In-Reply-To: <bug-33773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33773-70-Q5UDKQ2Hta@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33773 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #1 from George Williams (NEKLS) <george at nekls.org> --- The button highlighting is much appreciated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:09:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 19:09:02 +0000 Subject: [Koha-bugs] [Bug 28527] Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received In-Reply-To: <bug-28527-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28527-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28527-70-W090MfvJJa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28527 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Missing test plan = Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:13:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 19:13:57 +0000 Subject: [Koha-bugs] [Bug 33774] New: Loading club table in every tab in patron details Message-ID: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 Bug ID: 33774 Summary: Loading club table in every tab in patron details Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org When clubs are defined, the clubs table loads in all tabs at the bottom of the patrons details page. To recreate: 1. Create a club 1.1. Go to Tools > Patron clubs 1.2. Click 'New club template' 1.3. Enter a name 1.4. Click 'Save' 1.5. Click 'New club' and choose the template 1.6. Enter a name 1.7. Click 'Save' 2. Go to Patrons and go in any patron's account --> At the bottom of the page, the 'Checkouts' tab says 'Loading...' 3. Click any other tab in that bottom section (Holds, Claims, Restrictions, Article requests, Recalls) --> All say 'Loading...' 4. Click the Clubs tab --> The table loads finally 5. Click back in any other tab --> The Clubs table shows in all tabs https://snipboard.io/0tBYLM.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:14:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 19:14:01 +0000 Subject: [Koha-bugs] [Bug 33772] Header search input no longer has an outline when focused In-Reply-To: <bug-33772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33772-70-Cw1w44YZGu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33772 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:14:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 19:14:04 +0000 Subject: [Koha-bugs] [Bug 33773] Possible CSS adjustments for the header search usability improvement In-Reply-To: <bug-33773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33773-70-P4aJelPU9z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33773 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:17:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 19:17:07 +0000 Subject: [Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl In-Reply-To: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33722-70-hAcxgNwcYC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 --- Comment #11 from David Nind <david at davidnind.com> --- (In reply to Marcel de Rooy from comment #9) > (In reply to David Nind from comment #3) > > The only thing I noticed was that you can choose to make a list Private and > > choose Nobody for allow changes to content. > > > > You then lose access to the list, and even a super librarian can't see it. > > > > This is also the case in master, so I think this is a separate bug. > > I thought that I saw it too. But cannot reproduce anymore now somehow. Could > you give the exact steps to reproduce? I can't reproduce it on master now either - maybe I was mixing up my different browser windows with different staff users. Apologies for the noise... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:23:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 19:23:07 +0000 Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen In-Reply-To: <bug-32373-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32373-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32373-70-rU5eP6I4ZW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/691 Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:23:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 19:23:20 +0000 Subject: [Koha-bugs] [Bug 31448] Add option to re-send email receipt when UseEmailReceipts is enabled In-Reply-To: <bug-31448-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31448-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31448-70-I2NnuujIRY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/691 Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:23:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 19:23:20 +0000 Subject: [Koha-bugs] [Bug 33473] Allow to send email receipts for payments/writeoff manually instead of automatically In-Reply-To: <bug-33473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33473-70-AutJ8fvHLo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33473 Bug 33473 depends on bug 31448, which changed state. Bug 31448 Summary: Add option to re-send email receipt when UseEmailReceipts is enabled https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:23:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 19:23:35 +0000 Subject: [Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30579-70-KUSEACtDLx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |samalau at gmail.com --- Comment #34 from Sam Lau <samalau at gmail.com> --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:30:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 19:30:39 +0000 Subject: [Koha-bugs] [Bug 33774] Loading club table in every tab in patron details In-Reply-To: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33774-70-DRBAoXWEzP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major CC| |david at davidnind.com Version|unspecified |master --- Comment #1 from David Nind <david at davidnind.com> --- I checked this on 22.11.05, and it is not doing this. So, at the moment the bug is limited to master. I changed the importance to major, as the details area is used frequently - and I don't think you would want this bug showing in a new release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:38:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 19:38:06 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30418-70-S0RXq219dG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/691 CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:42:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 19:42:36 +0000 Subject: [Koha-bugs] [Bug 33775] New: Different/no results between Check Out and Search Patron when searching for names with spaces Message-ID: <bug-33775-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33775 Bug ID: 33775 Summary: Different/no results between Check Out and Search Patron when searching for names with spaces Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com For the patron first name Jane surname Van Allen - in Check out, entering Van Allen will bring up the patron record, entering Van Allen in the Search Patron brings no results. The search needs to be the same in both. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 21:46:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 19:46:50 +0000 Subject: [Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface In-Reply-To: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32677-70-1pvPZr4SxD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #11 from David Nind <david at davidnind.com> --- I was able to install with: koha-translate --install es-ES If I used the same command as you did, including the instancename (in my case, koha-translate --install es-ES kohadev), I got the same error as you did: Error: the selected language is not currently available. I'm not sure why this is. Maybe there is something wrong with the koha-translate package command (the help says you should include the instance name), or it is something to do with permissions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:26:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 20:26:29 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-scI6b9xsKP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144259|0 |1 is obsolete| | --- Comment #336 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 151438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151438&action=edit Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts Signed-off-by: Michal Denar <black23 at gmail.com> Bug 17015: When using book drop mode, set check in time as closing hours Signed-off-by: Michal Denar <black23 at gmail.com> Bug 17015: Automatically update calendar when creating or deleting a branch Signed-off-by: Michal Denar <black23 at gmail.com> Bug 17015: Rebase and tests for discrete calendar This patch is a rebase of all the previous patches in order to show the discrete calendar. TEST PLAN: 1- Apply the patch 2- Run installer/data/mysql/updatedatabase.pl 3- Run misc/cronjobs/add_days_discrete_calendar.pl 4- Check that the max date is today + 1 day 5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass) Signed-off-by: Michal Denar <black23 at gmail.com> Bug 17015: DiscreteCalendar->new() method is now in a HASH This patch adds missing curly brackets in all new() calls. All tests in t/ should pass too (The one that don't pass are not passing before the patch) TEST PLAN: 1- Apply the patch 2- Run installer/data/mysql/updatedatabase.pl 3- Run misc/cronjobs/add_days_discrete_calendar.pl 4- Check that the max date is today + 1 day 5- Attempt a checkout ~ The error "Can't use string ("branchcode") as a HASH ref while "strict refs" in use at /kohadevbox/koha/Koha/DiscreteCalendar.pm line 79" is no longer here 5- Run t/db_dependent/DiscreteCalendar.t (prove -l t/db_dependent/DiscreteCalendar.t) 6- Run all koha test in t/ (prove t). All tests should pass 7- Use Discrete Calendar in Tools->Calendar USING THE DISCRETE CALENDAR: 1- New UI a) Calendar on the left b) Holidays list on the right 2- New color system for holiday types: a) Working day : white b) Unique holiday: red c) Holiday repeating weekly: yellow d) Holiday repeating yearly: orange e) Floating holiday: green f) Need validation: blue 3- When clicking on a date in the calendar, opening, closing hours and holiday type are displayed. 4- All the fields are editable 5- New radio button to Edit selected dates or Copy to different dates 6- Option to copy the calendar to another branch Bug 17015: Fixing QA tools failures This patch fixes tests that fails with the QA tool. To test, run the QA tool All tests should say OK except 2 that fails. Bug 17015: Check out with the useDaysMode preference When checking out with useDaysMode preference set to "Use the calendar to push the due date to the next open day", an error 500 appears. This patch fixes this error. To test: 1. Go in Administration->useDaysMode 2. Set this preference t0 "Use the calendar to push the due date to the next open day" 3. Make sure you have a patron and a item (note the patron's category and the item's type) 4. Make sure you have a circulation rule with the patron's category and the item type in step 3 5. Attempt a checkout 6. An error 500 appears 7. Apply the patch 8. The error is no longer there -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:26:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 20:26:36 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-z3XuhgkkX9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144260|0 |1 is obsolete| | --- Comment #337 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 151439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151439&action=edit Bug 17015: Tests for DiscreteCalendar Signed-off-by: Michal Denar <black23 at gmail.com> Bug 17015: Rebase and tests for discrete calendar This patch is a rebase of all the previous patches in order to show the discrete calendar. TEST PLAN: 1- Apply the patch 2- Run installer/data/mysql/updatedatabase.pl 3- Run misc/cronjobs/add_days_discrete_calendar.pl 4- Check that the max date is today + 1 day 5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass) Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:26:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 20:26:41 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-imU4avnWoR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144261|0 |1 is obsolete| | --- Comment #338 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 151440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151440&action=edit Bug 17015: DatePicker/TimePicker to Flatpickr Changed all datepicker/timepicker to flatpickr + some small fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:26:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 20:26:47 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-E60OsBqUtY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144262|0 |1 is obsolete| | --- Comment #339 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 151441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151441&action=edit Bug 17015: Install scripts for DiscreteCalendar Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:26:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 20:26:52 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-8nPBV8SSoa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144264|0 |1 is obsolete| | --- Comment #340 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 151442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151442&action=edit Bug 17015: Use branchcode when adding or modifying a holiday -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:26:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 20:26:58 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-UAp97sD3nK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144268|0 |1 is obsolete| | --- Comment #341 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 151443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151443&action=edit Bug 17015: Add description field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:27:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 20:27:03 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-aVhmY5LDdx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144269|0 |1 is obsolete| | --- Comment #342 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 151444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151444&action=edit Bug 17015: Allow holiday edits to be applied to all branches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:27:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 20:27:09 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-bUfhwSuzpw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144270|0 |1 is obsolete| | --- Comment #343 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 151445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151445&action=edit Bug 17015: Add an option to view past holiday details in table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:27:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 20:27:14 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-SCm75DzzbU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144271|0 |1 is obsolete| | --- Comment #344 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 151446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151446&action=edit Bug 17015: Add minDate restrictions for pairs of date selectors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:27:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 20:27:19 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-VgLLgqAcg0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144272|0 |1 is obsolete| | --- Comment #345 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 151447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151447&action=edit Bug 17015: UI tweaks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:27:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 20:27:25 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-DMRUVhVFqb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144273|0 |1 is obsolete| | --- Comment #346 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 151448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151448&action=edit Bug 17015: Always uncheck "Copy all librairies" when opening edit page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:27:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 20:27:30 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-ERgLZUcd0W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #347 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 151449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151449&action=edit Bug 17015: Miscellaneous corrections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:27:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 20:27:35 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-97hwDC3l5b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #348 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 151450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151450&action=edit Bug 17015: Corrections for tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:41:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 20:41:40 +0000 Subject: [Koha-bugs] [Bug 33772] Header search input no longer has an outline when focused In-Reply-To: <bug-33772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33772-70-hRgVzM2CjZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33772 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #2 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- Agreed - I think having the outline will reduce mistakes and increase efficiency for our staff. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:42:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 20:42:04 +0000 Subject: [Koha-bugs] [Bug 33776] New: Add inLibro in default plugin repositories Message-ID: <bug-33776-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776 Bug ID: 33776 Summary: Add inLibro in default plugin repositories Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org We reorganized our plugin repository in order to be able to take advantage of bug 23975. Since there are three companies in the default <plugin_repos> tag, we'd like to be included also. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:48:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 20:48:26 +0000 Subject: [Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories In-Reply-To: <bug-33776-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33776-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33776-70-xcmEKFwCGR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:56:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 20:56:20 +0000 Subject: [Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories In-Reply-To: <bug-33776-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33776-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33776-70-HNZZzaV91N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776 --- Comment #1 from Blou <philippe.blouin at inlibro.com> --- Created attachment 151451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151451&action=edit Bug 33776: Additional default plugin repo in koha-conf-site.xml.in Solutions inLibro started formating its repository to be found by Bug 23975. This patch adds it to the default list in the config template. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 18 22:57:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 20:57:59 +0000 Subject: [Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories In-Reply-To: <bug-33776-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33776-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33776-70-ZlYzYbZV6W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776 Blou <philippe.blouin at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |philippe.blouin at inlibro.com |ity.org | Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #2 from Blou <philippe.blouin at inlibro.com> --- Not sure how this can be signed off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 23:08:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 21:08:46 +0000 Subject: [Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar In-Reply-To: <bug-17983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17983-70-PowGpsQU8s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144267|0 |1 is obsolete| | --- Comment #32 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 151452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151452&action=edit Bug 17983: Add minutes loan to DiscreteCalendar This is an additional feature to our new Discrete Calendar. Theses patches add the possibility to choose the loan unit as minutes in circulations rules. Test plan: - Apply patch of Bugzilla 17015 - Apply this patch. - Run test t/db_dependent/minutes_loan.t - Create new item type for the new rule. - Create circulation rule and fill the fields, make sure the unit is set to : minutes, choose the item type of the one created above.- - Checkout an item that follow the circulation rule and set due date in the past. - Run fines.pl. - Check if the correct amount was calculated. - Note: make sure to factor in the fine grace period if set and the system preference FinesIncludeGracePeriod.fixed patch tests and minor adjustments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 23:09:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 21:09:09 +0000 Subject: [Koha-bugs] [Bug 21330] Add XSLT for authority detail page in OPAC In-Reply-To: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21330-70-N23wxqliOl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 23:11:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 21:11:48 +0000 Subject: [Koha-bugs] [Bug 21330] Add XSLT for authority detail page in OPAC In-Reply-To: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21330-70-A9nhoQVOqf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/691 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 23:13:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 21:13:20 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-8H2rCVP14W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 23:14:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 21:14:11 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-4yyh3IKz5i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This adds the option to add |This adds the option to add release notes|additional user defined |additional user defined |fields to the order lines |fields to the order lines |in the acquisition module. |in the acquisition module. |The fields can be yet up as |The fields can be set up as |free text fields or pull |free text fields or pull |down lists driven by |down lists driven by |authorised values. They can |authorised values. They can |also pull information from |also pull information from |the MARC record or allow |the MARC record or allow |you to create and edit a |you to create and edit a |field in the MARC record. |field in the MARC record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 18 23:50:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 21:50:40 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30418-70-LGQof9zppt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #41 from Alex Buckley <alexbuckley at catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #40) > (In reply to Alex Buckley from comment #39) > > Hi Marcel, > > > > According to comment #36 this enhancement (bug 30418) was pushed to master > > around 2023-05-16 09:28:06 UTC, however, the list permission problems in bug > > 33722 were reported earlier at 2023-05-11 23:16:42 UTC > > > > Also, noting that if you checkout 2928c1cf634c97041ea3b1268dcc27a550feb2ca > > 'Bug 32775: (QA follow-up) remove useless empty line' (the commit in log > > before bug 30418 was pushed) the problem reported in bug 33722 can be > > replicated then. > > > > Alex > > Might be false alarm indeed. Sorry for the confusion. No worries, thanks Marcel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 00:51:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 22:51:17 +0000 Subject: [Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface In-Reply-To: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32677-70-HELk1DD1Sf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677 --- Comment #12 from Victor Zuniga <vctrzuniga at gmail.com> --- (In reply to David Nind from comment #11) > I was able to install with: koha-translate --install es-ES > > If I used the same command as you did, including the instancename (in my > case, koha-translate --install es-ES kohadev), I got the same error as you > did: > > Error: the selected language is not currently available. > > I'm not sure why this is. Maybe there is something wrong with the > koha-translate package command (the help says you should include the > instance name), or it is something to do with permissions. Thanks for testing. I tried running the command without the instance name and got the following message: Error: the selected language is already installed. Try --update if you want to re-install it. I tried using the --update command instead and basically got the same message (Package is already installed). Do you know what level of permissions should be attributed to the po packages? Thanks, Victor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 01:09:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 23:09:54 +0000 Subject: [Koha-bugs] [Bug 27452] Create GUI for patron_emailer cron In-Reply-To: <bug-27452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27452-70-62jqaMctDT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27452 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- (In reply to Katrin Fischer from comment #3) > Hm, that's odd as it's one of the most popular plugins. I left a note for > Nick on IRC. Thanks, Katrin :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 01:12:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 May 2023 23:12:52 +0000 Subject: [Koha-bugs] [Bug 33353] Add compatibility with Elasticsearch 8 In-Reply-To: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33353-70-Ro6sOM9PGk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33353 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:20:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 06:20:08 +0000 Subject: [Koha-bugs] [Bug 33777] New: Get Jenkins green again for Auth_with_shibboleth.t Message-ID: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33777 Bug ID: 33777 Summary: Get Jenkins green again for Auth_with_shibboleth.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org not ok 5 - checkpw_shib tests Caused by changes around EmailFieldPrecedence -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:20:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 06:20:15 +0000 Subject: [Koha-bugs] [Bug 33777] Get Jenkins green again for Auth_with_shibboleth.t In-Reply-To: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33777-70-L4LSZc2ZAM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33777 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:21:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 06:21:31 +0000 Subject: [Koha-bugs] [Bug 33777] Get Jenkins green again for Auth_with_shibboleth.t In-Reply-To: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33777-70-CG1PmAooMZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33777 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:21:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 06:21:33 +0000 Subject: [Koha-bugs] [Bug 33777] Get Jenkins green again for Auth_with_shibboleth.t In-Reply-To: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33777-70-0HG2XdEgIY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33777 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151453&action=edit Bug 33777: Fix Auth_with_shibboleth.t We need to 'mock' the new pref EmailFieldPrecedence Test plan: Run t/Auth_with_shibboleth.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:21:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 06:21:51 +0000 Subject: [Koha-bugs] [Bug 33777] Get Jenkins green again for Auth_with_shibboleth.t In-Reply-To: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33777-70-KVk6vYuSUY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33777 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:22:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 06:22:01 +0000 Subject: [Koha-bugs] [Bug 33777] Get Jenkins green again for Auth_with_shibboleth.t In-Reply-To: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33777-70-GMqBr4HORa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33777 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:22:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 06:22:09 +0000 Subject: [Koha-bugs] [Bug 33777] Get Jenkins green again for Auth_with_shibboleth.t In-Reply-To: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33777-70-ETCP82IGMz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33777 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:22:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 06:22:32 +0000 Subject: [Koha-bugs] [Bug 33777] Get Jenkins green again for Auth_with_shibboleth.t In-Reply-To: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33777-70-RTgL6kpzlj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33777 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Pushing right away in the queue for Tomas -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:24:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 06:24:10 +0000 Subject: [Koha-bugs] [Bug 33778] New: Move t/Auth_with_shibboleth.t to db_dependent Message-ID: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 Bug ID: 33778 Summary: Move t/Auth_with_shibboleth.t to db_dependent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:24:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 06:24:17 +0000 Subject: [Koha-bugs] [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent In-Reply-To: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33778-70-hqmv7T60Mz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33777 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33777 [Bug 33777] Get Jenkins green again for Auth_with_shibboleth.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 08:24:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 06:24:17 +0000 Subject: [Koha-bugs] [Bug 33777] Get Jenkins green again for Auth_with_shibboleth.t In-Reply-To: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33777-70-TGdAgP3NHm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33777 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33778 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 09:18:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 07:18:57 +0000 Subject: [Koha-bugs] [Bug 33779] New: Terminology: biblio record Message-ID: <bug-33779-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33779 Bug ID: 33779 Summary: Terminology: biblio record Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt:159 This item cannot be issued as it has no biblio record associated with it should be: ... bibiographic record... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 09:19:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 07:19:27 +0000 Subject: [Koha-bugs] [Bug 33779] Terminology: biblio record In-Reply-To: <bug-33779-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33779-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33779-70-FKw4U2JHQH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33779 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- ... and issued should be checked out! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 09:22:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 07:22:13 +0000 Subject: [Koha-bugs] [Bug 33780] New: Multi-line TT comment: [%% item.object.itemnotes.replace('\n', ' Message-ID: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33780 Bug ID: 33780 Summary: Multi-line TT comment: [%% item.object.itemnotes.replace('\n',' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org TT comments broken on multiple lines will lead to artifacts in the po files. Better to use a format that keeps them on one line or enclose each line in [%% ... %%] koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt:581 [%% item.object.itemnotes.replace('\n',' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:19:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 08:19:41 +0000 Subject: [Koha-bugs] [Bug 33781] New: Terminology: Item already issued to other borrower. Message-ID: <bug-33781-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33781 Bug ID: 33781 Summary: Terminology: Item already issued to other borrower. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt:156 Item already issued to other borrower. issued should be "checked out" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:47:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 08:47:17 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-UMb9pm1a0g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Highlight in|--- |Yes release notes| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:53:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 08:53:18 +0000 Subject: [Koha-bugs] [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent In-Reply-To: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33778-70-uncHM1jlc2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:53:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 08:53:20 +0000 Subject: [Koha-bugs] [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent In-Reply-To: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33778-70-uYzbBZYMF7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151454&action=edit Bug 33778: Remove T::D::C from Auth_with_shibboleth.t This test should be in t/db. It needs patrons, categories, branches. T::D::C now hides e.g. the branchcode constraint. When removing T::D::C, we therefore need to add a branchcode in the shibboleth test config. Test plan: Run t/Auth_with_shibboleth.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:53:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 08:53:22 +0000 Subject: [Koha-bugs] [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent In-Reply-To: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33778-70-wM4aGsBwUD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151455&action=edit Bug 33778: Further polishing Use mock_preference. Move final tests for BaseURLs into one subtest. Change reset_config to allow passing parameters replacing some variables. Copyright line. Test plan: Run t/Auth_with_shibboleth.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:53:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 08:53:24 +0000 Subject: [Koha-bugs] [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent In-Reply-To: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33778-70-bjtB8cRk5h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151456&action=edit Bug 33778: Fix indentation of last subtest Only whitespace. Test plan: git diff -w HEAD~1.. t/Auth_with_shibboleth.t No differences. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:53:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 08:53:26 +0000 Subject: [Koha-bugs] [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent In-Reply-To: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33778-70-vQ33Fd3PsS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151457&action=edit Bug 33778: Move to db_dependent Test plan: Run t/db_dependent/Auth_with_shibboleth.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:54:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 08:54:16 +0000 Subject: [Koha-bugs] [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent In-Reply-To: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33778-70-IDFrQRZ07a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:55:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 08:55:16 +0000 Subject: [Koha-bugs] [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent In-Reply-To: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33778-70-JLF16caikH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 10:58:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 08:58:09 +0000 Subject: [Koha-bugs] [Bug 29099] Add support for item bundles in the inventory tool In-Reply-To: <bug-29099-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29099-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29099-70-EhnrmdxtC8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Ping Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:00:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:00:46 +0000 Subject: [Koha-bugs] [Bug 27542] It should be possible to cancel an ILL request sent to a partner In-Reply-To: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27542-70-qNH7x9sJUl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27542 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:00:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:00:49 +0000 Subject: [Koha-bugs] [Bug 27542] It should be possible to cancel an ILL request sent to a partner In-Reply-To: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27542-70-Oyk1Lm4SzV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27542 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150641|0 |1 is obsolete| | --- Comment #12 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151458&action=edit Bug 27542: Allow cancellation of partner ILL This commit enables the display of the "Revert request" button when a request's status is GENREQ / "Requested from partners" The relevant unit test has also been updated Rescued-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk> Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:00:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:00:52 +0000 Subject: [Koha-bugs] [Bug 27542] It should be possible to cancel an ILL request sent to a partner In-Reply-To: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27542-70-R7pq5VloU4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27542 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150642|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151459&action=edit Bug 27542: (follow-up) Capitalization Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk> Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:00:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:00:55 +0000 Subject: [Koha-bugs] [Bug 27542] It should be possible to cancel an ILL request sent to a partner In-Reply-To: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27542-70-CfWTeobrMp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27542 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150643|0 |1 is obsolete| | --- Comment #14 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151460&action=edit Bug 27542: (follow-up) Fix unit test Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk> Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:12:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:12:31 +0000 Subject: [Koha-bugs] [Bug 31585] "ACQUISITION ORDER" action missing from log viewer search form In-Reply-To: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31585-70-gprMhssKIj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31585 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:12:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:12:33 +0000 Subject: [Koha-bugs] [Bug 31585] "ACQUISITION ORDER" action missing from log viewer search form In-Reply-To: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31585-70-zP6O4qvJsc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31585 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151398|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151461&action=edit Bug 31585: Fix 'acquisition order' and 'acquisition claim' Added 'ACQUISITION CLAIM' and 'ACQUISITION ORDER' to the log viewer form. Please test this well (making sure there are log entries of these types and they show properly upon searching for them) Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:12:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:12:35 +0000 Subject: [Koha-bugs] [Bug 31585] "ACQUISITION ORDER" action missing from log viewer search form In-Reply-To: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31585-70-mX5xj0Wj1x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31585 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151399|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151462&action=edit Bug 31585: (follow-up) Terminology: Rename Intranet to Staff interface Just a small fix renaming one of the options to comply with terminology guidelines. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:12:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:12:43 +0000 Subject: [Koha-bugs] [Bug 31585] "ACQUISITION ORDER" action missing from log viewer search form In-Reply-To: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31585-70-frlNhFgZ2Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31585 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:21:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:21:11 +0000 Subject: [Koha-bugs] [Bug 33767] Accessibility: The 'OPAC results' page contains semantically incorrect headings In-Reply-To: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33767-70-P5xvNKVG14@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33767 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:21:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:21:13 +0000 Subject: [Koha-bugs] [Bug 33767] Accessibility: The 'OPAC results' page contains semantically incorrect headings In-Reply-To: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33767-70-y9CRIlaL0O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33767 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151420|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151463&action=edit Bug 33767: Fix incorrect heading in page-numbers.inc This patch replaces an h6 with a span to avoid a jump from h2 to h6. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:21:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:21:22 +0000 Subject: [Koha-bugs] [Bug 33767] Accessibility: The 'OPAC results' page contains semantically incorrect headings In-Reply-To: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33767-70-dDqHGVtmxY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33767 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:23:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:23:53 +0000 Subject: [Koha-bugs] [Bug 33765] Accessibility: Fix ambiguous form-field in opac-main.tt In-Reply-To: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33765-70-1AIo3zGf0y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33765 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- What about: git grep ">Login:" intranet-tmpl/prog/en/modules/acqui/supplier.tt: <p><span>Login: [% i.login | html %]</span></p> opac-tmpl/bootstrap/en/includes/masthead.inc: <label for="muserid">Login:</label><input type="text" id="muserid" name="userid" autocomplete="off" /> opac-tmpl/bootstrap/en/modules/opac-auth.tt: <label for="userid">Login:</label> opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt: <label for="username">Login:</label> opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt: <label for="userid">Login:</label> opac-tmpl/bootstrap/en/modules/opac-reset-password.tt: <label for="userid">Login:</label> opac-tmpl/bootstrap/en/modules/sco/sco-main.tt: <label for="patronlogin">Login:</label> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:24:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:24:42 +0000 Subject: [Koha-bugs] [Bug 33764] Accessibility: Fix ambiguous form-field in masthead.inc In-Reply-To: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33764-70-mwJywHc3vZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33764 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Please fix on the other report too. 33765 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:34:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:34:23 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-xFx3AUAKHY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Did we look for other occurrences of $biblio->frameworkcode that might benefit from this caching? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:36:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:36:33 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-HYMsBTyiRo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:36:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:36:36 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-IgdEh2PUNG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151291|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151464&action=edit Bug 32060: Improve performance of columns_to_str To test: 1) Ensure the following tests pass t/db_dependent/Koha/Item.t t/db_dependent/Koha/Bibio.t 2) Go to a biblio (preferably as serial) with many items and click "New" -> "New item" and note down the response time. 3) Apply the patch 4) Ensure tests in 1) still pass 5) Repeat step 2), the response time should be substantially improved Sponsored-by: Gothenburg University Library Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:36:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:36:39 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-vWRFLbOgPS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151292|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151465&action=edit Bug 32060: Use selectrow_array Trivial ergonomic patch, use selectrow_array, no need to prepare the query + perltidy the sub Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:36:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:36:59 +0000 Subject: [Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32060-70-1d5hW6ufp6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:37:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:37:25 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-YZLagf1st5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Jonathan Field <jonathan.field at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field at ptfs-europe. | |com --- Comment #8 from Jonathan Field <jonathan.field at ptfs-europe.com> --- I'll post the full comment from the screen reader assessor: - "Providing a descriptive form field label will allow users to know what information to enter in a form field. Where a series of form fields relate to similar information, the context of the form fields needs to be included in the field description. The form field label should also show how it relates to other items in the form. On the ‘Login’ page there is a form field ambiguously labelled ‘Login’. This labelling does not help the user to understand what information is required. When there are any fields that are not sufficiently labelled it will be very difficult, or impossible for the information to be successfully submitted. All form fields need to be labelled clearly. This will allow a screen reader user to have all the information needed to complete any process. When all form fields are clearly labelled, then it is not only beneficial to the visitor, but also for the site owners; as correct information will get to them." So, to summarise, "Login" is really the action that is happening on this page (we are "logging" into the system), it is ambiguous to the user as to what information to provide in order to initiate the "login". As you say, in order to login, we can use "username or cardnumber" here so maybe we should label as such? As things stand this is a WCAG 2.1 Priority A fail, not even AA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:45:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:45:12 +0000 Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for branchtransfers In-Reply-To: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33493-70-SjDYfyLFB9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- __PACKAGE__->has_many( "branchtransfer", This name is confusing. Please do something with current and in plural. current_branchtransfers ? branchtransfers_filter_by_current ? Please add a test. Did you have a use case where get_transfer did not return the right transfer? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:59:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:59:51 +0000 Subject: [Koha-bugs] [Bug 33496] Add 'host_items' param to Koha::Biblio->items In-Reply-To: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33496-70-v5vXXlVf7N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33496 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:59:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:59:53 +0000 Subject: [Koha-bugs] [Bug 33496] Add 'host_items' param to Koha::Biblio->items In-Reply-To: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33496-70-ae3UlmQDup@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33496 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149572|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151466&action=edit Bug 33496: Add 'host_items' param to Koha::Biblio->items This patch adds an option to the $biblio->items method to allow retrieving the items and analytic items for a record. This is intended to allow fetching a single Items object, and related object, rather than having to fetch the items, and the host items, and push them together This is step towards being able to fetch items using API/DataTables directly To test: 1 - prove -v t/db_dependent/Koha/Biblio.t Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:59:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:59:55 +0000 Subject: [Koha-bugs] [Bug 33496] Add 'host_items' param to Koha::Biblio->items In-Reply-To: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33496-70-qqEVNflIfA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33496 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149678|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151467&action=edit Bug 33496: (follow-up) Correct param names Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 11:59:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 09:59:57 +0000 Subject: [Koha-bugs] [Bug 33496] Add 'host_items' param to Koha::Biblio->items In-Reply-To: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33496-70-4PJH20nNB3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33496 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151468&action=edit Bug 33496: (QA follow-up) Update POD statement Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 12:00:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 10:00:19 +0000 Subject: [Koha-bugs] [Bug 33496] Add 'host_items' param to Koha::Biblio->items In-Reply-To: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33496-70-ureXOYU42D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33496 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 12:30:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 10:30:30 +0000 Subject: [Koha-bugs] [Bug 33782] New: Oauth2/OIDC identity providers code is not covered by unit tests Message-ID: <bug-33782-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33782 Bug ID: 33782 Summary: Oauth2/OIDC identity providers code is not covered by unit tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org We need to provide tests for this code. It will require mocking, or using the Mojo mocking, but should be done before we add more in this area. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 12:30:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 10:30:48 +0000 Subject: [Koha-bugs] [Bug 33782] Oauth2/OIDC identity providers code is not covered by unit tests In-Reply-To: <bug-33782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33782-70-KqsXq79rhN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33782 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33675 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 [Bug 33675] Add CSRF protection to OAuth/OIDC authentication -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 12:30:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 10:30:48 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-NxUvO1e3Mp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33782 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33782 [Bug 33782] Oauth2/OIDC identity providers code is not covered by unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 12:44:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 10:44:22 +0000 Subject: [Koha-bugs] [Bug 33783] New: Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) Message-ID: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Bug ID: 33783 Summary: Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 12:47:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 10:47:01 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-7NbnD1SScl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |8179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 12:47:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 10:47:01 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-xht6k6aHUE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33783 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 12:47:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 10:47:06 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-Tob1tOzjit@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151469&action=edit Bug 33783: (bug 8179 follow-up) Populate actual cost with ecost during receiving if not set This restores behavior prior to 8179 to use the estimated cost when receiving if the actual cost is not set To test: 1 - Add some orders to a basket, do not set actual cost field 2 - Close basket, receive orders 3 - Note actual cost field is blank 4 - Cancel receipt 5 - Apply patch 6 - Receive again 7 - Note actual cost is populated 8 - Complete receipt and confirm actual cost correctly saved -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 12:47:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 10:47:33 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-EWvhDmPsRn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 13:11:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 11:11:32 +0000 Subject: [Koha-bugs] [Bug 33774] Loading club table in every tab in patron details In-Reply-To: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33774-70-4hmIrIbi7D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |shi-yao.wang at inLibro.com, | |tomascohen at gmail.com Depends on| |26598 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Git bisect says the problem comes from Bug 26598 Display guarantee's fines on guarantor's details page Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598 [Bug 26598] Display guarantee's fines on guarantor's details page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 13:11:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 11:11:32 +0000 Subject: [Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page In-Reply-To: <bug-26598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26598-70-vAmrtwfIRJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33774 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 [Bug 33774] Loading club table in every tab in patron details -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 13:20:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 11:20:37 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16522-70-fwcVNcLGGX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 13:30:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 11:30:05 +0000 Subject: [Koha-bugs] [Bug 33774] Loading club table in every tab in patron details In-Reply-To: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33774-70-bNQm8CMeLH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 13:34:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 11:34:59 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-zp7Rl0CHGT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I see the problem, I just feel there is no easy solution. For us some libraries don't use the cardnumbers (chip cards), but only a username, other only use cardnumbers, others use both. The flexibility of Koha makes it hard to give an accurate description in terms of "one that fits all" Not a native speaker, so not sure if any of these would work: * Login name * User ID Make it super accurate, but preference + template driven to allow one of those options: * Username * Cardnumber * Username/cardnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 13:42:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 11:42:43 +0000 Subject: [Koha-bugs] [Bug 33774] Loading club table in every tab in patron details In-Reply-To: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33774-70-pYe1jBXlMI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 13:42:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 11:42:46 +0000 Subject: [Koha-bugs] [Bug 33774] Loading club table in every tab in patron details In-Reply-To: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33774-70-7wJWdo0xuD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151470&action=edit Bug 33774: Loading club table in every tab in patron details This patch corrects a minor regression in template markup caused by Bug 33774. The Bootstrap tab attributes were lost (presumably in a merge) causing the whole tab structure to break. To test, you should have at least one club defined. Apply the patch and view the patron details page. Each tab should load its contents correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 13:43:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 11:43:45 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-2mC3KOrY8a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 13:43:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 11:43:47 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-3OZtg2118Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151180|0 |1 is obsolete| | --- Comment #20 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151471&action=edit Bug 26472: Configure Elasticsearch for better alphabetic sorting This enhancement configures the ICU collation keyword plugin used by Elasticsearch for sorting to better handle punctuation and whitespace in sort fields. Details at: https://www.elastic.co/guide/en/elasticsearch/plugins/current/analysis-icu-collation-keyword-field.html https://unicode-org.github.io/icu/userguide/collation/concepts.html To test: 1 - Create authorities with main headings like below and confirm they sort in the order shown Hand blows Hand book for Prospect Park Hand (Fictitious character) Hand in glove Hand-ball Handbok for sangere Handbook for adventure Hande im Pflug Hands in the past Handu 2 - Also confirm above order is correct and expected 3 - Test biblio search sorting as well (title, author, etc) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 13:46:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 11:46:50 +0000 Subject: [Koha-bugs] [Bug 33777] Get Jenkins green again for Auth_with_shibboleth.t In-Reply-To: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33777-70-1vgEzwF36i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33777 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 13:46:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 11:46:51 +0000 Subject: [Koha-bugs] [Bug 33777] Get Jenkins green again for Auth_with_shibboleth.t In-Reply-To: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33777-70-n4gch2yMc3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33777 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 13:53:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 11:53:44 +0000 Subject: [Koha-bugs] [Bug 33774] Loading club table in every tab in patron details In-Reply-To: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33774-70-rTkbQadBFk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 13:53:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 11:53:47 +0000 Subject: [Koha-bugs] [Bug 33774] Loading club table in every tab in patron details In-Reply-To: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33774-70-qXOIledu3Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151470|0 |1 is obsolete| | --- Comment #4 from David Nind <david at davidnind.com> --- Created attachment 151472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151472&action=edit Bug 33774: Loading club table in every tab in patron details This patch corrects a minor regression in template markup caused by Bug 33774. The Bootstrap tab attributes were lost (presumably in a merge) causing the whole tab structure to break. To test, you should have at least one club defined. Apply the patch and view the patron details page. Each tab should load its contents correctly. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 14:13:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 12:13:09 +0000 Subject: [Koha-bugs] [Bug 33758] Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook In-Reply-To: <bug-33758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33758-70-eGFN2O1LFu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151426|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 151473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151473&action=edit Bug 33758 - Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook This patch adds a parameter to call the method intranet_catalog_biblio_enhancements_toolbar_button with a biblionumber in the page catalogue/detail.pl. Modification of cat-toolbar.inc to display new buttons correctly. To test : 1. Apply the patch 2. Take a plugin who implements the method intranet_catalog_biblio_enhancements_toolbar_button 3. Check if the parameter "biblionumber" is passed correctly at this method 4. Create the new button in HTML in the plugin method (button must be like the ones that are in the toolbar of the page detail.pl) 5. Go to the page in browser and check if the new button is displayed Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 14:13:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 12:13:34 +0000 Subject: [Koha-bugs] [Bug 33758] Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook In-Reply-To: <bug-33758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33758-70-N7vGiXR5OS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #4 from Sally <sally.healey at cheshiresharedservices.gov.uk> --- Test plan works as described, thanks for the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 14:15:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 12:15:44 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-PPjWbO8GRG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #10 from Owen Leonard <oleonard at myacpl.org> --- Perhaps we should say "Username or card number" ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 14:17:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 12:17:33 +0000 Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service In-Reply-To: <bug-33371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33371-70-8ZgOmycMnx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 14:17:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 12:17:36 +0000 Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service In-Reply-To: <bug-33371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33371-70-YObDDRw6t2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149060|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151474&action=edit Bug 33371: Add 'koha-common.service' systemd service to test - install current package - note following $message on install 'Failed to enable unit: Unit /run/systemd/generator.late/koha-common.service is transient or generated.' - apply patch, build package, install new package - note $message is gone! :) - test koha-common.service # systemctl start koha-common # systemctl status koha-common | grep running Active: active (running) since Sun 2023-04-02 00:27:31 NZDT <<< # systemctl stop koha-common # systemctl status koha-common | grep dead Active: inactive (dead) since Sun 2023-04-02 00:25:34 NZDT <<< Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 14:18:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 12:18:05 +0000 Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service In-Reply-To: <bug-33371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33371-70-78s7YFOWNW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 14:21:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 12:21:13 +0000 Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service In-Reply-To: <bug-33371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33371-70-nuZ4S3ycYt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 14:21:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 12:21:15 +0000 Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service In-Reply-To: <bug-33371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33371-70-jeLGfbn6Nx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 14:21:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 12:21:17 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-mN8ut3ZBWl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 14:21:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 12:21:19 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-rjFfnRZXiQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 --- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 14:21:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 12:21:21 +0000 Subject: [Koha-bugs] [Bug 33767] Accessibility: The 'OPAC results' page contains semantically incorrect headings In-Reply-To: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33767-70-7mCsFvRmFH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33767 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 14:21:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 12:21:23 +0000 Subject: [Koha-bugs] [Bug 33767] Accessibility: The 'OPAC results' page contains semantically incorrect headings In-Reply-To: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33767-70-UzI5tk7UZB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33767 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 14:24:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 12:24:53 +0000 Subject: [Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication In-Reply-To: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33675-70-LznSsLB5ze@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | Text to go in the| |This development adds release notes| |support for the `state` | |parameter generation and | |delivery when contacting | |IdPs. This is an optional | |but recommended opaque | |value in the OAuth2/OIDC | |specs that helps prevent | |CSRF attacks, but is also a | |requirement on some | |Identity Provider | |solutions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 14:55:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 12:55:28 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-YuCxt7eYax@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:14:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 13:14:34 +0000 Subject: [Koha-bugs] [Bug 33772] Header search input no longer has an outline when focused In-Reply-To: <bug-33772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33772-70-kAjJGokoiu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33772 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151475&action=edit Screenshot showing the area which could be styled Because of the underlying markup I don't think the proposed style could be achieved. This screenshot shows how it would be possible to add an outline style to the focused form field, with a border-radius added to help match the surrounding elements -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:21:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 13:21:28 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11300-70-FIDoFQO5oL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151079|0 |1 is obsolete| | --- Comment #53 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151476&action=edit Bug 11300: Add a new authority linker which searches for authority links on a Z39.50 server. This patch adds a Z39.50 Linker which searches for authority links on a remote server. If a matching authority is found, it's imported in the local database for linking with the current biblio record. If no matching authority was found on the remote server, the Linker falls back to a local authority search. Configuration : * The option "Z39.50 Server" is added to the LinkerModule preference. You must choose this to use the new Linker. * The preference LinkerZ3950Server is required and specifies which server to use for linking. It must contain the "name" of the server, as defined in the z3950servers table. * You can set the "local_first" option in the LinkerOptions preference to force the Linker to search for authorities in the local database first. If no local authority match was found, the Linker falls back to a remote Z39.50 search. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:21:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 13:21:36 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11300-70-JI2hqZkHbw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 --- Comment #54 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151477&action=edit Bug 11300: (Fix) Editing the way authority links is searched on a Z39.50 server. To test: 1. Apply the patch 2. Set the preference LinkerModule to Z39.50 Server 3. Set the preference LinkerZ3950Server to LIBRARY OF CONGRESS SUBJECTS 4. Set the preference LinkerOptions to local_first 5. Verify that your local authorities include "Perl (Computer program language)" but do not include "Scripting languages (Computer science)" 6. Cataloging > New record 7. In tab 6, field 650, paste Perl (Computer program language) in subfield a and click "Link authorities automatically" - you should be told "650 - A matching authority was found in the local database." which verifies that authority linking currently works at all. 8. Clear the 650 by clicking the "Delete this tag" icon with the red X at the end of the tag description, and paste "Scripting languages (Computer science)" in subfield a and click "Link authorities automatically" ---> you should be told "A matching authority record was found on the Z39.50 server and was imported locally." ---> you should also find the imported authority in your local authorities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:22:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 13:22:35 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11300-70-kZ4AXIwsNF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:30:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 13:30:23 +0000 Subject: [Koha-bugs] [Bug 31585] "ACQUISITION ORDER" action missing from log viewer search form In-Reply-To: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31585-70-3xRiOAZKOU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31585 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Just drop my follow-up to make this string-change-free. I'll post it on a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:30:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 13:30:38 +0000 Subject: [Koha-bugs] [Bug 31585] "ACQUISITION ORDER" action missing from log viewer search form In-Reply-To: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31585-70-kf1i9IMFzI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31585 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151462|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:44:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 13:44:41 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-mlbckfOh1u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #11 from Jonathan Field <jonathan.field at ptfs-europe.com> --- Yes, I agree Owen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:47:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 13:47:15 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-0XsoQPKjhN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |blocker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:48:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 13:48:20 +0000 Subject: [Koha-bugs] [Bug 33578] Cannot edit patron restriction types In-Reply-To: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33578-70-cokPTTD6uH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150957|0 |1 is obsolete| | --- Comment #9 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 151478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151478&action=edit Bug 33578: Fix patron restriction types edition When editing an existing patron restriction type you'll always get an error on saving: Label is already in use To test: * Activate use of patron restriction types * Edit any of the system types * Create new ones Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:48:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 13:48:22 +0000 Subject: [Koha-bugs] [Bug 33578] Cannot edit patron restriction types In-Reply-To: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33578-70-1ErMK5fDvW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150976|0 |1 is obsolete| | --- Comment #10 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 151479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151479&action=edit Bug 33578: Fix controller when editing a restriction type Do not display a warning when we are editing a restriction type and no other types with this description exists. Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:49:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 13:49:36 +0000 Subject: [Koha-bugs] [Bug 33578] Cannot edit patron restriction types In-Reply-To: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33578-70-Qw8QgdacOb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578 Michaela Sieber <michaela.sieber at kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:52:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 13:52:57 +0000 Subject: [Koha-bugs] [Bug 33764] Accessibility: Fix ambiguous form-field in masthead.inc In-Reply-To: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33764-70-gBExBdjStS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33764 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- In light of the ongoing discussion on bug 33766 I think its best to close this bug and bug 33765 and wrap all instances of this issue into bug 33766 when the discussion is concluded -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:53:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 13:53:44 +0000 Subject: [Koha-bugs] [Bug 33764] Accessibility: Fix ambiguous form-field in masthead.inc In-Reply-To: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33764-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33764-70-Tw6uQ7Pzzb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33764 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 33766 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:53:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 13:53:44 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-TL46RnAK0W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #12 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- *** Bug 33764 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:53:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 13:53:45 +0000 Subject: [Koha-bugs] [Bug 23003] Accessibility improvements In-Reply-To: <bug-23003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23003-70-Q2Z6pybefc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Bug 23003 depends on bug 33764, which changed state. Bug 33764 Summary: Accessibility: Fix ambiguous form-field in masthead.inc https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33764 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:54:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 13:54:08 +0000 Subject: [Koha-bugs] [Bug 33765] Accessibility: Fix ambiguous form-field in opac-main.tt In-Reply-To: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33765-70-eqS03DGGmI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33765 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #4 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- In light of the ongoing discussion on bug 33766 I think its best to close this bug and bug 33764 and wrap all instances of this issue into bug 33766 when the discussion is concluded *** This bug has been marked as a duplicate of bug 33766 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:54:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 13:54:08 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-49KjoZ8Mz8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #13 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- *** Bug 33765 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:54:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 13:54:08 +0000 Subject: [Koha-bugs] [Bug 23003] Accessibility improvements In-Reply-To: <bug-23003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23003-70-QtjDOt2NQo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Bug 23003 depends on bug 33765, which changed state. Bug 33765 Summary: Accessibility: Fix ambiguous form-field in opac-main.tt https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33765 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 15:55:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 13:55:20 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-NQSx0mqFjX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #14 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- There are multiple instances of this that need changing once a solution is agreed on, closing the other bugs and will wrap all the changes into this bug once we have a way forward -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:19:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:19:29 +0000 Subject: [Koha-bugs] [Bug 33784] New: Single receive - clicking the Receive link in parcel.pl should lead to the receive form Message-ID: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 Bug ID: 33784 Summary: Single receive - clicking the Receive link in parcel.pl should lead to the receive form Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org With bug 8179, a new step was added when receiving a single item. This extra step is not useful and adds clicks for the staff member who is receiving orders. To recreate: - Make sure you have budgets and vendors set up 1. Create a basket 1.1. Go to Acquisitions 1.2. Search for a vendor 1.3. Click New > Basket 1.4. Fill out the basket form 1.5. Click Save 2. Add at least one order to the basket 2.1. Click Add to basket 2.2. Click From a new (empty) record 2.3. Fill out the order form 2.4. Click Save 3. Click Close basket and confirm 4. Click Receive shipments 5. Fill out the invoice form and click Next 6. Click the Receive link on the right of the order --> This used to bring to the receive form, now you are brought to an intermediary page that I think it meant for multi-receiving *7. Click Edit 8. Edit the quantity received 9. Click Save changes *10. Click Confirm The two steps with asterisks are extra clicks from the old workflow. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:19:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:19:55 +0000 Subject: [Koha-bugs] [Bug 33784] Single receive - clicking the Receive link in parcel.pl should lead to the receive form In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-ULPgpM9JL7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Depends on| |8179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:19:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:19:55 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-fKvDmNilx8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33784 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 [Bug 33784] Single receive - clicking the Receive link in parcel.pl should lead to the receive form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:20:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:20:10 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-imkhRMVizZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:23:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:23:25 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-dNQ4ixDsQz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- We have a lot of variations where libraries only use one or the other, but having both on the label reflects what Koha actually does, so we can do that. (Still a fan of the pref idea tho - jQuery'ing your way out of such a change is no fun with lots of languages) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:29:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:29:24 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-XhBmOHkoFX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33783, 33784 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 [Bug 33784] Single receive - clicking the Receive link in parcel.pl should lead to the receive form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:29:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:29:24 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-uQzSuCp1Sr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|8179 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:29:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:29:24 +0000 Subject: [Koha-bugs] [Bug 33784] Single receive - clicking the Receive link in parcel.pl should lead to the receive form In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-pLyLKEK90j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|8179 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:30:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:30:00 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-rCz7Y22foB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33783, 33784 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 [Bug 33784] Single receive - clicking the Receive link in parcel.pl should lead to the receive form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:30:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:30:00 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-fTDxPCiayb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:30:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:30:00 +0000 Subject: [Koha-bugs] [Bug 33784] Single receive - clicking the Receive link in parcel.pl should lead to the receive form In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-TZhv3Xq6tA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:31:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:31:17 +0000 Subject: [Koha-bugs] [Bug 33784] Single receive - clicking the Receive link in parcel.pl should lead to the receive form In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-W35LmWR1sZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |blocker Depends on|8179 | CC| |michaela.sieber at kit.edu --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- 2 extra clicks for single receive vs a multiple one is a real issue. We need to bring that down to the old number of clicks for a single receive or this will be seen as a serious regression. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:31:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:31:17 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-RjtSalHTla@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33784 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 [Bug 33784] Single receive - clicking the Receive link in parcel.pl should lead to the receive form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:31:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:31:30 +0000 Subject: [Koha-bugs] [Bug 33784] Single receive - clicking the Receive link in parcel.pl should lead to the receive form In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-GIio4nY4MZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:31:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:31:30 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-LfULmGQtEC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33784 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 [Bug 33784] Single receive - clicking the Receive link in parcel.pl should lead to the receive form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:42:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:42:10 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-VwXbJOWTRL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/692 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:47:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:47:43 +0000 Subject: [Koha-bugs] [Bug 21043] Add POST endpoint for patron debits In-Reply-To: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21043-70-A7aCpxOPmJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add routes to add debits to |Add POST endpoint for |a patron's account |patron debits -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:48:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:48:15 +0000 Subject: [Koha-bugs] [Bug 29453] Add GET endpoints to fetch patron credits and debits In-Reply-To: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29453-70-uJ0VwgSaks@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add routes to fetch patron |Add GET endpoints to fetch |credits/debits |patron credits and debits -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:48:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:48:36 +0000 Subject: [Koha-bugs] [Bug 31793] Add DELETE endpoint for Authorities In-Reply-To: <bug-31793-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31793-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31793-70-75j9sEV7yB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31793 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Summary|REST API: DELETE endpoint |Add DELETE endpoint for |for Authorities |Authorities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:49:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:49:15 +0000 Subject: [Koha-bugs] [Bug 31794] Add GET endpoint for Authorities In-Reply-To: <bug-31794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31794-70-9UBPDQ5muS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REST API: GET endpoint for |Add GET endpoint for |Authorities |Authorities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:49:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:49:32 +0000 Subject: [Koha-bugs] [Bug 31795] Add POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-9bx1JkCF1d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REST API: POST endpoint for |Add POST endpoint for |Authorities |Authorities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:50:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:50:42 +0000 Subject: [Koha-bugs] [Bug 30962] Add POST endpoint for validating a user password In-Reply-To: <bug-30962-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30962-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30962-70-xPflb6yP2T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REST API: Add endpoint |Add POST endpoint for |/auth/password/validation |validating a user password CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:50:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:50:50 +0000 Subject: [Koha-bugs] [Bug 30962] Add POST endpoint for validating a user password In-Reply-To: <bug-30962-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30962-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30962-70-amD5PbAndD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:51:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:51:30 +0000 Subject: [Koha-bugs] [Bug 31800] Add POST endpoint for Biblios In-Reply-To: <bug-31800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31800-70-awxmTNRKEV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REST API: POST endpoint for |Add POST endpoint for |Biblios |Biblios -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:51:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:51:38 +0000 Subject: [Koha-bugs] [Bug 31800] Add POST endpoint for Biblios In-Reply-To: <bug-31800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31800-70-vWL6WWSqun@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:51:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:51:59 +0000 Subject: [Koha-bugs] [Bug 31801] Add PUT endpoint for Biblios In-Reply-To: <bug-31801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31801-70-0NilNxPo1s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31801 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REST API: PUT endpoint for |Add PUT endpoint for |Biblios |Biblios Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:52:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:52:06 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30358-70-KT615C16Bu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:52:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:52:31 +0000 Subject: [Koha-bugs] [Bug 32734] Add GET endpoint for listing Biblios In-Reply-To: <bug-32734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32734-70-bI0dYzzmzx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32734 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REST API: Add a list |Add GET endpoint for |endpoint for Biblios |listing Biblios -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:52:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:52:36 +0000 Subject: [Koha-bugs] [Bug 32734] Add GET endpoint for listing Biblios In-Reply-To: <bug-32734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32734-70-IbTqR2kjOr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32734 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:54:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:54:25 +0000 Subject: [Koha-bugs] [Bug 21043] Add POST endpoint for patron debits In-Reply-To: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21043-70-qhckNUJv7R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature adds the | release notes|ability to add debits to a | |patron's account via the | |REST API. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:54:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:54:39 +0000 Subject: [Koha-bugs] [Bug 29453] Add GET endpoints to fetch patron credits and debits In-Reply-To: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29453-70-4wz09Lm3wl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Sponsored by** *PTFS |**Sponsored by** *PTFS release notes|Europe* |Europe* | | |This adds GET | |endpoints for fetching | |credits and debits of a | |patron to the REST API. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:54:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:54:58 +0000 Subject: [Koha-bugs] [Bug 31793] Add DELETE endpoint for Authorities In-Reply-To: <bug-31793-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31793-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31793-70-vIsNqdONhU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31793 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This adds a DELETE endpoint | release notes|for authorities to the REST | |API. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:55:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:55:10 +0000 Subject: [Koha-bugs] [Bug 31794] Add GET endpoint for Authorities In-Reply-To: <bug-31794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31794-70-V6EJoGM1px@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This adds a GET endpoint | release notes|for authorities to the REST | |API. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:55:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:55:21 +0000 Subject: [Koha-bugs] [Bug 31795] Add POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-Eyq1OKXEhp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This adds a POST endpoint | release notes|to the REST API for adding | |new authority records. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:55:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:55:48 +0000 Subject: [Koha-bugs] [Bug 31796] Add PUT endpoint for Authorities In-Reply-To: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31796-70-ygWhYa0yr9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REST API: PUT endpoint for |Add PUT endpoint for |Authorities |Authorities Text to go in the|This adds a PUT endpoint to | release notes|the REST API for modifying | |authority records. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:55:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:55:50 +0000 Subject: [Koha-bugs] [Bug 33772] Header search input no longer has an outline when focused In-Reply-To: <bug-33772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33772-70-OhJnfGPJ9y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33772 mspinney at clamsnet.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:56:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:56:08 +0000 Subject: [Koha-bugs] [Bug 33773] Possible CSS adjustments for the header search usability improvement In-Reply-To: <bug-33773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33773-70-fpOfawr42c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33773 mspinney at clamsnet.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:56:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:56:44 +0000 Subject: [Koha-bugs] [Bug 31797] Add DELETE endpoint for Items In-Reply-To: <bug-31797-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31797-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31797-70-uEMWAkV8i8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31797 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This adds a DELETE endpoint | release notes|to allow for deleting items | |to the REST API. | Summary|REST API: DELETE endpoint |Add DELETE endpoint for |for Items |Items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:57:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:57:11 +0000 Subject: [Koha-bugs] [Bug 31798] Add POST endpoint for Items In-Reply-To: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31798-70-TvKwxS7b6r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This adds a POST endpoint | release notes|to add items to a | |bibliographic record to the | |REST API. | Summary|REST API: POST endpoint for |Add POST endpoint for Items |Items | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:58:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:58:42 +0000 Subject: [Koha-bugs] [Bug 31799] Add PUT endpoint for Items In-Reply-To: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31799-70-E8gWvyocNe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This adds a PUT endpoint | release notes|for updating items to the | |REST API. | Summary|REST API: PUT endpoint for |Add PUT endpoint for Items |Items | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:58:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:58:47 +0000 Subject: [Koha-bugs] [Bug 33773] Possible CSS adjustments for the header search usability improvement In-Reply-To: <bug-33773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33773-70-X8pI2UPdfn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33773 --- Comment #2 from mspinney at clamsnet.org --- This is great. I agree with George, thanks for your work on this Jason. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 16:59:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 14:59:47 +0000 Subject: [Koha-bugs] [Bug 32735] Add GET endpoint for listing Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-aJVtDTuTmj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REST API: Add a list |Add GET endpoint for |endpoint for Authorities |listing Authorities Text to go in the|This adds a GET endpoint to | release notes|the REST API that allows to | |request a list of | |authorities. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:01:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:01:15 +0000 Subject: [Koha-bugs] [Bug 32981] Add GET endpoint for listing authorised values by a given category In-Reply-To: <bug-32981-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32981-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32981-70-7marjZZUiy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32981 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature Summary|Add REST API endpoint to |Add GET endpoint for |list authorised values for |listing authorised values |a given category |by a given category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:01:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:01:52 +0000 Subject: [Koha-bugs] [Bug 32997] Add GET endpoint for listing authorised values by multiple given categories In-Reply-To: <bug-32997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32997-70-3XMfPNqQ6O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32997 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add REST API endpoint to |Add GET endpoint for |list authorised values for |listing authorised values |multiple given categories |by multiple given | |categories Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:03:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:03:18 +0000 Subject: [Koha-bugs] [Bug 32997] Add GET endpoint for listing authorised value categories In-Reply-To: <bug-32997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32997-70-ruIE7RDl4P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32997 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add GET endpoint for |Add GET endpoint for |listing authorised values |listing authorised value |by multiple given |categories |categories | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:03:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:03:59 +0000 Subject: [Koha-bugs] [Bug 33146] Add public GET endpoint for listing items In-Reply-To: <bug-33146-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33146-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33146-70-9n5O7sUbCz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33146 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature Summary|Add a public fetch endpoint |Add public GET endpoint for |for items |listing items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:04:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:04:35 +0000 Subject: [Koha-bugs] [Bug 33161] Implement +strings for GET /items and GET /items/:item_id In-Reply-To: <bug-33161-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33161-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33161-70-8e5U1fLaCJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33161 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Implement +strings for GET |Implement +strings for GET |/items and /items/:item_id |/items and GET | |/items/:item_id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:07:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:07:17 +0000 Subject: [Koha-bugs] [Bug 33340] Correct formatting of English 1-page order PDF when the basket group covers multiple pages In-Reply-To: <bug-33340-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33340-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33340-70-DalskwbBpq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:08:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:08:17 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31095-70-F9khogypHG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |**Sponsored by** *PTFS release notes| |Europe* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:08:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:08:50 +0000 Subject: [Koha-bugs] [Bug 32013] Autorenewals is effectively a bulk action and should be treated as such In-Reply-To: <bug-32013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32013-70-okwGGYNUJQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |**Sponsored by** *PTFS release notes| |Europe* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:10:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:10:54 +0000 Subject: [Koha-bugs] [Bug 30642] We should record the renewal type (automatic/manual) In-Reply-To: <bug-30642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30642-70-VL0eNF8aOp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30642 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This ensures that the type |**Sponsored by** *PTFS release notes|of a renewal, automatic or |Europe* |manual, is stored in the | |new column `renewal_type` |This ensures that |of the `checkout_renewals` |the type of a renewal, |table. |automatic or manual, is | |stored in the new column | |`renewal_type` of the | |`checkout_renewals` table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:12:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:12:01 +0000 Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen In-Reply-To: <bug-32373-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32373-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32373-70-EK02iVirds@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds the |**Sponsored by** *PTFS release notes|date a restriction was |Europe* |added to patron restriction | |messages, for example: |This enhancement |"Restricted since |adds the date a restriction |31/12/2022: Patron's |was added to patron |account is restricted until |restriction messages, for |31/12/2022 with the |example: "Restricted since |explanation:...". |31/12/2022: Patron's | |account is restricted until | |31/12/2022 with the | |explanation:...". CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:13:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:13:26 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-Ke2eg96EGH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:14:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:14:01 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue .js and .ts files In-Reply-To: <bug-33625-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33625-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33625-70-Kv02vMwSRF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|ERM |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:14:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:14:15 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-C1DrunDEWi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Jonathan Field <jonathan.field at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:14:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:14:35 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-EUVXQUVrGz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|ERM |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:14:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:14:47 +0000 Subject: [Koha-bugs] [Bug 33772] Header search input no longer has an outline when focused In-Reply-To: <bug-33772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33772-70-8FdlAl2zqS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33772 --- Comment #4 from mspinney at clamsnet.org --- I agree it's an accessibility concern. Thanks for working on this Jason and to Owen for the proposed updates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:17:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:17:19 +0000 Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30358-70-KV8QYxff07@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/692 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:24:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:24:55 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-S8jMhPiOfL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:25:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:25:58 +0000 Subject: [Koha-bugs] [Bug 33526] Use template wrapper for tabs: Bibliographic detail page In-Reply-To: <bug-33526-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33526-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33526-70-GtM6IFStpC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:27:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:27:08 +0000 Subject: [Koha-bugs] [Bug 33785] New: A couple more UI changes related to Bug 8179 Message-ID: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33785 Bug ID: 33785 Summary: A couple more UI changes related to Bug 8179 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org A found a couple more things to fix in the orderreceive.tt modal, related to Bug 8179. -The select2 dropdown for #bookfund is splitting onto multiple lines in the modal. -The modal header has a green line extending through it. -At smaller screen sizes the modal close button ( upper right corner of modal ) drops down below the h4. It should stay on the same line as the h4. -The modal is not centered on the screen. -The toogle inactive/active checkbox can become it's own list element. -The #current-fund can become a hint -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:27:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:27:19 +0000 Subject: [Koha-bugs] [Bug 33785] A couple more UI changes related to Bug 8179 In-Reply-To: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33785-70-DOYgEyuvo7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33785 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:27:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:27:19 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-oWjyZQFomu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33785 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33785 [Bug 33785] A couple more UI changes related to Bug 8179 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:31:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:31:11 +0000 Subject: [Koha-bugs] [Bug 33785] A couple more UI changes related to Bug 8179 In-Reply-To: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33785-70-gH8UKMpOIG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33785 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:31:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:31:13 +0000 Subject: [Koha-bugs] [Bug 33785] A couple more UI changes related to Bug 8179 In-Reply-To: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33785-70-77GBzrAs0y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33785 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151480&action=edit Bug 33785: Some UI fisex to the orderreceive.tt modal To test: 1. Apply patch 2. Follow the steps in Bug 8179 to generate the modal on orderreceive.tt 3. Check that the following issues have been corrected: -The select2 dropdown for #bookfund is splitting onto multiple lines in the modal. -The modal header has a green line extending through it. -At smaller screen sizes the modal close button ( upper right corner of modal ) drops down below the h4. It should stay on the same line as the h4. -The modal is not centered on the screen. -The toogle inactive/active checkbox can become it's own list element. -The #current-fund can become a hint -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:33:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:33:59 +0000 Subject: [Koha-bugs] [Bug 33785] A couple more UI changes related to Bug 8179 In-Reply-To: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33785-70-I9R5HtprGV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33785 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:41:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:41:57 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display OPAC news on homepage In-Reply-To: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29691-70-YlCoIH8pDv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:41:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:41:59 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display OPAC news on homepage In-Reply-To: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29691-70-B2mrBct4sZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149932|0 |1 is obsolete| | Attachment #149933|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151481&action=edit Bug 29691: Use template to display news on opac homepage This patch moves the fetching of news to the template and adds a p[lugin method to get news by id TO test: 1 - Define some general and library specific news items 2 - Define in various languages 3 - Define some 'Additional contents' as well 4 - Apply patch 5 - Confirm onlly 'all libraries' news show if not loigged in to opac 6 - Confirm correct library news show when logged in 7 - View specific news items: http://localhost:8080/cgi-bin/koha/opac-main.pl?news_id=12 8 - Confirm that non-existent ids show " This news item does not exist. " 9 - Confirm if you enter ID for additional contents you get 'does not exist' Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:42:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:42:07 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display OPAC news on homepage In-Reply-To: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29691-70-QM7IKgtqrW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151482&action=edit Bug 29691: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:43:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:43:21 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display OPAC news on homepage In-Reply-To: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29691-70-vjuCPpDzGh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:43:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:43:43 +0000 Subject: [Koha-bugs] [Bug 28658] With SearchMyLibraryFirst if library isn't set for the opac, try to guess it by checking branchip In-Reply-To: <bug-28658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28658-70-vhDZfIXqqt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:46:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:46:45 +0000 Subject: [Koha-bugs] [Bug 28657] Expand branches.branchip to allow for multiple space separated ip ranges In-Reply-To: <bug-28657-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28657-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28657-70-KLks9NrNzi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:54:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:54:01 +0000 Subject: [Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30579-70-Z4I1mbUn06@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 17:54:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 15:54:04 +0000 Subject: [Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30579-70-t9eVAmazae@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150786|0 |1 is obsolete| | --- Comment #35 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151483&action=edit Bug 30579: Disentangle multi-hold and single bib forms This patch alters the structure of the hold request page to make it clear that "Hold next available", "Hold item group", and "Hold specific item" are mutually-exclusive options. While there is some duplication from this, it makes the sections easier to read and allows for more variation in the two forms To test: 1 - Find a bib with multiple items 2 - Enable item groups and item group holds in system preferences 3 - Load the records detail page 4 - Add an item group on the item groups tab 5 - Select two items and add to the group 6 - Place a hold for a patron 7 - Confirm the three levels of holds are clear 8 - Confirm checking the radio next to one disables the others 9 - Confirm you can successfully place all 3 types of holds 10 - Confirm if placing a second hold that the type is forced correctly Signed-off-by: hinemoea <hinemoea at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 18:03:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 16:03:41 +0000 Subject: [Koha-bugs] [Bug 28657] Expand branches.branchip to allow for multiple space separated ip ranges In-Reply-To: <bug-28657-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28657-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28657-70-2IE8KUyTQC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 18:03:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 16:03:43 +0000 Subject: [Koha-bugs] [Bug 28657] Expand branches.branchip to allow for multiple space separated ip ranges In-Reply-To: <bug-28657-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28657-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28657-70-cLOE8AhkxM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149412|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151484&action=edit Bug 28657: expand branches.branchip to allow for multiple ip ranges. change branches.branchip to a mediumtext, and remove '*' from existing branchip settings. Change C4/Auth.pm from a regexp to using in_iprange() to check client address against branchip. (in_iprange() doesn't work with '*' in branchip.) Change in_iprange() to default to false (which is what the POD says it should do). Also, have it trim '*' in case someone adds some back later. Change note in admin/branches.tt under branchip field to reflect changes to branchip handling. Test plan: 1. Turn on AutoLocation system preference 2. Change a branches branchip to multiple ip ranges seperated by a space, making sure one of the ranges includes your computers address. 3. Log out and try logging in. The location check will fail. 4. Apply patch. Restart plack if necessary. 5. Try logging in again. The location check will succeed. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 18:03:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 16:03:49 +0000 Subject: [Koha-bugs] [Bug 28657] Expand branches.branchip to allow for multiple space separated ip ranges In-Reply-To: <bug-28657-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28657-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28657-70-g0GUzjCfnX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657 --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151485&action=edit Bug 28657: (QA follow-up) Return 1 if no range, improve unit tests Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 18:22:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 16:22:30 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-KOrH9yrQx1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 18:27:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 16:27:56 +0000 Subject: [Koha-bugs] [Bug 33786] New: ILL requests table pagination in borrower history is transposing for different borrowers Message-ID: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Bug ID: 33786 Summary: ILL requests table pagination in borrower history is transposing for different borrowers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com CC: katrin.fischer at bsz-bw.de, martin.renvoize at ptfs-europe.com, nick at bywatersolutions.com, pedro.amorim at ptfs-europe.com, tomascohen at gmail.com Depends on: 22440 Reproduce: 1) Have a borrower with >20 ILL requests in their history 2) Visit cgi-bin/koha/members/ill-requests.pl?borrowernumber=<borrowernumber> 3) On the table, click page 2 4) Visit a different borrower with <20 ILL requests 5) Verify that no requests are shown, this is because the table is using page 2 from step 3) 6) Go back to original borrower, click table page 1 7) Now go back to 2nd borrower, verify is now showing page 1 correctly Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 [Bug 22440] Improve ILL page performance by moving to server side filtering -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 18:27:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 16:27:56 +0000 Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to server side filtering In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-pw8CUHsjUR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 18:51:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 16:51:52 +0000 Subject: [Koha-bugs] [Bug 33195] Reindent the bibliographic details page In-Reply-To: <bug-33195-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33195-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33195-70-M0vxxPiMTh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151486&action=edit Three related bibliographic records This MARC file can be imported and used for testing FRBRizeEditions with ThingISBN -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 18:54:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 16:54:36 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-Bzp322h1L7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 18:54:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 16:54:39 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-7eSaj8TXSF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 --- Comment #1 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151487&action=edit Bug 33786: set stateSave to false This fixes the issue, but I wonder if this is the fix for this, or a better alternative exists -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 18:54:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 16:54:50 +0000 Subject: [Koha-bugs] [Bug 33195] Reindent the bibliographic details page In-Reply-To: <bug-33195-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33195-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33195-70-MDRh0Uu8XG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Bug 8377 has a sample MARC file for testing HTML5MediaEnabled: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10685 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 19:33:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 17:33:53 +0000 Subject: [Koha-bugs] [Bug 23450] Display issue and subscription price for each issue in subscription tab of /catalogue/detail.pl In-Reply-To: <bug-23450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23450-70-BksL144EJW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23450 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |samalau at gmail.com --- Comment #10 from Sam Lau <samalau at gmail.com> --- CONFLICT (content): Merge conflict in C4/Serials.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 19:34:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 17:34:30 +0000 Subject: [Koha-bugs] [Bug 33787] New: Remove option to archive system debit types Message-ID: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 Bug ID: 33787 Summary: Remove option to archive system debit types Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It should not be possible to archive system debit types (such as ACCOUNT, OVERDUE, RENT, etc). Only the manual types should have that option. To recreate: 1. Go to Administration > Debit types 2. Click Show all debit types --> Note that *all* debit types have both the Edit and Archive buttons Possibly a regression from bug 32450 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 19:35:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 17:35:04 +0000 Subject: [Koha-bugs] [Bug 33787] Remove option to archive system debit types In-Reply-To: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33787-70-xPMDBA6CwJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |martin.renvoize at ptfs-europe | |.com Depends on| |32450 Severity|enhancement |normal Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 19:35:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 17:35:04 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-Mz8iSguFOE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33787 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 [Bug 33787] Remove option to archive system debit types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 19:37:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 17:37:22 +0000 Subject: [Koha-bugs] [Bug 33787] Remove option to archive system debit types In-Reply-To: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33787-70-QRcn6ov2Wa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I tried Martin's fix https://gitlab.com/mrenvoize/Koha/-/commit/824e4220c712b2a9de9e5666216f6d853889d46f And it works. Ready to sign-off :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 19:40:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 17:40:52 +0000 Subject: [Koha-bugs] [Bug 33788] New: moredetail.pl shows all (many?) previous borrowers instead of 3 Message-ID: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 Bug ID: 33788 Summary: moredetail.pl shows all (many?) previous borrowers instead of 3 Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: sbrown at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 151488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151488&action=edit moredetail.pl Instead of showing the last 3 borrowers per bug 32272, moredetail.pl is showing all previous borrowers for items (see attached). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 19 19:44:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 17:44:17 +0000 Subject: [Koha-bugs] [Bug 33526] Use template wrapper for tabs: Bibliographic detail page In-Reply-To: <bug-33526-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33526-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33526-70-bQgXmJXYJV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 19:44:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 17:44:19 +0000 Subject: [Koha-bugs] [Bug 33526] Use template wrapper for tabs: Bibliographic detail page In-Reply-To: <bug-33526-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33526-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33526-70-KaGXpNi0OB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151489&action=edit Bug 33526: Use template wrapper for tabs: Bibliographic detail page This patch updates the bibliographic detail page so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test, apply the patch and view the detail page for a bibliographic record. Test the tabs in as many variations as you can: - With and without SeparateHoldings enabled - With and without cover images enabled - With FRBRizeEditions enabled (and multiple editions in your catalog) - See Bug 33195 for a MARC file to use when testing FRBRizeEditions with ThingISBN - With LocalCoverImages enabled - With AcquisitionDetails enabled - With a serial record - With a record added from a suggestion - With a record with component parts - See Bug 11175 for a MARCXML file to use to test this feature - With EnableItemGroups enabled - Wtih CatalogConcerns enabled - With HTML5MediaEnabled and a record with media links - See Bug 8377 for a MARC file to use to test this feature - With and without NovelistSelect enabled (requires Novelist credentials) - With NovelistSelectStaffView set to "above the holdings table," "below the holdings table," and "in a tab" - With a plugin enabled which adds a tab to this view - See Bug 27120 for a sample plugin for testing plugin-generated tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 19:55:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 17:55:02 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-ahDIje29Bi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/692 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:04:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 18:04:18 +0000 Subject: [Koha-bugs] [Bug 33785] A couple more UI changes related to Bug 8179 In-Reply-To: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33785-70-0po12Deerr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33785 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:04:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 18:04:20 +0000 Subject: [Koha-bugs] [Bug 33785] A couple more UI changes related to Bug 8179 In-Reply-To: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33785-70-WefRne47xA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33785 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151480|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:04:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 18:04:40 +0000 Subject: [Koha-bugs] [Bug 33785] A couple more UI changes related to Bug 8179 In-Reply-To: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33785-70-uZ4ChdxCp7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33785 --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151490&action=edit Bug 33785: Some UI fixes to the orderreceive.tt modal To test: 1. Apply patch 2. Follow the steps in Bug 8179 to generate the modal on orderreceive.tt 3. Check that the following issues have been corrected: -The select2 dropdown for #bookfund is splitting onto multiple lines in the modal. -The modal header has a green line extending through it. -At smaller screen sizes the modal close button ( upper right corner of modal ) drops down below the h4. It should stay on the same line as the h4. -The modal is not centered on the screen. -The toogle inactive/active checkbox can become it's own list element. -The #current-fund can become a hint Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:05:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 18:05:53 +0000 Subject: [Koha-bugs] [Bug 33785] A couple more UI changes related to Bug 8179 In-Reply-To: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33785-70-bQFbpqWWJQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33785 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:05:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 18:05:58 +0000 Subject: [Koha-bugs] [Bug 32335] Allow stock rotation items to be moved several stages ahead In-Reply-To: <bug-32335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32335-70-QIHL4w0VLJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:06:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 18:06:00 +0000 Subject: [Koha-bugs] [Bug 32335] Allow stock rotation items to be moved several stages ahead In-Reply-To: <bug-32335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32335-70-SM3fg88jWp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148748|0 |1 is obsolete| | --- Comment #10 from Sam Lau <samalau at gmail.com> --- Created attachment 151491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151491&action=edit Bug 32335: Allow stock rotation items to be advanced when in transit This patch adjusts the logic so that we check: 1 - If there are less than 2 stages we disable the 'Move to next stage' button 2 - If the item is not in transit, we show move to next normally 3 - If the item is in transit (and there is more than 1 stage) the button is enabled with a note about transfer To test: 1 - Setup a rota with multiple stages 2 - Add an item 3 - Advance to next stage 4 - Observe 'Move to next stage' button is disabled 5 - Check item in at destination 6 - Reload rota - observe 'Move to next stage' is enabled 7 - Apply patch 8 - Click 'Move to next stage' 9 - Note button is not disabled 10 - Hover and confirm note about transit 11 - Click 'Move to next stage' 12 - Checkin item at wrong branch, confirm it is correctly directed to correct stage Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:06:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 18:06:22 +0000 Subject: [Koha-bugs] [Bug 31585] "ACQUISITION ORDER" action missing from log viewer search form In-Reply-To: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31585-70-vzgpoIJ7ob@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31585 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:06:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 18:06:23 +0000 Subject: [Koha-bugs] [Bug 31585] "ACQUISITION ORDER" action missing from log viewer search form In-Reply-To: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31585-70-mxSncYFrUp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31585 --- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:06:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 18:06:25 +0000 Subject: [Koha-bugs] [Bug 33785] A couple more UI changes related to Bug 8179 In-Reply-To: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33785-70-q2tJV84OTg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33785 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:06:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 18:06:27 +0000 Subject: [Koha-bugs] [Bug 33785] A couple more UI changes related to Bug 8179 In-Reply-To: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33785-70-JjZyVBAemI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33785 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:07:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 18:07:57 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-b8SplYcNbf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:29:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 18:29:16 +0000 Subject: [Koha-bugs] [Bug 33362] Return claims can be un-resolvable if issue_id is set but no issue is found in issues or old_issues In-Reply-To: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33362-70-uAuzRqrzdq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33362 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:29:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 18:29:18 +0000 Subject: [Koha-bugs] [Bug 33362] Return claims can be un-resolvable if issue_id is set but no issue is found in issues or old_issues In-Reply-To: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33362-70-SKdRvUON34@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33362 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151085|0 |1 is obsolete| | --- Comment #3 from Sam Lau <samalau at gmail.com> --- Created attachment 151492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151492&action=edit Bug 33362: Allow return claims to be resolved even if the issue has since been delete from the database Test Plan: 1) Check out an item 2) Claim return on it, moving it to the old_issues table 3) Delete the old_issue via koha-mysql or Use cleanup_database.pl 4) Attempt to resolve the claim 5) Note the error 6) Apply this patch set 7) Restart all the things! 8) Attempt to resolve the claim 9) No errors! Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:36:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 18:36:46 +0000 Subject: [Koha-bugs] [Bug 33788] moredetail.pl shows all (many?) previous borrowers instead of 3 In-Reply-To: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33788-70-zQoRHDnUPp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 blawlor at clamsnet.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor at clamsnet.org --- Comment #1 from blawlor at clamsnet.org --- One possible workaround I thought of would be to use javascript to remove all children <li> after the sixth one in the <ol class="bibliodetails"> on the item details page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:40:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 18:40:19 +0000 Subject: [Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers In-Reply-To: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33761-70-owfsTRnsZT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com --- Comment #8 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Can this be backported to 22.11.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:44:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 18:44:27 +0000 Subject: [Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30579-70-LeEuD1gEOv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 20:44:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 18:44:30 +0000 Subject: [Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30579-70-Xfa1DDPrPm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151483|0 |1 is obsolete| | --- Comment #36 from Sam Lau <samalau at gmail.com> --- Created attachment 151493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151493&action=edit Bug 30579: Disentangle multi-hold and single bib forms This patch alters the structure of the hold request page to make it clear that "Hold next available", "Hold item group", and "Hold specific item" are mutually-exclusive options. While there is some duplication from this, it makes the sections easier to read and allows for more variation in the two forms To test: 1 - Find a bib with multiple items 2 - Enable item groups and item group holds in system preferences 3 - Load the records detail page 4 - Add an item group on the item groups tab 5 - Select two items and add to the group 6 - Place a hold for a patron 7 - Confirm the three levels of holds are clear 8 - Confirm checking the radio next to one disables the others 9 - Confirm you can successfully place all 3 types of holds 10 - Confirm if placing a second hold that the type is forced correctly Signed-off-by: hinemoea <hinemoea at inlibro.com> Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 21:33:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 19:33:00 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11300-70-1qUlkeDezo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau at gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 21:41:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 19:41:42 +0000 Subject: [Koha-bugs] [Bug 33668] Add a 'clear search' button/icon inside the search input box on the OPAC In-Reply-To: <bug-33668-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33668-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33668-70-BUx21x0BSc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com Assignee|oleonard at myacpl.org |Laura.escamilla at bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 21:46:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 19:46:28 +0000 Subject: [Koha-bugs] [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent In-Reply-To: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33778-70-a1g6n823uE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 21:46:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 19:46:30 +0000 Subject: [Koha-bugs] [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent In-Reply-To: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33778-70-6ph0MhioyH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151454|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Created attachment 151494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151494&action=edit Bug 33778: Remove T::D::C from Auth_with_shibboleth.t This test should be in t/db. It needs patrons, categories, branches. T::D::C now hides e.g. the branchcode constraint. When removing T::D::C, we therefore need to add a branchcode in the shibboleth test config. Test plan: Run t/Auth_with_shibboleth.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 21:46:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 19:46:33 +0000 Subject: [Koha-bugs] [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent In-Reply-To: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33778-70-nMyFXcZJon@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151455|0 |1 is obsolete| | --- Comment #6 from David Nind <david at davidnind.com> --- Created attachment 151495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151495&action=edit Bug 33778: Further polishing Use mock_preference. Move final tests for BaseURLs into one subtest. Change reset_config to allow passing parameters replacing some variables. Copyright line. Test plan: Run t/Auth_with_shibboleth.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 21:46:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 19:46:35 +0000 Subject: [Koha-bugs] [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent In-Reply-To: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33778-70-QwElVP2CVl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151456|0 |1 is obsolete| | --- Comment #7 from David Nind <david at davidnind.com> --- Created attachment 151496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151496&action=edit Bug 33778: Fix indentation of last subtest Only whitespace. Test plan: git diff -w HEAD~1.. t/Auth_with_shibboleth.t No differences. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 21:46:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 19:46:38 +0000 Subject: [Koha-bugs] [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent In-Reply-To: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33778-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33778-70-rGYEreKNoW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151457|0 |1 is obsolete| | --- Comment #8 from David Nind <david at davidnind.com> --- Created attachment 151497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151497&action=edit Bug 33778: Move to db_dependent Test plan: Run t/db_dependent/Auth_with_shibboleth.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 21:52:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 19:52:22 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11300-70-XjDDNIsOX3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 --- Comment #55 from Phil Ringnalda <phil at chetcolibrary.org> --- Sorry if my "super-simple test plan" was confusing. I didn't intend that to be a description of everything the feature should do, only a super-simple way to tell whether or not it does anything at all, because testers have been asking for that since 2018. I certainly didn't intend to imply that the only thing a linker needs to do is link subjects which have only subfield a. A real test plan would include all the authority types that automatic linking supports, and headings with multiple subfields, and headings that should not match (for example, LC has an authority record for 150 $aAbandoned children$vFiction, which should not match 650 $aAbandoned children$xFiction, and $aAlabama$xHistory$yCivil War, 1861-1865 should match but in a different order $aAlabama$yCivil War, 1861-1865$xHistory should not). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 22:01:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 20:01:14 +0000 Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments In-Reply-To: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29145-70-GA8OQbQEEY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #44 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- Hi all! What's the current status of this patch? Is "Patch doesn't apply" accurate? David, will you be working on rebasing it? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 22:32:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 20:32:07 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-F5sKnZQn7P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau at gmail.com Status|Needs Signoff |Failed QA --- Comment #2 from Sam Lau <samalau at gmail.com> --- Created a new basket and added various items to basket, giving each one a vendor price, however leaving actual cost blank. After adding to basket, I closed basket and received the orders. Actual cost field was blank on the receipt. Canceled the receipt and applied patch. Received orders again. This time when I was receiving I noticed that the actual cost was showing up while receiving, however after finishing and viewing the receipt, the actual cost was still left blank. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 22:50:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 20:50:54 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-KVSUuf42to@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 19 23:05:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 21:05:59 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-rWhOPywQAc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/692 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 00:02:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 22:02:32 +0000 Subject: [Koha-bugs] [Bug 33789] New: Issue information is missing when adding a credit Message-ID: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789 Bug ID: 33789 Summary: Issue information is missing when adding a credit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org add_credit does not pass any issue information when the credit is related to an issue. It would be handy if it did. To recreate: 1. Make sure MarkLostItemsAsReturned is set so a lost item will stay on a patrons account after being marked as lost. 2. Check an item out to a patron, make sure it has a replacementprice 3. Mark the item as lost. 4. Now check the item in. 5. Go to the patrons account -> transaction tab. You should see 2 accountlines related to the item. 6. For the account type 'Lost item' you will see issue infomation ( check out date, due date, checkouted out from, etc ) 7. For the account type 'Lost item fee refund' there is no issue information. It would be helpful for librarians if they could see this information in both places. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 00:02:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 22:02:44 +0000 Subject: [Koha-bugs] [Bug 33789] Issue information is missing when adding a credit In-Reply-To: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33789-70-pVmrJOHuWh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 00:10:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 22:10:32 +0000 Subject: [Koha-bugs] [Bug 33789] Issue information is missing when adding a credit In-Reply-To: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33789-70-XzR1g9HQej@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 00:10:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 22:10:34 +0000 Subject: [Koha-bugs] [Bug 33789] Issue information is missing when adding a credit In-Reply-To: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33789-70-uyE1vqyhum@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151498&action=edit Bug 33789: Return issue info. when adding a credit To test: 1. Make sure MarkLostItemsAsReturned is set so a lost item will stay on a patrons account after being marked as lost. 2. Check an item out to a patron, make sure it has a replacementprice 3. Mark the item as lost. 4. Now check the item in. 5. Go to the patrons account -> transaction tab. You should see 2 accountlines related to the item. 6. For the account type 'Lost item' you will see issue infomation ( check out date, due date, checkouted out from, etc ) 7. For the account type 'Lost item fee refund' there is no issue information. 8. Apply patch 9. Try 2 - 6 again. This time the 'Lost item fee refund' should include issue information. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 00:10:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 22:10:43 +0000 Subject: [Koha-bugs] [Bug 33789] Issue information is missing when adding a credit In-Reply-To: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33789-70-xQtpFAtyE6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 00:12:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 May 2023 22:12:36 +0000 Subject: [Koha-bugs] [Bug 33789] Issue information is missing when adding a credit In-Reply-To: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33789-70-rocE26En6q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 02:43:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2023 00:43:44 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: <bug-28491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28491-70-8jSUD9uxgJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil at chetcolibrary.org --- Comment #26 from Phil Ringnalda <phil at chetcolibrary.org> --- (In reply to Martin Renvoize from comment #23) > Do you understand how subfield z vs subfield a work here.. my interpretation > is that a = 'current' (i.e what we're replacing with) and z = 'cancelled'. > > So am I right in thinking.. if we replace 001 + 003 on import we should add > a 035 with a = (new003)new001 and z (original003)original001. That idea misses the text in https://www.loc.gov/marc/bibliographic/bd035.html saying "Control number for the record in a system other than the one whose control number is contained in field 001 (Control Number), field 010 (Library of Congress Control Number), or field 016 (National Bibliographic Agency Control Number)." Since ours is in 001, we shouldn't be putting it in 035, never mind the part where $z should indeed mean "the organization in () has said that this number is canceled or invalid" rather than "I'm personally not currently using this number in 001." But, neither of those mean we can't push ahead with misusing 035, since the entire idea requires misuse. If the original 003 is a national library and the original 001 is in either 010 or 016, then putting it in 035 is also wrong. However, the existence of an 010 doesn't mean a record came from the LC, and unless we delete existing 035s before adding ours, the existence of an 035 $a(OCoLC) doesn't mean it came from OCLC. In fact, for a name heading first created by a NACO cataloger using OCLC, the OCLC record has an 010 but no 035 because OCLC's control number is in 001, and the LC record has an OCLC 035 from when LC imported it. And there's no meaning to the order of fields, and no 035 subfield which in any way says "this is the one that means something about where a Koha user imported this record from" so we would either have to use a very fragile system of saying "the source of the record is in the (first|last) 035, unless one of your employees or an outside contractor doing authority control didn't know that special fact and put one (before|after) it" or be overly-aggressive and delete every existing 035 before adding our One True 035. Or, we could do what the spec really wants, and define 935 $a(original003)original001 as being (within a Koha instance) the source from which we imported a record, and then people would only have to look in two places: if 935 exists, it's where it came from, if not and 003 is not your marcorgcode (or, not any of your marcorgcodes if you have them per-library) then it's an old import and the 003 is where it came from, if not then 003 is your marcorgcode and you're where it came from. We would have to clobber any existing 935, whether it was one of ours coming from an import from another Koha instance or one from elsewhere with a different meaning, but hey, that's how locally-defined works. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 20 03:57:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2023 01:57:32 +0000 Subject: [Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page In-Reply-To: <bug-26598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26598-70-Z22V9tF8OE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598 --- Comment #20 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Created attachment 151499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151499&action=edit Bug 33774: Loading club table in every tab in patron details This patch corrects a minor regression in template markup caused by Bug 33774. The Bootstrap tab attributes were lost (presumably in a merge) causing the whole tab structure to break. To test, you should have at least one club defined. Apply the patch and view the patron details page. Each tab should load its contents correctly. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 03:59:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2023 01:59:11 +0000 Subject: [Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page In-Reply-To: <bug-26598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26598-70-q8aKkXa1OT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151499|0 |1 is obsolete| | --- Comment #21 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Comment on attachment 151499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151499 Bug 33774: Loading club table in every tab in patron details oops, wrong ticket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 04:00:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2023 02:00:06 +0000 Subject: [Koha-bugs] [Bug 33774] Loading club table in every tab in patron details In-Reply-To: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33774-70-hGye64mwFP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151472|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Created attachment 151500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151500&action=edit Bug 33774: Loading club table in every tab in patron details This patch corrects a minor regression in template markup caused by Bug 33774. The Bootstrap tab attributes were lost (presumably in a merge) causing the whole tab structure to break. To test, you should have at least one club defined. Apply the patch and view the patron details page. Each tab should load its contents correctly. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> https://bugs.koha-community.org/show_bug.cgi?id=26598 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 04:02:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2023 02:02:20 +0000 Subject: [Koha-bugs] [Bug 33774] Loading club table in every tab in patron details In-Reply-To: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33774-70-cE7QmWQZEE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151500|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Created attachment 151501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151501&action=edit Bug 33774: Loading club table in every tab in patron details This patch corrects a minor regression in template markup caused by Bug 33774. The Bootstrap tab attributes were lost (presumably in a merge) causing the whole tab structure to break. To test, you should have at least one club defined. Apply the patch and view the patron details page. Each tab should load its contents correctly. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 04:03:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2023 02:03:21 +0000 Subject: [Koha-bugs] [Bug 33774] Loading club table in every tab in patron details In-Reply-To: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33774-70-k60VMMcl4l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA --- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 14:37:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2023 12:37:15 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26472-70-iZFVfC97wB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 --- Comment #21 from Janusz Kaczmarek <januszop at gmail.com> --- I have tried the patch. Maybe I'm doing something wrong but I was unable to get correct results. In fact, applying the patch did not change anything in the order--I'm getting: Hand (Fictitious character) Hand blows Hand book for Prospect Park Hand in glove Hand-ball Handbok for sangere Handbook for adventure Hande im Pflug Hands in the past Handu Same problems with an alternate names set--I'm getting: Kowal L.G. Kowal-Kwiatkowska, Aleksandra Kowal-Orczykowska, Anna Kowal, Alina Kowalak, Alina whereas I would expect: Kowal, Alina Kowal-Kwiatkowska, Aleksandra Kowal L.G. Kowal-Orczykowska, Anna Kowalak, Alina Unfortunately, the original proposal (alternate: shifted) also does not work well here (but the order changes, so there is no question of changing wrong file). Any suggestions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 17:53:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2023 15:53:03 +0000 Subject: [Koha-bugs] [Bug 33789] Checkout information is missing when adding a credit In-Reply-To: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33789-70-bv5Xp6iDX8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Issue information is |Checkout information is |missing when adding a |missing when adding a |credit |credit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 20 18:06:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 May 2023 16:06:08 +0000 Subject: [Koha-bugs] [Bug 33773] Possible CSS adjustments for the header search usability improvement In-Reply-To: <bug-33773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33773-70-O7c44V1b42@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33773 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 18:43:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2023 16:43:49 +0000 Subject: [Koha-bugs] [Bug 33663] Don't hide Suggestions link in side navigation when suggestion preference is disabled In-Reply-To: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33663-70-glgWfVz5m7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 --- Comment #3 from Michaela Sieber <michaela.sieber at kit.edu> --- Test Plan: Go to system pref and disable 'suggestion' (disable purchase suggestions in the OPAC.) Go to Acquisition and recognize that the suggestions link in the sidebar navigation in the acquisition module does not appear any more. Apply Patch - Go to system pref and disable 'suggestion' - Go to Acquisition and recognize that the suggestions link in the sidebar navigation in the acquisition module exists - Sign Off :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 18:44:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2023 16:44:59 +0000 Subject: [Koha-bugs] [Bug 33663] Don't hide Suggestions link in side navigation when suggestion preference is disabled In-Reply-To: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33663-70-PPOwucLlOx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150950|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 151502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151502&action=edit Bug 33663: Don't hide Suggestions link in side navigation when suggestion preference is disabled We don't want to depend on the pref for the staff interface. Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 18:45:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2023 16:45:02 +0000 Subject: [Koha-bugs] [Bug 33663] Don't hide Suggestions link in side navigation when suggestion preference is disabled In-Reply-To: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33663-70-2nHEyLpiMI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150951|0 |1 is obsolete| | --- Comment #5 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 151503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151503&action=edit Bug 33663: Pass 'suggestion' to the OPAC templates only We don't need it for the staff interface. The previous patch is removing the only occurrence using it. Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 18:45:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2023 16:45:34 +0000 Subject: [Koha-bugs] [Bug 33663] Don't hide Suggestions link in side navigation when suggestion preference is disabled In-Reply-To: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33663-70-yKfx3CHTHR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 Michaela Sieber <michaela.sieber at kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 21 21:52:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2023 19:52:49 +0000 Subject: [Koha-bugs] [Bug 33790] New: identity_providers.pl does not have Help link to manual Message-ID: <bug-33790-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33790 Bug ID: 33790 Summary: identity_providers.pl does not have Help link to manual Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: hebah at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 31378 The new identity_providers integration in the staff client introduced via bug 31378 does not link to a relevant section in the help manual. I'm also not seeing information on it in the manual where I would expect it: https://koha-community.org/manual//22.11/en/html/administration.html#additional-parameters Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 [Bug 31378] Add a generic OAuth2/OIDC client implementation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 21 21:52:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2023 19:52:49 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31378-70-vZtCDf5Ihw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 hebah at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33790 [Bug 33790] identity_providers.pl does not have Help link to manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 01:15:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2023 23:15:59 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: <bug-28491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28491-70-zQsFWREGxh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 --- Comment #27 from David Cook <dcook at prosentient.com.au> --- "...The MARC code identifying whose system control number is present in field 001 is contained in field 003 (Control Number Identifier). An organization using a record of another organization may move the incoming control number from field 001 (and the control number identifier from field 003) to field 035 (System Control Number), 010 (Library of Congress Control Number), or 016 (National Bibliographic Agency Control Number), as appropriate, and place its own system control number in field 001 (and its control number identifier in field 003)." https://www.loc.gov/marc/authority/ad001.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 01:23:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2023 23:23:26 +0000 Subject: [Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories In-Reply-To: <bug-33776-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33776-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33776-70-AdtLdrXLXi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 01:23:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2023 23:23:29 +0000 Subject: [Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories In-Reply-To: <bug-33776-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33776-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33776-70-Fn8ewKnoCO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151451|0 |1 is obsolete| | --- Comment #3 from David Nind <david at davidnind.com> --- Created attachment 151504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151504&action=edit Bug 33776: Additional default plugin repo in koha-conf-site.xml.in Solutions inLibro started formating its repository to be found by Bug 23975. This patch adds it to the default list in the config template. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 01:32:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2023 23:32:13 +0000 Subject: [Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories In-Reply-To: <bug-33776-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33776-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33776-70-yyJMfv86Al@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind <david at davidnind.com> --- Testing notes (using koha-testing-docker): 1. Apply this patch. 2. Copy the <plugin_repos> block from debian/templates/koha-conf-site.xml.in to /etc/koha/sites/kohadev/koha-conf.xml 2.1 This block should now include details for inLibro's repository. 2.2 Remove the comment lines (<!-- and -->). 3. Restart everything (flush_memcached and then restart_all). 4. Go to the plugins home page (Administration > Plugins > Manage plugins). 5. In the 'Search for plugins' search box (under and to the right of the Plugins heading), search for carrousel 6. The search results should include the koha-plugin-carrousel, with the organization show as Solutions inLibro. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 01:37:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2023 23:37:07 +0000 Subject: [Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories In-Reply-To: <bug-33776-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33776-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33776-70-QeTmmYQF08@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds release notes| |inLibro to the list of git | |repositories searched for | |plugins. | | | |Notes: | |- The | |ability to search git | |repositories for plugins | |from the manage plugins | |page, and then install, | |requires a system-level | |configuration change for | |your Koha instance(s). | |- To | |enable, copy the | |<plugin_repos> block from | |debian/templates/koha-conf- | |site.xml.in to your | |instance's koha-conf.xml | |file, remove comments, and | |restart. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 01:43:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 May 2023 23:43:16 +0000 Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service In-Reply-To: <bug-33371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33371-70-RNhyyZL9qE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 02:19:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 00:19:12 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-wmOMACGz8B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |david at davidnind.com --- Comment #41 from David Nind <david at davidnind.com> --- Patch no longer applies 8-(.. (from trying to test bug 24401): git bz apply 23336 Bug 23336 - Add an API endpoint for checking an item out to a patron 151322 - Bug 23336: (QA follow-up) Some minor fixes 151353 - Bug 23336: Unit tests 151354 - Bug 23336: Add checkout API's 151355 - Bug 23336: Fix inconsistent return of AddIssue 151356 - Bug 23336: (follow-up) Switch to using Koha::Token 151357 - Bug 23336: (QA follow-up) Minor fixes Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23336: (QA follow-up) Some minor fixes error: sha1 information is lacking or useless (Koha/REST/V1/Checkouts.pm). error: could not build fake ancestor Patch failed at 0001 Bug 23336: (QA follow-up) Some minor fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 02:20:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 00:20:10 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24401-70-UynlAQ6jGw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #8 from David Nind <david at davidnind.com> --- The patches for bug 23336 no longer apply - I will retest when that is fixed (I have changed the status for that bug). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 02:56:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 00:56:29 +0000 Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service In-Reply-To: <bug-33371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33371-70-PGiAaGym7d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- I don't know about this one... It feels hacky and yet it should work. On one hand, it would be nice to convert from the SysV init script to a Systemd unit. On the other hand, Systemd doesn't work well for containers. Maybe we should have a script or scripts that are called by either the SysV init, Systemd, or whatever management program we choose. That's for the future though I think... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 09:55:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 07:55:30 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33766-70-T7h0egfMZ7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:39:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 08:39:29 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33716-70-oFC1FvvdmA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Jonathan Field <jonathan.field at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:46:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 08:46:30 +0000 Subject: [Koha-bugs] [Bug 33787] Remove option to archive system debit types In-Reply-To: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33787-70-DzL5BjHpHH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151505&action=edit Bug 33787: Fix for regression caused by bug 32450 This patch fixes the regression cashed by bug 32450 where we accidentally introduced the option to archive system debit types. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:47:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 08:47:00 +0000 Subject: [Koha-bugs] [Bug 33787] Remove option to archive system debit types In-Reply-To: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33787-70-HlnbqzMhvV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks for spotting this, reporting it and then testing the fix Caroline :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:47:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 08:47:05 +0000 Subject: [Koha-bugs] [Bug 33787] Remove option to archive system debit types In-Reply-To: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33787-70-OPCYwysMFJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:47:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 08:47:10 +0000 Subject: [Koha-bugs] [Bug 33787] Remove option to archive system debit types In-Reply-To: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33787-70-KDu5MYKLmB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:47:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 08:47:39 +0000 Subject: [Koha-bugs] [Bug 33787] Remove option to archive system debit types In-Reply-To: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33787-70-FfrA0AZKQH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 10:47:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 08:47:52 +0000 Subject: [Koha-bugs] [Bug 33787] Remove option to archive system debit types In-Reply-To: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33787-70-e6k2ZjziqM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 11:54:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 09:54:50 +0000 Subject: [Koha-bugs] [Bug 33791] New: $hold->fill does not set itemnumber when checking out without confirming hold Message-ID: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Bug ID: 33791 Summary: $hold->fill does not set itemnumber when checking out without confirming hold Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If you add a hold on a book (next available), and then checkout an item of this book to the same patron, the hold is filled but without itemnumber. Since we normally expect an itemnumber in old_reserves, this may be confusing. For instance, reserve_stats.pl ignores these holds because it filters on itemnumber. Is this simply a bug or are there circumstances that this behavior is preferred? In other words, should we fix reserve_stats.pl and other code that assumes the itemnumber or should we fix MoveReserve/$hold->fill ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:49:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 10:49:31 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-PWXThm6YaN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151487|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151506&action=edit Bug 33786: ILL requests table id Make sure requests table is unique when visiting patron ILL history so the table state is not shared unintentionally -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:52:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 10:52:01 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-3OXAcKlM1x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 --- Comment #3 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- I'm happy with this patch, extra eyes on it are welcome. Thank you Tomas for your suggestion re making the requests table id unique, it does fix the issue and we can keep the stateSave: true this way. Test plan is the same as the steps to reproduce the issue, except the issue should not occur anymore after patch is applied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 12:58:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 10:58:41 +0000 Subject: [Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold In-Reply-To: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33791-70-uzYWwFhCJn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Interestingly, CheckReserves puts the given itemnumber (from the checkout) into its highest reserve of the result: $highest->{'itemnumber'} = $item->itemnumber; But MoveReserves does ignore it in the $res (==$highest) hash: if ($res->{borrowernumber} == $borrowernumber) { my $hold = Koha::Holds->find( $res->{reserve_id} ); $hold->fill; So it may have worked, and was perhaps undone by refactoring? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:23:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:23:27 +0000 Subject: [Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold In-Reply-To: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33791-70-9DRsTQFhsy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151507&action=edit Bug 33791: Pass itemnumber to $hold->fill Test plan: Without this patch: Place next available level on some book for patron A. Checkout this book directly to patron A. Check old_reserves table for this reserve; does not have itemnumber. With this patch: Do the same. In old_reserves the itemnumber should be saved. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:23:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:23:41 +0000 Subject: [Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold In-Reply-To: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33791-70-KXjdSnZN7J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:23:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:23:51 +0000 Subject: [Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold In-Reply-To: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33791-70-BYKnPCdxEs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:39:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:39:13 +0000 Subject: [Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold In-Reply-To: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33791-70-DzippMkf0l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:39:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:39:15 +0000 Subject: [Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold In-Reply-To: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33791-70-0yBLrZVIK5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151508&action=edit Bug 33791: Add unit test Test plan: Run t/db_dependent/Koha/Hold.t NOTE: This test should fail without following patch, but pass with it. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:39:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:39:17 +0000 Subject: [Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold In-Reply-To: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33791-70-IxRTLrVsyS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151507|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151509&action=edit Bug 33791: Pass itemnumber to $hold->fill Test plan: Without this patch: Place next available level on some book for patron A. Checkout this book directly to patron A. Check old_reserves table for this reserve; does not have itemnumber. With this patch: Do the same. In old_reserves the itemnumber should be saved. Run again t/db_dependent/Koha/Hold.t. Should pass. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:39:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:39:49 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-dBhocneSLP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:39:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:39:51 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-og0J1eJTCY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151510&action=edit Bug 33404: (bug 19436 follow-up) Save the original encoded record This patch restores previous behavior of storing the record as received from the source with the original encoding. We store the encoding in the DB as well, but save the record converted to UTF8 - this means that when we try to display and convert to UTF8 again, we mangle the record While providing a test plan, it requires a MARC8 Authority source, and I cannot locate an open one. This change can be verified by reading the code. There are no unit tests for Z3950SearchAuth, but it does too much and requires many mocks, this is a small fix to a reversion and should be able to move forward. To test: 1 - Search a Z39 authority server that has MARC8 (or non utf8) records 2 - Find a record with diacritics in the record 3 - Import it 4 - Note diacritics are mangled 5 - Apply patch, restart_all 6 - Perform a new Z3950 search (to ensure record is not already in reservoir) 7 - Find a record with diacritics 8 - Import it 9 - Note diacritics correctly encoded -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:40:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:40:23 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-iEP0ycp53J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151506|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151511&action=edit Bug 33786: ILL requests table id Make sure requests table is unique when visiting patron ILL history so the table state is not shared unintentionally -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:47:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:47:01 +0000 Subject: [Koha-bugs] [Bug 33787] Remove option to archive system debit types In-Reply-To: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33787-70-c5AbZP4x6a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:47:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:47:03 +0000 Subject: [Koha-bugs] [Bug 33787] Remove option to archive system debit types In-Reply-To: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33787-70-8WBrZSb1R6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151505|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151512&action=edit Bug 33787: Fix for regression caused by bug 32450 This patch fixes the regression cashed by bug 32450 where we accidentally introduced the option to archive system debit types. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:50:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:50:37 +0000 Subject: [Koha-bugs] [Bug 33792] New: reserves_stats.pl ignores filled holds without itemnumber Message-ID: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 Bug ID: 33792 Summary: reserves_stats.pl ignores filled holds without itemnumber Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See also 33791 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:50:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:50:46 +0000 Subject: [Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber In-Reply-To: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33792-70-rL8LCknmCZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33791 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:50:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:50:46 +0000 Subject: [Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold In-Reply-To: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33791-70-aEwfXfOee8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33792 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:52:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:52:33 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl needs overhaul In-Reply-To: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23059-70-HA2iZ1pBlG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:52:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:52:45 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl needs overhaul In-Reply-To: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23059-70-INeXgorTGA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33792 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:52:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:52:45 +0000 Subject: [Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber In-Reply-To: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33792-70-xMXqanlQgP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23059 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:57:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:57:47 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl needs overhaul In-Reply-To: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23059-70-XwUs0CHlOk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- When you do not confirm a hold, Koha stored it without itemnumber in old holds when directly checking out to same patron. These filled holds are not taken into consideration in statistics. See further 33791/33792. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:58:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:58:38 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-QjuTAzz0FY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:58:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:58:38 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-U2Sl9SVInU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30719 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 [Bug 30719] ILL should provide the ability to create batch requests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:59:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:59:48 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-wt5Pzdb1Xj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151308|0 |1 is obsolete| | --- Comment #66 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151513&action=edit Bug 30719: DB and API - Adds 'batch' accessor to Illrequest object - New illbatches and illbatch_statuses tables - New foreign key 'batch_id' in illrequests table - Atomic update file - Default illbatch_statuses - Add 'add' ill_requests api method - Add POST method in ill_requests path - Add 'batch_id property to ill_request api definition - Updated swagger.yml with new batches and batchstatuses endpoints Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:59:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:59:51 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-RlQUMrzQP3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151309|0 |1 is obsolete| | --- Comment #67 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151514&action=edit Bug 30719: ILL Batches - Add batch column to requests table - Establish if there are any availability or metadata enrichment plugins and pass that to the template - Verify if we have any backend that can support batches, if not, don't show the option - Updates to the ILL toolbar - New ILL batch modal - New Koha classes - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:59:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:59:54 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-96B6FhHpNi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151310|0 |1 is obsolete| | --- Comment #68 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151515&action=edit Bug 30719: ILL Batch Statuses - UI adding support for batch statuses in batch UI - Admin UI for managing batch statuses - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 13:59:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 11:59:57 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-DuTcSqNuCe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151311|0 |1 is obsolete| | --- Comment #69 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151516&action=edit Bug 30719: Tests Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:00:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 12:00:00 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-991HrWoNw1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151312|0 |1 is obsolete| | --- Comment #70 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151517&action=edit Bug 30719: dbic specific, DONT PUSH -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:13:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 12:13:06 +0000 Subject: [Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber In-Reply-To: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33792-70-VK2ssC83dy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Actually, it is caused by looking at homebranch/holdingbranch in the where: items.homebranch LIKE ? AND items.holdingbranch LIKE ? And since there is no item, there is no branch.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:15:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 12:15:40 +0000 Subject: [Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber In-Reply-To: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33792-70-xqib2nebFA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- And as mentioned on bug 23059, you can deselect that filter. But it does not work very intuitive. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:39:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 12:39:33 +0000 Subject: [Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber In-Reply-To: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33792-70-TFQ8ffttZV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:39:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 12:39:35 +0000 Subject: [Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber In-Reply-To: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33792-70-TalVL3inkL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151518&action=edit Bug 33792: reserves_stats: Undo homebranch and holdingbranch preselect This preselect cuts off all next available holds that are in reserves, as well as holds filled by checkout without confirm (see 33791). Test plan: Go to reporting. Click Hold statistics. Verify that Holding library and Home library are not selected. Test that you can still filter by one of those. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:40:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 12:40:28 +0000 Subject: [Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber In-Reply-To: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33792-70-TIX1SYupH7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:46:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 12:46:09 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-cZJisEKCph@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Michaela Sieber from comment #11) > (In reply to Jonathan Druart from comment #8) > > Remote branch rebased and a couple of fixes added. > > > > Setting status to Needs Signoff, this is ready to get feedback from testers. > > > Is there a test plan? There is a lot to test here, so it's hard to provide an exhaustive list. The idea is to catch bugs I have missed. You need to play with: * datatable features (column visibility, sorting, filtering, show/hide filters) * sysprefs SeparateHoldings and SeparateHoldingsBranch * syspref StaffDetailItemSelection * the different action links (when you select at least one item) * item cover images * item groups (EnableItemGroups) * bundles of items (there is still a FIXME to display the 'Manage bundle' button) * display of other values (recall, status, holds, checkout and renewal count, URIs) * host records * course reserves * analytic (this is still a FIXME) * print label button (SpineLabelShowPrintOnBibDetails) * edit permissions will show the edit buttons * and the other things I have missed in this list? :) In the code there are still FIXMEs: * display library names instead of codes * desk name is not displayed anymore * checkout due date is not correctly formatted * other technical ones for QA. > btw: it is not possible to test the patch in a sandbox > http://staff-b33568.sandboxes.ptfs-europe.co.uk/ > > Error: > Template process failed: undef error - C4::Koha::GetAuthorisedValues(): DBI > Exception: DBD::mysql::st execute failed: 'koha_b32748.av.category' isn't in > GROUP BY at /kohadevbox/koha/Koha/Template/Plugin/AuthorisedValues.pm line 39 > at /kohadevbox/koha/C4/Templates.pm line 127 There is something wrong going on but it's not related to this patch. The same of the sandbox was 'b33568' but the error is refering to another instance 'b32748'. To test this change you need to pass the info to the remote branch (there was a patch that has been wrongly attached here): 1. Don't pass a bug number 2. Click "advanced options" 3. "Git remote & branch" should be https://gitlab.com/joubu/Koha and bug_33568 I've just tested and it is working, see https://staff-bug33568.sandboxes.biblibre.eu/cgi-bin/koha/catalogue/detail.pl?biblionumber=1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:47:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 12:47:37 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl needs overhaul In-Reply-To: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23059-70-bt8G2Z8WWC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Andrew Fuerste-Henry from comment #0) > Two big issues: > - By default, the wizard sets a value for items.homebranch and > items.holdingbranch. That means it unexpectedly cuts out all bib-level holds > and gives no clear indication that it's done so. You *can* change home and > holding branch to not limit, but it's not intuitive. I submitted a tiny fix for this problem on bug 33792 with a possible major impact on your results :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:49:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 12:49:39 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl needs overhaul In-Reply-To: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23059-70-cWJaE7rDaw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Andrew Fuerste-Henry from comment #0) > > - The wizard splits holds into 5 statuses (Placed, Processed, Pending, > Satisfied, and Cancelled) that aren't used anywhere else in Koha. These > statuses aren't explained without diving into the code and don't match how > we otherwise divide and talk about holds. Yes this is weird code. Will try to improve that a bit. But it wont be the major overhaul you requested. But small steps may bring us further too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:50:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 12:50:50 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling In-Reply-To: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23059-70-oyMfvwnjc2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|reserves_stats.pl needs |reserves_stats.pl: Simplify |overhaul |reserve status handling Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 14:51:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 12:51:03 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling In-Reply-To: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23059-70-K6k8HcxEUh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:04:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:04:19 +0000 Subject: [Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface In-Reply-To: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32677-70-0hAl8EqtYY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- koha-translate has a 'print_installed' routine that is used by the script to know if the language is already installed (and block you with the error you get). It is doing print_installed() { ( ls -1 $KOHA_HOME/$OPAC_TMPL/bootstrap/ ; \ ls -1 $KOHA_HOME/$OPAC_TMPL/prog/ 2> /dev/null ) | \ sort | uniq | \ grep -v -e images -e itemtypeimg -x -e en -e css -e js -e less -e lib } Can you list the 2 directory and confirm that you have es-ES in there? Then call remove and ls again. What's left? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:09:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:09:53 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-SL2lhMtA2W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151513|0 |1 is obsolete| | --- Comment #71 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151519&action=edit Bug 30719: DB and API - Adds 'batch' accessor to Illrequest object - New illbatches and illbatch_statuses tables - New foreign key 'batch_id' in illrequests table - Atomic update file - Default illbatch_statuses - Add 'add' ill_requests api method - Add POST method in ill_requests path - Add 'batch_id property to ill_request api definition - Updated swagger.yml with new batches and batchstatuses endpoints Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:09:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:09:57 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-1y01w42GEd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151514|0 |1 is obsolete| | --- Comment #72 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151520&action=edit Bug 30719: ILL Batches - Add batch column to requests table - Establish if there are any availability or metadata enrichment plugins and pass that to the template - Verify if we have any backend that can support batches, if not, don't show the option - Updates to the ILL toolbar - New ILL batch modal - New Koha classes - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:10:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:10:00 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-Ba45mLXzok@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151515|0 |1 is obsolete| | --- Comment #73 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151521&action=edit Bug 30719: ILL Batch Statuses - UI adding support for batch statuses in batch UI - Admin UI for managing batch statuses - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:10:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:10:03 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-0JT6DC03cd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151516|0 |1 is obsolete| | --- Comment #74 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151522&action=edit Bug 30719: Tests Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:10:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:10:06 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-QDUU1JMM3j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151517|0 |1 is obsolete| | --- Comment #75 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151523&action=edit Bug 30719: dbic specific, DONT PUSH -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:14:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:14:40 +0000 Subject: [Koha-bugs] [Bug 33573] Holds cancellation for waiting holds via the API don't generate a cancellation request In-Reply-To: <bug-33573-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33573-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33573-70-uz4aehNi40@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33573 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:15:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:15:45 +0000 Subject: [Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold In-Reply-To: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33791-70-nfTDfOpwn4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151508|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151524&action=edit Bug 33791: Add unit test Test plan: Run t/db_dependent/Koha/Hold.t NOTE: This test should fail without following patch, but pass with it. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:15:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:15:47 +0000 Subject: [Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold In-Reply-To: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33791-70-iJcbBkRT09@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151509|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151525&action=edit Bug 33791: Pass itemnumber to $hold->fill Test plan: Without this patch: Place next available level on some book for patron A. Checkout this book directly to patron A. Check old_reserves table for this reserve; does not have itemnumber. With this patch: Do the same. In old_reserves the itemnumber should be saved. Run again t/db_dependent/Koha/Hold.t. Should pass. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:15:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:15:58 +0000 Subject: [Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold In-Reply-To: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33791-70-Nr1EqDQIQA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:16:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:16:00 +0000 Subject: [Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold In-Reply-To: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33791-70-UAkr4Hkcf0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151524|0 |1 is obsolete| | Attachment #151525|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151526&action=edit Bug 33791: Add unit test Test plan: Run t/db_dependent/Koha/Hold.t NOTE: This test should fail without following patch, but pass with it. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:16:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:16:07 +0000 Subject: [Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold In-Reply-To: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33791-70-vwJiqvyJqw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151527&action=edit Bug 33791: Pass itemnumber to $hold->fill Test plan: Without this patch: Place next available level on some book for patron A. Checkout this book directly to patron A. Check old_reserves table for this reserve; does not have itemnumber. With this patch: Do the same. In old_reserves the itemnumber should be saved. Run again t/db_dependent/Koha/Hold.t. Should pass. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:16:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:16:25 +0000 Subject: [Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold In-Reply-To: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33791-70-s3mkiAtcKJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:17:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:17:49 +0000 Subject: [Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold In-Reply-To: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33791-70-vGvvwuwvrE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Looks like Kyle and I both PQA'd on this one simultaneously.. lol.. it's certainly PQA anyways. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:18:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:18:47 +0000 Subject: [Koha-bugs] [Bug 33789] Checkout information is missing when adding a credit In-Reply-To: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33789-70-Uegfv7KoFq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151498|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 151528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151528&action=edit Bug 33789: Return issue info. when adding a credit To test: 1. Make sure MarkLostItemsAsReturned is set so a lost item will stay on a patrons account after being marked as lost. 2. Check an item out to a patron, make sure it has a replacementprice 3. Mark the item as lost. 4. Now check the item in. 5. Go to the patrons account -> transaction tab. You should see 2 accountlines related to the item. 6. For the account type 'Lost item' you will see issue infomation ( check out date, due date, checkouted out from, etc ) 7. For the account type 'Lost item fee refund' there is no issue information. 8. Apply patch 9. Try 2 - 6 again. This time the 'Lost item fee refund' should include issue information. Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:19:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:19:00 +0000 Subject: [Koha-bugs] [Bug 33789] Checkout information is missing when adding a credit In-Reply-To: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33789-70-AVwR91oQYD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |Laura.escamilla at bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:30:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:30:17 +0000 Subject: [Koha-bugs] [Bug 32932] Re-structure Vue router-links to use "name" instead of urls In-Reply-To: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32932-70-SwG3pJlbST@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149935|0 |1 is obsolete| | --- Comment #40 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 151529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151529&action=edit Bug 32932: Update router to use object references - agreements This patch updates the Vue files for ERM to use router object links rather than urls - this will make it much simpler to maintain the router if urls need to be updated. This first patch only updates the files in the agreements section of ERM as a first step to introduce the topic for discussion. Test plan: 1) Apply patch 2) Navigate to the Agreements section of ERM and click on different navigation links/buttons 3) The links/buttons should all work as normal 4) Review the code to see that the component files now refer back to the router using objects rather than url strings Signed-off-by: Agustin Moyano <agustinmoyano at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:42:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:42:43 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-NEtOgvSW8D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:44:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:44:18 +0000 Subject: [Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu In-Reply-To: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33169-70-qysbuMAZOQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:44:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:44:22 +0000 Subject: [Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu In-Reply-To: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33169-70-J1De3X0nex@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149744|0 |1 is obsolete| | --- Comment #12 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 151530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151530&action=edit Bug 33169: Build breadcrumbs and left-hand side menu from routes definition Signed-off-by: Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:45:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:45:13 +0000 Subject: [Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu In-Reply-To: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33169-70-OqVXZOK6zn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #13 from Agustín Moyano <agustinmoyano at theke.io> --- (In reply to Jonathan Druart from comment #11) > There is something broken. > > Uncaught (in promise) Error: Missing required param "license_id" > > To recreate: > 1. Create a license > 2. Go to /cgi-bin/koha/erm/licenses > 3. Click on a license's name Could no reproduce this bug... could you please try again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:57:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:57:02 +0000 Subject: [Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber In-Reply-To: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33792-70-Vd5la3sToL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 15:57:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 13:57:04 +0000 Subject: [Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber In-Reply-To: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33792-70-O3bdQo4s6h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151518|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151531&action=edit Bug 33792: reserves_stats: Undo homebranch and holdingbranch preselect This preselect cuts off all next available holds that are in reserves, as well as holds filled by checkout without confirm (see 33791). Test plan: Go to reporting. Click Hold statistics. Verify that Holding library and Home library are not selected. Test that you can still filter by one of those. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 16:26:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 14:26:06 +0000 Subject: [Koha-bugs] [Bug 33793] New: Add method to define limited access to run reports Message-ID: <bug-33793-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33793 Bug ID: 33793 Summary: Add method to define limited access to run reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: andrewfh at dubcolib.org QA Contact: testopia at bugs.koha-community.org Currently a user with the execute_reports permission can run any report in the system. A library may wish for a given user to be able run some reports but not others. It would be great to have a mechanism for allowing limited reports access. Maybe something akin to the SubfieldsToAllowForRestrictedEditing preference? We could create ReportGroupsToAllowForRestrictedExecution, in which one selects groups of reports. We add a new execute_reports_restricted permission. A user with that permission can only run reports in the groups specified in the preference. Or maybe ditch the system preference and add a "restricted access" flag to each report? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 16:26:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 14:26:29 +0000 Subject: [Koha-bugs] [Bug 33793] Add method to define limited access to run reports In-Reply-To: <bug-33793-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33793-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33793-70-4nJLUSJyJA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33793 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 16:28:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 14:28:31 +0000 Subject: [Koha-bugs] [Bug 33793] Add method to define limited access to run reports In-Reply-To: <bug-33793-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33793-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33793-70-T7Iocz1Cr3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33793 Michelle Spinney <mspinney at clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 16:38:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 14:38:55 +0000 Subject: [Koha-bugs] [Bug 33793] Add method to define limited access to run reports In-Reply-To: <bug-33793-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33793-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33793-70-fdEAC0Y9Js@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33793 --- Comment #1 from Michelle Spinney <mspinney at clamsnet.org> --- This would be very helpful for consortia. We'd like staff to run specific reports created for their library. Right now they can run network wide reports any time which can slow down our system during peak hours. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 16:47:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 14:47:26 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: <bug-29869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29869-70-QEKfh4pnbn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33791 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 16:47:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 14:47:26 +0000 Subject: [Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold In-Reply-To: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33791-70-MrzILAu1RN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29869 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 [Bug 29869] Add Koha::Hold->fill -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:10:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:10:25 +0000 Subject: [Koha-bugs] [Bug 32765] Transfer is not retried after cancelling hold In-Reply-To: <bug-32765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32765-70-OFVtPQ5aJl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau at gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:12:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:12:32 +0000 Subject: [Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers In-Reply-To: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33761-70-mbN8hv2iaA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Amanda Campbell <acampbell at hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell at hmcpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:16:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:16:19 +0000 Subject: [Koha-bugs] [Bug 33794] New: Holds Queue builder skips least cost branch unless target item's homebranch is patron's homebranch Message-ID: <bug-33794-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Bug ID: 33794 Summary: Holds Queue builder skips least cost branch unless target item's homebranch is patron's homebranch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The line next if $request->{borrowerbranch} ne $item->{homebranch}; has been in the holds queue builder since the very beginning, with no explanation. My justification for this line is that we would prefer to send an item to a patron whose home library is the same is the item's home library, assuming that patron will return the item at that library, thus reducing transportation costs. I will not argue here if this is a good feature or not. Bug 31557 makes in configurable, but perhaps it should have an 'off' feature as well. This feature does not make sense when using the transport cost matrix. We get the lowest cost branch, and then if the branches don't match we just move on the the "fall back to basics code". This line should be removed from the code section dealing with the transport cost matrix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:16:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:16:38 +0000 Subject: [Koha-bugs] [Bug 33794] Holds Queue builder skips least cost branch unless target item's homebranch is patron's homebranch In-Reply-To: <bug-33794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33794-70-46U9PBLYyr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |Laura.escamilla at bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:20:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:20:21 +0000 Subject: [Koha-bugs] [Bug 33795] New: Holds Queue builder should do cheap checks before expensive checks Message-ID: <bug-33795-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795 Bug ID: 33795 Summary: Holds Queue builder should do cheap checks before expensive checks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The holds queue builder runs many checks in a somewhat arbitrary order. We should order those checks such that the most expensive checks are at the end and can be avoided if a faster check fails. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:20:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:20:25 +0000 Subject: [Koha-bugs] [Bug 33795] Holds Queue builder should do cheap checks before expensive checks In-Reply-To: <bug-33795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33795-70-UsR2aJJ9DA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:20:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:20:31 +0000 Subject: [Koha-bugs] [Bug 33795] Holds Queue builder should do cheap checks before expensive checks In-Reply-To: <bug-33795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33795-70-iExV34OJnF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 [Bug 33794] Holds Queue builder skips least cost branch unless target item's homebranch is patron's homebranch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:20:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:20:31 +0000 Subject: [Koha-bugs] [Bug 33794] Holds Queue builder skips least cost branch unless target item's homebranch is patron's homebranch In-Reply-To: <bug-33794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33794-70-kexgxbUDRT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33795 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795 [Bug 33795] Holds Queue builder should do cheap checks before expensive checks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:21:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:21:24 +0000 Subject: [Koha-bugs] [Bug 33795] Holds Queue builder should do cheap checks before expensive checks In-Reply-To: <bug-33795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33795-70-mqRrcghXQQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:23:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:23:21 +0000 Subject: [Koha-bugs] [Bug 33796] New: Holds Queue builder never looks at any but the least cost branch of the transport cost matrix Message-ID: <bug-33796-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33796 Bug ID: 33796 Summary: Holds Queue builder never looks at any but the least cost branch of the transport cost matrix Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If for some reason all the items from the least cost branch fail ( can't be transferred, fail the hold policy, non-matching itemtype filter, etc ), Koha does not check the next cheapest branch, but instead moves onto the "fall back to basics" code. We should loop over all the branches from least costly to most costly to find the least costly items that can be used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:44:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:44:23 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-5KsY9C0QqD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:44:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:44:36 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-x876V8dkev@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement enables |This bugfix enables the use release notes|the use of framework |of framework plugins when: |plugins when: |- |- |`UseACQFrameworkForBiblioRe |`UseACQFrameworkForBiblioRe |cords` is enabled, and |cords` is enabled, and |- |- |entering catalog details |entering catalog details |when adding items to a |when adding items to a |basket from a new (empty) |basket from a new (empty) |record. |record. |This requires |This requires |plugins to be enabled for |plugins to be enabled for |fields in the `ACQ` |fields in the `ACQ` |framework. |framework. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:45:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:45:25 +0000 Subject: [Koha-bugs] [Bug 32990] Possible deadlock in C4::ImportBatch::_update_batch_record_counts In-Reply-To: <bug-32990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32990-70-LJ1SIJWGJA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32990 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:46:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:46:03 +0000 Subject: [Koha-bugs] [Bug 32992] Move background worker script to misc/workers In-Reply-To: <bug-32992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32992-70-VTVeXpSvKv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32992 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:46:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:46:23 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff interface catalog details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-dPOilGUIvn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:47:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:47:23 +0000 Subject: [Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL In-Reply-To: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32357-70-4yOD0l1njZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:48:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:48:09 +0000 Subject: [Koha-bugs] [Bug 32766] Update plugin unimarc_field_116.pl fields In-Reply-To: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32766-70-j32PJdHQTg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32766 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:48:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:48:29 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-rThiSkkbdA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:48:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:48:56 +0000 Subject: [Koha-bugs] [Bug 33699] Typo in identity_provider_domains.tt (presedence) In-Reply-To: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33699-70-6vNdlsS5Qe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:51:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:51:25 +0000 Subject: [Koha-bugs] [Bug 33170] Refactor MarcItemFieldsToOrder code to make adding more fields simpler In-Reply-To: <bug-33170-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33170-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33170-70-MVjM9E12yT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33170 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147963|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 151534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151534&action=edit Bug 33170: Refactor MARCItemFieldsToOrder to make adding more fields trivial There is no need for this code to have a hard coded list of fields directly in the code. Any invalid keys would be skipped anyway. If we refactor this code then adding new fields will be much simpler. Test Plan: 1) Set up your MARCItemFieldsToOrder, verify everything is working 2) Apply this patch 3) Restart all the things! 4) Verify there has been no change to the MARCItemFieldsToOrder functionality Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:51:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:51:36 +0000 Subject: [Koha-bugs] [Bug 33170] Refactor MarcItemFieldsToOrder code to make adding more fields simpler In-Reply-To: <bug-33170-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33170-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33170-70-W4SCzeAsoa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33170 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:53:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:53:03 +0000 Subject: [Koha-bugs] [Bug 33795] Holds Queue builder should do cheap checks before expensive checks In-Reply-To: <bug-33795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33795-70-qaPoHdsrRp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33796 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33796 [Bug 33796] Holds Queue builder never looks at any but the least cost branch of the transport cost matrix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:53:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:53:03 +0000 Subject: [Koha-bugs] [Bug 33796] Holds Queue builder never looks at any but the least cost branch of the transport cost matrix In-Reply-To: <bug-33796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33796-70-qPGSzgHX2p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33796 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33795 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795 [Bug 33795] Holds Queue builder should do cheap checks before expensive checks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:53:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:53:13 +0000 Subject: [Koha-bugs] [Bug 33021] Show an alert when adding an item on hold to an item bundle In-Reply-To: <bug-33021-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33021-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33021-70-tKzc98laEE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:54:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:54:03 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-QW32cKjnIx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:54:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:54:25 +0000 Subject: [Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin In-Reply-To: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25379-70-iBlxWuszfV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:55:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:55:11 +0000 Subject: [Koha-bugs] [Bug 33336] Use a dedicated column for plugin status in plugins table In-Reply-To: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33336-70-kOLpqVEN4w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 17:58:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 15:58:13 +0000 Subject: [Koha-bugs] [Bug 33171] Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder In-Reply-To: <bug-33171-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33171-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33171-70-4XYHXlW3VH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org --- Comment #3 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- Don't forget to add these fields to the list of supported values in the syspref description, please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 18:24:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 16:24:22 +0000 Subject: [Koha-bugs] [Bug 33795] Holds Queue builder should do cheap checks before expensive checks In-Reply-To: <bug-33795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33795-70-Y6YLzbMHXw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 18:24:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 16:24:23 +0000 Subject: [Koha-bugs] [Bug 33795] Holds Queue builder should do cheap checks before expensive checks In-Reply-To: <bug-33795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33795-70-JFnE5GHDjG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151535&action=edit Bug 33795: Holds Queue builder should do cheap checks before expensive checks The holds queue builder runs many checks in a somewhat arbitrary order. We should order those checks such that the most expensive checks are at the end and can be avoided if a faster check fails. Test Plan: 1) prove t/db_dependent/HoldsQueue.t 2) Apply this patch 3) prove t/db_dependent/HoldsQueue.t 4) Tests still pass! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 18:26:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 16:26:14 +0000 Subject: [Koha-bugs] [Bug 31627] Add ability to embed the letter ID in outgoing email notices In-Reply-To: <bug-31627-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31627-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31627-70-zjylJax1fA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 18:26:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 16:26:16 +0000 Subject: [Koha-bugs] [Bug 31627] Add ability to embed the letter ID in outgoing email notices In-Reply-To: <bug-31627-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31627-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31627-70-CeqeaCCp0m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142826|0 |1 is obsolete| | --- Comment #15 from Sam Lau <samalau at gmail.com> --- Created attachment 151536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151536&action=edit Bug 31627: Add ability to embed the letter id in outgoing email notices It can be useful to know exactly what template was used to generate a notice. To further this end, it would be useful be able to send the letter id as part of any emails sent out if there is a letter template associated with the message. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Enable SendLetterIdInEmailNotices 4) Generate an email notice like a checkout notice 5) Note your email has the letter id at the bottom! Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 18:26:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 16:26:19 +0000 Subject: [Koha-bugs] [Bug 31627] Add ability to embed the letter ID in outgoing email notices In-Reply-To: <bug-31627-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31627-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31627-70-ZHDMas7w06@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143022|0 |1 is obsolete| | --- Comment #16 from Sam Lau <samalau at gmail.com> --- Created attachment 151537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151537&action=edit Bug 31627: (followup) Hide id for HTML messages Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 18:33:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 16:33:54 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: <bug-28491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28491-70-SbG7nXgcaP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 --- Comment #28 from Heather <heather_hernandez at nps.gov> --- IMO, there really is no way to "misuse" an 035 field--a number in the 035 field is simply a number that is not the current/valid system control number, but is a number to be retained. (Retaining control numbers being a very good idea, IMO!) Putting a number that is valid in all the other systems and catalogs in the universe except for the one that the record is in right now is a perfectly valid and IMO very good use of the 035. 035s sure can mean, "I'm personally not currently using this number in 001." Also, IMO, there is no way to accurately trace source(s) of records. Records flow through systems, they are shared--that is really the point of cataloging according to standards, so the records can be shared. IMO.:) Figuring out which human or process imported a record into a catalog (the source of a record) works great for bibs in Koha--I can take a look a bib in the Advanced Bibliographic Editor and see in the information in the 945 field. (e.g., "Connexion Client User"--that's me!) And there are logs. If there were an Advanced Authority Editor I would probably be able to see the source of any authority record in a 945 field, but that's another bug/development...:) The MARC21 standard for authority records is that 001/003 work in tandem. It works great for bibs. IMO it should work the same for auts. The source of a bib in Koha is in the locally-defined 945 and works great; it should be the same for auts (and maybe it is?). If libraries are using the 003 for a source of a record, that is OK *if* it is functionally paired with the record number in the 001, but IMO is duplicating information that *should* be present in a 945 (that should be visible.) (Maybe there is a way to make a 945 visible in an aut record framework, but I don't see any authority record framework in the MARC frameworks, but, again, probably another bug!) I wish this had gone ahead as was signed off in 2021: if a library wants a different number in the 001 then the replaced number in the 001 and the therefore obsolute org code in the 003 is mapped to a $z in the 035, e.g., $z (ReplacedOrgCode)ReplacedNumber And the source of the record could be, as in bibs, in a locally-defined 945 field to serve the functionality for libraries who need the source of the record tracked in the record as is done in bibs. --h2, who always has *some* sort of cataloging-informed opinion!:) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 18:52:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 16:52:14 +0000 Subject: [Koha-bugs] [Bug 33796] Holds Queue builder never looks at any but the least cost branch of the transport cost matrix In-Reply-To: <bug-33796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33796-70-gBFK76tKLy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33796 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Depends on|33795 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795 [Bug 33795] Holds Queue builder should do cheap checks before expensive checks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 18:52:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 16:52:14 +0000 Subject: [Koha-bugs] [Bug 33795] Holds Queue builder should do cheap checks before expensive checks In-Reply-To: <bug-33795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33795-70-f6isP62nvE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33796 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33796 [Bug 33796] Holds Queue builder never looks at any but the least cost branch of the transport cost matrix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:01:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 17:01:35 +0000 Subject: [Koha-bugs] [Bug 33797] New: Extra space in supplier.tt Message-ID: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797 Bug ID: 33797 Summary: Extra space in supplier.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:05:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 17:05:17 +0000 Subject: [Koha-bugs] [Bug 33797] Extra space in supplier.tt In-Reply-To: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33797-70-B5J9YrC8sB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797 --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151538&action=edit Bug 33797: Remove extra space Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:05:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 17:05:28 +0000 Subject: [Koha-bugs] [Bug 33797] Extra space in supplier.tt In-Reply-To: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33797-70-CGOHjxp4Fs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |tomascohen at gmail.com CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:42:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 17:42:56 +0000 Subject: [Koha-bugs] [Bug 33793] Add method to define limited access to run reports In-Reply-To: <bug-33793-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33793-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33793-70-Dc0EB7vKvW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33793 Eileen Chandler <echandler at clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |echandler at clamsnet.org --- Comment #2 from Eileen Chandler <echandler at clamsnet.org> --- This would be great improvement for our consortium and I would imagine for any larger library system too. We want to empower library staff to run reports but we'd also like our consortium-wide reports to be accessible only to our consortium/network staff. Consortium wide reports are resource intensive and we run those in "off" hours. If library staff had access to a set of reports just for their location it would be more efficient and effective. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:45:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 17:45:17 +0000 Subject: [Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold In-Reply-To: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33791-70-kOrIo9os7a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 --- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151539&action=edit Bug 33791: (QA follow-up) Stick to 'item_id' for the parameter name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:46:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 17:46:10 +0000 Subject: [Koha-bugs] [Bug 33774] Loading club table in every tab in patron details In-Reply-To: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33774-70-xHUWp95O0b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:46:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 17:46:13 +0000 Subject: [Koha-bugs] [Bug 33774] Loading club table in every tab in patron details In-Reply-To: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33774-70-73dD9Cwpvo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:46:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 17:46:15 +0000 Subject: [Koha-bugs] [Bug 33787] Remove option to archive system debit types In-Reply-To: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33787-70-0r0DJgCLHa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:46:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 17:46:17 +0000 Subject: [Koha-bugs] [Bug 33787] Remove option to archive system debit types In-Reply-To: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33787-70-7X2HFhPE8Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:46:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 17:46:19 +0000 Subject: [Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold In-Reply-To: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33791-70-gFUaT7WzZP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:46:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 17:46:21 +0000 Subject: [Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold In-Reply-To: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33791-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33791-70-dtNn0qjAHZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 --- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:48:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 17:48:40 +0000 Subject: [Koha-bugs] [Bug 32767] Trimming of attribute types by wish (if enabled) In-Reply-To: <bug-32767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32767-70-4iKlzyB378@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32767 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 19:48:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 17:48:42 +0000 Subject: [Koha-bugs] [Bug 32767] Trimming of attribute types by wish (if enabled) In-Reply-To: <bug-32767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32767-70-czxq2k8Fhf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32767 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145846|0 |1 is obsolete| | --- Comment #3 from Sam Lau <samalau at gmail.com> --- Created attachment 151540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151540&action=edit Bug 32767: New feature that trims attributes (if enabled) to avoid duplicates Added a new "Trim identifier:" checkbox for attribute editor page, that if enabled, will trim the value from any trailing whitespaces. The use case for this feature is to avoid unintentionally creating duplicate attribute values with trailing whitespaces around of it. If this checkbox is grayed for you, that means that you have some values surrounded with whitespaces, and Koha can't decide for you which you want to remove and when (because that as well will lead to creating duplicated entries). So in order to use this feature you first need to clean up your database from already existing values with trailing whitespaces. This SQL query might help you find all untrimmed attributes & borrowers: ```SELECT * FROM borrower_attributes WHERE code=%Attribute Name% AND attribute REGEXP "^\\s+|\\s+$";``` Steps to reproduce: 1. Go to the attribute editor page. Check if the "Trim identifier:" checkbox is not grayed. (if it is grayed, it means you have some values surrounded with whitespaces, in that case you need to fix them manually) 2. Check the checkbox and save settings. 3. Add that attribute for a preferred patron, enter some value with a trailing whitespaces around of it. 4. Check that the trailing whitespaces were trimmed correctly. Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 20:12:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 18:12:03 +0000 Subject: [Koha-bugs] [Bug 33755] Profile used is not saved when importing records In-Reply-To: <bug-33755-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33755-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33755-70-DcagULzk9L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33755 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 20:33:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 18:33:09 +0000 Subject: [Koha-bugs] [Bug 33796] Holds Queue builder never looks at any but the least cost branch of the transport cost matrix In-Reply-To: <bug-33796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33796-70-y7gMf5utA7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33796 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151541&action=edit Bug 33796: Holds Queue builder should check more than just least cost branch for TCM If for some reason all the items from the least cost branch fail ( can't be transferred, fail the hold policy, non-matching itemtype filter, etc ), Koha does not check the next cheapest branch, but instead moves onto the "fall back to basics" code. We should loop over all the branches from least costly to most costly to find the least costly items that can be used. Test Plan: 1) Set up TCM so it's cheapest to transport item from A to C than from B to C. 2) Place hold for record with items at A and B, for pick at C 3) Disable transfer from A to C 4) Build the holds queue 5) Note the B item was selected over other more costly items, but not the less costly A item ( which cannot be transferred ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 20:33:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 18:33:55 +0000 Subject: [Koha-bugs] [Bug 32464] Koha::Item->as_marc_field obsolete option mss In-Reply-To: <bug-32464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32464-70-KOsu8jMmk9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32464 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 20:33:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 18:33:57 +0000 Subject: [Koha-bugs] [Bug 33796] Holds Queue builder never looks at any but the least cost branch of the transport cost matrix In-Reply-To: <bug-33796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33796-70-tLjJ0Lw14G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33796 --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Unit tests are failing, but are so complicated I cannot figure out how to fix them! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 20:33:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 18:33:57 +0000 Subject: [Koha-bugs] [Bug 32464] Koha::Item->as_marc_field obsolete option mss In-Reply-To: <bug-32464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32464-70-t9skARzPgn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32464 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144604|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151542&action=edit Bug 32464: Koha::Item->as_marc_field obsolete option mss Since Bug 28445 the method Koha::Item->as_marc_field has the option mss not anymore. This patch removes this in Koha::Filter::MARC::EmbedItems. Test with : prove t/db_dependent/Koha/Filter/EmbedItems.t Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 20:34:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 18:34:00 +0000 Subject: [Koha-bugs] [Bug 32464] Koha::Item->as_marc_field obsolete option mss In-Reply-To: <bug-32464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32464-70-rT5pUmHvNa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32464 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144608|0 |1 is obsolete| | --- Comment #18 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151543&action=edit Bug 32464: (follow-up) fix t/db_dependent/Koha/Item.t Remove useless unit tests with mss arg Test with : prove t/db_dependent/Koha/Filter/EmbedItems.t Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 20:45:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 18:45:51 +0000 Subject: [Koha-bugs] [Bug 32766] Update plugin unimarc_field_116.pl fields In-Reply-To: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32766-70-iz9ONAdakn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32766 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates the labels for release notes| |some values so that they | |match with the definitions | |in UNIMARC Bibliographic | |(3rd ed.) Updates, and to | |help with translation: | | | |- | |Specific material | |designation: | | i- print | |(no change in display) | | m- | |master -> m- mould | | | |- | |Techniques (drawings, | |paintings) 1, 2, and 3: | | | |crayon -> charcoal | | | |- | |Technique (prints) 1,2, and | |3: | | Label for dropdown | |list changed to Techniques | |(print) 1, 2, and 3 | | | |camaiu -> cameo | | computer | |graphics -> infography | | | |- | |Functional designation | | | |ab- item cover -> ab- | |resource cover | | ag- chart | |-> ag- diagram -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 20:54:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 18:54:41 +0000 Subject: [Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL In-Reply-To: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32357-70-55e1C23g0Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the default release notes| |value in the database for | |the 'Days in advance' field | |for patron messaging | |preferences so that it | |defaults to NULL instead of | |0 | |(borrower_message_preferenc | |es table and the | |days_in_advance field). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 21:36:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 19:36:49 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-RdHJ3Rnz3F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau at gmail.com Status|Needs Signoff |Failed QA --- Comment #61 from Sam Lau <samalau at gmail.com> --- Everything worked fine for me except for Apply formatting to ACCOUNTS_SUMMARY. The formatting stayed the same regardless of what was put under the ACCOUNTS_SUMMARY formatting tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 21:46:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 19:46:43 +0000 Subject: [Koha-bugs] [Bug 29700] Koha performs a second cashup in error when changing registers immediately after cashup In-Reply-To: <bug-29700-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29700-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29700-70-iBwIGq07k9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29700 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #1 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- Increased the severity of this one as it seems likely to be happening to others and is hard to identify when encountered in the wild. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 21:48:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 19:48:04 +0000 Subject: [Koha-bugs] [Bug 33755] Profile used is not saved when importing records In-Reply-To: <bug-33755-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33755-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33755-70-GJmKom67YP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33755 Michelle Spinney <mspinney at clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 21:51:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 19:51:52 +0000 Subject: [Koha-bugs] [Bug 33797] Extra space in supplier.tt In-Reply-To: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33797-70-utRe0uGYmv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 21:51:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 19:51:55 +0000 Subject: [Koha-bugs] [Bug 33797] Extra space in supplier.tt In-Reply-To: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33797-70-mFuURMarCs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151538|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 151546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151546&action=edit Bug 33797: Remove extra space Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 22:03:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 20:03:06 +0000 Subject: [Koha-bugs] [Bug 33797] Extra space in supplier.tt In-Reply-To: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33797-70-wFhCejYtqg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This removes the space release notes| |between the field label and | |the colon for the notes | |field in the interfaces | |section for a vendor's | |details. --- Comment #3 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. Add a new vendor: 1.1 Acquisitions > New vendor 1.2 Enter name of vendor: My vendor name 1.3 In the interfaces section, select 'Add another interface' 1.4 Enter some details: - Name: Test bz33797 - Email: me at example.com - Notes: Some notes! 1.5 Save the new vendor. 1.6 Search for vendors with: my 1.7 In the search results, click 'My vendor name' 1.8 Note that there is an extra space between Notes and the colon in the interfaces section. 2. Apply the patch. 3. Refresh the vendor page: ==> There is now no space between Notes and the colon in the interface section -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 22:06:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 20:06:39 +0000 Subject: [Koha-bugs] [Bug 33772] Header search input no longer has an outline when focused In-Reply-To: <bug-33772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33772-70-a9ETs8rWNR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33772 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #5 from Christopher Brannon <cbrannon at cdalibrary.org> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 22:08:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 20:08:03 +0000 Subject: [Koha-bugs] [Bug 33773] Possible CSS adjustments for the header search usability improvement In-Reply-To: <bug-33773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33773-70-PYl1VwzEj2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33773 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #3 from Christopher Brannon <cbrannon at cdalibrary.org> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 22:14:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 20:14:08 +0000 Subject: [Koha-bugs] [Bug 33772] Header search input no longer has an outline when focused In-Reply-To: <bug-33772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33772-70-YuQYz7vo46@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33772 --- Comment #6 from Christopher Brannon <cbrannon at cdalibrary.org> --- I used Jason's CSS and it worked just fine. Not sure where the problem is Owen. Also, I changed the color to black, as the contrast is not as great with the yellow. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 22:34:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 20:34:21 +0000 Subject: [Koha-bugs] [Bug 33798] New: Vendor details - improve consistency of edit forms and display Message-ID: <bug-33798-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 Bug ID: 33798 Summary: Vendor details - improve consistency of edit forms and display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org For vendor details in acquisitions, there are some inconsistencies in the display of the edit forms and vendor details. This could do with some tidy ups. Specific items: 1. Field labels when displaying vendor details - bold and plain text: for some sections, field labels are in bold, others are just plain text (for example: 'Vendor details' labels are in plain text, for 'Ordering information' they are bold). 2. Edit form for 'Interface details' missing colons after the labels. 2. Accessibility issues: using the WAVE Evaluation Tool browser extension (https://wave.webaim.org/), it shows lots of errors and warnings, such as missing or multiple form labels, and empty buttons and links (some of which may or may not be valid). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 22:34:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 20:34:43 +0000 Subject: [Koha-bugs] [Bug 33798] Vendor details - improve consistency of edit forms and display In-Reply-To: <bug-33798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33798-70-mcgfWM1ucB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 22:39:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 20:39:01 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-pHsc0sRXhV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |david at davidnind.com --- Comment #2 from David Nind <david at davidnind.com> --- Added assignee 8-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 22 23:30:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 21:30:16 +0000 Subject: [Koha-bugs] [Bug 33573] Holds cancellation for waiting holds via the API don't generate a cancellation request In-Reply-To: <bug-33573-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33573-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33573-70-LiauZmiNBA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33573 Rhonda Kuiper <rkuiper at roundrocktexas.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper at roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 23:56:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 21:56:32 +0000 Subject: [Koha-bugs] [Bug 33799] New: Setting default hold type Message-ID: <bug-33799-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33799 Bug ID: 33799 Summary: Setting default hold type Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com With the new grouping option in our holdings, we are now much closer to being able to place different formats in the same record. However, we still need a little work in terms of holds. I can place different formats in the same record, and I can force the holds to specific items, but it may not be the format the patron wants. There are few modifications I would like to see happen: 1) It would be preferable if in the circulation rules, the OPAC item level hold dropdown were changed to multiple choice selections, so we can check if we want to allow any first available, first available in group, or item level, or any combination. 2) There should be a staff side version of these choices as well. We should be able to control the staff's choices as well. 2) We should have the option of pre-selecting an item or not. There needs to be a way to make the patron make a selection, rather than once being made for them. Particularly if patrons might want to get a first available in a group rather than a specific item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 23:57:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 21:57:38 +0000 Subject: [Koha-bugs] [Bug 33799] Setting hold options in circulation rules In-Reply-To: <bug-33799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33799-70-ylcIOxHh7U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33799 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Setting default hold type |Setting hold options in | |circulation rules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 22 23:58:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 21:58:45 +0000 Subject: [Koha-bugs] [Bug 33799] Setting hold options in circulation rules In-Reply-To: <bug-33799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33799-70-D4U2nMSkAw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33799 --- Comment #1 from Christopher Brannon <cbrannon at cdalibrary.org> --- Obviously, that should be 1, 2 and 3 above! 4) We should be able to set which of the selected choices is default when placing a hold. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 00:36:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 22:36:46 +0000 Subject: [Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface In-Reply-To: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32677-70-F0UCkwD8z8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677 --- Comment #14 from Victor Zuniga <vctrzuniga at gmail.com> --- (In reply to Jonathan Druart from comment #13) > koha-translate has a 'print_installed' routine that is used by the script to > know if the language is already installed (and block you with the error you > get). > > It is doing > > print_installed() > { > ( ls -1 $KOHA_HOME/$OPAC_TMPL/bootstrap/ ; \ > ls -1 $KOHA_HOME/$OPAC_TMPL/prog/ 2> /dev/null ) | \ > sort | uniq | \ > grep -v -e images -e itemtypeimg -x -e en -e css -e js -e less -e > lib > } > > Can you list the 2 directory and confirm that you have es-ES in there? > Then call remove and ls again. What's left? Hi Jonathan, Here's the output I'm getting: vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ ls es-ES vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ cd es-ES/ vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog/es-ES$ ls vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog/es-ES$ cd .. vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ rm -rf es-ES/ vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ ls vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ Somehow the only thing left inside the prog folder was an empty es-ES folder. Per your suggestion, I removed and tried to install the Spanish package again. Here is the output I am getting: vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ sudo koha-translate --install es-ES [sudo] password for vzuniga: /usr/share/koha/opac/htdocs/opac-tmpl/prog/en/: Input must be a directory. (Symbolic links are not supported at the moment) Try `/usr/share/koha/misc/translator/tmpl_process3.pl --help for more information. /usr/share/koha/opac/htdocs/opac-tmpl/ccsr/en/: Input must be a directory. (Symbolic links are not supported at the moment) Try `/usr/share/koha/misc/translator/tmpl_process3.pl --help for more information. /usr/share/koha/opac/htdocs/opac-tmpl/prog/en/: Input must be a directory. (Symbolic links are not supported at the moment) Try `/usr/share/koha/misc/translator/tmpl_process3.pl --help for more information. /usr/share/koha/opac/htdocs/opac-tmpl/ccsr/en/: Input must be a directory. (Symbolic links are not supported at the moment) Try `/usr/share/koha/misc/translator/tmpl_process3.pl --help for more information. /usr/share/koha/opac/htdocs/opac-tmpl/prog/en/: Input must be a directory. (Symbolic links are not supported at the moment) Try `/usr/share/koha/misc/translator/tmpl_process3.pl --help for more information. /usr/share/koha/opac/htdocs/opac-tmpl/ccsr/en/: Input must be a directory. (Symbolic links are not supported at the moment) Try `/usr/share/koha/misc/translator/tmpl_process3.pl --help for more information. Connection to the memcached servers '__MEMCACHED_SERVERS__' failed. Are the unix socket permissions set properly? Is the host reachable? If you ignore this warning, you will face performance issues vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ Victor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 01:25:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 May 2023 23:25:13 +0000 Subject: [Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface In-Reply-To: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32677-70-p4ggce2IDe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677 --- Comment #15 from Victor Zuniga <vctrzuniga at gmail.com> --- Hi Jonathan, I noticed I didn't include the instance name so perhaps that's the reason for those error messages. I tried again using the instance name (catalog) at the end of the command and got the following: vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ sudo koha-translate --install es-ES catalog [sudo] password for vzuniga: Error: the selected language is not currently available. vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ sudo koha-translate --update es-ES catalog Error: the selected language is not currently installed. Try --install. vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ sudo koha-translate --install es-ES catalog Error: the selected language is not currently available. vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ I tried the --update and -- install commands respectively with no success. How can I add the language package again? Thanks, Victor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 04:07:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 02:07:26 +0000 Subject: [Koha-bugs] [Bug 33362] Return claims can be un-resolvable if issue_id is set but no issue is found in issues or old_issues In-Reply-To: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33362-70-OX5K4SYq7u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33362 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151492|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Created attachment 151547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151547&action=edit Bug 33362: Allow return claims to be resolved even if the issue has since been delete from the database Test Plan: 1) Check out an item 2) Claim return on it, moving it to the old_issues table 3) Delete the old_issue via koha-mysql or Use cleanup_database.pl 4) Attempt to resolve the claim 5) Note the error 6) Apply this patch set 7) Restart all the things! 8) Attempt to resolve the claim 9) No errors! Signed-off-by: Sam Lau <samalau at gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 04:08:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 02:08:12 +0000 Subject: [Koha-bugs] [Bug 33362] Return claims can be un-resolvable if issue_id is set but no issue is found in issues or old_issues In-Reply-To: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33362-70-k21KhmKDGS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33362 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA --- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 04:19:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 02:19:59 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-8Ue6M3UUCd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 04:20:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 02:20:03 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-nULxpqSpcW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #62 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 151548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151548&action=edit Bug 33478: Make sure formatting is applied to tables in notices This fixes the formatting not showing on ACCOUNTS_SUMMARY and also applies changes to headings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 05:01:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 03:01:21 +0000 Subject: [Koha-bugs] [Bug 33800] New: Error 500 in issues_stats.pl Message-ID: <bug-33800-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33800 Bug ID: 33800 Summary: Error 500 in issues_stats.pl Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: eugenegf at yahoo.com QA Contact: testopia at bugs.koha-community.org We're in Koha 22.11.04 and in "/cgi-bin/koha/reports/borrowers_stats.pl" and just the default "itemtype" and "issuing library" buttons ticked, cell value = count total items and output = "to screen into browser". After submitting, we're getting "Error 500". In the log, we were getting this: [2023/05/23 10:13:49] [WARN] Argument "2023-05-01" isn't numeric in numeric lt (<) at /usr/share/koha/intranet/cgi-bin/reports/issues_stats.pl line 214. [2023/05/23 10:13:49] [WARN] Argument "2023-05-31" isn't numeric in numeric lt (<) at /usr/share/koha/intranet/cgi-bin/reports/issues_stats.pl line 214. This worked in previous Koha ILS version. It seems there is a bug. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 05:33:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 03:33:16 +0000 Subject: [Koha-bugs] [Bug 26611] Required match checks don't work for authority records In-Reply-To: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26611-70-MijmhFILu5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | CC| |aleisha at catalyst.net.nz Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 05:43:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 03:43:21 +0000 Subject: [Koha-bugs] [Bug 26611] Required match checks don't work for authority records In-Reply-To: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26611-70-SQsow2g5Eq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 05:43:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 03:43:23 +0000 Subject: [Koha-bugs] [Bug 26611] Required match checks don't work for authority records In-Reply-To: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26611-70-lEzec7Wgsj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 --- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 151549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151549&action=edit Bug 26611: Make authority record matching use required match checks This patch fixes record matching for authorities to correctly apply required match checks. To test: 1) Create a record matching rule: Threshold: 100 Record type: Authority record Match point 1 Search index: subject-topical Score: 100 Tag: 150 Subfields: a Match check 1 Both source and target record check fields: Tag: 040 Subfields: a This rule says we want to match on the topical term heading, then confirm the match with 040$a. 2) Create two topical term authority records Authority 1: 150$a: Test 040$a: A Authority 2: 150$a: Test 040$a: B 3) Export authority 2 and save 4) Go to Cataloging -> Stage records for import 5) Upload your downloaded authority 2 file. Change the record type to Authority. Choose your new record matching rule. 6) Stage for import. 7) Confirm that with the record matching rule applied, both authorities 1 and 2 show as possible matches, even though only authority 2 has a matching 040$a. 8) Apply the patch and restart services 9) Change the matching rule to "Do not look for matching records" and apply. This is to essentially refresh the page. 10) Change the matching rule to your new matching rule and apply. Confirm only the matching authority 2 shows and is selected. Sponsored-by: Waikato Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 07:10:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 05:10:00 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-ZD7LITjbCE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 --- Comment #2 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 151550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151550&action=edit Bug 28130: [WIP] Manage a patron's subscription alerts Patch in progress -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 07:10:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 05:10:10 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-NfWPYd2bjl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz Change sponsored?|--- |Sponsored Assignee|oleonard at myacpl.org |aleisha at catalyst.net.nz Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 08:29:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 06:29:54 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-jimPjWiDkM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151339|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 08:40:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 06:40:50 +0000 Subject: [Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface In-Reply-To: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32677-70-O8OfOGDFPP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677 --- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Which version of Koha are you using? In recent versions you are not supposed to have 'prog' or 'ccsr' in /usr/share/koha/opac/htdocs/opac-tmpl/ but 'bootstrap'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 08:54:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 06:54:31 +0000 Subject: [Koha-bugs] [Bug 15567] Update API to allow multiple holds for the same record In-Reply-To: <bug-15567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15567-70-aArzVJPDzR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15567 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 08:56:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 06:56:53 +0000 Subject: [Koha-bugs] [Bug 33801] New: Holds API doesn't follow holds policies like the staff/OPAC UIs Message-ID: <bug-33801-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33801 Bug ID: 33801 Summary: Holds API doesn't follow holds policies like the staff/OPAC UIs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au CC: tomascohen at gmail.com The Holds API let you place multiple holds against the same item, while the OPAC and Staff Interface will prevent you from placing a hold on the same item for the same patron twice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 09:24:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 07:24:33 +0000 Subject: [Koha-bugs] [Bug 33734] Using custom search filters breaks scandic characters in search term In-Reply-To: <bug-33734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33734-70-UgS7HxmXdA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33734 Ville Korjus <vilkunpostilaatikko at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |vilkunpostilaatikko at gmail.c | |om Status|NEW |Needs Signoff --- Comment #3 from Ville Korjus <vilkunpostilaatikko at gmail.com> --- Created attachment 151551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151551&action=edit Bug 33734: Use raw filters with search filter links in facets.inc Using html filters breaks scandic characters in search term if one uses custom search filters. Use raw filters instead. To test: 1. Enable SavedSearchFilters syspref 2. Perform search with bib-level:("a") 3. Click "Save search as filter" and save 4. Perform search containing scandic character (åöä) 5. Use filter you just created => notice that scandic characters in search term are displayed incorrectly e.g. ä turns to ä 6. Apply this patch 7. Repeat steps 4 and 5 => scandic characters should now be displayed correctly Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 10:06:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 08:06:57 +0000 Subject: [Koha-bugs] [Bug 33784] Single receive - clicking the Receive link in parcel.pl should lead to the receive form In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-6qWqodydtL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151552&action=edit Bug 33784: Don't display the multi receive form for single receive With bug 8179, a new step was added when receiving a single item. This extra step is not useful and adds clicks for the staff member who is receiving orders. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 10:09:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 08:09:33 +0000 Subject: [Koha-bugs] [Bug 33784] Single receive - clicking the Receive link in parcel.pl should lead to the receive form In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-XrtY0ukFxJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This patch is not ideal but bug 8179 has not designed the code to make it reusable. It must have been moved to a different file (instead of making orderreceive.tt bigger than it was already). We could have displayed the modal from the parcel page. This patch is suggesting to hijack the JS code and click on the "edit" and "save" button. However it does not fully work There is a problem in the following situation: * Receive one and only one order * Don't change the quantity (0) and click "save changes" * Click "cancel" in the warning alert box => There is a .modal-backdrop that is on top of everything, the UI is stuck -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 10:19:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 08:19:33 +0000 Subject: [Koha-bugs] [Bug 33802] New: On OPAC authority detail page, usage count in erroneous Message-ID: <bug-33802-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 Bug ID: 33802 Summary: On OPAC authority detail page, usage count in erroneous Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org On OPAC opac-authoritiesdetail.pl page, usage count is wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 10:20:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 08:20:04 +0000 Subject: [Koha-bugs] [Bug 33802] On OPAC authority detail page, usage count in erroneous In-Reply-To: <bug-33802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33802-70-AZ0ohJEapQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 Frédéric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 10:21:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 08:21:25 +0000 Subject: [Koha-bugs] [Bug 32643] Send patron a notification of a new OPAC note In-Reply-To: <bug-32643-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32643-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32643-70-azmkOuPsJM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32643 Stina Hallin <stina.hallin at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stina.hallin at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 10:23:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 08:23:21 +0000 Subject: [Koha-bugs] [Bug 26608] Authorities: linked biblios is inconsistent using elasticsearch and QueryAutoTruncate In-Reply-To: <bug-26608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26608-70-UoSWXNWPJV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26608 Frédéric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Patch doesn't apply |RESOLVED CC| |frederic at tamil.fr --- Comment #6 from Frédéric Demians <frederic at tamil.fr> --- For me this bug doesn't exist anymore in master, and so, could be closed. In PRO, authorities-home.pl page display valid authorities usage count. On the other hand, a similar issue persists in OPAC: see bug 33802. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 10:40:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 08:40:31 +0000 Subject: [Koha-bugs] [Bug 33802] On OPAC authority detail page, usage count in erroneous In-Reply-To: <bug-33802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33802-70-wNif78JSMG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 --- Comment #1 from Frédéric Demians <frederic at tamil.fr> --- Created attachment 151553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151553&action=edit Bug 33802: On OPAC authority detail page, usage count in erroneous If QueryAutoTruncate is enabled, the biblio usage count of an authority displayed on OPAC may be wrong. This is due to the fact that the authid search being automatically truncated, a search for biblios using authority 22 will retrieved also biblios using authorities 222, 22*. TO TEST: 1. On a Koha with authorities, enable QueryAutoTruncate. 2. Go on opac-authoritiesdetail.pl page for an authority with the lowest possible authid. Let say 1. 3. Confirm that you have a large biblios usage count, and that by clicking on the link to see linked biblios, you get far less biblios than expected. 4. Apply the patch. Repeat 2-3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 10:40:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 08:40:47 +0000 Subject: [Koha-bugs] [Bug 33802] On OPAC authority detail page, usage count in erroneous In-Reply-To: <bug-33802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33802-70-J6aJ09uNRV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 Frédéric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 10:44:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 08:44:21 +0000 Subject: [Koha-bugs] [Bug 33740] Error 500, when editing authority TAG 000 (leader). In-Reply-To: <bug-33740-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33740-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33740-70-YwoDL0z1qx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33740 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Pablo Jones from comment #2) > (In reply to Jonathan Druart from comment #1) > > do you have access to the Koha logs on the server? > > Hi! Joneathan, thanks for answering, yes, I already checked the log files, I > can't find anything related to the error. Run `sudo tail -f /var/log/koha/*/*` on the server then recreate the error. You should see the error appearing in the output. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 10:45:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 08:45:07 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-fwLS34ZY99@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #26 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Matt Blenkinsop from comment #22) > (In reply to Jonathan Druart from comment #19) > > * About the scrollbar hitting top when scrolling down, did you have a look > > at 'more'? https://select2.org/data-sources/ajax#pagination > > There isn't a similar functionality for v-select, I'm trying a different > method using v-autocomplete as a second option. I'll try and finish that > before I go on holiday and see if it offers any improvement What about this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 10:47:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 08:47:50 +0000 Subject: [Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu In-Reply-To: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33169-70-pm9d67WMeq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Agustín Moyano from comment #13) > (In reply to Jonathan Druart from comment #11) > > There is something broken. > > > > Uncaught (in promise) Error: Missing required param "license_id" > > > > To recreate: > > 1. Create a license > > 2. Go to /cgi-bin/koha/erm/licenses > > 3. Click on a license's name > > Could no reproduce this bug... could you please try again? Tried again and still the problem. yes|git bz apply 33169 yarn js:build Create a license Go to /cgi-bin/koha/erm/licenses Open the console Click on a license's name Uncaught (in promise) Error: Missing required param "license_id" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 10:58:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 08:58:53 +0000 Subject: [Koha-bugs] [Bug 33803] New: Some scripts contain info about tab width Message-ID: <bug-33803-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33803 Bug ID: 33803 Summary: Some scripts contain info about tab width Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org We should remove them # WARNING: 4-character tab stops here # Local Variables: # tab-width: 4 # End: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 10:59:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 08:59:24 +0000 Subject: [Koha-bugs] [Bug 33803] Some scripts contain info about tab width In-Reply-To: <bug-33803-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33803-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33803-70-sxYRrcmz0o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33803 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 10:59:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 08:59:27 +0000 Subject: [Koha-bugs] [Bug 33803] Some scripts contain info about tab width In-Reply-To: <bug-33803-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33803-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33803-70-53AwKoXwik@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33803 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151554&action=edit Bug 33803: Remove comment about tab width -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 10:59:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 08:59:36 +0000 Subject: [Koha-bugs] [Bug 33803] Some scripts contain info about tab width In-Reply-To: <bug-33803-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33803-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33803-70-vw3pPKYR92@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33803 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:01:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:01:55 +0000 Subject: [Koha-bugs] [Bug 33797] Extra space in supplier.tt In-Reply-To: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33797-70-W02X539c7x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Depends on| |33104 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 [Bug 33104] Add vendor interfaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:01:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:01:55 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-3y8ua9Uccb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33797 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797 [Bug 33797] Extra space in supplier.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:02:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:02:14 +0000 Subject: [Koha-bugs] [Bug 33797] Extra space in supplier.tt In-Reply-To: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33797-70-r47XC8q0qP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:02:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:02:16 +0000 Subject: [Koha-bugs] [Bug 33797] Extra space in supplier.tt In-Reply-To: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33797-70-lQ82EbGxSL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151546|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151555&action=edit Bug 33797: Remove extra space Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:08:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:08:55 +0000 Subject: [Koha-bugs] [Bug 33762] Restore page-section in ILL In-Reply-To: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33762-70-qdAFs4RhOY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33762 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:08:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:08:57 +0000 Subject: [Koha-bugs] [Bug 33762] Restore page-section in ILL In-Reply-To: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33762-70-d35XAJ96JS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33762 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151400|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151556&action=edit Bug 33762: Fix page-section in ILL Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:09:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:09:03 +0000 Subject: [Koha-bugs] [Bug 27513] Add description to reports page In-Reply-To: <bug-27513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27513-70-fNEnY7Lokn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #11 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- Minor, won't backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:09:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:09:35 +0000 Subject: [Koha-bugs] [Bug 33040] Add "Date published (text)" to serials tab on record view (detail.pl) In-Reply-To: <bug-33040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33040-70-HPR7vZ67k0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33040 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- minor, won't backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:22:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:22:55 +0000 Subject: [Koha-bugs] [Bug 33789] Checkout information is missing when adding a credit In-Reply-To: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33789-70-n2KvJudr2g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Please provide a test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:23:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:23:09 +0000 Subject: [Koha-bugs] [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs In-Reply-To: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29311-70-U9aoDwInJ6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in| |21.11.21 CC| |arthur.suzuki at biblibre.com --- Comment #19 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:24:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:24:43 +0000 Subject: [Koha-bugs] [Bug 27513] Add description to reports page In-Reply-To: <bug-27513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27513-70-1GD8Uh7ZMK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in| |21.11.21 --- Comment #12 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- actually minors should also be backported for oldstable : try and backport regardless of severity. Applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:25:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:25:04 +0000 Subject: [Koha-bugs] [Bug 33040] Add "Date published (text)" to serials tab on record view (detail.pl) In-Reply-To: <bug-33040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33040-70-wMoNxHhmnn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33040 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in| |21.11.21 --- Comment #9 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- actually minors should also be backported for oldstable : try and backport regardless of severity. Applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:30:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:30:37 +0000 Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32301-70-BvpEY3m8eY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in| |21.11.21 --- Comment #18 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:31:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:31:12 +0000 Subject: [Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber In-Reply-To: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33792-70-Y7SXAGqbx3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:31:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:31:15 +0000 Subject: [Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber In-Reply-To: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33792-70-X9kZrxnTu9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151531|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151557&action=edit Bug 33792: reserves_stats: Undo homebranch and holdingbranch preselect This preselect cuts off all next available holds that are in reserves, as well as holds filled by checkout without confirm (see 33791). Test plan: Go to reporting. Click Hold statistics. Verify that Holding library and Home library are not selected. Test that you can still filter by one of those. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:31:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:31:37 +0000 Subject: [Koha-bugs] [Bug 33367] tmp/modified_authorities/README.txt seems useless In-Reply-To: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33367-70-gF79PF95n1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33367 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in| |21.11.21 --- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:36:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:36:58 +0000 Subject: [Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30579-70-cppWnnotJO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #37 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151558&action=edit Bug 30579: Add missing for attribute on label -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:41:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:41:30 +0000 Subject: [Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30579-70-wVpqzpc05O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #38 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- That's better but we should do better in my opinion. First would be to have only 1 "place hold" button maybe? And hide the form when the related radio is not checked? Owen, what do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:45:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:45:52 +0000 Subject: [Koha-bugs] [Bug 33195] Reindent the bibliographic details page In-Reply-To: <bug-33195-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33195-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33195-70-q2Bjmck4YZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Please don't do this, I am currently working heavily on this template, see bug 33568. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:51:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:51:56 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-oxmPb7TMCq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |m.de.rooy at rijksmuseum.nl, | |matthias.meusburger at biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:54:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:54:41 +0000 Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable In-Reply-To: <bug-33323-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33323-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33323-70-oCZa97g5bC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com --- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- doesn't to apply to 21.11. provide a backport if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:56:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:56:22 +0000 Subject: [Koha-bugs] [Bug 33077] Improve ease of translating template title tags In-Reply-To: <bug-33077-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33077-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33077-70-6yHFcM0Mn1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in| |21.11.21 --- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 11:57:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 09:57:03 +0000 Subject: [Koha-bugs] [Bug 32716] update NGINX config examples to increase proxy_buffer_size In-Reply-To: <bug-32716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32716-70-aXMawHifZL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32716 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in| |21.11.21 CC| |arthur.suzuki at biblibre.com --- Comment #9 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 12:00:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 10:00:32 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-5Vw2pTCc8x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate |rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 12:40:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 10:40:13 +0000 Subject: [Koha-bugs] [Bug 33772] Header search input no longer has an outline when focused In-Reply-To: <bug-33772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33772-70-qgwH1gXPHs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33772 --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Christopher Brannon from comment #6) > Not sure where the problem is Owen. Okay cool -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 12:40:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 10:40:52 +0000 Subject: [Koha-bugs] [Bug 33195] Reindent the bibliographic details page In-Reply-To: <bug-33195-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33195-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33195-70-tJKQ9UYOrz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Jonathan Druart from comment #5) > Please don't do this Okay cool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 13:01:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 11:01:06 +0000 Subject: [Koha-bugs] [Bug 33804] New: Implement as_due_date for $date (js-date-format) Message-ID: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 Bug ID: 33804 Summary: Implement as_due_date for $date (js-date-format) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 13:02:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 11:02:07 +0000 Subject: [Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format) In-Reply-To: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33804-70-iza6rz3AwS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151559&action=edit Bug 33804: Add as_due_date option to $date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 13:02:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 11:02:10 +0000 Subject: [Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format) In-Reply-To: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33804-70-bJKx00EyJT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151560&action=edit Bug 33804: Use as_due_date to display due dates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 13:03:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 11:03:37 +0000 Subject: [Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format) In-Reply-To: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33804-70-mvgP73I9xc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Still working on this. We should pass no_tz_adjust to tell dayjs to not adjust the date. We want to display the value from the DB (otherwise 23:59 will be displayed 21:59). We don't deal with datetime correctly, hence the confusion everywhere... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 13:03:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 11:03:49 +0000 Subject: [Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format) In-Reply-To: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33804-70-SDEbImKtsu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 13:04:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 11:04:02 +0000 Subject: [Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format) In-Reply-To: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33804-70-ElRnkCQiii@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the biblio detail view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 13:04:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 11:04:02 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-w5uwCkxgrs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 [Bug 33804] Implement as_due_date for $date (js-date-format) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 13:05:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 11:05:42 +0000 Subject: [Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format) In-Reply-To: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33804-70-RyCKV7rTG7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151560|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151561&action=edit Bug 33804: Use as_due_date to display due dates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 13:13:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 11:13:06 +0000 Subject: [Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format) In-Reply-To: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33804-70-YnZWOlgh9B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- See bug 33568 for another example, where we don't need no_tz_adjust. The value is coming from the REST API. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 13:57:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 11:57:56 +0000 Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in templates In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32127-70-4UuglCHRY1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com --- Comment #18 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- conflicts on 21.11. can't backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:06:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 12:06:55 +0000 Subject: [Koha-bugs] [Bug 33088] background-job-progressbar.js no longer needed in batch_record_modification.tt In-Reply-To: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33088-70-w1I3UNrUim@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33088 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in| |21.11.21 CC| |arthur.suzuki at biblibre.com --- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:09:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 12:09:02 +0000 Subject: [Koha-bugs] [Bug 33375] Advanced editor crashes when using MySQL 8 due to reserved rank keyword In-Reply-To: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33375-70-ErUTB7EFU4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33375 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in| |21.11.21 CC| |arthur.suzuki at biblibre.com --- Comment #10 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:21:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 12:21:59 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31695-70-w3ZxceKK7o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in| |21.11.21 CC| |arthur.suzuki at biblibre.com --- Comment #13 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:22:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 12:22:48 +0000 Subject: [Koha-bugs] [Bug 33509] Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternate holdings In-Reply-To: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33509-70-J6Y7ssn1uJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in| |21.11.21 --- Comment #7 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:25:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 12:25:29 +0000 Subject: [Koha-bugs] [Bug 33238] Error adding suggestion to basket as non-superlibrarian (Bug 29886 follow-up) In-Reply-To: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33238-70-oaHQYdz90n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in| |21.11.21 CC| |arthur.suzuki at biblibre.com --- Comment #10 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:30:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 12:30:29 +0000 Subject: [Koha-bugs] [Bug 33667] 'Copy to all libraries' doesn't work on editing holidays In-Reply-To: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33667-70-gvFM8ExFAP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33667 --- Comment #7 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> --- Created attachment 151562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151562&action=edit Bug 33667: Allow copying holidays to all libraries when editing When editing an existing holiday and checking the "copy to all libraires" checkbox, the other calendars won't get updates. Allow this by first checking if holiday exists in target calendar and if not, add it. To test: 1. Add unique holiday to branch A. 2. Don't check checkbox "Copy to all libraries". 3. Save. 4. Verify the holidays shows on all calendars as a green box. 5. Edit the holiday, now check "Copy to all libraries" and save. => Verify nothing has changed in other calendars: only the green box, no holiday in list on the right 6. Edit again, make a change to description, check checkbox, save. => Verify it's still not showing in the other calendars. 9. Apply this patch. 10. Edit holiday again, check "Copy to all libraries" and save. => Verify holiday is now added to other calendars. 11. Edit again, this time do not copy and save. => Verify holiday was edited just in branch A. 12. Again edit, check and save. => Verify holiday was edited in all libraries. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:30:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 12:30:37 +0000 Subject: [Koha-bugs] [Bug 33667] 'Copy to all libraries' doesn't work on editing holidays In-Reply-To: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33667-70-kGuK1gbku6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33667 Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:37:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 12:37:33 +0000 Subject: [Koha-bugs] [Bug 33805] New: Marking an item as claims returned results in a spinning wheel Message-ID: <bug-33805-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33805 Bug ID: 33805 Summary: Marking an item as claims returned results in a spinning wheel Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: Laura.escamilla at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Marking an item as claims returned in 22.11 results in a spinning wheel that does not resolve itself unless the page is refreshed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:46:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 12:46:17 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11300-70-VROoCjVD75@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 --- Comment #56 from Blou <philippe.blouin at inlibro.com> --- (In reply to Phil Ringnalda from comment #55) > children$xFiction, and $aAlabama$xHistory$yCivil War, 1861-1865 should match > but in a different order $aAlabama$yCivil War, 1861-1865$xHistory should > not). Are you saying subfield order should matter? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:54:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 12:54:26 +0000 Subject: [Koha-bugs] [Bug 33806] New: Overridden checkin date not retained when CircConfirmItemParts enabled Message-ID: <bug-33806-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 Bug ID: 33806 Summary: Overridden checkin date not retained when CircConfirmItemParts enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To test: 1 - Find or add an item with subfield 3 - materials specified 2 - Enable system preference CircConfirmItemParts 3 - Go to Circulation->Checkin 4 - Click the settings button in the input box and enter a checkin date and select the remeber check box 5 - Check in some items, confirm date retained 6 - Checkin the item with the materials specified 7 - Confirm checkin 8 - Note that checkin date is cleared -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:56:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 12:56:07 +0000 Subject: [Koha-bugs] [Bug 33806] Overridden checkin date not retained when CircConfirmItemParts enabled In-Reply-To: <bug-33806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33806-70-Ffvv09Ettm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:56:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 12:56:09 +0000 Subject: [Koha-bugs] [Bug 33806] Overridden checkin date not retained when CircConfirmItemParts enabled In-Reply-To: <bug-33806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33806-70-62cgSl2MHX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151563&action=edit Bug 33806: Retain specified date when confirming item parts at checkin This patch simply adds hidden inputs to the item parts confirm form to ensure specified checkin date is retained To test: 1 - Find or add an item with subfield 3 - materials specified 2 - Enable system preference CircConfirmItemParts 3 - Go to Circulation->Checkin 4 - Click the settings button in the input box and enter a checkin date and select the remeber check box 5 - Check in some items, confirm date retained 6 - Checkin the item with the materials specified 7 - Confirm checkin 8 - Note that checkin date is cleared 9 - Apply patch 10 - Repeat 3-7 11 - Confirm date is retained -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 14:56:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 12:56:27 +0000 Subject: [Koha-bugs] [Bug 33806] Overridden checkin date not retained when CircConfirmItemParts enabled In-Reply-To: <bug-33806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33806-70-u1sHlUSPJA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:02:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 13:02:19 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-LlHcc87E3C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #93 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I have a use case on bug 33568 where I need at least the library of the patron, to display "a patron from LIBRARY". Bug 29275 has the same problem I think: + if ( row.patron != null ) { + return $patron_to_html( row.patron, { display_cardnumber: true, url: true } ); + } + else { + return _("A patron from library %s").format(escape_str(row.library.name)); + } We need patron.library.name here, not library.name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:04:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 13:04:00 +0000 Subject: [Koha-bugs] [Bug 33807] New: Unable to resolve a claims returned item Message-ID: <bug-33807-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33807 Bug ID: 33807 Summary: Unable to resolve a claims returned item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: Laura.escamilla at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When marking a claims returned item as "resolved" in 22.11 the button has a spinning wheel that does not resolve with time. Refreshing the screen also does not resolve the issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:09:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 13:09:50 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: <bug-29275-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29275-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29275-70-r22tm2ozJI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #37 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- + if ( row.patron != null ) { + return $patron_to_html( row.patron, { display_cardnumber: true, url: true } ); + } + else { + return _("A patron from library %s").format(escape_str(row.library.name)); } This is not correct, is it? row.library.name should be row.patron.library.name, but we don't have it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:14:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 13:14:33 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-lqwgpt8gWU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29523 --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #12) > In the code there are still FIXMEs: > * display library names instead of codes Done in Bug 33568: Display library names instead of codes for recall Bug 33568: Display library names instead of codes for first hold Bug 33568: Display library names instead of codes for transfers > * desk name is not displayed anymore Done in Bug 33568: Display the desk name for the first hold > * checkout due date is not correctly formatted Done in Bug 33568: Use as_due_date to display due dates Remaining TODOs: * bundles of items (display the 'Manage bundle' button) * host records * analytic A new one: * Display the library name of the patron "A patron from LIBRARY NAME" if the patron's data must be hidden. This is related to bug 29523. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 [Bug 29523] Add a way to prevent embedding objects that should not be allowed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:14:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 13:14:33 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-eZNG9yjTTX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the biblio detail view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:25:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 13:25:30 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: <bug-29275-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29275-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29275-70-Hb5UjQmLmX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #38 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #37) > + if ( row.patron != null ) { > + return $patron_to_html( row.patron, { > display_cardnumber: true, url: true } ); > + } > + else { > + return _("A patron from library > %s").format(escape_str(row.library.name)); > } > > This is not correct, is it? > row.library.name should be row.patron.library.name, but we don't have it. +Strings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:55:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 13:55:02 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-pGA8P9Ud2y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #94 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Another thing, on bug 29275 we have a column with patron's name: "data": "patron.firstname:patron.surname:patron.cardnumber" I cannot test right now because the patch does not apply but in my understanding we are going to search on the patron's data, get the corresponding row, then hide the patron's info. We should remove the whole row I'd say, as we don't want to search on the patron's info. Are not we trying to provide a global solution for a tricky problem? What would be the other use cases? Both bug 29275 and bug 33568 need to hide patron's personal info, and this does not even answer this use case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:56:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 13:56:25 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-gIejJ228e7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #95 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #94) > Another thing, on bug 29275 we have a column with patron's name: > "data": "patron.firstname:patron.surname:patron.cardnumber" > > I cannot test right now because the patch does not apply but in my > understanding we are going to search on the patron's data, get the > corresponding row, then hide the patron's info. We should remove the whole > row I'd say, as we don't want to search on the patron's info. And, to be honest, I have no idea how we could deal with that, even with a simpler (more focus on patron) solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:56:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 13:56:52 +0000 Subject: [Koha-bugs] [Bug 33808] New: Accessibility: Non-descriptive links Message-ID: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Bug ID: 33808 Summary: Accessibility: Non-descriptive links Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: matt.blenkinsop at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org An accessibility report run by the Shaw trust for the British Museum has found some examples of links that are not labelled descriptively enough for screen readers. Extract below: "The text of a link should describe the destination of the link and the link’s purpose. Providing a descriptive link text will allow users to easily determine the function of the link and make educated decisions to click the link or not. If it is not possible to identify the purpose of the link from the link text itself, then this information should be provided in context. Screen reader users have the ability to display and navigate by lists of elements, or jump from element to element. Navigating this way is much quicker than listening to a whole page, however the context provided by paragraphs and other narrative is lost and non-descriptive links become harder to understand. For downloadable links, we recommend that the file type and size of the file is also included in the link text to allow the user to make a decision whether or not to download the file. On the 'opac-shelves.pl?op=view&shelfnumber=148&sortfield=title’ page there is a non-descriptive link labelled ‘Download’, this issue is found on numerous pages tested." This patch addresses similar Download buttons, adding aria-labels and aria-has popups to the links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:57:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 13:57:20 +0000 Subject: [Koha-bugs] [Bug 33808] Accessibility: Non-descriptive links In-Reply-To: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33808-70-gQ6xnE8VZ3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23003 Assignee|oleonard at myacpl.org |matt.blenkinsop at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:57:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 13:57:20 +0000 Subject: [Koha-bugs] [Bug 23003] Accessibility improvements In-Reply-To: <bug-23003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23003-70-GtU5yMXtqU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33808 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 [Bug 33808] Accessibility: Non-descriptive links -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:57:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 13:57:39 +0000 Subject: [Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format) In-Reply-To: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33804-70-q1wBCQhtcs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I think this is working correctly, but it seems that we could clean and remove some of the columns in checkouts.js (so maybe move the second patch to its own bug report). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:59:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 13:59:07 +0000 Subject: [Koha-bugs] [Bug 33171] Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder In-Reply-To: <bug-33171-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33171-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33171-70-tDx11IjYMl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- Tested this on a sandbox with the following in MarcItemFieldsToOrder: itype: 975$y coded_location_qualifier: 975$a barcode: 975$b enumchrom: 975$c My staged record contained: 975 _y CF _a coded location _b barcode _c enumchron On addorderiso2709.pl, when creating an order from my MARC record, the itype and coded location qualifier and correctly populated, but the barcode and enumchron are not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 15:59:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 13:59:46 +0000 Subject: [Koha-bugs] [Bug 33808] Accessibility: Non-descriptive links In-Reply-To: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33808-70-svTMLdoK43@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151564&action=edit Bug 33808: Add aria-labels in opac-shelves.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:00:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:00:41 +0000 Subject: [Koha-bugs] [Bug 33808] Accessibility: Non-descriptive links In-Reply-To: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33808-70-XxanBs9wiJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151565&action=edit Bug 33808: Add aria-labels in opac-basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:01:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:01:32 +0000 Subject: [Koha-bugs] [Bug 33808] Accessibility: Non-descriptive links In-Reply-To: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33808-70-u48q6clOWR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151566&action=edit Bug 33808: Add aria-labels in basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:02:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:02:18 +0000 Subject: [Koha-bugs] [Bug 33808] Accessibility: Non-descriptive links In-Reply-To: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33808-70-UhitEaD3oj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151567&action=edit Bug 33808: Add aria-labels in reports-toolbar.inc This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:03:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:03:09 +0000 Subject: [Koha-bugs] [Bug 33808] Accessibility: Non-descriptive links In-Reply-To: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33808-70-3ukE8ND81s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:09:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:09:55 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: <bug-29275-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29275-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29275-70-Af8Px2vjeN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #39 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Tomás Cohen Arazi from comment #38) > (In reply to Jonathan Druart from comment #37) > > + if ( row.patron != null ) { > > + return $patron_to_html( row.patron, { > > display_cardnumber: true, url: true } ); > > + } > > + else { > > + return _("A patron from library > > %s").format(escape_str(row.library.name)); > > } > > > > This is not correct, is it? > > row.library.name should be row.patron.library.name, but we don't have it. > > +Strings lol yes if you want, but that was not my point :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:12:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:12:29 +0000 Subject: [Koha-bugs] [Bug 33809] New: Accessibility: OPAC results page needs more descriptive links Message-ID: <bug-33809-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809 Bug ID: 33809 Summary: Accessibility: OPAC results page needs more descriptive links Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: matt.blenkinsop at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org A report by the Shaw trust for the British Museum's installation of Koha has identified some links in the OPAC results that are not descriptive enough for screen reader users. Extract below: "The text of a link should describe the destination of the link and the link’s purpose. Providing a descriptive link text will allow users to easily determine the function of the link and make educated decisions to click the link or not. If it is not possible to identify the purpose of the link from the link text itself, then this information should be provided in context. Screen reader users have the ability to display and navigate by lists of elements, or jump from element to element. Navigating this way is much quicker than listening to a whole page, however the context provided by paragraphs and other narrative is lost and non-descriptive links become harder to understand. For downloadable links, we recommend that the file type and size of the file is also included in the link text to allow the user to make a decision whether or not to download the file." This bug addresses the links identified in the report as needing clearer descriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:14:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:14:50 +0000 Subject: [Koha-bugs] [Bug 33809] Accessibility: OPAC results page needs more descriptive links In-Reply-To: <bug-33809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33809-70-5YfF4G4DJc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151568&action=edit Bug 33809: Facet "Show more/less" links don't identify what they are showing This patch addresses the Show more/less links in the side menu in opac-facets.inc. The links don't identify which facet they are linked to and this is confusing for screen readers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:16:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:16:17 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-sC9fywUpcl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:17:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:17:13 +0000 Subject: [Koha-bugs] [Bug 33809] Accessibility: OPAC results page needs more descriptive links In-Reply-To: <bug-33809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33809-70-BFTxGqkQ0L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151569&action=edit Bug 33809: Place hold and Add to cart links need better descriptions The place hold and add to cart buttons should identify to screen readers which title the button is linked to. This patch adds aria-labels that include the item title to make this more clear -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:17:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:17:22 +0000 Subject: [Koha-bugs] [Bug 33809] Accessibility: OPAC results page needs more descriptive links In-Reply-To: <bug-33809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33809-70-l7jqNGJhTC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:17:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:17:58 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-AKPXKr75JA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:19:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:19:03 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-bMEf7n1bAG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Can't locate object method "field" via package "00554cz a2200157n 4500001001300000003000400013005001700017008004100034010001700075040001800092100006800110400006200178400005600240400005000296670005000346n 00027419 DLC20000914083028.0000914n| acannaabn |a aaa an 00027419 aDLCbengcDLC1 aHacikyan, A. J.q(Agop Jack),d1931-tEté sans aube.lEnglish1 aHacikyan, A. J.q(Agop Jack),d1931-tSummer without dawn1 aSoucy, Jean Yves,d1945-tEté sans aube.lEnglish1 aSoucy, Jean Yves,d1945-tSummer without dawn aHacikyan, A. J. A summer without dawn, c2000." (perhaps you forgot to load "00554cz a2200157n 4500001001300000003000400013005001700017008004100034010001700075040001800092100006800110400006200178400005600240400005000296670005000346n 00027419 DLC20000914083028.0000914n| acannaabn |a aaa an 00027419 aDLCbengcDLC1 aHacikyan, A. J.q(Agop Jack),d1931-tEté sans aube.lEnglish1 aHacikyan, A. J.q(Agop Jack),d1931-tSummer without dawn1 aSoucy, Jean Yves,d1945-tEté sans aube.lEnglish1 aSoucy, Jean Yves,d1945-tSummer without dawn aHacikyan, A. J. A summer without dawn, c2000."?) at /usr/share/koha/C4/Breeding.pm line 479 in C4::Breeding::ImportBreedingAuth at /usr/share/koha/C4/Breeding.pm line 479 $marcdata is no marc record ! It is a marc blob. How did you manage to test it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:21:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:21:34 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-uQwfx0Y8Yr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- The changes do not look good to me. We should not save in other encodings. Everywhere we convert to UTF-8. Here we should too. When I compare BIB with AUTH in Z3950Search, we also save bib records in UTF8. Note that there are some subtle differences. For instance the moment when we call SetUTF8Flag. This needs more attention. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:23:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:23:10 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-RmujwbDUJT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Nick Clemens from comment #1) > While providing a test plan, it requires a MARC8 Authority source, and I > cannot locate > an open one. This change can be verified by reading the code. This sounds problematic. > There are no unit tests for Z3950SearchAuth, but it does too much and > requires many mocks, > this is a small fix to a reversion and should be able to move forward. And this too :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:23:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:23:38 +0000 Subject: [Koha-bugs] [Bug 18398] CHECKIN/CHECKOUT/RENEWAL don't use AutoEmailPrimaryAddress but first valid e-mail In-Reply-To: <bug-18398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18398-70-PcINN7LGqS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #19 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- doesn't apply to 21.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:23:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:23:39 +0000 Subject: [Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used In-Reply-To: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33223-70-vFN6ciemi0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 Bug 33223 depends on bug 18398, which changed state. Bug 18398 Summary: CHECKIN/CHECKOUT/RENEWAL don't use AutoEmailPrimaryAddress but first valid e-mail https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:24:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:24:59 +0000 Subject: [Koha-bugs] [Bug 33216] SIP fee paid messages explode if payment registers are enabled and the SIP account has no register In-Reply-To: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33216-70-G031IKtalo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33216 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.06,22.05.13 |23.05.00,22.11.06,22.05.13, released in| |21.11.21 CC| |arthur.suzuki at biblibre.com --- Comment #18 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:25:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:25:40 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11300-70-LPpv3PgYcB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 --- Comment #57 from Phil Ringnalda <phil at chetcolibrary.org> --- Correct: the order of subfields matters, which subfield letter it is matters, and whether or not there is a subfield matters ($aScience fiction should not match $aScience$vFiction). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:26:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:26:00 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32642-70-uxqDBpDhPz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.06,22.05.13 |23.05.00,22.11.06,22.05.13, released in| |21.11.21 CC| |arthur.suzuki at biblibre.com --- Comment #31 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:26:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:26:36 +0000 Subject: [Koha-bugs] [Bug 31432] MARC21: Make 245 n and p subfields visible in frameworks by default In-Reply-To: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31432-70-lhjEYZmXVV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31432 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Version(s)|23.05.00,22.11.06,22.05.13 |23.05.00,22.11.06,22.05.13, released in| |21.11.21 --- Comment #12 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:32:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:32:26 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11300-70-ggk47lz9GS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 --- Comment #58 from Blou <philippe.blouin at inlibro.com> --- The code will not care about the order. I would be doing that and I would hear about it asking why there are duplicates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:33:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:33:32 +0000 Subject: [Koha-bugs] [Bug 33038] Add classes to category code and category type in patron brief information for easier customization In-Reply-To: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33038-70-8zh7w7csO1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33038 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Back end stuff, nothing to add/amend in the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:35:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:35:40 +0000 Subject: [Koha-bugs] [Bug 33806] Overridden checkin date not retained when CircConfirmItemParts enabled In-Reply-To: <bug-33806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33806-70-ywhsd0DryU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151563|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 151570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151570&action=edit Bug 33806: Retain specified date when confirming item parts at checkin This patch simply adds hidden inputs to the item parts confirm form to ensure specified checkin date is retained To test: 1 - Find or add an item with subfield 3 - materials specified 2 - Enable system preference CircConfirmItemParts 3 - Go to Circulation->Checkin 4 - Click the settings button in the input box and enter a checkin date and select the remeber check box 5 - Check in some items, confirm date retained 6 - Checkin the item with the materials specified 7 - Confirm checkin 8 - Note that checkin date is cleared 9 - Apply patch 10 - Repeat 3-7 11 - Confirm date is retained Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:36:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:36:09 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-pw9TPLFOHW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151519|0 |1 is obsolete| | --- Comment #76 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 151571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151571&action=edit Bug 30719: DB and API - Adds 'batch' accessor to Illrequest object - New illbatches and illbatch_statuses tables - New foreign key 'batch_id' in illrequests table - Atomic update file - Default illbatch_statuses - Add 'add' ill_requests api method - Add POST method in ill_requests path - Add 'batch_id property to ill_request api definition - Updated swagger.yml with new batches and batchstatuses endpoints Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller at ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:36:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:36:12 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-HnjNHyKaMS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151520|0 |1 is obsolete| | --- Comment #77 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 151572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151572&action=edit Bug 30719: ILL Batches - Add batch column to requests table - Establish if there are any availability or metadata enrichment plugins and pass that to the template - Verify if we have any backend that can support batches, if not, don't show the option - Updates to the ILL toolbar - New ILL batch modal - New Koha classes - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller at ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:36:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:36:15 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-tjwZRJnJGv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151521|0 |1 is obsolete| | --- Comment #78 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 151573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151573&action=edit Bug 30719: ILL Batch Statuses - UI adding support for batch statuses in batch UI - Admin UI for managing batch statuses - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller at ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:36:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:36:18 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-OfCzvhqXeg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151522|0 |1 is obsolete| | --- Comment #79 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 151574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151574&action=edit Bug 30719: Tests Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller at ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:36:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:36:21 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-d8FaNCl86z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151523|0 |1 is obsolete| | --- Comment #80 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 151575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151575&action=edit Bug 30719: dbic specific, DONT PUSH Signed-off-by: Edith Speller <Edith.Speller at ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:36:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:36:24 +0000 Subject: [Koha-bugs] [Bug 33806] Overridden checkin date not retained when CircConfirmItemParts enabled In-Reply-To: <bug-33806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33806-70-r9CdHg4QNZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:37:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:37:20 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-mp3ghW3awT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:37:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:37:35 +0000 Subject: [Koha-bugs] [Bug 33809] Accessibility: OPAC results page needs more descriptive links In-Reply-To: <bug-33809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33809-70-tLeWpnTB56@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151569|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151576&action=edit Bug 33809: Place hold and Add to cart links need better descriptions The place hold and add to cart buttons should identify to screen readers which title the button is linked to. This patch adds aria-labels that include the item title to make this more clear -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:40:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:40:56 +0000 Subject: [Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page In-Reply-To: <bug-26598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26598-70-OArtFBJpO0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Text to go in the| |This enhancement adds a new release notes| |tab in the patron details | |page to show guarantees' | |unpaid charges. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:43:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:43:07 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-pjIDJVigts@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |arthur.suzuki at biblibre.com Status|Pushed to oldstable |RESOLVED --- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- doesn't apply on 21.11, provide a backport if needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:44:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:44:27 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-xGRZNcHKIn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |arthur.suzuki at biblibre.com --- Comment #19 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- doesn't apply on 21.11 please provide a backport if needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:48:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:48:29 +0000 Subject: [Koha-bugs] [Bug 33810] New: Accessibility: OPAC Advanced Search fields are not labelled Message-ID: <bug-33810-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Bug ID: 33810 Summary: Accessibility: OPAC Advanced Search fields are not labelled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: matt.blenkinsop at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The OPAC Advanced Search fields are not labelled and have been failed in an Accessibility report carried out by the Shaw Trust for the British Museum. The search field dropdowns do not have any labelling at all and the text inputs have a title, rather than a label element or an aria-label. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:48:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:48:39 +0000 Subject: [Koha-bugs] [Bug 33810] Accessibility: OPAC Advanced Search fields are not labelled In-Reply-To: <bug-33810-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33810-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33810-70-Hh15kU4Yru@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |matt.blenkinsop at ptfs-europe | |.com Blocks| |25423 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25423 [Bug 25423] Methods update and empty from Koha::Objects are not class methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:48:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:48:39 +0000 Subject: [Koha-bugs] [Bug 25423] Methods update and empty from Koha::Objects are not class methods In-Reply-To: <bug-25423-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25423-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25423-70-J29pu7QRBb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25423 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33810 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 [Bug 33810] Accessibility: OPAC Advanced Search fields are not labelled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:51:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:51:00 +0000 Subject: [Koha-bugs] [Bug 33810] Accessibility: OPAC Advanced Search fields are not labelled In-Reply-To: <bug-33810-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33810-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33810-70-cOv46jsOYN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151577&action=edit Bug 33810: Opac advanced search fields need aria-labels The OPAC advanced search fields need aria-labels to assist with screen reading. This patch adds labels to both the dropdown selects and the text inputs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:51:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:51:38 +0000 Subject: [Koha-bugs] [Bug 33810] Accessibility: OPAC Advanced Search fields are not labelled In-Reply-To: <bug-33810-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33810-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33810-70-35ScVcN2Cm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Blocks|25423 |25243 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25243 [Bug 25243] Accessibility: 2.4.6 Headings and Labels https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25423 [Bug 25423] Methods update and empty from Koha::Objects are not class methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:51:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:51:38 +0000 Subject: [Koha-bugs] [Bug 25243] Accessibility: 2.4.6 Headings and Labels In-Reply-To: <bug-25243-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25243-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25243-70-86Kpk8lACV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25243 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33810 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 [Bug 33810] Accessibility: OPAC Advanced Search fields are not labelled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:51:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:51:38 +0000 Subject: [Koha-bugs] [Bug 25423] Methods update and empty from Koha::Objects are not class methods In-Reply-To: <bug-25423-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25423-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25423-70-0Luzqg0cdG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25423 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|33810 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 [Bug 33810] Accessibility: OPAC Advanced Search fields are not labelled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:52:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:52:06 +0000 Subject: [Koha-bugs] [Bug 33811] New: Overridden checkin dates are not respected at all when CircConfirmItemParts enabled and item has parts note Message-ID: <bug-33811-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33811 Bug ID: 33811 Summary: Overridden checkin dates are not respected at all when CircConfirmItemParts enabled and item has parts note Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrewfh at dubcolib.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com, nick at bywatersolutions.com Depends on: 33806 To recreate: 1 - turn on CircConfirmItemParts 2 - have an item with a value in the 952$3 3 - check the item out 4 - go to the checkin page, set a due date in the past, check the item in 5 - run a report to find the returndate for your issue in old_issues, confirm that it shows the actual date of your checkin, not the manually overridden date 6 - Repeats steps 3 and 4 with an item without a 952$3 7 - confirm via report that the returndate for this issue shows the overridden date With the patch from 33806, if one checks the "Remember return date for next check in" box then the overridden returndate *is* correctly recorded in old_issues. But only if you check the box. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 [Bug 33806] Overridden checkin date not retained when CircConfirmItemParts enabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:52:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:52:06 +0000 Subject: [Koha-bugs] [Bug 33806] Overridden checkin date not retained when CircConfirmItemParts enabled In-Reply-To: <bug-33806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33806-70-2QsrOaiStM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33811 [Bug 33811] Overridden checkin dates are not respected at all when CircConfirmItemParts enabled and item has parts note -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:52:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:52:40 +0000 Subject: [Koha-bugs] [Bug 33156] Batch patron modification tool is missing search bar and other attributes In-Reply-To: <bug-33156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33156-70-6ggCaDiLKd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com --- Comment #13 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- conflicts on 21.11. won't backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 16:57:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 14:57:53 +0000 Subject: [Koha-bugs] [Bug 33806] Overridden checkin date not retained when CircConfirmItemParts enabled In-Reply-To: <bug-33806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33806-70-klHhtY9IGn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151570|0 |1 is obsolete| | --- Comment #3 from Sam Lau <samalau at gmail.com> --- Created attachment 151578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151578&action=edit Bug 33806: Retain specified date when confirming item parts at checkin This patch simply adds hidden inputs to the item parts confirm form to ensure specified checkin date is retained To test: 1 - Find or add an item with subfield 3 - materials specified 2 - Enable system preference CircConfirmItemParts 3 - Go to Circulation->Checkin 4 - Click the settings button in the input box and enter a checkin date and select the remeber check box 5 - Check in some items, confirm date retained 6 - Checkin the item with the materials specified 7 - Confirm checkin 8 - Note that checkin date is cleared 9 - Apply patch 10 - Repeat 3-7 11 - Confirm date is retained Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:00:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:00:16 +0000 Subject: [Koha-bugs] [Bug 32530] When duplicating child card, guarantor is not saved In-Reply-To: <bug-32530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32530-70-qPuHjumiwq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Still valid in master (22.12.00.048) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:06:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:06:34 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling In-Reply-To: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23059-70-UQxG17zTNK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:06:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:06:37 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling In-Reply-To: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23059-70-JuAf4O7KTY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151579&action=edit Bug 23059: reserve_stats.pl: Simplify reservestatus This patch does the following: [1] Go back to four statuses: Cancelled, Filled, Waiting or Placed. Placed is used as collective name for all other statuses: pending (placed), processing (found==P) or transit (found==T). Placed before anyway. [2] Allow translation of these statuses in the template. Remove the sub reservestatushuman. [3] The output of changeifreservestatus is considerably shorter and less ugly in the constructed sql statement. Test plan: [1] Use reservestatus as row, as column and only as filter (clicking few statuses). [2] Verify that the shown statistics meet your expectations. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:21:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:21:20 +0000 Subject: [Koha-bugs] [Bug 33805] Marking an item as claims returned results in a spinning wheel In-Reply-To: <bug-33805-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33805-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33805-70-a51cyvTfkv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33805 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 33621 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:21:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:21:20 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-FiiSdaOzfW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com --- Comment #19 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- *** Bug 33805 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:21:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:21:32 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-JzcfyTydin@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:21:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:21:35 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-1cQZTAmfol@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150265|0 |1 is obsolete| | --- Comment #63 from Sam Lau <samalau at gmail.com> --- Created attachment 151580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151580&action=edit Bug 33478: Add formatting columns to letter table Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:21:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:21:37 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-hNARutrey7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150266|0 |1 is obsolete| | --- Comment #64 from Sam Lau <samalau at gmail.com> --- Created attachment 151581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151581&action=edit Bug 33478: Schema updates Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:21:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:21:39 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-Fsz2sSXolc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150335|0 |1 is obsolete| | --- Comment #65 from Sam Lau <samalau at gmail.com> --- Created attachment 151582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151582&action=edit Bug 33478: Save notice format settings Save format settings for an individual notice, or for all notices To test: 1. Apply the patches, install database updates, update schema if needed, and restart services 2. Go to Tools -> Notices and slips 3. Edit any notice 4. Go to the Format tab 5. Confirm format settings are available to edit 6. Change some settings and confirm they save correctly 7. Test that 'apply these settings to all notices' option works. Test the confirmation box appears when this is checked. 8. Add a new notice and confirm format settings save successfully Sponsored-by: Colorado Library Consortium Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:21:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:21:42 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-CjgpXT3CeI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150336|0 |1 is obsolete| | --- Comment #66 from Sam Lau <samalau at gmail.com> --- Created attachment 151583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151583&action=edit Bug 33478: Apply formatting to HOLD_SLIP To test: 1. Place a hold on a record 2. Check in an item attached to the record 3. When the pop-up for the hold is triggered, confirm hold and print slip 4. Confirm your format settings for HOLD_SLIP are applied Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:21:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:21:44 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-WWgzw5Sjto@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150337|0 |1 is obsolete| | --- Comment #67 from Sam Lau <samalau at gmail.com> --- Created attachment 151584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151584&action=edit Bug 33478: Apply formatting to AR_SLIP To test: 1. Enable ArticleRequests system preference in Koha Administration -> Global system preferences 2. Log into the OPAC 3. Do a catalogue search 4. Click the 'Request article' button for a record 5. Fill in some information and submit 6. Go to the staff interface 7. Go to Circulation -> Article Requests 8. Click the Actions menu next to your article request and choose Print slip 9. Confirm your format settings for AR_SLIP are applied Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:21:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:21:47 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-DNRuqmcQf5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150338|0 |1 is obsolete| | --- Comment #68 from Sam Lau <samalau at gmail.com> --- Created attachment 151585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151585&action=edit Bug 33478: Apply formatting to TRANSFERSLIP To test: 1. Search for an item that was last seen at a library different from your logged in library i.e the holding library is Fairview but your logged in library is Centerville 2. Use the barcode to check in the item 3. When the popup to 'please return this item to <home library>' is triggered, click the Print slip button 4. Confirm your format settings for TRANSFERSLIP are applied Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:21:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:21:49 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-qv8RSIjxNk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150339|0 |1 is obsolete| | --- Comment #69 from Sam Lau <samalau at gmail.com> --- Created attachment 151586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151586&action=edit Bug 33478: Apply formatting to OVERDUES_SLIP To test: 1. Check out an item to a user. Set the due date to a time in the past so it is overdue 2. Click Print in the members toolbar, then Print overdues 3. Confirm your format settings for OVERDUES_SLIP are applied Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:21:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:21:51 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-216miTuIbZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150340|0 |1 is obsolete| | --- Comment #70 from Sam Lau <samalau at gmail.com> --- Created attachment 151587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151587&action=edit Bug 33478: Apply formatting to ACCOUNT_DEBIT To test: 1. Go to a patron accounting page 2. Create a manual invoice and Save 3. You'll be redirected to the Transactions tab 4. Click the Print button next to your invoice 5. Confirm your format settings for ACCOUNT_DEBIT are applied Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:21:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:21:54 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-gVMjy5CX1y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150341|0 |1 is obsolete| | --- Comment #71 from Sam Lau <samalau at gmail.com> --- Created attachment 151588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151588&action=edit Bug 33478: Apply formatting to ACCOUNT_CREDIT To test: 1. Go to a patron accounting page 2. Create a manual invoice and Save 3. You'll be redirected to the Transactions tab 4. Click the Pay button next to your invoice and confirm Payment 5. Click the Print button next to your Payment 6. Confirm your format settings for ACCOUNT_CREDIT are applied Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:21:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:21:56 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-b0mYKaOXjs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150342|0 |1 is obsolete| | --- Comment #72 from Sam Lau <samalau at gmail.com> --- Created attachment 151589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151589&action=edit Bug 33478: Apply formatting to ISSUESLIP, ISSUEQSLIP, CHECKINSLIP To test: 1. Check out an item to a patron 2. Click Print in the members toolbar, then Print quick slip 3. Confirm your format settings for ISSUEQSLIP are applied 4. Click Print in the members toolbar, then Print slip 5. Confirm your format settings for ISSUESLIP are applied 6. Return the item 7. When the item is checked in, click the 'Print checkin slip' button 8. Confirm your format settings for CHECKINSLIP are applied Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:21:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:21:58 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-WTRrnaae4T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150343|0 |1 is obsolete| | --- Comment #73 from Sam Lau <samalau at gmail.com> --- Created attachment 151590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151590&action=edit Bug 33478: Apply formatting to RECEIPT To test: 1. Enable EnablePointOfSale and UseCashRegisters system preferences in Koha Administration -> Global system preferences 2. Go to Koha Administration -> Cash registers and add a new cash register 3. Go to Koha Administration -> Debit types and add a new debit type. Make sure you check the 'can be sold' option 4. Go to Point of sale 5. Select Add for your item under Items for purchase 6. Fill in Collect payment box and click Confirm 7. When payment is received, click Print receipt 8. Confirm your format settings for RECEIPT are applied Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:22:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:22:01 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-jvF0kXiduu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150344|0 |1 is obsolete| | --- Comment #74 from Sam Lau <samalau at gmail.com> --- Created attachment 151591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151591&action=edit Bug 33478: Apply formatting to ACCOUNTS_SUMMARY To test: 1. Go to a patron accounting page 2. Create a manual invoice and Save 3. Click the Print button in the patron toolbar 4. Click the 'Print account balance' button 5. Confirm your format settings for ACCOUNTS_SUMMARY are applied Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:22:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:22:03 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-a5esHqmbhI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150345|0 |1 is obsolete| | --- Comment #75 from Sam Lau <samalau at gmail.com> --- Created attachment 151592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151592&action=edit Bug 33478: Apply formatting to RECALL_REQUESTER_DET To test: 1. Enable UseRecalls system preference and configure all relevant recalls circulation and fines rules 2. Search for a record with only one item 3. Check out this item to Patron A 4. Log into the OPAC as Patron B 5. Search for the item and place a recall 6. Go back to the staff interface 7. Check in the item 8. When the pop-up for the recall is triggered, confirm recall and print slip 9. Confirm your format settings for RECALL_REQUESTER_DET are applied Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:22:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:22:06 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-svnMOxXsZG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151548|0 |1 is obsolete| | --- Comment #76 from Sam Lau <samalau at gmail.com> --- Created attachment 151593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151593&action=edit Bug 33478: Make sure formatting is applied to tables in notices This fixes the formatting not showing on ACCOUNTS_SUMMARY and also applies changes to headings Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:24:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:24:57 +0000 Subject: [Koha-bugs] [Bug 30487] Convert checkout and patron details page tabs to Bootstrap In-Reply-To: <bug-30487-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30487-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30487-70-09bpzZxo5S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30487 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:24:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:24:57 +0000 Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs In-Reply-To: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29226-70-dMMJbbkoMS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Bug 29226 depends on bug 30487, which changed state. Bug 30487 Summary: Convert checkout and patron details page tabs to Bootstrap https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30487 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:25:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:25:34 +0000 Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs In-Reply-To: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29226-70-9kRtnucxWH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:25:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:25:34 +0000 Subject: [Koha-bugs] [Bug 29222] OMNIBUS: Replace the use of jQueryUI In-Reply-To: <bug-29222-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29222-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29222-70-cqPWMkh0Yb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29222 Bug 29222 depends on bug 29226, which changed state. Bug 29226 Summary: OMNIBUS: Replace the use of jQueryUI tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 17:46:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 15:46:57 +0000 Subject: [Koha-bugs] [Bug 33807] Unable to resolve a claims returned item In-Reply-To: <bug-33807-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33807-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33807-70-ohjdrt9rCo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33807 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:07:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 16:07:43 +0000 Subject: [Koha-bugs] [Bug 33812] New: Accessibility: OPAC messaging preferences is missing form labels Message-ID: <bug-33812-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33812 Bug ID: 33812 Summary: Accessibility: OPAC messaging preferences is missing form labels Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: matt.blenkinsop at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The checkboxes in the Messaging preferences table in the OPAC have been flagged as non-compliant by the Shaw Trust in a report carried out for the British Museum. It is not clear for screen readers what the checkboxes are for. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:08:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 16:08:05 +0000 Subject: [Koha-bugs] [Bug 33812] Accessibility: OPAC messaging preferences is missing form labels In-Reply-To: <bug-33812-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33812-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33812-70-4gQefLvvkJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33812 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |matt.blenkinsop at ptfs-europe | |.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33810 Blocks| |25243 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25243 [Bug 25243] Accessibility: 2.4.6 Headings and Labels -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:08:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 16:08:05 +0000 Subject: [Koha-bugs] [Bug 25243] Accessibility: 2.4.6 Headings and Labels In-Reply-To: <bug-25243-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25243-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25243-70-er6DxK67Dt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25243 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33812 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33812 [Bug 33812] Accessibility: OPAC messaging preferences is missing form labels -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:08:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 16:08:05 +0000 Subject: [Koha-bugs] [Bug 33810] Accessibility: OPAC Advanced Search fields are not labelled In-Reply-To: <bug-33810-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33810-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33810-70-0O1r2dstsi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33812 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:10:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 16:10:18 +0000 Subject: [Koha-bugs] [Bug 33812] Accessibility: OPAC messaging preferences is missing form labels In-Reply-To: <bug-33812-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33812-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33812-70-xRihPCgTK0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33812 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151594&action=edit Bug 33812: Checkboxes need labels in opac-messaging.tt Aria-labels have been added to checkboxes in the OPAC messaging preferences table to assist with screen reading. The relevant preference has been mentioned in each label to identify what the checkbox is for. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:26:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 16:26:28 +0000 Subject: [Koha-bugs] [Bug 33813] New: Accessibility: Lists button is not clearly identified Message-ID: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33813 Bug ID: 33813 Summary: Accessibility: Lists button is not clearly identified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: matt.blenkinsop at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The Lists button in the OPAC masthead has been identified as not being descriptive enough for screen readers. An aria-label is needed to show that this button provides a dropdown containing the users Lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:26:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 16:26:49 +0000 Subject: [Koha-bugs] [Bug 33813] Accessibility: Lists button is not clearly identified In-Reply-To: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33813-70-EjIrv8xDYk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33813 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27496 Assignee|oleonard at myacpl.org |matt.blenkinsop at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27496 [Bug 27496] Accessibility: Navigation buttons are poorly described by screen readers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:26:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 16:26:49 +0000 Subject: [Koha-bugs] [Bug 27496] Accessibility: Navigation buttons are poorly described by screen readers In-Reply-To: <bug-27496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27496-70-CUB167fsCS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27496 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33813 [Bug 33813] Accessibility: Lists button is not clearly identified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:27:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 16:27:59 +0000 Subject: [Koha-bugs] [Bug 33813] Accessibility: Lists button is not clearly identified In-Reply-To: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33813-70-yoRDNoVARy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33813 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151595&action=edit Bug 33813: Masthead lists button requires an aria-label This patch adds an aria-label to the Lists button in the masthead. It is currently not descriptive enough and doesn't identify what is displayed when clicking the button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:28:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 16:28:08 +0000 Subject: [Koha-bugs] [Bug 33813] Accessibility: Lists button is not clearly identified In-Reply-To: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33813-70-f11ZfdNGOW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33813 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:33:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 16:33:17 +0000 Subject: [Koha-bugs] [Bug 33809] Accessibility: OPAC results page needs more descriptive links In-Reply-To: <bug-33809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33809-70-paaztoO3ST@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |matt.blenkinsop at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:36:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 16:36:12 +0000 Subject: [Koha-bugs] [Bug 29507] Speed up auto renew cronjob via parallel processing In-Reply-To: <bug-29507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29507-70-wHzzjNheFB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29507 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau at gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:41:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 16:41:31 +0000 Subject: [Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface In-Reply-To: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32677-70-ybnBUZuGWD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677 --- Comment #17 from Victor Zuniga <vctrzuniga at gmail.com> --- (In reply to Jonathan Druart from comment #16) > Which version of Koha are you using? > > In recent versions you are not supposed to have 'prog' or 'ccsr' in > /usr/share/koha/opac/htdocs/opac-tmpl/ but 'bootstrap'. Hi Jonathan, We are using version 22.11.05 I checked this morning and to my surprise, the Spanish language package had been installed despite the error messages from yesterday. I checked on the staff interface and sure enough, the option was displayed and available. Here are the contents of the prog folder on our system as of this morning: vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ ls es-ES vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ cd es-ES/ vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog/es-ES$ ls js vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog/es-ES$ cd js/ vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog/es-ES/js$ ls locale_data.js I enabled it on the staff interface to confirm and it is working as expected. Woot Woot!! I checked and here are the contents of the bootstrap folder: vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/prog$ cd .. vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl$ ls bootstrap ccsr lib prog xslt vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl$ cd bootstrap vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/bootstrap$ ls css en es-ES images itemtypeimg js lib vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/bootstrap$ vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/bootstrap$ cd es-ES/ vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/es-ES$ ls includes js modules xslt vzuniga at SJDS:/usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/es-ES$ Am I to understand that the bootstrap folder should take precedence for language installations? We were forced to upgrade this system from a very outdated version back in December 2022. I wonder if the migration tools (even though we ended up doing a fair amount of manual tweaks) did not remove this folder as part of the upgrade. Can I remove the prog folder safely to avoid further confusion? or should I just leave it be? Thanks for all your help Katrin, David, and Jonathan!! Best, Victor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:49:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 16:49:44 +0000 Subject: [Koha-bugs] [Bug 33803] Some scripts contain info about tab width In-Reply-To: <bug-33803-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33803-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33803-70-ayREtyaSaQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33803 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:49:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 16:49:47 +0000 Subject: [Koha-bugs] [Bug 33803] Some scripts contain info about tab width In-Reply-To: <bug-33803-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33803-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33803-70-yzHxtJrKBm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33803 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151554|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151596&action=edit Bug 33803: Remove comment about tab width Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:57:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 16:57:53 +0000 Subject: [Koha-bugs] [Bug 33808] Accessibility: Non-descriptive links In-Reply-To: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33808-70-62YpozvVxR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151564|0 |1 is obsolete| | Attachment #151565|0 |1 is obsolete| | Attachment #151566|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151597&action=edit Bug 33808: Add aria-labels in opac-shelves.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:57:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 16:57:56 +0000 Subject: [Koha-bugs] [Bug 33808] Accessibility: Non-descriptive links In-Reply-To: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33808-70-vdEjuiTS2B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151598&action=edit Bug 33808: Add aria-labels in opac-basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:57:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 16:57:58 +0000 Subject: [Koha-bugs] [Bug 33808] Accessibility: Non-descriptive links In-Reply-To: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33808-70-acwOhlQjPZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151599&action=edit Bug 33808: Add aria-labels in basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 18:59:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 16:59:28 +0000 Subject: [Koha-bugs] [Bug 33808] Accessibility: Non-descriptive links In-Reply-To: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33808-70-tlsIXk7XLO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- > Bug 33808: Add aria-labels in reports-toolbar.inc The label on this one, "Select format and download chart" is incorrect. It should be something like "Select format and download report results." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 19:15:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 17:15:19 +0000 Subject: [Koha-bugs] [Bug 33810] Accessibility: OPAC Advanced Search fields are not labelled In-Reply-To: <bug-33810-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33810-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33810-70-lb2yMgBAGE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- "Choose search field 1," "Choose search field 2," etc seem a little unclear to me. What about "Choose search type for field 1" ? Then perhaps the text input could also refer to the field number? "Enter field 1 search terms" ? That might help the user understand the context. I also think this patch should address the search operator dropdowns that appear if you click the "More options" button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 19:45:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 17:45:29 +0000 Subject: [Koha-bugs] [Bug 33814] New: HOLD notices for email and sms do not enqueue even if enabled Message-ID: <bug-33814-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33814 Bug ID: 33814 Summary: HOLD notices for email and sms do not enqueue even if enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: emily.lamancusa at montgomerycountymd.gov QA Contact: testopia at bugs.koha-community.org I'm marking this Major because of the impact on customer service, but if Normal would be more appropriate feel free to adjust. I'm seeing this bug in 22.11.04 and in master: when a hold is set to Waiting, only the print notice for "hold waiting" is enqueued on the patron's account, even if the patron has email and/or SMS notices for waiting holds enabled on their account. Unless this is a display error in the patron notices tab (not sure how likely that is or how to test for that in a test environment), this would mean that the patron has no way of being notified when their hold is ready for pickup. To reproduce: 1. Edit a patron's Messaging Preferences to enable email/SMS notices for "Hold Filled" 2. Place a hold for that patron 3. Check in an item to fill the hold 4. Go to the patron's account and click the Notices tab Note that an enqueued print notice appears in the patron's notices table for the available hold, but there is no email or SMS notice listed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 20:02:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 18:02:25 +0000 Subject: [Koha-bugs] [Bug 33814] HOLD notices for email and sms do not enqueue even if enabled In-Reply-To: <bug-33814-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33814-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33814-70-vUwsd2U4Zt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33814 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |trivial Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- Never mind, I feel rather silly now... I was only working with test patrons and didn't notice that they didn't have a valid email address or SMS number on their account. It occurred to me to test multiple Koha version and notification settings, but not to check that. As soon as I added the requisite contact information the notices enqueued normally. Sorry for the false alarm folks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 20:20:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 18:20:43 +0000 Subject: [Koha-bugs] [Bug 33815] New: Crash when librarian changes their own username in the staff interface Message-ID: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 Bug ID: 33815 Summary: Crash when librarian changes their own username in the staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org, tomascohen at gmail.com I tried in our production system (22.05.11) to change the username on my own account (an account with superlibrarian privileges) and it let to a white page blank except for the text "Internal Server Error." I wasn't able to access any page in Koha until I cleared my browser's cookies. When I test in master I see this error: Can't call method "password_expired" on an undefined value at /kohadevbox/koha/C4/Auth.pm line 1780 I think the problem happens only when you change the username field but you enter your existing password. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 23 20:22:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 18:22:01 +0000 Subject: [Koha-bugs] [Bug 33663] Don't hide Suggestions link in side navigation when suggestion preference is disabled In-Reply-To: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33663-70-nuIs47kYhR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151502|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Created attachment 151600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151600&action=edit Bug 33663: Don't hide Suggestions link in side navigation when suggestion preference is disabled We don't want to depend on the pref for the staff interface. Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 20:22:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 18:22:04 +0000 Subject: [Koha-bugs] [Bug 33663] Don't hide Suggestions link in side navigation when suggestion preference is disabled In-Reply-To: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33663-70-9X7MKBuGZw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151503|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Created attachment 151601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151601&action=edit Bug 33663: Pass 'suggestion' to the OPAC templates only We don't need it for the staff interface. The previous patch is removing the only occurrence using it. Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 20:22:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 18:22:37 +0000 Subject: [Koha-bugs] [Bug 33663] Don't hide Suggestions link in side navigation when suggestion preference is disabled In-Reply-To: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33663-70-2WYgFNACuo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor at tuxayo.net QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net |y.org | --- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 20:33:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 18:33:51 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-H6hnFDRiqU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com --- Comment #35 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- Conflicts when trying to apply to 21.11, can you provide a backport? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 20:44:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 18:44:37 +0000 Subject: [Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are checked out OR the record has at least one hold already" In-Reply-To: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32142-70-uiWpmQiUkU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau at gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 20:50:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 18:50:48 +0000 Subject: [Koha-bugs] [Bug 33813] Accessibility: Lists button is not clearly identified In-Reply-To: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33813-70-kkYmI3qve8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33813 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Should we be concerned about using the phrase "Click to..." ? That label wouldn't be acceptable if it were part of a text link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:20:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 19:20:03 +0000 Subject: [Koha-bugs] [Bug 33667] 'Copy to all libraries' doesn't work on editing holidays In-Reply-To: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33667-70-j2Ec2M1MdB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33667 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:20:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 19:20:05 +0000 Subject: [Koha-bugs] [Bug 33667] 'Copy to all libraries' doesn't work on editing holidays In-Reply-To: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33667-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33667-70-KoQoRPp4g9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33667 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151562|0 |1 is obsolete| | --- Comment #8 from Sam Lau <samalau at gmail.com> --- Created attachment 151602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151602&action=edit Bug 33667: Allow copying holidays to all libraries when editing When editing an existing holiday and checking the "copy to all libraires" checkbox, the other calendars won't get updates. Allow this by first checking if holiday exists in target calendar and if not, add it. To test: 1. Add unique holiday to branch A. 2. Don't check checkbox "Copy to all libraries". 3. Save. 4. Verify the holidays shows on all calendars as a green box. 5. Edit the holiday, now check "Copy to all libraries" and save. => Verify nothing has changed in other calendars: only the green box, no holiday in list on the right 6. Edit again, make a change to description, check checkbox, save. => Verify it's still not showing in the other calendars. 9. Apply this patch. 10. Edit holiday again, check "Copy to all libraries" and save. => Verify holiday is now added to other calendars. 11. Edit again, this time do not copy and save. => Verify holiday was edited just in branch A. 12. Again edit, check and save. => Verify holiday was edited in all libraries. Sponsored-by: Koha-Suomi Oy Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:49:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 19:49:58 +0000 Subject: [Koha-bugs] [Bug 25079] Show club enrollment question answers in staff client In-Reply-To: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25079-70-pXoIv7UH4V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25079 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:50:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 19:50:00 +0000 Subject: [Koha-bugs] [Bug 25079] Show club enrollment question answers in staff client In-Reply-To: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25079-70-pdq5eZGw2o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25079 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149544|0 |1 is obsolete| | --- Comment #4 from Sam Lau <samalau at gmail.com> --- Created attachment 151603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151603&action=edit Bug 25079: Add a 'edit' functionality to the Clubs tool in the staff interface A club enrollment can be cancel but it can't be edited This patch add a 'edit' functionality to the Clubs tool in the staff interface Test plan 1. Create a club template 1.1. Go to Tools > Patron clubs 1.2. Click on 'New Club Template' 1.3. Fill the form 1.4. on the 'Club fields' section, Click on Add new field 1.5. Fill in the form 1.6. on the 'Enrollment fields' section, Click on Add new field 1.7. Fill in the form 1.8. Click on Save button 2. Creation of the club 2.1. Go to Tools > Patron clubs > 'Clubs' section (bottom) 2.2. Click on the 'New Club' button and select the club template create on step 1 2.3. Fill in the form 2.4. Click on Save button 3. Club enrollement On the intranet 3.1. Search for a pratron and open the patron folder 3.2. Click on the 'Clubs' tab 3.3. Find the name of the club and click on 'Enroll' 3.4. Fill the questionnaire 3.5. Confirm registration ---> Note that the enrollement can be canceled but it cannot be modified 4. Apply the patch 5. Click one more time on the 'Clubs' tab ---> Note that the enrollement can now be modified Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:50:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 19:50:03 +0000 Subject: [Koha-bugs] [Bug 25079] Show club enrollment question answers in staff client In-Reply-To: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25079-70-vI8xbFcsoU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25079 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149545|0 |1 is obsolete| | --- Comment #5 from Sam Lau <samalau at gmail.com> --- Created attachment 151604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151604&action=edit Bug 25079: Show club enrollment question answers in staff client When a patron is enrolled in a patron club, koha collects answers to library-defined enrollment questions. Those answers go into the database but are not viewable outside of reports. This patch make those answers viewable on club-enrollments.pl. Test plan 1. Apply the patch 2. Create a club template 2.1. Go to Tools > Patron clubs 2.2. Click on 'New Club Template' 2.3. Fill the form 2.4. on the 'Club fields' section, Click on Add new field 2.5. Fill in the form 2.6. on the 'Enrollment fields' section, Click on Add new field 2.7. Fill in the form 2.8. Click on Save button 3. Creation of the club 3.1. Go to Tools > Patron clubs > 'Clubs' section (bottom) 3.2. Click on the 'New Club' button and select the club template create on step 1 3.3. Fill in the form 3.4. Click on Save button 4. Club enrollement On the intranet (or the OPAC if permitted) 4.1. Search for a pratron and open the patron folder 4.2. Click on the 'Clubs' tab 4.3. Find the name of the club and click on 'Enroll' 4.4. Fill the questionnaire 4.5. Confirm registration 5. Check registrations on the intranet 5.1. Go to Tools > Patron clubs 5.2. In the bottom 'Clubs' section, find the name of the club 5.3. check the 'Enrolled patrons' column ---> should not be equal to zero. 5.4 Click on 'Action' and choose the option “Enrollments” ---> The Enrollment fields created on step 2.6. are viewable in the table with their values Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:53:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 19:53:39 +0000 Subject: [Koha-bugs] [Bug 33663] Don't hide Suggestions link in side navigation when suggestion preference is disabled In-Reply-To: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33663-70-Wgj8gx9Dwi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:53:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 19:53:41 +0000 Subject: [Koha-bugs] [Bug 33663] Don't hide Suggestions link in side navigation when suggestion preference is disabled In-Reply-To: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33663-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33663-70-TYyOy1cjHo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:53:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 19:53:43 +0000 Subject: [Koha-bugs] [Bug 33762] Restore page-section in ILL In-Reply-To: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33762-70-R0f8Dw8hJc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33762 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:53:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 19:53:45 +0000 Subject: [Koha-bugs] [Bug 33762] Restore page-section in ILL In-Reply-To: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33762-70-4GLzqKDR8t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33762 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:53:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 19:53:46 +0000 Subject: [Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber In-Reply-To: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33792-70-gRXWPdpEmB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:53:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 19:53:48 +0000 Subject: [Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber In-Reply-To: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33792-70-1LhQl3zHbl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:53:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 19:53:50 +0000 Subject: [Koha-bugs] [Bug 33797] Extra space in supplier.tt In-Reply-To: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33797-70-qnhVGZzQsh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 21:53:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 19:53:51 +0000 Subject: [Koha-bugs] [Bug 33797] Extra space in supplier.tt In-Reply-To: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33797-70-n8ZzQnDuH3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:10:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 20:10:26 +0000 Subject: [Koha-bugs] [Bug 32731] Option for cataloguing tools to also be shown in Tools Home In-Reply-To: <bug-32731-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32731-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32731-70-4zdFLGhtml@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 22:10:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 20:10:28 +0000 Subject: [Koha-bugs] [Bug 32731] Option for cataloguing tools to also be shown in Tools Home In-Reply-To: <bug-32731-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32731-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32731-70-sXUyCMOSEs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150691|0 |1 is obsolete| | --- Comment #16 from Sam Lau <samalau at gmail.com> --- Created attachment 151605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151605&action=edit Bug 32731: Move cataloging tools to an include and show on tools home This patch moves the cataloging tools to an include, which is then added with a toggle to the tools homepage. This allows for the content to be on both pages, and can easily be hidden or shown by default. It ensures we don't have to maintain the same links in two places To test: 1 - Apply patch 2 - Ensure cataloging home page looks the same 3 - Ensure you can view/hide the cataloging tools on the tools page Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 23:00:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 21:00:50 +0000 Subject: [Koha-bugs] [Bug 33813] Accessibility: Lists button is not clearly identified In-Reply-To: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33813-70-OcRWvHEFbR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33813 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Owen Leonard from comment #2) > Should we be concerned about using the phrase "Click to..." ? That label > wouldn't be acceptable if it were part of a text link. Yes, "Click to..." doesn't provide anything useful for assistive technologies. I think something like "Show dropdown with detailed list information" would be better in this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 23:04:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 21:04:51 +0000 Subject: [Koha-bugs] [Bug 33809] Accessibility: OPAC results page needs more descriptive links In-Reply-To: <bug-33809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33809-70-vNwMjdtlFr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 23:05:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 21:05:53 +0000 Subject: [Koha-bugs] [Bug 33809] Accessibility: OPAC results page needs more descriptive links In-Reply-To: <bug-33809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33809-70-4iTYmlKf6F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 23:05:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 21:05:54 +0000 Subject: [Koha-bugs] [Bug 33809] Accessibility: OPAC results page needs more descriptive links In-Reply-To: <bug-33809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33809-70-4QxXn4IGDh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151568|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151606&action=edit Bug 33809: Facet "Show more/less" links don't identify what they are showing This patch addresses the Show more/less links in the side menu in opac-facets.inc. The links don't identify which facet they are linked to and this is confusing for screen readers. Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 23:05:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 21:05:57 +0000 Subject: [Koha-bugs] [Bug 33809] Accessibility: OPAC results page needs more descriptive links In-Reply-To: <bug-33809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33809-70-dNO3xsPCQ0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151576|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151607&action=edit Bug 33809: Place hold and Add to cart links need better descriptions The place hold and add to cart buttons should identify to screen readers which title the button is linked to. This patch adds aria-labels that include the item title to make this more clear Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 23:09:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 21:09:55 +0000 Subject: [Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page In-Reply-To: <bug-26598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26598-70-VoJn62lLTS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/693 Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 23:09:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 21:09:56 +0000 Subject: [Koha-bugs] [Bug 33774] Loading club table in every tab in patron details In-Reply-To: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33774-70-5xgHTYmYYc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 Bug 33774 depends on bug 26598, which changed state. Bug 26598 Summary: Display guarantee's fines on guarantor's details page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 23 23:40:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 21:40:47 +0000 Subject: [Koha-bugs] [Bug 21699] Allow circulation messages to be editable In-Reply-To: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21699-70-Gn9F09sygH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/693 Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 01:22:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 23:22:07 +0000 Subject: [Koha-bugs] [Bug 26611] Required match checks don't work for authority records In-Reply-To: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26611-70-EBpnLXvIsQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 01:22:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 23:22:10 +0000 Subject: [Koha-bugs] [Bug 26611] Required match checks don't work for authority records In-Reply-To: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26611-70-AsauFMHcAu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151549|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 151608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151608&action=edit Bug 26611: Make authority record matching use required match checks This patch fixes record matching for authorities to correctly apply required match checks. To test: 1) Create a record matching rule: Threshold: 100 Record type: Authority record Match point 1 Search index: subject-topical Score: 100 Tag: 150 Subfields: a Match check 1 Both source and target record check fields: Tag: 040 Subfields: a This rule says we want to match on the topical term heading, then confirm the match with 040$a. 2) Create two topical term authority records Authority 1: 150$a: Test 040$a: A Authority 2: 150$a: Test 040$a: B 3) Export authority 2 and save 4) Go to Cataloging -> Stage records for import 5) Upload your downloaded authority 2 file. Change the record type to Authority. Choose your new record matching rule. 6) Stage for import. 7) Confirm that with the record matching rule applied, both authorities 1 and 2 show as possible matches, even though only authority 2 has a matching 040$a. 8) Apply the patch and restart services 9) Change the matching rule to "Do not look for matching records" and apply. This is to essentially refresh the page. 10) Change the matching rule to your new matching rule and apply. Confirm only the matching authority 2 shows and is selected. Sponsored-by: Waikato Institute of Technology Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 01:26:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 23:26:57 +0000 Subject: [Koha-bugs] [Bug 26611] Required match checks don't work for authority records In-Reply-To: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26611-70-aYU34RjAyP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This fixes match checking release notes| |for authorities when | |importing records, so that | |the required match checks | |are correctly applied. | |Previously, match checks | |for authority records did | |not work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 01:34:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 23:34:11 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14695-70-t6WxWJGqb7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #244 from David Cook <dcook at prosentient.com.au> --- (In reply to Katrin Fischer from comment #243) > (In reply to David Cook from comment #241) > > Was this feature reverted? I've never actually seen it operational in Koha, > > which is why bug 15565 exists in its present all-encompassing state? > > It's possible in staff, but you need to allow multiple holds on one record > in circulation rules. OPAC implementation is pending. I think maybe I've always misunderstood this one. I thought it was supposed to allow you to place multiple item level holds at the same time. "At the same time" meaning during the "placing" of the hold rather than the "having" of the hold. And that's why we still need bug 15565 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 01:39:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 23:39:25 +0000 Subject: [Koha-bugs] [Bug 15567] Update API to allow multiple holds for the same record In-Reply-To: <bug-15567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15567-70-lhDPaO37PY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15567 --- Comment #6 from David Cook <dcook at prosentient.com.au> --- Not sure why this would depend on bug 15565... Looks like this patch adds way too much logic into the controller. Surely it would make sense to just take multiple items in as input and then run it through a loop and record the results. If we have the API endpoint, then maybe we can change the UIs to use the API and sidestep even needing 15565 as it stands -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 01:40:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 23:40:42 +0000 Subject: [Koha-bugs] [Bug 15567] Update API to allow multiple holds for the same record In-Reply-To: <bug-15567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15567-70-4FXUWcdewh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15567 --- Comment #7 from David Cook <dcook at prosentient.com.au> --- (In reply to David Cook from comment #6) > Surely it would make sense to just take multiple items in as input and then > run it through a loop and record the results. I mean I've created my own API endpoint in a different system which takes data for multiple items and does exactly that, so that 1 API call on that system can place holds for multiple items at the same time. (It's just the backend API call to the Koha that has to be done X times.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 01:42:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 May 2023 23:42:36 +0000 Subject: [Koha-bugs] [Bug 33813] Accessibility: Lists button is not clearly identified In-Reply-To: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33813-70-f4rqrXnqMQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33813 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind <david at davidnind.com> --- (In reply to Lucas Gass from comment #3) > I think something like "Show dropdown with detailed list information" would > be better in this case. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 02:09:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 00:09:55 +0000 Subject: [Koha-bugs] [Bug 33816] New: Holds API errors not easily machine-readable Message-ID: <bug-33816-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33816 Bug ID: 33816 Summary: Holds API errors not easily machine-readable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au CC: tomascohen at gmail.com At the moment, if you place a hold via the Holds API and there are too many holds for the record, you get the following response: {"error":"Hold cannot be placed. Reason: tooManyHoldsForThisRecord"} That's a message that is meant for a human developer. It's not showable to a human audience, and it's not easily parsed by a machine. It would be good to have a human readable message for troubleshooting, but the core error code should just be "tooManyHoldsForThisRecord", as a machine can take that string and work with it as a code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 02:30:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 00:30:29 +0000 Subject: [Koha-bugs] [Bug 33802] On OPAC authority detail page, usage count in erroneous In-Reply-To: <bug-33802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33802-70-93kqk0E7Dy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind <david at davidnind.com> --- I couldn't replicate the issue when using Zebra, but can when using Elasticsearch. So is this Elasticsearch specific? After the patch is applied, it fixes things for Elasticsearch, and I noticed no changes when using Zebra. Testing notes using koha-testing-docker and the sample data: 1. I'm assuming by enable QueryAutoTruncate, this means to set it to 'automatically' (the default in KTD). 2. I can't replicate the issue using Zebra: for authid=1 there are no results (as expected). 3. However, I can replicate the issue when using Elasticsearch: for authid=1 the details page shows 152 usages, clicking on the link shows no results; using authid=11 I get 12 usages, but only one actual result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 04:02:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 02:02:23 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11300-70-bqGzN76Ak0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 --- Comment #59 from Phil Ringnalda <phil at chetcolibrary.org> --- I wasn't asking for a weird enhancement I just thought of, I was describing the behavior of an authority linker. Order matters, Dogs -- Food and Food -- Dogs are not the same headings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 08:51:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 06:51:07 +0000 Subject: [Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface In-Reply-To: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32677-70-6kfBUEzVTp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677 --- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Victor Zuniga from comment #17) > > Am I to understand that the bootstrap folder should take precedence for > language installations? "bootstrap" is the default OPAC theme. "prog" and "ccsr" have been removed in favour of "bootstrap". It is no longer used. > We were forced to upgrade this system from a very outdated version back in > December 2022. I wonder if the migration tools (even though we ended up > doing a fair amount of manual tweaks) did not remove this folder as part of > the upgrade. > > Can I remove the prog folder safely to avoid further confusion? or should I > just leave it be? You *should* be safe removing it, but backup and test before! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 09:11:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 07:11:58 +0000 Subject: [Koha-bugs] [Bug 33780] Multi-line TT comment: [%% item.object.itemnotes.replace('\n', ' In-Reply-To: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33780-70-hJPv8QZYSv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33780 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This line? 594 <td><div class="itemnotes">[% item.object.itemnotes.replace('\n','<br />') | $raw %]</div></td> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 09:13:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 07:13:18 +0000 Subject: [Koha-bugs] [Bug 33801] Holds API doesn't follow holds policies like the staff/OPAC UIs In-Reply-To: <bug-33801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33801-70-BNPQj96Zav@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33801 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 09:31:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 07:31:25 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-Dz9xnRjBIu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151609&action=edit Bug 33815: Do not explode if logged in user modify their own userid If the logged in librarian modifies their own userid they will get the following error when submitting the form: Can't call method "password_expired" on an undefined value at /kohadevbox/koha/C4/Auth.pm line 1780 We could handle this situation and flag the session as expired. Better would be to deal with this specific user case and update the cookie (?) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 09:31:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 07:31:28 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-Vsyj58EMF4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151610&action=edit Bug 33815: Add a hint on the patron edit form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 09:32:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 07:32:00 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-iCyX5KuJac@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Is a logout acceptable? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 09:32:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 07:32:12 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-YU97POSoHQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- We need tests for the first patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 09:45:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 07:45:33 +0000 Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23919-70-El0AnPBsIJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #41 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Can you please help on the follow-up bug report? See bug 33514. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 09:46:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 07:46:01 +0000 Subject: [Koha-bugs] [Bug 33514] SearchWithIS[B|S]NVariations breaks ISBN search in item search In-Reply-To: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33514-70-2eFIz280pm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33303 CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 09:46:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 07:46:01 +0000 Subject: [Koha-bugs] [Bug 33303] Performance issues/timeouts in item search In-Reply-To: <bug-33303-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33303-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33303-70-GxHPT5HXXe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33303 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33514 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 09:50:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 07:50:28 +0000 Subject: [Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories In-Reply-To: <bug-33776-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33776-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33776-70-5cFDhsRPLm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Depends on| |23975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 [Bug 23975] Add ability to search and install plugins from GitHub -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 09:50:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 07:50:28 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23975-70-qclg90FDoL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33776 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776 [Bug 33776] Add inLibro in default plugin repositories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 10:46:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 08:46:09 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-2LB5jQ69L7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151571|0 |1 is obsolete| | --- Comment #81 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151611&action=edit Bug 30719: DB and API - Adds 'batch' accessor to Illrequest object - New illbatches and illbatch_statuses tables - New foreign key 'batch_id' in illrequests table - Atomic update file - Default illbatch_statuses - Add 'add' ill_requests api method - Add POST method in ill_requests path - Add 'batch_id property to ill_request api definition - Updated swagger.yml with new batches and batchstatuses endpoints Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller at ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 10:46:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 08:46:13 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-uosOGfagK6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151572|0 |1 is obsolete| | --- Comment #82 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151612&action=edit Bug 30719: ILL Batches - Add batch column to requests table - Establish if there are any availability or metadata enrichment plugins and pass that to the template - Verify if we have any backend that can support batches, if not, don't show the option - Updates to the ILL toolbar - New ILL batch modal - New Koha classes - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller at ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 10:46:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 08:46:16 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-9nV9Zf43Jm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151573|0 |1 is obsolete| | --- Comment #83 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151613&action=edit Bug 30719: ILL Batch Statuses - UI adding support for batch statuses in batch UI - Admin UI for managing batch statuses - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller at ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 10:46:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 08:46:20 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-ppNTN6off2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151574|0 |1 is obsolete| | --- Comment #84 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151614&action=edit Bug 30719: Tests Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller at ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 10:46:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 08:46:23 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-qc7fc7IrMM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151575|0 |1 is obsolete| | --- Comment #85 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151615&action=edit Bug 30719: dbic specific, DONT PUSH Signed-off-by: Edith Speller <Edith.Speller at ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 10:48:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 08:48:10 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-G0Ay1HJqqF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #86 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- rebased after bug 33762 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 10:54:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 08:54:31 +0000 Subject: [Koha-bugs] [Bug 33817] New: Composition or an item bundle can be changed Message-ID: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 Bug ID: 33817 Summary: Composition or an item bundle can be changed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 10:54:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 08:54:45 +0000 Subject: [Koha-bugs] [Bug 33817] Composition or an item bundle can be changed In-Reply-To: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33817-70-7xm7VZSZJm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 [Bug 28854] Add ability to create bundles of items for circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 10:54:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 08:54:45 +0000 Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28854-70-Jrh8m6I4gq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33817 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 [Bug 33817] Composition or an item bundle can be changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 10:54:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 08:54:53 +0000 Subject: [Koha-bugs] [Bug 31082] Add tooltip to buttons when item bundles cannot be changed while checked out In-Reply-To: <bug-31082-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31082-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31082-70-bKJaLksY4H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31082 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Depends on|28854 |33817 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 [Bug 28854] Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 [Bug 33817] Composition or an item bundle can be changed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 10:54:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 08:54:53 +0000 Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28854-70-1CCptXKUeQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31082 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31082 [Bug 31082] Add tooltip to buttons when item bundles cannot be changed while checked out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 10:54:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 08:54:53 +0000 Subject: [Koha-bugs] [Bug 33817] Composition or an item bundle can be changed In-Reply-To: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33817-70-838YGta6IW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31082 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31082 [Bug 31082] Add tooltip to buttons when item bundles cannot be changed while checked out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 10:55:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 08:55:05 +0000 Subject: [Koha-bugs] [Bug 31082] Add tooltip to buttons when item bundles cannot be changed while checked out In-Reply-To: <bug-31082-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31082-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31082-70-1PXT2zAyd5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31082 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |unspecified -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 11:19:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 09:19:51 +0000 Subject: [Koha-bugs] [Bug 33813] Accessibility: Lists button is not clearly identified In-Reply-To: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33813-70-D270PzRBXG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33813 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151595|0 |1 is obsolete| | --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151616&action=edit Bug 33813: Masthead lists button requires an aria-label This patch adds an aria-label to the Lists button in the masthead. It is currently not descriptive enough and doesn't identify what is displayed when clicking the button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 11:20:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 09:20:18 +0000 Subject: [Koha-bugs] [Bug 33813] Accessibility: Lists button is not clearly identified In-Reply-To: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33813-70-VmVYlPUEAD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33813 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Thanks for the input everyone, I've updated the patch accordingly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 11:24:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 09:24:42 +0000 Subject: [Koha-bugs] [Bug 33808] Accessibility: Non-descriptive links In-Reply-To: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33808-70-IF4LlpF6OW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151567|0 |1 is obsolete| | --- Comment #9 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151617&action=edit Bug 33808: Add aria-labels in reports-toolbar.inc This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 11:25:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 09:25:22 +0000 Subject: [Koha-bugs] [Bug 33808] Accessibility: Non-descriptive links In-Reply-To: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33808-70-9MTmkzgZwI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Thanks Owen, I've updated the patch as suggested :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 11:34:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 09:34:04 +0000 Subject: [Koha-bugs] [Bug 33810] Accessibility: OPAC Advanced Search fields are not labelled In-Reply-To: <bug-33810-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33810-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33810-70-zj6WunNDA9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151577|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151618&action=edit Bug 33810: Opac advanced search fields need aria-labels The OPAC advanced search fields need aria-labels to assist with screen reading. This patch adds labels to both the dropdown selects and the text inputs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 11:35:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 09:35:29 +0000 Subject: [Koha-bugs] [Bug 33810] Accessibility: OPAC Advanced Search fields are not labelled In-Reply-To: <bug-33810-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33810-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33810-70-0gKRcZYCaJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Thanks Owen, I've updated the patch. For the "More Options" fields, all of those dropdowns already have labels with a "for" attribute so I don't think they are currently an issue for screen reading. Unless you want some aria-labels with more specific descriptions? let me know and I can take a look -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 11:43:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 09:43:08 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-PPxQR8cVKx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 11:43:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 09:43:10 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-3dsBfwHXEF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151550|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 151619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151619&action=edit Bug 28130: Manage a patron's subscription alerts This enhancement adds an 'Alert subscriptions' page to a patron account to easily view or cancel email alerts the patron has subscribed to. To test: 1. Go to Cataloging. Create a biblio. 2. Go to Tools -> Notices & slips. Create a notice under the "Serials (new issue)" module, if you don't already have one. 3. Go to Serials. Create a subscription. Link the biblio you just created. Add info like the callnumber, location, library. Choose your notice under Patron notification. Fill out the remaining details and save your subscription. 4. Open this record in the OPAC. Under the Subscriptions tab, click the button to "Subscribe to email notification on new issues" 5. Go back to the staff interface. Go to your patron account. 6. Notice there is a new "Alert subscriptions" tab in the left sidebar menu. The number in brackets should say 1, for the subscription you just enabled email alerts. 7. Click into the page. Confirm your subscription shows in the table. 8. Click the button to unsubscribe. A confirmation should pop up. Confirm you can cancel the unsubscribe action. Then confirm you can unsubscribe using this button. 9. Confirm tests pass t/db_dependent/Koha/Patron.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 11:44:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 09:44:10 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-LYpFWizRUM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds an release notes| |'Alert subscriptions' page | |to a patron account to | |easily view or cancel email | |alerts the patron has | |enabled for subscriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 12:13:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 10:13:49 +0000 Subject: [Koha-bugs] [Bug 33813] Accessibility: Lists button is not clearly identified In-Reply-To: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33813-70-VQVHcS2wr3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33813 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 12:13:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 10:13:51 +0000 Subject: [Koha-bugs] [Bug 33813] Accessibility: Lists button is not clearly identified In-Reply-To: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33813-70-xGxPTfL6dT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33813 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151616|0 |1 is obsolete| | --- Comment #7 from David Nind <david at davidnind.com> --- Created attachment 151620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151620&action=edit Bug 33813: Masthead lists button requires an aria-label This patch adds an aria-label to the Lists button in the masthead. It is currently not descriptive enough and doesn't identify what is displayed when clicking the button. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 12:46:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 10:46:31 +0000 Subject: [Koha-bugs] [Bug 33808] Accessibility: Non-descriptive links In-Reply-To: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33808-70-R88eovBZP0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 12:46:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 10:46:33 +0000 Subject: [Koha-bugs] [Bug 33808] Accessibility: Non-descriptive links In-Reply-To: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33808-70-aoPk4KkB0C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33808 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151617|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151621&action=edit Bug 33808: Add aria-labels in reports-toolbar.inc This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 12:46:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 10:46:48 +0000 Subject: [Koha-bugs] [Bug 26611] Required match checks don't work for authority records In-Reply-To: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26611-70-KyaaNgjj2K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 12:46:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 10:46:50 +0000 Subject: [Koha-bugs] [Bug 26611] Required match checks don't work for authority records In-Reply-To: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26611-70-P7o3JS4fNu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151608|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151622&action=edit Bug 26611: Make authority record matching use required match checks This patch fixes record matching for authorities to correctly apply required match checks. To test: 1) Create a record matching rule: Threshold: 100 Record type: Authority record Match point 1 Search index: subject-topical Score: 100 Tag: 150 Subfields: a Match check 1 Both source and target record check fields: Tag: 040 Subfields: a This rule says we want to match on the topical term heading, then confirm the match with 040$a. 2) Create two topical term authority records Authority 1: 150$a: Test 040$a: A Authority 2: 150$a: Test 040$a: B 3) Export authority 2 and save 4) Go to Cataloging -> Stage records for import 5) Upload your downloaded authority 2 file. Change the record type to Authority. Choose your new record matching rule. 6) Stage for import. 7) Confirm that with the record matching rule applied, both authorities 1 and 2 show as possible matches, even though only authority 2 has a matching 040$a. 8) Apply the patch and restart services 9) Change the matching rule to "Do not look for matching records" and apply. This is to essentially refresh the page. 10) Change the matching rule to your new matching rule and apply. Confirm only the matching authority 2 shows and is selected. Sponsored-by: Waikato Institute of Technology Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 12:47:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 10:47:58 +0000 Subject: [Koha-bugs] [Bug 26611] Required match checks don't work for authority records In-Reply-To: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26611-70-P3gqGGQldo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Note: I had to change 'subject-topical' to 'Heading-Main' for the matching to work This code could really use unit tests, but this patch is mostly a copy from the existing biblio code, and fixes a long standing bug - PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 12:48:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 10:48:04 +0000 Subject: [Koha-bugs] [Bug 26611] Required match checks don't work for authority records In-Reply-To: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26611-70-gQpy0tq3LZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 12:59:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 10:59:27 +0000 Subject: [Koha-bugs] [Bug 33817] Composition of an item bundle can be changed In-Reply-To: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33817-70-PBRz4nl26r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Composition or an item |Composition of an item |bundle can be changed |bundle can be changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 13:14:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 11:14:09 +0000 Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28854-70-86B1IDybGB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #515 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Martin Renvoize from comment #269) > (In reply to Katrin Fischer from comment #224) > > d) Should we be able to change contents of a bundle while it is checked out? > > At the moment it's possible. Maybe a 'safety question'? (question/suggestion) > > Fixed in follow-up. This is not working, there is some code in the template to disable the buttons but it does not work. I have a patch to fix it, but I am wondering if it is correct to disable the edition of a bundle item that is checked out. There is no code server-side to prevent that (and so it's currently possible). Should we fix or remove this restriction? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 13:15:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 11:15:06 +0000 Subject: [Koha-bugs] [Bug 33817] Composition of an item bundle can be changed if checked out In-Reply-To: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33817-70-pcUCAlPBE2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Composition of an item |Composition of an item |bundle can be changed |bundle can be changed if | |checked out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 13:15:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 11:15:17 +0000 Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28854-70-1lUWnLJ3oq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #516 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #515) > (In reply to Martin Renvoize from comment #269) > > (In reply to Katrin Fischer from comment #224) > > > d) Should we be able to change contents of a bundle while it is checked out? > > > At the moment it's possible. Maybe a 'safety question'? (question/suggestion) > > > > Fixed in follow-up. > > This is not working, there is some code in the template to disable the > buttons but it does not work. I have a patch to fix it, but I am wondering > if it is correct to disable the edition of a bundle item that is checked out. > > There is no code server-side to prevent that (and so it's currently > possible). > > Should we fix or remove this restriction? See bug 33817. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 13:15:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 11:15:51 +0000 Subject: [Koha-bugs] [Bug 33817] Composition of an item bundle can be changed if checked out In-Reply-To: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33817-70-GjYNJRozdd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- >From bug 28854 comment 515 (In reply to Martin Renvoize from comment #269) > (In reply to Katrin Fischer from comment #224) > > d) Should we be able to change contents of a bundle while it is checked out? > > At the moment it's possible. Maybe a 'safety question'? (question/suggestion) > > Fixed in follow-up. This is not working, there is some code in the template to disable the buttons but it does not work. I have a patch to fix it, but I am wondering if it is correct to disable the edition of a bundle item that is checked out. There is no code server-side to prevent that (and so it's currently possible). Should we fix or remove this restriction? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 13:16:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 11:16:36 +0000 Subject: [Koha-bugs] [Bug 33817] Composition of an item bundle can be changed if checked out In-Reply-To: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33817-70-iULw1EKdrR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151623&action=edit Bug 33817: Prevent item bundle that is checked out to be modified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 13:18:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 11:18:54 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-CjxABT7G1n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33817 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 [Bug 33817] Composition of an item bundle can be changed if checked out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 13:18:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 11:18:54 +0000 Subject: [Koha-bugs] [Bug 33817] Composition of an item bundle can be changed if checked out In-Reply-To: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33817-70-a29t6WSuN3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the biblio detail view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 13:23:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 11:23:43 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-gq8zm47nI6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 13:23:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 11:23:45 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-cGGlQV5AUy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151510|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151624&action=edit Bug 33404: (bug 19436 follow-up) Save the original encoded record This patch restores previous behavior of storing the record as received from the source with the original encoding. We store the encoding in the DB as well, but save the record converted to UTF8 - this means that when we try to display and convert to UTF8 again, we mangle the record While providing a test plan, it requires a MARC8 Authority source, and I cannot locate an open one. This change can be verified by reading the code. There are no unit tests for Z3950SearchAuth, but it does too much and requires many mocks, this is a small fix to a reversion and should be able to move forward. To test: 1 - Search a Z39 authority server that has MARC8 (or non utf8) records 2 - Find a record with diacritics in the record 3 - Import it 4 - Note diacritics are mangled 5 - Apply patch, restart_all 6 - Perform a new Z3950 search (to ensure record is not already in reservoir) 7 - Find a record with diacritics 8 - Import it 9 - Note diacritics correctly encoded -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 13:23:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 11:23:49 +0000 Subject: [Koha-bugs] [Bug 33817] Composition of an item bundle can be changed if checked out In-Reply-To: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33817-70-6kIEFSC13Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- >From IRC we came to the conclusion: * Bundles should not be editable whilst checked out (Removing and Adding should both be blocked at client and server side) * Items should not be available for adding to a bundle when they are individually checked out (Again, this should be blocked at both the client and the server). The real world idea of this was that you physically had a 'box' you were packing your items into to create the bundle.. you scan your items into the box and out of the box.. thus they should physically be there. We then track their presence at the checkin/checkout actions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 13:24:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 11:24:02 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-im1pEjmrIU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 13:24:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 11:24:21 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-4A367UBbT5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 --- Comment #9 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151625&action=edit Bug 33579: [21.11.x] Typo: record record To reproduce: - Search for records - Select two or more records - Select "Edit" > "Batch delete records" - Click "Delete selcted records" - Click "View detail of the enqueued job" - Verify the page says "Type: Batch bibliographic record record deletion" To test: - Repeat the steps above - The page should now say "Type: Batch bibliographic record deletion" Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 13:24:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 11:24:41 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-1ZrrjwxIT3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 13:24:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 11:24:50 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-kmebX5OTwR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 13:24:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 11:24:59 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-ni6ydWHMW4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 13:28:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 11:28:05 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-k3UQe6A91E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #5) > The changes do not look good to me. We should not save in other encodings. > Everywhere we convert to UTF-8. Here we should too. I am happy to go this direction if preferred (In reply to Marcel de Rooy from comment #4) > $marcdata is no marc record ! It is a marc blob. > > How did you manage to test it? I forgot to commit changes after testing :-) New patch retested and verified against OCLC MARC8 records (In reply to Marcel de Rooy from comment #6) > (In reply to Nick Clemens from comment #1) > > While providing a test plan, it requires a MARC8 Authority source, and I > > cannot locate > > an open one. This change can be verified by reading the code. > > This sounds problematic. If you can find a source I would appreciate it > > There are no unit tests for Z3950SearchAuth, but it does too much and > > requires many mocks, > > this is a small fix to a reversion and should be able to move forward. > > And this too :) Yes, but we should not allow bugs to remain when we have a fix, but not the time to pay technical debts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 13:38:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 11:38:18 +0000 Subject: [Koha-bugs] [Bug 33514] SearchWithIS[B|S]NVariations breaks ISBN search in item search In-Reply-To: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33514-70-lPmIHv3ABF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Katrin Fischer from comment #2) > I am not sure what the best solution here is: What about making sure that normalized strings are always stored on the DB? (i.e. no spaces, no symbols). It feels like GetVariationsOfISBN might be too much in my opinion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:00:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 13:00:31 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-ItngRMCUgI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 Christian Stelzenmüller <christian.stelzenmueller at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller at bs | |z-bw.de Status|Needs Signoff |Failed QA --- Comment #4 from Christian Stelzenmüller <christian.stelzenmueller at bsz-bw.de> --- An error occurs when trying to open a sandbox with the enhancement. Part of the error trace says: "Error trace Could not mkdir /tmp/cgi_compile_22068: No space left on device at /usr/share/perl5/CGI/Compile.pm line 195 1. in CGI::Compile::_eval at /usr/share/perl5/CGI/Compile.pm line 195 2. 192: $tmp_dir ||= File::Spec->catfile(File::Spec->tmpdir, "cgi_compile_$$"); 3. 193: 4. 194: if (! -d $tmp_dir) { 5. 195: mkdir $tmp_dir or die "Could not mkdir $tmp_dir: $!"; 6. 196: chmod 0700, $tmp_dir or die "Could not chmod 0700 $tmp_dir: $!"; 7. 197: } 8. 198: " I could send the complete error trace if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:22:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 13:22:15 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-KFSr58Gre7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #13) > Remaining TODOs: > * bundles of items (display the 'Manage bundle' button) Done in Bug 33568: Restore bundle items > * host records Done in Bug 33568: Restore host records > * analytic Done in Bug 33568: Restore analytics Remaning TODOs: * Display the library name of the patron "A patron from LIBRARY NAME" if the patron's data must be hidden. This is related to bug 29523. * Fix bug 33817 * Fix bug 33804 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:23:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 13:23:03 +0000 Subject: [Koha-bugs] [Bug 33784] Single receive - clicking the Receive link in parcel.pl should lead to the receive form In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-RL04IOZq51@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:23:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 13:23:04 +0000 Subject: [Koha-bugs] [Bug 33784] Single receive - clicking the Receive link in parcel.pl should lead to the receive form In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-qbJk3LYdAL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151552|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:23:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 13:23:24 +0000 Subject: [Koha-bugs] [Bug 33784] Single receive - clicking the Receive link in parcel.pl should lead to the receive form In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-Wsh7RJxuVq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151626&action=edit Bug 33784: Don't display the multi receive form for single receive With bug 8179, a new step was added when receiving a single item. This extra step is not useful and adds clicks for the staff member who is receiving orders. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:23:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 13:23:27 +0000 Subject: [Koha-bugs] [Bug 33784] Single receive - clicking the Receive link in parcel.pl should lead to the receive form In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-I8fTpUZxHZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151627&action=edit Bug 33784: Make buttons more meaningful This patch makes dismissing the modal equivalent to cancelling the receipt and thus returning to parcel.pl. The 'Save' button is renamed to 'Confirm' and is disabled when no items are selected for receiving. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:31:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 13:31:02 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-8cMoeCB9WE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 --- Comment #5 from Christian Stelzenmüller <christian.stelzenmueller at bsz-bw.de> --- I'm sorry that was a sandbox issue. The enhancement works fine. But it's for the staff client. First of all, we would like to have it for the patron itself, in hers or his account in the opac. Besides that, it looks fine to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:33:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 13:33:44 +0000 Subject: [Koha-bugs] [Bug 33784] Single receive - clicking the Receive link in parcel.pl should lead to the receive form In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-hLw0Pbe5jN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151627|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151628&action=edit Bug 33784: Make buttons more meaningful This patch makes dismissing the modal equivalent to cancelling the receipt and thus returning to parcel.pl. The 'Save' button is renamed to 'Confirm' and is disabled when no items are selected for receiving. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:35:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 13:35:21 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-XszxYAei0f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:35:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 13:35:54 +0000 Subject: [Koha-bugs] [Bug 33784] Save clicks on single order receive In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-LuPcPVkLUM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Single receive - clicking |Save clicks on single order |the Receive link in |receive |parcel.pl should lead to | |the receive form | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:36:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 13:36:02 +0000 Subject: [Koha-bugs] [Bug 33784] Save clicks on single order receive In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-GQH0RZx8xA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:40:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 13:40:33 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: <bug-15278-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15278-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15278-70-TkXDIk9eIh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- I would love to see this get back on the roadmap, perhaps for 23.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:40:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 13:40:45 +0000 Subject: [Koha-bugs] [Bug 33784] Save clicks on single order receive In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-dYZV1OmaAO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:40:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 13:40:48 +0000 Subject: [Koha-bugs] [Bug 33784] Save clicks on single order receive In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-1bS4Tc0YpU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151626|0 |1 is obsolete| | Attachment #151628|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151629&action=edit Bug 33784: Don't display the multi receive form for single receive With bug 8179, a new step was added when receiving a single item. This extra step is not useful and adds clicks for the staff member who is receiving orders. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:40:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 13:40:51 +0000 Subject: [Koha-bugs] [Bug 33784] Save clicks on single order receive In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-dW4Zx9fRDT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151630&action=edit Bug 33784: Make buttons more meaningful This patch makes dismissing the modal equivalent to cancelling the receipt and thus returning to parcel.pl. The 'Save' button is renamed to 'Confirm' and is disabled when no items are selected for receiving. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:41:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 13:41:01 +0000 Subject: [Koha-bugs] [Bug 33784] Save clicks on single order receive In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-DrUH5MIFaf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:44:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 13:44:33 +0000 Subject: [Koha-bugs] [Bug 33813] Accessibility: Lists button is not clearly identified In-Reply-To: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33813-70-gYmkRcezIo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33813 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:44:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 13:44:35 +0000 Subject: [Koha-bugs] [Bug 33813] Accessibility: Lists button is not clearly identified In-Reply-To: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33813-70-ev3N2rAjO3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33813 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151620|0 |1 is obsolete| | --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151631&action=edit Bug 33813: Masthead lists button requires an aria-label This patch adds an aria-label to the Lists button in the masthead. It is currently not descriptive enough and doesn't identify what is displayed when clicking the button. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 15:45:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 13:45:18 +0000 Subject: [Koha-bugs] [Bug 27496] Accessibility: Navigation buttons are poorly described by screen readers In-Reply-To: <bug-27496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27496-70-WRlqfkdWWX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27496 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:22:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:22:23 +0000 Subject: [Koha-bugs] [Bug 26611] Required match checks don't work for authority records In-Reply-To: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26611-70-vIe7AKhKNW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:22:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:22:25 +0000 Subject: [Koha-bugs] [Bug 26611] Required match checks don't work for authority records In-Reply-To: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26611-70-H3BiifKjIW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:22:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:22:27 +0000 Subject: [Koha-bugs] [Bug 33362] Return claims can be un-resolvable if issue_id is set but no issue is found in issues or old_issues In-Reply-To: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33362-70-3FudDbrGS0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33362 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:22:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:22:29 +0000 Subject: [Koha-bugs] [Bug 33362] Return claims can be un-resolvable if issue_id is set but no issue is found in issues or old_issues In-Reply-To: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33362-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33362-70-ArOsJvWE8G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33362 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:22:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:22:31 +0000 Subject: [Koha-bugs] [Bug 33784] Save clicks on single order receive In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-xj3pEoF8yM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:22:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:22:33 +0000 Subject: [Koha-bugs] [Bug 33784] Save clicks on single order receive In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-kpI4pN4TEY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:34:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:34:00 +0000 Subject: [Koha-bugs] [Bug 14250] Can generate discharge for patrons with fines In-Reply-To: <bug-14250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14250-70-hp3FMv0PAk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Still valid in master (22.12.00.048) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:50:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:50:12 +0000 Subject: [Koha-bugs] [Bug 33818] New: Accessibility: Non descriptive title on ISBD detail Message-ID: <bug-33818-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33818 Bug ID: 33818 Summary: Accessibility: Non descriptive title on ISBD detail Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: matt.blenkinsop at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The page title for the ISBD detail viewer on the OPAC has been flagged as not descriptive enough by the Shaw Trust in an accessibility report for the British Museum. The item title needs adding as in the Normal and MARC views to make it clearer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:50:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:50:44 +0000 Subject: [Koha-bugs] [Bug 33818] Accessibility: Non descriptive title on ISBD detail In-Reply-To: <bug-33818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33818-70-7YGWIa7z00@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33818 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25243 Assignee|oleonard at myacpl.org |matt.blenkinsop at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25243 [Bug 25243] Accessibility: 2.4.6 Headings and Labels -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:50:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:50:44 +0000 Subject: [Koha-bugs] [Bug 25243] Accessibility: 2.4.6 Headings and Labels In-Reply-To: <bug-25243-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25243-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25243-70-eBI9bfBtZp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25243 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33818 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33818 [Bug 33818] Accessibility: Non descriptive title on ISBD detail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:52:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:52:28 +0000 Subject: [Koha-bugs] [Bug 33818] Accessibility: Non descriptive title on ISBD detail In-Reply-To: <bug-33818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33818-70-kE5irjEYyh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33818 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151632&action=edit Bug 33818: Descriptive title added to opac-ISBDdetail.tt This patch adds the biblio.title to the breadcrumb for the ISBD viewer. This now matches the normal and MARC views and is much clearer for screen readers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:52:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:52:41 +0000 Subject: [Koha-bugs] [Bug 33818] Accessibility: Non descriptive title on ISBD detail In-Reply-To: <bug-33818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33818-70-D8CeLDdt8Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33818 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:54:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:54:53 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-funUcwusbo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:54:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:54:55 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-0AkjFrTbvn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151609|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:54:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:54:57 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-PUQjE4SVID@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151610|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:55:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:55:19 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-q05GXTyIDv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:55:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:55:36 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-Dovokfg88S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151633&action=edit Bug 33815: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:55:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:55:38 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-V04OEPZ83w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151634&action=edit Bug 33815: Do not explode if logged in user modify their own userid If the logged in librarian modifies their own userid they will get the following error when submitting the form: Can't call method "password_expired" on an undefined value at /kohadevbox/koha/C4/Auth.pm line 1780 We could handle this situation and flag the session as expired. Better would be to deal with this specific user case and update the cookie (?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:55:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:55:41 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-YkbLdvt2Qs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151635&action=edit Bug 33815: Add a hint on the patron edit form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:56:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:56:59 +0000 Subject: [Koha-bugs] [Bug 33819] New: Accessibility: More description required in opac search breadcrumbs Message-ID: <bug-33819-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33819 Bug ID: 33819 Summary: Accessibility: More description required in opac search breadcrumbs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: matt.blenkinsop at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org A report carried out for the British museum by the Shaw trust has identified that the "Search results for" breadcrumb on the opac search results page is not descriptive enough and should include the page number to assist screen readers with understanding the page content. Currently the breadcumb is the same on every page and it needs to be more unique to the page content. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:57:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:57:10 +0000 Subject: [Koha-bugs] [Bug 33819] Accessibility: More description required in opac search breadcrumbs In-Reply-To: <bug-33819-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33819-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33819-70-00StqI7e1c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33819 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25243 Assignee|oleonard at myacpl.org |matt.blenkinsop at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25243 [Bug 25243] Accessibility: 2.4.6 Headings and Labels -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:57:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:57:10 +0000 Subject: [Koha-bugs] [Bug 25243] Accessibility: 2.4.6 Headings and Labels In-Reply-To: <bug-25243-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25243-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25243-70-lWX9Kkqf2H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25243 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33819 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33819 [Bug 33819] Accessibility: More description required in opac search breadcrumbs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:57:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:57:39 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-DLuxFFjKE0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:58:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:58:55 +0000 Subject: [Koha-bugs] [Bug 33819] Accessibility: More description required in opac search breadcrumbs In-Reply-To: <bug-33819-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33819-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33819-70-FFT93ELyRO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33819 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151637&action=edit Bug 33819: Add page numbers to opac results breadcrumb This patch adds the page number to the breadcrumb in the opac search results to ensure that it is unique to the content on the page. Currently it is not compliant to Accessibility guidelines as the breadcrumb is identical on every page despite the content being different. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:58:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:58:55 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-CLUY9I6NLX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151636&action=edit Bug 33404: Alternative approach Work in progress -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 16:59:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 14:59:04 +0000 Subject: [Koha-bugs] [Bug 33819] Accessibility: More description required in opac search breadcrumbs In-Reply-To: <bug-33819-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33819-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33819-70-CRKSsoQf4N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33819 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:05:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:05:19 +0000 Subject: [Koha-bugs] [Bug 33820] New: Add hints to warn the librarian that they will be logged out if they change their username Message-ID: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Bug ID: 33820 Summary: Add hints to warn the librarian that they will be logged out if they change their username Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: rel_23_11_candidate Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org, gmcharlt at gmail.com, jonathan.druart+koha at gmail.com, kyle.m.hall at gmail.com, testopia at bugs.koha-community.org, tomascohen at gmail.com Depends on: 33815 Moving this aspect of Bug 33815 to its own bug: We should warn librarians that if they change their own username in the staff interface that they will be logged out. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 [Bug 33815] Crash when librarian changes their own username in the staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:05:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:05:19 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-DdrFYfCI0W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33820 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 [Bug 33820] Add hints to warn the librarian that they will be logged out if they change their username -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:05:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:05:45 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-G5xYDimxxS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151635|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:08:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:08:39 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: <bug-14251-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14251-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14251-70-bZMuyQgqJI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #39 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Seems like back end stuff. I still reviewed the discharge sections in the manual to at least update the screenshots... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:08:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:08:40 +0000 Subject: [Koha-bugs] [Bug 32892] Email template used when generating DISCHARGE PDF In-Reply-To: <bug-32892-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32892-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32892-70-4Kim4KQ9C1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32892 Bug 32892 depends on bug 14251, which changed state. Bug 14251 Summary: Allow use of CSS in discharge letter https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:09:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:09:39 +0000 Subject: [Koha-bugs] [Bug 26554] allow news tag in all slips In-Reply-To: <bug-26554-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26554-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26554-70-5jSpkxy7B6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26554 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:12:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:12:22 +0000 Subject: [Koha-bugs] [Bug 33821] New: OPAC flatpickr no longer allows for direct input of date Message-ID: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33821 Bug ID: 33821 Summary: OPAC flatpickr no longer allows for direct input of date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: lucas at bywatersolutions.com Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 30718 took away the ability to direct enter dates with flatpickr ( allowInput ) Some libraries find that problematic and would like patrons to be able to directly type in a date. Example: self registration. We should give that option back. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:14:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:14:38 +0000 Subject: [Koha-bugs] [Bug 33821] OPAC flatpickr no longer allows for direct input of date In-Reply-To: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33821-70-oKsl8gtwbu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33821 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:14:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:14:40 +0000 Subject: [Koha-bugs] [Bug 33821] OPAC flatpickr no longer allows for direct input of date In-Reply-To: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33821-70-g5GbdT9O7v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33821 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151638&action=edit Bug 33821: Allow direct input of dates on the OPAC To test: 1. Apply patch 2. Go to OPAC self registration and try to manually enter the date for date of birth. 3. You can do so sucessfully -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:17:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:17:30 +0000 Subject: [Koha-bugs] [Bug 33821] OPAC flatpickr no longer allows for direct input of date In-Reply-To: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33821-70-zBj9ig1zKn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33821 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30718 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 [Bug 30718] Use flatpickr's altInput option everywhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:17:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:17:30 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30718-70-ApeV9Ot5oO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33821 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33821 [Bug 33821] OPAC flatpickr no longer allows for direct input of date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:25:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:25:20 +0000 Subject: [Koha-bugs] [Bug 33820] Add hints to warn the librarian that they will be logged out if they change their username In-Reply-To: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33820-70-EtA1NE7H8I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:25:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:25:22 +0000 Subject: [Koha-bugs] [Bug 33820] Add hints to warn the librarian that they will be logged out if they change their username In-Reply-To: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33820-70-pEfvWWlme2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151639&action=edit Bug 33820: Add hints to warn the librarian that they will be logged out if they change their username This patch adds some JavaScript to the patron entry form which adds a hint if the logged-in librarian tries to change their own username. It warns them that they will be logged out. To test, apply the patch and log into the staff interface. - Locate and edit your own patron record. - In the "OPAC/Staff interface login" section, change the value in the username field. When focus leaves that form field a hint should appear, "You will be logged out if you modify your username." - Change the username field back to your original username. The hint should disappear. - Confirm that submitting a username change works correctly: You should be logged out, and when you log in again your username should be updated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:25:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:25:25 +0000 Subject: [Koha-bugs] [Bug 33820] Add hints to warn the librarian that they will be logged out if they change their username In-Reply-To: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33820-70-BXNTvyCGVK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151640&action=edit Bug 33820: (follow-up) Add hint to member-password.tt This follow-up makes the same change to the "Change password" template. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:30:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:30:46 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-nplDOiQ2RO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151624|0 |1 is obsolete| | Attachment #151636|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151641&action=edit Bug 33404: Alternative approach Work in progress Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:31:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:31:51 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-6dombXCWE8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151633|0 |1 is obsolete| | Attachment #151634|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151642&action=edit Bug 33815: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:31:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:31:54 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-Kf3HH8VooA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 --- Comment #9 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151643&action=edit Bug 33815: Do not explode if logged in user modify their own userid If the logged in librarian modifies their own userid they will get the following error when submitting the form: Can't call method "password_expired" on an undefined value at /kohadevbox/koha/C4/Auth.pm line 1780 We could handle this situation and flag the session as expired. Better would be to deal with this specific user case and update the cookie (?) Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:32:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:32:07 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-WcZLkEql7Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- This (In reply to Marcel de Rooy from comment #9) > Created attachment 151636 [details] [review] > Bug 33404: Alternative approach > > Work in progress This works better - sometimes mine worked, and then sometimes I was losing the heading fields, not sure why. I would attach a sample MARC-8 - but I can't get one out of the system without it being mangled - I exported the record I used for testing as marc 8 and will attach if that helps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:32:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:32:57 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-6lQZdGvO6E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151644&action=edit Sample record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:52:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:52:02 +0000 Subject: [Koha-bugs] [Bug 33822] New: Update variable picker to insert TT variables Message-ID: <bug-33822-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33822 Bug ID: 33822 Summary: Update variable picker to insert TT variables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The variable picker tool in notices still inserts <<>> type variables.. we should really be encouraging the use of TT now and instead insert [% %] type variables. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:52:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:52:19 +0000 Subject: [Koha-bugs] [Bug 33822] Update variable picker to insert TT variables In-Reply-To: <bug-33822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33822-70-trC1PckKm1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:52:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:52:19 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: <bug-15278-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15278-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15278-70-zmRh2bztyj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33822 [Bug 33822] Update variable picker to insert TT variables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:53:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:53:33 +0000 Subject: [Koha-bugs] [Bug 33823] New: KohaTable vue component action buttons spacing differ from kohaTable Message-ID: <bug-33823-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33823 Bug ID: 33823 Summary: KohaTable vue component action buttons spacing differ from kohaTable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: pedro.amorim at ptfs-europe.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, matt.blenkinsop at ptfs-europe.com, pedro.amorim at ptfs-europe.com minor and trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:54:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:54:04 +0000 Subject: [Koha-bugs] [Bug 33823] KohaTable vue component action buttons spacing differ from kohaTable In-Reply-To: <bug-33823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33823-70-PkHMT0gv5f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33823 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:54:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:54:07 +0000 Subject: [Koha-bugs] [Bug 33823] KohaTable vue component action buttons spacing differ from kohaTable In-Reply-To: <bug-33823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33823-70-o0VsAown7Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33823 --- Comment #1 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151645&action=edit Bug 33823: Add spacing to action labels -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:54:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:54:43 +0000 Subject: [Koha-bugs] [Bug 15277] Add Template Toolkit syntax for slips and notices to editor In-Reply-To: <bug-15277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15277-70-2kXyx7nsOV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15277 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Depends on| |33822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33822 [Bug 33822] Update variable picker to insert TT variables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:54:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:54:43 +0000 Subject: [Koha-bugs] [Bug 33822] Update variable picker to insert TT variables In-Reply-To: <bug-33822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33822-70-lbJuKlgv4u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15277 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15277 [Bug 15277] Add Template Toolkit syntax for slips and notices to editor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:58:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:58:41 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: <bug-14251-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14251-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14251-70-3oj63BpM2u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |With this patch, it is now release notes| |possible to add CSS | |formatting to the discharge | |letter. CSS styling can be | |added directly in the | |DISCHARGE letter in the | |Notices and slips tool. The | |CSS stylesheet added in the | |NoticeCSS system preference | |will also be applied to the | |discharge PDF. | | | |Note that | |the discharge functionality | |now requires the weasyprint | |module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:59:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:59:37 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: <bug-15278-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15278-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15278-70-rIcn2jqMVb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26746 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26746 [Bug 26746] Variables available for selecting into notices are misleading -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:59:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:59:37 +0000 Subject: [Koha-bugs] [Bug 26746] Variables available for selecting into notices are misleading In-Reply-To: <bug-26746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26746-70-7HtOzzgiTL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26746 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:59:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:59:53 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: <bug-15278-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15278-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15278-70-02MD4jfNx2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31510 [Bug 31510] The notice template tag helper still uses <<>> sytnax.. we should move to TT instead -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 17:59:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 15:59:53 +0000 Subject: [Koha-bugs] [Bug 31510] The notice template tag helper still uses <<>> sytnax.. we should move to TT instead In-Reply-To: <bug-31510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31510-70-xyvlTC7yIC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31510 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:00:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:00:14 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-rE7hjqLAai@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- The problem is that the form expects you to enter a value - if you don't we don't fire an event to update the table rows, which are considered the source of truth. We need some way to check the form values when 'Save changes' is clicked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:00:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:00:18 +0000 Subject: [Koha-bugs] [Bug 33822] Update variable picker to insert TT variables In-Reply-To: <bug-33822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33822-70-5IL1QzCkKf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 31510 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:00:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:00:18 +0000 Subject: [Koha-bugs] [Bug 31510] The notice template tag helper still uses <<>> sytnax.. we should move to TT instead In-Reply-To: <bug-31510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31510-70-QkY20t3y5H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31510 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** Bug 33822 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:00:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:00:18 +0000 Subject: [Koha-bugs] [Bug 15277] Add Template Toolkit syntax for slips and notices to editor In-Reply-To: <bug-15277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15277-70-VsPue7VSXs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15277 Bug 15277 depends on bug 33822, which changed state. Bug 33822 Summary: Update variable picker to insert TT variables https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33822 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:00:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:00:19 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: <bug-15278-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15278-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15278-70-Cp5mlSCEzv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Bug 15278 depends on bug 33822, which changed state. Bug 33822 Summary: Update variable picker to insert TT variables https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33822 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:02:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:02:36 +0000 Subject: [Koha-bugs] [Bug 33824] New: The picker should be re-worked to expose relation accessors and then fields from the related objects. Message-ID: <bug-33824-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33824 Bug ID: 33824 Summary: The picker should be re-worked to expose relation accessors and then fields from the related objects. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org We should be able to dynamically expose different options for template variables available to us in the TT notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:02:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:02:52 +0000 Subject: [Koha-bugs] [Bug 33824] The picker should be re-worked to expose relation accessors and then fields from the related objects. In-Reply-To: <bug-33824-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33824-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33824-70-BIaKjDilqn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33824 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31510 [Bug 31510] The notice template tag helper still uses <<>> sytnax.. we should move to TT instead -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:02:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:02:52 +0000 Subject: [Koha-bugs] [Bug 31510] The notice template tag helper still uses <<>> sytnax.. we should move to TT instead In-Reply-To: <bug-31510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31510-70-wkVxo6bxsQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31510 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33824 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33824 [Bug 33824] The picker should be re-worked to expose relation accessors and then fields from the related objects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:05:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:05:42 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: <bug-15278-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15278-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15278-70-AeN3xSQMwY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 --- Comment #8 from George Williams (NEKLS) <george at nekls.org> --- (In reply to Katrin Fischer from comment #4) > On one condition: we should accompany porting by writing up Documentation > and improving the editor! I'd like to see this move forward again, too. The documentation part is really important for us librarians. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:05:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:05:58 +0000 Subject: [Koha-bugs] [Bug 29449] Show userid on "your personal details" tab In-Reply-To: <bug-29449-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29449-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29449-70-F8O11v1om7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Patrons can now see their release notes| |username in the 'Personal | |details' tab in the OPAC. | | | |This can be hidden from | |them using the | |PatronSelfModificationBorro | |werUnwantedField system | |preference, if needed. Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Seems like a bug fix. Nothing to add/amend in the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:07:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:07:17 +0000 Subject: [Koha-bugs] [Bug 33821] OPAC flatpickr no longer allows for direct input of date In-Reply-To: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33821-70-1OnFjVGzp3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33821 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151638|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 151646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151646&action=edit Bug 33821: Allow direct input of dates on the OPAC To test: 1. Apply patch 2. Go to OPAC self registration and try to manually enter the date for date of birth. 3. You can do so sucessfully Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:13:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:13:21 +0000 Subject: [Koha-bugs] [Bug 33823] KohaTable vue component action buttons spacing differ from kohaTable In-Reply-To: <bug-33823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33823-70-LfcvOMbEbB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33823 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha at gmail. |pedro.amorim at ptfs-europe.co |com |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:21:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:21:47 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-sI4dE764VQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |samalau at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:24:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:24:27 +0000 Subject: [Koha-bugs] [Bug 28011] Add CLI script to update bibs from linked authority records In-Reply-To: <bug-28011-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28011-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28011-70-dKe6VsohiA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28011 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- This looks interesting - would be nice if adapted to work with ES as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:25:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:25:43 +0000 Subject: [Koha-bugs] [Bug 33821] OPAC flatpickr no longer allows for direct input of date In-Reply-To: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33821-70-x4DXkBdZcw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33821 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #3 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- This worked perfectly. I was able to create a patron by manually entering a birthdate and by using the flatpickr calendar. When entering the dob manually it worked with the formats of 02/14/2023, 02-14-2023 and 02142023. While the flatpickr calendar works great for selecting dates in the staff interface, it is not patron-friendly for the purpose of entering birthdates in the self-registration form. Here is our experience as early adopters of 22.11: All of our patrons self-register for their library cards. We tasked some patrons to register for a new library card using the self-registration form. They did not find the flatpickr datepicker to be intuitive or simple for the purpose of quickly entering their birthdates. They did not understand why they couldn't type in the box and then their first reaction was to use the arrows to either cycle backward through the months or years (which would take a very long time for someone born in 1933) They didn't understand the concept of directly typing their birthyear in the flatpickr year box first, then selecting their month in order to get to the correct calendar for them to select their specific date of birth. That lead to frustration and once things didn't seem to be working for them they got frustrated and the self-reg form timed out on them which led to a negative customer experience. So I think that it is imperative that users be able to manually enter the birthdates. Additionally, it was possible to do so in 22.05 so this is a loss of functionality for our library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:29:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:29:28 +0000 Subject: [Koha-bugs] [Bug 32977] Add call number column to list of charges on transactions tab in patron account In-Reply-To: <bug-32977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32977-70-CWjJTmOoTz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32977 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/694 Text to go in the| |This enhancement adds the release notes| |item call number to the | |'transactions' and 'make a | |payment' tabs in the | |patron's account, if the | |charge is linked to a | |particular item. | | | |If | |needed, it is possible to | |hide this column by going | |to Administration > Table | |settings > Patrons > Page: | |fines > | |Table id: | |account-fines or | |Administration > Table | |settings > Patrons > Page: | |pay > Table id: | |pay-fines-table. Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:41:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:41:37 +0000 Subject: [Koha-bugs] [Bug 33554] searching borrowers is a lot slower if there's searchable extended attributes. In-Reply-To: <bug-33554-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33554-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33554-70-Bxg8EvZv3G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554 --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Would it be reasonable if making an attribute searchable didn't mean it was searched by default? i.e. we could add the attribute to the search dropdowns, or have an option on the attribute to include in searches by default -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:42:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:42:59 +0000 Subject: [Koha-bugs] [Bug 33573] Holds cancellation for waiting holds via the API don't generate a cancellation request In-Reply-To: <bug-33573-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33573-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33573-70-JLXiZpI6kd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33573 Katie Bliss <kebliss at dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:45:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:45:56 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18855-70-CfiEnmTSfA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:45:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:45:59 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18855-70-kBAK60Yhf9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145496|0 |1 is obsolete| | --- Comment #31 from Sam Lau <samalau at gmail.com> --- Created attachment 151647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151647&action=edit Bug 18855: Don't create duplicate overdue fines if an issue is returned This includes Jonathan's followup If cronjobs/fines.pl is running during circulation hours, then an issue may be considered for having it's overdue fine updated after the issue has been returned and it's fine status flipped from 'UNRETURNED' to 'RETURNED'. In this case UpdateFine will create a duplicate fine because it can't find the specific accountline for the (formerly) overdue issue. This changes cronjobs/fines.pl to double check the issue before updating the fine. If the issue has changed between starting the script and updating the fine, then the script will skip it. There is a small amount of time between the check and calling UpdateFine where the issue can be changed and this problem can reoccure. The chance of that happening is so small that it's probably fine to leave as is. It is also possible that the fine won't be updated because the issue was returned. In this case the fine payed by the patron will be lower, but that is better then the patron finding later that there is more to a fine they thought they had paid all of. Test plan (by Caroline): 0. Preliminary settings 0.1. finesMode system preference must be set to Calculate and charge 0.2. There must be a circulation rule that will charge fines (beware of bug 32271) 0.3. In Tools > Calendar, today must not be a holiday 1. Make a lot of overdue checkouts - I used the batch checkout feature, but if your system already has a lot of overdue checkouts, you can skip to step 2 1.1. Enable batch checkouts 1.1.1. Go to Administration > Global system preferences 1.1.2. Search for BatchCheckouts 1.1.3. Set BatchCheckouts to Allow 1.1.4. Select all categories in BatchCheckoutsValidCategories 1.1.5. Click "Save all Circulation preferences" 1.2. Get a list of barcodes 1.2.1. Go to Reports 1.2.2. Click "Create from SQL" 1.2.3. Give the report a name 1.2.4. For the SQL query, enter SELECT barcode FROM items WHERE onloan IS NULL LIMIT 60; 1.2.5. Click "Save report" 1.2.6. Click "Run report" 1.2.7. Click "Download" > "Tab separated text" 1.3. Go to a patron's file 1.3.1. Go to Patrons 1.3.2. Click on "Search" 1.3.3. Click on a patron's name 1.4. Do a batch checkout with a due date in the past 1.4.1. Click on the "Batch check out" tab on the left 1.4.2. In "Use a file", click "Choose file" 1.4.3. Choose the file downloaded from the report 1.4.4. In "Hard due date", choose a date in the past 1.4.5. Click "Check out" 1.4.6. Click "Checkout or renew" 2. Find the last issue in the database 2.1. In the database (or in reports), type the following query SELECT issues.*, items.itype as itemtype, items.homebranch, items.barcode, items.itemlost, items.replacementprice, items.biblionumber FROM issues LEFT JOIN items USING (itemnumber) WHERE date_due < NOW() \G; 2.2. Copy the barcode from the last entry 3. Set up so that you can run fines.pl and check in the item at the same time (or very close to the same time) 3.1. In Koha, click the "Check in" option in the search bar at the top of the page 3.2. Paste the barcode in the search bar BUT DO NOT PRESS ENTER OR THE ARROW RIGHT AWAY 3.3. In a terminal, enter the fines.pl command ./misc/cronjobs/fines.pl 3.4. Execute the command and immediately click on the arrow in the staff interface to check in the item 4. Check the patron's fines 4.1. Click on the patron's name in the check in screen 4.2. Go to the Accounting tab on the left 4.3. In the search box just above the table, paste in the returned item's barcode --> Without the patch, there are two fines, one Fine (Accruing) and one Fine (Returned) for the same item at the same time --> With the patch, there is only one fine, Fine (Returned) Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:53:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:53:51 +0000 Subject: [Koha-bugs] [Bug 33021] Show an alert when adding an item on hold to an item bundle In-Reply-To: <bug-33021-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33021-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33021-70-X2OQVvVHaf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/694 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 18:53:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 16:53:51 +0000 Subject: [Koha-bugs] [Bug 33769] Terminology: 'Warning: Item {barcode} is reserved' In-Reply-To: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33769-70-hbnzbojSZd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33769 Bug 33769 depends on bug 33021, which changed state. Bug 33021 Summary: Show an alert when adding an item on hold to an item bundle https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:03:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 17:03:42 +0000 Subject: [Koha-bugs] [Bug 31615] Allow checkin of items bundles without verifying their contents In-Reply-To: <bug-31615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31615-70-o4UScrDYtO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31615 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/694 Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com Text to go in the| |This enhancement adds the release notes| |possibility to skip the | |content verification step | |when checking in a bundle. Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:03:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 17:03:43 +0000 Subject: [Koha-bugs] [Bug 32802] Bundle handling JS should be moved to an asset In-Reply-To: <bug-32802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32802-70-sGDqaN9dmd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32802 Bug 32802 depends on bug 31615, which changed state. Bug 31615 Summary: Allow checkin of items bundles without verifying their contents https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31615 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:04:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 17:04:26 +0000 Subject: [Koha-bugs] [Bug 33825] New: Allow more granular options when sharing item templates Message-ID: <bug-33825-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33825 Bug ID: 33825 Summary: Allow more granular options when sharing item templates Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl It would be great if rather than shared with everyone or private it could be shared with a patron list, or users in your library group, or users at your library. With larger libraries sharing templates could easily become overwhelming if you really only want to share with a few other staff members. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:08:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 17:08:59 +0000 Subject: [Koha-bugs] [Bug 33826] New: Item template permissions should have an add vs use option Message-ID: <bug-33826-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33826 Bug ID: 33826 Summary: Item template permissions should have an add vs use option Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Larger library systems may want the ability to limit who can create item templates without limiting who can use shared ones to allow cataloging staff to use templates but not create them either by accident or on purpose but not up to standards for the system. Probably adding a separate permission would be the way to go -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:25:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 17:25:35 +0000 Subject: [Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface In-Reply-To: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32677-70-hBxFtuBbXG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677 --- Comment #19 from Victor Zuniga <vctrzuniga at gmail.com> --- (In reply to Jonathan Druart from comment #18) > (In reply to Victor Zuniga from comment #17) > > > > Am I to understand that the bootstrap folder should take precedence for > > language installations? > > "bootstrap" is the default OPAC theme. "prog" and "ccsr" have been removed > in favour of "bootstrap". It is no longer used. > > > We were forced to upgrade this system from a very outdated version back in > > December 2022. I wonder if the migration tools (even though we ended up > > doing a fair amount of manual tweaks) did not remove this folder as part of > > the upgrade. > > > > Can I remove the prog folder safely to avoid further confusion? or should I > > just leave it be? > > You *should* be safe removing it, but backup and test before! Thanks for the clarification, Jonathan! Victor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:28:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 17:28:07 +0000 Subject: [Koha-bugs] [Bug 31615] Allow checkin of items bundles without verifying their contents In-Reply-To: <bug-31615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31615-70-BWr7DoLK38@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31615 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Oh, this never got tied to a preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:31:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 17:31:04 +0000 Subject: [Koha-bugs] [Bug 33827] New: The option to skip bundle verification at checkin should be syspref driven Message-ID: <bug-33827-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33827 Bug ID: 33827 Summary: The option to skip bundle verification at checkin should be syspref driven Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: caroline.cyr-la-rose at inlibro.com, gmcharlt at gmail.com, jacob.omara at ptfs-europe.com, julian.maurice at biblibre.com, kyle.m.hall at gmail.com, kyle at bywatersolutions.com, martin.renvoize at ptfs-europe.com Depends on: 28854, 31615 Blocks: 32802 Some libraries do not want to allow unverified check-ins of bundle sets. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 [Bug 28854] Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31615 [Bug 31615] Allow checkin of items bundles without verifying their contents https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32802 [Bug 32802] Bundle handling JS should be moved to an asset -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:31:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 17:31:04 +0000 Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28854-70-8FVuSz1mpV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33827 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33827 [Bug 33827] The option to skip bundle verification at checkin should be syspref driven -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:31:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 17:31:04 +0000 Subject: [Koha-bugs] [Bug 31615] Allow checkin of items bundles without verifying their contents In-Reply-To: <bug-31615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31615-70-L28BbmkvXz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31615 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33827 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33827 [Bug 33827] The option to skip bundle verification at checkin should be syspref driven -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:31:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 17:31:04 +0000 Subject: [Koha-bugs] [Bug 32802] Bundle handling JS should be moved to an asset In-Reply-To: <bug-32802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32802-70-6DVup07IQp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32802 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33827 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33827 [Bug 33827] The option to skip bundle verification at checkin should be syspref driven -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:32:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 17:32:53 +0000 Subject: [Koha-bugs] [Bug 33827] The option to skip bundle verification at checkin should be syspref driven In-Reply-To: <bug-33827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33827-70-QrSQTsA8kY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33827 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- In bug 31615 I asked for th enhancement to be tied to a syspref to it we could require verification for some workflows... Unfortunately the comment wasn't caught at QA so the regression for some workflows slipped through. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:33:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 17:33:10 +0000 Subject: [Koha-bugs] [Bug 33827] The option to skip bundle verification at checkin should be syspref driven In-Reply-To: <bug-33827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33827-70-3UPO4FSr47@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33827 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:33:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 17:33:32 +0000 Subject: [Koha-bugs] [Bug 33827] The option to skip bundle verification at checkin should be syspref driven In-Reply-To: <bug-33827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33827-70-RY8mxYNGo7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33827 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28854 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 [Bug 28854] Add ability to create bundles of items for circulation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:33:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 17:33:32 +0000 Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28854-70-TsJlSviEsj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33827 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33827 [Bug 33827] The option to skip bundle verification at checkin should be syspref driven -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:34:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 17:34:00 +0000 Subject: [Koha-bugs] [Bug 33827] The option to skip bundle verification at checkin should be syspref driven In-Reply-To: <bug-33827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33827-70-cKQkaVX3Zv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33827 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:35:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 17:35:20 +0000 Subject: [Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit In-Reply-To: <bug-15283-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15283-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15283-70-WpFX1ddYeg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:36:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 17:36:05 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: <bug-15278-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15278-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15278-70-ISmXBFK4HS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 19:53:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 17:53:34 +0000 Subject: [Koha-bugs] [Bug 33775] Different/no results between Check Out and Search Patron when searching for names with spaces In-Reply-To: <bug-33775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33775-70-cOlI9bdCi5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33775 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 20:12:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 18:12:08 +0000 Subject: [Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforlan values as unavailable In-Reply-To: <bug-30846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30846-70-ZzRlT6ZLNo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 20:12:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 18:12:10 +0000 Subject: [Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforlan values as unavailable In-Reply-To: <bug-30846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30846-70-uxqjZRkjjE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147443|0 |1 is obsolete| | --- Comment #9 from Sam Lau <samalau at gmail.com> --- Created attachment 151648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151648&action=edit Bug 30846: 'If any unavailable' doesn't consider negative notforlan values as unavailable When we set up a circulation rule where 'On shelf holds allowed' is 'If any unavailable' and we have a record with one 'Ordered' item, we cannot place this item on hold. This patch allows placing hold on item with negative not for loan values, when using rule with 'On shelf holds allowed' set to 'If any unavailable' To test: 1. Set up a circulation rule where on shelf holds are not allowed and force the choosing of an item (to facilitate the test) 1.1. Go to Administration > Circulation and fines rules 1.2. In the matrix, add a circulation like this - Patron category: All - Item type: Books - Current checkouts allowed: 10 - Current on-site checkouts allowed: 10 - Loan period: 21 - Holds allowed (total): 10 - Holds allowed (daily): 10 - Holds per record (count): 10 - On shelf holds allowed: If any unavailable - OPAC item level holds: Force 1.3. Click Save 2. Create a record with one 'Ordered' item (or any negative value not for loan status) 2.1. Go to Cataloging 2.2. Click New record 2.3. Fill out the mandatory fields (by default in MARC21: 000, 003, 005, 008, 040, 245, and 942 (942 should be set to Books)) 2.4. Click Save 2.5. Fill out the following item fields - Not for loan: Ordered - Koha item type: Books 2.6. Click Add item 2.7. Click Normal to go to the detailed record 3. Try to place a hold on the 'Ordered' item 3.1. From the detailed record, click OPAC view: Open in new window. --> Note that the 'Place hold' option is not present 4. Add a second 'Available' item 4.1. Back in the staff interface tab with the detailed record, click New > New item 4.2. Make sure the item type is set to Books 4.3. Add a barcode in p 4.4. Click Add item 5. Try again to place a hold on the 'Ordered' item 5.1. Go back to the OPAC tab and refresh the page --> Note that the 'Place hold' option is still not present 6. Check out the available item to a patron 6.1. In the staff interface tab, copy the barcode from the available item 6.2. Go to Patrons 6.3. Click on Search 6.4. Click Check out next to one of the patrons 6.5. Paste the barcode in the box and click Check out 7. Try again to place a hold on the 'Ordered' item 7.1. Go back to the OPAC tab and refresh the page --> Note that the 'Place hold' option is now present 7.2. Click Place hold --> Note that only the checked out item is available to place on hold, if you click Show unholdable items, it will show the Ordered item, but you can't place a hold on it. 8. Apply the patch 9. Go to the OPAC tab and click on the book title right next to 'Place a hold on' checkbox to go back to the record details. --> Note that the 'Place hold' option is still present 9.1. Click Place hold --> Note that you can now place a hold on the 'Checked out' or the 'Ordered' item. 10. Check in the item to make it available again 10.1. In the staff interface tab, click on 'Show checkouts' button 10.2. Select the Checked out item and click on 'Renew or check in selected items' button. 11. Try again to place a hold on the 'Ordered' item 11.1. Go back to the OPAC tab and click on the book title right next to 'Place a hold on' checkbox to go back to the record details. --> Note that the 'Place hold' option is still present 11.2. Click Place hold --> Note that only the 'Ordered' item is available to place on hold, if you click Show unholdable items, it will show the Available item and you can't place a hold on it. 12. Delete the available item to keep only the Ordered item 12.1 in the staff interface tab, click on 'Search catalog' and search for the record 12.2 click on 'Edit' then 'Edit items' 12.3 Delete the available item 13. Try to place a hold on the remain 'Ordered' item 13.1 Go back to the OPAC tab and click on the book title right next to 'Place a hold on' checkbox to go back to the record details. --> Note that the 'Place hold' option is present 13.2. Click Place hold --> Note that you can place a hold on the Ordered item. Signed-off-by: Amaury GAU <amaury.gau at bulac.fr> Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 20:12:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 18:12:13 +0000 Subject: [Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforlan values as unavailable In-Reply-To: <bug-30846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30846-70-1reAAd10Ia@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147444|0 |1 is obsolete| | --- Comment #10 from Sam Lau <samalau at gmail.com> --- Created attachment 151649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151649&action=edit Bug 30846: (follow-up) Unit tests Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 20:13:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 18:13:26 +0000 Subject: [Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforlan values as unavailable In-Reply-To: <bug-30846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30846-70-9vh4r7N0ss@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau at gmail.com --- Comment #11 from Sam Lau <samalau at gmail.com> --- The follow up unit test failed, however, it also failed before the patch was even applied. It left this message: Failed test 'IsAvailableForItemLevelRequest() tests' # at t/db_dependent/Reserves.t line 1493. t/db_dependent/Reserves.t .. 74/77 # Looks like you failed 1 test of 77. t/db_dependent/Reserves.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/77 subtests Test Summary Report ------------------- t/db_dependent/Reserves.t (Wstat: 256 Tests: 77 Failed: 1) Failed test: 72 Non-zero exit status: 1 Files=1, Tests=77, 6 wallclock secs ( 0.02 usr 0.01 sys + 3.85 cusr 0.94 csys = 4.82 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 20:39:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 18:39:20 +0000 Subject: [Koha-bugs] [Bug 33789] Checkout information is missing when adding a credit In-Reply-To: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33789-70-OGDvcLknvA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 20:39:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 18:39:22 +0000 Subject: [Koha-bugs] [Bug 33789] Checkout information is missing when adding a credit In-Reply-To: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33789-70-rfJ22evpDl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789 --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151650&action=edit Bug 33789: Add unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 21:06:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 19:06:19 +0000 Subject: [Koha-bugs] [Bug 33820] Add hints to warn the librarian that they will be logged out if they change their username In-Reply-To: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33820-70-A3cNnjpMG3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 21:15:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 19:15:03 +0000 Subject: [Koha-bugs] [Bug 33820] Add hints to warn the librarian that they will be logged out if they change their username In-Reply-To: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33820-70-Xhi6d2eitL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 --- Comment #3 from Sam Lau <samalau at gmail.com> --- First attachment works as expected. The problem occurs when clicking on the "Change Password" template. When editing the username, the hint occurs properly, however, if you press save changes while leaving the new password fields blank, the username doesn't change and it does not log you out. In order for the username change to take effect, you have to enter a new password which basically goes against the text that is listed at the bottom of this page: "Koha cannot display existing passwords. Leave the field blank to leave password unchanged." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 21:16:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 19:16:15 +0000 Subject: [Koha-bugs] [Bug 33820] Add hints to warn the librarian that they will be logged out if they change their username In-Reply-To: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33820-70-fVtPZExSfR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |samalau at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 21:26:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 19:26:38 +0000 Subject: [Koha-bugs] [Bug 33525] Use template wrapper for tabs: Basic MARC editor In-Reply-To: <bug-33525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33525-70-kW6z2HAkth@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33525 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 21:26:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 19:26:39 +0000 Subject: [Koha-bugs] [Bug 33525] Use template wrapper for tabs: Basic MARC editor In-Reply-To: <bug-33525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33525-70-qrsp17xA2o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33525 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151651&action=edit Bug 33525: Use template wrapper for tabs: Basic MARC editor This patch updates the basic MARC editor template to replace tab markup with the use of WRAPPERs. Some CSS and JS has been modified in order to make the custom style and behavior of the tabs on this page work correctly with standard Bootstrap tab markup. To test, apply the patch and go to Cataloging -> New record. - Confirm that the tabs look correct, with the same style they had before the template change. - The first tab ("0") should be selected by default. - Confirm that tab-switching works correctly: The tab color should change and the list of numbered tags in the menu just below should change to match the section. - Confirm that these tag number links still work correctly to jump you down the page to the corresponding tag. - Without filling in any mandatory fields, click the "Save" button. - You should get an error message about missing mandatory fields. - Clicking the "Go to field" link should take you to the correct tab and the correct tag. - Append a hash to the URL to pre-select a tab other than the first one, e.g. "/cgi-bin/koha/cataloguing/addbiblio.pl#tab5XX_panel" The correct tab should be selected upon page load. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 21:34:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 19:34:29 +0000 Subject: [Koha-bugs] [Bug 27775] Add hint about drag and drop feature on framework subfield edit In-Reply-To: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27775-70-bUgB3xQ03q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27775 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- The screenshot for this hint was already in the 23.05 manual. But I added the info in the text of the manual about the drag and drop feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 21:44:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 19:44:20 +0000 Subject: [Koha-bugs] [Bug 33525] Use template wrapper for tabs: Basic MARC editor In-Reply-To: <bug-33525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33525-70-zTt2XZmdcs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33525 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 21:44:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 19:44:22 +0000 Subject: [Koha-bugs] [Bug 33525] Use template wrapper for tabs: Basic MARC editor In-Reply-To: <bug-33525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33525-70-LcRT36nZZC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33525 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151651|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau at gmail.com> --- Created attachment 151652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151652&action=edit Bug 33525: Use template wrapper for tabs: Basic MARC editor This patch updates the basic MARC editor template to replace tab markup with the use of WRAPPERs. Some CSS and JS has been modified in order to make the custom style and behavior of the tabs on this page work correctly with standard Bootstrap tab markup. To test, apply the patch and go to Cataloging -> New record. - Confirm that the tabs look correct, with the same style they had before the template change. - The first tab ("0") should be selected by default. - Confirm that tab-switching works correctly: The tab color should change and the list of numbered tags in the menu just below should change to match the section. - Confirm that these tag number links still work correctly to jump you down the page to the corresponding tag. - Without filling in any mandatory fields, click the "Save" button. - You should get an error message about missing mandatory fields. - Clicking the "Go to field" link should take you to the correct tab and the correct tag. - Append a hash to the URL to pre-select a tab other than the first one, e.g. "/cgi-bin/koha/cataloguing/addbiblio.pl#tab5XX_panel" The correct tab should be selected upon page load. Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 21:46:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 19:46:06 +0000 Subject: [Koha-bugs] [Bug 32997] Add GET endpoint for listing authorised value categories In-Reply-To: <bug-32997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32997-70-nyuT35rioY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32997 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #14 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Back end stuff, doesn't affect the end user so there's nothing to add/amend in the manual. I'm told the API docs is automated, so there's no need to put those bugs as Needs documenting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 21:46:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 19:46:07 +0000 Subject: [Koha-bugs] [Bug 32983] Use REST API route to retrieve authorised values In-Reply-To: <bug-32983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32983-70-cJZ8kvig9S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32983 Bug 32983 depends on bug 32997, which changed state. Bug 32997 Summary: Add GET endpoint for listing authorised value categories https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32997 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 21:46:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 19:46:08 +0000 Subject: [Koha-bugs] [Bug 33235] Cypress tests are failing In-Reply-To: <bug-33235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33235-70-2nxUuVvJI5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33235 Bug 33235 depends on bug 32997, which changed state. Bug 32997 Summary: Add GET endpoint for listing authorised value categories https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32997 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 21:46:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 19:46:25 +0000 Subject: [Koha-bugs] [Bug 30962] Add POST endpoint for validating a user password In-Reply-To: <bug-30962-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30962-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30962-70-W6D3117Daf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #37 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Back end stuff, doesn't affect the end user so there's nothing to add/amend in the manual. I'm told the API docs is automated, so there's no need to put those bugs as Needs documenting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 21:46:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 19:46:26 +0000 Subject: [Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber In-Reply-To: <bug-32739-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32739-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32739-70-tDS3pNJvbd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739 Bug 32739 depends on bug 30962, which changed state. Bug 30962 Summary: Add POST endpoint for validating a user password https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 21:49:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 19:49:46 +0000 Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema In-Reply-To: <bug-32334-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32334-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32334-70-e0hwuQn9q7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED --- Comment #58 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Back end stuff, doesn't affect the end user so there's nothing to add/amend in the manual. I believe the schema (https://schema.koha-community.org/) is updated automatically, so there's no need to put DB bugs as Needs documenting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 21:49:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 19:49:46 +0000 Subject: [Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database revisions In-Reply-To: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30486-70-7D8SrjHSzK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486 Bug 30486 depends on bug 32334, which changed state. Bug 32334 Summary: Sync comments in database with schema https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 21:49:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 19:49:46 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-OQvzONTb75@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 Bug 33584 depends on bug 32334, which changed state. Bug 32334 Summary: Sync comments in database with schema https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 22:03:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 20:03:50 +0000 Subject: [Koha-bugs] [Bug 33734] Using custom search filters breaks scandic characters in search term In-Reply-To: <bug-33734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33734-70-RNtzBf6Wcw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33734 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 22:03:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 20:03:52 +0000 Subject: [Koha-bugs] [Bug 33734] Using custom search filters breaks scandic characters in search term In-Reply-To: <bug-33734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33734-70-93jBJfsFcA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33734 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151551|0 |1 is obsolete| | --- Comment #4 from Sam Lau <samalau at gmail.com> --- Created attachment 151653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151653&action=edit Bug 33734: Use raw filters with search filter links in facets.inc Using html filters breaks scandic characters in search term if one uses custom search filters. Use raw filters instead. To test: 1. Enable SavedSearchFilters syspref 2. Perform search with bib-level:("a") 3. Click "Save search as filter" and save 4. Perform search containing scandic character (åöä) 5. Use filter you just created => notice that scandic characters in search term are displayed incorrectly e.g. ä turns to ä 6. Apply this patch 7. Repeat steps 4 and 5 => scandic characters should now be displayed correctly Sponsored-by: Koha-Suomi Oy Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 22:17:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 20:17:27 +0000 Subject: [Koha-bugs] [Bug 33795] Holds Queue builder should do cheap checks before expensive checks In-Reply-To: <bug-33795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33795-70-rjtHN6C5iL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 22:17:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 20:17:29 +0000 Subject: [Koha-bugs] [Bug 33795] Holds Queue builder should do cheap checks before expensive checks In-Reply-To: <bug-33795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33795-70-bsNhYqWXNg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151535|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau at gmail.com> --- Created attachment 151654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151654&action=edit Bug 33795: Holds Queue builder should do cheap checks before expensive checks The holds queue builder runs many checks in a somewhat arbitrary order. We should order those checks such that the most expensive checks are at the end and can be avoided if a faster check fails. Test Plan: 1) prove t/db_dependent/HoldsQueue.t 2) Apply this patch 3) prove t/db_dependent/HoldsQueue.t 4) Tests still pass! Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 22:37:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 20:37:40 +0000 Subject: [Koha-bugs] [Bug 33828] New: ExportCircHistory description is misleading Message-ID: <bug-33828-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 Bug ID: 33828 Summary: ExportCircHistory description is misleading Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The description for ExportCircHistory is currently [Show/Don't show] the export patron checkout history options. However, the option to export is only available for the patron's current checkouts, not their checkout history. Either we add ExportCircHistory in members/readingrec.pl (circulation history) or we rename/change the description to say that this pref is used to export current checkouts. Current behaviour: 1. Enable ExportCircHistory 2. Go to a patron's account who has checkouts, or check out some items to a patron --> Note that in the checkouts table at the bottom of the page, there is an 'Export' column and at the bottom of the table, there are export options 3. Go to the patron's Details tab --> Note that in the checkouts table at the bottom of the page, there is an 'Export' column and at the bottom of the table, there are export options 4. Go to the patron's Circulation history tab --> No additional export options (other than the datatables thing) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 22:58:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 20:58:35 +0000 Subject: [Koha-bugs] [Bug 33828] ExportCircHistory description is misleading In-Reply-To: <bug-33828-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33828-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33828-70-JWrd1BgGXk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- ExportRemoveFields also mentions the "patron checkout history", but like ExportCircHistory it has nothing to do with the checkout history (both prefs are linked). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 24 23:00:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 21:00:45 +0000 Subject: [Koha-bugs] [Bug 33204] Add the ability to filter on patron library for borrowers-force-messaging-defaults.pl In-Reply-To: <bug-33204-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33204-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33204-70-C4P88EZ0xG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33204 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 23:00:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 21:00:47 +0000 Subject: [Koha-bugs] [Bug 33204] Add the ability to filter on patron library for borrowers-force-messaging-defaults.pl In-Reply-To: <bug-33204-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33204-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33204-70-lL7Vz2vINo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33204 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148102|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau at gmail.com> --- Created attachment 151655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151655&action=edit Bug 33204: Add the ability to filter on patron library for borrowers-force-messaging-defaults.pl Like filter on category Bug 19454, it would be helpful to filter on a specified library for misc/maintenance/borrowers-force-messaging-defaults.pl Test plan: 1) Select two patrons A and B in say libraries L1 and L2. 2) Change the msg prefs for A and B away from defaults. 3) Run misc/maintenance/borrowers-force-messaging-defaults.pl -doit -library L1 Verify that patron A changed and patron B did not. 4) Run with both category and library filters Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 24 23:50:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 21:50:38 +0000 Subject: [Koha-bugs] [Bug 33829] New: Cannot add patron to patron list if PatronAutoComplete is off Message-ID: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33829 Bug ID: 33829 Summary: Cannot add patron to patron list if PatronAutoComplete is off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: 1. Make sure PatronAutoComplete is set to 'Don't try'. 2. Go to Tools > Patron lists 3. Create a Patron list 4. Try to use the 'Patron search:' It doesn't work. This is confusing to users. It should either work without autocomplete or be hidden entirely from display. Using 'Add multiple patrons' still works. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 00:00:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 22:00:53 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-sqoh0gWRac@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 00:00:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 22:00:55 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-IOTKqicm9l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151619|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 151656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151656&action=edit Bug 28130: Manage a patron's subscription alerts This enhancement adds an 'Alert subscriptions' page to a patron account to easily view or cancel email alerts the patron has subscribed to. To test: 1. Go to Cataloging. Create a biblio. 2. Go to Tools -> Notices & slips. Create a notice under the "Serials (new issue)" module, if you don't already have one. 3. Go to Serials. Create a subscription. Link the biblio you just created. Add info like the callnumber, location, library. Choose your notice under Patron notification. Fill out the remaining details and save your subscription. 4. Open this record in the OPAC. Under the Subscriptions tab, click the button to "Subscribe to email notification on new issues" 5. Go back to the staff interface. Go to your patron account. 6. Notice there is a new "Alert subscriptions" tab in the left sidebar menu. The number in brackets should say 1, for the subscription you just enabled email alerts. 7. Click into the page. Confirm your subscription shows in the table. 8. Click the button to unsubscribe. A confirmation should pop up. Confirm you can cancel the unsubscribe action. Then confirm you can unsubscribe using this button. 9. Confirm tests pass t/db_dependent/Koha/Patron.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 00:00:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 22:00:58 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-XvMOmis8dQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 --- Comment #7 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 151657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151657&action=edit Bug 28130: Manage subscription alerts on OPAC This patch adds an 'Alert subscriptions' tab to the patron's account on the OPAC, so they can easily view or cancel email alerts they have subscribed to. To test: 1. Subscribe to email alerts for one or more subscriptions via the OPAC 2. Go to your account, notice the new 'Alert subscriptions' menu option, click here 3. Confirm your subscribed alerts show here. Confirm the table sorting works etc (JS enabled). 4. Test unsubscribing from email alerts, make sure the confirmation pop-up works as expected (JS enabled). 5. Confirm that, when unsubscribing, you are redirected back to this page. 6. Confirm the menu option disappears from the left sidebar navigation if you have no alert subscriptions. Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 00:01:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 22:01:38 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-fqZYujufMD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds an |This enhancement adds an release notes|'Alert subscriptions' page |'Alert subscriptions' page |to a patron account to |to a patron account to |easily view or cancel email |easily view or cancel email |alerts the patron has |alerts the patron has |enabled for subscriptions. |enabled for subscriptions. | |This new page is available | |on both the staff interface | |and the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 01:38:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 23:38:35 +0000 Subject: [Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber In-Reply-To: <bug-32739-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32739-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32739-70-AkayfkWJuY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739 --- Comment #1 from David Cook <dcook at prosentient.com.au> --- One option is to do a user search using the Patrons API using userid/cardnumber/email address or whatever match point(s) you want. And then you can validate using the fetched userid and provided password. This is what I do for a couple systems using this API endpoint. But I'm not opposed to someone adding cardnumber to this API endpoint either. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 01:48:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 23:48:04 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-52BZZSklj4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #10 from David Cook <dcook at prosentient.com.au> --- I might have an idea for this one... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 01:54:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 May 2023 23:54:11 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-uhCU0YX9vm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 --- Comment #11 from David Cook <dcook at prosentient.com.au> --- (In reply to David Cook from comment #10) > I might have an idea for this one... The ID that can't be changed is borrowernumber, so in check_cookie_auth() we should get $patron using $session->param('number') instead of userid/cardnumber; But... the $session will still contain the wrong details. In theory, this same problem applies beyond just userid/id. If the user's details are changed and the session details are used anywhere else, they'll be wrong until they log out and log back in. (Of course, that's not uncommon among many systems.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 02:44:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 00:44:37 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-I7B2Bh3Hdy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 --- Comment #12 from David Cook <dcook at prosentient.com.au> --- (In reply to David Cook from comment #11) > But... the $session will still contain the wrong details. In theory, this > same problem applies beyond just userid/id. If the user's details are > changed and the session details are used anywhere else, they'll be wrong > until they log out and log back in. (Of course, that's not uncommon among > many systems.) As I suspected, at line 559 of ./members/memberentry.pl there is a C4::Auth::haspermission check that uses C4::Context->userenv->{id} which is populated from the database session which is the wrong value, and that triggers a permission/authorization failure (if you use borrowernumber to find the patron to get through check_cookie_auth). -- This is tricky. I suppose we could update/refresh the session, if we stored "updated_on" in the $session as well, and then checked that against the database at authentication time. That said, for an authenticate related change like userid perhaps it is best to expire the session, as a critical aspect of the user account has been changed. If we stored "updated_on" in the $session, we could also notify users if their user id has been changed. This would probably be easier on the staff interface than the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 07:33:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 05:33:05 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-U7vBfXTUBN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Nick Clemens from comment #12) > Created attachment 151644 [details] > Sample record Thx. Will try to incorporate in a test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 07:55:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 05:55:07 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-lA8a6vv3wM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 Biblibre Sandboxes <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151656|0 |1 is obsolete| | --- Comment #8 from Biblibre Sandboxes <sandboxes at biblibre.com> --- Created attachment 151658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151658&action=edit Bug 28130: Manage a patron's subscription alerts This enhancement adds an 'Alert subscriptions' page to a patron account to easily view or cancel email alerts the patron has subscribed to. To test: 1. Go to Cataloging. Create a biblio. 2. Go to Tools -> Notices & slips. Create a notice under the "Serials (new issue)" module, if you don't already have one. 3. Go to Serials. Create a subscription. Link the biblio you just created. Add info like the callnumber, location, library. Choose your notice under Patron notification. Fill out the remaining details and save your subscription. 4. Open this record in the OPAC. Under the Subscriptions tab, click the button to "Subscribe to email notification on new issues" 5. Go back to the staff interface. Go to your patron account. 6. Notice there is a new "Alert subscriptions" tab in the left sidebar menu. The number in brackets should say 1, for the subscription you just enabled email alerts. 7. Click into the page. Confirm your subscription shows in the table. 8. Click the button to unsubscribe. A confirmation should pop up. Confirm you can cancel the unsubscribe action. Then confirm you can unsubscribe using this button. 9. Confirm tests pass t/db_dependent/Koha/Patron.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 07:55:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 05:55:09 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-82iBBhrGxD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 Biblibre Sandboxes <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151657|0 |1 is obsolete| | --- Comment #9 from Biblibre Sandboxes <sandboxes at biblibre.com> --- Created attachment 151659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151659&action=edit Bug 28130: Manage subscription alerts on OPAC This patch adds an 'Alert subscriptions' tab to the patron's account on the OPAC, so they can easily view or cancel email alerts they have subscribed to. To test: 1. Subscribe to email alerts for one or more subscriptions via the OPAC 2. Go to your account, notice the new 'Alert subscriptions' menu option, click here 3. Confirm your subscribed alerts show here. Confirm the table sorting works etc (JS enabled). 4. Test unsubscribing from email alerts, make sure the confirmation pop-up works as expected (JS enabled). 5. Confirm that, when unsubscribing, you are redirected back to this page. 6. Confirm the menu option disappears from the left sidebar navigation if you have no alert subscriptions. Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 07:57:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 05:57:03 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-WPQ9B9OfbV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 --- Comment #10 from Christian Stelzenmüller <christian.stelzenmueller at bsz-bw.de> --- Tested with alerts for two different subscriptions, looks good to me. Maybe someone else can have a look at it too to verify. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 08:12:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 06:12:58 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-NMEQzvHtUG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick at bywatersolutions.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 08:13:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 06:13:13 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-qeGv6ZvROD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 08:50:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 06:50:09 +0000 Subject: [Koha-bugs] [Bug 33830] New: Title and author not on same line anymore Message-ID: <bug-33830-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33830 Bug ID: 33830 Summary: Title and author not on same line anymore Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Since Bug 27613, in OPAC results display title and author not on same line anymore. Looks like it comes from : https://git.koha-community.org/Koha-community/Koha/src/commit/816bbbe77f47688ee79f6664e60cc72ce5d7dd4a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss#L91 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 08:50:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 06:50:17 +0000 Subject: [Koha-bugs] [Bug 33830] Title and author not on same line anymore In-Reply-To: <bug-33830-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33830-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33830-70-2hIE68oXhi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33830 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27613 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 [Bug 27613] Pipe separated contents are hard to customize (OPAC) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 08:50:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 06:50:17 +0000 Subject: [Koha-bugs] [Bug 27613] Pipe separated contents are hard to customize (OPAC) In-Reply-To: <bug-27613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27613-70-kT72l6feOY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33830 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33830 [Bug 33830] Title and author not on same line anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 08:51:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 06:51:48 +0000 Subject: [Koha-bugs] [Bug 27613] Pipe separated contents are hard to customize (OPAC) In-Reply-To: <bug-27613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27613-70-yskLgXzKlj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 --- Comment #28 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Katrin Fischer from comment #27) > I found some display issues that might be related to this bug: > > Example in ktd sample database: > http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=70 > > The label by is 'below' the content that is 'above' it. > > Could some CSS be missing? I think it looked ok in testing. I confirm this is not normal. I've opened Bug 33830. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 08:52:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 06:52:36 +0000 Subject: [Koha-bugs] [Bug 33830] Title and author not on same line anymore In-Reply-To: <bug-33830-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33830-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33830-70-XdllwwEX1H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33830 --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- You can see in our demo 22.11 : https://catalogue-v2211-koha.demo.biblibre.eu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 09:42:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 07:42:33 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-HU1YvhJCzM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- New branch pushed: * Fixed a bug about SeparateHoldings * Code moved to an include file * New patch for discussion: """ Bug 33568: Fix DT dom and remove DT info if not needed Was there a real need to deal with a specific dom? The "no filter" view was not really light, only the column filters were shown/hidden. This patch is suggesting to remove all the DT info in case the table is displaying all the items of the bibliographic record: Pagination, filtering, buttons, etc. """ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 10:01:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 08:01:00 +0000 Subject: [Koha-bugs] [Bug 33831] New: UNIMARCAuthorityField100 Message-ID: <bug-33831-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33831 Bug ID: 33831 Summary: UNIMARCAuthorityField100 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: Igor.A.Sychev at mail.ru QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com System preferences authorities.pref#UNIMARCAuthorityField100# Use the following text for the contents of UNIMARC authority field 100 position 08-35 (fixed length data elements). Do NOT include the date (position 00-07): UNIMARC authority field 100 position 08-23 https://cdn.ifla.org/wp-content/uploads/2019/05/assets/uca/unimarc-authorities-format.pdf -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 10:21:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 08:21:29 +0000 Subject: [Koha-bugs] [Bug 32802] Bundle handling JS should be moved to an asset In-Reply-To: <bug-32802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32802-70-fARXOQ2ZGH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32802 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33568 Status|NEW |BLOCKED CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Please don't do this before bug 33568. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the biblio detail view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 10:21:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 08:21:29 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-c2NB14TSrH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32802 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32802 [Bug 32802] Bundle handling JS should be moved to an asset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 10:59:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 08:59:09 +0000 Subject: [Koha-bugs] [Bug 30581] Items should show on the Holds Queue and Holds to Pull even if they have requested transfers In-Reply-To: <bug-30581-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30581-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30581-70-MYonBjHt1I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30581 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I 'think' this is a duplicate of bug 33761.. any chance someone could test with that and confirm my suspicions? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 11:39:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 09:39:38 +0000 Subject: [Koha-bugs] [Bug 33817] Composition of an item bundle can be changed if checked out In-Reply-To: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33817-70-4BP2o6Zoub@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 11:39:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 09:39:41 +0000 Subject: [Koha-bugs] [Bug 33817] Composition of an item bundle can be changed if checked out In-Reply-To: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33817-70-2wiL12yH4s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151660&action=edit Bug 33817: Enforce server-side -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 11:43:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 09:43:13 +0000 Subject: [Koha-bugs] [Bug 33817] Composition of an item bundle can be changed if checked out In-Reply-To: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33817-70-tKuNhmOGlN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks for your work here Jonathan.., testing not, but the code looks solid :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 11:46:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 09:46:58 +0000 Subject: [Koha-bugs] [Bug 31082] Add tooltip to buttons when item bundles cannot be changed while checked out In-Reply-To: <bug-31082-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31082-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31082-70-mJQTVk887F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31082 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 11:47:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 09:47:01 +0000 Subject: [Koha-bugs] [Bug 31082] Add tooltip to buttons when item bundles cannot be changed while checked out In-Reply-To: <bug-31082-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31082-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31082-70-xM0VWKst0h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31082 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151661&action=edit Bug 31082: Add tooltip to buttons when item bundles cannot be changed while checked out -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 11:47:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 09:47:12 +0000 Subject: [Koha-bugs] [Bug 31082] Add tooltip to buttons when item bundles cannot be changed while checked out In-Reply-To: <bug-31082-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31082-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31082-70-chBVJteDIb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31082 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 11:47:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 09:47:25 +0000 Subject: [Koha-bugs] [Bug 31082] Add tooltip to buttons when item bundles cannot be changed while checked out In-Reply-To: <bug-31082-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31082-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31082-70-SyCMm2LEd4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31082 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 11:49:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 09:49:03 +0000 Subject: [Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format) In-Reply-To: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33804-70-IJjJwqsDOA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Test plan: Confirm that the datetimes are correctly displayed on the checkouts table Apply 33568 (or use the remote branch) Confirm that the datetimes are correct on the items table (you need checked out items, with and without the time part 23:59) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 11:54:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 09:54:53 +0000 Subject: [Koha-bugs] [Bug 33817] Composition of an item bundle can be changed if checked out In-Reply-To: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33817-70-AEizYxcJif@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151623|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151662&action=edit Bug 33817: Prevent item bundle that is checked out to be modified Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 11:54:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 09:54:55 +0000 Subject: [Koha-bugs] [Bug 33817] Composition of an item bundle can be changed if checked out In-Reply-To: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33817-70-FMHbtUAgwD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151660|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151663&action=edit Bug 33817: Enforce server-side Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 11:55:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 09:55:25 +0000 Subject: [Koha-bugs] [Bug 33817] Composition of an item bundle can be changed if checked out In-Reply-To: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33817-70-Lqduv0cPxR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- All working as originally intended and covered by tests too.. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 11:55:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 09:55:38 +0000 Subject: [Koha-bugs] [Bug 33817] Composition of an item bundle can be changed if checked out In-Reply-To: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33817-70-zaZgoex5OY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 11:55:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 09:55:57 +0000 Subject: [Koha-bugs] [Bug 32671] basic_workflow.t is failing randomly In-Reply-To: <bug-32671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32671-70-oKs5ohgXcx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32671 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Koha_Master/2530 koha_1 | CP main = 3.30 koha_1 | koha_1 | # Failed test at t/db_dependent/selenium/basic_workflow.t line 113. koha_1 | Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 125. koha_1 | # 'Patron categories › Administration › Koha' koha_1 | # doesn't match '(?^u:New category)' koha_1 | koha_1 | STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} koha_1 | /usr/share/perl5/Selenium/Remote/Driver.pm:361 in Try::Tiny::try koha_1 | (eval 1858):1 in Selenium::Remote::Driver::__ANON__ koha_1 | (eval 1860):2 in Selenium::Remote::Driver::__ANON__ koha_1 | /usr/share/perl5/Selenium/Remote/Driver.pm:1340 in Selenium::Remote::Driver::_execute_command koha_1 | /usr/share/perl5/Selenium/Remote/Driver.pm:1340 in (eval) koha_1 | /kohadevbox/koha/t/lib/Selenium.pm:117 in Selenium::Remote::Driver::find_element koha_1 | t/db_dependent/selenium/basic_workflow.t:114 in t::lib::Selenium::fill_form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 11:59:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 09:59:08 +0000 Subject: [Koha-bugs] [Bug 29565] selenium/regressions.t can fail on slow boxes In-Reply-To: <bug-29565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29565-70-XvIAw5ySax@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Koha_Master/2531 22:21:45 koha_1 | # Looks like you planned 18 tests but ran 15. 22:21:45 koha_1 | 22:21:45 koha_1 | # Failed test 'Encoding in session variables' 22:21:45 koha_1 | # at t/db_dependent/selenium/regressions.t line 340. 22:21:45 koha_1 | Can't call method "get_text" on an undefined value at t/db_dependent/selenium/regressions.t line 325. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 12:21:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 10:21:20 +0000 Subject: [Koha-bugs] [Bug 33802] On OPAC authority detail page, usage count in erroneous In-Reply-To: <bug-33802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33802-70-IOP8r51Nca@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 --- Comment #3 from Frédéric Demians <frederic at tamil.fr> --- Yes, it's ES specific. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 12:50:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 10:50:08 +0000 Subject: [Koha-bugs] [Bug 33830] Title and author not on same line anymore In-Reply-To: <bug-33830-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33830-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33830-70-XWxGHMEYHp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33830 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151664&action=edit Screenshot showing author information duplicated on the same line This change was intentional. Many of the titles I was testing with had data in MARC21's 245c, statement of responsibility, and in many cases that field is a duplicate of the author information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 12:51:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 10:51:33 +0000 Subject: [Koha-bugs] [Bug 33830] Title and author not on same line anymore In-Reply-To: <bug-33830-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33830-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33830-70-02MVQHne4i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33830 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151665&action=edit Screenshot showing a large block of author information on the same line In other cases the author information runs on for so many lines that it creates a confusing block of text. The line break helps that be more readable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 12:57:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 10:57:54 +0000 Subject: [Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format) In-Reply-To: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33804-70-4YfZLq42Fg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151559|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151666&action=edit Bug 33804: Add as_due_date option to $date Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 12:57:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 10:57:57 +0000 Subject: [Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format) In-Reply-To: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33804-70-MrZZYkim06@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151561|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151667&action=edit Bug 33804: Use as_due_date to display due dates Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 12:57:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 10:57:59 +0000 Subject: [Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format) In-Reply-To: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33804-70-oC518Oh16r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151668&action=edit Bug 33804: (follow-up) Convert to JSDoc formatted documentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 12:58:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 10:58:37 +0000 Subject: [Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format) In-Reply-To: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33804-70-peKV5O6q16@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 12:58:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 10:58:59 +0000 Subject: [Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format) In-Reply-To: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33804-70-WItpHxSIgB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Our date handling still confuses me.. but I think this all appears to be correct. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 13:01:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 11:01:42 +0000 Subject: [Koha-bugs] [Bug 31082] Add tooltip to buttons when item bundles cannot be changed while checked out In-Reply-To: <bug-31082-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31082-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31082-70-6lOaA97306@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31082 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151661|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151669&action=edit Bug 31082: Add tooltip to buttons when item bundles cannot be changed while checked out Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 13:02:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 11:02:20 +0000 Subject: [Koha-bugs] [Bug 31082] Add tooltip to buttons when item bundles cannot be changed while checked out In-Reply-To: <bug-31082-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31082-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31082-70-eZ417pAWcA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31082 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- It's great to see these little improvements getting done, thanks for working on them Jonathan and my apologies for not having managed to get to them yet :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 13:24:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 11:24:26 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-Px1Iim9dNU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151511|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 151670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151670&action=edit Bug 33786: ILL requests table id Make sure requests table is unique when visiting patron ILL history so the table state is not shared unintentionally Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 13:24:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 11:24:40 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-207ms6Oz3k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 13:25:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 11:25:10 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-FdCHIxfaQe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pedro.amorim at ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 13:25:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 11:25:21 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-HMGfJRw445@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 13:25:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 11:25:30 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-kKygIvvrpQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 13:31:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 11:31:16 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-8Z3QQN8xNe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- We should instantiate borrower_prefilter_value, the code is confusing as it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 13:53:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 11:53:21 +0000 Subject: [Koha-bugs] [Bug 33832] New: Can't change a patron's username without entering passwords Message-ID: <bug-33832-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33832 Bug ID: 33832 Summary: Can't change a patron's username without entering passwords Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In the staff interface, on the "Change password" page, it's not possible to update a patron's username without also entering password information. This is contrary to the help text, "Leave the field blank to leave password unchanged." As far as I can tell this bug goes back to at least 21.05.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 13:53:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 11:53:21 +0000 Subject: [Koha-bugs] [Bug 33820] Add hints to warn the librarian that they will be logged out if they change their username In-Reply-To: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33820-70-dc5DVVkSwK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33832 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 13:55:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 11:55:16 +0000 Subject: [Koha-bugs] [Bug 33820] Add hints to warn the librarian that they will be logged out if they change their username In-Reply-To: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33820-70-58shZJCFjb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Sam Lau from comment #3) > In > order for the username change to take effect, you have to enter a new > password which basically goes against the text that is listed at the bottom > of this page: > > "Koha cannot display existing passwords. Leave the field blank to leave > password unchanged." This issue is unrelated to the patch, so I've created Bug 33832. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 13:55:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 11:55:23 +0000 Subject: [Koha-bugs] [Bug 33820] Add hints to warn the librarian that they will be logged out if they change their username In-Reply-To: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33820-70-HBeML9xsUD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:01:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:01:02 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-4QnQ3m05Qg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 --- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- +if (C4::Context->preference("AlternateHoldingsField") && scalar $items->count == 0) { scalar should be removed here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:01:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:01:25 +0000 Subject: [Koha-bugs] [Bug 33780] Multi-line TT comment: [%% item.object.itemnotes.replace('\n', ' In-Reply-To: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33780-70-G7BRC5VsFJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33780 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Katrin Fischer from comment #0) > [%% item.object.itemnotes.replace('\n',' I don't see this string anywhere but in Koha-staff-prog.pot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:04:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:04:06 +0000 Subject: [Koha-bugs] [Bug 33780] Multi-line TT comment: [%% item.object.itemnotes.replace('\n', ' In-Reply-To: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33780-70-vx8SVejAxz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33780 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Owen Leonard from comment #2) > I don't see this string anywhere but in Koha-staff-prog.pot Sorry, scratch that, I was on the wrong branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:22:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:22:16 +0000 Subject: [Koha-bugs] [Bug 33780] Multi-line TT comment: [%% item.object.itemnotes.replace('\n', ' In-Reply-To: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33780-70-VqJOOLt1gt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33780 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:25:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:25:26 +0000 Subject: [Koha-bugs] [Bug 33823] KohaTable vue component action buttons spacing differ from kohaTable In-Reply-To: <bug-33823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33823-70-yieL5XarwJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33823 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:25:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:25:29 +0000 Subject: [Koha-bugs] [Bug 33823] KohaTable vue component action buttons spacing differ from kohaTable In-Reply-To: <bug-33823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33823-70-hxrmSvhaN0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33823 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151645|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151671&action=edit Bug 33823: Add spacing to action labels Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:26:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:26:10 +0000 Subject: [Koha-bugs] [Bug 33823] KohaTable vue component action buttons spacing differ from kohaTable In-Reply-To: <bug-33823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33823-70-JlOVL3DDAD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33823 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:27:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:27:28 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-03PZ9RUjsG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:27:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:27:30 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-Dqmbdlxnfs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151672&action=edit Bug 33404: Z3950SearchAuth: Save in UTF-8 encoding Test plan: [1] If you have access to a Z3950 MARC8 auth server, search for an authority record and import it. [2] If you have access to a Z3950 UTF8 auth server, search for an authority record and import it. Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:27:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:27:33 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-F87kPr8NJE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151673&action=edit Bug 33404: Fix serverhost and init $page The array serverhost is not filled. Should be replaced with values from servers array. Test plan: Nothing exciting here. Read the patch. Note that we will test in the next patch if the hostname is saved correctly in the import batch. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:27:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:27:36 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-0WEjhJYqNU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 --- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151674&action=edit Bug 33404: Add unit tests Test plan: Run t/db_dependent/Breeding.t Run t/db_dependent/Breeding_Auth.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:28:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:28:47 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-iOnaIIK18t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:30:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:30:34 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-Kj1n6IihBr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151641|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:30:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:30:47 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-B4D0KiysSj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151644|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:32:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:32:26 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-53FYgfD4PR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 --- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Note for QA: The Z3950SearchAuth test can be extended further later on. And used as a basis for Z3950Search too. We need to consolidate the duplicated code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:33:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:33:20 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-A6tSqOVPLG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 --- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #13) > (In reply to Nick Clemens from comment #12) > > Created attachment 151644 [details] > > Sample record > > Thx. Will try to incorporate in a test. Nick, there is an issue with this sample record. I could import it but I could not use it in my test. I have the impression that there is an issue with exporting authority records from Koha in MARC8? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:33:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:33:44 +0000 Subject: [Koha-bugs] [Bug 33794] Holds Queue builder skips least cost branch unless target item's homebranch is patron's homebranch In-Reply-To: <bug-33794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33794-70-wbNjVIAmwv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:40:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:40:21 +0000 Subject: [Koha-bugs] [Bug 33802] On OPAC authority detail page, usage count in erroneous In-Reply-To: <bug-33802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33802-70-1OYJGP6alz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the usage count release notes| |shown on authority details | |pages in the OPAC (and the | |staff interface) - "Number | |of records used in: X". | |Previously, where | |QueryAutoTruncate is | |enabled, the usage count | |for an authority may have | |been wrong as the search | |was automatically truncated | |(for example, a search for | |records using authority 22 | |also retrieved using | |authorities 222, 22*, and | |so on). --- Comment #4 from David Nind <david at davidnind.com> --- (In reply to Frédéric Demians from comment #3) > Yes, it's ES specific. Thanks! Sign off coming for this patch that fixes the OPAC (and staff interface). I also noticed that this is occurring on the staff interface as well. This bug fixes the display for the staff interface authority details page - "Used in X records". But it doesn't fix the actual results. For example, authid=3 shows used in 1 record, but you get 44 records in the actual results. I vaguely remember testing a similar bug a while ago, but can't find it now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:41:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:41:58 +0000 Subject: [Koha-bugs] [Bug 33802] On OPAC authority detail page, usage count in wrong (when using Elasticsearch) In-Reply-To: <bug-33802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33802-70-e6oayygBW6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the usage count |This fixes the usage count release notes|shown on authority details |shown on authority details |pages in the OPAC (and the |pages in the OPAC (and the |staff interface) - "Number |staff interface) - "Number |of records used in: X". |of records used in: X". |Previously, where |Note: This only occurs when |QueryAutoTruncate is |using the Elasticsearch or |enabled, the usage count |Open Search search engine. |for an authority may have |Previously, where |been wrong as the search |QueryAutoTruncate is |was automatically truncated |enabled, the usage count |(for example, a search for |for an authority may have |records using authority 22 |been wrong as the search |also retrieved using |was automatically truncated |authorities 222, 22*, and |(for example, a search for |so on). |records using authority 22 | |also retrieved using | |authorities 222, 22*, and | |so on). Summary|On OPAC authority detail |On OPAC authority detail |page, usage count in |page, usage count in wrong |erroneous |(when using Elasticsearch) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:42:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:42:40 +0000 Subject: [Koha-bugs] [Bug 33802] On OPAC authority detail page, usage count in wrong (when using Elasticsearch) In-Reply-To: <bug-33802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33802-70-jsZx0oFzMo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:42:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:42:43 +0000 Subject: [Koha-bugs] [Bug 33802] On OPAC authority detail page, usage count in wrong (when using Elasticsearch) In-Reply-To: <bug-33802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33802-70-mhCbabFSFh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151553|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Created attachment 151675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151675&action=edit Bug 33802: On OPAC authority detail page, usage count in erroneous If QueryAutoTruncate is enabled, the biblio usage count of an authority displayed on OPAC may be wrong. This is due to the fact that the authid search being automatically truncated, a search for biblios using authority 22 will retrieved also biblios using authorities 222, 22*. TO TEST: 1. On a Koha with authorities, enable QueryAutoTruncate. 2. Go on opac-authoritiesdetail.pl page for an authority with the lowest possible authid. Let say 1. 3. Confirm that you have a large biblios usage count, and that by clicking on the link to see linked biblios, you get far less biblios than expected. 4. Apply the patch. Repeat 2-3. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:52:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:52:33 +0000 Subject: [Koha-bugs] [Bug 33734] Using custom search filters breaks scandic characters in search term In-Reply-To: <bug-33734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33734-70-MfYcpSrO5m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33734 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This code is wrong, we should reuse what we are doing later in the same file (search 'local_url'). Note that we are missing count and sort_by. It's not your patch that is wrong but the existing code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:53:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:53:14 +0000 Subject: [Koha-bugs] [Bug 33734] Using custom search filters breaks scandic characters in search term In-Reply-To: <bug-33734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33734-70-JUEJ2dfePc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33734 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I guess the OPAC side should be fixed as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:53:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:53:25 +0000 Subject: [Koha-bugs] [Bug 33734] Using custom search filters breaks scandic characters in search term In-Reply-To: <bug-33734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33734-70-kRhwoF5uin@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33734 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17170 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 14:53:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 12:53:25 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17170-70-pHVVGj3eUb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33734 [Bug 33734] Using custom search filters breaks scandic characters in search term -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:07:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:07:02 +0000 Subject: [Koha-bugs] [Bug 33833] New: Remove T::D::C from t/SocialData.t Message-ID: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33833 Bug ID: 33833 Summary: Remove T::D::C from t/SocialData.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Removing T::D::C and some polishing. The module is a bit weird. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:07:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:07:13 +0000 Subject: [Koha-bugs] [Bug 33833] Remove T::D::C from t/SocialData.t In-Reply-To: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33833-70-ncp3qDkcIe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33833 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:09:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:09:31 +0000 Subject: [Koha-bugs] [Bug 33829] Cannot add patron to patron list if PatronAutoComplete is off In-Reply-To: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33829-70-5MgiE3qgtj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33829 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:09:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:09:33 +0000 Subject: [Koha-bugs] [Bug 33829] Cannot add patron to patron list if PatronAutoComplete is off In-Reply-To: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33829-70-rSNsfs1T8F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33829 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151676&action=edit Bug 33829: Fix add patron to patron list if PatronAutoComplete is off When adding patrons to a patron list we get a JS error about undefined variables. We can easily fix this problem by defining them even if the pref is not set. We are enabling the auto complete even if PatronAutoComplete if off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:09:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:09:47 +0000 Subject: [Koha-bugs] [Bug 33829] Cannot add patron to patron list if PatronAutoComplete is off In-Reply-To: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33829-70-fkDXjXkxPi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33829 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:14:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:14:00 +0000 Subject: [Koha-bugs] [Bug 33834] New: api/v1/ill_requests.t fails randomly Message-ID: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834 Bug ID: 33834 Summary: api/v1/ill_requests.t fails randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Depending on how results are sorted, it might fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:14:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:14:14 +0000 Subject: [Koha-bugs] [Bug 33834] api/v1/ill_requests.t fails randomly In-Reply-To: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33834-70-6eZeyLgZeC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com CC| |jonathan.druart+koha at gmail. | |com, tomascohen at gmail.com Depends on| |22440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 [Bug 22440] Improve ILL page performance by moving to server side filtering -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:14:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:14:14 +0000 Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to server side filtering In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-HztDhSXwFJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33834 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834 [Bug 33834] api/v1/ill_requests.t fails randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:14:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:14:27 +0000 Subject: [Koha-bugs] [Bug 33834] api/v1/ill_requests.t fails randomly In-Reply-To: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33834-70-kF1c9jav9E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:17:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:17:13 +0000 Subject: [Koha-bugs] [Bug 33780] Multi-line TT comment: [%% item.object.itemnotes.replace('\n', ' In-Reply-To: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33780-70-DcSRtCCHR9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33780 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:17:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:17:15 +0000 Subject: [Koha-bugs] [Bug 33780] Multi-line TT comment: [%% item.object.itemnotes.replace('\n', ' In-Reply-To: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33780-70-M8Cvw5HTWV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33780 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151677&action=edit Bug 33780: Use TT html_line_break filter to format itemnotes This patch removes a snippet of TT code which was causing problems with translation. Putting HTML inside a TT replace() method resulted in TT code being processed for translation. To test, apply the patch and edit an item record's public note field so that it contains line breaks ("\n"). Since the notes field in the editor is a text field, you might want to update the record in the database: update items set itemnotes = "Line 1\nLine 2\n\n\n\nLine 3" where biblionumber = 228; View the bibliographic details page in the staff interface. The note in the holdings table should have the correct line breaks. If you inspect the HTML you should see that each "\n" has been replaced with "<br />" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:18:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:18:20 +0000 Subject: [Koha-bugs] [Bug 33834] api/v1/ill_requests.t fails randomly In-Reply-To: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33834-70-a2Saevsz21@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:18:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:18:23 +0000 Subject: [Koha-bugs] [Bug 33834] api/v1/ill_requests.t fails randomly In-Reply-To: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33834-70-7Yhcgm5lMw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834 --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151678&action=edit Bug 33834: Fix random failure on api/v1/ill_requests.t This patch makes the GET request results more deterministic so we avoid random failures. It does so by adding a fixed value to each ILL request and then sorting by it. To test: 1. Run: $ DB_IMAGE=mysqli:8.0 ktd up -d # wait until it finished: $ ktd --logs 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/ill_requests.t (repeat a few times) => FAIL: It sometimes fails 3. Apply this patch 4. Repeat 2 => SUCCESS: It doesn't fail 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:18:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:18:44 +0000 Subject: [Koha-bugs] [Bug 33834] api/v1/ill_requests.t fails randomly In-Reply-To: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33834-70-AIMfS6vNeS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:20:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:20:47 +0000 Subject: [Koha-bugs] [Bug 33554] searching borrowers is a lot slower if there's searchable extended attributes. In-Reply-To: <bug-33554-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33554-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33554-70-iCX1G7S4NH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I was going to suggest to have a separate "extended_attributes" parameter we could pass to the endpoint, but that's not trivial to implement (we need the search_type, and to know if we need a OR or AND with q...) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:28:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:28:39 +0000 Subject: [Koha-bugs] [Bug 33780] Multi-line TT comment: [%% item.object.itemnotes.replace('\n', ' In-Reply-To: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33780-70-box2NjbiJY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33780 --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I am not sure this is about what was reporting Katrin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:29:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:29:54 +0000 Subject: [Koha-bugs] [Bug 33833] Remove T::D::C from t/SocialData.t In-Reply-To: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33833-70-5Xe6gZBTP8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33833 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:29:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:29:56 +0000 Subject: [Koha-bugs] [Bug 33833] Remove T::D::C from t/SocialData.t In-Reply-To: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33833-70-e1f9rqVH0p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33833 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151679&action=edit Bug 33833: Use database in t/Socialdata.t Remove T::D::C. Add subtests. Remove useless parameter from get_report call. Add two additional trivial tests. Note: The module C4::SocialData looks a bit weird. Test plan: Run t/SocialData.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:29:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:29:58 +0000 Subject: [Koha-bugs] [Bug 33833] Remove T::D::C from t/SocialData.t In-Reply-To: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33833-70-xzLy1H09qA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33833 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151680&action=edit Bug 33833: Add two FIXMEs to SocialData::get_report Just comments, no test plan. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:30:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:30:00 +0000 Subject: [Koha-bugs] [Bug 33833] Remove T::D::C from t/SocialData.t In-Reply-To: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33833-70-XYynoNWUhC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33833 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151681&action=edit Bug 40002: Move to db_dependent Test plan: Run t/db_dependent/SocialData.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:31:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:31:43 +0000 Subject: [Koha-bugs] [Bug 33833] Remove T::D::C from t/SocialData.t In-Reply-To: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33833-70-Z7dYbqoeYb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33833 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151681|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151682&action=edit Bug 33833: Move to db_dependent Test plan: Run t/db_dependent/SocialData.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:36:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:36:59 +0000 Subject: [Koha-bugs] [Bug 33835] New: [OMNIBUS] Move Breeding module to Koha namespace Message-ID: <bug-33835-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33835 Bug ID: 33835 Summary: [OMNIBUS] Move Breeding module to Koha namespace Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:37:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:37:23 +0000 Subject: [Koha-bugs] [Bug 33835] [OMNIBUS] Move Breeding module to Koha namespace In-Reply-To: <bug-33835-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33835-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33835-70-PnzMvk37ZZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33835 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33404 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:37:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:37:23 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-bZ3inSxkvV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33835 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33835 [Bug 33835] [OMNIBUS] Move Breeding module to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:38:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:38:37 +0000 Subject: [Koha-bugs] [Bug 33835] [OMNIBUS] Move Breeding module to Koha namespace In-Reply-To: <bug-33835-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33835-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33835-70-tDED5BWxxu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33835 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- cat C4/Breeding.pm | grep -P "^sub " sub BreedingSearch { sub Z3950Search { sub _auth_build_query { sub _bib_build_query { sub _build_query { sub _handle_one_result { sub _do_xslt_proc { sub _add_custom_field_rowdata sub _isbn_replace { sub _create_connection { sub _translate_query { #SRU query adjusted per server cf. srufields column sub ImportBreedingAuth { sub Z3950SearchAuth { -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:40:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:40:58 +0000 Subject: [Koha-bugs] [Bug 33781] Terminology: Item already issued to other borrower. In-Reply-To: <bug-33781-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33781-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33781-70-gJQtXOv5kz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33781 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:40:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:40:59 +0000 Subject: [Koha-bugs] [Bug 33781] Terminology: Item already issued to other borrower. In-Reply-To: <bug-33781-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33781-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33781-70-YINtC7zX0p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33781 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151683&action=edit Bug 33781: Terminology: Item already issued to other borrower. This patch updates a couple of error message strings so that they use the correct terminology and read well. "This item is on hold for another borrower." becomes "This item is on hold for another patron." "Item already issued to other borrower." becomes "This item is already checked out to another patron." To test, apply the patch and log into the OPAC as a patron who has items checked out which are available for renewal. In another tab, place a hold on one of those items on behalf of a different patron. Back in your OPAC tab, click the "Renew" link next to the title which is now on hold. The page should reload and show the updated message, "This item is on hold..." I was not able to trigger the other message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:42:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:42:24 +0000 Subject: [Koha-bugs] [Bug 33836] New: Move the ZOOM event loops out of the Z3950 searches Message-ID: <bug-33836-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33836 Bug ID: 33836 Summary: Move the ZOOM event loops out of the Z3950 searches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org As a first step in consolidating code between Z3950Search and Z3950SearchAuth, as well as preparing to move to Koha namespace. Part of omnibus 33835. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:43:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:43:46 +0000 Subject: [Koha-bugs] [Bug 33836] Move the ZOOM event loops out of the Z3950 searches In-Reply-To: <bug-33836-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33836-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33836-70-Dehbpfuo4P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33836 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33835 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33835 [Bug 33835] [OMNIBUS] Move Breeding module to Koha namespace -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:43:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:43:46 +0000 Subject: [Koha-bugs] [Bug 33835] [OMNIBUS] Move Breeding module to Koha namespace In-Reply-To: <bug-33835-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33835-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33835-70-286HkteJeb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33835 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33836 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33836 [Bug 33836] Move the ZOOM event loops out of the Z3950 searches -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:51:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:51:15 +0000 Subject: [Koha-bugs] [Bug 33779] Terminology: biblio record In-Reply-To: <bug-33779-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33779-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33779-70-09ko2BZwsL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33779 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:51:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:51:17 +0000 Subject: [Koha-bugs] [Bug 33779] Terminology: biblio record In-Reply-To: <bug-33779-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33779-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33779-70-AAfHHAvKvN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33779 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151684&action=edit Bug 33779: Terminology: biblio record This patch corrects a string in the staff interface's ILL requests template. "This item cannot be issued as it has no biblio record associated with it" is updated to read "This item cannot be checked out as it has no bibliographic record associated with it." I don't know how to trigger the error message in the interface, but the change is simple enough that it could be verified by examining the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:54:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:54:02 +0000 Subject: [Koha-bugs] [Bug 33752] Password expiration warning In-Reply-To: <bug-33752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33752-70-1bl6X6uMDL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33752 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:54:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:54:16 +0000 Subject: [Koha-bugs] [Bug 33753] Password expiration warning In-Reply-To: <bug-33753-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33753-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33753-70-Mv5ZIeSPoH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33753 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:54:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:54:55 +0000 Subject: [Koha-bugs] [Bug 33753] Password expiration warning In-Reply-To: <bug-33753-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33753-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33753-70-12xPRszaCs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33753 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Christopher Brannon from comment #2) > I purposely kept this separate. It would be helpful if the bug titles were descriptive and distinct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 15:55:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 13:55:51 +0000 Subject: [Koha-bugs] [Bug 33837] New: Objects->filter_by_last_update: Does not allow time comparison Message-ID: <bug-33837-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Bug ID: 33837 Summary: Objects->filter_by_last_update: Does not allow time comparison Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:06:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:06:44 +0000 Subject: [Koha-bugs] [Bug 33820] Add hints to warn the librarian that they will be logged out if they change their username In-Reply-To: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33820-70-6QUZ7ED8bU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:06:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:06:46 +0000 Subject: [Koha-bugs] [Bug 33820] Add hints to warn the librarian that they will be logged out if they change their username In-Reply-To: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33820-70-VAIDayMcp5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151639|0 |1 is obsolete| | --- Comment #5 from Sam Lau <samalau at gmail.com> --- Created attachment 151685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151685&action=edit Bug 33820: Add hints to warn the librarian that they will be logged out if they change their username This patch adds some JavaScript to the patron entry form which adds a hint if the logged-in librarian tries to change their own username. It warns them that they will be logged out. To test, apply the patch and log into the staff interface. - Locate and edit your own patron record. - In the "OPAC/Staff interface login" section, change the value in the username field. When focus leaves that form field a hint should appear, "You will be logged out if you modify your username." - Change the username field back to your original username. The hint should disappear. - Confirm that submitting a username change works correctly: You should be logged out, and when you log in again your username should be updated. Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:06:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:06:48 +0000 Subject: [Koha-bugs] [Bug 33820] Add hints to warn the librarian that they will be logged out if they change their username In-Reply-To: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33820-70-DyXEpnPoIc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151640|0 |1 is obsolete| | --- Comment #6 from Sam Lau <samalau at gmail.com> --- Created attachment 151686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151686&action=edit Bug 33820: (follow-up) Add hint to member-password.tt This follow-up makes the same change to the "Change password" template. Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:08:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:08:21 +0000 Subject: [Koha-bugs] [Bug 33829] Cannot add patron to patron list if PatronAutoComplete is off In-Reply-To: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33829-70-UOah8rFjHM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33829 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:08:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:08:23 +0000 Subject: [Koha-bugs] [Bug 33829] Cannot add patron to patron list if PatronAutoComplete is off In-Reply-To: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33829-70-rZdWEL4HUU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33829 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151676|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151687&action=edit Bug 33829: Fix add patron to patron list if PatronAutoComplete is off When adding patrons to a patron list we get a JS error about undefined variables. We can easily fix this problem by defining them even if the pref is not set. We are enabling the auto complete even if PatronAutoComplete if off. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:11:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:11:24 +0000 Subject: [Koha-bugs] [Bug 31856] Improve performance of serials subscriptions search In-Reply-To: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31856-70-tgjm0HvzYo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856 --- Comment #20 from David Gustafsson <glasklas at gmail.com> --- (In reply to Jonathan Druart from comment #18) > What's the purpose of this line? > > 632 > $subscriptions_by_id{$field_value->record_id}->{additional_fields}- > >{$field_name} = $field_value->value; Additional fields are first prefetched for all subscription. This line assigns each additional field value to the subscription it belongs to, using a hash where subscriptions are indexed by id. It is not obvious to me how this code could be made more readable? Previously additional fields where fetched repeatedly for each subscription, by fetching them all at once there is only one database query instead of one per subscription, which is much more efficient. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:13:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:13:08 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-PUz6vg97An@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Owen Leonard <oleonard at myacpl.org> --- I would be in favor of a perfect solution being a later follow-up to a good solution! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:28:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:28:36 +0000 Subject: [Koha-bugs] [Bug 33837] Objects->filter_by_last_update: Does not allow time comparison In-Reply-To: <bug-33837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33837-70-xd9Wlse5ta@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:30:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:30:33 +0000 Subject: [Koha-bugs] [Bug 33832] Can't change a patron's username without entering passwords In-Reply-To: <bug-33832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33832-70-AjEzArA7do@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33832 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau at gmail.com --- Comment #1 from Sam Lau <samalau at gmail.com> --- It kind of makes sense that it behaves this way because it is on the "Change Password" page and not a page designed for just changing the username. The text at the bottom is just counterintuitive in my opinion. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:41:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:41:47 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-aulhx595sA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #16 from Owen Leonard <oleonard at myacpl.org> --- A few minor things: - use "fa fa-filter" icon for the "Show filters" link - the bulk actions controls (delete, modify) appear if you click a checkbox but not if you click "Select all" - The checkbox column should not be sortable (an existing bug) I like the choice to hide all the table controls until you click "Show filters" but I am concerned that others might miss the quick filter box. I hope others will comment on that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:42:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:42:01 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-AfdWIFtE1J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:43:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:43:39 +0000 Subject: [Koha-bugs] [Bug 20859] SMS and other notification preferences during self registration In-Reply-To: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20859-70-lHXw4kTGOU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151688&action=edit Bug 20859: Add SMSalertnumber to OPAC registration page This patch adds the SMS number field to patron self registration. To test: 1. Apply patch. 2. Make sure an SMSSendDriver 3. Go to the OPAC self registration form. 4. Notice the SMS Number field now appears. 5. Use the PatronSelfRegistrationBorrowerMandatoryField and PatronSelfRegistrationBorrowerUnwantedField system preferences to ensure you can hide the field and make it required. 6. Self register while adding a SMS number. Make sure that when you view the newly self-registered patron that the SMS number is properly populated in the staff interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:45:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:45:11 +0000 Subject: [Koha-bugs] [Bug 20859] SMS and other notification preferences during self registration In-Reply-To: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20859-70-oYpqaOeLuz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- I've submitted a patch that adds SMS number. Should we also add sms_provider_id here? What about messaging preferences? Should patrons be able to set those when self registering? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:48:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:48:34 +0000 Subject: [Koha-bugs] [Bug 33833] Remove T::D::C from t/SocialData.t In-Reply-To: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33833-70-SnFLqcYXwQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33833 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:48:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:48:36 +0000 Subject: [Koha-bugs] [Bug 33833] Remove T::D::C from t/SocialData.t In-Reply-To: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33833-70-fc0J86GO00@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33833 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151679|0 |1 is obsolete| | Attachment #151680|0 |1 is obsolete| | Attachment #151682|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151689&action=edit Bug 33833: Use database in t/Socialdata.t Remove T::D::C. Add subtests. Remove useless parameter from get_report call. Add two additional trivial tests. Note: The module C4::SocialData looks a bit weird. Test plan: Run t/SocialData.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:48:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:48:37 +0000 Subject: [Koha-bugs] [Bug 33833] Remove T::D::C from t/SocialData.t In-Reply-To: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33833-70-pAlpxhRji1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33833 --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151690&action=edit Bug 33833: Add two FIXMEs to SocialData::get_report Just comments, no test plan. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:48:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:48:39 +0000 Subject: [Koha-bugs] [Bug 33833] Remove T::D::C from t/SocialData.t In-Reply-To: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33833-70-mPuLZRQSW8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33833 --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151691&action=edit Bug 33833: Move to db_dependent Test plan: Run t/db_dependent/SocialData.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:50:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:50:16 +0000 Subject: [Koha-bugs] [Bug 33829] Cannot add patron to patron list if PatronAutoComplete is off In-Reply-To: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33829-70-4oL6L6yss8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33829 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:50:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:50:19 +0000 Subject: [Koha-bugs] [Bug 33829] Cannot add patron to patron list if PatronAutoComplete is off In-Reply-To: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33829-70-rdbUME1Jos@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33829 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151687|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151692&action=edit Bug 33829: Fix add patron to patron list if PatronAutoComplete is off When adding patrons to a patron list we get a JS error about undefined variables. We can easily fix this problem by defining them even if the pref is not set. We are enabling the auto complete even if PatronAutoComplete if off. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:51:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:51:27 +0000 Subject: [Koha-bugs] [Bug 33829] Cannot add patron to patron list if PatronAutoComplete is off In-Reply-To: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33829-70-Dkjth19cxx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33829 --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- Simple change that makes sense. Now works both with PatronAutoComplete on or off. QA script doesn't complain. Passing QA. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:55:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:55:45 +0000 Subject: [Koha-bugs] [Bug 33819] Accessibility: More description required in opac search breadcrumbs In-Reply-To: <bug-33819-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33819-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33819-70-Gd2Z6BieE8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33819 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:55:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:55:47 +0000 Subject: [Koha-bugs] [Bug 33819] Accessibility: More description required in opac search breadcrumbs In-Reply-To: <bug-33819-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33819-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33819-70-CedbRTk9MO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33819 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151637|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151693&action=edit Bug 33819: Add page numbers to opac results breadcrumb This patch adds the page number to the breadcrumb in the opac search results to ensure that it is unique to the content on the page. Currently it is not compliant to Accessibility guidelines as the breadcrumb is identical on every page despite the content being different. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:58:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:58:17 +0000 Subject: [Koha-bugs] [Bug 33818] Accessibility: Non descriptive title on ISBD detail In-Reply-To: <bug-33818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33818-70-3wrJ732a4Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33818 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 16:58:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 14:58:19 +0000 Subject: [Koha-bugs] [Bug 33818] Accessibility: Non descriptive title on ISBD detail In-Reply-To: <bug-33818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33818-70-794EwtBgyx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33818 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151632|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151694&action=edit Bug 33818: Descriptive title added to opac-ISBDdetail.tt This patch adds the biblio.title to the breadcrumb for the ISBD viewer. This now matches the normal and MARC views and is much clearer for screen readers. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 17:06:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 15:06:31 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-a2i7zBoWtL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau at gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 17:11:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 15:11:08 +0000 Subject: [Koha-bugs] [Bug 33697] Remove RecordedBooks (rbdigital) integration In-Reply-To: <bug-33697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33697-70-HfKGS6YZSU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33697 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 17:11:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 15:11:10 +0000 Subject: [Koha-bugs] [Bug 33697] Remove RecordedBooks (rbdigital) integration In-Reply-To: <bug-33697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33697-70-7tvEXGHbaK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33697 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151252|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151695&action=edit Bug 33697: Remove RecordedBooks (rbdigital) integration RecordedBooks search API integration is now obsolete following rbdigital's incorporation into OverDrive. Associated code should be removed. https://company.overdrive.com/2020/06/23/overdrive-to-acquire-rbdigital-from-rbmedia/ Test plan: use git grep extensively and confirm that this patch removes all occurrences of this feature. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 17:16:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 15:16:56 +0000 Subject: [Koha-bugs] [Bug 33239] Add the ability to run borrowers-force-messaging-defaults.pl only on a specified message name In-Reply-To: <bug-33239-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33239-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33239-70-v7EHT0Hu6e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33239 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 17:16:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 15:16:58 +0000 Subject: [Koha-bugs] [Bug 33239] Add the ability to run borrowers-force-messaging-defaults.pl only on a specified message name In-Reply-To: <bug-33239-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33239-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33239-70-Ns7Y15x2Yu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33239 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148250|0 |1 is obsolete| | --- Comment #3 from Sam Lau <samalau at gmail.com> --- Created attachment 151696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151696&action=edit Bug 33239: Add the ability to run borrowers-force-messaging-defaults.pl only on a specified message name Test plan: 1) Select a patron A 2) Change all the message prefs away from defaults. 3) Run misc/maintenance/borrowers-force-messaging-defaults.pl --doit --message-name Item_due Verify that patron A prefs changed only for 'Item due' Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 17:17:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 15:17:29 +0000 Subject: [Koha-bugs] [Bug 30581] Items should show on the Holds Queue and Holds to Pull even if they have requested transfers In-Reply-To: <bug-30581-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30581-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30581-70-hklHt93s2X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30581 --- Comment #4 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- (In reply to Martin Renvoize from comment #3) > I 'think' this is a duplicate of bug 33761.. any chance someone could test > with that and confirm my suspicions? I can confirm that this issue still exists in master after bug 33761. To recreate: 1 - have a bib with an available item 2 - place a hold on that bib 3 - confirm your item shows up on the holds queue 4 - use the Transfers interface to send the item to another branch (you'll be asked to confirm that you want to send it even though there's a hold) 5 - log into the SQL server and delete datesent from your transfer to kick it back to Pending (in the real world, an item would end up in this state due to stock rotation) 6 - confirm that the holdings table on your bib shows the item has a pending transfer 7 - confirm the title isn't on the holds queue anymore (run build_holds_queue if not using the realtime queue) 8 - check the item in and confirm that it does trigger the hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 17:34:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 15:34:02 +0000 Subject: [Koha-bugs] [Bug 17506] Offline circ needs to be logged In-Reply-To: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17506-70-cDGn9Ewsv3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506 --- Comment #6 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- Created attachment 151697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151697&action=edit Offline circ fule This koc file includes a checkout each to two different patrons and then the checkin of one of those items, all using the default testing data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 17:48:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 15:48:05 +0000 Subject: [Koha-bugs] [Bug 17506] Offline circ needs to be logged In-Reply-To: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17506-70-Ld1VTpZFIh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147842|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151698&action=edit Bug 17506: Offline circ needs to be logged Returns via offline circ are not logged. Test Plan: 1) Via offline circ * Return some items checked out to patrons * Check out some items that are currently checked out to other patrons 2) Apply the offline circs to Koha 3) Note the checkouts are logged, but not the returns 4) Apply this patch, restart all the things! 5) Repeat steps 1 and 2 6) Note the checkins are now logged both for returns and for checkouts where the item was checked out to a different patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 17:48:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 15:48:59 +0000 Subject: [Koha-bugs] [Bug 17506] Offline circ needs to be logged In-Reply-To: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17506-70-0St86DpZoF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151698|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151699&action=edit Bug 17506: Offline circ needs to be logged Returns via offline circ are not logged. Test Plan: 1) Via offline circ * Return some items checked out to patrons * Check out some items that are currently checked out to other patrons 2) Apply the offline circs to Koha 3) Note the checkouts are logged, but not the returns 4) Apply this patch, restart all the things! 5) Repeat steps 1 and 2 6) Note the checkins are now logged both for returns and for checkouts where the item was checked out to a different patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 17:57:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 15:57:41 +0000 Subject: [Koha-bugs] [Bug 17506] Offline circ needs to be logged In-Reply-To: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17506-70-0ixGxLPrwE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33838 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 [Bug 33838] Offline circulation interface error on return -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 17:57:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 15:57:41 +0000 Subject: [Koha-bugs] [Bug 33838] New: Offline circulation interface error on return Message-ID: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 Bug ID: 33838 Summary: Offline circulation interface error on return Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrewfh at dubcolib.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Blocks: 17506 Created attachment 151700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151700&action=edit check in item 3999900000001 The offline circ tool is behaving oddly when processing a return. The attached KOC file is just a return of barcode 3999900000001. To see the error: 1 - check item 3999900000001 out to a patron 2 - upload the attached KOC file 3 - navigate the Pending Offline Circ actions, see your return is listed 4 - click the checkbox to select your return 5 - click Process once. Nothing appears to happen 6 - in a new tab, pull up the bib for item 3999900000001, see that it has been checked in 7 - back on your Offline Circ tab, click Process a second time 8 - Koha tells you the item is not checked out Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506 [Bug 17506] Offline circ needs to be logged -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 17:59:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 15:59:31 +0000 Subject: [Koha-bugs] [Bug 33753] Intranet password expiration warning on patron accounts In-Reply-To: <bug-33753-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33753-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33753-70-ENX5w2uXIq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33753 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Password expiration warning |Intranet password | |expiration warning on | |patron accounts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 17:59:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 15:59:49 +0000 Subject: [Koha-bugs] [Bug 33753] Intranet password expiration warning on patron accounts In-Reply-To: <bug-33753-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33753-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33753-70-SR8H3VIhY5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33753 --- Comment #4 from Christopher Brannon <cbrannon at cdalibrary.org> --- Sorry about that! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:00:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:00:15 +0000 Subject: [Koha-bugs] [Bug 33752] OPAC Password expiration warning In-Reply-To: <bug-33752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33752-70-UiOPapfRy6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33752 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Password expiration warning |OPAC Password expiration | |warning -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:04:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:04:48 +0000 Subject: [Koha-bugs] [Bug 17506] Offline circ needs to be logged In-Reply-To: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17506-70-bOQ2dodOlL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506 --- Comment #9 from Christopher Brannon <cbrannon at cdalibrary.org> --- Haven't looked at this yet, but would it be helpful if offline circ file processing gave warnings on transactions that are older than the item's last timestamp? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:05:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:05:32 +0000 Subject: [Koha-bugs] [Bug 17506] Offline circ needs to be logged In-Reply-To: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17506-70-k5jktwNpVf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506 --- Comment #10 from Christopher Brannon <cbrannon at cdalibrary.org> --- Maybe in another bug??? Just wondering. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:08:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:08:54 +0000 Subject: [Koha-bugs] [Bug 17506] Offline circ needs to be logged In-Reply-To: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17506-70-etVfEuYsAL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- I see log entries for checkouts and for returns where the return was forced by a checkout to a different patron. I am not getting log entries for regular returns. Possibly related, a filed bug 33838 for some wonky display/interface stuff with returns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:12:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:12:14 +0000 Subject: [Koha-bugs] [Bug 33839] New: Local cover images not showing in search results Message-ID: <bug-33839-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33839 Bug ID: 33839 Summary: Local cover images not showing in search results Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org I think this might be caused by Bug 28314 To recreate: 1. Enable LocalCoverimages 2. Do a catalog search that will return a couple of results (in sandbox, I searched for Shakespeare) --> All results have "No cover image available" (this is normal so far) 3. Go into the first record 4. Add a cover image --> The cover image appears in the record details page 5. Redo the search from step 2 --> All results have "No cover image available"; the first result should have a cover image -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:13:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:13:09 +0000 Subject: [Koha-bugs] [Bug 33839] Local cover images not showing in search results In-Reply-To: <bug-33839-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33839-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33839-70-fMVaDNFsOd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33839 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Depends on| |28314 Severity|enhancement |normal Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28314 [Bug 28314] Spinning icon is not always going away for local covers in staff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:13:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:13:09 +0000 Subject: [Koha-bugs] [Bug 28314] Spinning icon is not always going away for local covers in staff In-Reply-To: <bug-28314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28314-70-gZIEsGCDNz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28314 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33839 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33839 [Bug 33839] Local cover images not showing in search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:32:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:32:32 +0000 Subject: [Koha-bugs] [Bug 33793] Add method to define limited access to run reports In-Reply-To: <bug-33793-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33793-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33793-70-IgP5U7gSY7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33793 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:33:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:33:27 +0000 Subject: [Koha-bugs] [Bug 33793] Add method to define limited access to run reports In-Reply-To: <bug-33793-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33793-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33793-70-efW2rqwC7y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33793 --- Comment #3 from Lisette Scheer <lisette.scheer at bywatersolutions.com> --- I think the "restricted access" flag would be a great way to go rather than groups. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:36:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:36:11 +0000 Subject: [Koha-bugs] [Bug 33838] Offline circulation interface error on return In-Reply-To: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33838-70-S8KMRUircV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- ==> /var/log/koha/kohadev/plack-error.log <== The method Koha::Item->renewals_count is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 925 Koha::Object::AUTOLOAD('Koha::Item=HASH(0x55e8cd9673b8)', 0) called at /kohadevbox/koha/C4/Circulation.pm line 4082 C4::Circulation::ProcessOfflineReturn('HASH(0x55e8cd676940)') called at /kohadevbox/koha/C4/Circulation.pm line 4054 C4::Circulation::ProcessOfflineOperation('HASH(0x55e8cd676940)') called at /kohadevbox/koha/offline_circ/process.pl line 42 eval {...} at /kohadevbox/koha/offline_circ/process.pl line 2 CGI::Compile::ROOT::kohadevbox_koha_offline_circ_process_2epl::__ANON__('CGI::Compile=HASH(0x55e8cda1f970)', '', '/kohadevbox/koha/offline_circ/process.pl', '/kohadevbox/koha/offline_circ', 'ARRAY(0x55e8cd836188)') called at /usr/share/perl5/CGI/Compile.pm line 151 CGI::Compile::ROOT::kohadevbox_koha_offline_circ_process_2epl::process_2epl at /usr/share/perl5/CGI/Emulate/PSGI.pm line 30 CGI::Emulate::PSGI::__ANON__('HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/App/WrapCGI.pm line 95 Plack::App::WrapCGI::call('Plack::App::WrapCGI=HASH(0x55e8cd79c308)', 'HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/App/CGIBin.pm line 50 Plack::App::CGIBin::serve_path('Plack::App::CGIBin=HASH(0x55e8c368b7f0)', 'HASH(0x55e8ce1266c8)', '/kohadevbox/koha/offline_circ/process.pl') called at /usr/share/perl5/Plack/App/File.pm line 34 Plack::App::File::call('Plack::App::CGIBin=HASH(0x55e8c368b7f0)', 'HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Middleware/LogWarn.pm line 22 Plack::Middleware::LogWarn::call('Plack::Middleware::LogWarn=HASH(0x55e8cd778bc0)', 'HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Middleware/Log4perl.pm line 30 Plack::Middleware::Log4perl::call('Plack::Middleware::Log4perl=HASH(0x55e8cd778ff8)', 'HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Middleware/HTTPExceptions.pm line 20 Plack::Middleware::HTTPExceptions::try {...} at /usr/share/perl5/Try/Tiny.pm line 100 eval {...} at /usr/share/perl5/Try/Tiny.pm line 93 Try::Tiny::try('CODE(0x55e8cda1c718)', 'Try::Tiny::Catch=REF(0x55e8cda986f0)') called at /usr/share/perl5/Plack/Middleware/HTTPExceptions.pm line 23 Plack::Middleware::HTTPExceptions::call('Plack::Middleware::HTTPExceptions=HASH(0x55e8cd778d58)', 'HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Middleware/ErrorDocument.pm line 15 Plack::Middleware::ErrorDocument::call('Plack::Middleware::ErrorDocument=HASH(0x55e8cd768138)', 'HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/App/URLMap.pm line 71 Plack::App::URLMap::call('Plack::App::URLMap=HASH(0x55e8cc324538)', 'HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8ce1266c8)') called at /kohadevbox/koha/Koha/Middleware/RealIP.pm line 64 Koha::Middleware::RealIP::call('Koha::Middleware::RealIP=HASH(0x55e8cd7678f8)', 'HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8ce1266c8)') called at /kohadevbox/koha/Koha/Middleware/SetEnv.pm line 105 Koha::Middleware::SetEnv::call('Koha::Middleware::SetEnv=HASH(0x55e8cda15358)', 'HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Middleware/Static.pm line 18 Plack::Middleware::Static::call('Plack::Middleware::Static=HASH(0x55e8cd7681c8)', 'HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Middleware/ReverseProxy.pm line 68 Plack::Middleware::ReverseProxy::call('Plack::Middleware::ReverseProxy=HASH(0x55e8cd768270)', 'HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Middleware/Lint.pm line 24 Plack::Middleware::Lint::call('Plack::Middleware::Lint=HASH(0x55e8c368b5c8)', 'HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Middleware/StackTrace.pm line 38 Plack::Middleware::StackTrace::try {...} at /usr/share/perl5/Try/Tiny.pm line 100 eval {...} at /usr/share/perl5/Try/Tiny.pm line 93 Try::Tiny::try('CODE(0x55e8cd836008)', 'Try::Tiny::Catch=REF(0x55e8cdc0ca70)') called at /usr/share/perl5/Plack/Middleware/StackTrace.pm line 42 Plack::Middleware::StackTrace::call('Plack::Middleware::StackTrace=HASH(0x55e8cc313ab8)', 'HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Middleware/AccessLog.pm line 27 Plack::Middleware::AccessLog::call('Plack::Middleware::AccessLog=HASH(0x55e8cc308eb0)', 'HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Util.pm line 145 eval {...} at /usr/share/perl5/Plack/Util.pm line 145 Plack::Util::run_app('CODE(0x55e8cc308d00)', 'HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Starman/Server.pm line 195 Starman::Server::dispatch_request('Starman::Server=HASH(0x55e8c30aaa38)', 'HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Starman/Server.pm line 298 Starman::Server::process_request('Starman::Server=HASH(0x55e8c30aaa38)', 'Net::Server::Proto::UNIX=GLOB(0x55e8cd97af18)') called at /usr/share/perl5/Net/Server.pm line 72 Net::Server::run_client_connection('Starman::Server=HASH(0x55e8c30aaa38)') called at /usr/share/perl5/Net/Server/PreFork.pm line 225 eval {...} at /usr/share/perl5/Net/Server/PreFork.pm line 225 Net::Server::PreFork::run_child('Starman::Server=HASH(0x55e8c30aaa38)') called at /usr/share/perl5/Net/Server/PreFork.pm line 183 Net::Server::PreFork::run_n_children('Starman::Server=HASH(0x55e8c30aaa38)', 2) called at /usr/share/perl5/Net/Server/PreFork.pm line 107 Net::Server::PreFork::loop('Starman::Server=HASH(0x55e8c30aaa38)') called at /usr/share/perl5/Net/Server.pm line 58 Net::Server::run('Starman::Server=HASH(0x55e8c30aaa38)', 'port', 'ARRAY(0x55e8c36357f8)', 'host', '*', 'proto', 'tcp', 'serialize', 'none', 'min_servers', 2, 'min_spare_servers', 1, 'max_spare_servers', 1, 'max_servers', 2, 'max_requests', 50, 'user', 'kohadev-koha', 'group', 'kohadev-koha', 'listen', 1024, 'check_for_waiting', 1, 'no_client_stdout', 1, 'setsid', 1, 'log_file', '/var/log/koha/kohadev/plack-error.log', 'background', 1, 'pid_file', '/var/run/koha/kohadev/plack.pid') called at /usr/share/perl5/Starman/Server.pm line 106 Starman::Server::run('Starman::Server=HASH(0x55e8c30aaa38)', 'CODE(0x55e8c30aa8e8)', 'HASH(0x55e8c30aa690)') called at /usr/share/perl5/Plack/Handler/Starman.pm line 25 Plack::Handler::Starman::run('Plack::Handler::Starman=HASH(0x55e8c30aa900)', 'CODE(0x55e8c30aa8e8)') called at /usr/share/perl5/Plack/Loader/Delayed.pm line 20 Plack::Loader::Delayed::run('Plack::Loader::Delayed=HASH(0x55e8c2df7d48)', 'Plack::Handler::Starman=HASH(0x55e8c30aa900)') called at /usr/share/perl5/Plack/Runner.pm line 279 Plack::Runner::run('Plack::Runner=HASH(0x55e8c2d94a68)') called at /usr/bin/starman line 38 at /usr/share/perl5/Exception/Class/Base.pm line 88 Exception::Class::Base::throw('Koha::Exceptions::Object::MethodNotCoveredByTests', 'error', 'The method Koha::Item->renewals_count is not covered by tests!', 'show_trace', 1) called at /kohadevbox/koha/Koha/Object.pm line 925 Koha::Object::AUTOLOAD('Koha::Item=HASH(0x55e8cd9673b8)', 0) called at /kohadevbox/koha/C4/Circulation.pm line 4082 C4::Circulation::ProcessOfflineReturn('HASH(0x55e8cd676940)') called at /kohadevbox/koha/C4/Circulation.pm line 4054 C4::Circulation::ProcessOfflineOperation('HASH(0x55e8cd676940)') called at /kohadevbox/koha/offline_circ/process.pl line 42 eval {...} at /kohadevbox/koha/offline_circ/process.pl line 2 CGI::Compile::ROOT::kohadevbox_koha_offline_circ_process_2epl::__ANON__('CGI::Compile=HASH(0x55e8cda1f970)', '', '/kohadevbox/koha/offline_circ/process.pl', '/kohadevbox/koha/offline_circ', 'ARRAY(0x55e8cd836188)') called at /usr/share/perl5/CGI/Compile.pm line 151 CGI::Compile::ROOT::kohadevbox_koha_offline_circ_process_2epl::process_2epl at /usr/share/perl5/CGI/Emulate/PSGI.pm line 30 CGI::Emulate::PSGI::__ANON__('HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/App/WrapCGI.pm line 95 Plack::App::WrapCGI::call('Plack::App::WrapCGI=HASH(0x55e8cd79c308)', 'HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/App/CGIBin.pm line 50 Plack::App::CGIBin::serve_path('Plack::App::CGIBin=HASH(0x55e8c368b7f0)', 'HASH(0x55e8ce1266c8)', '/kohadevbox/koha/offline_circ/process.pl') called at /usr/share/perl5/Plack/App/File.pm line 34 Plack::App::File::call('Plack::App::CGIBin=HASH(0x55e8c368b7f0)', 'HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Middleware/LogWarn.pm line 22 Plack::Middleware::LogWarn::call('Plack::Middleware::LogWarn=HASH(0x55e8cd778bc0)', 'HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Middleware/Log4perl.pm line 30 Plack::Middleware::Log4perl::call('Plack::Middleware::Log4perl=HASH(0x55e8cd778ff8)', 'HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Middleware/HTTPExceptions.pm line 20 Plack::Middleware::HTTPExceptions::try {...} at /usr/share/perl5/Try/Tiny.pm line 100 eval {...} at /usr/share/perl5/Try/Tiny.pm line 93 Try::Tiny::try('CODE(0x55e8cda1c718)', 'Try::Tiny::Catch=REF(0x55e8cda986f0)') called at /usr/share/perl5/Plack/Middleware/HTTPExceptions.pm line 23 Plack::Middleware::HTTPExceptions::call('Plack::Middleware::HTTPExceptions=HASH(0x55e8cd778d58)', 'HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Middleware/ErrorDocument.pm line 15 Plack::Middleware::ErrorDocument::call('Plack::Middleware::ErrorDocument=HASH(0x55e8cd768138)', 'HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/App/URLMap.pm line 71 Plack::App::URLMap::call('Plack::App::URLMap=HASH(0x55e8cc324538)', 'HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8ce1266c8)') called at /kohadevbox/koha/Koha/Middleware/RealIP.pm line 64 Koha::Middleware::RealIP::call('Koha::Middleware::RealIP=HASH(0x55e8cd7678f8)', 'HASH(0x55e8ce1266c8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8ce1266c8)') called at /kohadevbox/koha/Koha/Middleware/SetEnv.pm line 105 Koha::Middleware::SetEnv::call('Koha::Middleware::SetEnv=HASH(0x55e8cda15358)', 'HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Middleware/Static.pm line 18 Plack::Middleware::Static::call('Plack::Middleware::Static=HASH(0x55e8cd7681c8)', 'HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Middleware/ReverseProxy.pm line 68 Plack::Middleware::ReverseProxy::call('Plack::Middleware::ReverseProxy=HASH(0x55e8cd768270)', 'HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Middleware/Lint.pm line 24 Plack::Middleware::Lint::call('Plack::Middleware::Lint=HASH(0x55e8c368b5c8)', 'HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Middleware::StackTrace::try {...} at /usr/share/perl5/Try/Tiny.pm line 100 eval {...} at /usr/share/perl5/Try/Tiny.pm line 93 Plack::Middleware::StackTrace::call('Plack::Middleware::StackTrace=HASH(0x55e8cc313ab8)', 'HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Middleware/AccessLog.pm line 27 Plack::Middleware::AccessLog::call('Plack::Middleware::AccessLog=HASH(0x55e8cc308eb0)', 'HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Plack/Util.pm line 145 eval {...} at /usr/share/perl5/Plack/Util.pm line 145 Plack::Util::run_app('CODE(0x55e8cc308d00)', 'HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Starman/Server.pm line 195 Starman::Server::dispatch_request('Starman::Server=HASH(0x55e8c30aaa38)', 'HASH(0x55e8cd9c49b0)') called at /usr/share/perl5/Starman/Server.pm line 298 Starman::Server::process_request('Starman::Server=HASH(0x55e8c30aaa38)', 'Net::Server::Proto::UNIX=GLOB(0x55e8cd97af18)') called at /usr/share/perl5/Net/Server.pm line 72 Net::Server::run_client_connection('Starman::Server=HASH(0x55e8c30aaa38)') called at /usr/share/perl5/Net/Server/PreFork.pm line 225 eval {...} at /usr/share/perl5/Net/Server/PreFork.pm line 225 Net::Server::PreFork::run_child('Starman::Server=HASH(0x55e8c30aaa38)') called at /usr/share/perl5/Net/Server/PreFork.pm line 183 Net::Server::PreFork::run_n_children('Starman::Server=HASH(0x55e8c30aaa38)', 2) called at /usr/share/perl5/Net/Server/PreFork.pm line 107 Net::Server::PreFork::loop('Starman::Server=HASH(0x55e8c30aaa38)') called at /usr/share/perl5/Net/Server.pm line 58 Net::Server::run('Starman::Server=HASH(0x55e8c30aaa38)', 'port', 'ARRAY(0x55e8c36357f8)', 'host', '*', 'proto', 'tcp', 'serialize', 'none', 'min_servers', 2, 'min_spare_servers', 1, 'max_spare_servers', 1, 'max_servers', 2, 'max_requests', 50, 'user', 'kohadev-koha', 'group', 'kohadev-koha', 'listen', 1024, 'check_for_waiting', 1, 'no_client_stdout', 1, 'setsid', 1, 'log_file', '/var/log/koha/kohadev/plack-error.log', 'background', 1, 'pid_file', '/var/run/koha/kohadev/plack.pid') called at /usr/share/perl5/Starman/Server.pm line 106 Starman::Server::run('Starman::Server=HASH(0x55e8c30aaa38)', 'CODE(0x55e8c30aa8e8)', 'HASH(0x55e8c30aa690)') called at /usr/share/perl5/Plack/Handler/Starman.pm line 25 Plack::Handler::Starman::run('Plack::Handler::Starman=HASH(0x55e8c30aa900)', 'CODE(0x55e8c30aa8e8)') called at /usr/share/perl5/Plack/Loader/Delayed.pm line 20 Plack::Loader::Delayed::run('Plack::Loader::Delayed=HASH(0x55e8c2df7d48)', 'Plack::Handler::Starman=HASH(0x55e8c30aa900)') called at /usr/share/perl5/Plack/Runner.pm line 279 Plack::Runner::run('Plack::Runner=HASH(0x55e8c2d94a68)') called at /usr/bin/starman line 38 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:37:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:37:39 +0000 Subject: [Koha-bugs] [Bug 33838] Offline circulation interface error on return In-Reply-To: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33838-70-NeMeYSB7vC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Looks like the RM just needs to update the Schema files in master to fix this! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:37:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:37:46 +0000 Subject: [Koha-bugs] [Bug 33838] Offline circulation interface error on return In-Reply-To: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33838-70-J531oA2Djt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:40:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:40:38 +0000 Subject: [Koha-bugs] [Bug 33838] Offline circulation interface error on return In-Reply-To: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33838-70-sGi26dqWWb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Kyle M Hall from comment #2) > Looks like the RM just needs to update the Schema files in master to fix > this! I have have been mistaken about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:43:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:43:24 +0000 Subject: [Koha-bugs] [Bug 33779] Terminology: biblio record In-Reply-To: <bug-33779-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33779-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33779-70-ndEHs1TvDj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33779 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:43:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:43:26 +0000 Subject: [Koha-bugs] [Bug 33779] Terminology: biblio record In-Reply-To: <bug-33779-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33779-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33779-70-7gKKPUbKKo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33779 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151684|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151701&action=edit Bug 33779: Terminology: biblio record This patch corrects a string in the staff interface's ILL requests template. "This item cannot be issued as it has no biblio record associated with it" is updated to read "This item cannot be checked out as it has no bibliographic record associated with it." I don't know how to trigger the error message in the interface, but the change is simple enough that it could be verified by examining the patch. Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:44:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:44:35 +0000 Subject: [Koha-bugs] [Bug 33781] Terminology: Item already issued to other borrower. In-Reply-To: <bug-33781-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33781-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33781-70-BDIIbKg1X5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33781 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:44:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:44:37 +0000 Subject: [Koha-bugs] [Bug 33781] Terminology: Item already issued to other borrower. In-Reply-To: <bug-33781-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33781-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33781-70-z5Is0fKl8s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33781 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151683|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151702&action=edit Bug 33781: Terminology: Item already issued to other borrower. This patch updates a couple of error message strings so that they use the correct terminology and read well. "This item is on hold for another borrower." becomes "This item is on hold for another patron." "Item already issued to other borrower." becomes "This item is already checked out to another patron." To test, apply the patch and log into the OPAC as a patron who has items checked out which are available for renewal. In another tab, place a hold on one of those items on behalf of a different patron. Back in your OPAC tab, click the "Renew" link next to the title which is now on hold. The page should reload and show the updated message, "This item is on hold..." I was not able to trigger the other message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:49:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:49:15 +0000 Subject: [Koha-bugs] [Bug 33780] Multi-line TT comment: [%% item.object.itemnotes.replace('\n', ' In-Reply-To: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33780-70-tNjWUacQ03@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33780 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- This is an improvement so I will sign-off. Will let Katrin decide if this was what she initially reported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:49:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:49:39 +0000 Subject: [Koha-bugs] [Bug 33780] Multi-line TT comment: [%% item.object.itemnotes.replace('\n', ' In-Reply-To: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33780-70-QuVSHVDb58@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33780 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:49:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:49:41 +0000 Subject: [Koha-bugs] [Bug 33780] Multi-line TT comment: [%% item.object.itemnotes.replace('\n', ' In-Reply-To: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33780-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33780-70-IOSbkvvK1F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33780 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151677|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151703&action=edit Bug 33780: Use TT html_line_break filter to format itemnotes This patch removes a snippet of TT code which was causing problems with translation. Putting HTML inside a TT replace() method resulted in TT code being processed for translation. To test, apply the patch and edit an item record's public note field so that it contains line breaks ("\n"). Since the notes field in the editor is a text field, you might want to update the record in the database: update items set itemnotes = "Line 1\nLine 2\n\n\n\nLine 3" where biblionumber = 228; View the bibliographic details page in the staff interface. The note in the holdings table should have the correct line breaks. If you inspect the HTML you should see that each "\n" has been replaced with "<br />" Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:54:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:54:30 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: <bug-29393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29393-70-pz52RUhog6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |lucas at bywatersolutions.com --- Comment #28 from Lucas Gass <lucas at bywatersolutions.com> --- Merge conflicts in circ/add_message.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:56:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:56:20 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24401-70-rOf4iVPZeU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Depends on| |23336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 [Bug 23336] Add an API endpoint for checking an item out to a patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:56:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:56:20 +0000 Subject: [Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron In-Reply-To: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23336-70-Z1LpnwRb8R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24401 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 [Bug 24401] REST API: Check-in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 18:59:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 16:59:49 +0000 Subject: [Koha-bugs] [Bug 33839] Local cover images not showing in search results In-Reply-To: <bug-33839-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33839-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33839-70-2zqYW3Abmn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33839 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Looks like it's a me problem, sorry about that! The image just takes a while to show up... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 19:02:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 17:02:18 +0000 Subject: [Koha-bugs] [Bug 33838] Offline circulation interface error on return In-Reply-To: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33838-70-CXqqowUYkm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151704&action=edit Bug 33838: Don't reset the renewal count I cannot find any justification for this line existing. MarkIssueReturned does not do this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 19:05:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 17:05:33 +0000 Subject: [Koha-bugs] [Bug 32878] Make it impossible to renew the item if it has active item level hold In-Reply-To: <bug-32878-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32878-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32878-70-gyDi8Kmy2p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 --- Comment #20 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- (In reply to Laura Escamilla from comment #19) > Just following up to see if this can be backported to 22.11.x? Just wanted to check on this one again to see if it could be backported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 19:10:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 17:10:07 +0000 Subject: [Koha-bugs] [Bug 33838] Offline circulation interface error on return In-Reply-To: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33838-70-Ttjhd2J4cc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Resetting item's renewal count was introduced in bug 5877 with no explanation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 19:16:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 17:16:56 +0000 Subject: [Koha-bugs] [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider In-Reply-To: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32412-70-Vg0Q3yETp7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 --- Comment #12 from Owen Leonard <oleonard at myacpl.org> --- I'm not seeing any images in the shelf browser after this patch. In the console I see "Uncaught TypeError: parent.find is not a function" from coce.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 19:17:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 17:17:03 +0000 Subject: [Koha-bugs] [Bug 33838] Offline circulation interface error on return In-Reply-To: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33838-70-VPV5tNUrDM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 19:17:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 17:17:05 +0000 Subject: [Koha-bugs] [Bug 33838] Offline circulation interface error on return In-Reply-To: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33838-70-6WeLiljili@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151704|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151705&action=edit Bug 33838: Don't reset the renewal count I cannot find any justification for this line existing. MarkIssueReturned does not do this. Resetting item's renewal count was introduced in bug 5877 with no explanation. Test Plan: 1) Check out item 3999900000001 to a patron 2) Upload the KOC file attached to this bug report 3) Navigate the Pending Offline Circ actions, see your return is listed 4) Click the checkbox to select your return 5) Click Process once. Nothing appears to happen 6) In a new tab, pull up the bib for item 3999900000001, see that it has been checked in 7) Back on your Offline Circ tab, click Process a second time 8) Koha tells you the item is not checked out 9) Apply this patch, restart all the things! 10) Repeat steps 1-4, everything should now work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 19:48:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 17:48:09 +0000 Subject: [Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved In-Reply-To: <bug-32702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32702-70-8DTrCpqIwf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |andrewfh at dubcolib.org --- Comment #7 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- (In reply to Nick Clemens from comment #4) > > To test: > 1 - Setup a record with items to have: > 1 available item > 1 lost item > 1 item with positive not for loan status > 1 item with negative not for loan status > 1 item withdrawn > 1 item damaged > 1 item not for loan by itemtype > 2 - Attempt to place hold on staff and opac and note the statuses > 3 - Apply patch > 4 - Confirm the statuses have not changed > 5 - Attempt to hold lost/damaged/withdrawn/notforloan items via API > 6 - You should not be able to place the hold > 7 - Attempt to place club holds on these items - it should not be possible > 8 - Attempt to place holds via ILSDI - it should not be possible With these patches applied, I was able to create holds via API for all of these items, despite their statuses. I did get blocked from placing holds beyond the holds-per-record limit in the circ rules, but otherwise everything was permitted. Also, after the patches, in the staff client the lost and withdrawn items are showing new wording in the first column of the item selection table when placing a hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 19:53:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 17:53:02 +0000 Subject: [Koha-bugs] [Bug 33838] Offline circulation interface error on return In-Reply-To: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33838-70-yHa3sntzFx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 19:53:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 17:53:04 +0000 Subject: [Koha-bugs] [Bug 33838] Offline circulation interface error on return In-Reply-To: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33838-70-7OQDK06T9e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151705|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- Created attachment 151706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151706&action=edit Bug 33838: Don't reset the renewal count I cannot find any justification for this line existing. MarkIssueReturned does not do this. Resetting item's renewal count was introduced in bug 5877 with no explanation. Test Plan: 1) Check out item 3999900000001 to a patron 2) Upload the KOC file attached to this bug report 3) Navigate the Pending Offline Circ actions, see your return is listed 4) Click the checkbox to select your return 5) Click Process once. Nothing appears to happen 6) In a new tab, pull up the bib for item 3999900000001, see that it has been checked in 7) Back on your Offline Circ tab, click Process a second time 8) Koha tells you the item is not checked out 9) Apply this patch, restart all the things! 10) Repeat steps 1-4, everything should now work! Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 19:54:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 17:54:28 +0000 Subject: [Koha-bugs] [Bug 33840] New: UpdateItemLocationOnCheckin needs a duration and library parameters Message-ID: <bug-33840-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33840 Bug ID: 33840 Summary: UpdateItemLocationOnCheckin needs a duration and library parameters Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be nice if we could define in UpdateItemLocationOnCheckin how long the change takes effect. Either add a |0 for indefinite, or |60 for 60 minutes (enter the duration in minutes. Maybe also have a |[BRANCH,ETC] or |[ALL] parameter to indicate what branches this would affect. That way, you could specify which branches to apply which timings to. The reason for this is that the reset to permanent is currently done through a cron, so we can't see this in settings, and it is global. It affects everyone. Some libraries return items to the shelf sooner than others. We could streamline this to adjust to each libraries reshelving rate. I guess the only issue would be the trigger for this. Should a cron job be checking these updates, and should there be a minimum on how often this cron runs so that it doesn't bog down the system? Would it bog down the system looking for items in shelving location at a branch? Should it be limited to hours and not minutes? Also, should UpdateItemLocationOnCheckin be left as a global setting, and should we have a branch level setting in the branches setups? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:00:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 18:00:18 +0000 Subject: [Koha-bugs] [Bug 27663] statistics table should have some way to include items.permanent_location In-Reply-To: <bug-27663-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27663-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27663-70-ibFwoHKEJj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27663 --- Comment #7 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to George Williams (NEKLS) from comment #6) > items.permanent_location is not populated at libraries where the > cart-to-shelf function is not used, so I think it would be best as a system > preference, giving the library the choice of which one to use. That being > said, if both were populated in statistics, that would cover the issue > equally well. +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:00:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 18:00:32 +0000 Subject: [Koha-bugs] [Bug 27663] statistics table should have some way to include items.permanent_location In-Reply-To: <bug-27663-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27663-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27663-70-Z6NA592oPC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27663 --- Comment #8 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to George Williams (NEKLS) from comment #6) > items.permanent_location is not populated at libraries where the > cart-to-shelf function is not used, so I think it would be best as a system > preference, giving the library the choice of which one to use. That being > said, if both were populated in statistics, that would cover the issue > equally well. +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:02:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 18:02:20 +0000 Subject: [Koha-bugs] [Bug 33793] Add method to define limited access to run reports In-Reply-To: <bug-33793-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33793-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33793-70-X3WQqE8oX0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33793 --- Comment #4 from AspenCat Team <aspencatteam at clicweb.org> --- We would be interested in this as well. We haven't had a problem yet, but it is a potential concern that someone can get personal patron data from a library they don't work at. We would like to see this be secure and only staff who need to see that type of data, be able to see that type of data. - Bob Bennhoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:02:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 18:02:37 +0000 Subject: [Koha-bugs] [Bug 33793] Add method to define limited access to run reports In-Reply-To: <bug-33793-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33793-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33793-70-Vcm1wASLsY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33793 AspenCat Team <aspencatteam at clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:03:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 18:03:42 +0000 Subject: [Koha-bugs] [Bug 17506] Offline circ needs to be logged In-Reply-To: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17506-70-LIGMIbuiql@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506 --- Comment #12 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- Created attachment 151707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151707&action=edit log action error With 33838 patched the return logs correctly! I realized there's a tiny error with the return due to checkout to a different patron. It's recording "issue" for the action for that, instead of return. See attached screenshot in which item 3999900000002 is checked out to Edna via offline circ. The entry that's a checkout with no object should be a return. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:11:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 18:11:59 +0000 Subject: [Koha-bugs] [Bug 17506] Offline circ needs to be logged In-Reply-To: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17506-70-cZY4AoLisA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506 --- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #12) > Created attachment 151707 [details] > log action error > > With 33838 patched the return logs correctly! > I realized there's a tiny error with the return due to checkout to a > different patron. It's recording "issue" for the action for that, instead of > return. See attached screenshot in which item 3999900000002 is checked out > to Edna via offline circ. The entry that's a checkout with no object should > be a return. Are you testing with the latest version of the patch? I caught a bug in it earlier that is now fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:27:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 18:27:16 +0000 Subject: [Koha-bugs] [Bug 28206] Waiting holds should be filled at checkout even if they violate holds policies In-Reply-To: <bug-28206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28206-70-6yJJcl3OhH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28206 Katie Bliss <kebliss at dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:54:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 18:54:29 +0000 Subject: [Koha-bugs] [Bug 17506] Offline circ needs to be logged In-Reply-To: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17506-70-huhj0vgGIN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:54:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 18:54:31 +0000 Subject: [Koha-bugs] [Bug 17506] Offline circ needs to be logged In-Reply-To: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17506-70-QaKDi7t7GN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151699|0 |1 is obsolete| | --- Comment #14 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- Created attachment 151708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151708&action=edit Bug 17506: Offline circ needs to be logged Returns via offline circ are not logged. Test Plan: 1) Via offline circ * Return some items checked out to patrons * Check out some items that are currently checked out to other patrons 2) Apply the offline circs to Koha 3) Note the checkouts are logged, but not the returns 4) Apply this patch, restart all the things! 5) Repeat steps 1 and 2 6) Note the checkins are now logged both for returns and for checkouts where the item was checked out to a different patron Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 20:54:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 18:54:58 +0000 Subject: [Koha-bugs] [Bug 17506] Offline circ needs to be logged In-Reply-To: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17506-70-f3unjWkSmf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506 --- Comment #15 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- (In reply to Kyle M Hall from comment #13) > Are you testing with the latest version of the patch? Apparently not! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 21:00:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 19:00:39 +0000 Subject: [Koha-bugs] [Bug 33841] New: Add customization to serial routing slip Message-ID: <bug-33841-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33841 Bug ID: 33841 Summary: Add customization to serial routing slip Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be great if libraries could choose which fields/columns would show on the slip. For example if instead of date due a library wanted to show branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 25 21:04:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 19:04:36 +0000 Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32092-70-KAb0UA61Sl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 21:04:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 19:04:38 +0000 Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32092-70-YGzpqT2SWy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149782|0 |1 is obsolete| | Attachment #149783|0 |1 is obsolete| | Attachment #151197|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151709&action=edit Bug 32092: Improve circulation rules cache utilization To test: 1) Go to the page for placing a hold for a biblio with a large number of items 2) Depending on the number of items this page can be very slow to load 3) Ensure the following tests pass: t/db_dependent/Circulation.t t/db_dependent/Reserves.t t/db_dependent/Biblio.t t/db_dependent/Koha/Charges/Fees.t t/db_dependent/Koha/Charges/Fees.t t/db_dependent/Items.t t/db_dependent/Koha/Patron.t t/db_dependent/api/v1/checkouts.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Template/Plugin/CirculationRules.t t/db_dependent/Koha/CirculationRules.t 3) Apply the patch 4) The page loading time should now be significantly faster 5) Ensure all the tests in 3) still pass Sponsored-by: Gothenburg University Library Signed-off-by: Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 21:04:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 19:04:45 +0000 Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32092-70-QV4Lkd56Qz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092 --- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151710&action=edit Bug 32092: Fix tests Signed-off-by: Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 21:04:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 19:04:48 +0000 Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32092-70-mowHYWlbkn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092 --- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151711&action=edit Bug 32092: Fix uninitialized value in addition Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 21:38:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 19:38:04 +0000 Subject: [Koha-bugs] [Bug 33794] Holds Queue builder skips least cost branch unless target item's homebranch is patron's homebranch In-Reply-To: <bug-33794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33794-70-HY5Bm5uj8D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 25 21:38:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 19:38:07 +0000 Subject: [Koha-bugs] [Bug 33794] Holds Queue builder skips least cost branch unless target item's homebranch is patron's homebranch In-Reply-To: <bug-33794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33794-70-UH6Qxq6j0a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 --- Comment #1 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 151712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151712&action=edit Bug 33794: Removing line that causes TCM to pick the most expensive item if it means that it's going back to it's home branch. Test Plan: 1. Enable the UseTransportCostMatrix system preference 2. Ensure that there are at least three test libraries set up (Library A, Library B, Library C) 3. Set up the TCM so that it is cheaper to transport an item from Library A to Library C rather than from Library B to Library C. 4. Choose or create a biblio that has three items. 1. Item 1: 1. Set home library to Library C and the holding library to Library B — cost is more expensive 2. Item 2: 1. Set home library to Library A and the holding library is Library A - cost is least expensive (The TCM should be choosing this item) 3. Item 3: 1. Set home library to Library C and holding library to Library C, but check this item out to another patron so that it is unavailable. - Just a control variable. 5. Choose or create a patron that has their holds pickup library set to Library C. Place a hold on the biblio above for them. 6. Build the holds queue 7. The holds queue shows that Item 1 (most expensive) is being chosen over Item 2 (least expensive) 8. Delete the hold and apply the patch 9. Restart the services 10. Repeat step 5 11. Run the holds queue — it is now showing that Item 2 (least expensive) is being chosen over Item 1 (most expensive) 12. Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 00:11:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 22:11:11 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-9ckMjgall0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 00:11:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 22:11:14 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-zXLfMxbyoq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151329|0 |1 is obsolete| | --- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151713&action=edit Bug 33748: Fix UI issue when importing records from a staged MARC file This patch attempts to fix a UI issue on addorderiso2709.tt. It removes the <td> which contains the actoin buttons MARC, Card, and Add Order and adds them to the title line. This is so there is more space for the fieldsets. 1. Apply patch 2. Set MarcItemFieldsToOrder like this: homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 975$8 notforloan: 975$7 quantity: 975$q price: 975$g replacementprice: 975$v uri: 975$u 3. Stage a MARC file where the bibs have items attached 4. From acquisitions create a new basket and add 'From a staged file'. 5. Add the staged files to a basket. 6. Make sure the display looks correct. 7. Expand the data by clicking on the checkbox on the left hand side, or by clicking 'Select all'. 8. Make sure the display looks correct. 9. Tab over to 'Item informtion' and make sure that display looks correct. 10. Shrink the screen size down to less that 992px, ensuring the display remains correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 00:11:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 22:11:23 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-V8E0foYNSN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 00:11:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 22:11:28 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-lpDqYzNzUF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 00:11:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 22:11:34 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-48cwC3v7dz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 00:57:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 22:57:03 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-SkCT86yriH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151713|0 |1 is obsolete| | --- Comment #14 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 151714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151714&action=edit Bug 33748: Fix UI issue when importing records from a staged MARC file This patch attempts to fix a UI issue on addorderiso2709.tt. It removes the <td> which contains the actoin buttons MARC, Card, and Add Order and adds them to the title line. This is so there is more space for the fieldsets. 1. Apply patch 2. Set MarcItemFieldsToOrder like this: homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 975$8 notforloan: 975$7 quantity: 975$q price: 975$g replacementprice: 975$v uri: 975$u 3. Stage a MARC file where the bibs have items attached 4. From acquisitions create a new basket and add 'From a staged file'. 5. Add the staged files to a basket. 6. Make sure the display looks correct. 7. Expand the data by clicking on the checkbox on the left hand side, or by clicking 'Select all'. 8. Make sure the display looks correct. 9. Tab over to 'Item informtion' and make sure that display looks correct. 10. Shrink the screen size down to less that 992px, ensuring the display remains correct. Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 00:59:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 22:59:12 +0000 Subject: [Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page In-Reply-To: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33748-70-xnekU2eNCd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 01:37:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 23:37:09 +0000 Subject: [Koha-bugs] [Bug 20859] SMS and other notification preferences during self registration In-Reply-To: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20859-70-HUsp5F65lo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #10 from David Cook <dcook at prosentient.com.au> --- (In reply to Lucas Gass from comment #9) > What about messaging preferences? Should patrons be able to set those when > self registering? That would be pretty cool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 01:38:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 23:38:27 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-J3Gye3x89e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 --- Comment #14 from David Cook <dcook at prosentient.com.au> --- (In reply to Owen Leonard from comment #13) > I would be in favor of a perfect solution being a later follow-up to a good > solution! Agreed although I don't know if there is a perfect solution for this one! I'll look at QAing this shortly... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 01:42:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 May 2023 23:42:35 +0000 Subject: [Koha-bugs] [Bug 33793] Add method to define limited access to run reports In-Reply-To: <bug-33793-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33793-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33793-70-XL5VbfEYs9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33793 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook <dcook at prosentient.com.au> --- (In reply to AspenCat Team from comment #4) > We would be interested in this as well. We haven't had a problem yet, but > it is a potential concern that someone can get personal patron data from a > library they don't work at. We would like to see this be secure and only > staff who need to see that type of data, be able to see that type of data. - > Bob Bennhoff I was just thinking this same thing. Locally, we have a mechanism where reports that include "borrowers" need to use a token which is sent to a supervisor by email. That way, the supervisor knows who is running those potentially sensitive reports and when they're running them. (Kind of like some retail systems that require two people to authorize certain transactions.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 02:04:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 00:04:51 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-vpxWxLGALn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 02:04:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 00:04:54 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-imQ0WVsDzh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151642|0 |1 is obsolete| | --- Comment #15 from David Cook <dcook at prosentient.com.au> --- Created attachment 151715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151715&action=edit Bug 33815: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: David Cook <dcook at prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 02:04:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 00:04:57 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-yFOFBhdXQS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151643|0 |1 is obsolete| | --- Comment #16 from David Cook <dcook at prosentient.com.au> --- Created attachment 151716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151716&action=edit Bug 33815: Do not explode if logged in user modify their own userid If the logged in librarian modifies their own userid they will get the following error when submitting the form: Can't call method "password_expired" on an undefined value at /kohadevbox/koha/C4/Auth.pm line 1780 We could handle this situation and flag the session as expired. Better would be to deal with this specific user case and update the cookie (?) Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: David Cook <dcook at prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 02:10:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 00:10:18 +0000 Subject: [Koha-bugs] [Bug 33820] Add hints to warn the librarian that they will be logged out if they change their username In-Reply-To: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33820-70-ndlM4fy88W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #7 from David Cook <dcook at prosentient.com.au> --- Technically this works but the hints are very easy to miss/ignore. Even when I was looking for it, I didn't even notice it the first time or two. I think adding color, bolding, or maybe even a prefix like "Warning!" might help this to stand out. But perhaps that could be a follow up. Not enough of an issue to block this I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 02:11:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 00:11:00 +0000 Subject: [Koha-bugs] [Bug 33820] Add hints to warn the librarian that they will be logged out if they change their username In-Reply-To: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33820-70-BXqaI0EdOQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 02:11:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 00:11:03 +0000 Subject: [Koha-bugs] [Bug 33820] Add hints to warn the librarian that they will be logged out if they change their username In-Reply-To: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33820-70-QM335P5y1M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151685|0 |1 is obsolete| | --- Comment #8 from David Cook <dcook at prosentient.com.au> --- Created attachment 151717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151717&action=edit Bug 33820: Add hints to warn the librarian that they will be logged out if they change their username This patch adds some JavaScript to the patron entry form which adds a hint if the logged-in librarian tries to change their own username. It warns them that they will be logged out. To test, apply the patch and log into the staff interface. - Locate and edit your own patron record. - In the "OPAC/Staff interface login" section, change the value in the username field. When focus leaves that form field a hint should appear, "You will be logged out if you modify your username." - Change the username field back to your original username. The hint should disappear. - Confirm that submitting a username change works correctly: You should be logged out, and when you log in again your username should be updated. Signed-off-by: Sam Lau <samalau at gmail.com> Signed-off-by: David Cook <dcook at prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 02:11:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 00:11:06 +0000 Subject: [Koha-bugs] [Bug 33820] Add hints to warn the librarian that they will be logged out if they change their username In-Reply-To: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33820-70-bg131y5LvE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151686|0 |1 is obsolete| | --- Comment #9 from David Cook <dcook at prosentient.com.au> --- Created attachment 151718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151718&action=edit Bug 33820: (follow-up) Add hint to member-password.tt This follow-up makes the same change to the "Change password" template. Signed-off-by: Sam Lau <samalau at gmail.com> Signed-off-by: David Cook <dcook at prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 02:47:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 00:47:17 +0000 Subject: [Koha-bugs] [Bug 33834] api/v1/ill_requests.t fails randomly In-Reply-To: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33834-70-6SUsSlHo6U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 02:47:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 00:47:19 +0000 Subject: [Koha-bugs] [Bug 33834] api/v1/ill_requests.t fails randomly In-Reply-To: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33834-70-1yzabvsnwz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151678|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 151719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151719&action=edit Bug 33834: Fix random failure on api/v1/ill_requests.t This patch makes the GET request results more deterministic so we avoid random failures. It does so by adding a fixed value to each ILL request and then sorting by it. To test: 1. Run: $ DB_IMAGE=mysqli:8.0 ktd up -d # wait until it finished: $ ktd --logs 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/ill_requests.t (repeat a few times) => FAIL: It sometimes fails 3. Apply this patch 4. Repeat 2 => SUCCESS: It doesn't fail 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 05:10:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 03:10:49 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-3v6JxwqdNY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #11 from Aleisha Amohia <aleisha at catalyst.net.nz> --- I'm not sure why this was set to Patch doesn't apply, it applies cleanly on main for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 07:43:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 05:43:40 +0000 Subject: [Koha-bugs] [Bug 23100] Notify user if leaving modified patron edit form without saving In-Reply-To: <bug-23100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23100-70-YT3xBF4s7i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23100 Trigon <albintk33 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED CC| |albintk33 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 08:01:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 06:01:32 +0000 Subject: [Koha-bugs] [Bug 33833] Remove T::D::C from t/SocialData.t In-Reply-To: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33833-70-V39747Yr8Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33833 --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Owen Leonard from comment #7) > Signed-off-by: Owen Leonard <oleonard at myacpl.org> Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 08:04:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 06:04:14 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-VZpT64SQgb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Raising sev to major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 08:30:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 06:30:38 +0000 Subject: [Koha-bugs] [Bug 32878] Make it impossible to renew the item if it has active item level hold In-Reply-To: <bug-32878-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32878-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32878-70-Im6EdyxnAo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.07 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 08:30:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 06:30:40 +0000 Subject: [Koha-bugs] [Bug 32878] Make it impossible to renew the item if it has active item level hold In-Reply-To: <bug-32878-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32878-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32878-70-OOhPowDvv7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 08:42:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 06:42:04 +0000 Subject: [Koha-bugs] [Bug 33830] Title and author not on same line anymore In-Reply-To: <bug-33830-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33830-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33830-70-Yox281pV1G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33830 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Owen Leonard from comment #2) > Created attachment 151664 [details] > Screenshot showing author information duplicated on the same line > > This change was intentional. Ahhh OK no problem. We should do the same in staff interface maybe. I will close after some time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 09:48:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 07:48:17 +0000 Subject: [Koha-bugs] [Bug 33842] New: Search for authid not returning right results with QueryAutoTruncate ON Message-ID: <bug-33842-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33842 Bug ID: 33842 Summary: Search for authid not returning right results with QueryAutoTruncate ON Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: adolfo.rodriguez at xercode.es Conditions to replicate this bug: 1) Preference QueryAutoTruncate activated 2) Have authorities with low authids 3) ElasticSearch, though it should also happen with Zebra. You can try it on this demo, it's on the master branch. Intranet: https://intranet.koha-community.es OPAC: https://catalog.koha-community.es/ User demo/demo The following searchs return different results: 1) Search in the catalog an:1 The QueryAutoTruncate adds * so it returns all the biblios that use authorities with authids that begin with 1, which are 81. That doesn't make sense as those authorities have nothing in common. https://intranet.koha-community.es/cgi-bin/koha/catalogue/search.pl?q=an%3A1 2) The authority with the id 1 is Mika Ninagawa, if you search her in the Authorities module, it says the authority is being used in two records, which is correct. https://intranet.koha-community.es/cgi-bin/koha/authorities/authorities-home.pl?op=do_search&type=intranet&marclist=mainmainentry&and_or=and&excluding=&value=mika&authtypecode=&operator=contains&orderby=HeadingAsc 3) In the authority detail, Koha makes the same query as in point 1 so it appears it's being used in 81 records. https://intranet.koha-community.es/cgi-bin/koha/authorities/detail.pl?authid=1 I think this disparity in results can be confusing for librarians and readers, as they won't understand why Koha is recovering records that are unrelated to the author/subject... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 09:48:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 07:48:36 +0000 Subject: [Koha-bugs] [Bug 33514] SearchWithIS[B|S]NVariations breaks ISBN search in item search In-Reply-To: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33514-70-VSz2QSIYnZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #3) > (In reply to Katrin Fischer from comment #2) > > I am not sure what the best solution here is: > > What about making sure that normalized strings are always stored on the DB? > (i.e. no spaces, no symbols). It feels like GetVariationsOfISBN might be too > much in my opinion. I think that's not the main issue here, sorting differently would not resolve hte issue. We need to fix the search query. The problem is that we store a string of space separated ISBN and you can't search that with SQL without truncating/using LIKE. And that's what happens now and only works when there is only one ISBN on the record (which often is not the case at least for us) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 09:56:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 07:56:33 +0000 Subject: [Koha-bugs] [Bug 33837] Objects->filter_by_last_update: Does not allow time comparison In-Reply-To: <bug-33837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33837-70-p1cWFK3wVn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 09:56:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 07:56:35 +0000 Subject: [Koha-bugs] [Bug 33837] Objects->filter_by_last_update: Does not allow time comparison In-Reply-To: <bug-33837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33837-70-5YKgfnPizG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151720&action=edit Bug 33837: Add datetime comparison to filter_by_last_update Test plan: Verify that filter_by_last_update still works as expected by running cleanup_database.pl with --messages DAYS parameter. Look at the oldest messages.message_date (or insert one). Run with -days X where today - X is before that date. Run with -days Y where today - Y is just after it. Note: misc/cronjobs/cleanup_database.pl -confirm -messages -1 -v will remove all messages including one you inserted just now. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 09:56:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 07:56:37 +0000 Subject: [Koha-bugs] [Bug 33837] Objects->filter_by_last_update: Does not allow time comparison In-Reply-To: <bug-33837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33837-70-lUUnMyDEvw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151721&action=edit Bug 33837: Add unit test Test plan: Run t/db_dependent/Koha/Objects.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 09:56:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 07:56:39 +0000 Subject: [Koha-bugs] [Bug 33837] Objects->filter_by_last_update: Does not allow time comparison In-Reply-To: <bug-33837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33837-70-v374oaSmHh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151722&action=edit Bug 33837: filter_by_last_update: Add older_than and younger_than Test plan: Run t/db_dependent/Koha/Objects.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 09:56:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 07:56:41 +0000 Subject: [Koha-bugs] [Bug 33837] Objects->filter_by_last_update: Does not allow time comparison In-Reply-To: <bug-33837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33837-70-3GU7r1rVQi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151723&action=edit Bug 33837: Replace days_inclusive by min_days Instead of passing days and days_inclusive, this patch adds min_days as replacement. Since days_inclusive is not widely used, this can be done easily. It removes the confusion whether days_inclusive impacted other parameters or not. Test plan: Run t/db_dependent/Koha/Objects.t Run t/db_dependent/Koha/Old/Checkouts.t Run t/db_dependent/Koha/Patrons.t (verifying the change in the Koha::Patrons module for filtering by expiration date). Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 09:57:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 07:57:46 +0000 Subject: [Koha-bugs] [Bug 33842] Search for authid not returning right results with QueryAutoTruncate ON In-Reply-To: <bug-33842-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33842-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33842-70-tIObd57hc6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33842 Adolfo Rodríguez Taboada <adolfo.rodriguez at xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |adolfo.rodriguez at xercode.es |ity.org | --- Comment #1 from Adolfo Rodríguez Taboada <adolfo.rodriguez at xercode.es> --- Created attachment 151724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151724&action=edit Don't add * when searching an authid Change in the function _truncate_terms so it doesn't add * when searching an authid, as it's an autonumeric id so starting with the same numbers doesn't mean they are related. To test 1 Make sure the system preference QueryAutoTruncate is turned ON 2 Search an authority with a low id (1,2...) and see that the number of records in the results page and in the detail page don't match. 3 Apply patch, restart services 4 Repeat step 2 and check that the number of records now match. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 10:19:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 08:19:19 +0000 Subject: [Koha-bugs] [Bug 33843] New: Use filter_by_last_update in Koha::Notice::Util Message-ID: <bug-33843-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33843 Bug ID: 33843 Summary: Use filter_by_last_update in Koha::Notice::Util Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Resolve FIXME in sub _get_domain_count by using new datetime parameter from bug 33837. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 10:19:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 08:19:26 +0000 Subject: [Koha-bugs] [Bug 33843] Use filter_by_last_update in Koha::Notice::Util In-Reply-To: <bug-33843-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33843-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33843-70-MmlRerosIT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33843 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 10:22:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 08:22:06 +0000 Subject: [Koha-bugs] [Bug 33843] Use filter_by_last_update in Koha::Notice::Util In-Reply-To: <bug-33843-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33843-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33843-70-pyCggehqQA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33843 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 10:22:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 08:22:08 +0000 Subject: [Koha-bugs] [Bug 33843] Use filter_by_last_update in Koha::Notice::Util In-Reply-To: <bug-33843-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33843-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33843-70-O7TW8QqMVD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33843 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151725&action=edit Bug 33843: Use filter_by_last_update in Koha::Notice::Util Resolve FIXME in sub _get_domain_count by using new datetime parameter from bug 33837. Test plan: Run t/db_dependent/Koha/Notice_Util.t. This triggers the _get_domain_count call using the filter. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 10:22:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 08:22:22 +0000 Subject: [Koha-bugs] [Bug 33843] Use filter_by_last_update in Koha::Notice::Util In-Reply-To: <bug-33843-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33843-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33843-70-yRCUX9LfB2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33843 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33837 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 [Bug 33837] Objects->filter_by_last_update: Does not allow time comparison -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 10:22:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 08:22:22 +0000 Subject: [Koha-bugs] [Bug 33837] Objects->filter_by_last_update: Does not allow time comparison In-Reply-To: <bug-33837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33837-70-3fE50UT8zf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33837 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33843 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33843 [Bug 33843] Use filter_by_last_update in Koha::Notice::Util -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 11:49:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 09:49:02 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-j4TOcKU7Bg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 --- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- sub is_denied_renewal foreach my $field (keys %$denyingrules) { my $val = $self->$field; This is out of scope, but there is not even a check if it is a valid field. The method Koha::Item->a is not covered by tests! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:07:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 10:07:17 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-neGZyIv79X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:07:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 10:07:19 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-lsZtvaVw7V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150687|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151726&action=edit Bug 32478: Remove Koha::Config::SysPref->find since bypasses cache get_yaml_pref_hash also allows invalid YAML and only parses a limited subset so remove this method to avoid future issues. To test): Since tests already exists for C4::Context->yaml_preference and this is a trivial change, do we really need a test plan for this? Sponsored-by: Gothenburg University Library Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:07:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 10:07:22 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-ci3VjHQiGX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150688|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151727&action=edit Bug 32478: Fix handling of undef values in ItemsDeniedRenewal Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:07:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 10:07:25 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-AkXVlLYG0R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150689|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151728&action=edit Bug 32478: (follow-up) UpdateItemLocationOnCheckin no longer needs flattening This patch removes a line flattening the arrays generated by get_yaml_pref_hash as it is no longer necessary Conditionals are adjusted to avoid warnings in tests Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:07:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 10:07:27 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-bzPxoYzmrw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150690|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151729&action=edit Bug 32478: (follow-up) Tidy code Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:07:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 10:07:30 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-gtfb96MMTV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151136|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151730&action=edit Bug 32478: Fix syspref NULL values in tests Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:07:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 10:07:33 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-hITWk0cMSu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 --- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151731&action=edit Bug 32478: (QA follow-up) Shebang and chmod for Koha/Config/SysPrefs.t Test plan: Run t/db_dependent/Koha/Config/SysPrefs.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:07:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 10:07:35 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-NkHO7ndcNu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 --- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151732&action=edit Bug 32478: (QA follow-up) Keep current hashref behavior Prevent a crash on wrong contents for ItemsDeniedRenewal pref as we did before. Note: Could be a provisional measure (no band aid to repeat anywhere) until we resolve this in preferences.pl. Test plan: Without this patch: Change ItemsDeniedRenewal to 'nonsense' Run perl -MKoha::Items -e'Koha::Items->find(X)->is_denied_renewal; print "OK\n"' => Replace X by a valid itemnumber Crashes with: Can't use string ("nonsense") as a HASH ref ... No OK print. Apply this patch Run perl -MKoha::Items -e'Koha::Items->find(X)->is_denied_renewal; print "OK\n"' => Replace X by a valid itemnumber Warns only with: Hashref expected for ItemsDeniedRenewal. You got OK. Clear ItemsDeniedRenewal Try again. No warning anymore. Run t/Context.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:07:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 10:07:50 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-Sga8tbTjjz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:13:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 10:13:04 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-0kFCMKaKmA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 --- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to David Gustafsson from comment #17) > I see your point, but was it not already possible to make that code crash > (or even worse things) by for example using key values that does not exist > on the item object, or for example using "delete" as key :/ Hmm. You already said it. Read too quick. The delete example is even worse! Will add a report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:14:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 10:14:29 +0000 Subject: [Koha-bugs] [Bug 33844] New: item->is_denied_renewal should validate fields from associated pref Message-ID: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Bug ID: 33844 Summary: item->is_denied_renewal should validate fields from associated pref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See bug 32478. You could even add a field 'delete' in the pref. This is really bad. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:14:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 10:14:51 +0000 Subject: [Koha-bugs] [Bug 33844] item->is_denied_renewal should validate fields from associated pref In-Reply-To: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33844-70-c28Qy8mOKO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |glasklas at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:15:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 10:15:11 +0000 Subject: [Koha-bugs] [Bug 33844] item->is_denied_renewal should validate fields from associated pref In-Reply-To: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33844-70-AIquuWtIpx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:15:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 10:15:11 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-YzSYMBXeF8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 [Bug 33844] item->is_denied_renewal should validate fields from associated pref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:18:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 10:18:39 +0000 Subject: [Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache In-Reply-To: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32478-70-jkYubAQSu2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478 --- Comment #29 from David Gustafsson <glasklas at gmail.com> --- Ok, good! Yes, even though highly unlikely anyone would do that by mistake or malicious intent, but still serious issue. As wrote above get_column should be used here instead of dynamic method invokation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 12:58:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 10:58:29 +0000 Subject: [Koha-bugs] [Bug 33845] New: Hold notes should show when viewing a patron's hold list Message-ID: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Bug ID: 33845 Summary: Hold notes should show when viewing a patron's hold list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 13:36:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 11:36:09 +0000 Subject: [Koha-bugs] [Bug 31976] Incorrect default category selected by authorized values page In-Reply-To: <bug-31976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31976-70-414zkOGRrZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31976 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 13:40:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 11:40:11 +0000 Subject: [Koha-bugs] [Bug 30389] Switch to Bootstrap tabs on the page for adding orders from MARC file In-Reply-To: <bug-30389-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30389-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30389-70-dfTb3woQ4m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 13:41:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 11:41:00 +0000 Subject: [Koha-bugs] [Bug 32588] Filters on top of 'Items with no checkouts' report are untranslatable In-Reply-To: <bug-32588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32588-70-k2Y70YXdPU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32588 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 13:41:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 11:41:06 +0000 Subject: [Koha-bugs] [Bug 32215] 'You Searched for' for patron restrictions is not used In-Reply-To: <bug-32215-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32215-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32215-70-Wv45PNoyZ2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32215 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 13:55:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 11:55:19 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-7BeeF3cT3K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from Owen Leonard <oleonard at myacpl.org> --- When I run t/db_dependent/Stats.t I get an error: Cannot detect source of 't/db_dependent/Stats.t'! at /usr/share/perl/5.32/TAP/Parser/IteratorFactory.pm line 256. Am I doing something wrong? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:13:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:13:18 +0000 Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28966-70-bb9wdA4IHM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:13:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:13:21 +0000 Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28966-70-geDtaDJ2ch@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143859|0 |1 is obsolete| | Attachment #145395|0 |1 is obsolete| | --- Comment #29 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151733&action=edit Bug 28966: Add Koha::Object(s) for tmp_holdsqueue Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:13:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:13:24 +0000 Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28966-70-Nk9hiARwGl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #30 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151734&action=edit Bug 28966: Prefetch patron data for holds queue viewer Test Plan: 1) Generate the holds queue 2) Load the holds queue viewer page 3) Apply this patch 4) Restart all the things! 5) Reload the page 6) Note nothing has changed Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:17:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:17:59 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-TZaiFMGle3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135309|0 |1 is obsolete| | --- Comment #102 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151735&action=edit Bug 27378: Add new 'modaljs' syspref type This commit adds a new 'modaljs' syspref type. This is similar to the existing 'modalselect' syspref type but instead of using a file to create a list of selectable options which are displayed in the modal, it assumes that anything can happen within the modal driven by JS, and whatever happens is going to return a string, that will be saved as the syspref value. In our case, the string will be all the details of the “chunks” concatenated into a string Signed-ff-by: Barry Cannon <bc at interleaf.ie> (cherry picked from commit ec2dc19564a733a7d1db673331d41c3ae44235e1) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:18:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:18:04 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-GlBX5M1fEi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135310|0 |1 is obsolete| | --- Comment #103 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151736&action=edit Bug 27378: Add sysprefs This commit adds 4 new sysprefs: - CookieConsent - the master on/off for this functionality - ConsentJS - The configuration for JS code that requires consent prior to running. - CookieConsentBar: Allows the admin to specify the HTML that will be displayed in the consent bar that appears at the bottom of the page - CookieConsentPopup: Allows the admin to specify the HTML that will be displayed in the cookie consent popup Signed-ff-by: Barry Cannon <bc at interleaf.ie> (cherry picked from commit d17ee9aff67f99393aa47376a33764840eb2ab38) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:18:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:18:07 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-NsA2YIJx39@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135311|0 |1 is obsolete| | --- Comment #104 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151737&action=edit Bug 27378: Add JS to power modaljs This commit adds the Javascript that provides the functionality within the consentJS modaljs modal. It provides the ability to display the current state of any consentJS values and to amend them, as well as add new ones. There is also some refactoring of the existing modalselect functions to allow re-use of existing code between modalselect & modaljs. This refactoring has been minimal and consists of abstracting functionality into functions to allow more wide use. Styles for the consentJS UI were also added. Signed-ff-by: Barry Cannon <bc at interleaf.ie> (cherry picked from commit 16e78715c6bafba054104eadd1778599a75026da) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:18:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:18:11 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-yDwxaZxocw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135312|0 |1 is obsolete| | --- Comment #105 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151738&action=edit Bug 27378: Add cookie consent display to OPAC This commit adds the display of the cookie consent bar and modal to the OPAC. - Adds a new JSConsents template plugin that enables a template to be populated with the contents of the ConsentJS syspref in a prepared, usable form - Adds a new cookieconsent.js script that drives the display and functionality of the cookie consent bar and modal - Adds styles for the cookie consent bar and modal - Adds the creation and population of the cookie consent bar and modal, if appropriate - Adds the ability for both authenticated and unauthenticated users to view and modify their consents either via "your consents" or a new unobtrusive "Your cookies" button in the bottom right of the screen. - Adds unit test for JSConsents.pm Signed-ff-by: Barry Cannon <bc at interleaf.ie> (cherry picked from commit e8469e9997eaaefad834b9685e4906f89337bbc6) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:18:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:18:15 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-6kn4CVxZs7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135313|0 |1 is obsolete| | --- Comment #106 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151739&action=edit Bug 27378: Add cookie consent display to staff UI This commit adds the display of the cookie consent bar and modal to the staff interface: - Adds a new cookieconsent.js script that drives the display and functionality of the cookie consent bar and modal - Adds styles for the cookie consent bar and modal - Adds the creation and population of the cookie consent bar and modal, if appropriate Signed-ff-by: Barry Cannon <bc at interleaf.ie> (cherry picked from commit 40d4b094420ea1495996976434d250b15ee78c1b) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:18:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:18:18 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-BrNEUswFKT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135314|0 |1 is obsolete| | --- Comment #107 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151740&action=edit Bug 27378: Move "Your cookies" to existing bar The new "Your cookies" button that appeared at the bottom right when an unauthenticated user had made their cookie consent selections wasn't ideal. It has now been moved to the top bar, next to "Lists", this feels like a much more sensible place for it. Signed-ff-by: Barry Cannon <bc at interleaf.ie> (cherry picked from commit a663a7afa5fec005fed90b8a870e6633e133a539) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:18:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:18:22 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-9jCzNNI6Y4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135315|0 |1 is obsolete| | --- Comment #108 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151741&action=edit Bug 27378: Delete cookies when consent removed We have provided the ability for a user to remove previously granted consent, but we were not removing the cookie associated with that consent. This was a complete oversight on my part. I've introduced an additional bit of metadata for each "consent" defined in the ConsentJS syspref, this allows the admin defining a "consent" to specify a string (which is treated as a regex) that allows us to identify a cookie name associated with that consent. So, for example, if Google Analytics was being added, an identifying string might be '_ga'. This allows us to subsequently remove a cookie that a previously granted consent has set. This commit also adds some missing 'html' filters in koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc and koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc Signed-ff-by: Barry Cannon <bc at interleaf.ie> (cherry picked from commit 13bea186b66e1fd02ddad1327c073a64701edb12) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:18:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:18:26 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-jgXnl9qsr6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135316|0 |1 is obsolete| | --- Comment #109 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151742&action=edit Bug 27378: Add cookie domain and path A subtlety I missed was that some tracking services, such as Google Analytics, specify a cookie domain and path that differ from the default. E.g. on a site with a domain of demostaff.koha-ptfs.co.uk, the GA cookie will have a domain of '.koha-ptfs.co.uk' and a path of '/', even though the cookie may have been set at a different path. Both of these things makes sense, but of course unless we also specify both of those things when we try to delete a previously set cookie, we cannot. Therefore, I have added two more bits of metadata to each "consent", Cookie Domain and Cookie Path. It is necessary for an admin creating a "consent" entry to know and specify these values. They can be established by looking a cookie set by the service being configured. This adds more complexity to setting up a consent, but we cannot remove previously set cookies without it. Signed-ff-by: Barry Cannon <bc at interleaf.ie> (cherry picked from commit 2221f55646eb1675888725282005a613435ef0df) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:18:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:18:29 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-qIenYGg5FY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135317|0 |1 is obsolete| | --- Comment #110 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151743&action=edit Bug 27378: (follow-up) Fix update delimiter As suggested by Nick in Comment #64 (cherry picked from commit cf64bc373dcec60c51dccfe2e2f9359500c6cc9b) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:18:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:18:33 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-W2ldYFs0eU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135318|0 |1 is obsolete| | --- Comment #111 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151744&action=edit Bug 27378: (follow-up) Add missing filters (cherry picked from commit 6b8565b949b62269f6d850e6d412458d0dbcfb37) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:18:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:18:37 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-z5ZK9TCMOd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #112 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151745&action=edit Bug 27378: Fix heading structure of opac-patron-consent The current heading structure of opac-patron-consent.tt jumps straight from an h1 to an h5 for cookie consents. This has been changed to an h2 with scss updates to maintain formatting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:18:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:18:40 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-yJADfGvpfo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #113 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151746&action=edit Bug 27378: Fix missing bootstrap button classes This patch restores the background colour to buttons in the intranet where bootstrap classes were being overidden with a default of #fff. The colour of the the "More Information" button in the cookies bar and the "Accept selected non-essential cookies" button in the cookies modal have been changed slightly to comply with accessibility colour contrasts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:18:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:18:44 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-t0mNqGe7hY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #114 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151747&action=edit Bug 27378: Add missing aria-labels The checkboxes on the cookie consent modal were failing accessibility testing for not being labelled. This patch adds aria-labels to the checkboxes to satisfy the accessibility requirements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:18:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:18:51 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-YtaYFiyhrO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #115 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151748&action=edit Bug 27378: Add aria-label to more information button This patch adds an aria-label to the More Information button in order to comply with WCAG Accessibility guidelines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:18:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:18:55 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-3QObMs7TcW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #116 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151749&action=edit Bug 27378: Update to new atomicupdate structure This patch consolidates the previous 4 database update files into one atomicupdate file in line with the new structure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:18:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:18:59 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-sTODHX8yuM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #117 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151750&action=edit Bug 27378: Change ConsentJS to CookieConsentedJS This patch updates the name of the ConsentJS syspref to CookieConsentedJS and amends the description to be more clear what the syspref is for -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:19:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:19:03 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-RaOlu0zXKm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #118 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151751&action=edit Bug 27378: Stop the codemirror editor from duplicating Previously, if the "Add new code button" was clicked in the CookieConsentedJS editor, the original entry would have duplicated CodeMirror editors. This was exponential, i.e adding two new lines would result in three codemirror editors appearing on the first entry, two on the second and so on. The click event was not being applied properly and was being applied to every element with the .expand-textarea class, rather than specifically the new elements being created. The addExpandHandler function now loops through each element individually and decides whether to apply the click event handler. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:19:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:19:07 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-TjV33KLoJM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #119 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151752&action=edit Bug 27378: Prevent delete confirmation from duplicating Previously, if the "Add new code" button was clicked multipe times in the CookieConsentedJS editor and then those new items were deleted, the confirmation alert would show multiple times. This was an incremental issue, i.e. if 4 new items were deleted, then the first of those would require 4 confirmations to delete, the second would require 3 and so on. This is now prevented by looping through all delete buttons and avoiding duplicating the event listeners -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:19:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:19:11 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-EnxkyjUpgz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #120 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 151753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151753&action=edit Bug 27378: Remove two sysprefs and replace with html customisations Currently there are two sysprefs - CookieConsentBar and CookieConsentPopup. These allow the user to select what text they would like to see in the consent bar and modal. These have been removed and replaced with HTML customisations to allow more flexible customisations and different languages. Sponsored by: PTFS-Europe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:19:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:19:56 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-pWCaG4ITA2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #121 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- REVISED TEST PLAN ----------------- Note: As part of this test plan you will be required to remove a value from your browser's local storage store, we use this for storing a browser's cookie consent choice. To remove this value when instructed to do so, do the following: Chrome / Edge ------ - Press F12 or right click and choose “Inspect” - Click the "Application" tab - On the left, expand the "Local Storage" section - Find the entry that corresponds with the URL of your Koha and click on it - Find the entry in the list with a "Key" of "cookieConsent" - Click on it and press "Delete" on your keyboard Firefox ------- - Press F12 - Click the "Storage" tab - On the left, expand the "Local Storage" section - Find the entry that corresponds with the URL of your Koha and click on it - Find the entry in the list with a "Key" of "cookieConsent" - Click on it and press "Delete" on your keyboard Note: Also you will be required to inspect cookies set in your browser. When instructed to do so, do the following: Chrome / Edge ------ - Press F12 or right click and choose “Inspect” - Click the "Application" tab - On the left, expand the "Cookies" section - Find the entry that corresponds with the URL of your Koha and click on it - View the list of cookies Firefox ------- - Press F12 - Click the "Storage" tab - On the left, expand the "Cookies" section - Find the entry that corresponds with the URL of your Koha and click on it - View the list of cookies 1. Ensure you have a tab open on the intranet view and one open on the OPAC view, ensure you are logged in on both 2. Search for “cookieconsent" in the sysprefs => TEST: Observe there are 2 new sysprefs: - “CookieConsentedJS" - "CookieConsent" 3. Change the value for the "CookieConsent" syspref to "Require" and save 4. Refresh the intranet page => TEST: In the intranet view, observe that a cookie consent bar appears at the bottom of the page with just a single "Accept all cookies" button 5. Refresh the OPAC page => TEST: In the OPAC view, observe that a cookie consent bar appears at the bottom of the page with just a single "Accept all cookies" button 6. Navigate to Tools > HTML customisations 7. Click New entry 8. In Display location, select CookieConsentBar 9. Set the Publication Date for today’s date 10. Add some text to the text editor and click save 11. Refresh the intranet page => TEST: In the intranet view, observe that the cookie consent bar appears at the bottom of the page containing the text you specified 12. Refresh the OPAC page => TEST: In the OPAC view, observe that the cookie consent bar appears at the bottom of the page containing the text you specified 13. In the HTML customisations, repeat steps 7-10 but this time selecting CookieConsentPopup 14. Return to system preferences and search for “cookieconsent” again 15. Click the “CookieConsentedJS" syspref input 16. Click the "Add new code" link 17. Enter a name and description, and check both checkboxes. - For "String used to identify cookie name", enter "test1", this enables us to delete the cookie when consent is withdrawn. - For "Cookie domain" enter the domain of your Koha. - For "Cookie path" enter "/" 18. Click the "Click to expand" link 19. Enter the following Javascript: (function() { console.log('Hello from test1'); document.cookie = “test1=testing; domain=localhost; path=/; SameSite=None; Secure”; })(); N.B. IF YOUR DOMAIN IS NOT LOCALHOST, YOU WILL NEED TO CHANGE THIS TO YOUR CORRECT DOMAIN 20. Repeat steps 11 to 14 twice more, substituting "test1" for "test2" & "test3" 21. Click "Save" 22. Refresh the intranet page => TEST: In the intranet view, observe that the cookie consent bar appears at the bottom of the page containing 3 buttons 23. Refresh the OPAC page => TEST: In the OPAC view, observe that the cookie consent bar appears at the bottom of the page containing 3 buttons 24. Click the "More information" button => TEST: Observe that a cookie consent popup is displayed listing the codes you added in the syspref, displaying the name,description and checkbox for each, allowing a code to be selected 25. Select a code => TEST: Observe that "Accept selected non-essential cookies" is enabled 26. Deselect all codes => TEST: Observe that "Accept selected non-essential cookies" is disabled 27. Open the developer tools for your browser (usually F12) and ensure you are viewing the Javascript console 28. Click accept all cookies => TEST: In the Javascript console, observe that the messages in all the codes you added to the CookieConsentedJS syspref are displayed => TEST: In the cookie list (as detailed at the top of the test plan) observe that the cookies corresponding with the consents granted have been set. 29. Navigate to any other pages in the OPAC => TEST: On each page load, in the Javascript console, observe that the messages in all the codes you added to the ConsentJS syspref are displayed 30. Remove the cookieConsent local storage (as detailed at the start) 31. Switch to the intranet view 32. Repeat steps 19-25 in the intranet view 33. Refresh the page 34. Click the "Accept all cookies" button on the cookie bar => TEST: In the Javascript console, observe that the messages in all the codes you added to the CookieConsentedJS syspref are displayed 35. Remove the cookieConsent local storage (as detailed at the start) 36. Refresh the page 37. Click the "Accept only essential cookies" button on the cookie bar => TEST: In the Javascript console, observe that none of the messages in the codes you added to the CookieConsentedJS syspref are displayed 38. Remove the cookieConsent local storage (as detailed at the start) 39. Refresh the page 40. Click the "More information" button on the cookie bar 41. Select two of the codes you defined in the CookieConsentedJS syspref 42. Click the "Accept selected non-essential cookies" button => TEST: In the Javascript console, observe that only the messages from the selected codes you added to the CookieConsentedJS syspref are displayed 43. Repeat steps 28-37 on the OPAC view 44. In the OPAC view, go to the "Your account" page => TEST: Observe that the "your consents" option is available 45. Click on "your consents" => TEST: Observe that a "Cookie consents" section is displayed, with a button 46. Click the "View your cookie consents" button => TEST: Observe that the "Cookie consent" popup is displayed allowing you to modify your cookie consents 47. Remove consent from at least one cookie, click “Accept selected non-essential cookies” => TEST: In the cookie list in your browser (as detailed at the top of the test plan), observe that any cookies you removed consent from have either been removed or have no value. 48. Log out of the OPAC => Observe that a "Your cookies" button is displayed in the top bar next to "Links" 49. Click the "Your cookies" button => TEST: Observe that the "Cookie consent" popup is displayed allowing you to modify your cookie consents and that the consents match the same ones you had when logged in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:23:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:23:10 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-vukhX6KDs8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Owen Leonard from comment #20) > When I run t/db_dependent/Stats.t I get an error: > > Cannot detect source of 't/db_dependent/Stats.t'! at > /usr/share/perl/5.32/TAP/Parser/IteratorFactory.pm line 256. > > Am I doing something wrong? It seems so. I could reproduce it: root at master:/usr/share/koha# prove t/db_dependent/Koha/Statistics.t! Cannot detect source of 't/db_dependent/Koha/Statistics.t!'! at /usr/share/perl/5.32/TAP/Parser/IteratorFactory.pm line 256. This error signals running prove on a file that does not exist. Solution: Remove exclamation mark after .t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:23:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:23:26 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-0xScFClIRm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #122 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Quick summary of the new version as this has been idle for a while: - Rebased to latest master branch as of 26/05/23 - Accessibility fixes have been added where required - A glitch has been fixed with the codemirror editor where it was duplicating every time the "Add new code" button was pressed - Similarly, the confirmation alert for deleting new tracking code was also duplicating when the "Delete" button was pressed - Atomic update file has been revised to the new version - Two sysprefs removed and replaced with HTML customisations as per Katrin's last QA comments - One syspref renamed to make it clearer what it is for Setting back to Needs signoff as it has been on Failed QA for a while and I've made a few changes to the original concept -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:29:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:29:00 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33845-70-YNVwmo7257@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:29:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:29:02 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33845-70-hUGYAe9fh2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151754&action=edit Bug 33845: Display hold notes in staff client circulation paes This patch adds the reservenotes column to svc holds, and ensures they display on circulation and memeber details To test: 1 - Enable system preference 'OpacHoldNotes' 2 - Place a hold for a ptron via the OPAC 3 - View the patron in the staff client 4 - Click on the 'Holds' tab 5 - Ensure you can see the hold note 6 - Click on the 'Circulation' tab on the left 7 - Click the 'Holds' tab and confirm you can view the note -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:29:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:29:04 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33845-70-De1uqkxB4C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151755&action=edit Bug 33845: Display hold notes in OPAC This patch adds the holds notes to the patron's account holds list 1 - Ensure system preference 'OpacHoldNotes' is enabled 2 - Place a hold on the OPAC and add a note 3 - Confirm the note displays on the Summary page Holds tab of 'Your account' 4 - In staff client, disable system preference 'OpacHoldNotes' 5 - View Holds on patron's account in opac 6 - Confirm the note no longer shows -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:29:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:29:06 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33845-70-lXXaApTfS6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151756&action=edit Bug 33845: Use table settings and hide note by default This patch updates the holds table on circulation and moremembers to use table settings and hides the note column by default to preserve existing views To test: 1 - Apply patch 2 - Enable system preferece 'OpacHoldNotes' 3 - Place a hold on the opac and enter a note 4 - Confirm it shows on the patron's page 5 - View the patron in staff client 6 - Ensure the holds note does not display on Holds tab in Checkout or Details view 7 - Go to Admin->Table settings->Circulation 8 - Under holds_table confirm 'notes' is hidden by default 9 - Uncheck the box 10 - Refresh patron pages and confirm hold note shows -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:30:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:30:45 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33845-70-9oxKllc07F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:34:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:34:59 +0000 Subject: [Koha-bugs] [Bug 33834] api/v1/ill_requests.t fails randomly In-Reply-To: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33834-70-7wyvKakirQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:41:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:41:20 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33845-70-SyQpBXUZTO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151757&action=edit Bug 33845: (follow-up) escape hold notes for display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:44:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:44:27 +0000 Subject: [Koha-bugs] [Bug 27269] Move C4::Biblio::GetMarcSubjects to Koha namespace In-Reply-To: <bug-27269-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27269-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27269-70-ZK0QaVB0JY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Sorry this needs to be rebased again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:51:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:51:04 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-s2q55bCnrT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:51:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:51:06 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-3KIuPDZegh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 --- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:51:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:51:08 +0000 Subject: [Koha-bugs] [Bug 33823] KohaTable vue component action buttons spacing differ from kohaTable In-Reply-To: <bug-33823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33823-70-95boXNvHUA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33823 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:51:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:51:10 +0000 Subject: [Koha-bugs] [Bug 33823] KohaTable vue component action buttons spacing differ from kohaTable In-Reply-To: <bug-33823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33823-70-D0OZQY0unP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33823 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:51:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:51:12 +0000 Subject: [Koha-bugs] [Bug 33829] Cannot add patron to patron list if PatronAutoComplete is off In-Reply-To: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33829-70-xI9IIyKrSW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33829 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:51:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:51:14 +0000 Subject: [Koha-bugs] [Bug 33829] Cannot add patron to patron list if PatronAutoComplete is off In-Reply-To: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33829-70-A61fOuId4e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33829 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:51:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:51:16 +0000 Subject: [Koha-bugs] [Bug 33834] api/v1/ill_requests.t fails randomly In-Reply-To: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33834-70-auhT21eVeC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:51:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:51:18 +0000 Subject: [Koha-bugs] [Bug 33834] api/v1/ill_requests.t fails randomly In-Reply-To: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33834-70-FoeTo8U0kk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:52:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:52:16 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-rqXhcLlX2r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:52:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:52:18 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-uWSjhKarZg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151469|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151758&action=edit Bug 33783: (bug 8179 follow-up) Populate actual cost with ecost during receiving if not set This restores behavior prior to 8179 to use the estimated cost when receiving if the actual cost is not set. We set the unitprice in the table row so that it will be used when editing and will be saved even if not adjusted To test: 1 - Add some orders to a basket, do not set actual cost field 2 - Close basket, receive orders 3 - Note actual cost field is blank 4 - Cancel receipt 5 - Apply patch 6 - Receive again 7 - Note actual cost is populated 8 - Complete receipt and confirm actual cost correctly saved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:53:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:53:27 +0000 Subject: [Koha-bugs] [Bug 33830] Title and author not on same line anymore In-Reply-To: <bug-33830-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33830-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33830-70-wn1OZZrNPN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33830 --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Fridolin Somers from comment #4) > We should do the same in staff interface maybe. The staff interface already has this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 14:53:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 12:53:48 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-RkkUZMzIkF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Can we make this happen before wednesday? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 15:03:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 13:03:46 +0000 Subject: [Koha-bugs] [Bug 33844] item->is_denied_renewal should validate fields from associated pref In-Reply-To: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33844-70-F45fk03ZRQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 15:03:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 13:03:49 +0000 Subject: [Koha-bugs] [Bug 33844] item->is_denied_renewal should validate fields from associated pref In-Reply-To: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33844-70-6mL3YyG4a7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151759&action=edit Bug 33844: Modify test to show problem Add delete key. Without the follow-up, this triggers a delete. Test fails. DBIx::Class::Row::delete(): Not in database at /usr/share/koha/Koha/Object.pm line 234 Test plan: Run t/db_dependent/Koha/Item.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 15:03:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 13:03:51 +0000 Subject: [Koha-bugs] [Bug 33844] item->is_denied_renewal should validate fields from associated pref In-Reply-To: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33844-70-oWhhrlceSC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151760&action=edit Bug 33844: Fix is_denied_renewal Going via result_set->has_column does cost actually nothing if the object is already there. Test plan: Run again t/db_dependent/Koha/Item.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 15:04:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 13:04:07 +0000 Subject: [Koha-bugs] [Bug 33844] item->is_denied_renewal should validate fields from associated pref In-Reply-To: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33844-70-IN3pecx0b9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 15:05:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 13:05:26 +0000 Subject: [Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref In-Reply-To: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33844-70-MblIuP7T6r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|item->is_denied_renewal |item->is_denied_renewal |should validate fields from |should check column from |associated pref |associated pref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 15:41:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 13:41:44 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-fPOdAtrEGo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 15:41:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 13:41:46 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-gusw9pr9fn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151758|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151761&action=edit Bug 33783: (bug 8179 follow-up) Populate actual cost with ecost during receiving if not set This restores behavior prior to 8179 to use the estimated cost when receiving if the actual cost is not set. We set the unitprice in the table row so that it will be used when editing and will be saved even if not adjusted To test: 1 - Add some orders to a basket, do not set actual cost field 2 - Close basket, receive orders 3 - Note actual cost field is blank 4 - Cancel receipt 5 - Apply patch 6 - Receive again 7 - Note actual cost is populated 8 - Complete receipt and confirm actual cost correctly saved Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 15:46:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 13:46:38 +0000 Subject: [Koha-bugs] [Bug 33846] New: 'Save' and 'close' buttons confusing on multi-receive Message-ID: <bug-33846-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 Bug ID: 33846 Summary: 'Save' and 'close' buttons confusing on multi-receive Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org I'm opening this so we don't forget. Talking with Kyle and Nick, we agreed the 'Save' button is weird, in the sense that it is not saving but updating the underlying table which can then be used to receive. And there's the 'Close' button, that seems to be doing the same thing i.e. closing the modal. Plus, there's no real way of 'resetting' your changes which is the usual thing we have: a confirm button and a cancel. I'm not sure what is the best solution here, but we could have: - Close (which updates the underlying table) - Cancel link (which resets any changes you've made) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 15:47:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 13:47:24 +0000 Subject: [Koha-bugs] [Bug 33846] 'Save' and 'close' buttons confusing on multi-receive In-Reply-To: <bug-33846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33846-70-ctX65Khq9H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano at theke.io, | |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com, | |tomascohen at gmail.com Depends on| |8179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 15:47:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 13:47:24 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-r4WxNUxUEw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 [Bug 33846] 'Save' and 'close' buttons confusing on multi-receive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 16:00:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 14:00:43 +0000 Subject: [Koha-bugs] [Bug 33524] Use template wrapper for tabs: Authority editor In-Reply-To: <bug-33524-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33524-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33524-70-qTke0MIdlf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33524 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |33525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33525 [Bug 33525] Use template wrapper for tabs: Basic MARC editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 16:00:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 14:00:43 +0000 Subject: [Koha-bugs] [Bug 33525] Use template wrapper for tabs: Basic MARC editor In-Reply-To: <bug-33525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33525-70-AziHwVoeBu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33525 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33524 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33524 [Bug 33524] Use template wrapper for tabs: Authority editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 16:04:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 14:04:33 +0000 Subject: [Koha-bugs] [Bug 33524] Use template wrapper for tabs: Authority editor In-Reply-To: <bug-33524-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33524-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33524-70-Uy51Y9zxPO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33524 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 16:04:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 14:04:36 +0000 Subject: [Koha-bugs] [Bug 33524] Use template wrapper for tabs: Authority editor In-Reply-To: <bug-33524-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33524-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33524-70-8MTq9iAmXv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33524 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151762&action=edit Bug 33524: Use template wrapper for tabs: Authority editor This patch updates the authority editor template to replace tab markup with the use of WRAPPERs. Some CSS and JS has been modified in order to make the custom style and behavior of the tabs on this page work correctly with standard Bootstrap tab markup. To test, apply the patch and go to Authorities -> New authority. - Confirm that the tabs look correct, with the same style they had before the template change. - The first tab ("0") should be selected by default. - Confirm that tab-switching works correctly: The tab color should change and the list of numbered tags in the menu just below should change to match the section. - Confirm that these tag number links still work correctly to jump you down the page to the corresponding tag. - Without filling in any mandatory fields, click the "Save" button. - You should get an error message about missing mandatory fields. - Clicking the "Go to field" link should take you to the correct tab and the correct tag. - Append a hash to the URL to pre-select a tab other than the first one, e.g. "/cgi-bin/koha/authorities/authorities.pl?authtypecode=PERSO_NAME#tab5XX_panel" The correct tab should be selected upon page load. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 16:06:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 14:06:39 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-wYSbfvgFhs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #27 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- It didn't make any difference unfortunately, the key functionality is the same as the v-select so the same issues arose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 16:08:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 14:08:13 +0000 Subject: [Koha-bugs] [Bug 29941] Automatic item modification by age should be able to set a value to NULL In-Reply-To: <bug-29941-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29941-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29941-70-tTz9M4ORoW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29941 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27347 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 16:08:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 14:08:13 +0000 Subject: [Koha-bugs] [Bug 27347] Allow automatic item modification by age to match NULL values In-Reply-To: <bug-27347-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27347-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27347-70-aFU0JmzcPD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27347 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29941 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 16:11:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 14:11:54 +0000 Subject: [Koha-bugs] [Bug 33846] 'Save' and 'close' buttons confusing on multi-receive In-Reply-To: <bug-33846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33846-70-Nw52V1p3iX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 16:12:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 14:12:12 +0000 Subject: [Koha-bugs] [Bug 33846] 'Save' and 'close' buttons confusing on multi-receive In-Reply-To: <bug-33846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33846-70-f5OPIoDcTT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 16:25:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 14:25:27 +0000 Subject: [Koha-bugs] [Bug 23305] Add ability to append to item notes in batch item modification In-Reply-To: <bug-23305-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23305-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23305-70-S0nt2hx2Fx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23305 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- This is possible since bug 29781. Using capturing groups in a regex substitution, one can basically say "replace the current note with the current note plus these new words." A very basic example, if one wanted to append the text "Disc cleaned 5-26-23" to all notes on a group of items, one could put "(.*)" in the Regex Pattern and "$1 Disc Cleaned 5-26-23" in the Regex Replacement in the item batch mod interface. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 16:47:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 14:47:07 +0000 Subject: [Koha-bugs] [Bug 33788] moredetail.pl shows all (many?) previous borrowers instead of 3 In-Reply-To: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33788-70-o5H1ujshz7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 16:47:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 14:47:09 +0000 Subject: [Koha-bugs] [Bug 33788] moredetail.pl shows all (many?) previous borrowers instead of 3 In-Reply-To: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33788-70-qUjwFSuezx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151763&action=edit Bug 33788: Limit the number of old issues rows returned This patch updates the parameter from 'limit' to 'rows' To test: 1 - Checkout an item to 5 different people 2 - View item details on items tab of record 3 - Note you see last borrower, and three previous borrowers 4 - Apply patch, restart all 5 - Refresh page 6 - You shoulw now only see last borrower and 2 previous borrowers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 16:48:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 14:48:43 +0000 Subject: [Koha-bugs] [Bug 33788] moredetail.pl shows all (many?) previous borrowers instead of 3 In-Reply-To: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33788-70-VPtnG6BJ4N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32272 CC| |nick at bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 16:48:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 14:48:43 +0000 Subject: [Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken In-Reply-To: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32272-70-EEbuHHtIpG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 [Bug 33788] moredetail.pl shows all (many?) previous borrowers instead of 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 17:41:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 15:41:57 +0000 Subject: [Koha-bugs] [Bug 33847] New: Database update replaces undefined rules with defaults rather than the value that would be used Message-ID: <bug-33847-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 Bug ID: 33847 Summary: Database update replaces undefined rules with defaults rather than the value that would be used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 29012 introduces a database update that sets the default values for rules that are required but undefined. This functionally changes the results of the circulation rules. Instead, this update should find value that is being used for that rule combo and use that as the rule value, only using the default in the case that the derived rule doesn't exist or has a null value. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 17:44:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 15:44:15 +0000 Subject: [Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used In-Reply-To: <bug-33847-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33847-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33847-70-zrPAxnXWWz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29012 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 17:44:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 15:44:15 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29012-70-EEZKEC8iiI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 17:49:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 15:49:33 +0000 Subject: [Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used In-Reply-To: <bug-33847-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33847-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33847-70-zLrMOX3HaM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 17:49:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 15:49:35 +0000 Subject: [Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used In-Reply-To: <bug-33847-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33847-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33847-70-xsRgc0ESjx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151764&action=edit Bug 33847: Database update replaces undefined rules with defaults rather than the value that would be used Bug 29012 introduces a database update that sets the default values for rules that are required but undefined. This functionally changes the results of the circulation rules. Instead, this update should find value that is being used for that rule combo and use that as the rule value, only using the default in the case that the derived rule doesn't exist or has a null value. Test Plan: 1) Check out Koha 22.05.05 2) Create a default all/all/all rule, 3 other rules. Ensure they all have issuelength set to 7, with one of the non-default rules having an issuelength of 14. 3) Delete all but one of the non-default rules with the following query: Delete from circulation_rules where rule_name = 'issuelength' and ( issuelength != 14 or ( branchcode is null and categorycode is null and itemtype is null ) ) limit 2; 4) Check out Koha 22.05.06 4) Run updatedatabase.pl 5) Note the rules were recreated with the value 0 6) Repeat steps 1-4 7) Apply this patch 8) Run updatedatabase.pl 9) Note the rules were recreated, but the value is the derived value from the all/all/all rule! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 17:49:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 15:49:52 +0000 Subject: [Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used In-Reply-To: <bug-33847-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33847-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33847-70-UyoA4fNVsC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 17:54:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 15:54:36 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33845-70-hVx2dVFZMY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 17:54:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 15:54:38 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33845-70-eWzzI1EcAT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151754|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- Created attachment 151765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151765&action=edit Bug 33845: Display hold notes in staff client circulation paes This patch adds the reservenotes column to svc holds, and ensures they display on circulation and memeber details To test: 1 - Enable system preference 'OpacHoldNotes' 2 - Place a hold for a ptron via the OPAC 3 - View the patron in the staff client 4 - Click on the 'Holds' tab 5 - Ensure you can see the hold note 6 - Click on the 'Circulation' tab on the left 7 - Click the 'Holds' tab and confirm you can view the note Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 17:54:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 15:54:40 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33845-70-1N4nfsYIJb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151755|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- Created attachment 151766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151766&action=edit Bug 33845: Display hold notes in OPAC This patch adds the holds notes to the patron's account holds list 1 - Ensure system preference 'OpacHoldNotes' is enabled 2 - Place a hold on the OPAC and add a note 3 - Confirm the note displays on the Summary page Holds tab of 'Your account' 4 - In staff client, disable system preference 'OpacHoldNotes' 5 - View Holds on patron's account in opac 6 - Confirm the note no longer shows Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 17:54:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 15:54:42 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33845-70-WGMrgnOIeF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151756|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- Created attachment 151767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151767&action=edit Bug 33845: Use table settings and hide note by default This patch updates the holds table on circulation and moremembers to use table settings and hides the note column by default to preserve existing views To test: 1 - Apply patch 2 - Enable system preferece 'OpacHoldNotes' 3 - Place a hold on the opac and enter a note 4 - Confirm it shows on the patron's page 5 - View the patron in staff client 6 - Ensure the holds note does not display on Holds tab in Checkout or Details view 7 - Go to Admin->Table settings->Circulation 8 - Under holds_table confirm 'notes' is hidden by default 9 - Uncheck the box 10 - Refresh patron pages and confirm hold note shows Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 17:54:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 15:54:44 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33845-70-832NBayUU1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151757|0 |1 is obsolete| | --- Comment #8 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- Created attachment 151768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151768&action=edit Bug 33845: (follow-up) escape hold notes for display Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 18:57:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 16:57:20 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-YVw6NVggF8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 --- Comment #37 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 151769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151769&action=edit Bug 33117: Adding new PatronAutoCompleteSearchMethod system preference Test Plan: 0. Ensure system preference PatronAutoComplete is set to Try 1. Create a patron that has a first name, middle name and two surnames. (i.e. Adela Maria, Hernandez Acosta). 2. In patron or checkout search, enter their first name and first surname without submitting. 3. Confirm that a record is found in the autocomplete results 4. In patron or checkout search, enter their first name and second surname without submitting. 5. Confirm that no record is found. 6. Enter their middle name and first surname. Confirm that no record is found. 7. Enter their middle name and second surname. Confirm that no record is found. 8. Apply the patch, update database 9. Under Administration > Global System Preferences > search for "PatronAutocompleteSearchMethod" 10. Choose "Contains" instead of "Starts with" for the system preference, reload your search page 11. Repeat steps 2-4. The patron record should appear for all search methods. 12. Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 18:59:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 16:59:30 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-2aLPoDcKJb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151317|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 19:10:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 17:10:35 +0000 Subject: [Koha-bugs] [Bug 16243] Add reference manager software (Mendeley and EasyBib) to OPAC In-Reply-To: <bug-16243-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16243-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16243-70-w48WDTOnB0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16243 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 19:18:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 17:18:12 +0000 Subject: [Koha-bugs] [Bug 33775] Different/no results between Check Out and Search Patron when searching for names with spaces In-Reply-To: <bug-33775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33775-70-QNJ4QZoKuZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33775 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- This might be bug 33117 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 19:24:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 17:24:14 +0000 Subject: [Koha-bugs] [Bug 33848] New: Enabling Coce in the OPAC breaks cover images on bibliographic detail page Message-ID: <bug-33848-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 Bug ID: 33848 Summary: Enabling Coce in the OPAC breaks cover images on bibliographic detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: andrew.auld at ptfs-europe.com, jbalway at gmail.com, jonathan.druart+koha at gmail.com, lucas at bywatersolutions.com, testopia at bugs.koha-community.org Depends on: 32412 If you enable multiple cover image services, including Coce, the bibliographic detail page in the OPAC doesn't display all covers. Viewing a title with Amazon, Google, Coce, and OpenLibrary, only the Amazon and Google images display. In the console is an error message: Uncaught TypeError: parent.find is not a function getURL http://localhost:8080/opac-tmpl/bootstrap/js/coce_22.1200048.js:20 The script stops processing other sources when Coce fails. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 19:24:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 17:24:14 +0000 Subject: [Koha-bugs] [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider In-Reply-To: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32412-70-YUOtqtn7ms@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33848 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 [Bug 33848] Enabling Coce in the OPAC breaks cover images on bibliographic detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 20:04:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 18:04:26 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-AhIiWRK0en@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 --- Comment #22 from Owen Leonard <oleonard at myacpl.org> --- I did not run the command with an extra exclamation mark. > Cannot detect source of 't/db_dependent/Stats.t'! The exclamation mark is added by the error message. I guess I assumed that Stats.t existed because the test plan said so: > Test plan: > Run t/db_dependent/Stats.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 20:31:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 18:31:42 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-2ASrL0ef2K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 --- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Owen Leonard from comment #22) > I did not run the command with an extra exclamation mark. > > > Cannot detect source of 't/db_dependent/Stats.t'! > > The exclamation mark is added by the error message. > > I guess I assumed that Stats.t existed because the test plan said so: > > > Test plan: > > Run t/db_dependent/Stats.t t/db_dependent/Koha/Statistics.t | 144 +++++++++++++++++++++----- t/db_dependent/Stats.t | 168 ------------------------------- 2 files changed, 119 insertions(+), 193 deletions(-) delete mode 100755 t/db_dependent/Stats.t They are merged in the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 21:08:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 19:08:39 +0000 Subject: [Koha-bugs] [Bug 32695] Search string for 775 'Other editions' is incorrectly formed In-Reply-To: <bug-32695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32695-70-wrhIL00BJw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32695 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 21:08:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 19:08:41 +0000 Subject: [Koha-bugs] [Bug 32695] Search string for 775 'Other editions' is incorrectly formed In-Reply-To: <bug-32695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32695-70-IblHIlGumR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32695 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151770&action=edit Bug 32695: Use title (subfield t) only for 'Other editions' search links Currently the code does a title phrase search, but combines the title field with the Main Entry (author) field. This patch simply limits the search to the title to ensure links work To test: 1 - Ensure systme preference 'UseControlNumber' is set to don't 2 - Edit Default MARC framework in administration->Marc frameworks 3 - Make 775 subfields a & t visible in editor 4 - Edit a record to add a field 775 with subfields a & t that match another title/author in your system 5 - Save the record and view the details page 6 - Click the other editions link - no results 7 - Apply patch, restart_all 8 - Reload details and confirm the link works -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 21:08:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 19:08:49 +0000 Subject: [Koha-bugs] [Bug 32695] Search string for 775 'Other editions' is incorrectly formed In-Reply-To: <bug-32695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32695-70-iHcoWtJJbU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32695 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 26 22:07:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 20:07:16 +0000 Subject: [Koha-bugs] [Bug 33849] New: Duplicate patron warning resets borrowers branch if different than logged in user's branch Message-ID: <bug-33849-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33849 Bug ID: 33849 Summary: Duplicate patron warning resets borrowers branch if different than logged in user's branch Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When entering a new patron, if the patron's home library is not the same as the logged-in library of the user + the patron is flagged as a possible duplicate, the patron's home library reverts to the logged in user's library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 22:10:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 20:10:35 +0000 Subject: [Koha-bugs] [Bug 33849] Duplicate patron warning resets borrowers branch if different than logged in user's branch In-Reply-To: <bug-33849-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33849-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33849-70-zkI0ow3pgc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33849 ddemick at oslri.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ddemick at oslri.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 22:11:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 20:11:04 +0000 Subject: [Koha-bugs] [Bug 22135] Inventory tool doesn't export "out of order" problem to CSV In-Reply-To: <bug-22135-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22135-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22135-70-CxsxFvw61F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 23:09:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 21:09:36 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-ED1A5vzb3g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 --- Comment #38 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 151771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151771&action=edit Bug 33117: New system preference - PatronAutoCompleteSearchMethod New Test Plan: 0. Ensure system preference PatronAutoComplete is set to Try 1. Create a patron that has a first name, middle name and two surnames. (i.e. Adela Maria, Hernandez Acosta). 2. In patron or checkout search, enter their first name and first surname without submitting. 3. Confirm that a record is found in the autocomplete results 4. In patron or checkout search, enter their first name and second surname without submitting. 5. Confirm that no record is found. 6. Enter their middle name and first surname. Confirm that no record is found. 7. Enter their middle name and second surname. Confirm that no record is found. 8. Apply the patch, update database 9. Under Administration > Global System Preferences > search for "PatronAutocompleteSearchMethod" 10. Choose "Contains" instead of "Starts with" for the system preference, reload your search page 11. Repeat steps 2-4. The patron record should appear for all search methods. 12. Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 26 23:11:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 21:11:38 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-pyP8YERuO9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 00:40:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 May 2023 22:40:57 +0000 Subject: [Koha-bugs] [Bug 33850] New: Holdings - showing data on hover Message-ID: <bug-33850-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33850 Bug ID: 33850 Summary: Holdings - showing data on hover Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org What if the table columns option gave a third option to reveal information on hover? Maybe you don't want so much data filling up the table, but if you gave a hover option, an eyeball icon would appear in the table next to items, and if you hover over it, it shows all the data that is hidden but hoverable. For example, 22.11 introduces 2 more columns: issues and renewals. Maybe I don't want to cram so much into the table, but if I had an option to hover, I could easily see that info anytime by hovering over that row's eye. This keeps the table clutter free, but I wouldn't have to navigate away or reconfigure the table. It's just easier and cleaner. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 27 09:15:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2023 07:15:01 +0000 Subject: [Koha-bugs] [Bug 26815] QueryFuzzy should also fuzzy Elasticsearch searches when set to "try" In-Reply-To: <bug-26815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26815-70-QoV4XfMLSy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26815 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 13:34:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2023 11:34:49 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff interface catalog details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-K6RjEGHrNK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #26 from Mason James <mtj at kohaaloha.com> --- (In reply to Matt Blenkinsop from comment #25) > Nice work everyone! > > Pushed to stable for 22.11.x hi Matt, this patchset depends on 33070, which is missing from 22.11.x we probably need to revert this from 22.11.06, as it breaks catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 13:35:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2023 11:35:16 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff interface catalog details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-rREaqjlk0P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33070 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33070 [Bug 33070] Get rid of Koha::Patron->can_edit_item and use can_edit_item_from instead -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 13:35:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2023 11:35:16 +0000 Subject: [Koha-bugs] [Bug 33070] Get rid of Koha::Patron->can_edit_item and use can_edit_item_from instead In-Reply-To: <bug-33070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33070-70-ym9CPGmDs1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33070 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33167 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 [Bug 33167] Cleanup staff interface catalog details page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 27 23:54:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2023 21:54:48 +0000 Subject: [Koha-bugs] [Bug 33514] SearchWithIS[B|S]NVariations breaks ISBN search in item search In-Reply-To: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33514-70-iIOyHWnNbD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- sorting => storing > I think that's not the main issue here, storing differently would not > resolve hte issue. We need to fix the search query. The problem is that we > store a string of space separated ISBN and you can't search that with SQL > without truncating/using LIKE. And that's what happens now and only works > when there is only one ISBN on the record (which often is not the case at > least for us) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 28 01:57:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 May 2023 23:57:18 +0000 Subject: [Koha-bugs] [Bug 25079] Show club enrollment question answers in staff interface In-Reply-To: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25079-70-lHorNnyODF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25079 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show club enrollment |Show club enrollment |question answers in staff |question answers in staff |client |interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 28 02:11:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2023 00:11:41 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff interface results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-yu3gDxv39Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC and staff client |OPAC and staff interface |results page do not honor |results page do not honor |SyndeticsCoverImageSize |SyndeticsCoverImageSize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 01:24:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 May 2023 23:24:43 +0000 Subject: [Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used In-Reply-To: <bug-33847-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33847-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33847-70-pAinLsPba7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 03:37:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 01:37:59 +0000 Subject: [Koha-bugs] [Bug 27269] Move C4::Biblio::GetMarcSubjects to Koha namespace In-Reply-To: <bug-27269-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27269-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27269-70-JlQX0P3b7v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 03:38:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 01:38:02 +0000 Subject: [Koha-bugs] [Bug 27269] Move C4::Biblio::GetMarcSubjects to Koha namespace In-Reply-To: <bug-27269-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27269-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27269-70-52Oba8YMKA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146568|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 151772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151772&action=edit Bug 27269: Move GetMarcSubjects to Koha namespace This patch moves C4::Biblio::GetMarcSubjects to Koha::Biblio->get_marc_subjects. This is so get_marc_subjects can be used in templates and notices. To test: 1. Find a record that has a subject (6xx). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm subjects show as normal. 4. Click 'send' and confirm the email sent shows the subjects as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the ubjectsas normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm subjects show as normal. 9. Click 'send' and confirm the email sent shows the subjects as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the subjects as normal. 11. View the record detail page and confirm the subjects show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 11:51:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 09:51:50 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_33851=5D_New=3A_Punctuation=3A_Note?= =?utf-8?b?c+KQoDogJXM=?= Message-ID: <bug-33851-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33851 Bug ID: 33851 Summary: Punctuation: Notes␠: %s Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org There should be no space between the word and the : koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt:378 Notes␠: %s -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 13:17:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 11:17:00 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-AGJ07Bxfte@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151670|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 13:19:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 11:19:46 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-4i0DEffy3E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 13:19:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 11:19:52 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-nxrIxFxlmu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 --- Comment #8 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151773&action=edit Bug 33786: ILL requests table id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 13:21:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 11:21:03 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-lzm8WhzCMS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 --- Comment #9 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- I've rewritten the patch and tested that all works as intended. Please review again. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 14:01:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 12:01:40 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-7tGLm5DefL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Thomas Klausner <domm at plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |domm at plix.at --- Comment #37 from Thomas Klausner <domm at plix.at> --- Hi! Just a quick note that we (Steiermärkische Landesbibliothek) have some custom value builders on repeatable fields (that now work again because we used the 'jQuery._data' hack). But as soon as this Bug is resolved (or maybe even a bit earlier...) we will test if the new code still works with our value builders (or figure out how we'll need to change / adapt them. Greetings, domm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 14:22:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 12:22:25 +0000 Subject: [Koha-bugs] [Bug 33702] Patrons should only see their own ILLs in the OPAC In-Reply-To: <bug-33702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33702-70-Z3Tbwsks4Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33702 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Koha security |Koha Group|Koha security | Component|Koha |ILL CC| |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 14:29:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 12:29:45 +0000 Subject: [Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields In-Reply-To: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33489-70-9MSXjOETbe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 SOS <aliakbar.petiwala88 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aliakbar.petiwala88 at gmail.c | |om --- Comment #6 from SOS <aliakbar.petiwala88 at gmail.com> --- I tried to switched to new stable version but unfortunately received error on this number, please guide how to ignore this error and update the table using script file... step by step guide using koha on ubuntu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 14:46:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 12:46:12 +0000 Subject: [Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields In-Reply-To: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33489-70-ZmdPw1DOfx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This will be fixed with a new package very soon. Upgrade to 22.11.05.010 [10:48:17]: Bug 33489 - Add indices to default patron search fields ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: BLOB/TEXT column 'middle_name' used in key specification without a key length at /usr/share/koha/lib/C4/Installer.pm line 743 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 15:29:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 13:29:43 +0000 Subject: [Koha-bugs] [Bug 33852] New: jobs.t is not testing only_current Message-ID: <bug-33852-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33852 Bug ID: 33852 Summary: jobs.t is not testing only_current Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org This test is not covering that parameter behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 15:33:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 13:33:22 +0000 Subject: [Koha-bugs] [Bug 33852] jobs.t is not testing only_current In-Reply-To: <bug-33852-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33852-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33852-70-gqndTB4Ghq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33852 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 15:33:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 13:33:24 +0000 Subject: [Koha-bugs] [Bug 33852] jobs.t is not testing only_current In-Reply-To: <bug-33852-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33852-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33852-70-RitBJoRaKc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33852 --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151774&action=edit Bug 33852: Make jobs.t test the only_current parameter This trivial patch adds a test to the only_current parameter. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/jobs.t => SUCCESS: New tests added, and pass 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 15:34:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 13:34:16 +0000 Subject: [Koha-bugs] [Bug 33556] $c->validation->output should be avoided In-Reply-To: <bug-33556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33556-70-mmFeHQzY8E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33852 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33852 [Bug 33852] jobs.t is not testing only_current -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 15:34:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 13:34:16 +0000 Subject: [Koha-bugs] [Bug 33852] jobs.t is not testing only_current In-Reply-To: <bug-33852-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33852-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33852-70-BuvZ3H4eMW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33852 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33556 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556 [Bug 33556] $c->validation->output should be avoided -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 15:44:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 13:44:13 +0000 Subject: [Koha-bugs] [Bug 23487] Utf8mb4 collation causes problems with missing tables when upgrading the database In-Reply-To: <bug-23487-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23487-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23487-70-3F8cg1Ip3o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23487 Afrane Daniel <afrane55 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |afrane55 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 15:44:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 13:44:27 +0000 Subject: [Koha-bugs] [Bug 33853] New: Error upgrading database schema Message-ID: <bug-33853-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33853 Bug ID: 33853 Summary: Error upgrading database schema Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: afrane55 at gmail.com QA Contact: testopia at bugs.koha-community.org I tried Upgrading to 20.11.05.010 and database schema fails to upgrade with : Upgrade to 22.11.05.010 [12:59:19]: Bug 33489 - Add indices to default patron search fields ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: BLOB/TEXT column 'middle_name' used in key specification without a key length at /usr/share/koha/lib/C4/Installer.pm line 743 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 15:48:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 13:48:34 +0000 Subject: [Koha-bugs] [Bug 33853] Error upgrading database schema In-Reply-To: <bug-33853-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33853-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33853-70-FWVT8rvzUj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33853 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Depends on| |33489 Resolution|--- |FIXED --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi, this has been fixed by new Debian packages a little time ago. Please try to update again. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 [Bug 33489] The borrowers table should have indexes on default patron search fields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 15:48:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 13:48:34 +0000 Subject: [Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields In-Reply-To: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33489-70-xVpPCRyHtj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33853 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33853 [Bug 33853] Error upgrading database schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 15:52:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 13:52:06 +0000 Subject: [Koha-bugs] [Bug 33854] New: Typo in ImportBatchProfiles controller Message-ID: <bug-33854-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33854 Bug ID: 33854 Summary: Typo in ImportBatchProfiles controller Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 15:52:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 13:52:11 +0000 Subject: [Koha-bugs] [Bug 33854] Typo in ImportBatchProfiles controller In-Reply-To: <bug-33854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33854-70-AuyVNE0twe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33854 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 15:59:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 13:59:54 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-oDJjAdq2I2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Applied patch, restart_all, but the actual cost remains 0 on receive, for both multi and single receive :( Any hints? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:00:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 14:00:36 +0000 Subject: [Koha-bugs] [Bug 33854] Typo in ImportBatchProfiles controller In-Reply-To: <bug-33854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33854-70-MhkhOAURHO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33854 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- What is the typo? Happy to help fixing it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:00:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 14:00:55 +0000 Subject: [Koha-bugs] [Bug 33854] Typo in ImportBatchProfiles controller In-Reply-To: <bug-33854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33854-70-520iTVZLpF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33854 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:00:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 14:00:57 +0000 Subject: [Koha-bugs] [Bug 33854] Typo in ImportBatchProfiles controller In-Reply-To: <bug-33854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33854-70-ryHxRo5QO9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33854 --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151775&action=edit Bug 33854: Fix typo in ImportBatchProfiles controller Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> atch-complexity: Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:01:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 14:01:27 +0000 Subject: [Koha-bugs] [Bug 33854] Typo in ImportBatchProfiles controller In-Reply-To: <bug-33854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33854-70-FW3CWo5pFa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33854 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:01:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 14:01:40 +0000 Subject: [Koha-bugs] [Bug 33854] Typo in ImportBatchProfiles controller In-Reply-To: <bug-33854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33854-70-cdpPGNFqKo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33854 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:04:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 14:04:45 +0000 Subject: [Koha-bugs] [Bug 33855] New: Clean up forms and page sections on 'manage MARC imports' page Message-ID: <bug-33855-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33855 Bug ID: 33855 Summary: Clean up forms and page sections on 'manage MARC imports' page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The new options for handling MARC frameworks are not inside a page section on the MARC import page. I think this page would need profit from some restructuring. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:16:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 14:16:09 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-1ZwN0E1xUU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Just noting: I tested the process in 20.11 and the actual cost is pre-populated there. So I can confirm this bug is a regression. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:19:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 14:19:43 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-eKMNSRWm3E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Please don't forget to write good commit messages. Problem description and test plan should be included. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:32:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 14:32:43 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-HF83A6rhzQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:32:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 14:32:46 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-MYluEkVdSI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151773|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151776&action=edit Bug 33786: ILL requests table id Reproduce: 1) Have a borrower with >20 ILL requests in their history 2) Visit cgi-bin/koha/members/ill-requests.pl?borrowernumber=<borrowernumber> 3) On the table, click page 2 4) Visit a different borrower with <20 ILL requests 5) Verify that no requests are shown, this is because the table is using page 2 from step 3) 6) Go back to original borrower, click table page 1 7) Now go back to 2nd borrower, verify is now showing page 1 correctly Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:33:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 14:33:58 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-e0AgZ86zY7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151776|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151777&action=edit Bug 33786: ILL requests table id Make sure requests table is unique when visiting patron ILL history so the table state is not shared unintentionally Reproduce: 1) Have a borrower with >20 ILL requests in their history 2) Visit cgi-bin/koha/members/ill-requests.pl?borrowernumber=<borrowernumber> 3) On the table, click page 2 4) Visit a different borrower with <20 ILL requests 5) Verify that no requests are shown, this is because the table is using page 2 from step 3) 6) Go back to original borrower, click table page 1 7) Now go back to 2nd borrower, verify is now showing page 1 correctly Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:34:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 14:34:30 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-4oXkkIiAnk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Works well, fixed the commit message :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:37:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 14:37:01 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in patron history is transposing for different patrons In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-vfMUdBE8YJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ILL requests table |ILL requests table |pagination in borrower |pagination in patron |history is transposing for |history is transposing for |different borrowers |different patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 16:37:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 14:37:18 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in patron ILL history is transposing for different patrons In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-KgikzU8EhM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ILL requests table |ILL requests table |pagination in patron |pagination in patron ILL |history is transposing for |history is transposing for |different patrons |different patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:15:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 15:15:19 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-dBLLj7f9vb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:20:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 15:20:31 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-DWENLc0kah@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #39 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Laura, this needs some more work: 1) The database update doesn't work correctly: FAIL installer/data/mysql/atomicupdate/bug_33117.pl FAIL valid syntax error (Might be a runaway multi-line {} string starting on line 10) syntax error Missing right curly or square bracket installer/data/mysql/atomicupdate/bug_33117.pl had compilation errors. DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_33117.pl [15:19:11] ERROR - {UNKNOWN}: Can't use an undefined value as a subroutine reference at /kohadevbox/koha/C4/Installer.pm line 741. at /kohadevbox/koha/C4/Installer.pm line 743 2) There are some issues with the 'metadata' of the patches: * Author 'John Doe' seems invalid * Author 'John Doe' seems invalid * Email's author 'you at example.com' seems invalid * Email's author 'you at example.com' seems invalid Can you please have a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:20:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 15:20:38 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-pglPqyxfUX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:26:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 15:26:33 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-YfcLgttmRL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Eric Bégin <eric.begin at inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bouzid.fergani at gmail.com, |eric.begin at inLibro.com |charles.farmer at inlibro.com, | |david.bourgault at inlibro.com | |, | |francois.charbonnier at inlibr | |o.com, | |gabriel.decarufel at inlibro.c | |om, | |ivan.dziuba at inlibro.com, | |the-minh.luong at inlibro.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:41:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 15:41:28 +0000 Subject: [Koha-bugs] [Bug 22135] Inventory tool doesn't export "out of order" problem to CSV In-Reply-To: <bug-22135-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22135-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22135-70-WHv4ejRKYK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Version|18.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:45:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 15:45:52 +0000 Subject: [Koha-bugs] [Bug 22135] Inventory tool doesn't export "out of order" problem to CSV In-Reply-To: <bug-22135-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22135-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22135-70-CstzeYOGZu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:45:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 15:45:55 +0000 Subject: [Koha-bugs] [Bug 22135] Inventory tool doesn't export "out of order" problem to CSV In-Reply-To: <bug-22135-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22135-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22135-70-zx3CvXxjgL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151778&action=edit Bug 22135: Display 'shelved out of order' error in inventory CSV export When using the inventory tool with an uploaded barcode file and checking the "Compare barcodes list to results", "Check barcodes list for items shelved out of order" and "Export to CSV file" checkboxes, the resulting CSV file showed a blank in the "problem" column for items with out of order callnumbers. With this patch, you'll see "Shelved out of order". To test: * Create 3 items with callnumbers and barcodes a, b, and c * Go to Cataloguing > Inventory * Enter a c b (each on its own line) into the barcode field * Check "Compare barcodes list to results" * Check "Check barcodes list for items shelved out of order" * Check "Export to CSV file" (at the bottom) * Verify the file has empty lines in the problem column * Apply patch * Repeat test, the empty lines should now read: "Shelved out of order" Note: Also fixes "problem" to "Problem" to make capitalization consistent. All those strings are currently not translatable, this will be filed separately. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:46:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 15:46:18 +0000 Subject: [Koha-bugs] [Bug 22135] Inventory tool doesn't export "out of order" problem to CSV In-Reply-To: <bug-22135-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22135-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22135-70-ifyAIV515X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84013|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:47:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 15:47:57 +0000 Subject: [Koha-bugs] [Bug 22135] Inventory tool doesn't export "out of order" problem to CSV In-Reply-To: <bug-22135-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22135-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22135-70-b4woXPqrkP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151778|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151779&action=edit Bug 22135: Display 'shelved out of order' error in inventory CSV export When using the inventory tool with an uploaded barcode file and checking the "Compare barcodes list to results", "Check barcodes list for items shelved out of order" and "Export to CSV file" checkboxes, the resulting CSV file showed a blank in the "problem" column for items with out of order callnumbers. With this patch, you'll see "Shelved out of order". To test: * Create 3 items with callnumbers and barcodes a, b, and c * Go to Cataloguing > Inventory * Enter a c b (each on its own line) into the barcode field * Check "Compare barcodes list to results" * Check "Check barcodes list for items shelved out of order" * Check "Export to CSV file" (at the bottom) * Verify the file has empty lines in the problem column * Apply patch * Repeat test, the empty lines should now read: "Shelved out of order" Note: Also fixes "problem" to "Problem" to make capitalization consistent. All those strings are currently not translatable, this will be filed separately. Co-authored-by: Mark Alexander <marka at pobox.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:49:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 15:49:08 +0000 Subject: [Koha-bugs] [Bug 22135] Inventory tool doesn't export "out of order" problem to CSV In-Reply-To: <bug-22135-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22135-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22135-70-shWAMdMXDF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Realized too late that there was already an incomplete patch file from Mark, so I added him as a co-author. We ended up with the same solution :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:55:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 15:55:26 +0000 Subject: [Koha-bugs] [Bug 33856] New: Inventory tool CSV export contains untranslatable strings Message-ID: <bug-33856-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 Bug ID: 33856 Summary: Inventory tool CSV export contains untranslatable strings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Depends on: 22135 The "Problem" header row label and the problems themselves are untranslatable as they are added in the inventory.pl file. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 [Bug 22135] Inventory tool doesn't export "out of order" problem to CSV -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:55:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 15:55:26 +0000 Subject: [Koha-bugs] [Bug 22135] Inventory tool doesn't export "out of order" problem to CSV In-Reply-To: <bug-22135-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22135-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22135-70-3OXJnuh3jW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33856 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 [Bug 33856] Inventory tool CSV export contains untranslatable strings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 17:57:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 15:57:40 +0000 Subject: [Koha-bugs] [Bug 32695] Search string for 775 'Other editions' is incorrectly formed In-Reply-To: <bug-32695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32695-70-scuXIPNpg0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32695 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Nick, please check the patch, it contains files that don't belong in there: installer/data/mysql/atomicupdate/bug_33117.pl | 2 +- .../prog/en/modules/admin/preferences/circulation.pref | 8 ++++---- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 2 +- .../opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 2 +- members/member.pl | 2 +- Also because of those the patch currently doesn't apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 18:00:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 16:00:26 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33845-70-LYGxKsiLcq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 18:01:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 16:01:30 +0000 Subject: [Koha-bugs] [Bug 23305] Add ability to append to item notes in batch item modification In-Reply-To: <bug-23305-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23305-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23305-70-hNj5PZMJU2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23305 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Andrew Fuerste-Henry from comment #4) > This is possible since bug 29781. Using capturing groups in a regex > substitution, one can basically say "replace the current note with the > current note plus these new words." > > A very basic example, if one wanted to append the text "Disc cleaned > 5-26-23" to all notes on a group of items, one could put "(.*)" in the Regex > Pattern and "$1 Disc Cleaned 5-26-23" in the Regex Replacement in the item > batch mod interface. This might make a great addition for the manual. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 18:15:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 16:15:30 +0000 Subject: [Koha-bugs] [Bug 33857] New: Reduce and resize local cover images Message-ID: <bug-33857-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33857 Bug ID: 33857 Summary: Reduce and resize local cover images Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: hinemoea.viault at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 151780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151780&action=edit Image to download When the local cover images are imported from very large photos or images, they do not seem to be worked before being put in the database. To reproduce: 1. Download the attached image large-image.jpg --> It should be ~170kB and 1000×1500 pixels 2. Enable LocalCoverImages in System preferences 3. Find a record in the staff interface 4. Go to "Images" tab 5. Upload large-image.jpg image 5.1. Click on "Upload" 5.2. Click on "Drop files here or click to select a file" 5.3. Choose picture (large-image.jpg) 5.4. Click on "Process images" 6. Click on image for large image 7. Right-click on the image and save it --> It is ~930kB and 600x900 pixels -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 18:27:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 16:27:18 +0000 Subject: [Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list In-Reply-To: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33845-70-eY8ebGtcRl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- 2 things: 1) Is this correct? + holdsTable = KohaTable("holds-table", { + table_settings_holds_table = [% TablesSettings.GetTableSettings( 'circ', 'circulation', 'holds_table', 'json' ) | $raw %] We have holds-table and holds_table. 2) The holds table doesn't show the columns/export/configure buttons, but should it not? 3) For the checkouts table we have 2 separate configuration tables. Not sure if this is needed, but should we be consistent? (not a blocker) Otherwise this works pretty well and I think it will be quite helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 18:48:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 16:48:54 +0000 Subject: [Koha-bugs] [Bug 33857] Reduce and resize local cover images In-Reply-To: <bug-33857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33857-70-yKljRMo2yA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33857 Hinemoea Viault <hinemoea.viault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hinemoea.viault at inlibro.com --- Comment #1 from Hinemoea Viault <hinemoea.viault at inlibro.com> --- Created attachment 151781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151781&action=edit Resize local cover images This patch add a script in ./misc/maintenance/ that allows to reduce and resize local cover images. Test plan: 1. Download the attached image large-image.jpg --> It should be ~170kB and 1000×1500 pixels 2. Enable LocalCoverImages in System preferences 3. Find a record in the staff interface 4. Go to "Images" tab 5. Upload large-image.jpg image 5.1. Click on "Upload" 5.2. Click on "Drop files here or click to select a file" 5.3. Choose picture (large-image.jpg) 5.4. Click on "Process images" 6. Click on image for large image 7. Right-click on the image and save it --> It is ~930kB and 600x900 pixels 8. Apply the patch 9. In the terminal, run the script resize_cover_images.pl 9.1. Before running the script you need to run the following lines --> sudo apt install imagemagick --> sudo apt install libimage-magick-perl 9.2. Run resize_cover_images.pl --> perl ./misc/maintenance/resize_cover_images.pl 10. Repeat steps 6 and 7 --> The image is ~200kB and 267x400 pixels -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 18:51:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 16:51:21 +0000 Subject: [Koha-bugs] [Bug 33857] Reduce and resize local cover images In-Reply-To: <bug-33857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33857-70-JUHbAqBiGK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33857 Hinemoea Viault <hinemoea.viault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151781|Resize local cover images |Bug 33857: Resize local description| |cover images -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 18:52:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 16:52:03 +0000 Subject: [Koha-bugs] [Bug 33788] Items tab shows all previous borrowers instead of 3 In-Reply-To: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33788-70-CkU7Z4wIYt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |master Summary|moredetail.pl shows all |Items tab shows all |(many?) previous borrowers |previous borrowers instead |instead of 3 |of 3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 18:53:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 16:53:39 +0000 Subject: [Koha-bugs] [Bug 33857] Reduce and resize local cover images In-Reply-To: <bug-33857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33857-70-8EcYIVeeo4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33857 Hinemoea Viault <hinemoea.viault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 18:54:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 16:54:06 +0000 Subject: [Koha-bugs] [Bug 33788] Items tab shows all previous borrowers instead of 3 In-Reply-To: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33788-70-cDp03LJukR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 18:54:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 16:54:08 +0000 Subject: [Koha-bugs] [Bug 33788] Items tab shows all previous borrowers instead of 3 In-Reply-To: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33788-70-1MMeKOeyR9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151763|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151782&action=edit Bug 33788: Limit the number of old issues rows returned This patch updates the parameter from 'limit' to 'rows' To test: 1 - Checkout an item to 5 different people 2 - View item details on items tab of record 3 - Note you see last borrower, and three previous borrowers 4 - Apply patch, restart all 5 - Refresh page 6 - You shoulw now only see last borrower and 2 previous borrowers Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 18:54:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 16:54:44 +0000 Subject: [Koha-bugs] [Bug 33788] Items tab shows all previous borrowers instead of 3 In-Reply-To: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33788-70-XkGkvRW6cR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Very small, save, no strings. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 18:54:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 16:54:53 +0000 Subject: [Koha-bugs] [Bug 33788] Items tab shows all previous borrowers instead of 3 In-Reply-To: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33788-70-BJv7aJlHFY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:05:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 17:05:11 +0000 Subject: [Koha-bugs] [Bug 33525] Use template wrapper for tabs: Basic MARC editor In-Reply-To: <bug-33525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33525-70-hOXp94dPC3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33525 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:05:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 17:05:13 +0000 Subject: [Koha-bugs] [Bug 33525] Use template wrapper for tabs: Basic MARC editor In-Reply-To: <bug-33525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33525-70-Tv7ztjVWdA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33525 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151652|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151783&action=edit Bug 33525: Use template wrapper for tabs: Basic MARC editor This patch updates the basic MARC editor template to replace tab markup with the use of WRAPPERs. Some CSS and JS has been modified in order to make the custom style and behavior of the tabs on this page work correctly with standard Bootstrap tab markup. To test, apply the patch and go to Cataloging -> New record. - Confirm that the tabs look correct, with the same style they had before the template change. - The first tab ("0") should be selected by default. - Confirm that tab-switching works correctly: The tab color should change and the list of numbered tags in the menu just below should change to match the section. - Confirm that these tag number links still work correctly to jump you down the page to the corresponding tag. - Without filling in any mandatory fields, click the "Save" button. - You should get an error message about missing mandatory fields. - Clicking the "Go to field" link should take you to the correct tab and the correct tag. - Append a hash to the URL to pre-select a tab other than the first one, e.g. "/cgi-bin/koha/cataloguing/addbiblio.pl#tab5XX_panel" The correct tab should be selected upon page load. Signed-off-by: Sam Lau <samalau at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:08:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 17:08:35 +0000 Subject: [Koha-bugs] [Bug 33524] Use template wrapper for tabs: Authority editor In-Reply-To: <bug-33524-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33524-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33524-70-YuHgotODkS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33524 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:08:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 17:08:37 +0000 Subject: [Koha-bugs] [Bug 33524] Use template wrapper for tabs: Authority editor In-Reply-To: <bug-33524-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33524-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33524-70-LRJXEjWlPi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33524 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151762|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151784&action=edit Bug 33524: Use template wrapper for tabs: Authority editor This patch updates the authority editor template to replace tab markup with the use of WRAPPERs. Some CSS and JS has been modified in order to make the custom style and behavior of the tabs on this page work correctly with standard Bootstrap tab markup. To test, apply the patch and go to Authorities -> New authority. - Confirm that the tabs look correct, with the same style they had before the template change. - The first tab ("0") should be selected by default. - Confirm that tab-switching works correctly: The tab color should change and the list of numbered tags in the menu just below should change to match the section. - Confirm that these tag number links still work correctly to jump you down the page to the corresponding tag. - Without filling in any mandatory fields, click the "Save" button. - You should get an error message about missing mandatory fields. - Clicking the "Go to field" link should take you to the correct tab and the correct tag. - Append a hash to the URL to pre-select a tab other than the first one, e.g. "/cgi-bin/koha/authorities/authorities.pl?authtypecode=PERSO_NAME#tab5XX_panel" The correct tab should be selected upon page load. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:12:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 17:12:46 +0000 Subject: [Koha-bugs] [Bug 33841] Add customization to serial routing slip In-Reply-To: <bug-33841-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33841-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33841-70-ZRTR4rjSTT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33841 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Lisette, there is a really old bug report about bringing this into the notices & slips system. I am marking them as duplicate. I think this would give us the most flexibility. *** This bug has been marked as a duplicate of bug 9750 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:12:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 17:12:46 +0000 Subject: [Koha-bugs] [Bug 9750] Bring routing lists into notices & slips In-Reply-To: <bug-9750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9750-70-u6eFkeSmGe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9750 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 33841 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:15:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 17:15:46 +0000 Subject: [Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref In-Reply-To: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33844-70-dGK26JyMjf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:15:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 17:15:48 +0000 Subject: [Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref In-Reply-To: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33844-70-phpquQRfGa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151759|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151785&action=edit Bug 33844: Modify test to show problem Add delete key. Without the follow-up, this triggers a delete. Test fails. DBIx::Class::Row::delete(): Not in database at /usr/share/koha/Koha/Object.pm line 234 Test plan: Run t/db_dependent/Koha/Item.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:15:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 17:15:51 +0000 Subject: [Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref In-Reply-To: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33844-70-YMTiVME43c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151760|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151786&action=edit Bug 33844: Fix is_denied_renewal Going via result_set->has_column does cost actually nothing if the object is already there. Test plan: Run again t/db_dependent/Koha/Item.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:17:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 17:17:07 +0000 Subject: [Koha-bugs] [Bug 33838] Offline circulation interface error on return In-Reply-To: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33838-70-mES6L8Tbl0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:35:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 17:35:14 +0000 Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30556-70-mdzjSmHVeJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Eric Bégin <eric.begin at inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|the-minh.luong at inlibro.com |eric.begin at inLibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:35:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 17:35:36 +0000 Subject: [Koha-bugs] [Bug 28556] Make guarantor information available in notices In-Reply-To: <bug-28556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28556-70-Itn1PzZR42@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556 Eric Bégin <eric.begin at inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|the-minh.luong at inlibro.com |eric.begin at inLibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:36:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 17:36:29 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-8tvwYtk7sD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Eric Bégin <eric.begin at inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bouzid.fergani at gmail.com, | |charles.farmer at inlibro.com, | |david.bourgault at inlibro.com | |, | |francois.charbonnier at inlibr | |o.com, | |jose-mario.monteiro-santos@ | |inlibro.com, | |maksim.sen at inlibro.com, | |marius.mandrescu at inlibro.co | |m, | |mehdi.hamidi at inlibro.com, | |philippe.audet-fortin at inlib | |ro.com, | |roch.damour at inlibro.com, | |the-minh.luong at inlibro.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:38:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 17:38:24 +0000 Subject: [Koha-bugs] [Bug 30966] Record overlay rules - can't use Z39.50 filter In-Reply-To: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30966-70-gorTm5j3Ry@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Eric Bégin <eric.begin at inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|rachael.laritz at inlibro.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 19:41:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 17:41:03 +0000 Subject: [Koha-bugs] [Bug 33858] New: Date for pending offline circulation is unformatted Message-ID: <bug-33858-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33858 Bug ID: 33858 Summary: Date for pending offline circulation is unformatted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Following the test plan on bug 33838 (includes a koc test file) I noticed that the date in the pending offline circulations table is not formatted according to the DateFormat system preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 20:11:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 18:11:47 +0000 Subject: [Koha-bugs] [Bug 33838] Offline circulation interface error on return In-Reply-To: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33838-70-4Cy4pRaSBU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 20:11:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 18:11:50 +0000 Subject: [Koha-bugs] [Bug 33838] Offline circulation interface error on return In-Reply-To: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33838-70-ZgYLNQbtiy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151706|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151787&action=edit Bug 33838: Don't reset the renewal count I cannot find any justification for this line existing. MarkIssueReturned does not do this. Resetting item's renewal count was introduced in bug 5877 with no explanation. Test Plan: 1) Check out item 3999900000001 to a patron 2) Upload the KOC file attached to this bug report 3) Navigate the Pending Offline Circ actions, see your return is listed 4) Click the checkbox to select your return 5) Click Process once. Nothing appears to happen 6) In a new tab, pull up the bib for item 3999900000001, see that it has been checked in 7) Back on your Offline Circ tab, click Process a second time 8) Koha tells you the item is not checked out 9) Apply this patch, restart all the things! 10) Repeat steps 1-4, everything should now work! Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 20:13:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 18:13:09 +0000 Subject: [Koha-bugs] [Bug 32522] Accessibility: Calendar widget in OPAC is read-only / doesn't allow for manually entering dates In-Reply-To: <bug-32522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32522-70-efPJbWnMaq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32522 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 33821 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 20:13:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 18:13:09 +0000 Subject: [Koha-bugs] [Bug 33821] OPAC flatpickr no longer allows for direct input of date In-Reply-To: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33821-70-QXXB4m4MLk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33821 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 32522 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 20:14:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 18:14:29 +0000 Subject: [Koha-bugs] [Bug 33821] OPAC flatpickr no longer allows for direct input of date In-Reply-To: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33821-70-OFtT2n4XoH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33821 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Severity|minor |normal --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This is actually an accessibility issue too, as you don't want to use the widget with a screen reader. Updating severity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 20:17:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 18:17:04 +0000 Subject: [Koha-bugs] [Bug 33821] OPAC flatpickr no longer allows for direct input of date In-Reply-To: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33821-70-n7ZN9DTBod@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33821 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 20:17:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 18:17:07 +0000 Subject: [Koha-bugs] [Bug 33821] OPAC flatpickr no longer allows for direct input of date In-Reply-To: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33821-70-jUh5Pquvbq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33821 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151646|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151788&action=edit Bug 33821: Allow direct input of dates on the OPAC To test: 1. Apply patch 2. Go to OPAC self registration and try to manually enter the date for date of birth. 3. You can do so sucessfully Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 21:18:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 19:18:27 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-nIewBoMQnT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151789&action=edit Bug 33783: Make sure the value is populated on load time The original patch makes the form set the right values in the order row (before storing it) but misses to load the right value on page load, which is still a regression. This patch solves that. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 21:19:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 19:19:04 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-K05MKLSIfn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 21:22:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 19:22:30 +0000 Subject: [Koha-bugs] [Bug 33790] Fix and add various links to the manual In-Reply-To: <bug-33790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33790-70-QmDHemREuO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33790 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|identity_providers.pl does |Fix and add various links |not have Help link to |to the manual |manual | Component|System Administration |Documentation Version|22.11 |master Severity|enhancement |normal --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Identity providers is not the only one, patch incoming. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 21:23:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 19:23:48 +0000 Subject: [Koha-bugs] [Bug 33859] New: Sidebar labels 'Identity providers' as 'Authentication providers' Message-ID: <bug-33859-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33859 Bug ID: 33859 Summary: Sidebar labels 'Identity providers' as 'Authentication providers' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org This is probably due to a rename during development. The admin sidebar link should match the admin start page and page heading. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 21:43:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 19:43:02 +0000 Subject: [Koha-bugs] [Bug 33790] Fix and add various links to the manual In-Reply-To: <bug-33790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33790-70-omYZGfZe0P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33790 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 21:43:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 19:43:05 +0000 Subject: [Koha-bugs] [Bug 33790] Fix and add various links to the manual In-Reply-To: <bug-33790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33790-70-U5A0CPwDhd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33790 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151790&action=edit Bug 33790: Fix and add various links to the manual * Makes the move from tools to cataloguing for the pages linked from the cataloguing start page * Adds missing help links to admin and tools pages * Fix other existing links To test: * Best is to look at the patch, you'll see the pages you need to test on the left. * Open the page and access the help page through the help link Note: for a few links you'll need to update the version in the URL to 23.05 (identity providers is one) as the page doesn't exist yet in the 22.11 manual -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 29 22:09:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 20:09:29 +0000 Subject: [Koha-bugs] [Bug 33202] Add system preference to limit the size of local cover images In-Reply-To: <bug-33202-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33202-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33202-70-W06AHrHbrW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33202 Hinemoea Viault <hinemoea.viault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hinemoea.viault at inlibro.com --- Comment #1 from Hinemoea Viault <hinemoea.viault at inlibro.com> --- See Bug 33857 The patch add a script that reduce and resize local cover images. The max width and max height are not specified in a system preference, but the image is no size limit to 600 x 800 px. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 22:27:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 20:27:05 +0000 Subject: [Koha-bugs] [Bug 31049] Add tool to set/reduce local cover image size and quality, interactively and in batch. In-Reply-To: <bug-31049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31049-70-uHoqR5Yvi2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31049 Hinemoea Viault <hinemoea.viault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hinemoea.viault at inlibro.com --- Comment #6 from Hinemoea Viault <hinemoea.viault at inlibro.com> --- We noticed the same behavior from Koha. You can see Bug 33857 The patch add a script that reduce and resize oversized local cover images. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 29 23:40:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 21:40:58 +0000 Subject: [Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforlan values as unavailable In-Reply-To: <bug-30846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30846-70-RGp5pgu96q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 --- Comment #12 from Hammat wele <hammat.wele at inlibro.com> --- (In reply to Sam Lau from comment #11) > The follow up unit test failed, however, it also failed before the patch was > even applied. It left this message: > > Failed test 'IsAvailableForItemLevelRequest() tests' > # at t/db_dependent/Reserves.t line 1493. > t/db_dependent/Reserves.t .. 74/77 # Looks like you failed 1 test of 77. > t/db_dependent/Reserves.t .. Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/77 subtests > > Test Summary Report > ------------------- > t/db_dependent/Reserves.t (Wstat: 256 Tests: 77 Failed: 1) > Failed test: 72 > Non-zero exit status: 1 > Files=1, Tests=77, 6 wallclock secs ( 0.02 usr 0.01 sys + 3.85 cusr 0.94 > csys = 4.82 CPU) > Result: FAIL Hi Sam, I'm sorry, I'm not able to reproduce the failed test. it may have something to do with your configuration? if it also failed before applying the patch it's probably not related to this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 01:49:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 May 2023 23:49:00 +0000 Subject: [Koha-bugs] [Bug 33859] Sidebar labels 'Identity providers' as 'Authentication providers' In-Reply-To: <bug-33859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33859-70-NHo8cKNHUR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33859 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 08:33:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 06:33:04 +0000 Subject: [Koha-bugs] [Bug 33830] Title and author not on same line anymore In-Reply-To: <bug-33830-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33830-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33830-70-DRmJJpBdpn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33830 --- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Owen Leonard from comment #5) > (In reply to Fridolin Somers from comment #4) > > We should do the same in staff interface maybe. > > The staff interface already has this. Ah but not UNIMARC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 08:54:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 06:54:24 +0000 Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned In-Reply-To: <bug-22827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22827-70-6X65LEKehS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- <span class="hint">If not set then items.dateaccessioned will be used</span> Instead of this we could just select this value in the dropdown list if none exist, and remove the empty option to make it mandatory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 09:07:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 07:07:47 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in patron ILL history is transposing for different patrons In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-bCehxtrtiZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 --- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Not blocker, but this: + function get_prefilter_value(prefilter_key) { + let pre_filter = additional_prefilters.find(e => e.key === prefilter_key); + return additional_prefilters.length != 0 && typeof pre_filter !== "undefined" ? pre_filter['value'] : null; + } reads odd. We should not need 'additional_prefilters.length != 0'. Also I am wondering how this can be written nicely, Paul maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 09:07:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 07:07:55 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in patron ILL history is transposing for different patrons In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-wQDEZb0QFj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid at lmscloud.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 09:23:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 07:23:30 +0000 Subject: [Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref In-Reply-To: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33844-70-0kVDbFE39V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- We usually use Koha::Objects->columns to retrieve the exist columns. Not sure what's the fastest here however. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 09:32:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 07:32:54 +0000 Subject: [Koha-bugs] [Bug 33846] 'Save' and 'close' buttons confusing on multi-receive In-Reply-To: <bug-33846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33846-70-iRKnYUQRHU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Close is not saving, simply closing the modal. Saving is effectively saving the change you made in the modal. At least it is their intended behaviours. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 09:40:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 07:40:02 +0000 Subject: [Koha-bugs] [Bug 33848] Enabling Coce in the OPAC breaks cover images on bibliographic detail page In-Reply-To: <bug-33848-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33848-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33848-70-g3sUysL06F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I am not recreating the problem. Do you recreate in ktd? If so which biblionumber? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 09:58:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 07:58:42 +0000 Subject: [Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref In-Reply-To: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33844-70-1VazajSauL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #5) > We usually use Koha::Objects->columns to retrieve the exist columns. Not > sure what's the fastest here however. This is the fastest. Timed a few things here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 10:36:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 08:36:06 +0000 Subject: [Koha-bugs] [Bug 33860] New: Checkbox column on the items table of the catalogue detail page should not be sortable Message-ID: <bug-33860-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33860 Bug ID: 33860 Summary: Checkbox column on the items table of the catalogue detail page should not be sortable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Staff interface Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 33568 This will be fixed on top of bug 33568. If we need a separate patch to backport we should open an other bug report. See bug 33568 comment 16. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the biblio detail view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 10:36:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 08:36:06 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-NCj3KGwCkD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33860 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33860 [Bug 33860] Checkbox column on the items table of the catalogue detail page should not be sortable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 10:50:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 08:50:38 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-rHdQUbsbzD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Owen Leonard from comment #16) > A few minor things: Thanks! > - use "fa fa-filter" icon for the "Show filters" link Commit "Restore filters" adjusted. > - the bulk actions controls (delete, modify) appear if you click a checkbox > but not if you click "Select all" Done in "Fix select/clear all links". > - The checkbox column should not be sortable (an existing bug) This seems trivial to fix but it's not. The problem is the StaffDetailItemSelection (I've let a comment somewhere, IMO we should remove it, I don't see how it can be useful). As it's an existing bug I would like to deal with this specific bug on a separate bug report. I have opened bug 33860. > I like the choice to hide all the table controls until you click "Show > filters" but I am concerned that others might miss the quick filter box. I > hope others will comment on that. There was actually a bug. I've adjusted "Fix DT dom and remove DT info if not needed". The idea is to display the search and pagination only if there is pagination. If all the items are displayed then we show a simple table and browser search ctrl+f can then be used to search on the displayed info. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 11:09:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 09:09:58 +0000 Subject: [Koha-bugs] [Bug 33861] New: Packages_spec.ts is failing randomly Message-ID: <bug-33861-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33861 Bug ID: 33861 Summary: Packages_spec.ts is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 25551 It is currently failing on Koha_Master/2534 koha_1 | 1) Delete package koha_1 | koha_1 | koha_1 | 4 passing (35s) koha_1 | 1 failing koha_1 | koha_1 | 1) Package CRUD operations koha_1 | Delete package: koha_1 | AssertionError: Timed out retrying after 10000ms: Expected to find element: `#packages_list table tbody tr:first td:first a`, but never found it. koha_1 | at Context.eval (http://kohadev-intra.mydnsname.org:8081/__cypress/tests?p=t/cypress/integration/ERM/Packages_spec.ts:373:19) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 11:09:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 09:09:58 +0000 Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly In-Reply-To: <bug-25551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25551-70-HWOCPUbdVT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33861 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33861 [Bug 33861] Packages_spec.ts is failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 11:13:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 09:13:18 +0000 Subject: [Koha-bugs] [Bug 33861] Packages_spec.ts is failing randomly In-Reply-To: <bug-33861-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33861-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33861-70-NJlZfbS9bd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33861 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 11:22:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 09:22:41 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in patron ILL history is transposing for different patrons In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-FlAQ4eSo8w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151777|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151791&action=edit Bug 33786: ILL requests table id Make sure requests table is unique when visiting patron ILL history so the table state is not shared unintentionally Reproduce: 1) Have a borrower with >20 ILL requests in their history 2) Visit cgi-bin/koha/members/ill-requests.pl?borrowernumber=<borrowernumber> 3) On the table, click page 2 4) Visit a different borrower with <20 ILL requests 5) Verify that no requests are shown, this is because the table is using page 2 from step 3) 6) Go back to original borrower, click table page 1 7) Now go back to 2nd borrower, verify is now showing page 1 correctly Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 11:25:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 09:25:05 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in patron ILL history is transposing for different patrons In-Reply-To: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33786-70-820OcIG3rZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 --- Comment #16 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- I've simplified the patch (I believe). Some of the abstraction that was there was preparing for bug 30719 (because there will be a batch_if prefilter on top of the borrowernumber prefilter, but batch_id prefilter will make use of 'placed' and 'updated' filters, whereas borrowernumber does not (patron history page does not have left side filters with date inputs). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 11:48:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 09:48:31 +0000 Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned In-Reply-To: <bug-22827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22827-70-QmVW2MlBJ0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #19) > <span class="hint">If not set then items.dateaccessioned will be used</span> > > Instead of this we could just select this value in the dropdown list if none > exist, and remove the empty option to make it mandatory. Note: We'd also need a database update for the old entries. I can try to file that later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 11:58:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 09:58:06 +0000 Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned In-Reply-To: <bug-22827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22827-70-nBqpbxhA96@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Katrin Fischer from comment #20) > (In reply to Jonathan Druart from comment #19) > > <span class="hint">If not set then items.dateaccessioned will be used</span> > > > > Instead of this we could just select this value in the dropdown list if none > > exist, and remove the empty option to make it mandatory. > > Note: We'd also need a database update for the old entries. I can try to > file that later. Not necessarily but yes that will be better ofc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 12:45:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 10:45:53 +0000 Subject: [Koha-bugs] [Bug 33859] Use the phrase 'Identity providers' instead of 'Authentication providers' In-Reply-To: <bug-33859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33859-70-Udp5UpKCls@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33859 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |minor Summary|Sidebar labels 'Identity |Use the phrase 'Identity |providers' as |providers' instead of |'Authentication providers' |'Authentication providers' Depends on| |31378 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Renaming the bug because there are many more instances of the phrase "authentication provider" which should be corrected. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 [Bug 31378] Add a generic OAuth2/OIDC client implementation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 12:45:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 10:45:53 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31378-70-p1Tp6XV3uo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33859 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33859 [Bug 33859] Use the phrase 'Identity providers' instead of 'Authentication providers' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 12:47:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 10:47:25 +0000 Subject: [Koha-bugs] [Bug 33859] Use the phrase 'Identity providers' instead of 'Authentication providers' In-Reply-To: <bug-33859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33859-70-vuAE9IwLaz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33859 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx, Owen :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 12:51:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 10:51:37 +0000 Subject: [Koha-bugs] [Bug 33861] Packages_spec.ts is failing randomly In-Reply-To: <bug-33861-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33861-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33861-70-tnsYSn16aq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33861 --- Comment #1 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Unable to reproduce locally. I may be wrong but this looks like one of those "happens once every full moon" test failures. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 13:05:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 11:05:07 +0000 Subject: [Koha-bugs] [Bug 33854] Typo in ImportBatchProfiles controller In-Reply-To: <bug-33854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33854-70-iGGucd374O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33854 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 13:05:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 11:05:09 +0000 Subject: [Koha-bugs] [Bug 33854] Typo in ImportBatchProfiles controller In-Reply-To: <bug-33854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33854-70-rNx2NqowkL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33854 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 13:05:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 11:05:26 +0000 Subject: [Koha-bugs] [Bug 33854] Typo in ImportBatchProfiles controller In-Reply-To: <bug-33854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33854-70-sRfZdy3j7F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33854 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 13:27:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 11:27:30 +0000 Subject: [Koha-bugs] [Bug 33838] Offline circulation interface error on return In-Reply-To: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33838-70-r2AhWMiuby@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151787|0 |1 is obsolete| | --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151792&action=edit Bug 33838: Don't reset the renewal count I cannot find any justification for this line existing. MarkIssueReturned does not do this. Resetting item's renewal count was introduced in bug 5877 with no explanation. Test Plan: 1) Check out item 3999900000001 to a patron 2) Upload the KOC file attached to this bug report 3) Navigate the Pending Offline Circ actions, see your return is listed 4) Click the checkbox to select your return 5) Click Process once. Nothing appears to happen 6) In a new tab, pull up the bib for item 3999900000001, see that it has been checked in 7) Back on your Offline Circ tab, click Process a second time 8) Koha tells you the item is not checked out 9) Apply this patch, restart all the things! 10) Repeat steps 1-4, everything should now work! Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Edit: this line was introduced by bug 30275, by mistake. The renewals_count attribute belongs to the `issues` table, and I agree it shouldn't be set to 0 at all as it will (with no reason) make us loose the value! Tests pass with and without this change, so this isn't even tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 13:29:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 11:29:20 +0000 Subject: [Koha-bugs] [Bug 33788] Items tab shows all previous borrowers instead of 3 In-Reply-To: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33788-70-eMpOPZSEjm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 13:29:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 11:29:22 +0000 Subject: [Koha-bugs] [Bug 33788] Items tab shows all previous borrowers instead of 3 In-Reply-To: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33788-70-Y6QME62ezz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 13:29:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 11:29:24 +0000 Subject: [Koha-bugs] [Bug 33821] OPAC flatpickr no longer allows for direct input of date In-Reply-To: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33821-70-I8qLoNy4BN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33821 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 13:29:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 11:29:26 +0000 Subject: [Koha-bugs] [Bug 33821] OPAC flatpickr no longer allows for direct input of date In-Reply-To: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33821-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33821-70-y2Nn5HM1OL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33821 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 13:29:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 11:29:28 +0000 Subject: [Koha-bugs] [Bug 33838] Offline circulation interface error on return In-Reply-To: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33838-70-YRR0Ko2ODU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 13:29:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 11:29:30 +0000 Subject: [Koha-bugs] [Bug 33838] Offline circulation interface error on return In-Reply-To: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33838-70-BP1FjWO1ZV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838 --- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 13:30:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 11:30:20 +0000 Subject: [Koha-bugs] [Bug 33861] Packages_spec.ts is failing randomly In-Reply-To: <bug-33861-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33861-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33861-70-X0CE8ej0QF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33861 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Pedro Amorim from comment #1) > I may be wrong but this looks like one of those "happens once every full > moon" test failures. Yes, hence the "randomly" in the bug title ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 13:35:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 11:35:53 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-AYjBRoBLAL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | Severity|blocker |major --- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Removed from 23.05.00 blocker list, too late. Not a good idea to push such changes on release day... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 13:46:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 11:46:42 +0000 Subject: [Koha-bugs] [Bug 27269] Move C4::Biblio::GetMarcSubjects to Koha namespace In-Reply-To: <bug-27269-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27269-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27269-70-qV2BaTnOOU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 13:46:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 11:46:44 +0000 Subject: [Koha-bugs] [Bug 27269] Move C4::Biblio::GetMarcSubjects to Koha namespace In-Reply-To: <bug-27269-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27269-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27269-70-PPDokB10rI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151772|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151793&action=edit Bug 27269: Move GetMarcSubjects to Koha namespace This patch moves C4::Biblio::GetMarcSubjects to Koha::Biblio->get_marc_subjects. This is so get_marc_subjects can be used in templates and notices. To test: 1. Find a record that has a subject (6xx). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm subjects show as normal. 4. Click 'send' and confirm the email sent shows the subjects as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the ubjectsas normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm subjects show as normal. 9. Click 'send' and confirm the email sent shows the subjects as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the subjects as normal. 11. View the record detail page and confirm the subjects show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 13:48:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 11:48:37 +0000 Subject: [Koha-bugs] [Bug 27269] Move C4::Biblio::GetMarcSubjects to Koha namespace In-Reply-To: <bug-27269-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27269-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27269-70-e0n84cYKxm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- > 4. Click 'send' and confirm the email sent shows the subjects as normal. None of the emails sent according to the test plan include subject information, but that is true in master too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:30:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:30:13 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling In-Reply-To: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23059-70-PNxUwFeCJV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- NOTE for interested ones: The former code - when priority>0 then 1 - when priority=0 then - (case - when found='f' then 4 - when found='w' then - (case - when cancellationdate is null then 3 - else 5 - end ) - else 2 - end ) made a lot of cancelled holds count under processing status 2 ! The only ones that were counted were those which were already waiting. This bug is resolved now too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:31:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:31:37 +0000 Subject: [Koha-bugs] [Bug 33862] New: reserve_stats.pl: Cancelled holds are counted incorrectly under processing status Message-ID: <bug-33862-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33862 Bug ID: 33862 Summary: reserve_stats.pl: Cancelled holds are counted incorrectly under processing status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See bug 23059 comment6. Please test the patch on 23059 to resolve this issue too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:31:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:31:54 +0000 Subject: [Koha-bugs] [Bug 33862] reserve_stats.pl: Cancelled holds are counted incorrectly under processing status In-Reply-To: <bug-33862-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33862-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33862-70-AnlrUIGtOz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33862 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:34:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:34:06 +0000 Subject: [Koha-bugs] [Bug 33862] reserve_stats.pl: Cancelled holds are counted incorrectly under processing status In-Reply-To: <bug-33862-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33862-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33862-70-iGIZiFyJj4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33862 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23059 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:34:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:34:06 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling In-Reply-To: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23059-70-tYj63TL2vo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33862 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:34:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:34:17 +0000 Subject: [Koha-bugs] [Bug 33862] reserve_stats.pl: Cancelled holds are counted incorrectly under processing status In-Reply-To: <bug-33862-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33862-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33862-70-owQb6EDXEq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33862 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:36:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:36:22 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-sDOcyPQmPc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:36:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:36:25 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-mpM52VMRSJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151761|0 |1 is obsolete| | Attachment #151789|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151794&action=edit Bug 33783: (bug 8179 follow-up) Populate actual cost with ecost during receiving if not set This restores behavior prior to 8179 to use the estimated cost when receiving if the actual cost is not set. We set the unitprice in the table row so that it will be used when editing and will be saved even if not adjusted To test: 1 - Add some orders to a basket, do not set actual cost field 2 - Close basket, receive orders 3 - Note actual cost field is blank 4 - Cancel receipt 5 - Apply patch 6 - Receive again 7 - Note actual cost is populated 8 - Complete receipt and confirm actual cost correctly saved Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:36:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:36:28 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-hT2MRA8Dnt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151795&action=edit Bug 33783: Make sure the value is populated on load time The original patch makes the form set the right values in the order row (before storing it) but misses to load the right value on page load, which is still a regression. This patch solves that. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:37:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:37:29 +0000 Subject: [Koha-bugs] [Bug 33863] New: "change currency" always checked Message-ID: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 Bug ID: 33863 Summary: "change currency" always checked Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 25655 On bug 25655 we stored the invoice currency and invoice price. The "change currency" checkbox should be checked only if the previous order (in case of partial receives) had it checked. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655 [Bug 25655] Additionally store actual cost in foreign currency and currency from the invoice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:37:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:37:29 +0000 Subject: [Koha-bugs] [Bug 25655] Additionally store actual cost in foreign currency and currency from the invoice In-Reply-To: <bug-25655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25655-70-DuGow6baOh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33863 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 [Bug 33863] "change currency" always checked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:37:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:37:52 +0000 Subject: [Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling In-Reply-To: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23059-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23059-70-4HzDLiC8CF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Most cancelled holds look like: found, cancellationdate | NULL | 2022-05-16 | Only cancelled waits look like: found, cancellationdate | W | 2022-06-16 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:41:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:41:56 +0000 Subject: [Koha-bugs] [Bug 33863] "change currency" always checked In-Reply-To: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33863-70-eg4orfgLRy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:41:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:41:58 +0000 Subject: [Koha-bugs] [Bug 33863] "change currency" always checked In-Reply-To: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33863-70-16NnJMmvpJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151796&action=edit Bug 33863: (bug 25655 follow-up) Check "Change currency" only if checked before We should not check "Change currency" if it has not modified in the original order. Test plan: Create an order with 3+ items Receive 1 item, don't check "change currency" Receive an other item => "Change currency" is not checked Check "Change currency", modify the currency and the price Receive a third item => Change currency is checked, invoice currency and price are set correctly to the previous values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:43:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:43:47 +0000 Subject: [Koha-bugs] [Bug 33834] api/v1/ill_requests.t fails randomly In-Reply-To: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33834-70-VijQT5CMBm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:43:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:43:49 +0000 Subject: [Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface In-Reply-To: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33815-70-vW1L1jYxuQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:43:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:43:50 +0000 Subject: [Koha-bugs] [Bug 33787] Remove option to archive system debit types In-Reply-To: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33787-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33787-70-HroKyk49pc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Keywords|rel_23_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:43:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:43:51 +0000 Subject: [Koha-bugs] [Bug 33784] Save clicks on single order receive In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-oY4QmNheCW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:43:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:43:52 +0000 Subject: [Koha-bugs] [Bug 33761] Holds queue is not selecting items with completed transfers In-Reply-To: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33761-70-wOrqGjX8y9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:43:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:43:54 +0000 Subject: [Koha-bugs] [Bug 33708] OAuth/OIDC authentication for the staff interface requires OPAC enabled In-Reply-To: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33708-70-bW5cNRz4Ds@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33708 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:45:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:45:19 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-nyUg9J7SEi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:47:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:47:49 +0000 Subject: [Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu In-Reply-To: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33169-70-G69eHKG5Bv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:47:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:47:53 +0000 Subject: [Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu In-Reply-To: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33169-70-uDK5xwybTq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151530|0 |1 is obsolete| | --- Comment #15 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 151797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151797&action=edit Bug 33169: Build breadcrumbs and left-hand side menu from routes definition Signed-off-by: Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:49:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:49:18 +0000 Subject: [Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu In-Reply-To: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33169-70-hgcM0ZqNzv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #16 from Agustín Moyano <agustinmoyano at theke.io> --- Hi Jonathan, please try once more. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:49:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:49:23 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-eieixBAJRD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Passed QA |Failed QA --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- wait -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:54:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:54:05 +0000 Subject: [Koha-bugs] [Bug 33702] Patrons should only see their own ILLs in the OPAC In-Reply-To: <bug-33702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33702-70-9819yVwG7o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33702 --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- What happened here? It's part of 22.11.x only now? RMaints? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:56:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:56:07 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-I3qxbFKWym@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 --- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- 416 [% IF (invoiceincgst) %] 417 [% SET unitprice = order.unitprice_tax_included > 0 ? order.unitprice_tax_included : order.ecost_tax_included %] 418 <input type="text" size="20" name="unitprice" id="unitprice" value="[% unitprice | $Price on_editing => 1 %]" /> <span class="hint">(tax inclusive)</span> 419 [% ELSE %] 420 [% SET unitprice = order.unitprice_tax_included > 0 ? order.unitprice_tax_excluded : order.ecost_tax_excluded %] 421 <input type="text" size="20" name="unitprice" id="unitprice" value="[% unitprice | $Price on_editing => 1 %]" /> <span class="hint">(tax exclusive)</span> 422 [% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:57:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:57:37 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-rPSJIRX4Ul@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- You need to get ecost only if unitprice has not been passed when ordering. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 14:58:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 12:58:06 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff interface catalog details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-EJOKiwKigL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Chad Billman <chad at pennmanor.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chad at pennmanor.net --- Comment #27 from Chad Billman <chad at pennmanor.net> --- I can confirm this is causing issues for us on 22.11.x. Over the weekend 22.11.6 was installed and I began to get reports about 500 errors. The have all been on catalogue/detail.pl line 411 Trace begun at /usr/share/koha/lib/Koha/Object.pm line 925 Koha::Object::AUTOLOAD('Koha::Patron=HASH(0x562a086602e8)', 'LET') called at /usr/share/koha/intranet/cgi-bin/catalogue/detail.pl line 411 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 15:00:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 13:00:45 +0000 Subject: [Koha-bugs] [Bug 33855] Clean up forms and page sections on 'manage MARC imports' page In-Reply-To: <bug-33855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33855-70-BvGR7ZnsF5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33855 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 15:19:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 13:19:52 +0000 Subject: [Koha-bugs] [Bug 32671] basic_workflow.t is failing randomly In-Reply-To: <bug-32671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32671-70-kKywnaxujO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32671 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Koha_Master/2535 koha_1 | CP main = 3.84 koha_1 | koha_1 | # Failed test at t/db_dependent/selenium/basic_workflow.t line 113. koha_1 | Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 125. koha_1 | # 'Patron categories › Administration › Koha' koha_1 | # doesn't match '(?^u:New category)' koha_1 | koha_1 | STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} koha_1 | /usr/share/perl5/Selenium/Remote/Driver.pm:361 in Try::Tiny::try koha_1 | (eval 1858):1 in Selenium::Remote::Driver::__ANON__ koha_1 | (eval 1860):2 in Selenium::Remote::Driver::__ANON__ koha_1 | /usr/share/perl5/Selenium/Remote/Driver.pm:1340 in Selenium::Remote::Driver::_execute_command koha_1 | /usr/share/perl5/Selenium/Remote/Driver.pm:1340 in (eval) koha_1 | /kohadevbox/koha/t/lib/Selenium.pm:117 in Selenium::Remote::Driver::find_element koha_1 | t/db_dependent/selenium/basic_workflow.t:114 in t::lib::Selenium::fill_form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 15:24:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 13:24:24 +0000 Subject: [Koha-bugs] [Bug 33846] 'Save' and 'close' buttons confusing on multi-receive In-Reply-To: <bug-33846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33846-70-96rl66oNdq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- >From what I found in the code, save mostly just closes the window. All of the inputs on the form have events attached - when the value is changed we update the row in the background -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 15:24:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 13:24:35 +0000 Subject: [Koha-bugs] [Bug 33864] New: Modal broken when "AcqCreateItem" set to "cataloguing" Message-ID: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Bug ID: 33864 Summary: Modal broken when "AcqCreateItem" set to "cataloguing" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: tomascohen at gmail.com Reporter: nugged at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 33784 To test: 0. Set syspref to "AcqCreateItem" set to "cataloguing" ( /cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=AcqCreateItem ) 1. Create a basket 1.1. Go to Acquisitions 1.2. Search for a vendor 1.3. Click New > Basket 1.4. Fill out the basket form 1.5. Click Save 2. Add at least one order to the basket 2.1. Click Add to basket 2.2. Click From a new (empty) record 2.3. Fill out the order form 2.4. Click Save 3. Click Close basket and confirm 4. Click Receive shipments 5. THE PROBLEM IS HERE: - "Confirm" button never gets enabled even if we fill in the form fields, - "Date received:" not prefilled but better should be filled (auto? or from DB?), - "Quantity received:" not prefilled, but on 22.11 it was "1" by default and anyway saved clicks for librarians, and maybe it also should be filled with some cleverly even in "AcqCreateItem" set to "cataloguing" (=1?) NOTE: "AcqCreateItem" set to "cataloguing" is used in our libraries because they receive newspapers and magazines which not then have physical items but by quantity per-biblio, that's why and hos this option is used in our case. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 [Bug 33784] Save clicks on single order receive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 15:24:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 13:24:35 +0000 Subject: [Koha-bugs] [Bug 33784] Save clicks on single order receive In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-TRfsd0v494@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 Andrew Nugged <nugged at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33864 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 15:25:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 13:25:07 +0000 Subject: [Koha-bugs] [Bug 33855] Clean up forms and page sections on 'manage MARC imports' page In-Reply-To: <bug-33855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33855-70-slBKGE8OrF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33855 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 15:25:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 13:25:09 +0000 Subject: [Koha-bugs] [Bug 33855] Clean up forms and page sections on 'manage MARC imports' page In-Reply-To: <bug-33855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33855-70-VeHFGjizlz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33855 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151798&action=edit Bug 33855: Clean up forms and page sections on 'manage MARC imports' page This patch makes minor changes to the structure of the "Manage MARC imports" page so that sections are more clearly delineated and forms have the correct structure. The patch also shortens the new framework field labels and adds hints for clarification. To test, apply the patch and go to Cataloging -> Stage MARC records for import. - Import a batch of MARC records. - Go to Cataloging -> Manage staged records. - View the batch you just imported. - You should see three sections: - A list of information about the batch - Options for changing the matching rules - Options for setting frameworks during import. - Test that the form for applying different matching rules still works correctly. - Import a batch of records which contains matches (by, for example, exporting MARC records from Koha and then reimporting the same batch) - On the manage page for that batch try changing the matching rule applied, switching between "Do not look for matching records" and a matching rule which will catch the duplicate records. - Test that your records are imported correctly according to the framework settings you select, both for new records and for replaced records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 15:33:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 13:33:42 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-SgiGK2es1r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151799&action=edit Bug 33864: Set default date in all acqcreateitem scenarios On b0aab2aeef9a025d3907d0b723b5ea71eaf94542 the flatpickr default to 'today' was restored, but only for acqcreateitem='ordering'. This patch moves the initialization to a different stop for broader reach. To test: 1. Have 3 baskets on with each setting: - create_item = 'cateloguing' - create_item = 'ordering' - create_item = 'receiving' 2. Close those baskets 3. Go to 'Receive shipments' 4. Choose things from the 3 baskets and then 'Receive selected' 5. Navigate through the different orders => FAIL: Only the one that has items created on ordering has the date filled by default 6. Apply this patch 7. Reload the page 8. Repeat 5 => SUCCESS: Dates are pre-filled! 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 15:34:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 13:34:58 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff interface catalog details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-erdGj2Uyog@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 --- Comment #28 from Chad Billman <chad at pennmanor.net> --- My error went away after I upgraded the debian package to 22.11.06-3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 15:41:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 13:41:00 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-LE6ZCZWzXQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 --- Comment #2 from Andrew Nugged <nugged at gmail.com> --- Extra note: in 22.11 quantity was hard coded to 1 when no quantityreceived and the date to "today" if there's no "datereceived" property for the order, and that was more comfortable for our librarians than "0"/"empty". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 15:43:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 13:43:25 +0000 Subject: [Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used In-Reply-To: <bug-33847-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33847-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33847-70-r00luDLPS8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 15:51:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 13:51:11 +0000 Subject: [Koha-bugs] [Bug 33846] 'Save' and 'close' buttons confusing on multi-receive In-Reply-To: <bug-33846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33846-70-6K31qbB5WR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- In my understanding we effectively save the data stored in the "row" data of #order_edit when we click "Save": see onclick event on .modal-save which is calling save_rows -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:27:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 14:27:50 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: <bug-33245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33245-70-uN96aMPkgd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28688 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 [Bug 28688] Auto Renew Patron Membership if Patron has Been Active -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:27:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 14:27:50 +0000 Subject: [Koha-bugs] [Bug 28688] Auto Renew Patron Membership if Patron has Been Active In-Reply-To: <bug-28688-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28688-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28688-70-eg2lPR22bZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33245 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 [Bug 33245] Add $patron->is_active -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:28:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 14:28:22 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership for active patrons In-Reply-To: <bug-28688-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28688-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28688-70-QA8CprzDxc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Auto Renew Patron |Automatically renew patron |Membership if Patron has |membership for active |Been Active |patrons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:31:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 14:31:03 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership for active patrons In-Reply-To: <bug-28688-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28688-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28688-70-i4Ly1GnDKo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #4) > Great idea. Is borrowers.lastseen the best way to detect activity, or should > we look at holds or issues or ..? Bug 33245 provides a base for this. You can do $patron->is_active({ months => 6 }) or something and continue. The is_active method looks at datelastseen, enrollment date, expiry date, anonymized status, and recent holds, issues and article requests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:32:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 14:32:39 +0000 Subject: [Koha-bugs] [Bug 33522] Optionally skip inactive patrons when sending membership expiry notices In-Reply-To: <bug-33522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33522-70-C0HoSXNnOD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #0) > Could we use the patron->is_active method here? See bug 33245 (wip). Yes. Bug 33245 provides a base for this. You can do $patron->is_active({ months => 6 }) or something and continue. The is_active method looks at datelastseen, enrollment date, expiry date, anonymized status, and recent holds, issues and article requests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:42:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 14:42:46 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: <bug-33245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33245-70-E1i0U9u5W3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:42:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 14:42:48 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: <bug-33245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33245-70-Lcjc3DmcRm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151800&action=edit Bug 33245: TestBuilder: Default value for anonymized When we create a patron with TestBuilder, we normally do not expect an anonymized status. This will certainly hold for the patrons we are creating for testing is_active in a following patch. Test plan: Run t/db_dependent/Koha/Patron.t Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:42:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 14:42:50 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: <bug-33245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33245-70-p6bkkWWgxp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151801&action=edit Bug 33245: Introduce patron->is_active Does only add the new patron method. NOTE: We may define additional criteria at some point, but I think that this is a good starting point. Test plan: Run perl -MKoha::Patron -e'print Koha::Patrons->find(X)->is_active;' Note: replace X by a valid borrowernumber. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:42:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 14:42:52 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: <bug-33245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33245-70-i6r2FEDT9o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151802&action=edit Bug 33245: Add unit test Test plan: Run t/db_dependent/Koha/Patron.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 16:52:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 14:52:41 +0000 Subject: [Koha-bugs] [Bug 30519] Regression: using sys pref CircConfirmItemParts prevents checkin from moremember.pl and circulation.pl In-Reply-To: <bug-30519-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30519-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30519-70-RNO4eDZ58l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:00:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 15:00:41 +0000 Subject: [Koha-bugs] [Bug 33522] Optionally skip inactive patrons when sending membership expiry notices In-Reply-To: <bug-33522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33522-70-bPH8bXFU2N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:02:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 15:02:13 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership for active patrons In-Reply-To: <bug-28688-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28688-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28688-70-R34mKATCAU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33522 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:02:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 15:02:13 +0000 Subject: [Koha-bugs] [Bug 33522] Optionally skip inactive patrons when sending membership expiry notices In-Reply-To: <bug-33522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33522-70-kxnkn1MNPe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28688 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:03:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 15:03:49 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership for active patrons In-Reply-To: <bug-28688-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28688-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28688-70-P9rzxRA0GY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Note that bug 33522 provides another perspective: do not send expiry notices to inactive patrons. Might feel a bit less friendly, but could be an option too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:11:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 15:11:34 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-k0HjXZ6W5j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151803&action=edit Bug 33864: Better handling of confirmation button This patch corrects the behavior of the 'Confirm' button on the three possible scenarios regarding item creation. Ordering: - Quantity gets locked (only changeable when selecting items) - 'Confirm' disabled, only gets enabled if quantity > 0 Receiving: - Quantity gets locked (only changeable when creating items) - 'Confirm' disabled, only gets enabled if quantity > 0 Cataloguing: - It now defaults to 1 - 'Confirm' enabled by default (because of 1) if quantity is set to 0, it gets disabled. To test: 1. Verify the described behavior with the sample orders for the previous patch. => SUCCESS: It does the job! Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:11:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 15:11:55 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-PU7bjhCzEJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:12:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 15:12:33 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-GRz24SxmlE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano at theke.io, | |jonathan.druart+koha at gmail. | |com, | |katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com, | |michaela.sieber at kit.edu, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:35:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 15:35:40 +0000 Subject: [Koha-bugs] [Bug 33865] New: JS error when importing a staged MARC record file Message-ID: <bug-33865-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33865 Bug ID: 33865 Summary: JS error when importing a staged MARC record file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org When you import a staged MARC record file it triggers a JS error in the console: "Uncaught ReferenceError: submitBackgroundJob is not defined" It seems to be caused by the absence of the JS file background-job-progressbar.js, but the only outward problem seems to the error. Batches are being imported successfully. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:38:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 15:38:34 +0000 Subject: [Koha-bugs] [Bug 33725] Add item's collection code to search results location column in staff interface In-Reply-To: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33725-70-cnFplJUO4G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33725 Kristi <kkrueger at cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger at cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:39:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 15:39:42 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-6mHCf6IOde@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |samalau at gmail.com --- Comment #4 from Sam Lau <samalau at gmail.com> --- error: could not build fake ancestor Patch failed at 0001 Bug 33864: Set default date in all acqcreateitem scenarios -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:43:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 15:43:20 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-kB48eiUDxA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Sam, please make sure you do a git pull before trying to apply patches, Koha is moving fast. Patches apply ok on most recent master branch, testing now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 17:59:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 15:59:18 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-DTcjsWQMGc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- 2 things: 1) The date received patch works fine. No complaints. 2) I have an issue with quantity received: I tested in 20.11.19 and the quantity is set to 0 zero there. Could setting it to 1 have been a local customization? I am in favor of leaving it at 0 and keeping the existing behavior of older versions (I couldn't verify in 22.05) BUT: if we pre-populated I think 1 would still be wrong, it should be pre-set with quantity ordered. 3) BLOCKER: There is an issue if you have a basket with * item create on order * standing order You'll have an empty item form on the left and quantity received is BLOCKED. There is no way to receive. This combination is kinda odd, but currently doesn't cause issues, we can expect libraries having 'order' as standard to forget to change it and they won't be able to fix this in the GUI as the item create value can only be set when the basket is created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:03:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:03:22 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-5vbARZ2I1c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- 4) BLOCKER: if item create 'on receive': Don't lock 'Quantity received'. The existing behaviour is like this: * Enter the number received if you don't care which items will be selected. X checkboxes will be set on the items from top to bottom. * Check uncheck items and the quantity will be adjusted accordingly. The first use case is the one used more often and it's no broken. This means if a library orders something in big numbers, they need to click the checkbox for each and every item (and hate it ;) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:06:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:06:01 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-xbVvfzy6sq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #87 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151804&action=edit Bug 33786: ILL requests table id Make sure requests table is unique when visiting patron ILL history so the table state is not shared unintentionally Reproduce: 1) Have a borrower with >20 ILL requests in their history 2) Visit cgi-bin/koha/members/ill-requests.pl?borrowernumber=<borrowernumber> 3) On the table, click page 2 4) Visit a different borrower with <20 ILL requests 5) Verify that no requests are shown, this is because the table is using page 2 from step 3) 6) Go back to original borrower, click table page 1 7) Now go back to 2nd borrower, verify is now showing page 1 correctly Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:06:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:06:51 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-zlkCyqgxz5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151611|0 |1 is obsolete| | --- Comment #88 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151805&action=edit Bug 30719: DB and API - Adds 'batch' accessor to Illrequest object - New illbatches and illbatch_statuses tables - New foreign key 'batch_id' in illrequests table - Atomic update file - Default illbatch_statuses - Add 'add' ill_requests api method - Add POST method in ill_requests path - Add 'batch_id property to ill_request api definition - Updated swagger.yml with new batches and batchstatuses endpoints Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller at ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:06:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:06:58 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-JLiOXpWiVT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151612|0 |1 is obsolete| | --- Comment #89 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151806&action=edit Bug 30719: ILL Batches - Add batch column to requests table - Establish if there are any availability or metadata enrichment plugins and pass that to the template - Verify if we have any backend that can support batches, if not, don't show the option - Updates to the ILL toolbar - New ILL batch modal - New Koha classes - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller at ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:07:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:07:02 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-TqPhnyCU8z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151613|0 |1 is obsolete| | --- Comment #90 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151807&action=edit Bug 30719: ILL Batch Statuses - UI adding support for batch statuses in batch UI - Admin UI for managing batch statuses - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller at ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:07:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:07:02 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-276FhEK3Nh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151613|0 |1 is obsolete| | Attachment #151804|0 |1 is obsolete| | --- Comment #90 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151807&action=edit Bug 30719: ILL Batch Statuses - UI adding support for batch statuses in batch UI - Admin UI for managing batch statuses - API specs Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller at ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:07:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:07:05 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-PGvvGqYszF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151614|0 |1 is obsolete| | --- Comment #91 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151808&action=edit Bug 30719: Tests Co-authored-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> Signed-off-by: Edith Speller <Edith.Speller at ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:07:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:07:08 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-cvHtQrMiKK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151615|0 |1 is obsolete| | --- Comment #92 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151809&action=edit Bug 30719: dbic specific, DONT PUSH Signed-off-by: Edith Speller <Edith.Speller at ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:08:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:08:08 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-qAHcOtOm0j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #93 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- rebased for bug 33716 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:08:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:08:45 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-F0ZAkl7Ed8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #94 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- rebase for bug 33786 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:11:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:11:11 +0000 Subject: [Koha-bugs] [Bug 33857] Reduce and resize local cover images In-Reply-To: <bug-33857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33857-70-E7kRNGWnqH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33857 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:11:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:11:14 +0000 Subject: [Koha-bugs] [Bug 33857] Reduce and resize local cover images In-Reply-To: <bug-33857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33857-70-3n22SYyuZX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33857 --- Comment #2 from Sam Lau <samalau at gmail.com> --- Created attachment 151810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151810&action=edit Bug 33857: Add script to resize cover images Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:13:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:13:36 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-t1IHN4T01f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:13:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:13:39 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-gyu2FZgK4G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151803|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151811&action=edit Bug 33864: Better handling of confirmation button This patch corrects the behavior of the 'Confirm' button on the three possible scenarios regarding item creation. Ordering: - Quantity gets locked (only changeable when selecting items) - 'Confirm' disabled, only gets enabled if quantity > 0 Receiving: - Quantity gets locked (only changeable when creating items) - 'Confirm' disabled, only gets enabled if quantity > 0 Cataloguing: - It now defaults to 1 - 'Confirm' enabled by default (because of 1) if quantity is set to 0, it gets disabled. To test: 1. Verify the described behavior with the sample orders for the previous patch. => SUCCESS: It does the job! Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:15:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:15:32 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-GSI6oIPAxA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Katrin Fischer from comment #6) > 2 things: > > 1) The date received patch works fine. No complaints. Great. > 2) I have an issue with quantity received: > I tested in 20.11.19 and the quantity is set to 0 zero there. > Could setting it to 1 have been a local customization? > I am in favor of leaving it at 0 and keeping the existing behavior of > older versions (I couldn't verify in 22.05) > BUT: if we pre-populated I think 1 would still be wrong, it should be > pre-set with quantity ordered. Separate bug I think, we checked this is how it works in 22.11. > 3) BLOCKER: There is an issue if you have a basket with > * item create on order > * standing order > You'll have an empty item form on the left and quantity received is > BLOCKED. > There is no way to receive. > This combination is kinda odd, but currently doesn't cause issues, we can > expect libraries having 'order' as standard to forget to change it and > they > won't be able to fix this in the GUI as the item create value can only be > set > when the basket is created. Can you check with the new version? (In reply to Katrin Fischer from comment #7) > 4) BLOCKER: if item create 'on receive': > Don't lock 'Quantity received'. > The existing behaviour is like this: > * Enter the number received if you don't care which items will be > selected. > X checkboxes will be set on the items from top to bottom. > * Check uncheck items and the quantity will be adjusted accordingly. > The first use case is the one used more often and it's no broken. > This means if a library orders something in big numbers, they need to click > the checkbox for each and every item (and hate it ;) ) Can you check with the new version? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:18:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:18:34 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33462-70-uqLf9N2ZgJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 Rebecca Coert <rcoert at arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:19:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:19:03 +0000 Subject: [Koha-bugs] [Bug 33784] Save clicks on single order receive In-Reply-To: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33784-70-6rBl6cIt3V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 Andrew Nugged <nugged at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33864 Depends on|33864 | CC| |nugged at gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:19:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:19:03 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-9VSSrBHWAO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Andrew Nugged <nugged at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33784 | Depends on| |33784 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 [Bug 33784] Save clicks on single order receive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:20:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:20:14 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-WZRWenwXnm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Andrew Nugged <nugged at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:20:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:20:14 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-0uO2e8t9ZF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Andrew Nugged <nugged at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33864 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:25:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:25:58 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30719-70-uTY3fB9ipX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33762 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33762 [Bug 33762] Restore page-section in ILL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:25:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:25:58 +0000 Subject: [Koha-bugs] [Bug 33762] Restore page-section in ILL In-Reply-To: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33762-70-z8J8SRLUfd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33762 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30719 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 [Bug 30719] ILL should provide the ability to create batch requests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:26:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:26:18 +0000 Subject: [Koha-bugs] [Bug 33866] New: ExcludeHolidaysFromMaxPickUpDelay needs individual library settings Message-ID: <bug-33866-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33866 Bug ID: 33866 Summary: ExcludeHolidaysFromMaxPickUpDelay needs individual library settings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com ExcludeHolidaysFromMaxPickUpDelay is useless to consortium that has libraries that are only open part time. This setting can delay items an extra week if used, while this would be a perfect setting for larger libraries that are usually open 7 days a week. It would be preferable if this setting were set under individual libraries rather than as an all or nothing setting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:26:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:26:57 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-BJpNiS8eng@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:27:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:27:00 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-UyNNxSWfJa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151799|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151812&action=edit Bug 33864: Set default date in all acqcreateitem scenarios On b0aab2aeef9a025d3907d0b723b5ea71eaf94542 the flatpickr default to 'today' was restored, but only for acqcreateitem='ordering'. This patch moves the initialization to a different stop for broader reach. To test: 1. Have 3 baskets on with each setting: - create_item = 'cateloguing' - create_item = 'ordering' - create_item = 'receiving' 2. Close those baskets 3. Go to 'Receive shipments' 4. Choose things from the 3 baskets and then 'Receive selected' 5. Navigate through the different orders => FAIL: Only the one that has items created on ordering has the date filled by default 6. Apply this patch 7. Reload the page 8. Repeat 5 => SUCCESS: Dates are pre-filled! 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:27:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:27:03 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-IvGBQ3jPJR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151811|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151813&action=edit Bug 33864: Better handling of confirmation button This patch corrects the behavior of the 'Confirm' button on the three possible scenarios regarding item creation. Ordering: - Quantity gets locked (only changeable when selecting items) - 'Confirm' disabled, only gets enabled if quantity > 0 Receiving: - Quantity gets locked (only changeable when creating items) - 'Confirm' disabled, only gets enabled if quantity > 0 Cataloguing: - It now defaults to 1 - 'Confirm' enabled by default (because of 1) if quantity is set to 0, it gets disabled. To test: 1. Verify the described behavior with the sample orders for the previous patch. => SUCCESS: It does the job! Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> https://bugs.koha-community.org/show_bug.cgi?id=33846 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:32:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:32:24 +0000 Subject: [Koha-bugs] [Bug 32372] ExcludeHolidaysFromMaxPickUpDelay needs to include new option for expiration date In-Reply-To: <bug-32372-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32372-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32372-70-We55VJaZbi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32372 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Hold requests |System Administration Summary|Calculate hold waiting |ExcludeHolidaysFromMaxPickU |expiration based on days |pDelay needs to include new |closed |option for expiration date --- Comment #1 from Christopher Brannon <cbrannon at cdalibrary.org> --- This would be a really helpful addition to this setting! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:45:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:45:01 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-VfOzjIkQDj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 --- Comment #12 from Andrew Nugged <nugged at gmail.com> --- but to say how it behave before 23.05 - on our 22.11 there was such code: [% IF ( order.quantityreceived ) %] ... [% ELSE %] <input type="text" inputmode="numeric" pattern="[0-9]*" id="quantity" size="20" name="quantityrec" value="1" /> <input id="origquantityrec" readonly="readonly" type="hidden" name="origquantityrec" value="0" /> [% END %] i.e. hardcoded `value="1"`. And I see same on 22.05 and since ages: Bug 5917 : Converted templates 77b64098 Year 2011 [% IF ( items ) %] <input id="quantityrec" READONLY type="text" size="20" name="quantityrec" value="1" /> [% ELSE %] <input id="quantityrec" type="text" size="20" name="quantityrec" value="1" /> [% END %] ====== >(In reply to Katrin Fischer from comment #6) > I am in favor of leaving it at 0 and keeping the existing behavior of > older versions (I couldn't verify in 22.05) > BUT: if we pre-populated I think 1 would still be wrong, it should be > pre-set with quantity ordered. It would be a time saver if it were prepopulated with the quantity ordered, but at least having it "1" covers most cases our librarians receiving something 1, so good point to have it more clever but not zero. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:46:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:46:37 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-lBVOKYZL2M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:46:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:46:39 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-nqV78XKjnW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151658|0 |1 is obsolete| | --- Comment #12 from Sam Lau <samalau at gmail.com> --- Created attachment 151814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151814&action=edit Bug 28130: Manage a patron's subscription alerts This enhancement adds an 'Alert subscriptions' page to a patron account to easily view or cancel email alerts the patron has subscribed to. To test: 1. Go to Cataloging. Create a biblio. 2. Go to Tools -> Notices & slips. Create a notice under the "Serials (new issue)" module, if you don't already have one. 3. Go to Serials. Create a subscription. Link the biblio you just created. Add info like the callnumber, location, library. Choose your notice under Patron notification. Fill out the remaining details and save your subscription. 4. Open this record in the OPAC. Under the Subscriptions tab, click the button to "Subscribe to email notification on new issues" 5. Go back to the staff interface. Go to your patron account. 6. Notice there is a new "Alert subscriptions" tab in the left sidebar menu. The number in brackets should say 1, for the subscription you just enabled email alerts. 7. Click into the page. Confirm your subscription shows in the table. 8. Click the button to unsubscribe. A confirmation should pop up. Confirm you can cancel the unsubscribe action. Then confirm you can unsubscribe using this button. 9. Confirm tests pass t/db_dependent/Koha/Patron.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller at bsz-bw.de> Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:46:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:46:42 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-B9vsHrmFvj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151659|0 |1 is obsolete| | --- Comment #13 from Sam Lau <samalau at gmail.com> --- Created attachment 151815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151815&action=edit Bug 28130: Manage subscription alerts on OPAC This patch adds an 'Alert subscriptions' tab to the patron's account on the OPAC, so they can easily view or cancel email alerts they have subscribed to. To test: 1. Subscribe to email alerts for one or more subscriptions via the OPAC 2. Go to your account, notice the new 'Alert subscriptions' menu option, click here 3. Confirm your subscribed alerts show here. Confirm the table sorting works etc (JS enabled). 4. Test unsubscribing from email alerts, make sure the confirmation pop-up works as expected (JS enabled). 5. Confirm that, when unsubscribing, you are redirected back to this page. 6. Confirm the menu option disappears from the left sidebar navigation if you have no alert subscriptions. Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller at bsz-bw.de> Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:49:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:49:41 +0000 Subject: [Koha-bugs] [Bug 33848] Enabling Coce in the OPAC breaks cover images on bibliographic detail page In-Reply-To: <bug-33848-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33848-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33848-70-8SaIMF3u7L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- I'm able to reproduce this problem *intermittently* using Firefox, the sample data in master, and with these preferences enabled: OPACAmazonCoverImages OpacCoce GoogleJackets OpenLibraryCovers I perform this search: http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?q=su:%22C%20Computer%20program%20language%22 The first result, "The C programming language," shows four covers, one from each of the services listed above. On the detail page for that result, it only shows three covers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 18:58:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 16:58:57 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-wR7ccU1whc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 --- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151816&action=edit Bug 33864: Restore inputmode="numeric" (bug 28283) Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 19:03:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 17:03:22 +0000 Subject: [Koha-bugs] [Bug 33867] New: Quantity received should default to quantity ordered when creating items on cataloguing Message-ID: <bug-33867-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33867 Bug ID: 33867 Summary: Quantity received should default to quantity ordered when creating items on cataloguing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org At least in 22.11 (and in 23.05) it defaults to 1. It's been said that 20.11 defaulted to 0. There's some consensus it would be more helpful to have it default to quantity ordered or zero instead. I found bug 6903 for reference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 19:03:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 17:03:41 +0000 Subject: [Koha-bugs] [Bug 33867] Quantity received should default to quantity ordered when creating items on cataloguing In-Reply-To: <bug-33867-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33867-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33867-70-2Hp11U6ATp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33867 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Depends on| |33864 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6903 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 19:03:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 17:03:41 +0000 Subject: [Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing" In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-FX81UVleyb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33867 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33867 [Bug 33867] Quantity received should default to quantity ordered when creating items on cataloguing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 19:03:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 17:03:41 +0000 Subject: [Koha-bugs] [Bug 6903] Quantity for odering from suggestion should not default to 0 In-Reply-To: <bug-6903-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6903-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6903-70-QnYRm89MMn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6903 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33867 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 19:08:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 17:08:00 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-rAd0XfcTMm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Modal broken when |Problems in order receive |"AcqCreateItem" set to |modal |"cataloguing" | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 19:15:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 17:15:26 +0000 Subject: [Koha-bugs] [Bug 33698] Add fields to verbose output of cronjob delete_items.pl In-Reply-To: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33698-70-TH6GKM2ZoX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33698 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 19:15:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 17:15:36 +0000 Subject: [Koha-bugs] [Bug 33698] Add fields to verbose output of cronjob delete_items.pl In-Reply-To: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33698-70-rSarKtxu9r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33698 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |Laura.escamilla at bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 19:20:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 17:20:05 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-bKDdPKALMO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 19:20:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 17:20:57 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-JHP1bjgErE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 --- Comment #24 from Owen Leonard <oleonard at myacpl.org> --- The interface may be assumed to be "intranet" but should it log that information anyway for consistency? +---------------------+--------+--------+------------+-----------+ | datetime | branch | value | type | interface | +---------------------+--------+--------+------------+-----------+ | 2023-05-30 17:16:18 | CPL | 0.0000 | issue | intranet | | 2023-05-30 17:16:27 | CPL | NULL | item_lost | NULL | | 2023-05-30 17:18:45 | CPL | NULL | item_found | NULL | | 2023-05-30 17:18:45 | CPL | NULL | return | intranet | +---------------------+--------+--------+------------+-----------+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 19:24:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 17:24:16 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-jQVb8rXStI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 --- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151817&action=edit Bug 33783: Only use ecost if unitprice has not been set on ordering Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 19:25:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 17:25:13 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-Y9U3izOx1T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 19:25:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 17:25:23 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-deU2CoGNKf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 19:32:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 17:32:11 +0000 Subject: [Koha-bugs] [Bug 23305] Add ability to append to item notes in batch item modification In-Reply-To: <bug-23305-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23305-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23305-70-YaI5tBJJHu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23305 Sarah Cornell <sbcornell at cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell at cityofportsmouth. | |com --- Comment #6 from Sarah Cornell <sbcornell at cityofportsmouth.com> --- I'm glad appending is possible, and I've used it a few times. But it would be *so* wonderful if there were a checkbox that said "append?" and Koha would simply append if that was checked. It's a lot to ask my staff to learn even that amount of regex in order to append to notes when batch editing. Would a checkbox like that be possible? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 19:33:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 17:33:16 +0000 Subject: [Koha-bugs] [Bug 33846] 'Save' and 'close' buttons confusing on multi-receive In-Reply-To: <bug-33846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33846-70-zVk6H6gkIe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- When the modal opens, a copy of the underlying row is stored in the 'row' data element of the #order_edit element which is the modal itself. That data element is kept in sync with the events you mention, Nick. Not the 'real row' on the underlying table. And the 'real row' is synced using the `save_rows_()` function, looping through the 'real rows'. Nick: are you suggesting a more subtle issue? Like the row being stored as a reference to the one in the modal and causing issues? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 19:34:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 17:34:49 +0000 Subject: [Koha-bugs] [Bug 33846] 'Save' and 'close' buttons confusing on multi-receive In-Reply-To: <bug-33846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33846-70-QvdtwRGVsZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- I meant `keep_row()` not `save_rows()`. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 19:36:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 17:36:56 +0000 Subject: [Koha-bugs] [Bug 23305] Add ability to append to item notes in batch item modification In-Reply-To: <bug-23305-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23305-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23305-70-s0jomrjeow@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23305 --- Comment #7 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- (In reply to Sarah Cornell from comment #6) > I'm glad appending is possible, and I've used it a few times. But it would > be *so* wonderful if there were a checkbox that said "append?" and Koha > would simply append if that was checked. It's a lot to ask my staff to > learn even that amount of regex in order to append to notes when batch > editing. > > Would a checkbox like that be possible? Seems like a reasonable enhancement, yeah! We could reopen this bug as a request for a dedicated tool/checkbox/option or you could file a new one. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 19:39:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 17:39:48 +0000 Subject: [Koha-bugs] [Bug 23305] Add ability to append to item notes in batch item modification In-Reply-To: <bug-23305-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23305-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23305-70-OOHPkB3XrZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23305 --- Comment #8 from Sarah Cornell <sbcornell at cityofportsmouth.com> --- I've never filed a bug so I propose reopening this one! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:14:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 18:14:49 +0000 Subject: [Koha-bugs] [Bug 25079] Show club enrollment question answers in staff interface In-Reply-To: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25079-70-qb7utFHbZb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25079 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151603|0 |1 is obsolete| | Attachment #151604|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151818&action=edit Bug 25079: Add a 'edit' functionality to the Clubs tool in the staff interface A club enrollment can be cancel but it can't be edited This patch add a 'edit' functionality to the Clubs tool in the staff interface Test plan 1. Create a club template 1.1. Go to Tools > Patron clubs 1.2. Click on 'New Club Template' 1.3. Fill the form 1.4. on the 'Club fields' section, Click on Add new field 1.5. Fill in the form 1.6. on the 'Enrollment fields' section, Click on Add new field 1.7. Fill in the form 1.8. Click on Save button 2. Creation of the club 2.1. Go to Tools > Patron clubs > 'Clubs' section (bottom) 2.2. Click on the 'New Club' button and select the club template create on step 1 2.3. Fill in the form 2.4. Click on Save button 3. Club enrollement On the intranet 3.1. Search for a pratron and open the patron folder 3.2. Click on the 'Clubs' tab 3.3. Find the name of the club and click on 'Enroll' 3.4. Fill the questionnaire 3.5. Confirm registration ---> Note that the enrollement can be canceled but it cannot be modified 4. Apply the patch 5. Click one more time on the 'Clubs' tab ---> Note that the enrollement can now be modified Signed-off-by: Sam Lau <samalau at gmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:14:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 18:14:56 +0000 Subject: [Koha-bugs] [Bug 25079] Show club enrollment question answers in staff interface In-Reply-To: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25079-70-6axCQM2Q8W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25079 --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151819&action=edit Bug 25079: Show club enrollment question answers in staff client When a patron is enrolled in a patron club, koha collects answers to library-defined enrollment questions. Those answers go into the database but are not viewable outside of reports. This patch make those answers viewable on club-enrollments.pl. Test plan 1. Apply the patch 2. Create a club template 2.1. Go to Tools > Patron clubs 2.2. Click on 'New Club Template' 2.3. Fill the form 2.4. on the 'Club fields' section, Click on Add new field 2.5. Fill in the form 2.6. on the 'Enrollment fields' section, Click on Add new field 2.7. Fill in the form 2.8. Click on Save button 3. Creation of the club 3.1. Go to Tools > Patron clubs > 'Clubs' section (bottom) 3.2. Click on the 'New Club' button and select the club template create on step 1 3.3. Fill in the form 3.4. Click on Save button 4. Club enrollement On the intranet (or the OPAC if permitted) 4.1. Search for a pratron and open the patron folder 4.2. Click on the 'Clubs' tab 4.3. Find the name of the club and click on 'Enroll' 4.4. Fill the questionnaire 4.5. Confirm registration 5. Check registrations on the intranet 5.1. Go to Tools > Patron clubs 5.2. In the bottom 'Clubs' section, find the name of the club 5.3. check the 'Enrolled patrons' column ---> should not be equal to zero. 5.4 Click on 'Action' and choose the option “Enrollments” ---> The Enrollment fields created on step 2.6. are viewable in the table with their values Signed-off-by: Sam Lau <samalau at gmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:14:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 18:14:59 +0000 Subject: [Koha-bugs] [Bug 25079] Show club enrollment question answers in staff interface In-Reply-To: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25079-70-2UAhfiUTma@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25079 --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 151820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151820&action=edit Bug 25079: (QA follow-up) Fix TT issues Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:16:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 18:16:49 +0000 Subject: [Koha-bugs] [Bug 25079] Show club enrollment question answers in staff interface In-Reply-To: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25079-70-zAP9PMsJo6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25079 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:17:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 18:17:29 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-ev7nWggAMW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Slava Shishkin <slavashishkin at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:17:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 18:17:32 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-fKwkbiTW0u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 --- Comment #14 from Slava Shishkin <slavashishkin at gmail.com> --- Created attachment 151821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151821&action=edit Bug 33864: Fix to store shadow value for input as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:21:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 18:21:49 +0000 Subject: [Koha-bugs] [Bug 33852] jobs.t is not testing only_current In-Reply-To: <bug-33852-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33852-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33852-70-fCZrAFodWM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33852 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:21:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 18:21:51 +0000 Subject: [Koha-bugs] [Bug 33852] jobs.t is not testing only_current In-Reply-To: <bug-33852-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33852-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33852-70-PVTYpn1UdR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33852 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151774|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau at gmail.com> --- Created attachment 151822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151822&action=edit Bug 33852: Make jobs.t test the only_current parameter This trivial patch adds a test to the only_current parameter. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/jobs.t => SUCCESS: New tests added, and pass 3. Sign off :-D Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:27:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 18:27:04 +0000 Subject: [Koha-bugs] [Bug 23305] Add ability to append to item notes in batch item modification In-Reply-To: <bug-23305-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23305-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23305-70-UfVa4cnRDc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23305 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:28:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 18:28:29 +0000 Subject: [Koha-bugs] [Bug 23305] Add ability to append to item notes in batch item modification In-Reply-To: <bug-23305-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23305-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23305-70-RizNSSeocZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23305 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #9 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- I'm re-opening this bug to suggest a dedicated Append option in the item batch mod tool -- the ability to check a box labeled "append" and have whatever text is entered appended to the respective field rather than overwriting it. It'd probably make sense to include this on all the LONGTEXT fields in the item record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:28:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 18:28:42 +0000 Subject: [Koha-bugs] [Bug 23305] Add dedicated option to append to item notes in batch item modification In-Reply-To: <bug-23305-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23305-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23305-70-KmATfLyKs5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23305 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to append to |Add dedicated option to |item notes in batch item |append to item notes in |modification |batch item modification -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:29:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 18:29:32 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-7AU0Pg0Jvo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Slava Shishkin <slavashishkin at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |slavashishkin at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:47:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 18:47:49 +0000 Subject: [Koha-bugs] [Bug 33698] Add fields to verbose output of cronjob delete_items.pl In-Reply-To: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33698-70-57ziHXNEqh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33698 --- Comment #1 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 151823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151823&action=edit Bug 33698: Add fields to the verbose output that show the barcode and title of items that cannot be deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:48:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 18:48:23 +0000 Subject: [Koha-bugs] [Bug 33698] Add fields to verbose output of cronjob delete_items.pl In-Reply-To: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33698-70-TxXvPS20hE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33698 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Test Plan: 1. Checkout an item to a patron. 2. Mark that item as withdrawn. 3. Run misc/cronjobs/deleted_items.pl 4. Confirm that no barcode or title are shown. 5. Apply patch and restart services 6. Run the cron again. 7. Confirm that the barcode and title of the item withdrawn are shown and correct. 8. Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 20:54:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 18:54:07 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-kEaJSr7XZj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151769|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:13:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 19:13:27 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-Du2H1ZTPKR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151821|0 |1 is obsolete| | --- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 151824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151824&action=edit Bug 33864: Trigger the 'change' event when setting quantity Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:22:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 19:22:22 +0000 Subject: [Koha-bugs] [Bug 31198] Display results search authority numbers In-Reply-To: <bug-31198-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31198-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31198-70-7KZilbftCe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31198 Juliet Heltibridle <jheltibridle at rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle at rcplib.org --- Comment #1 from Juliet Heltibridle <jheltibridle at rcplib.org> --- Displaying the authority number on the Authority Search Results page would be very helpful and save a lot of time. Currently you have to click into an authority, or hover over the link to see the number in the link. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:35:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 19:35:06 +0000 Subject: [Koha-bugs] [Bug 33514] SearchWithIS[B|S]NVariations breaks ISBN search in item search In-Reply-To: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33514-70-88bC9zam8h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:52:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 19:52:55 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-n45ZhKqBgp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 --- Comment #40 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 151825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151825&action=edit Bug 33117: Adding new PatronAutoCompleteSearchMethod system preference Same test plan as above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:53:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 19:53:22 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-w12FvGfYQw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151771|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 21:53:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 19:53:37 +0000 Subject: [Koha-bugs] [Bug 22232] Use Advanced cataloguing editor (Rancor) for authority records In-Reply-To: <bug-22232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22232-70-XlOTpLbLdR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22232 Kristi <kkrueger at cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger at cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:02:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:02:47 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-A0PiPVp95c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:02:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:02:50 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-Tyju7RtVN6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151735|0 |1 is obsolete| | --- Comment #123 from Sam Lau <samalau at gmail.com> --- Created attachment 151826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151826&action=edit Bug 27378: Add new 'modaljs' syspref type This commit adds a new 'modaljs' syspref type. This is similar to the existing 'modalselect' syspref type but instead of using a file to create a list of selectable options which are displayed in the modal, it assumes that anything can happen within the modal driven by JS, and whatever happens is going to return a string, that will be saved as the syspref value. In our case, the string will be all the details of the “chunks” concatenated into a string Signed-ff-by: Barry Cannon <bc at interleaf.ie> (cherry picked from commit ec2dc19564a733a7d1db673331d41c3ae44235e1) Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:02:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:02:53 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-d3wHauXXmh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151736|0 |1 is obsolete| | --- Comment #124 from Sam Lau <samalau at gmail.com> --- Created attachment 151827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151827&action=edit Bug 27378: Add sysprefs This commit adds 4 new sysprefs: - CookieConsent - the master on/off for this functionality - ConsentJS - The configuration for JS code that requires consent prior to running. - CookieConsentBar: Allows the admin to specify the HTML that will be displayed in the consent bar that appears at the bottom of the page - CookieConsentPopup: Allows the admin to specify the HTML that will be displayed in the cookie consent popup Signed-ff-by: Barry Cannon <bc at interleaf.ie> (cherry picked from commit d17ee9aff67f99393aa47376a33764840eb2ab38) Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:02:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:02:57 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-kjgNKDOgjn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151737|0 |1 is obsolete| | --- Comment #125 from Sam Lau <samalau at gmail.com> --- Created attachment 151828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151828&action=edit Bug 27378: Add JS to power modaljs This commit adds the Javascript that provides the functionality within the consentJS modaljs modal. It provides the ability to display the current state of any consentJS values and to amend them, as well as add new ones. There is also some refactoring of the existing modalselect functions to allow re-use of existing code between modalselect & modaljs. This refactoring has been minimal and consists of abstracting functionality into functions to allow more wide use. Styles for the consentJS UI were also added. Signed-ff-by: Barry Cannon <bc at interleaf.ie> (cherry picked from commit 16e78715c6bafba054104eadd1778599a75026da) Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:03:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:03:00 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-CIk1En63hM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151738|0 |1 is obsolete| | --- Comment #126 from Sam Lau <samalau at gmail.com> --- Created attachment 151829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151829&action=edit Bug 27378: Add cookie consent display to OPAC This commit adds the display of the cookie consent bar and modal to the OPAC. - Adds a new JSConsents template plugin that enables a template to be populated with the contents of the ConsentJS syspref in a prepared, usable form - Adds a new cookieconsent.js script that drives the display and functionality of the cookie consent bar and modal - Adds styles for the cookie consent bar and modal - Adds the creation and population of the cookie consent bar and modal, if appropriate - Adds the ability for both authenticated and unauthenticated users to view and modify their consents either via "your consents" or a new unobtrusive "Your cookies" button in the bottom right of the screen. - Adds unit test for JSConsents.pm Signed-ff-by: Barry Cannon <bc at interleaf.ie> (cherry picked from commit e8469e9997eaaefad834b9685e4906f89337bbc6) Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:03:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:03:04 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-Lfctd6rAri@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151739|0 |1 is obsolete| | --- Comment #127 from Sam Lau <samalau at gmail.com> --- Created attachment 151830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151830&action=edit Bug 27378: Add cookie consent display to staff UI This commit adds the display of the cookie consent bar and modal to the staff interface: - Adds a new cookieconsent.js script that drives the display and functionality of the cookie consent bar and modal - Adds styles for the cookie consent bar and modal - Adds the creation and population of the cookie consent bar and modal, if appropriate Signed-ff-by: Barry Cannon <bc at interleaf.ie> (cherry picked from commit 40d4b094420ea1495996976434d250b15ee78c1b) Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:03:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:03:07 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-iL4PyXtSJW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151740|0 |1 is obsolete| | --- Comment #128 from Sam Lau <samalau at gmail.com> --- Created attachment 151831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151831&action=edit Bug 27378: Move "Your cookies" to existing bar The new "Your cookies" button that appeared at the bottom right when an unauthenticated user had made their cookie consent selections wasn't ideal. It has now been moved to the top bar, next to "Lists", this feels like a much more sensible place for it. Signed-ff-by: Barry Cannon <bc at interleaf.ie> (cherry picked from commit a663a7afa5fec005fed90b8a870e6633e133a539) Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:03:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:03:11 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-RVcNeLYoox@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151741|0 |1 is obsolete| | --- Comment #129 from Sam Lau <samalau at gmail.com> --- Created attachment 151832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151832&action=edit Bug 27378: Delete cookies when consent removed We have provided the ability for a user to remove previously granted consent, but we were not removing the cookie associated with that consent. This was a complete oversight on my part. I've introduced an additional bit of metadata for each "consent" defined in the ConsentJS syspref, this allows the admin defining a "consent" to specify a string (which is treated as a regex) that allows us to identify a cookie name associated with that consent. So, for example, if Google Analytics was being added, an identifying string might be '_ga'. This allows us to subsequently remove a cookie that a previously granted consent has set. This commit also adds some missing 'html' filters in koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc and koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc Signed-ff-by: Barry Cannon <bc at interleaf.ie> (cherry picked from commit 13bea186b66e1fd02ddad1327c073a64701edb12) Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:03:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:03:14 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-zOsBgRhkxi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151742|0 |1 is obsolete| | --- Comment #130 from Sam Lau <samalau at gmail.com> --- Created attachment 151833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151833&action=edit Bug 27378: Add cookie domain and path A subtlety I missed was that some tracking services, such as Google Analytics, specify a cookie domain and path that differ from the default. E.g. on a site with a domain of demostaff.koha-ptfs.co.uk, the GA cookie will have a domain of '.koha-ptfs.co.uk' and a path of '/', even though the cookie may have been set at a different path. Both of these things makes sense, but of course unless we also specify both of those things when we try to delete a previously set cookie, we cannot. Therefore, I have added two more bits of metadata to each "consent", Cookie Domain and Cookie Path. It is necessary for an admin creating a "consent" entry to know and specify these values. They can be established by looking a cookie set by the service being configured. This adds more complexity to setting up a consent, but we cannot remove previously set cookies without it. Signed-ff-by: Barry Cannon <bc at interleaf.ie> (cherry picked from commit 2221f55646eb1675888725282005a613435ef0df) Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:03:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:03:18 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-Bz6c2efruc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151743|0 |1 is obsolete| | --- Comment #131 from Sam Lau <samalau at gmail.com> --- Created attachment 151834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151834&action=edit Bug 27378: (follow-up) Fix update delimiter As suggested by Nick in Comment #64 (cherry picked from commit cf64bc373dcec60c51dccfe2e2f9359500c6cc9b) Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:03:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:03:21 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-MckdLzzlmX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151744|0 |1 is obsolete| | --- Comment #132 from Sam Lau <samalau at gmail.com> --- Created attachment 151835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151835&action=edit Bug 27378: (follow-up) Add missing filters (cherry picked from commit 6b8565b949b62269f6d850e6d412458d0dbcfb37) Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:03:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:03:25 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-vFv0oLpDgP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151745|0 |1 is obsolete| | --- Comment #133 from Sam Lau <samalau at gmail.com> --- Created attachment 151836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151836&action=edit Bug 27378: Fix heading structure of opac-patron-consent The current heading structure of opac-patron-consent.tt jumps straight from an h1 to an h5 for cookie consents. This has been changed to an h2 with scss updates to maintain formatting Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:03:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:03:28 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-146RWbWeAb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151746|0 |1 is obsolete| | --- Comment #134 from Sam Lau <samalau at gmail.com> --- Created attachment 151837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151837&action=edit Bug 27378: Fix missing bootstrap button classes This patch restores the background colour to buttons in the intranet where bootstrap classes were being overidden with a default of #fff. The colour of the the "More Information" button in the cookies bar and the "Accept selected non-essential cookies" button in the cookies modal have been changed slightly to comply with accessibility colour contrasts. Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:03:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:03:32 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-KU0Z1q2fef@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151747|0 |1 is obsolete| | --- Comment #135 from Sam Lau <samalau at gmail.com> --- Created attachment 151838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151838&action=edit Bug 27378: Add missing aria-labels The checkboxes on the cookie consent modal were failing accessibility testing for not being labelled. This patch adds aria-labels to the checkboxes to satisfy the accessibility requirements Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:03:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:03:35 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-7WEVec5D8P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151748|0 |1 is obsolete| | --- Comment #136 from Sam Lau <samalau at gmail.com> --- Created attachment 151839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151839&action=edit Bug 27378: Add aria-label to more information button This patch adds an aria-label to the More Information button in order to comply with WCAG Accessibility guidelines Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:03:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:03:38 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-e0bhWhJmUJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151749|0 |1 is obsolete| | --- Comment #137 from Sam Lau <samalau at gmail.com> --- Created attachment 151840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151840&action=edit Bug 27378: Update to new atomicupdate structure This patch consolidates the previous 4 database update files into one atomicupdate file in line with the new structure Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:03:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:03:42 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-zFgTeVYU0F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151750|0 |1 is obsolete| | --- Comment #138 from Sam Lau <samalau at gmail.com> --- Created attachment 151841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151841&action=edit Bug 27378: Change ConsentJS to CookieConsentedJS This patch updates the name of the ConsentJS syspref to CookieConsentedJS and amends the description to be more clear what the syspref is for Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:03:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:03:45 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-2pYWOkire0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151751|0 |1 is obsolete| | --- Comment #139 from Sam Lau <samalau at gmail.com> --- Created attachment 151842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151842&action=edit Bug 27378: Stop the codemirror editor from duplicating Previously, if the "Add new code button" was clicked in the CookieConsentedJS editor, the original entry would have duplicated CodeMirror editors. This was exponential, i.e adding two new lines would result in three codemirror editors appearing on the first entry, two on the second and so on. The click event was not being applied properly and was being applied to every element with the .expand-textarea class, rather than specifically the new elements being created. The addExpandHandler function now loops through each element individually and decides whether to apply the click event handler. Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:03:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:03:48 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-k1s9p76lcS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151752|0 |1 is obsolete| | --- Comment #140 from Sam Lau <samalau at gmail.com> --- Created attachment 151843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151843&action=edit Bug 27378: Prevent delete confirmation from duplicating Previously, if the "Add new code" button was clicked multipe times in the CookieConsentedJS editor and then those new items were deleted, the confirmation alert would show multiple times. This was an incremental issue, i.e. if 4 new items were deleted, then the first of those would require 4 confirmations to delete, the second would require 3 and so on. This is now prevented by looping through all delete buttons and avoiding duplicating the event listeners Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:03:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:03:52 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27378-70-11dS1QFysV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151753|0 |1 is obsolete| | --- Comment #141 from Sam Lau <samalau at gmail.com> --- Created attachment 151844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151844&action=edit Bug 27378: Remove two sysprefs and replace with html customisations Currently there are two sysprefs - CookieConsentBar and CookieConsentPopup. These allow the user to select what text they would like to see in the consent bar and modal. These have been removed and replaced with HTML customisations to allow more flexible customisations and different languages. Sponsored by: PTFS-Europe Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:08:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:08:39 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-dcDXpZAC66@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151825|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:26:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:26:24 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-4pKztowI3f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 --- Comment #41 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 151845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151845&action=edit Bug 33117: Adding new PatronAutoCompleteSearchMethod system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:50:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:50:10 +0000 Subject: [Koha-bugs] [Bug 33698] Add fields to verbose output of cronjob delete_items.pl In-Reply-To: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33698-70-xhB7Q59Mt8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33698 --- Comment #3 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 151846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151846&action=edit Bug 33698: Added fields to the verbose output -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:51:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:51:43 +0000 Subject: [Koha-bugs] [Bug 33698] Add fields to verbose output of cronjob delete_items.pl In-Reply-To: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33698-70-hNUan47uw5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33698 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151846|0 |1 is obsolete| | --- Comment #4 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 151847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151847&action=edit Bug 33698: Added fields to the verbose output Test Plan: 1. Checkout an item to a patron. 2. Mark that item as withdrawn. 3. Run perl misc/cronjobs/delete_items.pl --where "items.withdrawn != 0" --where "items.withdrawn_on <= ‘xxxx-xx-xx’” --verbose --commit (in the x’s you’ll put the year-month-date for tomorrow) 4. Confirm that no barcode or title are shown. 5. Apply patch and restart services 6. Run the cron again. 7. Confirm that the barcode and title of the item withdrawn are shown and correct. 8. Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:52:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:52:20 +0000 Subject: [Koha-bugs] [Bug 33698] Add fields to verbose output of cronjob delete_items.pl In-Reply-To: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33698-70-FogouyzSlP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33698 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151823|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:52:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:52:31 +0000 Subject: [Koha-bugs] [Bug 33698] Add fields to verbose output of cronjob delete_items.pl In-Reply-To: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33698-70-0qE1k4SZc8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33698 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151847|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:53:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:53:06 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-gUiwGQBvEX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Can you explain the latest changes for retesting? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 22:55:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 20:55:04 +0000 Subject: [Koha-bugs] [Bug 33698] Add fields to verbose output of cronjob delete_items.pl In-Reply-To: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33698-70-nd6UULdMST@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33698 --- Comment #5 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 151848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151848&action=edit Bug 33698: Added fields to the verbose output Test Plan: 1. Checkout an item to a patron. 2. Mark that item as withdrawn. 3. Run perl misc/cronjobs/delete_items.pl --where "items.withdrawn != 0" --where "items.withdrawn_on <= ‘xxxx-xx-xx’” --verbose --commit (in the x’s you’ll put the year-month-date for tomorrow) 4. Confirm that no barcode or title are shown. 5. Apply patch and restart services 6. Run the cron again. 7. Confirm that the barcode and title of the item withdrawn are shown and correct. 8. Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 23:08:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 21:08:34 +0000 Subject: [Koha-bugs] [Bug 33867] Quantity received should default to number of unreceived items when creating items on cataloguing In-Reply-To: <bug-33867-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33867-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33867-70-rfgT9NDMRr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33867 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Quantity received should |Quantity received should |default to quantity ordered |default to number of |when creating items on |unreceived items when |cataloguing |creating items on | |cataloguing --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I have been thinking about it some more, maybe instead of ordered it should be quantity ordered minus quantity received? (pending/unreceived items) And 1 for standing and subscription orders? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 23:17:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 21:17:56 +0000 Subject: [Koha-bugs] [Bug 33846] 'Save' and 'close' buttons confusing on multi-receive In-Reply-To: <bug-33846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33846-70-dyjeQtw5TY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Talking about the buttons: I feel like it might be more intuitive to have previous and next buttons next to each other on the left. I want to skip back and forth and now I have to 'move' over the other buttons each time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 23:18:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 21:18:55 +0000 Subject: [Koha-bugs] [Bug 33698] Add fields to verbose output of cronjob delete_items.pl In-Reply-To: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33698-70-3POryhxiSk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33698 --- Comment #6 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Created attachment 151849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151849&action=edit Bug 33698: Add fields to the verbose output that show the barcode and title of items that cannot be deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 23:19:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 21:19:15 +0000 Subject: [Koha-bugs] [Bug 33698] Add fields to verbose output of cronjob delete_items.pl In-Reply-To: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33698-70-mqHanbHHpk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33698 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151848|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 23:22:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 21:22:40 +0000 Subject: [Koha-bugs] [Bug 33698] Add fields to verbose output of cronjob delete_items.pl In-Reply-To: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33698-70-giQefhWNEX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33698 --- Comment #7 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Fixed test plan: Test Plan: 1. Checkout an item to a patron. 2. Mark that item as withdrawn. 3. Run perl misc/cronjobs/delete_items.pl --where "items.withdrawn != 0" --where "items.withdrawn_on <= 'xxxx-xx-xx'" --verbose --commit (in the x’s you’ll put the year-month-date for tomorrow) 4. Confirm that no barcode or title are shown. 5. Apply patch and restart services 6. Run the cron again. 7. Confirm that the barcode and title of the item withdrawn are shown and correct. 8. Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 30 23:24:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 21:24:10 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33117-70-xz8GBzVr2g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 --- Comment #42 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- (In reply to Laura Escamilla from comment #41) > Created attachment 151845 [details] [review] > Bug 33117: Adding new PatronAutoCompleteSearchMethod system preference Need to fix a few more things. Not ready for testing again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 00:10:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 22:10:52 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26597-70-1Bz1oSsbLB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 --- Comment #23 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151850&action=edit Bug 26597: (Fix) remove REST API call and retrieve the patron's data from borrower_data input This patch remove the REST API call in select_user function and retrieve the patron's data from borrower_data To test: 1) Apply patch 2) Search PrefillGuaranteeField preference and make sure some fields are selected 3) Select a user that can have a guarantor 4) In the edit form, click on "Search to add" in "Patron guarantor" fieldset 5) Choose a patron who has at least one of the fields in 1) set 6) Click Select 7) Confirm guarantee's information is filled from the guarantor's record 8) Check that any preexisting information is not overwritten -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 00:10:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 22:10:57 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26597-70-XjwskifxwA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 --- Comment #24 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151851&action=edit Bug 26597: (QA follow-up) Remane select_user and add missing filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 00:18:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 22:18:56 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26597-70-J3Kmqpy4Fc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #25 from Hammat wele <hammat.wele at inlibro.com> --- (In reply to Marcel de Rooy from comment #22) > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt > FAIL filters > missing_filter at line 1921 ( > guarantor_attributes = [% To.json(guarantor_attributes) %];) > missing_filter at line 1924 ( to_api_mapping = [% > To.json(to_api_mapping) %];) > Please fix. Missing_filters added > for this report. Just noting. But might be a chance to rename in members.js? > The name is quite obscure for copying guarantor information. I've rename the function to add_guarantor > Please explain why whe should do an ajax GET in select_user when we pass the > borrower unblessed hash to this function? > This does not look good. It was a suggestion in the comment 5 but you are right, there is no need to use the REST API to retrieve data from the guarantor since we can get it from the borrower hidden input, it is fixed in this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 01:08:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 May 2023 23:08:39 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-qOBXjpjEJz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 --- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Katrin Fischer from comment #16) > Can you explain the latest changes for retesting? The latest patch from Slava then replaced by mine, were talked about on Telegram... When you're using the 'cataloguing' setting, the input is correctly filled with '1' (as per our agreement) but any changes to the UI, should be stored in the underlying JS object that tracks the state of the request. When setting it, I force the 'change()' event, so that internal synced happens (by means of an event handler defined previously for the 'change' event. If you want to test, verify that without the patch, '1' is set, and when you want to confirm, a brief message about receiving less than 1 is incorrect, and then the parcel.pl table displays nothing got received. With the patch, that's fixed: no error, and the thing is received. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 04:36:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 02:36:28 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-v4QNUetxtl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Andrew Nugged <nugged at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 04:36:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 02:36:31 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-NaMurf7Tag@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Andrew Nugged <nugged at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151812|0 |1 is obsolete| | Attachment #151813|0 |1 is obsolete| | Attachment #151816|0 |1 is obsolete| | Attachment #151824|0 |1 is obsolete| | --- Comment #18 from Andrew Nugged <nugged at gmail.com> --- Created attachment 151852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151852&action=edit Bug 33864: Set default date in all acqcreateitem scenarios On b0aab2aeef9a025d3907d0b723b5ea71eaf94542 the flatpickr default to 'today' was restored, but only for acqcreateitem='ordering'. This patch moves the initialization to a different stop for broader reach. To test: 1. Have 3 baskets on with each setting: - create_item = 'cateloguing' - create_item = 'ordering' - create_item = 'receiving' 2. Close those baskets 3. Go to 'Receive shipments' 4. Choose things from the 3 baskets and then 'Receive selected' 5. Navigate through the different orders => FAIL: Only the one that has items created on ordering has the date filled by default 6. Apply this patch 7. Reload the page 8. Repeat 5 => SUCCESS: Dates are pre-filled! 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Andrew Nugged <nugged at gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=33846 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 04:36:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 02:36:34 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-rfmuetg73X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 --- Comment #19 from Andrew Nugged <nugged at gmail.com> --- Created attachment 151853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151853&action=edit Bug 33864: Better handling of confirmation button This patch corrects the behavior of the 'Confirm' button on the three possible scenarios regarding item creation. Ordering: - Quantity gets locked (only changeable when selecting items) - 'Confirm' disabled, only gets enabled if quantity > 0 Receiving: - Quantity gets locked (only changeable when creating items) - 'Confirm' disabled, only gets enabled if quantity > 0 Cataloguing: - It now defaults to 1 - 'Confirm' enabled by default (because of 1) if quantity is set to 0, it gets disabled. To test: 1. Verify the described behavior with the sample orders for the previous patch. => SUCCESS: It does the job! Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Andrew Nugged <nugged at gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=33846 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 04:36:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 02:36:37 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-83ufYD4I6x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 --- Comment #20 from Andrew Nugged <nugged at gmail.com> --- Created attachment 151854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151854&action=edit Bug 33864: Restore inputmode="numeric" (bug 28283) Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Andrew Nugged <nugged at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 04:36:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 02:36:40 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-MCYqzTbcx8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 --- Comment #21 from Andrew Nugged <nugged at gmail.com> --- Created attachment 151855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151855&action=edit Bug 33864: Trigger the 'change' event when setting quantity Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Andrew Nugged <nugged at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 07:36:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 05:36:35 +0000 Subject: [Koha-bugs] [Bug 33833] Remove Test::DBIx::Class from t/SocialData.t In-Reply-To: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33833-70-flqzcK3AJO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33833 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove T::D::C from |Remove Test::DBIx::Class |t/SocialData.t |from t/SocialData.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 07:37:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 05:37:58 +0000 Subject: [Koha-bugs] [Bug 33863] On receive "change currency" is always checked In-Reply-To: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33863-70-XD5m4uOS1S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"change currency" always |On receive "change |checked |currency" is always checked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 07:41:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 05:41:59 +0000 Subject: [Koha-bugs] [Bug 33863] On receive "change currency" is always checked In-Reply-To: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33863-70-XAdX3InnAV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I tried testing, but the 'Confirm' button always remains locked/inactive, so I can't receive the first item. Could this have to do with one of the other bugs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 07:42:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 05:42:51 +0000 Subject: [Koha-bugs] [Bug 33863] On receive "change currency" is always checked In-Reply-To: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33863-70-OF0l6Edh01@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I set quantity received, checked the "change currency", entered price and changed currency. Order line had create items while cataloguing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 07:48:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 05:48:56 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-t8MXk634C2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 07:48:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 05:48:59 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-EfdswUw5br@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151852|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151856&action=edit Bug 33864: Set default date in all acqcreateitem scenarios On b0aab2aeef9a025d3907d0b723b5ea71eaf94542 the flatpickr default to 'today' was restored, but only for acqcreateitem='ordering'. This patch moves the initialization to a different stop for broader reach. To test: 1. Have 3 baskets on with each setting: - create_item = 'cateloguing' - create_item = 'ordering' - create_item = 'receiving' 2. Close those baskets 3. Go to 'Receive shipments' 4. Choose things from the 3 baskets and then 'Receive selected' 5. Navigate through the different orders => FAIL: Only the one that has items created on ordering has the date filled by default 6. Apply this patch 7. Reload the page 8. Repeat 5 => SUCCESS: Dates are pre-filled! 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Andrew Nugged <nugged at gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=33846 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 07:49:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 05:49:02 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-ByTP3EYG8h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151853|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151857&action=edit Bug 33864: Better handling of confirmation button This patch corrects the behavior of the 'Confirm' button on the three possible scenarios regarding item creation. Ordering: - 'Confirm' disabled, only gets enabled if quantity > 0 Receiving: - Quantity gets locked (only changeable when creating items) - 'Confirm' disabled, only gets enabled if quantity > 0 Cataloguing: - It now defaults to 1 - 'Confirm' enabled by default (because of 1) if quantity is set to 0, it gets disabled. To test: 1. Verify the described behavior with the sample orders for the previous patch. => SUCCESS: It does the job! Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Andrew Nugged <nugged at gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=33846 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 07:49:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 05:49:05 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-xrnc1CuXaj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151854|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151858&action=edit Bug 33864: Restore inputmode="numeric" (bug 28283) Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Andrew Nugged <nugged at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 07:49:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 05:49:09 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-tC00MQU3Wo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151855|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 151859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151859&action=edit Bug 33864: Trigger the 'change' event when setting quantity Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Andrew Nugged <nugged at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 07:49:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 05:49:40 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-aUHd2SsXfT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 --- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I did another round of testing and adjusted the test plan of the second patch (we no longer lock quantity for 'create on order') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 07:50:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 05:50:14 +0000 Subject: [Koha-bugs] [Bug 33863] On receive "change currency" is always checked In-Reply-To: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33863-70-kaJZ7aauwt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33864 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #2) > I tried testing, but the 'Confirm' button always remains locked/inactive, so > I can't receive the first item. > > Could this have to do with one of the other bugs? This appears to be fixed by bug 33864, making them dependent for now. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 [Bug 33864] Problems in order receive modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 07:50:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 05:50:14 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-wMK4aIV625@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33863 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 [Bug 33863] On receive "change currency" is always checked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 07:55:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 05:55:58 +0000 Subject: [Koha-bugs] [Bug 33863] On receive "change currency" is always checked In-Reply-To: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33863-70-rgb0Wmf6Rs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It almost works: Test plan: Create an order with 3+ items Receive 1 item, don't check "change currency" Receive an other item => "Change currency" is not checked Check "Change currency", modify the currency and the price Receive a third item => Change currency is checked, invoice currency and price are set correctly to the previous values This works as described, but in the last step, the "Actual cost" is 0 and it should have the calculated price from the foreign currency. You need to click into the field and add a space or so to trigger the JS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 08:42:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 06:42:53 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26597-70-BQDoRZxN39@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 --- Comment #26 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Hammat wele from comment #24) > Created attachment 151851 [details] [review] > Bug 26597: (QA follow-up) Remane select_user and add missing filters This is wrong. You are mixing different things. select_user in patron-search.inc cannot be renamed, it's a generic function that is used in other places. If you rename it you are going to break other patron searches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 08:48:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 06:48:32 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26597-70-ToD6obEAJy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 --- Comment #27 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- If you are removing the REST API fetch I don't see why you are still passing and using to_api_mapping. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 09:25:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 07:25:34 +0000 Subject: [Koha-bugs] [Bug 33863] On receive "change currency" is always checked In-Reply-To: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33863-70-ynpUVykt74@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Skipping this for 23.05.00, back later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 09:29:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 07:29:45 +0000 Subject: [Koha-bugs] [Bug 33863] On receive "change currency" is always checked In-Reply-To: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33863-70-FXAaxENm9m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I think this patch is correct and what Katrin describes is an other bug (unitprice retrieved from parent order but not adjusted from already received order, when invoice_unitprice is stored in the parent order). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 09:37:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 07:37:47 +0000 Subject: [Koha-bugs] [Bug 33863] On receive "change currency" is always checked In-Reply-To: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33863-70-LjvwFr7Xu5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Talked to Jonathan about this and trying to summarize: * When we do a partial receive, the order lines are split into a parent and a child order line. The child is the one that is set to received, the parent remains. * But we do store some values in the parent order from the first receive: parent order has: unitprice: 0.000000 invoice_unitprice: 42.000000 invoice_currency: EUR Received child order line: unitprice: 36.710000 invoice_unitprice: 42.000000 invoice_currency: EUR * So we can check the checkbox and set the foreign currency and original price, but the actual cost remains empty that would be pulled from unitprice, if it was set. I think we could trigger the JS on opening the page if the actual cost was empty, filling in the actual cost with the calculated price in active currency. I am only worried about one use case: * Create a basket, create an order line, fill in "actual cost" on the order form * Receive the first item and set original price etc. * What happens to the actual cost in the parent? Does it remain the original value from ordering or is it updated? I assume it remains. * Receive the next item: original price would show as entered previously, but the actual cost would not be calculated from it, but be the one entered at order time. Could this be confusing? I can think of some ways to resolve: a) Store not only the original price (invoice_unitprice) in the parent, but also the unitprice. BUT: exchange rates might change between receives. So we'd still want to recalculate the unitprice on receive with the current exchange rate. Storing it doesn't seem to give us an advantage. b) When receiving, automatically calculate the actual cost (unitprice) from the invoice_unitprice with the current exchange rate (trigger JS). I'd do this independently if unitprice was set or not, so there is a relation between the original price (invoice_unitprice) we see and the actual cost (unitprice) c) Don't store the invoice_unitprice in the parent. People will need to enter it, calculation is triggered. An existing actual cost value might show before the value is entered. I think we can scratch a). b) or c)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 09:40:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 07:40:15 +0000 Subject: [Koha-bugs] [Bug 33863] On receive "change currency" is always checked In-Reply-To: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33863-70-sXjm3sYAbU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #7) > I think this patch is correct and what Katrin describes is an other bug > (unitprice retrieved from parent order but not adjusted from already > received order, when invoice_unitprice is stored in the parent order). I disagree. The problem appears because we are trying to pre-set values that might not match up (unitprice and invoice_unitprice should depend on each other, being calculated from current exchange rate) Without this change, we don't have the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 09:49:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 07:49:06 +0000 Subject: [Koha-bugs] [Bug 32671] basic_workflow.t is failing randomly In-Reply-To: <bug-32671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32671-70-E9GG8CrbHB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32671 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Koha_Master/2537 koha_1 | CP main = 3.56 koha_1 | koha_1 | # Failed test at t/db_dependent/selenium/basic_workflow.t line 113. koha_1 | Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 125. koha_1 | # 'Patron categories › Administration › Koha' koha_1 | # doesn't match '(?^u:New category)' koha_1 | CP add patron category = 11.80 koha_1 | CP add patron = 5.86 koha_1 | CP add biblio = 0.32 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 10:15:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 08:15:09 +0000 Subject: [Koha-bugs] [Bug 33863] On receive "change currency" is always checked In-Reply-To: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33863-70-xWvfbhOGoy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- The problem here is that the checkbox is always checked. I think we should fix that for 23.05.00. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 10:20:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 08:20:24 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-dIT9iWib1v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |normal Version(s)| |23.05.00 released in| | Status|Signed Off |Passed QA Keywords|regression, | |rel_23_05_candidate | --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Pushed to master for 23.05.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 10:20:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 08:20:30 +0000 Subject: [Koha-bugs] [Bug 33864] Problems in order receive modal In-Reply-To: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33864-70-ZcgOJO67Hs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | --- Comment #27 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Pushed to master for 23.05.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 10:20:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 08:20:35 +0000 Subject: [Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up) In-Reply-To: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33783-70-zB2NPpiYgu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 10:29:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 08:29:26 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff interface catalog details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-smGoVBWlLp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Barry Cannon <bc at interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bc at interleaf.ie --- Comment #29 from Barry Cannon <bc at interleaf.ie> --- I am still seeing this error, even after upgrading to 22.11.06-3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 11:09:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 09:09:03 +0000 Subject: [Koha-bugs] [Bug 33863] On receive "change currency" is always checked In-Reply-To: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33863-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33863-70-6HEY7pahGV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #10) > The problem here is that the checkbox is always checked. I think we should > fix that for 23.05.00. Ok, yes, we could uncheck it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 13:23:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 11:23:44 +0000 Subject: [Koha-bugs] [Bug 32695] Search string for 775 'Other editions' is incorrectly formed In-Reply-To: <bug-32695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32695-70-3tdqHobMPj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32695 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 13:23:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 11:23:46 +0000 Subject: [Koha-bugs] [Bug 32695] Search string for 775 'Other editions' is incorrectly formed In-Reply-To: <bug-32695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32695-70-x5xdXXnrxd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32695 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151770|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151860&action=edit Bug 32695: Use title (subfield t) only for 'Other editions' search links Currently the code does a title phrase search, but combines the title field with the Main Entry (author) field. This patch simply limits the search to the title to ensure links work To test: 1 - Ensure systme preference 'UseControlNumber' is set to don't 2 - Edit Default MARC framework in administration->Marc frameworks 3 - Make 775 subfields a & t visible in editor 4 - Edit a record to add a field 775 with subfields a & t that match another title/author in your system 5 - Save the record and view the details page 6 - Click the other editions link - no results 7 - Apply patch, restart_all 8 - Reload details and confirm the link works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 13:33:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 11:33:15 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-0SSqemdYkX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149573|0 |1 is obsolete| | Attachment #149574|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151861&action=edit Bug 33497: Use 'host_items' param to fetch all items at once This patch adjusts the detail page to fetch items and host items together, and prefetches transfers and checkouts To test: 1 - Enable easy analytics 2 - Attach some items to a bib 3 - Checkout an item on the bib 4 - View the details page 5 - Apply patch 6 - View details page, confirm nothing has changed Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 13:33:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 11:33:17 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-SROeWzoGrZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 --- Comment #14 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151862&action=edit Bug 33497: Add a filter relationship for branchtransfers This uses the new relationship from bug 33493 to fetch the transfers for items To test: 1 - Transfer some items on a bib 2 - View the biblio details page in the staff interface 3 - Apply patch 4 - Confirm the view is the same Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 13:33:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 11:33:19 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-kzE4lrvHVa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 --- Comment #15 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151863&action=edit Bug 33497: (follow-up) Remove unecessary scalar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 13:46:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 11:46:29 +0000 Subject: [Koha-bugs] [Bug 33848] Enabling Coce in the OPAC breaks cover images on bibliographic detail page In-Reply-To: <bug-33848-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33848-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33848-70-x36dgkyJwG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 151864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151864&action=edit Bug 33848: Don't remove coce container from template It's removed from coce.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 13:46:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 11:46:48 +0000 Subject: [Koha-bugs] [Bug 33848] Enabling Coce in the OPAC breaks cover images on bibliographic detail page In-Reply-To: <bug-33848-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33848-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33848-70-5aM6JOWleA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I think I've tracked it down, but there are several things that go wrong. First I don't get the error reported in comment 0. However I do see images removed, randomly. I can see 2, 3 or 4. This patch fix the Coce problem, but it is still not working for OpenLibrary. And it is not fixed staff side either. Apparently we reach verify_images before the image is loaded the the code around "KOHA.coce.done" (32307, 28179, 28180) was supposed to prevent that... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 13:49:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 11:49:25 +0000 Subject: [Koha-bugs] [Bug 27462] Number of suggestions includes archived suggestions In-Reply-To: <bug-27462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27462-70-V7ZabfLHZy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27462 Thibault Keromnès <thibault.keromnes at univ-paris8.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibault.keromnes at univ-pari | |s8.fr Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Thibault Keromnès <thibault.keromnes at univ-paris8.fr> --- *** This bug has been marked as a duplicate of bug 30493 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 13:49:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 11:49:25 +0000 Subject: [Koha-bugs] [Bug 30493] Pending archived suggestions appear on intranet home page In-Reply-To: <bug-30493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30493-70-AeLIgyPy3T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 Thibault Keromnès <thibault.keromnes at univ-paris8.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Thibault Keromnès <thibault.keromnes at univ-paris8.fr> --- *** Bug 27462 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 14:01:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 12:01:09 +0000 Subject: [Koha-bugs] [Bug 33868] New: Upgrade the Multiple Select plugin in the staff interface Message-ID: <bug-33868-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33868 Bug ID: 33868 Summary: Upgrade the Multiple Select plugin in the staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The system preferences page uses a jQuery plugin, Multiple Select, for some preferences (OpacAdvSearchMoreOptions, CoceProviders, BatchCheckoutsValidCategories, etc.). We use version 1.1, and the latest version is 1.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 14:03:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 12:03:13 +0000 Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for branchtransfers In-Reply-To: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33493-70-K09p3lnZzh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 14:03:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 12:03:15 +0000 Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for branchtransfers In-Reply-To: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33493-70-RjRjrJe3QH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151865&action=edit Bug 33493: (follow-up) Rename relationship and add test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 14:05:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 12:05:17 +0000 Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for branchtransfers In-Reply-To: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33493-70-3BCsmgqm7I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #6) > __PACKAGE__->has_many( > "branchtransfer", > > This name is confusing. Please do something with current and in plural. > current_branchtransfers ? > branchtransfers_filter_by_current ? Ok, current_branchtransfers > > Please add a test. Ok > Did you have a use case where get_transfer did not return the right transfer? The use case is not fixing an incorrect return, but allowing to prefetch/join easily ad only get relevant data. See bug 33497 for using this as a prefetch on details page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 14:06:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 12:06:56 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-taSnlL8Iod@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 --- Comment #16 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151866&action=edit Bug 33497: (follow-up) Adjust relationship name from bug 33493 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 14:21:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 12:21:48 +0000 Subject: [Koha-bugs] [Bug 33868] Upgrade the Multiple Select plugin in the staff interface In-Reply-To: <bug-33868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33868-70-dZjdxo86fz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33868 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 14:21:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 12:21:51 +0000 Subject: [Koha-bugs] [Bug 33868] Upgrade the Multiple Select plugin in the staff interface In-Reply-To: <bug-33868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33868-70-8eiKQWxkVJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33868 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151867&action=edit Bug 33868: Upgrade the Multiple Select plugin in the staff interface This patch upgrades the Multiple Select plugin in the staff interface and adds some minor adjustments to system preferences CSS to accommodate the change. The listing on the about page is updated with current information. To test, apply the patch and clear your browser cache if necessary. - Go to Administration -> System preferences. - Test some preferences which use the plugin, e.g. - ApplyFrameworkDefaults - CoceProviders - OpacHiddenItemsExceptions - OPACAllowUserToChangeBranch - Confirm that the menus look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 14:50:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 12:50:00 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-IPNpGXOHQj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 14:50:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 12:50:02 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-Ao5VWyUYtI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151672|0 |1 is obsolete| | Attachment #151673|0 |1 is obsolete| | Attachment #151674|0 |1 is obsolete| | --- Comment #20 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151868&action=edit Bug 33404: Z3950SearchAuth: Save in UTF-8 encoding Test plan: [1] If you have access to a Z3950 MARC8 auth server, search for an authority record and import it. [2] If you have access to a Z3950 UTF8 auth server, search for an authority record and import it. Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 14:50:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 12:50:04 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-1JWmc0DKJj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 --- Comment #21 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151869&action=edit Bug 33404: Fix serverhost and init $page The array serverhost is not filled. Should be replaced with values from servers array. Test plan: Nothing exciting here. Read the patch. Note that we will test in the next patch if the hostname is saved correctly in the import batch. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 14:50:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 12:50:07 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33404-70-67Vo11KXJd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 --- Comment #22 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 151870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151870&action=edit Bug 33404: Add unit tests Test plan: Run t/db_dependent/Breeding.t Run t/db_dependent/Breeding_Auth.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 14:51:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 12:51:16 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26597-70-bY72cUNlxp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 --- Comment #28 from Hammat wele <hammat.wele at inlibro.com> --- (In reply to Jonathan Druart from comment #27) > If you are removing the REST API fetch I don't see why you are still passing > and using to_api_mapping. With borrower, I get all the guarantor's data i need but it is not associated with the name of the fields of the form. the to_api_mapping allows me to retrieve the name of the fields to be filled. the data received from borrower is like { ... "altaddress_address": "addressvalue", "altaddress_address2": "address2value", "altaddress_city": "addressCityvalue", "altaddress_country": "addresscontryvalue", "altaddress_email": "email at example.com", ... } to be able to fill the form with these data i need to get the name of the fields to be filled in and the to_api_mapping help me to get it { B_address => 'altaddress_address', } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 14:51:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 12:51:52 +0000 Subject: [Koha-bugs] [Bug 33859] Use the phrase 'Identity providers' instead of 'Authentication providers' In-Reply-To: <bug-33859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33859-70-Ii9ZtIwoQl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33859 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 14:51:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 12:51:54 +0000 Subject: [Koha-bugs] [Bug 33859] Use the phrase 'Identity providers' instead of 'Authentication providers' In-Reply-To: <bug-33859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33859-70-e4hHvk9fqO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33859 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151871&action=edit Bug 33859: Use the phrase 'Identity providers' instead of 'Authentication providers' This patch updates instances in the code and templates where the term "Authentication providers" is used, replacing it with the preferred "Identity provider." Most of the instances of this change are in module or API documentation, but you can see a couple of the changes in the interface: - Administration -> Identity providers: - The sidebar menu should show "Identity providers" instead of "Authentication providers." - Patrons -> Patron details -> More -> Set permissions - Under " Manage Koha system settings (Administration panel)" you should see "Manage identity providers (manage_identity_providers)" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:07:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:07:57 +0000 Subject: [Koha-bugs] [Bug 33869] New: Move Matcher.t to db_dependent Message-ID: <bug-33869-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33869 Bug ID: 33869 Summary: Move Matcher.t to db_dependent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Not much work to replace T::D::C here by a few TestBuilder records in marc_matchers table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:09:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:09:20 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_33851=5D_Punctuation=3A_Notes?= =?utf-8?b?4pCgOiAlcw==?= In-Reply-To: <bug-33851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33851-70-AmwGswYz7T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33851 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- *** This bug has been marked as a duplicate of bug 33797 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:09:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:09:20 +0000 Subject: [Koha-bugs] [Bug 33797] Extra space in supplier.tt In-Reply-To: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33797-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33797-70-oGOG4G2hJN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33797 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- *** Bug 33851 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:10:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:10:07 +0000 Subject: [Koha-bugs] [Bug 33869] Move Matcher.t to db_dependent In-Reply-To: <bug-33869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33869-70-LRlf6REtkD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33869 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:10:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:10:09 +0000 Subject: [Koha-bugs] [Bug 33869] Move Matcher.t to db_dependent In-Reply-To: <bug-33869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33869-70-iXk5BIKnCE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33869 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151872&action=edit Bug 33869: Matcher.t - use TestBuilder Remove T::D::C Test plan: Run t/Matcher.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:10:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:10:11 +0000 Subject: [Koha-bugs] [Bug 33869] Move Matcher.t to db_dependent In-Reply-To: <bug-33869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33869-70-Elr35yPR0U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33869 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151873&action=edit Bug 33869: Matcher.t - indentation and whitespace changes Test plan: Run git diff --ignore-all-space --ignore-blank-lines HEAD~1.. t/Matcher.t; #no output expected Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:10:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:10:13 +0000 Subject: [Koha-bugs] [Bug 33869] Move Matcher.t to db_dependent In-Reply-To: <bug-33869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33869-70-487HUyOw6o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33869 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151874&action=edit Bug 33869: Move Matcher.t to t/db_dependent Test plan: Run t/db_dependent/Matcher.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:12:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:12:10 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26597-70-7ALFbYXts2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151851|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:12:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:12:28 +0000 Subject: [Koha-bugs] [Bug 33869] Move Matcher.t to db_dependent In-Reply-To: <bug-33869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33869-70-EMuvha3M7W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33869 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:14:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:14:27 +0000 Subject: [Koha-bugs] [Bug 33870] New: Remove T::D::C from Sitemapper.t Message-ID: <bug-33870-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 Bug ID: 33870 Summary: Remove T::D::C from Sitemapper.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Not that hard. And a follow-up adds a filtering parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:15:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:15:31 +0000 Subject: [Koha-bugs] [Bug 33871] New: Add where parameter to sitemap.pl Message-ID: <bug-33871-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33871 Bug ID: 33871 Summary: Add where parameter to sitemap.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Follow-up on 33870 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:15:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:15:42 +0000 Subject: [Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t In-Reply-To: <bug-33870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33870-70-YHLZQMCoNe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:18:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:18:13 +0000 Subject: [Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t In-Reply-To: <bug-33870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33870-70-XyM1XW2wE7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:18:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:18:15 +0000 Subject: [Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t In-Reply-To: <bug-33870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33870-70-hsTObfcGZj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151875&action=edit Bug 33870: Make $MAX in Sitemapper::Writer global This should preferably not be a lexical variable (in case we ever should call this under Plack). A global variable will also simplify testing (see next patch). Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:18:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:18:17 +0000 Subject: [Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t In-Reply-To: <bug-33870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33870-70-6YoFaO0E3j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151876&action=edit Bug 33870: Polishing Sitemapper.t Create subtest. Remove (useless) mock on DateTime. Remove T::D::C module, add TestBuilder. Replace local slurp function by use File::Slurp. Test plan: Run t/db_dependent/Sitemapper.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:18:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:18:19 +0000 Subject: [Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t In-Reply-To: <bug-33870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33870-70-KniDfRXy00@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151877&action=edit Bug 33870: Fix indentation in subtest Test plan: git diff -w HEAD~1.. t/db_dependent/Sitemapper.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:19:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:19:25 +0000 Subject: [Koha-bugs] [Bug 33871] Add where parameter to sitemap.pl In-Reply-To: <bug-33871-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33871-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33871-70-lzQO7vlujj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33871 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:19:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:19:33 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26597-70-tn6KsRYSFc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 --- Comment #29 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 151878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151878&action=edit Bug 26597: (QA follow-up) Add missing filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:20:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:20:44 +0000 Subject: [Koha-bugs] [Bug 33871] Add where parameter to sitemap.pl In-Reply-To: <bug-33871-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33871-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33871-70-m73ponfGC5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33871 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:20:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:20:46 +0000 Subject: [Koha-bugs] [Bug 33871] Add where parameter to sitemap.pl In-Reply-To: <bug-33871-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33871-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33871-70-7FDnBB9932@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33871 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151879&action=edit Bug 33871: Use Koha object in Sitemapper, add optional filter Test plan: Run misc/cronjobs/sitemap.pl -where "biblionumber>X" (replace X by some clever value) Verify results by browsing sitemap files. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:20:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:20:48 +0000 Subject: [Koha-bugs] [Bug 33871] Add where parameter to sitemap.pl In-Reply-To: <bug-33871-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33871-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33871-70-z0PcwMCntx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33871 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151880&action=edit Bug 33871: Test where parameter in Sitemapper.t This makes it possible to remove the ugly global deletes at the start. Test plan: Run t/db_dependent/Sitemapper.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:37:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:37:16 +0000 Subject: [Koha-bugs] [Bug 33871] Add where parameter to sitemap.pl In-Reply-To: <bug-33871-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33871-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33871-70-s8NLPLl6dO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33871 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 [Bug 33870] Remove T::D::C from Sitemapper.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:37:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:37:16 +0000 Subject: [Koha-bugs] [Bug 33870] Remove T::D::C from Sitemapper.t In-Reply-To: <bug-33870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33870-70-uNxysoQrxc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33871 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33871 [Bug 33871] Add where parameter to sitemap.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:42:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:42:32 +0000 Subject: [Koha-bugs] [Bug 33872] New: Duplicated patron's registration date is set to expiration date of template patron Message-ID: <bug-33872-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33872 Bug ID: 33872 Summary: Duplicated patron's registration date is set to expiration date of template patron Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: catrina at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When duplicating a patron, the duplicated patron’s registration date automatically populates with the expiration date of the patron being duplicated. So, the registration date for the new patron is the expiration date of the original patron. This appears to be new behavior in 22.11 - I cannot replicate on 22.05. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:54:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:54:14 +0000 Subject: [Koha-bugs] [Bug 33720] koha-upgrade-schema should restart memcached In-Reply-To: <bug-33720-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33720-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33720-70-LdZzu4hS5q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33720 --- Comment #4 from Jake Deery <jake.deery at ptfs-europe.com> --- Hi Jonathan, A fine point, well-raised. Flushing the cache from within updatedatabase.pl covers a wider range of install types, too. I've attached another patch, this time for updatedatabase.pl. To test (assuming the software version is 22.1106000, please amend to suit): 1. Set database to a historic version near to your own – SQL: UPDATE systempreferences SET value='22.1105012' WHERE variable='Version'; 2. Run sudo koha-upgrade-schema test (or updatedatabase.pl, if you use dev installs) – notice how nothing happens 3. Apply patch 4. Rerun sudo koha-upgrade-schema test (or updatedatabase.pl, if you use dev installs) – notice how the upgrade proceeds from correct point (even if it fails due to duplicate tables / columns / keys) 5. Repeat steps 1 & 4 to validate Many thanks, Jake -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:55:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:55:06 +0000 Subject: [Koha-bugs] [Bug 33720] koha-upgrade-schema should restart memcached In-Reply-To: <bug-33720-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33720-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33720-70-Dy4iqoCzun@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33720 Jake Deery <jake.deery at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151083|0 |1 is obsolete| | --- Comment #5 from Jake Deery <jake.deery at ptfs-europe.com> --- Created attachment 151881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151881&action=edit Update the updatedatabase.pl script to flush caches before running -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 31 15:59:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 13:59:16 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: <bug-27153-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27153-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27153-70-Zklzyt1uAC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 Dani Elder <danielle.elder at law.utexas.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle.elder at law.utexas.e | |du -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:09:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 14:09:45 +0000 Subject: [Koha-bugs] [Bug 33873] New: ILL requests with linked biblio_id that no longer exists causes table to not render Message-ID: <bug-33873-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33873 Bug ID: 33873 Summary: ILL requests with linked biblio_id that no longer exists causes table to not render Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, katrin.fischer at bsz-bw.de, nick at bywatersolutions.com, pedro.amorim at ptfs-europe.com, tomascohen at gmail.com Depends on: 22440 We stumbled upon this on one of our upgrades. This is what I think happened: Because bug 22440 is also the one introducing cascade delete on biblio_id in illrequests table, in the past, when a biblio was deleted its id still remained in the biblio_id column of illrequests. This causes the API embed to respond with a biblio_id for the ILL request, but a null biblio (because it wasn't able to retrieve it, it doesn't exist). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 [Bug 22440] Improve ILL page performance by moving to server side filtering -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:09:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 14:09:45 +0000 Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to server side filtering In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-p9UVQLUfUF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33873 [Bug 33873] ILL requests with linked biblio_id that no longer exists causes table to not render -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:11:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 14:11:24 +0000 Subject: [Koha-bugs] [Bug 33873] ILL requests with linked biblio_id that no longer exists causes table to not render In-Reply-To: <bug-33873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33873-70-0MqjodG0qh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33873 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:11:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 14:11:27 +0000 Subject: [Koha-bugs] [Bug 33873] ILL requests with linked biblio_id that no longer exists causes table to not render In-Reply-To: <bug-33873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33873-70-vIocIqjpcD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33873 --- Comment #1 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 151882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151882&action=edit Bug 33873: Improve check for inexistant biblio object -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:14:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 14:14:17 +0000 Subject: [Koha-bugs] [Bug 33873] ILL requests with linked biblio_id that no longer exists causes table to not render In-Reply-To: <bug-33873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33873-70-dx2ea8uC7z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33873 --- Comment #2 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- This change will now not only check for undefined, but also null - which is what is happening (and other falsy conditions of course). This may be considered critical, because as it stands, there is a high chance systems upgrading to a version with bug 22440 will have their ILL table potentially not functional. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:27:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 14:27:48 +0000 Subject: [Koha-bugs] [Bug 33873] ILL requests with linked biblio_id that no longer exists causes table to not render In-Reply-To: <bug-33873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33873-70-dOclp3jm3B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33873 --- Comment #3 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- I wonder if a test can/should be written for this? If so, test what? That a request is being returned with a biblio_id but an empty biblio in case the biblionumber does not exist? Should we provide an atomic update file? To clean-up data retroactively? i.e. update illrequests set biblio_id = NULL where biblio_id not in (select biblionumber from biblio); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:29:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 14:29:41 +0000 Subject: [Koha-bugs] [Bug 33873] ILL requests with linked biblio_id that no longer exists causes table to not render In-Reply-To: <bug-33873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33873-70-2fQTiCureC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33873 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Pedro, just to clarify: Are we deleting the biblio_id from illrequests or not? I am a little confused by the first comment. We'd like to keep it for sure, we can still look-up details in deletedbiblio. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:39:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 14:39:09 +0000 Subject: [Koha-bugs] [Bug 33698] Add fields to verbose output of cronjob delete_items.pl In-Reply-To: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33698-70-JjZ1AwsZ31@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33698 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:39:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 14:39:11 +0000 Subject: [Koha-bugs] [Bug 33698] Add fields to verbose output of cronjob delete_items.pl In-Reply-To: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33698-70-r9ZI6qFXS0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33698 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151849|0 |1 is obsolete| | --- Comment #8 from Sam Lau <samalau at gmail.com> --- Created attachment 151883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151883&action=edit Bug 33698: Add fields to the verbose output that show the barcode and title of items that cannot be deleted Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:48:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 14:48:50 +0000 Subject: [Koha-bugs] [Bug 33873] ILL requests with linked biblio_id that no longer exists causes table to not render In-Reply-To: <bug-33873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33873-70-suPX8ANN9X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33873 --- Comment #5 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- I believe this patch: https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22440&attachment=150716 Makes it so that if a biblio that is related to an ILL request is deleted, the ILL request biblio_id column is set to NULL Previous to bug 22440, apparently this wasn't the case, and in such an event, the biblionumber would remain in the biblio_id illrequests column, even after the biblio with said biblionumber is deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:59:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 14:59:31 +0000 Subject: [Koha-bugs] [Bug 32695] Search string for 775 'Other editions' is incorrectly formed In-Reply-To: <bug-32695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32695-70-XyFGlQxapt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32695 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 16:59:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 14:59:33 +0000 Subject: [Koha-bugs] [Bug 32695] Search string for 775 'Other editions' is incorrectly formed In-Reply-To: <bug-32695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32695-70-NbaTFqW70S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32695 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151860|0 |1 is obsolete| | --- Comment #4 from Sam Lau <samalau at gmail.com> --- Created attachment 151884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151884&action=edit Bug 32695: Use title (subfield t) only for 'Other editions' search links Currently the code does a title phrase search, but combines the title field with the Main Entry (author) field. This patch simply limits the search to the title to ensure links work To test: 1 - Ensure systme preference 'UseControlNumber' is set to don't 2 - Edit Default MARC framework in administration->Marc frameworks 3 - Make 775 subfields a & t visible in editor 4 - Edit a record to add a field 775 with subfields a & t that match another title/author in your system 5 - Save the record and view the details page 6 - Click the other editions link - no results 7 - Apply patch, restart_all 8 - Reload details and confirm the link works Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 17:04:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 15:04:21 +0000 Subject: [Koha-bugs] [Bug 21548] Make ILL patron category in koha-conf.xml match with ILL patron category in sample data In-Reply-To: <bug-21548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21548-70-Tut93rSts6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Aude Charillon <aude.charillon at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/695 Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #14 from Aude Charillon <aude.charillon at ptfs-europe.com> --- 23.05 Manual updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 17:04:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 15:04:21 +0000 Subject: [Koha-bugs] [Bug 19822] Add system preferences for ILL Module In-Reply-To: <bug-19822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19822-70-8NLJo68w2G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Bug 19822 depends on bug 21548, which changed state. Bug 21548 Summary: Make ILL patron category in koha-conf.xml match with ILL patron category in sample data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 17:04:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 15:04:22 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-mg8yqDVz6T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Bug 32911 depends on bug 21548, which changed state. Bug 21548 Summary: Make ILL patron category in koha-conf.xml match with ILL patron category in sample data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 17:19:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 15:19:01 +0000 Subject: [Koha-bugs] [Bug 33522] Optionally skip inactive patrons when sending membership expiry notices In-Reply-To: <bug-33522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33522-70-JbM3PxKSSU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 17:19:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 15:19:03 +0000 Subject: [Koha-bugs] [Bug 33522] Optionally skip inactive patrons when sending membership expiry notices In-Reply-To: <bug-33522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33522-70-m44DpsAPFZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 151885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151885&action=edit Bug 33522: Add active and inactive parameter to membership_expiry.pl Test plan: Enable TrackLastPatronActivity. Set MembershipExpiryDaysNotice to X days. Pick a patron, make it expire in X days. Add email address. Update borrowers.lastseen for this patron to make it active. Run membership_expiry.pl -c -v -active You should see at least one enqueued notice. Note: Since we passed no number, we default to 6 months. Run membership_expiry.pl -c -v -inactive You should see that it skipped a number of active patrons (>=1). Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 17:20:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 15:20:19 +0000 Subject: [Koha-bugs] [Bug 33522] Optionally skip (in)active patrons when sending membership expiry notices In-Reply-To: <bug-33522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33522-70-fteISZPSt6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Optionally skip inactive |Optionally skip (in)active |patrons when sending |patrons when sending |membership expiry notices |membership expiry notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 17:24:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 15:24:21 +0000 Subject: [Koha-bugs] [Bug 33859] Use the phrase 'Identity providers' instead of 'Authentication providers' In-Reply-To: <bug-33859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33859-70-mJxgkrnoE8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33859 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 17:24:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 15:24:23 +0000 Subject: [Koha-bugs] [Bug 33859] Use the phrase 'Identity providers' instead of 'Authentication providers' In-Reply-To: <bug-33859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33859-70-liFYVJQVmg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33859 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151871|0 |1 is obsolete| | --- Comment #4 from Sam Lau <samalau at gmail.com> --- Created attachment 151886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151886&action=edit Bug 33859: Use the phrase 'Identity providers' instead of 'Authentication providers' This patch updates instances in the code and templates where the term "Authentication providers" is used, replacing it with the preferred "Identity provider." Most of the instances of this change are in module or API documentation, but you can see a couple of the changes in the interface: - Administration -> Identity providers: - The sidebar menu should show "Identity providers" instead of "Authentication providers." - Patrons -> Patron details -> More -> Set permissions - Under " Manage Koha system settings (Administration panel)" you should see "Manage identity providers (manage_identity_providers)" Signed-off-by: Sam Lau <samalau at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 17:47:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 15:47:34 +0000 Subject: [Koha-bugs] [Bug 33528] Use template wrapper for tabs: Patron details and circulation In-Reply-To: <bug-33528-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33528-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33528-70-jBGffuR1eS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151313|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 151887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151887&action=edit Bug 33528: Use template wrapper for tabs: Patron details page This patch updates the checkout and patron details templates so that they use the new WRAPPER directive to build tabbed navigation. The markup for the tab navigation and tab panels is moved into its own include file since the templates were duplicating essentially the same code. To fully test you should have patrons with checkouts, fines, holds, recalls, and article requests. Apply the patch and go to the checkout page in the staff interface. With each tab, test as much functionality as you can within that tab. - Checkouts - Holds - Recalls (with UseRecalls enabled) - Claims (with a LOST value defined in ClaimReturnedLostValue) - Restrictions - Article Requests (with ArticleRequests preference enabled) - Clubs (with at least one club defined) - Relatives' checkouts (patron must have a guarantee linked to their account). Perform the same tests on the patron details page. Note that the "Charges" tab is shown on the patron details page but not the checkout page. This is not a change made by this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 18:16:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 16:16:13 +0000 Subject: [Koha-bugs] [Bug 33874] New: ILL Table - Pressing a column header to sort causes left-side filter values to be applied Message-ID: <bug-33874-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33874 Bug ID: 33874 Summary: ILL Table - Pressing a column header to sort causes left-side filter values to be applied Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, katrin.fischer at bsz-bw.de, martin.renvoize at ptfs-europe.com, nick at bywatersolutions.com, pedro.amorim at ptfs-europe.com, tomascohen at gmail.com Depends on: 22440 To reproduce: * Run sh start-ill-dev.sh (copy from https://github.com/ammopt/koha-ill-dev/blob/master/start-ill-dev.sh) * Create 1 request in some library * Go back to the table, pick a different library from the left-side filters but dont press the 'Search' button * Click on any column header to sort, notice the requests disappears (because the library filter value is being applied) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 [Bug 22440] Improve ILL page performance by moving to server side filtering -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 31 18:16:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 16:16:13 +0000 Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to server side filtering In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-DOFLLdV4aL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33874 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33874 [Bug 33874] ILL Table - Pressing a column header to sort causes left-side filter values to be applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 20:04:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 18:04:55 +0000 Subject: [Koha-bugs] [Bug 8331] Hidden field does not hide from plain MARC and normal views in staff In-Reply-To: <bug-8331-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8331-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8331-70-asCE37JDXM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8331 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com --- Comment #10 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Commenting to put this back on everyone's radar. We are still running into this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 20:27:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 18:27:43 +0000 Subject: [Koha-bugs] [Bug 33528] Use template wrapper for tabs: Patron details and circulation In-Reply-To: <bug-33528-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33528-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33528-70-gJc9PYSSaw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528 Sam Lau <samalau at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau at gmail.com Status|Needs Signoff |Failed QA --- Comment #5 from Sam Lau <samalau at gmail.com> --- I ran into some problems testing the club tab in both the check out page and the details page. The club shows up fine, however after clicking the enroll button, the "finish enrollment" button appears on the screen visually plain text rather than a button. And after clicking on the "finish enrollment" text, the club tab essentially disappears but all of the information from the tab is left on the screen. From here if you try to click on another tab, the formatting really gets messed up and the table turns green for some reason. Refreshing the page did put the club tab back in the correct spot and also fixed the formatting, but if you try to cancel your enrollment in the club, a pop up appears that says: "Something went wrong when loading the table." After closing the popup, the formatting of the club tab gets messed up again, with the same problems as described before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 21:36:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 19:36:38 +0000 Subject: [Koha-bugs] [Bug 33873] ILL requests with linked biblio_id that no longer exists causes table to not render In-Reply-To: <bug-33873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33873-70-OTWOuAAuDg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33873 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Pedro Amorim from comment #5) > I believe this patch: > https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter. > html&bug=22440&attachment=150716 > > Makes it so that if a biblio that is related to an ILL request is deleted, > the ILL request biblio_id column is set to NULL > Previous to bug 22440, apparently this wasn't the case, and in such an > event, the biblionumber would remain in the biblio_id illrequests column, > even after the biblio with said biblionumber is deleted. You are right, but I really wish they hadn't hidden this (breaking) change in a patch that seems totally unrelated to it :( It can and will create data loss for some libraries depending on how their backends work. And it's not advertised in release notes. Our backend cleans up the records automatically when a ILL request is filled, but we relied on having the link still to be able to pull the information. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 21:50:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 19:50:48 +0000 Subject: [Koha-bugs] [Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key In-Reply-To: <bug-21983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21983-70-xml6PpXZdh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 [Bug 22440] Improve ILL page performance by moving to server side filtering -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 21:50:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 19:50:48 +0000 Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to server side filtering In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-MROym53qIV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 [Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 21:51:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 19:51:31 +0000 Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to server side filtering In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-fmnOfs5o1g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, I am not so happy about the FK change hidden/sneaked in with this bug. Especially since it's now without documentation/warning to users and can create data loss. If you don't store all information also in ILL request attributes it will be hard to determine what has been ordered for making acq decisions and creating reports. Also: there already was as specific bug for this change, stuck in discussion for these reasons: bug 21983 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 22:48:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 20:48:17 +0000 Subject: [Koha-bugs] [Bug 33875] New: Missing closing tag a in API key management page Message-ID: <bug-33875-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 Bug ID: 33875 Summary: Missing closing tag a in API key management page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In API key management page, anchor closing tag is missing in : <div class="dialog message">No keys defined for the current patron. <a href="#" class="toggle_element" data-element="#add-api-key" id="show-api-form"><i class="fa fa-plus"></i> Generate a new client id/secret pair</div> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 22:48:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 20:48:23 +0000 Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page In-Reply-To: <bug-33875-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33875-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33875-70-fc7yzZRyz5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 [Bug 20568] Add API key management interface for patrons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 31 22:48:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 20:48:23 +0000 Subject: [Koha-bugs] [Bug 20568] Add API key management interface for patrons In-Reply-To: <bug-20568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20568-70-8Q17dYvFAo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33875 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 [Bug 33875] Missing closing tag a in API key management page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 22:50:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 20:50:45 +0000 Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page In-Reply-To: <bug-33875-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33875-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33875-70-ZYA9l1grVJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 31 23:04:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 21:04:02 +0000 Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page In-Reply-To: <bug-33875-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33875-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33875-70-dFQOqXxnq8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 23:04:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 21:04:04 +0000 Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page In-Reply-To: <bug-33875-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33875-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33875-70-3iKeoWqtTc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- Created attachment 151888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151888&action=edit Bug 33875: Fix missing closing tag a in API key management page In API key management page, anchor closing tag is missing in message "No keys defined for the current patron". This patch fixes that. Also changes display with link on a new line. Translatable text is on purpose surrounded by span or div. Test plan : 1) Enable system preference RESTOAuth2ClientCredentials 2) Go to a patron page 3) Click More > Manage API Keys 4) Look at page source HTML code => Check code is OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 23:05:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 21:05:57 +0000 Subject: [Koha-bugs] [Bug 33875] Missing closing tag a in API key management page In-Reply-To: <bug-33875-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33875-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33875-70-Fhyaxv3On8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 --- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> --- Created attachment 151889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151889&action=edit Screenshot with patch I choose to propose a minor change in display to move link on a new line. This looks better I think. Also each translatable text is surrounded by span or div to ease translation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 31 23:39:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2023 21:39:41 +0000 Subject: [Koha-bugs] [Bug 33725] Add item's collection code to search results location column in staff interface In-Reply-To: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33725-70-UnRmuYv8Cl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33725 --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 151890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151890&action=edit Bug 33725: (follow-up) Add ccode to grouping logic -- You are receiving this mail because: You are watching all bug changes.