From bugzilla-daemon at bugs.koha-community.org Mon May 1 00:21:50 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Apr 2023 22:21:50 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
more granular level
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #148544|0 |1
is obsolete| |
--- Comment #237 from Aleisha Amohia ---
Created attachment 150437
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150437&action=edit
Bug 8376: (QA follow-up) Update message on Hold waiting pickup report
Signed-off-by: Nick Clemens
https://bugs.koha-community.org/show_bug.cgi?id=8367
Signed-off-by: Kelly
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 00:21:57 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Apr 2023 22:21:57 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
more granular level
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #148545|0 |1
is obsolete| |
--- Comment #238 from Aleisha Amohia ---
Created attachment 150438
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150438&action=edit
Bug 8367: (QA follow-up) Improve display when value not set for rule
When a rule is not set for a speficic line, the value in the syspref
will be used. This should be made clear in the interface.
To test:
1 - Add a new rule for a specific item type
2 - Do not fill the 'Hold pickup period'
3 - Confirm that the rule defaults to the system preference
4 - Hover on 'Default' in the circ rules under 'Hold pickup period'
5 - Confirm the text is readable
Signed-off-by: Nick Clemens
Signed-off-by: Kelly
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 00:22:03 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Apr 2023 22:22:03 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
more granular level
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #239 from Aleisha Amohia ---
Created attachment 150439
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150439&action=edit
Bug 8367: Add holds_pickup_period fallback circulation rule
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 00:23:27 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Apr 2023 22:23:27 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
more granular level
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #240 from Aleisha Amohia ---
(In reply to Katrin Fischer from comment #236)
> (In reply to Nick Clemens from comment #235)
> > (In reply to Aleisha Amohia from comment #234)
> > > There are lots of signoffs on these patches, can this be marked Passed QA?
> >
> > Hi Aleisha,
> >
> > It appears I was wrong in comment 187, see comment 222
> >
> > It is a question of how the fallback should work, so we either need a DB
> > update, or to change the expectation for when a rule is not set
>
> It sounds like this needs a little bit more work?
Attached an atomic update patch, not sure how it affects the bug status.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 00:33:04 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Apr 2023 22:33:04 +0000
Subject: [Koha-bugs] [Bug 33348] Show authority heading use with
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 00:33:07 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Apr 2023 22:33:07 +0000
Subject: [Koha-bugs] [Bug 33348] Show authority heading use with
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #148791|0 |1
is obsolete| |
--- Comment #2 from Aleisha Amohia ---
Created attachment 150440
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150440&action=edit
Bug 33348: Show authority heading use with Elasticsearch
This patch ensures the ShowHeadingUse system preference and feature works as
expected when using Elasticsearch as the searchengine.
To test, follow the test plan at Bug 29990 Comment 9. Ensure the SearchEngine
system preference is set to Elasticsearch.
Sponsored-by: Education Services Australia SCIS
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 01:34:49 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Apr 2023 23:34:49 +0000
Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and
staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428
--- Comment #13 from David Cook ---
(In reply to Katrin Fischer from comment #12)
> You are right that different subdomains will create separate sessions, but I
> think the 99% is wrong. Koha used ports for a long time in its default setup
> and there are still reasons why you would want to do so. We do, with
> packages, use ports, for the installations we support.
>
> And it doesn't solve the problem here... different sessions, one timeout.
> How could you attach a different timeout to each?
For your case, I think you'd need different cookie names for OPAC and Staff.
Mostly would involve refactoring...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 02:21:55 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 00:21:55 +0000
Subject: [Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150430|0 |1
is obsolete| |
--- Comment #22 from David Nind ---
Created attachment 150441
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150441&action=edit
Bug 23781: SMS notices and messaging preferences for recalls
This patch adds recalls notices (pick up a waiting recall or return a
requested recall) to the messaging preferences.
To test:
1) Apply Bug 19532
2) Apply this bug
3) Update database, rebuild dbix files
4) Ensure UseRecalls syspref is enabled and values have been set in the
circulation rules for recalls
5) Go to a borrower (Person A) account page in the Intranet or the OPAC
6) Go to messaging preferences
7) Notice there are now preferences for two recalls notices
8) Select email as a preference
9) Find a different borrower (Person B) and set their messaging
preferences to SMS
10) Check out any item to Person B
11) Go to the OPAC logged in as Person A and find that item
12) Recall the item
13) In the terminal, look at the message_queue in the database. There
should be a 'RETURN_RECALLED_ITEM' recall notice sent to Person B via SMS
14) Go back to the Intranet and check in the item. Confirm the recall
when checking in
15) Look at the message_queue in the database again. There should be a
'PICKUP_RECALLED_ITEM' recall notice sent to Person A via email.
16) Confirm tests pass
t/db_dependent/Koha/Recall.t
t/db_dependent/Koha/Recalls.t
Sponsored-by: Toi Ohomai Institute of Technology
Signed-off-by: Lucas Gass
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 05:00:48 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 03:00:48 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
opening and closing hours
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 05:00:52 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 03:00:52 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
opening and closing hours
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #146988|0 |1
is obsolete| |
Attachment #146992|0 |1
is obsolete| |
--- Comment #28 from Aleisha Amohia ---
Created attachment 150442
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150442&action=edit
Bug 6796: Add branch_hours table and set opening hours for library
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 05:00:55 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 03:00:55 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
opening and closing hours
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #146989|0 |1
is obsolete| |
--- Comment #29 from Aleisha Amohia ---
Created attachment 150443
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150443&action=edit
Bug 6796: ConsiderLibraryHoursWhenIssuing system preference
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 05:00:59 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 03:00:59 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
opening and closing hours
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #146990|0 |1
is obsolete| |
--- Comment #30 from Aleisha Amohia ---
Created attachment 150444
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150444&action=edit
Bug 6796: Consider library hours when calculating due date + tests
This feature adds the ability to set opening and closing hours for your
library and for these hours to be considered when calculating due dates
for hourly loans. If the due date for an hourly loan falls after the
library closes, the library can choose for the due date to be shortened
to meet the close time, or extended to meet the open time the next day.
This feature adds a new table 'branch_hours' for storing the open and
close times per day for each library, and a new system preference
'ConsiderLibraryHoursWhenIssuing' to choose which behaviour should be
followed when calculating due dates.
To test:
1. Apply patches and update database. Upgrade schema if not applying
patch with schema changes. Restart services.
2. Go to Administration -> Libraries. Edit a library and scroll to the
bottom to find the 'opening hours' section. Test adding and removing
open and close times on various days. Confirm saving works as expected.
3. Add a new library and test adding open and close times works as
expected.
4. Edit your default library and save open and close times for each day.
5. Go to Administration -> Circulation and fine rules. Edit a rule, set
the unit to 'hours' and set the loan period to a number that would cause
a checkout to be due after the close time you just set, i.e. if you set
your close time to be 5pm and your system time is currently 1pm, set the
loan period to be 5 (5 hours) so the calculated due date would be 6pm.
6. Go to Administration -> system preferences. Search for
ConsiderLibraryHoursWhenIssuing. It should be under 'Checkout policy' in
the Circulation system preferences. Confirm the pre-selected option is
'ignore'. Keep this tab open.
6. In a new tab, get the barcode for an item that has an itemtype
matching the circulation rule you just set.
7. Go to the checkouts for a patron that has a categorycode matching the
circulation rule you just set.
8. Check out your item. Confirm that the checkout is due at the end of
the loan period, not taking closing hours into consideration. Return the
item.
9. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to
'close', so the due date should be shortened to meet the close time.
10. Check out your item. Confirm the checkout is due when the library
closes. Return the item.
11. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to
'open', so the due date should be extended to meet the opening time.
12. Check out your item. Confirm the checkout is due the next day when
the library opens.
13. Confirm tests pass t/db_dependent/Circulation/CalcDateDue.t
Sponsored-by: Catalyst IT
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 05:01:02 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 03:01:02 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
opening and closing hours
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #146991|0 |1
is obsolete| |
--- Comment #31 from Aleisha Amohia ---
Created attachment 150445
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150445&action=edit
Bug 6796: (follow-up) Fix logic for calculating following day's open hours
Since days for branch hours are stored as 0-6 in the database, when it's
a Saturday (6) incrementing the date leads to an error when issuing an
hourly loan because no opening hours are found for the non-existent day
(7).
This patch fixes this by calculating the tomorrow day and setting it to
0 if it's greater than 6.
This patch also corrects the mappings for days, where local_day_of_week
caluclates the date with Sunday first, which put it out of sync with the
database opening hours days.
Sponsored-by: Auckland University of Technology
Sponsored-by: Catalyst IT
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 05:01:06 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 03:01:06 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
opening and closing hours
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
--- Comment #32 from Aleisha Amohia ---
Created attachment 150446
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150446&action=edit
Bug 6796: Updated schema files
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 05:01:09 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 03:01:09 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
opening and closing hours
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
--- Comment #33 from Aleisha Amohia ---
Created attachment 150447
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150447&action=edit
Bug 6796: Fix atomic updates
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 05:01:13 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 03:01:13 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
opening and closing hours
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
--- Comment #34 from Aleisha Amohia ---
Created attachment 150448
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150448&action=edit
Bug 6796: Fix saving of libraries and tests
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 06:57:46 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 04:57:46 +0000
Subject: [Koha-bugs] [Bug 24400] REST API: Checkout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24400
--- Comment #1 from Danyon Sewell ---
Created attachment 150449
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150449&action=edit
Bug 24400: Rest API for checkout WIP
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 06:58:36 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 04:58:36 +0000
Subject: [Koha-bugs] [Bug 24400] REST API: Checkout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24400
Danyon Sewell changed:
What |Removed |Added
----------------------------------------------------------------------------
Change sponsored?|--- |Sponsored
CC| |danyonsewell at catalyst.net.n
| |z
Assignee|koha-bugs at lists.koha-commun |danyonsewell at catalyst.net.n
|ity.org |z
Status|NEW |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 08:56:00 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 06:56:00 +0000
Subject: [Koha-bugs] [Bug 33597] Get rid of few SameSite warnings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597
--- Comment #10 from Marcel de Rooy ---
(In reply to Nick Clemens from comment #8)
> Signed-off-by: Nick Clemens
Thx Nick
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 09:03:00 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 07:03:00 +0000
Subject: [Koha-bugs] [Bug 33242] Allow passing things like add_days => 3 to
KohaDates filter
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33242
--- Comment #18 from Marcel de Rooy ---
(In reply to Kyle M Hall from comment #17)
> Signed-off-by: Kyle M Hall
Thx !
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 11:19:23 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 09:19:23 +0000
Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and
staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428
--- Comment #14 from Katrin Fischer ---
(In reply to David Cook from comment #13)
> (In reply to Katrin Fischer from comment #12)
> > You are right that different subdomains will create separate sessions, but I
> > think the 99% is wrong. Koha used ports for a long time in its default setup
> > and there are still reasons why you would want to do so. We do, with
> > packages, use ports, for the installations we support.
> >
> > And it doesn't solve the problem here... different sessions, one timeout.
> > How could you attach a different timeout to each?
>
> For your case, I think you'd need different cookie names for OPAC and Staff.
> Mostly would involve refactoring...
Not only for our use case - currently it's not possible to set different
timeouts even if you are using different sub domains which divides the
sessions.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 12:21:05 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 10:21:05 +0000
Subject: [Koha-bugs] [Bug 33363] More specific permissions for purchase
suggestions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33363
PTFS Europe Sandboxes changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150247|0 |1
is obsolete| |
--- Comment #3 from PTFS Europe Sandboxes ---
Created attachment 150450
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150450&action=edit
Bug 33363: Add separate permissions for creating and deleting suggestions
There are a number of libraries that would like for their staff to be able to
submit (and view existing) purchase suggestions from the borrower record, but
not give the staff the ability to edit/manage/delete purchase suggestions.
Test Plan:
1) Apply this patch
2) Run restart all the things!
3) Run updatedatabase
4) Verify anyone with the suggestions manage permissions now has the create and
delete permissions as well
5) Verify anyone without the suggestions manage permission has not recieved the
new permissions
6) Enable only the create permission for a librarian
7) Verify that librarian can only create new suggestions ( not manage or delete
)
8) Enable only the manage permission for a librarian
9) Verify that librarian can only manage existing suggestions ( not create or
delete )
10) Enable only the delete permission for a librarian
11) Verify that librarian can only delete suggestions ( not create or manage )
Signed-off-by: Michaela Sieber
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 12:21:42 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 10:21:42 +0000
Subject: [Koha-bugs] [Bug 33363] More specific permissions for purchase
suggestions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33363
Michaela Sieber changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |michaela.sieber at kit.edu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 13:12:04 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 11:12:04 +0000
Subject: [Koha-bugs] [Bug 33028] The decimal separator 'comma' and its
consequences on the calculation of fines (crons)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028
--- Comment #22 from Kyle M Hall ---
(In reply to Katrin Fischer from comment #21)
> (In reply to Kyle M Hall from comment #20)
> > Circ rules are not enforcing currency formats either. This might fix things
> > once, but does not keep the issue from coming back.
>
> Hi Kyle, what do you suggest? A format check on the inputs in the circ
> rules? We could use the pattern check we use in other forms. Or did you
> think of something else?
Yes. Ideally we'd enforce the chosen format using javascript on the frontend,
and in perl on the backend. Since the js should enforce it on the frontend, the
backend could just die or throw an exception if it sees a violation.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 13:47:54 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 11:47:54 +0000
Subject: [Koha-bugs] [Bug 33028] The decimal separator 'comma' and its
consequences on the calculation of fines (crons)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |major
--- Comment #23 from Katrin Fischer ---
We had multiple reports of fines not working in 22.11 on the mailing lists and
on bugzilla - I'd like to move this forward in some way since I am pretty sure
that this one is to blame from the logs we saw complaining about invalid
values.
I am upping severity for now. This is definitely not an enhancement.
The problem is, that when you edit an existing rule, you might create
problematic values without noticing.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 13:50:19 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 11:50:19 +0000
Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in
items mandatory by default
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419
--- Comment #10 from Laura Escamilla ---
(In reply to Katrin Fischer from comment #9)
> Hi Laura, I'd love to see this in 23.05 - please let me know if you need any
> help or won't have time to continue. We can figure something out.
Hi Katrin! I was out recently for parental leave, I will get back to working on
this asap!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:11:12 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 12:11:12 +0000
Subject: [Koha-bugs] [Bug 31187] Regression,
Permanent shelving location is always updated when editing location
VIA BATCH ITEM MOD if both are mapped to MARC fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |regression
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:19:44 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 12:19:44 +0000
Subject: [Koha-bugs] [Bug 33240] After the latest update koha is not
calculating the fine. Previously it was calculating.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33240
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
Status|NEW |RESOLVED
--- Comment #1 from Katrin Fischer ---
Check your circulation rules for incorrect values in fine and max fine, see bug
33028.
*** This bug has been marked as a duplicate of bug 33028 ***
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:19:44 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 12:19:44 +0000
Subject: [Koha-bugs] [Bug 33028] The decimal separator 'comma' and its
consequences on the calculation of fines (crons)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dhanestraj at gmail.com
--- Comment #24 from Katrin Fischer ---
*** Bug 33240 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:27:27 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 12:27:27 +0000
Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for
renewals
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:31:27 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 12:31:27 +0000
Subject: [Koha-bugs] [Bug 33640] Adding new item group from item additem.pl
does nothing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33640
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |24857
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
[Bug 24857] Add ability to group items for records
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:31:27 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 12:31:27 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33640
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33640
[Bug 33640] Adding new item group from item additem.pl does nothing
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:32:15 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 12:32:15 +0000
Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item'
screen doesn't work
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |24857
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
[Bug 24857] Add ability to group items for records
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:32:15 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 12:32:15 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33639
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639
[Bug 33639] Adding item to item group from 'Add item' screen doesn't work
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:50:17 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 12:50:17 +0000
Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for
renewals creating issue with renewal history view
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|ILS-DI does not record |ILS-DI does not record
|renewer_id for renewals |renewer_id for renewals
| |creating issue with renewal
| |history view
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:51:00 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 12:51:00 +0000
Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for
renewals creating issue with renewal history view
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 14:51:03 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 12:51:03 +0000
Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for
renewals creating issue with renewal history view
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150184|0 |1
is obsolete| |
--- Comment #7 from Katrin Fischer ---
Created attachment 150451
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150451&action=edit
Bug 33504: Update patron_to_html to deal with null
In the patron_to_html function we were dealing explicitly with the case
where patron may be passed undefined, but forgetting that it may be
returned as 'null' from the api too. Changing from `( patron ===
undefined )` to `( patron == null )` is the recommended approach for
detecting 'undefined or null' in javascript.
Signed-off-by: Magnus Enger
Works as advertised. Martin's test plan from Bugzilla:
To test.
1) Use ILS-DI to renew an checkout
2) View the circulation history for the item
3) Click the 'View' button next to the count of renewals
4) Note that the modal just stalls at 'Retrieving renewals'
5) Apply the patch
6) Now the 'retrieving renewals' message should list the renewals instead.
Note that step 2 should be something like "Go to the "Circulation
history" of the patron.
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:00:36 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:00:36 +0000
Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item'
screen doesn't work
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #3 from Katrin Fischer ---
This fixes the problem, but it creates another:
* When enumchron was already filled out, selecting an item group now will
overwrite the entered value and replace it.
I feel like the initial intention here was to avoid this and I think that would
be correct:
if ( ! $('input.items-enumchron').val() ) {
I think if we keep the check, but change it to checking for the name with . not
-, it might actually work?
if ( ! $('input[name="items.enumchron"]').val() ) {
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:02:06 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:02:06 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
|y.org |
Keywords| |regression
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:03:35 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:03:35 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #11 from Katrin Fischer ---
(In reply to David Nind from comment #10)
> I was testing at the same time as Phil (using KTD):
>
> 1. Everything works as per the test plan.
>
> 2. However, after applying the patch and repeating the searches:
> - for Step 6, after getting no results using my name and clicking on "Try
> another search", the name in the field reverts to the original record name
> and not my name
> - for Step 10, the same as step 6 - which is probably correct (but I'm
> not sure...)
> - feel free to change the status to Failed QA if this is not the expected
> behavour (I would probably have failed QA if there wasn't already a sign off)
>
> 3. I tested using MARC21 and UNIMARC instances.
Hi Nick, could you please have a look at David's notes here? I believe we'd
always want the new name, so that would be one last glitch to fix.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:08:00 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:08:00 +0000
Subject: [Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show
correctly on checkin
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379
--- Comment #13 from Katrin Fischer ---
(In reply to Nick Clemens from comment #12)
> (In reply to Katrin Fischer from comment #11)
> >if you add any line breaks just for
> > making the HTML more readable, they will also all create a line break.
> > Should we not do either/or?
>
> We had calls that already did this - if we want either or, we need a flag to
> determine whether the field is HTML or not, otherwise we need to test with
> regex?
>
> I don't think the additional breaks for HTML cause a problem, but I'll
> follow your viewpoint. Maybe a new bug - so we can make a decision and be
> consistent on all the calls?
I think mostly people will probably use bold, italic etc and not do whole
paragraphs here, so we are probably OK with the line breaks. You are right, we
should discuss separately when needed, but I feel we can wait and see if it
actually turns out to be an issue.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:09:00 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:09:00 +0000
Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about
found/recovered books
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608
--- Comment #1 from Katrin Fischer ---
Hi Marcel, can you explain this a bit more? Is this about logging when an
item's lost status is lifted?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:12:17 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:12:17 +0000
Subject: [Koha-bugs] [Bug 29653] Return claims on deleted items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29653
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|21.05 |22.11
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:17:46 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:17:46 +0000
Subject: [Koha-bugs] [Bug 33642] New: Typo: No log found .
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33642
Bug ID: 33642
Summary: Typo: No log found .
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Keywords: Academy
Severity: trivial
Priority: P5 - low
Component: Staff interface
Assignee: koha-bugs at lists.koha-community.org
Reporter: katrin.fischer at bsz-bw.de
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
When using the log viewer under tools and no logs are found you'll see:
No log found .
This should be:
No log found.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:18:21 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:18:21 +0000
Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab
if TranslateNotices enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oleonard at myacpl.org
--- Comment #1 from Katrin Fischer ---
Also confirmed in master. Wonder if this could have something to do with the
work on tabs? Adding Owen.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:22:21 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:22:21 +0000
Subject: [Koha-bugs] [Bug 33643] New: Add page-section to 'scan index' page
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33643
Bug ID: 33643
Summary: Add page-section to 'scan index' page
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: trivial
Priority: P5 - low
Component: Staff interface
Assignee: katrin.fischer at bsz-bw.de
Reporter: katrin.fischer at bsz-bw.de
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
Depends on: 33505
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505
[Bug 33505] Improve styling of scan index page
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:22:21 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:22:21 +0000
Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33643
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33643
[Bug 33643] Add page-section to 'scan index' page
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:22:42 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:22:42 +0000
Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505
--- Comment #13 from Katrin Fischer ---
> 2. The results pages need the page section added (bug 31757).
Moved to:
Bug 33643 - Add page-section to 'scan index' page
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:29:07 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:29:07 +0000
Subject: [Koha-bugs] [Bug 33643] Add page-section to 'scan index' page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33643
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:29:09 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:29:09 +0000
Subject: [Koha-bugs] [Bug 33643] Add page-section to 'scan index' page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33643
--- Comment #1 from Katrin Fischer ---
Created attachment 150452
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150452&action=edit
Bug 33643: Add page-section to 'scan index' page in staff interface
This adds the white background. As we do on other pages I have
chosen to include the h2 heading within the page-section.
To test:
* Go to advanced search in staff interface
* Activate 'More options'
* Check checkbox for scan indexes
* Switch to author (especially when using Elasticsearch)
* Search for C
* On the result list verify there is no white background/page section
* Apply patch
* Repeat test - background should be present now
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:30:03 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:30:03 +0000
Subject: [Koha-bugs] [Bug 33631] results_summary label and content are
slightly misaligned in staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
|y.org |
Keywords| |rel_22_11_candidate
--- Comment #7 from Katrin Fischer ---
We've also seen this - happy to have a look!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:30:34 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:30:34 +0000
Subject: [Koha-bugs] [Bug 33631] results_summary label and content are
slightly misaligned in staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150314|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:30:39 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:30:39 +0000
Subject: [Koha-bugs] [Bug 33631] results_summary label and content are
slightly misaligned in staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|katrin.fischer at bsz-bw.de |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:36:10 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:36:10 +0000
Subject: [Koha-bugs] [Bug 33631] results_summary label and content are
slightly misaligned in staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631
--- Comment #8 from Katrin Fischer ---
Created attachment 150453
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150453&action=edit
k
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:37:17 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:37:17 +0000
Subject: [Koha-bugs] [Bug 33631] results_summary label and content are
slightly misaligned in staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:37:20 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:37:20 +0000
Subject: [Koha-bugs] [Bug 33631] results_summary label and content are
slightly misaligned in staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150320|0 |1
is obsolete| |
--- Comment #9 from Katrin Fischer ---
Created attachment 150454
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150454&action=edit
Bug 33631: [alternate] Fix misaligned labels
If you look at the results_summary on either the results
or detail pages you will notice that the label and
content are slightly misaligned.
To test:
1. On staff results, detail page, or ISBD details notice
that slight misaligmnet between label and content.
2. Apply patch, yarn_build, clear browser cache
3. Look again, alignment should be fixed
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:37:43 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:37:43 +0000
Subject: [Koha-bugs] [Bug 33631] results_summary label and content are
slightly misaligned in staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150453|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:37:59 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:37:59 +0000
Subject: [Koha-bugs] [Bug 33631] results_summary label and content are
slightly misaligned in staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631
--- Comment #10 from Katrin Fischer ---
I've fixed the commit message :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:41:48 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:41:48 +0000
Subject: [Koha-bugs] [Bug 33628] Show item info in self check-in module
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33628
--- Comment #1 from Katrin Fischer ---
Created attachment 150455
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150455&action=edit
Display of checkins on web based self checkin page
Confirmed: the current display is quite minimalistic.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:42:34 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:42:34 +0000
Subject: [Koha-bugs] [Bug 31187] Regression,
Permanent shelving location is always updated when editing location
VIA BATCH ITEM MOD if both are mapped to MARC fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:53:03 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:53:03 +0000
Subject: [Koha-bugs] [Bug 29664] Do not show voided payments in
cash_register_stats.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:53:05 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:53:05 +0000
Subject: [Koha-bugs] [Bug 29664] Do not show voided payments in
cash_register_stats.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664
--- Comment #10 from Kyle M Hall ---
Created attachment 150456
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150456&action=edit
Bug 29664: Do not show voided payments in cash_register_stats.pl
Test Plan:
1) Set up your cash register
2) Take a payment
3) Void that payment
4) Verify the voided fee shows for the "All payments to the library" and
"Payment" transaction type filters
5) Apply this patch
6) Restart all the things!
7) Verify the voided fee no longer shows for the "All payments to the library"
and
"Payment" transaction type filters
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 15:57:45 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 13:57:45 +0000
Subject: [Koha-bugs] [Bug 28093] Additional configuration option(s) for
Shibboleth-only mode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28093
--- Comment #4 from Katrin Fischer ---
I was looking into making the bug description a bit more specific, but now I am
not sure if this shouldn't be separate bugs:
* Add a landing page for Shibboleth/external auth that the user is redirected
to
* when being automatically logged in
* when logging out
I wonder if the first could be annoying or if we should still provide way to
get to the URL that was originally requested somehow.
* Deactivate local login if external auth is activated.
It looks like we already have this for Shibboleth with
OPACShibOnly/staffShibOnly? So would this be for extending this beyond
Shibboleth?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 16:03:39 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 14:03:39 +0000
Subject: [Koha-bugs] [Bug 33614] Templates contain problematic references to
local login
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33614
--- Comment #1 from Katrin Fischer ---
I think CSS might not be the correct solution here. You'll still want to have
helpful text/notes.
I feel like we need to adapt the templates for having no local login?
There is OPACShibOnly. Do we need this for OIDC and others too? Or turn it into
a general "LocalLogin" switch?
We have opacuserlogin, but that totally turns off anything that requires or
looks like login.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 16:06:29 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 14:06:29 +0000
Subject: [Koha-bugs] [Bug 33536] If staff member only has catalogue
permission, search bar is hidden
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33536
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
Status|NEW |RESOLVED
--- Comment #2 from Katrin Fischer ---
I believe we have a duplicate with a patch now with bug 33612.
*** This bug has been marked as a duplicate of bug 33612 ***
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 16:06:29 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 14:06:29 +0000
Subject: [Koha-bugs] [Bug 33612] Staff with limited permissions don't always
get an expanded catalog_search bar
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |caroline.cyr-la-rose at inlibr
| |o.com
--- Comment #5 from Katrin Fischer ---
*** Bug 33536 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:22:41 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 15:22:41 +0000
Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages
(Select all/Clear all, post-Ajax updates)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590
Caroline Cyr La Rose changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:22:43 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 15:22:43 +0000
Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages
(Select all/Clear all, post-Ajax updates)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590
Caroline Cyr La Rose changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150250|0 |1
is obsolete| |
--- Comment #8 from Caroline Cyr La Rose ---
Created attachment 150457
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150457&action=edit
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to
article-requests.tt
This commit fixed two cases:
1. Fixing "Select all" and "Clear all" links on the page.
2. Fixing the interaction with selected entries when switching between the
"New" and "Pending" tabs.
To test:
(Create article requests if they don't exist)
Case 1:
1. Go to /cgi-bin/koha/circ/article-requests.pl and don't switch between tabs.
2. Click on "Select all" and verify that it's not working -- the checkboxes are
not selected.
3. Activate any checkbox and click "Clear all" -- the checkbox is not cleared.
4. Apply the patch.
5. Restart the page and, without switching between tabs, repeat steps 2 and 3.
Verify that it works now.
Case 2:
1. Go to /cgi-bin/koha/circ/article-requests.pl.
2. Switch between tabs and leave "New" active.
3. Select any entry and delete or move it to another tab.
4. Verify that the entry remains in the table until the page reloads.
5. Apply the patch.
6. Restart the page and repeat steps 2 and 3. Make sure that everything works
now.
Signed-off-by: Caroline Cyr La Rose
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:22:46 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 15:22:46 +0000
Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages
(Select all/Clear all, post-Ajax updates)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590
Caroline Cyr La Rose changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150251|0 |1
is obsolete| |
--- Comment #9 from Caroline Cyr La Rose ---
Created attachment 150458
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150458&action=edit
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to
serials-collection.tt
To test:
* Add a subscription
* From the subscription detail page, click on serial collection link in left
hand navigation
* Create some additional issues
* "Clear all" link for selecting issues to edit won't work, "Select all" link
neither
* Apply the patch *
* "Clear all" link for selecting issues to edit works now, "Select all" link
works too.
Signed-off-by: Caroline Cyr La Rose
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:22:48 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 15:22:48 +0000
Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages
(Select all/Clear all, post-Ajax updates)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590
Caroline Cyr La Rose changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150298|0 |1
is obsolete| |
--- Comment #10 from Caroline Cyr La Rose ---
Created attachment 150459
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150459&action=edit
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to modborrowers.tt
The submitted numbers were not processed by the search query.
To test:
1. Go to /cgi-bin/koha/circ/modborrowers.pl
2. On the relevant tab, enter the card number or the borrower number in the
text area, or upload a text file with a relevant list of numbers.
3. Click "Continue" and verify that a message appears stating "No patron card
numbers or borrowernumbers given".
4. Apply the patch.
5. Restart the page and repeat steps 2 and 3. Make sure you receive the correct
response -- a list of borrowers or a message indicating that the specified
numbers were not found.
Signed-off-by: Caroline Cyr La Rose
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:22:51 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 15:22:51 +0000
Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages
(Select all/Clear all, post-Ajax updates)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590
Caroline Cyr La Rose changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150377|0 |1
is obsolete| |
--- Comment #11 from Caroline Cyr La Rose ---
Created attachment 150460
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150460&action=edit
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to export.tt
The list of CSV profiles was not displayed if the CSV format was selected in
the output format settings.
To test:
1. Go to /cgi-bin/koha/tools/export.pl
2. At the bottom of the page in the Output format, select SCV format.
*If SCV format is not active in the drop-down File format menu, create any
profile to Usage export records on the link /cgi-bin/koha/tools/csv-profiles.pl
3. Note that the list of SCV profiles is not displayed.
4. Apply the patch.
5. Restart the page and repeat steps 2.
6. Verify that when you select the CSV format, the list of CSV profiles
appears.
Signed-off-by: Caroline Cyr La Rose
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:24:14 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 15:24:14 +0000
Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages
(Select all/Clear all, post-Ajax updates)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590
Caroline Cyr La Rose changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |caroline.cyr-la-rose at inlibr
| |o.com
--- Comment #12 from Caroline Cyr La Rose ---
I tested the 4.5 scenarios (serial collection, article requests (cases 1 and
2), patron batch modification and catalog export) and everything works with the
patch.
Thank you!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:28:15 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 15:28:15 +0000
Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults
when cataloguing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250
Caroline Cyr La Rose changed:
What |Removed |Added
----------------------------------------------------------------------------
Documentation| |https://gitlab.com/koha-com
submission| |munity/koha-manual/-/merge_
| |requests/669
Documentation| |Caroline Cyr La Rose
contact| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 17:44:45 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 15:44:45 +0000
Subject: [Koha-bugs] [Bug 29664] Do not show voided payments in
cash_register_stats.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664
Laura Escamilla changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|Laura.escamilla at bywatersolu |kyle at bywatersolutions.com
|tions.com |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:31:32 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 16:31:32 +0000
Subject: [Koha-bugs] [Bug 33643] Add page-section to 'scan index' page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33643
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:31:35 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 16:31:35 +0000
Subject: [Koha-bugs] [Bug 33643] Add page-section to 'scan index' page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33643
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150452|0 |1
is obsolete| |
--- Comment #2 from Lucas Gass ---
Created attachment 150461
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150461&action=edit
Bug 33643: Add page-section to 'scan index' page in staff interface
This adds the white background. As we do on other pages I have
chosen to include the h2 heading within the page-section.
To test:
* Go to advanced search in staff interface
* Activate 'More options'
* Check checkbox for scan indexes
* Switch to author (especially when using Elasticsearch)
* Search for C
* On the result list verify there is no white background/page section
* Apply patch
* Repeat test - background should be present now
Signed-off-by: Lucas Gass
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 18:43:51 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 16:43:51 +0000
Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in
items mandatory by default
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419
--- Comment #11 from Laura Escamilla ---
Created attachment 150462
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150462&action=edit
Bug 33419: Set home library and current library as mandatory by default
Test plan to be used with KTD (Koha Testing Docker):
1. Reset KTD so that the web installer is used to setup Koha
2. Setup the web installer
-> When setting up the default settings, don't add any of the optional
data.
3. Once setup and logged in, check the two frameworks (default and ACQ) and
note that $952$a and $952$b are not mandatory.
4. Apply the patch.
5. Repeat steps 1-2.
6. Once setup and logged in, check the two frameworks (default and ACQ) and
note that $952$a and $952$b are now mandatory.
How to setup the web installer
~~~~~~~~~~~~~~~~~~~~
1. Access the database server[1]: mysql -uroot -ppassword -hkoha_db_1
2. Drop the koha_kohadev database: drop database koha_kohadev;
3. Create the database: create database koha_kohadev;
4. Add privileges (for a real installation this would be limited): grant all on
koha_kohadev.* to koha_kohadev;
5. Restart everything (may not be required, but just to be safe):
flush_memcached + restart_all
6. Access the web installer: go to 127.0.0.1:8081
7. Use the database user name and password: get from
/etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password)
8. Continue through the installation process
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:32:05 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 17:32:05 +0000
Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots
for the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317
--- Comment #7 from Lucas Gass ---
I have a few follow-up questions:
1. Should a default value of noindex, nofollow be used here?
2. Is freetext the right thing to use here? Using conflicting or inconsistent
values can confuse search engine crawlers and cause them to make incorrect
assumptions about how to treat your pages in their index.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:35:51 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 17:35:51 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
opening and closing hours
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
CC| |lucas at bywatersolutions.com
--- Comment #35 from Lucas Gass ---
Aleisha,
There are some things the QA script caught that need to be cleaned up:
Missing filters:
OK installer/data/mysql/mandatory/sysprefs.sql
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
FAIL filters
missing_filter at line 292 (
)
missing_filter at line 295 (
)
missing_filter at line 299 (
)
missing_filter at line 306 (
)
missing_filter at line 316 (
)
missing_filter at line 319 (
)
DB columns:
FAIL installer/data/mysql/kohastructure.sql
FAIL boolean_vs_tinyint
WARNING - The new column (day) for table branch_hours is using
INT(1) as type, must be TINYINT(1) if it has a boolean purpose, see the SQL12
coding guideline
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:36:15 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 17:36:15 +0000
Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in
items mandatory by default
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419
Laura Escamilla changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150462|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:51:59 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 17:51:59 +0000
Subject: [Koha-bugs] [Bug 33348] Show authority heading use with
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
CC| |lucas at bywatersolutions.com
--- Comment #3 from Lucas Gass ---
With this patch applied and ShowHeadingUse set to 'Allow' I notice that unit
tests are failing:
kohadev-koha at kohadevbox:koha(master)$ prove -v
/kohadevbox/koha/t/Koha/SearchEngine/Elasticsearch/Search.t
/kohadevbox/koha/t/Koha/SearchEngine/Elasticsearch/Search.t ..
1..2
Name "Koha::SearchEngine::Elasticsearch::AUTHORITIES_INDEX" used only once:
possible typo at /kohadevbox/koha/t/Koha/SearchEngine/Elasticsearch/Search.t
line 55.
ok 1 - use Koha::SearchEngine::Elasticsearch::Search;
# Subtest: search_auth_compat
1..2
ok 1 - Creating a new Search object
# Looks like you planned 2 tests but ran 1.
not ok 2 - search_auth_compat
# Failed test 'search_auth_compat'
# at /kohadevbox/koha/t/Koha/SearchEngine/Elasticsearch/Search.t line 63.
Can't call method "data" on an undefined value at
/kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Search.pm line 252.
# Looks like your test exited with 255 just after 2.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 1/2 subtests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:54:04 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 17:54:04 +0000
Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator
patron search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #39 from Michael Hafen ---
Let me try to amend the test plan with more detail. I was just able to apply
this patch to a current master and get through the test plan successfully, but
there are details missing from the test plan that could cause confusion if one
isn't familiar with the module.
Test plan:
1. start a new batch in the patron card creator (Tools -> Patron card creator
-> New -> card batch)
2. click the Add patron(s) button. This will open the 'Patron search' window.
Observe that Category and Library are the only options.
3. Close 'Patron search' window.
4. Apply patch. Restart Plack, etc.
5. click the Add patron(s) button. This will reopen the 'Patron search'
window. Observe that you can now search for patrons by their sort1 and sort2
values.
6. perform a search using a sort1 or sort2 value that will have multiple
results. Observe the 'Select all | Clear all | Add selected patrons' links and
button.
7. use the Select all link to select all the patrons found by the search.
8. use the Add selected patrons button to add the selected patrons to the card
batch's Add by borrowernumber(s) text input field in the main window.
9. close the 'Patron search' window. Click the Add patron(s) button again to
add the patrons to the batch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:56:55 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 17:56:55 +0000
Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if
DefaultHoldExpirationdate is set
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:56:58 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 17:56:58 +0000
Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if
DefaultHoldExpirationdate is set
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150294|0 |1
is obsolete| |
--- Comment #5 from David Nind ---
Created attachment 150463
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150463&action=edit
Bug 33611: Unit test
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 19:57:00 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 17:57:00 +0000
Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if
DefaultHoldExpirationdate is set
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150295|0 |1
is obsolete| |
--- Comment #6 from David Nind ---
Created attachment 150464
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150464&action=edit
Bug 33611: Ensure dt_from_string always returns a new object
This patch alters dt_from_string to pass a cloned object if called
on an existing date time object
This resolves an issue where a holds reserve date was being altered when
the default expiration date was set
To test:
1 - Set DefaultHoldExpiration to Set
2 - Set DefaultHoldExpirationPeriod to 365
3 - Set DefaultHoldExpirationunitOfTimeToDays
4 - Place a hold
5 - Note reserve date is 1 year in the future, same as expiration
6 - Apply patch
7 - Restart all
8 - Place another hold
9 - Note reserve date is set to today
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:06:59 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 18:06:59 +0000
Subject: [Koha-bugs] [Bug 33631] results_summary label and content are
slightly misaligned in staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631
--- Comment #11 from David Nind ---
Thanks for testing and signing off Katrin! (You beat me to it!)
I was working through various screens, but had not found anything - so far, any
misalignments I found were already there before the patch.
This also now corrects the display in the search results.
David
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:12:30 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 18:12:30 +0000
Subject: [Koha-bugs] [Bug 33631] results_summary label and content are
slightly misaligned in staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631
--- Comment #12 from Katrin Fischer ---
Please sign-off, then I can use my token for QA :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:24:49 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 18:24:49 +0000
Subject: [Koha-bugs] [Bug 33631] results_summary label and content are
slightly misaligned in staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150454|0 |1
is obsolete| |
--- Comment #13 from David Nind ---
Created attachment 150465
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150465&action=edit
Bug 33631: [alternate] Fix misaligned labels
If you look at the results_summary on either the results
or detail pages you will notice that the label and
content are slightly misaligned.
To test:
1. On staff results, detail page, or ISBD details notice
that slight misaligmnet between label and content.
2. Apply patch, yarn_build, clear browser cache
3. Look again, alignment should be fixed
Signed-off-by: Katrin Fischer
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:27:02 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 18:27:02 +0000
Subject: [Koha-bugs] [Bug 33631] results_summary label and content are
slightly misaligned in staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631
--- Comment #14 from David Nind ---
(In reply to Katrin Fischer from comment #12)
> Please sign-off, then I can use my token for QA :)
Done!
I also tested a sample of other pages to see if I noticed any changes (this was
in no way comprehensive).
I only identified some minor misalignments that were present before the patch
was applied.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:40:27 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 18:40:27 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:40:29 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 18:40:29 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
--- Comment #12 from Nick Clemens ---
Created attachment 150466
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150466&action=edit
Bug 33445: Pass through form info if present and use record values otherwise
This patch updates the form to pass through values formthe form when searching,
and
to use record values if nothing is passed in.
TO test:
1 - Without the patch, edit a personal name authority record
2 - Replace 100 subfield a (200 subfield a for UNIMARC) with your own name
3 - Click "Replace record via Z39.50/SRU search"
4 - Note that prefilled search field contains the original value, not your
name.
5 - Replace the Author (personal) field with your name in the search form
6 - choose a search target, and click Search.
7 - Note that the results of the search are for the original value, not your
name
8 - From the details page of a record, click 'Edit -> Replace record via
Z3950'
9 - Note form is prefilled
10 - Change value as in 5 and search
11 - Note original term was searched
12 - Apply patch, restart all
13 - Repeat searches as before
14 - Confirm that form is prefilled with record or the updated value
15 - Confirm your entered search terms are always searched
Signed-off-by: Phil Ringnalda
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:40:32 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 18:40:32 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
--- Comment #13 from Nick Clemens ---
Created attachment 150467
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150467&action=edit
Bug 33445: (follow-up) Pass form values through when clicking 'Try another
search'
We didn't include anything except the authid id in the try again form, this
patch extends to cover all the fields
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:40:35 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 18:40:35 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
--- Comment #14 from Nick Clemens ---
Created attachment 150468
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150468&action=edit
Bug 33445: (follow-up) Allow all search fields to be passed through and
returned when trying another search
It seems the form didn't populate all fields form data passed in. This patch
corrects that
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:43:10 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 18:43:10 +0000
Subject: [Koha-bugs] [Bug 33644] New: Link tracking
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33644
Bug ID: 33644
Summary: Link tracking
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: cbrannon at cdalibrary.org
QA Contact: testopia at bugs.koha-community.org
It would be awesome if we could add a unique parameter to the opac url that,
when used, would be recorded in a table as a use. It would record the link,
and how many times it has been clicked.
Sometimes we set up links on signage, or websites, or in a QR code, and it
would be great to measure which links are being utilized where.
So, maybe we could have a link that is in a QR code being displayed in a
particular location, like
https://YOUROPAC/cgi-bin/koha/opac-search.pl?q=(su%3A%7BGardening.%7D). Maybe
we add a parameter like &track=qrnorthdisplay, and every time this link is
visited, it would save to a tracking table, maybe linktracking. It would save
the &track parameter, and then keep count every time that link is hit. That
way it would only have one record in the table, rather than one for every
click.
Maybe you want one for every click so you could time stamp it and see when it
is being clicked? I don't know. But this would be such a handy feature,
especially for establishing how effective links are, and usage.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:44:26 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 18:44:26 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150419|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:45:35 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 18:45:35 +0000
Subject: [Koha-bugs] [Bug 32906] Make 'Replace record via Z3950/SRU' buttons
in authorities work consistently
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32906
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at bywatersolutions.com
--- Comment #1 from Nick Clemens ---
I don't see the difference, it looks like both pass the authid and pull the
terms from marc, and accounts for UNIMARC, maybe another bug fixed it?
See also bug 33445
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 20:51:34 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 18:51:34 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_14772=5D_Remove_or_clarify_checkbox?=
=?utf-8?q?_=C2=ABflagged=C2=BB_on_subfield_visibility_frameworks?=
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14772
Caroline Cyr La Rose changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |caroline.cyr-la-rose at inlibr
| |o.com
--- Comment #4 from Caroline Cyr La Rose ---
(In reply to Séverine Queune from comment #3)
> I tested the use of this option for items subfields and I'm not sure it
> should be suppressed, but adapted : this option is the only way (I found...)
> to hide subfields from the modification pages "Add item" and "Batch item
> modification".
> It could be great to have the "Flagged" box checkable with the others (now,
> all others boxes are unchecked when used) so each library could define which
> subfields can be modified using the "Add item" page (checkbox "Editor") but
> hidden on the "Batch item modification" form.
> But maybe my comment out of purpose...
Unless I'm misunderstanding, I cannot reproduce this in the current master
(22.12). If I uncheck 'Editor', the subfield is removed from both 'Add item'
and 'Batch item modification'.
I agree that there is no way currently to make a subfield appear in the 'Add
item' form, but not in the 'Batch item modification' form. You can use
SubfieldsToAllowForRestrictedBatchmod if really this subfield shouldn't be
allowed to be batch modified.
This probably should be the subject of another bug report, if there really is a
need. I'm in favour of removing the 'flagged' option completely
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:04:32 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 19:04:32 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
--- Comment #15 from Phil Ringnalda ---
Comment on attachment 150468
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150468
Bug 33445: (follow-up) Allow all search fields to be passed through and
returned when trying another search
>-[% USE raw %]
>+nt[% USE raw %]
Haven't looked at whether that nt belonged somewhere else, but it doesn't look
right there.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:06:45 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 19:06:45 +0000
Subject: [Koha-bugs] [Bug 33631] results_summary label and content are
slightly misaligned in staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:08:13 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 19:08:13 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
--- Comment #16 from David Nind ---
(In reply to Phil Ringnalda from comment #15)
> Comment on attachment 150468 [details] [review]
> Bug 33445: (follow-up) Allow all search fields to be passed through and
> returned when trying another search
>
> >-[% USE raw %]
> >+nt[% USE raw %]
>
> Haven't looked at whether that nt belonged somewhere else, but it doesn't
> look right there.
Was just retesting - the nt appears at the top left of the Z3950 search window.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:09:49 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 19:09:49 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150468|0 |1
is obsolete| |
--- Comment #17 from Nick Clemens ---
Created attachment 150469
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150469&action=edit
Bug 33445: (follow-up) Allow all search fields to be passed through and
returned when trying another search
It seems the form didn't populate all fields form data passed in. This patch
corrects that
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:10:35 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 19:10:35 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
--- Comment #18 from Nick Clemens ---
(In reply to David Nind from comment #16)
> (In reply to Phil Ringnalda from comment #15)
>
> Was just retesting - the nt appears at the top left of the Z3950 search
> window.
That was a slip, new patch attached
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:14:24 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 19:14:24 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:14:27 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 19:14:27 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150466|0 |1
is obsolete| |
--- Comment #19 from David Nind ---
Created attachment 150470
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150470&action=edit
Bug 33445: Pass through form info if present and use record values otherwise
This patch updates the form to pass through values formthe form when searching,
and
to use record values if nothing is passed in.
TO test:
1 - Without the patch, edit a personal name authority record
2 - Replace 100 subfield a (200 subfield a for UNIMARC) with your own name
3 - Click "Replace record via Z39.50/SRU search"
4 - Note that prefilled search field contains the original value, not your
name.
5 - Replace the Author (personal) field with your name in the search form
6 - choose a search target, and click Search.
7 - Note that the results of the search are for the original value, not your
name
8 - From the details page of a record, click 'Edit -> Replace record via
Z3950'
9 - Note form is prefilled
10 - Change value as in 5 and search
11 - Note original term was searched
12 - Apply patch, restart all
13 - Repeat searches as before
14 - Confirm that form is prefilled with record or the updated value
15 - Confirm your entered search terms are always searched
Signed-off-by: Phil Ringnalda
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:14:29 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 19:14:29 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150467|0 |1
is obsolete| |
--- Comment #20 from David Nind ---
Created attachment 150471
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150471&action=edit
Bug 33445: (follow-up) Pass form values through when clicking 'Try another
search'
We didn't include anything except the authid id in the try again form, this
patch extends to cover all the fields
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:14:32 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 19:14:32 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150469|0 |1
is obsolete| |
--- Comment #21 from David Nind ---
Created attachment 150472
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150472&action=edit
Bug 33445: (follow-up) Allow all search fields to be passed through and
returned when trying another search
It seems the form didn't populate all fields form data passed in. This patch
corrects that
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:16:42 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 19:16:42 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
--- Comment #22 from David Nind ---
(In reply to Nick Clemens from comment #18)
> (In reply to David Nind from comment #16)
> > (In reply to Phil Ringnalda from comment #15)
> >
> > Was just retesting - the nt appears at the top left of the Z3950 search
> > window.
>
> That was a slip, new patch attached
Thanks Nick!
Now signed off.
I added some values to the keyword input field, and these were retained
(including 'Try another search'.
David
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:32:11 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 19:32:11 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150470|0 |1
is obsolete| |
--- Comment #23 from David Nind ---
Created attachment 150473
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150473&action=edit
Bug 33445: Pass through form info if present and use record values otherwise
This patch updates the form to pass through values formthe form when searching,
and
to use record values if nothing is passed in.
TO test:
1 - Without the patch, edit a personal name authority record
2 - Replace 100 subfield a (200 subfield a for UNIMARC) with your own name
3 - Click "Replace record via Z39.50/SRU search"
4 - Note that prefilled search field contains the original value, not your
name.
5 - Replace the Author (personal) field with your name in the search form
6 - choose a search target, and click Search.
7 - Note that the results of the search are for the original value, not your
name
8 - From the details page of a record, click 'Edit -> Replace record via
Z3950'
9 - Note form is prefilled
10 - Change value as in 5 and search
11 - Note original term was searched
12 - Apply patch, restart all
13 - Repeat searches as before
14 - Confirm that form is prefilled with record or the updated value
15 - Confirm your entered search terms are always searched
Signed-off-by: Phil Ringnalda
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:32:14 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 19:32:14 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150471|0 |1
is obsolete| |
--- Comment #24 from David Nind ---
Created attachment 150474
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150474&action=edit
Bug 33445: (follow-up) Pass form values through when clicking 'Try another
search'
We didn't include anything except the authid id in the try again form, this
patch extends to cover all the fields
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:32:17 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 19:32:17 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150472|0 |1
is obsolete| |
--- Comment #25 from David Nind ---
Created attachment 150475
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150475&action=edit
Bug 33445: (follow-up) Allow all search fields to be passed through and
returned when trying another search
It seems the form didn't populate all fields form data passed in. This patch
corrects that
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 21:34:39 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 19:34:39 +0000
Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50
will not search for anything but the value from the existing authority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445
--- Comment #26 from David Nind ---
Apologies for the noise - somehow managed to add the patch with the 'nt' when I
signed off. Amended the patch, so should now be correct!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 22:34:25 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 20:34:25 +0000
Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after
allocation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844
Emily Lamancusa changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #60 from Emily Lamancusa ---
Hi Aleisha,
I encountered a few errors while trying to test this patchset.
#1
After changing RevertLostBibLevelHolds to "Revert", I get the following error
on cataloguing/additem.pl:
The method Koha::Items->holds is not covered by tests!
Trace begun at /kohadevbox/koha/Koha/Objects.pm line 572
Koha::Objects::AUTOLOAD('Koha::Items=HASH(0x564bf159f540)',
'HASH(0x564bf1743f18)') called at /kohadevbox/koha/cataloguing/additem.pl line
757
eval {...} at /kohadevbox/koha/cataloguing/additem.pl line 2
The error persists even if I change RevertLostBibLevelHolds to "Don't Revert"
and restart all. (It does not occur before I change the syspref, and does not
persist if I reset all.)
---------------------------------------------------------------------------------
#2
I get the following error on moredetail.pl:
Can't call method "holds" on an undefined value at
/kohadevbox/koha/catalogue/moredetail.pl line 251
The line in question is:
$item_info->{waiting_holds} = $item->{object}->holds({ found => [ 'W', 'T' ],
item_level_hold => { '!=' => 0 } })->count;
I tried replacing "$item->{object}->holds" with "$item->holds" and that seemed
to fix it (and had no effect on error #1).
---------------------------------------------------------------------------------
#3
Tests don't pass:
t/db_dependent/Reserves.t .. "my" variable $item masks earlier declaration in
same scope at /kohadevbox/koha/C4/Circulation.pm line 4029.
t/db_dependent/Reserves.t .. 24/78 No reserves HOLD_CANCELLATION letter
transported by email at /kohadevbox/koha/C4/Letters.pm line 588.
t/db_dependent/Reserves.t .. 73/78 # Looks like you planned 17 tests but
ran 13.
# Failed test 'Waiting item is marked as lost'
# at t/db_dependent/Reserves.t line 1563.
Can't call method "notice_email_address" on unblessed reference at
/kohadevbox/koha/C4/Message.pm line 185.
# Looks like your test exited with 11 just after 73.
t/db_dependent/Reserves.t .. Dubious, test returned 11 (wstat 2816, 0xb00)
Failed 6/78 subtests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 23:07:52 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 21:07:52 +0000
Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab
if TranslateNotices enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622
--- Comment #2 from Aleisha Amohia ---
(I'm using main in place of master as much as possible hehe)
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 23:23:49 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 21:23:49 +0000
Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab
if TranslateNotices enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622
--- Comment #3 from Katrin Fischer ---
You are right - I think we also decided to switch, but haven't yet figured out
the steps and timing. I mostly wanted to help this along saying I can see it
too and I'd also really like to see it fixed - it could cause a bit of a panic
when people think they lost their content.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 1 23:51:07 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 21:51:07 +0000
Subject: [Koha-bugs] [Bug 31187] Regression,
Permanent shelving location is always updated when editing location
VIA BATCH ITEM MOD if both are mapped to MARC fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|katrin.fischer at bsz-bw.de |testopia at bugs.koha-communit
| |y.org
Status|Signed Off |Failed QA
--- Comment #20 from Katrin Fischer ---
With this patch applied, I think we now have a regression for the other use
case:
select kohafield from marc_subfield_structure where tagfield = 952 and
kohafield like "%perm%";
= empty, no results
I haven't linked the subfield in the frameworks.
But:
* location and permanent location are both = FIC
* Edit location (c) in the item editor: both are now GEN
* Batch mod the same item. Set location (c) to FIC.
* We now have location = FIC / permanent.locaton = GEN
The item editor and the batch mod should behave the same way, shouldn't they?
How do you check on the link? I still had k set to the auth_value, but I think
that should not matter.
It works as expected without the patch applied.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:04:56 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 22:04:56 +0000
Subject: [Koha-bugs] [Bug 33633] Check if email exists
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33633
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |In Discussion
--- Comment #9 from Katrin Fischer ---
I think having the library send a verification email and flagging verified or
problematic emails in Koha would be totally ok. But I think using any kind of
outsite tool, API or website would be a big no-no in terms of data privacy and
I also agree with Marcel that we should not implement it within Koha.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:15:25 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 22:15:25 +0000
Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load
every line initially
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:15:27 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 22:15:27 +0000
Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load
every line initially
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253
--- Comment #1 from Lucas Gass ---
Created attachment 150476
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150476&action=edit
Bug 32253: Load all CodeMirror lines initially when using advanced editor
To test:
1. Have advanced editor turned on.
2. Load a record with many lines and see that not all the lines appear until
you click on the visible ones.
3. Apply patch and try again
4. All lines should load.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:16:14 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 22:16:14 +0000
Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in
items mandatory by default
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419
--- Comment #12 from Katrin Fischer ---
Hi Laura,
glad to have you back and congratulations :)
Leaving another note for later:
I was wondering if we should also update existing ones with a database update.
So I checked what we did for itype (see bug 25449). We didn't do a database
update there, so answering my own question: I think w don't need one here
either.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:17:15 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 22:17:15 +0000
Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load
every line initially
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:17:29 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 22:17:29 +0000
Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load
every line initially
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |31863
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863
[Bug 31863] Advanced cataloging editor no longer auto-resizes
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:17:29 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 22:17:29 +0000
Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer
auto-resizes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |32253
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253
[Bug 32253] Advanced cataloging editor doesn't load every line initially
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:32:22 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 22:32:22 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
opening and closing hours
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:32:25 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 22:32:25 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
opening and closing hours
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
--- Comment #36 from Aleisha Amohia ---
Created attachment 150477
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150477&action=edit
Bug 6796: (follow-up) Fix branch_hours.day to enum and add filters
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:32:29 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 22:32:29 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
opening and closing hours
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
--- Comment #37 from Aleisha Amohia ---
Created attachment 150478
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150478&action=edit
Bug 6796: (follow-up) Schema changes
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:37:55 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 22:37:55 +0000
Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie
to Strict
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lucas at bywatersolutions.com
--- Comment #10 from Lucas Gass ---
Alex,
The QA tool complains about quite a few missing filters within Cookies.set. I
think we can add the html filter in those cases, right?
Also, should none be option along with lax and strict?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:39:45 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 22:39:45 +0000
Subject: [Koha-bugs] [Bug 33348] Show authority heading use with
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:39:47 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 22:39:47 +0000
Subject: [Koha-bugs] [Bug 33348] Show authority heading use with
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348
--- Comment #4 from Aleisha Amohia ---
Created attachment 150479
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150479&action=edit
Bug 33348: (follow-up) Fix if no 008 defined
And copy fix across to Zebra search as well.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:47:21 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 22:47:21 +0000
Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after
allocation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:47:25 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 22:47:25 +0000
Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after
allocation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844
--- Comment #61 from Aleisha Amohia ---
Created attachment 150480
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150480&action=edit
Bug 20844: (follow-up) Fixes for lists, objects, templates, tests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:49:28 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 22:49:28 +0000
Subject: [Koha-bugs] [Bug 33348] Show authority heading use with
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:49:31 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 22:49:31 +0000
Subject: [Koha-bugs] [Bug 33348] Show authority heading use with
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150440|0 |1
is obsolete| |
--- Comment #5 from Lucas Gass ---
Created attachment 150481
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150481&action=edit
Bug 33348: Show authority heading use with Elasticsearch
This patch ensures the ShowHeadingUse system preference and feature works as
expected when using Elasticsearch as the searchengine.
To test, follow the test plan at Bug 29990 Comment 9. Ensure the SearchEngine
system preference is set to Elasticsearch.
Sponsored-by: Education Services Australia SCIS
Signed-off-by: Lucas Gass
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 00:49:33 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 22:49:33 +0000
Subject: [Koha-bugs] [Bug 33348] Show authority heading use with
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150479|0 |1
is obsolete| |
--- Comment #6 from Lucas Gass ---
Created attachment 150482
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150482&action=edit
Bug 33348: (follow-up) Fix if no 008 defined
And copy fix across to Zebra search as well.
Signed-off-by: Lucas Gass
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:09:04 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 23:09:04 +0000
Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load
every line initially
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:09:07 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 23:09:07 +0000
Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load
every line initially
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150476|0 |1
is obsolete| |
--- Comment #2 from David Nind ---
Created attachment 150483
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150483&action=edit
Bug 32253: Load all CodeMirror lines initially when using advanced editor
To test:
1. Have advanced editor turned on.
2. Load a record with many lines and see that not all the lines appear until
you click on the visible ones.
3. Apply patch and try again
4. All lines should load.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:10:08 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 23:10:08 +0000
Subject: [Koha-bugs] [Bug 32253] Advanced cataloging editor doesn't load
every line initially
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david at davidnind.com
--- Comment #3 from David Nind ---
Testing notes (using KTD):
1. Used biblionumber = 248 - this has more than 25 lines in the advanced
editor.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:32:26 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 23:32:26 +0000
Subject: [Koha-bugs] [Bug 33614] Templates contain problematic references to
local login
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33614
--- Comment #2 from David Cook ---
(In reply to Katrin Fischer from comment #1)
> There is OPACShibOnly. Do we need this for OIDC and others too? Or turn it
> into a general "LocalLogin" switch?
I like the idea of a general "LocalLogin" switch!
Or I suppose OpacLocalLogin since we'd be focused on the OPAC in this case.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 01:35:29 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 May 2023 23:35:29 +0000
Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and
staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428
--- Comment #15 from David Cook ---
(In reply to Katrin Fischer from comment #14)
> Not only for our use case - currently it's not possible to set different
> timeouts even if you are using different sub domains which divides the
> sessions.
I'm not 100% sure I understand what you're saying.
Different subdomains have different cookies, but in Koha there is only the
"timeout" syspref. Is that what you mean?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 02:15:45 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 May 2023 00:15:45 +0000
Subject: [Koha-bugs] [Bug 33645] New: koha-foreach always returns 1 if
--chdir not specified
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33645
Bug ID: 33645
Summary: koha-foreach always returns 1 if --chdir not specified
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Command-line Utilities
Assignee: koha-bugs at lists.koha-community.org
Reporter: dcook at prosentient.com.au
QA Contact: testopia at bugs.koha-community.org
CC: robin at catalyst.net.nz
If you don't provide --chdir to koha-foreach it will always return an exit code
of 1, because the final if statement in the script will return false
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 02:15:53 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 May 2023 00:15:53 +0000
Subject: [Koha-bugs] [Bug 33645] koha-foreach always returns 1 if --chdir
not specified
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33645
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 02:19:13 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 May 2023 00:19:13 +0000
Subject: [Koha-bugs] [Bug 33645] koha-foreach always returns 1 if --chdir
not specified
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33645
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 02:19:16 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 May 2023 00:19:16 +0000
Subject: [Koha-bugs] [Bug 33645] koha-foreach always returns 1 if --chdir
not specified
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33645
--- Comment #1 from David Cook ---
Created attachment 150484
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150484&action=edit
Bug 33645: Make koha-foreach return 0 if it completes successfully
This patch adds an "exit 0" to the end of koha-foreach, so that it
returns a successful exit code if it reaches the bottom of the script
without errors.
Test plan:
0) `koha-foreach echo`
1) `echo $?`
2) Note that the exit status is 1
3) Apply patch
4) `./debian/scripts/koha-foreach echo`
5) `echo $?`
6) Note that the exit status is 0
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 02:23:05 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 May 2023 00:23:05 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
opening and closing hours
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:18:08 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 May 2023 01:18:08 +0000
Subject: [Koha-bugs] [Bug 22718] Authorized value for not for loan not
showed in cataloging search results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22718
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |WORKSFORME
CC| |dcook at prosentient.com.au
Status|NEW |RESOLVED
--- Comment #1 from David Cook ---
Works for me in 21.11+
But there are other issues relating to the display of "not for loan" items in
the Cataloging search...
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:20:49 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 May 2023 01:20:49 +0000
Subject: [Koha-bugs] [Bug 33646] New: "Cataloging search" missing branch
data for not for loan items
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646
Bug ID: 33646
Summary: "Cataloging search" missing branch data for not for
loan items
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Searching
Assignee: koha-bugs at lists.koha-community.org
Reporter: dcook at prosentient.com.au
QA Contact: testopia at bugs.koha-community.org
In the "Cataloging search" (ie /cgi-bin/koha/cataloguing/addbooks.pl), the
branch name doesn't appear for "Not for loan" items, which makes the display
nonsensical when there are many not for loan items for many branches.
It's also inconsistent with the "Search results" (ie
/cgi-bin/koha/catalogue/search.pl).
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:22:15 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 May 2023 01:22:15 +0000
Subject: [Koha-bugs] [Bug 33646] "Cataloging search" missing important data
for not for loan items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|"Cataloging search" missing |"Cataloging search" missing
|branch data for not for |important data for not for
|loan items |loan items
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:38:36 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 May 2023 01:38:36 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:38:39 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 May 2023 01:38:39 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144131|0 |1
is obsolete| |
--- Comment #32 from David Nind ---
Created attachment 150485
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150485&action=edit
Bug 31391: RecallsInterface system preference
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:38:43 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 May 2023 01:38:43 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144132|0 |1
is obsolete| |
--- Comment #33 from David Nind ---
Created attachment 150486
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150486&action=edit
Bug 31391: Recalled authorised value for hold cancellation
Signed-off-by: David
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:38:46 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 May 2023 01:38:46 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144133|0 |1
is obsolete| |
--- Comment #34 from David Nind ---
Created attachment 150487
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150487&action=edit
Bug 31391: Implement RecallsInterface on OPAC
Signed-off-by: David
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:38:49 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 May 2023 01:38:49 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144134|0 |1
is obsolete| |
--- Comment #35 from David Nind ---
Created attachment 150488
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150488&action=edit
Bug 31391: Request recalls and convert reserves on staff interface
This enhancement adds the ability to place recalls via the staff
interface by introducing a system preference, RecallsInterface, to
configure where recalls can be placed. Recalls can either be placed via
the OPAC, or the staff interface, or both. This is set to OPAC by
default to be consistent with current behaviour.
This enhancement also adds the ability to convert existing reserves to
recalls easily via the staff interface. The reserve will be cancelled
and a recall placed using the reserve's information.
To test:
1) Update database and restart services
2) Enable UseRecalls and set the relevant recalls circulation rules
3) View the new RecallsInterface system preference. Confirm it is set to
OPAC only by default
4) Check out Item A to Patron B.
5) Log into the OPAC as Patron A. Confirm you can place, view and cancel
recalls as normal.
6) In the staff interface, set RecallsInterface to Staff interface only.
7) In the OPAC, confirm you can still view and cancel recalls, but can
no longer place recalls.
8) In the staff interface, search for Item A and go to the Reserves tab.
Place a reserve for Patron C.
9) Under the Priority column, select the dropdown and choose the recall
option next to your reserve.
10) Click Update holds. Confirm when the page refreshes that your
reserve has disappeared.
11) Go to the recalls tab. Confirm your reserve has been converted to a
recall, and details like the patron, expiration, and pickup location have
carried across to the recall.
12) On this recalls page, use the patron search to find Patron D. Test
placing a record-level recall by keeping the 'recall next available
item' checkbox.
13) When the page refreshes, confirm the recall was successfully placed
with the correct details stored.
14) Repeat steps 12 and 13 with Patron E, this time place an item-level
recall by choosing an item in the 'place a recall on a specific item'
table. When selecting one of these items, the 'recall next available
item' checkbox should de-select.
15) Set RecallsInterface back to OPAC only. Go back to the record and
view the Recalls tab.
16) Confirm you cannot search for a patron to place a recall, but can
still view and cancel recalls. Confirm you also cannot convert reserves
to recalls.
17) Set RecallsInterface to both staff interface and OPAC. Confirm you
can place recalls on both interfaces.
18) On the staff interface, test placing recalls that your circulation
rules do not allow. For example, if 'recalls per record' is 1, ensure
you're blocked from placing a second recall on a record for a patron.
19) Place a reserve for one of the patron's that already has a recall.
Once complete, try to convert this reserve into a recall. Confirm you
are blocked and shown a message that the hold cannot be converted to a
recall.
20) Ensure tests pass t/db_dependent/Holds.t
Sponsored-by: Auckland University of Technology
Signed-off-by: David
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:38:52 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 May 2023 01:38:52 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144135|0 |1
is obsolete| |
--- Comment #36 from David Nind ---
Created attachment 150489
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150489&action=edit
Bug 31391: (follow-up) Fix cancel recalls using checkbox
Signed-off-by: David
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:38:55 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 May 2023 01:38:55 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144136|0 |1
is obsolete| |
--- Comment #37 from David Nind ---
Created attachment 150490
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150490&action=edit
Bug 31391: (follow-up) Fix number of tests and terminology
Fixed two items:
- Number of tests: changed to 77 (from 76), tests now pass
- Terminology: changed message when attempting to place recalls
from the staff interface when RecallsInterface in set to the OPAC
only (staff client should be staff interface)
Signed-off-by: David
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:38:59 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 May 2023 01:38:59 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #147582|0 |1
is obsolete| |
--- Comment #38 from David Nind ---
Created attachment 150491
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150491&action=edit
Bug 31391: Interface and wording fixes
This patch includes the following fixes:
- Making the atomic updates executable
- Preventing warns when running tests
- Updating db updates
- Fixing terminology
- Make 'cancel selected recalls' button yellow
- Fix HTML makeup of recalls request page
- Show a warning when placing a recall if there is already a
record-level hold by this patron
- Show a link to mark a hold for conversion which selects the recall
option on holds page
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:45:29 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 May 2023 01:45:29 +0000
Subject: [Koha-bugs] [Bug 33645] koha-foreach always returns 1 if --chdir
not specified
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33645
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue May 2 03:45:31 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 02 May 2023 01:45:31 +0000
Subject: [Koha-bugs] [Bug 33645] koha-foreach always returns 1 if --chdir
not specified
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33645
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150484|0 |1
is obsolete| |
--- Comment #2 from David Nind ---
Created attachment 150492
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150492&action=edit
Bug 33645: Make koha-foreach return 0 if it completes successfully
This patch adds an "exit 0" to the end of koha-foreach, so that it
returns a successful exit code if it reaches the bottom of the script
without errors.
Test plan:
0) `koha-foreach echo`
1) `echo $?`
2) Note that the exit status is 1
3) Apply patch
4) `./debian/scripts/koha-foreach echo`
5) `echo $?`
6) Note that the exit status is 0
Signed-off-by: David Nind