[Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates)

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon May 1 17:22:43 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #150250|0                           |1
        is obsolete|                            |

--- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 150457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150457&action=edit
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to
article-requests.tt

This commit fixed two cases:
1. Fixing "Select all" and "Clear all" links on the page.
2. Fixing the interaction with selected entries when switching between the
"New" and "Pending" tabs.

To test:
(Create article requests if they don't exist)

Case 1:
1. Go to /cgi-bin/koha/circ/article-requests.pl and don't switch between tabs.
2. Click on "Select all" and verify that it's not working -- the checkboxes are
not selected.
3. Activate any checkbox and click "Clear all" -- the checkbox is not cleared.
4. Apply the patch.
5. Restart the page and, without switching between tabs, repeat steps 2 and 3.
Verify that it works now.

Case 2:
1. Go to /cgi-bin/koha/circ/article-requests.pl.
2. Switch between tabs and leave "New" active.
3. Select any entry and delete or move it to another tab.
4. Verify that the entry remains in the table until the page reloads.
5. Apply the patch.
6. Restart the page and repeat steps 2 and 3. Make sure that everything works
now.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list