[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |lucas at bywatersolutions.com

--- Comment #35 from Lucas Gass <lucas at bywatersolutions.com> ---
Aleisha,

There are some things the QA script caught that need to be cleaned up:

Missing filters:

 OK     installer/data/mysql/mandatory/sysprefs.sql
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
   FAIL   filters
                missing_filter at line 292 (                                <tr
id="hours_[% daycount %]">)
                missing_filter at line 295 (                                   
    <input type="hidden" value="[% daycount %]" name="day">)
                missing_filter at line 299 (                                   
    <input type="time" value="[% hr.open_time %]" name="open_time">)
                missing_filter at line 306 (                                   
    <input type="time" value="[% hr.close_time %]" name="close_time">)
                missing_filter at line 316 (                                <tr
id="hours_[% day %]">)
                missing_filter at line 319 (                                   
    <input type="hidden" value="[% daycount %]" name="day">)


DB columns:
 FAIL   installer/data/mysql/kohastructure.sql
   FAIL   boolean_vs_tinyint
                WARNING - The new column (day) for table branch_hours is using
INT(1) as type, must be TINYINT(1) if it has a boolean purpose, see the SQL12
coding guideline

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.