[Koha-bugs] [Bug 33649] New: Fix use of cronlogaction in process_message_queue.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649

            Bug ID: 33649
           Summary: Fix use of cronlogaction in process_message_queue.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: magnus at libriotech.no
        QA Contact: testopia at bugs.koha-community.org

process_message_queue.pl has this code: 

  try {
      $script_handler->lock_exec;
  }
  catch {
      my $message = "Skipping execution of $0 ($_)";
      print STDERR "$message\n"
          if $verbose;
      cronlogaction( $message );
      exit;
  };

If lock_exec fails for some reason, we get this error: 

$ sudo koha-foreach --chdir --enabled --email
/usr/share/koha/bin/cronjobs/process_message_queue.pl
Can't use string ("Skipping execution of /usr/share"...) as a HASH ref while
"strict refs" in use at /usr/share/koha/lib/C4/Log.pm line 135.
mykoha: 13 status returned by
"/usr/share/koha/bin/cronjobs/process_message_queue.pl"

This is because cronlogaction should be called like this: 

cronlogaction({ info => $message })

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.