[Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress"

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046

--- Comment #30 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 150125
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150125
Bug 29046: Use EmailFieldPrecedence in first_valid_email_address

Review of attachment 150125:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=29046&attachment=150125)
-----------------------------------------------------------------

::: Koha/Patron.pm
@@ +1439,5 @@
> +
> +    my @fields = split /\s*\|\s*/,
> +      C4::Context->preference('EmailFieldPrecedence');
> +    for my $field (@fields) {
> +        $email = $self->$field;

You could crash Koha by putting junk into EmailFieldPrecedence.

I think either @fields should be validated or  $self->$field should be
validated.

-- 
You are receiving this mail because:
You are watching all bug changes.