[Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Wed May 3 18:20:40 CEST 2023
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Kyle M Hall <kyle at bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #150569|0 |1
is obsolete| |
Attachment #150570|0 |1
is obsolete| |
Attachment #150571|0 |1
is obsolete| |
--- Comment #62 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 150603
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150603&action=edit
Bug 17427: Replace CGI::Session with Data::Session
CGI::Session is not maintained for ages and seems quite buggy.
It would be the culprit of random logout problems.
Another issue is the following crazy code in CGI::Session::Driver::DBI
sub DESTROY {
my $self = shift;
unless ( defined $self->{Handle} && $self->{Handle} -> ping ) {
$self->set_error(__PACKAGE__ . '::DESTROY(). Database handle has gone
away');
return;
}
unless ( $self->{Handle}->{AutoCommit} ) {
$self->{Handle}->commit;
}
if ( $self->{_disconnect} ) {
$self->{Handle}->disconnect;
}
}
If AutoCommit is off, it will commit anyway...
It causes some tests to fail (api) if SessionStorage is set to MySQL
Note that PostgreSQL is not supported yet so no need to implement it.
Test plan:
0/ The dependencies are not packaged for debian so far, so install it
via cpan
1/ Test the 3 different values for SessionStorage
2/ Using different browsers (or sessions) login into Koha with different
users. Naviguate => you should not be logged out
3/ Set SessionStorage to Memcached, stop memcached make sure that it
defaults to file.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
More information about the Koha-bugs
mailing list