[Koha-bugs] [Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Nick Clemens from comment #3)
> (In reply to Jonathan Druart from comment #2)
> > I don't think the removal here is correct, the method does more than
> > C4::Context->yaml_preference
> > 
> > Nick maybe?
> 
> perl -e 'use Koha::Config::SysPrefs; use C4::Context; my $sp =
> Koha::Config::SysPrefs->find("ItemsDeniedRenewal")->get_yaml_pref_hash; warn
> Data::Dumper::Dumper($sp); warn Data::Dumper::Dumper(
> C4::Context->yaml_preference("ItemsDeniedRenewal"));'
> 
> It doesn't convert from 'NULL' to undef - the expectation is that we can
> pass the return value into a DBIC search directly

Perhaps we removed the wrong copy here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27154

One was an object, the other took a pref name, so would have used cache

-- 
You are receiving this mail because:
You are watching all bug changes.