[Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
$paton->get_lists_with_patron
Looking at package Koha::List::Patron, it feels to me that it better should
live there. No absolute blocker.
That package is no Koha::Object btw. Explaining probably too why you add DBIx
code
 Seeing some calls that only need the count of this result btw.

+<div class="patroninfo-section">
+    <h4>Patron lists without this patron</h4>
Looks like this section contains a lot of duplicated code? Could probably be
merged in some named block.
Not sure why we need two tables, but that seems just a matter of taste.

    @available_lists = GetPatronLists();
    @available_lists = grep { ! $list_id_lookup{$_->patron_list_id} }
@available_lists;
[...]
    in_lists => \@in_lists,
    list_id_lookup => \%list_id_lookup,
    available_lists => \@available_lists,
This makes me even more wonder why we are using get_lists_with_patron. You are
selecting the reverse here?

-- 
You are receiving this mail because:
You are watching all bug changes.