[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

--- Comment #110 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 150256
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150256
Bug 12532: Send email to guarantee and guarantor

Review of attachment 150256:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12532&attachment=150256)
-----------------------------------------------------------------

I love where this is going... but I think it needs a few more little fixes to
get it through.

Happy to help work those in.

::: C4/Letters.pm
@@ +1471,5 @@
>        || $message->{to_address} ne $email->email->header('To');
>  
> +    _update_message_from_address($message->{'message_id'},$email->email->header('From') )
> +      if !$message->{from_address}
> +      || $message->{from_address} ne $email->email->header('From');

Not sure how this relates to the core bug here.. and I don't see any updated
tests to show what this does either?

::: Koha/Email.pm
@@ +118,4 @@
>          $args->{to} = $params->{to};
>      }
>  
> +    my @emails = split(',', $args->{to});

Interesting.. I thought we already supported multiple comma delimited to
addresses.. this feels bad enough that we should have it on it's own bug
really... but I'm happy to let that slide to get it in.

::: Koha/Patron.pm
@@ +1439,5 @@
> +                $address .=  $guarantor_address if $guarantor_address;
> +            }
> +        }
> +    }
> +    return $address;

I'd like to see this rebased against bug 33223 given it makes the use of
notice_email_address more consistent generally.

::: installer/data/mysql/mandatory/sysprefs.sql
@@ +597,4 @@
>  ('RecallsMaxPickUpDelay','7',NULL,'Define the maximum time a recall can be awaiting pickup','Integer'),
>  ('RecordLocalUseOnReturn','0',NULL,'If ON, statistically record returns of unissued items as local use, instead of return','YesNo'),
>  ('Reference_NFL_Statuses','1|2',NULL,'Contains not for loan statuses considered as available for reference','Free'),
> +('RedirectGuaranteeEmail', '0', NULL, 'Enable the ability to redirect guarantee email messages to guarantor.', 'YesNo'),

Redirect seems like the wrong term here.. we're cc'ing in effect in the end..
so perhaps it should be renamed 'Copy'

-- 
You are receiving this mail because:
You are watching all bug changes.