[Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #44 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
1.
+    return { status => '' } unless $borrowernumber;

+    return 0 unless $patron;

No, you can raise an exception if you want.

2. There is no explanation on the logic changes. Can you detail?

3. Code is duplicated in controller scripts, that feels wrong. We certainly
want it in a module, covered by tests.

-- 
You are receiving this mail because:
You are watching all bug changes.