[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

--- Comment #126 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #125)
> 1.
> -        b_sel => ( $budget->{budget_id} == $order->budget_id ) ? 1 : 0,
> +        # b_sel => ( $budget->{budget_id} == $order->budget_id ) ? 1 : 0,
> 
> Then remove ;)

Agreed.

> 2. 
> +  creator:
> +    type:
> +      - object
> +      - "null"
> +    description: Patron that created the order
> 
> We could tell here we expect an object representing a patron

It doesn't work. You cannot put a $ref and 'null', unfortunately. OpenAPI v3
might make it possible.

> 3. 
> +            - items.home_branch
> +            - items.holding_branch
> +            - items.itemtype
> 
> Shouldn't they use the "fixed names"? home_library, item_type?

That's a leftover, not even used and prior to the +strings addition. Will
remove.

> 4. https://snipboard.io/SvHwAn.jpg
> The "Change currency" checkbox is not aligned properly
> And it's actually not working:
> * edit
> * Set actual cost, check "change currency", select a currency, save
> * edit again
> => Values are not saved, you are actually breaking bug 25655.
> Also I have seen "NaN" generated in actual cost but not sure when/how.
> 
> And finally, values are not saved in the DB (invoice_currency,
> invoice_unitprice).

Will check. The most recent iteration got them flawed.

> 5. Partial receive does not seem to work
> I ordered 3, received 1, receiving again:
> "Receiving 0 out of 2" => OK
> Click edit
> => There are 3 items in the items table

Noted, it's a problem with how the post form is built (the items_to_receive
array arrives empty to finishreceive.pl). Working on it

> 6. "Date received:" does not have flatpickr applied
> 
> 7. Fund is not marked "required" like before
> 
> 8. We lost the "show active" checkbox next to the fund list
> 
> 9. There are missing spaces after numbers "Retail price: 0.00(adjusted for
> USD, tax exclusive)"
> 
> 10.
> +                    <th><!--input type="checkbox" id="selectAll"/--></th>
> 
> Do we want that?
> 
> 11. JS code in parcel.tt use 2 spaces indentation instead of 4
> 
> 12. I noticed 2 parallel request to parcel.pl?invoiceid=1 at the end of the
> process, and one of them is aborted. This is what is in the console:
> https://snipboard.io/IKwoVP.jpg
> 
> 13. comment 111 and comment 112 still need an answer.
> I don't understand how dataTables.select.min.js, select.dataTables.min.css
> is useful here. Is that the row.select() and row.deselect() statements in
> parcel.tt? If so, what are they doing? I removed them and didn't see any
> issues.
> 
> 14. There are several parts of the JS code in orderreceive.tt that are
> commented, if we don't need them we should remove them.
> 
> 15. I think we should widen the modal. The item form is not displayed nicely
> https://snipboard.io/VIKAgY.jpg 
> 
> 16: not sure it's a blocker: When you select some orders, the table on the
> order receive page has "Showing 1 to 1 of 1 entries (filtered from 3 total
> entries)"
> But there is no way to display them all. I understand why and what it
> implies, just noting.
> 
> 17. Another "just noting": the code (introduced by bug 20212 I think)
> related to biblio.suggestions.suggester is bad and should have been
> simplified before we did all this. I submitted a patch yesterday to remove
> GetSuggestionInfoFromBiblionumber, it's on bug 28844.

-- 
You are receiving this mail because:
You are watching all bug changes.