[Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon May 15 10:40:03 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 151123
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151123
Bug 33580 - Bring back ability to mark item as seen via SIP2 item information
request

Review of attachment 151123:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=33580&attachment=151123)
-----------------------------------------------------------------

::: t/db_dependent/SIP/Message.t
@@ +457,5 @@
> +    $item_object->update({ itemlost => 1, datelastseen => '1900-01-01' });
> +    $server->{account}->{seen_on_item_information} = 'keep_lost';
> +    $msg->handle_item_information( $server );
> +    $item_object = Koha::Items->find( $item_object->id );
> +    isnt( $item_object->datelastseen, "1900-01-01", "datelastseen updated" );

The tests are failing due to date vs datetime format mismatch.

However.. I think I'd also like ot have seen a different date used to prove the
change.. at first glance this looks like it's checking the field that's already
set.?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list