[Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to David Nind from comment #5)
> Testing notes using KTD:
> 
> 1. I used Ruben Harper (23529000686353) as the guarantor and Joyce Gaines
> (23529000224510) and Bobbie Middleton (23529000080862) as the guarantees.
> 
> 2. I wasn't sure how to restart the SIP emulator after applying the patch,
> so ending up shutting down and starting up KTD (otherwise there was no
> change in the responses received).
> 
restart_all will restart SIP - I had a mistake in the test plan, set the pref
to 9 for the guarantees to trigger the block



(In reply to Victor Grousset/tuxayo from comment #6)
> > 11 - Parent blocked, children should not be
> 
> David's test have the parent unblocked thanks to the patch. Is the test plan
> wrong then?
> 
> I can't get a difference with and without the patch. Even after doing
> "koha-sip --restart" is that the right way? (testing on ktd)

When KTD is shut down and restarted, all data is cleared, so the patrons no
longer had fines - that is why the parent was unblocked

The problem was the mistake in plan, now fixed, ready for testing

-- 
You are receiving this mail because:
You are watching all bug changes.