[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue May 16 19:39:51 CEST 2023
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358
Tomás Cohen Arazi <tomascohen at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tomascohen at gmail.com
--- Comment #86 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Hi all. I'm willing to push a squashed version of this, because it's been
hanging around for a while and it has an on/off switch and also (when squashed)
seems like a small thing.
I would've prefered more communication about this and a more QA eyes, because
the chosen pattern is hard to accept in the current codebase (a static method
on a not so related class). This should've been a Koha::RecordProcessor filter
instead, as (a) This is not about Koha::Metadata::Record objects, but
MARC::Record (b) that's what the Koha::RecordProcessor pattern is designed for.
I will file a separate follow-up bug, and would like the authors to consider
movign this code into a Koha::recordProcessor::Filter class. Happy to
guide/help.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list