[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Wed May 17 14:21:18 CEST 2023
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172
Hammat wele <hammat.wele at inlibro.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #148921|0 |1
is obsolete| |
--- Comment #44 from Hammat wele <hammat.wele at inlibro.com> ---
Created attachment 151330
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151330&action=edit
Bug 24172: Allow translation of seasons in serials-edit.tt and
subscription-detail.tt
Seasons are not handled by locales. Those generated are stored in
English in the database, and the display in serials-collection.tt is
translating them. But once you click on "Edit serials" or if you go
straight to the subscription's display, those are displayed as in the
database: in English.
This patch reproduces the same trick as in serial-collection.tt and
allow for the display to be translated.
NOTE: this patch's testing require knowledge of translation tools.
Reproducing Caroline's test:
0- Make sure you have at least one language other than English installed
1- With staff interface in English, create a subscription with a seasonal
numbering pattern and frequency, with locale in your other language
2- Check the prediction pattern, note that the season names are in English not
the locale language
3- Change the staff interface to other language, redo the prediction pattern
test with locale in other language, note that the season names are in other
language
4- Save the subscription
5- Receive an issue, note that the season name in the "Numbered" column on
serials-edit.pl is in English
6- Save your issue
7- Switch interface in other language
8- Note that the season name on serials-collection is in other language
9- If you check the database, you will see the season name is in English, even
though the subscription.locale is something else
10- validate the different pages:
- serials-collection.pl: display is translated
- serials-edit.pl: name pulled directly from db
- subscription-detail.pl: name pulled directly from db
- detail.pl: name pulled directly from db
- opac-detail.pl: name pulled directly from db
11- APPLY THE PATCH
12- translate the string
a) ./translate update <some locale>
b) find the strings, translate them
c) ./translate install <same locale>
13- restart Plack ?
14- validate the pages again.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Bug 24172: Allow translation of seasons in details.tt and opac-details.tt
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Bug 24172: Move duplicated code to an include file
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list