[Koha-bugs] [Bug 33200] IndependentBranchesTransfers does not prevent holds from creating transfers

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33200

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #151129|0                           |1
        is obsolete|                            |

--- Comment #10 from Hammat wele <hammat.wele at inlibro.com> ---
Created attachment 151348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151348&action=edit
Bug 33200: IndependentBranchesTransfers does not prevent holds from creating
transfers

This patch don't concider hold made from other branches when
IndependentBranchesTransfers is set to Yes and the connected user is not a
SuperLibrarian

To test, you must have

- IndependentBranches, IndependentBranchesPatronModifications and
IndependentBranchesTransfers preferences set to Yes

- canreservefromotherbranches must be set to Don't allow

- Circulation rules that allow holds and checkouts

- Two libraries (I used Midway (A) and Centerville (B))

- A record with two items, one at each library, with barcodes, check out the
one from library A

- Two non-superlibrarian staff user, one in each library, with at least
catalogue and holds permissions, this is what I gave them

  - circulate (all)
  - catalogue
  - delete_borrowers
  - edit_borrowers
  - reserveforothers (all)

1. Log in to the staff interface with the non-superlibrarian staff user from
library A

2. Go to the record with the two items, click 'Place hold'

3. Place a hold for a user, without changing anything (should be for 'next
available item')

4. Log out and log back in with the non-superlibrarian staff user from library
B

5. Check in the item from library B, which should be available
   --> Hold is confirmed for patron from library A, transfer is created

6. Click on 'Confirm hold and transfer'

7. Optionally, you can log out and log back in as staff from library A

8. Go to Circulation > Transfers to receive (should this even be available with
IndependentBranchesTransfers turned on?)
   --> Item from other branch is there

9. Apply the patch

10. Create an other record with two items, one at each library, with barcodes,
check out the one from library A

11. repeat step 1, 2, 3, 4, 5
    --> The 'Hold found' popup is not shown, because there is no hold for this
item in the user branch (library B)

12. repeat step 7,8
    --> Item from other branch is not there

-- 
You are receiving this mail because:
You are watching all bug changes.