[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon May 22 14:46:09 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Michaela Sieber from comment #11)
> (In reply to Jonathan Druart from comment #8)
> > Remote branch rebased and a couple of fixes added.
> > 
> > Setting status to Needs Signoff, this is ready to get feedback from testers.
> 
> 
> Is there a test plan?

There is a lot to test here, so it's hard to provide an exhaustive list. The
idea is to catch bugs I have missed.

You need to play with:
* datatable features (column visibility, sorting, filtering, show/hide filters)
* sysprefs SeparateHoldings and SeparateHoldingsBranch
* syspref StaffDetailItemSelection
* the different action links (when you select at least one item)
* item cover images
* item groups (EnableItemGroups)
* bundles of items (there is still a FIXME to display the 'Manage bundle'
button)
* display of other values (recall, status, holds, checkout and renewal count,
URIs)
* host records
* course reserves
* analytic (this is still a FIXME)
* print label button (SpineLabelShowPrintOnBibDetails)
* edit permissions will show the edit buttons
* and the other things I have missed in this list? :)

In the code there are still FIXMEs:
* display library names instead of codes
* desk name is not displayed anymore
* checkout due date is not correctly formatted
* other technical ones for QA.


> btw:  it is not possible to test the patch in a sandbox 
> http://staff-b33568.sandboxes.ptfs-europe.co.uk/
> 
> Error:
> Template process failed: undef error - C4::Koha::GetAuthorisedValues(): DBI
> Exception: DBD::mysql::st execute failed: 'koha_b32748.av.category' isn't in
> GROUP BY at /kohadevbox/koha/Koha/Template/Plugin/AuthorisedValues.pm line 39
>  at /kohadevbox/koha/C4/Templates.pm line 127

There is something wrong going on but it's not related to this patch. The same
of the sandbox was 'b33568' but the error is refering to another instance
'b32748'. To test this change you need to pass the info to the remote branch
(there was a patch that has been wrongly attached here):
1. Don't pass a bug number
2. Click "advanced options"
3. "Git remote & branch" should be https://gitlab.com/joubu/Koha and bug_33568

I've just tested and it is working, see
https://staff-bug33568.sandboxes.biblibre.eu/cgi-bin/koha/catalogue/detail.pl?biblionumber=1

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list