[Koha-bugs] [Bug 33794] New: Holds Queue builder skips least cost branch unless target item's homebranch is patron's homebranch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794

            Bug ID: 33794
           Summary: Holds Queue builder skips least cost branch unless
                    target item's homebranch is patron's homebranch
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The line
next if $request->{borrowerbranch} ne $item->{homebranch};
has been in the holds queue builder since the very beginning, with no
explanation.

My justification for this line is that we would prefer to send an item to a
patron whose home library is the same is the item's home library, assuming that
patron will return the item at that library, thus reducing transportation
costs.

I will not argue here if this is a good feature or not. Bug 31557 makes in
configurable, but perhaps it should have an 'off' feature as well. 

This feature does not make sense when using the transport cost matrix. We get
the lowest cost branch, and then if the branches don't match we just move on
the the "fall back to basics code". This line should be removed from the code
section dealing with the transport cost matrix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.