[Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Marcel de Rooy from comment #5)
> The changes do not look good to me. We should not save in other encodings.
> Everywhere we convert to UTF-8. Here we should too.

I am happy to go this direction if preferred


(In reply to Marcel de Rooy from comment #4)
> $marcdata is no marc record ! It is a marc blob.
> 
> How did you manage to test it?

I forgot to commit changes after testing :-) New patch retested and verified
against OCLC MARC8 records

(In reply to Marcel de Rooy from comment #6)
> (In reply to Nick Clemens from comment #1)
> > While providing a test plan, it requires a MARC8 Authority source, and I
> > cannot locate
> > an open one. This change can be verified by reading the code.
> 
> This sounds problematic.

If you can find a source I would appreciate it

> > There are no unit tests for Z3950SearchAuth, but it does too much and
> > requires many mocks,
> > this is a small fix to a reversion and should be able to move forward.
> 
> And this too :)

Yes, but we should not allow bugs to remain when we have a fix, but not the
time to pay technical debts.

-- 
You are receiving this mail because:
You are watching all bug changes.