[Koha-bugs] [Bug 33864] Modal broken when "AcqCreateItem" set to "cataloguing"

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864

--- Comment #12 from Andrew Nugged <nugged at gmail.com> ---
but to say how it behave before 23.05 - on our 22.11 there was such code:

    [% IF ( order.quantityreceived ) %]
        ...
    [% ELSE %]
        <input type="text" inputmode="numeric" pattern="[0-9]*" id="quantity"
size="20" name="quantityrec" value="1" />
        <input id="origquantityrec" readonly="readonly" type="hidden"
name="origquantityrec" value="0" />
    [% END %]

i.e. hardcoded `value="1"`. And I see same on 22.05 and since ages:

Bug 5917 : Converted templates
77b64098
Year 2011

    [% IF ( items ) %]
        <input id="quantityrec" READONLY type="text" size="20"
name="quantityrec" value="1" />
    [% ELSE %]
        <input id="quantityrec" type="text" size="20" name="quantityrec"
value="1" />
    [% END %]

======

>(In reply to Katrin Fischer from comment #6)
>    I am in favor of leaving it at 0 and keeping the existing behavior of 
>    older versions (I couldn't verify in 22.05) 
>    BUT: if we pre-populated I think 1 would still be wrong, it should be
>    pre-set with quantity ordered.

It would be a time saver if it were prepopulated with the quantity ordered,

but at least having it "1" covers most cases our librarians receiving something
1,
so good point to have it more clever but not zero.

-- 
You are receiving this mail because:
You are watching all bug changes.