[Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #25 from Hammat wele <hammat.wele at inlibro.com> ---
(In reply to Marcel de Rooy from comment #22)
>  FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>    FAIL   filters
>                 missing_filter at line 1921 (           
> guarantor_attributes = [% To.json(guarantor_attributes) %];)
>                 missing_filter at line 1924 (            to_api_mapping = [%
> To.json(to_api_mapping) %];)
> Please fix.
Missing_filters added

> for this report. Just noting. But might be a chance to rename in members.js?
> The name is quite obscure for copying guarantor information.

I've rename the function to add_guarantor

> Please explain why whe should do an ajax GET in select_user when we pass the
> borrower unblessed hash to this function?
> This does not look good.

It was a suggestion in the comment 5 but you are right, there is no need to use
the REST API to retrieve data from the guarantor since we can get it from the
borrower hidden input, it is fixed in this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.