[Koha-bugs] [Bug 25814] SIP: Add a message on successful checkin

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |matthias.meusburger at biblibr
                   |ity.org                     |e.com

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Tried to have a look at this one, but I would feel better if someone with more
SIP knowledge double checked. 

Some notes:

0) Set assignee to Matthias
1) We need some perltidy


Processing files before patches
|========================>| 3 / 3 (100.00%)
Processing files after patches
|========================>| 3 / 3 (100.00%)

 WARN   C4/SIP/ILS.pm
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 186,
now: 189)

 OK     etc/SIPconfig.xml

 WARN   t/db_dependent/SIP/Transaction.t
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 1,
now: 17)

2) The tests were failing with me on my test database because I had added some
new locations and used them on an item testing bug 21159. After a reset_all the
tests are passing.

3) I'd love some type of documentation/notes in SIPconfig.xml to explain the
use of the new option.

4) Also, never got a reply to my comment#2 about the codes vs. descriptions.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.