[Koha-bugs] [Bug 35157] The searchfieldstype select element produces invalid HTML

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35157

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #5)
> As it stands, this will move all those words back into one single string,
> hurting translations. I believe we can use the same trick as in the reworked
> title tags instead. Have a look at bug 33077.
> 
> It would also be worth checking if we haven't added spans to other strings
> appearing inside options.
> 
> I think we only need to think of where to place the:
> +[% PROCESS 'i18n.inc' %]

If my grepping is correct we need to make sure the i18n include is in the
following files:

koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt:        [%
INCLUDE 'cataloging-search.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt:    [% INCLUDE
'cataloging-search.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt:    [% INCLUDE
'cataloging-search.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/cataloging-home.tt:       
[% INCLUDE 'cataloging-search.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/concerns.tt:    [% INCLUDE
'cataloging-search.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/merge.tt:    [% INCLUDE
'cataloging-search.inc' %]q
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt:    [% INCLUDE
'adv-search.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt:    [% INCLUDE
'home-search.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt:        [% INCLUDE
'home-search.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt:    [%
INCLUDE 'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/alert-subscriptions.tt:    [%
INCLUDE 'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/apikeys.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/deletemem.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/discharges.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/files.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/ill-requests.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt:    [%
INCLUDE 'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:        [%
INCLUDE 'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt:    [%
INCLUDE 'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/merge-patrons.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt:        [%
INCLUDE 'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/purchase-suggestions.tt:    [%
INCLUDE 'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/recallshistory.tt:        [%
INCLUDE 'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/routing-lists.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt:    [% INCLUDE
'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/members/two_factor_auth.tt:    [%
INCLUDE 'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt:    [%
INCLUDE 'patron-search-header.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/tools/picture-upload.tt:    [% INCLUDE
'patron-search-header.inc' %]


So we need to add it to these 2 templates: 

koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/alert-subscriptions.tt

-- 
You are receiving this mail because:
You are watching all bug changes.