[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Needs Signoff               |Failed QA

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Let me start by saying thank you for taking on some work that has been needed
for a ling time. I like the way this is going very much, but I do have a few
concerns:

I think we need some test coverage for the new module if we want to move it
forward.

The templates should not be passed to the object, the matcher/batch info would
be better served as template plugins I think.

I wonder if add_items_from_import_record could combine a little more of the
code for the two agents - perhaps there could be a top level routine that calls
a lower level - after getting the parameters needed for the two different
agents?

add_biblios_from_import_record - I don't think the plural is correct here,
orders->biblios is 1:1?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.