[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668

--- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> ---
Comment on attachment 157315
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157315
Bug 34668: Add popup warn librarians of waiting holds when checking out

Review of attachment 157315:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=34668&attachment=157315)
-----------------------------------------------------------------

::: circ/circulation.pl
@@ +552,5 @@
> +        #Check for waiting holds
> +        my $waiting_holds          = $patron->holds->search( { found => 'W', branchcode => $branch } );
> +        my @waiting_holds_barcodes = ();
> +        while ( my $hold = $waiting_holds->next ) {
> +            push( @waiting_holds_barcodes, $hold->item->barcode );

There is no need to make a list of the barcodes, just pass the entire
waiting_holds rs to the template and let it loop over them.

-- 
You are receiving this mail because:
You are watching all bug changes.