[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I'd like for someone who knows their way around the REST API a little better to
have a second look here. 

Most of these are cosmetic and should be quick to follow-up:

1) Needs a follow-up to fix documentation.

+=head3 populate_empty_callnumbers
+
+Controller function that handles deleting a biblio object

2) Spelling

In the item form and the holding table we are using 'call number', but the
patch uses 'callnumber'. I believe we should follow the GUI. 

See also: https://wiki.koha-community.org/wiki/Terminology

3) I feel we should include the call number that would be used in the
confirmation question. 

if ( confirm(__('Are you sure you want to populate callnumbers for all items
without a callnumber on this record?')) ) 

4) Please no line breaks in translatable strings!

This is a known issue with Pootle, not sure about Weblate, but translators
often might not know what it is and accidentally remove it.

msg += __('\nReload the page?');
let msg = __('Item populated with the callnumber "%s"\nReload the
page?').format(callnumber);

4) Button in the holdings table

The button for every single item in the holdings table takes up quite a bit of
space. I wonder if we could find a way to make this work a little better. Maybe
a split button with Edit as the main action?

5) Button in the detail page's toolbar (not blocker)

Why not move this into the edit menu?


4) Maintenance script? (not blocker)

I wonder about the use case to require such a one by one change. If you have
itemcallnumber set, this would only apply to items that have been created
before, that have been imported or otherwise added from outside of Koha. 

Are there plans for a maintenance script to do this in batch?

-- 
You are receiving this mail because:
You are watching all bug changes.