[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #147 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Oi, so many rebases. Sorry we didn't get to this earlier.

1) Can you explain this part of the code please?

+        my $last_borrowers_to_anonymise =
$patron->_result->items_last_borrowers->search(
+            {
+                (
+                    $older_than_date
+                    ? ( created_on => { '<' =>
$dtf->format_datetime($older_than_date) } )
+                    : (),
+                    "itemnumber.damaged"   => 0,
+                    "itemnumber.itemlost"  => 0,
+                    "itemnumber.withdrawn" => 0,
+                ),
+            },
+            { join => ['itemnumber'] }
+        );

2) Database updated needs to be reformatted to use the newer template.

3) Terminology / System preference naming

Sorry to be nit-picky about this, but I believe we should stick to the standard
terminology as per our coding guidelines:

* Use AE instead of BE: Anonymise should be Anonymize
* Borrower should be Patron

AnonymiseLastBorrower => AnonymizeLastPatron
AnonymiseLastBorrowerDays => AnonymizeLastPatronDelay/Days

System preference descriptions need to be adapted as well.

4) Cronjob

+use strict;
+use warnings;

--> should be Use Modern::Perl.

5) anonymise_issue_history appears to be unused?

-- 
You are receiving this mail because:
You are watching all bug changes.