[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Sun Nov 5 13:38:41 CET 2023
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992
--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
1) Perltidied in a follow-up to make the tests pass. Please remember to run QA
test tools and perltidy your code.
2) Ternary operator needed?
+ my $block_lost_return =
C4::Context->preference("BlockReturnOfLostItems") ? 1 : 0;
Do we really need the ternary operator here? The preference is already stored
with 0 and 1 in the database.
3) I feel like the information to the users could be a bit more prominent,
maybe something for another bug. Not a blocker here.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list