[Koha-bugs] [Bug 35269] Koha::Item->update_item_location should be named `trigger_location_update`

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #7 from David Nind <david at davidnind.com> ---
This is how I tested - hope this is sufficient!

1. Before applying the patch run git grep update_item_location - this was the
result for me:

kohadev-koha at kohadevbox:koha(bz35269)$ git grep update_item_location
C4/Circulation.pm:            $item_object->update_item_location( 'checkout' );
C4/Circulation.pm:    my $loc_messages = $item->update_item_location( 'checkin'
);
Koha/Item.pm:=head3 update_item_location
Koha/Item.pm:    $item->update_item_location( $action );
Koha/Item.pm:sub update_item_location {
t/db_dependent/Koha/Item.t:subtest 'update_item_location() tests' => sub {
t/db_dependent/Koha/Item.t:        $item->update_item_location($action);
t/db_dependent/Koha/Item.t:        $item->update_item_location($action);
t/db_dependent/Koha/Item.t:        $item->update_item_location($action);
t/db_dependent/Koha/Item.t:        $item->update_item_location($action);
t/db_dependent/Koha/Item.t:        $item->update_item_location($action);

2. After applying the patch, run again - there should be no results.

3. Test updating the shelving location on check in:
   3.1 Update the UpdateItemLocationOnCheckin system preference and add: _ALL_:
FIC
   3.2 Check in an item (doesn't need to be checked out) - message should be
similar to:
     39999000011418: Programming Perl /
     Not checked out.
     Item shelving location updated.
     Old value: General stacks
     New value: Fiction
   3.3 Confirm that the shelving location was updated to Fiction.

4. Test updating the shelving location on check out:
   4.1 Update the UpdateItemLocationOnCheckout system preference and add: 
_ALL_: FIC
   4.2 Check out an item to a patron.
   4.3 Confirm that the shelving location was changed to Fiction.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.