[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032

--- Comment #15 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Katrin Fischer from comment #14)
> (In reply to Emmi Takkinen from comment #13)
> > We don't probably have to do anything to past dates, since they aren't
> > displayed at all. If I set reserves.expirationdate in past (or current date)
> > through database, expiration date field is blank. Is this intentional?
> 
> Hm, I have been wondering what we show in the GUI but didn't check.
> 
> It might all be a bit 'history' there. In the past there was only one field
> in the database used for both the "don't need after x" and "pick-up before".
> That lead to a couple of issues.
> 
> Later we divided the fields in the database (yay!), but maybe we don't show
> both in the GUI?

Technically we don't show them both, we show value in reserves.expirationdate.
But if reserves.patron_expiration_date is filled, it is copied to
reserves.expirationdate (not only with these patches but by default). But this
doesn't seem to be the problem here. In GUI it seems that expiration field
doesn't display date in past, including if value is current date. They are in
database however. There's probably some sort of jQuery (flatpicker maybe)
affecting this. I was wondering should we should also show dates in past and
display them with visual hind or does the field behave this way on purpose? I
was also wondering if we "fix" this, should it be done in another bug?

-- 
You are receiving this mail because:
You are watching all bug changes.