[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216

Brendan Lawlor <blawlor at clamsnet.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |blawlor at clamsnet.org

--- Comment #4 from Brendan Lawlor <blawlor at clamsnet.org> ---
I tried testing this out and verified the variable name changes look
consistent.

I tested checking out and checking in items, which mostly worked but if I tried
to checkout a barcode that was already checked out I got this error with line
395 highlighted:

Can't use string ("RENEW_ISSUE") as a HASH ref while "strict refs" in use at
/kohadevbox/koha/circ/circulation.pl line 395
in (eval) at /kohadevbox/koha/circ/circulation.pl line 395
  392: 
  393:             # pass needsconfirmation to template if issuing is possible
and user hasn't yet confirmed.
  394:             foreach my $needsconfirmation ( keys %$needsconfirmation ) {
  395:                 $template_params->{$needsconfirmation} =
$$needsconfirmation{$needsconfirmation};
  396:                 $template_params->{getTitleMessageIteminfo} =
$biblio->title;
  397:                 $template_params->{getBarcodeMessageIteminfo} =
$item->barcode;
  398:                 $template_params->{NEEDSCONFIRMATION} = 1;

Also got this error once but I can't remember how:
Can't use string ("issued_cardnumber") as a HASH ref while "strict refs" in use
at /kohadevbox/koha/circ/circulation.pl line 395
in (eval) at /kohadevbox/koha/circ/circulation.pl line 395
  392: 
  393:             # pass needsconfirmation to template if issuing is possible
and user hasn't yet confirmed.
  394:             foreach my $needsconfirmation ( keys %$needsconfirmation ) {
  395:                 $template_params->{$needsconfirmation} =
$$needsconfirmation{$needsconfirmation};
  396:                 $template_params->{getTitleMessageIteminfo} =
$biblio->title;
  397:                 $template_params->{getBarcodeMessageIteminfo} =
$item->barcode;
  398:                 $template_params->{NEEDSCONFIRMATION} = 1;

-- 
You are receiving this mail because:
You are watching all bug changes.