[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
That's fantastic testing David, thankyou!

I must admit, I was coding a little blind. As you've highlighted here, we were
already displaying "most" notices correctly, it was only certain constructs
that looked odd, but narrowing down which one's wasn't clear to me (you've
proved that <p> without <br> was one case and I'm sure there are some others
where this patch will help too).

As for NoticeCSS, thanks for confirming my suspicions there too.. I wanted to
make sure we covered it in the preview, but I am aware that using linked css
sheets in emails is 'variable at best'.. I'm keen to keep working through the
notices code and add options for embedding css at the top of the email as
aposed to adding a linked sheet.

Finally.. I'll take a look at the tests.. I wonder if there's a rebase issue
crept in, they were working when I tested before uploading.

-- 
You are receiving this mail because:
You are watching all bug changes.