[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl

Sat Nov 11 20:36:06 CET 2023

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes the display of n
      release notes|                            |
             Status|Needs Signoff               |Failed QA

--- Comment #27 from David Nind <david at davidnind.com> ---
Hi Martin.

It wouldn't hurt adding something like a little alert in the Modal when
NoticeCSS is detected that the content may not display correctly in all email
clients. But as you say, this should be a separate bug.

Alternatively or in addition, we could add a note to the NoticeCSS
documentation about this. I'm assuming that it works fine for printed notices,
and it doesn't always work with emails is because of the vagaries of HTML email
and different email clients.

Tests are still failing for me:

kohadev-koha at kohadevbox:koha(bz30287)$ prove
t/db_dependent/Koha/Notice/Message.t
t/db_dependent/Koha/Notice/Message.t .. 
    #   Failed test 'html_content returned the correct html wrapped letter'
    #   at t/db_dependent/Koha/Notice/Message.t line 92.
    #          got: '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0
Transitional//EN"
    #     "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
    # <html lang="en" xml:lang="en" xmlns="http://www.w3.org/1999/xhtml">
    #   <head>
    #     <title>uLrVEOWv9</title>
    #     <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
    #     
    #   </head>
    #   <body>
    #   This is a test template using borrower 55
    #   </body>
    # </html>
    # '
    #     expected: '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0
Transitional//EN"
    #     "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
    # <html lang="en" xml:lang="en" xmlns="http://www.w3.org/1999/xhtml">
    #   <head>
    #     <title>uLrVEOWv9</title>
    #     <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
    # 
    #   </head>
    #   <body>
    #   This is a test template using borrower 55
    #   </body>
    # </html>
    # '
    # Looks like you failed 1 test of 2.
t/db_dependent/Koha/Notice/Message.t .. 1/1 
#   Failed test 'html_content() tests'
#   at t/db_dependent/Koha/Notice/Message.t line 118.
# Looks like you failed 1 test of 1.
t/db_dependent/Koha/Notice/Message.t .. Dubious, test returned 1 (wstat 256,
0x100)
Failed 1/1 subtests 

Test Summary Report
-------------------
t/db_dependent/Koha/Notice/Message.t (Wstat: 256 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=1, Tests=1,  1 wallclock secs ( 0.01 usr  0.01 sys +  0.89 cusr  0.18
csys =  1.09 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.