[Koha-bugs] [Bug 35193] Rename "Message subject" to "File name" when module "Reports" was chosen

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Pedro Amorim from comment #16)
> (In reply to Pedro Amorim from comment #7)
> > Bug 34136 states that the template needs to be added to the "Print" area,
> > but testing this, this patch is also changing for the "E-mail" and "SMS"
> > areas, it seems unintended.
> 
> I'm ready to SO but can we confirm if the above is intended? It seems off
> that a "E-mail" or "SMS" section would be labeled as "File name" instead of
> "Message subject"
> 
> I can sort of see it making sense for "Print" as we're downloading the
> "Print" render of the notice template, and I haven't thought about this long
> enough, but wouldn't a new distinct "File" section be more appropriate for
> this?

The intention of the feature is to only use the "print" transport. I've added a
followup so that only the print transport shows up for report notice templates.
I think that solves the issue nicely! If you sign it, we can use Katrin's
sign-off as the QA signoff at her discretion.

-- 
You are receiving this mail because:
You are watching all bug changes.