[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216

--- Comment #7 from Brendan Lawlor <blawlor at clamsnet.org> ---
Hi David, 

I am having trouble going through the process with git bz and now am afraid I
could be doing something wrong. I reset the Koha clone, deleted the local
branch I was testing on and tried again. 

git reset --hard origin/master
git checkout -b bug_35216

ktd up

ktd --shell

git bz apply 35216

This time I got a merge conflict in circ/circulation.pl. I'm using VS Code and
I went through and accepted the incoming changes and checked to make sure the
code looked right.

Then when I tested again, if I checked out an item that was already checked
out, I got the error that I got the first time:

Can't use string ("RENEW_ISSUE") as a HASH ref while "strict refs" in use at
/kohadevbox/koha/circ/circulation.pl line 419
in (eval) at /kohadevbox/koha/circ/circulation.pl line 419
  416: 
  417:             # pass needsconfirmation to template if issuing is possible
and user hasn't yet confirmed.
  418:             foreach my $needsconfirmation ( keys %$needsconfirmation ) {
  419:                 $template_params->{$needsconfirmation} =
$$needsconfirmation{$needsconfirmation};
  420:                 $template_params->{getTitleMessageIteminfo} =
$biblio->title;
  421:                 $template_params->{getBarcodeMessageIteminfo} =
$item->barcode;
  422:                 $template_params->{NEEDSCONFIRMATION} = 1;

-- 
You are receiving this mail because:
You are watching all bug changes.