[Koha-bugs] [Bug 35310] Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310

--- Comment #8 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
(In reply to Victor Grousset/tuxayo from comment #7)
> > 6) Repeat 1) to 3). Notice it shows 2 current renewals even tho only 1 corresponds to the currently active check out
> 
> When clicking on "View" I see «Note: 1 out of 2 renewals have been logged».
> What is the function of this?
> Is that code in checkout_renewals_modal.js still relevant? I'm not sure
> after the patch we can still get that message.

Great observation. I'm not sure. Original work written 4 years ago (not the
pushed patch) where the string was introduced is:
https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23838&attachment=137167

Note that when the work was originally done, readingrec.tt was tracking issues
(which I believe is all the checkouts of an item), but after this:
https://github.com/PTFS-Europe/koha/commit/7fd26e0#diff-ff6b8814c72c6c6b8a9e53514a409d2dba8ce865849b8c1957a24e42cef90aeaR111
It's now tracking checkouts instead . I know this is a different file from the
one in my patch but I think it helps explain the history behind this as the
renewal modal functionality is similar in both moredetail.tt and readingrec.tt

I think the original string "Note: X out of Y renewals have been logged" was a
way to let the user now that only X amount of renewals corresponded to the
current checkout, out of a Y total, if that is the case then it's not needed
anymore. But I'm not 100%, this is confusing.

Additional testing to the previous test plans could also be done by visiting
the readingrec page to make sure everything is ok:
/cgi-bin/koha/members/readingrec.pl?cardnumber=42

-- 
You are receiving this mail because:
You are watching all bug changes.