[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331

--- Comment #5 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
(In reply to David Nind from comment #3)
> Everything works for me, except running the tests - which fail 8-(...
> 
> kohadev-koha at kohadevbox:koha(bz35331)$ prove
> t/db_dependent/Koha/Plugins/Ill_hooks.t
> t/db_dependent/Koha/Plugins/Ill_hooks.t .. 1/4 
>     #   Failed test 'get_staff_table_actions() should return core action
> plus a custom plugin actions'
>     #   at t/db_dependent/Koha/Plugins/Ill_hooks.t line 52.
>     #     Structures begin differing at:
>     #          $got->[1]{button_class} = 'btn btn-default btn-sm'
>     #     $expected->[1]{button_class} = 'test class'
>     # Looks like you failed 1 test of 1.
> t/db_dependent/Koha/Plugins/Ill_hooks.t .. 4/4 
> #   Failed test 'ill_table_actions hook'
> #   at t/db_dependent/Koha/Plugins/Ill_hooks.t line 73.
> # Looks like you failed 1 test of 4.
> t/db_dependent/Koha/Plugins/Ill_hooks.t .. Dubious, test returned 1 (wstat
> 256, 0x100)
> Failed 1/4 subtests 
> 
> Test Summary Report
> -------------------
> t/db_dependent/Koha/Plugins/Ill_hooks.t (Wstat: 256 Tests: 4 Failed: 1)
>   Failed test:  4
>   Non-zero exit status: 1
> Files=1, Tests=4,  2 wallclock secs ( 0.02 usr  0.00 sys +  0.93 cusr  0.14
> csys =  1.09 CPU)
> Result: FAIL

Thank you so much for testing, David!

I believe the tests may be failing for you because you have the plugin
installed.
They pass for me without having the plugin installed, as I believe that will be
the case for CI/CD.
Having said that, I'm not certain this is what's expected, i.e. a particular
hook test fails if a plugin implementing it is installed. As this is my first
time writing a hook test, there is a chance the tests need to/could be
improved!

-- 
You are receiving this mail because:
You are watching all bug changes.