[Koha-bugs] [Bug 34018] Patron image upload fails without cardnumber

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34018

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #1)
> I suppose there are some minor changes that could be made that could get it
> over the line...

Actually, I don't think so. I don't know what I was thinking back in June when
I wrote this comment.

While http://localhost:8081/cgi-bin/koha/members/moremember.pl does pass a
borrowernumber, the handle_dir and handle_file functions are hard-coded to only
accept cardnumber. 

Any change to just use borrowernumber would need to be tested, but then
./tools/picture-upload.pl isn't currently unit tested.

But to unit test it you'd need to rewrite ./tools/picture-upload.pl, so it's
just going to be too much work for too little gain.

The workaround here is to just use a temporary dummy cardnumber for a patron
when uploading a patron image.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.