[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216

--- Comment #14 from Brendan Lawlor <blawlor at clamsnet.org> ---
I tried testing this again, but when I tested circ, searching for a patron
raised errors that $error and $question were undefined.

Could not compile /kohadevbox/koha/circ/circulation.pl: Global symbol "$error"
requires explicit package name (did you forget to declare "my $error"?) at
/kohadevbox/koha/circ/circulation.pl line 391.
Global symbol "$error" requires explicit package name (did you forget to
declare "my $error"?) at /kohadevbox/koha/circ/circulation.pl line 392.
Global symbol "$question" requires explicit package name (did you forget to
declare "my $question"?) at /kohadevbox/koha/circ/circulation.pl line 427.
Global symbol "$question" requires explicit package name (did you forget to
declare "my $question"?) at /kohadevbox/koha/circ/circulation.pl line 448.
BEGIN not safe after errors--compilation aborted at
/kohadevbox/koha/circ/circulation.pl line 714.
 at /usr/share/perl5/CGI/Compile.pm line 144

I looked at the code for those lines and replaced a couple more instances of
$error with $issuingimpossible and $question with $needsconfirmation. That
resolved the error, and I could look up a patron and checkout items.

But if I checked out an item that was already checked out I got the same error
when testing the first patch:
Can't use string ("RENEW_ISSUE") as a HASH ref while "strict refs" in use at
/kohadevbox/koha/circ/circulation.pl line 420

-- 
You are receiving this mail because:
You are watching all bug changes.