[Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I think that we are not going in the right direction here with the hidden
backup inputs. We are trying to solve a flatpickr issue here. We should do that
differently.

Seeing several related bugs in the smart rules. Just listing a few:

[1] This is incorrect. The i is the column starting from 0. 
                        } else if ( i == 5 || i == 6 || i == 27 || i == 28 || i
== 29 || current_input_id === "holds_pickup_period" ) {
                            // If the value is not an integer for
                            //     - "Current checkouts allowed"
                            //     - "Current on-site checkouts allowed"
                            //     - "Holds allowed (total)"
                            //     - "Holds allowed (daily)"
                            //     - "Holds per record (count)"
                            //     - "Holds pickup period (day)"
                            // The value is "Unlimited" (or an equivalent
translated string)
                            // an it should be set to an empty string
Current checkouts allowed should be 4?
Because 6 is listed, it is now cleared. (Loan period should allow a zero?)

[2] There is a check on overwriting the edit rule. But shouldnt there be a
check too about warning to overwrite a current rule when saving a blank rule ?
Out of scope.

[3] Flatpickr fields should be cleared in edit rule when saving/submitting.

[4] If you do not click in the flatpickr field, the date is not saved! (This is
in my test patch.) The input is still empty. We should trigger flatpickr to
fill it before.

Will submit a test patch which is not finished but gives an idea of the
solution that I am thinking of.

-- 
You are receiving this mail because:
You are watching all bug changes.