[Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Nov 17 15:41:40 CET 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136213|0                           |1
        is obsolete|                            |
 Attachment #136214|0                           |1
        is obsolete|                            |
 Attachment #136263|0                           |1
        is obsolete|                            |
 Attachment #139978|0                           |1
        is obsolete|                            |
 Attachment #145920|0                           |1
        is obsolete|                            |
 Attachment #147497|0                           |1
        is obsolete|                            |

--- Comment #35 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 159088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159088&action=edit
Bug 18064: Add syspref to launch longOverdue script with calendar support

The problem here is that the longOverdue script does not support calendars
and when libraries set their holidays, long overdues do not take this into
account.
For example, during the covid pandemic, some libraries were closed for days,
maybe months,
but longOverdue didn't care and set "lost" or other values on the items.

This fix / enhancement based on taking calendars into account to test it,
regardless of your
rules related to longOverdue, I propose this test plan:

Test plan :

1) For clearer vision on what the patch does, have at least "2" libraries
2) Go to Tools/Calendar and place holidays, on each of the libraries for
example, of any kind (special, repeated, as you want)
3) Manually run the misc/cronjobs/longoverdue.pl script with the -v (verbose)
argument to get as much information as possible
4) You will see a common "block", with today's date + 366 days (by default if
you don't pass any arguments to the script),
holidays are not taken into account in this date range
5) Apply my patch
6) Launch the updatedatabase
7) Set the new system preference "LongOverdueNoticeCalendar" to "use calendar"
8) Repeat step 3
9) You will see in output one line per library and according to the number of
days off in the interval of dates,
the start date of the analysis will have been postponed by as many days in
order to take these holidays into account.

If something is not completely clear, we can of course discuss it

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list