[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #69 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> ---
Thanks for the fixes!

I added a follow-up with a couple of trivial fixes to the alerts. :)

The notice is sent twice when reverting or cancelling an item-level hold from
the prompt (sorry for missing that the last time I tested). Is there a reason
LostItem needs to be called a second time when the user responds to the prompt
of whether to revert or cancel an item-level hold? Couldn't the prompt
cancel/revert the hold directly at that point, and avoid re-doing all the lost
item processing (including the second notice)?

Also, tests are failing:
# Subtest: Waiting item is marked as lost
    1..17
    ok 1 - Biblio-level hold placed
not ok 70 - Waiting item is marked as lost
    # Looks like you planned 17 tests but ran 1.

#   Failed test 'Waiting item is marked as lost'
#   at t/db_dependent/Reserves.t line 1546.
Can't call method "effective_itemtype" on an undefined value at
/kohadevbox/koha/Koha/Hold.pm line 234.
# Looks like your test exited with 11 just after 70.
Dubious, test returned 11 (wstat 2816, 0xb00)
Failed 9/78 subtests

-- 
You are receiving this mail because:
You are watching all bug changes.