[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #49 from David Nind <david at davidnind.com> ---
I've tested and signed off. But feel free to change back to "Needs signoff" if
this isn't sufficient.

(I'm always nervous about testing circulation and fine rules - "Here be
dragons".)

Testing notes using KTD:

1. Set the "All All" rule as follows:
   - Unit: change from Days to Hours
   - Suspension in days (day): change from blank to 2
   - Max. suspension duration (day): left blank
   - Suspension charging interval: 1

2. Items checked out on 20 November 2023.

3. Results before the patch was applied (I set the due date for an item to
11/09/2023). When checked in, the message says:
   "[Patron name] is now debarred until 06/05/2055."

4. After the patch was applied, the message on check in says: "[Patron name] is
now debarred until 12/10/2023."
   - Matches what was expected: difference between due date and checked in date
= 10; x2 = 20 days = 12/10/2023

5. I then set "Suspension in days (day)" to 1. The message on check in says:
"[Patron name] is now debarred until 11/30/2023."
   - Matches what was expected: difference between due date and checked in date
= 10; x1 = 10 days = 11/30/2023

6. The tests pass: prove t/db_dependent/Circulation/maxsuspensiondays.t

-- 
You are receiving this mail because:
You are watching all bug changes.