[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972

--- Comment #2 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> ---
Also making a note for later:

GetOtherReserves should probably be removed entirely. Once the bad code is
removed, it's basically just a wrapper for CheckReserves that returns a trivial
additional message. It's also only called in two places, and has almost no test
coverage.

ModReserveMinusPriority (which is called by GetOtherReserves and is the actual
culprit here) should also be removed. It also has almost no test coverage, only
has one remaining reference outside of GetOtherReserves, and is currently
redundant and unnecessary in that place also.

Will make follow-up bugs for those after I upload patches for this one.

-- 
You are receiving this mail because:
You are watching all bug changes.